Tuesday, 2015-04-07

*** puck has joined #openstack-neutron00:01
*** sridhar_ram has joined #openstack-neutron00:01
*** sridhar_ram1 has quit IRC00:03
*** mlavalle has quit IRC00:06
*** rangansw has quit IRC00:06
*** yamamoto has joined #openstack-neutron00:08
*** vivek-ebay has quit IRC00:10
*** Marga_ has joined #openstack-neutron00:14
*** achanda has joined #openstack-neutron00:15
*** emagana has quit IRC00:16
*** julim has joined #openstack-neutron00:17
kevinbentondane_leblanc: i need to think about this more. the db-access lock still seems like a big hammer00:17
*** rook__ has joined #openstack-neutron00:19
dane_leblanckevinbenton: If there's a rational explanation for why the first fix works, I think everyon would prefer that approach.00:20
*** achanda has quit IRC00:20
kevinbentondane_leblanc: right, i haven't found anything obvious yet.00:20
kevinbentondane_leblanc: calling get_sesion alone does not trigger a yield00:20
dane_leblanckevinbenton: Right, it's the query that yields00:21
kevinbentondane_leblanc: not even that yields in my testing00:22
*** zzzeek has quit IRC00:22
dane_leblanckevinbenton: Let me know, I can go back to the Patch #2 version, which doesn't have the other collateral changes made for consistency.00:25
*** ociuhandu has quit IRC00:28
*** xgerman has quit IRC00:30
*** shaohe_feng has joined #openstack-neutron00:30
*** shaohe_feng1 has joined #openstack-neutron00:32
*** dboik_ has joined #openstack-neutron00:32
*** shaohe_feng has quit IRC00:35
*** signed8bit_ZZZzz is now known as signed8bit00:35
*** banix has quit IRC00:35
*** banix has joined #openstack-neutron00:37
*** banix has quit IRC00:41
*** rook__ has quit IRC00:42
*** yamamoto has quit IRC00:42
*** yamamoto has joined #openstack-neutron00:43
openstackgerritMaru Newby proposed openstack/neutron: Reorganize plugin test modules  https://review.openstack.org/17100500:43
*** yamamoto has quit IRC00:43
*** seizadi has joined #openstack-neutron00:50
*** markvoelker has joined #openstack-neutron00:50
*** shwetaap has joined #openstack-neutron00:51
marunkevinbenton, HenryG, mestery: plz push!  https://review.openstack.org/#/c/158811/00:53
kevinbentonmarun: done!00:54
marunkevinbenton: danke!00:55
* marun sacrifices small animals to the merge conflict gods00:55
*** markvoelker has quit IRC00:55
openstackgerritMaru Newby proposed openstack/neutron: Reorganize plugin test modules  https://review.openstack.org/17100500:55
*** vivek-ebay has joined #openstack-neutron00:57
*** tiswanso has joined #openstack-neutron00:57
*** SumitNaiksatam has joined #openstack-neutron00:58
dougwigmarun, kevinbenton - did we clear the aas repo unit tests?00:58
kevinbentondougwig: won't they have to break one way or another?00:59
kevinbentondougwig: we'll just need to quick-merge fixes00:59
marundougwig: https://review.openstack.org/#/c/170983/00:59
marundougwig: apologies, I forgot that it had gone to merge conflict01:00
dougwigkevinbenton: heh, it'd be quicker if the fixes were ready.  :)01:00
marundougwig: given how long our gate takes, you have over an hour. your change is test-only at least.01:01
dougwigmarun: ahh, thanks.  i'll update brandon's fix.01:01
marundougwig: do you know if you depend on any plugin test code? there are some follow-on patches that clean that up too.01:01
*** sripriya has quit IRC01:01
*** ijw has quit IRC01:02
dougwigsince our tests were mostly grafted over, i'm not sure. we will know soon.  :001:02
marundougwig: not the base db plugin, the ml2, ovs and lb-specific test code01:02
dougwigmarun: i wouldn't think so.01:02
* marun crosses his fingers01:03
*** banix has joined #openstack-neutron01:05
amullermarun: A lot of people are going to hate you in the upcoming week or two, then forget about it01:06
amullerMyself included01:06
*** annegentle has joined #openstack-neutron01:06
marunamuller: lots of hate to go round :)01:06
amullermarun: <301:07
marunamuller: luckily, people are mostly software ;001:08
marun;)01:08
*** hichihara has quit IRC01:08
*** krtaylor has quit IRC01:10
*** seizadi has quit IRC01:10
*** lazy_prince has quit IRC01:11
*** gildub has joined #openstack-neutron01:12
*** sridhar_ram has quit IRC01:13
*** seizadi has joined #openstack-neutron01:14
*** _cjones_ has quit IRC01:14
*** shwetaap1 has joined #openstack-neutron01:14
*** vishwanathj has joined #openstack-neutron01:14
*** sridhar_ram has joined #openstack-neutron01:15
*** yamamoto has joined #openstack-neutron01:15
*** seizadi has quit IRC01:16
*** shwetaap has quit IRC01:17
dougwigmarun: and by hate, we really mean... hate.01:18
mesterylol01:18
marundougwig: heh01:18
mesteryI'm going to give marun a special medal in Vancouver01:18
mestery:)01:18
dougwigi think we all owe him a beer for taking on such a thankless task.01:18
marunI think we all deserve many beers :D01:19
mesteryMOAR BEERS!01:19
dougwigmany beers... that might be an openstack proposal that achieves consensus without 100 emails.01:19
marunhmmmm01:19
maruna worthy experiment!01:19
*** tiswanso has quit IRC01:19
marunI have a theory about our difficulty in finding consensus, actually.01:20
*** tiswanso has joined #openstack-neutron01:20
marunSome folks - including russellb - have suggested that it's a problem that we have to meet so often.01:20
lifeless800 people01:20
mesteryin person you mean?01:20
lifelessconsensus is hard ;)01:20
marunyeah01:20
marunI think it's a lack of shared vision01:21
mesteryI agree01:21
mesteryThere's something else too01:21
lifelessmarun: I agree01:21
mesteryIt's the fact Neutron is still conflated as an API/DB layer AND an SDN controller01:21
mesteryThat doesn't help01:21
marunWe're all going in different directions, so it's pretty hard to agree on what we want to do when we don't have any shared goals.01:21
marunmestery: agreed01:21
dougwigi agree.  my first reaction was, "what vision?"01:21
marunNot just Neutron, though.01:21
dougwigi apply it openstack-wide.01:21
mesteryLets just rearrange the deck chairs a bit!01:21
mesteryThat'll surely help! :)01:22
dougwigbut hey, if we add enough release tags, we can build a vision banner with them.01:22
marunSo, where are we going to get shared vision?01:22
marunheh01:22
marunvision banner!01:22
mesteryWe'll get shared vision by narrowing the focus enough so it's easier01:22
*** annegentle has quit IRC01:22
marunthat's necessary, but I don't think it's sufficient01:22
marunI don't think we can substitute anything for vision.  We need...vision01:22
mesteryI didn't say it was the only thing we'll need01:23
marunWe need...leadership01:23
mesteryOh no01:23
dougwigwell, we have no linus, and the TC won't do it. so it becomes a million visions based on monied interests.01:23
marunleadership, not management01:23
marunShowing us where to go (results), not necessarily how to get there (process)01:23
marunWhy won't the TC do it?01:23
marunWho else can, honestly?01:23
mesteryThey don't want to do it near as I can tell01:23
mesterySee: The Big Tent01:24
marunWe can do good things at the project level, but that won't save openstack from itself.01:24
dougwigwouldn't it have happened by now?  isn't the big tent the opposite direction?01:24
mesteryRight01:24
mesterymarun for TC!01:24
marun:(01:24
mestery#voteformarun01:24
dougwigneutron tests and now the tc.  poor marun.  :)01:24
marunWhy doesn't the TC want to do it though?01:24
mesteryIt's hard01:24
mesteryThat's why they got out of saying no to projects01:24
gusand unpopular.01:24
marunIt's the only thing worth doing, though.01:24
mesteryand we have hte big tent01:24
mesterygus: Right01:24
*** annegentle has joined #openstack-neutron01:24
mesteryBut it's needed01:25
marungus: leadership/vision -> unpopular?01:25
mesteryThe Open Washing that OpenStack will see over the next year is going to be awful01:25
*** britthouser has quit IRC01:25
*** wanghong has joined #openstack-neutron01:26
dougwigi think we're going to see openstack fragment, with the distro maintainers using the big tent to differentiate themselves. but hey, at least people won't have vendor lock-in.  oh, wait.01:26
marunmestery: I'm not sure I care about openwashing, to be honest.  I do care about developers having enough direction to coordinate their efforts effectively.01:26
*** britthouser has joined #openstack-neutron01:27
gusmarun: It's largely a democract selection process.  The candidates that survive that process are most likely to be the ones that offend the least people.01:27
marunmestery: I don't know that the big tent changes that problem at all.01:27
mesterymarun: Not only will the products be open washed, the developers will as well.01:27
mesterygus: Democracy at it's finest?01:27
openstackgerritDane LeBlanc proposed openstack/neutron: Synchronize auto-addr updates for subnet create  https://review.openstack.org/17096801:27
*** DD_ has joined #openstack-neutron01:27
marungus: That doesn't say much about the people currently on the TC. :/01:28
mesterymarun: I think you're underestimating the negative effect Open Washing will have on OpenStack, but it's not the only problem going forward, you're right.01:28
mesterymarun: I think a bigger problem is relevance, medium to long term.01:28
gusmestery: right.  Democracy has plenty of good and bad properties - (in)efficiency and tendency to the middle are seem like downsides relevant to this discussion.01:28
dougwigwell, it all goes back to marun's initial point, which i agree with.  there is effectively no unifying leadership/vision/end goal.01:28
*** annegentle has quit IRC01:29
mesterymarun: Is OpenStack losing it's buzz? Will we all be made irrelevant due to the latest hotness, containers? Do you even care about IaaS layer with containers? Who knows.01:29
marungus: I guess I don't understand why pandering to the middle needs to happen to a technical project.01:29
mesterydougwig marun: The project is too big for a shared goal across all of it.01:29
dougwighow many years, and not a single person has been able to say that the nova-net (consumer cloud) versus neutron (amazon vpc) models are the most beneficial for openstack's future/operators/customers?01:30
marungus: real democracy has the problem of corruption, and I don't think that's manifesting here.01:30
*** annegent_ has joined #openstack-neutron01:30
gusmarun: because people aren't mostly software ;)01:30
*** Longgeek has joined #openstack-neutron01:30
marungus: maybe I'm just mostly software :(01:30
marunmestery: I'm not sure that has to be true.01:30
marunmestery: there are larger software development efforts.  see: google01:30
marunmicrosoft01:30
lifelessThe TC is setup as a chokepoint, not as a lead point01:31
marunooh, maybe not a good example01:31
mesterylol01:31
gusjust saying that negative responses tend to outweigh positive ones, so the approach that introduces the least resistance wins out over one that introduces the most positives.01:31
gussee for example the difficulties removing dead code vs just leaving it in.01:31
marunwhat's the tenure of a tc member?01:31
*** igordcard_ has quit IRC01:31
dougwig1 year01:31
marunso we should all run and tear s*** up for a year01:31
lifelesswell01:32
marunset a good example for those to come01:32
lifelessI think that setting a shared vision01:32
marunlifeless: or is that simply not the charter?01:32
lifelessis something that can and should happen outside of the tc01:32
marunlifeless: by who?01:32
marunlifeless: nobody else seems to have the necessary authority at the technical level01:32
lifelesssee thats the wrong word01:32
lifelessthis isn't a matter of authority01:32
maruninfluence?01:32
mesteryHeh, we can't even do things at a project level without everyone getting involved01:32
marunI think you know what I mean01:33
lifelessright01:33
*** xgerman has joined #openstack-neutron01:33
lifelessI'm working up to something along those lines at the moment01:33
lifelessgathering data and thoughts right now01:33
dougwigwe can't even agree on how to set a shared vision. :)01:33
lifelessthe TC is chartered as handling exception which individual projects fail to agree on, and setting *only when needed* project wide rules01:34
marunlifeless: I don't think that charter matches what I've seen, but I'll hold my tongue.01:34
*** killer_prince has joined #openstack-neutron01:34
*** killer_prince is now known as lazy_prince01:34
marunlifeless: So, assuming you come up with a compelling vision, how do you propose to have it evolve over time?01:34
marunlifeless: and how to take it down to the project level?01:35
lifelesswell01:35
lifelesshttps://www.openstack.org/foundation/tech-committee/01:35
lifelessit does say technical leadership01:35
lifelessbut there is this whole cultural 'projects make their own decisions' thing01:35
dougwigit's only specific power (4.13.b) is to determine what is openstack.  which it's abdicated.01:35
lifelesswhich the big tent debate and discussion has entrenched further AFAICT01:35
marunlifeless: which, to some degree, I think I agree with.01:35
marunlifeless: projects are necessarily going to have their own cultures01:35
marunlifeless: I don't think that precludes collaboration, though01:36
lifelessmarun: conways law bites us pretty hard01:36
marunlifeless: I hear that a lot, and I don't think it's an entirely valid criticism01:36
dougwigfor anyone else that needed to google: "organizations which design systems ... are constrained to produce designs which are copies of the communication structures of these organizations"01:36
lifelessmarun: ok. let me try a different way of describing the specific issue I see01:36
marunlifeless: We don't expect all people in a project to communicate with all others01:36
*** xgerman has quit IRC01:36
*** xgerman has joined #openstack-neutron01:36
marunlifeless: But we do need an incentive for that coordination to happen between key people01:37
*** stanzgy has joined #openstack-neutron01:37
marunlifeless: the incentive doesn't really exist without shared vision, though.01:37
lifelessmarun: our solution so far to scaling development is to create new teams01:37
marun(I'm talking cross-project communication)01:37
*** xgerman has quit IRC01:37
marunlifeless: and that doesn't scale, agreed01:37
marunlifeless: direct trust doesn't scale01:37
*** xgerman has joined #openstack-neutron01:37
marunlifeless: we need to start relying on trust delegation01:38
lifelessand we make new projects and code bases when we make new teams01:38
marunlifeless: then we can maintain organization along functional rather than 'we can't manage via direct trust - split!'01:38
marunlines01:38
dougwigmarun: but you've wandered away from the point that with more delegation, you need even *more* higher-level vision in place for people to align around.01:38
marundougwig: I don't think so01:39
*** annegent_ has quit IRC01:39
marundougwig: but I'm an optimist, admittedly :)01:39
lifelesstechnically there's very little reason to have nova, cinder and neutron be different codebases.01:39
dougwignote that *more* in this case would mean *any*, but i digress.01:39
*** xgerman has quit IRC01:39
*** hichihara has joined #openstack-neutron01:39
*** sluo_wfh has joined #openstack-neutron01:39
*** xgerman has joined #openstack-neutron01:39
marunlifeless: I'm not entirely sure about that01:39
*** sluo_wfh has quit IRC01:40
marunlifeless: I'm caught between wanting to drink the amazon 2-pizza team meme01:40
lifelessmarun: so, google have a similar thing AIUI01:40
marunlifeless: and recognizing the cost of coordination we're seeing when we split things up01:40
lifelesslots of small teams01:40
lifelessone code base01:40
*** erkules_ has joined #openstack-neutron01:40
lifelesshermetic releases01:41
*** s3wong has quit IRC01:41
*** nlahouti has quit IRC01:42
lifelessconways law bites us in the following way: our product is not 'openstack', its 'combine these separate projects into a release'; each project has latency on change; changes that involve many projects then pay that latency per project, effectively in serial01:42
*** erkules has quit IRC01:43
lifelessto fix a bug that exists in the interaction between nova and neutron01:43
lifelessyou need two specs with two different mostly distinct groups to sign off on it01:44
lifelessand then you need to do the work01:44
lifelessand you need to maintain compat in both directions to work with older neutron new nova and the reverse01:44
marunlifeless: it seems all but impossible  :/01:44
*** dane_leblanc has quit IRC01:44
lifelessthis is a self inflicted problem01:44
marunlifeless: Beyond the vision thing, I think the integrated gate is another key contributor to our current state.01:45
marunlifeless: it's allowed nova and neutron to grow together in entirely undocumented ways.01:45
lifelessso for the vision thing, there's several lyers. There's a product vision01:45
lifelessand theres a technical how its built vision01:45
marunIsn't the product vision foundational?01:45
lifelessand there's the social how we play together and collaborate thing01:45
marunI mean, if we're not focused on a result like 'deliver software', what value does any other vision bring?01:46
*** krtaylor has joined #openstack-neutron01:46
lifelesswell01:46
lifelesswe've built a social structure where lots of orgs feel comfortable working upstream01:46
lifelessbut I'm very sure they'll all give different answers about what the product means to them01:47
marunI think without a shared product vision, we're done.01:47
lifelessis it the basis for a product of their own? Something they sell add-ons for? ...01:47
marunI don't care that it means different things to different companies.01:47
marunIf we can't agree on what's important upstream in the large, what's the point?:01:48
lifelessI'd say we have a product vision for that much01:48
marunI'm not sure we do01:48
dougwiglifeless: where is it?  what is it?01:48
*** vivek-ebay has quit IRC01:48
*** suresh12 has joined #openstack-neutron01:48
*** sripriya has joined #openstack-neutron01:48
*** baoli has joined #openstack-neutron01:48
gusmarun: what might a vision statement look like?  If it's too vague ("make some software, maybe") then it isn't very useful, and if it's too specific ("implement exactly this") then it isn't long-lasting, or adaptive.01:49
marungus: like anything, a vision needs to evolve01:49
gusperhaps this is why many free software projects (start by) copying/reimplementing something else - "make whatever $they're making" is probably quite an effective vision statement.01:50
lifelessdougwig: I'm not sure. I meant more in the sense of shared context, not a written document.01:50
marunlifeless: I don't think it exists, really.01:50
lifelessok, so we should write one down01:50
gus(as in: "make an aws clone" might not be such a terrible directive)01:50
marunlifeless: If it did, most projects wouldn't feel so comfortable ignoring user experience and quality in general.01:50
lifelessmarun: hahahahahahaha. no, thats totally different :)01:50
marunlifeless: I don't think it is, frankly.01:51
dougwiggus: there has to be a middle line between "build some software" and "make an AngryBirdsAsAService clone".01:51
*** markvoelker has joined #openstack-neutron01:51
marungus: except we're not exactly building for public cloud anymore01:51
dougwiglifeless: i'd agree on writing it down.  even the process of doing that would result in some of the leadership gains we've been referencing.  if such a beast could even be consensus created in our governance.01:51
dougwig(which might be an enlightening output of its own.)01:52
gusdougwig/marun: yeah agreed - I'm just not sure how to describe what we _are_ building ;)01:52
marungus: private cloud :)01:52
*** catohornet has quit IRC01:52
*** carl_baldwin has joined #openstack-neutron01:52
marunlifeless: I don't think it's as simple as writing it down01:52
*** suresh12 has quit IRC01:52
dougwigwhat's a private cloud?  ;-)01:52
marunlifeless: we need enough people with influence to agree on direction01:53
marunlifeless: and then promote that direction mercilessly at the project level01:53
lifelessmarun: IFF we actually don't agree.01:53
marunlifeless: either that or refactor our social contract entirely, but that seems all but impossible (and probably undesirable)01:53
dougwigmarun: have to start somewhere.01:53
lifelessI'll noodle around some prose this week01:54
marunit has to be something that people actually agree on01:54
dougwiglifeless: i'd be interested in seeing what you come up with.01:54
*** baoli has quit IRC01:54
marunI'd be interested in seeing, too01:55
lifelessmy current openstack goal is to try and get some fundamentals in our architecture fixed01:55
openstackgerritKevin Benton proposed openstack/neutron: Only call get_engine().pool.dispose if _FACADE  https://review.openstack.org/16536401:55
lifelessone challenge is that we're solving stuff via how low hanging it is at the moment01:56
marunlifeless: that certainly is ambitious01:56
*** markvoelker has quit IRC01:56
lifelessmarun: it is01:56
marunWithout some form of effective developer education, we are constrained to lcd right now01:56
lifelessmarun: but fragility and failure-during-change was a huge huge huge cost to tripleo01:56
*** sridhar_ram has quit IRC01:57
marunIt doesn't matter how smart you or anyone else is, and what kind of wonderful approaches you can apply, if developers can't maintain them due to a lack of experience/training/etc01:57
gusof course the other approach is to not have a shared vision, and to instead make it easy to all go our separate ways. I think that means more+smaller projects (neutron in particular could probably be exploded into half a dozen actually separate projects); and we dismantle everything that creates the false "in vs out" dichotomy - no free tickets to summit, turn openstack.org into a generic software project hosting site (with01:57
gusfewer editorial restrictions on eligibility), etc01:57
*** zhhuabj has quit IRC01:57
*** zhhuabj has joined #openstack-neutron01:57
marungus: the coordination overhead is huge even for the macro splits we are currently attempting01:57
lifelessgus: yah01:57
marungus: we'd have to find more effective ways of sharing code / libraries than we have now, at the least01:58
lifelessmarun: so we have in principle a mentoring program at the moment01:58
lifelessmarun: but we also have about 0 data, which reminds me, I was going to fix that.01:58
*** melwitt has quit IRC01:58
gusmarun: does it become easier if we just try less hard?  Eg: "arms length" projects wouldn't have to agree on global-requirements.01:58
marungus: we'd end up with duplication of effort if we didn't coordinate.  maybe it's a cost worth paying, we'd have to see.01:59
marungus: certainly being tied to each other so tightly via co-gating is not working in anyone's favor01:59
gusI guess then the "openstack distros" become more important, because assembling a set of projects to work together will be harder.01:59
marunlifeless: I think we need more than mentorship02:00
marunlifeless: it doesn't scale very well02:00
marunlifeless: have you heard of software carpentry?02:01
lifelessI have02:01
marunI heard greg talk at last year's pycon, I found it fascinating02:01
lifelessI have heard great things about it; though I thought it was aimed mainly at scientists who need more programming skill...02:01
marunI think we need something like that but tailored to our new contributors rather than scientists02:01
gusA lot of the current pressures are of our own making - right now it really does have material effects on an individual if their project is considered "part of openstack".02:02
marungus: the big tent may break that :/02:02
marunlifeless: Nick Coughlin attended one of the train-the-trainers sessions for sc last year iirc02:02
marunlifeless: He might have some insight into whether/how we could apply it to openstack02:02
marunlifeless: Most impressive about the program as it exists for scientists is the rigor with which they optimize the learning experience02:03
*** tomoe_ has joined #openstack-neutron02:03
marunlifeless: Knowing the social tricks to use on people to get them to care, to participate02:03
openstackgerritMerged openstack/neutron: Reorganize unit test tree  https://review.openstack.org/15881102:04
marunyay!02:04
marun1 down...02:04
openstackgerritMerged openstack/neutron: Merge open source plugin test code modules  https://review.openstack.org/17100402:05
marun2 down...02:05
mesterylol02:05
marunHenryG, armax: one more to go! https://review.openstack.org/#/c/171005/02:05
mesterymarun: I beat you too it and already poked armax02:07
*** shwetaap1 has quit IRC02:07
marunmestery: awesome!02:07
mestery171005 is in the merge queu :P02:07
mesteryMay the gods have mercy on our souls ;)02:07
*** signed8bit has quit IRC02:07
marunmestery: yes, the 3rd party ci is likely to have a bad day :/02:08
*** shwetaap has joined #openstack-neutron02:08
mesteryrofl02:08
lifelessso the developer training thing is interesting02:08
*** tomoe_ has quit IRC02:08
HenryGmarun: already fixing ours02:08
lifelessbut is it that we have lots of lcd devs02:08
HenryGmarun: it's not hard02:08
lifelessor lots of new-to-python-but-god-they-can-crank-out-C devs02:08
lifelessor ...02:08
marunHenryG: glad to hear :)02:08
*** xgerman has quit IRC02:09
*** pal has joined #openstack-neutron02:09
marunlifeless: we could tailor the development to the broad strokes of common pain points (like 'doesn't know python')02:09
marunlifeless: and then use mentoring to do the rest02:09
kevinbentonmarun: can we add requirements just for the functional tests?02:09
lifelessmarun: what language would we use instead?02:09
marunkevinbenton: we can02:09
kevinbentonmarun: where do they live?02:10
marunlifeless: I'm saying, we could do intro to python02:10
marunkevinbenton: devstack02:10
kevinbentonmarun: just test-requirements.txt ?02:10
lifelessmarun: oh, heh. Thats much less exciting :)02:10
marunkevinbenton: or are you talking about python-only?02:10
marunlifeless: well, less exciting but maybe necessary02:10
*** tomoe_ has joined #openstack-neutron02:10
marunlifeless: it's more costly to teach python in review, that's for sure02:10
kevinbentonmarun: i think i can get by python only02:10
marunkevinbenton: then yeah, test-requirements.txt02:11
marunkevinbenton: oh!02:11
marunactually, we have functional-only test-requirements02:11
*** Marga_ has quit IRC02:11
marunhttps://github.com/openstack/neutron/blob/master/neutron/tests/functional/requirements.txt02:11
marunfor stuff the unit tests don't need02:11
*** popw has joined #openstack-neutron02:12
marunlifeless: but seriously, every project has common pain points for new contributors02:12
marunlifeless: faq and other docs could help to some degree02:12
marunlifeless: but having an intro that was more than mechanical 'how to submit' would be helpful.02:13
*** yamahata has quit IRC02:13
*** sthillma has quit IRC02:13
*** Longgeek has quit IRC02:14
*** psd_ has quit IRC02:15
amullermarun: why would openstack training or mentoring teach Python? There's so many great resources in different mediums that allow you to learn Python02:18
*** lazy_prince has quit IRC02:18
amullerThere's a million different OpenStack specific subjects a new contributor has to learn02:18
marunamuller: python is still a pain point02:19
marunamuller: I think any training regime would have to at least point people at the right resources02:19
*** baoli has joined #openstack-neutron02:19
amulleryeah that I agree with, make sure people are learning from the right sources has a lot of value02:19
amullermarun: btw only 8 notifications from Jenkins about merge conflict, that's not *that* bad :)02:20
*** killer_prince has joined #openstack-neutron02:20
*** killer_prince is now known as lazy_prince02:20
marun:)02:20
marunthat doesn't include out-of-tree, though :(02:20
marunwith luck, nobody has unit tests out of the tree :)02:20
marunbut that would also have obvious downsides ;(02:20
marunreally, we need a test framework that can consume stuff from outside of the tree02:21
amullerfixing out of tree unit tests... http://memegenerator.net/instance/2363716802:21
marunheh02:21
marunto be fair, we do need validation that, say, a plugin or extension outside of the tree works with neutron02:22
marunbut we also need better testing to be able to say the same thing about in-tree stuff02:22
* marun ducks02:22
HenryGmarun: Is this file in the right place? neutron/tests/unit/_test_extension_portbindings.py02:24
marunHenryG: I've ignored those 'helpers' for now02:24
marunHenryG: they aren't actually tests - they can't run on their own02:24
marunHenryG: they're test helpers02:24
HenryGmarun: ok02:25
marunHenryG: iirc that file isn't even used, lemme check that assumption02:25
HenryGmarun: it is used02:25
marunHenryG: correct, by a bunch of plugins02:25
HenryGmarun: and by external repos too02:25
*** baoli has quit IRC02:25
marunHenryG: I figure it's a corner case we can address in lemming02:26
*** carl_baldwin has quit IRC02:26
marunHenryG: better separation between test and supporting code02:26
*** zhenq has quit IRC02:27
*** lazy_prince has quit IRC02:27
marunHenryG: it probably does belong in unit/plugins at the least, though02:28
*** killer_prince has joined #openstack-neutron02:28
HenryGmarun: neutron/tests/unit/plugins/extensions/common/helpers/... :)02:28
marunoy02:29
*** killer_prince is now known as lazy_prince02:29
HenryGjust kidding02:29
marun:)02:29
marunthe work on the functional side is proceeding without much in the way of high-level intent02:29
marunI'm hoping we can clean that up next cycle.  Things should be easier on test developers, and opaque framework/fixture just makes it harder.02:30
HenryG"high-level intent"?02:30
maruncoordination02:30
marun'what are we trying to do?'02:30
marunit's mostly reacting to what we have02:31
openstackgerritshihanzhang proposed openstack/neutron: Fix 'router_gateway' port status can't be updated  https://review.openstack.org/15150102:32
marunbut we are making progress, don't get me wrong. We need to do a better job of presenting a coherent set of tools to those that need them.02:32
marunDocs are definitely a part of it.02:33
kevinbentonmarun: what do i need on my machine to fulfill this?     ImportError: No module named ovs.db02:35
marunkevinbenton: you're trying to run the functional suite?02:36
kevinbentonmarun: yes02:36
marunhttps://github.com/openstack/neutron/blob/master/TESTING.rst#with-tox02:36
marunyou'll need  to run the configure script02:36
* marun needs to revise the TESTING.rst so he can link to that section directly02:37
kevinbenton oh okay02:37
marunkevinbenton: it requires devstack02:37
marunkevinbenton: if the test in question doesn't require sudo, you might be able to get away with tox -e functional02:37
*** achanda has joined #openstack-neutron02:37
kevinbentonmarun: i have already run devstack and this is in a working environment. is there no way to use what's already there?02:37
marunkevinbenton: but if it has os dependencies you'll need to run the script02:37
marunkevinbenton: you can reuse most o fit02:37
marunkevinbenton: run the configure script without '-i'02:38
armaxamuller: ping02:38
marunkevinbenton: it will configure the db and install the python dep for ovs02:38
amullerarmax: yessir02:38
marunkevinbenton: https://github.com/openstack/neutron/blob/master/tools/configure_for_func_testing.sh#L21002:38
kevinbentonmarun: ok02:38
armaxamuller: I’d need your help in addressing an RC1 bug02:38
armaxI know it’s getting pretty late your end02:39
amullerthe ARP thing?02:39
marunkevinbenton: if you're installing post-devstack it does the db, rootwrap and ovs config02:39
armaxamuller: ya, it’s https://review.openstack.org/#/c/170323/02:39
kevinbentonmarun: ugh, now back down this same path of not having the correct database password :(02:39
armaxI wrote a functional test and I am about to post the patch02:39
marunkevinbenton: it should reuse the db password you have set in localrc02:39
kevinbentonmarun: i gtg for now, will just do a clean system later tonight02:39
armaxamuller: if you get a chance and eyeball it, I’d appreciate it02:39
marunkevinbenton: ok02:40
kevinbentonmarun: i use local.conf02:40
amullerarmax: anything specific you want from me?02:40
marunkevinbenton: same thing02:40
armaxamuller: no, just a review02:40
kevinbentonmarun: it didn't honor that02:40
marunkevinbenton: the script loads stackrc which should pull in either02:40
*** suresh12 has joined #openstack-neutron02:41
amullerarmax: looks like Swami needs to augment the functional test to check that the ARP table in the router namespace has the expected entries, should be fairly simple02:41
armaxamuller: because of the RC1 deadline, hence my urge to poke you here02:41
amullerarmax: I had one concern, let me look at the bug02:41
marunkevinbenton: you can probably try setting MYSQL/DATABASE_PASSWORD in the shell before you invoke02:41
armaxamuller: the patch doesn’t have a test right02:41
armaxnow02:41
amulleryeah that's what I said02:42
*** chlong has quit IRC02:42
amullerarmax: Swami said this in the bug report: "02:42
*** suresh12 has quit IRC02:42
amullerAssaf yes the "RPC message is received by the agent" when you spawn an new VM on a Compute.02:42
amullerMost of the times I do see that it immediately returns with "ri.router_info" not found.02:42
kevinbentonmarun: where does that ovs lib come from? can i just install that in my tox env and call it a day or will a bunch of other stuff fall apart?02:42
amuller"02:42
armaxamuller: ok02:43
*** baoli has joined #openstack-neutron02:43
marunkevinbenton: as per the script, you can manually perform the necessary steps02:43
marunkevinbenton: I'd recommend commenting out the _install_databases call02:43
armaxamuller: have you looked at the last comments from carl on the patch itself?02:44
marunkevinbenton: the 2 steps in the file for ovs use is installing python-openvswitch and setting permissions on the port02:44
*** lazy_prince has quit IRC02:44
*** chlong has joined #openstack-neutron02:44
marunhttps://github.com/openstack/neutron/blob/master/tools/configure_for_func_testing.sh#L22402:44
armaxamuller it looks like the snafus is caused by the fact that we were populating the arp cache conditionally on the existence of the gw port02:44
*** pritesh has joined #openstack-neutron02:45
amullerarmax: if the RPC method in the agent returns because the router is not found, Swami said that in the comment I quoted... So the RPC method is called on the agent, but the router is not scheduled on the agent yet, because of the race condition in the server I outlined in the bug report02:45
amullerso any changes you make to the agent will only be a partial fix02:45
amullerunless I'm missing something02:45
armaxamuller: comment #?02:45
amullerarmax: I made comment 5 then he made comment 702:46
*** marun has quit IRC02:46
*** killer_prince has joined #openstack-neutron02:46
*** killer_prince is now known as lazy_prince02:47
*** achanda has quit IRC02:47
armaxamuller: to be honest I am a bit confused by all these comments02:47
amullerarmax: So he said the agents do receive the message, but from his response it looks like sometimes the agent did not manage to configure the router yet (So it doesn't exist in self.router_info cache), then it receives the ARP RPC and doesn't do anything02:47
amullerand there's no fallback there02:47
armaxamuller: all I can understand is carl’s comment #802:47
armaxwhich is what swami’s fix is about02:47
amullerarmax: OK, I'm saying I think there may be another bug, even with Swami's fix02:48
*** pal has quit IRC02:48
armaxamuller: ok, that’s not what I am asking your help for :)02:48
*** achanda has joined #openstack-neutron02:48
armaxamuller: at least not right now02:48
amullerarmax: You asked me to review, I'm saying Swami's fix is partial02:49
armaxamuller: true, let me be more specific: swami didnt add a test02:49
armaxamuller: and he’s been off sick today02:49
amullerarmax: ok02:49
*** dboik_ has quit IRC02:49
openstackgerritSanjeev Rampal proposed openstack/neutron: Fixes description strong for the config parameter metadata_workers. This will get extracted into the documentation automatically  https://review.openstack.org/17102602:50
armaxamuller: I am pushing a functional test alongside this patch; the lack of tests is the reason of most -102:50
amullerarmax: hrmph, I'm currently trying to help on Mike on https://review.openstack.org/#/c/141114/1202:50
amullerand it's already 11pm, I'll see what I can do about Swami's patch02:50
armaxamuller: I was going to ask you if you could check whether the functional test is up to your standards02:50
amullerarmax: oh ok02:50
armaxamuller: agreed02:50
amullerarmax: then push it :)02:50
*** Longgeek has joined #openstack-neutron02:51
armaxamuller: I am not asking you to do it now02:51
armaxamuller: but you are 4 hours ahead of me02:51
amullerarmax: I think we can live with just checking that the number of entries in the ARP table is as expected02:51
armaxso if you get a chance tomorrow02:51
amullerthat's the minimum02:51
armaxit’d be good02:51
amullersure02:51
armaxI did more than that02:51
* amuller awards one brownie point to Armando02:51
armaxlet me clean this up and post if for review02:52
armaxamuller: yum brownie02:52
*** markvoelker has joined #openstack-neutron02:52
armaxamuller: k, won’t hold you longer02:52
openstackgerritSanjeev Rampal proposed openstack/neutron: Fixes description string for the config parameter metadata_workers. This will get extracted into the documentation automatically  https://review.openstack.org/17102602:53
armaxyamamoto: ping02:56
*** dannywilson has joined #openstack-neutron02:56
*** markvoelker has quit IRC02:56
armaxyamamoto: please have a look at https://review.openstack.org/#/c/170939/02:56
armaxyamamoto: as this may affect you02:57
*** baoli has quit IRC02:58
*** dims has quit IRC02:58
*** pritesh has quit IRC02:58
*** vivek-ebay has joined #openstack-neutron02:58
*** baoli has joined #openstack-neutron02:58
*** pritesh has joined #openstack-neutron02:58
openstackgerritArmando Migliaccio proposed openstack/neutron: Fix dynamic arp populate error for dvr routers  https://review.openstack.org/17032302:59
*** dannywilson has quit IRC03:00
HenryGarmax: still around?03:05
armaxyes03:06
HenryGarmax: Danes DB issue is eating away at me. I don't understand it. :(03:07
*** dims has joined #openstack-neutron03:07
armaxHenryG: what’s issue?03:07
*** dims_ has joined #openstack-neutron03:08
HenryGarmax: The deadlock provoked by the dhcpv6 scenario test03:08
amullerarmax: Can you add the check to _dvr_router_lifecycle?03:08
*** ajmiller_ has joined #openstack-neutron03:08
amullerarmax: Adding a new test for every check is not going to scale well, those tests take a while to execute03:08
armaxamuller: can do, so long as the setup is the same though03:08
*** xgerman has joined #openstack-neutron03:09
amullerarmax: I think you can make it work03:09
armaxamuller: iirc that test does set up the gateway for the router too03:10
armaxamuller: and I wanted to add a test that indeed failed without swami’s fix03:10
armaxamuller: hence I went the route you saw03:10
*** Longgeek_ has joined #openstack-neutron03:10
yamamotoarmax: thank you.  will look03:10
*** Longgeek has quit IRC03:12
*** dims has quit IRC03:12
*** ajmiller__ has quit IRC03:12
armaxamuller: tweaking the existing test code sounds like more trouble than it’s worth to be honest03:12
armaxamuller:  the test took only 2 seconds to run on my box03:12
armaxamuller: not sure if we’re at the inflection point where speed is really a problem, but I’ll look into it03:13
*** DD_ has quit IRC03:13
amullerarmax: yeah I forgot the rootwrap daemon really cut those down03:13
amullerand the DVR tests don't have any wait_untils that the HA router tests do...03:13
amulleryou can forget about my comment then03:14
openstackgerritMerged openstack/neutron: Reorganize plugin test modules  https://review.openstack.org/17100503:15
*** srampal has joined #openstack-neutron03:15
armaxamuller: anyway it’s a good point, I’ll look more closely03:15
*** leenheer has joined #openstack-neutron03:15
armaxamuller but I’d rather make the patch easier to digest for now, if that’s okay with you03:15
amullerit is03:16
*** dims_ has quit IRC03:20
*** dsneddon has quit IRC03:21
*** baoli has quit IRC03:22
openstackgerritpritesh proposed openstack/neutron: Moving VLAN Transparency support from core to extension  https://review.openstack.org/16956903:25
*** Longgeek_ has quit IRC03:32
*** sbfox has joined #openstack-neutron03:32
*** tiswanso has quit IRC03:35
yamamotomajor reorg of tests are done?  ie. should i rebase my patches or wait?03:35
armaxyamamoto: you can start03:36
*** pritesh has quit IRC03:39
*** pritesh has joined #openstack-neutron03:40
yamamotoarmax: thank you03:41
*** tflynn has joined #openstack-neutron03:41
*** pritesh has quit IRC03:41
*** pritesh has joined #openstack-neutron03:43
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: linuxbridge UT: Fix a regression of the recent ip_lib change  https://review.openstack.org/16529103:43
*** coolsvap|afk is now known as coolsvap03:45
*** wanghong has quit IRC03:46
*** tflynn_ has joined #openstack-neutron03:47
*** jamielennox is now known as jamielennox|away03:47
*** pritesh has quit IRC03:47
*** pritesh has joined #openstack-neutron03:48
openstackgerritAssaf Muller proposed openstack/neutron: Update port bindings for master router  https://review.openstack.org/14111403:49
*** baoli has joined #openstack-neutron03:49
*** tflynn has quit IRC03:50
*** pal has joined #openstack-neutron03:51
*** markvoelker has joined #openstack-neutron03:53
*** Marga_ has joined #openstack-neutron03:54
*** Marga_ has quit IRC03:54
*** Marga_ has joined #openstack-neutron03:55
*** harlowja is now known as harlowja_away03:55
*** baoli has quit IRC03:55
*** TrevorV_ has joined #openstack-neutron03:56
*** markvoelker has quit IRC03:57
*** emagana has joined #openstack-neutron03:57
openstackgerritAssaf Muller proposed openstack/neutron: Remove tests from HA routers test framework  https://review.openstack.org/17104003:58
*** banix has quit IRC03:59
openstackgerritpritesh proposed openstack/neutron: Moving VLAN Transparency support from core to extension  https://review.openstack.org/16956903:59
*** Longgeek has joined #openstack-neutron04:00
*** nlahouti has joined #openstack-neutron04:01
*** TrevorV_ has quit IRC04:01
openstackgerritHenry Gessau proposed openstack/neutron: Allow unit tests to be run independently  https://review.openstack.org/16978904:04
*** nlahouti has quit IRC04:05
*** nlahouti has joined #openstack-neutron04:05
*** dave-mccowan has quit IRC04:08
*** suresh12 has joined #openstack-neutron04:08
*** suresh12 has quit IRC04:09
*** sthillma has joined #openstack-neutron04:09
*** sthillma has quit IRC04:10
*** suresh12 has joined #openstack-neutron04:10
*** amuller has quit IRC04:12
*** achanda has quit IRC04:13
*** _cjones_ has joined #openstack-neutron04:15
*** neeti has joined #openstack-neutron04:17
*** Administrator has joined #openstack-neutron04:18
*** Administrator is now known as Guest530104:18
*** _cjones_ has quit IRC04:19
*** achanda has joined #openstack-neutron04:20
*** amotoki has joined #openstack-neutron04:20
*** Guest5301 has quit IRC04:20
*** pritesh has quit IRC04:25
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: Functional tests for OVS-agent OpenFlow drivers  https://review.openstack.org/16458404:26
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver  https://review.openstack.org/15394604:26
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024504:26
*** nplanel_ has quit IRC04:26
openstackgerritMerged openstack/python-neutronclient: Adding VLAN Transparency support to neutronclient  https://review.openstack.org/16204004:27
*** xgerman has quit IRC04:28
*** watanabe_isao has joined #openstack-neutron04:29
*** seizadi has joined #openstack-neutron04:29
*** seizadi has quit IRC04:30
*** neeti_ has joined #openstack-neutron04:38
*** neeti has quit IRC04:38
*** ajo has quit IRC04:38
*** coolsvap is now known as coolsvap|afk04:41
*** vthapar has joined #openstack-neutron04:43
*** tomoe_ has quit IRC04:44
*** tomoe_ has joined #openstack-neutron04:45
*** ajo has joined #openstack-neutron04:47
*** coolsvap|afk is now known as coolsvap04:48
*** pritesh has joined #openstack-neutron04:48
*** lazy_prince has quit IRC04:48
*** srampal has quit IRC04:48
openstackgerritgoocher proposed openstack/neutron-fwaas: logic error in updating audited of firewall policy  https://review.openstack.org/16923904:48
*** tflynn has joined #openstack-neutron04:49
*** tflynn_ has quit IRC04:50
*** vivek-ebay has quit IRC04:52
*** markvoelker has joined #openstack-neutron04:53
*** sbfox has quit IRC04:56
*** pradipta has joined #openstack-neutron04:58
*** markvoelker has quit IRC04:58
*** chandankumar has joined #openstack-neutron05:00
*** yatin has joined #openstack-neutron05:04
*** pritesh has quit IRC05:04
*** sbfox has joined #openstack-neutron05:08
*** tflynn has quit IRC05:08
*** TrevorV_ has joined #openstack-neutron05:08
*** neeti_ has quit IRC05:09
*** pritesh has joined #openstack-neutron05:11
*** neeti has joined #openstack-neutron05:12
*** luqas has joined #openstack-neutron05:12
*** luqas has quit IRC05:16
*** TrevorV|Home has joined #openstack-neutron05:19
*** anish_ has joined #openstack-neutron05:19
*** anshul has joined #openstack-neutron05:20
*** sripriya has quit IRC05:21
*** sripriya has joined #openstack-neutron05:21
*** apuimedo has joined #openstack-neutron05:22
*** anilvenkata has joined #openstack-neutron05:26
*** bobmel has quit IRC05:27
*** TrevorV_ has quit IRC05:28
openstackgerritAman Kumar proposed openstack/neutron: ovs agent resync may miss port remove event  https://review.openstack.org/16502305:31
*** irenab has joined #openstack-neutron05:32
*** leenheer has quit IRC05:33
*** anilvenkata has quit IRC05:33
*** Aish has quit IRC05:36
*** Zemeio has joined #openstack-neutron05:43
openstackgerritAman Kumar proposed openstack/neutron: Added config variable for External Network type in ML2  https://review.openstack.org/14954605:44
openstackgerritGal Sagie proposed openstack/neutron: Add OVSDB connection as a parameter to the transaction  https://review.openstack.org/17077105:46
*** anilvenkata has joined #openstack-neutron05:47
*** tflynn has joined #openstack-neutron05:52
*** Murali has joined #openstack-neutron05:52
*** markvoelker has joined #openstack-neutron05:54
openstackgerritGal Sagie proposed openstack/neutron: allow OVSDB connection schema to be configurable  https://review.openstack.org/17084205:56
openstackgerritGal Sagie proposed openstack/neutron: Add OVSDB connection as a parameter to the transaction  https://review.openstack.org/17077105:56
*** veena has joined #openstack-neutron05:56
veenaHi, please provide the reference for localrc, stackrc and other config files to install devstack Juno and enable neutron with sriov funtionality05:58
*** markvoelker has quit IRC05:58
*** armax has quit IRC06:05
*** kickinz1|afk is now known as kickinz106:06
*** ZZelle has quit IRC06:07
*** pritesh has quit IRC06:08
*** killer_prince has joined #openstack-neutron06:09
*** killer_prince is now known as lazy_prince06:10
openstackgerritGal Sagie proposed openstack/neutron: allow OVSDB connection schema to be configurable  https://review.openstack.org/17084206:11
*** numan has joined #openstack-neutron06:14
*** Bsony has joined #openstack-neutron06:14
*** tflynn_ has joined #openstack-neutron06:15
*** suresh12 has quit IRC06:16
*** tflynn has quit IRC06:18
openstackgerritEdgar Magana proposed openstack/neutron: Add missing config parameters in neutron.conf  https://review.openstack.org/17105906:22
*** Bsony has quit IRC06:22
veenairenab: Hi, please provide the reference for localrc, stackrc and other config files to install devstack Juno and enable neutron with sriov funtionality06:22
*** ishant has joined #openstack-neutron06:23
*** yamahata has joined #openstack-neutron06:25
*** numan has quit IRC06:28
*** Marga_ has quit IRC06:29
*** Longgeek has quit IRC06:34
*** Longgeek has joined #openstack-neutron06:34
*** irenab has quit IRC06:34
openstackgerritEdgar Magana proposed openstack/neutron: Add missing config parameters in neutron.conf  https://review.openstack.org/17105906:37
*** moshele has joined #openstack-neutron06:41
*** nlahouti has quit IRC06:42
*** atuvenie has joined #openstack-neutron06:46
*** jistr has joined #openstack-neutron06:47
openstackgerritCedric Brandily proposed openstack/neutron: Allow to define enable_snat default value  https://review.openstack.org/13058806:49
openstackgerritCedric Brandily proposed openstack/neutron: Correct inconsistent enable_snat management  https://review.openstack.org/13019906:50
*** ajo has quit IRC06:51
*** trinaths has joined #openstack-neutron06:52
*** numan has joined #openstack-neutron06:53
*** afazekas has joined #openstack-neutron06:54
*** markvoelker has joined #openstack-neutron06:55
*** popw1 has joined #openstack-neutron06:55
*** liusheng has joined #openstack-neutron06:56
*** anshul has quit IRC06:56
*** popw has quit IRC06:57
*** tflynn_ has quit IRC06:57
*** aswadr has joined #openstack-neutron06:58
*** markvoelker has quit IRC06:59
*** achanda has quit IRC07:04
*** kiran_ has joined #openstack-neutron07:05
*** kiran_ is now known as kiran-r07:07
*** ajo has joined #openstack-neutron07:07
*** Bsony has joined #openstack-neutron07:07
*** irenab has joined #openstack-neutron07:08
*** kawa2014 has joined #openstack-neutron07:08
*** achanda has joined #openstack-neutron07:08
*** TrevorV|Home has quit IRC07:09
irenabveena: hi, I am not dealing with SRIOV for some time now. Can you please check with moshele? He may help you with this.07:11
*** anshul has joined #openstack-neutron07:11
mosheleveena: hi07:14
mosheleirenab: what is the problem ?07:16
irenabmoshele: veena is looking for a help with devstack configuration to enable SRIOV. I hoped you can help him07:17
*** Bsony has quit IRC07:18
irenab^^Hi, please provide the reference for localrc, stackrc and other config files to install devstack Juno and enable neutron with sriov funtionality07:19
*** anshul has quit IRC07:20
*** nuritv has joined #openstack-neutron07:22
mosheleirenab: sure I am here to help :)07:22
irenabmoshele: :-)07:23
*** achanda has quit IRC07:23
openstackgerritpritesh proposed openstack/neutron: Moving VLAN Transparency support from core to extension  https://review.openstack.org/16956907:23
*** bobmel has joined #openstack-neutron07:23
*** pritesh has joined #openstack-neutron07:24
*** ankit_ag has joined #openstack-neutron07:25
priteshsalv-orlando: hi07:26
*** achanda has joined #openstack-neutron07:26
*** ajo has quit IRC07:27
salv-orlandohi pritesh07:28
*** ebagdasa_ has joined #openstack-neutron07:28
openstackgerritJohn Schwarz proposed openstack/neutron: Add full-stack test  https://review.openstack.org/12300007:28
*** shwetaap has quit IRC07:29
priteshsalv-orlando: thanks for the review of #169569, I added todo for both items which you mentioned, will try to handle this in a separate follow up patch, if you are ok with it.07:29
*** neeti has quit IRC07:30
*** ronis has joined #openstack-neutron07:30
mosheleveena: here is an example of local.conf for devstack http://pastebin.com/kKdXjbpB if you need help please free to ping me07:31
salv-orlandopritesh: for the config option, I believe it should be fairly easy to get rid of it. anyway, thanks for your quick reply. I will wait for opinions from amotoki and armax regarding whether the patch is ok as it is as they've followed it from the beginning07:32
*** anshul has joined #openstack-neutron07:33
amotokipritesh: will check it again in a couple of hours07:33
priteshsalv-orlando: np, ok, will try to get the config options handled, sure will wait for their opinions. thanks.07:33
*** chlong has quit IRC07:34
salv-orlandopritesh: cool thanks07:34
*** jlibosva has joined #openstack-neutron07:36
*** achanda has quit IRC07:37
*** yog__ has joined #openstack-neutron07:37
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: Remove duplicated l3 router scheduler test cases  https://review.openstack.org/16748907:40
*** neeti has joined #openstack-neutron07:40
*** subscope has joined #openstack-neutron07:41
*** pritesh has quit IRC07:41
openstackgerritEdgar Magana proposed openstack/neutron: Add missing config parameters in neutron.conf  https://review.openstack.org/17105907:41
*** anshul has quit IRC07:42
*** veena has quit IRC07:44
*** gildub has quit IRC07:45
*** YorikSar has quit IRC07:46
*** safchain has joined #openstack-neutron07:46
*** dguitarbite has joined #openstack-neutron07:47
*** luqas has joined #openstack-neutron07:47
*** luqas has quit IRC07:49
*** devvesa has joined #openstack-neutron07:49
*** luqas has joined #openstack-neutron07:49
*** jistr has quit IRC07:50
*** veena has joined #openstack-neutron07:50
veenairenab, moshele: Thanks for the reference.07:50
veenamoshele: Can I use that localrc file to install Icehouse release?07:51
veenamoshele: or it is specific to Juno?07:52
irenabveena: specific for Juno07:52
*** psd has joined #openstack-neutron07:53
veenairenab: What changes do I need to make if I want to use it for Icehouse? I need to check "neutron port-create" on the physical network connected to SRIOV nic07:53
irenabveena: for the Icehouse SRIOV was supported only via mlnx Mechanism Driver, which is different from sriovnicswitch Mech. Driver.07:53
*** anshul has joined #openstack-neutron07:54
irenabveena: if you insist on Icehouse, you need different devstack setup and it will only work on Mellanox NICs.07:55
*** markvoelker has joined #openstack-neutron07:56
veenairenab: I have added the sriovnicagent and mech_sriov to the Icehouse code base. Basically copied from Juno and made some changes related to oslo.messaging.07:56
openstackgerritEdgar Magana proposed openstack/neutron: Add missing config parameters in neutron.conf  https://review.openstack.org/17105907:56
irenabveena: there are also nova changes that need to be present, and this support was added in Juno07:57
veenairenab: I have sent you an email with the details07:57
*** yfauser has joined #openstack-neutron07:57
veenairenab: I'm supposed to use only Icehouse and not upgrade to Juno. But get the SRIOV functionality. So am doing back porting of code from Juno to Icehouse.07:58
*** yfauser has left #openstack-neutron07:58
irenabveena: please check with moshele, maybe he can help you with the setup and your use case. You must have nova support for SRIOV that was added in Juno07:59
*** jpena has joined #openstack-neutron07:59
*** markvoelker has quit IRC08:00
*** ajo has joined #openstack-neutron08:00
veenaSure irenab. Will check with him. Thanks for the reference.08:00
veenamoshele: Hi08:01
*** matrohon has joined #openstack-neutron08:02
*** luqas__ has joined #openstack-neutron08:03
*** luqas__ has quit IRC08:04
*** sripriya has quit IRC08:04
*** moshele has quit IRC08:06
*** sbfox has quit IRC08:06
*** apuimedo has quit IRC08:06
*** ygbo has joined #openstack-neutron08:06
*** anshul has quit IRC08:07
*** jistr has joined #openstack-neutron08:09
*** lazy_prince has quit IRC08:11
openstackgerritShaoRan Xiao proposed openstack/neutron: Definition of the Virtual Network Performance interface Implements:blueprint virtual-network-performance-monitor  https://review.openstack.org/16481408:12
anteayaemagana: sorry to remove you from the agenda, I had just gone by the date posted which was stale08:13
anteayaemagana: thanks for catching that08:13
*** ronis_ has joined #openstack-neutron08:14
*** ronis has quit IRC08:18
*** anshul has joined #openstack-neutron08:22
*** ociuhandu has joined #openstack-neutron08:22
*** psd has quit IRC08:22
*** aepifanov has joined #openstack-neutron08:27
openstackgerritIWAMOTO Toshihiro proposed openstack/neutron: Add availability_zone support  https://review.openstack.org/14994008:30
*** ihrachyshka has joined #openstack-neutron08:31
*** yamahata has quit IRC08:32
*** anilvenkata has quit IRC08:36
*** doude has joined #openstack-neutron08:38
*** YorikSar has joined #openstack-neutron08:39
*** moshele has joined #openstack-neutron08:40
mosheleveena: hi08:40
*** yuanying has quit IRC08:40
mosheleveena: please contact me for the issue my mail is moshele@mellanox.com08:42
veenaHi moshele, I'm working to get SRIOV functionality in Icehouse release. I see from the blueprint that code enchancement for neutron was done during Icehouse08:42
veenamoshele: So I'm backporting the nova and neutron code form Juno to Icehouse08:43
veenamoshele: Okay, will drop you a mail08:43
mosheleveena: ok what are the issues?08:44
*** killer_prince has joined #openstack-neutron08:44
*** killer_prince is now known as lazy_prince08:44
veenamoshele: I added sriovnicagent and mech_driver to the neutron/plugin/ml2 code base. And want to test the functionality. What changes in localrc file do I need to make it get working in Icehouse?08:45
*** yamamoto has quit IRC08:46
mosheleveen: you need to configure the pci_passthrough_whitelist08:48
*** anshul has quit IRC08:48
mosheleveena: see http://pastebin.com/kKdXjbpB08:48
*** killer_prince has joined #openstack-neutron08:49
veenamoshele: This localrc file will be same for both Juno and Icehouse?08:50
*** rotbeard has joined #openstack-neutron08:51
mosheleveena: do you have [[post-config|$NOVA_CONF]]08:51
moshele[DEFAULT]08:51
moshelepci_passthrough_whitelist ={"'"address"'":"'"*:02:00.*"'","'"physical_network"'":"'"default"'"} in you local.conf08:51
*** anilvenkata has joined #openstack-neutron08:51
*** lazy_prince has quit IRC08:51
*** killer_prince is now known as lazy_prince08:51
veenamoshele: No, I didn't add that. I haven't yet done the nova code change. So didn't add nova config changes08:52
mosheleveena: the nova change is import you should do it as well08:53
*** asrangne has joined #openstack-neutron08:54
veenamoshele: Okay. Is there any way I that I can test neutron changes only? I mean, functional testing08:54
mosheleveena: no you need both08:54
*** neeti has quit IRC08:55
*** lazy_prince has quit IRC08:55
*** aswadr has quit IRC08:56
*** asrangne__ has joined #openstack-neutron08:56
*** markvoelker has joined #openstack-neutron08:56
*** killer_prince has joined #openstack-neutron08:57
veenamoshele, Okay. I update the nova code also. But there are many files to be changed as I see in https://review.openstack.org/#/c/107123/ and virt/libvirt/driver.py. Is there any patch that's been already written to get the SRIOV working with Icehouse?08:57
*** killer_prince is now known as lazy_prince08:57
mosheleveena: not that I am aware of08:58
*** asrangne has quit IRC09:00
veenamoshele: Okay. Whom should I contact in Nova team to understand this?09:00
*** killer_prince has joined #openstack-neutron09:01
*** markvoelker has quit IRC09:01
*** lazy_prince has quit IRC09:02
*** killer_prince is now known as lazy_prince09:02
*** neeti has joined #openstack-neutron09:02
mosheleveena: I think you should cerry-pick  https://review.openstack.org/#/c/107123 and https://review.openstack.org/#/c/99043/,but  I am not sure it will be trivial you can contact baoli for nova changes09:03
*** claudiub has joined #openstack-neutron09:03
veenamoshele:okay. Are there any design doc or code change logs or any references related to SRIOV changes? If you could share, it'll be helpful09:04
*** anshul has joined #openstack-neutron09:05
mosheleveena: this is blue print https://review.openstack.org/#/c/86606/25/specs/juno/pci-passthrough-sriov.rst09:06
veenamoshele: Thanks for the link. These are exactly what I was looking for, but these include changes only in pci module. Seems like libvirt/driver and few other files need to be changed.09:06
irenabveena: you can see all related patches linked here: https://blueprints.launchpad.net/nova/+spec/pci-passthrough-sriov09:08
veenamoshele: Okay. the blueprint explains it very well. Looks like baoli is not on IRC now. Will contact him when he is online09:09
veenaThanks irenab, I think the link you shared covers everything.09:09
veenamoshele, irenab: Will continue doing the nova changes and then test. If successful, will try to submit a patch that can be used to get SRIOV working with Icehouse release :)09:10
*** atuvenie has quit IRC09:10
*** pradipta has quit IRC09:11
*** ociuhandu has quit IRC09:17
openstackgerritYatin Kumbhare proposed openstack/neutron: opencontrail extension support  https://review.openstack.org/14529009:19
*** wznoinsk has joined #openstack-neutron09:20
*** shaohe_feng1 has quit IRC09:21
*** watanabe_isao has quit IRC09:21
*** Longgeek has quit IRC09:23
*** atuvenie has joined #openstack-neutron09:24
*** dims has joined #openstack-neutron09:29
*** pask81 has joined #openstack-neutron09:31
*** dims has quit IRC09:35
*** pask81 has quit IRC09:35
*** anilvenkata has quit IRC09:35
openstackgerritElena Ezhova proposed openstack/neutron: [WIP]: Add handling of SIGHUP - multiprocess mode  https://review.openstack.org/16173209:39
openstackgerritElena Ezhova proposed openstack/neutron: [WIP] Add SIGHUP support: single process mode  https://review.openstack.org/17090509:39
openstackgerritElena Ezhova proposed openstack/neutron: Sync service from oslo-incubator  https://review.openstack.org/16797409:39
*** ujjain has joined #openstack-neutron09:39
*** rook__ has joined #openstack-neutron09:42
*** aix has joined #openstack-neutron09:45
*** anilvenkata has joined #openstack-neutron09:50
*** trinaths has left #openstack-neutron09:51
*** SridharG1 has joined #openstack-neutron09:53
openstackgerritRomil Gupta proposed openstack/neutron: Move values for network_type to plugins.common.constants.py  https://review.openstack.org/16687909:56
*** markvoelker has joined #openstack-neutron09:57
*** rook__ has quit IRC09:58
*** moshele has quit IRC09:59
*** pask81 has joined #openstack-neutron10:02
*** markvoelker has quit IRC10:02
*** ociuhandu has joined #openstack-neutron10:03
*** chlong has joined #openstack-neutron10:07
*** pask81 has quit IRC10:07
*** kickinz1 is now known as kickinz1|afk10:09
*** doude has quit IRC10:14
*** numan has quit IRC10:15
*** doude has joined #openstack-neutron10:16
*** kickinz1|afk is now known as kickinz110:20
*** Longgeek has joined #openstack-neutron10:24
*** pal has quit IRC10:28
*** moshele has joined #openstack-neutron10:28
*** moshele has quit IRC10:29
*** jistr has quit IRC10:30
*** pask81 has joined #openstack-neutron10:30
*** moshele has joined #openstack-neutron10:30
*** Longgeek has quit IRC10:30
*** pask81 has quit IRC10:40
*** pask81 has joined #openstack-neutron10:42
*** pc_m has joined #openstack-neutron10:49
*** jistr has joined #openstack-neutron10:51
*** pask81 has quit IRC10:52
*** jistr is now known as jistr|biab10:52
*** anshul has quit IRC10:52
*** pal has joined #openstack-neutron10:53
*** ujjain has quit IRC10:56
*** ujjain has joined #openstack-neutron10:56
*** stanzgy has quit IRC10:56
*** markvoelker has joined #openstack-neutron10:58
*** rook__ has joined #openstack-neutron11:00
*** markvoelker has quit IRC11:03
*** anshul has joined #openstack-neutron11:05
*** dguitarbite has quit IRC11:06
HenryGsalv-orlando: ping11:06
*** dguitarbite has joined #openstack-neutron11:06
salv-orlandogood morning HenryG11:06
HenryGsalv-orlando: about your last comment here, https://review.openstack.org/#/c/170968/2/neutron/db/db_base_plugin_v2.py11:07
*** shaohe_feng has joined #openstack-neutron11:07
salv-orlandothe DbReference error catch clause?11:07
HenryGsalv-orlando: yes11:08
*** tomoe_ has quit IRC11:08
HenryGsalv-orlando: it is very easy to reproduce11:08
openstackgerritDarragh O'Reilly proposed openstack/neutron: Fix dhcp _test_sync_state_helper asserting calls wrong  https://review.openstack.org/15975611:08
salv-orlandoHenryG: how that can be reproduced?11:08
salv-orlandoI am actually more interested in understanding why the introduction of the lock introduces it11:08
HenryGsalv-orlando: no, it happens even easier without the lock11:09
salv-orlandoah ok.11:09
HenryGsalv-orlando: see end of description here, https://bugs.launchpad.net/neutron/+bug/144019211:09
openstackLaunchpad bug 1440183 in neutron "duplicate for #1440192 DBDeadlock on subnet allocation" [High,In progress] - Assigned to Dane LeBlanc (leblancd)11:09
HenryGsalv-orlando: The lock removes the deadlock, but we are still left with the FK integrity error11:10
salv-orlandoHenryG: and we do not have a real clue to the reason which is causing the fk violation?11:11
salv-orlandoI am just trying to understand if the issue is really a concurrent delete as described here11:11
salv-orlandoor something else - like a problem with sqlalchemy and transaction buffering. - and therefore this fix would just hide a problem11:12
HenryGsalv-orlando: The ipallocations has a fk on ports id11:12
openstackgerritElena Ezhova proposed openstack/neutron: [WIP] Add SIGHUP support: single process mode  https://review.openstack.org/17090511:12
salv-orlandoHenryG: I will quote Dr. McCoy from Star Trek.... "Tell me something I do not know" ;)11:12
*** ankit_ag has quit IRC11:13
*** lori|away is now known as lori11:13
*** ankit_ag has joined #openstack-neutron11:13
openstackgerritElena Ezhova proposed openstack/neutron: [WIP] Add SIGHUP support: single process mode  https://review.openstack.org/17090511:13
HenryGsalv-orlando: sorry :) Yeah, I have no real clue, or even an imaginary one11:14
HenryGsalv-orlando: I suggested to try the expire (line 1366) and that reduced the issue's occurrence rate but did not eliminate it.11:15
salv-orlandoHenryG: the point is that I would like to understand how it is possible that the port to which the allocation refers is deleted before the same transaction that creates the port completes11:16
salv-orlandoeither we have split that transaction and we did not realize that11:16
salv-orlandoor the port is not actually deleted.11:16
HenryGsalv-orlando: Well, I think the tempest NetworksTestDHCPv6 tests emit concurrent create and delete requests11:17
HenryGactually I know they do11:18
HenryGsalv-orlando: If you read some of Armando's comments he thinks the test is rather awful11:19
*** oreillyd has joined #openstack-neutron11:19
HenryGsalv-orlando: You can see previous attempts at addressing the issue here https://review.openstack.org/170690 and here https://review.openstack.org/17061111:21
*** john-davidge has joined #openstack-neutron11:21
*** pal has quit IRC11:21
*** trinaths has joined #openstack-neutron11:21
*** trinaths has left #openstack-neutron11:21
*** vthapar has quit IRC11:22
salv-orlandoHenryG: how can you concurrently delete a port that you are creating?11:23
salv-orlandodid we switched to async operations?11:23
HenryGsalv-orlando: no :)11:23
HenryGsalv-orlando: the code in question is during subnet create11:23
salv-orlandoso we do not delete concurrently the port, but the subnet?11:24
HenryGwe are in subnet create when the test is deleting ports, I believe11:24
salv-orlandoHenryG: I will look at the logs myself, there is something that's not yet entirely clear to me11:24
*** devvesa has quit IRC11:28
*** gildub has joined #openstack-neutron11:28
*** veena has quit IRC11:29
*** yamamoto has joined #openstack-neutron11:32
openstackgerritshihanzhang proposed openstack/neutron: Fix 'router_gateway' port status can't be updated  https://review.openstack.org/15150111:32
*** ujjain has quit IRC11:33
*** dguitarbite has quit IRC11:33
*** anish_ has quit IRC11:35
*** dguitarbite has joined #openstack-neutron11:36
*** amotoki has quit IRC11:38
*** yamamoto has quit IRC11:38
*** anish_ has joined #openstack-neutron11:40
*** enikanorov has quit IRC11:42
*** numan has joined #openstack-neutron11:42
*** enikanorov has joined #openstack-neutron11:43
ajotrying to fix a bug in the gate: http://i.imgur.com/TfB1Cpv.gif11:43
ajosorry, I couldn't resist X)11:43
*** kiran-r has quit IRC11:43
*** ferest has joined #openstack-neutron11:44
*** jpena is now known as jpena|lunch11:45
*** chlong has quit IRC11:49
*** jistr|biab is now known as jistr11:49
*** chlong has joined #openstack-neutron11:51
*** ferest has quit IRC11:51
*** Longgeek has joined #openstack-neutron11:53
*** gildub has quit IRC11:54
*** lazy_prince has quit IRC11:58
*** markvoelker has joined #openstack-neutron11:59
*** coolsvap is now known as coolsvap|afk11:59
*** mattt has left #openstack-neutron12:01
*** markvoelker has quit IRC12:03
sc68calajo: haha I was doing the same thing12:09
*** anilvenkata has quit IRC12:09
ajo:-)12:09
sc68calajo: https://review.openstack.org/#/c/171071/12:09
sc68calif you haven't seen already :)12:09
*** pal has joined #openstack-neutron12:10
*** aepifanov has quit IRC12:11
ajowoops, I didn't :), I was doing something else, but I found the gif very funny when thinking of fixing gate bugs12:11
*** aepifanov has joined #openstack-neutron12:11
*** anilvenkata has joined #openstack-neutron12:14
*** baoli has joined #openstack-neutron12:16
*** rook__ has quit IRC12:16
*** kerpan has joined #openstack-neutron12:18
*** flaviof_ has joined #openstack-neutron12:18
*** dave-mccowan has joined #openstack-neutron12:21
*** flaviof has quit IRC12:21
*** alexpilotti has joined #openstack-neutron12:22
*** devvesa has joined #openstack-neutron12:23
*** mwagner_lap has quit IRC12:25
*** killer_prince has joined #openstack-neutron12:25
*** killer_prince is now known as lazy_prince12:25
*** baoli_ has joined #openstack-neutron12:28
*** killer_prince has joined #openstack-neutron12:28
*** erkules_ is now known as erkules12:28
*** erkules has quit IRC12:28
*** erkules has joined #openstack-neutron12:28
*** smccully has joined #openstack-neutron12:28
*** lazy_prince has quit IRC12:30
*** baoli has quit IRC12:30
*** killer_prince has quit IRC12:33
*** pal_ has joined #openstack-neutron12:33
*** dims has joined #openstack-neutron12:34
*** pal has quit IRC12:36
*** killer_prince has joined #openstack-neutron12:36
*** killer_prince is now known as lazy_prince12:36
*** yatin has quit IRC12:38
*** dims has quit IRC12:39
*** numan has quit IRC12:48
*** killer_prince has joined #openstack-neutron12:48
*** shaohe_feng has quit IRC12:49
*** lazy_prince has quit IRC12:49
*** killer_prince is now known as lazy_prince12:49
*** jpena|lunch is now known as jpena12:50
*** wverdugo500 has left #openstack-neutron12:51
*** rpothier has joined #openstack-neutron12:51
*** Murali has quit IRC12:52
*** killer_prince has joined #openstack-neutron12:56
openstackgerritElena Ezhova proposed openstack/neutron: Handle SIGHUP: neutron-server (multiprocess) and metadata agent  https://review.openstack.org/16173212:57
openstackgerritElena Ezhova proposed openstack/neutron: Refactor socket ssl wrapping  https://review.openstack.org/17117812:57
openstackgerritElena Ezhova proposed openstack/neutron: Handle SIGHUP in dhcp and l3 agents  https://review.openstack.org/17117912:57
openstackgerritMike Kolesnik proposed openstack/neutron: Update port bindings for master router  https://review.openstack.org/14111412:57
*** lazy_prince has quit IRC12:58
*** killer_prince is now known as lazy_prince12:58
*** annegentle has joined #openstack-neutron12:58
*** markvoelker has joined #openstack-neutron12:59
*** amotoki has joined #openstack-neutron13:00
*** fifieldt has joined #openstack-neutron13:00
*** johnbelamaric has joined #openstack-neutron13:01
*** johnbelamaric has quit IRC13:01
*** johnbelamaric has joined #openstack-neutron13:01
*** numan has joined #openstack-neutron13:02
*** markvoelker has quit IRC13:04
*** dane_leblanc has joined #openstack-neutron13:04
*** anish_ has quit IRC13:05
*** annegentle has quit IRC13:06
*** annegentle has joined #openstack-neutron13:06
*** openstackgerrit has quit IRC13:07
*** openstackgerrit has joined #openstack-neutron13:07
*** numan has quit IRC13:11
*** dims has joined #openstack-neutron13:11
*** rook__ has joined #openstack-neutron13:11
*** cference has joined #openstack-neutron13:12
*** mwagner_lap has joined #openstack-neutron13:12
*** cference has quit IRC13:12
*** pal_ has quit IRC13:12
*** cference_ has joined #openstack-neutron13:12
*** tiswanso has joined #openstack-neutron13:13
*** cference_ has quit IRC13:13
*** a_le has joined #openstack-neutron13:13
*** kbringard has joined #openstack-neutron13:15
*** cference has joined #openstack-neutron13:15
*** rook__ has quit IRC13:17
*** anish_ has joined #openstack-neutron13:17
*** SridharG1 has left #openstack-neutron13:20
*** ZZelle has joined #openstack-neutron13:21
*** numan has joined #openstack-neutron13:23
*** Marga_ has joined #openstack-neutron13:24
flaviof_hi folks. Not sure if this is the best venue to talk about this, but in my latest devstack install (from clean slate) I've been noticing that AMQP has been very flaky: https://gist.github.com/85b6bf571d487ada059713:24
*** Marga_ has quit IRC13:24
*** zhenq has joined #openstack-neutron13:25
*** Marga_ has joined #openstack-neutron13:25
flaviof_I'm trying to find out if this is a known issue; or my erlang/heart is trying to tell me there is something wrong with my localrc. Any feedback is greatly appreciated13:25
flaviof_AMQP server on 192.168.50.20:5672 is unreachable: Too many heartbeats missed. Trying again in 1 seconds.13:25
*** flaviof_ is now known as flaviof13:26
*** lazy_prince has quit IRC13:29
*** neeti has quit IRC13:29
*** rotbeard has quit IRC13:30
ajoflaviof_, recently the AMQP heartbeat patch was introduced to oslo.messaging13:31
ajoflaviof_ not sure if the implementation has any issue or it's just a matter of tweaking the settings?13:31
ajoif there are settings, let me check13:31
*** watanabe_isao has joined #openstack-neutron13:32
flaviofajo: ack. thanks! I saw a link that seems to describe a similar issue online, but there is no answers for it: https://ask.openstack.org/en/question/64590/nova-submodules-cant-connect-to-rabbitmq-server/13:32
*** gsagie has joined #openstack-neutron13:33
*** rotbeard has joined #openstack-neutron13:33
flaviofajo: this is what I get when doing nova-cert:   https://gist.github.com/d87c9783a4512d9a5ab213:33
*** zzzeek has joined #openstack-neutron13:34
*** chandankumar has quit IRC13:34
*** shwetaap has joined #openstack-neutron13:34
gsagieIs there any known problem with the CI tests? my reviews keep failing for unrelated tests (so it seems to me)13:35
*** killer_prince has joined #openstack-neutron13:35
*** killer_prince is now known as lazy_prince13:35
*** dims has quit IRC13:36
*** devvesa has quit IRC13:36
*** devvesa has joined #openstack-neutron13:36
openstackgerritElena Ezhova proposed openstack/neutron: [WIP] Handle SIGHUP: neutron-server (single process mode)  https://review.openstack.org/17090513:36
*** markvoelker has joined #openstack-neutron13:37
*** dims has joined #openstack-neutron13:37
*** baoli_ has quit IRC13:37
*** marrusl has joined #openstack-neutron13:37
*** baoli has joined #openstack-neutron13:37
*** jgrimm is now known as zz_jgrimm13:37
HenryGajo: ping13:38
openstackgerritRomil Gupta proposed openstack/neutron: Vxlan UDP port value should be updated in neutron DB  https://review.openstack.org/15389113:38
*** raildo|away is now known as raildo13:39
HenryGajo: are you OK with https://review.openstack.org/170328 as it is for kilo? I noticed you did not give +113:40
*** zzzeek has quit IRC13:40
ajoHenryG, let me check13:40
*** jckasper has joined #openstack-neutron13:41
ajoHenryG right, patchset change from my last vote, I thought it was voted13:41
*** rushil has joined #openstack-neutron13:41
ajoHenryG, let me check the differences and I will +113:41
mesteryajo: Thanks!13:41
mesteryHenryG: Thank you too!13:41
mesteryOne more off the list as I head into the RC meeting with ttx. :)13:41
HenryGajo: thanks, note a follow-up bug is filed13:41
*** yamamoto has joined #openstack-neutron13:41
ajoHenryG, LGTM, Brian took my last "pedant nit / suggestions" :) thanks haleyb ! ;)13:43
HenryGthanks ajo13:43
haleybyes, i got that bug this morning :(13:43
ajowoops13:43
ajothanks HenryG !13:44
*** ihrachyshka has quit IRC13:44
openstackgerritPavel Bondar proposed openstack/neutron: IPAM reference driver  https://review.openstack.org/15048513:44
*** ihrachyshka has joined #openstack-neutron13:44
*** anish_ has quit IRC13:44
*** cbouch has joined #openstack-neutron13:45
*** lazy_prince has quit IRC13:46
*** roeyc has joined #openstack-neutron13:47
*** zzzeek has joined #openstack-neutron13:49
*** dboik has joined #openstack-neutron13:50
*** irenab has quit IRC13:50
*** chlong has quit IRC13:51
openstackgerritThierry Carrez proposed openstack/neutron: Open Liberty development  https://review.openstack.org/17120013:51
mesteryhaleyb: lol, sorry about that :)13:51
*** emagana has quit IRC13:51
ajomestery, ping, do we have timeslots that "work for everybody" for meetings? I guess not... I'm thinking of the last ML request to offer a "timeslot that works for all" ... ':)13:52
mesteryajo: In a 1:1 with ttx, then neutron meeting, will digest QoS email post that, :)13:52
ajoI guess that's impossible, yet all we can do is maximize the attendance by voting on the time.13:52
ajomestery, ack ack :)13:52
openstackgerritThierry Carrez proposed openstack/neutron-fwaas: Open Liberty development  https://review.openstack.org/17120213:52
haleybmestery: np, it's a low-hanging fruit kind of bug13:53
mesteryhaleyb: Exactly, and thanks for jumping on the ipset bug last week!13:54
*** fawadkhaliq has joined #openstack-neutron13:54
*** nplanel_ has joined #openstack-neutron13:55
*** FJB has joined #openstack-neutron13:55
*** seizadi1 has joined #openstack-neutron13:55
openstackgerritThierry Carrez proposed openstack/neutron-vpnaas: Open Liberty development  https://review.openstack.org/17120613:56
haleybmestery: np, it was actually on my "to do" list since i saw it just a week before13:56
*** marun has joined #openstack-neutron13:57
*** jaypipes has joined #openstack-neutron13:59
*** mlavalle has joined #openstack-neutron13:59
openstackgerritAndrew Boik proposed openstack/neutron: Allow only one IPv4 and one IPv6 fixed IP on router gateway port  https://review.openstack.org/16778413:59
*** marun has quit IRC13:59
*** marun has joined #openstack-neutron14:00
*** nlahouti has joined #openstack-neutron14:00
openstackgerritPavel Bondar proposed openstack/neutron: Implement IPAM Driver loader  https://review.openstack.org/14747914:00
*** nlahouti has quit IRC14:00
openstackgerritAndrew Boik proposed openstack/neutron: Consider all address scopes in init_l3  https://review.openstack.org/16850214:01
openstackgerritPavel Bondar proposed openstack/neutron: Implement IPAM Driver loader  https://review.openstack.org/14747914:01
*** fawadk has joined #openstack-neutron14:01
*** yamahata has joined #openstack-neutron14:02
*** julien_ZTE has joined #openstack-neutron14:02
*** carl_baldwin has joined #openstack-neutron14:02
*** mdavidson has quit IRC14:03
*** psd has joined #openstack-neutron14:03
openstackgerritElena Ezhova proposed openstack/neutron: [WIP] Handle SIGHUP: neutron-server (single process mode)  https://review.openstack.org/17090514:03
openstackgerritEd Bak proposed openstack/neutron: Return from check_ports_exist_on_l3agent if no subnet found  https://review.openstack.org/15428914:03
openstackgerritGal Sagie proposed openstack/neutron: allow OVSDB connection schema to be configurable  https://review.openstack.org/17084214:04
*** suresh12 has joined #openstack-neutron14:04
*** fawadkhaliq has quit IRC14:04
openstackgerritGal Sagie proposed openstack/neutron: Add OVSDB connection as a parameter to the transaction  https://review.openstack.org/17077114:06
*** amuller has joined #openstack-neutron14:06
*** Marga_ has quit IRC14:07
*** julien_ZTE has quit IRC14:07
*** julien_ZTE has joined #openstack-neutron14:07
*** boris-42 has joined #openstack-neutron14:07
sc68calamotoki: for the vlan transparency cleanup, don't we need to remove the vlan attribute from here? https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L84714:08
sc68calI commented as such, and one of the first patchsets did, but subsequent patchsets do not remove that line14:08
*** jorgem has joined #openstack-neutron14:09
amotokisc68cal: thanks for pointing this. I missed that.14:09
amotokisc68cal: checking14:10
*** rook__ has joined #openstack-neutron14:13
*** killer_prince has joined #openstack-neutron14:15
*** killer_prince is now known as lazy_prince14:15
*** seizadi1 has quit IRC14:15
*** tomoe_ has joined #openstack-neutron14:15
*** annegentle has quit IRC14:16
*** jorgem1 has joined #openstack-neutron14:16
*** jorgem1 has quit IRC14:16
*** jorgem1 has joined #openstack-neutron14:17
*** rook__ has quit IRC14:18
*** jorgem has quit IRC14:18
*** signed8bit has joined #openstack-neutron14:19
*** signed8bit is now known as signed8bit_ZZZzz14:19
*** signed8bit_ZZZzz is now known as signed8bit14:19
openstackgerritMerged openstack/python-neutronclient: Add Neutron subnet-create with subnetpool  https://review.openstack.org/16591014:20
*** seizadi has joined #openstack-neutron14:21
*** jobewan has joined #openstack-neutron14:23
*** zz_jgrimm is now known as jgrimm14:23
*** Aish has joined #openstack-neutron14:24
openstackgerritMerged openstack/python-neutronclient: Allow passing None for subnetpool  https://review.openstack.org/16849914:25
*** Sukhdev has joined #openstack-neutron14:25
*** pdb has joined #openstack-neutron14:26
*** jobewan has quit IRC14:26
*** anshul has quit IRC14:26
pdbhi, wondering does anyone know if it's possible to run the openvswitch osvb server on a seperate node and have neutron talk to it via tcp?14:27
*** dboik_ has joined #openstack-neutron14:27
*** amirosh has joined #openstack-neutron14:28
openstackgerritMathieu Rohon proposed openstack/neutron: ML2: Change port status only when it's bound to the host  https://review.openstack.org/16317814:28
*** watanabe_isao has quit IRC14:28
yamamotomarun: ping14:29
marunyamamoto: pong14:29
marunfrom the review, we should be using #!/usr/bin/env bash ?14:29
marunI'm less sure about the version14:30
marunThe main things I've found useful about bash vs sh are arrays and string manipulation.14:30
*** atuvenie has quit IRC14:30
yamamotomarun: can you give me some advice about UT in https://review.openstack.org/#/c/160245/ ?14:30
yamamotomarun: and FT https://review.openstack.org/#/c/164584/14:30
marunyamamoto: do you mean actual unit tests, not just what we pretend are unit tests in neutron?14:31
yamamotoi vaguely remember "env bash" has some problems14:31
*** claudiub has quit IRC14:31
*** dboik has quit IRC14:32
marunyamamoto: invoking scripts ad-hoc, calling 'bash script.sh' will work14:32
yamamotomarun: i don't know the difference between them :-)14:32
*** nfedotov has joined #openstack-neutron14:32
marunyamamoto: I can see a potential problem with things like check_unit_test_structure.sh, though, because it is supposed to be called by tox14:32
yamamotomarun: 'bash script.sh' is the safest way sure14:33
*** aveiga has joined #openstack-neutron14:33
marunyamamoto: should we be invoking in tox.ini, bash 'script'?14:33
*** tsg_ has joined #openstack-neutron14:33
marunyamamoto: i.e. here: https://review.openstack.org/#/c/158811/10/tox.ini14:33
sc68cal+1 for using env bash14:34
*** leenheer has joined #openstack-neutron14:34
marunsc68cal: yamamoto thinks that may have problems14:34
yamamotomarun: yes "bash script.sh" makes me happier14:34
matrohonrossella_s : hi14:35
sc68calmarun: oh?14:35
yamamotomarun: i don't remember what exactly problems are though.14:35
rossella_smatrohon: hi14:35
matrohonrossella_s : I'm back to PS4 on https://review.openstack.org/#/c/163178/14:35
sc68cal/usr/bin/env bash is pretty common for locating bash14:35
*** carl_baldwin has quit IRC14:36
marunI'll update the removal patch to fix bash usage.14:38
marunremoval -> check removal14:38
marunyamamoto: as to unit test vs non-unit tests...14:38
*** devlaps has quit IRC14:38
yamamotosc68cal: it's entirely possible i misremember something.14:38
marunyamamoto: unit tests should be targeting a module in isolation, which implies that the code can be tested largely without mocks14:39
marunyamamoto: most of neutron's 'unit tests' are mock-heavy and actually not unit tests14:39
sc68calyamamoto: no worries, if you happen to recall what it was, do share, I'd be curious to learn more14:39
marunyamamoto: they don't try to isolate functionality under test and attack things like corner cases14:39
marunyamamoto: i.e. they don't provide the kind of comprehensive coverage that unit tests are useful for14:39
openstackgerritGal Sagie proposed openstack/neutron: Add OVSDB connection as a parameter to the transaction  https://review.openstack.org/17077114:39
rossella_smatrohon: I still don't understand why the bugs appear...after the port update by nova the port should be bound correctly right?14:39
openstackgerritJohn Davidge proposed openstack/neutron: Implement Neutron IPv6 Prefix Delegation  https://review.openstack.org/15869714:40
marunyamamoto: does that make sense?14:40
*** carl_baldwin has joined #openstack-neutron14:40
marunyamamoto: I'm assuming some examples would be helpful14:40
marunyamamoto: https://review.openstack.org/#/c/160245/34/neutron/tests/unit/plugins/openvswitch/agent/ovs_ofctl/ovs_bridge_test_base.py14:41
ajoping dougwig :)14:41
ajoare you around?14:41
marunyamahata: so, test_port_drop()14:41
marunoops, sorry yamahata14:41
rossella_smatrohon: what you are fixing is just the interval of time before the port update, right?14:41
marunyamamoto: ^14:42
ajodougwig, if you had time to give me a flavours 101 class, that'd be nice14:42
matrohonrossella_s : you're talking about the bug 1438040?14:42
openstackbug 1438040 in neutron "fdb entries can't be removed when a VM is migrated" [Undecided,In progress] https://launchpad.net/bugs/1438040 - Assigned to Mathieu Rohon (mathieu-rohon)14:42
marunyamamoto: I would expect the code to be structured so that I could call a function that would return me the flows rather than trying to apply them14:43
marunyamamoto: so that mocking wasn't required14:43
matrohonrossella_s : not sure, i'm currently trying to reproduce it14:43
marunyamamoto: and then I could directly look at corner-cases rather than having to inspect secondary interaction14:43
marunyamamoto: does that make sense?14:43
*** shaohe_feng has joined #openstack-neutron14:44
rossella_smatrohon: let me know14:44
yamamotomarun: it makes sense if i write the code from scrach.14:44
marunyamamoto: So you think it's too expensive to refactor for testability?14:44
marunyamamoto: and spend more time writing tests (let alone the cost of reviewing them)?14:45
marunyamamoto: or are you just saying that you've already written them this way14:45
*** lukasa has joined #openstack-neutron14:45
*** amirosh has quit IRC14:45
marunyamamoto: I think the cost of poorly written tests extends beyond their initial implementation, but I'm one of the few that think this way.14:46
yamamotomarun: i just want to avoid refactoring existing ovs_lib code. :-)14:46
marunyamamoto: I don't think you'd have trouble merging the unit tests as-is.14:46
rossella_smatrohon: anyway I think the solution of PS4 it probably the only way. Sorry for all this back and forth14:47
matrohonrossella_s : actually, in l2pop, port info are store in migrated_port only if they are active when the host is changed by nova14:47
*** annegentle has joined #openstack-neutron14:47
marunyamamoto: most reviewers aren't too concerned about how unit tests work, especially given our legacy of bad ones.14:47
yamamotomarun: "merging the unit tests as-is" ?14:47
*** shwetaap has quit IRC14:47
marunyamamoto: i.e. despite my concerns, your approach is in keeping with what is already there, so reviewers other than me won't complain.14:47
matrohonrossella_s : but during a long migration, port status might be set to BUILD when nova send update_port()14:48
*** FJB has quit IRC14:48
matrohonrossella_s : the patch is fixing this race, so that old fdb entry are correctly removed14:48
rossella_smatrohon: got that thanks!14:48
yamamotomarun: i see14:49
yamamotomarun: i'm asking you because you commented about tests on a previous version of the patch14:50
marunyamamoto: You can ignore me14:50
marunyamamoto: What about functional tests?14:50
*** anshul has joined #openstack-neutron14:51
yamamotomarun: i wrote a small functional test but i'm not still sure it's something useful14:51
yamamotomarun: https://review.openstack.org/#/c/164584/14:51
openstackgerritGal Sagie proposed openstack/neutron: allow OVSDB connection schema to be configurable  https://review.openstack.org/17084214:52
openstackgerritGal Sagie proposed openstack/neutron: Add OVSDB connection as a parameter to the transaction  https://review.openstack.org/17077114:52
marunyamamoto: It's a start14:52
marunyamamoto: I would expect to see more, though, given the scale of your proposed change.14:52
marunyamamoto: My goal would be validating flow installation, testing the effect of the flow, and validation of flow removal14:53
*** SridharG1 has joined #openstack-neutron14:53
marunyamamoto: for as many  use cases as are being handled14:53
marunyamamoto: I think the key is focusing on 'capability' as opposed to 'coverage' that is the focus of unit tests14:54
yamamotomarun: do you have an idea how to validate flows?14:54
*** dboik_ has quit IRC14:54
marunyamamoto: wouldn't it be different for each function?14:54
*** fawadk has quit IRC14:54
*** dboik has joined #openstack-neutron14:55
marunyamamoto: e.g. validating setup of a tunnel port may imply validating tunnel connection14:55
marunyamamoto: or maybe it's as simple as making sure the flow is as intended14:55
marunyamamoto: you already do that in unit testing, though14:55
*** shwetaap has joined #openstack-neutron14:55
yamamotomarun: you mean something involving actual packets?14:56
*** jorgem1 has quit IRC14:56
marunyamamoto: that would probably be useful, yes.14:56
marunyamamoto: if we can validate that a given capability (e.g. setting up a tunnel port) works in an isolated functional test, we can understand failures during integration testing much better14:57
*** seizadi has quit IRC14:57
*** numan has quit IRC14:57
marunintegration testing -> multiple openstack services14:57
*** jorgem has joined #openstack-neutron14:58
*** banix has joined #openstack-neutron14:58
*** annegentle has quit IRC14:58
*** atuvenie has joined #openstack-neutron15:00
*** roeyc has quit IRC15:01
openstackgerritPavel Bondar proposed openstack/neutron: Refactor db_base_plugin_v2.py to use new IPAM  https://review.openstack.org/15323615:01
*** annegentle has joined #openstack-neutron15:01
openstackgerritMaru Newby proposed openstack/neutron: Remove check for bash usage  https://review.openstack.org/17093915:02
marunyamamoto: hopefully this makes you less sad? ^15:02
*** emagana has joined #openstack-neutron15:02
* yamamoto looking15:02
*** cbouch has quit IRC15:03
marunihrachyshka: we do specify a minimum tox version, or is that not what you meant?15:03
*** jorgem1 has joined #openstack-neutron15:03
marunihrachyshka: also, I've just updated ps4 :)15:03
*** Sukhdev has quit IRC15:04
amullermatrohon: rossella_s: A semi-related question to what you were discussing: When you add a router port by subnet_id, do you know when in that flow is the port bound to a host? I'm having trouble figuring that out15:05
ihrachyshkamarun, well, we cap it from the bottom, but we don't limit ourselves on max version. I guess yamahata suggested that we should write scripts in some old-enough bash version, *and* be explicit about this version.15:05
*** jorgem has quit IRC15:05
*** anilvenkata has left #openstack-neutron15:06
*** annegent_ has joined #openstack-neutron15:06
amullermatrohon: rossella_s: I thought that the L3 agent hosting the router is notified, at which point it'll attach the port to br-int, OVS agent will find out via the ovs monitor, which will send an update to the plugin, but that method (update_device_up) will see that the port is unbound and do nothing15:06
openstackgerritElena Ezhova proposed openstack/neutron: WIP: Don't monkey patch os.waitpid  https://review.openstack.org/17124415:06
amullerSo I'm missing some step there15:06
*** zhipeng has joined #openstack-neutron15:07
*** annegentle has quit IRC15:07
marunihrachyshka: :/15:07
*** suresh12 has quit IRC15:07
openstackgerritDane LeBlanc proposed openstack/neutron: Re-use context session in ML2 DB get_port_binding_host  https://review.openstack.org/17069015:08
marunihrachyshka: I agree that we shouldn't limit ourselves to an old version.  If/when compat issues arise we can deal with case-by-case.15:08
ihrachyshka+1 to that15:09
yamamotomarun: looks good to me except whitelist.  thank you15:10
marunyamamoto: whitelist?15:10
*** hichihara has quit IRC15:10
*** vivek-ebay has joined #openstack-neutron15:11
*** vivek-ebay has quit IRC15:11
yamamotomarun: commented on review15:11
*** asrangne__ has quit IRC15:12
marunyamamoto: ok15:12
marunyamamoto: as per ihrachyshka'scomment, is it enough to use /usr/bin/env in the check_unit_test_structure.sh?15:13
ihrachyshkamestery, candidate for RC maybe: https://review.openstack.org/#/c/169307/ It's safe and removes a deprecation warning for users.15:13
marunyamamoto: or is explicit use of bash required?15:13
*** ishant has quit IRC15:13
mesteryihrachyshka: +2/+A, seems innocuous enough for the RC, thanks!15:14
*** xgerman has joined #openstack-neutron15:14
matrohonamuller : the port gets bound to the host when the l3agent sent update_port(its_host) to ML215:14
yamamotomarun: one of them should be enough15:14
matrohonamuller : is this related to l3_ha15:15
marunyamamoto: ok15:15
amullermatrohon: kind of, but first I need to understand the basic flow15:15
amullermatrohon: but yeah I'm working on Mike's fix for l3_ha + l2pop15:15
*** signed8bit is now known as signed8bit_ZZZzz15:15
amullermatrohon: thanks I'll look for that update_port in the l3 agent15:15
matrohonamuller : it's pretty messy, but let me elp on that since I already tracked this flow down15:15
openstackgerritMaru Newby proposed openstack/neutron: Remove check for bash usage  https://review.openstack.org/17093915:15
amullermatrohon: do you know where that is in the L3 agent? grep for 'update_port' in the L3 agent folder doesn't find anything15:16
yamamotomarun: how do you think about using ofproto/trace for ovs FTs?  it might be easier than sending real packets15:16
*** vivek-ebay has joined #openstack-neutron15:16
matrohonamuller : https://github.com/openstack/neutron/blob/a3a1b5a5db36df7831d9cb205e8acd266dfd1285/neutron/api/rpc/handlers/l3_rpc.py#L6015:16
*** annegentle has joined #openstack-neutron15:17
*** dannywilson has joined #openstack-neutron15:17
amullermatrohon++15:17
amullermatrohon: thanks15:17
*** annegent_ has quit IRC15:17
matrohonamuller : sync_routers()->_ensure_host_set_on_ports()->_ensure_host_set_on_port()->update_port(binding)15:18
matrohonamuller : you're welcome15:18
*** armax has joined #openstack-neutron15:18
*** jorgem1 has quit IRC15:18
*** signed8bit_ZZZzz is now known as signed8bit15:18
marunyamamoto: I'm not familiar with it, but it sounds promising.15:19
matrohonamuller : do you think you can filter this out, and ensure that only the master node sends update_port(binding)?15:19
*** rushil has quit IRC15:19
*** dannywilson has quit IRC15:19
*** ijw has joined #openstack-neutron15:19
*** dannywilson has joined #openstack-neutron15:19
amullermatrohon: that's interesting, Mike fixed this here: https://review.openstack.org/#/c/141114/14/neutron/plugins/ml2/rpc.py15:19
amullerI'll have to think about this I'm not sure that is correct15:20
amullermatrohon: what you just proposed seems to make more sense?15:20
*** tsg_ has quit IRC15:20
*** rushil has joined #openstack-neutron15:21
matrohonamuller : ideally, now that the control plane knows which host is hosting the master router, it can send update_port accordingly15:21
amullermatrohon: yeah that's already happening15:22
amullermatrohon: check out the other change in that same patch15:22
amullermatrohon: but it's not enough15:22
matrohonamuller : yep, update_port(binding) is sent twice now, from sync_router, and from l3_hamode_db.update_routers_states(), am I wrong?15:23
*** claudiub has joined #openstack-neutron15:24
amullermatrohon: and in the place I linked above, so three times15:24
amullermatrohon: I'll think about this more deeply15:24
matrohonamuller : may be, with your patch, you can disable the call from sync_router if the port is a ha router port...15:24
*** jlibosva has quit IRC15:25
amullermatrohon: updating the host in update_routers_states makes perfect sense to me, just need to make sure that the initial host set on the port is correct15:25
matrohonamuller : ++15:25
*** jorgem has joined #openstack-neutron15:25
amullermatrohon: yeah it's definitely either/or, no point in having it in both places...15:25
*** anshul has quit IRC15:25
amullermatrohon: but maybe it's simpler in sync_router15:25
*** popw has joined #openstack-neutron15:26
matrohonamuller: and filtering if the port is the master one?15:26
amulleryeah15:26
matrohonamuller: why not, but I also feel like there should only be one update_port(binding), the one for the master15:27
*** ajmiller_ has quit IRC15:27
rossella_samuller, matrohon glad you figured all out without me, I am back now but I don't think you need me15:27
*** krtaylor has quit IRC15:28
amullerrossella_s: :)15:29
*** aveiga has quit IRC15:30
*** popw1 has quit IRC15:30
*** nlahouti has joined #openstack-neutron15:30
amullermatrohon: I thought about it and I think it's incorrect to bind the port where Mike put it15:31
amullermatrohon: because the L2 agent RPC handler for update_device_up currently doesn't do port binding in any other case15:32
amullerso it's a mistake to mix it up there15:32
amullerthe port binding should be in sync_routers, just fixed to filter only on the master instance15:32
*** matrohon has quit IRC15:32
*** johnbelamaric has quit IRC15:33
*** johnbelamaric1 has joined #openstack-neutron15:33
*** ajmiller has joined #openstack-neutron15:33
*** amotoki has quit IRC15:34
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Reorganize test tree  https://review.openstack.org/17125615:37
*** anshul has joined #openstack-neutron15:38
pc_mmarun: dougwig: mestery: ^^15:39
marunpc_m: I like your intent, though doing it all in one go is not something I'd encourage.15:40
*** devlaps has joined #openstack-neutron15:40
pc_mmarun: Should I break it into two commits?15:40
*** crose has joined #openstack-neutron15:41
marunpc_m: up to you, really. You have control :)15:41
*** ijw_ has joined #openstack-neutron15:42
marunpc_m: I wasn't expecting *aas to start enforcing the same structural requirement, it may make sense to make the script reusable (via parametization) at some point rather than copying around15:42
marunBut it's fine for now15:42
pc_mmarun: I'll split it into two commits, one for bash change, one for restructuring.15:43
*** popw has quit IRC15:44
*** banix has quit IRC15:44
*** anshul has quit IRC15:44
pc_mmarun: Later we can try to have one check_unit_test_structure.sh script.15:44
marunsounds good15:44
*** ijw has quit IRC15:44
*** kiran has joined #openstack-neutron15:45
*** Longgeek has quit IRC15:45
*** ijw_ has quit IRC15:45
*** ijw has joined #openstack-neutron15:46
*** Marga_ has joined #openstack-neutron15:47
*** yog__ has quit IRC15:48
*** ihrachyshka has quit IRC15:49
*** suresh12 has joined #openstack-neutron15:51
*** suresh12 has quit IRC15:52
*** rotbeard has quit IRC15:52
*** yamamoto has quit IRC15:54
*** _cjones_ has joined #openstack-neutron15:54
*** rangansw has joined #openstack-neutron15:56
*** thomasem has quit IRC15:57
*** shwetaap1 has joined #openstack-neutron15:57
*** devvesa has quit IRC15:58
*** seizadi has joined #openstack-neutron15:59
*** alexpilotti has quit IRC15:59
*** tiswanso has quit IRC15:59
*** emagana has quit IRC15:59
*** yamamoto has joined #openstack-neutron16:00
*** shaohe_feng has quit IRC16:01
*** dboik_ has joined #openstack-neutron16:01
*** tiswanso has joined #openstack-neutron16:01
*** shwetaap has quit IRC16:01
*** YorikSar has quit IRC16:02
*** zhipeng has quit IRC16:02
*** ivar-lazzaro has joined #openstack-neutron16:02
*** yamamoto has quit IRC16:02
*** emagana has joined #openstack-neutron16:03
*** ronis_ has quit IRC16:03
*** dboik has quit IRC16:04
*** lazy_prince has quit IRC16:05
*** vivek-ebay has quit IRC16:06
*** SumitNaiksatam has quit IRC16:06
*** leenheer has quit IRC16:06
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Reorganize test tree  https://review.openstack.org/17125616:07
*** tsg_ has joined #openstack-neutron16:07
*** anshul has joined #openstack-neutron16:07
*** killer_prince has joined #openstack-neutron16:07
*** claudiub has quit IRC16:08
*** killer_prince is now known as lazy_prince16:08
*** alexpilotti has joined #openstack-neutron16:10
*** oreillyd has quit IRC16:11
*** jorgem has quit IRC16:14
*** fawadkhaliq has joined #openstack-neutron16:14
*** rushil has quit IRC16:14
*** rook__ has joined #openstack-neutron16:15
openstackgerritMaru Newby proposed openstack/neutron: Enhance TESTING.rst  https://review.openstack.org/16738416:15
*** afazekas has quit IRC16:16
marunkevinbenton, armax: ^ a minor update, I'm hoping we can defer more comprehensive changes to L16:16
armaxmarun: looking16:16
*** aveiga has joined #openstack-neutron16:17
openstackgerritMaru Newby proposed openstack/neutron: Enhance TESTING.rst  https://review.openstack.org/16738416:17
*** signed8bit has quit IRC16:17
*** Aish has quit IRC16:18
*** banix has joined #openstack-neutron16:19
*** rook__ has quit IRC16:20
*** moshele has quit IRC16:23
prometheanfireijw: ping again?16:23
ijwhey16:23
*** alexpilotti_ has joined #openstack-neutron16:24
ijwThe bug you cited is more of a feature (or a gap in features) and yes, the MTU stuff is supposed to address is16:24
prometheanfireijw: if I start working that linuxbridge mtu bug you think it can get into kilo?16:24
*** alexpilotti has quit IRC16:24
*** alexpilotti_ is now known as alexpilotti16:24
prometheanfirewhen we have a spec like that, shouldn't it hit the 'minimum' required list of plugins?16:24
ijwThe bug you pointed at shoudn't need working with the MTU patch in place so you may want to check the current trunk16:24
prometheanfireis that just ovs, or does that include LB?16:25
*** roeyc has joined #openstack-neutron16:25
ijwprometheanfire: don't open that argument - I think it should but it's now an extension due to a last minute core reviewer objection16:25
ijwCovers both, under ML216:25
prometheanfireok, so HEAD should set mtu on LB?16:25
ijwyup16:26
prometheanfireneat16:26
ijwAnd advertise MTU to VMs16:26
prometheanfireright16:26
ijwWhich was always missing16:26
prometheanfiresaw that patch too :P16:26
*** kickinz1 is now known as kickinz1|afk16:26
*** kawa2014 has quit IRC16:26
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Remove check for bash usage  https://review.openstack.org/17127816:26
prometheanfireso can that bug be closed? or is it valid as a 'direct' LB issue (not going through ML2)16:26
*** jistr has quit IRC16:27
*** anshul has quit IRC16:27
ijwI would close it when you demonstrate to your own satisfaction that thing are actually working correctly16:27
prometheanfireworking correctly is a wide thing to say :P16:27
*** signed8bit has joined #openstack-neutron16:28
pc_mmestery: ping16:28
mesterypc_m: pong16:28
*** signed8bit is now known as signed8bit_ZZZzz16:28
ijwpc_m, mestery: ping16:29
mesteryijw: pong16:29
pc_mmestery: I created bug https://bugs.launchpad.net/neutron/+bug/1441244 to do bash change, similar to Neutron.16:29
openstackLaunchpad bug 1441244 in neutron "VPNaaS: Remove check for bash scripts" [Undecided,In progress] - Assigned to Paul Michali (pcm)16:29
pc_mijw: pong16:30
ijwpc_m, mestery: ping16:30
prometheanfirelol16:30
*** signed8bit_ZZZzz is now known as signed8bit16:30
ijwI can keep this up all day, you know16:30
pc_mijw: I was trying to get ahold of him16:31
mesterypc_m: Seems reasonable16:31
mesterylol16:31
prometheanfireijw: I see no code in linuxbridge directly, so I'm guessing mtu cannot be set when using LB without ML216:31
ijwpc_m: careless16:31
ijwprometheanfire: test it16:31
pc_mmestery: I have that change, and the one to reorg vpn, up for review.16:31
*** seizadi has quit IRC16:31
prometheanfireright, one thing at a time though :P16:31
mesteryprometheanfire: The LB plugin doesn't exist anymore, you can't use it without ML2 in Kilo.16:31
ijwIt should work, I'm not sure you actually have to set the MTU on the bridge16:31
*** jorgem has joined #openstack-neutron16:31
prometheanfireoh, that helps16:31
ijwI can check, anyway16:31
prometheanfireijw: if you could that would be awesome, I don't have the setup to do so16:32
pc_mmestery: I used the same bug, on the restructuring, as I think that bug is still open.16:32
mesteryprometheanfire: You should note the LB agent is not in good shape at the moment. /cc sc68cal16:32
mesterypc_m: Makes sense16:32
pc_mmestery: Can you disposition the bug as needed (I'm assuming this wants to get in quickly)?16:32
prometheanfiremestery: I know, is there a list of things that need to be fixed to bring it up to par with OVS and the like?16:32
mesteryprometheanfire: Not yet, sc68cal is working on that.16:32
pc_mmestery: What should happen with https://bugs.launchpad.net/neutron/+bug/1438259 w.r.t. Kilo? I had it out for review, before the reorg. Will likely need to rebase, due to the Neutron changes.16:34
openstackLaunchpad bug 1438259 in neutron "VPNaaS: remove dependency on Neutron in UT" [Undecided,In progress] - Assigned to Paul Michali (pcm)16:34
*** fawadkhaliq has quit IRC16:34
*** rangansw has quit IRC16:34
prometheanfiresc68cal: if you don't mind, can you ping me with the list of LB deficiencies when you have them (or give me the tracking bug)?16:34
mesterypc_m: That one lets leave for Liberty16:35
pc_mmestery: ok16:35
*** pritesh has joined #openstack-neutron16:36
*** yatin has joined #openstack-neutron16:36
*** Marga_ has quit IRC16:38
*** Marga_ has joined #openstack-neutron16:38
*** anshul has joined #openstack-neutron16:39
*** devlaps has quit IRC16:39
ijwprometheanfire: I've pinged someone, we'll see what I find out.  You're using LB and what network protocol?16:40
ijwsc68cal: me too16:41
*** jorgem has quit IRC16:42
*** Marga_ has quit IRC16:43
*** ankit_ag has quit IRC16:44
*** ygbo has quit IRC16:44
*** jobewan has joined #openstack-neutron16:47
*** Marga_ has joined #openstack-neutron16:49
*** anish_ has joined #openstack-neutron16:50
*** lukasa_work has joined #openstack-neutron16:50
*** vivek-ebay has joined #openstack-neutron16:50
*** lazy_prince has quit IRC16:51
*** lukasa has quit IRC16:53
*** anshul has quit IRC16:54
*** _kiran_ has joined #openstack-neutron16:54
*** krtaylor has joined #openstack-neutron16:54
*** aix has quit IRC16:55
*** carl_baldwin has quit IRC16:56
*** kiran has quit IRC16:57
*** dave-mccowan has quit IRC16:58
*** YorikSar has joined #openstack-neutron16:58
*** fawadkhaliq has joined #openstack-neutron16:58
*** Aish has joined #openstack-neutron16:59
*** fawadk has joined #openstack-neutron16:59
*** mlavalle has quit IRC17:01
*** nfedotov has quit IRC17:01
*** _kiran_ has quit IRC17:01
*** kiran has joined #openstack-neutron17:01
*** roeyc has quit IRC17:02
*** fawadkhaliq has quit IRC17:03
*** tsg_ has quit IRC17:04
openstackgerritstephen-ma proposed openstack/neutron: Router is not unscheduled when the last VM is deleted  https://review.openstack.org/15929617:05
*** moha_hunt has joined #openstack-neutron17:05
*** dboik_ has quit IRC17:06
*** dboik has joined #openstack-neutron17:06
dougwigajo: good morning17:06
*** dboik has quit IRC17:07
*** kiran has quit IRC17:07
*** dboik has joined #openstack-neutron17:07
*** arosen has joined #openstack-neutron17:08
*** tiswanso has quit IRC17:08
*** tiswanso_ has joined #openstack-neutron17:09
*** yamamoto has joined #openstack-neutron17:09
*** yamamoto has quit IRC17:10
*** moshele has joined #openstack-neutron17:10
*** aepifanov1 has joined #openstack-neutron17:11
*** a_le has quit IRC17:12
*** crose has quit IRC17:12
*** aepifanov has quit IRC17:12
*** rotbeard has joined #openstack-neutron17:12
*** _cjones_ has quit IRC17:13
*** leenheer has joined #openstack-neutron17:13
*** aepifanov1 has quit IRC17:14
*** aepifanov has joined #openstack-neutron17:14
*** yamamoto has joined #openstack-neutron17:16
*** rook__ has joined #openstack-neutron17:16
openstackgerritZengfa Gao proposed openstack/python-neutronclient: Add Neutron subnetpool API  https://review.openstack.org/15961817:17
*** _cjones_ has joined #openstack-neutron17:18
*** aepifanov has quit IRC17:18
*** claudiub has joined #openstack-neutron17:19
*** rook__ has quit IRC17:21
*** ronis_ has joined #openstack-neutron17:22
*** anish_ has quit IRC17:22
*** psd has quit IRC17:23
*** dboik has quit IRC17:23
*** sbfox has joined #openstack-neutron17:23
*** safchain has quit IRC17:24
*** dave-mccowan has joined #openstack-neutron17:26
*** dsneddon has joined #openstack-neutron17:26
*** Sukhdev has joined #openstack-neutron17:26
*** nlahouti has quit IRC17:27
*** annegentle has quit IRC17:27
*** annegentle has joined #openstack-neutron17:27
*** yamahata has quit IRC17:28
*** jpena is now known as jpena|away17:28
*** suresh12 has joined #openstack-neutron17:29
*** angela-s has joined #openstack-neutron17:30
*** harlowja_away is now known as harlowja17:31
*** annegent_ has joined #openstack-neutron17:31
*** rushil has joined #openstack-neutron17:31
*** annegentle has quit IRC17:32
*** nlahouti has joined #openstack-neutron17:34
*** pritesh has quit IRC17:35
*** pritesh has joined #openstack-neutron17:36
*** Akanksha08 has joined #openstack-neutron17:36
openstackgerritpritesh proposed openstack/neutron: Moving VLAN Transparency support from core to extension  https://review.openstack.org/16956917:36
*** s3wong has joined #openstack-neutron17:36
*** achanda has joined #openstack-neutron17:36
*** dboik has joined #openstack-neutron17:38
*** gsagie_ has joined #openstack-neutron17:38
openstackgerritGal Sagie proposed openstack/neutron: Add OVSDB connection as a parameter to the transaction  https://review.openstack.org/17077117:39
*** pritesh has quit IRC17:40
*** yatin has quit IRC17:42
*** bobmel has quit IRC17:42
*** ajmiller_ has joined #openstack-neutron17:43
*** sicrano has quit IRC17:44
*** bishtsanddev has joined #openstack-neutron17:44
*** atuvenie has quit IRC17:44
openstackgerritGal Sagie proposed openstack/neutron: allow OVSDB connection schema to be configurable  https://review.openstack.org/17084217:47
*** ajmiller has quit IRC17:47
*** claudiub has quit IRC17:51
*** dboik has quit IRC17:53
*** sicrano has joined #openstack-neutron17:54
amulleremagana: Hey Edgar, do we have any 'new contributors' documentation, something from the upstream openstack courses for example? I could only find https://wiki.openstack.org/wiki/How_To_Contribute#If_you.27re_a_developer and it's really lackluster17:54
*** sicrano has quit IRC17:54
*** sicrano has joined #openstack-neutron17:55
emaganaamuller: https://wiki.openstack.org/wiki/Documentation/HowTo#Edit_OpenStack_RST_and.2For_DocBook_documentation17:55
emaganaamuller: https://wiki.openstack.org/wiki/Documentation/Markup_conventions17:55
emaganaamuller: Is that what you are looking for?17:56
amulleremagana: I'm looking for documents that would help us onboard new contributors17:56
amulleremagana: If I could just point people to something they could read to get them started, like a list of materials you should get to know if you want to work on OpenStack17:57
emaganaamuller: as developers, the best source will be:17:57
amullerlike: If you're new to Python, he's a list of good materials to learn it from17:57
amullerthen work from there...17:57
emaganaamuller: https://wiki.openstack.org/wiki/NeutronDevelopment17:57
emaganaamuller: http://docs.openstack.org/infra/manual/developers.html17:57
*** ivar-lazzaro has quit IRC17:58
*** fawadk has quit IRC17:58
emaganaamuller: https://wiki.openstack.org/wiki/How_To_Contribute17:58
*** jorgem has joined #openstack-neutron17:58
*** jorgem has quit IRC17:58
emaganaon the python side, well there a few books out there... one that is close to OpenStack is:17:58
amulleremagana: I see that the NeutronDevelopment wiki article was updated a bit since last time I looked17:59
*** pritesh has joined #openstack-neutron17:59
*** nmagnezi has joined #openstack-neutron17:59
annegent_amuller: there's https://github.com/openstack/training-guides/tree/master/doc/upstream-training for the upstream training17:59
*** dboik has joined #openstack-neutron18:00
annegent_amuller: emagana: It's not neutron specific to my knowledge18:00
*** fawadkhaliq has joined #openstack-neutron18:00
*** afazekas has joined #openstack-neutron18:00
*** jlk has left #openstack-neutron18:01
*** jamielennox|away is now known as jamielennox18:01
emaganaamuller: I like this book for new contributors: https://julien.danjou.info/books/the-hacker-guide-to-python18:01
*** yamamoto has quit IRC18:02
emaganaamuller: and obiously dev docs in the neutron tree18:02
amulleremagana: haven't read that one18:02
*** absubram has joined #openstack-neutron18:04
amulleremagana: I always recommend this: http://www.diveintopython.net/ for the basics, then this: https://www.youtube.com/watch?v=OSGv2VnC0go18:05
amullerwhen I onboard people at Red Hat18:05
*** dane_leblanc has quit IRC18:05
emaganaamuller: will take a look!18:05
Akanksha08Hi folks!18:08
*** yamahata has joined #openstack-neutron18:08
*** tongli has joined #openstack-neutron18:08
Akanksha08I am a new contributor to OpenStack and would like to contribute to neutron18:09
Akanksha08I am working on this https://bugs.launchpad.net/neutron/+bug/125498418:09
openstackLaunchpad bug 1254984 in neutron "spawn_n swallows exceptions in l3_agent " [Low,In progress] - Assigned to Akanksha (akanksha-aha)18:09
*** gsagie_ has quit IRC18:10
*** lukasa_work has quit IRC18:11
Akanksha08Someone has already worked on it. So should I just work on improving the solution already given by the one who worked on this18:11
*** tomoe_ has quit IRC18:12
amullerAkanksha08: I don't think so, the code changed a lot since November of 201318:12
Akanksha08okay18:12
prometheanfireijw: vxlan18:12
amullerAkanksha08: because of that I would start a new patch, but generally yes you would coordinate with the original author18:12
Akanksha08okay18:12
ijwYeah, I've done that but I admit I've not had a chance to do that with the new code yet18:12
prometheanfireijw:  might be able to test18:12
ijwprometheanfire: cool18:13
prometheanfireusing the os-ansible stuff, it deploys with ml2/vxlan iirc18:13
prometheanfirejust needs an edit to add the mtu settings18:13
Akanksha08Thanks amuller18:13
prometheanfirealso, master needs to work18:13
amullerAkanksha08: sure thing, feel free to add me as a reviewer to your patch I have some experience there18:13
Akanksha08I was trying to find any other low-hanging fruit but couldn't18:13
Akanksha08amuller, yes sure I will18:14
amullerAkanksha08: And I'd probably get familiar with the L3 agent functional tests: neutron/tests/functional/agent/test_l3_agent18:14
amullerAkanksha08: Yes I don't think we have much if any unassigned low hanging fruit18:14
amullerat this time18:14
Akanksha08yes I didn't find any18:14
amullerBut there's loads to do18:14
*** dane_leblanc has joined #openstack-neutron18:14
Akanksha08So in the mean time I contributed to zaqar18:15
Akanksha08I have applied for neutron project as a prt of OPW18:15
Akanksha08part*18:15
*** leenheer has quit IRC18:15
amullerAkanksha08: What is OPW? Not familiar with that18:16
*** leenheer has joined #openstack-neutron18:16
Akanksha08Outreachy now former Outreach Program for Women18:16
*** gsagie_ has joined #openstack-neutron18:16
Akanksha08amuller, https://gnome.org/outreachy/18:17
*** Zemeio has quit IRC18:17
amullerAkanksha08: Ahh that's interesting18:17
*** rook__ has joined #openstack-neutron18:18
Akanksha08amuller, yes I am waiting for the results :)18:18
Akanksha08Till then I will keep contributing and learning18:18
*** shwetaap1 has quit IRC18:19
*** Zemeio has joined #openstack-neutron18:19
openstackgerritEdgar Magana proposed openstack/neutron: Add missing config parameters in neutron.conf  https://review.openstack.org/17105918:21
*** leenheer has quit IRC18:22
*** rook__ has quit IRC18:23
*** afazekas has quit IRC18:24
*** srampal has joined #openstack-neutron18:24
*** doude has quit IRC18:25
*** luqas has quit IRC18:26
*** mlavalle has joined #openstack-neutron18:27
openstackgerritMerged openstack/neutron: Fix dynamic arp populate error for dvr routers  https://review.openstack.org/17032318:28
Akanksha08Hi bishtsanddev18:30
*** nmagnezi has quit IRC18:30
bishtsanddevAkanksh08: Hi18:30
Akanksha08yes so for contributing first you need to follow http://docs.openstack.org/infra/manual/developers.html18:31
Akanksha08All the steps are nicely documented there18:32
Akanksha08I followed the same18:32
bishtsanddevOk will go through all the steps provided in channel.18:33
*** fawadkhaliq has quit IRC18:33
Akanksha08bishtsanddev, let me know if you face any issues. Would be glad if I could help :)18:33
bishtsanddevOfcourse, i am really new. I need lots of help from you guys.18:35
*** carl_baldwin has joined #openstack-neutron18:35
*** shwetaap has joined #openstack-neutron18:37
*** yamahata has quit IRC18:38
*** kickinz1|afk is now known as kickinz118:38
*** leenheer has joined #openstack-neutron18:38
openstackgerritMerged openstack/neutron: Stop using deprecated DEFAULT group for lock_path  https://review.openstack.org/16930718:38
*** gsagie_ has quit IRC18:39
Akanksha08bishtsanddev, No problem we would love to help you!18:42
*** seizadi has joined #openstack-neutron18:42
rushilHey. Does anyone know what is the range of segmentation id ranges supported by GRE?18:43
*** ajmiller has joined #openstack-neutron18:44
*** ajmiller_ has quit IRC18:44
*** signed8bit is now known as signed8bit_ZZZzz18:44
*** tiswanso_ has quit IRC18:44
*** yamahata has joined #openstack-neutron18:44
*** pritesh_ has joined #openstack-neutron18:47
openstackgerritArvind Somya proposed openstack/neutron: Model and migration for cisco providernet extension driver  https://review.openstack.org/17132618:47
*** lukasa has joined #openstack-neutron18:49
*** leenheer has quit IRC18:49
*** Akanksha08 has quit IRC18:51
*** pritesh has quit IRC18:51
*** ijw has quit IRC18:53
*** lukasa has quit IRC18:54
*** signed8bit_ZZZzz is now known as signed8bit18:55
*** tiswanso has joined #openstack-neutron18:56
*** annegent_ has quit IRC18:56
*** john-davidge has quit IRC18:57
*** annegentle has joined #openstack-neutron18:57
*** tflynn has joined #openstack-neutron19:00
pc_mmarun: mestery: dougwig: Jenkins passed on the VPN UT restructure. Can you kindly review https://review.openstack.org/#/c/171256?19:00
*** enikanorov has quit IRC19:01
*** fawadkhaliq has joined #openstack-neutron19:01
*** matrohon has joined #openstack-neutron19:02
*** doude has joined #openstack-neutron19:03
*** dane_leblanc has quit IRC19:03
*** bishtsanddev has left #openstack-neutron19:04
*** Marga_ has quit IRC19:04
*** rpothier has quit IRC19:04
*** jistr has joined #openstack-neutron19:07
*** tflynn has quit IRC19:11
*** rpothier has joined #openstack-neutron19:12
*** annegent_ has joined #openstack-neutron19:12
*** carl_baldwin has quit IRC19:13
*** annegentle has quit IRC19:13
*** suresh12 has quit IRC19:13
*** dboik has quit IRC19:14
*** suresh12 has joined #openstack-neutron19:14
*** dane_leblanc has joined #openstack-neutron19:14
*** srampal has quit IRC19:15
openstackgerritDane LeBlanc proposed openstack/neutron: Re-use context session in ML2 DB get_port_binding_host  https://review.openstack.org/17069019:15
*** annegent_ has quit IRC19:17
*** doude has quit IRC19:17
*** annegentle has joined #openstack-neutron19:18
*** suresh12 has quit IRC19:18
*** igordcard_ has joined #openstack-neutron19:19
*** rook__ has joined #openstack-neutron19:19
*** aepifanov has joined #openstack-neutron19:21
*** pritesh has joined #openstack-neutron19:22
*** openstackgerrit has quit IRC19:22
*** openstackgerrit has joined #openstack-neutron19:23
*** pritesh_ has quit IRC19:23
*** rook__ has quit IRC19:24
baoliamuller: ping, RE: https://review.openstack.org/#/c/167339/19:24
*** achanda has quit IRC19:25
amullerbaoli: heya19:26
*** psd has joined #openstack-neutron19:26
*** Sukhdev has quit IRC19:26
*** luqas has joined #openstack-neutron19:26
*** leenheer has joined #openstack-neutron19:26
*** jpena|away has quit IRC19:27
amullerbaoli: it's just really weird because I didn't hit that issue on both my Ubuntu and Fedora VMs, let me look at your latest comment19:28
*** suresh12 has joined #openstack-neutron19:28
baoliamuller: can you check where the utility is installed on your system? With devstack, it's always installed at /usr/local/bin19:29
baoliamuller: another question is do we have support in devstack in setting up l3_ha, and networks, etc?19:30
openstackgerritSlawek Kaplonski proposed openstack/neutron-specs: fwaas rules directions  https://review.openstack.org/17134019:30
baoliamuller: I have to make some change in devstack in order to run ha19:30
amullerbaoli: ok so I use the functional tests on my Ubuntu VM successfully but there the rootwrap configuration is different19:31
*** luqas has quit IRC19:31
amullerbaoli: on my Fedora VMs that run devstack for L3 HA neutron-keepalived-state-change is installed in /usr/bin, not /usr/local/bin19:31
*** harlowja is now known as harlowja_away19:31
amullerbaoli: but the correct fix is to modify rootwrap.conf19:31
amullernot amend every single process19:32
baoliamuller: I thought about that too, but saw that metadata proxy does the same. But if you prefer, we can go that route.19:32
amullerbaoli: yeah it's wrong for metadata proxy... If whoever added that just modified rootwrap.conf you wouldn't have this issue19:33
amullerso let's save the next guy some time19:33
baoliamuller: agreed19:33
amullerbaoli: There is no devstack macro for l3_ha, but the only modification you need to make is to flip l3_ha to True in neutron.conf on your controller19:33
baoliamuller: I'll make that change then. Also I'd remove the local entry for metadata_proxy. Does that sound good to you?19:34
amullerbaoli: That would go in another patch though of course19:34
baoliamuller: so you are saying to make a cleanup patch for metadata_proxy. That's fine with me too.19:34
*** sbfox has quit IRC19:36
*** atuvenie has joined #openstack-neutron19:37
*** achanda has joined #openstack-neutron19:37
*** harlowja_away is now known as harlowja19:37
amullerbaoli: you can add this to your local.conf19:38
amullerhttp://paste.openstack.org/19:38
amullererr19:38
amullerhttp://paste.openstack.org/show/199763/19:38
amullerthat should set l3_ha for you during stack.sh19:38
amulleror you can just set it after stack.sh finishes19:39
baoliamuller: yeah, that would do.19:39
*** psd has quit IRC19:40
baoliamuller: in devstack, it creates initial networks and a router. With l3_ha turned on, the controller stack.sh would bail out while creating the router and complains that at least two l3 agents should be available.19:41
*** chandankumar has joined #openstack-neutron19:41
baoliamuller: how do you overcome that problem?19:41
amullerbaoli: I turn l3_ha on after stack.sh finishes19:41
amullerand my VMs with the l3_agent have registered19:41
*** psd has joined #openstack-neutron19:41
*** catohornet has joined #openstack-neutron19:41
*** tflynn has joined #openstack-neutron19:42
baoliamuller, so you'd have to restart neutron services?19:42
amullerbaoli: yeah19:42
*** tsg has joined #openstack-neutron19:42
amulleror you can turn off the devstack feature that creates a demo network/subnet/router for you19:42
openstackgerritpritesh proposed openstack/neutron: Moving VLAN Transparency support from core to extension  https://review.openstack.org/16956919:42
baoliamuller: that's what I did19:43
baoliamuller: would it be nice to take the neutron "create initial network" out of the devstack neutron script, and make it independent?19:45
amullerbaoli: how do you mean make it independent? Require the user to run it manually?19:45
*** johnbelamaric1 has quit IRC19:45
baoliamuller: it runs by default, but if one prefer, it can be run manually after stack.sh.19:46
baoliamuller, in the case of l3_ha, one can run it after all the devstack nodes are up19:46
amullerbaoli: I don't know if the devstack maintainers would see the need for it but you can try19:47
*** achanda has quit IRC19:47
amullerI think it's easy to create a network/subnet/router triplet anyway19:47
baoliamuller, it would just make it easy for someone to try the l3 ha, I think19:47
amullerbaoli: that person would have to know to manually change the bit that makes that script not run though19:48
baoliamuller: this would be part of your ha wiki.19:48
amullerbaoli: I haven't updated that in a while19:49
amullerprobably should19:49
amullerbaoli: I'm preparing a blog post about bp/report-ha-router-master sometime soon hopefully19:49
baoliamuller, cool19:50
baoliamuller, if you think that the devstack change would be useful, I'd like to propose it. Otherwise, I can just put it aside.19:50
amullerbaoli: Go for it19:51
baoliamuller: cool. I'll give it a shot.19:52
*** busterswt has joined #openstack-neutron19:52
baoliamuller: thanks. Will update the patch sometime soon19:52
*** jistr has quit IRC19:55
*** _cjones_ has quit IRC19:55
*** _cjones_ has joined #openstack-neutron19:55
*** britthou_ has joined #openstack-neutron19:56
*** melwitt has joined #openstack-neutron19:57
*** cference has quit IRC19:58
*** britthouser has quit IRC19:58
*** tflynn_ has joined #openstack-neutron19:58
*** annegent_ has joined #openstack-neutron19:59
*** tflynn has quit IRC20:00
*** tflynn has joined #openstack-neutron20:00
*** ijw has joined #openstack-neutron20:01
*** tsg has quit IRC20:01
*** moha_hunt has quit IRC20:02
*** tiswanso has quit IRC20:02
*** annegentle has quit IRC20:02
openstackgerritSanjeev Rampal proposed openstack/neutron: Improves the  description string for the config parameter metadata_workers. This will get extracted into the documentation automatically  https://review.openstack.org/17102620:03
*** jmeridth has quit IRC20:03
*** tiswanso has joined #openstack-neutron20:03
*** johnbelamaric has joined #openstack-neutron20:04
*** tflynn_ has quit IRC20:04
*** tsg has joined #openstack-neutron20:05
*** tflynn has quit IRC20:05
*** chandankumar has quit IRC20:06
*** moha_hunt has joined #openstack-neutron20:07
openstackgerritBaodong (Robert) Li proposed openstack/neutron: Add /usr/local/bin in exec_dirs  https://review.openstack.org/16733920:13
*** pritesh has quit IRC20:13
*** signed8bit is now known as signed8bit_ZZZzz20:15
*** signed8bit_ZZZzz is now known as signed8bit20:16
openstackgerritMathieu Rohon proposed openstack/neutron: ML2: Change port status only when it's bound to the host  https://review.openstack.org/16317820:17
*** rpothier has quit IRC20:18
openstackgerritBaodong (Robert) Li proposed openstack/neutron: remove metadata_proxy_local filters for rootwrap  https://review.openstack.org/17135420:18
openstackgerritKevin Benton proposed openstack/neutron: Add simple ARP spoofing protection  https://review.openstack.org/17100320:20
*** rook__ has joined #openstack-neutron20:20
*** busterswt has quit IRC20:20
*** bjornar_ has joined #openstack-neutron20:21
*** carl_baldwin has joined #openstack-neutron20:21
*** jmeridth has joined #openstack-neutron20:23
*** johnbelamaric has quit IRC20:23
*** rook__ has quit IRC20:25
*** vivek-ebay has quit IRC20:26
*** atuvenie has quit IRC20:27
*** tongli has quit IRC20:28
*** achanda has joined #openstack-neutron20:29
*** tsg_ has joined #openstack-neutron20:29
*** tsg has quit IRC20:30
*** tgohad has joined #openstack-neutron20:31
*** melwitt has quit IRC20:31
*** fawadkhaliq has quit IRC20:32
*** dboik has joined #openstack-neutron20:32
*** melwitt has joined #openstack-neutron20:32
*** psd has quit IRC20:33
*** psd has joined #openstack-neutron20:33
*** tsg_ has quit IRC20:33
*** alex_xu has quit IRC20:34
*** heyongli has quit IRC20:36
*** claudiub has joined #openstack-neutron20:41
*** igordcard_ has quit IRC20:47
*** melwitt has quit IRC20:50
*** Marga_ has joined #openstack-neutron20:50
*** johnbelamaric has joined #openstack-neutron20:51
*** melwitt has joined #openstack-neutron20:51
*** rangansw has joined #openstack-neutron20:53
*** ivar-lazzaro has joined #openstack-neutron20:54
*** pc_m has quit IRC20:55
*** pritesh has joined #openstack-neutron20:56
*** _cjones_ has quit IRC20:58
*** seizadi has quit IRC20:59
*** raildo is now known as raildo|away20:59
*** seizadi has joined #openstack-neutron20:59
*** bjornar_ has quit IRC21:03
*** johnbelamaric has quit IRC21:03
*** ociuhandu has quit IRC21:06
*** fifieldt has quit IRC21:08
*** matrohon has quit IRC21:08
*** johnbelamaric has joined #openstack-neutron21:09
*** atuvenie has joined #openstack-neutron21:09
*** aepifanov has quit IRC21:10
*** annegent_ has quit IRC21:13
*** SridharG2 has joined #openstack-neutron21:15
*** tiswanso has quit IRC21:15
*** SridharG1 has quit IRC21:16
*** _cjones_ has joined #openstack-neutron21:16
*** psd has quit IRC21:17
priteshsalv-orlando: ping21:17
*** SridharG2 has left #openstack-neutron21:18
*** kickinz1 is now known as kickinz1|afk21:19
*** moha_hunt has quit IRC21:20
*** fifieldt has joined #openstack-neutron21:21
*** rook__ has joined #openstack-neutron21:21
*** signed8bit has quit IRC21:23
*** chlong has joined #openstack-neutron21:25
*** rook__ has quit IRC21:25
openstackgerritMerged openstack/neutron: Remove check for bash usage  https://review.openstack.org/17093921:26
*** vivek-ebay has joined #openstack-neutron21:27
*** annegentle has joined #openstack-neutron21:28
*** luqas has joined #openstack-neutron21:29
*** leenheer has quit IRC21:29
*** vivek-eb_ has joined #openstack-neutron21:30
*** Marga_ has quit IRC21:31
*** vivek-ebay has quit IRC21:31
*** Marga_ has joined #openstack-neutron21:31
*** rotbeard has quit IRC21:31
*** ijw has quit IRC21:33
*** luqas has quit IRC21:33
*** ijw has joined #openstack-neutron21:34
*** marun has quit IRC21:35
*** atuvenie has quit IRC21:35
*** YorikSar has quit IRC21:36
*** marun has joined #openstack-neutron21:36
*** smccully has quit IRC21:37
*** dboik_ has joined #openstack-neutron21:37
*** openstackgerrit has quit IRC21:37
*** johnbelamaric has quit IRC21:37
*** openstackgerrit has joined #openstack-neutron21:38
openstackgerritSridhar Gaddam proposed openstack/neutron: Add sanity_check for keepalived ipv6 support  https://review.openstack.org/16878121:39
*** banix has quit IRC21:40
*** dboik has quit IRC21:41
*** dboik_ has quit IRC21:41
*** rpothier has joined #openstack-neutron21:44
*** melwitt has quit IRC21:45
*** melwitt has joined #openstack-neutron21:45
*** psd has joined #openstack-neutron21:47
*** leenheer has joined #openstack-neutron21:47
*** ijw has quit IRC21:49
*** ijw has joined #openstack-neutron21:49
*** sbfox has joined #openstack-neutron21:54
*** ijw_ has joined #openstack-neutron21:55
*** ijw has quit IRC21:59
*** moshele has quit IRC22:01
*** Marga_ has quit IRC22:01
*** Marga_ has joined #openstack-neutron22:02
*** leenheer has quit IRC22:03
*** jckasper has quit IRC22:03
*** mwagner_lap has quit IRC22:04
*** rpothier has left #openstack-neutron22:05
*** absubram has quit IRC22:06
*** mestery has quit IRC22:11
*** mestery has joined #openstack-neutron22:12
*** kbringard has quit IRC22:12
*** alexpilotti has quit IRC22:12
*** alexpilotti has joined #openstack-neutron22:13
*** xgerman has quit IRC22:13
*** alexpilotti has quit IRC22:14
*** seizadi has quit IRC22:14
*** seizadi has joined #openstack-neutron22:14
prometheanfireijw_: ok, tested, neutron pieces work, but the linuxbridge angent on the nova compute host doesn't set the mtu22:15
ijw_prometheanfire: does that cause a problem?22:15
*** xgerman has joined #openstack-neutron22:15
prometheanfireit means guests can't use the larger mtu22:15
prometheanfireI haven't checked nova config for mtu stuff though22:15
*** seizadi has quit IRC22:19
*** psd has quit IRC22:19
openstackgerritMerged openstack/neutron: Enhance TESTING.rst  https://review.openstack.org/16738422:19
ijw_prometheanfire: you've confirmed that packets drop?  I'm not sure if LB respects its MTU setting22:21
*** igordcard_ has joined #openstack-neutron22:21
prometheanfirethe tap/bridge on the neutron-agent server side stuff is set properly22:22
*** rook__ has joined #openstack-neutron22:22
prometheanfirethe tap/bridge on the nova compute host running linuxbridge-agent doesn't have it's mtu set at all22:22
*** Sam-I-Am has joined #openstack-neutron22:23
*** Sam-I-Am has left #openstack-neutron22:24
*** dkehn has quit IRC22:25
*** Sam-I-Am has joined #openstack-neutron22:26
prometheanfireSam-I-Am: hi22:26
Sam-I-Amhowdy22:26
*** rook__ has quit IRC22:26
prometheanfireSam-I-Am: wanna try that patch from the email?22:26
prometheanfireSam-I-Am: or maybe set the mtu manually, just to see if it works everwhere else (just for this instance)22:27
Sam-I-Amwhich?22:27
prometheanfirewhich what?22:27
Sam-I-Ampatch email?22:27
*** marun has quit IRC22:27
*** rangansw has quit IRC22:27
*** rangansw has joined #openstack-neutron22:27
prometheanfirethe one from james, included in claco's email22:28
prometheanfireSam-I-Am: for now I have to go though, might pick it up in the morning if that sounds right22:28
prometheanfirewell, going home/food now22:29
Sam-I-Amk22:29
Sam-I-Ami gotta run too :/22:29
*** annegentle has quit IRC22:29
*** annegentle has joined #openstack-neutron22:30
*** dims_ has joined #openstack-neutron22:30
*** dims_ has quit IRC22:30
*** dims_ has joined #openstack-neutron22:31
*** ijw_ has quit IRC22:31
*** ijw has joined #openstack-neutron22:32
*** lori is now known as lori|away22:32
*** Marga_ has quit IRC22:32
ijwprometheanfire: So MTUs aren't set, but what I said still applies - are you  seeing dropped packets?22:32
openstackgerritKevin Benton proposed openstack/neutron: Add simple ARP spoofing protection  https://review.openstack.org/17100322:32
*** Marga_ has joined #openstack-neutron22:33
ijwkevinbenton: does that work with the portsecurity extension that was added to ML2?22:34
*** dims has quit IRC22:34
kevinbentonijw: what does the portsecurity extension allow?22:35
kevinbentonijw: or what did it do?22:35
ijwdisabling of port security - specifically, groups, mac and address spoofing22:35
*** boris-42 has quit IRC22:38
*** zhenq has quit IRC22:38
*** dkehn has joined #openstack-neutron22:38
kevinbentonijw: can a tenant do that to their own port?22:38
kevinbentonijw: or is it admin-only?22:39
*** baoli has quit IRC22:39
ijwkevinbenton: a tenant can do that to their own port on their own network22:39
kevinbentonijw: but not on a shared network belonging to someone else, right?22:39
ijwNope (and that was the first thing I asked)22:39
kevinbentonijw: ok. i should be able to make this respect that setting pretty easily22:39
ijwIt's got the same security that the original Nicira extension had, but it hangs together22:40
kevinbentonijw: do you have a pointer to that change so i can see the relevant flags?22:40
ijwI think it was Isaku's (I didn't actually review it, I'm a bad person)22:40
ijwLet me look22:40
ijwTry from here: https://blueprints.launchpad.net/neutron/+spec/ml2-ovs-portsecurity22:41
*** joshw42 has joined #openstack-neutron22:42
*** rushil has quit IRC22:42
*** alexpilotti has joined #openstack-neutron22:43
*** annegentle has quit IRC22:43
*** seizadi has joined #openstack-neutron22:45
kevinbentonis it this 'port_filter' flag in the vif details?22:45
*** igordcard_ has quit IRC22:46
*** igordcard_ has joined #openstack-neutron22:47
priteshcheck-neutron-dsvm-functional keeps failing for all neutron patches currently, anyone sees this too?22:48
*** carl_baldwin has quit IRC22:49
*** Marga_ has quit IRC22:49
priteshmainly the test_ovsdb_monitor tests.22:49
*** dboik has joined #openstack-neutron22:50
kevinbentonijw: got it22:51
*** jgrimm has quit IRC22:51
*** tflynn has joined #openstack-neutron22:52
*** jgrimm has joined #openstack-neutron22:52
*** dboik_ has joined #openstack-neutron22:53
*** tflynn_ has joined #openstack-neutron22:53
*** mlavalle has quit IRC22:55
*** mwagner_lap has joined #openstack-neutron22:55
*** dboik has quit IRC22:55
*** jobewan has quit IRC22:56
*** tflynn_ has quit IRC22:56
*** tflynn has quit IRC22:56
*** tflynn has joined #openstack-neutron22:57
*** leenheer has joined #openstack-neutron22:59
*** jgrimm is now known as zz_jgrimm22:59
*** dave-mccowan has quit IRC23:04
*** achanda has quit IRC23:05
*** joshw42 has quit IRC23:05
*** Aish has left #openstack-neutron23:06
*** jckasper has joined #openstack-neutron23:06
*** igordcard_ has quit IRC23:07
*** Sukhdev has joined #openstack-neutron23:08
Sukhdevarmax: Ping23:09
*** TrevorV|Home has joined #openstack-neutron23:12
Sam-I-Amijw: ping23:12
*** sbfox has quit IRC23:13
*** julien_ZTE has quit IRC23:14
*** tflynn has quit IRC23:14
Sam-I-Amijw: testing the new mtu stuff in kilo23:15
Sam-I-Amijw: everything seemed to get the correct mtu except the compute tap and bridge23:15
*** TrevorV|Home has quit IRC23:17
*** seizadi has quit IRC23:19
*** pritesh has quit IRC23:19
*** achanda has joined #openstack-neutron23:21
*** rook__ has joined #openstack-neutron23:23
*** yamamoto has joined #openstack-neutron23:25
*** dboik_ has quit IRC23:25
*** jckasper has quit IRC23:26
*** tflynn has joined #openstack-neutron23:26
*** rook__ has quit IRC23:27
*** ZZelle has quit IRC23:27
*** luqas has joined #openstack-neutron23:30
*** tflynn has quit IRC23:31
*** hichihara has joined #openstack-neutron23:31
*** ociuhandu has joined #openstack-neutron23:33
*** luqas has quit IRC23:35
*** Marga_ has joined #openstack-neutron23:37
*** gildub has joined #openstack-neutron23:37
openstackgerritEdgar Magana proposed openstack/neutron: Add missing config parameters in neutron.conf  https://review.openstack.org/17105923:38
openstackgerritArmando Migliaccio proposed openstack/neutron: Fix intermittent UT failures in test_utils  https://review.openstack.org/17143323:41
armaxmestery, amuller, kevinbenton: ^^^23:42
*** annegentle has joined #openstack-neutron23:44
amullerarmax: never seen those fail, maybe you can add a sample failure in the commit message?23:44
armaxamuller: what about the bug report?23:44
amullerarmax: oy vey, didn't notice you had one23:44
armaxamuller: with logstash query annexed?23:44
armaxamuller: yes, sir23:45
armaxamuller: I am the full package23:45
amullerhah23:45
armax...23:45
armax:)23:45
mesterylol23:45
mesteryarmax is the man23:45
armaxmestery, kevinbenton thanks for the prompt turnaround23:46
mesteryarmax: thanks for the prompt bug fix!23:46
amullerarmax: the bad thing about logstash is that those links go away after some time... I had that happen when I needed to investigate an old bug, the bug description was only a link to logstash and it was dead23:47
amullerjust something to keep in mind23:47
armaxamuller: um interesting23:47
armaxamuller: you’re right, even the logs go away23:47
armaxamuller: I’ll add the stacktrace to the report23:48
amullerit's useful to add some information to the bug because of that reason (Not for this specific bug though)23:48
amullerwell, maybe if someone git blames your change to the functional test and tracks it down to the bug report23:48
armaxamuller: no, that’s a good point, sometimes I do do that, but this time I forgot23:49
*** yamamoto has quit IRC23:49
openstackgerritMerged openstack/neutron-vpnaas: VPNaaS: Reorganize test tree  https://review.openstack.org/17125623:49
armaxthe traceback is not as glamorous this time though :)23:49
*** annegentle has quit IRC23:50
*** boris-42 has joined #openstack-neutron23:54
openstackgerritAssaf Muller proposed openstack/neutron: Update port bindings for master router  https://review.openstack.org/14111423:57
Sukhdevarmax: Ping23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!