Monday, 2015-04-20

*** salv-orlando has quit IRC00:04
*** yamamoto has quit IRC00:05
*** yamahata has quit IRC00:06
*** daneyon has joined #openstack-neutron00:08
*** amotoki has joined #openstack-neutron00:14
*** itsAmeMario0o has quit IRC00:18
*** yamahata has joined #openstack-neutron00:18
*** shaohe_feng has quit IRC00:19
*** dboik has quit IRC00:22
*** itsAmeMario0o has joined #openstack-neutron00:28
*** aranjan has quit IRC00:31
*** itsAmeMario0o has quit IRC00:40
*** dttocs has joined #openstack-neutron00:52
*** zhenguo has joined #openstack-neutron00:54
*** dttocs has quit IRC00:57
*** signed8bit has joined #openstack-neutron00:58
*** dboik has joined #openstack-neutron01:04
*** salv-orlando has joined #openstack-neutron01:05
*** yalie has joined #openstack-neutron01:08
*** signed8bit has quit IRC01:09
*** salv-orlando has quit IRC01:11
*** luqas has joined #openstack-neutron01:17
*** alex_xu has quit IRC01:18
*** luqas has quit IRC01:21
*** alex_xu has joined #openstack-neutron01:23
*** shaohe_feng has joined #openstack-neutron01:25
*** shaohe_feng1 has joined #openstack-neutron01:28
*** yamamoto has joined #openstack-neutron01:29
*** popw has joined #openstack-neutron01:29
*** shaohe_feng has quit IRC01:29
*** shaohe_feng1 has left #openstack-neutron01:31
*** yalie1 has joined #openstack-neutron01:31
*** salv-orlando has joined #openstack-neutron01:32
*** yalie has quit IRC01:34
*** salv-orlando has quit IRC01:35
*** banix has joined #openstack-neutron01:38
*** itsAmeMario0o has joined #openstack-neutron01:38
*** stanzgy has joined #openstack-neutron01:39
*** erkules has joined #openstack-neutron01:40
*** dboik has quit IRC01:40
*** ivar-lazzaro has joined #openstack-neutron01:40
*** salv-orlando has joined #openstack-neutron01:41
*** erkules_ has quit IRC01:43
*** julim has quit IRC01:47
*** julim has joined #openstack-neutron01:48
*** julim has quit IRC01:48
*** ivar-lazzaro has quit IRC01:50
*** salv-orlando has quit IRC01:51
*** achanda has joined #openstack-neutron01:53
*** dttocs has joined #openstack-neutron01:53
*** banix has quit IRC01:53
*** baoli has quit IRC01:54
*** dttocs has quit IRC01:57
*** jbell8 has joined #openstack-neutron01:58
*** jbell8_ has joined #openstack-neutron02:06
*** jbell8 has quit IRC02:09
*** jbell8_ has quit IRC02:10
*** britthou_ has quit IRC02:13
openstackgerritgongysh proposed openstack/neutron: Simplify keepalived.virtual_routes  https://review.openstack.org/16043002:13
*** britthouser has joined #openstack-neutron02:13
*** banix has joined #openstack-neutron02:14
*** banix has quit IRC02:18
*** shwetaap has joined #openstack-neutron02:20
*** seizadi has joined #openstack-neutron02:23
*** tflynn has joined #openstack-neutron02:30
*** itsAmeMario0o has quit IRC02:31
*** itsAmeMario0o has joined #openstack-neutron02:31
*** itsAmeMario0o has quit IRC02:32
*** chem has quit IRC02:39
*** tflynn has quit IRC02:44
*** carl_baldwin has quit IRC02:44
*** seizadi has quit IRC02:48
*** tflynn has joined #openstack-neutron02:48
*** dttocs has joined #openstack-neutron02:54
*** chem has joined #openstack-neutron02:54
*** baoli has joined #openstack-neutron02:55
*** tflynn has quit IRC02:55
*** david-lyle has quit IRC02:55
*** tflynn has joined #openstack-neutron02:56
*** jamielennox is now known as jamielennox|away02:58
*** dttocs has quit IRC02:58
*** banix has joined #openstack-neutron02:59
*** baoli has quit IRC02:59
*** achanda has quit IRC03:00
*** jamielennox|away is now known as jamielennox03:03
*** sbalukoff has quit IRC03:07
*** aranjan has joined #openstack-neutron03:10
*** armax has joined #openstack-neutron03:14
*** jbell8 has joined #openstack-neutron03:15
*** sbalukoff has joined #openstack-neutron03:20
*** aranjan has quit IRC03:22
*** banix has quit IRC03:29
*** dboik has joined #openstack-neutron03:30
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: WIP Ryu functional tests  https://review.openstack.org/17234403:32
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver  https://review.openstack.org/15394603:32
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024503:32
*** itsAmeMario0o has joined #openstack-neutron03:32
*** armax has quit IRC03:37
*** itsAmeMario0o has quit IRC03:38
*** coolsvap|afk is now known as coolsvap03:39
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024503:42
*** vks has quit IRC03:43
*** ozialien has quit IRC03:43
*** salv-orlando has joined #openstack-neutron03:45
*** tflynn has quit IRC03:45
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: WIP Ryu functional tests  https://review.openstack.org/17234403:48
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver  https://review.openstack.org/15394603:48
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow driver  https://review.openstack.org/15394603:49
*** salv-orlando has quit IRC03:51
*** tflynn has joined #openstack-neutron03:52
*** dttocs has joined #openstack-neutron03:55
*** nlahouti has quit IRC03:59
*** tflynn has quit IRC03:59
*** nlahouti has joined #openstack-neutron03:59
*** dttocs has quit IRC04:00
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow interface  https://review.openstack.org/15394604:01
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024504:01
*** dboik has quit IRC04:03
*** ishant has joined #openstack-neutron04:04
*** tflynn has joined #openstack-neutron04:05
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024504:08
*** Bhavya has joined #openstack-neutron04:13
*** bobmel_ has joined #openstack-neutron04:14
*** dave-mccowan has quit IRC04:16
*** bobmel has quit IRC04:16
*** aranjan has joined #openstack-neutron04:17
*** yfried|afk is now known as yfried__04:18
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow interface  https://review.openstack.org/15394604:23
*** yatin has joined #openstack-neutron04:24
*** subscope has joined #openstack-neutron04:25
*** Kennan2 has joined #openstack-neutron04:26
*** Kennan has quit IRC04:26
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation  https://review.openstack.org/15394604:32
*** aswadr has joined #openstack-neutron04:32
*** ajmiller has quit IRC04:34
*** Longgeek has joined #openstack-neutron04:35
*** Longgeek has quit IRC04:35
*** Longgeek has joined #openstack-neutron04:36
*** popw has quit IRC04:42
*** popw has joined #openstack-neutron04:42
*** subscope has quit IRC04:47
*** vivek-eb_ has joined #openstack-neutron04:48
*** yfried__ is now known as yfried|afk04:49
*** yfried|afk is now known as yfried__04:51
*** vivek-ebay has quit IRC04:51
*** luqas has joined #openstack-neutron04:55
*** dttocs has joined #openstack-neutron04:55
*** itsAmeMario0o has joined #openstack-neutron04:57
*** boris-42 has quit IRC04:58
*** luqas has quit IRC04:59
*** dttocs has quit IRC05:00
*** itsAmeMario0o has quit IRC05:01
*** yfried__ has quit IRC05:02
*** chem has quit IRC05:07
*** ishant has quit IRC05:13
*** pal has joined #openstack-neutron05:13
*** _kiran_ has joined #openstack-neutron05:15
*** pal has quit IRC05:19
*** vivek-eb_ has quit IRC05:20
*** irenab has quit IRC05:23
*** nlahouti has quit IRC05:23
*** jbell8 has quit IRC05:27
openstackgerritHirofumi Ichihara proposed openstack/neutron-specs: Add enable_new_agents to agent conf in network node  https://review.openstack.org/17077405:28
*** abregman has joined #openstack-neutron05:31
*** sbalukoff has quit IRC05:34
*** achanda has joined #openstack-neutron05:37
*** ishant has joined #openstack-neutron05:38
*** vthapar has joined #openstack-neutron05:42
*** sbalukoff has joined #openstack-neutron05:51
*** tflynn has quit IRC05:51
*** redbeard has joined #openstack-neutron05:53
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation  https://review.openstack.org/15394605:55
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024505:55
*** tflynn has joined #openstack-neutron05:55
*** seizadi has joined #openstack-neutron05:55
*** dttocs has joined #openstack-neutron05:56
*** salv-orlando has joined #openstack-neutron05:57
*** yamahata has quit IRC05:58
*** yamahata has joined #openstack-neutron05:59
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation  https://review.openstack.org/15394606:00
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024506:00
*** aranjan_ has joined #openstack-neutron06:00
*** sudipto has joined #openstack-neutron06:00
*** dttocs has quit IRC06:01
*** aranjan has quit IRC06:04
*** salv-orlando has quit IRC06:06
*** nlahouti has joined #openstack-neutron06:07
*** anilvenkata has joined #openstack-neutron06:08
yamamotodougwig: ping06:09
*** aranjan_ has quit IRC06:09
*** afazekas_ has joined #openstack-neutron06:10
*** aranjan has joined #openstack-neutron06:10
*** garyk has joined #openstack-neutron06:12
*** irenab has joined #openstack-neutron06:12
*** anshul has joined #openstack-neutron06:14
*** yamahata has quit IRC06:15
*** SridharG has joined #openstack-neutron06:15
*** zz_jgrimm is now known as jgrimm06:19
*** yfried__ has joined #openstack-neutron06:19
*** scheuran has joined #openstack-neutron06:21
*** aranjan has quit IRC06:23
*** lazy_prince has joined #openstack-neutron06:25
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: l2pop UT: Reduce code duplication in migration tests  https://review.openstack.org/15818406:25
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: l2pop UT: Expire cached db objects before reusing a session  https://review.openstack.org/17152006:25
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: l2pop UT: Simplify migration tests  https://review.openstack.org/15818206:25
*** shwetaap has quit IRC06:25
openstackgerritwatanabe isao proposed openstack/neutron: Restrict subnet create/update to avoid DHCP resync  https://review.openstack.org/17422806:26
*** bjornar_ has joined #openstack-neutron06:27
*** anshul has quit IRC06:27
*** yfried__ is now known as yfried|afk06:30
*** bjornar_ has quit IRC06:32
*** neeti has joined #openstack-neutron06:33
*** yfried|afk is now known as yfried__06:34
*** nuritv has joined #openstack-neutron06:34
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Separate ovs-ofctl using code as a driver  https://review.openstack.org/16024506:35
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Introduce Ryu based OpenFlow implementation  https://review.openstack.org/15394606:37
*** anshul has joined #openstack-neutron06:40
*** gillllllliard is now known as gilliard06:48
openstackgerritgongysh proposed openstack/neutron: Simplify keepalived.virtual_routes  https://review.openstack.org/16043006:50
*** anshul has quit IRC06:50
*** jamielennox is now known as jamielennox|away06:52
*** jyuso1 has joined #openstack-neutron06:54
*** apuimedo has joined #openstack-neutron06:54
*** moshele has joined #openstack-neutron06:56
*** nlahouti has quit IRC06:56
*** dttocs has joined #openstack-neutron06:57
*** itzikb has joined #openstack-neutron07:01
*** dttocs has quit IRC07:01
openstackgerritAnkit Agrawal proposed openstack/neutron: Remove use of contextlib.nested  https://review.openstack.org/16767707:02
*** anshul has joined #openstack-neutron07:04
*** enikanorov_ has joined #openstack-neutron07:06
*** slaweq has joined #openstack-neutron07:07
*** enikanorov_ has quit IRC07:07
*** aranjan has joined #openstack-neutron07:10
*** subscope has joined #openstack-neutron07:10
*** SridharG has left #openstack-neutron07:12
*** nmagnezi_ has joined #openstack-neutron07:12
*** aranjan has quit IRC07:15
*** aepifanov has joined #openstack-neutron07:15
*** seizadi has quit IRC07:21
*** claudiub has joined #openstack-neutron07:21
*** devvesa has joined #openstack-neutron07:24
*** ociuhandu has joined #openstack-neutron07:27
*** kawa2014 has joined #openstack-neutron07:29
*** chlong has quit IRC07:29
*** ihrachyshka has joined #openstack-neutron07:31
openstackgerritMerged openstack/neutron: Correct typo for matching non-dict ovsdb rows  https://review.openstack.org/17505907:34
*** SridharG has joined #openstack-neutron07:36
*** pask81 has joined #openstack-neutron07:36
*** jlanoux has joined #openstack-neutron07:37
*** criptoverso has joined #openstack-neutron07:37
*** luqas has joined #openstack-neutron07:38
*** kiranr has joined #openstack-neutron07:38
*** pask81 has quit IRC07:39
*** _kiran_ has quit IRC07:39
*** ociuhandu has quit IRC07:45
*** emaray has joined #openstack-neutron07:46
*** jistr has joined #openstack-neutron07:47
*** achanda has quit IRC07:47
*** moha_hunt has joined #openstack-neutron07:49
*** roeyc has joined #openstack-neutron07:50
*** nyechiel has joined #openstack-neutron07:52
*** claudiub has quit IRC07:53
*** moha_hunt has quit IRC07:53
*** matrohon has joined #openstack-neutron07:55
*** claudiub has joined #openstack-neutron07:56
*** _kiran_ has joined #openstack-neutron07:57
*** kiranr has quit IRC07:57
*** dttocs has joined #openstack-neutron07:58
*** jpena has joined #openstack-neutron07:59
*** matrohon has quit IRC08:01
*** safchain has joined #openstack-neutron08:01
*** dttocs has quit IRC08:02
*** matrohon1 has joined #openstack-neutron08:02
*** dguitarbite has joined #openstack-neutron08:02
*** claudiub has quit IRC08:06
*** txomon|fon has quit IRC08:07
*** salv-orlando has joined #openstack-neutron08:07
*** matrohon1 has left #openstack-neutron08:09
*** matrohon1 has joined #openstack-neutron08:10
*** matrohon1 has left #openstack-neutron08:10
*** salv-orlando has quit IRC08:11
*** matrohon has joined #openstack-neutron08:11
*** aranjan has joined #openstack-neutron08:11
*** claudiub has joined #openstack-neutron08:11
*** lionelz has joined #openstack-neutron08:13
*** erkules has quit IRC08:13
*** erkules has joined #openstack-neutron08:13
*** matrohon has left #openstack-neutron08:14
*** matrohon has joined #openstack-neutron08:15
*** jlibosva has joined #openstack-neutron08:15
*** ygbo has joined #openstack-neutron08:15
*** jlibosva has quit IRC08:15
*** jlibosva has joined #openstack-neutron08:16
*** aranjan has quit IRC08:16
*** salv-orlando has joined #openstack-neutron08:17
*** numan has joined #openstack-neutron08:19
*** txomon|fon has joined #openstack-neutron08:20
*** salv-orlando has quit IRC08:21
*** emaray has left #openstack-neutron08:22
*** salv-orlando has joined #openstack-neutron08:23
*** salv-orlando has quit IRC08:28
*** ajo has joined #openstack-neutron08:28
*** dmellado has joined #openstack-neutron08:30
*** julien_ZTE has joined #openstack-neutron08:30
openstackgerritwatanabe isao proposed openstack/neutron: Make sure OVS restarts when Exception occurred  https://review.openstack.org/16997508:31
*** pask81 has joined #openstack-neutron08:32
*** anshul has quit IRC08:32
*** txomon|fon has quit IRC08:32
*** doude has joined #openstack-neutron08:34
*** garyk1 has joined #openstack-neutron08:39
*** garyk has quit IRC08:42
*** yamamoto has quit IRC08:45
*** anshul has joined #openstack-neutron08:46
*** f13o has joined #openstack-neutron08:47
*** txomon|fon has joined #openstack-neutron08:49
*** garyk1 has quit IRC08:50
*** garyk has joined #openstack-neutron08:50
*** devvesa has quit IRC08:50
*** chlong has joined #openstack-neutron08:50
*** salv-orlando has joined #openstack-neutron08:51
*** neeti has quit IRC08:52
*** kbyrne has joined #openstack-neutron08:54
*** lori|away is now known as lori08:54
*** apuimedo has quit IRC08:54
*** sudipto has quit IRC08:56
*** devvesa has joined #openstack-neutron08:56
*** dttocs has joined #openstack-neutron08:59
*** nyechiel has quit IRC08:59
*** lukasa has joined #openstack-neutron08:59
*** ihrachyshka has quit IRC09:00
*** dttocs has quit IRC09:03
*** nyechiel has joined #openstack-neutron09:05
openstackgerritNeo proposed openstack/neutron-vpnaas: Provide Fedora support for StrongSwan  https://review.openstack.org/17420509:06
*** sambetts has joined #openstack-neutron09:06
*** sudipto has joined #openstack-neutron09:08
*** redbeard has quit IRC09:09
openstackgerritNeo proposed openstack/neutron-vpnaas: Provide Fedora support for StrongSwan  https://review.openstack.org/17420509:09
*** ihrachyshka has joined #openstack-neutron09:11
*** aranjan has joined #openstack-neutron09:12
openstackgerritHirofumi Ichihara proposed openstack/neutron-specs: Add availability_zone support  https://review.openstack.org/16961209:12
*** pask81 has quit IRC09:14
*** jlanoux_ has joined #openstack-neutron09:17
*** alexpilotti has joined #openstack-neutron09:17
*** pradip has joined #openstack-neutron09:17
*** pask81 has joined #openstack-neutron09:19
*** chlong has quit IRC09:20
*** jlanoux has quit IRC09:20
*** dtynan has joined #openstack-neutron09:21
*** hichihara has quit IRC09:23
*** aepifanov has quit IRC09:26
*** pcaruana has quit IRC09:27
*** matrohon has quit IRC09:27
*** pradip has quit IRC09:28
*** ishant has quit IRC09:28
*** matrohon has joined #openstack-neutron09:28
*** matrohon has joined #openstack-neutron09:28
*** julien_ZTE has quit IRC09:30
*** pcaruana has joined #openstack-neutron09:30
*** numan has quit IRC09:32
*** chlong has joined #openstack-neutron09:32
*** amotoki has quit IRC09:35
*** sudipto has quit IRC09:35
*** moha_hunt has joined #openstack-neutron09:36
*** nyechiel has quit IRC09:37
*** aranjan has quit IRC09:37
*** shi has quit IRC09:41
*** hanzhang has joined #openstack-neutron09:42
*** yfried__ is now known as yfried|afk09:48
*** garyk has quit IRC09:48
*** garyk has joined #openstack-neutron09:49
*** coolsvap is now known as coolsvap|afk09:51
*** boris-42 has joined #openstack-neutron09:51
*** sudipto has joined #openstack-neutron09:52
*** yfried|afk is now known as yfried__09:53
*** numan has joined #openstack-neutron09:55
*** Tiancheng has joined #openstack-neutron09:55
*** redbeard has joined #openstack-neutron09:55
openstackgerritKevin Benton proposed openstack/neutron-specs: Role-based access control for networks  https://review.openstack.org/13266109:57
*** dttocs has joined #openstack-neutron09:59
*** claudiub has quit IRC10:00
*** aix has joined #openstack-neutron10:01
*** neeti has joined #openstack-neutron10:01
*** dttocs has quit IRC10:04
*** doude has quit IRC10:07
*** wznoinsk_ has joined #openstack-neutron10:07
*** wznoinsk has quit IRC10:09
*** pc_m has joined #openstack-neutron10:09
openstackgerritMerged openstack/neutron: Drop the ovs_lib compat layer as per TODO note  https://review.openstack.org/17417910:12
*** safchain has quit IRC10:12
*** anilvenkata has left #openstack-neutron10:14
*** anilvenkata has joined #openstack-neutron10:15
*** nyechiel has joined #openstack-neutron10:15
*** moshele has quit IRC10:16
*** Guest3939 is now known as rook10:22
*** rook is now known as Guest8986010:23
*** itsAmeMario0o has joined #openstack-neutron10:23
*** Guest89860 is now known as rook_10:23
*** yfried__ is now known as yfried|afk10:25
*** itsAmeMario0o has quit IRC10:27
openstackgerritMiguel Angel Ajo proposed openstack/neutron: (DO NOT MERGE/WIP/POC) OVSFirewallDriver  https://review.openstack.org/16767110:29
*** yfried|afk is now known as yfried__10:31
openstackgerritSridhar Gaddam proposed openstack/neutron: Support multiple IPv6 prefixes on internal router ports for an HA Router  https://review.openstack.org/17534210:32
*** roeyc has quit IRC10:33
*** aranjan has joined #openstack-neutron10:34
*** aranjan has quit IRC10:39
*** anshul has quit IRC10:42
*** numan has quit IRC10:43
*** moshele has joined #openstack-neutron10:45
openstackgerritMerged openstack/neutron: Add Kilo release milestone  https://review.openstack.org/17448310:50
_kiran_Hello guys! I am getting create failed (client error): Quota exceeded for resources: ['subnet'] http://paste.openstack.org/show/204862/ Please help me debug this problem. I have set Quota for subnet as -1.10:51
*** numan has joined #openstack-neutron10:51
*** yuanying has quit IRC10:52
*** kickinz1_mob|off has quit IRC10:53
*** kickinz1|afk has joined #openstack-neutron10:53
*** kickinz1_mob|off has joined #openstack-neutron10:53
*** kickinz1|afk is now known as kickinz110:54
*** anshul has joined #openstack-neutron10:55
*** Tiancheng has quit IRC10:56
*** stanzgy has quit IRC10:57
openstackgerritSalvatore Orlando proposed openstack/neutron: Remove get_admin_roles and associated logic  https://review.openstack.org/17523810:59
*** dttocs has joined #openstack-neutron11:00
*** numan has quit IRC11:02
*** afaranha has quit IRC11:02
*** txomon|fon has quit IRC11:03
*** dttocs has quit IRC11:04
HenryGsalv-orlando: hi, do you have a moment for a question?11:06
salv-orlandoHenryG: sure11:06
HenryGsalv-orlando: I see external_net is an extension, but some code seems to assume it is always loaded. Is it a valid assumption?11:07
openstackgerritvenkata anil proposed openstack/neutron-vpnaas: Libreswan driver support in VPNaaS  https://review.openstack.org/17429911:07
salv-orlandoHenryG: technically not.11:08
HenryGsalv-orlando: example: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/l3_db.py#n30711:08
salv-orlandobut for l3_db is fine. Indeed the l3 extension is unlikely to work without external network, I think11:08
salv-orlandoHenryG: if you look at http://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/l3.py it is kind of clear that external networks are a prerequisite for l311:10
salv-orlandobut for some reason we never made "officialy" a required extension for l311:10
HenryGsalv-orlando: I see, thanks.11:11
HenryGsalv-orlando: What about: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/db/db_base_plugin_v2.py#n126311:11
*** pradip has joined #openstack-neutron11:11
*** numan has joined #openstack-neutron11:11
salv-orlandoHenryG: that's a bug. I'm pretty sure arosen posted a patch for that a week ago.11:11
*** roeyc has joined #openstack-neutron11:11
openstackgerritSalvatore Orlando proposed openstack/neutron: Drop load_admin_roles parameter  https://review.openstack.org/17535011:12
HenryGsalv-orlando: I see it, thanks11:12
pradiphi all11:12
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Revise functional test hooks  https://review.openstack.org/16811511:13
*** anshul has quit IRC11:14
pradipi am trying to provide internet access ti instences can any one tell me what are the initial configuration i have to do ..... i am using devstack for installing openstack on single vm all in one11:14
salv-orlandopradip: do you control addressing on your external network? for instance if your machine has eth0 on a 10.0.0.0/24 network, can you control addressing on that network?11:16
*** kickinz1_mob|off has quit IRC11:17
*** kickinz1 has quit IRC11:17
*** kickinz1|afk has joined #openstack-neutron11:17
*** kickinz1|afk is now known as kickinz111:17
pradipsalv-orlando : i don't have idea how to control..11:17
pradipsalv-orlando : i have saprate network with router and all configuration for neutron11:18
salv-orlandopradip: I just wanted to know if you could use a chunk of your "real" network for neutron external network. it seems you cannot, and that's fine11:19
pradipsalv-orlando : yes i can use my real network..11:19
salv-orlandowhen you run devstack enabling neutron, neutron creates an external network of 172.24.4.0/24. The l3 agent will plug interfaces for the external network on br-ex11:19
pradipsalv-orlando : yes11:19
salv-orlandoif you want to use your real network, set the external network to a chunk of that11:20
salv-orlandofor instance if you have 10.0.0.0/24 use 10.0.0.128/2511:20
salv-orlandoand then you need to manually connect br-ex to your eth interface11:20
salv-orlandodevstack does not do that in order to not mess up with networking on your machine11:20
pradipsalv-orlando : ok11:21
salv-orlandobasically the procedure is simple: 1) clear ip addresses on ethX interface; 2) add those on br-ex; 3) attach ethX to br-ex11:21
salv-orlandoand you should be up and running11:21
salv-orlandopradip: the easiest thing imho however is to let neutron use 172.24.4.0/24 and configure a snat rule with iptables.11:22
salv-orlandoless manual steps, less chances of messing up networking in your machine11:22
*** lionelz has quit IRC11:23
*** afazekas_ has quit IRC11:24
*** yfried__ is now known as yfried|afk11:25
*** jlibosva has quit IRC11:25
*** yfried|afk is now known as yfried__11:26
pradipsalv-orlando :  can you share me any link which help me do these steps... actualy i new for networking and neutron11:27
*** anshul has joined #openstack-neutron11:27
*** afazekas_ has joined #openstack-neutron11:28
*** jlibosva has joined #openstack-neutron11:31
openstackgerritSalvatore Orlando proposed openstack/neutron: Remove backward compatibility for check_is_admin  https://review.openstack.org/17507811:33
openstackgerritSalvatore Orlando proposed openstack/neutron: Drop load_admin_roles parameter  https://review.openstack.org/17535011:33
openstackgerritSalvatore Orlando proposed openstack/neutron: Remove get_admin_roles and associated logic  https://review.openstack.org/17523811:33
HenryGfrickler: ping11:35
*** jpena is now known as jpena|lunch11:35
*** aranjan has joined #openstack-neutron11:35
*** safchain has joined #openstack-neutron11:36
*** doude has joined #openstack-neutron11:36
*** doude has quit IRC11:37
*** doude has joined #openstack-neutron11:37
*** apuimedo has joined #openstack-neutron11:38
*** baoli has joined #openstack-neutron11:41
*** ollivier has joined #openstack-neutron11:42
*** baoli has quit IRC11:46
*** popw has quit IRC11:47
*** pask81 has quit IRC11:54
*** apuimedo_ has joined #openstack-neutron11:55
*** jistr has quit IRC11:57
*** chlong has quit IRC11:58
*** afazekas_ has quit IRC11:58
*** jckasper_ has quit IRC11:59
*** gsagie has joined #openstack-neutron11:59
*** jckasper_ has joined #openstack-neutron11:59
*** dttocs has joined #openstack-neutron12:01
*** aranjan has quit IRC12:03
*** jistr has joined #openstack-neutron12:03
*** apuimedo_ has quit IRC12:03
*** ihrachyshka has quit IRC12:03
*** dttocs has quit IRC12:05
*** vthapar has quit IRC12:06
*** zhenguo has quit IRC12:07
*** jlibosva has quit IRC12:09
*** ronis has joined #openstack-neutron12:11
*** tiswanso has joined #openstack-neutron12:14
*** lazy_prince has quit IRC12:14
*** busterswt has joined #openstack-neutron12:14
*** dave-mccowan has joined #openstack-neutron12:14
*** tiswanso has quit IRC12:16
*** tiswanso has joined #openstack-neutron12:16
*** ihrachyshka has joined #openstack-neutron12:19
*** ihrachyshka has quit IRC12:19
*** ihrachyshka has joined #openstack-neutron12:19
*** itsAmeMario0o has joined #openstack-neutron12:20
openstackgerritvenkata anil proposed openstack/neutron-vpnaas: Libreswan driver support in VPNaaS  https://review.openstack.org/17429912:20
*** nivtuckio has joined #openstack-neutron12:23
*** sudipto has quit IRC12:23
*** numan has quit IRC12:26
openstackgerritDmitry Ratushnyy proposed openstack/neutron: Added more Api tests for port-security extension. DependsOn: #167910  https://review.openstack.org/17537212:26
*** salv-orlando has quit IRC12:28
*** nfedotov has joined #openstack-neutron12:28
*** amuller has joined #openstack-neutron12:29
*** numan has joined #openstack-neutron12:30
*** jckasper_ has quit IRC12:30
*** jamielennox|away is now known as jamielennox12:31
*** jamielennox is now known as jamielennox|away12:32
*** jaypipes has joined #openstack-neutron12:33
*** jschwarz has joined #openstack-neutron12:33
*** numan has quit IRC12:34
*** kickinz1 has left #openstack-neutron12:36
*** gsagie has quit IRC12:37
*** baoli has joined #openstack-neutron12:38
*** itsAmeMario0o has quit IRC12:38
*** prad has quit IRC12:40
*** prad has joined #openstack-neutron12:40
pradipsalv-orlando : thank its working12:43
*** cference_ has joined #openstack-neutron12:43
*** cference_ has quit IRC12:44
*** cference_ has joined #openstack-neutron12:44
*** tiswanso has quit IRC12:45
*** ihrachyshka has quit IRC12:46
*** jpena|lunch is now known as jpena12:47
openstackgerritVivekanandan Narasimhan proposed openstack/neutron: vm migration needs persistent state for l2pop  https://review.openstack.org/17538312:49
*** shwetaap has joined #openstack-neutron12:49
*** redbeard has quit IRC12:50
fricklerHenryG: pong12:52
HenryGfrickler: Hi, I saw your comment on bug 136632612:52
openstackbug 1366326 in CirrOS "ipv6 support" [Medium,Confirmed] https://launchpad.net/bugs/136632612:52
HenryGfrickler: Have you contributed to cirros before?12:53
*** jlibosva has joined #openstack-neutron12:53
*** baoli has quit IRC12:54
fricklerno, I did talk a bit with smoser though12:54
*** baoli has joined #openstack-neutron12:54
HenryGfrickler: OK, I am looking to get some movement going on that bug12:55
HenryGfrickler: Are you interesting in helping? I also have a resource or two who can help.12:55
*** jlibosva has quit IRC12:55
*** jlibosva has joined #openstack-neutron12:56
*** salv-orlando has joined #openstack-neutron12:56
HenryGfrickler: Right now though, I am struggling to understand the workflow required.12:56
fricklersure, maybe you want to join #cirros12:56
*** wverdugo500 has joined #openstack-neutron12:56
*** ihrachyshka has joined #openstack-neutron12:58
*** aranjan has joined #openstack-neutron12:59
*** baoli has quit IRC12:59
*** baoli has joined #openstack-neutron13:00
*** dttocs has joined #openstack-neutron13:02
*** thomasem has joined #openstack-neutron13:02
*** yatin has quit IRC13:02
*** clett has quit IRC13:03
*** neeti has quit IRC13:03
*** aranjan has quit IRC13:04
*** lifeless has quit IRC13:05
*** dttocs has quit IRC13:06
*** f13o has quit IRC13:07
openstackgerritDmitry Ratushnyy proposed openstack/neutron: Add more tests for port-security extension DependsOn: #167910  https://review.openstack.org/17538913:07
*** moshele has quit IRC13:07
ihrachyshkasalv-orlando, hey!13:07
*** wverdugo500 has left #openstack-neutron13:07
ihrachyshkasalv-orlando, I wonder whether that 'backward compat' code for admin role even worked at all. __missing__ seems to be always preset in oslo policy.py (?) Or is there any other reason that broke it?13:08
*** banix has joined #openstack-neutron13:08
*** wznoinsk_ has quit IRC13:08
salv-orlandoihrachyshka: yeah it did not work. didn't I state that in the commit message?13:09
ihrachyshkasalv-orlando, "However, this backward compatibility check does not work anymore"13:09
ihrachyshkait suggested that it worked13:09
salv-orlandoihrachyshka: and by not working it also created an interesting hole in the app security13:09
salv-orlandoihrachyshka: right. I am positive there has been a point in time where it worked.13:10
salv-orlandoI do not remember when the openstack.common.policy started returning TrueCheck for missing policies, but it used to not be like that13:10
ihrachyshkayeah, I'm concerned a bit. basically, people who upgraded from havana could be exposed to an issue. and we have havana releases in support in downstream.13:10
salv-orlandoihrachyshka: they could be exposed is they have custom policy.json files with no context_is_admin rule13:11
salv-orlandoif we push a patch to stable we can secure those deployments, but we will also break them13:11
salv-orlandoobviously it is preferrable to break them.13:12
*** f13o has joined #openstack-neutron13:12
*** thomasem has quit IRC13:14
*** banix has quit IRC13:14
*** thomasem has joined #openstack-neutron13:15
*** pask81 has joined #openstack-neutron13:17
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas: Insert validation in creating/updating firewall  https://review.openstack.org/14739613:19
openstackgerritYushiro FURUKAWA proposed openstack/neutron-fwaas: Insert tenant_id validation for fw and fw-policy  https://review.openstack.org/17539413:19
*** banix has joined #openstack-neutron13:23
*** banix has quit IRC13:23
ihrachyshkasalv-orlando, it started to behave like that as of https://review.openstack.org/#/c/14359/ which was merged long before backward compat change13:23
salv-orlandoihrachyshka: wow 2012 is the prehistory of openstack13:24
*** rook_ has quit IRC13:24
salv-orlandoand I approved that13:24
openstackgerritDmitry Ratushnyy proposed openstack/neutron: Add more API tests for port-security extension  https://review.openstack.org/17539913:25
*** gongysh has joined #openstack-neutron13:26
*** crose has joined #openstack-neutron13:29
*** alagalah has joined #openstack-neutron13:29
salv-orlandoihrachyshka: so we need to see what we should backport to stable branches. I would say there are two ways13:30
*** Networkn3rd has joined #openstack-neutron13:30
salv-orlando1) build a rulecheck for the bw compatibility thing13:30
*** moshele has joined #openstack-neutron13:30
salv-orlando2) return false is context_is_admin policy does not exist and then remove the bw compatibility thing13:31
*** superdan is now known as dansmith13:31
*** moshele has quit IRC13:32
*** drawsmcgraw has joined #openstack-neutron13:34
*** ferest has joined #openstack-neutron13:34
drawsmcgrawHi everyone13:35
*** annegentle has joined #openstack-neutron13:35
*** jistr_ has joined #openstack-neutron13:35
drawsmcgrawI've been digging through the docs to no avail. Hoping this one is easy for someone in here.  If I have more than one Nuetron network built, is there a way to tell Nova which one is the default?13:35
*** claudiub has joined #openstack-neutron13:36
*** matrohon has quit IRC13:36
*** matrohon has joined #openstack-neutron13:37
HenryGjlibosva: ping13:37
*** stanzgy has joined #openstack-neutron13:37
*** matrohon has left #openstack-neutron13:38
*** jistr has quit IRC13:38
*** matrohon has joined #openstack-neutron13:39
openstackgerritDmitry Ratushnyy proposed openstack/neutron: Add more API tests for port-security extension  https://review.openstack.org/17539913:40
salv-orlandoihrachyshka: btw, it seems it's not defaulting to a TrueCheck. That was just happening in my tests.13:40
salv-orlandoihrachyshka: the check if the rule is missing default to whatever was there13:40
salv-orlandoihrachyshka: as "default" rule in policy.json13:40
*** russellb has quit IRC13:40
salv-orlandoso it's likely that the bw compatibility thing never really worked but at the same time never caused a security issue13:41
*** doude_ has joined #openstack-neutron13:41
ihrachyshkasalv-orlando, right, that's what I see in oslo policy.py. ok, my pain is relieved.13:41
*** julim has joined #openstack-neutron13:41
ihrachyshkasalv-orlando, __missing__ should not actually be triggered for 'in' check (python docs say it's for [] only)13:42
ihrachyshkasalv-orlando, so maybe it even worked (works?)13:42
*** rook has joined #openstack-neutron13:42
salv-orlandoihrachyshka: I'm sure it worked at some point. But those were times were we seldom tested anything at the gate.13:42
*** matrohon has quit IRC13:43
*** matrohon has joined #openstack-neutron13:43
salv-orlandoregardless, I'd say that since that patch merged for Grizzly, we can now consider that backward compatibility check not necessary anymore13:43
*** dboik has joined #openstack-neutron13:44
*** jckasper has joined #openstack-neutron13:44
*** jistr_ has quit IRC13:44
*** matrohon has left #openstack-neutron13:44
*** jistr has joined #openstack-neutron13:44
*** zhenguo has joined #openstack-neutron13:44
*** dboik has quit IRC13:45
*** matrohon has joined #openstack-neutron13:45
*** dboik has joined #openstack-neutron13:45
*** russellb has joined #openstack-neutron13:45
*** matrohon has joined #openstack-neutron13:45
ihrachyshkasalv-orlando, that's fair I guess, for this specific case. though we should be more explicit with deprecations when moving forward. (the expectation would be that we issue a deprecation warning for one cycle the least)13:45
*** matrohon has left #openstack-neutron13:46
*** matrohon has joined #openstack-neutron13:47
drawsmcgrawJust re-read the room description. My apologies; I'll take it over to #openstack.13:47
*** drawsmcgraw has left #openstack-neutron13:47
*** matrohon has joined #openstack-neutron13:47
*** matrohon has left #openstack-neutron13:47
*** matrohon has joined #openstack-neutron13:48
*** doude has quit IRC13:48
pc_mAnyone familiar with using oslo_rootwrap?  I'm having problems updating a functional job and am getting a NoFilterMatched exception.13:48
*** claudiub has quit IRC13:48
*** doude_ has quit IRC13:48
salv-orlandoihrachyshka: I do not have a strong opinion, so I might just convert that patch into a deprecation. However I feel like that won't be necessary in this case (Foldom/Grizzly operators hardly touched policy.json since most of the policy checks were hardcoded)13:49
ihrachyshkasalv-orlando, I agree on this particular patch, probably no need for explicit deprecation.13:50
*** gsagie has joined #openstack-neutron13:51
*** shaohe_feng has joined #openstack-neutron13:53
*** apuimedo has quit IRC13:55
*** aepifanov has joined #openstack-neutron13:55
*** shwetaap has quit IRC13:55
HenryGjschwarz: ping13:56
*** stanzgy has quit IRC13:56
jlibosvaHenryG: hi13:58
*** wznoinsk has joined #openstack-neutron13:58
*** rushil has joined #openstack-neutron13:59
HenryGjlibosva: IIRC you are an expert on grenade :)13:59
jlibosvaHenryG: if expert equals 'I did something' then yes :)13:59
*** aranjan has joined #openstack-neutron14:00
*** garyk has quit IRC14:00
jlibosvaHenryG: how can I help?14:00
*** garyk has joined #openstack-neutron14:00
HenryGjlibosva: Exactly :)  Any idea what is the problem with bug 1435343 ?14:00
openstackbug 1435343 in grenade "check-grenade-dsvm fails when updating CIRROS_VERSION in devstack" [Undecided,New] https://launchpad.net/bugs/143534314:00
* jlibosva looking14:00
gsagieHello all, is there any way to block any configuration updates to the mechanism driver until some process in another thread is finished, or i have to use locks for it?14:02
*** dttocs has joined #openstack-neutron14:02
*** jgrimm is now known as zz_jgrimm14:04
*** smccully has joined #openstack-neutron14:04
*** irenab has quit IRC14:04
jschwarzHenryG, pong14:05
HenryGjschwarz: Is the fullstack test supposed to run in the functional job?14:05
*** dboik_ has joined #openstack-neutron14:06
jschwarzHenryG, yes. we didn't want to create a new gate job for the fullstack until there are more tests, so we just added it to the functional14:06
jschwarzwhy do you ask?14:06
*** doude has joined #openstack-neutron14:06
HenryGjschwarz: The functional job is very unstable, and it seems related to the fullstack test14:06
*** dttocs has quit IRC14:07
jschwarzHenryG, how so?14:07
amullerjschwarz: +1, today I saw the failure of a l3 ha functional test that I never saw fail before14:07
*** ajmiller has joined #openstack-neutron14:08
amullerjschwarz: ha router would not become active during the rpc bulk test14:08
amullerjschwarz: was just on my way out, chat with you later14:08
jschwarzamuller, ack14:08
*** dboik has quit IRC14:08
HenryGamuller: but some router tests also leak namespaces14:08
jschwarzI'm curious as to why you are linking this to the full-stack?14:09
*** mwagner_lap has joined #openstack-neutron14:09
*** alagalah has left #openstack-neutron14:09
*** doude has quit IRC14:09
jlibosvaHenryG: I think it depends on what we want to do. If we want to use 3.2 cirros in 'old' and 3.3 in 'new', we need to download 3.3 with grenade. I think correct thing to do here is to test 'new' version with 3.2 cirros due to backward compatibility14:09
HenryGjschwarz: If I run "tox -e dsvm-functional -- neutron.tests.functional" then it passes every time for me.14:09
*** shwetaap has joined #openstack-neutron14:09
jschwarzuhm14:10
*** tflynn has quit IRC14:10
jlibosvaHenryG: the config file for tempest was probably overwritten by new 3.3 value, thus the error14:10
HenryGjschwarz: if I run "tox -e dsvm-functional" then it fails.14:10
jschwarzHenryG, and running with the full-stack doesn't?14:10
*** doude has joined #openstack-neutron14:10
jschwarzwell that sucks.14:10
*** doude_ has joined #openstack-neutron14:10
jschwarzHenryG, I'm thinking it might be related to the fact that the rabbitmq exchanges that are used are the same for all neutron code14:11
jschwarzso maybe the functional tests are sending rabbitmq messages that are caught by the full-stack daemon?14:11
HenryGjschwarz: I see "neutron-server" processes left running after tests complete14:11
jschwarzHenryG, link?14:12
HenryGjschwarz: I see this locally on my system14:12
*** doude_ has quit IRC14:12
jschwarzuhm14:12
*** zhhuabj has joined #openstack-neutron14:12
HenryGjlibosva: I am not sure I understand the flow there14:13
jschwarzHenryG, and if you kill the neutron-server processes and re-run the tests, do some funcitonal still fail?14:13
HenryGjschwarz: I have not tried that yet14:13
jschwarzHenryG, please do. might be that there's a problem with the cleanup process of the tests (looking into it now)14:14
*** stanzgy has joined #openstack-neutron14:14
jlibosvaHenryG: it's simple - part of devstack downloads cirros image in order to prepare some data for demo tenant, right? The URL for such image is given by the change made by the patch causing issue you sent14:14
jschwarzmultiple neutron-servers will surely make some fullstack tests more likely to fail (for the "one rabbitmq exchange" reason mentioned above), but I'm still not sure if it can effect functional tests14:15
jlibosvaHenryG: after we bump the version, tempest config file gets updated by grenade - introducing the change from patch14:15
jlibosvaHenryG: the old tempest was run with 3.214:15
jlibosvaHenryG: the new tempest expects 3.3 but the image wasn't downloaded as devstack wasn't run again14:15
HenryGjlibosva: aha14:16
jlibosvaHenryG: does it make sense?14:16
HenryGjlibosva: so we need to add a check for and download image if needed?14:16
*** jbell8 has joined #openstack-neutron14:16
*** zhhuabj_ has joined #openstack-neutron14:16
jlibosvaHenryG: it depends what we want to test. I believe grenade's motivation is to test backward compatibility - so my recommendation would be to use 3.2 after upgrade.14:17
jlibosvaHenryG: but if there is a necessary feature in 3.3 that is used by new tempest, we need to download a new image14:17
HenryGjlibosva: the new image is for better ipv6 support14:18
*** apuimedo has joined #openstack-neutron14:18
jlibosvaHenryG: then I guess it makes sense to get a new one14:18
*** afazekas_ has joined #openstack-neutron14:18
HenryGjlibosva: But I assume that grenade runs the same tests for old and new, so the old image should be OK14:18
*** zhhuabj has quit IRC14:19
HenryGjlibosva: or is that a wrong assumption?14:19
jlibosvaHenryG: I think it also updates tempest but I'm checking to make sure14:20
openstackgerritNikolay Fedotov proposed openstack/neutron-vpnaas: Scenario test for vpnaas: ipsec-site-connection  https://review.openstack.org/15974614:20
*** jbell8 has quit IRC14:21
*** zhhuabj_ has quit IRC14:22
openstackgerritvenkata anil proposed openstack/neutron-vpnaas: Libreswan driver support in VPNaaS  https://review.openstack.org/17429914:24
*** daneyon_ has joined #openstack-neutron14:24
jlibosvaHenryG: yep, from logs I can say we do upgrade tempest14:24
*** zhhuabj_ has joined #openstack-neutron14:24
*** jobewan has joined #openstack-neutron14:24
HenryGjlibosva: thanks. Then it would make sense to update the cirros image too.14:25
*** roeyc has quit IRC14:26
*** garyk has quit IRC14:26
*** garyk has joined #openstack-neutron14:26
*** daneyon has quit IRC14:26
*** afazekas_ has quit IRC14:26
*** dboik_ has quit IRC14:27
jschwarzamuller, re what we discussed earlier?14:27
*** dboik has joined #openstack-neutron14:27
jschwarzamuller, I'm thinking it can be because of the rabbitmq-exchange business14:28
*** emagana has joined #openstack-neutron14:28
jschwarzamuller, doesn't functional mock those?14:28
*** aranjan has quit IRC14:29
*** afazekas_ has joined #openstack-neutron14:30
*** anilvenkata has left #openstack-neutron14:31
jlibosvaHenryG: are we talking upgrade Juno->Kilo or Kilo->Liberty?14:31
*** lifeless has joined #openstack-neutron14:32
*** zhhuabj_ has quit IRC14:32
*** ferest has quit IRC14:32
*** achanda has joined #openstack-neutron14:32
*** zhhuabj_ has joined #openstack-neutron14:33
*** phil_h has joined #openstack-neutron14:33
*** thedodd has joined #openstack-neutron14:34
*** ollivier has quit IRC14:35
*** aepifanov has quit IRC14:35
*** aepifanov has joined #openstack-neutron14:35
*** afazekas_ has quit IRC14:36
*** shaohe_feng has left #openstack-neutron14:36
*** aepifanov has quit IRC14:37
jschwarzHenryG, I can confirm that running the full functional job with fullstack creates errors with l3 agnet...14:37
*** aepifanov has joined #openstack-neutron14:37
jschwarzhow do we want to proceed?14:37
*** aepifanov has quit IRC14:38
*** aepifanov has joined #openstack-neutron14:38
*** roeyc has joined #openstack-neutron14:38
*** aepifanov has quit IRC14:38
*** aepifanov has joined #openstack-neutron14:38
*** achanda has quit IRC14:39
*** f13o has quit IRC14:40
HenryGjlibosva: Juno->Kilo preferrably14:40
*** f13o has joined #openstack-neutron14:40
jlibosvaHenryG: k, I can try to send patch then to test whether my assumption is correct14:41
HenryGjschwarz: not sure. Any clues to root cause?14:41
HenryGjlibosva: awesome, thanks14:41
jlibosvaHenryG: we can also consult with sdague first14:43
jlibosvasdague: hi :)14:43
jaypipesmestery, garyk, others: would appreciate your votes on https://review.openstack.org/#/c/173289 (it adds a Neutron VMware DVS ML2 driver project to stackforge)14:44
*** dguitarbite has quit IRC14:44
sdaguejlibosva: what is the question?14:44
*** emagana has quit IRC14:44
*** emagana has joined #openstack-neutron14:45
garykjaypipes: sure. can take a look. please note that we have the dvs support in the vmware_nsx project.14:45
jschwarzHenryG, as I wrote above, I think it's because neutron is using the same topics across the board14:45
garyki am not sure if that is relevant with what is being done here14:45
jschwarzHenryG, so the same rabbitmq queues can be used for multiple neutron-server (or fullstack and functional)14:45
jlibosvasdague: we need 3.3 cirros version that contains better ipv6 support - question is if uploading 3.3 image as a part of from-juno is a correct thing to do14:45
*** flaviof has joined #openstack-neutron14:46
jschwarzHenryG, though I'm not sure why the functional tests doesn't mock those rabbitmq function calls...14:46
HenryGjschwarz: OK, makes sense. Can the functional tests patch the topics to be test-case unique?14:46
jschwarzHenryG, I'm really not sure. will definetely require looking into14:47
sdaguejlibosva: cirros 0.3.3 has regressions in some of the commands which means it won't work in the gate14:47
*** gongysh_ has joined #openstack-neutron14:47
jschwarzHenryG, I'll ping marun and see if he has any ideas here - I started this discussion with him a while back14:47
*** afazekas_ has joined #openstack-neutron14:47
HenryGsdague: sad face :(14:47
*** jlanoux_ has quit IRC14:47
*** zhhuabj_ has quit IRC14:47
*** zhhuabj_ has joined #openstack-neutron14:48
sdaguehttps://bugs.launchpad.net/cirros/+bug/140892214:48
openstackLaunchpad bug 1408922 in CirrOS "busybox nc: persistent server (-ll) option lost" [Undecided,In progress] - Assigned to Dr. Jens Rosenboom (j-rosenboom-j)14:48
jlibosvasdague: HenryG then I guess this solves our concern in a most work-less way14:48
sdagueif you can get that resolved, and get a new version cut for upstream cirros, then we could move to a newer release14:48
*** russellb has quit IRC14:48
mesteryjaypipes: done!14:49
*** banix has joined #openstack-neutron14:49
*** gongysh has quit IRC14:49
jlibosvasdague: in case that happens - should we do it via from-juno/upgrade-tempest ? In devstack, image upload is part of glance but I think it should rather go to tempest14:50
SridharGHenryG: You may want to have a look at this patch for reference - https://review.openstack.org/#/c/93949/1 (to update the version of cirros). Original patch: https://review.openstack.org/#/c/81486/314:50
amullerjschwarz: the l3 agent functional tests mock the rpc layer yes14:51
*** banix has quit IRC14:51
sdaguejlibosva: maybe, though realistically get the cirros image released first, then we'll figure it out14:51
jaypipesmestery: cheers (though I've learned from garyk that https://review.openstack.org/#/c/152414/ might actually be better than what is proposed there...but we'll see...)14:51
HenryGjschwarz: IIUC to mock the rabbit function calls or mock the topic depends on what is being tested.14:52
*** nmagnezi_ has quit IRC14:52
mesteryjaypipes: Right! Collaboration with that group perhaps?14:52
ihrachyshkamestery, are we going to create stable client branches for pre-kilo?14:52
jschwarzamuller, I trust that work correctly.. so what else can fail here?14:52
jaypipesmestery: heh, I'm working on that internally :)14:53
mesteryihrachyshka: That is part of the plan, yes.14:53
mesteryjaypipes: :)14:53
ihrachyshkaok, I just saw kilo only and decided to check whether you consider it done14:53
*** russellb has joined #openstack-neutron14:53
amullerjschwarz: I don't know what errors you're seeing. Are you seeing the same errors all of the time? Can you try to run the minimal set of tests that cause these errors?14:53
*** banix has joined #openstack-neutron14:53
jlibosvasdague: Roger that, thanks14:53
amullerjschwarz: is this a result of tests interaction, or can you find a test that when run alone sometimes fails?14:54
salv-orlandojaypipes, garyk, mestery: how many plugins and drivers there are for vmware's DVS? 9?14:54
salv-orlando99?14:54
mesterysalv-orlando: I've lost track, but they are spreading like rabbits in the spring.14:54
salv-orlandomestery: do you know that it's an exponential models?14:55
mesterysalv-orlando: I'm not surprised :)14:55
jschwarzamuller, I'm getting non-deterministic errors locally.. running a few runs on latest upstream to see if I can put my finger on it14:55
salv-orlandoarmax and I actually did a project back in the university to model how rabbits spread14:55
mesterysalv-orlando: The bigger question is perhaps which ones support the NFV+Docker use case.14:55
mesterysalv-orlando: You and armax :)14:55
*** anshul has quit IRC14:56
openstackgerritMatthew Treinish proposed openstack/python-neutronclient: Add functional test for subnet create  https://review.openstack.org/17254814:56
*** itzikb has quit IRC14:56
*** annegentle has quit IRC14:57
salv-orlandomestery: I don't know. As long as it enables cloud-native applications in a hybrid Cloud scenario, that's fine for me.14:57
*** zzzeek has joined #openstack-neutron14:58
*** strictlyb has quit IRC14:58
*** crose has quit IRC14:59
mesterysalv-orlando: While that's a valiant effort, if it's microservices architecture doesn't allow for a distributed, scale-out approach to declarative control, it's a waste.14:59
*** annegentle has joined #openstack-neutron14:59
jaypipesmestery, salv-orlando, garyk: I've asked some of the team responsible for the DVS driver work in Mirantis to please join on IRC and discuss with you all. I don't really feel like being a community proxy at this point... how hard is it to IRC anyway? ;)15:00
garykjaypipes: i am here15:00
salv-orlandojaypipes: Idk I know a lot of people that have made a career out of being people proxies...15:00
mesterylol15:01
salv-orlandojaypipes: anyway we only talk to people which are properly dockerized and NFV-ready15:01
jaypipessalv-orlando: I am proxy for a lot of things unfortunately :)15:02
*** rwsu has joined #openstack-neutron15:02
mesteryI prefer it if they have a declarative interface as well.15:02
*** carl_baldwin has joined #openstack-neutron15:03
*** marun has joined #openstack-neutron15:03
*** annegentle has quit IRC15:04
*** zz_jgrimm is now known as jgrimm15:04
*** annegentle has joined #openstack-neutron15:05
*** achanda has joined #openstack-neutron15:05
*** annegentle has quit IRC15:06
*** achanda has quit IRC15:07
*** afazekas_ has quit IRC15:08
*** annegentle has joined #openstack-neutron15:10
*** nyechiel has quit IRC15:10
*** vivek-ebay has joined #openstack-neutron15:11
openstackgerritIhar Hrachyshka proposed openstack/neutron: tests: confirm that _output_hosts_file does not log too often  https://review.openstack.org/17544515:12
*** rpothier has joined #openstack-neutron15:13
*** vivek-ebay has quit IRC15:14
*** jistr has quit IRC15:14
*** xgerman has joined #openstack-neutron15:16
*** strictlyb has joined #openstack-neutron15:16
openstackgerritIhar Hrachyshka proposed openstack/neutron: Replace custom method call logger with oslo.log helper  https://review.openstack.org/16899915:16
*** _kiran_ has quit IRC15:18
*** annegentle has quit IRC15:18
*** Bhavya has quit IRC15:19
pc_mmestery: hi15:19
*** dsneddon has joined #openstack-neutron15:20
*** afazekas_ has joined #openstack-neutron15:21
*** armax_ has joined #openstack-neutron15:22
*** aepifanov has quit IRC15:22
*** dttocs has joined #openstack-neutron15:25
jschwarzHenryG, amuller, so I tracked it down to the l3 agent removing namespaces that it doesn't know about (that are functional-tests owned)15:25
*** sbalukoff has quit IRC15:25
amullerjschwarz: good work15:25
HenryGjschwarz: how does it do that?15:26
amullerjschwarz: I guess this is a regression in the namespace refactor work that was merged a month or two ago15:26
*** ZZelle has quit IRC15:26
amullercarl_baldwin: ^15:26
jschwarzamuller, yep15:26
amullerjschwarz: can you link the offending code?15:26
amulleror are we not there yet?15:26
*** ZZelle has joined #openstack-neutron15:26
*** afazekas_ has quit IRC15:26
jschwarzyes, a sec15:26
jschwarzour uplink is a bit slow today :<15:26
HenryGamuller: note, I also see some dvr functional tests do not clean up their test namespaces15:27
jschwarzHenryG, amuller, https://github.com/openstack/neutron/blob/master/neutron/agent/l3/namespace_manager.py#L7315:27
*** ihrachyshka has quit IRC15:27
carl_baldwinjschwarz: is there a bug number for context?15:27
*** vivek-ebay has joined #openstack-neutron15:28
jschwarzcarl_baldwin, not yet. will have one soon enough15:28
*** safchain has quit IRC15:28
*** jistr has joined #openstack-neutron15:28
HenryGamuller: https://github.com/openstack/neutron/blob/master/neutron/tests/functional/agent/test_l3_agent.py#L115815:30
HenryGamuller: _create_router() does not have addCleanup()15:30
amullerHenryG: it's not supposed to be used directly, you're supposed to use manage_router15:31
amullerI see there's two tests that use it directly =/15:31
amulleryeah that's gonna leak resources15:31
amullerI'll take care of that, thanks Henry15:31
HenryGamuller: thanks, I was not sure exactly how the fix should look15:32
jschwarzamuller, I don't think we fixed that - we added that '@<host>' suffix and logic so it wouldn't delete namespaces that weren't his15:32
amullerHenryG: me neither yet :)15:32
amullerHenryG: Time to... Think. *shudders*15:32
*** roeyc has left #openstack-neutron15:32
*** roeyc has joined #openstack-neutron15:32
*** SridharG has left #openstack-neutron15:33
*** nfedotov has quit IRC15:34
*** vivek-ebay has quit IRC15:36
*** stanzgy has quit IRC15:36
*** afazekas_ has joined #openstack-neutron15:37
*** vivek-ebay has joined #openstack-neutron15:38
*** dannywilson has joined #openstack-neutron15:39
*** safchain has joined #openstack-neutron15:41
*** Swami has joined #openstack-neutron15:42
*** dannywilson has quit IRC15:42
jschwarzcarl_baldwin, HenryG, amuller, https://bugs.launchpad.net/neutron/+bug/144628415:42
openstackLaunchpad bug 1446284 in neutron "functional tests fail non-deterministicly because of full-stack" [Undecided,New]15:42
carl_baldwinThanks.15:42
*** dannywilson has joined #openstack-neutron15:43
jschwarzcarl_baldwin, sure thing. I'd fix it but I'm not likely to have enough time on my hand in the following weeks so I'd suggest someone else for this15:43
*** nlahouti has joined #openstack-neutron15:44
*** ygbo has quit IRC15:45
*** yfried__ has quit IRC15:45
*** nyechiel has joined #openstack-neutron15:46
*** dboik_ has joined #openstack-neutron15:47
*** afazekas_ has quit IRC15:47
*** zhhuabj_ has quit IRC15:49
*** zhhuabj_ has joined #openstack-neutron15:50
*** dboik has quit IRC15:50
*** mlavalle has joined #openstack-neutron15:50
*** yfauser has joined #openstack-neutron15:50
*** yfauser has left #openstack-neutron15:50
*** dannywilson has quit IRC15:51
*** ronis has quit IRC15:52
*** rm_work is now known as rm_work|away15:52
*** jistr_ has joined #openstack-neutron15:53
openstackgerritAssaf Muller proposed openstack/neutron: Fix DVR functional tests resources leak  https://review.openstack.org/17546215:53
*** russellb has quit IRC15:53
amullerHenryG: carl_baldwin: jschwarz: ^15:53
jschwarzamuller, reviewing15:53
amullerThat won't solve random failures but at least we'll clean up after ourselves :)15:53
salv-orlandoamuller: like every good dog15:54
*** pradipta has joined #openstack-neutron15:54
amullersalv-orlando: I'm not sure who's the dog in your analogy but I love dogs, so, :)15:54
*** bjornar_ has joined #openstack-neutron15:55
*** Marga_ has joined #openstack-neutron15:55
jschwarzamuller, see comment15:56
*** garyk has quit IRC15:56
*** gongysh_ has quit IRC15:56
*** jistr has quit IRC15:56
*** _cjones_ has joined #openstack-neutron15:57
*** russellb has joined #openstack-neutron15:58
*** zhhuabj_ has quit IRC15:58
*** ihrachyshka has joined #openstack-neutron15:58
*** _cjones_ has quit IRC15:59
*** _cjones_ has joined #openstack-neutron15:59
*** zhhuabj_ has joined #openstack-neutron16:00
*** Longgeek has quit IRC16:00
*** moha_hunt has quit IRC16:01
*** daneyon has joined #openstack-neutron16:02
amullerjschwarz: replied, I knew that would come up, I should have expanded the commit message16:02
amulleroh well16:02
*** roeyc has quit IRC16:03
jschwarzamuller, weird, was sure create_router wasn't used anymore either than with manage_router16:04
jschwarzso +116:04
*** daneyon_ has quit IRC16:04
*** jistr_ is now known as jistr16:05
*** scheuran has quit IRC16:05
*** Marga_ has quit IRC16:05
*** Marga_ has joined #openstack-neutron16:06
jschwarzamuller, so i'm thinking that a new l3 agent is needed for the fullstack, that will not delete namespaces at all? otherwise need to add a certain suffix to the test namespaces and make sure those aren't deleted?16:07
jschwarzcode seems more complicated to patch now than before16:07
amullersome of the functional tests already use a test suffix16:08
amullerthe l3 agent ones don't16:08
amullerprefix I mean16:08
jschwarzamuller, why not?16:08
amullerthey're old16:08
amullerand crumbling16:08
amullerkind of smelly too16:08
jschwarzamuller, just like dogs, it would seem16:09
amullerwhen I created that file it was like 200 LoCs, now it's over 1.2k I think16:09
jschwarz119616:09
amullerand tests a lot of very different things16:09
*** jorgem has joined #openstack-neutron16:10
amullerjschwarz: I'll have to think more deeply about this and see what I can do16:10
amullerdon't have a solution off hand16:10
*** aepifanov has joined #openstack-neutron16:12
*** moshele has joined #openstack-neutron16:15
*** aepifanov has quit IRC16:15
*** aepifanov has joined #openstack-neutron16:15
*** bobmel has joined #openstack-neutron16:16
*** apuimedo has quit IRC16:16
*** zhhuabj_ has quit IRC16:17
*** zhhuabj_ has joined #openstack-neutron16:18
*** bobmel_ has quit IRC16:18
*** absubram has joined #openstack-neutron16:19
*** apuimedo has joined #openstack-neutron16:20
*** Marga_ has quit IRC16:22
*** Marga_ has joined #openstack-neutron16:24
*** thedodd has quit IRC16:24
*** jistr has quit IRC16:24
*** seizadi has joined #openstack-neutron16:25
*** Kennan2 has quit IRC16:29
*** baoli has quit IRC16:29
*** Kennan has joined #openstack-neutron16:29
*** aranjan has joined #openstack-neutron16:30
*** dboik_ has quit IRC16:30
*** dboik has joined #openstack-neutron16:30
*** rm_work|away is now known as rm_work16:31
pc_mmarun: hi16:31
marunpc_m: Hi.  I'm afraid I have a meeting for the next hourl16:32
*** ijw has joined #openstack-neutron16:32
*** dboik has quit IRC16:33
pc_mmarun: sure. Maybe we can hook up after?16:33
marunpc_m: yes16:33
pc_mmarun: thanks16:33
*** baoli_ has joined #openstack-neutron16:33
*** dboik has joined #openstack-neutron16:33
*** moshele has quit IRC16:33
pc_mmarun: I'm stuck and need some advise.16:33
marunpc_m: ok16:34
*** ijw_ has joined #openstack-neutron16:36
*** abregman has quit IRC16:36
*** jschwarz has quit IRC16:37
*** ijw__ has joined #openstack-neutron16:37
*** ijw has quit IRC16:38
*** aepifanov has quit IRC16:38
*** ijw_ has quit IRC16:40
*** safchain has quit IRC16:40
*** aepifanov has joined #openstack-neutron16:41
*** claudiub has joined #openstack-neutron16:41
*** Swami has quit IRC16:41
*** vivek-ebay has quit IRC16:42
*** abregman has joined #openstack-neutron16:43
*** pask81 has quit IRC16:43
*** luqas has quit IRC16:43
*** abregman has quit IRC16:44
*** jlibosva has quit IRC16:45
*** armax_ has left #openstack-neutron16:46
*** jschwarz has joined #openstack-neutron16:47
*** armax_ has joined #openstack-neutron16:47
*** Swami has joined #openstack-neutron16:48
jschwarzarmax_, do you have a second to talk about https://review.openstack.org/#/c/111580/ ?16:49
armax_sure16:49
armax_jschwarz: what about it?16:49
jschwarzwhat's the status of that API refactor you talked about last cycle?16:49
jschwarzI'm interested in re-opening it for submission for L16:49
jschwarzbut it was blocked due to the API work mark was supposed to do16:50
armax_jschwarz: then you’re best person is salv-orlando16:50
jschwarzahah! thanks :)16:50
jschwarzsalv-orlando, what do you think?16:50
*** matrohon has quit IRC16:51
*** nmagnezi_ has joined #openstack-neutron16:51
armax_jschwarz: dougwig was also not so fond of special casing API filters16:51
*** devvesa has quit IRC16:51
*** shwetaap has quit IRC16:51
dougwigarmax_, jschwarz - indeed, i was not.16:51
*** abregman has joined #openstack-neutron16:52
jschwarzarmax_, aye, I remember it was to be a uphill battle, though it's not the first code to do so16:52
armax_jschwarz: I think that until we have a way to sanely add all these useful filtering capabilities I’d hold on16:52
jschwarzdoude, the ports_list code does almost exactly the same thing i'm proposing16:52
jschwarzquestion is - how long? not like this is in any rush, but in the beginning of K we discussed it and I was under the impression that the work should be done by the end of K-316:53
dougwigjschwarz: the pecan work slipped.  that's a question for kevinbenton or blogan16:53
jschwarzarmax_, also I remember salv-orlando saying that this was a piece of sensitive code base he was willing to not edit at all because it touches so many things16:54
jschwarzWell the list is getting bigger and bigger... :)16:54
openstackgerritIhar Hrachyshka proposed openstack/neutron: tests: confirm that _output_hosts_file does not log too often  https://review.openstack.org/17544516:54
*** zhhuabj_ has quit IRC16:54
*** russellb has quit IRC16:55
*** zhhuabj_ has joined #openstack-neutron16:55
jschwarzdougwig, armax_, think I'll take this to the list - the probability of me catching so many cores at once seems very unlikely :)16:56
jschwarzthanks for the time16:57
dougwigjschwarz: no worries, good luck.  :)16:57
*** f13o has quit IRC16:57
jschwarzthanks16:58
armax_jschwarz: you could always resubmit the spec, taking the history into account and get the discussion take place on the patch itself16:58
*** russellb has joined #openstack-neutron16:58
armax_jschwarz: frankly all of us need to have a serious as to whether we want to seriously do something about the API layer or shelve it for good16:59
jschwarzarmax_, good point. do we know when the spec submission deadline is yet?16:59
armax_jschwarz: don’t know the exact that, but there’s plenty of time16:59
*** dguitarbite has joined #openstack-neutron16:59
jschwarzso I'll resubmit it. perhaps we can take it from them and hopefully we'll get an open discussion on this17:00
jschwarzs/from them/from there/g17:00
*** ijw has joined #openstack-neutron17:01
*** baoli_ has quit IRC17:01
*** dboik has quit IRC17:02
*** kawa2014 has quit IRC17:02
*** vivek-ebay has joined #openstack-neutron17:02
*** dboik has joined #openstack-neutron17:02
*** gsagie has quit IRC17:02
*** dboik has quit IRC17:03
*** dboik has joined #openstack-neutron17:03
*** armax_ has quit IRC17:03
*** moha_hunt has joined #openstack-neutron17:04
*** armax_ has joined #openstack-neutron17:04
*** ijw__ has quit IRC17:04
openstackgerritAndy Hill proposed openstack/neutron: Add use_slave DB api support  https://review.openstack.org/17549117:05
ihrachyshkaobondarev, W+1 please: https://review.openstack.org/#/c/168999/ I needed to rebase to pass gate due to unrelated bug that is already fixed17:06
*** dboik has quit IRC17:07
*** dboik has joined #openstack-neutron17:07
*** ivar-lazzaro has joined #openstack-neutron17:08
*** alagalah has joined #openstack-neutron17:09
*** ivar-lazzaro has quit IRC17:09
*** ivar-lazzaro has joined #openstack-neutron17:09
*** shwetaap has joined #openstack-neutron17:10
*** daneyon_ has joined #openstack-neutron17:11
openstackgerritAssaf Muller proposed openstack/neutron: Fix DVR functional tests resources leak  https://review.openstack.org/17546217:12
*** daneyon has quit IRC17:12
*** nyechiel has quit IRC17:13
*** ronis has joined #openstack-neutron17:14
marunamuller: Hi17:14
amullermarun: Hello sir17:14
amullerHenryG: ^17:15
marunamuller: are you interested in tackling another dvr issue?17:15
amullernew revision up17:15
marunamuller: https://bugs.launchpad.net/neutron/+bug/144626117:15
openstackLaunchpad bug 1446261 in neutron "gate-neutron-dsvm-functional race fails HA/DVR tests with network namespace not found" [High,Confirmed] - Assigned to Maru Newby (maru)17:15
amullermarun: depends... first on my plate is the random functional tests failure17:15
amullerhheeyyyy17:15
jschwarzmarun, heeeeey17:15
amullerwe might have dup bug reports17:15
marunamuller: mestery assigned to me thinking that the timeout changes might have been related17:15
jschwarzyep17:15
jschwarzthat's fullstack fault17:15
jschwarzwell, partially17:15
marunamuller: ah, so you're already working on it?17:15
marunjschwarz: you too?17:15
mesterymarun: Yes, I had hoped you coudl triage, looks like you did, thanks!17:16
jschwarzyeah\17:16
jschwarzmarun, https://bugs.launchpad.net/neutron/+bug/144628417:16
openstackLaunchpad bug 1446284 in neutron "functional tests fail non-deterministicly because of full-stack" [Undecided,New] - Assigned to Carl Baldwin (carl-baldwin)17:16
amullermarun: I'm on that yeah17:16
marunmriedem commented on the other bug that https://github.com/openstack/neutron/commit/61aa4a57b17594bb0412f870f361a8a35ec07b62 might have something to do with it17:16
marunthe timing is suspicious, at least17:16
amullermarun: maybe there's 2 separate issues17:16
amullermarun: jschwarz figured out that the full stack l3 agent that starts up is destroying namespaces from concurrent functional tests17:17
jschwarzmarun, I tracked it down the the l3 agent deleting "unknown" namespaces it doesn't know17:17
jschwarzsee my bug report17:17
amullerbut that full stack test was merged after Swami's test17:17
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS: Revise functional test hooks  https://review.openstack.org/16811517:17
jschwarzI think I did see that test fail regardless of the fullstack locally17:18
jschwarzlet me check17:18
marunjschwarz, amuller: I thought the idea was to only clean up namespaces in tests whose ownership was clear?17:18
maruni.e. tests clearly mark resources they create so they can clean them up17:18
amullermarun: the failure is due to agent code not test code17:18
marunamuller: so the agents need that same constraint17:19
jschwarzyep17:19
amullermarun: yeah I was about to dive in to it17:19
marunamuller: cool beans17:19
jschwarzmarun, amuller, also if I have you both here17:19
amullerthe initial gut reaction is that when the agent starts it should not delete namespaces that are marked for testing17:19
marunamuller: can you take ownership of the other bug too, then?17:19
amullermarun: you can assign it to me, jschwarz can you close yours as dup?17:19
marunamuller: right.  maybe any namespace that contains a : or other special identifying character should be considered off-limits17:20
jschwarzmarun, amuller, re: that whole "add a rabbitmq exchange per test" won't work probably since the "topics" that are used are basically exchanges (run rabbitmqctl list_exchanges on your devstack)17:20
marunjschwarz: dynamic topics it is...17:20
jschwarzmarun, was afraid you'll say that17:20
jschwarz^_^17:20
marunjschwarz: if you can find a way to make exchanges work, more power to you.17:20
marunjschwarz: the static topics are an artifact of not designing for testability, though17:21
*** zhhuabj_ has quit IRC17:21
jschwarzamuller, can't close it (doesn't appear in my list of "change status to") - ask marun17:21
*** zhhuabj_ has joined #openstack-neutron17:21
marundone17:21
jschwarzmarun, I'll need to dive into it, but not sure I'll have enough time17:21
jschwarzcarl_baldwin, ^17:22
* carl_baldwin already reading back.17:22
jschwarzmarun, I'll try to devote some time for this next week but management probably wants me doing some other stuff17:23
jschwarzmarun, it will probably end up with a long-term spec though17:23
marunjschwarz: ok17:23
jschwarzmarun, how was your weekend? :)17:23
marunjschwarz: not long enough.  how about yours? :)17:24
jschwarzmarun, not long enough.  not enough GTA5 :<17:24
*** achanda has joined #openstack-neutron17:24
carl_baldwinI’m sure I can find time to address these bugs.17:24
jschwarzalas, 3rd world problems17:24
amullerjschwarz: Are you familiar with the concept of vacation days?17:24
jschwarzamuller, I am. The college I go to doesn't17:24
amullerjschwarz: oh common17:25
amulleryou don't really have to go to classes17:25
amullererr, I mean, don't skip school17:25
jschwarzI feel bad if I don't17:25
jschwarzI already skipped a few classes last week (and one today, in fact)17:25
*** sudipto has joined #openstack-neutron17:27
*** zhenguo has quit IRC17:27
*** tflynn has joined #openstack-neutron17:28
jschwarzrighto, I'm off17:30
jschwarzsee you around guys :)17:30
*** jschwarz has quit IRC17:30
*** armax_ has left #openstack-neutron17:32
*** aswadr has quit IRC17:32
amullermarun: please take a look at https://review.openstack.org/#/c/175462/17:32
*** armax_ has joined #openstack-neutron17:33
* marun lookin17:33
amullermarun: there's a lot of context in the comments of the first PS17:33
*** jorgem has quit IRC17:33
*** jpena has quit IRC17:34
*** abregman has quit IRC17:34
openstackgerritCedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional/fullstack tests  https://review.openstack.org/14341217:35
*** russellb has quit IRC17:36
marunamuller: /url 217:36
marunoops, sorry17:36
*** irenab has joined #openstack-neutron17:37
*** dboik has quit IRC17:37
*** dboik has joined #openstack-neutron17:38
marunamuller: Isn't there a more explicit exception you could trap for?17:38
*** melwitt has joined #openstack-neutron17:38
amullermarun: maybe Runtime, dunno17:38
*** harlowja_away is now known as harlowja17:38
amullermarun: it won't be fool proof17:38
amulleror future proof17:39
marunamuller: Maybe the underlying code needs to be fixed, then?17:39
amullerwho knows what errors you might get when you try to delete a router that's not there17:39
marunamuller: trapping for Exception is almost entirely an anti-pattern (unless you're at least logging the problem)17:39
marunamuller: I think there should be code in the deletion method that throws a NotFound based on any number of possible scenarios.17:39
marunamuller: you're right that the test code shouldn't be responsible for determining that condition17:40
marunamuller: the test wrapper should know how to differentiate between failure modes, though.17:40
*** russellb has joined #openstack-neutron17:40
*** dboik has quit IRC17:40
*** zhhuabj_ has quit IRC17:40
amullermarun: I'm OK with this since safe_delete_router can only be used with manage_router (Since I made it an internal method) during its cleanup, and we have tests that use delete_router (The non-safe version)17:40
*** zhhuabj_ has joined #openstack-neutron17:41
*** dboik has joined #openstack-neutron17:41
amullermarun: I don't think this fix requires changing deletion error handling in the agent itself17:41
amullerwe have coverage for deletion17:41
marunamuller: Can the deletion error handling indicate specifically that the targeted resources cannot be found?17:42
marunamuller: It's not a matter of 'coverage'17:42
marunamuller: It's a matter of encapsulating detection of expected failure conditions in the code that expects the failure.17:42
amullermarun: we have code in the L3 agent that checks if the router exists in the in-memory cache17:43
amullerif it doesn't, you return early17:43
marunamuller: that doesn't sound like the case we're talking about17:43
amullerhowever in the functional tests we try to simulate agent restarts in a weird way17:43
*** luqas has joined #openstack-neutron17:44
amullerby creating an agent and a router, then configuring the router again with a new agent instance17:44
*** moshele has joined #openstack-neutron17:44
marunamuller: does the l3 agent know how to clean up after itself?17:44
marunamuller: or is that cleanup mainly the responsibility of the functional tests?17:44
amullermarun: partially, depends...17:44
*** aranjan has quit IRC17:44
*** ZZelle has quit IRC17:45
marunamuller: 'partially' sounds a bit ominous to me'17:45
*** criptoverso has quit IRC17:45
marunamuller: Is there a reason that resource management shouldn't be the responsibility of the agent?17:45
amullerit's complicated I guess. The agent starts by deleting namespaces in the (get_routers RPC method) / (currently present namespaces) set17:45
amullermarun: this is what's screwing us over in the full stack tsts17:46
amullertests*17:46
amullerthen you have the neutron-netns-cleanup script17:46
*** baoli has joined #openstack-neutron17:46
amullermarun: the agent has to be told to create and delete routers17:47
amullermarun: what would you propose?17:47
*** russellb has quit IRC17:47
*** yfried__ has joined #openstack-neutron17:48
*** luqas has quit IRC17:48
marunamuller: I mainly want the router deletion method to indicate via an exception that a router doesn't exist to be deleted.17:48
marunamuller: So that the method of detecting a missing router is encapsulated in the method.17:49
*** aranjan has joined #openstack-neutron17:50
amullermarun: that code would be pretty weird to exist in the agent. Bear with me: It'd first check that the router exists in the internal cache. If it doesn't, return. If it goes, then it goes to check if the router namespace(s) exist on the system (Why would they?), if not, it exits. There's two issues here:17:50
amuller1) You could have other resources on the system even without the namespace (Like processes)17:50
amuller2) Why would a router exist in the cache but not on the system? That can only happen in the functional testing suite, specifically because of the tests that simulate agent restarts17:51
marunamuller: tell me about the router cache17:51
*** russellb has joined #openstack-neutron17:52
marunamuller: if the agent dies or is restarted in production, does the router cache persist?17:52
amullermarun: self.router_info likes long walks and prefers dry red wine. It's favorite romantic era Czech composer is of course Tchaikovsky.17:52
*** jorgem has joined #openstack-neutron17:53
amullermarun: It's populated when the agent starts17:53
marunamuller: so, agent dies17:53
*** jprovazn has joined #openstack-neutron17:53
marunamuller: lost cache17:53
marunamuller: how does agent figure out the state of the system?17:53
marunagent -> restarted agent17:53
amullermarun: calls out to the controller when it starts to get all of the routers that are scheduled on it. It configures them, then deletes orphaned namespaces (Routers that were deleted when the agent was down basically)17:54
*** crc32 has joined #openstack-neutron17:54
marunamuller: so the agent does know how to manage resources, then.17:55
marunamuller: in the context of a restart, anyway17:55
amullermarun: OK, the term 'manage resources' in this context is very vague to me17:55
amullerit means something to you, I don't know what it means to me17:55
*** cference_ has quit IRC17:56
*** dttocs has quit IRC17:56
*** nivtuckio has quit IRC17:56
*** ijw has quit IRC17:58
*** cference has joined #openstack-neutron17:58
openstackgerritCedric Brandily proposed openstack/neutron: Define FakeMachine helper for functional/fullstack tests  https://review.openstack.org/14341217:58
*** ijw has joined #openstack-neutron17:59
openstackgerritCarl Baldwin proposed openstack/neutron-specs: Specification to run an L3 router without dedicated public IP  https://review.openstack.org/17551718:00
*** dguitarbite has quit IRC18:00
*** dboik_ has joined #openstack-neutron18:01
*** annegentle has joined #openstack-neutron18:01
*** seizadi1 has joined #openstack-neutron18:02
*** seizadi has quit IRC18:02
*** zhhuabj_ has quit IRC18:03
amullermarun: So I don't know what to do about your comment, I don't know what change I could make to the agent that would make sense18:03
*** shashankhegde has joined #openstack-neutron18:03
*** ijw has quit IRC18:03
*** zhhuabj_ has joined #openstack-neutron18:03
marunamuller: I'm probably getting too esoteric (also am talking on another channel at the same time).18:04
openstackgerritCarl Baldwin proposed openstack/neutron-specs: Specification to eliminate the DVR fip ns  https://review.openstack.org/17465718:04
*** dboik has quit IRC18:05
*** ijw has joined #openstack-neutron18:06
*** alagalah has quit IRC18:08
*** vishwanathj has quit IRC18:08
*** vishwanathj has joined #openstack-neutron18:09
*** jorgem has quit IRC18:09
marunamuller: I'd be happy if you could provide a clear indication of 'router missing' rather than requiring the caller to decide.18:09
*** rushil has quit IRC18:10
*** zhhuabj_ has quit IRC18:11
*** zhhuabj_ has joined #openstack-neutron18:11
*** vishwanathj has quit IRC18:11
*** vishwanathj has joined #openstack-neutron18:12
*** alagalah has joined #openstack-neutron18:13
*** sbalukoff has joined #openstack-neutron18:13
*** vishwanathj has quit IRC18:16
*** tsg has joined #openstack-neutron18:17
*** zhhuabj_ has quit IRC18:18
*** dboik_ has quit IRC18:19
*** slaweq has quit IRC18:19
*** ihrachyshka has quit IRC18:20
*** zhhuabj_ has joined #openstack-neutron18:21
*** irenab has quit IRC18:21
*** vivek-eb_ has joined #openstack-neutron18:27
*** vivek-ebay has quit IRC18:27
*** zhhuabj_ has quit IRC18:30
*** zhhuabj_ has joined #openstack-neutron18:31
*** padkrish has joined #openstack-neutron18:33
*** dboik has joined #openstack-neutron18:33
*** ZZelle has joined #openstack-neutron18:33
*** padkrish has quit IRC18:36
*** padkrish has joined #openstack-neutron18:37
*** padkrish has quit IRC18:37
*** padkrish has joined #openstack-neutron18:37
*** shivharis has joined #openstack-neutron18:38
*** banix has quit IRC18:38
*** sudipto has quit IRC18:40
openstackgerritCedric Brandily proposed openstack/neutron: Replace BaseIPVethTestCase by FakeMachine  https://review.openstack.org/16029018:41
*** banix has joined #openstack-neutron18:41
*** baoli has quit IRC18:41
*** doude has quit IRC18:42
*** ZZelle has quit IRC18:42
openstackgerritCedric Brandily proposed openstack/neutron: Replace BaseIPVethTestCase by FakeMachine  https://review.openstack.org/16029018:43
*** nmagnezi_ has quit IRC18:43
*** padkrish has quit IRC18:43
*** seizadi1 has quit IRC18:44
*** seizadi has joined #openstack-neutron18:44
*** padkrish has joined #openstack-neutron18:44
HenryGdougwig: ping18:47
*** dboik has quit IRC18:48
*** ZZelle has joined #openstack-neutron18:48
*** rushil has joined #openstack-neutron18:49
*** dannywilson has joined #openstack-neutron18:52
*** sudipto has joined #openstack-neutron18:53
*** shivharis has quit IRC18:54
*** shivharis has joined #openstack-neutron18:54
*** pradipta has quit IRC18:54
*** imcsk8 has quit IRC18:54
*** imcsk8 has joined #openstack-neutron18:54
*** dannywilson has quit IRC18:56
HenryGmarun: ping18:57
marunHenryG: pong18:57
marunpc_m: oh, pong18:57
pc_mmarun: hi18:57
*** dttocs has joined #openstack-neutron18:57
*** dboik has joined #openstack-neutron18:57
HenryGmarun: Do you know if the *aas repos will have API tests in their trees, or in the neutron tree?18:57
dougwigHenryG: ack18:58
HenryGdougwig: same question I asked marun ^^18:58
dougwigHenryG: they'll be moving into the *aas trees as soon as I can get some cycles to do so.18:58
dougwig(or anyone else)18:58
marunHenryG: they should have them in their own tree18:59
marunHenryG: what dougwig said18:59
marunpc_m: hi18:59
marunHenryG: each repo should own their tests18:59
pc_mmarun: I'm stuck on https://review.openstack.org/#/c/168115/ and could use some help. For the StrongSwan job, which actually does some calls that use rootwrap, it is failing on the config file.18:59
*** sudipto_ has joined #openstack-neutron19:00
pc_mmarun: I thought I had it figured out, but I guess not. The rootwrap config file and filters all seem to be placed in the right area, but I get a test failure.19:00
marunpc_m: I recommended you not duplicate the script19:00
pc_mmarun: Which script?19:00
marunpc_m: the neutron configure script19:00
*** zhhuabj_ has quit IRC19:01
*** carlp has joined #openstack-neutron19:01
pc_mmarun: well, there are some differences with what VPN needs, so just to get things working, I'm trying to copy the and get the script working.19:01
*** lori is now known as lori|away19:02
*** zhhuabj_ has joined #openstack-neutron19:02
*** dttocs has quit IRC19:02
*** seizadi has quit IRC19:03
HenryGdougwig: what about neutron/tests/api/test_service_type_management.py ?19:03
*** seizadi has joined #openstack-neutron19:03
HenryGdougwig: Is that something that will stay in neutron?19:03
*** seizadi has quit IRC19:03
*** seizadi has joined #openstack-neutron19:04
*** seizadi has quit IRC19:04
HenryGdougwig: It currently has a skip on bug 140037019:04
openstackbug 1400370 in neutron "Need to split advanced services out of neutron (placeholder bug to skip tempest tests temporarily)" [Medium,Confirmed] https://launchpad.net/bugs/1400370 - Assigned to Doug Wiegley (dougwig)19:04
dougwigit think the service-type extension lives in neutron, doesn't it?19:04
*** seizadi has joined #openstack-neutron19:04
dougwigat the same time, neutron never has service providers by itself.19:04
pc_mmarun: any idea on the cause of the failure?19:05
marunpc_m: where's the failure?19:05
*** jorgem has joined #openstack-neutron19:06
HenryGdougwig: Trying to figure out why it is skipping the (very rudimentary) test. I removed the skip and it works fine.19:06
pc_mmarun: It's just finishing the run... https://jenkins07.openstack.org/job/check-neutron-vpnaas-dsvm-functional-sswan/29/console19:06
dougwigHenryG: might be cruft that it got left skipped19:06
pc_mmarun: /opt/stack/new/neutron-vpnaas/.tox/dsvm-functional-sswan/bin/neutron-rootwrap-daemon: Incorrect configuration file: /opt/stack/new/neutron-vpnaas/.tox/dsvm-functional-sswan/etc/neutron/rootwrap.conf19:07
marunpc_m: I'm not sure what would cause that error19:07
HenryGdougwig: do you know if more service-type management API tests are planned? We could remove the skip or delete that file since it doesn't really test anything useful.19:07
dougwigis neutron a dependency in the tox env?19:07
dougwigpc_m: ^^19:07
dougwigHenryG: none that I'm aware of.19:08
marunpc_m: I'm not sure that file is saved as part of the run19:08
marun(probably an oversight we should fix)19:08
marunpc_m: it could be missing for all I know19:08
*** sudipto_ has quit IRC19:08
*** sudipto has quit IRC19:08
marunpc_m: what happens when you try to run locally?19:08
*** slaweq has joined #openstack-neutron19:08
*** aduarte has joined #openstack-neutron19:09
pc_mdougwig: yes neutron is a dependency in tox19:09
*** ijw has quit IRC19:10
pc_mmarun: Well, it passes, but I had to tweak the gate-hook.sh as my dev tree is different (no '/opt/stack/new', no devstack under /opt/stack). I don't know how to run it without changing things.19:11
*** nplanel_ has joined #openstack-neutron19:11
pc_mmarun: In looking at the log, it is placing the rootwrap.conf in the expected place, and trying to access it in the test. I'm baffled.19:12
HenryGdougwig: OK, I am going to remove the skip so we can close the bug. Hopefully someone will add more useful tests later.19:12
*** zhhuabj_ has quit IRC19:13
openstackgerritMerged openstack/neutron: Clarify the init logic for the ML2 plugin  https://review.openstack.org/17455519:13
pc_mmarun: The test failure is in PRRQ now (job finished).19:13
*** zhhuabj_ has joined #openstack-neutron19:13
*** dboik_ has joined #openstack-neutron19:13
*** dboik has quit IRC19:13
*** yfried__ is now known as yfried|afk19:14
*** tsg has quit IRC19:14
openstackgerritHenry Gessau proposed openstack/neutron: Remove skip of service-type management API test  https://review.openstack.org/17554619:14
*** padkrish has quit IRC19:14
marunpc_m: I would suggest mirroring the environment in the gate locally19:15
*** padkrish has joined #openstack-neutron19:15
marunpc_m: that's the whole reason I wrote the configure script, so we didn't have to debug through a keyhole.19:15
pc_mmarun: ok. I'll try.19:15
marunpc_m: I need to eat, I'll be back in a bit.19:15
pc_mmarun: ok.19:16
openstackgerritMerged openstack/neutron: Avoid double-hopping deletes for security group rules  https://review.openstack.org/17466619:16
openstackgerritAssaf Muller proposed openstack/neutron: Log caught exceptions while deleting a router  https://review.openstack.org/17554719:17
*** baoli has joined #openstack-neutron19:18
*** ijw has joined #openstack-neutron19:18
*** padkrish has quit IRC19:19
openstackgerritCedric Brandily proposed openstack/neutron: Replace BaseLinuxTestCase by BaseSudoTestCase  https://review.openstack.org/16191319:19
*** baoli has quit IRC19:21
*** nyechiel has joined #openstack-neutron19:21
*** baoli has joined #openstack-neutron19:21
*** padkrish has joined #openstack-neutron19:21
openstackgerritAssaf Muller proposed openstack/neutron: Log caught exceptions while deleting a router  https://review.openstack.org/17554719:22
*** ZZelle_ has joined #openstack-neutron19:22
*** yfried|afk is now known as yfried__19:22
HenryGarosen: ping19:23
*** shashankhegde has quit IRC19:24
amullercarl_baldwin: What do you think about this: https://review.openstack.org/#/c/175547/19:25
*** nyechiel has quit IRC19:27
carl_baldwinamuller: reading...19:28
*** aix has quit IRC19:29
*** ajmiller_ has joined #openstack-neutron19:29
arosenHenryG: pong19:31
carl_baldwinProbably better to catch the exception and log it at least.19:31
carl_baldwinamuller: ^19:31
amullercarl_baldwin: ack19:31
carl_baldwinamuller: I’d hate to kick off a full sync in this case.  Looks like you’ve avoided that.19:31
HenryGarosen: https://review.openstack.org/17177019:31
amullercarl_baldwin: yeah that's partially why I did not set full_sync in the safe_delete method itself19:32
amullermarun: Would you be content if I rebase https://review.openstack.org/#/c/175462/ on https://review.openstack.org/#/c/175547/, and have the functional test use the same method the agent itself uses?19:33
*** ajmiller has quit IRC19:33
amullermarun: instead of the functional test framework providing a safe delete method, the agent does19:33
*** ajmiller_ is now known as ajmiller19:34
arosenHenryG: k, let me fix that one up.19:34
HenryGarosen: thanks19:34
*** annegentle has quit IRC19:36
*** crose has joined #openstack-neutron19:37
arosenarmax_:  around?19:38
armax_arosen: yes19:38
amullermarun: btw gongysh fixed up https://review.openstack.org/#/c/160430/19:39
arosenarmax_: https://review.openstack.org/#/c/171770/1/neutron/db/db_base_plugin_v2.py19:39
arosenreplied19:39
*** nmagnezi_ has joined #openstack-neutron19:41
armax_arosen: ok, what about the other comment I made, that was the actual reason for -1?19:42
*** nyechiel has joined #openstack-neutron19:42
*** padkrish has quit IRC19:43
armax_arosen: but hang on…I’d have to remember what I was thinking ;)19:43
armax_arosen: line 1256 seems to have the same conditional19:43
*** padkrish has joined #openstack-neutron19:43
arosenarmax_:  right I'll need to update that line too.19:43
armax_arosen: it’s said we spilled that logic in the base class19:44
armax_*sad19:44
arosenI agree19:44
*** padkrish_ has joined #openstack-neutron19:45
*** padkrish has quit IRC19:45
*** ronis has quit IRC19:45
*** luqas has joined #openstack-neutron19:46
openstackgerritAaron Rosen proposed openstack/neutron: _create_subnet_from_implicit_pool assumes external network extension  https://review.openstack.org/17177019:47
*** ajo has quit IRC19:49
*** seizadi has quit IRC19:51
*** luqas has quit IRC19:51
*** seizadi has joined #openstack-neutron19:53
*** nlahouti has quit IRC19:54
*** shashankhegde has joined #openstack-neutron19:55
*** shihanzhang has joined #openstack-neutron19:56
*** tsg has joined #openstack-neutron19:56
*** julim has quit IRC19:58
*** liusheng has quit IRC19:58
*** liusheng has joined #openstack-neutron19:59
*** hanzhang has quit IRC19:59
*** zhhuabj_ has quit IRC20:01
*** amuller has quit IRC20:01
*** zhhuabj_ has joined #openstack-neutron20:01
*** jckasper has quit IRC20:04
*** padkrish_ has quit IRC20:04
*** dttocs has joined #openstack-neutron20:04
*** padkrish has joined #openstack-neutron20:05
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: Test patch to test dvr-multinode(*DO-NOT-MERGE*)  https://review.openstack.org/17555920:06
*** zhhuabj_ has quit IRC20:07
* ijw is so disappointed in armax_20:09
armax_ijw: what did I do?20:09
ijwWell, you didn't, that's the problem20:10
*** tsg has quit IRC20:12
*** jprovazn has quit IRC20:13
*** fawadkhaliq has joined #openstack-neutron20:19
*** yfried__ is now known as yfried|afk20:20
*** crose has quit IRC20:20
*** zhhuabj_ has joined #openstack-neutron20:21
openstackgerritMerged openstack/neutron: Replace custom method call logger with oslo.log helper  https://review.openstack.org/16899920:21
*** achanda has quit IRC20:22
*** tsg has joined #openstack-neutron20:28
openstackgerritDane LeBlanc proposed openstack/neutron: Reuse callers session in ML2 DB methods  https://review.openstack.org/17332020:30
*** redbeard has joined #openstack-neutron20:33
*** achanda has joined #openstack-neutron20:35
*** tsg has quit IRC20:35
*** zhhuabj_ has quit IRC20:37
redbearddunno wether it is neutron related or not, but if I (in icehouse) associate a floating-ip while spawning/building an instance, it takes 10 minutes or more for "nova list" to know about the floating ip20:37
armax_ijw: I know, father duties got me tired at the end of the week, and the couch was so inviting that I gave in at the end:)20:38
*** jorgem has quit IRC20:39
*** zhhuabj_ has joined #openstack-neutron20:39
*** padkrish has quit IRC20:40
*** jorgem has joined #openstack-neutron20:40
*** padkrish has joined #openstack-neutron20:40
*** padkrish_ has joined #openstack-neutron20:42
*** padkrish has quit IRC20:42
*** kevinbenton has joined #openstack-neutron20:43
*** jorgem has quit IRC20:44
*** kevinbenton has quit IRC20:44
*** kevinbenton has joined #openstack-neutron20:44
ijwChildren or beer?20:45
ijwHonestly, you have all the easy choices...20:45
sc68calwhy not both?20:48
*** dboik has joined #openstack-neutron20:48
*** padkrish_ has quit IRC20:50
marunredbeard: that might be a question for #openstack-nova20:51
*** dboik_ has quit IRC20:51
*** nlahouti has joined #openstack-neutron20:52
redbeardmarun, I think so too. thanks :)20:52
*** zhhuabj_ has quit IRC20:52
marunredbeard: nova's responsible for updating its cache, we can't influence that on the neutron side20:53
redbeardmh, well. I see. neutron floating-ip-list gives me the correct output20:55
openstackgerritAdolfo Duarte proposed openstack/neutron: Refactoring to adhere to coding convention  https://review.openstack.org/15923020:55
*** annegent_ has joined #openstack-neutron20:55
*** haleyb_ is now known as haleyb20:56
*** rook_ has joined #openstack-neutron20:58
*** jckasper has joined #openstack-neutron20:59
*** akanksha has joined #openstack-neutron21:02
*** zhhuabj_ has joined #openstack-neutron21:03
*** slaweq has quit IRC21:06
*** tiswanso has joined #openstack-neutron21:09
openstackgerritSalvatore Orlando proposed openstack/neutron: Amend VMware NSX readme  https://review.openstack.org/17557421:10
*** rook_ has quit IRC21:11
*** cgoncalves has quit IRC21:12
*** padkrish has joined #openstack-neutron21:12
*** jbell8 has joined #openstack-neutron21:12
*** tiswanso has quit IRC21:16
*** tiswanso has joined #openstack-neutron21:17
*** banix has quit IRC21:19
*** cference has quit IRC21:19
*** moha_hunt has quit IRC21:20
*** moshele has quit IRC21:22
*** jgrimm is now known as zz_jgrimm21:25
*** dboik has quit IRC21:26
*** jaypipes has quit IRC21:26
*** dboik has joined #openstack-neutron21:27
*** cgoncalves has joined #openstack-neutron21:31
*** rpothier has quit IRC21:33
*** hichihara has joined #openstack-neutron21:34
*** jbell8 has quit IRC21:44
*** bjornar_ has quit IRC21:44
*** tiswanso has quit IRC21:45
*** tiswanso has joined #openstack-neutron21:45
*** mwagner_lap has quit IRC21:46
*** zhhuabj_ has quit IRC21:47
ZZelle_marun, hi21:47
marunZZelle_: hi21:47
*** zhhuabj_ has joined #openstack-neutron21:47
marunZZelle_: ah, recheck passed21:47
ZZelle_https://review.openstack.org/143412 survives jenkins checks :)21:47
*** nyechiel has quit IRC21:47
marunZZelle_: I've +2'd, and will do the same for the descendents21:47
ZZelle_marun, thx21:48
marunZZelle_: we'll need a second like HenryG, armax_ or mestery to approve.21:48
*** shashankhegde has quit IRC21:48
marunZZelle_: thank you for your patience.  I'm hoping we can move a bit quicker this cycle21:48
marunZZelle_: I'm whittling away at my desire to get things perfect on merge.  I think it's preferable to iterate faster and fix our mistakes as we go than try to anticipate them all.21:49
*** tsg has joined #openstack-neutron21:49
*** yfauser has joined #openstack-neutron21:50
*** yfauser has left #openstack-neutron21:50
*** tiswanso has quit IRC21:50
marunZZelle_: hi21:51
marunhttps://review.openstack.org/#/c/130588/13/neutron/tests/unit/extensions/test_l3_ext_gw_mode.py21:51
marunI'm not sure I understand why you would run x number of tests on a simple configuration change21:51
marunZZelle_: can't that change be tested in isolation?21:51
*** sripriya has joined #openstack-neutron21:51
ZZelle_marun, let me look it's an old change21:52
marunZZelle_: I was just going through the list looking for more test-related changes.  Should I not review?21:52
ZZelle_marun, it's a "feature" change not a test improvement21:53
marunZZelle_: I get that, but running x number of tests for a simple configuration change does not seem worth it21:53
marunZZelle_: The change should be isolated for testing purposes.21:53
*** yamahata has joined #openstack-neutron21:54
*** busterswt has quit IRC21:54
ZZelle_marun, only test_update_router_gw_* are required21:56
*** yamamoto has joined #openstack-neutron21:56
marunZZelle_: right, so creating a new test case that runs all the tests in that class does not seem reasonable.21:56
ZZelle_marun, about 100lines for a unittest test stUP :|21:56
marunZZelle_: that's not a unit test :)21:56
ZZelle_s/stUP/setUp21:56
marunZZelle_: Isolate the targeted change - by refactoring if necessary - so that the test change is commensurate with the code change.21:57
ZZelle_ok21:57
marunZZelle_: If you want you can add a method like 'get_default_snat' and test that21:58
pc_mmarun: hi21:58
marunZZelle_: or maybe init_router_info()?  It could init the dict and call setdefault() on it to set the default snat flag21:59
marunpc_m: hi21:59
pc_mmarun: I reworked the configure_for_func_test.sh and tox.ini to be able to run under /opt/stack/new/... like the gate. I think it is working (I think is is still kludgey though).21:59
ZZelle_marun, good idea21:59
*** shashankhegde has joined #openstack-neutron22:00
marunpc_m: great!22:00
*** absubram has quit IRC22:00
pc_mmarun: Current failure (different than what was seen before) is that a VPN script is importing net_helpers.py from neutron and it is trying to import ovs_lib, which doesn't exist.22:00
pc_mmarun: It says it cannot import, but the file is there...22:01
marunpc_m: can you give me a github link to the import?22:02
openstackgerritCedric Brandily proposed openstack/neutron: Correct inconsistent enable_snat management  https://review.openstack.org/13019922:02
pc_mmarun:  here's the failure... http://paste.openstack.org/show/204926/22:02
*** sripriya has quit IRC22:03
*** seizadi has quit IRC22:03
pc_mmarun: this is odd...22:03
*** seizadi has joined #openstack-neutron22:03
*** banix has joined #openstack-neutron22:03
pc_mmarun: In neutron repo the file exists... neutron.agent.linux ovs_lib22:04
*** sripriya has joined #openstack-neutron22:04
marunpc_m: which repo?22:04
*** seizadi has quit IRC22:04
*** seizadi1 has joined #openstack-neutron22:04
marunpc_m: I don't see it there22:04
marunhttps://github.com/openstack/neutron/tree/master/neutron/agent/linux22:04
marunhttps://github.com/openstack/neutron/tree/master/neutron/agent/ovsdb22:04
marunit's moved22:04
*** melwitt has quit IRC22:04
pc_mmarun: Ah! I had a repo with it, but it was not under .tox/dsvm-functional-sswan/src/neutron/...22:05
marunpc_m: you may want to 'tox -r'22:06
pc_mso my env is old?22:06
*** yfauser has joined #openstack-neutron22:07
*** Swami has quit IRC22:07
*** dboik has quit IRC22:09
*** ijw has quit IRC22:11
*** dboik has joined #openstack-neutron22:11
*** yfauser has quit IRC22:11
*** yfauser has joined #openstack-neutron22:11
*** yfauser has left #openstack-neutron22:11
*** ijw has joined #openstack-neutron22:11
*** zhhuabj_ has quit IRC22:12
*** zhhuabj_ has joined #openstack-neutron22:13
*** ijw has quit IRC22:16
*** jbell8 has joined #openstack-neutron22:17
*** redbeard has quit IRC22:17
*** nmagnezi_ has quit IRC22:17
pc_mmarun: I tried tox -r, but get a message "ERROR: unknown environment 'pylint'". I must have something wrong in the tox.ini file now.22:19
*** yfauser has joined #openstack-neutron22:19
pc_mmarun: I did rm -rf .tox, and am trying again now.22:19
*** yfauser has left #openstack-neutron22:19
*** jbell8 has quit IRC22:21
*** sripriya has quit IRC22:22
*** ijw has joined #openstack-neutron22:23
*** fawadkhaliq has quit IRC22:24
*** yfauser has joined #openstack-neutron22:24
*** rook_ has joined #openstack-neutron22:24
*** yfauser has left #openstack-neutron22:24
*** tsg has quit IRC22:25
*** rushil has quit IRC22:25
marunpc_m: tox -r requires an environment22:26
marunpc_m: e.g. 'tox -r -e dsvm-functional' will recreate the tox env22:26
marunpc_m: but removing .tox works as well22:26
pc_mmarun: duh... I'm geting tired, I guess...22:26
pc_mmarun: I still get the same error... it is accessing net_helpers.py in .tos area (/opt/stack/new/neutron-vpnaas/.tox/dsvm-functional-sswan/src/neutron/neutron/tests/common/net_helpers.py)22:27
pc_mmarun: That is trying to import neutron.agent.linux ovs_lib, which doesn't exist in .tox path22:27
pc_mmarun: Looks like ovs_lib.py is in neutron/agent/common/ and not neutron/agent/linux. I don't know why net_helpers.py points to the wrong place.22:30
marunpc_m: old code22:30
*** seizadi1 has quit IRC22:31
*** seizadi has joined #openstack-neutron22:31
*** achanda has quit IRC22:31
pc_mmarun: I'm still confused...  test code is accessing net_helpers.py from inside the .tox area. That file, is looking for ovs_lib.py in linux dir, but the file is in common dir in the same .tox area22:33
openstackgerritMaru Newby proposed openstack/neutron: Fix test discovery for api and functional paths  https://review.openstack.org/17187422:33
marunpc_m: Isn't net_helpers simply importing a module that has moved?22:35
marunpc_m: Updating the import in your tree should fix things.22:35
kevinbentoncarl_baldwin: i'm getting some pretty bad deadlocks while trying to add a subnet to a network that i'm also attaching ports to at the the same time22:36
kevinbentoncarl_baldwin: on the latest master22:36
kevinbentoncarl_baldwin: is this a known issue that someone is working on?22:36
kevinbentoncarl_baldwin: related to that create_port thread?22:37
*** jaypipes has joined #openstack-neutron22:37
*** shwetaap has quit IRC22:38
pc_mmarun: Correct. It appears net_helpers.py is importing from the wrong place.22:38
pc_mmarun: But net_helpers.py is not in the VPN tree. It is in the neutron tree.22:38
pc_mmarun: So it is broken in neutron.22:39
*** pradip has quit IRC22:39
pc_mhttps://github.com/openstack/neutron/blob/master/neutron/tests/common/net_helpers.py#L2422:39
*** pradip has joined #openstack-neutron22:39
pc_mmarun: Maybe this file is not tested?22:40
carl_baldwinkevinbenton: I’m not aware.22:40
*** baoli has quit IRC22:40
openstackgerritDane LeBlanc proposed openstack/neutron: Reuse callers session in ML2 DB methods  https://review.openstack.org/17332022:40
*** Swami has joined #openstack-neutron22:41
marunpc_m: maybe?22:41
pc_mmarun: Am I loosing my mind? Wait don't answer that22:44
pc_mmarun: There seem to be several tests that use net_helpers import.22:45
marunpc_m: that doesn't make a lot of sense, I agree.22:45
*** _cjones_ has quit IRC22:46
*** wuhg has joined #openstack-neutron22:47
marunpc_m: That kind of thing sometimes can run locally due to stale pyc files, but that shouldn't happen in the gate.22:47
pc_mmarun: Yeah, I'm sort of shocked here...22:47
*** luqas has joined #openstack-neutron22:48
marunpc_m: I have it locally, I think I might be outdated.22:48
marunpc_m: hold on22:48
marunpc_m: ah, it was deleted recently22:49
marunpc_m: ah...22:49
marunpc_m: :/22:49
*** _cjones_ has joined #openstack-neutron22:49
marunpc_m: I think our discovery problem masked the problem in a recent commit22:49
marunpc_m: my change should fail the tests22:49
marunhttps://review.openstack.org/#/c/171874/22:49
marunarmax_: ^22:49
pc_mmarun: that's what I was wondering - it the discovery problem was hiding this.22:50
armax_marun: way ahead of you :)22:50
armax_marun: for once22:50
openstackgerritMaru Newby proposed openstack/neutron: Fix test discovery for api and functional paths  https://review.openstack.org/17187422:50
marunso, the rebased change should fail22:50
marunI'll revise with a fix22:50
marunarmax_: you saw this problem?22:52
armax_marun: hang on, didn’t you change just the commit message?22:52
armax_marun: /me looks back22:52
*** luqas has quit IRC22:53
marunarmax_: I rebased22:53
pc_mmarun: But the discovery is targeted to functional tests, not unit tests right?22:53
marunarmax_: a recent change removed neutron.agent.linux.ovs_lib, and some functional tests were importing it22:53
marunarmax_: that common path is used by the functional tests22:54
marunoops, pc_m ^22:54
pc_mmarun: ah.22:54
*** ijw has quit IRC22:54
armax_marun: gotcha22:54
pc_mmarun: So my fucntional test, pulls in the net_helpers.py, which has an issue and is not seen because it is run only for functional tests. is that correct?22:55
armax_marun:  I did that change I thought I had switched22:55
armax_marun: https://review.openstack.org/#/c/17417922:55
marunpc_m: it's not seen because the functional path is subject to the discovery bug22:56
armax_marun: oh…gotcha22:56
*** padkrish has quit IRC22:56
marunarmax_: nasty bug, this one22:56
pc_mmarun: right. But net_helpers.py is not used in unit tests?22:56
marunarmax_: failing tests - no problem!22:56
armax_marun: the discoverabiltiy issue broke the functional tests without us realizing22:56
marunarmax_: multiple times22:57
*** annegent_ has quit IRC22:57
*** padkrish has joined #openstack-neutron22:57
armax_marun: well I was lazy enough to go and check where it was used darn22:57
marunarmax_: well, you relied on the tests working22:57
*** nplanel_ has quit IRC22:57
marunarmax_: that's a pretty reasonable assumption22:57
marunpc_m: no, we don't use it in unit tests22:57
marunpc_m: I'm not sure why that's important22:57
armax_marun: but what I recall was that in tree we were already using the renamed version22:57
*** zhhuabj_ has quit IRC22:58
armax_marun: do you have the patch where we fix the glitch?22:58
pc_mmarun: OK. that makes sense. I just was wondering why it wasn't seen yet. So only used by functional.22:58
marunarmax_: the module in question was updated by ZZelle_ recently22:58
marunarmax_: I'm working on it now22:58
armax_marun: ok understood22:58
*** zhhuabj_ has joined #openstack-neutron22:58
armax_marun: ya22:59
armax_marun: the change came post rename22:59
*** seizadi has quit IRC23:00
*** seizadi has joined #openstack-neutron23:00
*** ijw has joined #openstack-neutron23:00
*** padkrish has quit IRC23:01
pc_mmarun: SO, are you fixing the import in the file as well?23:03
*** zhhuabj_ has quit IRC23:03
*** zhhuabj_ has joined #openstack-neutron23:03
*** aduarte has quit IRC23:04
*** padkrish has joined #openstack-neutron23:05
*** tflynn has quit IRC23:05
*** yuanying has joined #openstack-neutron23:06
ZZelle_armax_, can i help?23:06
armax_ZZelle_: in which regard?23:07
*** akanksha has quit IRC23:07
ZZelle_about https://review.openstack.org/#/c/174179, iiuc23:07
ZZelle_^^23:08
marunZZelle_: I'm on it23:09
marunZZelle_: https://review.openstack.org/#/c/171874/23:09
*** achanda has joined #openstack-neutron23:10
pc_mmarun: thanks! Tomorrow, I'll retry VPN functional test, once this is in.23:10
marunZZelle_: pc_m cool23:11
marunoops, sorry ZZelle_23:11
openstackgerritMaru Newby proposed openstack/neutron: Fix test discovery for api and functional paths  https://review.openstack.org/17187423:11
*** jobewan has quit IRC23:12
*** sicrano has quit IRC23:15
*** pc_m has quit IRC23:17
*** yamamoto has quit IRC23:18
*** pradip has quit IRC23:18
*** pradip has joined #openstack-neutron23:18
*** achanda_ has joined #openstack-neutron23:18
*** achanda_ has quit IRC23:18
*** achanda_ has joined #openstack-neutron23:19
*** achanda has quit IRC23:19
lifelessmarun: hi23:21
lifelessso https://review.openstack.org/#/c/171874/ is cleaner, but still doing the discovery-hack ?23:21
openstackgerritCarl Baldwin proposed openstack/neutron: Utilities for building/parsing netns names to facilitate testing  https://review.openstack.org/17560923:21
lifelessmarun: what prevent the tox based approach?23:21
*** seizadi has quit IRC23:21
*** seizadi has joined #openstack-neutron23:21
marunlifeless: hi23:27
marunlifeless: as per my comment on the review, if we discover all, and use filtering to narrow to subpaths, user filters won't work23:28
marunlifeless: afaik, I'd be happy to hear differently23:28
marunlifeless: is there a trick I'm missing?23:29
*** thedodd has joined #openstack-neutron23:30
*** rm_work is now known as rm_work|away23:31
*** padkrish has quit IRC23:32
*** gildub has joined #openstack-neutron23:32
*** padkrish has joined #openstack-neutron23:33
*** dboik has quit IRC23:33
*** arif-ali has quit IRC23:34
*** chlong has joined #openstack-neutron23:34
lifelessmarun: why wouldn't user filters work ?23:34
lifelessmarun: is it that they don't incrementally restrict?23:34
lifelessmarun: so the filter should be the users filter on its own, or the default filter.23:35
lifeless(today)23:35
*** baoli has joined #openstack-neutron23:37
marunlifeless: the filters appear to be additive23:37
*** padkrish has quit IRC23:37
*** shashankhegde has quit IRC23:37
lifelessmarun: right, X || Y today23:38
marunlifeless: so yes, they don't incrementally restrict23:38
lifelessand there's no syntax to say 'give me an AND23:38
marunlifeless: right.23:39
marunlifeless: is that where the fix should go?  vs allowing discover to accept multiple targets?23:39
lifelesswell23:39
lifelessI think we should probably do all those things23:39
lifelessI wanted to understand the change in direction in the patch is all23:39
marunlifeless: ok23:40
lifelesslets fix the current issue (missing tests)23:40
lifelessand know I know whats needed to do something better in future.23:40
marunlifeless: cool.23:41
*** marun has quit IRC23:42
*** ZZelle_ has quit IRC23:42
*** zhhuabj_ has quit IRC23:42
*** crc32 has quit IRC23:43
*** zhhuabj_ has joined #openstack-neutron23:43
*** david-ly_ has joined #openstack-neutron23:44
*** yfauser has joined #openstack-neutron23:45
*** yfauser has left #openstack-neutron23:45
*** jamielennox|away is now known as jamielennox23:45
*** tsg has joined #openstack-neutron23:45
*** david-ly_ is now known as david-lyle23:46
*** jbell8 has joined #openstack-neutron23:50
*** ajmiller has quit IRC23:51
*** aranjan has quit IRC23:52
*** igordcard has joined #openstack-neutron23:54
*** yamamoto has joined #openstack-neutron23:55
*** zhhuabj_ has quit IRC23:55
*** aranjan has joined #openstack-neutron23:56
*** annegentle has joined #openstack-neutron23:57
*** openstackgerrit has quit IRC23:58
*** openstackgerrit has joined #openstack-neutron23:58
*** Murali has joined #openstack-neutron23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!