*** thorst_afk has quit IRC | 00:01 | |
*** chlong_ has quit IRC | 00:03 | |
*** jckasper has quit IRC | 00:04 | |
*** mickeys has quit IRC | 00:04 | |
*** Aish has quit IRC | 00:05 | |
*** Aish has joined #openstack-neutron | 00:06 | |
*** ivar-lazzaro has quit IRC | 00:06 | |
*** ivar-lazzaro has joined #openstack-neutron | 00:07 | |
*** abhiraut has quit IRC | 00:09 | |
*** manuel112 has quit IRC | 00:09 | |
*** krtaylor has joined #openstack-neutron | 00:12 | |
*** abhiraut has joined #openstack-neutron | 00:14 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Make agent interface plugging utilize network MTU https://review.openstack.org/283790 | 00:14 |
---|---|---|
*** yamamoto_ has joined #openstack-neutron | 00:18 | |
*** banix has quit IRC | 00:20 | |
*** Sukhdev has joined #openstack-neutron | 00:20 | |
openstackgerrit | Ritesh Anand proposed openstack/neutron: Avoids logging error on OVS agent start. https://review.openstack.org/281498 | 00:23 |
*** yamamoto_ has quit IRC | 00:23 | |
openstackgerrit | Ritesh Anand proposed openstack/neutron: Added test cases for DVR L3 schedulers. https://review.openstack.org/188157 | 00:24 |
*** sdague has quit IRC | 00:26 | |
*** daneyon has quit IRC | 00:28 | |
*** SumitNaiksatam has joined #openstack-neutron | 00:29 | |
*** Sukhdev has quit IRC | 00:29 | |
*** sridhar_ram has joined #openstack-neutron | 00:30 | |
*** eil397 has joined #openstack-neutron | 00:32 | |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/neutron: ADD API tests for network ip availability https://review.openstack.org/283357 | 00:33 |
*** sridhar_ram has quit IRC | 00:33 | |
*** mickeys has joined #openstack-neutron | 00:34 | |
*** sridhar_ram has joined #openstack-neutron | 00:35 | |
openstackgerrit | Reedip proposed openstack/python-neutronclient: Change try..except to assertRaises in UT https://review.openstack.org/282184 | 00:36 |
*** mfuruta has joined #openstack-neutron | 00:40 | |
openstackgerrit | David Bingham proposed openstack/neutron: Add API extension for reporting IP availability usage statistics https://review.openstack.org/212955 | 00:41 |
*** salv-orlando has joined #openstack-neutron | 00:45 | |
openstackgerrit | ZhaoBo proposed openstack/neutron: Add timestamp for neutron core resources https://review.openstack.org/213586 | 00:45 |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/neutron: ADD API tests for network ip availability https://review.openstack.org/283357 | 00:52 |
*** SumitNaiksatam has quit IRC | 00:54 | |
*** gongysh has joined #openstack-neutron | 00:54 | |
*** eil397 has quit IRC | 00:57 | |
*** RichardRaseley has quit IRC | 00:57 | |
*** madhu_ak has quit IRC | 00:58 | |
openstackgerrit | David Bingham proposed openstack/neutron: Add API extension for reporting IP availability usage statistics https://review.openstack.org/212955 | 00:58 |
*** vilobhmm11 has quit IRC | 00:59 | |
*** thorst_afk has joined #openstack-neutron | 00:59 | |
*** madhu_ak has joined #openstack-neutron | 00:59 | |
*** Aish has left #openstack-neutron | 01:00 | |
*** john-davidge has quit IRC | 01:01 | |
*** ivar-lazzaro has quit IRC | 01:01 | |
*** rotbeard has joined #openstack-neutron | 01:01 | |
*** ijw has quit IRC | 01:01 | |
*** ajmiller has quit IRC | 01:01 | |
*** ijw has joined #openstack-neutron | 01:02 | |
*** manuel112 has joined #openstack-neutron | 01:03 | |
*** hoangcx has joined #openstack-neutron | 01:04 | |
*** minwang2 has quit IRC | 01:04 | |
*** thorst_afk has quit IRC | 01:05 | |
*** thorst_afk has joined #openstack-neutron | 01:05 | |
openstackgerrit | Songming Yan proposed openstack/neutron: Adds trunk api of server. https://review.openstack.org/281723 | 01:05 |
*** thorst_afk has quit IRC | 01:06 | |
*** salv-orlando has quit IRC | 01:07 | |
*** thorst_afk has joined #openstack-neutron | 01:07 | |
*** vilobhmm11 has joined #openstack-neutron | 01:10 | |
*** thorst_afk has quit IRC | 01:12 | |
*** ivar-lazzaro has joined #openstack-neutron | 01:14 | |
*** gangil has quit IRC | 01:16 | |
*** EinstCrazy has joined #openstack-neutron | 01:16 | |
*** ivar-lazzaro has quit IRC | 01:16 | |
*** ivar-lazzaro has joined #openstack-neutron | 01:17 | |
*** gangil has joined #openstack-neutron | 01:17 | |
*** gangil has quit IRC | 01:17 | |
*** gangil has joined #openstack-neutron | 01:17 | |
*** john-davidge has joined #openstack-neutron | 01:20 | |
*** yamamoto_ has joined #openstack-neutron | 01:20 | |
*** stanzgy has joined #openstack-neutron | 01:20 | |
*** gangil has quit IRC | 01:22 | |
*** shivrao has quit IRC | 01:22 | |
*** tfukushima has joined #openstack-neutron | 01:25 | |
*** shashank_hegde has quit IRC | 01:25 | |
*** yamamoto_ has quit IRC | 01:26 | |
*** baohua has joined #openstack-neutron | 01:26 | |
*** daneyon has joined #openstack-neutron | 01:28 | |
*** tfukushima has quit IRC | 01:28 | |
*** daneyon_ has joined #openstack-neutron | 01:30 | |
*** skamithi has joined #openstack-neutron | 01:31 | |
*** daneyon has quit IRC | 01:33 | |
*** manuel112 has quit IRC | 01:34 | |
*** madhu_ak has quit IRC | 01:34 | |
*** mickeys has quit IRC | 01:37 | |
*** shivrao has joined #openstack-neutron | 01:37 | |
*** abhiraut has quit IRC | 01:37 | |
*** tfukushima has joined #openstack-neutron | 01:38 | |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/neutron: ADD API tests for network ip availability https://review.openstack.org/283357 | 01:38 |
*** tfukushima has quit IRC | 01:40 | |
*** EinstCrazy has quit IRC | 01:40 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron: Updated from global requirements https://review.openstack.org/283991 | 01:41 |
*** EinstCrazy has joined #openstack-neutron | 01:42 | |
*** ijw has quit IRC | 01:43 | |
*** ijw has joined #openstack-neutron | 01:46 | |
kevinbenton | ZZelle: still there? | 01:46 |
*** shivrao has quit IRC | 01:46 | |
*** ijw has quit IRC | 01:48 | |
*** ijw has joined #openstack-neutron | 01:48 | |
*** vilobhmm11 has left #openstack-neutron | 01:48 | |
*** dims has quit IRC | 01:49 | |
*** chlong_ has joined #openstack-neutron | 01:49 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron: Updated from global requirements https://review.openstack.org/283991 | 01:49 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas: Updated from global requirements https://review.openstack.org/285041 | 01:50 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-lib: Updated from global requirements https://review.openstack.org/282753 | 01:50 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-vpnaas: Updated from global requirements https://review.openstack.org/285043 | 01:50 |
openstackgerrit | Lujin Luo proposed openstack/neutron: This patch avoids duplicate port records in routerport table https://review.openstack.org/285048 | 01:51 |
*** s3wong has quit IRC | 01:53 | |
*** tfukushima has joined #openstack-neutron | 01:55 | |
*** thorst_afk has joined #openstack-neutron | 01:57 | |
*** hoangcx has quit IRC | 02:01 | |
*** liuyulong has joined #openstack-neutron | 02:02 | |
liuyulong | Hi there | 02:03 |
openstackgerrit | LIU Yulong proposed openstack/neutron: Clean up l3 agent side HA router stuffs https://review.openstack.org/265672 | 02:04 |
*** yamamoto has joined #openstack-neutron | 02:04 | |
openstackgerrit | LIU Yulong proposed openstack/neutron: ML2: catch router HA ports update DB error after race conditions https://review.openstack.org/265676 | 02:05 |
*** manjeets has left #openstack-neutron | 02:05 | |
openstackgerrit | LIU Yulong proposed openstack/neutron: Ensure HA router can be synced after HA router race conditions https://review.openstack.org/265680 | 02:07 |
*** banix has joined #openstack-neutron | 02:07 | |
*** banix has quit IRC | 02:09 | |
*** hichihara has joined #openstack-neutron | 02:09 | |
openstackgerrit | LIU Yulong proposed openstack/neutron: Catch exceptions during the delete of tenant last HA router https://review.openstack.org/265682 | 02:10 |
*** gvrangan_ has joined #openstack-neutron | 02:11 | |
*** ZZelle_ has quit IRC | 02:14 | |
*** tiswanso has joined #openstack-neutron | 02:15 | |
*** yamamoto has quit IRC | 02:15 | |
*** tiswanso has quit IRC | 02:16 | |
*** tiswanso has joined #openstack-neutron | 02:17 | |
*** emagana has quit IRC | 02:24 | |
*** annp has joined #openstack-neutron | 02:26 | |
*** emagana has joined #openstack-neutron | 02:27 | |
*** manuel112 has joined #openstack-neutron | 02:27 | |
*** emagana has quit IRC | 02:31 | |
openstackgerrit | LIU Yulong proposed openstack/neutron: Catch DB error after HA router race conditions https://review.openstack.org/265685 | 02:34 |
*** jckasper has joined #openstack-neutron | 02:35 | |
*** vhosakot has joined #openstack-neutron | 02:35 | |
*** baoli has joined #openstack-neutron | 02:36 | |
*** DevonBoatwright has joined #openstack-neutron | 02:37 | |
*** DevonBoatwright has quit IRC | 02:37 | |
*** fzdarsky|afk has quit IRC | 02:37 | |
*** yamahata has quit IRC | 02:39 | |
*** iyamahat_ has quit IRC | 02:39 | |
*** gvrangan_ has quit IRC | 02:40 | |
*** gvrangan has quit IRC | 02:40 | |
*** emagana has joined #openstack-neutron | 02:44 | |
*** s3wong has joined #openstack-neutron | 02:45 | |
openstackgerrit | Brandon Logan proposed openstack/neutron: Pecan routing for agent schedulers https://review.openstack.org/267985 | 02:45 |
*** tbachman has quit IRC | 02:46 | |
*** fzdarsky has joined #openstack-neutron | 02:46 | |
*** tbachman has joined #openstack-neutron | 02:47 | |
*** rkukura has quit IRC | 02:47 | |
*** shashank_hegde has joined #openstack-neutron | 02:47 | |
*** fawadkhaliq has joined #openstack-neutron | 02:48 | |
*** emagana has quit IRC | 02:49 | |
*** wolverin_ has quit IRC | 02:49 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Deprecate segment_mtu and add global_physnet_mtu https://review.openstack.org/284814 | 02:53 |
*** minwang2 has joined #openstack-neutron | 02:55 | |
*** hanchao has joined #openstack-neutron | 02:59 | |
*** manuel112 has quit IRC | 03:00 | |
*** yamamoto has joined #openstack-neutron | 03:01 | |
*** thorst_afk has quit IRC | 03:09 | |
*** s3wong has quit IRC | 03:09 | |
*** thorst_afk has joined #openstack-neutron | 03:09 | |
*** dims has joined #openstack-neutron | 03:10 | |
*** intr1nsic has quit IRC | 03:10 | |
*** tfukushima has quit IRC | 03:11 | |
*** tfukushima has joined #openstack-neutron | 03:11 | |
*** neelashah has joined #openstack-neutron | 03:12 | |
*** singhj has joined #openstack-neutron | 03:14 | |
*** tfukushima has quit IRC | 03:15 | |
*** ianw has quit IRC | 03:16 | |
*** singhj has quit IRC | 03:16 | |
*** ivar-laz_ has joined #openstack-neutron | 03:17 | |
*** intr1nsic has joined #openstack-neutron | 03:17 | |
*** thorst_afk has quit IRC | 03:18 | |
*** shwetaap has joined #openstack-neutron | 03:19 | |
*** ianw has joined #openstack-neutron | 03:19 | |
*** shwetaap1 has joined #openstack-neutron | 03:20 | |
*** ajmiller has joined #openstack-neutron | 03:20 | |
*** ivar-lazzaro has quit IRC | 03:20 | |
*** ivar-laz_ has quit IRC | 03:21 | |
*** tbachman has quit IRC | 03:22 | |
*** shwetaap has quit IRC | 03:23 | |
openstackgerrit | Li Ma proposed openstack/python-neutronclient: Add popular IP protocols for security group https://review.openstack.org/282621 | 03:23 |
*** ijw has quit IRC | 03:24 | |
*** boris-42 has quit IRC | 03:24 | |
*** links has joined #openstack-neutron | 03:26 | |
*** tfukushima has joined #openstack-neutron | 03:29 | |
*** baohua has quit IRC | 03:30 | |
*** baohua has joined #openstack-neutron | 03:31 | |
*** emagana has joined #openstack-neutron | 03:32 | |
*** fawadkhaliq has quit IRC | 03:32 | |
*** ajmiller has quit IRC | 03:34 | |
*** ajmiller has joined #openstack-neutron | 03:34 | |
*** ijw has joined #openstack-neutron | 03:35 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Make L3 HA interface creation concurrency safe https://review.openstack.org/282876 | 03:37 |
openstackgerrit | Kevin Benton proposed openstack/neutron: Get rid of unnecessary _ha_routers_present check https://review.openstack.org/285093 | 03:37 |
*** emagana has quit IRC | 03:37 | |
*** Kennan has quit IRC | 03:39 | |
*** Kennan has joined #openstack-neutron | 03:39 | |
*** ijw has quit IRC | 03:40 | |
*** amotoki has joined #openstack-neutron | 03:41 | |
*** cappetta has quit IRC | 03:41 | |
*** rickyrem has quit IRC | 03:43 | |
*** fedexo has joined #openstack-neutron | 03:45 | |
*** kriskend has joined #openstack-neutron | 03:48 | |
*** hanchao has quit IRC | 03:50 | |
*** markvoelker has quit IRC | 03:51 | |
*** manuel112 has joined #openstack-neutron | 03:52 | |
*** ajmiller_ has joined #openstack-neutron | 03:54 | |
*** daneyon_ has quit IRC | 03:54 | |
*** hoangcx has joined #openstack-neutron | 03:55 | |
*** azbiswas has joined #openstack-neutron | 03:55 | |
*** wolverineav has joined #openstack-neutron | 03:57 | |
*** ajmiller has quit IRC | 03:57 | |
*** Marga_ has quit IRC | 03:57 | |
*** Marga_ has joined #openstack-neutron | 03:58 | |
*** Marga_ has quit IRC | 04:03 | |
*** amotoki has quit IRC | 04:05 | |
*** sridhar_ram has quit IRC | 04:05 | |
*** vhosakot has quit IRC | 04:06 | |
*** baoli has quit IRC | 04:07 | |
Sam-I-Am | moo. | 04:07 |
*** tbachman has joined #openstack-neutron | 04:09 | |
*** baoli has joined #openstack-neutron | 04:09 | |
*** armax has joined #openstack-neutron | 04:11 | |
*** azbiswas has quit IRC | 04:12 | |
*** kriskend has quit IRC | 04:12 | |
*** thorst_afk has joined #openstack-neutron | 04:15 | |
*** jckasper has quit IRC | 04:16 | |
*** jckasper has joined #openstack-neutron | 04:17 | |
russellb | quack | 04:18 |
*** jckasper has quit IRC | 04:18 | |
*** baoli has quit IRC | 04:18 | |
*** jckasper has joined #openstack-neutron | 04:19 | |
*** Marga_ has joined #openstack-neutron | 04:19 | |
Sam-I-Am | russellb: whats up? | 04:19 |
*** baoli has joined #openstack-neutron | 04:20 | |
russellb | falling asleep trying to hack ovn code | 04:20 |
*** amotoki has joined #openstack-neutron | 04:20 | |
*** Marga_ has quit IRC | 04:21 | |
Sam-I-Am | sounds dazzling | 04:21 |
Sam-I-Am | i'm falling asleep writing docs | 04:21 |
*** Marga_ has joined #openstack-neutron | 04:21 | |
*** thorst_afk has quit IRC | 04:23 | |
*** gongysh has quit IRC | 04:23 | |
Sam-I-Am | the soothing sounds of config file updates | 04:24 |
*** manuel112 has quit IRC | 04:24 | |
russellb | :) | 04:26 |
Sam-I-Am | so apparently nova uses 2 dbs now | 04:27 |
*** amotoki has quit IRC | 04:30 | |
*** amotoki has joined #openstack-neutron | 04:35 | |
*** fedexo has quit IRC | 04:35 | |
*** skamithi has left #openstack-neutron | 04:38 | |
*** wolverineav has quit IRC | 04:39 | |
*** shashank_hegde has quit IRC | 04:40 | |
*** tfukushima has quit IRC | 04:43 | |
*** tiswanso has quit IRC | 04:48 | |
*** markvoelker has joined #openstack-neutron | 04:51 | |
*** akshai has joined #openstack-neutron | 04:52 | |
*** mfuruta has quit IRC | 04:52 | |
*** jckasper has quit IRC | 04:53 | |
*** markvoelker has quit IRC | 04:56 | |
*** fawadkhaliq has joined #openstack-neutron | 04:58 | |
*** amotoki has quit IRC | 05:00 | |
*** hdaniel has joined #openstack-neutron | 05:01 | |
*** wolverineav has joined #openstack-neutron | 05:03 | |
*** jamespage has quit IRC | 05:05 | |
*** amotoki has joined #openstack-neutron | 05:07 | |
*** jamespage has joined #openstack-neutron | 05:07 | |
*** wolverineav has quit IRC | 05:07 | |
*** ajmiller_ has quit IRC | 05:10 | |
*** singhj has joined #openstack-neutron | 05:11 | |
*** singhj has quit IRC | 05:13 | |
*** gongysh has joined #openstack-neutron | 05:16 | |
*** manuel112 has joined #openstack-neutron | 05:16 | |
*** baoli has quit IRC | 05:17 | |
*** tfukushima has joined #openstack-neutron | 05:18 | |
*** wolverineav has joined #openstack-neutron | 05:18 | |
*** numans has joined #openstack-neutron | 05:19 | |
*** thorst_afk has joined #openstack-neutron | 05:20 | |
Sam-I-Am | time to locate my bed | 05:22 |
openstackgerrit | Merged openstack/neutron-lib: Updated from global requirements https://review.openstack.org/282753 | 05:25 |
*** tbachman has quit IRC | 05:26 | |
*** thorst_afk has quit IRC | 05:27 | |
*** anilvenkata has joined #openstack-neutron | 05:28 | |
*** oomichi_ has joined #openstack-neutron | 05:30 | |
*** anilvenkata has quit IRC | 05:32 | |
*** tbachman has joined #openstack-neutron | 05:34 | |
*** mubirru has joined #openstack-neutron | 05:35 | |
*** emagana has joined #openstack-neutron | 05:35 | |
*** hdaniel has quit IRC | 05:36 | |
*** ajo_ has joined #openstack-neutron | 05:38 | |
*** neelashah has quit IRC | 05:38 | |
*** emagana has quit IRC | 05:40 | |
*** ajo_ has quit IRC | 05:41 | |
*** ajo_ has joined #openstack-neutron | 05:42 | |
*** tbachman has quit IRC | 05:45 | |
*** tbachman has joined #openstack-neutron | 05:46 | |
*** vthapar has joined #openstack-neutron | 05:46 | |
*** reedip is now known as outofmemory | 05:46 | |
*** vhosakot has joined #openstack-neutron | 05:46 | |
*** tbachman has quit IRC | 05:47 | |
*** anilvenkata has joined #openstack-neutron | 05:47 | |
*** manuel112 has quit IRC | 05:48 | |
*** dileepr has quit IRC | 05:49 | |
liuyulong | Hi guys, I've been dealing with the HA router race condition between concurrent creation and deletion for a quite while. And All the patchs are ready for review. The main LP bug to trace this is here: https://launchpad.net/bugs/1523780 All the review patchs are already reference bug#1523780 as related. | 05:49 |
openstack | Launchpad bug 1523780 in neutron "Race between HA router create and HA router delete" [Medium,In progress] - Assigned to LIU Yulong (dragon889) | 05:49 |
openstackgerrit | LIU Yulong proposed openstack/neutron: Catch PorNotFound after HA router race condition https://review.openstack.org/265685 | 05:50 |
*** vthapar has quit IRC | 05:54 | |
*** vthapar has joined #openstack-neutron | 05:59 | |
*** Marga_ has quit IRC | 06:00 | |
openstackgerrit | Merged openstack/neutron-fwaas: FWaaS quota registration https://review.openstack.org/284249 | 06:04 |
*** hanchao has joined #openstack-neutron | 06:05 | |
*** Marga_ has joined #openstack-neutron | 06:17 | |
*** javeriak has joined #openstack-neutron | 06:17 | |
*** javeriak has quit IRC | 06:18 | |
*** john-davidge has quit IRC | 06:18 | |
*** javeriak has joined #openstack-neutron | 06:18 | |
*** ajo_ has quit IRC | 06:18 | |
*** ajo_ has joined #openstack-neutron | 06:19 | |
*** vhosakot has quit IRC | 06:19 | |
*** javeriak_ has joined #openstack-neutron | 06:21 | |
*** baoli has joined #openstack-neutron | 06:22 | |
*** annp has quit IRC | 06:22 | |
*** lajos-katona has joined #openstack-neutron | 06:22 | |
*** ajo_ has quit IRC | 06:22 | |
*** ajo_ has joined #openstack-neutron | 06:23 | |
*** javeriak has quit IRC | 06:23 | |
*** ajo_ has quit IRC | 06:25 | |
*** thorst_afk has joined #openstack-neutron | 06:25 | |
*** baoli has quit IRC | 06:26 | |
*** links has quit IRC | 06:26 | |
openstackgerrit | yalei wang proposed openstack/neutron: Change the exception type from ValueError to IpamValueInvalid https://review.openstack.org/264086 | 06:30 |
*** armax has quit IRC | 06:31 | |
*** thorst_afk has quit IRC | 06:32 | |
*** gvrangan has joined #openstack-neutron | 06:33 | |
*** gvrangan_ has joined #openstack-neutron | 06:33 | |
*** dims has quit IRC | 06:37 | |
*** baoli has joined #openstack-neutron | 06:37 | |
*** gvrangan_ has quit IRC | 06:37 | |
*** gvrangan has quit IRC | 06:38 | |
kevinbenton | russellb: will you be at the mid-cycle at all tomorrow? | 06:38 |
*** manuel112 has joined #openstack-neutron | 06:41 | |
*** baoli has quit IRC | 06:42 | |
*** numans has quit IRC | 06:43 | |
*** gampel has joined #openstack-neutron | 06:48 | |
*** josecastroleon has joined #openstack-neutron | 06:48 | |
*** wolverineav has quit IRC | 06:52 | |
*** markvoelker has joined #openstack-neutron | 06:53 | |
*** jckasper has joined #openstack-neutron | 06:54 | |
*** sudipto has joined #openstack-neutron | 06:56 | |
*** markvoelker has quit IRC | 06:57 | |
*** wolverineav has joined #openstack-neutron | 06:58 | |
*** numans has joined #openstack-neutron | 06:58 | |
*** shwetaap1 has quit IRC | 06:58 | |
*** jckasper has quit IRC | 06:59 | |
*** djan_ has joined #openstack-neutron | 07:00 | |
*** slaweq has joined #openstack-neutron | 07:01 | |
*** djan has quit IRC | 07:01 | |
openstackgerrit | Li Ma proposed openstack/python-neutronclient: Add popular IP protocols for security group https://review.openstack.org/282621 | 07:04 |
*** rcernin has joined #openstack-neutron | 07:05 | |
*** korzen has joined #openstack-neutron | 07:07 | |
*** gongysh has quit IRC | 07:08 | |
*** eddima has joined #openstack-neutron | 07:10 | |
*** scheuran has joined #openstack-neutron | 07:12 | |
*** apuimedo has joined #openstack-neutron | 07:13 | |
*** manuel112 has quit IRC | 07:14 | |
openstackgerrit | Hirofumi Ichihara proposed openstack/python-neutronclient: Add wrapper classes for return-request-id-to-caller https://review.openstack.org/270118 | 07:17 |
*** manuel112 has joined #openstack-neutron | 07:18 | |
*** claudiub has joined #openstack-neutron | 07:22 | |
*** chlong_ has quit IRC | 07:26 | |
*** hynekm has joined #openstack-neutron | 07:27 | |
*** anshul has joined #openstack-neutron | 07:27 | |
*** javeriak_ has quit IRC | 07:27 | |
*** neeti has joined #openstack-neutron | 07:28 | |
*** apuimedo has quit IRC | 07:28 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Use network RBAC feature for external access https://review.openstack.org/282295 | 07:29 |
*** salv-orlando has joined #openstack-neutron | 07:29 | |
*** mfuruta has joined #openstack-neutron | 07:29 | |
*** thorst_afk has joined #openstack-neutron | 07:30 | |
openstackgerrit | Songming Yan proposed openstack/python-neutronclient: Adds trunk api for neutronclient. https://review.openstack.org/283407 | 07:32 |
*** mfuruta has quit IRC | 07:33 | |
*** thorst_afk has quit IRC | 07:39 | |
*** ihrachys has joined #openstack-neutron | 07:39 | |
*** rotbeard has left #openstack-neutron | 07:42 | |
*** minwang2 has quit IRC | 07:43 | |
*** mfuruta has joined #openstack-neutron | 07:44 | |
*** ildikov has joined #openstack-neutron | 07:46 | |
*** ranjithd1 has quit IRC | 08:01 | |
openstackgerrit | LIU Yulong proposed openstack/neutron: Catch PortNotFound after HA router race condition https://review.openstack.org/265685 | 08:02 |
*** ranjithd has joined #openstack-neutron | 08:02 | |
*** emagana has joined #openstack-neutron | 08:02 | |
*** gvrangan has joined #openstack-neutron | 08:03 | |
*** gvrangan_ has joined #openstack-neutron | 08:03 | |
*** tmorin has joined #openstack-neutron | 08:04 | |
*** josecastroleon has quit IRC | 08:05 | |
*** emagana has quit IRC | 08:06 | |
*** josecastroleon has joined #openstack-neutron | 08:08 | |
*** yalie has quit IRC | 08:11 | |
*** mfuruta has quit IRC | 08:13 | |
*** wolverineav has quit IRC | 08:14 | |
openstackgerrit | Artur Korzeniewski proposed openstack/neutron: Create a hook in base object to modify the fields before DB operations https://review.openstack.org/281850 | 08:19 |
*** hdaniel has joined #openstack-neutron | 08:19 | |
*** jlanoux has joined #openstack-neutron | 08:26 | |
*** matrohon has joined #openstack-neutron | 08:27 | |
*** achanda has quit IRC | 08:29 | |
*** akshai has quit IRC | 08:30 | |
*** jpena has joined #openstack-neutron | 08:31 | |
*** djan has joined #openstack-neutron | 08:31 | |
*** djan_ has quit IRC | 08:31 | |
*** feisky has joined #openstack-neutron | 08:32 | |
scheuran | Hey good morning rossella_s | 08:33 |
*** achanda has joined #openstack-neutron | 08:33 | |
rossella_s | scheuran, morning | 08:34 |
scheuran | rossella_s, I think I need some advice - I have a couple of options how to handle the migration I want to double check with you | 08:34 |
rossella_s | scheuran, shoot :) | 08:34 |
scheuran | rossella_s, #1 on in mech_driver try_to_bind_segment_for_agent I compare the interface mapping of all agents and deny any binding if one does not match | 08:35 |
scheuran | rossella_s, this would force the admin to synch all its agent configs | 08:36 |
scheuran | rossella_s, otherwise he can't even launch any instance | 08:36 |
scheuran | rossella_s, that's the safe way... | 08:36 |
*** thorst_afk has joined #openstack-neutron | 08:36 | |
*** jlanoux has quit IRC | 08:37 | |
rossella_s | scheuran, you need to check the interface mapping only of the agent that is trying the binding | 08:37 |
scheuran | #2 in try_to_bind_segment_for_agent I can access the port context. It has device:owner = compute:host, & binding.host = host | 08:37 |
*** jlanoux has joined #openstack-neutron | 08:38 | |
scheuran | now on live migration, nova set binding.host to host2 while device:owner keeps host - if the agent does not set the device up | 08:38 |
scheuran | this is how I could determine a live migration | 08:38 |
scheuran | then check the agent for the device owner host | 08:38 |
scheuran | and if the mapping is equal - allow binding, if not deny | 08:39 |
rossella_s | scheuran, to me it makes for sense the first option | 08:39 |
rossella_s | the second option is more complex and I am sure there could be corner cases that will bite us later | 08:40 |
scheuran | but the problem with #2 is that it does not work for a cold migration, as the device owner is compute:all :( | 08:40 |
scheuran | you're right | 08:40 |
scheuran | let me elaborate #3 | 08:40 |
rossella_s | ok | 08:40 |
*** mfuruta has joined #openstack-neutron | 08:41 | |
scheuran | part of the agent status reports is a long list of macvtap mac addresses that are available on this host | 08:41 |
scheuran | now on binding, I could iterate over all agents and figure out if the mac is available somewhere else as well and if so check the interface mappings | 08:42 |
rossella_s | scheuran, but anyway you can tell nova to migrate the port to another host | 08:42 |
rossella_s | *can't | 08:42 |
rossella_s | so I don't understand why you should check all the agents...you should check only the one that is trying to bind the port, right? | 08:43 |
*** thorst_afk has quit IRC | 08:43 | |
scheuran | yes ideally | 08:43 |
scheuran | the problem is, before we try to establish the new portbinding, the old portbinding was cleared | 08:44 |
*** gongysh has joined #openstack-neutron | 08:44 | |
scheuran | so I don't know where to port originated before | 08:44 |
scheuran | also the vid_details are not available any more, as it seems they are getting deleted after unbinding | 08:44 |
scheuran | rossella_s, the only piece of information that gives me a hint is the device:owner, but only in the case of a live migration... | 08:46 |
rossella_s | scheuran, everything should be in context._original_port | 08:46 |
scheuran | rossella_s, this is always none :( | 08:46 |
rossella_s | scheuran, interesting | 08:47 |
rossella_s | why do you need to know where the port originates? you have the network and the interface binding...why is this not enough? | 08:48 |
scheuran | rossella_s, this would be sufficient if nova would contact neutron before live migration start | 08:49 |
scheuran | rossella_s, then I could modify the xml accordingly | 08:49 |
scheuran | rossella_s, but that's not happening today | 08:50 |
rossella_s | got that scheuran | 08:50 |
rossella_s | I guess the idea was refuse to bind and fail | 08:50 |
scheuran | rossella_s, the agent requests the device details after the instance appeared on the target side (in paused state) | 08:50 |
scheuran | right | 08:50 |
rossella_s | maybe I didn't have enough coffee and I am not following :) | 08:51 |
scheuran | rossella_s, hehe. ok let me try to find other words | 08:51 |
scheuran | so my mech driver can easily determine the vif details that should be used on the target host | 08:52 |
rossella_s | so the agent request the details, after lots of method we arrive to try_to_bind_segment_for_agent, ah I think I get i now | 08:52 |
scheuran | so I need to compare this information somehow to the actual state - where the macvtap resides on | 08:52 |
scheuran | the question is, how to get to the current state information | 08:52 |
scheuran | *current state on the target side | 08:53 |
scheuran | or on the source side | 08:53 |
rossella_s | got | 08:53 |
scheuran | cause both are the same | 08:53 |
rossella_s | is it stored in the vif_details? | 08:53 |
scheuran | yes | 08:53 |
*** markvoelker has joined #openstack-neutron | 08:53 | |
rossella_s | but it's empty you say | 08:53 |
rossella_s | that's the problem right? | 08:53 |
scheuran | right | 08:53 |
rossella_s | I don't understand why it's empty | 08:54 |
rossella_s | if you get the port from the db, just to test...is it empty there? | 08:54 |
scheuran | rossella_s, let me try to hack something to figure out the db values... | 08:56 |
hdaniel | ajo: hey, good morning :) | 08:56 |
rossella_s | scheuran, you can simply query the db I guess, even from the db console | 08:57 |
rossella_s | scheuran, that's just to test if those values are written into the db. If they are there we should find the point in the code where they are cleared | 08:57 |
*** markvoelker has quit IRC | 08:57 | |
scheuran | rossella_s, ah ok | 08:58 |
rossella_s | scheuran, it would probably require some hack...I think we clear the binding at some point, that's where you lose those values | 08:59 |
*** tfukushima has quit IRC | 09:00 | |
scheuran | rossella_s, yes, they are stored in the db | 09:01 |
scheuran | ml2-portbindings table | 09:01 |
*** tfukushima has joined #openstack-neutron | 09:02 | |
scheuran | 2 possible places where this could happen: a) in request device_details b) when nova updates the binding:host | 09:02 |
*** lucas-afk is now known as lucasagomes | 09:02 | |
*** achanda has quit IRC | 09:03 | |
rossella_s | scheuran, https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L371 | 09:06 |
ajo | hey hdaniel | 09:06 |
openstackgerrit | linwei wu proposed openstack/neutron: Remove unclear built-in in subnetpool exception https://review.openstack.org/270649 | 09:06 |
ajo | hdaniel, any idea of what broke the policies ? | 09:07 |
rossella_s | scheuran, the vif_details are not copied | 09:07 |
hdaniel | ajo: no, | 09:07 |
ajo | hdaniel, may be any change in oslo_policy has broken us? | 09:07 |
hdaniel | ajo: no, saw that you have the same issues | 09:07 |
scheuran | rossella_s, cool | 09:07 |
ajo | yes, I want to check the graphs and logs | 09:07 |
ajo | to see when this started | 09:07 |
scheuran | rossella_s, is there a reason why the original port context is not available anymore? | 09:08 |
hdaniel | hdaniel: cool, I just started doing so - feels like CSI scene | 09:08 |
rossella_s | scheuran, that's what I am trying to find out | 09:08 |
rossella_s | scheuran, it's not copied because it's not passed here https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L371 | 09:09 |
rossella_s | scheuran, I don't think there's a good reason for that...probably nobody needed it before. When the code was written migration was not a possibility | 09:10 |
rossella_s | scheuran, I think we can modify that line to pass the original port so that you can use those data | 09:10 |
scheuran | rossella_s, was that your intention to paste the same link as before? | 09:10 |
rossella_s | scheuran, nope sorry, it's few lines after...https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L374 | 09:11 |
rossella_s | scheuran, we can pass the original port to PortContext but it's not done here...I think because usually you bind a port for the first time, so there's no original port. But that's not true for migration | 09:11 |
scheuran | rossella_s, makes sense. cool - thank you! Let me try that in my test environment | 09:12 |
rossella_s | scheuran, good luck!! | 09:12 |
*** mfuruta has quit IRC | 09:14 | |
*** rcernin has quit IRC | 09:14 | |
*** jlanoux has quit IRC | 09:17 | |
*** salv-orlando has quit IRC | 09:19 | |
*** salv-orlando has joined #openstack-neutron | 09:19 | |
*** jschwarz has joined #openstack-neutron | 09:20 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Collect details on ARP spoof functional failures https://review.openstack.org/285181 | 09:24 |
hdaniel | ajo: just saw some patches pass gate-neutron-dsvm-api , maybe it's worth rechecking ? | 09:25 |
ajo | hdaniel, yeah, try, why not :) | 09:26 |
kevinbenton | hdaniel, ajo: until this merges i think you will be out of luck https://review.openstack.org/#/c/284911 | 09:27 |
*** kawa2014 has joined #openstack-neutron | 09:27 | |
*** jistr has joined #openstack-neutron | 09:27 | |
ajo | kevinbenton++ | 09:28 |
ajo | thanks, I was trying to investigate the cause, but I see it's under control | 09:28 |
openstackgerrit | Hirofumi Ichihara proposed openstack/python-neutronclient: Add tags support https://review.openstack.org/282360 | 09:28 |
*** rcernin has joined #openstack-neutron | 09:28 | |
*** djan has quit IRC | 09:29 | |
*** jlanoux has joined #openstack-neutron | 09:30 | |
ajo | kevinbenton, what's the tempest_lib / tempest.lib history | 09:30 |
* ajo looks for the db9672e3473cd chagne | 09:30 | |
*** sudipto has quit IRC | 09:30 | |
*** mickeys has joined #openstack-neutron | 09:30 | |
hdaniel | kevinbenton: 10x for the head's up - I saw you patch gets the jack-pot, did you rebase on top of https://review.openstack.org/#/c/284911 ? | 09:31 |
ajo | oh | 09:31 |
ajo | deprecated | 09:31 |
*** baohua has quit IRC | 09:31 | |
*** mgoddard_ has joined #openstack-neutron | 09:31 | |
kevinbenton | hdaniel: which one? | 09:32 |
kevinbenton | hdaniel: the one to collect failure info? | 09:32 |
hdaniel | Kennan: rbac external access | 09:32 |
*** ihrachys_ has joined #openstack-neutron | 09:32 | |
hdaniel | kevinbenton: ^ | 09:32 |
kevinbenton | hdaniel: oh yeah, i put that on top of his because mine was conflicting with it | 09:32 |
kevinbenton | hdaniel: with the tempest lib changes in the API tests | 09:32 |
hdaniel | ajo: ^ that might do the trick , then | 09:33 |
ajo | hdaniel, may be it's more effective to rebase yours hdaniel (if you want to buy some time : ) | 09:33 |
ajo | anyway, gate seems quite pressured btw | 09:33 |
hdaniel | ajo, kevinbenton: yeah, will do | 09:33 |
kevinbenton | i must inspect the inside of my eyelids for a few hours, ttyl | 09:33 |
ajo | kevinbenton, :D | 09:34 |
hdaniel | kevinbenton: cheers | 09:34 |
hdaniel | ajo: gtg - picking up em kids . ttyl | 09:34 |
*** hichihara has quit IRC | 09:34 | |
*** ihrachys has quit IRC | 09:35 | |
*** fzdarsky has quit IRC | 09:35 | |
*** mgoddard has quit IRC | 09:35 | |
*** fzdarsky has joined #openstack-neutron | 09:35 | |
ajo | hdaniel, ack :) | 09:36 |
* ajo eyeballs patches | 09:36 | |
*** fawadkhaliq has quit IRC | 09:37 | |
*** lezbar__ has joined #openstack-neutron | 09:37 | |
*** lezbar has quit IRC | 09:38 | |
*** gongysh has quit IRC | 09:39 | |
*** gongysh has joined #openstack-neutron | 09:40 | |
*** neiljerram has joined #openstack-neutron | 09:40 | |
*** thorst_afk has joined #openstack-neutron | 09:41 | |
*** akamyshnikova has joined #openstack-neutron | 09:42 | |
*** sudipto has joined #openstack-neutron | 09:43 | |
*** mickeys has quit IRC | 09:44 | |
*** liuyulong has left #openstack-neutron | 09:44 | |
*** davidsha has joined #openstack-neutron | 09:44 | |
*** liuyulong has joined #openstack-neutron | 09:44 | |
liuyulong | @jschwarz here? | 09:44 |
jschwarz | liuyulong, good morning | 09:45 |
jschwarz | :) | 09:45 |
liuyulong | hi | 09:45 |
jschwarz | liuyulong, we want to get https://review.openstack.org/#/c/260303 merged asap IMO (I think you'll agree) | 09:46 |
jschwarz | liuyulong, so can we move the changes to safe_creation to the patch that actually uses it (that you referenced to earlier)? | 09:46 |
liuyulong | For that safe_creation change, we need remove that change? | 09:46 |
jschwarz | liuyulong, what do you mean? | 09:47 |
jschwarz | liuyulong, if you move the entire change to safe_creation to https://review.openstack.org/#/c/265682/ , it shouldn't be at 260303 | 09:47 |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: RPC Callback rolling upgrades reporting, and integration https://review.openstack.org/268040 | 09:47 |
liuyulong | remove that safe_creation change to its reference patch? | 09:47 |
*** thorst_afk has quit IRC | 09:48 | |
jschwarz | liuyulong, yes | 09:48 |
jschwarz | liuyulong, I think this will let us focus on what really matters :) | 09:48 |
liuyulong | OK, for now, add/raise the RouterNotFound will make that change no need anymore. I will remove that. | 09:48 |
jschwarz | liuyulong, excellent, thank you very much | 09:49 |
jschwarz | liuyulong, as to the race you said in https://review.openstack.org/#/c/257059/ | 09:49 |
jschwarz | liuyulong, with the router-update and create/delete - can you describe a concrete situation to reproduce it? | 09:49 |
*** tpsilva has joined #openstack-neutron | 09:50 | |
jschwarz | liuyulong, I agree that if we can do a router-update at the same time as router-delete, there's a possible race | 09:52 |
jschwarz | liuyulong, however it will be really helpful if we have an "how to reproduce" and a traceback | 09:52 |
liuyulong | For the race I mentioned here https://review.openstack.org/#/c/257059/, I have not test it yet, but according to the multi-API workers behavior, that race may happen. | 09:53 |
jschwarz | liuyulong, ok | 09:53 |
liuyulong | Try to reproduce it just like I said in that patch inline comments. | 09:54 |
jschwarz | liuyulong, how about this: you work on the patch to make sure we can merge it asap, and I'll try to reproduce it | 09:54 |
jschwarz | liuyulong, does that sound good to you? | 09:54 |
*** EinstCrazy has quit IRC | 09:55 | |
liuyulong | OK, fine, try that, I am working on 260303 now : ), a new patch is coming very soon. | 09:55 |
jschwarz | liuyulong, thank you | 09:55 |
*** jlibosva has joined #openstack-neutron | 09:55 | |
jschwarz | liuyulong, also, I strongly recommend you hang around this channel | 09:56 |
jschwarz | liuyulong, Kevin for example is kevinbenton so you can also talk with him (once he's awake) and it's much easier to talk like this :) | 09:56 |
davidsha | ihrachys_: ping | 09:56 |
liuyulong | yes, I know, thank you. | 09:57 |
liuyulong | Have you guys ever discuess https://bugs.launchpad.net/neutron/+bug/1523780 and it's sub-bugs? | 09:58 |
openstack | Launchpad bug 1523780 in neutron "Race between HA router create and HA router delete" [Medium,In progress] - Assigned to LIU Yulong (dragon889) | 09:58 |
liuyulong | I've been dealing with the HA router race condition between concurrent creation and deletion for a quite while. | 09:58 |
jschwarz | liuyulong, not directly, but all the patches we are working on are about fixing those races that you mentioned | 09:58 |
jschwarz | liuyulong, I understand that you have worked on this a while and it seems that some of kevinbenton's patches and yours try to solve the same thing | 09:59 |
ihrachys_ | davidsha: pong | 09:59 |
*** salv-orlando has quit IRC | 10:00 | |
ihrachys_ | hdaniel: +2 on rbac patch. waiting for CI. | 10:00 |
jschwarz | liuyulong, we need to see going forward what's the best thing to do with all of these conflicts | 10:00 |
ihrachys_ | ajo: do we need another core to approve the rbac patch? | 10:00 |
jschwarz | liuyulong, what I'm interested in knowing is, if we take 3 specific patches - can you find any more races? | 10:01 |
davidsha | ihrachys_: hey, was working on the new patch and the unit tests kept failing. I don't think we can move reserved_cookies out of OVSBridge, I was using the mixin to override set_agent_uuid_stamp but it seems to default to the OVSBridge version where I needed to remove references to reserved_cookies. | 10:01 |
jschwarz | liuyulong, and if so, what races? then we can fix them together :) | 10:01 |
ihrachys_ | davidsha: doesn't super() help? | 10:02 |
liuyulong | Yes all of that bugs are fired by me, and all have my patchs to solve it. | 10:02 |
*** lajos-katona has quit IRC | 10:02 | |
ihrachys_ | davidsha: you would have the base class messing with default_cookie, and mixin would add reserved_cookies mechanics | 10:02 |
jschwarz | liuyulong, so for example the ALLOCATING patch makes some of your patches not so much needed anymore I'm afraid | 10:02 |
davidsha | In the mixin? Ok, I'll try that. | 10:02 |
ihrachys_ | davidsha: I personally wouldn't mind either way, but I guess we want to make yamamoto happy | 10:03 |
jschwarz | liuyulong, so I propose we have a look at all the patches and see what solves which problem and then it'll be easier to decide the best way going forward | 10:03 |
jschwarz | (all the patches = kevin's ann's and yours) | 10:03 |
liuyulong | If the ALLOCATING do not bring new race, I'am OK with that. | 10:03 |
jschwarz | liuyulong, good | 10:03 |
davidsha | ihrachys_: kk, I'll have it up soon, sorry for the delay. | 10:03 |
jschwarz | liuyulong, I agree though that 260303 should definitely go in though | 10:04 |
*** lajos-katona has joined #openstack-neutron | 10:04 | |
*** tfukushima has quit IRC | 10:04 | |
jschwarz | liuyulong, anyway I'm gonna try to reproduce that race you mentioned and see if there's something there | 10:05 |
openstackgerrit | Jakub Libosvar proposed openstack/neutron: secgroup: Define hybrid plug in driver itself https://review.openstack.org/284620 | 10:06 |
*** salv-orlando has joined #openstack-neutron | 10:08 | |
*** bjornar has joined #openstack-neutron | 10:08 | |
bjornar | Is there any work beeing done to make neutron-server/api run behind a real wsgi server? All the other api's currently run fine under mod_wsgi/uwsgi | 10:09 |
*** salv-orlando has quit IRC | 10:11 | |
hdaniel | ihrachys_: ack | 10:12 |
*** javeriak has joined #openstack-neutron | 10:12 | |
*** salv-orlando has joined #openstack-neutron | 10:12 | |
liuyulong | jschwarz, currently the ALLOCATING status is only added to HA router, the patch title is a little inaccurate. What do you think? | 10:12 |
jschwarz | liuyulong, as to the race condition you mentioned with the update/delete - I checked it and it doesn't raise any exception | 10:15 |
*** wolverineav has joined #openstack-neutron | 10:15 | |
jschwarz | liuyulong, the update-router code is safe and makes sure that the router exists before it tries to unbind it, etc, so no exception is raised | 10:15 |
openstackgerrit | LIU Yulong proposed openstack/neutron: Catch DBReferenceError in HA router race conditions https://review.openstack.org/260303 | 10:15 |
*** jckasper has joined #openstack-neutron | 10:15 | |
jschwarz | liuyulong, and actually an error is returned to the user to say that the router was not found | 10:16 |
jschwarz | liuyulong, so no race is found. I'll comment on the review and describe what I did to try to reproduce this | 10:16 |
jschwarz | so you can also try yourself :) | 10:16 |
jschwarz | liuyulong, also I agree that the patch title can be expanded a bit - you can comment so on the review | 10:17 |
liuyulong | IMO, that race is not easy to produce, try Rally job create_and_update_router | 10:17 |
ihrachys_ | hdaniel: client patch: all good, but you probably need to add a release note | 10:17 |
jschwarz | liuyulong, ok. let me tell you what I did to try and reproduce this | 10:17 |
jschwarz | liuyulong, I put a pdb.set_trace() right before the call to _unbind_ha_router | 10:18 |
hdaniel | ihrachys_: sure thing - will do | 10:18 |
jschwarz | liuyulong, then I called router-update --ha=False from a client and made sure the pdb.set_trace() was called | 10:18 |
jschwarz | liuyulong, then, I deleted the router | 10:18 |
jschwarz | liuyulong, afterwards I made the unbind_ha_router code continue and no exception was raised | 10:19 |
jschwarz | liuyulong, did you have a different scenario in mind? | 10:19 |
*** jckasper has quit IRC | 10:20 | |
*** wolverineav has quit IRC | 10:20 | |
ajo | ihrachys_, I'd guess yes, | 10:20 |
ajo | otherwise it'd be too in-redhat IMHO | 10:21 |
ihrachys_ | yeah, two redhat cores + redhat author... | 10:21 |
jschwarz | ajo, you can temporarily quit your job, approve and then come back ;-) | 10:21 |
jschwarz | I'm sure hdaniel wouldn't mind | 10:21 |
liuyulong | the race could happen in any time between l3 agents and neutron server | 10:22 |
ihrachys_ | jschwarz: I am not afraid of hdaniel mind :P | 10:22 |
ihrachys_ | kevinbenton: could you take a look for the 2nd time at hdaniel's patch for rbac? https://review.openstack.org/250081 | 10:23 |
ajo | ihrachys_, he's looking at his own eyelids now | 10:23 |
ihrachys_ | kevinbenton: it should probably address your previous concerns for the most part | 10:23 |
jschwarz | liuyulong, I understand it could happen any time - the trick is finding a concrete situation where it does reproduce | 10:23 |
ajo | ihrachys_, but he'll be back soon | 10:23 |
ihrachys_ | ajo: it's kevinbenton, you never know :) | 10:23 |
ajo | lol | 10:23 |
ajo | infinite power | 10:23 |
jschwarz | liuyulong, if we can't reproduce it, I suggest we don't -1 the patch (since we can't prove it's broken) - this way in the worst case scenario we can fix this afterwards | 10:24 |
ihrachys_ | redbull powered review machine | 10:24 |
jschwarz | ajo, the other day he was awake all the way through 3pm our time | 10:24 |
jschwarz | debugging HA races with me | 10:24 |
liuyulong | If ha router was created and scheduled to l3 agent, then l3 agent try sync the router info, but a router update api just set the statues to ALLOCTIONG, the sync will got a None, then the l3 agent may directly delete the HA router | 10:24 |
liuyulong | @jschwarz, 260303 is ready for review. | 10:26 |
jschwarz | liuyulong, I'll look at it in a few minutes. I didn't understand your scenario completely | 10:26 |
*** sdague has joined #openstack-neutron | 10:27 | |
jschwarz | liuyulong, if the update API just set the router to ALLOCATING of course the agent will not see the router | 10:27 |
ajo | jschwarz, once upon a time I was able to do that sort of thing, now I do it and I'm dead for one week | 10:27 |
*** hoangcx has quit IRC | 10:27 | |
jschwarz | liuyulong, but mind you, keep in mind that changing the HA property of a router is only possible if --admin-state-up=False | 10:27 |
ajo | jschwarz, may be It's influcenced by the fact that I need to wake up 2-3 times every night because of kids... | 10:27 |
jschwarz | liuyulong, in this case the router isn't scheduled to any agent anyway, and is deleted from them as well | 10:27 |
jschwarz | liuyulong, so this acts as a safeguard to prevent the race you said | 10:28 |
jschwarz | ajo, aye :< | 10:28 |
jschwarz | ajo, how are you going to cope with our pub-crawling in Austin?! | 10:28 |
ajo | jschwarz, that week I won't be taking care of kids, and having good sleeps | 10:29 |
ajo | that works :P | 10:29 |
jschwarz | ajo, XD | 10:29 |
ajo | jschwarz, I'll look for a good steak too :P | 10:29 |
*** emagana has joined #openstack-neutron | 10:30 | |
ajo | hdaniel, do you need help rebasing on the tempest lib patch? | 10:30 |
jschwarz | ajo, oh, i can't wait to taste the infamous Texas steaks | 10:30 |
*** gampel has quit IRC | 10:30 | |
ajo | hdaniel, it can be done from the gerrit interface itself | 10:30 |
jschwarz | liuyulong, what do you think on what I said earlier? | 10:30 |
ajo | just give it the tempest lib 6-digit-gerrit-code | 10:30 |
*** tfukushima has joined #openstack-neutron | 10:30 | |
liuyulong | ok, yes, that will make sense | 10:31 |
jschwarz | liuyulong, I'm happy it does. So I'll post this on the review in a minute | 10:32 |
jschwarz | liuyulong, looking at your patch it looks good to me so I'll +1 it | 10:32 |
jschwarz | :) | 10:32 |
liuyulong | what about the race between updating HA to false and deleting it ? | 10:32 |
ajo | jlibosva, I see arp_spoof_tests failing a bit: http://logs.openstack.org/11/284911/3/check/gate-neutron-dsvm-functional/76dffe6/testr_results.html.gz | 10:32 |
liuyulong | when its admin-state-up already in flase? | 10:33 |
ajo | randomly | 10:33 |
ajo | may we disable those for now ? | 10:33 |
*** baohua has joined #openstack-neutron | 10:33 | |
ajo | obondarev, | 10:33 |
*** achanda has joined #openstack-neutron | 10:33 | |
ajo | the tempest_lib change failed again | 10:33 |
ajo | shall we recheck? | 10:33 |
jschwarz | liuyulong, so that's the scenario I tested earlier | 10:33 |
ajo | it seems unrelated | 10:33 |
jschwarz | liuyulong, and as I said, the rest of the 'update-router' code is safe and no exception is raised | 10:33 |
ajo | obondarev, rechecked | 10:34 |
*** emagana has quit IRC | 10:34 | |
jschwarz | liuyulong, also, the router-update code will return a proper 'router not found' error to the user, so even that is happening | 10:34 |
jschwarz | liuyulong, in other words, no race there :) | 10:34 |
scheuran | rossella_s, https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L284 | 10:36 |
scheuran | rossella_s, this is the place where the vif_details get removed | 10:36 |
*** stanzgy has quit IRC | 10:36 | |
*** sambetts|afk is now known as sambetts | 10:37 | |
scheuran | but I have not yet figured out how the binding object correlates to the context... | 10:37 |
*** achanda has quit IRC | 10:38 | |
jschwarz | liuyulong, have a look at what I wrote in https://review.openstack.org/#/c/257059/23/neutron/db/l3_hamode_db.py | 10:39 |
*** feisky has quit IRC | 10:41 | |
liuyulong | by looking deeply to the _unbind_ha_router(), seems it will delete the HA port multi-times between the updating ha status and deleting API. Nothing harms. | 10:41 |
liuyulong | I will remove my -1 | 10:42 |
jschwarz | liuyulong, thank you | 10:42 |
ajo | yamamoto, davidsha : https://review.openstack.org/#/c/267591/27/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/br_cookie.py | 10:42 |
davidsha | ajo: hey | 10:43 |
ihrachys_ | ajo: tell me, why the 8191 magic value in json field for versions? | 10:43 |
ajo | ihrachys_, 65k is the mysql limit | 10:43 |
ajo | buuuut | 10:43 |
ajo | 65k is also the row limit | 10:43 |
ajo | so 65k fails | 10:43 |
ajo | 8191 is just bigger than 4095 | 10:43 |
jschwarz | liuyulong, I'm going off now (I don't usually work Fridays) | 10:43 |
ihrachys_ | ajo: why not 8192? :) | 10:44 |
jschwarz | liuyulong, if you need me you can reach me at jschwarz@redhat.com - ok? | 10:44 |
ajo | ihrachys_, TBH, 8000 would also do | 10:44 |
ihrachys_ | ajo: I mean, there should be some reasoning behind the value | 10:44 |
jschwarz | ihrachys_, for the same reason it's not 8193 | 10:44 |
jschwarz | du'h | 10:44 |
ajo | low level alignment I guess | 10:44 |
ajo | I was following the other json field size (2^N -1 ) | 10:44 |
*** bsv___ has joined #openstack-neutron | 10:44 | |
ajo | but not sure if it's right, | 10:44 |
ajo | anyway, we should probably not be caring about low level optimizations which are probably done by mysql if needed (alignments) | 10:45 |
*** lajos-katona has quit IRC | 10:45 | |
ajo | ihrachys_, varchar up to 255 uses 1 byte lenght in Mysql (as far as I understood) | 10:45 |
ajo | then 2 bytes | 10:45 |
*** thorst_afk has joined #openstack-neutron | 10:45 | |
rossella_s | scheuran, the binding should be saved in the context | 10:46 |
ajo | ihrachys_, but for pgsql, it's 1 byte up to 127, then 2 bytes | 10:46 |
jschwarz | righto, bb guys | 10:46 |
jschwarz | have a happy weekend | 10:46 |
*** jschwarz has quit IRC | 10:46 | |
ihrachys_ | ajo: I prolly don't need the details :) the fact that you need to explain it to me suggests there is missing comment there. | 10:46 |
ajo | ihrachys_, IMO, it's random, I just picked something bigger and beautiful to my mind :) | 10:46 |
ajo | probably no reasonable explanation, it's going to work equally well or bad in any size | 10:47 |
ajo | as long as data fits | 10:47 |
ajo | http://dev.mysql.com/doc/refman/5.7/en/char.html | 10:47 |
scheuran | rossella_s, you're right and it's still there.. unfortunately it was not present anymore in _bind_port. Something reset the original binding before to the new empty binding... | 10:48 |
rossella_s | scheuran, not sure if it's too complex to change the code so that you can get the vif_details from the old binding | 10:48 |
ajo | ihrachys_, IMHO we should probably start using JSON fields, but that's only available in latests mysql's | 10:48 |
ajo | 5.7+ | 10:48 |
ajo | also in postgresql, but haven't checked which version | 10:48 |
rossella_s | scheuran, either you find out how to avoid the reset...or since you need this info only if it a migration, you can check if it's a migration and get the data from the db | 10:49 |
liuyulong | @jschwarz, and for the patch https://review.openstack.org/#/c/265685/, any advice? seems that the DB error was no longer existed. | 10:50 |
scheuran | rossella_s, I think at that point in time it's too late to catch the data from db - but I need to verify, first. I hope I can find the place where it gets removed.. | 10:50 |
rossella_s | scheuran, I am sure you can find it...question is if it's going to be easy to modify the code without breaking other stuff.. | 10:50 |
scheuran | rossella_s, :) | 10:51 |
rossella_s | scheuran, good luck! | 10:51 |
scheuran | rossella_s, thanks | 10:51 |
ajo | ihrachys_, please also check my comments in PS14: https://review.openstack.org/#/c/268040/14/neutron/db/agents_db.py | 10:51 |
ajo | I rebased and those are lost, but I believe it's probably a good strategy what I was thinking of | 10:51 |
*** hanchao has quit IRC | 10:51 | |
ajo | because it buys us less changes in the plugins that use agents | 10:52 |
*** thorst_afk has quit IRC | 10:53 | |
ajo | ihrachys_, specifically: https://review.openstack.org/#/c/268040/14/neutron/db/agents_db.py@372 | 10:53 |
ihrachys_ | ajo: JSON type is not supported by our sqlalchemy version | 10:53 |
*** markvoelker has joined #openstack-neutron | 10:54 | |
*** salv-orlando has quit IRC | 10:57 | |
ajo | ihrachys_, hm, I thought it was already there, but I guess we don't use yet latest an greatest | 10:57 |
ihrachys_ | ajo: it's 1.1 | 10:57 |
ihrachys_ | and we have <1.1 | 10:57 |
ihrachys_ | we use 1.0.+ now | 10:57 |
ajo | ack | 10:58 |
ajo | that has to wait then | 10:58 |
jlibosva | ajo: yes, I saw that too. Note it has nothing to do with ovs firewall :) | 10:58 |
jlibosva | ajo: I saw a patch today from kevinbenton to add some additional info to see what's going on | 10:58 |
*** markvoelker has quit IRC | 10:58 | |
ajo | jlibosva, yes, but you wrote the test, right? :) | 10:58 |
ajo | ack | 10:59 |
jlibosva | ajo: no | 10:59 |
*** yfried has quit IRC | 10:59 | |
*** liuyulong has quit IRC | 10:59 | |
ajo | ahh, ok, ':D | 10:59 |
jlibosva | :] | 10:59 |
ajo | jlibosva, just curious, do you know what's the patch with extra debug? | 10:59 |
jlibosva | ajo: you want link? | 10:59 |
ajo | jlibosva, https://review.openstack.org/#/c/285181/ I guess? | 11:00 |
ajo | :) | 11:00 |
jlibosva | ajo: your guess is correct :) | 11:00 |
ihrachys_ | ajo: agreed that moving the code into report_state handler would be the best. | 11:00 |
ihrachys_ | ajo: I posted some comments | 11:00 |
*** lajos-katona has joined #openstack-neutron | 11:01 | |
*** vikram_ has joined #openstack-neutron | 11:01 | |
ajo | ihrachys_, thanks, I'll finish the QoS LB review, and move back to it | 11:02 |
ajo | ihrachys_, was the unit conversion concern because my conversation bout burst_kbps ? | 11:02 |
ajo | abou | 11:02 |
ajo | t | 11:02 |
ajo | ....... ':) | 11:02 |
ihrachys_ | ajo: no, it's different | 11:02 |
ihrachys_ | ajo: it's about tc using bytes not bits | 11:02 |
ihrachys_ | and slaweq realized it lately | 11:02 |
ajo | ihrachys_, ack | 11:06 |
*** miyagishi_t_ has joined #openstack-neutron | 11:12 | |
hdaniel | ajo: I'd like to attempt it myself at first :) , 10x | 11:13 |
slaweq__ | ihrachys_ ajo: yep, I have it fixed on my dev host already | 11:14 |
slaweq__ | but I need to fix also this problem with notifications about policy update | 11:14 |
slaweq__ | and then will push it all to review | 11:14 |
ajo | njohnston, do we know if VXLAN/GRE linux implementation copies the DSCP flags from the inner packets to the outer frame ? | 11:18 |
ajo | that'd be cool for vxlan tenant networks | 11:18 |
ajo | you'd get in-tenant packet prioritization too | 11:18 |
*** gvrangan_ has quit IRC | 11:21 | |
*** gvrangan has quit IRC | 11:21 | |
ajo | hmm http://lxr.free-electrons.com/source/drivers/net/vxlan.c#L1979 | 11:21 |
*** gongysh has quit IRC | 11:22 | |
ihrachys_ | mestery: I wonder whether we could let https://review.openstack.org/#/c/263819/ going | 11:25 |
njohnston | ajo: No, it does not. There are RFCs that govern that if you want to do that, and it gets very complicated very quickly, especially if you imagine a vxlan where some of the packets should be tagged DSCP but others shouldn't, so you get different on-the-wire behavior from different packets in the same TCP sequence. | 11:29 |
njohnston | ajo: So our approach for this was to avoid the entire question and not tag the encapsulating frame. | 11:29 |
ajo | hmm njohnston can you explain? | 11:30 |
ajo | why if every packet is individually encapsulate would be an issue? | 11:30 |
ajo | or can a vxlan packet encapsulate several? | 11:30 |
ajo | individually encapsulate -> encapsulated | 11:30 |
ajo | I see the vxlan support in kernel seems to have support for that (if you set the tos flag to 1, and I didn't get it wrong) | 11:31 |
ajo | but ovs does not set that flag | 11:31 |
ajo | we could make it optional | 11:32 |
*** armax has joined #openstack-neutron | 11:32 | |
ajo | admin could deploy his net with that on or off | 11:32 |
*** EinstCrazy has joined #openstack-neutron | 11:32 | |
ajo | njohnston: for example an agent setting... (I'm not talking about now, but possible future follow ups if it makes any sense at all) | 11:32 |
ajo | njohnston, and of course, we'd need some setting in openvswitch to propagate that down to https://github.com/openvswitch/ovs/blob/master/datapath/vport-vxlan.c#L91 | 11:33 |
njohnston | ajo: Yeah, I could definitely see it in a future follow up. It could be useful especially in cases where congestion is an issue, but it would have to be tested to make sure the vxlan wouldn't freak out if packets arrived out-of-order or with significant drops in the non-tagged packets. FYI the governing RFC for this is https://tools.ietf.org/html/rfc2983 | 11:34 |
*** achanda has joined #openstack-neutron | 11:35 | |
ajo | oh, thanks for the pointer njohnston | 11:35 |
*** armax has quit IRC | 11:36 | |
*** pavel_bondar has quit IRC | 11:36 | |
ajo | njohnston: I understand the concern, but of course, it'd be another tool for admins to tune their networks, they can shot themselves on the foot in many different ways :D | 11:36 |
*** sudipto has quit IRC | 11:36 | |
ajo | I'll read the RFC | 11:36 |
*** miyagishi_t_ has quit IRC | 11:37 | |
njohnston | :-) | 11:39 |
*** achanda has quit IRC | 11:39 | |
*** baohua has quit IRC | 11:50 | |
*** thorst_afk has joined #openstack-neutron | 11:50 | |
ajo | njohnston, I'd say vxlan doesn't have an issue with that, I think it doesn't have any sequence number | 11:51 |
ajo | it's just VNI and metadata (/me checks) | 11:51 |
*** baohua has joined #openstack-neutron | 11:51 | |
ajo | njohnston, I understand what you mean now, but yeah, I think VXLAN is quite sequence independent | 11:52 |
*** thorst_afk has quit IRC | 11:57 | |
*** baoli has joined #openstack-neutron | 11:58 | |
openstackgerrit | LIU Yulong proposed openstack/neutron: Catch exceptions during the delete of tenant last HA router https://review.openstack.org/265682 | 11:59 |
ajo | slaweq, ping: https://review.openstack.org/#/c/236210/29 what's the issue bit/bytes that ihrachys_ comments respect to burst rate, I couldn't notice it by looking at the code | 11:59 |
ihrachys_ | ajo: stop mixing things :) | 11:59 |
ihrachys_ | ajo: burst is not related to that at all | 12:00 |
ajo | oh | 12:00 |
ajo | sorry :D | 12:00 |
ajo | general bit/byte | 12:00 |
ajo | I see they handle the conversion | 12:00 |
ihrachys_ | yes | 12:00 |
ajo | to bytes for TC | 12:00 |
ajo | may be tc works with bits ? | 12:00 |
ihrachys_ | burst issue is about the param having _kbps postfix | 12:00 |
ajo | correct | 12:00 |
ihrachys_ | iiuc tc works with bytes | 12:00 |
ihrachys_ | and our API is kbit based | 12:00 |
ajo | ihrachys_, but he handles the conversion in code | 12:01 |
ihrachys_ | ajo: prolly in wrong way | 12:01 |
ajo | https://review.openstack.org/#/c/236210/29/neutron/agent/linux/tc_lib.py@112 | 12:01 |
ajo | https://review.openstack.org/#/c/236210/29/neutron/agent/linux/tc_lib.py@129 | 12:02 |
ihrachys_ | ajo: iiuc tc uses 'kb' postfix for bytes | 12:02 |
ihrachys_ | so you don't need to convert | 12:02 |
ajo | hh | 12:02 |
ajo | he's using "kb" postfix | 12:02 |
ajo | that's it | 12:02 |
slaweq__ | ajo: tc is using strange (for me) notation of units | 12:02 |
ihrachys_ | what was the link to gate failures dashboard? | 12:02 |
*** ihrachys_ is now known as ihrachys | 12:03 | |
slaweq__ | and I made mistake there because in tc kbps means kilobytes (not kilobits as usual) | 12:03 |
*** baoli has quit IRC | 12:03 | |
slaweq__ | that's why in this file I configured wrong values in fact | 12:03 |
ajo | ahaaa | 12:03 |
ajo | I see http://man7.org/linux/man-pages/man8/tc.8.html | 12:04 |
*** baoli has joined #openstack-neutron | 12:04 | |
ajo | acl | 12:04 |
slaweq__ | exactly | 12:04 |
slaweq__ | and I made mistake because in neutron api it is also kbps (and in ovs also) but it means something different | 12:05 |
slaweq__ | :) | 12:05 |
slaweq__ | but I found it in fullstack test when I started doing it few days ago :) | 12:05 |
slaweq__ | so fullstack tests are good | 12:05 |
ajo | fullstack++ | 12:05 |
hdaniel | ajo: did you try rebasing your rpc patch over the 'tempest_lib' one ? | 12:06 |
slaweq__ | and also in this test I found that LinuxBridge agent is not consuming "policy update" notifications | 12:06 |
ajo | hdaniel, I did, it's rebased | 12:07 |
hdaniel | and you don't get 'No module named lib.common.utils' ? | 12:07 |
ajo | hdaniel, where? | 12:07 |
hdaniel | ajo: when running api tests | 12:07 |
ajo | hdaniel, nope | 12:07 |
ajo | hdaniel, : https://review.openstack.org/#/c/268040/ | 12:08 |
*** yamamoto has quit IRC | 12:08 | |
*** mubirru has quit IRC | 12:08 | |
hdaniel | ajo: hmmm, I was trying to run it on my env before that - it fails finding the utils module. oh well. | 12:09 |
ajo | hdaniel, may be you need to update your tempest repo | 12:12 |
ajo | hdaniel, it's probably that | 12:12 |
ajo | they copied tempest_lib inside tempest | 12:12 |
ajo | and your local copy of tempest os probably outdated | 12:12 |
ajo | cd /opt/stack/tempest; git pull | 12:12 |
ajo | hdaniel, ^ | 12:12 |
ajo | os->is | 12:13 |
*** krotscheck_dcm is now known as krotscheck | 12:13 | |
hdaniel | ajo++ | 12:15 |
ajo | hdaniel, :) | 12:15 |
*** baoli has quit IRC | 12:15 | |
ajo | did it work? | 12:16 |
*** wolverineav has joined #openstack-neutron | 12:17 | |
*** baoli has joined #openstack-neutron | 12:20 | |
*** salv-orlando has joined #openstack-neutron | 12:20 | |
*** zhipeng has quit IRC | 12:21 | |
*** baohua has quit IRC | 12:22 | |
*** wolverineav has quit IRC | 12:22 | |
*** baoli has quit IRC | 12:23 | |
*** baohua has joined #openstack-neutron | 12:24 | |
*** sleviim has joined #openstack-neutron | 12:31 | |
*** sleviim has left #openstack-neutron | 12:31 | |
*** amotoki_ has joined #openstack-neutron | 12:32 | |
*** claudiub has quit IRC | 12:34 | |
*** amotoki has quit IRC | 12:34 | |
openstackgerrit | Haim Daniel proposed openstack/neutron: Qos policy RBAC DB setup and migration https://review.openstack.org/250081 | 12:39 |
*** fzdarsky is now known as fzdarsky|afk | 12:39 | |
*** markvoelker has joined #openstack-neutron | 12:40 | |
*** markvoelker has quit IRC | 12:44 | |
*** bsv___ has quit IRC | 12:45 | |
*** julim has joined #openstack-neutron | 12:45 | |
*** MCoLo has quit IRC | 12:48 | |
*** thorst_afk has joined #openstack-neutron | 12:50 | |
ajo | ihrachys, good catch there: https://review.openstack.org/#/c/268040/15/neutron/api/rpc/callbacks/version_manager.py@106 | 12:53 |
* ajo goes for lunch | 12:53 | |
*** johnbelamaric has quit IRC | 12:56 | |
*** emagana has joined #openstack-neutron | 12:57 | |
*** ArchiFleKs has quit IRC | 13:01 | |
*** korzen_ has joined #openstack-neutron | 13:01 | |
*** yamamoto has joined #openstack-neutron | 13:01 | |
*** emagana has quit IRC | 13:01 | |
*** korzen has quit IRC | 13:02 | |
*** jpena is now known as jpena|lunch | 13:02 | |
*** ArchiFleKs has joined #openstack-neutron | 13:02 | |
*** claudiub has joined #openstack-neutron | 13:03 | |
openstackgerrit | Akihiro Motoki proposed openstack/python-neutronclient: WIP: Allow to add non-CRUD methods to v2_0.client thru client extension https://review.openstack.org/285288 | 13:04 |
openstackgerrit | Ryan Moats proposed openstack/neutron: Collector Proof of Concept https://review.openstack.org/213474 | 13:05 |
*** yamamoto has quit IRC | 13:05 | |
*** jckasper has joined #openstack-neutron | 13:06 | |
*** davidsha has quit IRC | 13:06 | |
*** ArchiFleKs has quit IRC | 13:09 | |
*** lucasagomes is now known as lucas-hungry | 13:09 | |
*** ArchiFleKs has joined #openstack-neutron | 13:09 | |
*** baoli has joined #openstack-neutron | 13:10 | |
*** jckasper has quit IRC | 13:10 | |
*** ArchiFleKs has quit IRC | 13:13 | |
*** prithiv has joined #openstack-neutron | 13:14 | |
*** itisha has joined #openstack-neutron | 13:15 | |
*** MCoLo has joined #openstack-neutron | 13:15 | |
*** banix has joined #openstack-neutron | 13:16 | |
*** pavel_bondar has joined #openstack-neutron | 13:16 | |
*** eddima1 has joined #openstack-neutron | 13:17 | |
*** ArchiFleKs has joined #openstack-neutron | 13:17 | |
*** fzdarsky|afk is now known as fzdarsky | 13:17 | |
*** baoli_ has joined #openstack-neutron | 13:17 | |
*** eddima has quit IRC | 13:17 | |
*** eddima1 is now known as eddima | 13:17 | |
*** davidsha has joined #openstack-neutron | 13:18 | |
*** thorst_afk is now known as thorst | 13:18 | |
*** baohua has quit IRC | 13:19 | |
*** markvoelker has joined #openstack-neutron | 13:20 | |
*** neeti has quit IRC | 13:20 | |
*** baoli has quit IRC | 13:20 | |
*** akshai has joined #openstack-neutron | 13:21 | |
*** akshai_ has joined #openstack-neutron | 13:23 | |
*** yamamoto has joined #openstack-neutron | 13:25 | |
*** dslevin has joined #openstack-neutron | 13:26 | |
*** akshai has quit IRC | 13:26 | |
*** dslevin has quit IRC | 13:26 | |
*** dslevin has joined #openstack-neutron | 13:27 | |
*** sleviim has joined #openstack-neutron | 13:29 | |
*** neelashah has joined #openstack-neutron | 13:29 | |
*** sleviim has left #openstack-neutron | 13:29 | |
*** akshai_ has quit IRC | 13:29 | |
*** yamamoto has quit IRC | 13:30 | |
*** pradk has joined #openstack-neutron | 13:31 | |
*** pradk has quit IRC | 13:31 | |
*** fawadkhaliq has joined #openstack-neutron | 13:36 | |
*** abregman has joined #openstack-neutron | 13:37 | |
*** achanda has joined #openstack-neutron | 13:37 | |
ihrachys | Sam-I-Am: nice progress on MTU stuff | 13:39 |
*** cappetta has joined #openstack-neutron | 13:39 | |
ihrachys | I think I reviewed all the bits currently uploaded to gerrit. I assume that's all that we want in, right? | 13:40 |
openstackgerrit | Hynek Mlnarik proposed openstack/neutron: Use cookies consistently in flows of all bridges https://review.openstack.org/284639 | 13:42 |
*** achanda has quit IRC | 13:42 | |
*** pradk has joined #openstack-neutron | 13:43 | |
*** javeriak has quit IRC | 13:44 | |
openstackgerrit | Akihiro Motoki proposed openstack/python-neutronclient: WIP: Allow to add non-CRUD methods to v2_0.client thru client extension https://review.openstack.org/285288 | 13:44 |
openstackgerrit | abregman proposed openstack/neutron: DO NOT MERGE - Verfying doc gate functionalility https://review.openstack.org/284849 | 13:45 |
*** shwetaap has joined #openstack-neutron | 13:45 | |
Sam-I-Am | ihrachys: yeah i think so | 13:45 |
*** shwetaap1 has joined #openstack-neutron | 13:47 | |
*** jckasper has joined #openstack-neutron | 13:47 | |
*** lnicolas has quit IRC | 13:49 | |
*** shwetaap has quit IRC | 13:50 | |
*** edmondsw has joined #openstack-neutron | 13:50 | |
*** jckasper has quit IRC | 13:52 | |
*** dims has joined #openstack-neutron | 13:54 | |
*** feleouet has joined #openstack-neutron | 13:55 | |
*** johnbelamaric has joined #openstack-neutron | 13:57 | |
*** armax has joined #openstack-neutron | 13:57 | |
*** eddima has quit IRC | 13:57 | |
*** eddima has joined #openstack-neutron | 13:58 | |
Sam-I-Am | ihrachys: i think we might need a relnote because support for larger than 1500 byte MTU is a feature | 13:58 |
ihrachys | right | 13:58 |
Sam-I-Am | in addition to fixing something that should have just worked | 13:58 |
*** eddima has quit IRC | 13:59 | |
*** eddima has joined #openstack-neutron | 13:59 | |
*** shwetaap1 has quit IRC | 14:00 | |
openstackgerrit | Armando Migliaccio proposed openstack/neutron: Switch to using in-tree tempest lib https://review.openstack.org/284911 | 14:00 |
ajo | hi hynekm++ ^ nice patch : | 14:00 |
*** skamithi13 has joined #openstack-neutron | 14:00 | |
*** eddima has quit IRC | 14:01 | |
hynekm | ajo, thanks. would you mind reviewing it? :-) | 14:02 |
pc_m | armax: ping | 14:02 |
armax | pc_m: pong | 14:02 |
pc_m | armax: Hi. For vpnaas, I modified (and upstreamed) tox.ini so that is runs all targets with constraints. | 14:02 |
armax | pc_m: ok | 14:02 |
pc_m | armax: I cherry picked to Liberty, but it fails, because vpn uses a neutron script, which in liberty does not support this. | 14:03 |
armax | on this note, I wonder where the vpn api transition effort lies | 14:03 |
armax | pc_m: forget about liberty for now, that would be my advice | 14:03 |
armax | to me the api tests for mitaka is top priority | 14:03 |
pc_m | This is running constraints w/o using -constraints name in target. | 14:03 |
*** annemccormick has joined #openstack-neutron | 14:04 | |
pc_m | understood. Just trying to get the bug I was working on (constraints for *aas/Nlib) done. | 14:04 |
armax | that’s done for mitaka though | 14:04 |
pc_m | didin't know if you wanted neutron updated (and backported) or not. | 14:04 |
armax | is it not? | 14:05 |
armax | well ideally | 14:05 |
armax | but if it’s too convoluted | 14:05 |
pc_m | yes, however, the project config job is setup for liberty and mitaka. | 14:05 |
*** korzen has joined #openstack-neutron | 14:05 | |
armax | we may want to put up with the current status for an extra cycle | 14:05 |
ajo | hynekm, I will as soon as I respin the rpc patch I will 'eyeball' your patch | 14:05 |
armax | it’s not like we’d be cronically broken if we don’t backport the constraints magic | 14:06 |
pc_m | armax: So skip backport for Liberty? | 14:06 |
armax | pc_m: unless it’s straightforward and you can accomplish with minimal effort | 14:06 |
*** korzen_ has quit IRC | 14:07 | |
pc_m | It requires updating neutron script. Which means, updating neutron for mitaka, backporting that, and then vpn is good to go. | 14:07 |
pc_m | neutron still uses the -constraints named targets. | 14:07 |
pc_m | vpn is the only one converted over completely so far. | 14:08 |
hynekm | ajo, hope that the eyeballs won't be rolling too fast :) thanks | 14:08 |
armax | pc_m: so you’re saying that vpn is not constrained in mitaka either? | 14:08 |
pc_m | armax: no. | 14:08 |
*** skamithi has joined #openstack-neutron | 14:08 | |
ajo | hynekm, lol | 14:08 |
pc_m | armax: VPN is using constraints for mitaka, like all the others, only the target names (per TC's request) do not have -constraints suffix. | 14:09 |
pc_m | IOW constraints is the default. | 14:09 |
armax | pc_m: right, I think I saw that somewhere | 14:09 |
pc_m | So, I went into vpn and changed tox.ini and gate hooks. Upstreamed that work. | 14:09 |
russellb | kevinbenton: nope, i'm already on the way home | 14:10 |
pc_m | Now there are several avenues. Leave liberty with unconstrained targets (py27,...), or cherry pick. To do the latter, we need change to neutron. | 14:10 |
*** eddima has joined #openstack-neutron | 14:10 | |
armax | pc_m: I see | 14:10 |
armax | pc_m: changing neutron master to drop the -constraints labels and backport you mean? | 14:11 |
*** vhoward has joined #openstack-neutron | 14:11 | |
pc_m | Wanting to know if I should do the neutron conversion (py-27 vs py27-constraints) for mitaka, and whether it that should be backported. | 14:11 |
pc_m | armax: yas | 14:11 |
pc_m | yes | 14:11 |
armax | pc_m: do you have that note from the TC? | 14:12 |
armax | pc_m: I recall seeing this done somewhere in Nova | 14:12 |
armax | pc_m: but that’s all I recall | 14:12 |
pc_m | armax: No. It was in meeting mins, several weeks ago. | 14:12 |
pc_m | They don't want the -constraints targets. | 14:12 |
armax | when it comes to touching stable branches, ihrachys should really be the one signing off on any activity like that | 14:13 |
ihrachys | armax: whatsup | 14:13 |
*** abregman is now known as abregman|nb | 14:13 | |
pc_m | armax: He's been on the reviews, as has doug | 14:13 |
armax | we could pursue the venue that you suggested, but I am failing to grasp what it would happen if we dropped the -constraints label on master only | 14:13 |
armax | and leave Liberty be | 14:13 |
armax | ihrachys: I was pulling you in because pcm would like to rename the gate jobs and have the -constraints job dropped | 14:14 |
pc_m | armax: for VPN, it will NOT be using constraints on Liberty (as it stands today) | 14:14 |
armax | now that would need to be done in master before it could be backported | 14:14 |
*** EinstCrazy has quit IRC | 14:14 | |
ihrachys | armax: it's the issue of different names for tox targets in master vs stable? | 14:14 |
armax | ihrachys: correct | 14:15 |
armax | now, I must admit I am not up to speed with the marching orders | 14:15 |
ihrachys | ok. do we have a plan that I could digest? | 14:15 |
*** rtheis has joined #openstack-neutron | 14:15 | |
armax | but I would suspect that flipping the constraints suffix would require touching project-config too | 14:15 |
pc_m | ihrachys: VPN master done. Libery, issue w/dependency on neutron. | 14:16 |
armax | pc_m: if you could provide us with the notes | 14:16 |
*** yamamoto has joined #openstack-neutron | 14:16 | |
pc_m | armax: Will dig for them. | 14:16 |
armax | pc_m: that would give us better insight why the rename exercise would be necessary and its timeline | 14:16 |
*** jckasper has joined #openstack-neutron | 14:16 | |
*** jpena|lunch is now known as jpena | 14:16 | |
armax | at this point, I am not sure I have enough information to make a decision | 14:17 |
armax | or provide a suggestion | 14:17 |
*** tiswanso has joined #openstack-neutron | 14:18 | |
*** wolverineav has joined #openstack-neutron | 14:19 | |
armax | pc_m: pls let me know what the rationale for the rename is and we can review what we can do in time for the mitaka release | 14:19 |
ihrachys | armax: pc_m: I think it would be wise to have some etherpad with all details, so that we could grasp the whole picture before we go into implementation | 14:19 |
armax | in the meantime, if there’s anything I can help you with to facilitate the setup of the api job for vpnaas, feel free to ping me | 14:20 |
*** insequent has quit IRC | 14:20 | |
ihrachys | davidsha: some nits in the patch. I am fine to +2 after it's handled. | 14:20 |
pc_m | armax: http://eavesdrop.openstack.org/meetings/tc/2016/tc.2016-01-19-20.02.log.html | 14:20 |
pc_m | There was no mandate for a time frame | 14:20 |
* armax reads | 14:21 | |
*** insequent has joined #openstack-neutron | 14:21 | |
pc_m | armax: They want projects to move to not using the constraints naming. | 14:21 |
davidsha | ihrachys: just responding, I can do the dots but not the ones in br_cookie, I'll put it in the comments | 14:21 |
*** jaypipes is now known as sicklypipes | 14:22 | |
pc_m | lifeless: Can you comment on constraints from a TC perspective ^^ | 14:22 |
armax | pc_m: bear in mind that we don’t run two jobs in the gate | 14:22 |
armax | pc_m: so really we have already opted in | 14:22 |
pc_m | armax: I'm not sure who is working on the API stuff, nor where the status is on that (I'm not working on it, nor plan to) | 14:22 |
armax | the developer has the choice to run the unconstrained target if they wanted to | 14:22 |
*** lucas-hungry is now known as lucasagomes | 14:23 | |
armax | but from scanning through the review it doesn’t seem like dropping the unconstrained target and renaming the jobs buys us anything | 14:23 |
armax | pc_m: well, thanks! | 14:23 |
*** wolverineav has quit IRC | 14:24 | |
armax | pc_m: I think the madhu is working on it | 14:24 |
davidsha | ihrachys: nvm I'll try it out now | 14:24 |
ihrachys | davidsha: ok ping me when done | 14:24 |
ihrachys | davidsha: ok :) | 14:24 |
armax | pc_m: I was simply suggest you’d keep an eye on it and help her where required | 14:24 |
armax | pc_m: after all you’re one of the vpn custodians | 14:25 |
armax | pc_m: are you not? | 14:25 |
pc_m | armax: Have been and will continue. | 14:25 |
pc_m | armax: Well, no... I moved away from that months ago... remember? | 14:25 |
*** anshul has quit IRC | 14:25 | |
*** abregman|nb is now known as abregman | 14:26 | |
pc_m | armax: I've been trying to do reviews and address critical issues, like breakages, as much as I can. | 14:26 |
*** akshai has joined #openstack-neutron | 14:26 | |
armax | pc_m: right, but there’s stuff that’s still pending | 14:27 |
armax | pc_m: it’d be nice to identify someone who could take over at full capacity | 14:27 |
pc_m | armax: sure, but not any tasks I promised to complete for that repo. I completed the work I had in hand at the time I notified people I was moving off of that project. | 14:28 |
pc_m | armax: There are a few people that have been helping, but no-one has stepped up. | 14:28 |
*** baoli has joined #openstack-neutron | 14:28 | |
armax | pc_m: that were clearly important tasks that were not completed nor started | 14:28 |
armax | pc_m: I am not saying you should be dragged back in | 14:29 |
armax | pc_m: but if you have bandwidth to do anything with vpn | 14:29 |
*** hynekm has quit IRC | 14:29 | |
armax | like the constraints stuff | 14:29 |
pc_m | armax: good, because my employer doesn't want me to continue on vpn. | 14:29 |
armax | I’d rather suggest you to work on higher priority stuff | 14:29 |
armax | not just stuff that pleases you | 14:29 |
armax | pc_m: ok, that’s fine I get that | 14:29 |
armax | pc_m: let’s figure out together what can be done, otehrwise we’ll be forced to mark vpn as a rotten apple and move on | 14:30 |
ajo | ihrachys, can you have an eye on https://review.openstack.org/#/c/268040/15/neutron/api/rpc/callbacks/version_manager.py@173 , I will be working in other parts, but I'd like to check if that sounds reasonable to you. | 14:30 |
pc_m | armax: Believe me constraints is not something that pleases me. I'm trying to fullfill that obligation that I committed to. | 14:30 |
armax | pc_m: where is this obligation coming from? | 14:31 |
pc_m | armax: https://bugs.launchpad.net/neutron/+bug/1522503 | 14:31 |
openstack | Launchpad bug 1522503 in neutron "Add support for constraints based jobs for neutron-*aas and -lib" [High,In progress] - Assigned to Paul Michali (pcm) | 14:31 |
*** baoli_ has quit IRC | 14:31 | |
pc_m | armax: So last word on this. Please respond to that bug and indicate what you want done - continued, done on liberty too, dropped, whatever. | 14:32 |
armax | ok | 14:32 |
ihrachys | ajo: I don't mind. let's get it in. | 14:32 |
armax | pc_m: is the job completed in master? | 14:32 |
armax | for all repos? | 14:32 |
ajo | ihrachys, ack, let me fix it | 14:32 |
*** akshai has quit IRC | 14:33 | |
pc_m | armax: no. I completed on VPN. I had some work done on the other repos, but because of the TC recommendation, I abandoned the work, and reworked VPN to meet those needs. | 14:33 |
ihrachys | pc_m: can we get the state of constraints captured somewhere, and we could then take it from there? | 14:34 |
armax | pc_m: ok, consider the job complete and move on | 14:34 |
pc_m | armax: Essentially, infra didn't want changes done unless they were in line with the new method. | 14:34 |
armax | pc_m: we’ll pick it up if need be | 14:34 |
pc_m | armax: Please put that in the bug. | 14:34 |
pc_m | armax: Your decision on the matter. | 14:35 |
armax | pc_m: dfoner | 14:35 |
armax | done | 14:35 |
pc_m | armax: thanks. | 14:35 |
armax | pc_m: you’re good, fly high | 14:35 |
*** baoli has quit IRC | 14:35 | |
*** amotoki_ has quit IRC | 14:36 | |
*** dansmith is now known as superdan | 14:36 | |
scheuran | hi rossella_s, I figured out a way how to prevent the port binding on an invalid live migration in the plugin and I also can detect that in the agent.. | 14:37 |
scheuran | rossella_s, but somehow I have messed up my test systems and I'm not sure if I can point a solution by end of today | 14:37 |
scheuran | rossella_s, do you see a chance to get the main part merged right before m3, and then handle the live migration thing as a bugfix? | 14:38 |
*** mlavalle has joined #openstack-neutron | 14:41 | |
rossella_s | scheuran, your rfe was approved for mitaka and the code is quite isolated...it shouldn't be a problem to merge it. Maybe you can specify that live migration is not supported. Regarding treating the live migration fix as bug...might be risky to merge it, it depends on how much you change | 14:41 |
rossella_s | scheuran, anyway you should talk about it with the neutron drivers and the PTL...you might want to ping kevinbenton and armax | 14:42 |
*** localloop127 has joined #openstack-neutron | 14:42 | |
*** sc68cal has joined #openstack-neutron | 14:44 | |
Sam-I-Am | mornings | 14:45 |
sc68cal | Sam-I-Am: morning | 14:45 |
scheuran | rossella_s, ok, thanks - will do | 14:45 |
*** dane_leblanc has joined #openstack-neutron | 14:45 | |
rossella_s | scheuran, np :) | 14:46 |
Sam-I-Am | sc68cal: MOOOOOOOOOoooo | 14:46 |
*** banix has quit IRC | 14:46 | |
scheuran | rossella_s, FYI, it was really just passing the original port into the new context and then this information is available in the mech driver... | 14:47 |
rossella_s | scheuran, then it seems safe | 14:47 |
scheuran | armax, do you have second to discuss how to continue with https://bugs.launchpad.net/neutron/+bug/1480979 | 14:48 |
openstack | Launchpad bug 1480979 in neutron "[RFE] Adding macvtap ml2 driver and agent" [Wishlist,In progress] - Assigned to Andreas Scheuring (andreas-scheuring) | 14:48 |
*** amotoki has joined #openstack-neutron | 14:48 | |
*** gvrangan has joined #openstack-neutron | 14:48 | |
*** gvrangan_ has joined #openstack-neutron | 14:48 | |
armax | scheuran: only a few mins | 14:49 |
armax | scheuran: what about it? | 14:49 |
scheuran | armax, that should be sufficient | 14:49 |
scheuran | armax, the mech driver has already, merged, the agent is short before getting merged | 14:49 |
scheuran | armax, there's just one open issue | 14:49 |
scheuran | that came up the last 2 days | 14:49 |
armax | ok | 14:49 |
scheuran | armax, it's about live migration | 14:50 |
scheuran | armax, it works, but if host a has an interface mapping of physnet1=eth0 and host2 a mapping of physnet1=abc | 14:50 |
scheuran | armax, the migrated instance will be placed on eth0 on host2 as well (although not specified in the mapping) | 14:50 |
*** baoli has joined #openstack-neutron | 14:51 | |
scheuran | armax, this is a problem | 14:51 |
armax | scheuran: none of the patches that target the bug have release notes, vbtw | 14:51 |
armax | scheuran: am I missing something? | 14:51 |
*** crose has joined #openstack-neutron | 14:51 | |
armax | could this be captured in the release notes perhaps? | 14:51 |
*** akshai has joined #openstack-neutron | 14:51 | |
scheuran | armax, https://review.openstack.org/#/c/275306/ | 14:52 |
scheuran | armax, this is the last outstanding patch | 14:52 |
armax | scheuran: ah, wrong topic | 14:52 |
scheuran | armax, sorry, I changed it again by mistake... | 14:52 |
scheuran | armax, yes, it could be handled by the release notes | 14:52 |
armax | scheuran: how much of a release blocker you think this is? | 14:53 |
scheuran | armax, I can detect those missbehaviors in the agent and in the mech driver - but there's no time left to fix that before m3 I assume | 14:53 |
scheuran | armax, so my question is if we could merge the main part and handle the migration issue as a bugfix | 14:53 |
armax | scheuran: it sounds like the live migration behavior is undetermined if the compute nodes are not configured uniformly | 14:54 |
scheuran | armax, right | 14:54 |
armax | at least in the current version of the coe | 14:54 |
armax | code | 14:54 |
*** mhickey has joined #openstack-neutron | 14:54 | |
scheuran | exactly | 14:54 |
armax | this is going to be greenfield though, would it not? | 14:54 |
armax | I expect to capture this in the release notes | 14:54 |
*** fawadkhaliq has quit IRC | 14:55 | |
armax | scheuran: bear in mind that I would like to see openstack-manuals content for this effort to be marked complete | 14:55 |
*** abregman is now known as abregman|nb | 14:55 | |
armax | I mean the networking guide section for the openstack-manuals | 14:55 |
scheuran | armax, sorry what do you mean by " going to be greenfield though" ? | 14:55 |
scheuran | armax, the scenario guide already has a workflow | 14:55 |
scheuran | it's just waiting for the agent patch to get it | 14:56 |
armax | then we can elaborate a bit more on how this issue manifests itself and how to make sure the admin can prevent him/herselfs from shooting his/her foot | 14:56 |
armax | scheuran: what I mean is that you need deploy the mactapv agents for the first time | 14:56 |
scheuran | armax, right | 14:57 |
scheuran | armax, and yes, if the admin configures everything correctly - there is no issue! | 14:57 |
scheuran | armax, so you would be ok if I document this in more detail in the scenario guide? | 14:57 |
*** rossella_s has quit IRC | 14:58 | |
scheuran | armax, I mean I still can come up with a fix for that before the final release | 14:58 |
scheuran | but probably not before m3 | 14:58 |
armax | scheuran: if you have time then we can figure out the extent of the fix and see if there’s time during the rc window | 14:58 |
openstackgerrit | Sean M. Collins proposed openstack/neutron: ML2: Increase segment_mtu from 0 to 1500 bytes https://review.openstack.org/284407 | 14:58 |
openstackgerrit | Sean M. Collins proposed openstack/neutron: Set DEFAULT_NETWORK_MTU constant to sane 1500 byte default https://review.openstack.org/285339 | 14:58 |
*** rossella_s has joined #openstack-neutron | 14:58 | |
*** fishbone has joined #openstack-neutron | 14:58 | |
Sam-I-Am | sc68cal: pffft, sane values | 14:59 |
sc68cal | Sam-I-Am: I know right? | 14:59 |
armax | scheuran: but I’d suggest to make sure we have at least enough doc in place and point to the issue (bug report) and if we have time to nail it down | 14:59 |
Sam-I-Am | i need to write a relnote for the mtu patch... | 14:59 |
Sam-I-Am | well, one of them | 14:59 |
armax | scheuran: great, if not at least we don’t cause any unwanted surprise | 14:59 |
Sam-I-Am | solving world hunger... and mtu problems | 14:59 |
scheuran | armax, so if I got you right: let's merge this, let's udpate the docs to reflect more details and let's open a bug for it and try to resolve before the rc phase? | 15:00 |
armax | yes | 15:00 |
armax | scheuran: now to make sure I understood you right | 15:01 |
*** jreeves has quit IRC | 15:01 | |
armax | scheuran: this issue is a blocker for deployments where you roll out the mactap driver alongside LB or OVS agents and compute hosts have heterogeneous physnet attachments | 15:01 |
armax | blocker as far as live migration goes | 15:01 |
armax | or any type of migration for that matter | 15:02 |
armax | like resize or block migration | 15:02 |
scheuran | armax, ovs or lb are not in the game | 15:02 |
*** amotoki has quit IRC | 15:02 | |
scheuran | armax, just assume a pure macvtap deployment | 15:02 |
scheuran | armax, on compute nodes | 15:02 |
armax | ok | 15:02 |
scheuran | armax, to get around this issue, that admin needs to configure the same interface mapping on each host | 15:03 |
armax | scheuran: that’s even beter | 15:03 |
armax | better | 15:03 |
*** shwetaap has joined #openstack-neutron | 15:03 | |
scheuran | armax, if the target runs lb or ovs - migration will fail anyhow | 15:03 |
armax | then this is greenfield as I hinted above | 15:03 |
scheuran | armax, ok, so I will ask rossella_s to merge this last patch, and I'll take care about advanced doc and the fix, ok? | 15:04 |
*** akamyshnikova has quit IRC | 15:04 | |
armax | scheuran: seems like a sound plan | 15:04 |
scheuran | armax, ok, thank you! | 15:04 |
*** rickyrem has joined #openstack-neutron | 15:05 | |
rossella_s | thanks armax! | 15:05 |
*** banix has joined #openstack-neutron | 15:05 | |
scheuran | rossella_s, is this approach ok for you? | 15:06 |
armax | rossella_s: np, can I remind you to check in on https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/vlan-aware-vms | 15:06 |
armax | rossella_s: even though it’s unlikely to see this merge/complete in time for Mitaka | 15:06 |
armax | rossella_s: it’d be nice to get that in shape for N | 15:07 |
rossella_s | armax, yes I got that feeling too...I am trying to keep up but you can remind me any time | 15:07 |
armax | rossella_s: I saw you dropped some reviews..but maybe you can try and nudge the authors to respond ;) | 15:08 |
rossella_s | armax, good suggestion ;) | 15:08 |
armax | I meant dropped on by some reviews | 15:08 |
*** anilvenkata has quit IRC | 15:08 | |
rossella_s | armax, btw thanks for getting the spec into shape, things got so much better when you chimed in ;) | 15:08 |
armax | rossella_s: let’s see if we find out any nonsense during the implemenation process ;) | 15:09 |
rossella_s | armax, that's our job, creating and fixing nonsenses | 15:10 |
armax | rossella_s: um, not sure that sounds right, but ok | 15:10 |
armax | :) | 15:10 |
openstackgerrit | Artur Korzeniewski proposed openstack/neutron: Add custom SQLAlchemy type for CIDR. https://review.openstack.org/285349 | 15:10 |
*** hdaniel has quit IRC | 15:10 | |
armax | in my head this reads like: “keep ourselves busy for no good reason' | 15:10 |
rossella_s | armax, :D | 15:10 |
scheuran | rossella_s, when I update the release notes in the gerrit, will this cause a new patchset to be created? | 15:12 |
rossella_s | scheuran, I think so | 15:12 |
rossella_s | scheuran, anyway we are now kind of blocked till https://review.openstack.org/#/c/284911/ merges | 15:13 |
scheuran | rossella_s, makes sense | 15:14 |
*** irenab has joined #openstack-neutron | 15:14 | |
*** korzen has quit IRC | 15:15 | |
*** h10_a has joined #openstack-neutron | 15:18 | |
Sam-I-Am | kevinbenton: working on a relnote for the mtu plugging patch | 15:19 |
*** ajmiller has joined #openstack-neutron | 15:20 | |
openstackgerrit | Rossella Sblendido proposed openstack/neutron: Improve logging for port binding https://review.openstack.org/276301 | 15:21 |
*** manuel112 has quit IRC | 15:21 | |
openstackgerrit | Merged openstack/neutron-vpnaas: Updated from global requirements https://review.openstack.org/285043 | 15:22 |
kevinbenton | Sam-I-Am: ack, just post a new patch for it on top of mine | 15:22 |
*** rkukura has joined #openstack-neutron | 15:23 | |
*** baoli has quit IRC | 15:24 | |
*** achanda has joined #openstack-neutron | 15:24 | |
openstackgerrit | David Shaughnessy proposed openstack/neutron: Added agent specific API support to L2 extensions https://review.openstack.org/267591 | 15:25 |
davidsha | ihrachy: ping, new PS is up. | 15:25 |
kevinbenton | rossella_s: one of the downsides to logging in bind_port is that an agent not binding a port may be completely normal if you have another driver loaded | 15:27 |
kevinbenton | rossella_s: left a comment on your patch | 15:27 |
*** vikram has joined #openstack-neutron | 15:27 | |
rossella_s | kevinbenton, thanks Kevin | 15:27 |
*** emagana has joined #openstack-neutron | 15:28 | |
*** amuller has joined #openstack-neutron | 15:28 | |
*** singhj has joined #openstack-neutron | 15:31 | |
Sam-I-Am | kevinbenton: thats what i'm doing | 15:33 |
*** mubirru has joined #openstack-neutron | 15:33 | |
*** apuimedo has joined #openstack-neutron | 15:35 | |
mhickey | ihrachys, ZZelle: Hi | 15:35 |
openstackgerrit | abregman proposed openstack/neutron: DO NOT MERGE - Verfying doc gate functionalility https://review.openstack.org/284849 | 15:36 |
ZZelle | mhickey, ave | 15:36 |
cappetta | is there any way to get an instance to show the floatingip via ifconfig or ip a? | 15:36 |
mhickey | ihrachys, ZZelle: Looking at your comments in https://review.openstack.org/#/c/277558/9/neutron/db/sqlalchemytypes.py | 15:37 |
*** wwriverrat has left #openstack-neutron | 15:37 | |
mhickey | Not sure what to do here. | 15:38 |
ZZelle | mhickey, ihrachys, iiuc, we allow to push invalid information in the db because we do str(value) which allows None, list, dict, integer value | 15:39 |
*** baoli has joined #openstack-neutron | 15:39 | |
mhickey | ZZelle: so you are saying with need some checks in this method? | 15:40 |
ZZelle | imo, it's really strange not to check what we push in the db as db cannot do the check for us | 15:40 |
h10_a | Hi, wondering if anyone has used TAAS before. I have been trying several different ways to get the service to work for me, but I haven’t yet. There seems to be an unanswered question that might help me. https://ask.openstack.org/en/question/84356/taas-any-guide-or-steps-to-implement-tap-as-as-service/ Anyone with experiece here? | 15:40 |
ZZelle | mhickey, ^ | 15:40 |
mhickey | ZZelle: ok, makes sense. so any data can be persisted in db. | 15:41 |
*** baoli_ has joined #openstack-neutron | 15:41 | |
*** kriskend has joined #openstack-neutron | 15:41 | |
mhickey | ZZelle: let me put in some checks for next PS. sound ok? | 15:41 |
*** mubirru has quit IRC | 15:42 | |
*** abregman|nb is now known as abregman|afk | 15:42 | |
*** tbachman has joined #openstack-neutron | 15:43 | |
*** baoli has quit IRC | 15:44 | |
ZZelle | mhickey, fine for me | 15:45 |
davidsha | ajo: ping | 15:46 |
ajo | davidsha, pong, I've seen your patchset, but trying to finish the RPC one | 15:46 |
ajo | I'll look at it ASAP | 15:46 |
ajo | (sorry for the delay ;) :) | 15:47 |
davidsha | ajo: thanks, sorry to bother you! I'll put a response to your last comment then, was going to say it here. | 15:47 |
mhickey | ZZelle: ok, thanks. :) | 15:48 |
ajo | davidsha, say it, sorry :D | 15:48 |
openstackgerrit | Andreas Scheuring proposed openstack/neutron: macvtap: Macvtap L2 Agent https://review.openstack.org/275306 | 15:48 |
davidsha | ajo: Just on deprecating a way to change the default_cookie. The Idea is that you shouldn't because this is the bridge used by the neutron agent. | 15:48 |
ajo | davidsha, but I undestood from yamamoto's comments that others can be using it | 15:49 |
ajo | not the bridge itself | 15:49 |
ajo | but the class | 15:49 |
ajo | ? | 15:49 |
ajo | or did I get it wrong | 15:49 |
davidsha | ajo: they can but if they do they couldn't use flows anyways because of flows being deleted. | 15:50 |
*** achanda has quit IRC | 15:51 | |
*** josecastroleon has quit IRC | 15:51 | |
davidsha | ajo: So they would need to request a cookie from the api which would also provide them with the bridge to use to create them. | 15:51 |
ajo | davidsha | 15:51 |
ajo | but he's talking about separate bridges | 15:51 |
ajo | not br-int, br-tun ... | 15:51 |
ajo | they could create 'my-bridge', and do something within | 15:52 |
ajo | with their own cookie | 15:52 |
ajo | and be accessing the default_cookie field for that matter | 15:52 |
ajo | or am I saying a nonsense? | 15:52 |
ajo | am I a nonsense? :) | 15:52 |
ajo | %) | 15:52 |
davidsha | ajo: ya, but those wouldn't have the flow deletion problem because they have entirely different flow tables. | 15:53 |
ajo | davidsha, hmm, yeah, but they could be using that same mechanism to cleanup, couldn't they? | 15:54 |
ajo | :) | 15:54 |
ajo | or is the cleanup mechanism outside the bridge class? (I can't remember now) | 15:54 |
* ajo 's head is down in a test | 15:54 | |
*** zhhuabj_ has joined #openstack-neutron | 15:54 | |
openstackgerrit | Matthew Kassawara proposed openstack/neutron: Make agent interface plugging utilize network MTU https://review.openstack.org/283790 | 15:55 |
davidsha | ajo: The clean up method is inside the OVSAgentBridge class, they would need to call it themselves | 15:55 |
ajo | ah | 15:55 |
ajo | ok | 15:55 |
ajo | davidsha, can you comment with what we just said | 15:55 |
*** busterswt has joined #openstack-neutron | 15:55 | |
ajo | "as per IRC conversation... blah blah" :D | 15:56 |
ajo | it's good to document this stuff in case somebody comes again asking you for the same nonsense because of me :D | 15:56 |
davidsha | ajo: I'll quote that exactly ;) | 15:56 |
ajo | lol | 15:56 |
davidsha | ajo: sorry for taking your time and good luck with that, is there anything I can do to help? | 15:56 |
ajo | davidsha, no, but thanks, it's almost done | 15:57 |
*** zhhuabj_ has quit IRC | 15:57 | |
davidsha | ajo: cool :) | 15:57 |
*** zhhuabj_ has joined #openstack-neutron | 15:57 | |
*** hdaniel has joined #openstack-neutron | 15:57 | |
openstackgerrit | Numan Siddique proposed openstack/neutron: Handle PortNotFound exception while creating an ipv6 auto addr subnet https://review.openstack.org/285388 | 15:58 |
*** salv-orl_ has joined #openstack-neutron | 15:59 | |
*** localloo1 has joined #openstack-neutron | 15:59 | |
*** localloop127 has quit IRC | 15:59 | |
*** yamahata has joined #openstack-neutron | 16:00 | |
*** salv-orlando has quit IRC | 16:01 | |
*** eddima has quit IRC | 16:05 | |
*** haplo37 has joined #openstack-neutron | 16:06 | |
*** rpothier has joined #openstack-neutron | 16:07 | |
*** baoli_ has quit IRC | 16:08 | |
openstackgerrit | Martin Hickey proposed openstack/neutron: Port Extra Dhcp Opt to OVO https://review.openstack.org/273072 | 16:08 |
openstackgerrit | Martin Hickey proposed openstack/neutron: Integrate the Extra Dhcp Opt VersionedObject in Neutron https://review.openstack.org/285397 | 16:08 |
*** jreeves has joined #openstack-neutron | 16:11 | |
*** annemccormick has quit IRC | 16:11 | |
*** vikram has quit IRC | 16:11 | |
*** anilvenkata has joined #openstack-neutron | 16:12 | |
mhickey | rossella_s: Hi. First stacking of ovo parch ^^^^^ | 16:12 |
rossella_s | mhickey, great | 16:13 |
mhickey | rossella_s: I will get to the other patch (address pairs_ asap | 16:13 |
*** hdaniel has quit IRC | 16:13 | |
ihrachys | armax: can we get https://review.openstack.org/#/c/263819/ in? | 16:13 |
*** kriskend has quit IRC | 16:13 | |
electrocucaracha | mhickey, congrats | 16:13 |
*** logan- has quit IRC | 16:14 | |
armax | ihrachys: how much are you prepared to pay? | 16:14 |
ajo | lol :) | 16:14 |
rossella_s | mhickey, cool, thanks a lot | 16:14 |
*** logan- has joined #openstack-neutron | 16:14 | |
ihrachys | armax: I will pay with my loyalty ;) | 16:14 |
armax | ihrachys: that’s not gonna get you far | 16:14 |
armax | ihrachys: but I appreciate the sentiment | 16:14 |
ihrachys | damn | 16:14 |
armax | :) | 16:14 |
armax | you know what, I am gonna let you catch a break this time | 16:15 |
*** amuller has quit IRC | 16:16 | |
ihrachys | armax: I knew you will accept my time limited offer. it does not happen every day! | 16:17 |
openstackgerrit | Merged openstack/neutron-specs: Agent specific API for L2 agent extensions https://review.openstack.org/263819 | 16:17 |
armax | ihrachys: yeah, I had second thoughts…loyalty is most definitely better than any economic rewad | 16:18 |
armax | reward | 16:18 |
*** abregman|afk has quit IRC | 16:18 | |
ihrachys | armax: right. economy gives you money; politics gives you money and power | 16:18 |
*** kobis has quit IRC | 16:18 | |
ajo | rofl, but true.. ;) | 16:19 |
armax | ihrachys: you sound like you’re a mobster | 16:19 |
* armax buckles up for landing | 16:19 | |
ihrachys | armax: now you indeed appreciate the offer :P | 16:19 |
russellb | armax: in flight too, huh? | 16:19 |
armax | russellb: yup | 16:19 |
ajo | have safe flights guys ;) | 16:19 |
russellb | the future is neat | 16:19 |
ihrachys | haha | 16:20 |
*** skamithi has quit IRC | 16:21 | |
*** kobis has joined #openstack-neutron | 16:22 | |
ajo | ohh ihrachys the server_rpc in callback works like a charm :) | 16:22 |
*** skamithi has joined #openstack-neutron | 16:22 | |
*** dims has quit IRC | 16:22 | |
ihrachys | ajo: great. | 16:22 |
ajo | now, addressing the other things, that alone take me 1h yikes... moving a couple of methods | 16:22 |
*** armax has quit IRC | 16:22 | |
ihrachys | ajo: how is dscp qos piece? have you looked at it lately? is it good to go? | 16:22 |
ajo | take me -> took me | 16:22 |
ajo | ihrachys, it probably should review it over tonight or the weekend I can't remember | 16:23 |
* ajo looks | 16:23 | |
ihrachys | ajo: I haven't looked since eternity | 16:23 |
* ihrachys is afraid it's not good | 16:23 | |
ihrachys | but I better do the review. prolly tomorrow. | 16:23 |
*** armax has joined #openstack-neutron | 16:25 | |
ajo | ihrachys, : the spec is still there : hmm https://review.openstack.org/#/c/190285/ | 16:25 |
*** scheuran has quit IRC | 16:25 | |
ihrachys | ajo: oh | 16:27 |
ihrachys | I +2 though we probably did not need the spec | 16:27 |
ajo | hmm | 16:27 |
*** hynekm has joined #openstack-neutron | 16:27 | |
ihrachys | we'll need some driver member like armax to get it in | 16:27 |
ajo | it seems that we agreed not to need a spec | 16:27 |
ajo | or even RFE | 16:27 |
ajo | as per bug conversation.. but the spec was left there | 16:28 |
ajo | I forgot about it | 16:28 |
*** localloo1 has quit IRC | 16:28 | |
dasm | o/ | 16:28 |
armax | ihrachys: how far is the code in the pipeline | 16:29 |
kevinbenton | ihrachys: ping | 16:29 |
ihrachys | armax: dscp? | 16:29 |
ihrachys | kevinbenton: pong | 16:29 |
armax | ihrachys: you woudln’t want to push your luck too far today, would you not? | 16:29 |
*** skamithi has quit IRC | 16:29 | |
armax | ihrachys: :) | 16:29 |
armax | ihrachys: ya that one | 16:29 |
kevinbenton | ihrachys: i think there is something i don't understand about oslo config deprecation warnings | 16:29 |
kevinbenton | ihrachys: your comment implies that we throw warnings at users even if they aren't using those options if the code references them | 16:30 |
ajo | armax, we're checking, they were blocked on the L2 API and the RPC ovo push/pull upgrade support, long ago it was looking good, but we need to recheck | 16:30 |
*** localloo1 has joined #openstack-neutron | 16:30 | |
ihrachys | armax: all blockers are set to merge really quick. now, for the actual dscp patch, I can't tell because honestly I was busy with all its blockers till now. will need to check to say. but the patch is up for review for a while. | 16:30 |
*** rcernin has quit IRC | 16:31 | |
ihrachys | kevinbenton: the option access is probably the one that triggers a warning. but let me check the code to be sure. | 16:31 |
armax | ihrachys: we can merge it but if the code is in bad shape it’ll be pulled out in https://review.openstack.org/#/c/283383/ | 16:31 |
kevinbenton | ihrachys: that's terrible if that's the case :/ | 16:31 |
kevinbenton | ihrachys: it means there is no way to deprecate an option without spamming operators that don't even use it | 16:31 |
*** wwriverrat has joined #openstack-neutron | 16:32 | |
ihrachys | kevinbenton: that's how I read the code: https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L817 | 16:32 |
*** skamithi has joined #openstack-neutron | 16:33 | |
ihrachys | armax: I think it's fair | 16:33 |
ihrachys | kevinbenton: seems like it logs once | 16:33 |
*** thorst is now known as thorst_afk | 16:33 | |
kevinbenton | ihrachys: ouch, that's unfortunate | 16:34 |
ihrachys | kevinbenton: but I would need to write a test to check | 16:34 |
kevinbenton | ihrachys: ok. i'll flip all of the code around in my patch | 16:34 |
*** armax has quit IRC | 16:34 | |
ihrachys | kevinbenton: right. note that it changes the behavior for those who rely on network_device_mtu, so probably worth a reno | 16:34 |
ihrachys | it's worth it anyhow.. | 16:34 |
kevinbenton | ihrachys: well it will change it if you make me change the order :) | 16:35 |
kevinbenton | ihrachys: maybe the deprecated warning is a little safer than changing behavior to effectively disable network_device_mtu ? | 16:35 |
ihrachys | kevinbenton: right :) I believe it's the right thing to impose the correct behaviour by default, irrelevant to deprecation warnings question :) | 16:35 |
kevinbenton | ihrachys: i think as long as we have the network_device_mtu we should honor it though | 16:36 |
ihrachys | kevinbenton: how about avoiding deprecation right now and give ourselves a tiny bit more time to check whether it's safe? | 16:37 |
kevinbenton | ihrachys: safe to set the 'deprecated_for_removal' flag? | 16:37 |
ihrachys | I would like to play with oslo.config a bit, but probably will need to wait till Mon for that | 16:37 |
ihrachys | kevinbenton: yes. to validate whether it actually spams as I expect. | 16:38 |
ihrachys | kevinbenton: so I would say, let's hold the deprecation patch till Mon and I will provide info on actual behaviour then | 16:38 |
ihrachys | and then we decide where to go | 16:38 |
kevinbenton | ihrachys: i can just test it locally | 16:38 |
ihrachys | other patches should be unblocked | 16:38 |
ihrachys | kevinbenton: ok then do :) | 16:38 |
*** iyamahat has joined #openstack-neutron | 16:38 | |
ihrachys | I need to run, keep me posted | 16:38 |
kevinbenton | ihrachys: when i make these other changes | 16:39 |
*** ihrachys has quit IRC | 16:39 | |
ajo | ping davidsha | 16:39 |
sc68cal | Sam-I-Am: I found another mtu option! AGENT.veth_mtu | 16:39 |
sc68cal | in ovs agent | 16:39 |
sc68cal | yaaay! | 16:39 |
*** amuller has joined #openstack-neutron | 16:40 | |
Sam-I-Am | sc68cal: lols | 16:40 |
amuller | kevinbenton: I have a question regarding CONF.router_auto_schedule | 16:40 |
sc68cal | just why | 16:40 |
Sam-I-Am | who here was working on the OSC for neutron? | 16:40 |
Sam-I-Am | HenryG: was it you? | 16:41 |
dougwig | it is silent as a tomb in the mid-cycle room today. | 16:41 |
HenryG | Sam-I-Am: no it's rtheis | 16:41 |
Sam-I-Am | dougwig: shhhhh, your typing is disturbing me | 16:41 |
*** wwriverrat has left #openstack-neutron | 16:41 | |
Sam-I-Am | rtheis: pssst | 16:41 |
dougwig | Sam-I-Am: go back into your MTU closet. | 16:41 |
Sam-I-Am | dougwig: but its too small | 16:41 |
*** wwriverrat has joined #openstack-neutron | 16:42 | |
amuller | Sam-I-Am: Too many jokes, I don't know where to begin | 16:42 |
kevinbenton | amuller: shoot | 16:42 |
sc68cal | doude: I keep banging my head on the low doorframe | 16:42 |
sc68cal | err dougwig | 16:42 |
russellb | lol | 16:42 |
amuller | kevinbenton: What... Is it for? | 16:42 |
amuller | kevinbenton: What problem does it solve? | 16:43 |
dougwig | Sam-I-Am: cut yourself in half. | 16:43 |
amuller | kevinbenton: (I'm asking if we can get rid of it) | 16:43 |
dougwig | Sam-I-Am: it's what the standard says you must do. | 16:43 |
*** lajos-katona has left #openstack-neutron | 16:43 | |
* sc68cal imagines the magic trick where the magicial saws his assistant in half | 16:43 | |
sc68cal | god I can't type. magician | 16:44 |
wwriverrat | blogan: Am I the only one in the openstack-osic channel? Or… more likely mistyped/forgot/blew-it as the the real neame | 16:44 |
kevinbenton | amuller: when someone wants to micromanage how things are scheduled because of limited physnet connectivity | 16:44 |
kevinbenton | amuller: same thing for 'network_auto_schedule' | 16:45 |
*** mgoddard__ has joined #openstack-neutron | 16:45 | |
kevinbenton | amuller: whatever their fate, they should probably share it | 16:45 |
dougwig | kevinbenton: it's all just a scheduling problem. | 16:46 |
amuller | kevinbenton: I'm not asking why turn it off, I'm saying why turn it on | 16:46 |
amuller | kevinbenton: routers are scheduled automatically regardless | 16:46 |
amuller | kevinbenton: having it set to True just adds an additional code flow / complexity and I have no ideas why we need it enabled | 16:47 |
amuller | idea* | 16:47 |
kevinbenton | amuller: oh, it would seem that we regressed then and broke this feature anyway :) | 16:47 |
*** dslevin has left #openstack-neutron | 16:48 | |
*** numans has quit IRC | 16:48 | |
*** kobis has quit IRC | 16:48 | |
*** fedexo has joined #openstack-neutron | 16:49 | |
*** mgoddard_ has quit IRC | 16:49 | |
*** manuel112 has joined #openstack-neutron | 16:49 | |
amuller | kevinbenton: when you add an interface to a legacy router the server automatically schedules the router without checking value of router_auto_schedule | 16:49 |
*** yamamoto has quit IRC | 16:50 | |
*** kobis has joined #openstack-neutron | 16:50 | |
kevinbenton | amuller: auto schedule routers prevents unscheduled routers from being rescheduled | 16:50 |
kevinbenton | amuller: so if you remove a router from an l3 agent | 16:50 |
kevinbenton | amuller: it will stay unscheduled until explicitly rescheduled i think with this option | 16:50 |
*** yamamoto has joined #openstack-neutron | 16:50 | |
openstackgerrit | Martin Hickey proposed openstack/neutron: Update Neutron with temporary registry pattern from VersionedObjectRegistry https://review.openstack.org/270309 | 16:50 |
amuller | kevinbenton: but HA routers are scheduled when they're created for example | 16:51 |
kevinbenton | amuller: and what happens when you use the API to remove them from the agent? | 16:51 |
amuller | kevinbenton: so you'd have to create the router, explicitly remove it from all L3 agents | 16:51 |
kevinbenton | amuller: does another agent steal it on some periodic sync? | 16:51 |
*** rickyrem has quit IRC | 16:51 | |
amuller | kevinbenton: offhand no, with router_auto_schedule off it would not be rescheduled on its own | 16:51 |
*** Marga_ has quit IRC | 16:51 | |
amuller | kevinbenton: that's not exactly a sane user experience though | 16:52 |
amuller | kevinbenton: and I'd have to check but for DVR routers the SNAT portion is probably scheduled right away as well | 16:52 |
*** Marga_ has joined #openstack-neutron | 16:52 | |
kevinbenton | amuller: possibly, but this option is about interferring with admins managing where routers are scheduled | 16:52 |
kevinbenton | amuller: after the fact | 16:53 |
kevinbenton | amuller: so if we got rid of this, we need to make sure there is still an easy way for admins to move routers | 16:53 |
kevinbenton | amuller: without fighting the auto scheduling | 16:53 |
amuller | kevinbenton: agreed | 16:53 |
amuller | kevinbenton: note that the L3 agent doesn't sync with the server periodically, unless there was an error | 16:54 |
*** hdaniel has joined #openstack-neutron | 16:54 | |
amuller | kevinbenton: in fact... | 16:55 |
kevinbenton | amuller: ah, since the self.fullsync optimization was snuck in... | 16:55 |
amuller | kevinbenton: fullsync is set to True only if the agent enters the REVIVED state | 16:55 |
*** tmorin has quit IRC | 16:55 | |
kevinbenton | amuller: that's a stupid periodic task now :) | 16:55 |
hdaniel | ajo: do you mind peeking at : https://review.openstack.org/#/c/250081/ ? | 16:55 |
kevinbenton | amuller: we should just have the thing that transitions it to the REVIVED state trigger that sync | 16:55 |
kevinbenton | amuller: one other use case that this may interfere with is if operators use this to disable a tenants router | 16:56 |
Sam-I-Am | dougwig: MTU | 16:56 |
kevinbenton | amuller: tenant doesn't pay bandwidth bill, unschedule their router :) | 16:56 |
openstackgerrit | Merged openstack/neutron: Switch to using in-tree tempest lib https://review.openstack.org/284911 | 16:57 |
*** Marga_ has quit IRC | 16:57 | |
ajo | hdaniel: checked the diff from my last check, looks good | 16:57 |
hdaniel | ajo: hooray :) | 16:57 |
*** Marga_ has joined #openstack-neutron | 16:57 | |
ajo | kevinbenton, hdaniel's patch is ready for eyeballing of you had any timeslot I believe he addressed your comments | 16:58 |
amuller | kevinbenton: removing auto_schedule_router wouldn't mess that use case up I think? | 16:58 |
*** rickyrem has joined #openstack-neutron | 16:59 | |
*** manjeets has joined #openstack-neutron | 17:00 | |
*** claudiub|2 has joined #openstack-neutron | 17:00 | |
*** mriedem has joined #openstack-neutron | 17:00 | |
mriedem | dougwig: kevinbenton: was this the api job failure? http://logs.openstack.org/35/207635/54/gate/gate-neutron-dsvm-api/424b676/logs/screen-q-svc.txt.gz?level=TRACE#_2016-02-25_03_10_38_577 | 17:01 |
kevinbenton | amuller: unless an l3 agent does a full sync | 17:01 |
kevinbenton | mriedem: no, they were policy violations | 17:01 |
*** Marga_ has quit IRC | 17:02 | |
mriedem | kevinbenton: ok, was just looking at the one job failure that showed up here: http://status.openstack.org/elastic-recheck/data/uncategorized.html | 17:02 |
mriedem | kevinbenton: is there an example of the policy failure? maybe it's check queue | 17:02 |
kevinbenton | mriedem: yeah, one sec | 17:02 |
*** claudiub has quit IRC | 17:02 | |
amuller | kevinbenton: if the L3 agent does a full sync, with auto_schedule_routers set to False or the code removed, it would not schedule unscheduled routers | 17:03 |
amuller | kevinbenton: so it would not mess that use case up | 17:03 |
mriedem | ^ still fails a hell of a lot http://goo.gl/Yf5UY2 | 17:03 |
kevinbenton | mriedem: http://logs.openstack.org/81/285181/1/check/gate-neutron-dsvm-api/55f9bb2/console.html#_2016-02-26_11_57_08_172 | 17:03 |
amuller | mriedem: the fix merged a few minutes ago | 17:03 |
ajo | hdaniel, : https://review.openstack.org/#/c/250081/ not so fast, merge conflict ;) | 17:03 |
openstackgerrit | Haim Daniel proposed openstack/neutron: Qos policy RBAC DB setup and migration https://review.openstack.org/250081 | 17:04 |
ajo | I guess something-db merged | 17:04 |
kevinbenton | amuller: oh, so you are advocating that we remove and never automatically schedule a router that isn't scheduled | 17:04 |
ajo | hmm or was something else | 17:04 |
amuller | kevinbenton: correct | 17:04 |
*** vthapar has quit IRC | 17:04 | |
amuller | kevinbenton: yeah sorry if I was unclear, I meant to remove the option and all of its code, essentially defaulting to setting it to False | 17:04 |
kevinbenton | amuller: ack. that makes sense. the only thing I would want to make sure is safe is the auto scheduling code | 17:05 |
kevinbenton | amuller: because it unschedules and the scheduled | 17:05 |
kevinbenton | schedules * | 17:05 |
*** hynekm has quit IRC | 17:05 | |
kevinbenton | IIRC | 17:05 |
kevinbenton | so if the server explodes after one of those it could leave an orphaned router | 17:06 |
*** feleouet has quit IRC | 17:06 | |
kevinbenton | amuller: but that should probably be fixed orthoganally anyway if that's still the case | 17:06 |
amuller | kevinbenton: Like if a router was created, commited, and before the server was able to schedule it, it crashes? | 17:07 |
kevinbenton | ajo: will check it out | 17:07 |
amuller | kevinbenton: and then it's just never scheduled | 17:07 |
kevinbenton | amuller: oh, that too | 17:07 |
ajo | thanks kevin | 17:07 |
amuller | kevinbenton: what did you mean then? | 17:07 |
mriedem | dougwig: kevinbenton: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22rule%3Acreate_port%20and%20rule%3Acreate_port%3Aport_security_enabled%5C%22%20AND%20message%3A%5C%22PolicyNotAuthorized%5C%22%20AND%20tags%3A%5C%22console%5C%22&from=7d | 17:07 |
amuller | kevinbenton: (the thing I just said doesn't work now too though) | 17:07 |
mriedem | dougwig: kevinbenton: 1 hit in the gate queue | 17:07 |
kevinbenton | amuller: i meant the auto rescheduling code that will take routers from dead agents and move them | 17:07 |
mriedem | 31 in check | 17:07 |
amuller | kevinbenton: ohhh | 17:07 |
amuller | kevinbenton: ah ha | 17:07 |
amuller | automatic_rescheduling | 17:07 |
mriedem | so that's probably why isn't wasn't flaming up the uncategorized bugs page (which only shows gate queue failures) | 17:08 |
amuller | kevinbenton: yeah it should continue to work | 17:08 |
amuller | kevinbenton: it has tests | 17:08 |
*** jpena has quit IRC | 17:08 | |
openstackgerrit | Sean M. Collins proposed openstack/neutron: Consolidate the OVS DF and CSUM options into constants https://review.openstack.org/285440 | 17:08 |
kevinbenton | amuller: yeah, my memory is coming back to me now that this is something that i fixed :) | 17:08 |
kevinbenton | amuller: but you bring up a good point about the created routers | 17:09 |
kevinbenton | amuller: we can fix that with maybe a 'pending_schedule' flag | 17:09 |
*** jlanoux has quit IRC | 17:09 | |
*** dims has joined #openstack-neutron | 17:09 | |
amuller | kevinbenton: some of the L3 HA patches could be abandoned if router_auto_schedule didn't exist | 17:09 |
openstackgerrit | Doug Wiegley proposed openstack/neutron: Bump to neutron-lib 0.0.2 https://review.openstack.org/285441 | 17:09 |
kevinbenton | amuller: that's set to true immediately on the create of the record | 17:09 |
amuller | kevinbenton: yeah | 17:09 |
*** achanda has joined #openstack-neutron | 17:10 | |
*** dims has quit IRC | 17:10 | |
kevinbenton | amuller: but handling a partially formed router is probably something that needs to be more generically fixed anyway | 17:10 |
*** Leom has joined #openstack-neutron | 17:10 | |
kevinbenton | amuller: imagine if you pull the plug on a server now right after router db object is created but before L3 HA interfaces | 17:10 |
amuller | kevinbenton: yep | 17:10 |
kevinbenton | amuller: ok. if you propose a patch to remove all of that, i'm solf | 17:10 |
kevinbenton | sold* | 17:10 |
amuller | kevinbenton: there's probably a lot of places we don't handle multi-commits | 17:11 |
kevinbenton | amuller: yeah, so i think we probably need some more general transaction log thingy | 17:11 |
amuller | kevinbenton: or "partial" resources | 17:11 |
amuller | kevinbenton: yeah | 17:11 |
kevinbenton | amuller: that shows when something started | 17:11 |
*** michchap_ has joined #openstack-neutron | 17:11 | |
kevinbenton | amuller: and that it never finished | 17:11 |
amuller | kevinbenton: that's what we had on some other project I worked on | 17:11 |
amuller | kevinbenton: exactly | 17:11 |
amuller | kevinbenton: that should probably be in oslo.db | 17:12 |
amuller | kevinbenton: nothing neutron specific here | 17:12 |
Sam-I-Am | kevinbenton: do my relnotes make sense? | 17:12 |
*** jklare_ has joined #openstack-neutron | 17:12 | |
*** melwitt_ has joined #openstack-neutron | 17:12 | |
*** pai15- has joined #openstack-neutron | 17:12 | |
kevinbenton | amuller: i think if we massively refactored all of neutron to use taskflow it can handle these multi-task tasks | 17:12 |
*** xek__ has joined #openstack-neutron | 17:13 | |
*** wolverineav has joined #openstack-neutron | 17:13 | |
*** Kennan2 has joined #openstack-neutron | 17:13 | |
*** baoli has joined #openstack-neutron | 17:13 | |
kevinbenton | amuller: :) | 17:13 |
*** rawlin_ has joined #openstack-neutron | 17:14 | |
kevinbenton | Sam-I-Am: haven't had a chance to look yet | 17:14 |
*** yamahata__ has joined #openstack-neutron | 17:14 | |
*** manuel112 has quit IRC | 17:14 | |
*** tbachman_ has joined #openstack-neutron | 17:15 | |
*** j_king_ has joined #openstack-neutron | 17:15 | |
*** Trident has joined #openstack-neutron | 17:15 | |
*** gbraad_ has joined #openstack-neutron | 17:15 | |
*** pl0pix has joined #openstack-neutron | 17:15 | |
*** diegows_ has joined #openstack-neutron | 17:16 | |
amuller | kevinbenton: that'll happen right after the nova scheduler is split out to a separate project, the Neutron stadium replaces the OpenStack big tent and OpenStack releases wrap back from Z | 17:16 |
*** tonyb_ has joined #openstack-neutron | 17:16 | |
*** kfox1111_ has joined #openstack-neutron | 17:16 | |
*** sshen_ has joined #openstack-neutron | 17:16 | |
*** Nakato_ has joined #openstack-neutron | 17:17 | |
*** coreycb` has joined #openstack-neutron | 17:18 | |
*** dkehn_ is now known as dkehn | 17:18 | |
*** matrohon has quit IRC | 17:19 | |
*** kawa2014 has quit IRC | 17:19 | |
*** fedexo has quit IRC | 17:19 | |
*** X123_ has joined #openstack-neutron | 17:19 | |
slaweq | ajo: hello | 17:19 |
openstackgerrit | Hirofumi Ichihara proposed openstack/neutron: Make API framework more flexible for various extensions https://review.openstack.org/284519 | 17:20 |
slaweq | I found today why linuxbridge agent is not consuming notifications about policy update (in QoS) | 17:20 |
*** tbachman has quit IRC | 17:20 | |
*** edmondsw has quit IRC | 17:20 | |
*** pavel_bondar has quit IRC | 17:20 | |
*** Kennan has quit IRC | 17:20 | |
*** xek_ has quit IRC | 17:20 | |
*** ekarlso- has quit IRC | 17:20 | |
*** michchap has quit IRC | 17:20 | |
*** Nakato has quit IRC | 17:20 | |
*** anteaya has quit IRC | 17:20 | |
*** krotscheck has quit IRC | 17:20 | |
*** isq_ has quit IRC | 17:20 | |
*** _fortis has quit IRC | 17:20 | |
*** jklare has quit IRC | 17:20 | |
*** j_king has quit IRC | 17:20 | |
*** lucasagomes has quit IRC | 17:20 | |
*** tonyb has quit IRC | 17:20 | |
*** blogan has quit IRC | 17:20 | |
*** sshen has quit IRC | 17:20 | |
*** gbraad has quit IRC | 17:20 | |
*** mkoderer__ has quit IRC | 17:20 | |
*** morgabra has quit IRC | 17:20 | |
*** plopix has quit IRC | 17:20 | |
*** strictlyb has quit IRC | 17:20 | |
*** manjeets has quit IRC | 17:20 | |
*** otherwiseguy has quit IRC | 17:20 | |
*** rawlin has quit IRC | 17:20 | |
*** coreycb has quit IRC | 17:20 | |
*** afazekas has quit IRC | 17:20 | |
*** nwonknu has quit IRC | 17:20 | |
*** pcarver has quit IRC | 17:20 | |
*** pai15 has quit IRC | 17:20 | |
*** bapalm has quit IRC | 17:20 | |
*** Tridde has quit IRC | 17:20 | |
*** diegows has quit IRC | 17:20 | |
*** 20WAAACXB has quit IRC | 17:20 | |
*** melwitt has quit IRC | 17:20 | |
*** avico has quit IRC | 17:20 | |
*** X123 has quit IRC | 17:20 | |
*** lmiccini has quit IRC | 17:20 | |
*** kfox1111 has quit IRC | 17:20 | |
*** avico- has joined #openstack-neutron | 17:20 | |
*** tbachman_ is now known as tbachman | 17:20 | |
*** krotscheck has joined #openstack-neutron | 17:20 | |
*** X123_ is now known as X123 | 17:20 | |
slaweq | it is in fact bug in CommonAgentLoop class | 17:20 |
*** absubram has joined #openstack-neutron | 17:20 | |
slaweq | diff is rather small: http://pastebin.com/8L8tzN9A | 17:21 |
*** afazekas has joined #openstack-neutron | 17:21 | |
*** adjohn- has joined #openstack-neutron | 17:21 | |
*** bapalm has joined #openstack-neutron | 17:21 | |
*** strictlyb has joined #openstack-neutron | 17:21 | |
*** blogan has joined #openstack-neutron | 17:21 | |
*** mkoderer___ has joined #openstack-neutron | 17:21 | |
slaweq | question: should I fix it in patch with QoS or report new bug on launchpad and make another patch for that? | 17:21 |
slaweq | probably this second option but I want to be sure :) | 17:21 |
*** absubram_ has joined #openstack-neutron | 17:21 | |
*** minwang2 has joined #openstack-neutron | 17:21 | |
*** pcarver has joined #openstack-neutron | 17:22 | |
*** dims has joined #openstack-neutron | 17:22 | |
*** otherwiseguy has joined #openstack-neutron | 17:22 | |
*** morgabra has joined #openstack-neutron | 17:22 | |
*** lucasagomes_ has joined #openstack-neutron | 17:22 | |
*** lucasagomes_ is now known as lucasagomes | 17:23 | |
*** lmiccini has joined #openstack-neutron | 17:23 | |
openstackgerrit | Sean M. Collins proposed openstack/neutron: [WIP] Deprecate the tunnel_csum option for OVS in favor of autodetection https://review.openstack.org/285448 | 17:23 |
*** _fortis_ has joined #openstack-neutron | 17:23 | |
*** baoli has quit IRC | 17:24 | |
*** nwonknu has joined #openstack-neutron | 17:24 | |
*** baoli has joined #openstack-neutron | 17:24 | |
*** absubram has quit IRC | 17:25 | |
*** absubram_ is now known as absubram | 17:25 | |
*** ekarlso- has joined #openstack-neutron | 17:27 | |
*** edmondsw has joined #openstack-neutron | 17:27 | |
*** anteaya has joined #openstack-neutron | 17:28 | |
*** yamamoto has quit IRC | 17:28 | |
*** yamamoto has joined #openstack-neutron | 17:28 | |
*** yamamoto has quit IRC | 17:28 | |
*** pavel_bondar has joined #openstack-neutron | 17:29 | |
*** cappetta has quit IRC | 17:30 | |
*** wasmum has joined #openstack-neutron | 17:30 | |
*** yamamoto has joined #openstack-neutron | 17:30 | |
*** anshul has joined #openstack-neutron | 17:31 | |
*** prithiv has quit IRC | 17:31 | |
sc68cal | russellb: mestery: can you think of any reason that someone would *not* want tunnel_csum equal to true if their hardware supports it? | 17:32 |
*** baoli has quit IRC | 17:32 | |
*** tfukushima has left #openstack-neutron | 17:32 | |
*** tfukushima has quit IRC | 17:32 | |
sc68cal | tunnel_csum boils down to the "csum" option being set to true when creating the OVS port | 17:32 |
sc68cal | if I understand correctly | 17:32 |
Sam-I-Am | sc68cal: does it depend on underlying interface offload? | 17:32 |
*** lezbar__ has quit IRC | 17:33 | |
sc68cal | I'm not sure. I'm deep down in this thread http://marc.info/?l=linux-netdev&m=143527704810458&w=2 | 17:34 |
*** ranjithd has quit IRC | 17:34 | |
sc68cal | where they talk about software vs hardware support... I think.. | 17:34 |
sc68cal | specifically this message - http://marc.info/?l=linux-netdev&m=143528746114050&w=2 | 17:34 |
sc68cal | and this | 17:35 |
sc68cal | http://marc.info/?l=linux-netdev&m=143529575915353&w=2 | 17:35 |
sc68cal | so I'm at the edge of my knowledge on this and could use expert opinion | 17:35 |
*** _fortis_ is now known as _fortis | 17:35 | |
*** slaweq has quit IRC | 17:35 | |
*** ranjithd has joined #openstack-neutron | 17:36 | |
Sam-I-Am | i think this is one of those cases where the operator needs to understand what the csum option does in combination with their specific kernel and nics | 17:37 |
sc68cal | yeah. Taking a look at this perf result now - http://marc.info/?l=linux-netdev&m=143534714030223&w=2 | 17:39 |
*** shashank_hegde has joined #openstack-neutron | 17:42 | |
*** madhu_ak has joined #openstack-neutron | 17:43 | |
Sam-I-Am | this is also not OVS? | 17:43 |
*** ranjithd has quit IRC | 17:44 | |
openstackgerrit | Sean M. Collins proposed openstack/neutron: [WIP] Deprecate the tunnel_csum option for OVS in favor of autodetection https://review.openstack.org/285448 | 17:44 |
openstackgerrit | Henry Gessau proposed openstack/neutron-vpnaas: Track alembic heads https://review.openstack.org/285460 | 17:45 |
sc68cal | ah - found my mailing list thread where I ranted about this | 17:46 |
sc68cal | now linked in commit message - yaay | 17:46 |
*** Aish has joined #openstack-neutron | 17:47 | |
*** eil397 has joined #openstack-neutron | 17:48 | |
*** Leom has quit IRC | 17:48 | |
*** eil397 has left #openstack-neutron | 17:49 | |
*** jistr has quit IRC | 17:49 | |
*** slaweq has joined #openstack-neutron | 17:50 | |
anteaya | mhickey: http://docs.openstack.org/infra/zuul/gating.html | 17:52 |
openstackgerrit | Hynek Mlnarik proposed openstack/neutron: Use cookies consistently in flows of all bridges https://review.openstack.org/284639 | 17:54 |
*** manjeets_ has joined #openstack-neutron | 17:56 | |
openstackgerrit | Henry Gessau proposed openstack/neutron-fwaas: Track alembic heads https://review.openstack.org/285468 | 17:57 |
*** abregman has joined #openstack-neutron | 17:58 | |
*** slaweq has quit IRC | 18:00 | |
*** mriedem has left #openstack-neutron | 18:01 | |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/python-neutronclient: Add commands for Network IP Availability https://review.openstack.org/269926 | 18:02 |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove effectively empty directories https://review.openstack.org/285472 | 18:03 |
*** manjeets has joined #openstack-neutron | 18:04 | |
*** manjeets_ has quit IRC | 18:04 | |
*** abregman is now known as abregman|afk | 18:06 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: WIP: Remove auto_schedule_routers code and option https://review.openstack.org/285480 | 18:08 |
*** amuller is now known as amuller_afk | 18:08 | |
*** dims is now known as dimsum__ | 18:09 | |
*** banix has quit IRC | 18:10 | |
*** Marga_ has joined #openstack-neutron | 18:10 | |
*** RichardRaseley has joined #openstack-neutron | 18:11 | |
*** ijw has joined #openstack-neutron | 18:11 | |
*** Marga__ has joined #openstack-neutron | 18:11 | |
*** Marga__ has quit IRC | 18:12 | |
*** yamamoto has quit IRC | 18:12 | |
*** rtheis has quit IRC | 18:12 | |
*** yamamoto has joined #openstack-neutron | 18:12 | |
*** yamamoto has quit IRC | 18:12 | |
*** Marga_ has quit IRC | 18:12 | |
*** yamamoto has joined #openstack-neutron | 18:13 | |
*** Marga_ has joined #openstack-neutron | 18:13 | |
*** Marga_ has quit IRC | 18:13 | |
*** ijw has quit IRC | 18:14 | |
*** ijw has joined #openstack-neutron | 18:14 | |
*** Marga_ has joined #openstack-neutron | 18:14 | |
*** sambetts is now known as sambetts|afk | 18:16 | |
*** evgenyf has joined #openstack-neutron | 18:17 | |
*** mgoddard__ has quit IRC | 18:17 | |
*** mgoddard has joined #openstack-neutron | 18:17 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Make network segment table available for standalone plugin https://review.openstack.org/242393 | 18:20 |
*** gangil has joined #openstack-neutron | 18:21 | |
*** gangil has quit IRC | 18:21 | |
*** gangil has joined #openstack-neutron | 18:21 | |
*** thorst_afk is now known as thorst_ | 18:23 | |
davidsha | Hey, is anyone around that could answer a quick question on object versioning? | 18:28 |
*** shashank_hegde has quit IRC | 18:29 | |
mhickey | anteaya: Thanks! :) | 18:30 |
*** jreeves has quit IRC | 18:30 | |
mhickey | davidsha: Hey. Wahts the question? | 18:30 |
*** bjornar__ has joined #openstack-neutron | 18:30 | |
mhickey | *Whats | 18:31 |
davidsha | I'm incrementing a versioned object, I'm just wondering is there a class I need to override to make it decrement if the new version isn't supported | 18:33 |
davidsha | I'm working off this example: https://github.com/openstack/oslo.versionedobjects/blob/e6c275a3fee177afa0ec734e9b52d0e2e637c6dc/oslo_versionedobjects/tests/test_objects.py#L114 | 18:33 |
*** tiswanso has quit IRC | 18:33 | |
*** Aish has quit IRC | 18:33 | |
davidsha | class -> method* | 18:33 |
*** tiswanso has joined #openstack-neutron | 18:34 | |
*** wolverineav has quit IRC | 18:34 | |
davidsha | mhickey: ^ | 18:34 |
*** manuel112 has joined #openstack-neutron | 18:34 | |
*** armax has joined #openstack-neutron | 18:35 | |
kevinbenton | hdaniel: ping | 18:36 |
mhickey | davidsha: not sure. maybe ask rlrossit on oslo channel? | 18:36 |
hdaniel | kevinbenton: pong | 18:36 |
hdaniel | kevinbenton: sup | 18:36 |
davidsha | mhickey: ack, thanks! | 18:36 |
mhickey | davidsha: np | 18:36 |
kevinbenton | hdaniel: oh, nevermind. i had a question about some code in your patch but i see the reason now | 18:36 |
kevinbenton | hdaniel: :) | 18:36 |
hdaniel | kevinbenton: sure thing ;) | 18:37 |
kevinbenton | hdaniel: was wondering why you were using itertools.chain.from_iterable in _get_tenants_with_shared_access_to_db | 18:37 |
hdaniel | kevinbenton: I guess you figured that | 18:37 |
kevinbenton | hdaniel: yeah, each row needs to be iterated over | 18:38 |
kevinbenton | hdaniel: to get the one value | 18:38 |
kevinbenton | hdaniel: it's the equivalent of set(r[0] for r in context.session.query...) right? | 18:38 |
hdaniel | hdaniel: yeah | 18:39 |
kevinbenton | hdaniel: k | 18:39 |
hdaniel | kevinbenton: I guess that ugly itertools.chain thing could be replaced | 18:40 |
kevinbenton | hdaniel: it's fine | 18:40 |
kevinbenton | hdaniel: just wanted to make sure i understood what it was doing | 18:40 |
kevinbenton | hdaniel: not worth another respin for that | 18:40 |
hdaniel | kevinbenton: cool. | 18:40 |
*** abhiraut has joined #openstack-neutron | 18:44 | |
*** mickeys has joined #openstack-neutron | 18:44 | |
*** jlibosva has quit IRC | 18:44 | |
*** Aish has joined #openstack-neutron | 18:45 | |
*** s3wong has joined #openstack-neutron | 18:49 | |
*** absubram has quit IRC | 18:50 | |
*** achanda has quit IRC | 18:51 | |
*** abhiraut has quit IRC | 18:51 | |
*** manuel112 has quit IRC | 18:53 | |
*** abhiraut has joined #openstack-neutron | 18:53 | |
*** manuel112 has joined #openstack-neutron | 18:54 | |
*** achanda has joined #openstack-neutron | 18:55 | |
*** agireud has quit IRC | 18:55 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Deprecate network_device_mtu https://review.openstack.org/283798 | 18:56 |
*** wolverineav has joined #openstack-neutron | 18:56 | |
*** agireud has joined #openstack-neutron | 18:57 | |
*** wolverineav has quit IRC | 18:57 | |
*** wolverineav has joined #openstack-neutron | 18:57 | |
*** rossella_s has quit IRC | 18:58 | |
*** rossella_s has joined #openstack-neutron | 18:58 | |
*** john-davidge has joined #openstack-neutron | 18:58 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Override addOnException to catch exceptions https://review.openstack.org/283340 | 18:59 |
*** vhosakot has joined #openstack-neutron | 19:01 | |
*** john-davidge_ has joined #openstack-neutron | 19:02 | |
*** banix has joined #openstack-neutron | 19:02 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Collect details on ARP spoof functional failures https://review.openstack.org/285181 | 19:03 |
*** john-davidge has quit IRC | 19:04 | |
*** john-davidge_ is now known as john-davidge | 19:04 | |
*** permalac has joined #openstack-neutron | 19:05 | |
*** RichardRaseley has quit IRC | 19:05 | |
*** neiljerram has quit IRC | 19:05 | |
*** manjeets has left #openstack-neutron | 19:06 | |
*** jwarendt has joined #openstack-neutron | 19:06 | |
*** sdague has quit IRC | 19:06 | |
*** john-davidge_ has joined #openstack-neutron | 19:11 | |
russellb | sc68cal: not that i know of | 19:12 |
*** john-davidge has quit IRC | 19:13 | |
*** john-davidge_ is now known as john-davidge | 19:13 | |
*** ZZelle_ has joined #openstack-neutron | 19:13 | |
*** manuel112 has quit IRC | 19:14 | |
*** manuel112 has joined #openstack-neutron | 19:14 | |
*** melwitt_ is now known as melwitt | 19:14 | |
*** wasmum has quit IRC | 19:15 | |
*** baoli has joined #openstack-neutron | 19:15 | |
*** afaranha has left #openstack-neutron | 19:16 | |
*** dimsum__ has quit IRC | 19:16 | |
*** wolverineav has quit IRC | 19:18 | |
*** sridhar_ram has joined #openstack-neutron | 19:19 | |
*** wolverineav has joined #openstack-neutron | 19:19 | |
*** ivar-lazzaro has joined #openstack-neutron | 19:19 | |
*** sbalukoff has quit IRC | 19:22 | |
*** baoli has quit IRC | 19:22 | |
*** baoli has joined #openstack-neutron | 19:23 | |
*** wasmum has joined #openstack-neutron | 19:26 | |
*** anshul has quit IRC | 19:26 | |
*** ritesh has joined #openstack-neutron | 19:28 | |
*** baoli has quit IRC | 19:28 | |
*** baoli has joined #openstack-neutron | 19:28 | |
*** skamithi14 has joined #openstack-neutron | 19:29 | |
*** rickyrem has quit IRC | 19:29 | |
*** hdaniel has quit IRC | 19:31 | |
*** skamithi13 has quit IRC | 19:32 | |
*** manuel112 has quit IRC | 19:33 | |
*** baoli has quit IRC | 19:33 | |
*** manuel112 has joined #openstack-neutron | 19:34 | |
*** abhiraut has quit IRC | 19:35 | |
*** vhosakot has quit IRC | 19:37 | |
*** abhiraut has joined #openstack-neutron | 19:37 | |
*** manuel112 has quit IRC | 19:38 | |
*** porunov has joined #openstack-neutron | 19:38 | |
*** vhosakot has joined #openstack-neutron | 19:39 | |
*** emagana has quit IRC | 19:40 | |
*** rickyrem has joined #openstack-neutron | 19:41 | |
*** emagana has joined #openstack-neutron | 19:42 | |
*** emagana has quit IRC | 19:44 | |
*** emagana has joined #openstack-neutron | 19:44 | |
*** rickyrem has quit IRC | 19:47 | |
porunov | Hello everyone! I am trying install neutron like in documentation but have some troubles with understanding. What is local_ip = OVERLAY_INTERFACE_IP_ADDRESS? We have this parameter in /etc/neutron/plugins/ml2/linuxbridge_agent.ini in [vxlan] section. Which IP adress I need to wrtie insted of OVERLAY_INTERFACE_IP_ADDRESS? Is it ip address of public interface of machine where we configure this parameter? | 19:48 |
*** erhudy has joined #openstack-neutron | 19:48 | |
kevinbenton | porunov: it's the IP of your compute node that it will use to tunnel traffic to the other compute nodes | 19:49 |
kevinbenton | porunov: so use the IP that allows it to communicate with other compute nodes | 19:49 |
porunov | I have only one compute node. It's ip: 192.168.56.131. So I have to write: local_ip = 192.168.56.131 in compute and controller nodes? | 19:51 |
kevinbenton | russellb: hola | 19:53 |
*** hdaniel has joined #openstack-neutron | 19:53 | |
*** absubram has joined #openstack-neutron | 19:53 | |
kevinbenton | porunov: no, local_ip is just the IP address of the node itself | 19:53 |
sc68cal | porunov: which documentation is this? can you provide a link? It probably needs some work to clarify | 19:53 |
kevinbenton | porunov: so on the compute node it will be the compute nodes ip | 19:53 |
kevinbenton | porunov: on the network nodes, it will be their IPs they use to communicate with the compute node | 19:53 |
porunov | sc68cal: http://docs.openstack.org/liberty/install-guide-rdo/neutron-controller-install-option2.html | 19:54 |
porunov | kevinbenton: Thank you) | 19:55 |
*** ranjithd has joined #openstack-neutron | 19:56 | |
kevinbenton | porunov: no prob | 19:57 |
*** hdaniel has quit IRC | 19:57 | |
*** baoli has joined #openstack-neutron | 19:58 | |
*** amuller_afk is now known as amuller | 19:58 | |
*** anilvenkata has quit IRC | 19:58 | |
openstackgerrit | Evgeny Fedoruk proposed openstack/python-neutronclient: L7 capability implementation for lbaas v2 https://review.openstack.org/217276 | 20:00 |
*** gangil has quit IRC | 20:00 | |
davidsha | njohnston: ping | 20:03 |
njohnston | davidsha: pong | 20:03 |
davidsha | njohnston: hey, you've seen ajo's comments have you? | 20:03 |
*** baoli has quit IRC | 20:03 | |
njohnston | davidsha: Yep. Would you like me to take a whack at them? | 20:04 |
davidsha | njohnston: they were put on PS8 but we never put versioning on the QosPolicy class. I think I have it just don't know how to test. | 20:04 |
njohnston | davidsha: Are you specifically speaking of `neutron/objects/qos/rule.py Line 91: you need to bump the policy version, and add a method to handle downgrades, removing any QosDscpMarkRule` | 20:05 |
*** baoli has joined #openstack-neutron | 20:05 | |
*** h10_a has left #openstack-neutron | 20:06 | |
*** kbringard has quit IRC | 20:06 | |
davidsha | njohnston: that's the one, was reading the example code and just made it remove dscp_marking_rule from field['rules'] if the version was '1.0' | 20:07 |
*** kbringard has joined #openstack-neutron | 20:07 | |
*** gangil has joined #openstack-neutron | 20:07 | |
*** gangil has quit IRC | 20:07 | |
*** gangil has joined #openstack-neutron | 20:07 | |
*** pl0pix has quit IRC | 20:07 | |
*** plopix has joined #openstack-neutron | 20:08 | |
njohnston | Right. It seems you can probably test the behavior by having a multinode setup containing a neutron server with a new agent attached, do something DSCP, then downgrade the agent, and try to do DSCP operations. | 20:09 |
*** gangil has quit IRC | 20:09 | |
*** itisha has quit IRC | 20:09 | |
*** safchain has joined #openstack-neutron | 20:10 | |
davidsha | njohnston: was looking more into unit tests at the moment, (I could also kill the q-agt manually change the version to 1.0 and try again) | 20:10 |
njohnston | Unless you mean 'how to functional/unit/fullstack test', which is hard. I think fullstack would be the logical place, but I don't have the requisite skill yet - still learning in the fullstack testing area. But fundamentally you're relying on Ajo's RPC rolling upgrades code and the underlying OVO code to work as expected. | 20:10 |
njohnston | Yeah, this isn't really an arena for unit testing, I think. | 20:11 |
*** johnbelamaric has quit IRC | 20:11 | |
*** baoli has quit IRC | 20:11 | |
*** sdague has joined #openstack-neutron | 20:13 | |
*** yamamoto has quit IRC | 20:13 | |
*** yamamoto has joined #openstack-neutron | 20:13 | |
*** yamamoto has quit IRC | 20:13 | |
davidsha | njohnston: Hmmmm... I'll keep at it, think I have the basis of how to test it... just don't think people are going to like it that much (manually changing VERSION and calling the version check).... | 20:14 |
njohnston | davidsha: Do you think testing that adds value? | 20:14 |
*** javeriak has joined #openstack-neutron | 20:15 | |
davidsha | njohnston: I think testing it will let me know if I made a mess of it ;) | 20:15 |
njohnston | davidsha: Then let's roll with it, and come what may! | 20:15 |
davidsha | njohnston: kk, I'll go through the rest of it and pull out whatever comments we left in. | 20:16 |
*** javeriak has quit IRC | 20:16 | |
*** javeriak has joined #openstack-neutron | 20:16 | |
njohnston | davidsha: Excellent. I'll read more about fullstack tests in the meantime, perhaps we can have a follow-on patch with a more holistic testing approach. | 20:17 |
*** baoli has joined #openstack-neutron | 20:18 | |
davidsha | njohnston: ack, I'll try and have this up within the hour. | 20:18 |
njohnston | davidsha: Thanks! I know it's getting late there. | 20:18 |
ajo | hi :) | 20:18 |
ajo | njohnston, ^what do you mean about functional/unit/fullstack? | 20:19 |
davidsha | ajo: hey, for Versioning. | 20:19 |
ajo | hmm, no, I mean you have to take neutron/objects/qos/policy.py | 20:20 |
*** alejandrito has joined #openstack-neutron | 20:20 | |
ajo | and in the QosPolicy bump the version to 1.1 | 20:20 |
*** javeriak_ has joined #openstack-neutron | 20:21 | |
*** javeriak has quit IRC | 20:21 | |
ajo | then add a method like: https://github.com/openstack/oslo.versionedobjects/blob/e6c275a3fee177afa0ec734e9b52d0e2e637c6dc/oslo_versionedobjects/tests/test_objects.py#L114 | 20:22 |
davidsha | ajo: ya I've done that, was just doing the function for removing dscp_marking_rule if it's version 1.0 | 20:22 |
ajo | to remove DSCP rules | 20:22 |
ajo | yeah | 20:22 |
ajo | correct | 20:22 |
davidsha | ajo: just adding tests to make sure it works! :) | 20:22 |
ajo | awesome | 20:22 |
*** slaweq has joined #openstack-neutron | 20:22 | |
*** yarkot_ has joined #openstack-neutron | 20:22 | |
*** johnbelamaric has joined #openstack-neutron | 20:23 | |
ajo | davidsha, and may be we need to ask the remaining rules to downgrade to 1.0 too | 20:23 |
ajo | davidsha, because otherwise the older agent won't know how to deserialize a 1.1 rule | 20:23 |
ajo | even though for the bandwidthlimit rule it'd be the same | 20:24 |
ajo | in fact I'm not sure if you need to bump QoSRule or not by having a different subclass | 20:24 |
davidsha | ajo: when we added DSCP it changed the hash for QosRule so we bumped the version | 20:25 |
ajo | aha | 20:25 |
ajo | ok | 20:26 |
*** yarkot_ has quit IRC | 20:26 | |
ajo | we will check with ihar | 20:26 |
ajo | https://github.com/openstack/oslo.versionedobjects/blob/e6c275a3fee177afa0ec734e9b52d0e2e637c6dc/doc/source/usage.rst | 20:26 |
ajo | oh at least now oslo versioned objects has some doc now | 20:26 |
davidsha | ajo: Will I add a similar method for QosRule then? | 20:27 |
openstackgerrit | Doug Wiegley proposed openstack/neutron: Bump to neutron-lib 0.0.2 https://review.openstack.org/285441 | 20:27 |
*** sbalukoff has joined #openstack-neutron | 20:28 | |
ajo | davidsha, I'm not sure how that method would work exactly | 20:28 |
*** baoli has quit IRC | 20:28 | |
ajo | davidsha, for QoSRule itself... I believe it's something to be left to the childs, the top class knows nothing | 20:29 |
ajo | davidsha, may be there's something related to subclasses and the downgrade method in the ovo's lib testing | 20:29 |
ajo | I need to dig back into my rpc patch | 20:29 |
davidsha | ajo: Is it the QosPolicy we need to be doing this to? I don't think the QosPolicy is aware of the rule types and it didn't need to be upgraded when we made the other changes. | 20:30 |
davidsha | just in regards to the hash values at least. | 20:30 |
openstackgerrit | Kevin Benton proposed openstack/neutron: Deprecate 'ovs_use_veth' and 'veth_mtu' options https://review.openstack.org/285532 | 20:30 |
openstackgerrit | Kevin Benton proposed openstack/neutron: Remove deprecated veth options from OVS https://review.openstack.org/285533 | 20:30 |
ajo | davidsha, yeah, but we will call the obj_make_compat thing | 20:30 |
*** abhiraut has quit IRC | 20:31 | |
ajo | we need it :) trust me | 20:31 |
*** baoli has joined #openstack-neutron | 20:31 | |
ajo | davidsha, make sure that when you downgrade it to 1.0, will have no DSCP rules, and the remaining Bandwidth rules are 1.0 | 20:31 |
openstackgerrit | Emilien Macchi proposed openstack/neutron-fwaas: add tempest-lib to test-requirements https://review.openstack.org/285534 | 20:32 |
davidsha | ajo: kk, but I don't think versioning out dscp needs to be done in QosPolicy, I think it might be in QosRule. | 20:32 |
ajo | davidsha, yeah, but, think what happens to a QoSRule (DSCP) if you try to downgrade ? | 20:33 |
ajo | and btw, our push/pull mechanism will call to downgrade on the QoSPolicy, | 20:33 |
ajo | not on the rules themselves | 20:33 |
ajo | so we need to make the QoSPolicy responsible for downgrading | 20:33 |
davidsha | ajo: kk | 20:34 |
*** baoli has quit IRC | 20:37 | |
*** madhu_ak has quit IRC | 20:37 | |
amuller | kevinbenton: I'm just finding more and more code to remove... It's not ending | 20:38 |
slaweq | ajo: hello | 20:38 |
ajo | hi slaweq | 20:39 |
slaweq | I just opened but on launchpad: https://bugs.launchpad.net/neutron/+bug/1550514 | 20:39 |
openstack | Launchpad bug 1550514 in neutron "L2 agents are not subscribing properly to push notifications queues" [Undecided,New] - Assigned to Slawek Kaplonski (slaweq) | 20:39 |
Sam-I-Am | mhickey: http://t.qkme.me/3py8mt.jpg | 20:39 |
Sam-I-Am | mhickey: that about describes america | 20:39 |
slaweq | I think it will be better to fix it in separate patch, not to do it together with QoS for LB | 20:39 |
slaweq | yes? | 20:39 |
kevinbenton | amuller: yay! | 20:40 |
kevinbenton | amuller: getting rid of those will really clean up the agents | 20:40 |
ajo | slaweq, aha, you may need to patch somehow the CommonAgentLoop to let you do that | 20:40 |
slaweq | yes, I already have such patch :) | 20:41 |
ajo | slaweq: ahh, ok :) | 20:41 |
slaweq | and it's working | 20:41 |
ajo | good | 20:41 |
amuller | kevinbenton: right now I'm only removing code from the scheduling layer in the server, and some DB methods | 20:41 |
amuller | kevinbenton: and a ton of tests | 20:41 |
ajo | slaweq, can I rephrase the title of your bug a bit? | 20:41 |
slaweq | but I will push it as another patch because it is not related to QoS IMHO | 20:41 |
slaweq | yes, sure | 20:41 |
amuller | kevinbenton: I need some tool that shows unused methods. I need a static language. | 20:41 |
slaweq | I always have problem with writing such things :) | 20:41 |
amuller | kevinbenton: maybe pylint has this if I remove some exceptions | 20:42 |
kevinbenton | amuller: don't you think we'll have to deprecate and then remove in newton? | 20:43 |
ajo | slaweq, done, so reference the bug from your patch, probably you didn't need a bug | 20:43 |
ajo | but it's good for explaining if somebody asks why are you changing it :) | 20:43 |
openstackgerrit | Doug Wiegley proposed openstack/neutron: Bump to neutron-lib 0.0.2 https://review.openstack.org/285441 | 20:43 |
amuller | kevinbenton: I personally don't think so. The use case of having the option set to True makes no sense, I can't imagine anyone wants this. | 20:43 |
slaweq | ok, so I can add info in commit message that it will close this bug also and it will be fine? | 20:43 |
kevinbenton | amuller: ok | 20:44 |
* ajo fills up the glass with Coke | 20:44 | |
*** achanda has quit IRC | 20:45 | |
*** apuimedo has quit IRC | 20:45 | |
kevinbenton | amuller: you're supposed to be reviewing the ALLOCATING patch ;) | 20:45 |
amuller | kevinbenton: aye | 20:46 |
amuller | kevinbenton: so, I was thinking about it | 20:46 |
kevinbenton | amuller: actually, while i have you and ajo around, do you think it's finally safe to deprecate these? https://bugs.launchpad.net/neutron/+bug/1550501 | 20:46 |
openstack | Launchpad bug 1550501 in neutron "the 'ovs_use_veth' and 'veth_mtu' options should be deprecated" [Undecided,In progress] - Assigned to Kevin Benton (kevinbenton) | 20:46 |
amuller | kevinbenton: I commented on the bug, I think it's safe to remove without a deprecation cycle | 20:46 |
ajo | kevinbenton, : reading | 20:46 |
amuller | kevinbenton: About the ALLOCATING patch, if we remove auto_schedule_routers, is there a scenario where an agent receives a notification about an HA router without an HA interface? | 20:47 |
ajo | kevinbenton, what was ovs_use_veth for, the patch ports ? | 20:47 |
*** abhiraut has joined #openstack-neutron | 20:47 | |
amuller | ajo: it was instead of OVS patch ports | 20:47 |
*** madhu_ak has joined #openstack-neutron | 20:47 | |
ajo | oh, | 20:47 |
ajo | can we leave those? | 20:47 |
ajo | I suspect I'm going to need that option for QoS, sadly | 20:47 |
ajo | patch ports don't allow QoS queue attachment, because they are not a linux kernel primitive device :( | 20:48 |
ajo | and those ports are the best port to do min bandwidth guarantees (eventually) | 20:48 |
kevinbenton | ajo: :'( | 20:48 |
*** manjeets has joined #openstack-neutron | 20:48 | |
ajo | yeah :( | 20:48 |
*** dims has joined #openstack-neutron | 20:48 | |
amuller | ajo: so you need veth pairs? | 20:48 |
amuller | ajo: between what bridges? | 20:48 |
manjeets | ?join ##osic-neutron | 20:48 |
ajo | amuller, yes, optionally if anybody wants min bandwidth guarantees they will need to use veths | 20:49 |
ajo | at performance expense... | 20:49 |
ajo | is a tradeoff :/ | 20:49 |
amuller | ajo: so the API will depend on a configuration option in the OVS agent being enabled? | 20:49 |
amuller | ajo: something smells here | 20:49 |
amuller | ajo: will the API check the OVS agents configurations dict? | 20:49 |
ajo | amuller, we definitely will need to | 20:50 |
amuller | ajo: how will you handle upgrades? | 20:50 |
ajo | amuller, we send the agent config info in state reports | 20:50 |
kevinbenton | amuller: so if we remove auto_schedule_routers we still have to worry about the update case | 20:50 |
ajo | amuller, : carefully | 20:50 |
amuller | hehe | 20:50 |
ajo | ':D | 20:50 |
ajo | amuller, I haven't been able to think about that | 20:50 |
ajo | sec, kid crying.. | 20:50 |
*** eddima has joined #openstack-neutron | 20:50 | |
*** arosen12 has joined #openstack-neutron | 20:51 | |
*** eddima has quit IRC | 20:51 | |
kevinbenton | amuller: however, i was thinking about it and since we are filtering before routers go out to the agent anyway, i can just adjust the filter to not send any routers in the 'ha' state that don't have 'ha interface' key set | 20:51 |
anteaya | kevinbenton mhickey http://www.eatmacs.com/menu/2113870 | 20:51 |
kevinbenton | amuller: and then we don't need the new status | 20:51 |
kevinbenton | amuller: what do you think? The patch would become drastically simpler | 20:52 |
kevinbenton | amuller: with no state transitions | 20:52 |
amuller | kevinbenton: I need to think about what you said about the update case, sec | 20:53 |
*** claudiub has joined #openstack-neutron | 20:53 | |
*** absubram has quit IRC | 20:54 | |
*** gangil has joined #openstack-neutron | 20:55 | |
*** gangil has quit IRC | 20:55 | |
*** gangil has joined #openstack-neutron | 20:55 | |
*** abregman|afk has quit IRC | 20:55 | |
*** manjeets has left #openstack-neutron | 20:55 | |
amuller | kevinbenton: can you highlight the race in update_router without auto_schedule_routers in the mix? | 20:56 |
*** dave-mccowan has quit IRC | 20:56 | |
kevinbenton | amuller: an agent can host both an L3 legacy router and an HA router, right? | 20:56 |
amuller | kevinbenton: yes | 20:56 |
amuller | kevinbenton: people actually do that | 20:56 |
kevinbenton | amuller: issue two updates to the router | 20:57 |
*** claudiub|2 has quit IRC | 20:57 | |
kevinbenton | amuller: second converts to ha | 20:57 |
kevinbenton | amuller: first triggers it to poll the server | 20:57 |
kevinbenton | amuller: when l3 agent polls the server, the type has been set to HA | 20:57 |
kevinbenton | amuller: but the interfaces haven't been created yet | 20:57 |
amuller | kevinbenton: k | 20:57 |
amuller | kevinbenton: you're right | 20:57 |
* amuller is thinking | 20:58 | |
mhickey | Sam-I-Am, anteaya: thanks | 20:58 |
anteaya | awesome | 20:59 |
*** manjeets has joined #openstack-neutron | 21:00 | |
amuller | kevinbenton: I think that an update_router that doesn't change the HA flag doesn't notify agents | 21:00 |
ajo | kevinbenton, if you feel in the mood of cleanups, may be end up the use_ipsets for the iptablesfirewalldriver ? | 21:00 |
ajo | default to true, and kill the rule expansions in if branches ? | 21:01 |
ajo | :) | 21:01 |
ajo | O:) | 21:01 |
ajo | or.. just mark it deprecated for now | 21:01 |
kevinbenton | ajo: that might work :) | 21:01 |
kevinbenton | amuller: but what updates do notify agents? | 21:01 |
*** ivar-lazzaro has quit IRC | 21:02 | |
kevinbenton | amuller: how about a router-gateway set? | 21:02 |
kevinbenton | amuller: or an interface add | 21:02 |
amuller | kevinbenton: yes | 21:02 |
amuller | kevinbenton: those 2 | 21:02 |
kevinbenton | amuller: right, so either of those could trigger it | 21:02 |
kevinbenton | amuller: there is also the basic bad timing case of the agent starting up right while routers are being converted | 21:02 |
kevinbenton | amuller: or it reconnects to oslo messaging | 21:02 |
openstackgerrit | Merged openstack/neutron: Add use_default_subnetpool to subnet create requests https://review.openstack.org/282021 | 21:02 |
*** absubram has joined #openstack-neutron | 21:07 | |
*** skamithi14 has quit IRC | 21:11 | |
*** skamithi13 has joined #openstack-neutron | 21:11 | |
kevinbenton | amuller: what do you think? | 21:12 |
*** yarkot_ has joined #openstack-neutron | 21:13 | |
*** rickyrem has joined #openstack-neutron | 21:13 | |
*** yamamoto has joined #openstack-neutron | 21:14 | |
amuller | kevinbenton: the ALLOCATING status is more future-proof | 21:14 |
amuller | kevinbenton: if we add additional resources to an HA router, but it's unlikely | 21:14 |
amuller | kevinbenton: how significant is the complexity difference? | 21:14 |
kevinbenton | amuller: let me propose a separate patch for you to look at | 21:15 |
amuller | kevinbenton: that would be ideal :) | 21:15 |
amuller | kevinbenton++ | 21:15 |
kevinbenton | amuller: even if we add more resources to an HA router, we would just update the filter instead of the status changing logic, but i see what you mean | 21:15 |
amuller | kevinbenton: you'd have to remember to do that | 21:15 |
amuller | kevinbenton: and we don't really have a test for this | 21:15 |
*** alejandrito has quit IRC | 21:16 | |
kevinbenton | amuller: right | 21:16 |
kevinbenton | amuller: ok, give me a few. how much longer are you on for today? | 21:16 |
amuller | kevinbenton: if the complexity difference is significant, considering the scenario I'm talking about is not likely, I'm OK with just filtering on the existence of an HA port | 21:17 |
amuller | kevinbenton: dunno, few hours | 21:17 |
kevinbenton | amuller: ok, just wanted to make sure it wasn't in the next couple of minutes :) | 21:17 |
davidsha | ajo: ok, it's done for the QosPolicy (it steps through the rules and deletes any that are not bandwidth limit rules), what would I need to do for the QosRules then? | 21:18 |
amuller | kevinbenton: no no | 21:19 |
*** javeriak_ has quit IRC | 21:19 | |
*** yamamoto has quit IRC | 21:19 | |
ajo | davidsha, I'm not completely sure, we may need to discuss with ihar, but I'd say: | 21:19 |
ajo | provide a downgrade method on each rule type (DSCP/Bandwidth) | 21:20 |
ajo | DSCP just throws an exception if you try to downgrade 1.1 to 1.0 | 21:20 |
ajo | Bandwidth limit rule, just does nothing ? :) | 21:20 |
ajo | davidsha, it's a bit weird with the subclasses, look at the oslo versionedobjects tests, and see if there's something like that related to subclasses | 21:21 |
ajo | or look for the authors of that "stuff" and ask, or alternatively read the oslo versioned objects subclasses code... | 21:21 |
*** baoli has joined #openstack-neutron | 21:21 | |
davidsha | ajo: kk. | 21:21 |
ajo | davidsha: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/tests/test_objects.py#L165 | 21:22 |
ajo | I wonder what that child_versions is for | 21:22 |
davidsha | ajo: VERSION is a static variable across all QosRule objects is it? | 21:22 |
*** evgenyf has quit IRC | 21:23 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: WIP: Remove auto_schedule_routers code and option https://review.openstack.org/285480 | 21:23 |
ajo | davidsha, I wonder if we can have QoSBandwidthRule 1.0 and the DSCP 1.0, but QoSRule is 1.1 | 21:23 |
ajo | I'm a bit new on that, sorry | 21:23 |
mlavalle | carl_baldwin: ping | 21:23 |
ajo | you need to investigate :) | 21:23 |
carl_baldwin | mlavalle: pong! | 21:23 |
*** john-davidge has quit IRC | 21:24 | |
*** ritesh_ has joined #openstack-neutron | 21:24 | |
*** tiswanso has quit IRC | 21:24 | |
*** claudiub|2 has joined #openstack-neutron | 21:25 | |
mlavalle | carl_baldwin: I finished my first version of the segemtns host mapping. I wanted to push now, but your patchset needs to be rebased. SO, since I am not exactly an expert on this (as you might remember) and I have to leave in 10 minutes, I'll do the rebasing slowly when I get home | 21:25 |
*** tiswanso has joined #openstack-neutron | 21:25 | |
carl_baldwin | mlavalle: Let me take a look... | 21:25 |
mlavalle | carl_baldwin: I don't want to mess up your patchset | 21:25 |
carl_baldwin | mlavalle: Why does mine need to be rebased? | 21:26 |
Sam-I-Am | aight folks, time to airporterize | 21:26 |
Sam-I-Am | was a fun mid-cycle | 21:26 |
mlavalle | carl_baldwin: well, gerrit says it's in conflict wuth 3 patchsets | 21:27 |
carl_baldwin | Sam-I-Am: Safe travels. I'll watch for your plane flying overhead. | 21:27 |
Sam-I-Am | haha... i'll wave. | 21:27 |
njohnston | ajo: That is the way the tests look: https://review.openstack.org/#/c/251738/27/neutron/tests/unit/objects/test_objects.py | 21:27 |
openstackgerrit | Slawek Kaplonski proposed openstack/neutron: Add support for QoS for LinuxBridge agent https://review.openstack.org/236210 | 21:27 |
carl_baldwin | mlavalle: That just means that 3 other patch sets in flight will conflict if they all try to merge. | 21:27 |
openstackgerrit | Merged openstack/neutron: Prevent binding IPv6 addresses to Neutron interfaces https://review.openstack.org/268373 | 21:28 |
*** claudiub has quit IRC | 21:28 | |
ajo | njohnston, ahaa | 21:28 |
carl_baldwin | mlavalle: If it truly needs a rebase, it will say in bold red letters something like "Merge conflict" | 21:28 |
ajo | ok, njohnston , davidsha, may be you don't need to provide anything on QoSRuleType then | 21:28 |
*** absubram has quit IRC | 21:28 | |
njohnston | ajo: I had to add that to get the DSCP tests to work, which taught me a lot | 21:29 |
mlavalle | carl_baldwin: ok, then I'll try to push slowly when I get home. I got an error in git review. Time to leave for Minneapolis. Have a nice weekend! | 21:29 |
*** baoli has quit IRC | 21:29 | |
*** claudiub has joined #openstack-neutron | 21:29 | |
*** yarkot_ has quit IRC | 21:29 | |
carl_baldwin | mlavalle: Safe travels for you too! | 21:29 |
ajo | ok, njohnston , davidsha, may be you don't need to provide anything on QoSRuleType then, just try to downgrade it to 1.0 and let's see, may be you need to go from the QoSpolicy on the downgrade loop and ask the rules to get downgraded too (the survivor rules) | 21:29 |
ajo | njohnston, thanks :) | 21:30 |
njohnston | ajo: Happy to help! | 21:30 |
*** claudiub|2 has quit IRC | 21:31 | |
carl_baldwin | For everyone getting ready to travel from the Rochester meetup, safe travels! It was a great meetup! | 21:33 |
openstackgerrit | Merged openstack/neutron: Allow address pairs to be cleared with None https://review.openstack.org/273018 | 21:33 |
*** vhosakot has quit IRC | 21:34 | |
openstackgerrit | Miguel Lavalle proposed openstack/neutron: [WIP] Basic extension and CRUD for Segments https://review.openstack.org/284440 | 21:35 |
openstackgerrit | Miguel Lavalle proposed openstack/neutron: Add segments to hosts mappings for Routed Networks https://review.openstack.org/285548 | 21:35 |
davidsha | ajo: Ok so just waterfall the new version to the rules I don't delete? | 21:35 |
openstackgerrit | Martin Hickey proposed openstack/neutron: Add custom SQLAlchemy type for IP addresses https://review.openstack.org/277558 | 21:35 |
*** vhoward has quit IRC | 21:36 | |
*** zhhuabj_ has quit IRC | 21:36 | |
mlavalle | carl_baldwin: I pushed: https://review.openstack.org/#/c/285548 | 21:37 |
carl_baldwin | mlavalle: Cool. | 21:37 |
mlavalle | carl_baldwin: did di it wrong, though? Please look at your patchset | 21:37 |
* carl_baldwin looking... | 21:37 | |
ajo | davidsha, I'd guess that, | 21:38 |
davidsha | ajo, njohnston: wait do we need to version change the QosRules? I assume if the version isn't supported then they can't be created so once they are deleted from the policy it should be ok... right? | 21:38 |
ajo | we will have to review and check | 21:38 |
ajo | davidsha, they can't contain '1.1', or old agent's won't be able to deserialize | 21:38 |
njohnston | ajo: You mean QosRuleType? | 21:39 |
davidsha | njohnston: yeah QosRuleType, sorry! | 21:39 |
ajo | yeah | 21:39 |
carl_baldwin | mlavalle: You did upload a new version of my patch set which shouldn't have happened. I can help you work through that. | 21:39 |
njohnston | the '1.1' just needs to match whatever is in here: https://review.openstack.org/#/c/251738/27/neutron/objects/qos/rule_type.py | 21:39 |
njohnston | ajo davidsha: so we could put '2.0' and it would be just as happy | 21:40 |
mhickey | Bye all. Thanks to all those I met at the moidcycle. I enjoyed the fun. Safe home to those travelling. | 21:40 |
mlavalle | carl_baldwin: mhhh.... sorry, let's fix it MOnday..... Sam-I-Am is getting nervous, we have to leave | 21:40 |
mlavalle | carl_baldwin: have a nice weekend! | 21:40 |
carl_baldwin | mhickey: Bye, have a nice (long) trip back. It was great to meet you. | 21:40 |
mhickey | mlavalle: mins the state troppers!:) | 21:41 |
mhickey | mind* | 21:41 |
carl_baldwin | mlavalle: bye | 21:41 |
mhickey | carl_baldwin: I enjoyde it too. | 21:41 |
*** mlavalle has quit IRC | 21:41 | |
mhickey | *enjoyed | 21:41 |
* njohnston likes the term 'moidcycle' | 21:41 | |
carl_baldwin | mhickey: :) | 21:41 |
*** agireud has quit IRC | 21:41 | |
* carl_baldwin sure mhickey is just typing way to fast | 21:42 | |
mhickey | njohnston: sorry; the piano has been drinking!:) | 21:43 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron: Updated from global requirements https://review.openstack.org/283991 | 21:43 |
*** jamielennox is now known as jamielennox|away | 21:43 | |
*** agireud has joined #openstack-neutron | 21:43 | |
mhickey | brain is shutting down | 21:43 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas: Updated from global requirements https://review.openstack.org/285041 | 21:43 |
*** mhickey has quit IRC | 21:44 | |
*** porunov has quit IRC | 21:45 | |
openstackgerrit | Manjeet Singh Bhatia proposed openstack/python-neutronclient: Fix the unicode for address scope create https://review.openstack.org/285557 | 21:46 |
njohnston | safe travels for those travelling, and happy weekend all. | 21:49 |
*** manjeets has quit IRC | 21:49 | |
*** john-davidge has joined #openstack-neutron | 21:50 | |
*** ritesh has quit IRC | 21:52 | |
*** iyamahat has quit IRC | 21:55 | |
*** iyamahat has joined #openstack-neutron | 21:55 | |
*** ivar-lazzaro has joined #openstack-neutron | 21:55 | |
*** baoli has joined #openstack-neutron | 21:57 | |
*** baoli has quit IRC | 21:59 | |
*** salv-orlando has joined #openstack-neutron | 21:59 | |
*** salv-orl_ has quit IRC | 22:02 | |
*** crose has quit IRC | 22:02 | |
*** localloo1 has quit IRC | 22:03 | |
*** boden has joined #openstack-neutron | 22:05 | |
*** safchain has quit IRC | 22:05 | |
*** tpsilva has quit IRC | 22:07 | |
*** gvrangan_ has quit IRC | 22:09 | |
*** gvrangan has quit IRC | 22:09 | |
*** baoli has joined #openstack-neutron | 22:11 | |
*** gvrangan_ has joined #openstack-neutron | 22:14 | |
*** tbachman has quit IRC | 22:14 | |
*** gvrangan has joined #openstack-neutron | 22:14 | |
openstackgerrit | Assaf Muller proposed openstack/neutron: WIP: Remove auto_schedule_routers code and option https://review.openstack.org/285480 | 22:15 |
*** yamamoto has joined #openstack-neutron | 22:16 | |
*** Marga_ has quit IRC | 22:16 | |
*** Marga_ has joined #openstack-neutron | 22:16 | |
*** ranjithd has quit IRC | 22:19 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Revert "Functional test for address scope" https://review.openstack.org/285570 | 22:20 |
*** abhiraut has quit IRC | 22:21 | |
*** yamamoto has quit IRC | 22:21 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Filter HA routers without HA interface and state https://review.openstack.org/285572 | 22:25 |
davidsha | njohnston, ajo: I'm gonna have to call it a night, weather is pretty bad here and I've a long commute. Will I upload what I have now (just object versioning for QosPolicys and unit tests for it)? | 22:25 |
*** thorst_ has quit IRC | 22:26 | |
*** tiswanso has quit IRC | 22:26 | |
kevinbenton | amuller: still there? | 22:26 |
ajo | davidsha, sure, perfect, have safe trip back home | 22:26 |
amuller | kevinbenton: yarp | 22:26 |
kevinbenton | amuller: https://review.openstack.org/285572 | 22:26 |
ajo | davidsha: thanks a lot | 22:26 |
*** iyamahat has quit IRC | 22:26 | |
*** ivar-lazzaro has quit IRC | 22:27 | |
davidsha | ajo: thanks, no problem. I'd stay on but the roads are bad enough during the day. that PS will be up in the next 15 mins | 22:27 |
openstackgerrit | Kevin Benton proposed openstack/neutron: Collect details on ARP spoof functional failures https://review.openstack.org/285181 | 22:29 |
openstackgerrit | Kevin Benton proposed openstack/neutron: Override addOnException to catch exceptions https://review.openstack.org/283340 | 22:29 |
*** abhiraut has joined #openstack-neutron | 22:30 | |
amuller | kevinbenton: that is pretty simple =p | 22:31 |
*** baoli has quit IRC | 22:31 | |
*** abhiraut has quit IRC | 22:31 | |
*** baoli has joined #openstack-neutron | 22:33 | |
kevinbenton | amuller: yeah | 22:34 |
*** rkukura has quit IRC | 22:36 | |
*** yamahata has quit IRC | 22:37 | |
*** baoli has quit IRC | 22:39 | |
*** ivar-lazzaro has joined #openstack-neutron | 22:40 | |
*** thorst has joined #openstack-neutron | 22:42 | |
amuller | kevinbenton: commented | 22:43 |
*** baoli has joined #openstack-neutron | 22:45 | |
kevinbenton | amuller: i was future proofing in case there were other fields! :) | 22:45 |
*** gvrangan_ has quit IRC | 22:46 | |
*** thorst has quit IRC | 22:46 | |
amuller | kevinbenton: in that function specifically we care if the router is actually bound to the agent though no? | 22:46 |
amuller | even if we envision the future =p | 22:47 |
*** gvrangan_ has joined #openstack-neutron | 22:47 | |
ajo | how beautiful is to catch your bugs upfront via tests... | 22:47 |
* ajo smiles | 22:47 | |
*** marcusvrn_ has quit IRC | 22:47 | |
jckasper | kevinbenton: http://www.eatmacs.com/menu/2113870 | 22:47 |
*** gvrangan has quit IRC | 22:48 | |
ajo | jckasper, greek restaurants, yummy | 22:48 |
ajo | I could have dinner again, I almost forgot what I had for dinner :) | 22:48 |
jckasper | haven't had any myself | 22:48 |
*** Marga_ has quit IRC | 22:48 | |
*** abhiraut has joined #openstack-neutron | 22:49 | |
*** Marga_ has joined #openstack-neutron | 22:49 | |
ajo | jckasper, Moussaka is a classic :) | 22:50 |
kevinbenton | amuller: we do, but that would be the place to filter if there are other keys as well | 22:50 |
kevinbenton | amuller: i suppose it's a case where we can just fix it when it's needed in the future | 22:50 |
amuller | kevinbenton: the context of that function is per-router-per-host | 22:50 |
amuller | kevinbenton: so any keys would be per host | 22:51 |
amuller | kevinbenton: i.e. because of a binding | 22:51 |
openstackgerrit | Merged openstack/neutron: Qos policy RBAC DB setup and migration https://review.openstack.org/250081 | 22:51 |
kevinbenton | amuller: i understand, but if the router body is supposed to have another key that hasn't been set yet that would be where to filter | 22:51 |
kevinbenton | amuller: unrelated to the binding | 22:51 |
openstackgerrit | Merged openstack/neutron: Ensure DVR unit tests use '/tmp' directory https://review.openstack.org/283843 | 22:52 |
*** baoli has quit IRC | 22:52 | |
*** iyamahat has joined #openstack-neutron | 22:52 | |
*** boden has quit IRC | 22:53 | |
*** Marga_ has quit IRC | 22:53 | |
amuller | kevinbenton: I won't insist | 22:54 |
amuller | kevinbenton: not important anyway | 22:54 |
kevinbenton | amuller: updating now | 22:55 |
kevinbenton | amuller: gonna simplify some more if we're just looking at the binding | 22:55 |
ajo | kevinbenton, ^ hi, thanks for the quick review (qos rbac and ovo-rbac) :) | 22:56 |
*** singhj has quit IRC | 22:56 | |
*** pradk has quit IRC | 22:56 | |
*** baoli has joined #openstack-neutron | 22:58 | |
*** rossella_s has quit IRC | 22:58 | |
*** fishbone has quit IRC | 22:58 | |
*** rossella_s has joined #openstack-neutron | 22:58 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Filter HA routers without HA interface and state https://review.openstack.org/285572 | 23:01 |
kevinbenton | amuller: ^^ | 23:01 |
kevinbenton | ajo: no prob | 23:01 |
*** singhj has joined #openstack-neutron | 23:02 | |
*** baoli has quit IRC | 23:02 | |
openstackgerrit | Merged openstack/neutron: ML2: Increase segment_mtu from 0 to 1500 bytes https://review.openstack.org/284407 | 23:02 |
*** jckasper has quit IRC | 23:03 | |
*** sridhar_ram1 has joined #openstack-neutron | 23:03 | |
openstackgerrit | Merged openstack/neutron: Fix test_get_device_id() failure on OSX https://review.openstack.org/284234 | 23:03 |
*** singhj has quit IRC | 23:03 | |
*** neelashah has quit IRC | 23:04 | |
*** jwarendt has quit IRC | 23:04 | |
*** BhavyaM has joined #openstack-neutron | 23:05 | |
*** sridhar_ram has quit IRC | 23:05 | |
*** rpothier has quit IRC | 23:06 | |
*** NightKhaos has quit IRC | 23:06 | |
*** singhj has joined #openstack-neutron | 23:07 | |
*** dims has quit IRC | 23:07 | |
*** skamithi has quit IRC | 23:12 | |
*** yamahata has joined #openstack-neutron | 23:13 | |
*** jckasper has joined #openstack-neutron | 23:14 | |
*** Marga_ has joined #openstack-neutron | 23:15 | |
*** ccard_ has joined #openstack-neutron | 23:16 | |
*** jwarendt has joined #openstack-neutron | 23:17 | |
*** yamamoto has joined #openstack-neutron | 23:17 | |
*** jckasper has quit IRC | 23:18 | |
*** baoli has joined #openstack-neutron | 23:19 | |
*** ccard__ has quit IRC | 23:19 | |
*** Marga_ has quit IRC | 23:19 | |
openstackgerrit | David Shaughnessy proposed openstack/neutron: DSCP QoS rule implementation https://review.openstack.org/251738 | 23:23 |
*** yamamoto has quit IRC | 23:23 | |
*** amuller has quit IRC | 23:23 | |
*** armax has quit IRC | 23:23 | |
davidsha | ajo: PS is up, sorry for the delay rebased my code without committing the changes..... | 23:24 |
*** haplo37 has quit IRC | 23:24 | |
*** armax has joined #openstack-neutron | 23:25 | |
*** davidsha has quit IRC | 23:26 | |
*** tbachman has joined #openstack-neutron | 23:27 | |
ajo | davidsha, no worries, have a good night | 23:27 |
ajo | oh, he was out already :) | 23:27 |
*** shwetaap has quit IRC | 23:28 | |
*** rossella_s has quit IRC | 23:28 | |
openstackgerrit | Kevin Benton proposed openstack/neutron: Filter HA routers without HA interface and state https://review.openstack.org/285572 | 23:29 |
*** singhj has quit IRC | 23:33 | |
*** dims has joined #openstack-neutron | 23:34 | |
*** skamithi13 has quit IRC | 23:36 | |
*** tbachman has quit IRC | 23:37 | |
*** tbachman has joined #openstack-neutron | 23:38 | |
*** singhj has joined #openstack-neutron | 23:38 | |
*** edmondsw has quit IRC | 23:39 | |
*** sridhar_ram1 has quit IRC | 23:40 | |
*** skamithi13 has joined #openstack-neutron | 23:40 | |
*** haplo37 has joined #openstack-neutron | 23:40 | |
*** erhudy has quit IRC | 23:40 | |
*** sridhar_ram has joined #openstack-neutron | 23:42 | |
*** tbachman has quit IRC | 23:51 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: RPC Callback rolling upgrades reporting, and integration https://review.openstack.org/268040 | 23:51 |
*** iyamahat has quit IRC | 23:51 | |
*** yamamoto has joined #openstack-neutron | 23:54 | |
*** Marga_ has joined #openstack-neutron | 23:55 | |
*** emagana has quit IRC | 23:56 | |
*** singhj has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!