Friday, 2016-07-29

*** rossella_s has quit IRC00:00
*** rossella_s has joined #openstack-neutron00:00
*** lujinluo has joined #openstack-neutron00:04
*** nlahouti1 has joined #openstack-neutron00:04
*** nlahouti has quit IRC00:04
*** nlahouti1 has quit IRC00:06
*** nlahouti has joined #openstack-neutron00:06
*** singhj has quit IRC00:08
*** abhiraut has quit IRC00:10
*** nlahouti has quit IRC00:12
*** nlahouti has joined #openstack-neutron00:12
*** sbalukoff has quit IRC00:12
*** wolverineav has quit IRC00:12
*** wolverineav has joined #openstack-neutron00:13
*** iyamahat has quit IRC00:14
*** sputnik13 has quit IRC00:14
*** iyamahat has joined #openstack-neutron00:14
*** wolverineav has quit IRC00:14
openstackgerritAradhana Singh proposed openstack/neutron: Refactoring config options for cmd  https://review.openstack.org/32304600:14
*** wolverineav has joined #openstack-neutron00:15
*** fnaval has quit IRC00:15
*** yamahata has quit IRC00:17
openstackgerritAdolfo Duarte proposed openstack/neutron: Add RPC layer for Trunk Plugin and initial Open vSwitch driver  https://review.openstack.org/34766200:17
*** zhhuabj has quit IRC00:18
*** mattgreene has quit IRC00:23
*** yamamoto_ has joined #openstack-neutron00:25
*** ircuser-1 has quit IRC00:28
*** yamamoto_ has quit IRC00:31
openstackgerritKevin Benton proposed openstack/neutron: Increment revision numbers on object changes  https://review.openstack.org/30396600:34
*** fnaval has joined #openstack-neutron00:35
openstackgerritLujin Luo proposed openstack/neutron: Add a unique key to port_id in routerports table  https://review.openstack.org/28504800:36
*** zhhuabj has joined #openstack-neutron00:37
*** fnaval has quit IRC00:37
*** fnaval has joined #openstack-neutron00:37
*** jamesden_ has quit IRC00:38
openstackgerritLujin Luo proposed openstack/neutron: Add a composite unique key to floatingip table in Neutron database  https://review.openstack.org/27601800:39
*** Swami has quit IRC00:41
*** vijaykc4 has joined #openstack-neutron00:41
*** mfuruta has joined #openstack-neutron00:41
*** emagana has joined #openstack-neutron00:43
*** jckasper has quit IRC00:43
*** jckasper has joined #openstack-neutron00:44
*** hoangcx has joined #openstack-neutron00:44
*** andymaier has quit IRC00:44
*** yamahata has joined #openstack-neutron00:46
*** emagana has quit IRC00:47
*** sbalukoff has joined #openstack-neutron00:48
*** thorst has joined #openstack-neutron00:48
*** jckasper has quit IRC00:49
*** vijaykc4 has quit IRC00:49
openstackgerritManjeet Singh Bhatia proposed openstack/neutron: Refactor Router Db Models  https://review.openstack.org/34856200:49
*** jamielennox is now known as jamielennox|away00:49
*** trananhkma has joined #openstack-neutron00:51
*** mlavalle has quit IRC00:53
*** tonytan4ever has joined #openstack-neutron00:53
*** nlahouti has quit IRC00:53
*** thorst has quit IRC00:54
*** emagana has joined #openstack-neutron00:54
*** thorst has joined #openstack-neutron00:54
*** yb has quit IRC00:55
*** abhiraut has joined #openstack-neutron00:56
*** fnaval has quit IRC00:57
*** tonytan4ever has quit IRC00:58
*** iyamahat has quit IRC00:58
*** iyamahat has joined #openstack-neutron00:58
*** hoangcx2 has quit IRC00:58
*** thorst has quit IRC00:59
*** elo has quit IRC00:59
openstackgerritMerged openstack/neutron: Wait for vswitchd to add interfaces in native ovsdb  https://review.openstack.org/34485900:59
*** emagana has quit IRC01:01
*** abhiraut has quit IRC01:02
*** abhiraut has joined #openstack-neutron01:02
*** djan_ has joined #openstack-neutron01:03
*** djan has quit IRC01:04
openstackgerritgengchc2 proposed openstack/neutron: modify the home-page info with the developer documentation  https://review.openstack.org/34859801:06
*** lujinluo has quit IRC01:06
*** lujinluo has joined #openstack-neutron01:06
*** wolverin_ has joined #openstack-neutron01:08
openstackgerritManjeet Singh Bhatia proposed openstack/neutron: Refactor Router Db Models  https://review.openstack.org/34856201:10
*** yamahata has quit IRC01:10
*** itisha has quit IRC01:10
*** wolverineav has quit IRC01:11
*** elo has joined #openstack-neutron01:11
*** yb has joined #openstack-neutron01:11
*** s3wong has quit IRC01:12
*** wolverin_ has quit IRC01:12
*** vijaykc4 has joined #openstack-neutron01:15
*** namnh has joined #openstack-neutron01:17
*** johnbelamaric has joined #openstack-neutron01:25
openstackgerritli,chen proposed openstack/neutron-vpnaas: Fix API Tests  https://review.openstack.org/33583801:25
*** yamamoto_ has joined #openstack-neutron01:27
*** bvandewa has quit IRC01:28
*** abhiraut has quit IRC01:28
*** banix has quit IRC01:28
*** iyamahat has quit IRC01:29
*** iyamahat has joined #openstack-neutron01:29
*** yamamoto_ has quit IRC01:32
*** tidwellr has left #openstack-neutron01:33
*** tonytan4ever has joined #openstack-neutron01:34
*** jamielennox|away is now known as jamielennox01:34
*** kevo has quit IRC01:36
*** vijaykc4 has quit IRC01:40
*** vijaykc4 has joined #openstack-neutron01:40
*** vijaykc4 has quit IRC01:41
*** abhiraut has joined #openstack-neutron01:42
*** EinstCrazy has joined #openstack-neutron01:44
*** yamahata has joined #openstack-neutron01:44
*** EinstCrazy has quit IRC01:45
*** EinstCrazy has joined #openstack-neutron01:45
*** janzian has quit IRC01:46
*** gvrangan has quit IRC01:51
*** vijaykc4 has joined #openstack-neutron01:56
*** thorst has joined #openstack-neutron02:04
*** thorst has quit IRC02:05
*** thorst has joined #openstack-neutron02:05
*** thorst has quit IRC02:10
namnhzzzeek: Hello Mr.Mike, are you around? I have just answered your comment. Could you please take a look at it.02:10
*** lujinluo has quit IRC02:11
*** lujinluo has joined #openstack-neutron02:11
*** yamahata has quit IRC02:15
*** Leo_ has joined #openstack-neutron02:15
*** iyamahat has quit IRC02:16
namnhzzzeek: ^^ Here is our patch: https://review.openstack.org/#/c/314054/2902:19
*** Leom has joined #openstack-neutron02:20
*** Leo_ has quit IRC02:23
*** djan has joined #openstack-neutron02:23
*** xinliang has quit IRC02:24
*** jckasper has joined #openstack-neutron02:24
*** elopez has joined #openstack-neutron02:25
*** djan_ has quit IRC02:25
*** elopez is now known as Guest7854302:25
*** Guest78543 has quit IRC02:26
*** yamamoto_ has joined #openstack-neutron02:28
*** abhiraut has quit IRC02:28
openstackgerritAnh Tran proposed openstack/neutron: Prevent duplicate SG rules in 'concurrent requests' case  https://review.openstack.org/34597802:31
*** jamielennox is now known as jamielennox|away02:32
*** yamamoto_ has quit IRC02:34
openstackgerritOpenStack Proposal Bot proposed openstack/python-neutronclient: Updated from global requirements  https://review.openstack.org/34867802:34
openstackgerritDarek Smigiel proposed openstack/neutron: Rename DB columns: tenant -> project  https://review.openstack.org/33578602:38
*** veena has joined #openstack-neutron02:38
*** veena has quit IRC02:40
*** tonytan4ever has quit IRC02:41
*** itzikb has joined #openstack-neutron02:42
openstackgerritDarek Smigiel proposed openstack/neutron: Added Deprecation Warning to models  https://review.openstack.org/33579202:42
*** jhershbe has joined #openstack-neutron02:42
*** banix has joined #openstack-neutron02:46
*** claudiub|2 has quit IRC02:46
*** a_ta has joined #openstack-neutron02:47
*** gouthamr_ has quit IRC02:51
*** zhhuabj_ has joined #openstack-neutron02:52
*** zhhuabj has quit IRC02:53
*** xinliang has joined #openstack-neutron02:54
*** MadOtis has joined #openstack-neutron02:55
*** vijaykc4 has quit IRC02:55
*** jckasper has quit IRC02:56
*** elo has quit IRC02:56
*** jckasper has joined #openstack-neutron02:56
*** Leom has quit IRC02:56
*** yuanying_ has quit IRC02:57
*** elo has joined #openstack-neutron02:59
*** jckasper has quit IRC03:01
*** abhiraut has joined #openstack-neutron03:05
*** abhiraut has quit IRC03:06
*** jckasper has joined #openstack-neutron03:06
*** tbachman has quit IRC03:09
*** zhhuabj_ has quit IRC03:10
*** jckasper has quit IRC03:11
*** jckasper has joined #openstack-neutron03:11
*** emagana has joined #openstack-neutron03:13
*** jckasper has quit IRC03:13
openstackgerrithuan proposed openstack/neutron: XenAPI: add support for conntrack with XenServer  https://review.openstack.org/34130403:13
*** jckasper has joined #openstack-neutron03:14
*** tbachman has joined #openstack-neutron03:16
*** emagana has quit IRC03:17
*** jhershbe has quit IRC03:18
*** 1JTAAVE94 has joined #openstack-neutron03:19
*** 18VABF8Y2 has joined #openstack-neutron03:19
*** zhhuabj_ has joined #openstack-neutron03:22
*** 18VABF8Y2 has quit IRC03:24
*** 1JTAAVE94 has quit IRC03:24
*** lujinluo has quit IRC03:25
*** tflynn has joined #openstack-neutron03:27
*** zhhuabj_ has quit IRC03:28
openstackgerritIrina proposed openstack/neutron-vpnaas: Adding tests for endpoint-group api.  https://review.openstack.org/33807503:29
*** yamamoto_ has joined #openstack-neutron03:31
*** jckasper has quit IRC03:31
*** jckasper has joined #openstack-neutron03:32
*** jckasper has quit IRC03:33
*** Guest78543 has joined #openstack-neutron03:36
*** yamamoto_ has quit IRC03:36
*** zhhuabj_ has joined #openstack-neutron03:36
*** Guest78543 has quit IRC03:38
*** MadOtis has quit IRC03:40
*** Sukhdev has joined #openstack-neutron03:40
*** tonytan4ever has joined #openstack-neutron03:42
*** yamamoto_ has joined #openstack-neutron03:44
*** liuyulong has joined #openstack-neutron03:45
*** zhhuabj_ has quit IRC03:45
*** tonytan4ever has quit IRC03:47
*** zhhuabj_ has joined #openstack-neutron03:49
*** yuanying has joined #openstack-neutron03:51
*** hieulq has joined #openstack-neutron03:51
openstackgerritMerged openstack/neutron-vpnaas: Add Libreswan installation guide in devstack.rst  https://review.openstack.org/34472303:53
*** tidwellr has joined #openstack-neutron03:53
*** zhhuabj has joined #openstack-neutron03:54
*** zhhuabj_ has quit IRC03:57
namnhHi everyone. Do you know so that Neutron use oslo_db which I cloned from Githup?. I don't want to use Oslo_db from .../python2.7/dist-packages/oslo_db. Thanks!03:58
*** lujinluo has joined #openstack-neutron03:59
*** buttercup has joined #openstack-neutron03:59
*** zhhuabj has quit IRC04:01
*** emagana has joined #openstack-neutron04:01
*** zhhuabj has joined #openstack-neutron04:02
*** zhhuabj_ has joined #openstack-neutron04:03
*** emagana has quit IRC04:06
*** zhhuabj has quit IRC04:06
*** links has joined #openstack-neutron04:13
*** links has quit IRC04:13
*** links has joined #openstack-neutron04:13
*** djan has quit IRC04:13
*** djan has joined #openstack-neutron04:14
*** jckasper has joined #openstack-neutron04:14
*** zhhuabj_ has quit IRC04:19
*** jhershbe has joined #openstack-neutron04:21
*** itzikb has quit IRC04:21
*** Sukhdev has quit IRC04:24
*** Sukhdev has joined #openstack-neutron04:25
*** ircuser-1 has joined #openstack-neutron04:28
*** Sukhdev has quit IRC04:29
*** nlahouti has joined #openstack-neutron04:29
*** yamamoto_ has quit IRC04:34
*** krtaylor has joined #openstack-neutron04:35
openstackgerritAnh Tran proposed openstack/neutron: Rollback port after failed to add it to router  https://review.openstack.org/34142704:38
*** chandankumar has joined #openstack-neutron04:38
*** zhhuabj_ has joined #openstack-neutron04:39
*** Leo_ has joined #openstack-neutron04:41
*** a_ta has quit IRC04:42
*** a_ta has joined #openstack-neutron04:43
*** Leo_ has quit IRC04:46
*** boden has joined #openstack-neutron04:46
*** elopez has joined #openstack-neutron04:46
*** elopez is now known as Guest3193204:47
*** tonytan4ever has joined #openstack-neutron04:47
*** boden has quit IRC04:47
*** a_ta has quit IRC04:47
*** kevo has joined #openstack-neutron04:52
*** numans has joined #openstack-neutron04:53
*** banix has quit IRC04:54
*** elo has quit IRC04:56
*** elo has joined #openstack-neutron05:00
*** sindhu has quit IRC05:01
*** yfried has joined #openstack-neutron05:04
*** numans has quit IRC05:07
*** hynekm has joined #openstack-neutron05:10
*** pbandark has joined #openstack-neutron05:11
openstackgerritIrina proposed openstack/neutron-vpnaas: Adding tests for endpoint-group api.  https://review.openstack.org/33807505:15
*** yamamoto_ has joined #openstack-neutron05:15
*** imcsk8 has quit IRC05:17
*** imcsk8 has joined #openstack-neutron05:17
*** jhershbe has quit IRC05:19
*** amitkqed has quit IRC05:19
*** amitkqed has joined #openstack-neutron05:19
*** vikram has joined #openstack-neutron05:20
*** mohankumar has joined #openstack-neutron05:22
*** tflynn has quit IRC05:26
*** vthapar has joined #openstack-neutron05:29
openstackgerritMerged openstack/neutron: Update testing coverage document  https://review.openstack.org/29260705:29
*** shausy has joined #openstack-neutron05:31
*** yfried has quit IRC05:32
*** zhhuabj_ has quit IRC05:33
*** saggi has joined #openstack-neutron05:36
*** zhhuabj_ has joined #openstack-neutron05:36
*** Leo_ has joined #openstack-neutron05:36
*** saggi has quit IRC05:38
openstackgerritReedip proposed openstack/neutron: Add name and desc to networksegments table  https://review.openstack.org/29330505:40
*** mickeys has quit IRC05:40
*** Leo_ has quit IRC05:40
*** kawa2014 has joined #openstack-neutron05:42
*** mickeys has joined #openstack-neutron05:45
*** amotoki has joined #openstack-neutron05:46
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/neutron: [WIP] Testing latest u-c  https://review.openstack.org/30334605:49
*** mickeys has quit IRC05:49
*** pgadiya has joined #openstack-neutron05:50
*** Fdaisuke has joined #openstack-neutron05:52
*** mfuruta has quit IRC05:52
*** mfuruta has joined #openstack-neutron05:52
*** _Fdaisuke_ has quit IRC05:54
openstackgerritManjeet Singh Bhatia proposed openstack/neutron: Relocate L3 DB Models  https://review.openstack.org/34856205:54
*** sridharg has joined #openstack-neutron05:55
*** zhhuabj_ has quit IRC05:59
*** gouthamr has joined #openstack-neutron06:01
*** david-lyle has joined #openstack-neutron06:07
*** obondarev has joined #openstack-neutron06:08
*** gouthamr has quit IRC06:10
*** tidwellr has quit IRC06:13
*** tflynn has joined #openstack-neutron06:16
ajoping armax: I was thinking, now that I read your comments about bulk_push06:16
armaxajo: aye06:16
ajothat may be now we're still in time to change the subscriber callback function semantics06:16
ajoto receive always a list in all cases06:16
armaxajo: I have a local change06:16
ajowhen it's a push we pass [resource]06:16
ajoand when it's a bulk, we pass resource_list06:16
ajoso we don't have two cases06:16
armaxajo: let me post what I have06:17
ajoack06:17
armaxajo: then you can decide06:17
armaxajo: I think it can work as it is06:17
ajothank's armax06:17
armaxajo: but we can see what’s better06:17
armaxI won06:17
armaxI won’t be long06:17
armaxI just need to rebase06:17
armax347662 on top of yours06:17
armaxajo: I also solved the sanity check issue06:18
ajoack, I need to sort out the kids and do some bureaucracy this morning :/06:18
armaxajo: actually I got rid of it altogether and solved the compat diffently :)06:18
ajo:)06:18
armaxajo: good luck! :)06:18
armaxajo: if Spanish bureucracy is like the Italian's06:18
armaxajo: you’re in trouble06:18
*** zhhuabj_ has joined #openstack-neutron06:19
ajothanks :s, probably similar... at least they're no completely tracked and part of their salary comes from goals (forms/steps processed)06:19
ajono->now06:20
armaxajo: that’s a bit step forward06:20
ajometrics help :)06:20
armaxajo: can’t improve what you can’t measure!06:20
*** shausy has quit IRC06:20
ajoarmax, I'll look at it all together when I'm back, and I'll also look at the payload sizes, etc06:21
armaxajo: ack06:21
ajowhich I wanted to do yesterday and I didn't have enough time06:21
armaxI’ll push this in the next 10 mins06:21
armaxthen I am going to bed06:21
armaxI’ll catch up with you in a few hours06:21
ajoarmax, yeah, rest is necessary06:21
armaxajo: indeed it is06:21
armaxajo: but this stuff is addictive!06:21
armaxajo: weird type of drug, let me tell you that!06:22
ajohehehe, I know what you mean ;)06:22
openstackgerritKevin Benton proposed openstack/neutron: Change external_network_bridge default to ''  https://review.openstack.org/29844306:26
openstackgerritArmando Migliaccio proposed openstack/neutron: Add RPC layer for Trunk Plugin and initial Open vSwitch driver  https://review.openstack.org/34766206:27
armaxajo: ^ check it out and let me know what you reckon!06:27
ajoarmax, ack :)06:27
ajohttps://review.openstack.org/#/c/347662/8/neutron/api/rpc/callbacks/resources.py  ahhh, I see06:28
ajothat could definitely work06:28
ajoI'll think of the possibilities06:28
ajoI need to afk now, but will get back to it in now+1.5h or so06:29
*** jhershbe has joined #openstack-neutron06:29
*** Leo_ has joined #openstack-neutron06:30
*** tonytan4ever has quit IRC06:30
*** tflynn has quit IRC06:32
*** mickeys has joined #openstack-neutron06:34
*** kevo has quit IRC06:34
*** Leo_ has quit IRC06:34
*** mickeys has quit IRC06:34
*** jhershbe has quit IRC06:36
*** armax has quit IRC06:36
*** numans has joined #openstack-neutron06:36
*** tesseract- has joined #openstack-neutron06:37
*** gvrangan has joined #openstack-neutron06:38
*** sticker_ has joined #openstack-neutron06:41
*** andymaier has joined #openstack-neutron06:41
*** gongysh has joined #openstack-neutron06:42
*** hoangcx has quit IRC06:42
openstackgerritKevin Benton proposed openstack/neutron: [DO NOT MERGE]: iptables diff canary  https://review.openstack.org/30133806:43
openstackgerritKevin Benton proposed openstack/neutron: Add option to validate iptables rules  https://review.openstack.org/34875306:43
*** sticker has quit IRC06:44
*** david-lyle has quit IRC06:45
*** pcaruana has joined #openstack-neutron06:45
*** obondarev has quit IRC06:47
openstackgerritLewis proposed openstack/neutron-vpnaas: Add connection API cases  https://review.openstack.org/33806106:48
*** sticker_ is now known as sticker06:49
*** manikanta_tadi has joined #openstack-neutron06:51
openstackgerritKevin Benton proposed openstack/neutron: [DO NOT MERGE]: test short tokens  https://review.openstack.org/30037106:52
*** matrohon has joined #openstack-neutron06:52
*** itisha has joined #openstack-neutron06:53
*** hoangcx has joined #openstack-neutron06:55
openstackgerritJohn Schwarz proposed openstack/neutron: Fix a race with auto_schedule of HA routers  https://review.openstack.org/28440006:55
*** namnh has quit IRC06:58
openstackgerritKevin Benton proposed openstack/neutron: Use revision to discard stale DHCP updates  https://review.openstack.org/30413606:58
*** Fdaisuke has quit IRC06:59
*** Fdaisuke has joined #openstack-neutron07:00
openstackgerritAndrey Shestakov proposed openstack/neutron: Consider baremetal device_owner as compute for nova notify  https://review.openstack.org/34682307:00
*** anilvenkata has joined #openstack-neutron07:02
*** zhenguo has joined #openstack-neutron07:04
openstackgerritManjeet Singh Bhatia proposed openstack/neutron: Relocate Metering DB models  https://review.openstack.org/34875707:07
*** nherciu has joined #openstack-neutron07:10
*** vijaykc4 has joined #openstack-neutron07:10
*** sticker has quit IRC07:12
*** vijaykc4 has quit IRC07:15
*** bvandewa has joined #openstack-neutron07:16
*** Fdaisuke has quit IRC07:17
*** Fdaisuke has joined #openstack-neutron07:17
*** vishwanathj has quit IRC07:21
*** davidlenwell has quit IRC07:22
*** Leo_ has joined #openstack-neutron07:24
*** rubasov has joined #openstack-neutron07:26
*** Leo_ has quit IRC07:28
*** matrohon has quit IRC07:29
*** tonytan4ever has joined #openstack-neutron07:31
*** davidlenwell has joined #openstack-neutron07:34
*** jlanoux has joined #openstack-neutron07:36
*** tonytan4ever has quit IRC07:36
*** zhhuabj_ has quit IRC07:36
*** zhhuabj_ has joined #openstack-neutron07:37
*** jlibosva has joined #openstack-neutron07:38
*** aqkhan has joined #openstack-neutron07:39
*** zhhuabj has joined #openstack-neutron07:41
*** mosulica has joined #openstack-neutron07:43
*** zhhuabj_ has quit IRC07:44
*** dkehn_ has quit IRC07:44
*** fzdarsky|afk has joined #openstack-neutron07:44
*** bvandewa has quit IRC07:45
*** dkehn has quit IRC07:45
*** hoangcx has quit IRC07:48
*** mohankumar has quit IRC07:49
*** kaisers has quit IRC07:50
*** hoangcx has joined #openstack-neutron07:50
*** obondarev has joined #openstack-neutron07:50
*** kaisers has joined #openstack-neutron07:51
openstackgerritKevin Benton proposed openstack/neutron: Use single priority for floating IP rules  https://review.openstack.org/31279007:52
kevinbentongaryk: hey, can you take a look at https://review.openstack.org/#/c/327996/ and weigh in?07:53
*** gongysh has quit IRC07:53
*** jhershbe has joined #openstack-neutron07:56
*** dkehn has joined #openstack-neutron07:56
*** namnh has joined #openstack-neutron07:57
*** dkehn_ has joined #openstack-neutron07:58
openstackgerritLIU Yulong proposed openstack/neutron: Resolve infinite loops in L3 HA agent side  https://review.openstack.org/26567207:58
*** zzzeek has quit IRC08:00
*** rossella_s has quit IRC08:00
*** johnbelamaric has quit IRC08:00
openstackgerritKevin Benton proposed openstack/neutron: Cleanup DB retry logic in ML2  https://review.openstack.org/33258608:00
*** rossella_s has joined #openstack-neutron08:00
*** johnbelamaric has joined #openstack-neutron08:00
*** zzzeek has joined #openstack-neutron08:00
*** gvrangan has quit IRC08:05
*** fragatina has quit IRC08:09
*** fzdarsky has joined #openstack-neutron08:11
*** fzdarsky|afk has quit IRC08:11
openstackgerritLewis proposed openstack/neutron-vpnaas: Add connection API cases  https://review.openstack.org/33806108:16
garykkevinbenton: there is an indentation and typo issue08:17
kevinbentongaryk: well it's a back-port08:17
kevinbentongaryk: should i fix there?08:17
kevinbentongaryk: we normally keep it the same08:17
garykkevinbenton: its a backport so no need to change them08:19
garykkevinbenton: i have given a +208:20
garykkevinbenton: approved08:21
*** jhershbe has quit IRC08:21
kevinbentongaryk: thx08:21
*** vijaykc4 has joined #openstack-neutron08:21
liuyulonggaryk, hi08:23
liuyulonggaryk, how about this patch https://review.openstack.org/#/c/265680/ now ? Kevin has also explained some detail in comments.08:23
garykgit a guy a finger and he takes the whole hand08:23
garykliuyulong: looks good.08:25
garykliuyulong: i prefer that a core who is more familiar with the HA approve08:25
liuyulonggaryk, thanks, that patch is staying there in a very long time, :)08:26
*** ygbo has joined #openstack-neutron08:26
*** tflynn has joined #openstack-neutron08:27
liuyulongjschwarz, hi, ping?08:29
*** yamamoto_ has quit IRC08:30
*** iyamahat has joined #openstack-neutron08:32
*** bvandewa has joined #openstack-neutron08:32
*** yamahata has joined #openstack-neutron08:37
*** wolverineav has joined #openstack-neutron08:38
*** iranzo has joined #openstack-neutron08:42
*** iranzo has joined #openstack-neutron08:42
*** iyamahat has quit IRC08:42
*** wolverineav has quit IRC08:43
*** iyamahat has joined #openstack-neutron08:44
*** shausy has joined #openstack-neutron08:45
*** davidsha has joined #openstack-neutron08:47
*** ramishra has quit IRC08:48
*** mohankumar has joined #openstack-neutron08:49
*** gongysh has joined #openstack-neutron08:50
*** wolverineav has joined #openstack-neutron08:50
*** jhershbe has joined #openstack-neutron08:52
*** abregman has joined #openstack-neutron08:52
*** iyamahat has quit IRC08:54
*** wolverineav has quit IRC08:55
apuimedogaryk: kevinbenton: we could use some merges in stable/mitaka for networking-midonet08:56
*** mickeys has joined #openstack-neutron08:56
kevinbentonapuimedo: links?08:56
*** mhickey has joined #openstack-neutron08:56
*** amotoki has quit IRC08:56
apuimedohttps://review.openstack.org/#/c/348789/08:57
apuimedohttps://review.openstack.org/#/q/status:open+project:openstack/networking-midonet+branch:stable/mitaka+topic:bug/159844908:57
*** mickeys has quit IRC08:58
*** mickeys has joined #openstack-neutron08:58
apuimedokevinbenton: garyk: ^^08:59
apuimedoafter getting these merged, pushing a new release tag would be ideal08:59
*** amotoki has joined #openstack-neutron09:00
*** wolverineav has joined #openstack-neutron09:02
*** mickeys has quit IRC09:03
*** zhhuabj has quit IRC09:03
*** zhhuabj has joined #openstack-neutron09:03
*** wolverineav has quit IRC09:06
*** matrohon has joined #openstack-neutron09:07
*** jhershbe has quit IRC09:08
*** kawa2014 has quit IRC09:08
openstackgerritLewis proposed openstack/neutron-vpnaas: Add connection API cases  https://review.openstack.org/33806109:11
*** yb has quit IRC09:11
*** Leo_ has joined #openstack-neutron09:12
*** kawa2014 has joined #openstack-neutron09:12
*** djan has quit IRC09:13
openstackgerritLujin Luo proposed openstack/neutron: Add a unique key to port_id in routerports table  https://review.openstack.org/28504809:14
*** Leo_ has quit IRC09:17
*** mfuruta has quit IRC09:21
*** ihrachys has joined #openstack-neutron09:21
*** jhershbe has joined #openstack-neutron09:23
*** wolverineav has joined #openstack-neutron09:24
*** ociuhandu has quit IRC09:25
*** bvandewa has quit IRC09:27
*** wolverineav has quit IRC09:28
openstackgerritJakub Libosvar proposed openstack/neutron: Fix that api_workers=0 doesn't spawn any api workers  https://review.openstack.org/34880109:30
*** tflynn has quit IRC09:31
apuimedojlibosva: good catch with the "not" -> "is None"09:32
apuimedo:-)09:32
apuimedojlibosva: is there some fullstack tests that checks that it actually works without api workers?09:33
jlibosvaapuimedo: :) I would be more glad if it will be actually tests that catch it09:33
jlibosvaapuimedo: nope09:33
*** permalac has joined #openstack-neutron09:33
apuimedo:(09:33
jlibosvaor not that I'm aware of09:34
*** john-davidge has joined #openstack-neutron09:34
openstackgerritKevin Benton proposed openstack/neutron: Add option to validate iptables rules  https://review.openstack.org/34875309:34
openstackgerritKevin Benton proposed openstack/neutron: [DO NOT MERGE]: iptables diff canary  https://review.openstack.org/30133809:34
openstackgerritKevin Benton proposed openstack/neutron: Set prefix on floating_ip_mangle rules  https://review.openstack.org/34880509:34
jlibosvaapuimedo: we use oslo library though for workers - so I guess it's fine to verify we call a correct parameter to the library09:35
*** john-dav_ has joined #openstack-neutron09:35
jlibosvas/call/pass/09:35
apuimedoI guess so09:36
*** john-davidge has quit IRC09:38
*** fragatina has joined #openstack-neutron09:38
openstackgerritJakub Libosvar proposed openstack/neutron: Fix that api_workers=0 doesn't spawn any api workers  https://review.openstack.org/34880109:38
*** moshele has joined #openstack-neutron09:38
openstackgerritJakub Libosvar proposed openstack/neutron: Fix that api_workers=0 doesn't spawn any api workers  https://review.openstack.org/34880109:40
*** zhhuabj has quit IRC09:41
*** moshele has quit IRC09:43
*** vijaykc4 has quit IRC09:44
*** wolverineav has joined #openstack-neutron09:47
*** abregman has quit IRC09:50
*** wolverineav has quit IRC09:52
*** vijaykc4 has joined #openstack-neutron09:52
*** wolverineav has joined #openstack-neutron09:55
jlibosvakevinbenton: hi, still awake? quick Q: is a subnet that belongs to external network with 'access_as_external' rbac action and '*' target_tenant supposed to be seen by all tenants?09:57
jlibosvafrom the code it seems we limit it to access_as_shared action only09:57
*** sambetts|afk is now known as sambetts09:58
jlibosvaihrachys or any rbac experts: ^^09:59
*** ociuhandu has joined #openstack-neutron09:59
*** ramishra has joined #openstack-neutron10:00
kevinbentonjlibosva: no10:01
kevinbentonjlibosva: i don't believe so10:01
kevinbentonjlibosva: which is why router-gateway-set takes a network instead of a subnet like the other router interface actions10:01
*** zhhuabj has joined #openstack-neutron10:02
kevinbentonjlibosva: even if you don't use rbac10:02
jlibosvakevinbenton: we have a bug report claiming shared subnets where seen in Mitaka10:02
jlibosvakevinbenton: https://bugs.launchpad.net/bugs/160753410:02
openstackLaunchpad bug 1607534 in neutron "Subnets not visible for admin tenant external network for non-admin user" [Medium,Confirmed]10:02
jlibosvakevinbenton: if that is true, do you know if we have that documented somewhere? I can close the bug then as invalid, right?10:03
kevinbentonjlibosva: ah, no. it may have been a regression10:03
kevinbentonjlibosva: let me see if i can confirm10:03
jlibosvakevinbenton: thanks10:03
liuyulongcloud anyone have a look at https://bugs.launchpad.net/neutron/+bug/1578523 and its fix https://review.openstack.org/#/c/312849/10:04
openstackLaunchpad bug 1578523 in neutron "Floating IP updating procedure is inaccurate" [Low,In progress] - Assigned to LIU Yulong (dragon889)10:04
*** wolverineav has quit IRC10:06
*** trananhkma has quit IRC10:08
*** diga has joined #openstack-neutron10:12
*** yamahata has quit IRC10:16
*** wolverineav has joined #openstack-neutron10:16
kevinbentonjlibosva: left a comment. marked as incomplete because this is the behavior in stable/liberty as well10:17
*** gongysh has quit IRC10:18
*** sdague has joined #openstack-neutron10:19
*** EinstCrazy has quit IRC10:19
*** namnh has quit IRC10:20
*** wolverineav has quit IRC10:20
*** liuyulong has quit IRC10:21
*** wolverineav has joined #openstack-neutron10:22
kevinbentonihrachys: yo10:27
kevinbentonihrachys: what do you think about this? https://review.openstack.org/#/c/298443/10:27
ihrachyskevinbenton: howdy!10:27
ihrachyslooking10:27
kevinbentonihrachys: slowly make it more painful for people refusing to move :)10:27
*** liuyulong has joined #openstack-neutron10:29
ihrachyskevinbenton: I am for the change. one dumb question since I am not too close to l3: so for those using flat external connectivity, no rewiring is generally needed?10:31
ihrachysis it only a matter of changing options and restarting the agent?10:31
openstackgerritgaryk proposed openstack/neutron: Add in missing translations for exceptions  https://review.openstack.org/33763010:31
kevinbentonihrachys: yes, in fact the agent may not even rewire then unless the namespace is cleaned up or gateway is re-attached10:32
kevinbentonihrachys: because i think it will see the interface already exists10:32
kevinbentonihrachys: but yeah, no change if external network is flat10:32
kevinbentonihrachys: because the ports will already be correctly bound to a segment10:32
*** kawa2014 has quit IRC10:33
kevinbentonihrachys: even though i claimed we would remove in Ocata, i would like to wait until we have a method of making ports attempt to rebind on other segments10:33
kevinbentonihrachys: so we have a migration path that is a little cleaner10:33
*** hoangcx has quit IRC10:33
ihrachyskevinbenton: is it possible to write a test that would validate this kind of migration? I want to make sure that the router still sees the port and does not attempt to wire another one. I think functional would do (?)10:34
kevinbentonihrachys: if it decides to rewire it would delete it10:34
*** hoangcx has joined #openstack-neutron10:34
kevinbentonihrachys: well i better check10:34
kevinbentonihrachys: the delete may include the bridge name10:34
ihrachyskevinbenton: yeah, you said 'I think' which is not 100% sure :)10:35
openstackgerritKengo Hobo proposed openstack/neutron-vpnaas: Add router_id to query when check subnet is used by vpnservice  https://review.openstack.org/34883510:35
kevinbentonihrachys: can't i just tell them to run the netns cleanup tool in between ? :)10:35
*** claudiub|2 has joined #openstack-neutron10:35
ihrachyskevinbenton: but I think we may still switch default, that validation would really be needed when we remove the rug completely from under operators?10:35
ihrachyskevinbenton: netns cleanup is data plane downtime.10:36
*** wolverineav has quit IRC10:36
*** john-dav_ is now known as john-davidge10:37
openstackgerritKevin Benton proposed openstack/neutron: Use single priority for floating IP rules  https://review.openstack.org/31279010:38
kevinbentonihrachys: https://github.com/openstack/neutron/blob/38d33363e3d5e1aea864259443379e0bcc9d9028/neutron/agent/linux/interface.py#L24710:39
*** moshele has joined #openstack-neutron10:39
ihrachyskevinbenton: we should also have it covered with non dvr grenade multinode.10:39
ihrachysbut a more granular check that backend have not done anything weird could still be of use. you decide if you think it's worth it.10:40
ihrachysI am ok to go as is. we may revisit validation later when we actually remove the option.10:40
kevinbentonihrachys: let me check something first10:41
kevinbentonihrachys: no, we likely won't be testing this with grenade unfortunately10:41
kevinbentonihrachys: http://logs.openstack.org/43/298443/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/5acdcca/logs/etc/neutron/l3_agent.ini.txt.gz10:41
kevinbentonihrachys: devstack plants that value in there10:42
kevinbentonihrachys: with extreme prejudice10:42
ihrachysah10:42
ihrachysdo we have it cleaned up in devstack master?10:42
kevinbentonihrachys: not yet10:42
kevinbentonihrachys: had to revert that10:42
kevinbentonihrachys: waiting for revert of the revert10:43
kevinbentonihrachys: so plop a -1 on my patch an make me write a functional test10:43
kevinbentonihrachys: i'll catch that tomorrow10:43
kevinbentonihrachys: https://review.openstack.org/#/c/346282/10:43
kevinbentonihrachys: i'm worried that we scared Sean away by breaking the gate :)10:43
ihrachyskevinbenton: :)10:44
ihrachyswe are still to land the first one anyway10:45
ihrachyskevinbenton: one question on sqla10:45
ihrachyskevinbenton: https://review.openstack.org/#/c/348279/3/neutron/objects/base.py10:46
ihrachyskevinbenton: see I needed to copy the model otherwise it seems like it always returned the same relationship on each access, even though more related models were pushed in the middle.10:46
ihrachyskevinbenton: I would hope that sqla would populate cached relationships with whatever related models are inserted, but it seems it's not the case (?)10:47
kevinbentonihrachys: example?10:47
kevinbentonihrachys: how are the related models being added?10:47
ihrachysjust by adding new related models to the session10:48
ihrachysI still need to poke it myself, but I was thinking, maybe you have some ready to read doc in mind to understand how sqla tracks models10:49
kevinbentonihrachys: nah, i've run into similar issues though with ports and ip addresses10:50
kevinbentonihrachys: like if you create an IPallocation with a port ID and just jam it in the database10:50
*** wolverineav has joined #openstack-neutron10:50
kevinbentonihrachys: an existing port in the session that has already had it's fixed_ips referenced will not see the update10:50
ihrachysI see. it's interesting that it really depends on me saving the reference to the model on the object. if I just comment out line 304, it all passes and properly loads eg routes thru the synthetic field for subnet.10:51
kevinbentonihrachys: hang on10:53
kevinbentonihrachys: i'm not sure i understand which model is breaking which object10:53
*** moshele has quit IRC10:53
kevinbentonihrachys: can you elaborate?10:53
ihrachyskevinbenton: see fe. failures in http://logs.openstack.org/79/348279/2/check/gate-neutron-python27-ubuntu-xenial/776a25d/testr_results.html.gz10:54
ihrachyskevinbenton: that was without copying10:54
*** wolverineav has quit IRC10:54
*** vsaienk0 has quit IRC10:55
*** tflynn has joined #openstack-neutron10:55
*** lujinluo has quit IRC10:56
kevinbentonihrachys: aye10:57
kevinbentonihrachys: holding onto the reference is preventing garbage collection10:57
kevinbentonihrachys: i suspect the result of copy.copy isn't know about by the session10:58
kevinbentonihrachys: and by having it still in the session it is using that cached stuff10:58
kevinbentonihrachys: https://github.com/openstack/neutron/blob/38d33363e3d5e1aea864259443379e0bcc9d9028/neutron/db/api.py#L119-L12410:58
kevinbentonihrachys: this is the root of all evils10:58
*** vsaienk0 has joined #openstack-neutron10:58
kevinbentonihrachys: expire_on_commit=False10:58
kevinbentonihrachys: can you see if you change expire_on_commit to true of that prevents the failures?10:59
ihrachyskevinbenton: it does!10:59
kevinbentonihrachys: http://docs.sqlalchemy.org/en/latest/orm/session_api.html#sqlalchemy.orm.session.Session.params.expire_on_commit10:59
kevinbentonihrachys: so that's the default from sqlalchemy11:00
kevinbentonihrachys: i've considered changing it for us11:00
kevinbentonihrachys: but i'm not sure why we went the other way with our default11:00
ihrachyskevinbenton: but them, do we have more sql statements issued on expire?11:00
*** Leo_ has joined #openstack-neutron11:00
kevinbentonihrachys: yes11:00
kevinbentonihrachys: expire will cause new lookups11:00
*** fragatina has quit IRC11:00
ihrachysso bad scaling wise11:00
ihrachyskevinbenton: problem is, if I copy, relationships do not reflect reality11:01
*** obondarev has quit IRC11:01
kevinbentonihrachys: yeah, they're stuck in time11:01
kevinbentonihrachys: because of this same reason11:01
kevinbentonihrachys: are the subobjects you are creating part of the same OVO object?11:02
ihrachyskevinbenton: is that because I open subtransations agressively in objects base create/update/....?11:02
*** tflynn has quit IRC11:02
ihrachyskevinbenton: they are, yes11:02
ihrachyswell, they are also their own objects11:02
kevinbentonihrachys: well i see one failure is Trunk/Subport11:02
ihrachysbut exposed thru list-of-objects fields too11:02
apuimedokevinbenton: do you think my "recheck" message to https://review.openstack.org/#/c/336801/ will re-trigger?11:02
ihrachysapuimedo: it will11:03
ihrachysapuimedo: but you may check zuul11:03
apuimedocool11:03
ihrachysapuimedo: anything that stats with 'recheck' will do11:03
apuimedothanks Ihar :-)11:03
ihrachys`8starts11:03
ihrachysmeh. fingers are so 90s, I need a brain-to-kbd interface11:03
*** vijaykc4 has quit IRC11:04
apuimedoihrachys: you can repurpose a son to scribe11:04
apuimedospecially on summer holidays11:04
*** Leo_ has quit IRC11:05
jlibosvakevinbenton: thanks11:06
kevinbentonihrachys: bleck. i need to revisit my notes from the ip allocation mess11:06
openstackgerritJohn Davidge proposed openstack/neutron: Enable CRUD for Subnet Service Types  https://review.openstack.org/33785111:07
*** vijaykc4 has joined #openstack-neutron11:07
*** hoangcx2 has joined #openstack-neutron11:09
kevinbentonihrachys: so one way i know does it for sure is when the new objects are constructed with a ref to the parent or by calling 'append' on the parent's relationship to the child11:10
kevinbentonihrachys: but that might be difficult to do when they are separate OVO objects11:10
*** hoangcx has quit IRC11:13
*** davidsha has quit IRC11:13
*** lucasagomes is now known as lucas-hungry11:14
*** rodrigods has quit IRC11:19
*** rodrigods has joined #openstack-neutron11:19
*** nlahouti has quit IRC11:20
*** rtheis has joined #openstack-neutron11:21
kevinbentonihrachys: whenever you build a dnsnameserver model. if you call 'print dns_db_obj.subnet' does that stop the failures?11:22
kevinbenton(for subnet at least)11:22
kevinbentonihrachys: that should cause it to look for the subnet in the existing session11:22
kevinbentonihrachys: so it would be interesting to see if it updates it when it finds it11:23
ihrachyskevinbenton: nope, it does not help. for some reason I get None then.11:28
ihrachyseven though subnet_id is passed11:28
*** ijw has joined #openstack-neutron11:28
*** jprovazn has joined #openstack-neutron11:29
ihrachysok, that shows up after I move it from under subtransaction11:29
ihrachysbut still does not solve the failure11:29
*** ijw has quit IRC11:30
*** ijw has joined #openstack-neutron11:31
*** tonytan4ever has joined #openstack-neutron11:32
*** abregman has joined #openstack-neutron11:32
kevinbentonihrachys: if you call session.expunge(self._db_obj...) on it does that stop the failure?11:33
kevinbentonihrachys: i'm worried that the db object will have stale data in that case still though...11:34
jlibosvakevinbenton: http://paste.openstack.org/show/543866/ - don't you need to set the network to shared?11:34
kevinbentonjlibosva: sure, but that wouldn't be what the bug report is about :)11:35
ihrachyskevinbenton: it makes the test fail with: http://paste.fedoraproject.org/397252/46979209/11:35
kevinbentonihrachys: wait, don't detach until the object has constructed itself11:35
jlibosvakevinbenton: how come? the regression might have come due to creating access_as_external in rbac11:36
kevinbentonjlibosva: what?11:36
kevinbentonjlibosva: the poster is complaining they can't see external subnets11:36
kevinbentonjlibosva: unless they are shared11:36
kevinbentonjlibosva: so i showed that you can't see external subnets if they aren't shared in stable/liberty11:36
kevinbentonjlibosva: which is what that paste is11:36
*** diga has quit IRC11:37
*** ijw has quit IRC11:37
kevinbentonihrachys: bleh, this isn't the right solution anyway, because an extension might reference a relationship and get that same error11:37
*** tonytan4ever has quit IRC11:37
ihrachyskevinbenton: huh. yeah, it fixes it. though the fix looks ugly atm11:38
jlibosvakevinbenton: aha, but in liberty, you had a way how to see shared subnets which now on master you don't.11:38
kevinbentonihrachys: we may just impose a performance penaltly on people using out of tree extensions and call session.expire on the object each time before returning it in @property11:38
jlibosvakevinbenton: anyway, you're the expert here, I just wanted to make sure the 'shared' isn't missing in the paste :) Thanks for explanation11:39
kevinbentonjlibosva: no, in master you can see shared subnets11:39
ihrachyskevinbenton: but then, do they need to maintain the transaction to reload relationships?11:39
kevinbentonihrachys: don't need a transaction for a relationship load, just a session11:40
jlibosvakevinbenton: those that belong to external network?11:40
kevinbentonjlibosva: yes11:40
kevinbentonihrachys: and the thing is attached to the session11:40
*** itisha has quit IRC11:40
*** thorst has joined #openstack-neutron11:40
kevinbentonihrachys: so just by nature of doing subnet.dnsnameservers or whatever, it will do the lookup11:40
ihrachyskevinbenton: the problem is that synthetic field loading depends on the relationship, not just users of exposed db_obj property. the former is broken by the caching, not the latter.11:41
ihrachyswell, maybe the latter too (like in: relationships are obsolete), but still11:41
kevinbentonihrachys: well if the object is expired, it has to do a db lookup anyway11:42
*** obondarev has joined #openstack-neutron11:42
kevinbentonihrachys: there won't be a stale object hanging around in the session11:42
jlibosvakevinbenton: aha, I see now.11:42
ihrachyskevinbenton: I may miss something. how does sqla refresh relationships without a transaction? from some internal lib cache, not from db server?11:42
kevinbentonihrachys: a session is a connection to a db11:42
kevinbentonihrachys: it can issue select queries without a transaction11:42
ihrachysok. but with no consistency guarantees.11:43
kevinbentonihrachys: that's why it would be a performance hit for them11:43
kevinbentonihrachys: right11:43
ihrachysso, save a copy, and expunge it on return?11:44
ihrachysI need to write some tests to validate that relationships are current, even if with a perf hit11:44
kevinbentonihrachys: i think just change the @property decorator to call expire on the object before returing it11:45
kevinbentonihrachys: not expunge11:45
*** lilintan has joined #openstack-neutron11:45
kevinbentonihrachys: expunge will give them something detached11:45
kevinbentonihrachys: which will be stale11:45
ihrachyskevinbenton: without copy, load_synthetic_... will see the model state as was when it was first time attached to an object11:46
kevinbentonihrachys: what do you mean?11:46
kevinbentonihrachys: it's stale?11:46
*** jhershbe has quit IRC11:47
ihrachyskevinbenton: the test does the following: create a subnet; create 3 dns servers; fetch subnet, which loads synthetic field for servers and is expected to load servers thru relationship; but the model that is returned from the sqla query for subnet does not contain servers probably because sqla returns the model we previously saved BEFORE servers were created. so the resulting subnet object misses servers on the field because11:48
ihrachys db_model.get('servers') returns []11:48
kevinbentonright, but calling expire on db_model should cause its attributes to be reloaded11:49
ihrachyskevinbenton: right. but the test does not trigger db_obj property, so if we just put it there, it won't fix the test. we should also copy to make consequent fetches return a new model with proper relationship list.11:50
*** obondarev has quit IRC11:50
*** wolverineav has joined #openstack-neutron11:51
kevinbentonihrachys: if we use copy.copy then all of the stuff is stale right?11:54
*** jhershbe has joined #openstack-neutron11:54
*** pradk has joined #openstack-neutron11:55
*** wolverineav has quit IRC11:55
*** liyifeng has quit IRC11:55
*** moshele has joined #openstack-neutron11:58
ihrachyskevinbenton: it's stale on the stored model only; but then the only place we'll use the stale model is in db_obj were we'll expire anyway, so it should not be an issue right?11:59
*** imcsk8 has quit IRC11:59
*** rossella_s has quit IRC11:59
*** rossella_s has joined #openstack-neutron12:00
kevinbentonihrachys: no, if it's a copy i don't think calling expire will work anymore12:01
kevinbentonihrachys: or did that work for you?12:02
ihrachyskevinbenton: I am writing a unit test to confirm12:02
kevinbentonihrachys: can you try one more thing for me. at the end of https://github.com/openstack/neutron/blob/master/neutron/objects/db/api.py#L25 put .populate_existing() at the end of it and then don't use copy.copy()12:03
kevinbentonihrachys: as i understand the docs http://docs.sqlalchemy.org/en/latest/orm/query.html#sqlalchemy.orm.query.Query.populate_existing12:03
kevinbentonihrachys: that should update existing ones in the session rather than pull from them12:03
kevinbentonihrachys: the issue is that getting by primary key makes it pull it out of the identity map and not even query the db12:04
ihrachyskevinbenton: you are right, copy results in sqlalchemy.exc.InvalidRequestError: Instance '<Trunk at 0x7fc950f48f00>' is not persistent within this Session12:04
kevinbentonihrachys: so i'm hoping populate_existing() will get you the latest from the db without breaking the db reference in the old one12:04
*** lenny__ has joined #openstack-neutron12:06
lenny__hi12:06
*** johnbelamaric has quit IRC12:06
ihrachyskevinbenton: yay12:07
ihrachyskevinbenton: at least it fixes the test12:07
ihrachyskevinbenton: now validating whether my NEW test for relationships on @db_obj to be current passes12:07
*** liyifeng has joined #openstack-neutron12:08
lenny__hi12:08
kevinbentonlenny__: hi12:08
lenny__how can i list the external ip adresses being used as external side on the gateway/router?12:08
*** wolverineav has joined #openstack-neutron12:09
kevinbentonlenny__: neutron router-show router-name12:09
kevinbentonlenny__: should have the gateway IP12:09
lenny__kevinbenton: thx for your feedback. there is no general list command (so i do not have to create a loop) like floatingip-list?12:10
kevinbentonlenny__: are you an admin?12:11
lenny__yes12:11
kevinbentonlenny__: if so, you can just list all of the ports on the external network12:11
kevinbentonlenny__: neutron port-list --network-id=external_net_id12:11
lenny__kevinbenton: cool! :) thx12:11
*** vijaykc4 has quit IRC12:12
kevinbentonlenny__: you can add other columns to make it easy to see which routers they belong to12:12
kevinbentonlenny__: neutron port-list --network-id=external_net_id -c id -c fixed_ips -c device_id -c device_owner12:12
kevinbentondevice_id is the id of the router12:13
*** vijaykc4 has joined #openstack-neutron12:14
lenny__kevinbenton: cool, good tip, works a a charm :)12:14
lenny__kevinbenton: thx! this is really appreciated12:14
kevinbentonlenny__: oh, you can also just list all routers as an admin as well12:14
ihrachyskevinbenton: ok, it seems to pass too. I have a single failure for qos policy to solve, but since it handles its rules field in a custom way, that's understandable.12:14
kevinbentonlenny__: neutron router-list -c id -c external_gateway_info12:14
kevinbentonlenny__: that will give you list of ids with IPs12:14
ihrachyskevinbenton: thanks a lot for pointers, I will upload a new revision once the test is fixed12:14
kevinbentonihrachys: yeah, i suspect you should also add that statement to the get_objects query as well12:15
*** boden has joined #openstack-neutron12:15
kevinbentonihrachys: because if it finds primary keys in a result in the identity map, it uses the version in the identity map12:15
kevinbentonihrachys: http://docs.sqlalchemy.org/en/latest/orm/session_basics.html#is-the-session-a-cache12:15
*** boden has quit IRC12:16
*** ijw has joined #openstack-neutron12:16
*** itisha has joined #openstack-neutron12:16
*** boden has joined #openstack-neutron12:16
*** boden has quit IRC12:16
*** jhershbe has quit IRC12:16
*** mohankumar has quit IRC12:18
lenny__kevinbenton: i will have a detailed look, thx again12:18
kevinbentonlenny__: no prob12:18
*** boden has joined #openstack-neutron12:19
ihrachyskevinbenton: right. in _get_collection, it's a tad harder because I don't have query available right away.12:19
*** wolverineav has quit IRC12:20
kevinbentonihrachys: frankly i think this probably belongs in our general query builder12:20
*** lucas-hungry is now known as lucasagomes12:20
kevinbentonihrachys: we've fought this issue before12:20
kevinbentonihrachys: grep for context.session.expire in the code12:21
kevinbentonihrachys: each one of those was likely associated with tears12:21
ihrachys:)12:21
ihrachyskevinbenton: do you suggest we kill all of them and apply populate_existing in common_db_mixin globally?12:21
kevinbentonihrachys: yes12:22
ihrachysfine with me. I will craft something. any specific tests we would need to run/write for the change?12:22
kevinbentonihrachys: actually just fix it for OVO for now if you can12:23
kevinbentonihrachys: i want to do some more experimenting12:23
ihrachysfine with me. I will leave a TODO there to get back to it.12:23
kevinbentonihrachys: sounds good12:24
kevinbentonihrachys: keep an eye for wonky gate failures after this merges https://review.openstack.org/#/c/303966/12:25
kevinbentonihrachys: it's going to peel back the curtain on stuff that we were pretending was atomic but wasn't :)12:26
*** moshele has quit IRC12:29
*** wolverineav has joined #openstack-neutron12:37
*** obondarev has joined #openstack-neutron12:41
*** wolverineav has quit IRC12:41
*** tpsilva has joined #openstack-neutron12:42
*** sindhu has joined #openstack-neutron12:44
*** kawa2014 has joined #openstack-neutron12:45
*** vijaykc4 has quit IRC12:46
*** ijw has quit IRC12:47
*** wolverineav has joined #openstack-neutron12:48
*** ijw has joined #openstack-neutron12:48
*** Leo_ has joined #openstack-neutron12:48
*** vijaykc4 has joined #openstack-neutron12:49
*** liyifeng has quit IRC12:52
*** wolverineav has quit IRC12:52
*** kawa2014 has quit IRC12:52
*** Leo_ has quit IRC12:53
*** edmondsw has joined #openstack-neutron12:54
*** amuller has joined #openstack-neutron12:55
*** sean-k-mooney has quit IRC12:59
*** pradk has quit IRC13:02
*** zkassab has joined #openstack-neutron13:03
*** manikanta_tadi has quit IRC13:04
*** tonytan4ever has joined #openstack-neutron13:04
*** links has quit IRC13:07
*** numans has quit IRC13:07
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Introduce bulk_push to rpc callback mechanism  https://review.openstack.org/34847613:07
*** tonytan4ever has quit IRC13:08
john-davidgecarl_baldwin: haleyb: Hey guys, I've updated the subnet service types patch this morning https://review.openstack.org/#/c/33785113:09
*** ianw has quit IRC13:10
*** ianw has joined #openstack-neutron13:10
*** vijaykc4 has quit IRC13:10
*** ijw has quit IRC13:10
*** numans has joined #openstack-neutron13:10
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Introduce bulk push to rpc callback mechanism  https://review.openstack.org/34847613:11
*** moshele has joined #openstack-neutron13:12
*** lilintan has quit IRC13:13
openstackgerritIhar Hrachyshka proposed openstack/neutron: objects: expose database model for NeutronDbObject instances  https://review.openstack.org/34827913:13
ajojlibosva, I posted a newer version ^ :)13:13
ihrachyskevinbenton: woohoo that should fix the problem ^13:13
jlibosvaajo: saw, good one :)13:13
jlibosvaajo: is it still a wip?13:14
ajojlibosva, not WIP now, I became serious about it :)13:14
ajoit's better to do it now that it's only used for one object, and only in-tree13:14
ajo:)13:14
jlibosvaajo: you have some todos there, those are ment for follow-ups?13:14
ajojlibosva, 4 are for otaka, and I'm handlink the ValueError thing now13:15
ajohandling13:15
ajo(I forgot that one)13:15
ajobut feel free to check that what I'm writing makes sense,13:15
*** gouthamr has joined #openstack-neutron13:18
*** boden has quit IRC13:20
*** wolverineav has joined #openstack-neutron13:20
*** buttercup has quit IRC13:21
*** cleong has joined #openstack-neutron13:22
jlibosvaajo: some comments, I'm not sure about the backward compatibility13:24
ihrachysajo: some comments from me too13:24
jlibosvaajo: I also think, we should somehow document that for other parties using callback mechanisms13:24
ihrachysI have concerns about compat13:24
ajonobody else uses it yet13:24
jlibosvanow it's two of us with concerns13:25
ajoconcerners!13:25
ajojlibosva, the callbacks mechanism is filtered so only QoSPolicies could be exposed over13:25
ajo(and that we exactly knew what was exposed), so far it's the only accepted resource to be pushed13:26
ajoso that scopes it all to qos13:26
*** vijaykc4 has joined #openstack-neutron13:26
jlibosvaajo: so you're saying there is no other project that is crazy enough to use this beautiful feature?13:26
*** wolverineav has quit IRC13:27
ajoconsidering no out of tree consumers of raw rpc callbacks, it should be fine, or if there is any undocumented one, the problem is non existing, since, we honour the old interface of having "resource" instead of resource_list for single items13:27
ajojlibosva, we filtered the objects to have some control about what was being exposed over the wire with this :)13:27
* ajo looks for the code13:27
jlibosvaajo: I'm talking about other projects in the stadium for example13:28
*** moshele has quit IRC13:28
ajoI know OVN attempted that, and rolled back so they now use the qos notification driver13:28
ajoand same thing for nsx13:28
*** wolverineav has joined #openstack-neutron13:29
ajojlibosva, didn't we have a code search thingy in openstack?13:29
ajowe could use that to verify13:29
jlibosvawe do13:29
russellbhttp://codesearch.openstack.org/13:29
jlibosvaajo: amuller knows13:29
jlibosvaalso russellb knows :)13:30
jlibosvathanks13:30
openstackgerritKevin Benton proposed openstack/neutron: Change external_network_bridge default to ''  https://review.openstack.org/29844313:30
amullerthat's my favorite website :)13:30
ajoanyway, the scope of the danger is tiny, if broken, they change the callback to iterate over a list13:30
russellbi irc highlight on "OVN" heh13:30
ajoamuller, russellb if it had code xrefs links that'd be just plain amazing13:30
ajoahh nsx http://codesearch.openstack.org/?q=neutron.api.rpc.callback&i=nope&files=&repos=13:31
ajogaryk,  ^13:31
*** andymaier has quit IRC13:32
ajook, nsx would have to patch this: http://git.openstack.org/cgit/openstack/vmware-nsx/tree/vmware_nsx/services/qos/nsx_v3/utils.py#n3413:32
ajoand that's it13:32
ajothe damage is controlled, and we don't twist the code too much.13:33
jlibosvaajo: I think if we will be more paranoid about the push parameters and make it generic, it wouldn't hurt13:33
jlibosvamaybe I'm too paranoid13:33
*** wolverineav has quit IRC13:33
ajojlibosva, what do you mean exactly?13:33
*** wolverineav has joined #openstack-neutron13:34
ajoamuller, , russellb agreed, codesearch is cool :D13:34
jlibosvaajo: like introduce resource parameter that defaults to None, resource_list also defaults to None, and check that resource_list is a list type.13:34
jlibosvaajo: if resouce is used or resource_list is not a list type, it's someone that is using old code13:34
ajojlibosva, yup, that's another option13:35
ajoI had a little ihrachys in my head telling me that lots of =None parameters in functions are hated13:35
ajo:D13:35
ajolol13:35
ajo:)13:35
jlibosva:D13:35
ajoalso **kwargs isn't the nicest thing, but ok :)13:35
jlibosvaajo: yeah, I think the bad thing is that you'll need to set all other parameters with default values :D13:36
ajoah, like when calling the function with just the list of params, and no param names13:36
russellbfun codesearch game ... come up with a regex that finds all cases of an obvious bug / anti-pattern13:36
ihrachysajo: I don't follow why not adding a new method and retiring the old one13:36
ajoihrachys, that's a very good strategy when you have a lot of API users, and want to do a deprecation cycle13:37
ajoihrachys, but if your external user is just one, and this is not neutron_lib but a neutron internal...13:38
*** sridharg has quit IRC13:38
ihrachysI don't buy it, sorry. we released a thing, we are supposed to maintain it.13:38
*** tflynn has joined #openstack-neutron13:38
ajoI think it's acceptable to tradeoff for a tiny breackage13:38
ihrachysanyhow, you break old agents, even in tree13:38
*** wolverineav has quit IRC13:38
ajoihrachys, no I don't13:38
ihrachysyou do. they will catch tracebacks.13:39
ajoor I think I don't may be I do, please explain :)13:39
ihrachysbecause their push method will fail to make sense of the payload13:39
ihrachysso for those 'new' messages, you will trigger logs errors. it's not like qos will be broken, but there are more facets of a 'breakage' than just 'crashes and burns'13:40
ajoihrachys, hmm, no13:40
ajoihrachys, no, because the scope of the push is per topic queue13:40
*** jamesdenton has joined #openstack-neutron13:40
ajoand the qos policy queue will only receive "resource" parameter13:40
ajosince we only push single items13:41
ajoand there's no plan to change that into lists13:41
ajoplan, or reason at all13:41
ajoso13:41
*** janzian has joined #openstack-neutron13:41
ajoon the neutron-object-qos_policy-<ver> topic, pushes will stay on the old "resource" parameter,13:41
openstackgerritKevin Benton proposed openstack/neutron: Use single priority for floating IP rules  https://review.openstack.org/31279013:42
ihrachys? you have a TODO to switch to resource_lists in O13:42
ajothen, in newton, the agents will understand also resource_list even if it's not used13:42
*** catintheroof has quit IRC13:42
ajoanyeah13:42
ajoand yeah13:42
*** Leo_ has joined #openstack-neutron13:42
ajoin otaka, we kill the if branch, and13:42
ajoall goes via resource_lists13:42
ajobecause agents on newton understand both13:42
ihrachyssec, digesting13:42
*** buttercup has joined #openstack-neutron13:42
ajoagents in otaka understand resource_list13:42
*** Leom has joined #openstack-neutron13:43
ajoyeah, I had to draw it a couple of times here to be sure,13:43
*** tflynn has quit IRC13:43
ihrachysok, I think I see where you go13:43
ajothe only constraint to this13:44
ajois that we won't start sending QoSPolicies pushes of more than one element during newton13:44
ajoand we won't13:44
openstackgerritHynek Mlnarik proposed openstack/neutron: Set secure fail mode for physical bridges  https://review.openstack.org/34888913:44
jlibosvahynekm: I love those unittests13:45
ihrachysajo: I think you are right, updated the patch with comments13:46
ihrachyslemme read tests thru13:46
ajoif we find strong reasons to do a full deprecation cycle, I'm ok to do that, but may be a breakage document, and syncing with garyk to see it's fine with nsx would avoid burning time.13:46
ajoihrachys, ack, thanks a lot for spending time trying to understand it :)13:46
ajobrb,13:47
*** Leo_ has quit IRC13:47
ihrachysajo: I am not completely clear what we do with versions. I think that for new messages, we should set version 1.113:47
ihrachysajo: and bump client versions to 1.1 so that they are ready to handle the messages.13:47
ajoihrachys, no, for server>agent direction we don't bump13:47
ajoor I'm missing something , we must review that13:48
ihrachysajo: why. we modified signature for some messages, so that would justify the bump, no?13:48
ajobut if we bump the server side to 1.1, agent stays 1.013:48
hynekmjlibosva, it's wonderful to become able to make sense of them13:48
ajowe upgrade server...13:48
ihrachysajo: only for new messages13:48
ajoserver is unable to call agent13:48
ihrachysajo: meaning, pass version=... to casr13:48
ihrachys*cast13:48
ajoahh13:48
ajotrue13:48
*** dansmith is now known as superdan13:49
ihrachysthen if there are for some reason some agents that listen on the new topic but don't specify the version of 1.1, they will have a nice log error instead of a traceback13:49
jlibosvahynekm: I'm also sure otherwiseguy will like those13:49
ihrachysI don't think it's too important, but makes the logic more clean.13:49
*** akshai has joined #openstack-neutron13:50
*** wolverineav has joined #openstack-neutron13:51
jlibosvahynekm: do you also plan to add the fullstack test we talked about yesterday? I think it should come with that patch13:53
*** moshele has joined #openstack-neutron13:54
*** obondarev has quit IRC13:54
hynekmjlibosva, it's already there - https://review.openstack.org/#/c/334926/ so I'd like it to be included once 348889 patch would get in13:54
*** pgadiya has quit IRC13:54
hynekmjlibosva, or you mean the one with blocking traffic for 15 secs?13:55
jlibosvahynekm: it doesn't cover the case where you don't restart agent13:55
jlibosvahynekm: yes, that one13:55
*** jianghuaw has quit IRC13:55
*** jianghuaw has joined #openstack-neutron13:56
*** edmondsw has quit IRC13:56
hynekmyes, that one will be added, I'll create it on Monday13:56
hynekmjlibosva, ^13:56
*** nlahouti has joined #openstack-neutron13:56
jlibosvahynekm: acknowledged, you gonna mark it as WIP?13:57
hynekmjlibosva, either that or a separate patch, I'd prefer the latter but don't mind the former too13:57
*** amotoki has quit IRC13:58
jlibosvahynekm: I think it makes sense to have it altogether as it shows it actually fixes the issue13:58
hynekmjlibosva, ack13:59
*** pradk has joined #openstack-neutron14:00
ihrachysajo: ok, more comments. you miss some pieces of the puzzle, like updating rpc callbacks subscribers in tree.14:00
*** claudiub|2 has quit IRC14:01
*** zengine has joined #openstack-neutron14:03
*** wolverineav has quit IRC14:04
*** zengine has quit IRC14:04
*** sridharg has joined #openstack-neutron14:04
*** lenny__ has quit IRC14:05
*** akshai has quit IRC14:06
ajoihrachys, I thought I had updated those14:07
*** akshai has joined #openstack-neutron14:07
ajobut let's see what I missed..14:07
*** yb has joined #openstack-neutron14:07
*** a_ta has joined #openstack-neutron14:07
ihrachysajo: you touched server side only14:07
ajohmmm, ahaa14:08
*** wolverineav has joined #openstack-neutron14:08
ajoihrachys, about batching by resource type, I'd leave that to a later patch if necessary, I thought of that, but I wanted the thing to be atomic, I mean, if you send the pack, you expect the same thing at the other side...14:08
ajoif you break in batches, the callbacks get something different14:08
ajobut14:08
*** obondarev has joined #openstack-neutron14:09
ajomay be at some point we may need to batch big lists if necessary for payload size?14:09
ihrachysit should not be hard to test, I suppose.14:09
ihrachysajo: that could be useful so that plugins could populate a storage with objects, then flush all of them at the very end.14:09
ajohmm14:10
ajoyes14:10
ihrachysajo: then you could trigger notify right from a transaction.14:10
*** nlahouti has quit IRC14:10
ajothat usage pattern would be very neat in fact14:10
ajoihrachys, can I iterate a second patch for that?14:10
ihrachysyou mean on top?14:10
ajoI don't want to make this one too complicated14:11
ihrachyswhy? you still need to respin14:11
ajoyup14:11
ihrachysit shouldn't be hard14:11
ajook, let me try14:11
ajo:)14:11
ihrachys:)14:11
*** wolverineav has quit IRC14:13
amullerajo: I may have missed the conversation, but about https://review.openstack.org/#/c/348889/14:13
amullerajo: didn't you set the fail mode to a different value in the past? it was about broadcast storms?14:13
ajoamuller, yes, I did, but we had it only for br-int and br-tun14:14
*** vijaykc4 has quit IRC14:14
ajobr-tun was the responsible for generating the broadcast storms14:14
ajoI think all the br-tuns in diferent hypervisors14:14
amullerajo: what value did you set it to?14:14
ajostarted broadcasting to each other any multicast/broadcast packet14:14
ajoand boom14:14
ajosecure_mode=True14:14
ajothat's it :)14:14
*** sridharg has quit IRC14:15
ajoamuller, but for br-tun it was on a reset_bridge14:15
ajoor something like that14:15
amullerajo: so now we'll be setting *all* bridges to secure=True14:15
ajoyes14:15
ajothat should be fine, we must verify that the br-<phys> tunnels don't relay on the default normal rule,14:15
ajoand if they do, we insert it14:16
*** b_bezak has joined #openstack-neutron14:16
ajohynekm,  ^14:16
ajodo we test provider networks?14:16
jlibosvaajo: you mean with br-exes?14:17
ajojlibosva, provider network bridges14:18
ajobr-eth1, br-eth0 br-whatever :)14:19
*** hynekm has quit IRC14:19
ajoI'd check that br-ex is treated equally14:19
*** tbachman has quit IRC14:19
openstackgerritIhar Hrachyshka proposed openstack/neutron: objects: expose database model for NeutronDbObject instances  https://review.openstack.org/34827914:20
ihrachysrossella_s: I hope ^ clarified14:20
rossella_sihrachys, it looks great, thanks!14:21
openstackgerritIhar Hrachyshka proposed openstack/neutron: objects: expose database model for NeutronDbObject instances  https://review.openstack.org/34827914:22
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron: Add QoS minimum bandwidth rule for instance egress traffic  https://review.openstack.org/34414514:22
ihrachysthere was a small pep8 glitch..14:23
*** johnbelamaric has joined #openstack-neutron14:23
ihrachysajo: where should I start review for qos? from the validation patch?14:23
ajo1 sec14:24
ajoihrachys, https://review.openstack.org/#/c/319694/14:24
ihrachysok, will do14:24
ajothanks ihrachys14:24
*** wolverineav has joined #openstack-neutron14:26
*** moshele has quit IRC14:26
openstackgerritSindhu Devale proposed openstack/neutron: Refactoring agent linux&ovsdb config  https://review.openstack.org/34786714:26
*** yb has quit IRC14:28
*** banix has joined #openstack-neutron14:31
*** sindhu has quit IRC14:31
openstackgerritRichard Theis proposed openstack/neutron: Fix L3 NAT DB signature mismatch  https://review.openstack.org/34855814:31
*** sindhu has joined #openstack-neutron14:32
*** claudiub|2 has joined #openstack-neutron14:34
*** edmondsw has joined #openstack-neutron14:34
*** tonytan4ever has joined #openstack-neutron14:35
*** wolverineav has quit IRC14:35
*** wolverineav has joined #openstack-neutron14:37
*** zhhuabj has quit IRC14:40
*** shausy has quit IRC14:40
*** Guest31932 has quit IRC14:42
*** dane_leblanc has joined #openstack-neutron14:42
*** david-lyle has joined #openstack-neutron14:42
*** banix has quit IRC14:45
*** wolverineav has quit IRC14:45
*** david-lyle_ has joined #openstack-neutron14:46
*** david-lyle has quit IRC14:47
*** banix has joined #openstack-neutron14:47
*** david-lyle__ has joined #openstack-neutron14:48
*** vijaykc4 has joined #openstack-neutron14:51
*** zhhuabj has joined #openstack-neutron14:51
*** david-lyle_ has quit IRC14:52
*** vhoward has joined #openstack-neutron14:52
*** vijaykc4 has quit IRC14:54
*** mosulica has quit IRC14:56
*** wolverineav has joined #openstack-neutron14:57
*** pbandark has quit IRC14:57
*** jlibosva has quit IRC14:59
*** garyk has quit IRC15:01
*** b_bezak has quit IRC15:02
*** gvrangan has joined #openstack-neutron15:02
*** mhickey has quit IRC15:05
*** dasanind has joined #openstack-neutron15:07
*** banix has quit IRC15:07
*** pbandark has joined #openstack-neutron15:09
*** elopez has joined #openstack-neutron15:09
*** elopez is now known as Guest2136815:10
openstackgerritAradhana Singh proposed openstack/neutron: Refactoring config options for cmd  https://review.openstack.org/32304615:10
*** singhj has joined #openstack-neutron15:10
*** jistr is now known as jistr|call15:10
*** wolverineav has quit IRC15:12
*** armax has joined #openstack-neutron15:12
*** mickeys has joined #openstack-neutron15:16
*** jistr|call is now known as jistr15:17
*** vikram has quit IRC15:20
*** david-lyle has joined #openstack-neutron15:23
*** david-lyle__ has quit IRC15:23
*** wolverineav has joined #openstack-neutron15:24
*** dasanind has quit IRC15:25
*** dasanind has joined #openstack-neutron15:25
*** tflynn has joined #openstack-neutron15:26
*** wolverineav has quit IRC15:29
*** ijw has joined #openstack-neutron15:30
*** tflynn has quit IRC15:31
*** mlavalle has joined #openstack-neutron15:32
*** mlavalle has quit IRC15:32
*** marst has quit IRC15:33
*** mlavalle has joined #openstack-neutron15:33
*** vthapar has quit IRC15:34
*** yamamoto has joined #openstack-neutron15:34
*** jckasper has quit IRC15:35
*** mlavalle has quit IRC15:35
*** zhhuabj has quit IRC15:36
*** jckasper has joined #openstack-neutron15:36
*** jlanoux has quit IRC15:36
*** jckasper has quit IRC15:36
openstackgerritRichard Theis proposed openstack/neutron: Support callbacks for L3 plugins without an agent  https://review.openstack.org/34893315:37
*** wolverineav has joined #openstack-neutron15:37
*** chandankumar has quit IRC15:38
*** mlavalle has joined #openstack-neutron15:38
*** zhhuabj has joined #openstack-neutron15:39
*** ijw has quit IRC15:40
openstackgerritJohn Davidge proposed openstack/neutron: Enable CRUD for Subnet Service Types  https://review.openstack.org/33785115:40
*** namnh has joined #openstack-neutron15:43
ihrachysajo: ok posted some comments for the validation patch. I think we should tild design somewhat.15:43
ajowhat do you mean by tild?15:44
ajothanks for the review btw15:44
ajowill check as soon as I push another "push" :)15:44
haleybjohn-davidge: i'm glad i'm slow and didn't get to PS13 :)  I'll take a look and rebase the osc patch15:44
*** wolverineav has quit IRC15:45
ajoihrachys,  ^15:45
*** boden has joined #openstack-neutron15:45
ihrachysajo: sorry, tilt15:46
john-davidgehaleyb: :)15:46
*** jckasper has joined #openstack-neutron15:46
ajoihrachys, ack, I'll check it out :)15:46
*** jckasper has quit IRC15:46
haleybjohn-davidge: thanks for keeping it updated btw15:47
ajoihrachys, I disagree about the notification driver, in 1st place, it shouldn't be called notification driver, but qos_driver :/15:47
john-davidgehaleyb: Although since it's a cross-project dependency, does it actually need rebasing? Perhaps it only needs a recheck?15:47
ajothere's where confusion comes from :/15:47
ajoin the current model, where qos service calls "the backend" using notification_driver, it's just a qos_driver (service side)15:48
ihrachysajo: in the end, your core plugin is supposed to know what to do with ports, that's why it should own the validation.15:48
*** liuyulong has quit IRC15:48
ajoihrachys, yeah, that makes sense15:48
ajoI'll read your comments and let it settle through the weekend ;)15:48
ihrachyssure15:48
ajofirst, pushing push :]15:48
haleybjohn-davidge: it needs an update i think anyways, but i do see some jenkins complaint15:49
*** wolverineav has joined #openstack-neutron15:49
*** liuyulong has joined #openstack-neutron15:50
ajoihrachys, allowing mixed objects was easy to implement, PITA to test :P15:50
ajo:)15:50
john-davidgehaleyb: I think that was from when the patch was in merge conflict, but I could be wrong15:50
*** gvrangan has quit IRC15:50
ajoihrachys, still on it, good part is that test implementation is cleaning up the test code to group common stuff15:51
*** marst has joined #openstack-neutron15:52
*** janzian has quit IRC15:52
*** Guest21368 has quit IRC15:55
*** jckasper has joined #openstack-neutron15:56
*** wolverineav has quit IRC15:57
*** vishwanathj has joined #openstack-neutron15:57
openstackgerritMerged openstack/neutron: Increment revision numbers on object changes  https://review.openstack.org/30396615:58
*** dasanind has quit IRC15:58
ihrachyskevinbenton: ^ bring on the apocalypse!15:59
*** sdague has quit IRC15:59
*** rossella_s has quit IRC15:59
ihrachysarmax: ^ you should be aware of the patch landed. it may reveal some unknown issues in the code, we'll see how gate behaves16:00
*** rossella_s has joined #openstack-neutron16:00
*** nlahouti has joined #openstack-neutron16:00
*** pcaruana has quit IRC16:01
*** john-davidge has quit IRC16:01
*** wolverineav has joined #openstack-neutron16:02
*** john-davidge has joined #openstack-neutron16:02
openstackgerritMerged openstack/neutron-vpnaas: Updated from global requirements  https://review.openstack.org/34864816:03
openstackgerritSergey Belous proposed openstack/neutron-specs: Extend Quota API to report usage statistics  https://review.openstack.org/34894716:03
openstackgerritMerged openstack/neutron-vpnaas: Fix API Tests  https://review.openstack.org/33583816:03
*** nlahouti1 has joined #openstack-neutron16:03
*** pbandark has quit IRC16:05
*** nlahouti has quit IRC16:05
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: DVR: Clean stale snat-ns by checking its existence when agent restarts  https://review.openstack.org/32672916:08
openstackgerritMerged openstack/neutron: Remove deprecated network_device_mtu option  https://review.openstack.org/34295816:09
ihrachyssc68cal: kevinbenton: Sam-I-Am: ^ die witch die16:09
*** janzian has joined #openstack-neutron16:09
sc68calWoooo!!!!16:09
*** wolverineav has quit IRC16:12
*** numans has quit IRC16:12
*** bvandewa has joined #openstack-neutron16:14
*** bvandewa has quit IRC16:15
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Introduce bulk push to rpc callback mechanism  https://review.openstack.org/34847616:16
*** chandankumar has joined #openstack-neutron16:16
*** wolverineav has joined #openstack-neutron16:17
*** ygbo has quit IRC16:17
ajoihrachys,  ^ there it is16:18
*** dasanind has joined #openstack-neutron16:21
openstackgerritMerged openstack/neutron: Don't use exponential back-off for report_state  https://review.openstack.org/34770816:21
Sam-I-Amsc68cal: woohoo16:23
openstackgerritCarl Baldwin proposed openstack/neutron: WIP Tickle a problem with rollback trying to reuse the session  https://review.openstack.org/34895616:23
*** namnh has quit IRC16:24
*** wolverineav has quit IRC16:25
openstackgerritSreekumar S proposed openstack/neutron: Fix for Cookie Bridge not applying ext cookie to flow ops  https://review.openstack.org/32663716:26
*** Leom has quit IRC16:26
*** sambetts is now known as sambetts|afk16:27
*** wolverineav has joined #openstack-neutron16:27
*** jckasper has quit IRC16:27
*** jckasper has joined #openstack-neutron16:28
*** jckasper has quit IRC16:29
*** tesseract- has quit IRC16:30
*** eezhova has quit IRC16:30
*** permalac has quit IRC16:31
armaxihrachys: which one?16:31
armaxhttps://review.openstack.org/#/c/303966/?16:31
ihrachysarmax: the one that bumps revision numbers16:31
ihrachysyes, that one16:31
armaxihrachys: we’ll get kevinbenton to fix any issue16:31
ihrachyswe'll do!16:31
ihrachys:)16:31
ajoarmax, so 4096 subports serialized are 1255751 bytes (1.2MB)16:32
ajobig chunk of RPC, yes16:32
*** jamielennox|away is now known as jamielennox16:32
armaxajo: still manaageable though16:32
armaxajo: don’t you reckon?16:32
ajoyes, not super crazy, but it feels like it takes >10secs to handle it, let me check time16:33
ajoor may be it's because creation...16:33
ajolet's pdb16:33
ajoI hope rabbitmq doesn't handle fanouts by copying stuff into different queues instead of keeping some internal reference,16:34
ajo:)16:34
ajothat'd be 1.2MB * number of agents (boom) :)16:34
*** kobis has quit IRC16:35
armaxajo: I am sure we would have found out about this by now!16:35
ajoarmax, they better did :D16:36
armaxajo: so are you gonna respin to expect list of heterogeneous objects?16:36
ajoarmax, it's done already :)16:36
*** wolverineav has quit IRC16:36
ajotests got a bit more complicated than the code to do it (which was trivial), but test code is sightly cleaner now too16:36
*** wolverineav has joined #openstack-neutron16:37
*** wolverineav has quit IRC16:37
armaxajo: I am not sure I get it though16:37
openstackgerritRichard Theis proposed openstack/neutron: Support callbacks for L3 plugins without an agent  https://review.openstack.org/34893316:37
ajonah, db fetch and serialization of the chunk is very tiny <2s in my system16:37
*** iyamahat has joined #openstack-neutron16:37
armaxif the list is heterogeneous, what is the resource do we subscribe to?16:38
*** wolverineav has joined #openstack-neutron16:38
*** wolverineav has quit IRC16:38
ajoarmax, all of the possible objects16:38
ihrachysajo: -1 but nothing critical, please take a look16:38
*** wolverineav has joined #openstack-neutron16:38
ajoarmax, as they go in different queue topics, they need to be sent per-type16:38
*** wolverineav has quit IRC16:39
ajoin different underlying push calls16:39
ajoihrachys,  ^16:39
ajothanks ihrachys16:39
ajoreading16:39
*** wolverineav has joined #openstack-neutron16:39
*** wolverineav has quit IRC16:39
ajothe non-heterogenous thing is a YAGNI, but ihrachys thinks could be valuable soon16:39
*** jckasper has joined #openstack-neutron16:39
ihrachysarmax: from server perspective, we don't care if there are subscribers at all. we just push crap on the wire.16:39
*** wolverineav has joined #openstack-neutron16:39
armaxajo: ok16:39
armaxihrachys: I don’t disagree16:40
*** wolverineav has quit IRC16:40
armaxihrachys: from a consumer point of view16:40
*** wolverineav has joined #openstack-neutron16:40
*** wolverineav has quit IRC16:40
ihrachysarmax: I still owe you an etherpad update. oh boy.16:40
ihrachyson it16:40
armaxihrachys: I think the resulting rpc callback registry API may not be super intuitive16:40
ajoarmax, yes, you lose the atomicity of the list :/16:40
*** wolverineav has joined #openstack-neutron16:40
armaxah16:40
ajoI guess it can be reasonable as soon as we document it16:40
*** lucasagomes is now known as lucas-dinner16:41
*** wolverineav has quit IRC16:41
*** wolverineav has joined #openstack-neutron16:41
*** wolverineav has quit IRC16:41
armaxajo: right, so what does a callback have to do to receive an heterogenous list?16:41
ihrachysarmax: it won't16:41
ajoarmax, it wont16:41
ajoimagine you have resource A and B16:41
*** wolverineav has joined #openstack-neutron16:41
ihrachysarmax: it will always get the chunk that it cares16:41
*** wolverineav has quit IRC16:42
ihrachysif it wants both, it subscribes to both and get it in separate chunks16:42
ajoand you push [A(id=1), A(id=2), B(id=1), A(id=3)]16:42
armaxihrachys: but a callaback must subscribe to receive stuff16:42
armaxno?16:42
*** wolverineav has joined #openstack-neutron16:42
*** wolverineav has quit IRC16:42
ajoyour agent is subscribed to A and B16:42
ajoit get's two callback calls16:42
ihrachysyes, it will pick and choose what it cares about16:42
armaxoh16:42
ajoone for A with [A(id=1), A(id=2), A(id=3)]16:42
armaxso the callback always see the chunk for a given type?16:42
*** wolverineav has joined #openstack-neutron16:42
ajoanother for B with [B(id=1)]16:42
*** wolverineav has quit IRC16:43
ihrachysso your server will eg be able to send both subports and trunks and maybe a flying saucer, and agents will receive just subports. along those lines.16:43
*** wolverineav has joined #openstack-neutron16:43
*** wolverineav has quit IRC16:43
ihrachysarmax: yes, it's just a sugar on server side to allow to call registry once instead of multiple times16:43
ajoarmax, yes, comes from the limitation of how we do things in the low level (one separate queue for resource type and resource version combination)16:43
*** wolverineav has joined #openstack-neutron16:43
armaxok so a bulky heternogenous push results into the receivers side into local bulky homogeneous pushes?16:43
ihrachysit could as well do N times where N is the number of resource types to update.16:43
*** wolverineav has quit IRC16:44
*** wolverineav has joined #openstack-neutron16:44
*** wolverineav has quit IRC16:44
ajoarmax, that's correct16:44
ihrachys+16:44
armaxajo: well. if you’re ok with this level of complexity I am not gonna judge :)16:44
*** wolverineav has joined #openstack-neutron16:44
*** wolverineav has quit IRC16:45
ajoYes, It's reasonable I think, the code complexity increase was very low16:45
*** wolverineav has joined #openstack-neutron16:45
*** wolverineav has quit IRC16:45
ihrachysin the future we could have a deferred transactional notifier that you could update from under transaction with objects, and when its __exit__ is triggered, we push it into registry in one call.16:45
armaxthe only reserve I have is the fact that this behavior is not clear from the registry API16:45
armaxthat’s all16:45
ihrachysajo: it was either that, or validation for the same type16:45
ajomost pain came from the tests, which were assuming a single resource type in mocks (FakeResource), now we have Fake, and Faker resources...16:45
armaxI can see that the code is only slightly more complex16:45
*** wolverineav has joined #openstack-neutron16:45
ihrachysarmax: we may want to describe it in more details in devref16:45
ihrachysajo: ^16:45
*** wolverineav has quit IRC16:45
ajoyes, I can do that, and also in the push docstring16:46
*** wolverineav has joined #openstack-neutron16:46
*** wolverineav has quit IRC16:46
armaxultimately the receiver would always see a bulky homogenous list16:46
ajoif all this sounds reasonable16:46
armaxbut what’s not clear though16:46
*** wolverineav has joined #openstack-neutron16:46
armaxis that the calls are a result of a single push from the producer side16:46
*** wolverineav has quit IRC16:47
armaxI think this may be potentially confusing16:47
*** wolverineav has joined #openstack-neutron16:47
*** wolverineav has quit IRC16:47
armaxso overall I can see how powerful this is16:47
armaxbut it’s a lot tricker to handle and understand16:47
armaxso I wonder whether it’s gonna backfire16:47
*** neiljerram has joined #openstack-neutron16:47
ajoarmax, I agree on that part16:47
*** wolverineav has joined #openstack-neutron16:47
openstackgerritRichard Theis proposed openstack/neutron: Support callbacks for L3 plugins without an agent  https://review.openstack.org/34893316:48
ajoI wonder if there's any value in having a separate function for homogeneous push, and heterogeneous , where we explain clearly the difference16:48
armaxajo: in other words from a receiver point of view it’s gonnab be trickier to understand where the push is coming from from the server side16:48
*** tonytan_brb has joined #openstack-neutron16:48
ajostill the heterogeneous could be confusing if you don't read the docstring or the devref16:48
armaxin there are multiple producer side emission points16:48
armaxif*16:49
armaxso in a nutshell I feel that the tool may be prone to misuse, now assumed you guys are not going anywhere…16:49
ajowell, I'm going to the swimming pool in 15 min :D16:50
armaxwe can keep it as is…if you were to be hit by the proverbial bus, I’d rather have a slightly less powerful but more usable tool16:50
*** moshele has joined #openstack-neutron16:50
ajoihrachys, armax I let you both choose , I'm happy with any of both options16:50
armaxthe notifier side is not afffected if we change the semantic16:50
*** wolverineav has quit IRC16:51
armaxsorry I mean the consumer16:51
openstackgerritSindhu Devale proposed openstack/neutron: Refactoring db config options  https://review.openstack.org/34487716:51
armaxthe producer one is16:51
*** wolverineav has joined #openstack-neutron16:51
*** wolverineav has quit IRC16:51
ajoyes, that's the only thing16:51
*** tonytan4ever has quit IRC16:51
ajothis patch introduced the semantic change on the receiver that it's always going to get a list on the callback16:51
ajoinstead of a single resource16:51
armaxbecause if we decide to complain about heterogenous lists the producer freaks out16:51
ajoit can be a single item list, or multiple16:51
*** wolverineav has joined #openstack-neutron16:51
armaxajo: right16:51
*** wolverineav has quit IRC16:52
*** wolverineav has joined #openstack-neutron16:52
*** wolverineav has quit IRC16:52
armaxperhaps we can make absolutely clear in the docs to use heterogenous list only if it is a really GOOD GOOD use case!16:52
*** wolverineav has joined #openstack-neutron16:52
*** wolverineav has quit IRC16:53
ihrachysI think it's just describing that as default, then having an 'advanced usage' below mentioning that this actually may also classify objects.16:53
*** wolverineav has joined #openstack-neutron16:53
*** wolverineav has quit IRC16:53
ajoihrachys, armax option 3 can be, leave push homogeneous, and provide a helper to split & send, so it's obvious to the caller16:53
*** elopez has joined #openstack-neutron16:53
*** sputnik13 has joined #openstack-neutron16:53
*** wolverineav has joined #openstack-neutron16:53
*** elopez is now known as Guest1060016:54
openstackgerritManjeet Singh Bhatia proposed openstack/neutron: Relocate L3 DB Models  https://review.openstack.org/34856216:54
armaxlet me mull over this a bit, I can see that the heregeneous list push is nice16:54
ajoI'm going to fix the comments Ihar left (I'm afraid stuff won't work without the receiver version '1.1') and I'll continue monday morning with whatever you tell me on gerrit :)16:54
ihrachysI don't know how long we want to spin on it. I find a slightly more powerful API a good thing if it does not complicate much, but someone may claim it's YAGNI.16:54
armaxI only wish that it would result into a single consumer-side pull16:54
armax*push16:55
*** wolverineav has quit IRC16:55
*** wolverineav has joined #openstack-neutron16:55
*** wolverineav has quit IRC16:55
armaxihrachys: I don’t carea bout YAGNI16:55
armaxihrachys: I care if the API is well designed16:55
*** yamahata has joined #openstack-neutron16:55
*** wolverineav has joined #openstack-neutron16:55
*** sridharg has joined #openstack-neutron16:55
ajosometimes providing functionality in advance makes your future less painful16:55
*** wolverineav has quit IRC16:56
armaxihrachys: and if not, it may result into unintentional misuse16:56
ajofor example, multiple item push was a YAGNI in the past :)16:56
*** iyamahat has quit IRC16:56
*** wolverineav has joined #openstack-neutron16:56
armaxthe only argument I have is that there’s nothing in the API that tells me that a hetero-list push is gonna result into multiple homo-list pushes16:56
*** wolverineav has quit IRC16:57
*** wolverineav has joined #openstack-neutron16:57
*** wolverineav has quit IRC16:57
armaxthat’s quite an implicit assumption that can be discovered through RTFM16:57
armaxrtheis: ping16:57
*** wolverineav has joined #openstack-neutron16:57
rtheisarmax: hi16:57
ihrachysarmax: it's a matter of doc16:57
*** wolverineav has quit IRC16:58
*** wolverineav has joined #openstack-neutron16:58
armaxihrachys: well, it’d be nice if the doc would be the API itself, that’s one of the secret of good API design16:58
*** wolverineav has quit IRC16:58
armaxrtheis: re 34889716:58
ihrachysanyhow, whatever makes you happy. I am slightly happier with what we have now, but if it blocks progress for vlan-aware, let's revert..16:58
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron: SR-IOV: add agent QoS driver to support egress minimum bandwidth  https://review.openstack.org/34730216:58
armaxrtheis: we should not just drop the module subscribe()16:58
*** wolverineav has joined #openstack-neutron16:58
ihrachysarmax: an argument allowing heterogenous?16:58
ihrachysthat is off by default?16:58
*** wolverineav has quit IRC16:59
*** wolverineav has joined #openstack-neutron16:59
*** wolverineav has quit IRC16:59
*** eilert has joined #openstack-neutron16:59
rtheisarmax: ack16:59
ihrachysthen we'll raise if it's not off and multiple keys in the per-type list16:59
ihrachysthat would require some more tests.16:59
armaxrtheis: but we should move it into the L3 mixin16:59
*** wolverineav has joined #openstack-neutron16:59
armaxrtheis: perhaps into a __new__() block16:59
*** wolverineav has quit IRC17:00
armaxrtheis: and only then it can be removed17:00
*** wolverineav has joined #openstack-neutron17:00
*** wolverineav has quit IRC17:00
armaxihrachys: right, my reserve against allowing hetero-list17:00
armaxihrachys: I am ok with the existing approach17:00
*** wolverineav has joined #openstack-neutron17:00
armaxihrachys: I am simply pondering :)17:00
*** wolverineav has quit IRC17:01
ihrachysit's open source, we'll iterate!17:01
ihrachys:)17:01
*** wolverineav has joined #openstack-neutron17:01
*** wolverineav has quit IRC17:01
armaxihrachys: right, let’s see if we get stung by this17:01
rtheisarmax: we still keep the subscribe() method, correct?17:01
armaxihrachys: and reconsider things if need be17:01
armaxrtheis: yes17:01
*** wolverineav has joined #openstack-neutron17:01
armaxrtheis: split into agent vs agentless subscribes17:01
ajoI also wonder17:01
*** wolverineav has quit IRC17:02
ajohow useful is if you receive the different items out of order, well17:02
*** wolverineav has joined #openstack-neutron17:02
armaxrtheis: one goes into the notifier mixin, the other goes into the L3_db mixin17:02
*** wolverineav has quit IRC17:02
ajobut that can also happen if you do it individually17:02
*** Guest10600 has quit IRC17:02
armaxrtheis: well17:02
ajodifferent resource types, different queues....17:02
armaxrtheis: forget about the notifier part17:02
*** ijw has joined #openstack-neutron17:02
armaxrtheis: we’d keep the subscriber as is and move into the mixin definition17:02
*** wolverineav has joined #openstack-neutron17:02
*** matrohon has quit IRC17:02
*** wolverineav has quit IRC17:03
*** wolverineav has joined #openstack-neutron17:03
*** wolverineav has quit IRC17:03
armaxajo: right, we’ll have to cross that bridge when we get to it, I guess17:03
armaxeven if the tool allows me hetero lists17:03
armaxI don’t think I am ever gonna is it17:03
armaxbut never say never17:03
*** wolverineav has joined #openstack-neutron17:03
armaxrtheis: what do you reckon?17:03
*** wolverineav has quit IRC17:04
ajowe could re-implement later when we find the use case17:04
ajothe patch is up17:04
*** wolverineav has joined #openstack-neutron17:04
*** wolverineav has quit IRC17:04
armaxajo: did you respin?17:04
rtheisarmax: I started splitting and moving the bits under https://review.openstack.org/#/c/348933/ ... but it still had the implicit subscription17:04
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron: Add QoS minimum bandwidth rule for instance egress traffic  https://review.openstack.org/34414517:04
ajoarmax, about to respin17:04
armaxajo: ack17:04
ajoarmax, give me 5 more minutes17:04
*** wolverineav has joined #openstack-neutron17:04
*** claudiub|2 has quit IRC17:04
armaxajo: don’t be late to your swimming session!17:04
*** wolverineav has quit IRC17:05
*** wolverineav has joined #openstack-neutron17:05
*** wolverineav has quit IRC17:05
armaxrtheis: in hindsight, I think the module subsription is overkill17:05
rtheisarmax: if __new__ can be used for the implicit subscription then I suppose I could pull the unsubscribe bits17:05
armaxrtheis: yes, if we give it a try, that should do it I think17:05
armaxrtheis: and your life is simpler17:05
*** wolverineav has joined #openstack-neutron17:05
*** wolverineav has quit IRC17:06
rtheisarmax: I like simple.  I'll give it a try17:06
armaxrtheis: you’d still keep the subscribe method17:06
*** wolverineav has joined #openstack-neutron17:06
*** wolverineav has quit IRC17:06
rtheisarmax: ack17:06
rtheisthanks17:06
*** elopez_ has joined #openstack-neutron17:06
armaxrtheis: and move the agentless subscribe into the dbonly mixin17:06
*** wolverineav has joined #openstack-neutron17:06
*** wolverineav has quit IRC17:07
armaxand then call subscribe() from the agent-based mixin17:07
*** wolverineav has joined #openstack-neutron17:07
*** wolverineav has quit IRC17:07
armaxnow subscribe() could be split into agentless subscriptions and agent-based subscriptions17:07
*** sbalukoff has quit IRC17:07
*** wolverineav has joined #openstack-neutron17:07
*** wolverineav has quit IRC17:08
*** wolverineav has joined #openstack-neutron17:08
*** wolverineav has quit IRC17:08
armaxrtheis: but that’s only to avoid duplicating the subscription to _prevent_l3_port_delete_callback17:08
*** wolverineav has joined #openstack-neutron17:08
*** wolverineav has quit IRC17:09
*** wolverineav has joined #openstack-neutron17:09
*** wolverineav has quit IRC17:09
rtheisarmax: sounds good, I'll start reworking the patch17:09
armaxrtheis: ok, let’s see how it works out17:09
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Introduce bulk push to rpc callback mechanism  https://review.openstack.org/34847617:09
ajoarmax, there it goes ^17:09
*** wolverineav has joined #openstack-neutron17:09
openstackgerritManjeet Singh Bhatia proposed openstack/neutron: Relocate Metering DB models  https://review.openstack.org/34875717:10
*** wolverineav has quit IRC17:10
*** wolverineav has joined #openstack-neutron17:10
*** wolverineav has quit IRC17:10
* armax reviews17:10
*** gvrangan has joined #openstack-neutron17:10
armaxajo: thank you for pulling ths off so quickly17:10
armaxI owe you a free/uncoditional +217:10
armax:P17:10
armaxuse it with care17:10
*** wolverineav has joined #openstack-neutron17:10
*** wolverineav has quit IRC17:11
ajonah, you're welcome :D17:11
ajoI'm glad to be of help17:11
*** wolverineav has joined #openstack-neutron17:11
*** wolverineav has quit IRC17:11
armaxajo: you know I wasn’t going to give you a free/unconditonal +2 anyway… :)17:11
ajoof course :P :D17:11
*** wolverineav has joined #openstack-neutron17:11
*** wolverineav has quit IRC17:12
*** wolverineav has joined #openstack-neutron17:12
*** wolverineav has quit IRC17:12
*** kevo has joined #openstack-neutron17:12
*** wolverineav has joined #openstack-neutron17:12
*** wolverineav has quit IRC17:13
*** wolverineav has joined #openstack-neutron17:13
*** wolverineav has quit IRC17:13
*** wolverineav has joined #openstack-neutron17:13
ihrachyswolverineav: struggling with comcast?17:14
*** tflynn has joined #openstack-neutron17:14
*** wolverineav has quit IRC17:15
*** wolverineav has joined #openstack-neutron17:15
*** wolverineav has quit IRC17:15
*** wolverineav has joined #openstack-neutron17:15
*** nherciu has quit IRC17:15
armaxrtheis: btw what do you think about my response on https://review.openstack.org/#/c/340624/14/setup.cfg@4317:15
*** wolverineav has quit IRC17:16
*** wolverineav has joined #openstack-neutron17:16
*** wolverineav has quit IRC17:16
armaxrtheis: I’d like to close in on this if I can help it17:16
*** wolverineav has joined #openstack-neutron17:16
*** wolverineav has quit IRC17:17
*** wolverineav has joined #openstack-neutron17:17
*** sdague has joined #openstack-neutron17:17
*** wolverineav has quit IRC17:17
*** wolverineav has joined #openstack-neutron17:17
*** ijw has quit IRC17:18
*** wolverineav has quit IRC17:19
*** wolverineav has joined #openstack-neutron17:19
*** wolverineav has quit IRC17:19
*** tflynn has quit IRC17:19
openstackgerritMerged openstack/neutron-specs: QoS Improved validation mechanism for rules  https://review.openstack.org/32347417:19
*** wolverineav has joined #openstack-neutron17:19
*** wolverineav has quit IRC17:20
*** wolverineav has joined #openstack-neutron17:20
*** wolverineav has quit IRC17:20
ihrachysajo: ^ validation spec landed, we just need to make the code polished17:20
*** wolverineav has joined #openstack-neutron17:20
*** wolverineav has quit IRC17:21
*** wolverineav has joined #openstack-neutron17:21
*** wolverineav has quit IRC17:21
*** wolverineav has joined #openstack-neutron17:21
*** wolverineav has quit IRC17:22
*** wolverineav has joined #openstack-neutron17:22
*** wolverineav has quit IRC17:22
*** wolverineav has joined #openstack-neutron17:22
*** wolverineav has quit IRC17:23
*** wolverineav has joined #openstack-neutron17:23
*** wolverineav has quit IRC17:23
*** singhj has quit IRC17:23
*** wolverineav has joined #openstack-neutron17:23
*** wolverineav has quit IRC17:24
*** wolverineav has joined #openstack-neutron17:24
*** wolverineav has quit IRC17:24
*** wolverineav has joined #openstack-neutron17:24
*** wolverineav has quit IRC17:25
*** wolverineav has joined #openstack-neutron17:25
*** wolverineav has quit IRC17:25
*** elopez_ has quit IRC17:25
*** wolverineav has joined #openstack-neutron17:25
*** wolverineav has quit IRC17:26
*** wolverineav has joined #openstack-neutron17:26
*** wolverineav has quit IRC17:26
*** wolverineav has joined #openstack-neutron17:26
*** wolverineav has quit IRC17:27
*** wolverineav has joined #openstack-neutron17:27
*** wolverineav has quit IRC17:27
*** wolverineav has joined #openstack-neutron17:28
*** wolverineav has quit IRC17:28
*** wolverineav has joined #openstack-neutron17:28
*** wolverineav has quit IRC17:29
*** wolverineav has joined #openstack-neutron17:29
*** wolverineav has quit IRC17:29
*** dasanind has quit IRC17:29
*** sbalukoff has joined #openstack-neutron17:29
*** wolverineav has joined #openstack-neutron17:29
*** wolverineav has quit IRC17:30
*** wolverineav has joined #openstack-neutron17:30
*** wolverineav has quit IRC17:30
*** wolverineav has joined #openstack-neutron17:30
*** neiljerram has quit IRC17:30
*** wolverineav has quit IRC17:31
*** wolverineav has joined #openstack-neutron17:31
*** wolverineav has quit IRC17:31
*** wolverineav has joined #openstack-neutron17:31
*** wolverineav has quit IRC17:32
*** neiljerram has joined #openstack-neutron17:32
*** wolverineav has joined #openstack-neutron17:32
*** wolverineav has quit IRC17:32
*** wolverineav has joined #openstack-neutron17:32
*** wolverineav has quit IRC17:33
*** wolverineav has joined #openstack-neutron17:33
*** wolverineav has quit IRC17:33
*** wolverineav has joined #openstack-neutron17:33
*** fnaval has joined #openstack-neutron17:34
ihrachysarmax: do we have time till Monday with the patch, or we want to land it quicker?17:34
armaxihrachys: I think it can bake a little longer17:35
*** wolverineav has quit IRC17:35
ihrachysarmax: if the former, I will let ajo to handle remaining comments, otherwise I can respin17:35
*** wolverineav has joined #openstack-neutron17:35
ihrachysack17:35
*** wolverineav has quit IRC17:35
*** itlinux has quit IRC17:35
armaxihrachys: I think we agreed that we are ok with the existing approach17:35
*** jamielennox is now known as jamielennox|away17:35
*** wolverineav has joined #openstack-neutron17:35
*** wolverineav has quit IRC17:36
*** wolverineav has joined #openstack-neutron17:36
*** wolverineav has quit IRC17:36
*** iyamahat has joined #openstack-neutron17:36
*** fnaval has quit IRC17:36
*** wolverineav has joined #openstack-neutron17:36
*** fnaval has joined #openstack-neutron17:37
ihrachysarmax: there are some remaining comments in tests that would be cool to handle before landing, so if we have time, let's give it another day.17:37
armaxihrachys: absolutely17:38
*** wolverineav has quit IRC17:38
*** wolverineav has joined #openstack-neutron17:38
*** wolverineav has quit IRC17:38
*** singhj has joined #openstack-neutron17:38
*** wolverineav has joined #openstack-neutron17:38
*** wolverineav has quit IRC17:39
openstackgerritJoseph Pasque proposed openstack/neutron: Action status updating tag changed from 201 to 200  https://review.openstack.org/34897717:39
*** wolverineav has joined #openstack-neutron17:39
*** wolverineav has quit IRC17:41
*** wolverineav has joined #openstack-neutron17:41
*** wolverineav has quit IRC17:41
*** wolverineav has joined #openstack-neutron17:41
*** wolverineav has quit IRC17:42
*** wolverineav has joined #openstack-neutron17:42
*** wolverineav has quit IRC17:42
*** singhj has quit IRC17:42
*** abhiraut has joined #openstack-neutron17:42
*** wolverineav has joined #openstack-neutron17:42
*** wolverineav has quit IRC17:43
*** wolverineav has joined #openstack-neutron17:43
*** wolverineav has quit IRC17:43
*** wolverineav has joined #openstack-neutron17:44
wolverineavihrachys: oops, not sure what happened there, but last night laptop didn't go to sleep after shut lid. endless loop of connect/disconnect. woke up and laptop is a hot cake! haha17:46
*** wolverineav has quit IRC17:48
*** wolverineav has joined #openstack-neutron17:49
*** kobis has joined #openstack-neutron17:52
*** obondarev has quit IRC17:52
openstackgerritIhar Hrachyshka proposed openstack/neutron: objects: switched back to passing models into extension handlers  https://review.openstack.org/34898717:53
*** Sarath has joined #openstack-neutron17:53
ihrachyskevinbenton: ^ switching back to models for some objects for which we passed objects into extend_dict functions for some time17:53
*** links has joined #openstack-neutron17:53
*** s3wong has joined #openstack-neutron17:54
*** wolverineav has quit IRC17:57
*** nlahouti1 has quit IRC17:57
*** nlahouti has joined #openstack-neutron17:57
rtheisarmax: sorry, I stepped away for a while.  I'll take a look at the review again17:58
armaxrtheis: thanks17:58
openstackgerritArmando Migliaccio proposed openstack/neutron: Revisit the Stadium section of the developer guide  https://review.openstack.org/33573917:59
*** jprovazn has quit IRC17:59
*** elopez_ has joined #openstack-neutron18:01
*** johnbelamaric has quit IRC18:01
*** elopez_ has quit IRC18:01
*** johnbelamaric has joined #openstack-neutron18:01
*** jprovazn has joined #openstack-neutron18:02
*** nlahouti1 has joined #openstack-neutron18:02
*** nlahouti has quit IRC18:02
*** iranzo has quit IRC18:04
*** singhj has joined #openstack-neutron18:08
*** nlahouti1 has quit IRC18:09
*** nlahouti has joined #openstack-neutron18:09
*** Captain_Murdoch has quit IRC18:11
*** singhj has quit IRC18:13
*** ijw has joined #openstack-neutron18:13
openstackgerritManjeet Singh Bhatia proposed openstack/neutron: Pass the complete info in sg/rules db into PRECOMMIT_XXX callback  https://review.openstack.org/28169318:15
*** wolverineav has joined #openstack-neutron18:16
*** nlahouti has quit IRC18:19
*** wolverineav has quit IRC18:19
*** nlahouti has joined #openstack-neutron18:19
*** wolverineav has joined #openstack-neutron18:19
*** ijw has quit IRC18:20
*** nlahouti1 has joined #openstack-neutron18:23
*** nlahouti has quit IRC18:23
*** amuller has quit IRC18:25
*** singhj has joined #openstack-neutron18:26
*** anilvenkata has quit IRC18:26
*** wolverineav has quit IRC18:28
*** wolverineav has joined #openstack-neutron18:29
*** nlahouti1 has quit IRC18:30
*** nlahouti has joined #openstack-neutron18:30
*** john-davidge has quit IRC18:32
*** nlahouti has quit IRC18:34
*** thorst has quit IRC18:34
*** nlahouti has joined #openstack-neutron18:34
*** ociuhandu has quit IRC18:37
*** thorst has joined #openstack-neutron18:37
*** nlahouti has quit IRC18:38
*** nlahouti has joined #openstack-neutron18:38
*** dkehn has quit IRC18:39
*** dkehn_ has quit IRC18:40
*** thorst has quit IRC18:42
openstackgerritAnkur proposed openstack/neutron: [WIP] Introducing Network OVO  https://review.openstack.org/34901818:43
*** elopez_ has joined #openstack-neutron18:44
*** johnbelamaric has quit IRC18:44
*** johnbelamaric has joined #openstack-neutron18:44
*** iyamahat has quit IRC18:46
*** yamahata has quit IRC18:46
*** dkehn has joined #openstack-neutron18:46
*** gvrangan has quit IRC18:52
*** dkehn_ has joined #openstack-neutron18:52
*** achanda has joined #openstack-neutron18:55
*** hoonetorg has quit IRC18:56
*** Leo_ has joined #openstack-neutron18:56
*** thorst has joined #openstack-neutron18:56
*** Leom has joined #openstack-neutron18:56
*** ijw has joined #openstack-neutron18:57
*** Leo_ has quit IRC19:00
*** thorst has quit IRC19:00
*** thorst has joined #openstack-neutron19:01
*** bks has joined #openstack-neutron19:02
*** tflynn has joined #openstack-neutron19:03
*** ijw has quit IRC19:03
*** elopez_ has quit IRC19:03
*** thorst_ has joined #openstack-neutron19:03
*** ihrachys has quit IRC19:04
*** nlahouti has left #openstack-neutron19:05
*** cleong has quit IRC19:05
*** elo has quit IRC19:06
*** yamamoto has quit IRC19:06
*** thorst has quit IRC19:06
*** fifieldt has quit IRC19:07
*** elo has joined #openstack-neutron19:07
*** tflynn has quit IRC19:07
*** hynekm has joined #openstack-neutron19:07
openstackgerritMerged openstack/neutron: Fix that api_workers=0 doesn't spawn any api workers  https://review.openstack.org/34880119:13
*** buttercup has quit IRC19:13
*** hynekm has quit IRC19:14
*** vhoward has quit IRC19:15
*** ijw has joined #openstack-neutron19:15
*** johnbelamaric has quit IRC19:15
*** sridharg has quit IRC19:16
*** moshele has quit IRC19:17
*** johnbelamaric has joined #openstack-neutron19:17
openstackgerritMerged openstack/neutron: tests: enable test_get_objects_queries_constant for trunk ports  https://review.openstack.org/34837819:18
*** fifieldt has joined #openstack-neutron19:18
*** fzdarsky is now known as fzdarsky|afk19:19
*** fzdarsky|afk has quit IRC19:19
*** johnbelamaric has quit IRC19:19
*** dkehn_ has quit IRC19:19
*** links has quit IRC19:20
*** dkehn has quit IRC19:20
*** mickeys has quit IRC19:21
*** bvandewa has joined #openstack-neutron19:22
*** dkehn has joined #openstack-neutron19:22
*** iyamahat has joined #openstack-neutron19:24
*** ijw has quit IRC19:25
*** dkehn has quit IRC19:28
*** johnbelamaric has joined #openstack-neutron19:28
openstackgerritMerged openstack/neutron: Added test cases for DVR L3 schedulers.  https://review.openstack.org/18815719:30
openstackgerritMerged openstack/neutron: Fix for check_vlan_transparency on mech drivers not called  https://review.openstack.org/34100319:31
*** dkehn_ has joined #openstack-neutron19:32
openstackgerritMerged openstack/neutron: Refactoring config options for common config opts  https://review.openstack.org/34428119:32
*** dkehn has joined #openstack-neutron19:34
*** edmondsw has quit IRC19:35
*** bvandewa has quit IRC19:35
*** yamahata has joined #openstack-neutron19:43
*** banix has joined #openstack-neutron19:43
*** chandankumar has quit IRC19:45
*** tidwellr has joined #openstack-neutron19:51
*** krtaylor has quit IRC19:52
openstackgerritArmando Migliaccio proposed openstack/neutron: Revisit the Stadium section of the developer guide  https://review.openstack.org/33573919:54
*** jprovazn has quit IRC19:54
*** Sarath has quit IRC19:55
*** ijw has joined #openstack-neutron19:58
*** rahuls has joined #openstack-neutron19:59
*** rossella_s has quit IRC19:59
*** rossella_s has joined #openstack-neutron20:00
openstackgerritAnindita Das proposed openstack/neutron: Refactoring config options for extension opts  https://review.openstack.org/34548620:05
*** ociuhandu has joined #openstack-neutron20:07
*** yamamoto has joined #openstack-neutron20:07
*** sindhu has quit IRC20:07
*** ijw has quit IRC20:07
*** slaweq has joined #openstack-neutron20:09
*** baoli has quit IRC20:11
*** yamamoto has quit IRC20:12
*** bvandewa has joined #openstack-neutron20:12
*** jckasper has quit IRC20:12
*** jckasper has joined #openstack-neutron20:13
*** sindhu has joined #openstack-neutron20:14
*** jckasper has quit IRC20:17
*** azbiswas has joined #openstack-neutron20:20
*** ijw has joined #openstack-neutron20:21
*** mickeys_ has joined #openstack-neutron20:23
*** kobis has quit IRC20:27
*** ijw has quit IRC20:27
*** sindhu has quit IRC20:27
*** dasanind has joined #openstack-neutron20:27
*** mickeys_ has quit IRC20:28
*** sindhu has joined #openstack-neutron20:29
*** tonytan_brb has quit IRC20:31
*** janzian has quit IRC20:32
*** achanda has quit IRC20:34
*** slaweq has quit IRC20:37
*** gouthamr has quit IRC20:41
*** akshai has quit IRC20:42
*** gvrangan has joined #openstack-neutron20:45
*** moshele has joined #openstack-neutron20:46
openstackgerritVictor Morales proposed openstack/neutron: Relocate Flavor and ServiceProfile DB models  https://review.openstack.org/34907120:47
*** boden has quit IRC20:53
*** abhiraut has quit IRC20:57
openstackgerritAnindita Das proposed openstack/neutron: Refactoring config options for services opts  https://review.openstack.org/34704420:59
*** wolverin_ has joined #openstack-neutron21:03
*** bvandewa has quit IRC21:04
*** marst has quit IRC21:04
*** wolverineav has quit IRC21:06
*** singhj has quit IRC21:07
*** yamamoto has joined #openstack-neutron21:08
*** banix has quit IRC21:10
*** singhj has joined #openstack-neutron21:11
*** jamesdenton has quit IRC21:13
*** yamamoto has quit IRC21:13
*** elo has quit IRC21:14
*** xinliang has quit IRC21:14
*** elo has joined #openstack-neutron21:22
*** singhj has quit IRC21:23
*** abhiraut has joined #openstack-neutron21:25
*** singhj has joined #openstack-neutron21:25
*** armax has quit IRC21:26
*** elo has quit IRC21:27
*** xinliang has joined #openstack-neutron21:29
*** tonytan4ever has joined #openstack-neutron21:31
openstackgerritBrandon Logan proposed openstack/neutron: WIP: Pecan: Handle member actions  https://review.openstack.org/34458121:33
*** banix has joined #openstack-neutron21:34
*** bvandewa has joined #openstack-neutron21:35
*** tonytan4ever has quit IRC21:36
*** wolverin_ has quit IRC21:41
*** liuyulong_ has joined #openstack-neutron21:44
*** liuyulong has quit IRC21:44
*** dims_ has quit IRC21:44
openstackgerritMerged openstack/neutron: Filter HA router without HA port bindings after race conditions  https://review.openstack.org/26568021:44
*** dims has joined #openstack-neutron21:46
*** liuyulong has joined #openstack-neutron21:47
*** singhj has quit IRC21:48
*** liuyulong_ has quit IRC21:48
*** liuyulong_ has joined #openstack-neutron21:49
*** rtheis has quit IRC21:49
*** singhj has joined #openstack-neutron21:50
*** moshele has quit IRC21:50
openstackgerritMerged openstack/neutron: Fix L3 NAT DB signature mismatch  https://review.openstack.org/34855821:50
*** liuyulong has quit IRC21:52
*** elo has joined #openstack-neutron21:56
*** singhj has quit IRC21:56
*** bvandewa has quit IRC21:57
*** sindhu has quit IRC21:57
*** singhj has joined #openstack-neutron21:58
*** ajmiller has joined #openstack-neutron22:01
*** sbalukoff has quit IRC22:01
*** azbiswas has quit IRC22:02
*** zkassab has quit IRC22:02
*** azbiswas has joined #openstack-neutron22:02
*** azbiswas has quit IRC22:02
*** singhj has quit IRC22:03
*** liuyulong_ has quit IRC22:03
*** johnbelamaric has quit IRC22:03
*** ajmiller_ has joined #openstack-neutron22:03
*** liuyulong has joined #openstack-neutron22:04
*** pradk has quit IRC22:04
*** ajmiller has quit IRC22:07
*** superdan has quit IRC22:07
*** moshele has joined #openstack-neutron22:08
*** bks has quit IRC22:08
*** yamamoto has joined #openstack-neutron22:10
*** azbiswas has joined #openstack-neutron22:12
*** wolverineav has joined #openstack-neutron22:13
*** achanda has joined #openstack-neutron22:13
*** ijw has joined #openstack-neutron22:14
*** daneyon has quit IRC22:15
*** singhj has joined #openstack-neutron22:15
*** yamamoto has quit IRC22:15
*** wolverineav has quit IRC22:18
*** liuyulong_ has joined #openstack-neutron22:21
*** liuyulong has quit IRC22:22
*** ijw has quit IRC22:24
*** dane_leblanc has quit IRC22:31
*** moshele has quit IRC22:32
*** wolverineav has joined #openstack-neutron22:33
*** liuyulong has joined #openstack-neutron22:37
*** wolverineav has quit IRC22:37
*** tpsilva has quit IRC22:38
*** dave-mccowan has quit IRC22:38
*** liuyulong_ has quit IRC22:39
*** wolverineav has joined #openstack-neutron22:40
*** wolverineav has quit IRC22:40
*** wolverineav has joined #openstack-neutron22:41
*** liuyulong_ has joined #openstack-neutron22:41
*** liuyulong has quit IRC22:41
*** abregman has quit IRC22:45
*** gouthamr has joined #openstack-neutron22:45
openstackgerritAbhishek Raut proposed openstack/python-neutronclient: Add trunk commands to openstackclient  https://review.openstack.org/34062422:46
*** liuyulong has joined #openstack-neutron22:47
*** Guest41489 has joined #openstack-neutron22:49
*** liuyulong_ has quit IRC22:50
*** singhj has quit IRC22:50
*** moshele has joined #openstack-neutron22:52
*** singhj has joined #openstack-neutron22:52
openstackgerritRawlin Peters proposed openstack/neutron: Pass bridge_name in OVS port's vif_details  https://review.openstack.org/34381622:52
*** minwang2 has joined #openstack-neutron22:57
*** minwang2 has left #openstack-neutron22:58
*** sdague has quit IRC22:59
*** a_ta has quit IRC22:59
*** a_ta has joined #openstack-neutron23:00
openstackgerritIsaku Yamahata proposed openstack/neutron: many tests modify global RESOURCE_ATTRIBUTES_MAP  https://review.openstack.org/34911123:00
*** sindhu has joined #openstack-neutron23:01
*** Guest41489 has quit IRC23:02
openstackgerritRawlin Peters proposed openstack/neutron: Pass bridge_name in OVS port's vif_details  https://review.openstack.org/34381623:03
*** a_ta has quit IRC23:04
*** thorst_ has quit IRC23:04
*** thorst has joined #openstack-neutron23:05
*** singhj has quit IRC23:08
*** mickeys has joined #openstack-neutron23:08
openstackgerritKevin Benton proposed openstack/neutron: Revert "Don't use exponential back-off for report_state"  https://review.openstack.org/34911323:09
*** mickeys_ has joined #openstack-neutron23:11
*** mickeys has quit IRC23:11
*** yamamoto has joined #openstack-neutron23:12
*** abhiraut has quit IRC23:13
*** thorst has quit IRC23:13
*** mickeys_ has quit IRC23:13
*** sindhu has quit IRC23:14
*** achanda has quit IRC23:17
*** yamamoto has quit IRC23:17
*** dasanind has quit IRC23:17
apuimedokevinbenton: all the patches got merged. Thanks23:22
apuimedoplease, when you can, tag a release :-)23:23
apuimedonetworking-midonet stable/mitaka23:23
*** tonytan4ever has joined #openstack-neutron23:25
*** eilert has quit IRC23:26
kevinbentonapuimedo: i can't to tags23:26
*** Guest39119 has joined #openstack-neutron23:27
*** armax has joined #openstack-neutron23:28
kevinbentonapuimedo: try pinging armax23:28
*** armax is now known as Guest4601923:28
*** Guest46019 has quit IRC23:29
apuimedothanks kevinbenton. I will23:32
apuimedocarl_baldwin: ping23:34
openstackgerritLIU Yulong proposed openstack/neutron: Put HA router state change event into queue  https://review.openstack.org/27561423:34
apuimedocarl_baldwin: I saw that you are on neutron-release, could you please tag a networking-midonet stable/mitaka release?23:34
apuimedodougwig: ^^23:35
*** banix has quit IRC23:35
* apuimedo trying to find a neutron-release member :P23:35
apuimedojohnsom: ^^23:38
*** vishwanathj has quit IRC23:52
*** Guest39119 is now known as dansmith23:52
openstackgerritHenry Gessau proposed openstack/neutron: Don't use file() to write object hashes  https://review.openstack.org/34911723:54
*** abhiraut has joined #openstack-neutron23:55
*** ajmiller_ has quit IRC23:58
*** achanda has joined #openstack-neutron23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!