Sunday, 2017-01-08

*** zhugaoxiao has quit IRC00:08
*** wolverineav has joined #openstack-neutron00:10
*** claudiub has joined #openstack-neutron00:10
openstackgerritJianghua Wang proposed openstack/neutron: XenAPI: Support daemon mode for rootwrap  https://review.openstack.org/39093100:13
*** wolverineav has quit IRC00:15
*** marlinc has quit IRC00:18
*** thorst has joined #openstack-neutron00:21
*** thorst has quit IRC00:23
*** gbutnaru has joined #openstack-neutron00:29
*** wolverineav has joined #openstack-neutron00:30
*** wolverineav has quit IRC00:34
*** salv-orl_ has quit IRC00:38
*** wolverineav has joined #openstack-neutron00:40
*** tommylikehu_ has joined #openstack-neutron00:43
*** wolverineav has quit IRC00:44
*** tommylikehu_ has quit IRC00:47
*** tommylikehu_ has joined #openstack-neutron00:48
*** tommylikehu_ has quit IRC00:48
*** tommylikehu_ has joined #openstack-neutron00:49
*** tommylikehu_ has quit IRC00:49
*** tommylikehu_ has joined #openstack-neutron00:49
*** tommylikehu_ has quit IRC00:50
*** tommylikehu_ has joined #openstack-neutron00:50
*** roeyc has quit IRC00:50
*** tommylikehu_ has quit IRC00:51
*** tommylikehu_ has joined #openstack-neutron00:51
*** tommylikehu_ has quit IRC00:51
*** tommylikehu_ has joined #openstack-neutron00:52
*** tommylikehu_ has quit IRC00:52
*** tommylikehu_ has joined #openstack-neutron01:06
*** tommylikehu_ has quit IRC01:06
*** tommylikehu_ has joined #openstack-neutron01:07
*** tommylik_ has joined #openstack-neutron01:08
*** tommylikehu_ has quit IRC01:08
*** wolverineav has joined #openstack-neutron01:09
*** thorst has joined #openstack-neutron01:11
*** thorst has quit IRC01:11
*** sterdnotshaken has joined #openstack-neutron01:13
*** sterdnotshaken has quit IRC01:13
*** wolverineav has quit IRC01:14
*** yamahata has joined #openstack-neutron01:17
*** marlinc has joined #openstack-neutron01:23
*** gooduone has quit IRC01:27
*** wolverineav has joined #openstack-neutron01:29
*** grantma has joined #openstack-neutron01:30
*** wolverineav has quit IRC01:33
*** salv-orlando has joined #openstack-neutron01:38
*** claudiub has quit IRC01:40
*** salv-orlando has quit IRC01:43
*** marlinc has quit IRC01:43
*** wolverineav has joined #openstack-neutron01:48
*** marlinc has joined #openstack-neutron01:53
*** wolverineav has quit IRC01:53
*** tflynn has joined #openstack-neutron01:59
*** bobmel has joined #openstack-neutron02:03
*** bobmel has quit IRC02:08
*** wolverineav has joined #openstack-neutron02:08
*** shaner_ has quit IRC02:13
*** wolverineav has quit IRC02:13
openstackgerritKevin Benton proposed openstack/neutron: Decompose router extra attr processing  https://review.openstack.org/41760402:16
openstackgerritDavid Hill proposed openstack/neutron: Escape quotes in conn_uri declaration  https://review.openstack.org/41764102:26
*** wolverineav has joined #openstack-neutron02:28
*** tflynn has quit IRC02:30
*** wolverineav has quit IRC02:33
*** thorst has joined #openstack-neutron02:35
*** thorst has quit IRC02:35
*** salv-orlando has joined #openstack-neutron02:40
*** yamahata has quit IRC02:44
*** salv-orlando has quit IRC02:44
*** wolverineav has joined #openstack-neutron02:48
*** shaner_ has joined #openstack-neutron02:51
*** wolverineav has quit IRC02:52
*** fzdarsky__ has joined #openstack-neutron02:57
*** fzdarsky_ has quit IRC03:01
*** wolverineav has joined #openstack-neutron03:07
*** ramishra has quit IRC03:11
*** shaner has quit IRC03:11
*** wolverineav has quit IRC03:11
*** ramishra has joined #openstack-neutron03:12
*** bobmel has joined #openstack-neutron03:16
*** bobmel has quit IRC03:20
*** jhershbe_ has joined #openstack-neutron03:20
*** wolverineav has joined #openstack-neutron03:27
*** wolverineav has quit IRC03:32
*** itisha has quit IRC03:32
*** salv-orlando has joined #openstack-neutron03:41
*** reedip_outofmemo has joined #openstack-neutron03:42
*** salv-orlando has quit IRC03:45
*** wolverineav has joined #openstack-neutron03:46
*** wolverineav has quit IRC03:51
*** prateek has joined #openstack-neutron03:54
*** dkehn has quit IRC03:57
*** wolverineav has joined #openstack-neutron03:57
*** dkehn has joined #openstack-neutron03:57
*** wolverineav has quit IRC04:01
*** wolverineav has joined #openstack-neutron04:06
*** wolverineav has quit IRC04:11
*** tbachman has joined #openstack-neutron04:19
*** tflynn has joined #openstack-neutron04:20
*** wolverineav has joined #openstack-neutron04:26
*** wolverineav has quit IRC04:31
*** wolverineav has joined #openstack-neutron04:36
*** wolverineav has quit IRC04:41
*** reedip_outofmemo has quit IRC04:41
*** salv-orlando has joined #openstack-neutron04:41
*** salv-orlando has quit IRC04:46
*** wolverineav has joined #openstack-neutron04:55
*** belharar has joined #openstack-neutron05:00
*** belharar_ has joined #openstack-neutron05:00
*** wolverineav has quit IRC05:00
*** gkadam has joined #openstack-neutron05:03
*** tommylik_ has quit IRC05:15
*** tflynn has quit IRC05:18
*** tflynn has joined #openstack-neutron05:18
*** nyechiel has joined #openstack-neutron05:25
*** bkopilov has joined #openstack-neutron05:29
*** gongysh has joined #openstack-neutron05:32
*** tommylikehu_ has joined #openstack-neutron05:42
*** salv-orlando has joined #openstack-neutron05:42
*** salv-orlando has quit IRC05:47
*** gvrangan has joined #openstack-neutron05:53
*** kobis1 has quit IRC06:00
*** garyk has joined #openstack-neutron06:05
*** itzikb has joined #openstack-neutron06:10
*** Alex_Stef has joined #openstack-neutron06:14
*** ekuris has joined #openstack-neutron06:15
*** moshele has joined #openstack-neutron06:18
*** mkolesni has joined #openstack-neutron06:25
openstackgerritKevin Benton proposed openstack/neutron: Decompose router extra attr processing  https://review.openstack.org/41760406:27
*** tommylikehu_ has quit IRC06:31
*** gkadam has quit IRC06:32
*** nmagnezi has joined #openstack-neutron06:35
*** brault has joined #openstack-neutron06:39
*** thorst has joined #openstack-neutron06:40
*** tommylikehu_ has joined #openstack-neutron06:43
*** brault has quit IRC06:43
*** salv-orlando has joined #openstack-neutron06:43
*** kobis has joined #openstack-neutron06:45
*** thorst has quit IRC06:45
*** Jeffrey4l_ has joined #openstack-neutron06:49
*** kobis has quit IRC06:49
*** salv-orlando has quit IRC06:50
*** kobis has joined #openstack-neutron06:51
*** thorst has joined #openstack-neutron06:52
*** jhershbe_ has quit IRC06:53
*** thorst has quit IRC06:56
*** jhershbe_ has joined #openstack-neutron07:07
*** jhershbe_ has quit IRC07:13
*** gcheresh_ has joined #openstack-neutron07:14
openstackgerritQunyingRan proposed openstack/neutron: Remove used ip which not in subnet pools  https://review.openstack.org/32238707:17
*** prateek has quit IRC07:20
*** prateek has joined #openstack-neutron07:26
*** yamahata has joined #openstack-neutron07:33
*** jhershbe has joined #openstack-neutron07:35
*** salv-orlando has joined #openstack-neutron07:46
*** salv-orlando has quit IRC07:51
*** Alex_Stef has quit IRC07:59
*** moshele has quit IRC08:00
*** moshele has joined #openstack-neutron08:01
*** moshele has quit IRC08:03
openstackgerritKevin Benton proposed openstack/neutron: Decompose router extra attr processing  https://review.openstack.org/41760408:08
*** reedip has quit IRC08:12
*** pck has quit IRC08:15
*** pck has joined #openstack-neutron08:16
*** yfried has joined #openstack-neutron08:17
openstackgerritKevin Benton proposed openstack/neutron: Decompose router extra attr processing  https://review.openstack.org/41760408:19
openstackgerritKevin Benton proposed openstack/neutron: Simplify AZ string conversion  https://review.openstack.org/41766108:19
openstackgerritKevin Benton proposed openstack/neutron: Get rid of l3 ha delete_router inheritance  https://review.openstack.org/39950708:19
openstackgerritKevin Benton proposed openstack/neutron: Get rid of L3 HA override of _update_router_db  https://review.openstack.org/39950608:19
openstackgerritKevin Benton proposed openstack/neutron: Get rid of create_router override in l3_ha mixin  https://review.openstack.org/39950508:19
*** reedip has joined #openstack-neutron08:25
openstackgerritKevin Benton proposed openstack/neutron: Simplify AZ string conversion  https://review.openstack.org/41766108:34
openstackgerritKevin Benton proposed openstack/neutron: Decompose router extra attr processing  https://review.openstack.org/41760408:34
openstackgerritKevin Benton proposed openstack/neutron: Get rid of create_router override in l3_ha mixin  https://review.openstack.org/39950508:35
openstackgerritKevin Benton proposed openstack/neutron: Get rid of L3 HA override of _update_router_db  https://review.openstack.org/39950608:35
openstackgerritKevin Benton proposed openstack/neutron: Get rid of l3 ha delete_router inheritance  https://review.openstack.org/39950708:35
*** grantma has quit IRC08:38
*** kobis has quit IRC08:39
*** tflynn has quit IRC08:41
*** tflynn has joined #openstack-neutron08:42
*** kobis has joined #openstack-neutron08:45
*** tflynn has quit IRC08:46
*** salv-orlando has joined #openstack-neutron08:47
*** jhershbe has quit IRC08:48
kevinbentonjschwarz: ping08:49
jschwarzkevinbenton, morning (or evening for you)08:50
*** salv-orlando has quit IRC08:51
kevinbentonjschwarz: moring08:51
openstackgerritKevin Benton proposed openstack/neutron: Get rid of l3 ha delete_router inheritance  https://review.openstack.org/39950708:52
kevinbentonjschwarz: have some patches in flight that i would like you to review08:52
kevinbentonjschwarz: ^^08:52
kevinbentonthat's the first08:52
jschwarzkevinbenton, will do :)08:52
jschwarzkevinbenton, it looks like https://review.openstack.org/#/c/317949/ introduced some race, btw08:52
*** thorst has joined #openstack-neutron08:52
jschwarzkevinbenton, 2 ha_vr_ids are allocated for the same router, and since only one is initialized the l3 agent also crashes on it08:53
jschwarzkevinbenton, https://bugs.launchpad.net/neutron/+bug/165403208:53
openstackLaunchpad bug 1654032 in tripleo "CI: unable to ping floating-ip in pingtest" [Critical,In progress] - Assigned to Emilien Macchi (emilienm)08:53
kevinbentonjschwarz: 2 vr_ids?08:53
kevinbentonjschwarz: why don't we have a unique constraint on that?08:53
jschwarzkevinbenton, I dunno08:54
jschwarzthough that would be a solution, I would like to understand the exact race first08:54
jschwarzI can't really reproduce this yet :<08:54
jschwarzmeh, I'm gonna put in more debugs on that shit08:55
*** thorst has quit IRC08:57
kevinbentonjschwarz: there is another change i have that may affect that behavior08:57
jschwarzkevinbenton, well actually it is a primary key so it should be already unique08:57
jschwarzkevinbenton, I think it might be overriding the old one so it doesn't affect it08:58
jschwarzkevinbenton, what change?08:58
*** roeyc has joined #openstack-neutron08:59
kevinbentonhttps://review.openstack.org/#/c/399505/08:59
*** kobis has quit IRC08:59
*** zzzeek has quit IRC09:00
kevinbentonjschwarz: after that vr_id will be allocated as part of router transaction09:00
*** zzzeek has joined #openstack-neutron09:01
jschwarzkevinbenton, aye I see.. though it can still be creation from the l3_agent_scheduler logic09:02
*** jhershbe has joined #openstack-neutron09:02
kevinbentonjschwarz: L3HARouterVRIdAllocation doesn't have unique constraint on router09:03
jschwarzkevinbenton, aye, but it has a primary key with the HA network (which is per tenant) so it should cover it09:03
jschwarzam I mistaken?09:03
*** iranzo has joined #openstack-neutron09:04
kevinbentonjschwarz: right, but there may be a race where two things allocate different VR IDs09:04
kevinbentonjschwarz: for the same router09:05
kevinbentonjschwarz: although we should just end up with an orphaned VR_ID09:05
jschwarzkevinbenton, only if something deletes the old one09:05
jschwarzwhich I don't think is happening09:06
*** slaweq_ has quit IRC09:08
kevinbentonjschwarz: so if the agent calls create_ha_port_and_bind right at the same time the ha network is being allocated09:08
jschwarzkevinbenton, but it shouldn't (because ALLOCATING)09:09
jschwarzkevinbenton, also I've gone through the logs very thoroughly - I don't think the agent is aware of the router until after the first routers_updated notification09:09
*** slaweq_ has joined #openstack-neutron09:10
kevinbentonjschwarz: so where are you seeing two vr_ids?09:10
jschwarzkevinbenton, and when it does, the scheduler says that the router has already been bound and ignores it09:10
kevinbentonjschwarz: the model only has one volumn09:10
jschwarzkevinbenton, here:09:10
kevinbentoncolumn09:10
jschwarzkevinbenton, hold on, the log is loading :|09:11
*** Alex_Stef has joined #openstack-neutron09:12
*** ushkalim has joined #openstack-neutron09:13
*** moshele has joined #openstack-neutron09:14
jschwarzkevinbenton, so here: http://logs.openstack.org/89/417089/3/experimental-tripleo/gate-tripleo-ci-centos-7-ovb-ha/19f0335/logs/overcloud-controller-1/var/log/neutron/l3-agent.txt.gz#_2017-01-07_10_37_25_40009:14
jschwarzkevinbenton, you can see that the agent is aware of ha_vr_id = 1 for this router09:15
jschwarzbut later on it has ha_vr_id=209:15
jschwarz(when an exception occurs a bit down, it prints the router_db09:15
jschwarzkevinbenton, http://logs.openstack.org/89/417089/3/experimental-tripleo/gate-tripleo-ci-centos-7-ovb-ha/19f0335/logs/overcloud-controller-1/var/log/neutron/l3-agent.txt.gz#_2017-01-07_10_37_31_32209:16
openstackgerritJohn Schwarz proposed openstack/neutron: DNM: debug for ha  https://review.openstack.org/41708909:17
openstackgerritJohn Schwarz proposed openstack/neutron: DNM: debug for ha  https://review.openstack.org/41708909:21
jschwarzkevinbenton, anyway I'm not clear on what's calling that code again so I'm a bit lost... added some more debug logs and will reproduce it again at the gate (though it may take some time)09:23
*** kobis has joined #openstack-neutron09:23
jschwarzkevinbenton, do you have some time to talk about our lords and saviors https://review.openstack.org/#/c/357966/ and https://review.openstack.org/#/c/386077/ while we're at it? :09:23
jschwarz:)09:23
kevinbentonjschwarz: hang on, looking at these logs09:23
jschwarzack09:24
kevinbentonjschwarz: so after this change09:25
kevinbentonjschwarz: routers no longer have an interface on the HA network after being created09:25
kevinbentonjschwarz: so something could come in a delete the HA network... :/09:26
jschwarzkevinbenton, say what?09:26
jschwarzafter what change?09:26
kevinbentonjschwarz: after our change, we no longer create HA interfaces on the HA network during router creation09:27
kevinbentonjschwarz: after your change09:27
kevinbentonjschwarz: whatever you want to call it09:27
jschwarzkevinbenton, you mean https://review.openstack.org/#/c/317949/ ?09:27
kevinbentonjschwarz: yep09:27
jschwarzkevinbenton, ahhh09:27
kevinbentonjschwarz: so if another HA router gets deleted on that tenant in the interim09:28
jschwarzkevinbenton, so by the time https://review.openstack.org/#/c/317949/28/neutron/scheduler/l3_agent_scheduler.py@326 is ran, the ha network has already been deleted?09:28
kevinbentonjschwarz: yes, i think something else must come along and wipe out the HA network09:28
kevinbentonjschwarz: but I'm trying to confirm09:28
jschwarzwell that's a bummer09:28
jschwarzlet me run this locally09:28
jschwarzkevinbenton, but if the HA network has been deleted, the vr_id should also have been deleted09:31
jschwarzand the re-creation of it should have the value 109:31
jschwarzno?09:31
kevinbentonjschwarz: yeah, it doesn't look like that's the problem09:31
kevinbentonjschwarz: because i see a mention of the HA network ID09:31
kevinbentonjschwarz: before even the first sync09:31
jschwarzand it doesn't change?09:31
kevinbentonjschwarz: well i can't tell which version the l3 agent first got09:32
kevinbentonjschwarz: but the network existing before that first sync09:33
kevinbentonjschwarz: so it wasn't created afterwards09:34
kevinbentonjschwarz: and you're right that it should have been the same vr-ID of 109:34
jschwarzkevinbenton, was a nice idea though :)09:34
kevinbentonjschwarz: we can lose the HA network now though, right? or do we have a relational constraint that would stop network deletion if an HA router exists09:35
jschwarzkevinbenton, I think it can be delete09:36
jschwarzd09:36
jschwarzkevinbenton, but the scheduler should be smart enough to re-create it with the create_with_dependency09:36
kevinbentonjschwarz: then the scheduling would just create a new one09:36
kevinbentonjschwarz: yeah09:36
*** shausy has joined #openstack-neutron09:40
kevinbentonjschwarz: the ALLOCATING filter only applies to what is returned to the agent, right?09:44
jschwarzkevinbenton, right09:44
kevinbentonjschwarz: couldn't that still trigger interface building then?09:44
*** shausy has quit IRC09:45
kevinbentonjschwarz: i see here the router is in ALLOCATING in process_sync_data http://logs.openstack.org/89/417089/3/experimental-tripleo/gate-tripleo-ci-centos-7-ovb-ha/19f0335/logs/overcloud-controller-1/var/log/neutron/server.txt.gz#_2017-01-07_10_37_22_00209:45
jschwarzkevinbenton, yes, but process_sync_data should eventually filter that one out, and it shouldn't be able to modify anything09:47
kevinbentonjschwarz: when is that interface building triggered?09:47
jschwarzkevinbenton, only on create_router, update_router and the scheduler09:47
kevinbentonjschwarz: right, but when is the scheduler called?09:48
kevinbentonjschwarz: before or after filtering?09:48
jschwarzkevinbenton, after09:48
kevinbentonjschwarz: sck09:48
kevinbentonjschwarz: ack09:48
jschwarzkevinbenton, the scheduler filters it out, and create_router calls it on its own when it's already filtered09:48
kevinbentonjschwarz: well create_router doesn't call it at all anymore09:48
kevinbentonjschwarz: same with update_router09:49
kevinbentonjschwarz: at least not interfaces, right?09:49
jschwarzwhy not?09:49
jschwarzah right09:49
jschwarzkevinbenton, but see here:09:49
jschwarzkevinbenton, https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L41709:49
jschwarzkevinbenton, this in turn triggers the scheduler's creation of the interfaces09:49
kevinbentonjschwarz: oh09:50
kevinbentonjschwarz: so we still end up creating interfaces as part of create_router09:50
jschwarzkevinbenton, yes - after RouterL3AgentBinding09:50
jschwarzbut that's later down the line09:50
kevinbentonjschwarz: oh, i wonder if the issue is that we are setting the vr_id on the extra attrs outside of a transaction09:52
kevinbentonjschwarz: and so it randomly gets flushed to the DB at a later time09:52
kevinbentonjschwarz: https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L191-L19309:52
jschwarzkevinbenton, :S09:52
kevinbentonjschwarz: we aren't calling that inside of a transaction anymore09:52
jschwarzkevinbenton, but https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L158 is giving us a transaction anyway, no?09:53
kevinbentonjschwarz: that transaction is closed when that function exits09:53
kevinbentonjschwarz: well when that context manager exits09:53
kevinbentonjschwarz: so we allocate one09:53
kevinbentonjschwarz: but then the assingment to extra attrs model is outisde09:54
jschwarzermmm09:54
jschwarzkevinbenton, so shouldn't _allocate_vr_id fail the second time?09:55
jschwarzbecause the ha network already has a vr_id?09:55
kevinbentonjschwarz: ha networks have multiple vr ids09:55
jschwarzkevinbenton, no they don't09:55
kevinbentonjschwarz: yes they do09:55
kevinbentonjschwarz: why do you think that table exists :P09:55
jschwarzkevinbenton, ah right09:56
jschwarzI was thinking about something else :P09:56
kevinbentonjschwarz: let me do some testing locally really quick09:56
jschwarzkevinbenton, likewise09:56
kevinbentonjschwarz: i've run into issues before where making modifications to a model outside of a transaction led to late commited or even lost changes09:57
kevinbentonjschwarz: this probem existed with the quota engine09:57
jschwarzkevinbenton, but my patch didn't change the behavior - it was already outside a transaction before09:58
jschwarzkevinbenton, why did it only now start failing?09:58
kevinbentonjschwarz: well we did change the timing of when the attribute was next referenced10:00
kevinbentonjschwarz: https://review.openstack.org/#/c/317949/28/neutron/db/l3_hamode_db.py10:00
kevinbentonjschwarz: L435 of the old version10:00
kevinbentonjschwarz: that may have flushed the change to the db10:00
jschwarzaye10:00
kevinbentonjschwarz: before schedule_router10:00
jschwarzwell that's a bummer :P10:00
kevinbentonjschwarz: but I need to confirm the behavior is indeed weird with something concrete10:01
kevinbentonjschwarz: the fix will be really simple if that's the problem10:01
jschwarzkevinbenton, ack10:01
jschwarzkevinbenton, but even if it wasn't yet committed, shouldn't create a new vr_id10:01
jschwarzkevinbenton, the ha network is created and committed so it shouldn't need to create a new vr_id10:01
kevinbentonjschwarz: yes it does, vr_id's aren't per ha network :)10:02
kevinbentonjschwarz: they are per router10:02
jschwarzkevinbenton, erm right again :P10:02
*** kobis has quit IRC10:02
jschwarzkevinbenton, so the logic in https://review.openstack.org/#/c/317949/28/neutron/scheduler/l3_agent_scheduler.py@326 isn't really correct then10:03
kevinbentonjschwarz: yeah, actually i'm not sure how this is supposed to work :)10:03
jschwarzkevinbenton, if the ha network exists but no vr_id exists for that router, one won't be created10:03
kevinbentonjschwarz: right10:04
* jschwarz oopses10:04
kevinbentonjschwarz: but unless it couldn't find the ha network, i don't see what would trigger a new allocation10:04
jschwarzkevinbenton, aye, that's what puzzling me10:05
*** mickeys has quit IRC10:07
*** prateek has quit IRC10:09
jschwarzkevinbenton, so the first API request was create_router10:09
jschwarzkevinbenton, if the second one was something like add_router_interface, that would trigger a schedule_routers() call10:10
jschwarzthis might lead to a re-creation of vr id if some data is not comitted10:10
kevinbentonjschwarz: but the network should be committing fine10:11
jschwarzalas, everything other than the extra_attrs.ha_vr_id is in a transaction10:11
*** kevo has joined #openstack-neutron10:16
*** prateek has joined #openstack-neutron10:19
kevinbentonjschwarz: definitely keeps the same ha network10:28
kevinbentonjschwarz: http://logs.openstack.org/89/417089/3/experimental-tripleo/gate-tripleo-ci-centos-7-ovb-ha/19f0335/logs/overcloud-controller-0/var/log/neutron/server.txt.gz#_2017-01-07_10_37_18_98510:28
kevinbentonjschwarz: 22f0fb93 is the uuid of the network when vr_id 2 shows up later10:28
jschwarzbrb10:29
kevinbentonjschwarz: and the request ID of that line belongs to the HTTP POST10:29
kevinbentonjschwarz: ok10:29
*** yamahata has quit IRC10:30
jschwarzkevinbenton, :<10:30
jschwarzkevinbenton, so wth10:30
jschwarzkevinbenton, ok so look10:32
jschwarzkevinbenton, nvm :< dead end10:32
*** gvrangan has quit IRC10:40
* jschwarz likes Sushi for lunch10:48
*** salv-orlando has joined #openstack-neutron10:49
kevinbentonjschwarz: that does make a good lunch :)10:49
jschwarzkevinbenton++10:49
jschwarzand to think I didn't like Sushi until 6 months ago10:49
*** claudiub has joined #openstack-neutron10:51
*** salv-orlando has quit IRC10:53
kevinbentonjschwarz: it's addictive :)10:54
kevinbentonjschwarz: picking up smoking might be cheaper :P10:54
*** jhershbe has quit IRC10:55
jschwarzkevinbenton, lol, yeah10:55
*** slaweq_ has quit IRC11:02
*** slaweq_ has joined #openstack-neutron11:03
jschwarzkevinbenton, hopefully the gate for the latest patch will fail and will give a proper traceback explaining what flow is triggering the allocation11:04
jschwarzI'm lost :<11:04
jschwarzit should finish in ~15 minutes11:04
*** mickeys has joined #openstack-neutron11:07
openstackgerritKevin Benton proposed openstack/neutron: test  https://review.openstack.org/41767211:11
kevinbentonjschwarz: more stuff to tell if it's being called &&11:11
kevinbenton^^11:11
kevinbentonjschwarz: i need a 'check experimental' right?11:11
*** mickeys has quit IRC11:12
jschwarzkevinbenton, yes, but you want to "Depends-On: I5aa89db3624bd4fd7da8681d7b6e86618b93e4cb"11:12
jschwarzwhich adds debug logs for the neutron processes11:12
kevinbentonah11:12
openstackgerritKevin Benton proposed openstack/neutron: test  https://review.openstack.org/41767211:13
kevinbentonjschwarz: it's not in the tripleo queue11:14
kevinbentonjschwarz: is there a diff keyword for that?11:14
jschwarzkevinbenton, nope11:14
kevinbentonjschwarz: oh, wrong queue11:14
kevinbentonjschwarz: i was looking at check-tripleo11:14
jschwarzkevinbenton, yep :)11:14
*** jhershbe has joined #openstack-neutron11:15
kevinbentonjschwarz: it could be that we have another bug lurking and this just altered the timing enough to reveal it11:15
jschwarzkevinbenton, agreed11:16
jschwarzkevinbenton, the run I started didn't fail11:17
jschwarzkevinbenton, :< need to recheck11:17
jschwarzwith my luck, the logs I added changed the timings and now everything works11:17
jschwarzkevinbenton, hold on, it did fail11:19
jschwarzkevinbenton, http://logs.openstack.org/89/417089/5/experimental-tripleo/gate-tripleo-ci-centos-7-ovb-ha/9999697/logs/ :)11:19
*** bigjools_ is now known as bigjools11:19
*** tbachman has quit IRC11:19
*** bigjools has quit IRC11:20
*** bigjools has joined #openstack-neutron11:20
kevinbentonjschwarz: what's the word?11:20
jschwarzlooking11:20
jschwarzkevinbenton, my browser isn't working with me very nicely, need to wget the files... :<11:21
kevinbentonjschwarz: yeah, these are brutal11:21
jschwarzkevinbenton, allocation #1: http://logs.openstack.org/89/417089/5/experimental-tripleo/gate-tripleo-ci-centos-7-ovb-ha/9999697/logs/overcloud-controller-0/var/log/neutron/server.txt.gz#_2017-01-08_11_10_07_89011:21
jschwarzkevinbenton, allocation #2: http://logs.openstack.org/89/417089/5/experimental-tripleo/gate-tripleo-ci-centos-7-ovb-ha/9999697/logs/overcloud-controller-0/var/log/neutron/server.txt.gz#_2017-01-08_11_10_10_95611:22
jschwarzkevinbenton, so uhh11:23
jschwarzlet me pastebin11:24
jschwarzkevinbenton, http://pastebin.com/uNZGz00Y11:24
jschwarzkevinbenton, the first allocation is from inside the schedule(), the second one is from create_router's call to _set_vr_id_and_ensure_network11:24
jschwarzah wow11:25
jschwarzI didn't even think of this flow!11:25
jschwarzthe super().create_router() calls schedule() on it's own11:25
jschwarz:S11:25
jschwarzwtf this is some crazy ass bug11:25
jschwarzkevinbenton, anyways I'll solve it by removing one of those calls (the schedule() from the super() shouldn't happen) and put in a transaction for _set_vr_id11:27
jschwarzkevinbenton, I assume a normal subtransaction is ok?11:30
kevinbentonjschwarz: yep11:30
*** belharar has quit IRC11:31
kevinbentonjschwarz: just approve my patch :)11:31
kevinbentonjschwarz: and it should fix it11:31
jschwarzkevinbenton, lol :P11:32
jschwarzkevinbenton, jenkins doesn't agree with you :P11:32
kevinbentonjschwarz: jenkins is having a bad day11:32
jschwarzkevinbenton, :)11:33
kevinbentonjschwarz: since the base thing calls schedule, we can actually get rid of the schedule call completely in l3 HA11:33
kevinbentonjschwarz: once my patch is in11:33
*** kevo has quit IRC11:34
kevinbentonjschwarz: we have to be careful ripping it out of the base one because other l3 plugins not based on HA may depend on it11:34
*** slaweq_ has quit IRC11:34
jschwarzkevinbenton, the base code doesn't always call schedule though11:34
kevinbentonjschwarz: ok, well we'll have to leave it then11:34
jschwarzkevinbenton, it only does if external_gateway was provided when create_router was called11:34
kevinbentonjschwarz: but once we are on callbacks, the order will be fixed11:34
jschwarzkevinbenton, I'll review your code after I submit a patch to fix the gate failure11:35
*** slaweq_ has joined #openstack-neutron11:36
jschwarzkevinbenton, adding "context.session.begin(subtransactions=True)" to _set_vr_id doesn't like me11:36
jschwarzkevinbenton, "sqlalchemy.exc.InvalidRequestError: A transaction is already begun.  Use subtransactions=True to allow subtransactions." for the begin() in _allocate_vr_id11:36
kevinbentonjschwarz: oh, we must call it in a transaction from somewhere then11:37
kevinbentonjschwarz: leave it be for now :)11:37
jschwarzkevinbenton, lol11:37
jschwarzkevinbenton, EmilienM wants this fixed asap for the tripleo gate though11:37
jschwarzit's breaking them11:37
jschwarzand I want to fix it because it bothers me :P11:37
kevinbentonjschwarz: how are you going to fix it?11:37
jschwarzkevinbenton, putting the "router_db.extra_attributes.ha_vr_id = XXX" in a transaction, and removing the call to _set_vr_id_and_ensure_network from create_router and update_router11:38
jschwarzah but then I also need to fix the bad logic in the schedulers11:39
jschwarzkevinbenton, can we change https://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L158 to an autonested_transaction?11:42
kevinbentonjschwarz: no11:43
kevinbentonjschwarz: that breaks retries11:43
kevinbentonjschwarz: what you can do though is split them into two lines11:43
kevinbentonjschwarz: this i mean11:43
kevinbentonhttps://github.com/openstack/neutron/blob/master/neutron/db/l3_hamode_db.py#L192-L19311:43
kevinbentonjschwarz: allocate outside of transaction11:43
jschwarzkevinbenton, ack11:44
kevinbentonjschwarz: then assign to the extra attr inside a transaction11:44
jschwarzkevinbenton, looks better11:45
jschwarzright, working on a fix, will let you know when it's up11:46
jschwarzkevinbenton, when are you planning to log off?11:46
kevinbentonjschwarz: will be around for a while longer11:46
kevinbentonjschwarz: want to get my patches fixed up11:46
*** rdo has quit IRC11:50
*** rdo has joined #openstack-neutron11:51
jschwarzkevinbenton, so I'm thinking we're gonna want a unique constrain for the vr id allocation11:57
jschwarzkevinbenton, like you talked about before11:57
kevinbentonjschwarz: unfortunately we can't have contract scripts anymore11:58
jschwarzkevinbenton, yay us11:58
kevinbentonjschwarz: so i think we should probably just have a one line query to check that the router doesn't have a VR_ID already11:59
jschwarzkevinbenton, but if 2 threads concurrently check that query...11:59
jschwarzkevinbenton, like, 2 auto_schedule_routers() running and bind_router was successful for 2 different agents11:59
kevinbentonjschwarz: i don't think 2 threads can land there can they?12:00
jschwarzthey can override its other's extra_attrs.ha_vr_id12:00
jschwarzit's possible12:00
kevinbentonjschwarz: how?12:00
jschwarzkevinbenton, unless the chosen_agents is sorted, in which case they can't12:00
kevinbentonjschwarz: we don't schedule until vr_id is allocated12:00
jschwarzkevinbenton, that's what's happening now12:01
jschwarzwe create the RouterL3AgentBinding and only then realize we need a new ha_vr_id12:01
kevinbentonjschwarz: no, what's happening now is we are scheduling before VR_ID12:01
kevinbentonjschwarz: and that's what you're fixing, right?12:02
openstackgerritJohn Schwarz proposed openstack/neutron: DNM: debug for ha  https://review.openstack.org/41708912:02
jschwarzkevinbenton, have a look at ^12:02
jschwarz(a wip fix of what I had in mind)12:02
jschwarzwell, we could fix it in another, simpler way12:03
jschwarzof just calling _set_vr_id_and_ensure_network before we start iterating over the chosen_agents12:03
jschwarzkevinbenton, in https://review.openstack.org/#/c/417089/6/neutron/scheduler/l3_agent_scheduler.py@39212:04
jschwarzkevinbenton, then we'll really schedule until vr_id is allocated12:04
jschwarzs/until/after/g12:04
jschwarzthoughts?12:04
kevinbentonevery time you call  _set_vr_id_and_ensure_network it allocates another vr_id12:05
jschwarzkevinbenton, agreed12:05
jschwarzkevinbenton, but we can't call _set_vr_id without the safe creation loop for the ha network12:05
jschwarzwe can do a "if not router_db.extra_attributes.ha_vr_id:", but that's not concurrently safe12:06
kevinbentonjschwarz: actually, if you move router_db.extra_attributes.ha_vr_id assingment into the allocate function12:07
kevinbentonjschwarz: so it's part of the same transaction12:07
kevinbentonjschwarz: it will become safe12:07
jschwarzthen it's safe12:07
jschwarzand if it's created more than once - so be it12:07
kevinbentonjschwarz: because if something else races, one will hit a staledataerror12:07
*** mickeys has joined #openstack-neutron12:08
*** iranzo has quit IRC12:12
*** mickeys has quit IRC12:13
*** iranzo has joined #openstack-neutron12:14
*** gongysh has quit IRC12:14
*** markvoelker has quit IRC12:15
*** brault has joined #openstack-neutron12:23
*** jhershbe has quit IRC12:26
*** thorst has joined #openstack-neutron12:30
*** bkopilov has quit IRC12:31
*** thorst has quit IRC12:32
*** nyechiel has quit IRC12:38
openstackgerritJohn Schwarz proposed openstack/neutron: l3scheduler: create ha_vr_id more robustly  https://review.openstack.org/41708912:42
jschwarzkevinbenton, ^12:42
jschwarzkevinbenton, will be happy if we can merge it quickly so reviews would be obviously appreciated ;-)12:43
kevinbentonjschwarz: missing a check12:44
kevinbentonjschwarz: left a couple of comments12:44
jschwarzkevinbenton, ack12:45
*** jhershbe has joined #openstack-neutron12:47
*** salv-orlando has joined #openstack-neutron12:50
*** kobis has joined #openstack-neutron12:51
*** salv-orlando has quit IRC12:55
openstackgerritJohn Schwarz proposed openstack/neutron: l3scheduler: create ha_vr_id more robustly  https://review.openstack.org/41708912:55
jschwarzkevinbenton, ^ :)12:55
kevinbentonjschwarz: is 0 a valid VR_ID?12:56
*** tommylikehu has quit IRC12:56
jschwarzkevinbenton, nope12:56
jschwarzit starts from 112:56
*** tommylikehu has joined #openstack-neutron12:57
kevinbentonjschwarz: you don't want to get rid of _set_vr_id?12:57
jschwarzkevinbenton, forgot to post replies12:57
jschwarzkevinbenton, it's still used by _set_vr_id_and_ensure_network (to extrapolate network_id)12:57
kevinbentonjschwarz: why can't it call _allocate_vr_id ?12:58
kevinbentonjschwarz: adjust the signature of _allocate_vr_id to accept the same thing _set_vr_id used to12:58
jschwarzkevinbenton, ah13:00
jschwarzright, silly me O.o13:00
oansonHi. I have a strange issue with openstack: It returns "'NoneType' object is not iterable" when I create a router (router is created)13:01
oansonIt seems availability_zone_hints is None, rather than a list.13:02
oansonIs this known? Where there changes in that area?13:03
kevinbentonoanson: not that i've heard of13:03
jschwarzoanson, can you provide a full traceback?13:04
oansonYes. One sec13:04
oansonAvailable here: http://paste.fedoraproject.org/522599/8069414813:05
oansonI added a try/catch clause myself. Otherwise the traceback wouldn't appear.13:05
jschwarzoanson, sorry, not familiar with that code13:06
oansonjschwarz, kevinbenton, thanks. I'll keep digging.13:07
*** mickeys has joined #openstack-neutron13:09
*** tbachman has joined #openstack-neutron13:13
*** mickeys has quit IRC13:13
*** markvoelker has joined #openstack-neutron13:16
jschwarzkevinbenton, done13:16
openstackgerritJohn Schwarz proposed openstack/neutron: l3scheduler: create ha_vr_id more robustly  https://review.openstack.org/41708913:16
*** yfried has quit IRC13:18
*** prateek has quit IRC13:19
roeycoanson: have a look here https://bugs.launchpad.net/python-openstackclient/+bug/165202513:20
openstackLaunchpad bug 1652025 in python-openstackclient "Traceback after subnet create" [Undecided,In progress] - Assigned to Roey Chen (roeyc)13:20
oansonroeyc, yes. This is it! Thanks!13:21
*** markvoelker has quit IRC13:21
*** gkadam has joined #openstack-neutron13:22
openstackgerritKevin Benton proposed openstack/neutron: Simplify AZ string conversion  https://review.openstack.org/41766113:22
*** tbachman has quit IRC13:23
*** bobmel has joined #openstack-neutron13:23
*** tbachman has joined #openstack-neutron13:23
*** prateek has joined #openstack-neutron13:24
kevinbentonjschwarz: what is the purpose of changing https://review.openstack.org/#/c/417089/9/neutron/scheduler/l3_agent_scheduler.py ?13:25
*** bobmel_ has joined #openstack-neutron13:26
kevinbentonjschwarz: wasn't it fine the way it was?13:26
jschwarzkevinbenton, nope13:26
kevinbentonjschwarz: why?13:26
jschwarzkevinbenton, well it was since _set_vr_id_and_ensure_network was called from the create_router() logic13:26
jschwarzbut now that it isn't, in case an ha network already exists, it would never create a vr_id allocation now13:27
kevinbentonjschwarz: oh, i see13:27
*** bobmel has quit IRC13:28
kevinbentonjschwarz: two more small changes13:28
jschwarzkevinbenton, will do13:29
*** moshele has quit IRC13:32
*** moshele has joined #openstack-neutron13:33
*** tbachman has quit IRC13:33
*** moshele has quit IRC13:34
*** moshele has joined #openstack-neutron13:34
openstackgerritgaryk proposed openstack/neutron: Remove python 3.4 support  https://review.openstack.org/41595213:38
*** bobmel_ has quit IRC13:38
*** tbachman has joined #openstack-neutron13:39
*** garyk has quit IRC13:41
*** tbachman has quit IRC13:43
*** bobmel has joined #openstack-neutron13:45
jschwarzkevinbenton, and yet another ping ^_^13:46
*** tbachman has joined #openstack-neutron13:46
openstackgerritJohn Schwarz proposed openstack/neutron: l3scheduler: create ha_vr_id more robustly  https://review.openstack.org/41708913:46
*** tbachman has quit IRC13:50
kevinbentonjschwarz: lgtm13:51
*** salv-orlando has joined #openstack-neutron13:52
jschwarzkevinbenton, pleasure doing business with you :)13:52
*** xinliang has quit IRC13:53
*** limao has joined #openstack-neutron13:55
*** salv-orlando has quit IRC13:56
*** mriedem1 has joined #openstack-neutron13:59
*** mriedem has quit IRC13:59
*** bobmel has quit IRC14:02
*** wolverineav has joined #openstack-neutron14:03
*** xinliang has joined #openstack-neutron14:06
*** mickeys has joined #openstack-neutron14:10
*** gkadam is now known as newnick14:12
*** newnick is now known as gkadam14:12
*** itzikb has quit IRC14:13
*** mickeys has quit IRC14:14
openstackgerritJohn Schwarz proposed openstack/neutron: Revert "Add ALLOCATING state to routers"  https://review.openstack.org/35796614:16
*** markvoelker has joined #openstack-neutron14:17
openstackgerritKevin Benton proposed openstack/neutron: Decompose router extra attr processing  https://review.openstack.org/41760414:18
kevinbentonjschwarz: what else did you want to chat about?14:19
jschwarzkevinbenton, https://review.openstack.org/357966 and https://review.openstack.org/#/c/386077/14:19
jschwarzkevinbenton, the last missing pieces of The Great L3 Scheduler Refactor14:19
jschwarzTGLSR!14:19
*** gkadam has quit IRC14:20
*** shausy has joined #openstack-neutron14:21
*** gkadam has joined #openstack-neutron14:21
*** markvoelker has quit IRC14:22
*** mriedem1 is now known as mriedem14:22
openstackgerritJohn Schwarz proposed openstack/neutron: Refactor L3 scheduler (unify code paths)  https://review.openstack.org/38607714:25
jschwarzkevinbenton, reviewing your patches next14:26
*** wolverineav has quit IRC14:26
jschwarzkevinbenton, re: https://review.openstack.org/#/c/399505, the commit message mentions that if the scheduler threw an error it's now ignored (puts the router into ERROR)14:28
*** shausy has quit IRC14:28
jschwarzworth mentioning that the scheduler should be safe as it is (doesn't throw exceptions afair)14:28
kevinbentonjschwarz: not even if all agents disappear?14:29
*** wolverineav has joined #openstack-neutron14:29
*** shausy has joined #openstack-neutron14:29
*** wolverineav has quit IRC14:30
jschwarzkevinbenton, I didn't check all the possible scenarios, mind you ;-)14:30
*** bobmel has joined #openstack-neutron14:32
*** thorst has joined #openstack-neutron14:32
openstackgerritJohn Schwarz proposed openstack/neutron: Revert "Add ALLOCATING state to routers"  https://review.openstack.org/35796614:35
*** tommylikehu_ has quit IRC14:36
*** thorst has quit IRC14:37
*** armax has joined #openstack-neutron14:37
*** reedip has quit IRC14:39
*** wolverineav has joined #openstack-neutron14:45
*** belharar has joined #openstack-neutron14:46
*** moshele has quit IRC14:47
*** bobmel has quit IRC14:49
*** fzdarsky__ has quit IRC14:49
*** wolverineav has quit IRC14:50
*** jhershbe has quit IRC14:51
*** bobmel has joined #openstack-neutron14:52
*** gus has quit IRC14:52
*** salv-orlando has joined #openstack-neutron14:52
*** reedip has joined #openstack-neutron14:53
*** gus has joined #openstack-neutron14:54
*** nyechiel has joined #openstack-neutron14:56
openstackgerritJohn Schwarz proposed openstack/neutron: Revert "Add ALLOCATING state to routers"  https://review.openstack.org/35796614:56
*** salv-orlando has quit IRC14:57
*** wolverineav has joined #openstack-neutron14:57
*** fzdarsky has joined #openstack-neutron15:00
*** bobmel has quit IRC15:01
*** wolverineav has quit IRC15:02
jschwarzkevinbenton, replied on https://review.openstack.org/#/c/386077/515:05
* jschwarz likes the fast iterations15:05
*** moshele has joined #openstack-neutron15:05
kevinbentonjschwarz: so we still have two different ways scheduling can occur15:07
kevinbentonjschwarz: either right after router creation (or interface attachment in legacy case)15:07
kevinbentonjschwarz: or if auto_schedule_routers is called15:07
*** bobmel has joined #openstack-neutron15:08
kevinbentonjschwarz: right?15:08
jschwarzkevinbenton, correct15:08
jschwarzkevinbenton, but they both use the same code paths now15:08
kevinbentonjschwarz: when does the l3 agent call auto_schedule_routers15:09
kevinbentonjschwarz: only on a sync right?15:09
jschwarzkevinbenton, on get_router_ids (the one before the sync)15:10
*** armax has quit IRC15:10
kevinbentonjschwarz: but it only calls in reaction to something else is what i mean15:10
kevinbentonjschwarz: on startup or if something updates?15:10
kevinbentonjschwarz: i'm trying to understand when auto_schedule_routers will be called15:11
jschwarzkevinbenton, yes15:11
*** mickeys has joined #openstack-neutron15:11
jschwarzkevinbenton, on startup of an agent, or on a full_sync15:11
kevinbentonjschwarz: and a full sync now only occurs on error?15:11
jschwarzkevinbenton, iirc yes15:11
*** fzdarsky is now known as fzdarsky|afk15:12
kevinbentonjschwarz: ok. it's out of scope of this patch, but I think this needs to go away in its current form15:12
*** fzdarsky|afk has quit IRC15:13
jschwarzkevinbenton, I agree15:13
jschwarzkevinbenton, once we have all the OVOs for routers, we can do some good push notification logic here and change a lot of how it works15:13
kevinbentonjschwarz: regardless of that, it's just stupid scheduling15:13
jschwarzkevinbenton, lol15:13
kevinbentonjschwarz: first router that happens to hit this will consume every unscheduled router15:14
kevinbentonjschwarz: even if it's fully loaded15:14
jschwarzunderscheduled, you mean15:14
kevinbentonjschwarz: either15:14
jschwarzkevinbenton, yep15:14
kevinbenton<1 for legacy15:14
jschwarzkevinbenton, we can change this into some kind of a global scheduler for all the routers and all the agents15:14
jschwarzlike a load-balancer scheduler or something15:14
kevinbentonjschwarz: we already have that15:15
kevinbentonjschwarz: it happens during normal router scheduling15:15
kevinbentonjschwarz: or maybe that's just dhcp agents?15:15
jschwarzkevinbenton, if we use the LeastRoutersScheduler, yes15:15
kevinbentonjschwarz: right15:16
kevinbentonjschwarz: but auto schedule just completely ignores that15:16
jschwarzkevinbenton, but that doesn't work the same for auto_schedule_routers15:16
jschwarzyep15:16
kevinbentonjschwarz: i'm not sure what the point of auto schedule routers is now15:16
*** bobmel has quit IRC15:16
*** mickeys has quit IRC15:16
jschwarzkevinbenton, the point was always "here's a new agent, lets share the load". whether or not it's smart about it is a different story15:17
*** wolverineav has joined #openstack-neutron15:17
kevinbentonjschwarz: but it doesn't share the load15:17
*** bobmel has joined #openstack-neutron15:17
kevinbentonjschwarz: no routers should ever match the criteria unless there was an error scheduling before15:17
jschwarzkevinbenton, on HA routers there could be a case where it does - if max_l3_agents is high enough15:17
jschwarzbut yeah, that's sucky15:17
*** markvoelker has joined #openstack-neutron15:18
jschwarzyou'd expect something like a rescheduling of some of the existing routers to the new agent15:18
jschwarzor something like that15:18
kevinbentonjschwarz: i can see the case for HA adding more instances15:18
jschwarzkevinbenton, how does the dhcp scheduler does it?15:19
kevinbentonjschwarz: there is no auto_schedule15:20
kevinbentonjschwarz: that i can think of15:20
kevinbentonjschwarz: nothing triggered by the agent15:20
*** wolverineav has quit IRC15:21
*** markvoelker has quit IRC15:22
*** dave-mccowan has joined #openstack-neutron15:25
kevinbentonjschwarz: let me ponder on it over the rest of the weekend :)15:26
kevinbentonjschwarz: i'm wondering if it's time to dump auto_schedule_routers15:26
jschwarzkevinbenton, meh15:27
jschwarzkevinbenton, we could have done that one like a year ago, and it would have prevented 99% of the races we fixed :P15:27
jschwarzkevinbenton, jokes aside though, I do like the general idea of the auto schedule concept. that it's bad is something else and we can improve it over time (that's what my patches intend to start to do)15:28
kevinbentonjschwarz: can you explain to me what you want it to do though?15:28
kevinbentonjschwarz: is it just for adding more HA instances?15:29
jschwarzkevinbenton, the long game plan is making it actually useful15:30
kevinbentonjschwarz: how?15:30
kevinbentonjschwarz: all routers are scheduled after creation15:30
kevinbentonjschwarz: there shouldn't be a case for it to do something15:30
kevinbentonjschwarz: that's what I'm trying to wrap my head around15:30
*** bobmel has quit IRC15:30
jschwarzkevinbenton, as in, if I have 50 routers on node 1 and 50 routers on node 2, surely an addition of a new node can unschedule some of these routers to make it a 33/33/3415:30
jschwarzor something along those lines15:31
kevinbentonjschwarz: no, that disrupts traffic15:31
jschwarzkevinbenton, not sure it distrupts floatingips traffic15:32
kevinbentonjschwarz: for ha maybe you could shuffle some standby ones around15:32
jschwarzkevinbenton, snat traffic can be managed through contrackd I think (but didn't make sure)15:32
kevinbentonjschwarz: so you want to implement live migration of conntrackd state? :)15:32
jschwarzkevinbenton, YES! :D15:33
kevinbentonjschwarz: you would also need to have the notion of a think being scheduled to both agents while its happening15:33
kevinbentona thing*15:33
jschwarzlol15:33
jschwarzproblems for future me ;-)15:33
kevinbentonjschwarz: we used to have a config option for auto_schedule_routers15:33
*** thorst has joined #openstack-neutron15:34
jschwarzkevinbenton, don't we still?15:34
*** mriedem has quit IRC15:34
*** thorst has quit IRC15:34
jschwarzpretty sure we still do15:34
*** bobmel has joined #openstack-neutron15:34
kevinbentonjschwarz: not that grep showed me15:34
kevinbentonjschwarz: unless it's named something weird15:34
jschwarzkevinbenton, ./neutron/db/l3_agentschedulers_db.py:55:    cfg.BoolOpt('router_auto_schedule', default=True,15:35
jschwarzof course, why not switch some words around to make it interesting to find? :P15:35
kevinbentonjschwarz: ah, the dyslexic defense device15:35
*** rossella_s has joined #openstack-neutron15:39
*** bobmel has quit IRC15:40
kevinbentonjschwarz: https://github.com/openstack/neutron/commit/4c41a259c93e326d5635164047c72c9de207fde515:43
kevinbentonjschwarz: L131 of neutron/db/l3_dvr_db.py15:43
kevinbentonjschwarz: on the new side15:43
jschwarzkevinbenton, yes?15:43
kevinbentonjschwarz: why did you do it on every router update instead of just on migration?15:44
*** gcheresh_ has quit IRC15:44
jschwarzlooking15:44
*** kobis has quit IRC15:44
kevinbentonjschwarz: i.e. put under the "if migrating_to_distributed:" branch15:45
*** Alex_Stef has quit IRC15:45
jschwarzkevinbenton, I didn't introduce the original code15:45
jschwarzkevinbenton, https://review.openstack.org/#/c/404215/2/neutron/db/l3_dvr_db.py15:45
*** yfried has joined #openstack-neutron15:45
kevinbentonjschwarz: ah15:45
jschwarzkevinbenton, the _update_distributed_attr was already there, I only made it more generic so I can reuse it15:45
jschwarzkevinbenton, didn't want to also touch the logic as we needed it for some downstream milestone15:46
kevinbentonjschwarz: makese sense15:46
kevinbentonjschwarz: i'm afraid to touch it right now :)15:46
kevinbentonjschwarz: hence the question15:46
jschwarzkevinbenton, man that code is scary15:46
kevinbentonjschwarz: well it's becoming much shorter15:47
kevinbentonjschwarz: to the point where just that is starting to stand out as odd15:47
jschwarzkevinbenton, but yeah, I agree it should be moved to inside the 'if'15:47
jschwarzthose are some good patches actually :)15:47
*** fidgi has joined #openstack-neutron15:47
*** moshele has quit IRC15:47
*** moshele has joined #openstack-neutron15:48
*** ekuris has quit IRC15:50
* jschwarz is logging off15:55
jschwarzsee you guys tomorrow :)15:55
*** shausy has quit IRC15:56
*** wolverineav has joined #openstack-neutron15:56
*** shausy has joined #openstack-neutron15:56
*** bkopilov has joined #openstack-neutron15:59
kevinbentonjschwarz: bye!15:59
*** wolverineav has quit IRC16:00
*** wolverineav has joined #openstack-neutron16:06
*** fidgi has left #openstack-neutron16:08
*** yfried has quit IRC16:11
*** wolverineav has quit IRC16:11
*** roeyc has quit IRC16:11
*** mickeys has joined #openstack-neutron16:13
*** wolverineav has joined #openstack-neutron16:16
*** mickeys has quit IRC16:17
*** markvoelker has joined #openstack-neutron16:19
*** wolverineav has quit IRC16:20
openstackgerritKevin Benton proposed openstack/neutron: Decompose router extra attr processing  https://review.openstack.org/41760416:22
openstackgerritKevin Benton proposed openstack/neutron: Only migrate ports on DVR migration  https://review.openstack.org/41769916:22
*** markvoelker has quit IRC16:23
*** gkadam has quit IRC16:24
*** moshele has quit IRC16:26
*** shausy has quit IRC16:30
*** moshele has joined #openstack-neutron16:30
*** shausy has joined #openstack-neutron16:30
openstackgerritKevin Benton proposed openstack/neutron: Get rid of create_router override in l3_ha mixin  https://review.openstack.org/39950516:34
*** mdbooth has quit IRC16:34
openstackgerritKevin Benton proposed openstack/neutron: Get rid of L3 HA override of _update_router_db  https://review.openstack.org/39950616:35
*** moshele has quit IRC16:35
*** salv-orlando has joined #openstack-neutron16:35
*** mdbooth has joined #openstack-neutron16:35
*** ushkalim has quit IRC16:36
*** mriedem has joined #openstack-neutron16:36
*** nyechiel has quit IRC16:41
*** wolverineav has joined #openstack-neutron16:45
*** markvoelker has joined #openstack-neutron16:47
*** armax has joined #openstack-neutron16:48
*** wolverineav has quit IRC16:50
*** markvoelker has quit IRC16:52
*** limao has quit IRC16:59
*** wolverineav has joined #openstack-neutron17:05
*** wolverineav has quit IRC17:10
*** nyechiel has joined #openstack-neutron17:11
*** mickeys has joined #openstack-neutron17:14
*** mickeys has quit IRC17:18
*** moshele has joined #openstack-neutron17:21
*** wolverineav has joined #openstack-neutron17:25
*** teclator has quit IRC17:26
*** teclator has joined #openstack-neutron17:26
*** prateek has quit IRC17:26
*** shausy has quit IRC17:27
*** shausy has joined #openstack-neutron17:27
*** haplo37_ has quit IRC17:29
*** salv-orlando has quit IRC17:29
*** wolverineav has quit IRC17:30
*** prateek has joined #openstack-neutron17:32
*** haplo37_ has joined #openstack-neutron17:32
*** thorst has joined #openstack-neutron17:35
*** armax has quit IRC17:35
*** igordcard has quit IRC17:38
*** igordcard has joined #openstack-neutron17:38
*** teclator has quit IRC17:38
*** gkadam has joined #openstack-neutron17:39
*** teclator has joined #openstack-neutron17:39
*** thorst has quit IRC17:39
*** wolverineav has joined #openstack-neutron17:41
*** shausy has quit IRC17:42
openstackgerritMargaret Frances proposed openstack/neutron-lib: FWaaS v2 API reference  https://review.openstack.org/39133817:44
*** wolverineav has quit IRC17:45
*** neiljerram has quit IRC17:47
*** teclator has quit IRC18:02
*** teclator has joined #openstack-neutron18:02
*** gkadam has quit IRC18:06
*** thorst has joined #openstack-neutron18:07
*** thorst has quit IRC18:08
*** ijw has joined #openstack-neutron18:10
*** belharar has quit IRC18:11
*** mickeys has joined #openstack-neutron18:14
*** duartea__ has joined #openstack-neutron18:17
*** mickeys has quit IRC18:18
*** adduarte has quit IRC18:20
*** moshele has quit IRC18:22
*** nyechiel has quit IRC18:25
*** Jack_V has joined #openstack-neutron18:25
*** wolverineav has joined #openstack-neutron18:26
*** salv-orlando has joined #openstack-neutron18:30
*** markmcclain has quit IRC18:30
*** markmcclain has joined #openstack-neutron18:31
*** wolverineav has quit IRC18:31
*** tbachman has joined #openstack-neutron18:31
*** tbachman_ has joined #openstack-neutron18:33
*** salv-orlando has quit IRC18:35
*** tbachman_ has quit IRC18:36
*** tbachman has quit IRC18:36
*** belharar has joined #openstack-neutron18:37
*** grantma has joined #openstack-neutron18:40
*** belharar has quit IRC18:42
*** bobmel has joined #openstack-neutron18:42
*** mickeys has joined #openstack-neutron18:44
*** dave-mccowan has quit IRC18:46
*** wolverineav has joined #openstack-neutron18:46
*** bobmel has quit IRC18:47
*** nyechiel has joined #openstack-neutron18:48
*** wolverineav has quit IRC18:51
*** g3ek has quit IRC18:54
*** nyechiel has quit IRC19:02
*** prateek has quit IRC19:03
*** pcaruana has quit IRC19:03
*** g3ek has joined #openstack-neutron19:04
*** wolverineav has joined #openstack-neutron19:06
*** bobmel has joined #openstack-neutron19:08
*** moshele has joined #openstack-neutron19:08
*** wolverineav has quit IRC19:10
*** matrohon has joined #openstack-neutron19:11
*** prateek has joined #openstack-neutron19:13
*** wolverineav has joined #openstack-neutron19:25
*** yfried has joined #openstack-neutron19:29
*** matrohon has quit IRC19:30
*** wolverineav has quit IRC19:30
*** salv-orlando has joined #openstack-neutron19:31
*** fnaval has joined #openstack-neutron19:31
*** nicolasbock has joined #openstack-neutron19:32
*** fnaval has quit IRC19:33
*** fnaval has joined #openstack-neutron19:34
*** salv-orlando has quit IRC19:35
*** wolverineav has joined #openstack-neutron19:35
*** thorst has joined #openstack-neutron19:37
*** fnaval has quit IRC19:38
*** Jack_V has quit IRC19:40
*** wolverineav has quit IRC19:40
*** thorst has quit IRC19:41
*** fnaval has joined #openstack-neutron19:43
*** fnaval has quit IRC19:43
*** fnaval has joined #openstack-neutron19:44
johnsomIs anyone looking at this issue?19:44
johnsom++ /opt/stack/new/octavia/devstack/plugin.sh:build_mgmt_network:221 :   openstack security group create lb-mgmt-sec-grp19:44
johnsom'SecurityGroup' object has no attribute 'keys'19:44
*** wolverineav has joined #openstack-neutron19:45
johnsomLooks like it started failing sometime after 1/6 11:28am pacific time19:48
*** bobmel_ has joined #openstack-neutron19:49
*** bobmel has quit IRC19:49
*** wolverineav has quit IRC19:50
*** thorst has joined #openstack-neutron19:53
*** thorst has quit IRC19:54
*** rkukura has quit IRC19:57
*** yfried has quit IRC19:58
johnsomIt looks like q-svc returned a 201, so maybe a client issue?20:03
*** ircuser-1 has quit IRC20:06
*** wolverineav has joined #openstack-neutron20:14
*** bobmel_ has quit IRC20:16
*** yfried has joined #openstack-neutron20:18
*** wolverineav has quit IRC20:19
*** bobmel has joined #openstack-neutron20:21
*** wolverineav has joined #openstack-neutron20:25
johnsomYep, if I run with python-openstackclient 3.5.0 no problem, but when I upgrade to 3.6.0 I get the failure20:26
openstackgerritfumihiko kakuma proposed openstack/neutron-dynamic-routing: Enable gate_hook for tempest api test  https://review.openstack.org/41770720:27
*** wolverineav has quit IRC20:29
*** bobmel has quit IRC20:31
*** salv-orlando has joined #openstack-neutron20:32
johnsomPut a bug in: https://bugs.launchpad.net/python-openstackclient/+bug/165488720:33
openstackLaunchpad bug 1654887 in python-openstackclient "Upgrade to 3.6.0 causes AttributeError: 'SecurityGroup' object has no attribute 'keys'" [Undecided,New]20:33
*** rossella_s has quit IRC20:36
*** salv-orlando has quit IRC20:36
*** adriant has joined #openstack-neutron20:41
openstackgerritfumihiko kakuma proposed openstack/neutron-dynamic-routing: Enable gate_hook for tempest api test  https://review.openstack.org/41770720:43
*** tbachman has joined #openstack-neutron20:43
*** wolverineav has joined #openstack-neutron20:44
*** tbachman has quit IRC20:46
*** wolverineav has quit IRC20:48
*** yfried has quit IRC20:49
*** wolverineav has joined #openstack-neutron20:54
*** moshele has quit IRC20:57
*** wolverineav has quit IRC20:59
*** gvrangan has joined #openstack-neutron20:59
*** baoli has joined #openstack-neutron21:04
*** gvrangan has quit IRC21:13
openstackgerritfumihiko kakuma proposed openstack/neutron-dynamic-routing: Enable gate_hook for tempest api test  https://review.openstack.org/41770721:17
*** salv-orlando has joined #openstack-neutron21:33
*** Jeffrey4l_ has quit IRC21:35
*** salv-orlando has quit IRC21:37
*** nicolasbock has quit IRC21:39
*** Alex_Stef has joined #openstack-neutron21:41
*** salv-orlando has joined #openstack-neutron21:47
*** Jeffrey4l_ has joined #openstack-neutron21:47
*** Alex_Stef has quit IRC21:51
*** catintheroof has joined #openstack-neutron21:52
*** Jeffrey4l_ has quit IRC21:57
*** Jeffrey4l_ has joined #openstack-neutron21:58
*** prateek has quit IRC22:00
*** tflynn has joined #openstack-neutron22:02
*** aspiers has quit IRC22:03
*** teclator has quit IRC22:12
*** teclator has joined #openstack-neutron22:12
*** neiljerram has joined #openstack-neutron22:20
*** salv-orl_ has joined #openstack-neutron22:22
*** salv-orlando has quit IRC22:22
*** thorst has joined #openstack-neutron22:24
*** thorst has quit IRC22:24
*** zhhuabj has quit IRC22:25
*** tflynn has quit IRC22:31
*** fnaval has quit IRC22:35
*** jamielennox is now known as jamielennox|away22:37
*** zhhuabj has joined #openstack-neutron22:38
*** bobmel has joined #openstack-neutron22:39
*** neiljerram has quit IRC22:40
*** bobmel has quit IRC22:43
*** nmagnezi has quit IRC22:44
*** jamielennox|away is now known as jamielennox22:53
*** ianw_pto is now known as ianw23:01
*** grantma has quit IRC23:01
*** tommylikehu_ has joined #openstack-neutron23:08
*** ihrachys has joined #openstack-neutron23:11
*** tommylikehu_ has quit IRC23:12
*** reedip has quit IRC23:17
*** reedip has joined #openstack-neutron23:29
*** wolverineav has joined #openstack-neutron23:31
*** gouthamr has joined #openstack-neutron23:32
*** teclator_ has joined #openstack-neutron23:34
*** teclator has quit IRC23:34
*** wolverineav has quit IRC23:36
*** thorst has joined #openstack-neutron23:38
*** kevo has joined #openstack-neutron23:38
*** thorst has quit IRC23:39
*** catintheroof has quit IRC23:41
*** itisha has joined #openstack-neutron23:43
*** reedip has quit IRC23:43
*** teclator_ has quit IRC23:46
*** teclator has joined #openstack-neutron23:46
*** salv-orlando has joined #openstack-neutron23:48
*** salv-orl_ has quit IRC23:48
*** baoli has quit IRC23:48
*** wolverineav has joined #openstack-neutron23:51
*** wolverineav has quit IRC23:56
*** reedip has joined #openstack-neutron23:57
*** ijw has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!