Thursday, 2019-05-09

openstackgerritMerged openstack/neutron master: Fix handling of network:shared field in policy module  https://review.opendev.org/65263600:09
openstackgerritMerged openstack/networking-ovn master: Fix networking-ovn-tempest-dsvm-ovs-master-fedora  https://review.opendev.org/65662100:13
*** mriedem has quit IRC00:15
*** yamamoto has quit IRC00:18
*** ijw has joined #openstack-neutron00:19
*** Weifan has quit IRC00:20
*** ijw has quit IRC00:27
*** SmearedBeard has joined #openstack-neutron00:39
*** hyang has left #openstack-neutron00:45
*** hyang has joined #openstack-neutron00:51
openstackgerritReedip proposed openstack/networking-ovn master: DNM Testing support for Router Scheduling  https://review.opendev.org/65779401:04
openstackgerritReedip proposed openstack/networking-ovn master: DNM Testing support for Router Scheduling  https://review.opendev.org/65779401:07
*** SmearedBeard has quit IRC01:11
*** dsneddon has quit IRC01:15
openstackgerritLIU Yulong proposed openstack/neutron master: Minimizing L3 agent QoS extensions lock granularity  https://review.opendev.org/65616301:15
openstackgerritLIU Yulong proposed openstack/neutron master: Minimizing lock for port forwarding  https://review.opendev.org/65616501:15
*** dsneddon has joined #openstack-neutron01:20
*** dsneddon has quit IRC01:29
*** baojg has joined #openstack-neutron01:32
*** dsneddon has joined #openstack-neutron01:39
*** yamamoto has joined #openstack-neutron01:41
*** sean-k-mooney has quit IRC01:42
*** tbachman has quit IRC01:49
*** tbachman has joined #openstack-neutron01:51
*** yamamoto has quit IRC02:03
*** iyamahat has quit IRC02:24
*** yamahata has quit IRC02:26
*** itlinux has joined #openstack-neutron02:28
*** partlycloudy has joined #openstack-neutron02:34
*** itlinux has quit IRC02:38
*** yamamoto has joined #openstack-neutron02:39
*** yamamoto has quit IRC02:51
*** yamamoto has joined #openstack-neutron02:54
*** JamesBenson has joined #openstack-neutron02:59
openstackgerritGuo Jingyu proposed openstack/neutron-lib master: Add sort_keys retreiving function  https://review.opendev.org/65791303:31
*** dsneddon has quit IRC03:43
*** dsneddon has joined #openstack-neutron03:45
*** dsneddon has quit IRC03:49
*** lpetrut has joined #openstack-neutron03:53
*** ramishra has joined #openstack-neutron03:55
*** wwriverrat has quit IRC04:03
*** ramishra has quit IRC04:03
*** dsneddon has joined #openstack-neutron04:10
*** gcheresh has joined #openstack-neutron04:12
*** ratailor has joined #openstack-neutron04:14
*** lpetrut has quit IRC04:18
*** ramishra has joined #openstack-neutron04:18
*** gcheresh has quit IRC04:34
*** ramishra has quit IRC04:34
*** dsneddon has quit IRC04:37
*** janki has joined #openstack-neutron04:38
*** gcheresh has joined #openstack-neutron04:44
*** ivve has quit IRC04:45
*** gcheresh has quit IRC04:54
*** JamesBenson has quit IRC05:01
*** gcheresh has joined #openstack-neutron05:15
*** samueldmq has quit IRC05:19
*** gcheresh has quit IRC05:25
*** dsneddon has joined #openstack-neutron05:34
*** ramishra has joined #openstack-neutron05:41
*** yamamoto has quit IRC05:42
*** yamamoto has joined #openstack-neutron05:46
*** ivve has joined #openstack-neutron05:49
*** yamamoto has quit IRC05:51
*** ksambor has joined #openstack-neutron06:02
*** hjensas has joined #openstack-neutron06:04
*** slaweq has joined #openstack-neutron06:06
openstackgerritReedip proposed openstack/networking-ovn master: Support for Router Scheduling on addition/removal of chassis  https://review.opendev.org/59146106:06
*** ccamposr has joined #openstack-neutron06:09
*** whoami-rajat has joined #openstack-neutron06:20
openstackgerritzhongshengping proposed openstack/neutron-lib master: Update Python 3 test runtimes for Train  https://review.opendev.org/65792706:26
*** Luzi has joined #openstack-neutron06:26
*** lajoskatona has joined #openstack-neutron06:26
*** yamamoto has joined #openstack-neutron06:28
openstackgerritzhongshengping proposed openstack/neutron master: Update Python 3 test runtimes for Train  https://review.opendev.org/65794006:28
*** yamamoto has quit IRC06:29
*** yamamoto has joined #openstack-neutron06:30
*** dsneddon has quit IRC06:49
*** dsneddon has joined #openstack-neutron06:58
*** maciejjozefczyk has joined #openstack-neutron07:09
*** tesseract has joined #openstack-neutron07:09
*** dsneddon has quit IRC07:11
*** aedc has quit IRC07:15
*** dsneddon has joined #openstack-neutron07:15
*** gcheresh has joined #openstack-neutron07:16
*** panda|off is now known as panda07:19
*** orzel has left #openstack-neutron07:27
*** rpittau|afk is now known as rpittau07:35
*** dsneddon has quit IRC07:45
*** jpena|off is now known as jpena07:45
*** gcheresh has quit IRC07:47
*** aojea has joined #openstack-neutron07:57
*** aedc has joined #openstack-neutron08:17
*** lucasagomes has joined #openstack-neutron08:18
*** ralonsoh has joined #openstack-neutron08:20
*** dsneddon has joined #openstack-neutron08:21
*** tkajinam has quit IRC08:30
*** aedc has quit IRC08:31
*** dsneddon has quit IRC08:36
*** SmearedBeard has joined #openstack-neutron08:37
*** SmearedBeard has quit IRC08:38
*** jangutter has joined #openstack-neutron08:39
openstackgerritLucas Alvares Gomes proposed openstack/networking-ovn master: Distributed OVSDB lock: HashRing common methods and DB migration  https://review.opendev.org/65540708:41
openstackgerritLucas Alvares Gomes proposed openstack/networking-ovn master: Distributed OVSDB lock: Make use of the HashRing  https://review.opendev.org/65540808:41
*** tobias-urdin has joined #openstack-neutron08:41
lucasagomesbcafarel, around ? If you have few minutes mind taking a look at https://review.opendev.org/#/c/657584/ ? The stable/stein branch is broken and that will fix it08:47
*** aedc has joined #openstack-neutron08:47
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron master: FdbInterfaceTestCase interface names should be randomly generated  https://review.opendev.org/65795808:49
openstackgerritGuo Jingyu proposed openstack/neutron-lib master: Add sort_keys retreiving function  https://review.opendev.org/65791308:49
*** panda has quit IRC08:55
openstackgerritGuo Jingyu proposed openstack/neutron-lib master: Add sort_keys retreiving function  https://review.opendev.org/65791308:55
*** panda has joined #openstack-neutron08:55
*** SmearedBeard has joined #openstack-neutron08:57
*** davidsha has joined #openstack-neutron08:58
*** gmann_pto has joined #openstack-neutron08:58
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron master: [DNM] Remove rootwrap-daemon from neutron-keepalived-state-change  https://review.opendev.org/65784909:06
*** dsneddon has joined #openstack-neutron09:13
*** dsneddon has quit IRC09:17
*** tssurya has joined #openstack-neutron09:18
openstackgerritzhongshengping proposed openstack/neutron-lib master: Update Python 3 test runtimes for Train  https://review.opendev.org/65792709:36
openstackgerritzhongshengping proposed openstack/neutron master: Update Python 3 test runtimes for Train  https://review.opendev.org/65794009:37
*** dsneddon has joined #openstack-neutron09:43
*** yamamoto has quit IRC09:45
*** dsneddon has quit IRC09:48
*** tssurya has quit IRC09:57
*** ramishra has quit IRC10:04
*** pbandark has joined #openstack-neutron10:05
*** yamamoto has joined #openstack-neutron10:06
*** ramishra has joined #openstack-neutron10:13
*** mugsie has quit IRC10:25
*** yamamoto has quit IRC10:27
*** yamamoto has joined #openstack-neutron10:27
*** yamamoto has quit IRC10:28
*** yamamoto has joined #openstack-neutron10:32
*** yamamoto has quit IRC10:32
*** yamamoto_ has joined #openstack-neutron10:32
*** davidsha has quit IRC10:33
*** yamamoto_ has quit IRC10:33
*** mugsie has joined #openstack-neutron10:35
*** mugsie has quit IRC10:35
*** mugsie has joined #openstack-neutron10:36
*** mugsie has quit IRC10:38
*** mugsie has joined #openstack-neutron10:39
*** tesseract has quit IRC10:40
*** tesseract has joined #openstack-neutron10:41
*** tssurya has joined #openstack-neutron10:42
*** priteau has joined #openstack-neutron10:43
*** dsneddon has joined #openstack-neutron10:44
*** tesseract has quit IRC10:45
*** tesseract has joined #openstack-neutron10:45
*** tbachman has quit IRC10:48
*** dsneddon has quit IRC10:49
*** aedc has quit IRC10:52
*** panda is now known as panda|lunch11:02
openstackgerritSlawek Kaplonski proposed openstack/neutron master: DNM Try to delay a bit ip addr list  https://review.opendev.org/65756511:03
*** yamamoto has joined #openstack-neutron11:08
openstackgerritSlawek Kaplonski proposed openstack/neutron master: [DNM] Remove rootwrap-daemon from neutron-keepalived-state-change  https://review.opendev.org/65784911:08
slaweqralonsoh: ^^ I "improved" a bit Your patch :)11:09
ralonsohslaweq, sure, perfect!11:09
*** yamamoto has quit IRC11:13
*** priteau has quit IRC11:23
*** yamamoto has joined #openstack-neutron11:34
*** jpena is now known as jpena|lunch11:39
*** dsneddon has joined #openstack-neutron11:44
*** dsneddon has quit IRC11:48
*** gmann_pto has quit IRC11:50
*** janki has quit IRC11:54
*** lukasz_asdf has joined #openstack-neutron11:55
*** zigo has quit IRC11:59
*** aedc has joined #openstack-neutron12:02
*** yamamoto has quit IRC12:02
*** tbachman has joined #openstack-neutron12:05
*** panda|lunch is now known as panda12:06
*** yamamoto has joined #openstack-neutron12:07
*** aedc has quit IRC12:07
*** baojg has quit IRC12:08
*** iyamahat has joined #openstack-neutron12:15
*** aedc has joined #openstack-neutron12:16
*** iyamahat has quit IRC12:21
openstackgerritLucas Alvares Gomes proposed openstack/networking-ovn master: PEP8: Fix bandit exclude path  https://review.opendev.org/65806412:22
*** zigo has joined #openstack-neutron12:23
*** jpena|lunch is now known as jpena12:31
*** yamamoto has quit IRC12:40
slaweqhaleyb: hi12:46
slaweqhaleyb: can You take a look at https://bugs.launchpad.net/neutron/+bug/1828364 ? I'm not sure if this is really a bug or it is like that "by design" and should stay like that12:46
openstackLaunchpad bug 1828364 in neutron "DVR: Fip namespaces are created in all the controllers and computes with vm only when an external interface to the router is added" [Undecided,New] - Assigned to Slawek Kaplonski (slaweq)12:47
*** njohnston has joined #openstack-neutron12:47
haleybslaweq: i'll look, i'm thinking it's by design. might have to ping Swami as well12:48
slaweqhaleyb: thx12:49
lajoskatonaslaweq, ralonsoh: Hi12:51
slaweqlajoskatona: hi12:51
lajoskatonaslaweq, ralonsoh: I started to play with routed networks, and found that it is not working, if I understand well due to placement microversion things12:51
*** mriedem has joined #openstack-neutron12:51
lajoskatonaslaweq: Is that ok if I open a kind of umbrella bug for that?12:52
slaweqlajoskatona: what you mean by "umbrella bug"?12:53
lajoskatonaslaweq: as I see now there will be some small changes how we handle exceptions on different microversion12:53
lajoskatonaslaweq: I mean on bug like "routed networks placement microversion error" or similar12:53
slaweqI think that it will be fine12:53
lajoskatonas'on/one'12:53
lajoskatonaslaweq: ok12:54
*** ratailor has quit IRC12:54
lajoskatonaslaweq: and a more philosophical question, what do you think would be better12:56
*** ramishra has quit IRC12:56
*** ramishra has joined #openstack-neutron12:56
lajoskatonaslaweq: routed networks now documented to be used with placement 1.1, make it work with placement 1.112:56
lajoskatonaslaweq: or "upgrade" it to use 1.20 which we use for the placement reported for QoS min bw reporting?12:57
openstackgerritMerged openstack/networking-ovn master: PEP8: Fix bandit exclude path  https://review.opendev.org/65806412:58
slaweqlajoskatona: so currently in docs we have that is should works in placement 1.1 but it don't work like that?12:59
slaweqis my understanding correct?12:59
lajoskatonaslaweq: yes13:00
slaweqlajoskatona: and is it like that in stable branch(es) also?13:00
openstackgerritDaniel Alvarez proposed openstack/networking-ovn master: Update device_owner for subports  https://review.opendev.org/65690713:00
lajoskatonaslaweq: correction: in doc (https://docs.openstack.org/neutron/latest/admin/config-routed-networks.html ) we have 1.1 as minimum microversion13:01
slaweqlajoskatona:so it is only matter of placement API microversion, not placement package version, right?13:01
lajoskatonaslaweq: hmmmm, as I see from pike we have this in doc13:03
slaweqlajoskatona:so I think that we can fix docs if that will be enough :)13:04
lajoskatonaslaweq: and to tell the truth I can't see in placement microversion history where/when  the exception (if we receive back details in exception for get inventory if the resourceprovider is not existing) changed13:04
lajoskatonaso on stable branches this can be different, but I have to read more the placement history13:04
lajoskatonaslaweq: I check that13:05
*** yamamoto has joined #openstack-neutron13:06
slaweqlajoskatona: so basically if fix would require to bump requirements version than it's not possible for stable branches13:07
slaweqbut if this is not the case and stable branches can also use newer placement API version than IMO this should be ok13:07
lajoskatonaslaweq: ok I check that13:08
*** ramishra has quit IRC13:09
*** boden has joined #openstack-neutron13:09
*** boden has quit IRC13:13
*** samueldmq has joined #openstack-neutron13:16
*** ramishra has joined #openstack-neutron13:20
*** baojg has joined #openstack-neutron13:20
openstackgerritBrian Haley proposed openstack/neutron master: Fix bandit exclude path  https://review.opendev.org/65807513:25
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron master: Bump Pyroute2 version to 0.5.5  https://review.opendev.org/65775213:29
*** tesseract has quit IRC13:35
*** tesseract has joined #openstack-neutron13:35
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron master: Revert "Lock privileged.agent.linux.ip_lib functions"  https://review.opendev.org/65760813:35
*** gcheresh has joined #openstack-neutron13:42
*** altlogbot_0 has quit IRC13:43
*** dsneddon has joined #openstack-neutron13:45
*** altlogbot_1 has joined #openstack-neutron13:45
*** boden has joined #openstack-neutron13:49
*** dsneddon has quit IRC13:50
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron master: [DNM] Remove rootwrap-daemon from neutron-keepalived-state-change  https://review.opendev.org/65784913:55
openstackgerritDarragh O'Reilly proposed openstack/neutron master: Make OVS controller inactivity_probe configurable  https://review.opendev.org/64168113:59
*** rpittau is now known as rpittau|afk14:08
*** mlavalle has joined #openstack-neutron14:13
*** JamesBenson has joined #openstack-neutron14:17
*** itlinux has joined #openstack-neutron14:17
mlavallehaleyb, slaweq, ralonsoh, amotoki: do you know that today is njohnston birthday?14:19
mlavallenjohnston: Happy Birthday!14:19
ralonsohmlavalle, of course hehehe14:19
*** JamesBenson has quit IRC14:21
*** itlinux has quit IRC14:23
*** JamesBenson has joined #openstack-neutron14:23
*** tesseract has quit IRC14:24
*** liuyulong has joined #openstack-neutron14:25
*** JamesBenson has quit IRC14:28
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron master: Limit monotonic to python < 3.3  https://review.opendev.org/65811114:29
*** JamesBenson has joined #openstack-neutron14:29
*** yamamoto has quit IRC14:35
*** mvkr has quit IRC14:37
*** tesseract has joined #openstack-neutron14:50
*** Luzi has quit IRC14:51
*** tesseract has quit IRC14:51
*** tesseract has joined #openstack-neutron14:51
*** ratailor has joined #openstack-neutron14:52
*** hongbin has joined #openstack-neutron14:56
*** davidsha has joined #openstack-neutron14:57
njohnstonThank you mlavalle!  I'm 44 today, not sure if that makes mea young whippersnapper or a golden oldie14:59
mlavallenjohnston: the former14:59
mlavallenjohnston: the golden oldies are the 59ers like me15:00
*** tesseract has quit IRC15:01
*** tesseract has joined #openstack-neutron15:03
*** tesseract has quit IRC15:11
*** wwriverrat has joined #openstack-neutron15:11
*** imacdonn has quit IRC15:12
*** imacdonn has joined #openstack-neutron15:12
*** yamamoto has joined #openstack-neutron15:12
*** pbandark has quit IRC15:14
*** tesseract has joined #openstack-neutron15:16
amotokinjohnston: happy birthday!15:16
amotokieveryone will be young if they believe themselves so :)15:16
*** lajoskatona has quit IRC15:17
*** yamamoto has quit IRC15:17
*** tesseract has quit IRC15:18
*** tesseract has joined #openstack-neutron15:20
liuyulongnjohnston: happy birthday!15:23
*** gcheresh has quit IRC15:24
njohnstonthank you amotoki and liuyulong!15:28
*** trident has quit IRC15:33
*** trident has joined #openstack-neutron15:35
*** baojg has quit IRC15:37
*** dsneddon has joined #openstack-neutron15:39
*** ivve has quit IRC15:40
openstackgerritReedip proposed openstack/networking-ovn master: DNM Testing support for Router Scheduling  https://review.opendev.org/65779415:41
*** mvkr has joined #openstack-neutron15:42
openstackgerritBrian Haley proposed openstack/neutron master: Fix bandit exclude path  https://review.opendev.org/65807515:46
liuyulonghttps://bugs.launchpad.net/neutron/+bug/1609217, hi guys, I just reopen this bug. Opinions needed. : )15:48
openstackLaunchpad bug 1609217 in neutron "DVR: dvr router ns should not exist in scheduled DHCP agent nodes" [Medium,Opinion]15:48
*** priteau has joined #openstack-neutron15:48
liuyulongAnd it has a very very old fix: https://review.opendev.org/#/c/364793/. gerrit review may give some clue about the bug.15:50
*** dsneddon has quit IRC15:52
*** priteau has quit IRC15:56
*** bnemec has quit IRC15:58
*** ijw has joined #openstack-neutron15:58
*** bnemec has joined #openstack-neutron15:58
*** mvkr has quit IRC15:59
*** tesseract has quit IRC16:01
*** davidsha has quit IRC16:02
*** ratailor has quit IRC16:03
*** lucasagomes has quit IRC16:13
*** enyinna1234 has joined #openstack-neutron16:18
openstackgerritboden proposed openstack/neutron master: DNM: use SqlFixture and StaticSqlFixture from neutron-lib  https://review.opendev.org/65788716:21
*** tssurya has quit IRC16:38
*** maciejjozefczyk has quit IRC16:42
*** jpena is now known as jpena|off16:42
*** irclogbot_1 has quit IRC16:46
*** munimeha1 has joined #openstack-neutron16:46
openstackgerritBrian Haley proposed openstack/neutron master: Fix bandit exclude path  https://review.opendev.org/65807516:46
ralonsohhaleyb, http://paste.openstack.org/show/751179/16:47
*** irclogbot_1 has joined #openstack-neutron16:47
ralonsohhaleyb, just the first part of the execution16:47
ralonsohhaleyb, with bandit==1.5.016:47
*** aojea has quit IRC16:47
ralonsohwith 1.6.0, not errors16:47
haleybralonsoh: ack, i finally did reproduce it just didn't trigger the first time somehow.  One of those was the resource_allocator test code i've been trying to fix :(16:48
*** dsneddon has joined #openstack-neutron16:49
*** ramishra has quit IRC16:50
*** dsneddon has quit IRC16:54
openstackgerritRodolfo Alonso Hernandez proposed openstack/neutron master: Remove QoS related objects unneeded compatibility conversions  https://review.opendev.org/65815516:56
*** aedc has quit IRC16:58
*** ccamposr has quit IRC17:02
*** liuyulong has quit IRC17:03
*** dsneddon has joined #openstack-neutron17:06
*** ralonsoh has quit IRC17:08
*** macza has joined #openstack-neutron17:12
enyinna1234haleyb, manjeets, slaweq, tidwellr, I'm canvassing for code reviews: https://review.opendev.org/#/c/628071/17:19
*** yamamoto has joined #openstack-neutron17:22
*** Weifan has joined #openstack-neutron17:23
*** ijw has quit IRC17:37
*** rubasov has joined #openstack-neutron17:38
*** ivve has joined #openstack-neutron17:42
*** rubasov has quit IRC17:46
*** livelace has joined #openstack-neutron17:47
*** hongbin has quit IRC17:54
openstackgerritBrian Haley proposed openstack/networking-ovn master: Bump bandit version to 1.6.0  https://review.opendev.org/65816517:58
*** ijw has joined #openstack-neutron18:00
*** yamamoto has quit IRC18:11
*** tbachman has quit IRC18:13
openstackgerritMerged openstack/networking-ovn master: Update device_owner for subports  https://review.opendev.org/65690718:21
*** SmearedBeard has quit IRC18:21
*** hyang has left #openstack-neutron18:30
*** igordc has joined #openstack-neutron18:35
*** igordc has quit IRC18:44
*** Weifan has quit IRC18:44
*** tbachman has joined #openstack-neutron18:45
*** igordc has joined #openstack-neutron18:47
*** yamamoto has joined #openstack-neutron18:51
*** iyamahat has joined #openstack-neutron18:51
*** yamamoto has quit IRC19:02
*** SmearedBeard has joined #openstack-neutron19:07
*** SmearedBeard has quit IRC19:13
*** Weifan has joined #openstack-neutron19:15
*** SmearedBeard has joined #openstack-neutron19:15
*** maciejjozefczyk has joined #openstack-neutron19:15
*** Weifan has quit IRC19:19
*** jobewan has joined #openstack-neutron19:23
*** maciejjozefczyk has quit IRC19:23
*** SmearedBeard has quit IRC19:26
tidwellrenyinna1234: see my latest comments on https://review.opendev.org/#/c/628071/19:26
*** cheng1 has quit IRC19:27
*** tbachman has quit IRC19:30
*** cheng1 has joined #openstack-neutron19:33
enyinna1234Thanks for the review, tidwellr, I replied your comment19:42
*** hongbin has joined #openstack-neutron19:44
enyinna1234haleyb, thanks. I also replied https://review.opendev.org/#/c/628071/19:44
tidwellrenyinna1234: I'm not seeing your comments after refreshing the page19:48
*** Weifan has joined #openstack-neutron19:51
enyinna1234tidwellr: Look again. I replied to the post20:02
*** Weifan has quit IRC20:03
*** boden_ has joined #openstack-neutron20:15
*** boden has quit IRC20:19
*** SmearedBeard has joined #openstack-neutron20:30
*** livelace has quit IRC20:31
*** dsneddon has quit IRC20:39
mriedemmlavalle: i've got some port binding (extended) questions about the flow when messing with multiple port bindings during a migration20:40
mriedemone is, if we start a migration with an inactive port binding on the dest host and an active port binding on the source host, and the port's binding:host_id points at the source, if we activate the dest host binding does the port's binding:host_id value automatically get updated?20:41
mriedemit seems that it does during live migration with the new port binding stuff we added in rocky20:41
mlavalleyes, it should20:41
mriedemok so what if rather than activate the dest host port binding directly, i update the port's binding:host_id to point at the dest host, would you expect that to automatically activate the dest host binding and update the source host binding to be inactive?20:42
mriedemright now we're getting a UniqueConstraint error if we do ^20:44
mriedemi don't know if we're losing a race or what20:44
mlavalleno. when you activate a binding you are calling this: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L2458. If you update the port, you are updating the same port binding that pointed previously to the source host20:45
mlavalleyou are not changing the binding20:45
mlavalleupdate port is not going to call the new port binding activation20:46
mriedemok so that would explain the UniqueConstraint then because neutron is trying to have an active and inactive binding on the same host for the same port which violates the constraint20:48
mriedemsean mooney described it in this workaround patch https://review.opendev.org/#/c/653506/ but i wasn't sure if that's what was really happening on the neutron side20:48
mlavalleto your point: https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/models.py#L4220:49
mriedemso to recap the issue, if we have binding for port1 on hostA as active, and port1 on hostB which is inactive, and then update the port['binding:host_id'] = hostB, neutron will try to change the binding for hostA to be hostB which blows up b/c we already have a binding for hostB20:49
mriedemyup we get something like this20:50
mriedemDBDuplicateEntry: (pymysql.err.IntegrityError) (1062, "Duplicate entry  '4b9a5615-c534-4205-892b-947b8460c874-ubuntu-bionic-ovh-gra1-0005' for  key 'PRIMARY'") [SQL: 'UPDATE ml2_port_bindings SET host=%(host)s,  vif_type=%(vif_type)s, vif_details=%(vif_details)s WHERE  ml2_port_bindings.port_id = %(ml2_port_bindings_port_id)s AND  ml2_port_bindings.host = %(ml2_port_bindings_host)s'] [parameters:  {'host': 'ubuntu-bionic-o20:50
mriedemra1-0005970038', 'vif_type': 'unbound',  'vif_details': '', 'ml2_port_bindings_port_id':  '4b9a5615-c534-4205-892b-947b8460c874', 'ml2_port_bindings_host':  'ubuntu-bionic-ovh-gra1-0005970036'}]20:50
mlavalleyes, looking at the db model makes it crystal clear20:50
mriedemwhat wasn't clear to me was what neutron does when the port's binding:host_id was updated20:51
mriedemthat's a bit confusing since we have the bindings records and the thing on the port20:51
mriedemi'm actually really surprised more people aren't hitting this with live migration in rocky+20:54
mriedemmnaser: you haven't hit https://bugs.launchpad.net/nova/+bug/1822884 right?20:55
openstackLaunchpad bug 1822884 in OpenStack Compute (nova) "live migration fails due to port binding duplicate key entry in post_live_migrate" [Undecided,In progress] - Assigned to sean mooney (sean-k-mooney)20:55
mlavallemriedem: in this patch we converted the relationship between the port and its binding(s) to a list and also changed the way to access the binding to use a utility function: https://review.opendev.org/#/c/414251/7420:59
mlavallehttps://review.opendev.org/#/c/414251/74/neutron/plugins/ml2/models.py21:00
*** logan- has quit IRC21:00
mlavallehttps://review.opendev.org/#/c/414251/74/neutron/common/utils.py21:01
mlavalleand then this patch pluralized the relationship name21:02
*** logan- has joined #openstack-neutron21:03
*** mchlumsky has quit IRC21:04
*** Weifan has joined #openstack-neutron21:20
openstackgerritboden proposed openstack/neutron master: use payloads for PORT AFTER_CREATE events  https://review.opendev.org/63446121:31
*** dasp has quit IRC21:52
*** boden_ has quit IRC21:55
*** tbachman has joined #openstack-neutron21:58
mriedemmlavalle: thanks for the details, i think i have another way to trigger a recreate of that bug in the gate to test the theory21:58
mlavallemriedem: glad to help :-)21:58
*** JamesBenson has quit IRC21:59
*** ijw has quit IRC22:02
*** ijw has joined #openstack-neutron22:03
*** hongbin has quit IRC22:04
*** hongbin has joined #openstack-neutron22:05
*** hongbin has quit IRC22:05
*** hongbin has joined #openstack-neutron22:06
*** hongbin has quit IRC22:06
*** hongbin has joined #openstack-neutron22:06
*** ijw has quit IRC22:07
*** hongbin has quit IRC22:08
*** hongbin has joined #openstack-neutron22:08
*** trident has quit IRC22:19
*** tbachman has quit IRC22:19
*** enyinna1234 has quit IRC22:21
*** enyinna1234 has joined #openstack-neutron22:22
*** trident has joined #openstack-neutron22:22
wwriverratAnyone have the time to review the PTG requested spec for: Multi-segment-per-host spec? Pretty please, with sugar on top? :-P22:32
wwriverrathttps://review.opendev.org/#/c/657170/22:32
*** markmcclain has quit IRC22:35
*** markmcclain has joined #openstack-neutron22:37
mlavallewwriverrat: I am actually writing the summary and was looking at the spec. I will give feedback over the next few days22:39
mlavalleit will be in my radar screen22:40
mlavallethanks for the quick submission22:40
*** iyamahat has quit IRC22:42
wwriverratwoohoo! :)22:47
*** mlavalle has quit IRC22:49
*** slaweq has quit IRC22:51
*** munimeha1 has quit IRC22:52
*** SmearedBeard has quit IRC22:56
*** macza has quit IRC22:57
*** SmearedBeard has joined #openstack-neutron22:58
*** slaweq has joined #openstack-neutron22:58
*** slaweq has quit IRC23:03
*** tkajinam has joined #openstack-neutron23:03
*** slaweq has joined #openstack-neutron23:11
*** slaweq has quit IRC23:16
*** SmearedBeard has quit IRC23:17
*** samueldmq has quit IRC23:31
*** whoami-rajat has quit IRC23:34
*** jobewan has quit IRC23:36
*** enyinna1234 has quit IRC23:40
*** eandersson has joined #openstack-neutron23:41
*** dsneddon has joined #openstack-neutron23:44
*** dsneddon has quit IRC23:51

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!