*** mlavalle has quit IRC | 00:15 | |
*** armax has quit IRC | 00:40 | |
*** gregwork has quit IRC | 00:42 | |
*** tkajinam has quit IRC | 01:29 | |
*** tkajinam has joined #openstack-neutron | 01:29 | |
openstackgerrit | zhangyuhe proposed openstack/neutron master: [OVN] Support native DHCP service for subnet without gateway IP https://review.opendev.org/708011 | 02:59 |
---|---|---|
*** hongbin has joined #openstack-neutron | 03:00 | |
openstackgerrit | zhangyuhe proposed openstack/neutron master: [OVN]floating IP QoS. https://review.opendev.org/712239 | 03:27 |
*** yamamoto has joined #openstack-neutron | 03:53 | |
openstackgerrit | norman shen proposed openstack/neutron master: Keep stale flows if there are failed devices https://review.opendev.org/727048 | 03:58 |
*** ratailor has joined #openstack-neutron | 04:06 | |
*** lajoskatona has joined #openstack-neutron | 04:07 | |
openstackgerrit | norman shen proposed openstack/neutron master: Reraise timeout exception https://review.opendev.org/726492 | 04:11 |
*** gcheresh_ has joined #openstack-neutron | 04:31 | |
*** yamamoto has quit IRC | 04:43 | |
*** hongbin has quit IRC | 05:04 | |
openstackgerrit | Lajos Katona proposed openstack/networking-odl master: Use unittest.mock instead of third party mock https://review.opendev.org/720956 | 05:14 |
openstackgerrit | Lajos Katona proposed openstack/networking-odl master: Add subnet deleted handler https://review.opendev.org/724656 | 05:27 |
*** waleedm has joined #openstack-neutron | 06:06 | |
*** abdysn has joined #openstack-neutron | 06:11 | |
*** dayou has quit IRC | 06:28 | |
*** tkajinam has quit IRC | 06:35 | |
*** tkajinam has joined #openstack-neutron | 06:36 | |
openstackgerrit | zhangyuhe proposed openstack/neutron master: [OVN] Support native DHCP service for subnet without gateway IP https://review.opendev.org/708011 | 06:44 |
*** livelace has joined #openstack-neutron | 06:55 | |
*** maciejjozefczyk has joined #openstack-neutron | 06:59 | |
*** tmorin has joined #openstack-neutron | 06:59 | |
*** tesseract has joined #openstack-neutron | 07:04 | |
maciejjozefczyk | Hey :) Looks like we need +W here: https://review.opendev.org/#/c/726965/1 | 07:05 |
openstackgerrit | Lajos Katona proposed openstack/networking-bgpvpn master: DNM: Check the gate https://review.opendev.org/726860 | 07:08 |
*** slaweq has joined #openstack-neutron | 07:11 | |
openstackgerrit | zhanghao proposed openstack/neutron-vpnaas master: Add aggressive negotiation mode for ikepolicy https://review.opendev.org/727073 | 07:19 |
*** awalende has joined #openstack-neutron | 07:23 | |
*** ralonsoh has joined #openstack-neutron | 07:33 | |
*** jlibosva has joined #openstack-neutron | 07:39 | |
*** dayou has joined #openstack-neutron | 07:40 | |
*** sapd1_x has joined #openstack-neutron | 07:45 | |
*** lpetrut has joined #openstack-neutron | 07:52 | |
*** dtantsur|afk is now known as dtantsur | 07:54 | |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Add support for OVN LB selection fields https://review.opendev.org/726787 | 07:54 |
*** jpena|off is now known as jpena | 07:56 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/neutron master: Fix some pep8 errors https://review.opendev.org/727093 | 07:57 |
*** rpittau|afk is now known as rpittau | 07:58 | |
*** tmorin has quit IRC | 07:59 | |
maciejjozefczyk | ralonsoh, Hey! Brian already proposed the pep8 fix: https://review.opendev.org/#/c/726965/ | 08:01 |
*** nirmoy has joined #openstack-neutron | 08:04 | |
ralonsoh | maciejjozefczyk, hahaha thanks!! | 08:05 |
maciejjozefczyk | ralonsoh, :) | 08:05 |
*** tmorin has joined #openstack-neutron | 08:07 | |
*** lucasagomes has joined #openstack-neutron | 08:09 | |
*** tmorin has quit IRC | 08:13 | |
*** yamamoto has joined #openstack-neutron | 08:22 | |
*** yamamoto has quit IRC | 08:24 | |
*** tmorin has joined #openstack-neutron | 08:31 | |
*** awalende_ has joined #openstack-neutron | 08:32 | |
*** salmankhan has joined #openstack-neutron | 08:33 | |
*** awalende has quit IRC | 08:35 | |
*** lpetrut_ has joined #openstack-neutron | 08:39 | |
*** lpetrut has quit IRC | 08:42 | |
*** livelace has quit IRC | 08:49 | |
openstackgerrit | Lajos Katona proposed openstack/networking-bgpvpn stable/ussuri: DNM: Check the gate stable/ussuri https://review.opendev.org/727114 | 08:50 |
*** priteau has joined #openstack-neutron | 09:02 | |
*** yamamoto has joined #openstack-neutron | 09:04 | |
*** salmankhan has quit IRC | 09:06 | |
*** salmankhan has joined #openstack-neutron | 09:07 | |
*** ociuhandu has joined #openstack-neutron | 09:07 | |
*** ociuhandu has quit IRC | 09:08 | |
*** ociuhandu has joined #openstack-neutron | 09:08 | |
*** yamamoto has quit IRC | 09:09 | |
*** ociuhandu_ has quit IRC | 09:10 | |
*** livelace has joined #openstack-neutron | 09:11 | |
*** ociuhandu_ has joined #openstack-neutron | 09:13 | |
*** ociuhand_ has joined #openstack-neutron | 09:14 | |
openstackgerrit | zhanghao proposed openstack/neutron-vpnaas master: Add aggressive negotiation mode for ikepolicy https://review.opendev.org/727073 | 09:16 |
*** ociuhandu has quit IRC | 09:17 | |
*** ociuhandu has joined #openstack-neutron | 09:18 | |
*** ociuhand_ has quit IRC | 09:18 | |
*** ociuhandu_ has quit IRC | 09:18 | |
bcafarel | another new release week, another pep8 update breaking all stable branches sigh | 09:32 |
openstackgerrit | Merged openstack/ovn-octavia-provider master: Fix E741 pep8 errors https://review.opendev.org/726953 | 09:34 |
*** ociuhandu has quit IRC | 09:51 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/neutron master: Use pyroute2 to retrieve the SRIOV VF information https://review.opendev.org/726918 | 09:56 |
*** ociuhandu has joined #openstack-neutron | 09:57 | |
*** tesseract-RH has joined #openstack-neutron | 10:02 | |
*** tesseract has quit IRC | 10:04 | |
*** waleedm_ has joined #openstack-neutron | 10:07 | |
*** livelace has quit IRC | 10:09 | |
*** waleedm has quit IRC | 10:09 | |
*** jlibosva has quit IRC | 10:18 | |
*** jlibosva has joined #openstack-neutron | 10:19 | |
*** rpittau is now known as rpittau|bbl | 10:19 | |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home OvnProviderHelper class https://review.opendev.org/724427 | 10:19 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home unit tests https://review.opendev.org/724428 | 10:19 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home ovsdb event classes https://review.opendev.org/725398 | 10:19 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home functional tests https://review.opendev.org/726227 | 10:19 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Add support for OVN LB selection fields https://review.opendev.org/726787 | 10:19 |
*** nirmoy has quit IRC | 10:27 | |
openstackgerrit | Dongcan Ye proposed openstack/neutron-vpnaas master: Add Ussuri milestone tag for alembic migration revisions https://review.opendev.org/727156 | 10:48 |
*** gcheresh_ has quit IRC | 10:52 | |
*** lucasagomes is now known as lucas-hungry | 11:01 | |
openstackgerrit | Lajos Katona proposed openstack/networking-odl master: Update master for stable/ussuri https://review.opendev.org/722265 | 11:15 |
openstackgerrit | Lajos Katona proposed openstack/networking-odl master: Add Python3 victoria unit tests https://review.opendev.org/722266 | 11:15 |
*** livelace has joined #openstack-neutron | 11:17 | |
openstackgerrit | Lajos Katona proposed openstack/networking-bgpvpn master: DNM: Check the gate https://review.opendev.org/726860 | 11:25 |
*** samueldmq_ has joined #openstack-neutron | 11:28 | |
*** gcheresh_ has joined #openstack-neutron | 11:28 | |
*** nirmoy has joined #openstack-neutron | 11:31 | |
*** jpena is now known as jpena|lunch | 11:33 | |
*** samueldmq_ has quit IRC | 11:34 | |
*** samueldmq_ has joined #openstack-neutron | 11:36 | |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home OvnProviderHelper class https://review.opendev.org/724427 | 11:40 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home unit tests https://review.opendev.org/724428 | 11:40 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home ovsdb event classes https://review.opendev.org/725398 | 11:40 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Re-home functional tests https://review.opendev.org/726227 | 11:40 |
openstackgerrit | Maciej Józefczyk proposed openstack/ovn-octavia-provider master: Add support for OVN LB selection fields https://review.opendev.org/726787 | 11:40 |
*** samueldmq_ is now known as samueldmq | 11:40 | |
*** nweinber has joined #openstack-neutron | 11:52 | |
*** lucas-hungry is now known as lucasagomes | 11:55 | |
*** ratailor has quit IRC | 12:07 | |
*** sapd1_x has quit IRC | 12:08 | |
openstackgerrit | Takashi Natsume proposed openstack/os-vif master: Remove egg_info in setup.cfg https://review.opendev.org/727173 | 12:10 |
*** abdysn has quit IRC | 12:12 | |
*** ratailor has joined #openstack-neutron | 12:20 | |
*** rpittau|bbl is now known as rpittau | 12:21 | |
*** waleedm_ has quit IRC | 12:24 | |
*** adrianc has quit IRC | 12:24 | |
rubasov | njohnston: hello | 12:27 |
rubasov | njohnston: I was reading yesterday's meeting log | 12:27 |
rubasov | njohnston: and would like to ask about https://bugs.launchpad.net/neutron/+bug/1878031 | 12:28 |
openstack | Launchpad bug 1878031 in neutron " Unable to delete an instance | Conflict: Port [port-id] is currently a parent port for trunk [trunk-id]" [Undecided,New] - Assigned to Nate Johnston (nate-johnston) | 12:28 |
*** ratailor has quit IRC | 12:33 | |
*** happyhemant has joined #openstack-neutron | 12:36 | |
*** jpena|lunch is now known as jpena | 12:40 | |
*** elod_pto is now known as elod | 12:42 | |
*** adrianc has joined #openstack-neutron | 12:45 | |
*** adrianc has quit IRC | 12:50 | |
*** adrianc has joined #openstack-neutron | 12:53 | |
njohnston | rubasov: Sure! | 12:55 |
rubasov | hi | 12:55 |
rubasov | I was wondering how the second interface you write about in the bug report came to be | 12:56 |
rubasov | starting with 64f6a222-9e9a- | 12:56 |
rubasov | I wasn't expecting a 2nd interface at all | 12:57 |
rubasov | also do you have the exact workflow of how the trunk and vm was created? | 12:59 |
rubasov | particularly 1) do you first create the trunk and then boot the vm, or the other way around? | 13:05 |
*** livelace has quit IRC | 13:05 | |
rubasov | 2) are subports ever passed to nova in the vm boot? | 13:05 |
*** livelace has joined #openstack-neutron | 13:08 | |
*** spotz has joined #openstack-neutron | 13:27 | |
openstackgerrit | norman shen proposed openstack/neutron master: Reraise timeout exception https://review.opendev.org/726492 | 13:36 |
openstackgerrit | Maciej Józefczyk proposed openstack/neutron master: [WIP] Run functional tests with selected OVN and OVS versions https://review.opendev.org/727193 | 13:40 |
openstackgerrit | Maciej Józefczyk proposed openstack/neutron master: [WIP] Run functional tests with selected OVN and OVS versions https://review.opendev.org/727193 | 13:42 |
openstackgerrit | norman shen proposed openstack/neutron master: Keep stale flows if there are failed devices https://review.opendev.org/727048 | 13:45 |
*** openstackstatus has quit IRC | 13:53 | |
*** openstackstatus has joined #openstack-neutron | 13:54 | |
*** ChanServ sets mode: +v openstackstatus | 13:54 | |
openstackgerrit | Brian Haley proposed openstack/ovn-octavia-provider stable/ussuri: DNM: test to see if we need to backport pep8 change https://review.opendev.org/727199 | 14:02 |
njohnston | rubasov: Apologies was taken away for a meeting. | 14:07 |
rubasov | njohnston: np | 14:07 |
*** armax has joined #openstack-neutron | 14:08 | |
njohnston | rubasov: I believe when the VM is boted it is given a network, not a specific port, i.e. `openstack server create --nic net-id=<UUID>` | 14:08 |
openstackgerrit | Brian Haley proposed openstack/ovn-octavia-provider stable/ussuri: Fix E741 pep8 errors https://review.opendev.org/727201 | 14:09 |
njohnston | The order of operations is: 1) parent port created; 2) trunk created and attached to the parent port; 3) indeterminate amount of time elapses; 4) server created on the trunk | 14:10 |
rubasov | njohnston: and then the user finds the port which got created by nova and is that used as a parent port in trunk create? | 14:10 |
openstackgerrit | Brian Haley proposed openstack/ovn-octavia-provider stable/ussuri: Fix E741 pep8 errors https://review.opendev.org/727201 | 14:10 |
njohnston | the trunk predates the server | 14:10 |
rubasov | that's definitely not how it was originally meant to be used (not meaning to imply it is a wrong way) | 14:11 |
rubasov | originally we never to support the case when a vm is booted with a network | 14:12 |
rubasov | but there's a driver dependent part of this | 14:12 |
*** sapd1_x has joined #openstack-neutron | 14:12 | |
rubasov | njohnston: wait, I'm still confused | 14:13 |
rubasov | njohnston: how is the order you listed and server create --nic net-id is possible at the same time? | 14:14 |
*** adrianc has quit IRC | 14:15 | |
rubasov | if we use --nic net-id then nova creates a port and (unless we are really fast) the vm is booted before we can make the port a parent port of a trunk | 14:16 |
*** adrianc has joined #openstack-neutron | 14:17 | |
njohnston | rubasov: I have not been able to follow the code in nova properly, but my working theory was that the process in nova was 1) create port on trunk, then 2) attach an available subport to the instance. The key being that the port in 1 is not necessarily the same as the one in 2 if there is another subport that looks unowned hanging around, i.e. the trunk parent port. | 14:18 |
njohnston | so that way a previously existing parent port could be attached to an instance | 14:19 |
rubasov | I feel there's some confusion about the workflow a trunk is meant to be used | 14:20 |
rubasov | let me start with the canonical way: | 14:21 |
rubasov | while from an end user perspective (and logically) it would be nice to pass a trunk to a vm boot | 14:21 |
rubasov | this would have meant huge changes in nova | 14:22 |
rubasov | so we tried hard to keep the trunk feature neutron-only | 14:22 |
rubasov | this had the consequence of nova never knowing about the trunk | 14:22 |
rubasov | nova only ever knows about the parent port | 14:23 |
njohnston | ok | 14:23 |
rubasov | the trunk should never be passed to nova, because nova cannot do anything with it | 14:23 |
njohnston | got it | 14:24 |
rubasov | second, we considered the combination of booting a vm with a network (as opposed to a port) and making that port part of a trunk unsupported | 14:24 |
rubasov | there may be an exception to this, I'll come back to that later | 14:25 |
rubasov | the reason was: some drivers (like ovs) requires the trunk to be created before the vm is booted | 14:25 |
rubasov | because a trunked port and a plain old port is wired differently and we did want to do complex live rewiring upgrades | 14:27 |
rubasov | for the trunk to exist before the vm, the parent port has to exist before the trunk and the vm | 14:27 |
rubasov | so we kind of considered that the canonical way | 14:28 |
rubasov | that the parent port is always pre-created and passed explicitly to the vm boot | 14:28 |
rubasov | with ovs that was actually the only way | 14:28 |
rubasov | with other drivers though (e.g. lb or ovn) it is possible to trunk a port which was already used to boot a vm | 14:29 |
rubasov | because these drivers do not need to wire the port differently depending on whether the port is trunked or not | 14:30 |
rubasov | here I see a possible bug after I read the bug report | 14:31 |
rubasov | if we boot a vm with a network then nova creates a plain old port | 14:31 |
rubasov | we can find that port and with non-ovs drivers we can make it a parent port of a trunk | 14:32 |
rubasov | after that when we delete the vm, nova wants to delete the port (since nova created it in the first place) | 14:33 |
rubasov | and we may run into the error of 'trunk is in use' | 14:33 |
rubasov | but because of the second interface in the bug report I suspect that may not be the problem you have | 14:34 |
rubasov | can it be that one or more subports were attached to the vm? | 14:35 |
njohnston | rubasov: so in your opinion, am I correct in saying the only way we should ever see a log message like "Failed to delete port 991e4e50-481a-4ca6-9ea6-69f848c4ca9f for instance.: Conflict: Port 991e4e50-481a-4ca6-9ea6-69f848c4ca9f is currently a parent port for trunk 5800ee0f-b558-46cb-bb0b-92799dbe02cf." is if the parent port was specifically requested as instance port on instance creation? | 14:35 |
*** tkajinam has quit IRC | 14:37 | |
rubasov | not sure about the answer yet, but I see three cases | 14:39 |
rubasov | case 1) order: create parent port, create trunk, boot vm | 14:40 |
*** ralonsoh has quit IRC | 14:40 | |
rubasov | in case 1) we will never see this error because nova does now want to delete the port if it was given to it | 14:40 |
*** ralonsoh has joined #openstack-neutron | 14:40 | |
rubasov | case 2) boot vm with network, never turn the nova-created port into a trunk | 14:41 |
rubasov | again no problem here | 14:41 |
rubasov | case 3) boot vm with network, find the nova-created port and make it a parent port of a trunk | 14:42 |
rubasov | this case was kind of considered unsupported, but still today this is doable and there's no warning that you shouldn't do it | 14:43 |
rubasov | and here I think it is possible to hit the error you saw | 14:43 |
njohnston | given that the `openstack port show` for the parent port has trunk_details set properly and has device_owner = 'compute:nova' does that indicate scenario 3? | 14:44 |
*** ralonsoh has quit IRC | 14:44 | |
rubasov | that still could be case 1 or case 3 | 14:45 |
*** livelace has quit IRC | 14:46 | |
rubasov | let me come back to that second interface in the report for a bit | 14:47 |
*** rcernin has quit IRC | 14:48 | |
rubasov | we had to keep nova unchanged while implementing trunks | 14:48 |
rubasov | that also means nova should not know about the subports too | 14:48 |
rubasov | a subport should never be passed to server create | 14:49 |
rubasov | but if it is passed there's no direct error message, because of how hard it would have been to produce that error message | 14:50 |
rubasov | so if a subport got directly attached to a vm, that could explain the second interface in the report | 14:51 |
rubasov | but that is a case that should not be done | 14:52 |
rubasov | does all this make any sense? not sure if I'm explaining it right | 14:53 |
njohnston | It does make sense, and I am very grateful. I'm just not sure how to prevent this from happening. | 14:54 |
rubasov | great | 14:54 |
rubasov | I'm trying to separate the two possible causes I see | 14:55 |
rubasov | 1) subports attached directly to the vm | 14:55 |
rubasov | 2) the previous case 3) | 14:55 |
openstackgerrit | Slawek Kaplonski proposed openstack/neutron master: Don't check if any bridges were recrected when OVS was restarted https://review.opendev.org/726770 | 14:56 |
rubasov | if 1) is the cause then what needs to be fixed is that we never pass a subport to server create | 14:57 |
rubasov | if 2) is the cause that we may consider a genuine bug which needs to be fixed (at the moment I'm not sure if this is to be fixed in nova or neutron) | 14:58 |
rubasov | and the second interface you listed in the report gives me a hunch (not a proof though) that cause 1) is more likely | 14:59 |
openstackgerrit | Merged openstack/networking-midonet stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/723722 | 15:00 |
rubasov | or more precisely that there's something else beyond cause 2) even if cause 2) is what we are seeing | 15:00 |
openstackgerrit | Merged openstack/networking-midonet stable/ussuri: Update TOX_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/723723 | 15:00 |
rubasov | I'll have a meeting in 10 minutes, so I'll have to drop off soon | 15:01 |
rubasov | but feel free to catch me tomorrow if you'd like to continue the discussion | 15:01 |
njohnston | rubasov: If there are investigations I can do in the meantime that would be helpful, please feel free to assign me some homework | 15:02 |
njohnston | rubasov: Yes, let's continue it; I also sent an email to the ML if that is a better forum | 15:02 |
rubasov | it would be helpful to understand what api calls we had and in what other if that's something you can collect from the logs | 15:03 |
rubasov | will read the ml too | 15:04 |
rubasov | then talk to you tomorrow | 15:05 |
rubasov | cheers | 15:05 |
*** hjensas is now known as hjensas|afk | 15:06 | |
*** dtantsur is now known as dtantsur|afk | 15:08 | |
*** dasp_ has quit IRC | 15:14 | |
openstackgerrit | Brian Haley proposed openstack/neutron-tempest-plugin master: Add nose to requirements.txt https://review.opendev.org/727222 | 15:16 |
*** dasp has joined #openstack-neutron | 15:16 | |
openstackgerrit | Maciej Józefczyk proposed openstack/neutron master: [WIP] Run functional tests with selected OVN and OVS versions https://review.opendev.org/727193 | 15:17 |
*** tesseract-RH has quit IRC | 15:22 | |
*** tesseract has joined #openstack-neutron | 15:23 | |
*** mlavalle has joined #openstack-neutron | 15:27 | |
openstackgerrit | Terry Wilson proposed openstack/neutron master: Set class ovsdb_conection to None https://review.opendev.org/727232 | 15:36 |
*** dasp has quit IRC | 15:41 | |
*** dasp has joined #openstack-neutron | 15:42 | |
*** lpetrut_ has quit IRC | 15:51 | |
*** maciejjozefczyk has quit IRC | 15:53 | |
openstackgerrit | Merged openstack/neutron master: Fix some pep8 errors https://review.opendev.org/726965 | 16:00 |
*** lajoskatona has quit IRC | 16:02 | |
*** livelace has joined #openstack-neutron | 16:02 | |
openstackgerrit | Nate Johnston proposed openstack/neutron master: Time port fetches https://review.opendev.org/724787 | 16:02 |
openstackgerrit | Terry Wilson proposed openstack/ovsdbapp master: WIP Add indexed column support to ovsdbapp https://review.opendev.org/678076 | 16:03 |
*** jlibosva has quit IRC | 16:05 | |
openstackgerrit | Flavio Fernandes proposed openstack/neutron master: WIP (DNM): [ovn]: port forwarding functionality https://review.opendev.org/723863 | 16:10 |
*** rpittau is now known as rpittau|afk | 16:10 | |
*** tesseract has quit IRC | 16:12 | |
openstackgerrit | Terry Wilson proposed openstack/ovsdbapp master: Don't create new API instance in fixtures https://review.opendev.org/726235 | 16:14 |
openstackgerrit | Terry Wilson proposed openstack/ovsdbapp master: WIP Add indexed column support to ovsdbapp https://review.opendev.org/678076 | 16:14 |
*** lucasagomes has quit IRC | 16:17 | |
*** gcheresh_ has quit IRC | 16:31 | |
*** gcheresh_ has joined #openstack-neutron | 16:33 | |
openstackgerrit | Brian Haley proposed openstack/neutron stable/ussuri: Cap pycodestyle to be < 2.6.0 https://review.opendev.org/727274 | 16:57 |
openstackgerrit | Merged openstack/neutron master: Add "qos_policy_id" field to "FloatingIP" OVO https://review.opendev.org/726208 | 17:05 |
openstackgerrit | Merged openstack/neutron master: Open Victoria DB branch https://review.opendev.org/721207 | 17:05 |
*** numans has quit IRC | 17:13 | |
*** ralonsoh has joined #openstack-neutron | 17:14 | |
*** jpena is now known as jpena|off | 17:14 | |
*** ralonsoh has quit IRC | 17:14 | |
*** salmankhan has quit IRC | 17:17 | |
*** priteau has quit IRC | 17:17 | |
*** ralonsoh has joined #openstack-neutron | 17:19 | |
*** iurygregory has quit IRC | 17:27 | |
*** ralonsoh has quit IRC | 17:28 | |
*** ralonsoh has joined #openstack-neutron | 17:31 | |
*** gcheresh_ has quit IRC | 17:32 | |
*** ralonsoh has quit IRC | 17:33 | |
*** ociuhandu has quit IRC | 17:35 | |
*** ociuhandu has joined #openstack-neutron | 17:37 | |
*** ociuhandu has quit IRC | 17:37 | |
*** ociuhandu has joined #openstack-neutron | 17:37 | |
*** ralonsoh has joined #openstack-neutron | 17:39 | |
*** ralonsoh has quit IRC | 17:40 | |
*** ralonsoh has joined #openstack-neutron | 17:48 | |
*** ociuhandu has quit IRC | 17:48 | |
*** ociuhandu has joined #openstack-neutron | 17:51 | |
openstackgerrit | Maciej Józefczyk proposed openstack/neutron master: Skip OVS module compilation for kernels newer than 5.5 https://review.opendev.org/726759 | 17:51 |
*** ociuhandu has quit IRC | 17:55 | |
*** sapd1_x has quit IRC | 18:03 | |
*** JamesBen_ has quit IRC | 18:06 | |
openstackgerrit | Brian Haley proposed openstack/neutron stable/ussuri: Cap flake8 to be < 3.8.0 https://review.opendev.org/727274 | 18:06 |
gmann | haleyb: let's try without flake8 also in requirement ^^ and see if it still pull pycodestyle some somewhere | 18:12 |
gmann | pycodestyle latest | 18:12 |
haleyb | gmann: i can run it locally, do you mean without either? | 18:13 |
gmann | yeah, hacking pull flake8 compatible version and flake8 pull pycodestyle compatible | 18:13 |
gmann | i mean locally you can try first | 18:14 |
haleyb | this is "hacking>=1.1.0,<1.2.0" since it's stable/ussuri, not hacking 3.0.0 | 18:14 |
*** happyhemant has quit IRC | 18:15 | |
haleyb | gmann: so without either it uses flake8==2.6.2 and pycodestyle==2.6.0 :( | 18:16 |
*** ralonsoh has quit IRC | 18:17 | |
*** ociuhandu has joined #openstack-neutron | 18:18 | |
haleyb | with flake8>=3.6.0,<3.8.0 it uses flake8==3.7.9 and pycodestyle==2.5.0 | 18:18 |
haleyb | i'd have to run with -vv to see why it does that, strange | 18:19 |
gmann | haleyb: yeah so it does right things- " flake8==2.6.2 and pycodestyle==2.6.0 " are correct version for hacking 1.1.0 which you use for stable/ussuri -https://github.com/openstack/hacking/blob/0a43156fab3ca870334098afd1914b5e0bdbc3e6/requirements.txt#L6 | 18:22 |
*** ralonsoh has joined #openstack-neutron | 18:22 | |
gmann | if you pull higher flake8 it might end up asking few code change if something in ussuri code behind some checks | 18:23 |
haleyb | gmann: but the pycodestyle version has the new checks that cause the failure | 18:23 |
*** jamesden_ has joined #openstack-neutron | 18:26 | |
*** jamesdenton has quit IRC | 18:27 | |
gmann | haleyb: but it will pull pycodestyle==2.5.0 if no flake8 or pycodestyle in test-requirement.txt | 18:27 |
*** jamesden_ is now known as jamesdenton | 18:28 | |
haleyb | gmann: no, in that case it pulled 2.6.0 | 18:28 |
haleyb | let me double-check | 18:28 |
haleyb | Using cached pycodestyle-2.6.0-py2.py3-none-any.whl | 18:30 |
haleyb | tox -e pep8 -r -vv | 18:30 |
*** iurygregory has joined #openstack-neutron | 18:31 | |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/neutron master: Remove unneeded DB register retrieval and refresh in network update https://review.opendev.org/726424 | 18:32 |
gmann | haleyb: humm and 2.60 does not work for ussuri ? | 18:33 |
haleyb | gmann: no, it has the new E471 checks, and a few others | 18:33 |
haleyb | gmann: i just didn't want to cherry-pick a large change to fix style issues | 18:33 |
gmann | i tried to find exact version of pycodestyle for https://github.com/PyCQA/flake8/ 2.6.2 but could not find | 18:33 |
haleyb | since it's broken all the way to rocky | 18:34 |
*** livelace has quit IRC | 18:35 | |
gmann | haleyb: cannot find how flake8 2.6.2 capped pycodestyle or started doing after that | 18:38 |
* haleyb shrugs | 18:38 | |
gmann | haleyb: i think explicit cap as you proposed is way forward to avoid big backports. | 18:38 |
haleyb | it works... for now | 18:39 |
gmann | ? you mean with flake8 2.6.2 ? | 18:41 |
haleyb | gmann: with flake8 3.7.9 it seems to work fine | 18:41 |
gmann | haleyb: on ussuri right? it may break on older release? but anything is fine whatever work, either capping pycodestyle or flake8 | 18:43 |
*** ralonsoh has quit IRC | 18:43 | |
gmann | may be we can check all backports together and then merge ussuri one if it work i all required stable branch | 18:43 |
haleyb | gmann: yes, on ussuri, i haven't tried older than that yet | 18:43 |
*** livelace has joined #openstack-neutron | 18:50 | |
openstackgerrit | Brian Haley proposed openstack/neutron stable/ussuri: Cap pycodestyle to be < 2.6.0 https://review.opendev.org/727274 | 19:09 |
*** ociuhandu has quit IRC | 19:12 | |
*** ociuhandu has joined #openstack-neutron | 19:12 | |
*** ociuhandu has quit IRC | 19:13 | |
*** ociuhandu has joined #openstack-neutron | 19:13 | |
*** nirmoy has quit IRC | 19:17 | |
*** ociuhandu has quit IRC | 19:23 | |
*** ociuhandu has joined #openstack-neutron | 19:24 | |
*** ociuhandu has quit IRC | 19:29 | |
*** dsneddon has joined #openstack-neutron | 19:32 | |
*** slaweq has quit IRC | 19:57 | |
*** slaweq has joined #openstack-neutron | 20:01 | |
*** slaweq has quit IRC | 20:06 | |
*** nweinber has quit IRC | 20:14 | |
openstackgerrit | Brian Haley proposed openstack/neutron master: Switch to hacking 3.0 https://review.opendev.org/708966 | 20:19 |
*** tmorin has quit IRC | 20:24 | |
*** slaweq has joined #openstack-neutron | 20:35 | |
*** awalende_ has quit IRC | 20:40 | |
*** ociuhandu has joined #openstack-neutron | 20:40 | |
*** awalende has joined #openstack-neutron | 20:42 | |
*** ociuhandu has quit IRC | 20:53 | |
*** ociuhandu has joined #openstack-neutron | 20:54 | |
*** ociuhandu has quit IRC | 20:54 | |
*** ociuhandu has joined #openstack-neutron | 20:54 | |
openstackgerrit | Brian Haley proposed openstack/neutron master: Switch to hacking 3.0.1 https://review.opendev.org/708966 | 20:59 |
*** jamesdenton has quit IRC | 20:59 | |
*** jamesdenton has joined #openstack-neutron | 21:03 | |
*** slaweq has quit IRC | 21:13 | |
*** ccamposr__ has joined #openstack-neutron | 21:21 | |
*** ccamposr has quit IRC | 21:23 | |
*** slaweq has joined #openstack-neutron | 21:25 | |
openstackgerrit | Terry Wilson proposed openstack/ovsdbapp master: WIP Add indexed column support to ovsdbapp https://review.opendev.org/678076 | 21:25 |
openstackgerrit | Brian Haley proposed openstack/neutron-lib master: Fix errors found by new pycodestyle https://review.opendev.org/727470 | 21:29 |
openstackgerrit | Brian Haley proposed openstack/neutron-lib master: Update to victoria jobs template https://review.opendev.org/727471 | 21:29 |
*** slaweq has quit IRC | 21:30 | |
*** awalende has quit IRC | 21:36 | |
*** slaweq has joined #openstack-neutron | 21:40 | |
*** ociuhandu has quit IRC | 21:41 | |
*** ociuhandu has joined #openstack-neutron | 21:42 | |
*** ociuhandu has quit IRC | 21:42 | |
*** ociuhandu has joined #openstack-neutron | 21:43 | |
*** slaweq has quit IRC | 21:44 | |
openstackgerrit | Flavio Fernandes proposed openstack/neutron master: WIP (DNM): [ovn]: port forwarding functionality https://review.opendev.org/723863 | 21:44 |
*** ociuhandu has quit IRC | 21:52 | |
*** ociuhandu has joined #openstack-neutron | 21:54 | |
*** ociuhandu has quit IRC | 21:54 | |
*** ociuhandu has joined #openstack-neutron | 21:54 | |
*** ociuhandu has quit IRC | 22:05 | |
*** ociuhandu has joined #openstack-neutron | 22:05 | |
*** ociuhandu has quit IRC | 22:06 | |
*** ociuhandu has joined #openstack-neutron | 22:06 | |
*** ociuhandu has quit IRC | 22:16 | |
*** ociuhandu has joined #openstack-neutron | 22:17 | |
*** ociuhandu has quit IRC | 22:17 | |
*** ociuhandu has joined #openstack-neutron | 22:18 | |
*** ociuhandu has quit IRC | 22:28 | |
*** ociuhandu has joined #openstack-neutron | 22:29 | |
*** ociuhandu has quit IRC | 22:29 | |
*** ociuhandu has joined #openstack-neutron | 22:29 | |
*** ccamposr has joined #openstack-neutron | 22:32 | |
*** ccamposr__ has quit IRC | 22:35 | |
*** ociuhandu has quit IRC | 22:39 | |
*** ociuhandu has joined #openstack-neutron | 22:41 | |
*** ociuhandu has quit IRC | 22:51 | |
*** ociuhandu has joined #openstack-neutron | 22:52 | |
*** ociuhandu has quit IRC | 22:52 | |
*** ociuhandu has joined #openstack-neutron | 22:53 | |
*** tkajinam has joined #openstack-neutron | 22:54 | |
*** ociuhandu has quit IRC | 23:03 | |
*** ociuhandu has joined #openstack-neutron | 23:04 | |
*** ociuhandu has quit IRC | 23:15 | |
*** ociuhandu has joined #openstack-neutron | 23:16 | |
*** rcernin has joined #openstack-neutron | 23:19 | |
*** ociuhandu has quit IRC | 23:21 | |
*** awalende has joined #openstack-neutron | 23:36 | |
*** awalende has quit IRC | 23:41 | |
*** mlavalle has quit IRC | 23:53 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!