Friday, 2021-06-18

yangyi01hello, anybody there?01:08
yangyi01Is driver meeting Beijing Time 22:00 Fri if it is UTC 14:00 Fri?01:09
opendevreviewIhar Hrachyshka proposed openstack/neutron master: Bump minimal ovsdbapp version to 1.11.0  https://review.opendev.org/c/openstack/neutron/+/79694301:32
slaweqyangyi01 hi, yes, that's correct06:17
opendevreviewRodolfo Alonso proposed openstack/neutron master: Sanitize MAC addresses  https://review.opendev.org/c/openstack/neutron/+/78983106:36
opendevreviewKamil Sambor proposed openstack/neutron master: Enable querier for multicast (IGMP) in OVN  https://review.opendev.org/c/openstack/neutron/+/79699707:15
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/wallaby: Read keepalived initial state in parallel to interface monitoring  https://review.opendev.org/c/openstack/neutron/+/79686507:33
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/victoria: Read keepalived initial state in parallel to interface monitoring  https://review.opendev.org/c/openstack/neutron/+/79686607:34
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/ussuri: Read keepalived initial state in parallel to interface monitoring  https://review.opendev.org/c/openstack/neutron/+/79699807:37
opendevreviewJakub Libosvar proposed openstack/neutron stable/wallaby: ovn: Don't use dict.remove() for filtering dhcp ports in db-sync  https://review.opendev.org/c/openstack/neutron/+/79687207:43
opendevreviewJakub Libosvar proposed openstack/neutron stable/victoria: ovn: Don't use dict.remove() for filtering dhcp ports in db-sync  https://review.opendev.org/c/openstack/neutron/+/79701307:43
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/train: Read keepalived initial state in parallel to interface monitoring  https://review.opendev.org/c/openstack/neutron/+/79699907:45
opendevreviewJakub Libosvar proposed openstack/neutron stable/ussuri: ovn: Don't use dict.remove() for filtering dhcp ports in db-sync  https://review.opendev.org/c/openstack/neutron/+/79700007:48
opendevreviewLajos Katona proposed openstack/networking-bgpvpn stable/train: stable only: Fix failing jobs and make l-c non-voting  https://review.opendev.org/c/openstack/networking-bgpvpn/+/79680807:56
opendevreviewJakub Libosvar proposed openstack/networking-ovn stable/train: ovn: Don't use dict.remove() for filtering dhcp ports in db-sync  https://review.opendev.org/c/openstack/networking-ovn/+/79700107:58
*** rpittau|afk is now known as rpittau08:17
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Remove FIP agent's gw port when L3 agent is deleted  https://review.opendev.org/c/openstack/neutron/+/78769108:21
opendevreviewMamatisa Nurmatov proposed openstack/neutron master: use payloads for PORT AFTER_UPDATE events  https://review.opendev.org/c/openstack/neutron/+/79511708:31
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Force to close http connection after notify about HA router status  https://review.opendev.org/c/openstack/neutron/+/79684408:34
opendevreviewMamatisa Nurmatov proposed openstack/neutron master: use payloads for PORT AFTER_DELETE events  https://review.opendev.org/c/openstack/neutron/+/79700408:34
slaweqralonsoh obondarev lajoskatona please check https://review.opendev.org/c/openstack/neutron/+/796844 when You will have some time08:34
ralonsohslaweq, right now08:38
slaweqThanks08:55
bcafarelslaweq: wow nice one (I guess it is something to backport to branches running on focal?)09:02
slaweqbcafarel yes, I will backport it09:02
opendevreviewRodolfo Alonso proposed openstack/neutron master: Sanitize MAC addresses  https://review.opendev.org/c/openstack/neutron/+/78983109:21
ralonsohlajoskatona, can you please check https://review.opendev.org/c/openstack/neutron/+/795761?09:24
ralonsohthank you in advance09:24
lajoskatonaralonsoh: sure09:25
ralonsohlucasagomes, if you have some time (I know the patch is quite big): minBW placement for OVN09:25
ralonsohhttps://review.opendev.org/c/openstack/neutron/+/776701/2209:25
ralonsoh(there are other 3 patches on top of this one)09:25
lucasagomesralonsoh, thanks I will try to take a look soon09:29
bcafarelslaweq: https://review.opendev.org/c/openstack/neutron/+/788893 so this may change default value returned, but I suppose if get_hypervisor_hostname != socket.gethostname() that deployment was not working properly?09:50
bcafarel(aka for existing working deployments, this does not change the value returned)09:50
slaweqbcafarel do You mean resource_provider_default_hypervisor's value?09:53
bcafarelslaweq: yes, if an existing working deployment had socket.gethostname() and after that patch value returned by get_hypervisor_hostname() is a different one09:55
bcafarelif I got it correctly this should not exist in the real world (as it would mean broken configuration and non-working hypervisor), but just wanted to confirm :)09:56
bcafarelas it potentially changes the default value used09:56
slaweqbcafarel yes, it may, but that config option was introduced in the previous patch in same series: https://review.opendev.org/c/openstack/neutron/+/763563/809:57
slaweqso in fact nobody will use one without another :)09:57
bcafarelooh true09:58
bcafarelwell I had reviewed the previous patch at least 20 minutes ago, so it is normal I forgot about it in this long interval :)09:59
slaweq:D10:00
opendevreviewDr. Jens Harbott proposed openstack/neutron-dynamic-routing master: Drop dsvm-functional tox env and related files  https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/79704410:17
opendevreviewDr. Jens Harbott proposed openstack/neutron-dynamic-routing master: Use xena-based job definitions instead of wallaby  https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/79704510:17
opendevreviewRodolfo Alonso proposed openstack/neutron master: Make explicit the network backend used in the CI jobs  https://review.opendev.org/c/openstack/neutron/+/79705110:27
opendevreviewRodolfo Alonso proposed openstack/neutron master: Make explicit the network backend used in the CI jobs  https://review.opendev.org/c/openstack/neutron/+/79705110:50
opendevreviewSlawek Kaplonski proposed openstack/neutron master: DVR: Populate ARP entries of the allowed_address_pairs to the routers  https://review.opendev.org/c/openstack/neutron/+/60133611:08
opendevreviewJakub Libosvar proposed openstack/neutron master: ovn: Make ovn metadata agent report optional  https://review.opendev.org/c/openstack/neutron/+/79299812:07
opendevreviewMamatisa Nurmatov proposed openstack/neutron master: use callback payloads for SECURITY_GROUP  https://review.opendev.org/c/openstack/neutron/+/67404412:09
opendevreviewMamatisa Nurmatov proposed openstack/neutron master: use callback payloads for SECURITY_GROUP_RULE  https://review.opendev.org/c/openstack/neutron/+/79289512:26
opendevreviewSlawek Kaplonski proposed openstack/networking-sfc master: Use ovs constants from neutron-lib  https://review.opendev.org/c/openstack/networking-sfc/+/79707712:53
opendevreviewRodolfo Alonso proposed openstack/neutron master: Make explicit the network backend used in the CI jobs  https://review.opendev.org/c/openstack/neutron/+/79705113:14
opendevreviewMamatisa Nurmatov proposed openstack/neutron master: use payloads for PORT AFTER_DELETE events  https://review.opendev.org/c/openstack/neutron/+/79700413:24
opendevreviewLuis Tomas Bolivar proposed openstack/neutron master: WIP/DNR Add neutron port tags information into OVN DBs  https://review.opendev.org/c/openstack/neutron/+/79708713:59
slaweq#startmeeting neutron_drivers14:00
opendevmeetMeeting started Fri Jun 18 14:00:18 2021 UTC and is due to finish in 60 minutes.  The chair is slaweq. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'neutron_drivers'14:00
slaweqhi14:00
fnordahlo/14:00
mlavalleo/14:00
obondarevhi14:00
amotokio/14:00
lajoskatonai14:00
lajoskatonaHi14:00
velizarx_o/14:01
ralonsohhi14:01
yangyi01hi14:01
*** velizarx_ is now known as velizarx14:01
dmitriiso/14:02
slaweqI think we can start14:02
slaweq#topic RFEs14:02
slaweqwe have one new RFE for today14:03
slaweqhttps://bugs.launchpad.net/neutron/+bug/193195314:03
slaweqwhich in fact isn't very new as we had something similar in the past14:03
slaweqhttps://bugs.launchpad.net/neutron/+bug/1705536, https://blueprints.launchpad.net/neutron/+spec/openflow-based-dvr14:03
ralonsohI added this topic but I shouldn't talk about it14:04
slaweqralonsoh I think You should :)14:04
yangyi01I filed this REF14:04
ralonsohyangyi01, will present this feature better than me14:04
ralonsohright14:04
slaweqhi yangyi01, good that You are here :)14:04
yangyi01ok, let me talk about why we need it.14:05
yangyi01Actually, I have worke on this tough issue last year in OVS project.14:06
yangyi01We want to use OVS DPDK in openstack14:06
mlavallewho's we?14:07
yangyi01But obviously it is very very bad as far as performance is concerned.14:07
yangyi01Inpur, China-based cloud provider.14:07
mlavalleack14:07
yangyi01I have fixed many perofermance issues on OVS DPDK side.14:08
yangyi01including VXLAN TSO, GRO, GSO, UFO, etc.14:08
yangyi01I also have a batch process patch to improve tap and veth performnce in OVS, it has been merged.14:09
*** rpittau is now known as rpittau|afk14:09
yangyi01that can improve performance significantly, but it is far not enough.14:10
yangyi01it is best way not to use tap and veth in OVS DPDK case.14:10
yangyi01that is why I want to have this REF.14:11
yangyi01this can improve across-node L3 vm to vm performance and FIP performance dramatically.14:12
yangyi01the result is really incredible.14:12
yangyi01this REF also can improve OVS kernel performance and big UDP issue.14:13
mlavallein your RFE you mention that it is different to https://blueprints.launchpad.net/neutron/+spec/openflow-based-dvr. How is it different?14:13
yangyi01now, big UDP or big ICMP  can't work in OVS kernel case with security group in linux bridge.14:14
yangyi01yes, implementation way is different.14:14
mlavallehow?14:14
yangyi01I think old spec only considered virtual IP, didn't consider FIP.14:15
ralonsohit was, in centralized mode14:15
yangyi01for FIP, only neutron as a SDN controller and handle ARP request can fix it.14:16
amotokiIIRC current DVR supports FIP from compute nodes. 14:17
yangyi01yes, for SNAT, it also used FIP, that can be centralized or distributed.14:18
ralonsohfor sure, L3 agents supports this, not the Intel implementation for OF DVR14:18
ralonsohbut let's focus on the new implementation14:18
yangyi01Intel just impelmented l3 agent by using openflow.14:19
yangyi01I was Intel guy before.14:19
slaweqdo You think that Your solution may replace current DVR implementation, or we should keep both in-tree?14:19
yangyi01if you chech that submited implementation patch, I don't think it can work, it din't install flow per FIP or qrouter.14:20
mlavallemeaning it cannot replace the current DVR implementation?14:21
opendevreviewLajos Katona proposed openstack/networking-bgpvpn stable/train: stable only: Fix failing jobs and make l-c non-voting  https://review.opendev.org/c/openstack/networking-bgpvpn/+/79680814:21
yangyi01We added a config option dvr_use_openflow, if set to True, l3 agent will install openflow to br-int, if false, old way can still work.14:22
yangyi01my REF depends on current DVR impelmetation.14:22
amotokido you mean the neutron tree maintains two different OVS based DVR implementations?14:22
mlavallethanks for the clarification14:23
obondarevI'd say not only DVR but all L3 agent, right?14:23
slaweqso in Your implementation L3 agent will change flows in the br-int directly, right?14:24
yangyi01I think it is ok. With old implementation there, users can use old namespaces to do anything as before.14:24
yangyi01yes14:25
slaweqmy main concern is maintenance of that code, we will need to add new CI job to have it tested, etc.14:25
slaweq:/14:25
yangyi01it is worthy for super high performance.14:25
obondarevan option is to have it in a separate networking-ovs-dvr repo, right?14:26
ralonsohthat's a good option14:26
yangyi01FIP can reach line speed, I don't think current implementation can attain this.14:26
ralonsohI have the same concern as slaweq. This is not like the distributed DHCP feature in OVS, that removes the need of any DHCP agent.14:27
mlavalleor why don't we go in the opposite direction... could this proposal be used as a springboard to have a brand new DVR implementaion in tree?14:27
slaweqor include it in networking-ovs-dpdk repo maybe?14:27
ralonsohhere you are duplicating paths: with iptables or OF, but keeping the L3 agent14:27
ralonsoh(and the L3 agent code is not easy to maintain)14:27
ralonsohnetworking-ovs-dpdk is dead14:28
mlavallethat's why I say, take this as an opportunity for a new reset14:28
yangyi01this isn't ML2 driver, main neutron tree is best place for this. 14:28
mlavalleyangyi01: what would it take to expand your effort to completely replace our current DVR implementation?14:29
yangyi01Not sure, if it has been stable enough, we can remove old unnecesary DVR code.14:31
amotokiour concern is mainly for the maintenance cost of having competing DVR implementations. It includes the number of CI jobs, review bandwitdh and deeper knowledge of specific impls.14:31
* mlavalle understands slaweq and ralonsoh concerns about CI and all that. But meaybe this is an opportunity to offer our OVS deployments a more performant DVR implementation. THos OVS deployments will be around for a loong time14:31
ralonsohmlavalle, we should support linux bridge14:31
ralonsohthat won't work with an OF based L3 agent14:32
slaweqralonsoh DVR don't works with linux bridge currently14:32
slaweqso that's not an issue IMO14:32
ralonsohright14:32
ralonsohsorry14:32
mlavalleall I'm saying is that we have and will have  for a long time OVS users and we should strive to improve their performance experience when the oppotunity arises. Maybe this is one of these opportunities if we expand the effort14:33
slaweqTBH personally I'm a bit torn here - from one side I have this maintenance concern, but from the other hand I like idea of more performant DVR implementation, especially that old RFE for that was actually approved already long time ago :)14:33
ralonsohI'm ok with this if that means replace any other implementation. I prefer not to have two paths in the code14:33
mlavalleyeah, I agree with not having two paths in the code14:34
yangyi01Finally, we can have one path if new path is good enough, I'm not sure if it covers some corner cases.14:35
ralonsohyou have my +1 if that RFE includes the replacement of all iptables/conntrack code and provides the same functionality14:36
ralonsohand a good spec to know how are you going to implement it14:36
mlavalleso going back to yangyi01, could we re-scope your RFE / spec in such a way that the effort's goal is to replace our DVR implementation in OF?14:36
slaweqI agree with ralonsoh - if that can finally be replacement for old implementation of DVR, than I'm ok with it14:36
slaweqbut IMO we will need much more detailed spec first14:37
amotokiralonsoh: what do you mean by "the replacement of all iptables/conntrack code"? is it the one related to the current DVR?14:37
amotokior l3-agent itself?14:37
ralonsohamotoki, yes, just this code14:37
yangyi01No problem, please point out what parts it ddin't cover, I can add them.14:37
ralonsohno no, not all L3 agent, only DVR stuff14:37
mlavalleralonsoh: DVR, right?14:37
ralonsohyes14:38
amotokiralonsoh: thanks14:38
mlavalle+114:38
obondarevwhat is L3 agent without DVR?14:38
yangyi01I have iplemented it, maybe patch is best spec.14:38
ralonsohsorry no14:38
obondarevin a DVR env DVR and L3 agent seem the same14:38
ralonsohI could help, but no14:38
yangyi01I can submit my patch if you want to know details.14:38
yangyi01l2 agent also handled many DVR-related stuff, DVR is very complicated.14:39
slaweqyangyi01 only implementation will for sure not be enough, even if not detailed spec, we would need some docs patch at least with detailed description of tables/flows/etc.14:39
mlavalleyeah, because we have to live with the maintenace issue14:40
mlavalleso I'd say, let's start with a good spec of what is going to be done14:40
yangyi01understood, developers prefer  code to docuemnt.14:40
mlavalleyangyi01: we are being supportive of you, don't dismiss us as non-developers14:41
mlavallenot very nice of you14:41
slaweqso let's vote - I'm +1 to approve this rfe, but it's final goal should be to replace current dvr implementation, and we will need detailed spec and docs with description of how it works14:43
yangyi01mlavalle, sorry, I can add parts you expect, please add your comments in current spec. not sure what parts are missed.14:43
ralonsoh+1 with those conditions14:43
mlavalle+1 with aformentioned conditions14:44
yangyi01+1 by myself :-)14:44
slaweqamotoki any thoughts?14:45
amotoki+1. I agree the final goal should cover replacing with the current dvr impl. I think we need to cover the rough plan in the spec.14:45
slaweqthx, I will mark rfe as approved with those mentioned conditions14:46
slaweqand we can then review spec and then implementation as well14:46
mlavalleinclude those conditions in your approval comment14:46
slaweqmlavalle sure, I will14:46
slaweqthx yangyi01 for the proposal14:47
slaweqok, that was the only rfe for today14:47
fnordahlAnything you need answered to triage https://bugs.launchpad.net/neutron/+bug/1932154 for next weeks meeting?14:47
slaweqdo You have any other topics You would like to talk about?14:47
amotokiyangyi01: one question: you said "add your comments in current spec". did you already propose some spec?14:47
yangyi01One question, how long can a approved spec take to finish? This is a big engineering effort.14:48
yangyi01yes, I have submited spec.14:48
slaweqamotoki https://review.opendev.org/c/openstack/neutron-specs/+/79674614:48
slaweqthis is the spec14:48
amotokithanks. I just found it :)14:48
velizarxcould we discuss RFE from previous meeting https://bugs.launchpad.net/neutron/+bug/1931100?14:49
yangyi01https://blueprints.launchpad.net/neutron/+spec/openflow-based-dvr-l314:49
slaweqfnordahl I asked ralonsoh to check Your rfe, I think he didn't check it yet14:49
ralonsohslaweq, I couldn't yet14:49
slaweqralonsoh np at all :)14:50
fnordahlslaweq, ralonsoh ok, nw, ta for answer, we'll wait in line :)14:50
slaweqok, lets quickly back to velizarx's RFE https://bugs.launchpad.net/neutron/+bug/193110014:50
slaweqamotoki I see that velizarx just replied to Your comment yesterday14:51
amotokiI saw it.14:51
mlavalleThis last RFE makes sense at first glance14:51
amotokiit clarifies what should be shared and I think we can allow network/router association only to end-users with access_as_shared.14:52
amotokiI am now fine with this RFE.14:52
slaweqthx amotoki, are there any other questions regarding that RFE?14:52
slaweqor can we vote on it now?14:52
mlavallemhhh, I said at first glance14:53
amotokislaweq: no more questions from me14:53
slaweqI'm +1 on that RFE too14:53
mlavalleif you want my vote, can we vote at the beginning of next meeting?14:53
slaweqmlavalle we can, of course but next week I will not be able to chair the meeting so I though about cancelling it14:54
slaweqin that case we will have next meeting in 2 weeks14:54
slaweqif You want, we can wait with this RFE14:54
mlavalleof course y'all can go ahead and approve without me. I just don't want to give a +1 without some thinking14:54
velizarxCould you give some details about glance? Where is a problem?14:55
velizarxI'm a bit out of context 14:55
mlavalleglance means at first sight14:55
velizarxah :)14:55
mlavalleI'm not talking glance the OpenStack project14:56
mlavalleslaweq: please feel free to approve this RFE without me. "At first glance" I don't have any concerns14:56
mlavalle:-)14:56
ralonsohI think it sounds reasonable but as amotoki said, the spec should define the operations to be allowed14:57
ralonsohso +1 from me too14:57
velizarxI have only one question about implementation (if this RFE will be approved ofc) for this RFE. For this RFE I should add BGPV's objects to the main neutron repository (to neutron/objects) but all other code will be in networking-bgpvpn repository. Is it problem?14:57
slaweqthx mlavalle and ralonsoh14:57
slaweqI will mark rfe as approved14:57
ralonsohno, those objects will live in your repo14:57
ralonsohwe can talk about this later14:58
velizarxok, will retrun with this question ;) thx14:58
slaweqthank You all for attending the meeting14:58
amotokiI think we can skip the spec for this RFE. 14:58
slaweqwe are almost on top of the hour now14:58
ralonsohamotoki, ok then, I'll wait for the patch14:58
slaweqamotoki I agree with You14:58
amotokithe scope clarifies in the RFE. the API ref and the patch can cover it.14:59
ralonsohperfect14:59
amotokis/clarifies/is clarified/14:59
slaweqhave a great weekend and see You online :)14:59
slaweq#endmeeting14:59
opendevmeetMeeting ended Fri Jun 18 14:59:53 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:59
opendevmeetMinutes:        https://meetings.opendev.org/meetings/neutron_drivers/2021/neutron_drivers.2021-06-18-14.00.html14:59
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/neutron_drivers/2021/neutron_drivers.2021-06-18-14.00.txt14:59
opendevmeetLog:            https://meetings.opendev.org/meetings/neutron_drivers/2021/neutron_drivers.2021-06-18-14.00.log.html14:59
ralonsohhave a nice weekend14:59
mlavalleo/14:59
amotokio/15:00
fnordahl\o cheers15:00
lajoskatonao/15:00
velizarxo/15:00
yangyi01bye15:00
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Use ovs constants from neutron-lib  https://review.opendev.org/c/openstack/neutron/+/79712015:06
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Remove ovs agent's common constants module  https://review.opendev.org/c/openstack/neutron/+/79712115:06
opendevreviewKamil Sambor proposed openstack/neutron master: Enable querier for multicast (IGMP) in OVN  https://review.opendev.org/c/openstack/neutron/+/79699715:11
opendevreviewGregory Thiemonge proposed openstack/neutron master: Fix devstack path in plugin.sh  https://review.opendev.org/c/openstack/neutron/+/79712815:30
opendevreviewLajos Katona proposed openstack/networking-bgpvpn stable/train: stable only: Fix failing jobs and make l-c non-voting  https://review.opendev.org/c/openstack/networking-bgpvpn/+/79680815:39
sean-k-mooneyslaweq: will you have a chance to comment on https://review.opendev.org/c/openstack/devstack/+/796826 today16:21
sean-k-mooneyralonsoh: perhaps you could ^16:21
sean-k-mooneybasicaly defaulting to the old vsctl client in os-vif via devstack until we fix https://launchpad.net/bugs/192944616:22
sean-k-mooneyit can wait to moday but if ye are around then it would be nice to get this on its way.16:25
ralonsohsean-k-mooney, sure I'll do16:26
opendevreviewMamatisa Nurmatov proposed openstack/neutron master: use payloads for PORT AFTER_DELETE events  https://review.opendev.org/c/openstack/neutron/+/79700417:02
slaweqsean-k-mooney sorry for being late with that but I already +1'ed it19:05
opendevreviewMerged openstack/neutron stable/train: Make phynet paramter also is optional when network_segment_range enabled  https://review.opendev.org/c/openstack/neutron/+/79528023:13

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!