Monday, 2022-01-17

*** EugenMayer1 is now known as EugenMayer03:02
*** tbachman_ is now known as tbachman04:18
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/xena: Register cleanup hooks for the object change handlers only when needed  https://review.opendev.org/c/openstack/neutron/+/82487207:08
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/wallaby: Register cleanup hooks for the object change handlers only when needed  https://review.opendev.org/c/openstack/neutron/+/82487307:08
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/victoria: Register cleanup hooks for the object change handlers only when needed  https://review.opendev.org/c/openstack/neutron/+/82487407:08
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/ussuri: Register cleanup hooks for the object change handlers only when needed  https://review.opendev.org/c/openstack/neutron/+/82487507:08
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/train: Fix ObjectChangeHandler thread usage  https://review.opendev.org/c/openstack/neutron/+/82252207:14
opendevreviewyatin proposed openstack/neutron stable/xena: [Stable Xena Only] Drop TripleO periodic jobs  https://review.opendev.org/c/openstack/neutron/+/82486307:42
ralonsohslaweq, hi! sorry for the revert08:16
ralonsohis it possible that you can use BUILD_OVS_FROM_SOURCE instead of Q_BUILD_OVS_FROM_GIT?08:17
opendevreviewLajos Katona proposed openstack/neutron master: [Functional/fullstack] Remove tools from irrelevant list  https://review.opendev.org/c/openstack/neutron/+/82477308:21
opendevreviewyatin proposed openstack/neutron stable/wallaby: Recheck irrelevant files  https://review.opendev.org/c/openstack/neutron/+/82490108:50
opendevreviewMerged openstack/neutron master: [OVN] Check if OVN SB supports virtual ports  https://review.opendev.org/c/openstack/neutron/+/81638309:28
slaweqralonsoh: hi, no problem, thx for fixing the gate quickly09:48
slaweqI will take a look at it and propose it once again but without breaking anything :)09:48
ralonsohI'll review it09:49
slaweqralonsoh: lajoskatona_ hi, please check backports https://review.opendev.org/q/I40b72316bd0f4281484d3cf07542177297028e34 and https://review.opendev.org/c/openstack/neutron/+/822522 when You will have some time, I really need them :)10:28
slaweqthx in advance10:28
lajoskatonaslaweq: sure10:29
jpic__lajoskatona: i mean I changed both dhcp.py's Dnsmasq code and, to a smaller extent, neutron10:29
ralonsohright now10:29
lajoskatonaslaweq, ralonsoh: I gerrit related question: I try to move this patch: https://review.opendev.org/c/openstack/tap-as-a-service/+/823492 (and https://review.opendev.org/c/openstack/neutron-lib/+/823475) , but I can't make it "ready for review", could you please check if it is a missing permission from my side or a general missing premissions10:35
ralonsohlajoskatona, I don't think you can10:37
lajoskatonajpic__: you mean this class: https://opendev.org/openstack/neutron/src/branch/master/neutron/agent/linux/dhcp.py#L362 , than cool?10:37
ralonsohbecause this is not yours10:37
lajoskatonajpic__: I mean if all code changes covered in https://review.opendev.org/c/openstack/neutron/+/824718 ?10:38
ralonsohYou need to (1) ask the owner or (2) abandon and propose a new one10:38
lajoskatona ralonsoh: yeah, the guy already left my organization, so I suppose I have to abandon/repropose10:38
ralonsohexactly10:38
slaweqralonsoh: can You maybe +W https://review.opendev.org/c/openstack/neutron/+/821132/ ?10:42
slaweqthx in advance10:42
ralonsohyes10:43
slaweqor wait10:45
slaweqit was on top of the patch which You reverted10:45
slaweqso I will check it10:46
slaweqfirst :)10:46
ralonsohah right, we need first the options for centos10:47
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Make configure_for_func_testing compatible with e.g. Centos  https://review.opendev.org/c/openstack/neutron/+/82492411:17
slaweqralonsoh: ^^ iit's second attempt now11:17
ralonsohlet's go11:17
slaweqit should works better now, and also it should run functional tests job on that patch so we will see if that breaks anything or not11:18
slaweq:)11:18
ralonsohslaweq, but we shouldn't use Q_* variables11:18
slaweqwhy?11:18
ralonsohthose are private and internal to the scripts11:18
slaweqQ_BUILD_OVS_FROM_GIT is devstack's variable11:18
slaweqwe are already using it in e.g. neutron's devstack plugin: https://opendev.org/openstack/neutron/src/branch/master/devstack/plugin.sh#L2311:19
ralonsohheheheh because you added it11:19
ralonsohI think we should not use them, but maybe devstack folks will know that better11:19
slaweqbut what's the point of having additional variable used in the functional tests job just to set the Q_BUILD_OVS_FROM_GIT later?11:21
slaweqdo we really need it to be like that?11:21
opendevreviewMerged openstack/neutron master: [Functional/fullstack] Remove tools from irrelevant list  https://review.opendev.org/c/openstack/neutron/+/82477311:22
ralonsohslaweq, I think at some point, we started to misuse this variable11:23
opendevreviewLajos Katona proposed openstack/neutron-lib master: Move API definitions of taas to neutron-lib  https://review.opendev.org/c/openstack/neutron-lib/+/82492611:24
opendevreviewLajos Katona proposed openstack/tap-as-a-service master: WIP: Modify taas extensions to use neutron-lib API def  https://review.opendev.org/c/openstack/tap-as-a-service/+/82492711:27
slaweqralonsoh: so do You think we should use in FT job some other variable?11:27
slaweqI don't really see any value in that, especially that it's only for the CI purpose, nothing else11:27
jpic_lajoskatona: yes, i'm asking if i can leave them changes all together or if i need to split the RFE and patch11:27
ralonsohslaweq, I'm checking devstack now and we have removed "BUILD_OVS_FROM_SOURCE" from there11:27
ralonsohso at this point makes sense to use the other one11:27
slaweq++11:28
ralonsohslaweq, there is a merge conflict11:30
ralonsohcan you update it?11:30
slaweqyes, with https://review.opendev.org/c/openstack/neutron/+/824773 :)11:30
slaweqI will update my patch right now11:30
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Make configure_for_func_testing compatible with e.g. Centos  https://review.opendev.org/c/openstack/neutron/+/82492411:32
opendevreviewyatin proposed openstack/neutron stable/xena: [Functional] Add extra logs to the L3 HA router transitions  https://review.opendev.org/c/openstack/neutron/+/82488611:51
opendevreviewLajos Katona proposed openstack/tap-as-a-service master: Modify taas extensions to use neutron-lib API def  https://review.opendev.org/c/openstack/tap-as-a-service/+/82492712:11
lajoskatonapic_: as I see your current patch it is not too big, so can be consumed in one, but please push changes to master not to stable/ branches12:14
lajoskatonajpic_:  and a suggestion: you can locally execute easily some tests with tox, i.e.: tox -epep8 to run static code check12:15
lajoskatona jpic_: for executing all the unit tests, you need a lot of CPU time, but even that is possible with tox -epy39 (or py3x depending on your python binary at  hand)12:16
opendevreviewMerged openstack/neutron stable/xena: Register cleanup hooks for the object change handlers only when needed  https://review.opendev.org/c/openstack/neutron/+/82487212:35
opendevreviewMerged openstack/neutron stable/wallaby: Register cleanup hooks for the object change handlers only when needed  https://review.opendev.org/c/openstack/neutron/+/82487312:35
*** dasm|off is now known as dasm13:13
slaweqralonsoh: lajoskatona can You check https://review.opendev.org/c/openstack/neutron/+/823412? It's breaking some Tripleo CI jobs13:29
slaweqthx a lot in advance13:29
ralonsohsure13:30
lajoskatonaslaweq: sure13:33
ralonsohltomasbo, hi! do you mind to rebase https://review.opendev.org/c/openstack/neutron/+/824378 in top of https://review.opendev.org/c/openstack/neutron/+/823412?13:38
ralonsohjust to check that both patches solve all trunk port issues13:38
ralonsohthanks in advance!13:38
ltomasboralonsoh, of course!14:00
opendevreviewLuis Tomas Bolivar proposed openstack/neutron master: Ensure subports status is aligned with parent port  https://review.opendev.org/c/openstack/neutron/+/82437814:03
ltomasboralonsoh, done14:03
ralonsohthanks14:03
ltomasboralonsoh, anyway, regarding https://review.opendev.org/c/openstack/neutron/+/824378, I think there is no testing coverage for it anyway14:03
ralonsohyeah, I know14:03
ralonsohIt could be interesting at least to have something in FT14:04
ralonsohis that possible?14:04
ralonsohI say FT because this is usually faster to develop and test14:04
ralonsohand we can simulate trunk ports in the OVN DB14:04
opendevreviewMerged openstack/neutron stable/victoria: Register cleanup hooks for the object change handlers only when needed  https://review.opendev.org/c/openstack/neutron/+/82487414:19
opendevreviewMaximilian Stinsky proposed openstack/neutron master: Return true if we are not keepalived primary  https://review.opendev.org/c/openstack/neutron/+/82494714:40
opendevreviewMerged openstack/ovsdbapp master: Update QoS register in "QoSAddCommand" if exists  https://review.opendev.org/c/openstack/ovsdbapp/+/82213815:24
gmannlajoskatona: slaweq ralonsoh mlavalle  Not sure if you have discussed about bringing neutron-fwaas back (as discussion going on on ML) but there is project-config change to maintain it outside of openstack because it is deprecated in openstack -  https://review.opendev.org/c/openstack/project-config/+/824905/15:36
ralonsohgmann, it was discussed last friday15:36
ralonsohin the drivers meeting. It was approved to keep it in /x namespace15:36
ralonsohand continue the development there for now15:37
slaweqnot keep but move it to x/ namespace :)15:37
lajoskatonagmann, ralonsoh: yes, exactly15:37
gmannohk, 15:37
slaweqbut all other is correct :)15:37
gmanncan either of you please  update it on ML thread. we will proceed from governance and project-config side. 15:37
slaweq*everything else is correct15:38
slaweqIMO lajoskatona is the best guy to update it15:38
lajoskatonaslaweq: +1 :P15:38
gmannI think this was last reply http://lists.openstack.org/pipermail/openstack-discuss/2022-January/026550.html15:38
gmannthanks. 15:38
lajoskatonagmann: I answer it to the same thread then15:39
gmannlajoskatona: perfect, thanks again15:39
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Don't publish PROVISIONING_COMPLETE notification if there wasn't block  https://review.opendev.org/c/openstack/neutron/+/82498115:56
opendevreviewMerged openstack/neutron stable/train: Fix ObjectChangeHandler thread usage  https://review.opendev.org/c/openstack/neutron/+/82252216:00
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Call enable DHCP only if there are subnets with enabled DHCP in network  https://review.opendev.org/c/openstack/neutron/+/82498216:07
opendevreviewMerged openstack/ovn-octavia-provider master: Set listeners back to ACTIVE upon pool/member action failures  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/82354417:03
opendevreviewMaximilian Stinsky proposed openstack/neutron master: Return true if we are not keepalived primary  https://review.opendev.org/c/openstack/neutron/+/82494717:32
opendevreviewMerged openstack/neutron master: Exclude router gw subnet ports from port list while port delete.  https://review.opendev.org/c/openstack/neutron/+/82400817:44
opendevreviewMerged openstack/networking-ovn stable/train: [OVN] Prevent deleting the only IP of a router port  https://review.opendev.org/c/openstack/networking-ovn/+/82378719:37
*** eagles_ is now known as eagles20:24
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Add FIPS enabled scenario jobs  https://review.opendev.org/c/openstack/neutron/+/79753720:27
opendevreviewAde Lee proposed openstack/neutron master: Add FIPS enabled scenario jobs  https://review.opendev.org/c/openstack/neutron/+/79753720:32
opendevreviewElod Illes proposed openstack/networking-odl master: Update pylint version  https://review.opendev.org/c/openstack/networking-odl/+/82342820:54
opendevreviewElod Illes proposed openstack/networking-odl master: Update pylint version  https://review.opendev.org/c/openstack/networking-odl/+/82342821:11
*** tbachman_ is now known as tbachman23:01
*** dasm is now known as dasm|off23:11
*** tbachman_ is now known as tbachman23:11

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!