| opendevreview | ZhouHeng proposed openstack/neutron master: [ovn]support read chassis update time from nb_cfg_timestamp https://review.opendev.org/c/openstack/neutron/+/802834 | 01:54 |
|---|---|---|
| opendevreview | Jacy Lee proposed openstack/neutron-lib master: Support binding floating ip to smart-nic port https://review.opendev.org/c/openstack/neutron-lib/+/831639 | 05:57 |
| ykarel | obondarev, ralonsoh, can u recheck https://review.opendev.org/c/openstack/neutron/+/828687 | 08:34 |
| ralonsoh | sure | 08:35 |
| obondarev | ykarel: sure | 08:35 |
| ralonsoh | ykarel, can you check https://review.opendev.org/c/openstack/neutron/+/831830 | 08:35 |
| ykarel | ralonsoh, looking | 08:35 |
| ykarel | ralonsoh, the patch or the failures? | 08:35 |
| ykarel | i see jobs failing there | 08:36 |
| ralonsoh | the patch | 08:36 |
| ykarel | ok sure | 08:36 |
| opendevreview | Eduardo Olivares proposed openstack/neutron master: [ovn-migration] Add debug information to create-resources.sh.j2 scripts https://review.opendev.org/c/openstack/neutron/+/829027 | 08:58 |
| opendevreview | Merged openstack/neutron stable/ussuri: [OVN] Do not delete port's revision on RowNotFound https://review.opendev.org/c/openstack/neutron/+/828798 | 10:08 |
| opendevreview | Merged openstack/neutron stable/ussuri: [ovn] Prevent stale ports in the OVN database https://review.opendev.org/c/openstack/neutron/+/828799 | 10:08 |
| opendevreview | Arnau Verdaguer proposed openstack/networking-ovn stable/train: [ OVN ][Migration] Reload systemctl daemon after removal https://review.opendev.org/c/openstack/networking-ovn/+/831596 | 11:03 |
| opendevreview | Pedro Henrique Pereira Martins proposed openstack/neutron master: Extend database to support portforwardings with port range https://review.opendev.org/c/openstack/neutron/+/798961 | 11:43 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider master: Retry of logical switch association to the load balancer for large networks https://review.opendev.org/c/openstack/ovn-octavia-provider/+/829126 | 11:53 |
| opendevreview | Anton Vazhnetsov proposed openstack/ovsdbapp master: vtep: add support for 'hardware_vtep' schema https://review.opendev.org/c/openstack/ovsdbapp/+/828720 | 11:54 |
| opendevreview | Merged openstack/networking-ovn stable/train: [ OVN ][Migration] Reload systemctl daemon after removal https://review.opendev.org/c/openstack/networking-ovn/+/831596 | 12:05 |
| opendevreview | Balazs Gibizer proposed openstack/neutron-lib master: Document that PF MAC is shown from the binding:profile https://review.opendev.org/c/openstack/neutron-lib/+/831935 | 12:54 |
| opendevreview | Merged openstack/neutron master: [ovn-migration] Add debug information to create-resources.sh.j2 scripts https://review.opendev.org/c/openstack/neutron/+/829027 | 13:10 |
| opendevreview | Merged openstack/neutron stable/xena: [ OVN ][Migration] Reload systemctl daemon after removal https://review.opendev.org/c/openstack/neutron/+/831595 | 13:10 |
| opendevreview | Merged openstack/neutron stable/wallaby: [ OVN ][Migration] Reload systemctl daemon after removal https://review.opendev.org/c/openstack/neutron/+/831594 | 13:10 |
| opendevreview | Merged openstack/neutron stable/victoria: [ OVN ][Migration] Reload systemctl daemon after removal https://review.opendev.org/c/openstack/neutron/+/831593 | 13:10 |
| opendevreview | Merged openstack/neutron stable/ussuri: [ OVN ][Migration] Reload systemctl daemon after removal https://review.opendev.org/c/openstack/neutron/+/831592 | 13:10 |
| opendevreview | yatin proposed openstack/neutron-tempest-plugin master: Add script which configures patch ports between bridges https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/763628 | 13:48 |
| ralonsoh | lajoskatona, hi | 14:03 |
| lajoskatona | #startmeeting neutron_drivers | 14:03 |
| opendevmeet | Meeting started Fri Mar 4 14:03:31 2022 UTC and is due to finish in 60 minutes. The chair is lajoskatona. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:03 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:03 |
| opendevmeet | The meeting name has been set to 'neutron_drivers' | 14:03 |
| lajoskatona | Hi, | 14:03 |
| ralonsoh | hi | 14:03 |
| mlavalle | o/ | 14:03 |
| trident | Hi | 14:03 |
| amotoki | hi | 14:04 |
| obondarev | hi | 14:04 |
| gibi | o/ | 14:04 |
| lajoskatona | ok, let's start | 14:05 |
| lajoskatona | we have one topic left from last week: | 14:05 |
| lajoskatona | Gratuitous ARPs are not sent during master transition: (#link https://bugs.launchpad.net/neutron/+bug/1952907): | 14:05 |
| lajoskatona | the link again without extra chars: #link https://bugs.launchpad.net/neutron/+bug/1952907 | 14:05 |
| ralonsoh | I'll start, if you don't mind | 14:06 |
| ralonsoh | I took a look at proposal 1, https://github.com/acassen/keepalived/commit/b10bbfc2a2b216487cea5a586c55765275e41253 | 14:06 |
| ralonsoh | since keepalived 2.0.19, this is solved in the service itself | 14:07 |
| lajoskatona | thanks | 14:07 |
| ralonsoh | I would like to confirm that this was the initial problem to implement https://review.opendev.org/c/openstack/neutron/+/707406 | 14:07 |
| trident | Damian is unfortunately on vacation. I'll try to cover it from our side. | 14:07 |
| lajoskatona | this is for this patch: https://review.opendev.org/c/openstack/neutron/+/712474 | 14:07 |
| lajoskatona | trident: thanks, I was looking for Damian to ping him | 14:08 |
| trident | The more I have looked into it the more I am wondering if we can either revert (if we are okay to require keepalived > 2.0.19) or re-work https://review.opendev.org/c/openstack/neutron/+/707406 ... | 14:09 |
| obondarev | are there any issues with keepalived upgrade? | 14:10 |
| trident | To be honest for more reasons than only this issue. Mainly for mixing neutron into the process of failing over. Before neutron agents did actually not have to be at a fully working condition to in fact perform a successful fail over as everything was up, plugged and ready to roll as soon as the VRRP failed over. | 14:10 |
| opendevreview | yatin proposed openstack/neutron master: [DNM] Check ovn ovs experimental https://review.opendev.org/c/openstack/neutron/+/831220 | 14:11 |
| ralonsoh | I think obondarev was asking if using a keepalived newer version is a problem for the L3 agent | 14:12 |
| mlavalle | newer meaning 2.0.19, right? | 14:13 |
| ralonsoh | yes | 14:13 |
| lajoskatona | exactly | 14:13 |
| ralonsoh | btw, this is the version used now in our CI with ubuntu 20.04 | 14:14 |
| ralonsoh | 2022-03-03 17:38:20.185329 | controller | Unpacking keepalived (1:2.0.19-2ubuntu0.2) ... | 14:14 |
| trident | Yeah, 2.0.19 comes with Ubuntu 20.04 and we have run it pretty extensively and had no issues related to that version. | 14:15 |
| trident | So, from that point of view I think it would be okay to revert https://review.opendev.org/c/openstack/neutron/+/707406 | 14:16 |
| mlavalle | trident: "run it pretty extensively" after reverting the changes in https://review.opendev.org/c/openstack/neutron/+/707406? | 14:16 |
| ralonsoh | if that is the case and in sake in simplicity, I would revert the change ^^ AND add a upgrade check with a warning | 14:16 |
| mlavalle | in other words, do you know that after reverting it works fine with keepalived 2.0.19? | 14:17 |
| ralonsoh | that should be tested manually I think | 14:17 |
| trident | No, from the general point of view that 2.0.19 works fine with l3 agents. | 14:17 |
| lajoskatona | ralonsoh: but that patch is in Neutrons since ussuri, so I suppose we can't backport the revert till that | 14:17 |
| ralonsoh | lajoskatona, no no | 14:17 |
| mlavalle | trident: thanks for the clarification | 14:17 |
| ralonsoh | revert in master only | 14:17 |
| lajoskatona | ralonsoh: +1 | 14:17 |
| ralonsoh | and I would ask slaweq, who created the initial bug, steps to reproduce it manually | 14:18 |
| trident | The issue https://bugs.launchpad.net/neutron/+bug/1859832 that called for https://review.opendev.org/c/openstack/neutron/+/707406 has been a bit hard to verify that it is gone in 2.0.19 as it's pretty intermittent. So far I have not been able to re-produce that issue with the patch reverted, but that has been in small test environments. | 14:19 |
| ralonsoh | trident, yes but at least we can try it manually with different versions of keepalived | 14:19 |
| *** dasm|off is now known as dasm | 14:20 | |
| lajoskatona | trident: I can help with the upgrade check if you need assistance | 14:20 |
| trident | Could probably put more time into it and force the IPv6 address flush to happen after the proper local_vlan_id is set for the port to really test it. | 14:21 |
| trident | lajoskatona: That would be apreciated! | 14:21 |
| mlavalle | so are we saying asking trident to do some more testing for the team? | 14:21 |
| trident | Yeah, if we decide on a prefered path forward, we can put some time into testing that path out a bit and look into what's needed to get tha actual fix out. | 14:23 |
| lajoskatona | trident: thanks, by fix you mean the revert and using keepalived 2.0.19? | 14:24 |
| trident | Yes. | 14:24 |
| lajoskatona | trident: I eman revert of https://review.opendev.org/c/openstack/neutron/+/707406 | 14:24 |
| lajoskatona | trident: ok | 14:24 |
| mlavalle | so we revisit this next week? would that be enough time for you trident? | 14:25 |
| trident | mlavalle: Sounds good! | 14:26 |
| mlavalle | Thanks! | 14:26 |
| lajoskatona | ok, than I think we agree on the way forward, and based on the results we check the next steps, is that ok | 14:26 |
| lajoskatona | ? | 14:26 |
| mlavalle | +1 | 14:26 |
| obondarev | + | 14:26 |
| ralonsoh | +1 | 14:26 |
| trident | +1 | 14:27 |
| amotoki | +1 | 14:27 |
| lajoskatona | +1 | 14:27 |
| lajoskatona | Ok, thanks | 14:27 |
| mlavalle | thank you trident for helping with this | 14:27 |
| trident | Thanks! | 14:27 |
| mlavalle | much appreciated | 14:27 |
| lajoskatona | exactly, thanks for working on this and bringing it here | 14:27 |
| lajoskatona | ok, next topic | 14:27 |
| *** iurygregory_ is now known as iurygregory | 14:28 | |
| lajoskatona | #topic On Demand Agenda | 14:28 |
| lajoskatona | (ralonsoh): https://bugs.launchpad.net/neutron/+bug/1962465. I want to discuss the scope of this bug and the possible fix. | 14:28 |
| ralonsoh | thanks | 14:28 |
| ralonsoh | patch: https://review.opendev.org/c/openstack/neutron/+/819147 | 14:28 |
| ralonsoh | the point here is that now we allow to have, in a single node, two external networks with overlaping CIDRs | 14:29 |
| ralonsoh | or the same CIDR, for example | 14:29 |
| lajoskatona | The comments were mostly realted to the question if it can happen real env that 2 public nets has the same or overlapping subnet range | 14:29 |
| ralonsoh | right | 14:29 |
| lajoskatona | ralonsoh: thanks exactly | 14:29 |
| ralonsoh | nothing should happen, having external networks doesn't imply those networks are connected to, for example, internet | 14:30 |
| ralonsoh | "external" doesn't mean "internet connection" | 14:30 |
| ralonsoh | external means to be connected to an upper network, outside openstack | 14:30 |
| opendevreview | Balazs Gibizer proposed openstack/neutron master: Show port MAC from binding profile for PFs https://review.opendev.org/c/openstack/neutron/+/829247 | 14:30 |
| obondarev | could we name that just provider networks? | 14:31 |
| ralonsoh | perfect, provider networks | 14:31 |
| mlavalle | lol | 14:31 |
| ralonsoh | sorry, the patch is https://review.opendev.org/c/openstack/neutron/+/831238 | 14:32 |
| ralonsoh | my bad | 14:32 |
| ralonsoh | if, in a future, we want to limit this, that's perfect | 14:32 |
| ralonsoh | now it is not limited | 14:32 |
| ralonsoh | and this patch will work now and in this possible future | 14:32 |
| ralonsoh | (and, IMO, we should not force this artificial limitation) | 14:33 |
| obondarev | +1 the fix does not seem so complex to limit the use case | 14:33 |
| ralonsoh | right | 14:33 |
| mlavalle | I'm ok with ralonsoh's proposal | 14:34 |
| lajoskatona | yes, we can even document it somewhere to be clear | 14:35 |
| ralonsoh | I'll add a reno and documentation | 14:35 |
| mlavalle | no need to impose artificial limits when we don't know who might be taking advantage of the current freedom :-) | 14:35 |
| lajoskatona | ralonsoh: thanks | 14:35 |
| ralonsoh | thank you all | 14:36 |
| mlavalle | amotoki: you good with this? | 14:36 |
| amotoki | i am fine with this | 14:37 |
| mlavalle | :-) | 14:37 |
| lajoskatona | liuyulong has comments on the patch, but He is not here today | 14:37 |
| lajoskatona | I am ok with this, so +1 | 14:37 |
| mlavalle | first rule in a fight is to shoup up | 14:37 |
| mlavalle | show up | 14:37 |
| mlavalle | if you don't, you loose for sure | 14:37 |
| lajoskatona | mlavalle: true | 14:38 |
| lajoskatona | ok, if no more comments, ralonsoh can continue the patch, and we can vote on it in the review | 14:39 |
| mlavalle | +1 | 14:39 |
| ralonsoh | thanks | 14:39 |
| lajoskatona | Next topic: | 14:39 |
| lajoskatona | (mlavalle): Should we backport this: https://review.opendev.org/q/c9242f9a889f4d69653de4d21bec6060f549ee7b | 14:40 |
| mlavalle | saw a comment in one of the patches asking whether we should backport this | 14:40 |
| mlavalle | so decided to bring it up to the team | 14:40 |
| ralonsoh | I don't think so: that changes the policies of stable projects. Those changes should be done only in master, adding release notes and documentation | 14:41 |
| ralonsoh | in other words: bumping a minor version should imply a policy file change (if there is no an explicit bug) | 14:42 |
| ralonsoh | should not* | 14:42 |
| lajoskatona | ralonsoh: agree, this is an API change even if it is not explicit like an extension | 14:42 |
| mlavalle | so we are saying that changing policy is akin to an outright api change | 14:43 |
| amotoki | does it change the default and existing behavior? If not, it just bringes more granular polices to operators. | 14:44 |
| amotoki | I think API change usually means behaviro changes for valid authorized users. | 14:44 |
| ralonsoh | RBAC for quotas was something that existed in older releases | 14:45 |
| ralonsoh | but wasn't used | 14:45 |
| ralonsoh | if you created, by mistake, a RBAC register before this change, the behaviour will change too | 14:46 |
| ralonsoh | (if I'm not wrong) | 14:46 |
| amotoki | ah, that's the only case I think. it happens someone created such rules while they are not used. | 14:48 |
| mlavalle | but if it was done by mistake, should we honor it? | 14:49 |
| ralonsoh | mistake or not, the user is responsible | 14:49 |
| ralonsoh | so if we backport this change, the policy behaviour will change only by user decissions/operations | 14:50 |
| ralonsoh | if we accept this, then we can backport it | 14:50 |
| mlavalle | I think it makes sense | 14:51 |
| ralonsoh | (I would add a reno in the backports, please) | 14:51 |
| mlavalle | yeap | 14:51 |
| mlavalle | document it in case someone made that 'mistake' | 14:51 |
| ralonsoh | right | 14:51 |
| lajoskatona | it was in the original patch anyway | 14:51 |
| mlavalle | yes, there is a reno there | 14:52 |
| ralonsoh | perfect then | 14:52 |
| lajoskatona | Ok, than with documentation we agree to backport his change to ussuri and train | 14:52 |
| ralonsoh | +1 | 14:52 |
| lajoskatona | +1 | 14:52 |
| mlavalle | +1 | 14:52 |
| amotoki | +1 | 14:53 |
| obondarev | +1 | 14:53 |
| lajoskatona | Thanks | 14:53 |
| mlavalle | thanks for the time :-) | 14:53 |
| lajoskatona | We have few minutes gibi, ralonsoh do you think it is enough for https://review.opendev.org/c/openstack/neutron/+/829247 ? | 14:53 |
| amotoki | reagrding "RBAC for quotas was something that existed in older releases", I looked through git logs and we never had a policy named "get_quota" before the commit backported. | 14:53 |
| gibi | lajoskatona: let's try :)\ | 14:53 |
| ralonsoh | amotoki, not in the policies but in the API, we were able to create RBACs for quotas | 14:54 |
| ralonsoh | gibi, lets go | 14:54 |
| lajoskatona | ok, thanks | 14:54 |
| * mlavalle has a meeting in 5 minutes, might have to drop out if we go over time | 14:55 | |
| gibi | so we are talking about https://review.opendev.org/c/openstack/neutron/+/829247/3#message-42662fa9f1788ef4031c756abb9ee12ecc4761c7 | 14:55 |
| gibi | it was discussed before | 14:55 |
| gibi | it is about to allow mac_address to be added to the binding:profile | 14:55 |
| gibi | for direct-physical ports | 14:55 |
| gibi | and to change neturon to show the MAC from the binding:profile for the direct-physical ports | 14:55 |
| gibi | so the port.mac_address will show the MAC from the active binding:profile if any | 14:56 |
| ralonsoh | the API (get/list ports) will should the binding:profile:mac (if exists), instead of port.mac | 14:56 |
| gibi | yes | 14:56 |
| ralonsoh | will show* | 14:56 |
| gibi | but neutron will not overwrite the DB cell behind port.mac_address | 14:57 |
| gibi | with the value from the binding:profile | 14:57 |
| ralonsoh | I think this is a good solution for this problem (and, btw, maybe we'll find new cases for this with HW offload and smart NICs) | 14:58 |
| mlavalle | are we concerned about the discrepancy? | 14:58 |
| gibi | I have limited neutron knowledge so I'm not :) | 14:58 |
| mlavalle | lol | 14:58 |
| mlavalle | the bliss of ignorance | 14:59 |
| gibi | yepp | 14:59 |
| ralonsoh | the user (Nova in this case) who binds the port is reponsible of the port binding info | 14:59 |
| gibi | yes | 14:59 |
| mlavalle | ralonsoh: that's my opinion | 14:59 |
| obondarev | maybe should consider support that in Port OVO | 14:59 |
| ralonsoh | and MAC address is tightly related to the port binding: some NICs cannot change it | 14:59 |
| amotoki | If other codes in neutron refers mac_address of ports, it may affect but perhaps it can be handled in the port object | 15:00 |
| ralonsoh | obondarev, correct! | 15:00 |
| ralonsoh | amotoki, right | 15:00 |
| gibi | obondarev, ralonsoh: if you give me some pointers where to make the OVO change then I'm happy to do that in the current patch | 15:00 |
| ralonsoh | gibi, I'll help on this | 15:00 |
| gibi | cool | 15:00 |
| gibi | btw is somebody is interested here is the nova side populating the bindig:profile https://review.opendev.org/c/openstack/nova/+/829248 | 15:01 |
| lajoskatona | so am I right that the db will not change just mirror the mac from binding:profile to OVO? | 15:01 |
| ralonsoh | yes | 15:01 |
| obondarev | + | 15:02 |
| gibi | fine by me | 15:02 |
| lajoskatona | ok, +1 | 15:02 |
| ralonsoh | (with the active binding) | 15:02 |
| ralonsoh | +1 | 15:02 |
| mlavalle | +1 | 15:02 |
| amotoki | seems voting | 15:02 |
| amotoki | +1 | 15:02 |
| lajoskatona | amotoki: thanks :-) | 15:02 |
| lajoskatona | ok, so with this we finished all the topics for today | 15:03 |
| gibi | I plugged a -W to the neutron patch | 15:03 |
| ralonsoh | busy Friday! | 15:03 |
| gibi | :) | 15:03 |
| lajoskatona | Thanks everybody | 15:03 |
| gibi | thanks! | 15:03 |
| lajoskatona | Bye | 15:03 |
| obondarev | o/ | 15:03 |
| ralonsoh | have a nice weekend | 15:03 |
| amotoki | o/ | 15:03 |
| gibi | o/ | 15:03 |
| lajoskatona | #endmeeting | 15:03 |
| opendevmeet | Meeting ended Fri Mar 4 15:03:26 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:03 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-03-04-14.03.html | 15:03 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-03-04-14.03.txt | 15:03 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-03-04-14.03.log.html | 15:03 |
| lajoskatona | Have a nice weekend | 15:03 |
| mlavalle | bcafarel: these are the backports I was telling you about. please take a look when you have a bit of time: https://review.opendev.org/q/c9242f9a889f4d69653de4d21bec6060f549ee7b | 15:34 |
| bcafarel | mlavalle: ack will look before weekend :) | 15:42 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [SR-IOV] Fix QoS extension to set min/max values https://review.opendev.org/c/openstack/neutron/+/831830 | 16:52 |
| opendevreview | Takashi Natsume proposed openstack/os-vif master: Change minversion of tox to 3.18.0 https://review.opendev.org/c/openstack/os-vif/+/791970 | 17:04 |
| opendevreview | Merged openstack/neutron stable/ussuri: Allow RBAC on Neutron quotas https://review.opendev.org/c/openstack/neutron/+/828564 | 18:26 |
| opendevreview | Brian Haley proposed openstack/neutron master: DNM: Test IPv6 all (including tunnel) job definition https://review.opendev.org/c/openstack/neutron/+/828634 | 19:28 |
| *** dasm is now known as dasm|off | 22:07 | |
| *** marlinc is now known as Guest1321 | 23:57 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!