Friday, 2022-07-22

opendevreviewLajos Katona proposed openstack/neutron master: Test: mock out _check_netfilter_for_bridges in unit tests  https://review.opendev.org/c/openstack/neutron/+/85067005:57
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: db: add segment_index to the unique constraint  https://review.opendev.org/c/openstack/neutron/+/84145906:08
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: segment: enable multisegments support for host  https://review.opendev.org/c/openstack/neutron/+/84183806:08
*** amoralej|off is now known as amoralej06:17
opendevreviewRodolfo Alonso proposed openstack/os-ken master: [DNM][Testing]  Remove "nose" library  https://review.opendev.org/c/openstack/os-ken/+/85063107:06
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/yoga: Ensure members without subnet belong to VIP subnet or fail  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85055607:27
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/xena: Ensure members without subnet belong to VIP subnet or fail  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85055707:27
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/wallaby: Ensure members without subnet belong to VIP subnet or fail  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85055807:28
opendevreviewRodolfo Alonso proposed openstack/os-ken master: [DNM][Testing]  Remove "nose" library  https://review.opendev.org/c/openstack/os-ken/+/85063107:50
opendevreviewFernando Royo proposed openstack/neutron stable/train: Optimize queries for port operations  https://review.opendev.org/c/openstack/neutron/+/85073509:05
opendevreviewFernando Royo proposed openstack/networking-ovn stable/train: Optimize queries for port operations  https://review.opendev.org/c/openstack/networking-ovn/+/85073809:18
opendevreviewRodolfo Alonso proposed openstack/os-ken master: [DNM][Testing]  Remove "nose" library  https://review.opendev.org/c/openstack/os-ken/+/85063109:59
opendevreviewRodolfo Alonso proposed openstack/os-ken master: Remove "nose" library  https://review.opendev.org/c/openstack/os-ken/+/85063111:25
ralonsohlajoskatona, slaweq ^^11:26
ralonsohplease, don't be scared about the number of changed lines11:26
ralonsohI've just converted "nose" tests to "unittest"11:26
lajoskatonaralonsoh: I saw that yesterday, thanks for taking care11:30
lajoskatonaralonsoh: do we have other projects with nose dependency?11:30
ralonsohlajoskatona, I'll check it11:30
ralonsohlajoskatona, so far, only https://opendev.org/openstack/monasca-agent11:32
slaweqralonsoh: sorry but I'm off today and as I saw, this is big patch so I can review it on Monday 🙂11:34
slaweqis it urgent?11:34
ralonsohslaweq, not urgent at all11:35
ralonsohenjoy!!11:35
slaweqOk. Thx11:35
*** amoralej is now known as amoralej|lunch12:20
*** amoralej|lunch is now known as amoralej13:07
opendevreviewRodolfo Alonso proposed openstack/neutron master: Add a default table in "ip rule" command  https://review.opendev.org/c/openstack/neutron/+/85022313:12
spatelFolks looking for ovn-bgp-agent related help - https://paste.opendev.org/show/b0jSgXWlkkkws8Wp18Xz/13:20
ralonsohspatel, commands should be split in words13:22
ralonsohin this case, the last section has three13:22
ralonsohvtysh_command = "copy {} running-config".format(frr_config_file)13:22
ralonsohthis should be a list added at the end of full_args13:23
spatelralonsoh sorry i am not following you.. :(13:23
ralonsohhttps://opendev.org/x/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/privileged/vtysh.py#L26-L2813:23
ralonsohone sec13:23
spatelok13:24
ralonsohspatel, 13:25
ralonsoh    vtysh_command = "copy {} running-config".format(frr_config_file)13:25
ralonsoh    full_args = ['/usr/bin/vtysh', '--vty_socket', constants.FRR_SOCKET_PATH, c']13:25
ralonsoh    full_args.extend(vtysh_command.split(' ')13:25
spatelso its bug in code?13:26
ralonsohspatel, maybe, I can't check it13:26
ralonsohif you can, that could be great13:27
spatellet me modify that code and try hold on13:27
ralonsohperfect13:27
spatelralonsoh is this looks good to you ? - https://paste.opendev.org/show/bJjEkndreE76IW69HPGx/13:32
spatelsome quotation issue look like.. around 'c' i believe13:32
spatelsorry i am not python expert so trying to figure out 13:33
ralonsohspatel, in line 513:36
ralonsohis missing a parenthesis 13:36
ralonsohfull_args.extend(vtysh_command.split(' '))13:36
ralonsohthe last one13:36
spatelralonsoh little progress now i got this error - https://paste.opendev.org/show/b0cxtqR53LvUFaAGLCrV/13:38
ralonsohspatel, you didn't configure properly the DB connection13:38
spatel'/usr/local/var/run/openvswitch/db.sock': No such file or directory13:39
spatelcorrect path is - /var/run/openvswitch/db.sock13:39
spatelhow do i tell ovn-bgp-agent to look at alternative path?13:40
spatellet me create symlink and quickly test it out13:41
ralonsohno, this is not the solution13:41
ralonsohyou need to configure the DB access13:42
spatelhmm! but ovn-bgp-agent looking at wrong place.. 13:42
ralonsohwhat is the connection string?13:43
ralonsohwhy don't you use the tcp port?13:43
ralonsohe.g.: tcp:<ip_address>:664213:43
spatelThis is what i am trying to setup in my LAB, following this blog - https://ltomasbo.wordpress.com/2021/02/04/ovn-bgp-agent-testing-setup/13:44
spatelI have setup openstack using devstack 13:44
spatelI didn't customize anything, this is all coming from default devstack deployment13:44
ralonsohspatel, can you check that is the value of "ovsdb_connection"?13:45
ralonsohin the config13:45
spatelin which config file? 13:45
ralonsohboth neutron.conf and the ovn agent config file13:47
ralonsoh(I don't know what is the name of the second)13:47
ralonsohby default, Neutron and ovn bgp agent use different values13:47
ralonsohbgp agent13:47
ralonsoh    cfg.StrOpt('ovsdb_connection',13:47
ralonsoh               default='unix:/usr/local/var/run/openvswitch/db.sock',13:47
ralonsoh               help='The connection string for the native OVSDB backend.\n'13:47
ralonsoh                    'Use tcp:IP:PORT for TCP connection.\n'13:47
ralonsoh                    'Use unix:FILE for unix domain socket connection.'),13:47
ralonsohneutron13:47
ralonsoh    cfg.StrOpt('ovsdb_connection',13:47
ralonsoh               default='tcp:127.0.0.1:6640',13:47
ralonsoh               help=_('The connection string for the OVSDB backend. '13:47
ralonsoh                      'Will be used for all ovsdb commands and '13:47
ralonsoh                      'by ovsdb-client when monitoring'13:47
ralonsoh                      )),13:47
ralonsohso that's a problem13:47
ralonsoh(if you don't explicitly define the values)13:48
lajoskatonaluis5tb, ltomasbo: ----^13:49
spatelralonsoh check this out - https://paste.opendev.org/show/befLSdcOwTzLbNV6Q8ZD/13:50
spatelThis is what i have in compute node 13:50
ralonsohso ovsdb_connection is not defined13:51
ralonsohthat means each project will use a different value13:51
ralonsohby default, when using devstack, neutron's value will work13:51
spatelwhere i should define that?13:51
ralonsohwhat is the config file the bgp agent is using?13:51
ralonsohis it a different service?13:51
ralonsohI mean13:52
spatelI didn't create any config for bgp-agent.. just using default 13:52
ralonsohis a different binary apart from the neutron API?13:52
ralonsoh(my first time with this)13:52
spatelyes ovn-bgp-agent is different binary 13:52
ralonsohperfect13:52
ralonsohso, what config file is using?13:53
ralonsohsystemctl | grep devstack13:53
ralonsohfind the bgp agent13:53
ralonsohand then systemctl status <agent>13:53
spatelhttps://paste.opendev.org/show/bXO9Vfkosg63wzIRmp4y/13:53
ralonsohso where is the bgp agent?13:54
spatelbgp-agent isn't daemon.. just single executable python command 13:54
ralonsohok13:54
ralonsohwhat config file uses?13:54
spatel$ sudo ovn-bgp-agent  - command to run daemon but its not able to find ovsdb..  when you run that command it use default option if there is no custom parameters defined. 13:55
*** obondarev_ is now known as obondarev13:55
spatellet me create foo.conf and add ovsdb connection path13:55
spatelralonsoh look like encounter new error after creating config file and point to corrected path - https://paste.opendev.org/show/bYxy4cBWygOQ21JgEJZb/13:59
ralonsohspatel, what version are you using?14:00
lajoskatona#startmeeting neutron_drivers14:00
opendevmeetMeeting started Fri Jul 22 14:00:23 2022 UTC and is due to finish in 60 minutes.  The chair is lajoskatona. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'neutron_drivers'14:00
mlavalleo/14:00
lajoskatonaHi14:00
obondarevhi14:00
ralonsohhello14:00
lajoskatonaLet's see if we have enough drivers14:00
yamamotohi14:00
spatelralonsoh I am running frr 7.2.1 and ovn-bgp-agent checkout from latest clone, openstack is latest master from devstack openvswitch-switch  version 2.13.5 14:02
lajoskatonaok, let's start14:02
ralonsohspatel, let's talk after the meeting14:02
spatelsure!14:02
lajoskatonaralonsoh, spatel: thanks14:02
lajoskatonaWe have one RFE for today:14:02
amotokihi14:02
lajoskatona[rfe][ovn] Support address group for ovn driver (#link [rfe][ovn] Support address group for ovn driver )14:02
lajoskatonasorry wrong link: https://bugs.launchpad.net/neutron/+bug/198228714:03
mlavallehow is this different to address groups?14:04
lajoskatonaIf I understand well the OVN side of this feature is already there, just the ml2_ovn part is missing14:04
mlavalleor is it the same concept just directly supported by ovn14:05
mlavalle?14:05
lajoskatonamlavalle: yes as I see the same feature but with OVN14:05
ralonsohit is the same, just missing the implementation in OVN14:05
amotokiralonsoh: more precisely, missing in ML2/OVN?14:05
ralonsohexactly, core OVN supports that14:06
obondarevseems pretty obvious to approve then :)14:06
mlavalleyeap14:06
lajoskatonaobondarev: +114:06
mlavallebrings parity to ml2 / ovn14:06
mlavalleto me, it is a no brainer14:06
obondarevonly question from me if it's needs a spec or not14:07
mlavalleyeah, let's ask a spec, specifically explaining how this play with the current address groups implementation14:07
amotokiI don't think so. a spec is not necessarily required and this looks straight-forward14:08
obondarevif the API/interface is same that neutron already has - then probably no spec is needed14:08
ralonsohI don't think there will be any API/DB change14:08
mlavalleyeap, that was my concern14:08
ralonsohso spec maybe won't be necessary 14:08
mlavalleit is is going to stick to the current API and DB, the no spec is needed14:08
mlavalleif it ^^^14:08
lajoskatonaagree, if it is just to adopt ovn driver to create address sets based on the API req of address groups, I see no need for spec14:09
mlavallebut let's indicate that when we approve the RFE14:09
mlavalleexplicitely14:09
mlavalleso expectations are clear14:09
amotoki+114:09
obondarev+114:10
ralonsoh+114:10
lajoskatonaOk, so I add comment to the RFE that if the same API and db can be used the RFE can go without spec, otherwise let's request one14:10
yamamoto+114:10
haleyb+114:10
obondarevif only all RFEs be so nice!14:10
lajoskatonaok, it was quick :-)14:10
ralonsohhehehe14:10
atimminsCould we also please have an update on https://bugs.launchpad.net/neutron/+bug/1979816 before we close today?14:10
ralonsohatimmins, let's finish the previous topic14:11
*** dasm|off is now known as dasm14:12
lajoskatonaI think we accepted the RFE with the condition that it is "only" an OVN driver14:12
ralonsohperfect14:12
lajoskatona#topic On Demand Agenda14:12
lajoskatonaatimmins: you refer to your last comment on the RFE pointing to the etherpad: https://etherpad.opendev.org/p/fwaas-api-evolution-spec#L244 ?14:13
atimminsYes14:13
lajoskatonaatimmins: if this strata concept covers your issue with fw goup ordering, isn't that good to create a spec based on this in the etherpad?14:15
luis5tbspatel, sorry I missed this... note the blogpost is a bit old, and there has been quite some changes14:16
luis5tbspatel, there is a WIP patch for devstack support https://review.opendev.org/c/x/ovn-bgp-agent/+/81418514:16
luis5tbperhaps yo ucan take some ideas about how you shoul configure theee agent for devstack14:16
spatelluis5tb working with ralonsoh and made some progress but stuck here https://paste.opendev.org/show/bYxy4cBWygOQ21JgEJZb/14:16
atimminsPerhaps I am just unaware of the process for creating a spec - is that something I should do myself, and if so, is there documented guidance for doing so?14:17
mlavalleatimmins: this is the neutron specs repo: https://opendev.org/openstack/neutron-specs14:17
ralonsohatimmins, you need to propose something like this14:18
ralonsohhttps://github.com/openstack/neutron-specs/blob/master/specs/yoga/distributed-metadata-data-path.rst14:18
lajoskatonaexactly14:18
ralonsohin any case, what is in the etherpad is different from group ordering14:18
mlavalleatimmins: please note there is a directory for the zed cycle: https://opendev.org/openstack/neutron-specs/src/branch/master/specs/zed14:18
ralonsohyou are introducing priority levels (but we can discuss this in the spec)14:18
mlavalleyes, the spec would be a good place to discuss that14:19
ralonsohand, btw, in the previous meeting we talked about the current behaviour14:19
ralonsohthat doesn't match the current spec (allow by default)14:19
mlavalleatimmins: please also note that in that zed directory there is a placeholder.rst file that you can use as a template14:20
atimminsThis is all very helpful, thanks! I'll work on putting a spec together in the zed directory.14:20
mlavallewhen you have you first version of the spec, just submmit is to gerrit with git review, like any other patch in the OpenStack project14:20
atimminsWill do14:21
mlavalleatimmins: and we will have a discussion over gerrit, just like any other piece of code14:21
lajoskatonaatimmins: before pushing you can build it with tox -edocs I think, and can check in browser14:21
lajoskatonaI have another quick sentence for today: 14:22
lajoskatonaI started the Antelope etherpad: https://etherpad.opendev.org/p/neutron-antelope-ptg14:22
mlavallecool!14:22
lajoskatonaand the next release will be Antelope :-)14:22
mlavalleso bad for anteater14:23
lajoskatonaI think antelope is much better for marketing people :-)14:23
lajoskatonaIf there is no more topics to discuss, let's close the meeting14:24
haleybthe anteater would have gotten all the bugz :)14:24
lajoskatonahaleyb: that was my reasoning also :-)14:24
haleybbut there are no bugs left, coffee must be working if i'm talking14:25
lajoskatona:-)14:25
lajoskatona#endmeeting14:25
opendevmeetMeeting ended Fri Jul 22 14:25:41 2022 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:25
opendevmeetMinutes:        https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-07-22-14.00.html14:25
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-07-22-14.00.txt14:25
opendevmeetLog:            https://meetings.opendev.org/meetings/neutron_drivers/2022/neutron_drivers.2022-07-22-14.00.log.html14:25
lajoskatonaHave a nice weekend :-)14:25
ralonsohhave a nice weekend14:25
lajoskatonao/14:25
amotokio/14:25
yamamotogood night14:25
obondarevo/14:26
mlavalleo/14:26
haleybo/14:27
spatelralonsoh i believe meeting is over :)14:35
ralonsohyes14:36
spatelbased on last output error encounter here - https://opendev.org/x/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/drivers/openstack/ovn_bgp_driver.py#L9114:36
spatellook at latest error code - https://paste.opendev.org/show/bYxy4cBWygOQ21JgEJZb/14:37
ralonsohspatel, and in L9714:37
ralonsohthis is because I don't know if you are accessing correctly to the SB DB14:37
spatelmy ovn version is 20.03.1 whatever comes with Ubuntu 20.04.4 14:37
ralonsohso doesn't have chassis_private14:37
ralonsohin any case, L97 should work14:37
ralonsohcan you print what you have in "schema.tables" ?14:38
spatelwhat is Chassi_Private? 14:38
spatelDo you know command to print schema.tables?14:38
ralonsoha SB DB table14:38
ralonsohyes, print this value14:38
spatel ovn-sbctl show ?14:39
ralonsohno, the value in L9314:39
ralonsohbefore instantiating ovn.OvnSbIdl14:40
spatelralonsoh how do i print schema.tables ?14:41
ralonsohyou can log it14:42
ralonsohLOG.debug(schema.tables)14:42
spatelsorry i am not very familiar with ovs/ovn commands so trying to google 14:44
ralonsohspatel, this is in the code14:44
spatelyou want me to put it in that file and run ovn-bgp-agent so it will print table 14:46
ralonsohyes14:46
spatellet me try 14:46
opendevreviewRodolfo Alonso proposed openstack/os-ken master: Remove "nose" library  https://review.opendev.org/c/openstack/os-ken/+/85063114:51
spatelralonsoh https://paste.opendev.org/show/bWAXQpKMLAFJyXic2UkQ/14:52
spatelralonsoh talking to lucasagomes and he suggested to remove Load_Balancer table from here and look like it made little progress but now dealing other next error - https://opendev.org/x/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/drivers/openstack/ovn_bgp_driver.py#L4015:01
lucasagomesralonsoh, I think it's due to the version of OVN that does not have that table in the schmea15:02
lucasagomes<spatel> ovn-sbctl: unknown table "Load_Balancer"15:02
ralonsohthis is why I asked for the tables15:02
lucasagomesyup15:02
ralonsohI didn't see this error in any log15:02
lucasagomesthe other error seems strange, because it's actually going thru privsep15:03
lucasagomesand capabilities.CAP_NET_ADMIN is set by default15:03
ralonsohwhich one?15:03
lucasagomesralonsoh, https://paste.opendev.org/show/bHmQAT3a22jK602asI0S/15:03
lucasagomesthis one15:03
spatelThis is where i stuck now after removing LB table - https://paste.opendev.org/show/baUZQZ0LioGbMXEQVft0/15:03
ralonsohlucasagomes, pyroute NDB interface is deprecated15:04
ralonsohhttps://opendev.org/x/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/privileged/linux_net.py#L27215:04
ralonsohthis is not supported anymore15:05
ralonsohonly if you are using an old version of pyroute215:05
lucasagomesralonsoh, hmm lemme make a note of it, because we actually use it heavily in the agent15:05
spatelI have pyroute2   0.6.1315:05
ralonsohthis is old15:06
spatelhmm so you are suggesting to upgrade it?15:07
ralonsohno at all15:07
ralonsohyou can't do it with this implementation15:08
spatelok15:08
ralonsohcan you execute this command in the shell?15:08
spateltell me which one15:09
ralonsohadd this IP address to this inteface15:10
ralonsohusing "ip a add" commands15:10
ralonsohand python15:10
spatelralonsoh give me full command and what ip you want to add?15:11
ralonsohspatel, the one you are trying to add here https://paste.opendev.org/show/baUZQZ0LioGbMXEQVft0/15:12
ralonsohI have no idea what IP not interface15:12
ralonsohyou need to have this info from your env15:12
spatelbut i thought this is the agent and it will just run in background interact with frr.. i am also new so trying to understand.. 15:13
ralonsohyes, but the agent is failing in a specific operation15:14
ralonsohso let's try to find why15:15
ralonsohfind the IP and the device15:15
spatelThis is what agent does - https://ltomasbo.wordpress.com/2021/06/25/openstack-networking-with-evpn/15:15
ralonsohsorry, if you want remote debugging, you need to provide this information15:16
spatelLet me follow that blog and see what its doing which i can try by hand15:16
ralonsohprint the info before executing this command15:16
spatellet me run it in debug mode 15:17
opendevreviewRodolfo Alonso proposed openstack/os-ken master: Remove "nose" library  https://review.opendev.org/c/openstack/os-ken/+/85063115:24
*** rpioso_ is now known as rpioso15:27
*** johnsom_ is now known as johnsom15:27
*** amoralej is now known as amoralej|off15:38
opendevreviewRodolfo Alonso proposed openstack/os-ken master: Remove "six" library  https://review.opendev.org/c/openstack/os-ken/+/85076716:07
opendevreviewRodolfo Alonso proposed openstack/neutron stable/wallaby: functional: Add debug messages around OVN services  https://review.opendev.org/c/openstack/neutron/+/85003916:10
opendevreviewSharon Koech proposed openstack/neutron-lib master: Network Cascade Deletion Extension  https://review.opendev.org/c/openstack/neutron-lib/+/84904616:17
spatelGood news ovn-bgp-agent works :) Permission problem was IPv6 (I have disable ipv6 and error disappeared )17:04
opendevreviewSharon Koech proposed openstack/neutron master: Network Cascade Deletion Extension  https://review.opendev.org/c/openstack/neutron/+/84977619:06
*** dasm is now known as dasm|off22:11
opendevreviewMiguel Lavalle proposed openstack/neutron master: Avoid race condition when deleting trunk bridges  https://review.opendev.org/c/openstack/neutron/+/83778023:05

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!