Thursday, 2022-08-18

*** amoralej|off is now known as amoralej06:16
opendevreviewSlawek Kaplonski proposed openstack/os-ken master: Use py3 as the default runtime for tox  https://review.opendev.org/c/openstack/os-ken/+/85233406:48
opendevreviewLajos Katona proposed openstack/neutron master: Doc: New bug tags: pyroute2 and stable  https://review.opendev.org/c/openstack/neutron/+/85359907:33
fricklerlajoskatona: seems ralonsoh was waiting for your feedback on https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/851798 , could you have another look please?07:38
ralonsohlet me check07:38
*** dulek_ is now known as dulek07:39
lajoskatonafrickler: sure07:42
opendevreviewSlawek Kaplonski proposed openstack/neutron master: [OVN] Try to bind ports only to the ovn-controller agents  https://review.opendev.org/c/openstack/neutron/+/85347907:59
opendevreviewRodolfo Alonso proposed openstack/neutron master: Script to remove duplicated port bindings  https://review.opendev.org/c/openstack/neutron/+/84642208:13
opendevreviewMerged openstack/neutron master: Don't retrieve SG port bindings when deleting a SG  https://review.opendev.org/c/openstack/neutron/+/85272308:37
opendevreviewLajos Katona proposed openstack/neutron stable/stein: DNM: check stein branch fixes  https://review.opendev.org/c/openstack/neutron/+/85360809:18
opendevreviewMerged openstack/os-ken master: Use py3 as the default runtime for tox  https://review.opendev.org/c/openstack/os-ken/+/85233409:24
opendevreviewMerged openstack/neutron-dynamic-routing master: Don't run periodic actions for StaticScheduler  https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/85179809:28
opendevreviewrenliang proposed openstack/neutron stable/yoga: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85344509:41
opendevreviewrenliang proposed openstack/neutron stable/xena: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85344609:44
opendevreviewrenliang proposed openstack/neutron stable/wallaby: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85344709:44
opendevreviewrenliang proposed openstack/neutron stable/victoria: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85344809:44
opendevreviewrenliang proposed openstack/neutron stable/ussuri: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85344909:45
opendevreviewrenliang proposed openstack/neutron stable/train: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85363009:46
opendevreviewrenliang proposed openstack/neutron stable/rocky: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85363109:47
opendevreviewrenliang proposed openstack/neutron stable/queens: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85363209:47
opendevreviewLajos Katona proposed openstack/neutron stable/stein: DNM: check stein branch fixes  https://review.opendev.org/c/openstack/neutron/+/85360809:59
opendevreviewrenliang proposed openstack/neutron stable/stein: Mellanox_eth.img url expires, remove the mellanox_eth.img node  https://review.opendev.org/c/openstack/neutron/+/85363310:08
amorinralonsoh I am coming back on my port with device_id, I dont understand how you endup having a 409 from nova12:09
amorinhere is what I do:12:09
amorinopenstack port create --network public --device 09718173-3170-46b7-b313-e7adb7cc1046 p312:09
amorinand neutron accept this very nicely on my side12:10
opendevreviewLajos Katona proposed openstack/neutron stable/stein: DNM: check stein branch fixes  https://review.opendev.org/c/openstack/neutron/+/85360812:43
mlavalle1lucasagomes: I thought you might want to chime in here: https://review.opendev.org/c/openstack/neutron/+/83660813:04
lucasagomesmlavalle1, will take a look13:05
lucasagomesmlavalle1, I will comment on the patch13:07
lucasagomessorry I forgot about that revert13:08
mlavalle1lucasagomes: thanks!13:08
lucasagomesmlavalle1, added a comment. About 3 weeks ago dumitru (core OVN dev) refactored some parts of IGMP in core OVN and when I was testing it he explicitly said that mcast_flood should be set to False13:14
lucasagomesmlavalle1, that revert changes that. So I asked the author if he could test it again without the reverts using a new OVN13:15
lucasagomesmlavalle1, I left links and references in my comment. But for now I think we should hold that revert13:15
lucasagomesthe core OVN change btw: https://github.com/ovn-org/ovn/commit/6aeeccdf272bc60630581e46aa42d97f4f56d4fa13:15
mlavalle1lucasagomes: yeah, I was reviewing it yesterday and seeing at the history and one comment you left in the LP bug, I suspected you didn't want to merge the revert. That's why I wanted you to chime in13:16
mlavalle1Thanks!13:16
lucasagomesmlavalle1++ thanks for checking it before!13:16
amorinralonsoh out of curiosity, are you using ovs mech driver on your neutron deployment? Or maybe ovn? or something else?13:27
opendevreviewMerged openstack/neutron master: [OVN] Try to bind ports only to the ovn-controller agents  https://review.opendev.org/c/openstack/neutron/+/85347913:37
spatellucasagomes just to let you know after upgrade of OVN/OVS  fix bunch of errors and now i am able to advertise VM tenant ips in BGP 13:52
spatelcurrently i am stuck at here where VRF configuration not getting inject in FRR by this code - https://opendev.org/x/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/drivers/openstack/utils/frr.py#L3113:56
spatelwhat trigger this code to execute?13:56
ralonsohamorin, I'm using OVN14:21
ralonsohbut I can try with OVS14:22
amorinplease, thanks14:22
amorinI did try with my OVN and nova is not complaining neither, but I am not running the latest ovn so maybe that's why14:22
amorinor, maybe we have a different configuration14:23
opendevreviewSlawek Kaplonski proposed openstack/neutron stable/yoga: [OVN] Try to bind ports only to the ovn-controller agents  https://review.opendev.org/c/openstack/neutron/+/85363514:23
opendevreviewMerged openstack/neutron master: Use neutron-lib method is_session_active  https://review.opendev.org/c/openstack/neutron/+/85119214:39
opendevreviewRodolfo Alonso proposed openstack/neutron master: [OVN] Remove session check in ``update_network_postcommit``  https://review.opendev.org/c/openstack/neutron/+/85288514:42
ralonsohamorin, same behaviour with both backends14:53
ralonsohhttps://paste.opendev.org/show/b8RDqxL4BeSsuioJ1lOw/14:53
ralonsoh(this is from one of then, the other is the same)14:53
amorinok checking14:54
amorinhum14:55
amorinwhen you created your port20, you espacially created it with a device_id, right?14:56
amorinyou set fistro in your example14:56
ralonsohyes14:56
amorinmy issue is there, if you set a device_id to a real nova instance ID, neutron is accepting it, but neutron is not calling nova interface-attach14:57
ralonsohamorin, no, it doesn't work like this14:57
amorinwhy?14:57
amorinwhat is the purpose of leting the user setting the device_id?14:58
ralonsohbecause is Nova who sets this device_id once applied the needed config in the backend14:58
ralonsohand the port is bound to the VM14:58
ralonsohno idea, to be honest14:58
ralonsohbut doesn't work like this14:58
amorinthis is anyway problematic because, if you set a real device_id, and reboot hard the instance on nova side14:59
amorinthe port will be plugged14:59
ralonsohI've never tested that, I'll try it14:59
slaweqamorin: I think You can change API policies to allow changing device_id only for admin and nova user14:59
slaweqso others will not be able to do so15:00
amorinagree but then my openstack deployment would act diffently from upstream15:00
amorinand end users wont understand why15:00
amorinwe are asking ourself why device_id is modifiable by end users15:01
slaweqamorin: I guess it's because neutron ports can be used not only by nova15:05
slawequser can use neutron differently and create ports for some custom things15:05
ralonsohbtw, I've checked that and that's correct: nova retrieves the network info when rebooting and reads the manually assigned15:06
ralonsoh(I never tried this)15:06
amorinand if you do:15:06
amorinopenstack port list --server yourserverid15:06
amorinthe port will be visible15:06
amorinthe port will be listed15:06
amorinand will stay down until the reboot hard15:07
ralonsohyes15:07
amorinthis is affecting our customers, because some of them believe that creating a port with a device_id will actually plug the port to their instance15:07
amorinbut it's not15:07
ralonsohamorin, this is just a documentation issue, IMO15:08
amorintrue15:08
slaweqralonsoh: I agree15:08
amorinIMO this is also very confusing15:08
ralonsohI'll open a LP bug15:08
amorinthere is also a weird effect:15:09
amorinimagine 2 tenants:15:09
amorintenant1 with serverid115:09
amorintenant2 is creating a port:15:09
amorinopenstack port create --device serverid115:09
amorinneutron accept this15:09
*** dasm|off is now known as dasm15:09
amorinfrom tenant1, port is not visible (make sense, because it does belong to tenant2)15:10
amorinbut, from an admin:15:10
amorinopenstack port list --server serverid115:10
amorinwill list the port from tenant215:10
amorineven if serverid1 belongs to tenant115:10
amorinnova will never plug the port, because they are checking if the port belong to the tenant115:11
amorinbut this is very confusing for an administrator15:11
ralonsohthis could be a security bug if user1 can read user2 VM IDs15:11
ralonsoh(they can't)15:11
amorinthey can't15:11
amorinbut you know, some customers are sharing instance Id on public mailing list15:12
amorinso...15:12
ralonsohbut that shows a questionable design, in this case of the port.device_id15:12
ralonsohmaybe (just maybe), this value should be tested before assigned15:12
amorinyes, or writable only in admin context by default15:13
amorinmaybe through a conf param15:13
amorinso operator that use neutron out of nova can still do what they want15:13
ralonsohin any case, it is quite difficult to assign the VM ID of another project without knowing it15:16
amorinagree15:16
ralonsohhttps://bugs.launchpad.net/neutron/+bug/198696915:17
amorinthanks15:18
amorinactually, device_owner is not mandatory15:19
amorinalso, note that current openstack provider on terraform doc is here:15:20
amorinhttps://registry.terraform.io/providers/terraform-provider-openstack/openstack/latest/docs/resources/networking_port_v2#device_id15:20
amorin"The ID of the device attached to the port"15:20
amorinI know this is outside of the openstack scope, but maybe worth to be mentionned?15:21
ralonsohI'll add it, but this should be considered in this tool15:23
*** amoralej is now known as amoralej|off15:27
amorinthanks!15:29
opendevreviewMerged openstack/neutron stable/xena: [OVN] Fix updating network segmentation ID  https://review.opendev.org/c/openstack/neutron/+/85314815:51
opendevreviewFernando Royo proposed openstack/ovn-octavia-provider master: Fix healthMonitor events affecting to unrelated LB  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85368115:53
opendevreviewRodolfo Alonso proposed openstack/neutron master: [OVN] Remove session check in ``update_network_postcommit``  https://review.opendev.org/c/openstack/neutron/+/85288516:11
opendevreviewMerged openstack/neutron master: Doc: New bug tags: pyroute2 and stable  https://review.opendev.org/c/openstack/neutron/+/85359919:08
*** dasm is now known as dasm|off22:08

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!