Monday, 2022-10-03

opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider master: Ensure lbs are properly configured for router gateway set/unset  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85836307:11
opendevreviewMerged openstack/neutron master: Accept a port deletion with missing port binding information  https://review.opendev.org/c/openstack/neutron/+/85749007:34
opendevreviewArnau Verdaguer proposed openstack/neutron master: [ovn migration] Use ecsda ssh key instead of rsa  https://review.opendev.org/c/openstack/neutron/+/86000207:38
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider master: Ensure lbs are properly configured for router gateway set/unset  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85836308:03
ralonsohlajoskatona, hi, one question about https://review.opendev.org/c/openstack/releases/+/86001109:10
ralonsohin some projects, for example https://review.opendev.org/c/openstack/releases/+/860011/1/deliverables/zed/neutron-dynamic-routing.yaml09:11
ralonsohthe hash does not contain the .gitreviw patch for stable/zed09:11
ralonsohor the TOX_CONSTRAINTS_FILE update09:11
ralonsohbut that should not affect the projec09:11
ralonsohI mean, that's fine, right?09:11
opendevreviewLajos Katona proposed openstack/neutron master: Update grenade skip level jobs for new release  https://review.opendev.org/c/openstack/neutron/+/85999109:11
lajoskatonaralonsoh: good question, I check it09:12
bcafarelI'd say it is fine these are mostly for sending backports to correct branch and running ci properly - as release tarballs they are fine for end-user09:16
bcafarelbut I will be curious to hear if that is indeed the case09:16
ralonsohright, that was my feeling09:16
ralonsohI reviewed all neutron related projects and this is the only issue09:18
ralonsohthat in some of them, the hash is before the CI patches to push the zed branch09:18
ralonsohbut as bcafarel, the tarball should be fine for delivery09:18
ralonsohbut as bcafarel said *09:19
opendevreviewLajos Katona proposed openstack/neutron master: Update grenade skip level jobs for new release  https://review.opendev.org/c/openstack/neutron/+/85999109:22
elodilles.gitreview and TOX_CONSTRAINTS_FILE update patches are proposed usually with RC1 patches (as those are generated *after* the branch cut)09:30
elodillesthey does not worth a 2nd (or 3rd, etc) RCs09:30
elodillesso in general, they are not necessary for the final release09:31
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: dhcp: make device manager to clean only not used devices  https://review.opendev.org/c/openstack/neutron/+/84041909:31
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: dhcp: add/use cleanup stale devices API  https://review.opendev.org/c/openstack/neutron/+/84042009:31
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: dhcp: support multiple segmentations per network  https://review.opendev.org/c/openstack/neutron/+/84042109:31
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: db: add segment_index to the unique constraint  https://review.opendev.org/c/openstack/neutron/+/84145909:31
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: segment: enable multisegments support for host  https://review.opendev.org/c/openstack/neutron/+/84183809:31
lajoskatonaelodilles: thanks for clarification09:32
elodillesnp :)09:32
ralonsohelodilles, thanks!09:33
ralonsohlajoskatona, ok so I'll +1 this releases patch09:33
opendevreviewRodolfo Alonso proposed openstack/neutron stable/zed: Accept a port deletion with missing port binding information  https://review.opendev.org/c/openstack/neutron/+/86006909:40
opendevreviewRodolfo Alonso proposed openstack/neutron stable/yoga: Accept a port deletion with missing port binding information  https://review.opendev.org/c/openstack/neutron/+/86007109:44
opendevreviewRodolfo Alonso proposed openstack/neutron stable/xena: Accept a port deletion with missing port binding information  https://review.opendev.org/c/openstack/neutron/+/86007209:44
opendevreviewRodolfo Alonso proposed openstack/neutron stable/wallaby: Script to remove duplicated port bindings  https://review.opendev.org/c/openstack/neutron/+/85999809:48
opendevreviewkiran pawar proposed openstack/neutron-lib master: Use oslo_context.from_dict() for context generation  https://review.opendev.org/c/openstack/neutron-lib/+/85981309:57
opendevreviewMerged openstack/ovn-octavia-provider stable/victoria: Avoid LB ERROR status on delete when LS/LR are already deleted  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85953210:07
opendevreviewMerged openstack/ovn-octavia-provider stable/wallaby: Avoid LB ERROR status on delete when LS/LR are already deleted  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85953110:15
opendevreviewArkady Shtempler proposed openstack/neutron-tempest-plugin master: Adds use of "Designate API" into "_verify_dns_records" method  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/85987110:17
opendevreviewRodolfo Alonso proposed openstack/neutron master: Bump minimum OVN version to v21.06.0  https://review.opendev.org/c/openstack/neutron/+/86007810:35
sean-k-mooneyralonsoh: what is the state of nftabels support in neutron these days.  or more specificaly in yoga10:40
sean-k-mooneyis it exepcted to work10:40
ralonsohsean-k-mooney, we use nftables but the old API10:44
sean-k-mooneyand if the old api is not present any more10:45
sean-k-mooneylink ubuntu 22.0410:45
opendevreviewRodolfo Alonso proposed openstack/neutron master: Since OVN 20.06, config is stored in "Chassis.other_config"  https://review.opendev.org/c/openstack/neutron/+/85964210:46
ralonsohsean-k-mooney, then it won't work10:46
sean-k-mooneyand cause https://bugs.launchpad.net/neutron/+bug/199150110:46
sean-k-mooneyprivileged.agent.linux.ip_lib.InterfaceOperationNotSupported: Operation not supported on interface qg-4bb9d20b-a0, namespace qrouter-edf1cc99-879a-4fe5-a7b2-d19acb8fdcbf.10:46
ralonsohsean-k-mooney, nftables provides IP tables API support10:47
sean-k-mooneydoes that not require the iptables-legacy package10:48
ralonsohsean-k-mooney, let me check10:48
ralonsohsean-k-mooney, no, "iptables-legacy" is the previous framwork10:49
ralonsohwe use netfilter, using the old API10:49
sean-k-mooneyoh ok10:50
sean-k-mooneyso it might not be related to that speficically10:50
sean-k-mooneywhat failing is deleting the ip address in the router10:50
ralonsohright, the error is in "delete_ip_address"10:51
ralonsohsean-k-mooney, did you try to execute manually the command?10:51
sean-k-mooneyno but restarting the l3 agent semas to fix it temporally10:52
sean-k-mooneyill see if i can figure out what command its running10:52
sean-k-mooneyhttps://github.com/openstack/neutron/blob/master/neutron/agent/linux/ip_lib.py#L834-L835 thats what is failing so i guess that simialr to ifconfig 0 10:55
sean-k-mooneyok its usign pyroute210:55
sean-k-mooneyi guess ip a del qg-4bb9d20b-a010:56
sean-k-mooneymight be the same10:56
sean-k-mooneyah i see10:58
ralonsohsean-k-mooney, why don't you try to open a python console and execute the same method?10:58
sean-k-mooneythe floating ips are assigned to the bridge interface10:58
sean-k-mooneyhttps://paste.opendev.org/show/bSVlRFcUzxYX36YDVH4G/10:59
sean-k-mooneyralonsoh: because that would be the smart thing :P10:59
ralonsohyes, the FIP are in qg11:00
sean-k-mooneyi can add and remove them form the command line11:00
sean-k-mooneyill try it form the container via python11:01
sean-k-mooneymy concen is this seams to work for a time11:01
sean-k-mooneyand then break11:01
sean-k-mooneyas in restartign the l3 agent fixes it11:01
ralonsohyou need to import neutron.agent.linux.ip_lib11:01
ralonsohand then call this method11:01
sean-k-mooneythen it breaks so im wondering if there is a race or something11:01
sean-k-mooneyralonsoh: sure ill try that now11:02
sean-k-mooneyralonsoh: ye remove the old cli impelmeation a few years ago right11:02
opendevreviewMerged openstack/ovn-octavia-provider stable/yoga: Avoid LB ERROR status on delete when LS/LR are already deleted  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85952811:02
ralonsohyes, we no longer call "ip address"11:02
sean-k-mooneyack i rememeber ye did the convertion to iproute just was not sure if the legacy code was still there somewhere11:03
sean-k-mooneyhttps://paste.opendev.org/show/biKsu3bTAiVpI5ycBteG/11:10
sean-k-mooneyfails the same way11:10
sean-k-mooneyso ya it works with the cli and fails in the command line11:15
sean-k-mooneysorry works with cli but fails with iproute11:15
ralonsohsean-k-mooney, let me check11:17
sean-k-mooneyby the wya the reason i went back to ml2/ovs in this env is ovn seamed to be very broken11:18
sean-k-mooneyit was not installing flow that woudl allow the metadata api to work and i confirmed that packets were gettign to ovs but never to the metadata namespaces11:18
ralonsohsean-k-mooney, can you execute this command inside a root python shell?11:21
ralonsohone sec11:21
sean-k-mooneyno rush. i was redeploying my home cloud and setting up my third party ci again at teh weekend when i hit this. this is causuging the fip to break in the middel of tempest runs which is why i brought this up but its not super urgent11:22
sean-k-mooneybut i can try anything that you would like me too11:23
ralonsohsean-k-mooney, 11:25
ralonsohfrom neutron.privileged.agent.linux import ip_lib11:25
ralonsoh_run_iproute_addr("delete","qg-4bb9d20b-a0","qrouter-edf1cc99-879a-4fe5-a7b2-d19acb8fdcbf", address="172.20.0.79", mask=32, family=4)11:25
ralonsohsorry, 11:25
opendevreviewMerged openstack/networking-ovn stable/train: Avoid LB ERROR status on delete when LS/LR are already deleted  https://review.opendev.org/c/openstack/networking-ovn/+/85962911:25
ralonsohip_lib._run_iproute_addr11:25
sean-k-mooneyah you think it might eb the cidr notation11:26
ralonsohI'm just trying to avoid the privsep context11:26
ralonsohand see that the pyroute2 call returns11:26
sean-k-mooney ah11:26
ralonsohbut no, this method will also catch the exception11:27
sean-k-mooney https://paste.opendev.org/show/baTFAUlPTvw5U05xFuB3/11:27
sean-k-mooneyits the same error that i saw form the neutron logs more or less11:28
sean-k-mooneywell i think it gets dumpt to stdout11:28
ralonsohsean-k-mooney, it could be a problem in the pyroute2 library version11:32
ralonsohI really don't know 11:32
ralonsohcan you try first "add" an IP11:32
ralonsohand then "delete"?11:32
sean-k-mooneywith iproute11:32
ralonsohyes11:33
sean-k-mooneysure11:33
ralonsohsame command just using another IP address11:33
ralonsohwith /3211:33
sean-k-mooneyi added .42 and got the same error11:33
ralonsohbut during the deletion, right?11:34
ralonsohwhat version of pyroute2 do you have?11:35
sean-k-mooneyno add failed11:35
ralonsohI'll try manually on my dev11:35
sean-k-mooneypyroute2==0.6.611:36
sean-k-mooneythats from febuary which makes sense for yoga11:38
sean-k-mooneybug it predates 22.04's release11:38
sean-k-mooneyso maybe i need a newer version11:38
ralonsohI'm having the same issue with 20.04 and latest pyroute211:40
ralonsohI can't believe this...11:41
sean-k-mooneyif you have been using ovn you would not see this11:41
ralonsohsean-k-mooney, we have a functional test testing this11:42
ralonsohtest_delete_ip_address11:42
sean-k-mooneyis taht passing?11:43
ralonsohsure11:43
sean-k-mooneyi noticed that ye marked some fo the floating ip tempest test as flaky11:43
sean-k-mooneywhatever this is its not new if its showing up in yoga and in contaienr based on (centos 8/py3.6 , debian 11/py39 and ubuntu 20.04/py38)11:46
opendevreviewFernando Royo proposed openstack/neutron master: Check subnet overlapping after add router interface  https://review.opendev.org/c/openstack/neutron/+/85914311:47
sean-k-mooneyhttps://bugs.launchpad.net/neutron/+bug/181558511:51
sean-k-mooneythat was the bug i was thinking of11:51
sean-k-mooneyhttps://github.com/openstack/neutron-tempest-plugin/commit/5ddcf33322f1e257322369fff6416aa48c4214b9 marked that test as unstable and it was reverted by https://github.com/openstack/neutron-tempest-plugin/commit/305ded386ba186d38247d91ff3657b36defd3a0b11:52
ralonsohso now is tested11:52
sean-k-mooneywell this was just disabled for linuxbridge11:53
sean-k-mooneybut this was the bug i came across when i was looking last night11:53
sean-k-mooneyoh i guess https://bugs.launchpad.net/neutron/+bug/179979011:53
ralonsohlet me check that after lunch11:54
sean-k-mooneyi might try swapping back to ovn11:54
sean-k-mooneyalthough metadta was not workign form me on ovn11:54
sean-k-mooneyi have sicne enabeld config drive so maybe thats not an issue if everythign else works11:55
ralonsohdid you set the OVS openvswitch name?11:55
ralonsohone sec11:55
ralonsohsean-k-mooney, 11:55
ralonsohovs-vsctl list open .11:55
ralonsohexternal_ids        : {hostname=u20ovn,  <=== name of the host11:55
ralonsohif not11:55
ralonsohovs-vsctl set open . external_ids:hostname="u20ovn"11:56
sean-k-mooneyhttps://paste.opendev.org/show/bpj0hkCyEsShOTYZssc5/11:56
ralonsohin your OVN env?11:57
sean-k-mooneywell its not ovn any more11:57
ralonsohah ah ok11:57
sean-k-mooneyi uninstalled openstack and redeployed with ml2/ovs11:57
ralonsohok, give me some time for lunch11:57
ralonsohand I'll check what is happenign with the IP deletion11:57
sean-k-mooneyack as i said not super urgent11:57
sean-k-mooneybut it seamed like a real bug11:57
sean-k-mooneyim kind of tempetd to locally hack in a call to "ip a ..."11:58
opendevreviewMerged openstack/ovn-octavia-provider stable/xena: Avoid LB ERROR status on delete when LS/LR are already deleted  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85953012:08
sean-k-mooneyralonsoh: https://bugzilla.redhat.com/show_bug.cgi?id=209498612:15
sean-k-mooneyhttps://github.com/svinota/pyroute2/commit/1eb08312de30a083bcfddfaa9c1d5e124b6368df12:15
sean-k-mooneyits in 0.6.1012:15
ralonsohsean-k-mooney, I've tested this with 0.7.212:47
ralonsohand I have the same result12:47
*** dkehn_ is now known as dkehn12:55
*** dasm|off is now known as dasm12:59
opendevreviewArkady Shtempler proposed openstack/neutron-tempest-plugin master: Adds use of "Designate API" into "_verify_dns_records" method  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/85987113:07
opendevreviewFernando Royo proposed openstack/neutron master: Check subnet overlapping after add router interface  https://review.opendev.org/c/openstack/neutron/+/85914314:39
*** dkehn_ is now known as dkehn15:55
opendevreviewMerged openstack/ovn-octavia-provider stable/zed: Avoid LB ERROR status on delete when LS/LR are already deleted  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/85952716:00
*** dasm is now known as dasm|off21:16

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!