Friday, 2022-11-25

opendevreviewMiguel Lavalle proposed openstack/neutron master: [WIP][DNM][OVN] Change the default firewall policy  https://review.opendev.org/c/openstack/neutron/+/83906600:33
*** dmitriis is now known as Guest2200:56
opendevreviewMerged openstack/neutron stable/ussuri: ovn: first tear down old metadata namespaces, then deploy new  https://review.opendev.org/c/openstack/neutron/+/86498103:00
opendevreviewLuca Czesla proposed openstack/neutron master: Add address scope to the OVN LSP port registers  https://review.opendev.org/c/openstack/neutron/+/86171907:48
bcafarelslaweq: good morning can you check https://review.opendev.org/c/openstack/neutron/+/865163/ ? a backport in a chain that missed for second +2 (all others are W+1)08:00
ralonsohI can check it08:02
slaweqthx ralonsoh - You were faster than me :)08:09
bcafarelralonsoh: thanks!08:09
slaweqfrickler hi, please check https://review.opendev.org/c/openstack/devstack/+/865014/ when You will have some time08:15
slaweqit's removal of the lib/neutron (finally) :)08:15
slaweqthx in advance08:15
opendevreviewRodolfo Alonso proposed openstack/neutron-lib master: Use a secure hash method: replace "sha1" with "sha256"  https://review.opendev.org/c/openstack/neutron-lib/+/86557808:18
opendevreviewRodolfo Alonso proposed openstack/neutron-lib master: "convert_to_sanitized_mac_address" accepts netaddr.EUI type values  https://review.opendev.org/c/openstack/neutron-lib/+/86551708:18
opendevreviewRodolfo Alonso proposed openstack/neutron master: Remove deprecation warning of "ovs-ofctl" usage  https://review.opendev.org/c/openstack/neutron/+/86558808:19
ralonsohfolks, we need https://review.opendev.org/c/openstack/neutron/+/865590 in order to bump n-lib08:20
ralonsohpatch for requirements blocked: https://review.opendev.org/c/openstack/requirements/+/86489908:20
opendevreviewLajos Katona proposed openstack/neutron master: Fix bulk create without mac  https://review.opendev.org/c/openstack/neutron/+/86388108:45
fricklerralonsoh: may I ask how that change is handled during upgrades?08:47
ralonsohfrickler, what change?08:48
fricklerralonsoh: the table number change in n-lib that requires https://review.opendev.org/c/openstack/neutron/+/86559008:49
ralonsohfrickler, first of all, I was against a change in the FW table numbers. In any case, this number is used only by the OVS agent locally. When the agent is restarted with the new n-lib, the OF table is rebuilt08:51
fricklerdoes that happen on any agent restart? that would mean it would always disrupt traffic iiuc08:52
ralonsohfrickler, that could affect to the conntrack entries, but should be rebuilt inmediately08:53
frickler"should" is a pretty soft term, but likely that's a more general issue, thx anyway08:57
ralonsohfrickler, this is what is happening right now, even without this change08:57
ralonsohthe datapath will change, but that means a packet will cross now table 58 instead of 5908:58
ralonsohbut this change is done in the OF table in one shot08:58
opendevreviewMaximilian Stinsky proposed openstack/neutron master: Fix duplicated routes exceptions  https://review.opendev.org/c/openstack/neutron/+/86552508:58
fricklerralonsoh: yes, not a new issue, I agree09:07
opendevreviewMerged openstack/neutron master: Fix missing [designate] options  https://review.opendev.org/c/openstack/neutron/+/86522009:07
fricklerslaweq: looking pretty good already, just two minor comments09:07
opendevreviewMerged openstack/neutron stable/wallaby: Delete MAC binding for LRP when the port is deleted  https://review.opendev.org/c/openstack/neutron/+/86516309:07
opendevreviewMerged openstack/neutron stable/wallaby: Ensure only one worker creates neturon_pg_drop  https://review.opendev.org/c/openstack/neutron/+/86516709:12
opendevreviewRodolfo Alonso proposed openstack/neutron master: Add an env variable "PROCESS_TAG" in ``ProcessManager``  https://review.opendev.org/c/openstack/neutron/+/86501809:14
sahidlajoskatona: I commented on your patches, I hope that will make sense, thanks !09:30
lajoskatonasahid: thanks I will check it09:31
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider master: Make clear distinction between health check and health monitor  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/86481709:36
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider master: Make clear distinction between health check and health monitor  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/86481710:17
opendevreviewRodolfo Alonso proposed openstack/neutron master: Avoid race condition when deleting trunk bridges  https://review.opendev.org/c/openstack/neutron/+/83778010:20
opendevreviewRodolfo Alonso proposed openstack/neutron master: [DNM] Testing patch  https://review.opendev.org/c/openstack/neutron/+/86503910:23
opendevreviewMerged openstack/neutron master: Configure placement credentials for segments plugin  https://review.opendev.org/c/openstack/neutron/+/81509311:07
opendevreviewMerged openstack/neutron stable/xena: Delete MAC binding for LRP when the port is deleted  https://review.opendev.org/c/openstack/neutron/+/86516211:07
stephenfinralonsoh: Afternoon o/ Does this error message look familiar to you? https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1396/pull-cluster-api-provider-openstack-e2e-test/1595934082498301952/artifacts/devstack/controller-devstack.log11:22
ralonsohstephenfin, yes but not there11:22
ralonsohstephenfin, let me check that11:22
ralonsohis the first time you see it?11:23
stephenfinYeah, I see a bug from Thomas Goirand but that's only in the unit tests https://bugs.launchpad.net/neutron/+bug/199350211:23
ralonsohstephenfin, this is only for UTs11:23
stephenfinYup. There's a bug in k8s cluster-api-provider-openstack https://github.com/kubernetes-sigs/cluster-api-provider-openstack/issues/139711:23
ralonsohstephenfin, is that using neutron master?11:24
stephenfinI don't think so. I think we use stable devstack11:24
stephenfinstable/yoga iirc, but I'm checking11:25
stephenfinyes yoga https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/hack/ci/create_devstack.sh#L3411:27
opendevreviewRodolfo Alonso proposed openstack/neutron master: Support for minimum bandwidth rules in tunnelled networks  https://review.opendev.org/c/openstack/neutron/+/86063911:27
ralonsohstephenfin, ok, I'll check it now11:27
stephenfinthe bug mentions this commit which was merged three days ago https://github.com/openstack/neutron/commit/44ec1f150338ec69a811e1b2cfa4214c07a9af8311:28
stephenfinthat would coincide with this11:28
opendevreviewMerged openstack/neutron stable/ussuri: OVN: Add support for DHCP option "domain-search" for IPv4  https://review.opendev.org/c/openstack/neutron/+/86501111:29
stephenfinFYI here's our local.conf https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/hack/ci/cloud-init/controller.yaml.tpl11:32
stephenfinMy initial guess is that we're enabling some combination of services that isn't tested upstream on stable/yoga, but I'm checking myself too11:32
ralonsohstephenfin, are there more logs? are those logs from the neutron-server?11:36
ralonsohwell, they are11:36
ralonsohbut what I mean is if you have all the neutron-server logs11:36
stephenfinLet me check11:36
stephenfinokay, here's a recent prow build for CAPO https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1393/pull-cluster-api-provider-openstack-e2e-test/159607631477788262411:37
stephenfinno more logs11:37
stephenfinhttps://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1393/pull-cluster-api-provider-openstack-e2e-test/1596076314777882624/artifacts/devstack/11:37
stephenfinralonsoh: I'll modify the job and get you some. Will be a few hours11:38
ralonsohstephenfin, thanks a lot. 11:38
ralonsohplease ping me 11:38
labedzhi guys, I am thinking about bumping python ovs libraries: ovs and ovsdbapp like: https://review.opendev.org/c/openstack/requirements/+/86567211:51
labedzbut I am supprised that 'proper' version is since Yoga11:51
labedzam I missing anything?11:51
ralonsohlabedz, sorry, that does it means?11:52
labedzok, let's rewind :)11:53
labedzthere is a bug: https://bugs.launchpad.net/os-vif/+bug/1929446 that impact me11:53
labedzfix appear with new libraries ovs 2.16 and ovsdbapp 1.1411:53
mnasiadkaovs is tricky, because it should match your installed openvswitch version11:53
labedzbut until Yoga we are still using versions bellow11:53
mnasiadka(or at least not be older) - from what we've noticed over time ;)11:54
labedzwhich means that without 'admin tuning' we are affected11:54
ralonsohI would need to check but I don't know if we are using ovs 2.16 in the CI11:54
labedzmnasiadka: true11:54
ralonsohlabedz, now we are using Ubuntu 22.04, we can consider using newer OVS versions11:56
ralonsohI'll check if we can bump to this pyhton-ovs version, along with the ovsdbapp library11:56
labedzbut if you are unlucky this issue can break your system totally (like not processing 50% of OVN notification)11:57
ralonsohlabedz, https://review.opendev.org/c/openstack/requirements/+/865672 won't be accepted12:00
ralonsohCI in ussuri is not running ubuntu 20.0412:00
ralonsohthis OS is installing an older version of OVS12:00
labedzsure - just an example12:00
ralonsohactually I though I was looking at a master branch patch12:01
ralonsohthis is already solved in master12:01
ralonsohI mean, the versions are bumped12:01
labedzyes - ut's since Yoga12:01
ralonsohin your env (Ussuri) you'll need to use a never OVS version with newer python-ovs and ovsdbapp12:01
opendevreviewFelix Huettner proposed openstack/neutron stable/yoga: Since OVN 20.06, config is stored in "Chassis.other_config"  https://review.opendev.org/c/openstack/neutron/+/86328112:02
labedznow I know :)12:02
labedzbut would be nice to have some sollution to mittigate this issue12:02
labedzas we have still some users <Yoga :)12:02
ralonsohlabedz, requirements is for testing, that doesn't prevent you from installing newer versions in your env12:03
labedzunderstand12:04
labedzstill: tests are also impacted (there is some probability that issue will hit) and operators has to be at least aware of the issue somehow12:05
labedzanyway smth to consider12:05
ralonsohsahid, hey, please check https://bugs.launchpad.net/neutron/+bug/199796412:23
stephenfinQuick q: Can an extension _remove_ API routes or response fields? Can it modify response fields (i.e. switch from string to list)?12:38
ralonsohstephenfin, when we build the resources, we create the maps. By default we use the n-lib API definitions. There are some of them that are "built" in Neutron, but that's all12:40
ralonsohare you talking aboyt something specific?12:41
stephenfinI'm trying to describe in a sentence or two how neutron does API versioning (for OSC docs)12:41
stephenfinso far I have this12:41
stephenfin.. rubric:: Extensions12:41
ralonsohstephenfin, we don't have API versioning12:41
stephenfinThis is used by the Networking services (neutron). An extension can add12:41
ralonsohwe have the extensions12:41
stephenfinfeatures and vendor-specific functionality to the API. This can include new API12:41
stephenfinresources and well as new fields in API requests and responses. If you want to12:42
stephenfindepend on a feature added by an extension, you can check if the extension is12:42
stephenfinpresent.12:42
ralonsohstephenfin, yes, that could describe how is done in Neutron12:42
ralonsohand yes, we don't have a version number but you can check if the extension is enabled12:43
stephenfinCool. So my question is does the n-lib API definitions ever remove stuff or is purely additive?12:43
ralonsohwe can add, remove or modify12:43
stephenfini.e. if extension foo was present, could that mean /bar disappears 12:43
stephenfinokay, sweet12:43
stephenfinso instead of12:44
stephenfin"An extension can add features and vendor-specific functionality to the API"12:44
stephenfinit would be better to say 12:44
stephenfin"An extension can add, remove or features and vendor-specific functionality to the API"12:44
stephenfin*add, remove or modify12:45
ralonsohright12:45
opendevreviewRodolfo Alonso proposed openstack/neutron master: Avoid race condition when deleting trunk bridges  https://review.opendev.org/c/openstack/neutron/+/83778012:49
opendevreviewRodolfo Alonso proposed openstack/neutron master: [DNM] Testing patch  https://review.opendev.org/c/openstack/neutron/+/86503912:49
opendevreviewFelix Huettner proposed openstack/neutron stable/yoga: Since OVN 20.06, config is stored in "Chassis.other_config"  https://review.opendev.org/c/openstack/neutron/+/86328112:51
opendevreviewMerged openstack/neutron stable/xena: ovn: Use ovsdb-client to create neutron_pg_drop  https://review.opendev.org/c/openstack/neutron/+/86516113:30
slaweqralonsoh hi, I just wrote a question in https://review.opendev.org/c/openstack/neutron-lib/+/865578 - if this will not be a problem, I'm happy to approve it :)14:04
slaweqbut please check and reply to my question first14:04
ralonsohslaweq, ufff hold on, I didn't think about this... to be honest, how we build the interface name is trivial, but we should be consistent14:06
ralonsohI'll change it, skipping the pylint error14:07
opendevreviewElvira García Ruiz proposed openstack/python-neutronclient master: Fix help sentence in network log create --enable  https://review.opendev.org/c/openstack/python-neutronclient/+/86569414:09
opendevreviewElvira García Ruiz proposed openstack/python-neutronclient master: Fix help sentence in network log create --enable  https://review.opendev.org/c/openstack/python-neutronclient/+/86569414:10
slaweqI think You can add parameter "usedforsecurity=False" or something like that14:10
slaweqand it will not complain anymore14:11
slaweqIIRC14:11
ralonsohI prefer to skip just this warning there14:11
ralonsohah no, I know what you mean now14:12
slaweq:)14:15
*** tbachman_ is now known as tbachman14:18
sahido/ Neutron steam, how do you feel about to ebable the feature multisegments? https://review.opendev.org/c/openstack/neutron/+/841838 Even if ofcourse I will be glad to ensure that it is merged for this release :-) I think it's a good point to have it merged sooner in the release so we can address and fix any bugs that may exist :D14:19
sahids/steam/team14:19
opendevreviewRodolfo Alonso proposed openstack/neutron-lib master: User "sha1" with "usedforsecurity=False"  https://review.opendev.org/c/openstack/neutron-lib/+/86557814:20
ralonsohsahid, hey, please check https://bugs.launchpad.net/neutron/+bug/199796414:21
sahidralonsoh: oh! let me see what's going on and share a fix14:24
sahidi mean, are you woirking on it?14:24
ralonsohnot today14:24
sahidralonsoh: you see... having the whole thing merged soon as possible is better ;-)14:24
sahidlet me assign myself on it14:24
opendevreviewElvira García Ruiz proposed openstack/python-neutronclient master: Fix help sentence in network log create --enable  https://review.opendev.org/c/openstack/python-neutronclient/+/86569414:33
sahidlajoskatona: just to be sure, I have assigned myself on https://bugs.launchpad.net/neutron/+bug/1997964, you are not on it right?14:47
sahidthe whole point is to understand when we can be in a sitatuation of calling this method with network == None, if it is ligit, then we could just return I guess since there are nothing we can do14:50
opendevreviewRodolfo Alonso proposed openstack/neutron-tempest-plugin master: Skip "test_port_resource_request_no_provider_net_conflict"  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/86388014:56
opendevreviewRodolfo Alonso proposed openstack/neutron master: Support for minimum bandwidth rules in tunnelled networks  https://review.opendev.org/c/openstack/neutron/+/86063914:56
lajoskatonasahid: no actually I just checked when it was introduced, so don't worry I am not on it :P14:58
opendevreviewMaximilian Stinsky proposed openstack/neutron master: Fix duplicated routes exceptions  https://review.opendev.org/c/openstack/neutron/+/86552515:15
opendevreviewMerged openstack/neutron master: Use the neutron-lib constant for PACKET_RATE_LIMIT table number  https://review.opendev.org/c/openstack/neutron/+/86559015:29
sahidlajoskatona: ok cool, don't revert anything I will fix it soon :-) I noticed you have marked it as Critical, It may be a bit too much I think :-)15:41
ralonsohthis is the default priority if a bug is affecting the CI15:42
opendevreviewElvira García Ruiz proposed openstack/neutron master: Fix behaviour of enable/disable in OVN network log  https://review.opendev.org/c/openstack/neutron/+/86415215:42
opendevreviewFelix Huettner proposed openstack/neutron master: Fix handling the restart of ovn-controllers  https://review.opendev.org/c/openstack/neutron/+/86569715:43
*** elvira1 is now known as elvira16:18
opendevreviewMerged openstack/ovn-octavia-provider master: Ensure HM updates work as expected  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/86482117:05
sahidralonsoh: ack17:27
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/zed: Ensure HM updates work as expected  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/86571017:30
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/yoga: Ensure HM updates work as expected  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/86571117:31
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/xena: Ensure HM updates work as expected  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/86571217:31
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider stable/wallaby: Ensure HM updates work as expected  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/86571317:32
opendevreviewMerged openstack/python-neutronclient master: Fix help sentence in network log create --enable  https://review.opendev.org/c/openstack/python-neutronclient/+/86569418:06
opendevreviewMaximilian Stinsky proposed openstack/neutron master: Fix duplicated routes exceptions  https://review.opendev.org/c/openstack/neutron/+/86552518:40
opendevreviewMaximilian Stinsky proposed openstack/neutron master: Add function to refresh accept_ra on router state change  https://review.opendev.org/c/openstack/neutron/+/82494723:18

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!