Friday, 2023-06-30

*** amoralej|off is now known as amoralej06:18
ykarelfrickler, sorry can you link again the failure i couldn't see it in irc logs, was out yesterday06:53
fricklerykarel: seems https://review.opendev.org/c/openstack/neutron/+/878565 is causing some failure on startup, at least in kolla https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_437/886088/6/check/kolla-ansible-ubuntu-ovn/437a107/primary/logs/container_logs/neutron_ovn_agent.txt , looks to me like the daemon isn't getting tested at all in neutron jobs07:04
fricklerbut also just fyi the channel is logged here https://meetings.opendev.org/irclogs/%23openstack-neutron/%23openstack-neutron.2023-06-29.log.html#t2023-06-29T06:56:4407:06
ykarelfrickler, yes seems that's not being tested atleast in devstack jobs07:07
ykarelralonsoh, may be you have some WIP patch for ^?07:07
ykarelhttps://review.opendev.org/q/topic:ovn-agent, i see it's running in puppet jobs and not failing https://89eff09f79bbd4ce4af9-46ed996c4c88287cea630d62dd5380de.ssl.cf5.rackcdn.com/886438/3/gate/puppet-openstack-integration-7-scenario005-tempest-centos-9-stream/37acf7d/logs/neutron/neutron-ovn-agent.txt07:11
ykarelneutron.conf is not passed in these puppet jobs , that seems to be the difference with kolla one07:14
ykarelok wait let me check promotion jobs as neutron change is not yet in puppet upstream jobs07:23
ralonsohykarel, I'll check it now07:24
ralonsohykarel, this agent only has one implementation for HWOL with QoS07:26
ralonsohthere is no reason to test it in the CI because we don't have this HW07:26
ralonsohonce we migrate the ovn metadata agent to the OVN agent, we'll be able to test something07:26
mnasiadkafrickler: let's just disable testing of that agent in the CI for now07:27
ykarelack just checked puppet jobs also hit it in promotion pipeline https://logserver.rdoproject.org/openstack-periodic-daily/review.rdoproject.org/rdoinfo/master/weirdo-bobcat-promote-puppet-scenario005-centos-stream-9/9f93f3b/logs/weirdo-project/logs/systemctl.txt.gz07:35
ralonsohI abandoned the patches for puppet and tripleo07:36
ralonsohfor the ovn agent07:36
ykarelas part of https://review.opendev.org/q/topic:ovn-agent it's enabled in puppet jobs07:37
ykareland with https://review.opendev.org/c/openstack/neutron/+/878565 the agent couldn't start07:37
ykarelbecause it's checking for https://github.com/openstack/neutron/blob/master/neutron/common/config.py#L105 during start07:38
ralonsohso I need to remove this patch then07:38
ykarelralonsoh, you mean https://review.opendev.org/c/openstack/neutron/+/878565 or https://review.opendev.org/c/openstack/puppet-openstack-integration/+/878512 ?07:43
ralonsohboth if ovn agent should be tested in Neutron07:44
ralonsohin any case, I didn't remember reviewing this neutron patch07:44
ralonsohI'll revert it07:44
ralonsohor at least propose a fixed version, let me check the neutron patch now and how to fix it07:45
ykarelack +107:47
opendevreviewRodolfo Alonso proposed openstack/neutron stable/wallaby: [OVN] Remove SB "Chassis"/"Chassis_Private" duplicated registers  https://review.opendev.org/c/openstack/neutron/+/88725308:18
opendevreviewChristian Rohmann proposed openstack/neutron master: Drop redundant index on ports table  https://review.opendev.org/c/openstack/neutron/+/88545609:10
opendevreviewRodolfo Alonso proposed openstack/neutron master: [OVN] Read the necessary configuration options in the OVN agent load  https://review.opendev.org/c/openstack/neutron/+/88736309:34
ralonsohykarel, ^09:35
ralonsohlajoskatona, slaweq mlavalle hi folks, if you have 2 mins: https://review.opendev.org/c/openstack/neutron/+/88621310:19
ralonsohthanks!10:19
opendevreviewMerged openstack/neutron stable/victoria: [OVN][FT] Mech driver stop accessing DB at exit  https://review.opendev.org/c/openstack/neutron/+/88696210:25
ykarelThanks ralonsoh 10:42
lajoskatonaralonsoh, slaweq, mlavalle: If you have some free minutes, please check this one: https://review.opendev.org/c/openstack/neutron/+/884505 (history included in commit msg ;))10:57
ralonsohsure10:59
ralonsohlajoskatona, why don't we merge Guillaume patch?11:03
ralonsohhttps://review.opendev.org/c/openstack/neutron/+/88323511:03
ralonsohthat is doing the same, actually better because it is first reading the cache11:03
ralonsohnonono, nevermind11:04
ralonsohyour patch is acting on "remote_group_id"11:04
ralonsohnot "security_group_id", sorry!11:04
ralonsohbut IMO, we should have both merged11:04
lajoskatonathat's just the same part of the code , so be aware of merge conflicts ;)11:05
ralonsohyeah, and IMO, if we backport it, we should backport both11:05
lajoskatonaagree 883235 is also needed, to tell the truth I beleived it was merged11:05
ralonsohissue in the CI...11:05
ralonsohI've rechecked it now11:05
fnordahlralonsoh: we would love to hear review feedback on the remainder of the Active-Active L3 GW series: https://review.opendev.org/q/topic:2023-aa-l3-gw-multihoming+status:open 11:30
ralonsohyes, whenever I have some time for this11:30
*** obondare_ is now known as obondarev12:04
opendevreviewMerged openstack/neutron stable/wallaby: [OVN][Trunk] Add port binding info on subport when parent is bound  https://review.opendev.org/c/openstack/neutron/+/88702212:12
*** amoralej is now known as amoralej|lunch12:20
opendevreviewyatin proposed openstack/neutron master: Switch fullstack/functional fips jobs to 9-stream  https://review.opendev.org/c/openstack/neutron/+/84324512:32
ralonsohykarel, please check https://review.opendev.org/c/openstack/neutron/+/887254. Related to ^^^12:47
ralonsohok, your patch is older and is working12:48
ykarelralonsoh, yes can rebase ^ on top of the other one12:48
ralonsohno no, your patch is enough12:49
ykarelahh yes right12:49
ykareli thought both targetting some different jobs12:49
opendevreviewyatin proposed openstack/neutron master: Switch fullstack/functional fips jobs to 9-stream  https://review.opendev.org/c/openstack/neutron/+/84324513:00
*** amoralej|lunch is now known as amoralej13:09
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Run FIPS functional and fullstack jobs on Centos 9 Stream  https://review.opendev.org/c/openstack/neutron/+/88725413:26
ralonsohslaweq, ykarel posted another patch https://review.opendev.org/c/openstack/neutron/+/84324513:27
ralonsohand this one is older13:27
ralonsohand I think is working now13:27
bcafarellucasagomes: o/ I am looking at https://review.opendev.org/c/openstack/neutron/+/887280 backport chain, was there an important bug to have the 2 backports squashed together? we tend to backport commits 1-1 unless it blocks gates or similar big issues13:28
slaweqralonsoh great - I though there was something but I couldn't find it :)13:29
lucasagomesbcafarel, yes, I squashed both changes because otherwise it will be broken. It was breaking another project CI13:30
lucasagomesralonsoh, ^ do u remember which project was it ? RDO CI or something ?13:30
ralonsohyeah, this patch was introducing a DB txn error13:30
ralonsohlet me check13:30
lucasagomesbcafarel, but that was the reason why I squashed it13:30
ralonsohno, I didn't refer the error in the LP bug https://bugs.launchpad.net/neutron/+bug/202444713:31
lucasagomesyeah I don't remember either, but I remember someone from the project commented here on IRC13:31
lucasagomesand then you fixed it in no time heh13:31
lucasagomesthat's why I prefered to squash and have both patches merged at once instead a broken one and the fix separated13:32
bcafarellucasagomes: ack good enough for me then :)13:32
lucasagomesbcafarel, cheers!13:32
fnordahlralonsoh: great, thank you, we're getting awfully close to milestone 2 and patches have been up since before the opening of 2023.2, so would be very much apprechiated13:37
fnordahlotherwiseguy: since we've been in close loop on the ovsdbapp pieces, would you be interested in reviewing https://review.opendev.org/c/openstack/neutron/+/874760 and https://review.opendev.org/c/openstack/neutron/+/874760 ?13:37
fnordahlarg, latter link should have been https://review.opendev.org/c/openstack/neutron/+/87369913:38
otherwiseguyfnordahl: yeah, I'll take a look at it this morning. Sorry, got caught up on some other projects.13:38
fnordahlthx! 13:38
opendevreviewSlawek Kaplonski proposed openstack/neutron-lib master: Add is_service_role property to the context class  https://review.opendev.org/c/openstack/neutron-lib/+/88719113:56
opendevreviewLucas Alvares Gomes proposed openstack/neutron stable/2023.1: [OVN] Hash Ring: Set nodes as offline upon exit  https://review.opendev.org/c/openstack/neutron/+/88728113:57
slaweqralonsoh I just updated patch https://review.opendev.org/c/openstack/neutron-lib/+/887191 addressing Your comments, please check it when You will have some time13:58
slaweqthx in advance13:58
ralonsohslaweq, sure, let me check13:59
ralonsohPing list: ykarel, mlavalle, mtomaska, slawek, obondarev, tobias-urdin, lajoskatona, amotoki 13:59
mlavalleo/13:59
lajoskatonao/14:00
ralonsoh#startmeeting neutron_drivers14:00
opendevmeetMeeting started Fri Jun 30 14:00:07 2023 UTC and is due to finish in 60 minutes.  The chair is ralonsoh. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'neutron_drivers'14:00
ralonsohhello all!14:00
ykarelo/14:00
haleybo/14:00
slaweqo/14:00
ralonsohjust before starting: please check https://review.opendev.org/c/openstack/neutron-specs/+/88532414:00
ralonsohnext week will the the last to merge a neutron spec for this cycle14:00
ralonsohthat's all (before starting)14:00
mlavalle\o/14:01
ralonsohfrickler?14:01
ralonsohI think we have quorum, let's start14:01
ralonsoh1) [RFE] Formalize use of subnet service-type for draining subnets14:01
ralonsoh#link https://bugs.launchpad.net/neutron/+bug/202492114:01
ralonsohis frickler here?14:02
obondarevhi14:02
ralonsohok, let's move to the second one for now14:02
ralonsoh2) [RFE] Caching instance id in the metadata agent to have less RPC messages sent to server14:02
ralonsohhttps://bugs.launchpad.net/neutron/+bug/202458114:03
ralonsohslaweq, please14:03
slaweqI opened it based on some feedback from the forum in Vancouver14:03
slaweqbasically someone in the large scale deployments room was saying that adding caching of the instance_id in metadata agent lowered load on rabbitmq significantly14:04
slaweqand as we checked with ralonsoh it seems that we are asking neutron server for instance id with every request to the metadata service 14:04
slaweqmaybe we should ask for it once and then cache it for short time locally14:05
slaweqso when guest vm is booted and cloud-init is doing many requests to the metadata server it will do just one rpc query to neutron-server14:05
mlavalleso, each agent in each compute would have a cache?14:05
lajoskatonasahid added some comment which they use in their env if I understand well to use caching for metadata14:05
slaweqthat's whole idea14:05
ralonsohthe OVS RPC cache implementation is better than using solo_cache14:06
lajoskatonawithout code change, would be interestingto try it (I never personally but happy to test it)14:06
ralonsohthe RPC cache will subscribe to the resource events (ports in this case)14:06
ralonsohand will have always the updated information14:06
slaweqlajoskatona I didn't know we can use that memcache there14:06
slaweqmaybe that's the solution then, I will need to test it14:07
ralonsohand will run faster because it won't issue any RPC call (regardless that it will be catch by oslo cache)14:07
lajoskatonaneither me, so omething new to check for met atl east :-)14:07
slaweqthx a lot14:07
mlavalleyeah, let's give it a try14:07
slaweqso I will check it and we can come back to that rfe later14:07
ralonsohok, I'm against using the oslo cache, just for the records14:09
slaweqwhy?14:09
ralonsohbecause that won't have the most updated information14:10
ralonsohoslo cache catches the RPC calls and store the info14:10
ralonsohbut it doesn't store the latest DB info14:10
ralonsohas we can achieve with the OVS RPC cache implementation14:10
ralonsohOVS agent14:10
ralonsohin any case, the oslo cache is just configuration, no code is needed14:11
lajoskatonaI think if it is documented as option with all the effects it can be a choise for the operator, of course without knowing now if it is really working 14:11
slaweqyep14:11
ralonsohthat's ok, but are we going to go further?14:12
slaweqit has some (small) cons so if we will test it and document properly, it can work IMO14:12
slaweqI will test this oslo cache thing and will then see if we need any changes in docs or somewhere else14:12
ralonsohok, so the output of this RFE is documentation, right?14:12
slaweqif I will need any other discussion about it, I will get back to You to bring it here :)14:13
ralonsohperfect14:13
lajoskatona+114:13
mlavalle+114:13
lajoskatonathanksslaweq for bringing it here14:13
ralonsohso we have 2 votes in favor of this RFE14:13
ralonsoh+1 mine too14:13
ralonsohplease, vote for this RFE14:13
haleyb+1 from me14:14
ralonsohobondarev?14:14
*** obondare_ is now known as obondarev__14:14
ralonsohok, we have enough votes I think14:15
ralonsohso RFE approved14:15
ykarel+114:15
obondarev__which one? sorry got disconnected14:15
mlavallehe seems tp have dropped off14:15
ralonsohobondarev__, https://bugs.launchpad.net/neutron/+bug/202458114:15
*** obondarev__ is now known as obondarev14:15
obondarevthanks ralonsoh, lgtm , +114:16
ralonsohthanks14:16
ralonsohI'll update the LP bug14:16
ralonsohok, let's go for the third one14:16
ralonsoh3) [rfe][ml2] Add a new API that supports cloning a specified security group14:16
ralonsoh#link https://bugs.launchpad.net/neutron/+bug/202505514:16
ralonsohI don't know the nickname of Liu Xie14:17
ralonsohin any case, did you check the proposal?14:17
ralonsohwhat is proposed is to have an API to clone SG+rules14:17
ralonsohany feedback? comment?14:18
obondarevnot sure how common is this use case14:19
obondarevwhen one would need an SG with same rules?14:19
mlavalleIn principle I side with Luyong, comment 214:19
slaweqIMO this can be easily scripted using existing API and having that in neutron would be overcomplicating things14:20
obondarev+1 https://bugs.launchpad.net/neutron/+bug/2025055/comments/214:20
slaweqbut that's just my opinion14:20
mlavalleluyong and I agree14:20
mlavallewith slaweq I mean14:20
lajoskatona+1 for Liu's comment14:20
ralonsohand I agree too, the Neutron API should be "atomic" 14:20
haleybso me it seemed somewhat possibly related to the default SG template work, i.e. admin wants to define the default set of SG rules? I didn't get a response to my question though14:21
mlavalleI liked the way Yulong put it: "concise and fundamental"14:21
ralonsohhaleyb, could help, for sure14:21
obondarevhaleyb: well noted14:22
ralonsohand slaweq is working on it14:22
ralonsohok, I think we all think the same here, if I'm not wrong14:22
ralonsohlet's vote first14:23
ralonsoh-114:23
obondarev-114:23
slaweq-114:23
haleyb-114:23
ykarel-114:23
ralonsohI'll update the LP bug with the feedback provided in this conversation14:23
lajoskatona+114:23
lajoskatona-114:23
mlavalle=114:23
ralonsohahh14:23
lajoskatonaI mean(s=orry)14:23
mlavalle+114:23
ralonsohmlavalle, +1?14:24
ralonsohanyway, the RFE is not approved, I'll update the LP today14:24
ralonsohthanks14:24
haleybhe would need a +714:24
mlavalle+114:25
slaweqhaha14:25
obondarevalready +3 :)14:25
slaweqeven +2+W is just kind of +3 in total so far from +7 :P14:25
ralonsohthink about people reading these logs 10 years later14:26
slaweqLOL14:26
ralonsohok, let's jump again to the first RFE14:26
ralonsoh1) [RFE] Formalize use of subnet service-type for draining subnets14:26
ralonsoh#link https://bugs.launchpad.net/neutron/+bug/202492114:26
ralonsohI'll try to summarize it14:26
ralonsohbut I think you know this proposal14:26
mlavalleit's just documentation, isn't it?14:26
ralonsohnot really14:26
obondarevthis one is basically doc update, right?14:27
slaweqIIUC correctly this rfe is about making officially supported something what already works in Neutron14:27
slaweqdoc and some testing maybe14:27
ralonsohwe need to add this service type to the IPAM module14:27
ralonsohin order to avoid it when assigning IPs14:27
ralonsohso no, is not only documentation14:27
ralonsohbut we need to state on the constant to be used as service type14:28
ralonsohbut apart from this, what do you think about this proposal?14:28
ralonsohapart from the implementation14:28
slaweqsounds reasonable for me14:28
slaweqso +114:29
mlavalleseems the use case is justified14:29
obondarevi thought any "unknown" service type would prevent IPAM from allocating IPs from this subnet. The author said they already using it like this14:29
lajoskatonayeah some testing (tempest maybe) is necessary to keep the functionalty working14:29
obondarevam I missing something?14:29
mlavallethat's what I understood14:29
mlavallesame as obondarev 14:29
ralonsohobondarev, yes, but that's the point: not using any random value14:29
obondarevgot it, fair enough, thanks14:30
obondarev+114:30
ralonsohbut yes, now IPAM will skip any service type not null14:30
haleybwe can bikeshed on the name later :)14:30
ralonsohexactly14:30
ralonsohso +1 from, makes sense to have this feature14:30
mlavalle+114:31
haleyb+1, especially to get it documented on how to use14:31
ralonsohok, that was quite productive today! 14:31
ralonsoh3 RFEs in 30 mins14:31
ralonsohI'll update the LP bugs now14:31
ralonsohanything else you want to bring here??14:32
ralonsohso thank you all for attending the meeting14:32
ralonsohand have a nice weekend14:32
ralonsoh#endmeeting14:32
opendevmeetMeeting ended Fri Jun 30 14:32:37 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:32
opendevmeetMinutes:        https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-06-30-14.00.html14:32
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-06-30-14.00.txt14:32
opendevmeetLog:            https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-06-30-14.00.log.html14:32
obondarevo/14:32
lajoskatona1o/14:32
mlavalleo/14:32
slaweqo/14:32
ykarelo/14:32
haleybo/14:32
haleybralonsoh: with next tuesday being a US holiday i will not be at neutron meeting. will send bug report out tomorrow though14:33
ralonsohthanks!14:33
opendevreviewLucas Alvares Gomes proposed openstack/neutron master: [OVN] Expose chassis hosting information in LSP  https://review.opendev.org/c/openstack/neutron/+/88270514:45
opendevreviewRodolfo Alonso proposed openstack/neutron master: [OVN] Prevent Trunk creation/deletion with parent port bound  https://review.opendev.org/c/openstack/neutron/+/88515414:51
opendevreviewChristian Rohmann proposed openstack/neutron master: Drop redundant index on ports table  https://review.opendev.org/c/openstack/neutron/+/88545615:04
*** amoralej is now known as amoralej|off15:07
opendevreviewChristian Rohmann proposed openstack/neutron master: Drop redundant index on ports table  https://review.opendev.org/c/openstack/neutron/+/88545615:10
opendevreviewLajos Katona proposed openstack/python-neutronclient master: WIP: OSC: Remove SFC V2 calls to neutronclient  https://review.opendev.org/c/openstack/python-neutronclient/+/88738815:13
opendevreviewMerged openstack/neutron master: [OVN] Read the necessary configuration options in the OVN agent load  https://review.opendev.org/c/openstack/neutron/+/88736315:26
fricklerralonsoh: meh, sorry I missed that meeting, glad you managed to work through it anyway.15:31
ralonsohfrickler, no problem, that was easy15:31
opendevreviewLuis Tomas Bolivar proposed openstack/ovn-octavia-provider master: Ensure DVR is restablished on member on cascade deletion  https://review.opendev.org/c/openstack/ovn-octavia-provider/+/88661117:09
opendevreviewMerged openstack/neutron master: Do not query neutron-rpc for sg rules upon sg deletion  https://review.opendev.org/c/openstack/neutron/+/88323521:34
opendevreviewMerged openstack/neutron stable/zed: [OVN] Improve Hash Ring logs  https://review.opendev.org/c/openstack/neutron/+/88727221:34
opendevreviewMerged openstack/neutron stable/yoga: [OVN] Improve Hash Ring logs  https://review.opendev.org/c/openstack/neutron/+/88727421:34
opendevreviewMerged openstack/neutron stable/xena: [OVN] Improve Hash Ring logs  https://review.opendev.org/c/openstack/neutron/+/88727621:34
ralonsoh^^^ finally! OK, I'm done for today, have a nice weekend!21:35
opendevreviewMiguel Lavalle proposed openstack/neutron master: Remove unused method from OVN L3 plugin  https://review.opendev.org/c/openstack/neutron/+/88743322:20

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!