| opendevreview | liuyulong proposed openstack/neutron master: Add basical functionalities for metadata path extension https://review.opendev.org/c/openstack/neutron/+/881535 | 04:59 |
|---|---|---|
| opendevreview | liuyulong proposed openstack/neutron master: Add metadata path extension openflows https://review.opendev.org/c/openstack/neutron/+/888097 | 04:59 |
| opendevreview | liuyulong proposed openstack/neutron master: Fullstack case for metadata path https://review.opendev.org/c/openstack/neutron/+/888098 | 04:59 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3 scheduler: calculate load of chassis per priority https://review.opendev.org/c/openstack/neutron/+/893653 | 07:06 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: reschedule lower priorities https://review.opendev.org/c/openstack/neutron/+/893654 | 07:06 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: reschedule priorities on new chassis https://review.opendev.org/c/openstack/neutron/+/893655 | 07:06 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3 router scheduler: reproduce scheduling issue https://review.opendev.org/c/openstack/neutron/+/893656 | 07:06 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: implement caching for Scheduler https://review.opendev.org/c/openstack/neutron/+/893657 | 07:06 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: try to keep routers at current chassis https://review.opendev.org/c/openstack/neutron/+/893658 | 07:06 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: value the higher priorities when scheduling https://review.opendev.org/c/openstack/neutron/+/893659 | 07:06 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider master: Cover the use case of a member non existing https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893839 | 08:08 |
| opendevreview | Lajos Katona proposed openstack/python-neutronclient master: OSC: Remove VPNAAS V2 calls to neutronclient https://review.opendev.org/c/openstack/python-neutronclient/+/886729 | 08:20 |
| opendevreview | Lajos Katona proposed openstack/python-neutronclient master: OSC: Remove FWAAS V2 calls to neutronclient https://review.opendev.org/c/openstack/python-neutronclient/+/880629 | 08:23 |
| opendevreview | Lajos Katona proposed openstack/python-neutronclient master: OSC: Remove SFC V2 calls to neutronclient https://review.opendev.org/c/openstack/python-neutronclient/+/887388 | 08:25 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3 router scheduler: reproduce scheduling issue https://review.opendev.org/c/openstack/neutron/+/893656 | 08:31 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: implement caching for Scheduler https://review.opendev.org/c/openstack/neutron/+/893657 | 08:31 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: try to keep routers at current chassis https://review.opendev.org/c/openstack/neutron/+/893658 | 08:31 |
| opendevreview | Felix Huettner proposed openstack/neutron master: ovn-l3: value the higher priorities when scheduling https://review.opendev.org/c/openstack/neutron/+/893659 | 08:31 |
| opendevreview | Rodolfo Alonso proposed openstack/ovn-octavia-provider master: Bump Neutron and neutron-lib versions https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893858 | 10:39 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/zed: DNM testing functional tests https://review.opendev.org/c/openstack/neutron/+/893859 | 10:41 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider master: [CI] Bump OVS_BRANCH in ovs/ovn source deploy jobs https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893860 | 10:44 |
| felixhuettner[m] | i currently see a lot of functional tests failing in the ci at the test test_add_tc_filter_policy with the message pyroute2.netlink.exceptions.NetlinkError: (95, 'Operation not supported') | 11:02 |
| felixhuettner[m] | is there anything known about that? | 11:02 |
| ralonsoh | felixhuettner[m], that is in stable branches | 11:08 |
| ralonsoh | I've sent a patch 30 mins ago to test it | 11:08 |
| ralonsoh | ^^^ | 11:08 |
| ralonsoh | --> https://review.opendev.org/c/openstack/neutron/+/893859 | 11:08 |
| felixhuettner[m] | ok, thank you | 11:11 |
| felixhuettner[m] | allthough i also see it here against master | 11:15 |
| felixhuettner[m] | https://zuul.opendev.org/t/openstack/build/0b4905d3b4bf41e9831b8556c8636a56 | 11:15 |
| ykarel | :q | 11:18 |
| ralonsoh | master too? ok | 11:21 |
| ralonsoh | I'll open a LP right now and check what is happening | 11:21 |
| felixhuettner[m] | ok, thanks | 11:27 |
| nkshirsa_ | hi ralonsoh o/ | 11:36 |
| ralonsoh | hi | 11:36 |
| nkshirsa_ | I just saw your comment on https://bugs.launchpad.net/neutron/+bug/1948466 .. so in the bug you've mentioned "ensure the check behaves correctly, and try another run with dhcp_options['subnet'] = {}" .. | 11:36 |
| nkshirsa_ | but when I do that (by hardcoding it to {} before the check, that unit test fails.. | 11:36 |
| ralonsoh | to be honest, I didn't write this description | 11:37 |
| nkshirsa_ | I also tried not hardcoding it in the code, and changing the unit test like https://pastebin.com/b2rhPsDB but same issue.. | 11:37 |
| ralonsoh | if that is needed (that I don't think so), then the test is changes | 11:38 |
| ralonsoh | changed* | 11:38 |
| ralonsoh | so it is needed to refactor the test | 11:38 |
| nkshirsa_ | but the patch handles empty directory so, how do we test the patch .. don't you think we need to test the patch itself .. | 11:38 |
| ralonsoh | ok, now I get that | 11:38 |
| nkshirsa_ | :-) | 11:38 |
| nkshirsa_ | i understand its a one liner and simple change, but if i actually hardcode it to {} , we get a failing unit test.. so .. how do we ensure the patch doesnt break anything in neutron.. | 11:39 |
| ralonsoh | the issue is that dhcp_options['subnet'] was before always a dictionary | 11:39 |
| ralonsoh | and now it could be None | 11:39 |
| ralonsoh | this is the rationale of the change in https://review.opendev.org/c/openstack/neutron/+/815280/2/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py#1969 | 11:39 |
| ralonsoh | that's all | 11:39 |
| nkshirsa_ | i understand. but the LP bug needs verification by testing those proposed packages and marking those flags to verified | 11:40 |
| nkshirsa_ | will you be able to do that? | 11:40 |
| ralonsoh | in Neutron we have verified that with the UTs | 11:40 |
| ralonsoh | what else do you expect? | 11:40 |
| nkshirsa_ | but.. none of the UTs are actually sending {} | 11:41 |
| nkshirsa_ | so how is that patch being actually tested and verified.. | 11:41 |
| ralonsoh | ok in that case, if you feel the UT coverage is not enough, please feel free to send a UT | 11:42 |
| nkshirsa_ | after the patch, the if condition will handle None as well as {} , so handling the empty directory is the new thing in the patch, right? | 11:42 |
| nkshirsa_ | ralonsoh, i am OK with any idea you have to mark the proposed package as verified. | 11:42 |
| ralonsoh | so please, send a patch adding this UT | 11:43 |
| nkshirsa_ | its not necessary to send a new UT if you are sure and can show some results on the LP bug that will get the packages to focal-updates , from proposed. the bug is actually blocked on the reporter to test and change those flags to verified | 11:43 |
| nkshirsa_ | but if you like, i can try to send a new UT too.. but when i changed the existing UT to https://pastebin.com/b2rhPsDB it does not pass.. i am not sure how to actually test with empty directory from the UT if this is incorrect | 11:44 |
| ralonsoh | I can't show you any result without a UT. The change was trivial although a UT was missing | 11:44 |
| nkshirsa_ | yes but what is incorrect about this UT - i am attempting to send an empty directory in it | 11:45 |
| nkshirsa_ | https://pastebin.com/b2rhPsDB | 11:45 |
| ralonsoh | again, if the conditions change, the test too | 11:45 |
| ralonsoh | so please, propose a UT | 11:45 |
| ralonsoh | if not, I'll do it but on Friday | 11:46 |
| ralonsoh | not today | 11:46 |
| nkshirsa_ | ack thank you | 11:46 |
| *** bauzas_ is now known as bauzas | 12:01 | |
| opendevreview | Rodolfo Alonso proposed openstack/ovn-octavia-provider master: Bump Neutron and neutron-lib versions https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893858 | 12:56 |
| haleyb | ralonsoh: i had sent a test patch for the zed gate last night too, https://review.opendev.org/c/openstack/neutron/+/893807 for the tc failure, of course it passed, but must be a race. and i see you beat me to filing the bug :) | 12:57 |
| ralonsoh | haleyb, this is also failing in master too | 12:58 |
| ralonsoh | I'm going to send a patch to check the interface qdisc before adding a new one | 12:58 |
| ralonsoh | I don't know why that changed | 12:58 |
| haleyb | that explains why i didn't find a recent change that needed a backport | 12:58 |
| haleyb | ack, i'll look out for any patches | 13:00 |
| *** bauzas_ is now known as bauzas | 13:07 | |
| mtomaska1 | ralonsoh: see my response, let me know if you are OK with it. https://review.opendev.org/c/openstack/neutron/+/890986 | 13:26 |
| ykarel | haleyb, ralonsoh, seems that FT failure is triggered by recent kernel updates in ubuntu focal and jammy | 13:28 |
| ykarel | the failure looks consistent | 13:28 |
| ralonsoh | mtomaska1, I have it open, I'll check it later | 13:28 |
| ralonsoh | ykarel, yes, this change adds a default qdisc in the interfaces | 13:29 |
| ralonsoh | I'm going to push a patch now | 13:29 |
| ykarel | ralonsoh, ack thanks | 13:29 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: DNM FT testing "test_add_tc_filter_policy" https://review.opendev.org/c/openstack/neutron/+/893917 | 13:29 |
| opendevreview | Merged openstack/ovn-octavia-provider master: [CI] Bump OVS_BRANCH in ovs/ovn source deploy jobs https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893860 | 13:36 |
| opendevreview | Arnaud Morin proposed openstack/neutron master: Set DVR qr-xyz interfaces DOWN on backup node https://review.opendev.org/c/openstack/neutron/+/869741 | 14:01 |
| opendevreview | Arnaud Morin proposed openstack/neutron master: Add a new option to enable signals https://review.opendev.org/c/openstack/neutron/+/884711 | 14:06 |
| ralonsoh | mtomaska, ping jlibosvar to make a last review (and merge it) | 14:24 |
| mtomaska | ralonsoh thanks! | 14:30 |
| opendevreview | Miro Tomaska proposed openstack/neutron stable/2023.1: OVN Metadata handle process exceptions https://review.opendev.org/c/openstack/neutron/+/893775 | 14:36 |
| opendevreview | Miro Tomaska proposed openstack/neutron stable/zed: OVN Metadata handle process exceptions https://review.opendev.org/c/openstack/neutron/+/893776 | 14:36 |
| opendevreview | Miro Tomaska proposed openstack/neutron stable/yoga: OVN Metadata handle process exceptions https://review.opendev.org/c/openstack/neutron/+/893777 | 14:36 |
| opendevreview | Miro Tomaska proposed openstack/neutron stable/xena: OVN Metadata handle process exceptions https://review.opendev.org/c/openstack/neutron/+/893778 | 14:36 |
| opendevreview | Miro Tomaska proposed openstack/neutron stable/wallaby: OVN Metadata handle process exceptions https://review.opendev.org/c/openstack/neutron/+/893779 | 14:37 |
| opendevreview | Merged openstack/ovn-octavia-provider master: Bump Neutron and neutron-lib versions https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893858 | 15:49 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider master: Cover the use case of a member non existing https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893839 | 15:54 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider master: Cover the use case of a member non existing https://review.opendev.org/c/openstack/ovn-octavia-provider/+/893839 | 15:55 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Call the "tc qdisc" command for ingress qdisc without parent https://review.opendev.org/c/openstack/neutron/+/893962 | 16:11 |
| ralonsoh | haleyb, ^^ | 16:11 |
| ralonsoh | I'll need to leave soon today but I'll check the result later this evening | 16:12 |
| haleyb | ralonsoh: ack, will take a look, thanks! | 16:17 |
| opendevreview | Jakub Libosvar proposed openstack/neutron master: WIP: Remove unused things from the OVN metadata agent https://review.opendev.org/c/openstack/neutron/+/893966 | 16:20 |
| opendevreview | Fiorella Yanac proposed openstack/neutron-tempest-plugin master: Add username in resource_setup https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/893967 | 16:22 |
| *** ykarel is now known as ykarel|away | 17:29 | |
| ralonsoh | haleyb, please check my reply. I'm going offline now | 18:55 |
| *** ralonsoh is now known as ralonsoh_away | 18:55 | |
| opendevreview | Ghanshyam proposed openstack/networking-bagpipe master: Fix bindep.txt for python 3.11 job(Debian Bookworm) https://review.opendev.org/c/openstack/networking-bagpipe/+/893987 | 22:02 |
| opendevreview | Ghanshyam proposed openstack/tap-as-a-service master: Fix bindep.txt for python 3.11 job(Debian Bookworm) https://review.opendev.org/c/openstack/tap-as-a-service/+/893989 | 22:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!