| opendevreview | ZhouHeng proposed openstack/neutron master: DNM: test remove some rpc message https://review.opendev.org/c/openstack/neutron/+/894891 | 02:52 |
|---|---|---|
| opendevreview | Merged openstack/ovn-bgp-agent master: Update master for stable/2023.2 https://review.opendev.org/c/openstack/ovn-bgp-agent/+/895074 | 05:58 |
| opendevreview | Merged openstack/ovn-bgp-agent stable/2023.2: Update .gitreview for stable/2023.2 https://review.opendev.org/c/openstack/ovn-bgp-agent/+/895072 | 05:58 |
| opendevreview | Merged openstack/ovn-bgp-agent stable/2023.2: Update TOX_CONSTRAINTS_FILE for stable/2023.2 https://review.opendev.org/c/openstack/ovn-bgp-agent/+/895073 | 05:58 |
| *** ykarel|away is now known as ykarel | 06:33 | |
| opendevreview | ZhouHeng proposed openstack/neutron master: DNM: test remove some rpc message https://review.opendev.org/c/openstack/neutron/+/894891 | 06:47 |
| opendevreview | Merged openstack/neutron-vpnaas-dashboard stable/2023.2: Update .gitreview for stable/2023.2 https://review.opendev.org/c/openstack/neutron-vpnaas-dashboard/+/895078 | 07:38 |
| opendevreview | Merged openstack/neutron-vpnaas-dashboard stable/2023.2: Update TOX_CONSTRAINTS_FILE for stable/2023.2 https://review.opendev.org/c/openstack/neutron-vpnaas-dashboard/+/895079 | 07:38 |
| ralonsoh | haleyb, btw I forgot to talk about the next PTG, that will be in a month. I'll open an etherpad to start adding topics. I'll make it public next week, during the team meeting | 08:26 |
| ralonsoh | or maybe sending a mail, that will be nice too | 08:26 |
| ralonsoh | haleyb, I've created the etherpad and updated the Neutron agenda: https://wiki.openstack.org/wiki/Network/Meetings | 08:32 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Revert "[OVN][Trunk] Add port binding info on subport when parent is bound" https://review.opendev.org/c/openstack/neutron/+/893447 | 08:54 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/2023.2: Revert "[OVN][Trunk] Add port binding info on subport when parent is bound" https://review.opendev.org/c/openstack/neutron/+/895899 | 09:05 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/2023.1: Revert "[OVN][Trunk] Add port binding info on subport when parent is bound" https://review.opendev.org/c/openstack/neutron/+/894791 | 09:06 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/zed: Revert "[OVN][Trunk] Add port binding info on subport when parent is bound" https://review.opendev.org/c/openstack/neutron/+/894792 | 09:06 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/yoga: Revert "[OVN][Trunk] Add port binding info on subport when parent is bound" https://review.opendev.org/c/openstack/neutron/+/894793 | 09:06 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/xena: Revert "[OVN][Trunk] Add port binding info on subport when parent is bound" https://review.opendev.org/c/openstack/neutron/+/894794 | 09:07 |
| opendevreview | Lucas Alvares Gomes proposed openstack/neutron master: [OVN] External ports scheduling (WIP) https://review.opendev.org/c/openstack/neutron/+/894767 | 09:20 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: WIP remove W0105 flake8 error https://review.opendev.org/c/openstack/neutron/+/895922 | 09:32 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Add a "port" child table "porthardwareoffloadtype" https://review.opendev.org/c/openstack/neutron/+/882832 | 09:32 |
| opendevreview | liuyulong proposed openstack/neutron master: Add basical functionalities for metadata path extension https://review.opendev.org/c/openstack/neutron/+/881535 | 09:50 |
| opendevreview | liuyulong proposed openstack/neutron master: Add metadata path extension openflows https://review.opendev.org/c/openstack/neutron/+/888097 | 09:50 |
| opendevreview | liuyulong proposed openstack/neutron master: Fullstack case for metadata path https://review.opendev.org/c/openstack/neutron/+/888098 | 09:50 |
| ralonsoh | slaweq, do you know what could be failing https://review.opendev.org/c/openstack/neutron/+/882832/? In particular the pep8 job | 12:49 |
| ralonsoh | I've pushed https://review.opendev.org/c/openstack/neutron/+/895922/ under this other patch | 12:49 |
| ralonsoh | and is still failing | 12:49 |
| slaweq | ralonsoh I will check it in a minute | 12:51 |
| frickler | the latter failure seems just an unrelated timeout? | 13:16 |
| ralonsoh | no, the pep8 | 13:21 |
| ralonsoh | I don't know why is failing | 13:21 |
| haleyb | ralonsoh: pep8 is complaining on this | 13:23 |
| haleyb | neutron/db/migration/alembic_migrations/versions/kilo_initial.py:39:0: W0105: [35mString statement has no effect[0m ([35mpointless-string-statement[0m) | 13:23 |
| haleyb | which makes no sense to me yet | 13:23 |
| ralonsoh | yes but I've pushed a patch under this one removing this W0105 | 13:23 |
| slaweq | haleyb++ exactly, I was going to write the same now :) | 13:23 |
| slaweq | thx | 13:23 |
| haleyb | there's a lot of expand code with the same comment | 13:23 |
| ralonsoh | I've pushed a patch under this one | 13:24 |
| ralonsoh | https://review.opendev.org/c/openstack/neutron/+/895922/ | 13:24 |
| ralonsoh | so this error should not be happening | 13:24 |
| haleyb | right, i guess we should fix if it's just one occurrence, just odd | 13:25 |
| haleyb | ralonsoh: and thanks for the reminder about the etherpad, will put on my list | 13:31 |
| ralonsoh | yw | 13:31 |
| ralonsoh | haleyb, I've created a link | 13:31 |
| ralonsoh | this is in the Neutron meeting agenda | 13:31 |
| ralonsoh | https://etherpad.opendev.org/p/neutron-caracal-ptg | 13:32 |
| haleyb | ralonsoh: so there are two fixes for that pep8 error, which now seems to happen for most files in the db migration dir for me - either move the docstring above the imports, or make it a # comment | 14:04 |
| ralonsoh | or avoid this pylint warning, but seems that is not working | 14:05 |
| ralonsoh | if we do the first, we'll need to change all db migrations and the script creating the migration python file | 14:06 |
| haleyb | i thought your patch that ignored worked for now? | 14:06 |
| ralonsoh | nope | 14:06 |
| ralonsoh | https://review.opendev.org/c/openstack/neutron/+/882832/ | 14:07 |
| ralonsoh | ^^ this is in top of the WIP patch removing the flake8 error | 14:07 |
| ralonsoh | or warning | 14:07 |
| haleyb | https://review.opendev.org/c/openstack/neutron/+/895922 worked i mean | 14:08 |
| haleyb | there's over 250 migration files :( | 14:08 |
| ralonsoh | yes and any other patch in the CI | 14:09 |
| ralonsoh | I don't know why my patch is triggering it | 14:09 |
| ralonsoh | considering that my patch is not touching this file | 14:09 |
| haleyb | actually there is maybe 125, my grep found both """ | 14:10 |
| haleyb | pylint runs on the whole tree except for test in the gate | 14:10 |
| ralonsoh | I'm testing locally the new pylint version | 14:10 |
| ralonsoh | but takes 6 mins each test | 14:10 |
| haleyb | something must have just changed, when i rebased master it started failing here | 14:11 |
| opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: Doc: add documentation for usage and flow examples for OVS https://review.opendev.org/c/openstack/tap-as-a-service/+/828382 | 14:11 |
| opendevreview | Miro Tomaska proposed openstack/neutron master: OVN Metadata handle process execeptions https://review.opendev.org/c/openstack/neutron/+/890986 | 14:50 |
| haleyb | ralonsoh: i think i have another fix - tweak .pylintrc to disable the warning (for now) until we have time to fix all occurences. | 15:05 |
| ralonsoh | haleyb, pylint==2.17.5 seems to fix this issue. I'll update the binary in the pep8 requirements, in tox.ini | 15:14 |
| ralonsoh | haleyb, no, false alarm, it took even more time | 15:15 |
| ralonsoh | ok, let's skip this warning | 15:15 |
| haleyb | ack. since the warning has been enabled for almost 10 years we probably should re-enable eventually. i'm on-call this weekend so might have some un-interrupted cycles to fix 100 files... | 15:19 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Add "pointless-string-statement" W0105 to the pylint disable list https://review.opendev.org/c/openstack/neutron/+/895922 | 15:23 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Add a "port" child table "porthardwareoffloadtype" https://review.opendev.org/c/openstack/neutron/+/882832 | 15:23 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Add the "abortable" flag to the ``CallbacksManager`` events https://review.opendev.org/c/openstack/neutron-lib/+/895940 | 15:30 |
| ralonsoh | ^^ your idea (just the n-lib part, that is the most complex): if a callback fails (in this case AFTER_INIT) we can force a CallbackFailure exception | 15:32 |
| ralonsoh | lucasagomes, | 15:32 |
| ralonsoh | I'll push now the Neutron code, that is easier | 15:32 |
| lucasagomes | checking | 15:33 |
| lucasagomes | ah nice! I see where it's going | 15:33 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Make ``OVNMechanismDriver.post_fork_initialize`` callback abortable https://review.opendev.org/c/openstack/neutron/+/895946 | 16:10 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Add the "abortable" flag to the ``CallbacksManager`` events https://review.opendev.org/c/openstack/neutron-lib/+/895940 | 16:21 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Add the "abortable" flag to the ``CallbacksManager`` events https://review.opendev.org/c/openstack/neutron-lib/+/895940 | 16:36 |
| frickler | haleyb: that's an interesting find for the MTU issue. maybe test with snat disabled to see if that works better. I've always been meaning to do a test with IPv6, which only allows fragmentation on the source host, too | 16:55 |
| haleyb | frickler: yeah, it just appeared on the ovs-discuss ML today, although i do see you didn't see any icmp messages in your testing | 17:32 |
| *** jlibosva is now known as Guest772 | 18:14 | |
| opendevreview | Miguel Lavalle proposed openstack/neutron master: [PoC][DNM] Router flavors and service type for OVN https://review.opendev.org/c/openstack/neutron/+/883988 | 18:42 |
| opendevreview | Brian Haley proposed openstack/neutron master: Fix pointless-string-statement pylint warning https://review.opendev.org/c/openstack/neutron/+/895975 | 19:54 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!