Friday, 2023-10-06

opendevreviewLuis Tomas Bolivar proposed openstack/neutron master: Add support for FDB aging  https://review.opendev.org/c/openstack/neutron/+/89333305:39
opendevreviewSlawek Kaplonski proposed openstack/neutron-tempest-plugin master: New basic API tests for the default SG rules templates CRUDs  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/88355306:00
opendevreviewRodolfo Alonso proposed openstack/neutron master: [OVN] Populate the "router.distributed" flag in ML2/OVN  https://review.opendev.org/c/openstack/neutron/+/88699207:28
opendevreviewRodolfo Alonso proposed openstack/neutron master: [OVN] Set the Neutron port status based on "lsp.up" and "lsp.enabled"  https://review.opendev.org/c/openstack/neutron/+/89693907:33
ralonsohhi folks, please check these patches to fix the CI:07:33
ralonsoh* https://review.opendev.org/c/openstack/neutron/+/89743807:33
ralonsoh* https://review.opendev.org/c/openstack/neutron/+/89744007:33
ralonsoh* https://review.opendev.org/c/openstack/neutron/+/89743907:33
ralonsohthanks!07:33
lajoskatonaralonsoh: checking07:39
opendevreviewSlawek Kaplonski proposed openstack/neutron master: [S-RBAC] Add service role in neutron policy  https://review.opendev.org/c/openstack/neutron/+/88672407:55
opendevreviewRodolfo Alonso proposed openstack/neutron master: Drop unused tables from the Neutron database  https://review.opendev.org/c/openstack/neutron/+/89747207:59
ralonsohslaweq, hi! I know the patch is very big, but mostly repetitive: https://review.opendev.org/c/openstack/neutron/+/89650908:00
ralonsohall new policies are mimicking the existing ones (create, modify, delete)08:01
ralonsohwith the _tags sufix08:01
slaweqthx ralonsoh I commented it already08:11
ralonsohslaweq, thanks!08:11
slaweqmostly nits but I gave -1 due to comments in the neutron/conf/policies/subnet.py file08:11
ralonsohI'll check it right now08:12
opendevreviewRodolfo Alonso proposed openstack/neutron master: Drop unused tables from the Neutron database  https://review.opendev.org/c/openstack/neutron/+/89747208:17
opendevreviewSlawek Kaplonski proposed openstack/neutron master: Add dhcpagentscheduler API extension to the ML2/OVN extensions  https://review.opendev.org/c/openstack/neutron/+/89752809:02
ykarelralonsoh, can you restore https://review.opendev.org/c/openstack/neutron/+/89746209:02
ykarelsorry ignore09:02
ralonsohis that affecting 2023.1 too?09:03
ralonsohahh ok09:03
ralonsohI pushed that for 2023.209:03
ykareli meant https://review.opendev.org/c/openstack/neutron/+/89744009:03
ykarelbut it's already there09:03
slaweqralonsoh ykarel lajoskatona when You will have few minutes, please check https://review.opendev.org/c/openstack/neutron/+/897528 - it's small patch to review :)09:04
ralonsohsure09:04
opendevreviewyatin proposed openstack/neutron-tempest-plugin master: Include legacy_ebtables for LinuxBridge Jammy jobs  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/89752909:11
ykarelralonsoh, slaweq ^ also needed09:11
opendevreviewElvira García Ruiz proposed openstack/neutron stable/yoga: [OVN] Fix rate and burst for stateless security groups  https://review.opendev.org/c/openstack/neutron/+/89566309:12
opendevreviewElvira García Ruiz proposed openstack/neutron stable/yoga: Use safer methods to get security groups on security group logging  https://review.opendev.org/c/openstack/neutron/+/89753009:12
ykarelslaweq, ack09:12
ralonsohright!09:12
ralonsohslaweq, about https://review.opendev.org/c/openstack/neutron/+/897528, should we backport this patch?09:13
ralonsohI think so09:13
opendevreviewElvira García Ruiz proposed openstack/neutron stable/xena: [OVN] Fix rate and burst for stateless security groups  https://review.opendev.org/c/openstack/neutron/+/89578309:15
opendevreviewElvira García Ruiz proposed openstack/neutron stable/xena: Use safer methods to get security groups on security group logging  https://review.opendev.org/c/openstack/neutron/+/89753109:15
opendevreviewElvira García Ruiz proposed openstack/neutron stable/wallaby: [OVN] Fix rate and burst for stateless security groups  https://review.opendev.org/c/openstack/neutron/+/89578509:19
opendevreviewElvira García Ruiz proposed openstack/neutron stable/wallaby: Use safer methods to get security groups on security group logging  https://review.opendev.org/c/openstack/neutron/+/89753209:19
slaweqralonsoh yes, I will propose backports quickly once it will be merged in master09:35
ralonsohperfect09:35
opendevreviewRodolfo Alonso proposed openstack/neutron master: Add policy enforcer for "tags" service plugin  https://review.opendev.org/c/openstack/neutron/+/89650909:56
opendevreviewLajos Katona proposed openstack/neutron-tempest-plugin master: Tap Mirror API tests  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/88600410:07
*** gryf is now known as Guest236010:12
*** Guest2360 is now known as _gryf10:13
opendevreviewRodolfo Alonso proposed openstack/neutron master: [RBAC] Update the subnet policies  https://review.opendev.org/c/openstack/neutron/+/89754010:50
slaweqralonsoh or lajoskatona can You +W https://review.opendev.org/c/openstack/neutron/+/886724 maybe? Zuul is fine with it finally and we are at the beginning of the cycle so I think it's good time to go with this10:59
ralonsohsure11:00
ralonsohsone11:00
ralonsohdone11:00
opendevreviewRodolfo Alonso proposed openstack/neutron master: Add policy enforcer for "tags" service plugin  https://review.opendev.org/c/openstack/neutron/+/89650911:05
lajoskatonaslaweq: ralonsoh: :-) I was slow11:06
opendevreviewRodolfo Alonso proposed openstack/neutron master: [fullstack] Unify ``TestMTUScenarios`` tests  https://review.opendev.org/c/openstack/neutron/+/89754211:39
opendevreviewRodolfo Alonso proposed openstack/neutron master: [fullstack] Unify ``TestQoSPolicyIsDefault`` tests  https://review.opendev.org/c/openstack/neutron/+/89754411:47
opendevreviewRodolfo Alonso proposed openstack/neutron master: Drop unused tables from the Neutron database  https://review.opendev.org/c/openstack/neutron/+/89747212:03
opendevreviewMerged openstack/neutron master: Fix the ``log.setup`` method call with "fix_eventlet=False"  https://review.opendev.org/c/openstack/neutron/+/89733212:48
mnaserralonsoh: happy friday -- i see you've commented on https://bugs.launchpad.net/neutron/+bug/1889388 at some point, i am most def running into this, do you have any hints that i could use to try and dig into this more?  i _feel_ like i'm at a wall right now for this issue13:05
opendevreviewAlban PRATS proposed openstack/neutron master: Enabling routing of routed subnets through snat.  https://review.opendev.org/c/openstack/neutron/+/89045913:10
ralonsohmnaser, I'll check it but this bug is 3 years old, I don't know if that is valid now13:12
ralonsohi'll try to reproduce it13:13
mnaserralonsoh: i have an environment here that i have the same exact problem with.. could be some other 'form' of the same bug.. :( i havent tried to reproduce outside of that env but im fairly certain its an ovn/neutron thing13:13
ralonsohmnaser, OVN will use the first subnet to provide the GW13:19
ralonsohthat means 1.1.1.0/2413:19
ralonsohhow can you have a FIP in 2.2.2.0/24?13:20
opendevreviewAlban PRATS proposed openstack/neutron master: Enabling routing of routed subnets through snat.  https://review.opendev.org/c/openstack/neutron/+/89045913:20
mnaserralonsoh: the external provider network has two subnets, and you can get fips in both subnets13:20
ralonsohyes but that won't work13:20
ralonsohbecause the GW IP is from the first subnet13:21
ralonsohso far, OVN routers provide one single GW IP and access to this CIDR only13:21
mnaserit did in ml2/ovs world, and im not sure how we'd work around it then, that seems like a pretty severe limitation in large scale envs where you hae a big public network13:21
mnaseralso the fip actually works from everywhere13:22
mnaserexcept from hosts on teh same system13:22
mnaser(i agree with your theory fwiw)13:22
ralonsoh"my theory"?13:22
mnaserlike it shouldnt work because the gw is not the same as the fip13:22
mnaserbut it does for everything except for system on the same host13:23
mnaserin ml2/ovs, we would assign a network to a virtual router and then any FIP from any subnet worked13:24
mnaserthis is still the case in ml2/ovn right now too, but with the exception that if they're on the same host, it seems to not be too happy about it13:24
ralonsohbecause the traffic going outside a node is treated, in the other chassis, as external traffic13:26
ralonsohin the same chassis there are no rules to nat from 1.1.1.0/24 to 2.2.2.0/2413:27
mnaseris that the same as https://bugs.launchpad.net/neutron/+bug/2035281 ?13:27
haleybralonsoh, slaweq and other cores: i need to take today off and most of next week, in case you ping me and i don't respond. I'll be around next Tuesday though.13:27
ralonsohI don't know, the case is different13:27
*** haleyb is now known as haleyb|away13:27
mnaser(i've dredged the heck out of ovn bugs for this issue)13:27
racostamnaser, are you using chassis as gq? I mean, to attach an instance to the external network, this network needs to be created on the host (in the case of OVN, mapped to br-ext and the host needs to be gw "chassis-as-gw"). Otherwise you would see log messages like: "Refusing to bind port aaaaaaaa-aaaa on host HOST-1 due to the OVN chassis bridge mapping physical networks [] not supporting physical network: provider"13:28
slaweqhaleyb thx for the heads up :)13:28
mnaserracosta: we avoid `enable-chassis-as-gw` on compute nodes since we dont want them serving centralized traffic, but users are able to plug directly into the external network (cause we do add the mapping)13:30
opendevreviewyatin proposed openstack/neutron-tempest-plugin master: Add playbooks to irrelevant-files  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/89755213:35
ralonsohmnaser, when the GW port is created, the port creation process follow the same rules as any other13:35
ralonsohthat means if you have several IPv4 subnets, the IPAM module will assign only one of these IPs13:36
ralonsoha FIP must be in the same CIDR of the GW port because it needs to have L2 communication to access to this IP13:37
opendevreviewMerged openstack/neutron master: [S-RBAC] Add service role in neutron policy  https://review.opendev.org/c/openstack/neutron/+/88672413:37
ralonsohif that is working between several CIDRs, is by coincidence13:37
ralonsohand if that is working in all cases in ovs and not in ovn, we can't fix that13:37
ralonsohthat is not an expected behaviour13:38
racostaI agree with ralonsoh, you need a HW Vtep to route these two different networks via L3 (e.g. border leaves switches).13:47
mnaserwell i have that already, both these networks have a def gw, but yeah, i see how the outbound would come from the 'wrong' ip13:48
mnaserralonsoh: shouldn't we deny attaching a fip if the router isnt part of a external network CIDR?13:48
ralonsohyes, that could be something to propose because doesn't make sense13:48
mnaserralonsoh: https://paste.opendev.org/show/bUsXALn2ME7oaMp9LlFL/ so this is my state13:51
mnaserso fip in subnet .56.158 when router is .83.3713:52
racostawait, we are using different CIDR between router and FIP (but both are on the same physical network - VLAN). This works and makes sense because the external network domain is the VLAN.13:54
mnaseryeah13:54
racostaPlease don't propose this FIP CIDR restriction ralonsoh because what happens when a subnet range of IPs ends up in a external subnet? you create another one and FIP can derive of that other network.14:00
ralonsohok, but the OVN won't work (at least in the same host)14:00
ralonsohin OVS the kernel could route these packets14:01
ralonsohin OVN there are no OF rules to nat subnet1 to subnet2 of this external network14:01
mnaserhttps://paste.opendev.org/show/bxMRYkmcCvkARtYx7KnS/ it seems like natting is actually happening14:03
ralonsohbetween what CIDRs?14:03
ralonsohnot the external subnets in the same host14:03
ralonsohthis is exactly the description you updated in the LP bug14:04
mnasercause ICMP works btw, but TCP doesn't14:04
mnaseri think my suspicion is that the traffic is coming back from the virtual router _directly_ to the vm rather than being sent back to the gateway14:09
mnaserand if it was sent to the gateway, it'd be fine, but its almsot like its short-circuiting and sending replies straight to the vm, instead of actually sending the reply to the gateway14:09
mnasercause you can see packet goes towards hw gateway (fa:61:25:a2:5a:71) but the reply comes from fa:16:3e:ff:88:8a (virtual router)14:10
mnaserso there _is_ traffic flowing, its not nothing, but i think because of that 'mismatch' tcp/stateful traffic isnt working, but normal icmp is working cause there's no state14:11
mnaserif ovn was to be told to NOT short-circuit this traffic and send it back to its gateway, back to the hardware gateway, and then back to the vm, it would work just fine (but then it wouldn't be very efficient but it always works)14:11
mnaserim sorry if the terminology is all wrong here, im slowly working on my ovn chops :(14:12
ralonsohI'll open a bug to core OVN. But traffic to IPs in the same chassis won't go outside14:14
ralonsohwhat you are asking is to have some kind of nating between external network subnets14:14
ralonsohor some kind of ip forwarding14:15
mnaserralonsoh: in this case they are going outside so maybe that is the bug, bc if i tcpdump br-ex, or the external provider interface, im seeing the traffic going to 38.129.56.15814:19
mnaserso egress traffic actually goes to provider network, but return traffic is coming directly through ovn14:20
ykarelslaweq, a small patch when you get chance https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/89755214:54
ykarelralonsoh, cyclic dep b/w https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/897529 and https://review.opendev.org/c/openstack/neutron/+/89744015:03
ralonsohykarel, join both in one15:04
ralonsohah no15:04
ralonsohsorry15:04
ralonsohthis is not the same project15:04
ralonsohykarel, ok, I'm going to disable LB job in neutron15:05
ralonsohthen merge the neutron patch15:05
ralonsohand then n-t-p15:05
ykarelokk15:07
opendevreviewRodolfo Alonso proposed openstack/neutron stable/2023.1: [stable-only] Disable "neutron-tempest-plugin-jobs-2023-1" temporarily  https://review.opendev.org/c/openstack/neutron/+/89756515:10
ralonsohykarel, ^ once we have the Neutron patch merged, I'll revert this patch15:10
ralonsohI'll fast approve it15:10
ykarelokk15:11
opendevreviewRodolfo Alonso proposed openstack/neutron stable/2023.1: Add "jammy" distribution release to the legacy ebtables installation  https://review.opendev.org/c/openstack/neutron/+/89744015:15
opendevreviewRodolfo Alonso proposed openstack/neutron master: Add a new extension "security-groups-rules-belongs-to-default-sg"  https://review.opendev.org/c/openstack/neutron/+/88390715:36
opendevreviewRodolfo Alonso proposed openstack/neutron master: DNM WIP Remove network RBACs from subnet view  https://review.opendev.org/c/openstack/neutron/+/89757816:59
opendevreviewRodolfo Alonso proposed openstack/neutron stable/2023.1: [stable-only] Disable "neutron-tempest-plugin-jobs-2023-1" temporarily  https://review.opendev.org/c/openstack/neutron/+/89756517:02
opendevreviewRodolfo Alonso proposed openstack/neutron stable/2023.1: [stable-only] Disable "neutron-tempest-plugin-jobs-2023-1" temporarily  https://review.opendev.org/c/openstack/neutron/+/89756519:30
opendevreviewRodolfo Alonso proposed openstack/neutron stable/2023.1: Add "jammy" distribution release to the legacy ebtables installation  https://review.opendev.org/c/openstack/neutron/+/89744022:23
opendevreviewMerged openstack/neutron stable/2023.1: [stable-only] Disable "neutron-tempest-plugin-jobs-2023-1" temporarily  https://review.opendev.org/c/openstack/neutron/+/89756523:44

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!