| opendevreview | yatin proposed openstack/neutron master: Make unit tests compatible with neutron-lib-3.9.0 https://review.opendev.org/c/openstack/neutron/+/901430 | 07:04 |
|---|---|---|
| ykarel | lajoskatona, bcafarel please check https://review.opendev.org/c/openstack/neutron/+/901430 | 09:30 |
| ykarel | required to clear gates | 09:30 |
| lajoskatona | ykrarel: done, thanks | 09:34 |
| opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up remaining python 2.7 support https://review.opendev.org/c/openstack/os-vif/+/896598 | 09:36 |
| opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up remaining python 2.7 support https://review.opendev.org/c/openstack/os-vif/+/896598 | 09:36 |
| bcafarel | ykarel: you have my +1 at least :) (I only have core on stable) | 09:43 |
| opendevreview | Jakub Skunda proposed openstack/neutron-tempest-plugin master: Remove test duplications between tempest and n-t-p plugin https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/901051 | 10:39 |
| ykarel | lajoskatona, can you trigger +W too https://review.opendev.org/c/openstack/neutron/+/901430 | 10:53 |
| opendevreview | Lajos Katona proposed openstack/neutron-lib master: Tap mirror API def and API ref https://review.opendev.org/c/openstack/neutron-lib/+/885354 | 12:45 |
| opendevreview | Lajos Katona proposed openstack/neutron-lib master: Add Tap Mirror exception https://review.opendev.org/c/openstack/neutron-lib/+/895603 | 12:45 |
| opendevreview | Merged openstack/neutron master: Forbid updating vnic type on a bound port https://review.opendev.org/c/openstack/neutron/+/892815 | 15:25 |
| opendevreview | Merged openstack/neutron master: Update OVN db sync code log messages https://review.opendev.org/c/openstack/neutron/+/890832 | 15:25 |
| *** dmellado2 is now known as dmellado | 15:58 | |
| andreykurilin | hi folks! Can someone help me understand whether I'm doing something wrong or share the best practice for overriding policies? | 17:17 |
| andreykurilin | I deployed Neutron via Kolla-Ansible and defined policy.yaml file with the following content `{"delete_port": "rule:admin_owner_or_network_owner OR role:Something"}`. | 17:17 |
| andreykurilin | This overridden rule works as expected, but I see `Policies ['delete_port'] reference a rule that is not defined.` warning message while restarting neutron. | 17:18 |
| andreykurilin | * while restarting neutron-server service | 17:18 |
| andreykurilin | After digging into the root of this warning, I found that it comes from neutron-lib policy enforcer as it does not have neutron's rule definitions, and as a result, it does not know anything about default value for 'admin_owner_or_network_owner' rule. | 17:19 |
| haleyb | andreykurilin: did you mean "admin_or_network_owner"? is it just a typo? | 17:45 |
| haleyb | oh, it's a new string | 17:46 |
| haleyb | slaweq: ^^ ? | 17:47 |
| andreykurilin | haleyb: https://github.com/openstack/neutron/blob/master/neutron/conf/policies/base.py#L109 this one. the actual policy.yaml which I'm using is more complex, the shared one is just simplified version | 17:49 |
| haleyb | right, i originally only looked in neutron-lib | 17:51 |
| andreykurilin | https://xsnippet.org/NoWaXT53 <- the script I used to load policies and ensure that "neutron's" enforcer is happy | 17:53 |
| andreykurilin | https://xsnippet.org/5xSMLrLN <- the output. most of overridden policies do not use any new custom rules, just use the existing | 17:56 |
| andreykurilin | Forgot to mention: I'm using 2023.1 release (neutron-lib==3.4.1, oslo.policy==4.1.1, neutron is from stable/2023.1 branch) | 17:58 |
| haleyb | andreykurilin: i would still defer to slaweq, especially since it's unclear to me if this rule name has been deprecated based on neutron/conf/policies/port.py | 18:03 |
| andreykurilin | haleyb: I could be wrong, but I do not see any deprecation for delete_port policy itself. delete_port has deprecated default value. As far as I understand, as soon as deprecated value is not specified, no warnings are expected. | 18:17 |
| opendevreview | Brian Haley proposed openstack/neutron master: Remove ovs_integration_bridge configuration option https://review.opendev.org/c/openstack/neutron/+/901474 | 18:29 |
| opendevreview | Brian Haley proposed openstack/neutron master: Remove agent veth_mtu configuration option https://review.opendev.org/c/openstack/neutron/+/901476 | 18:36 |
| opendevreview | Brian Haley proposed openstack/neutron master: Remove vnic_type_blacklist deprecated name https://review.opendev.org/c/openstack/neutron/+/901478 | 18:40 |
| opendevreview | Merged openstack/neutron master: Make unit tests compatible with neutron-lib-3.9.0 https://review.opendev.org/c/openstack/neutron/+/901430 | 19:13 |
| opendevreview | Lajos Katona proposed openstack/neutron master: FIP QoS: check policy id before blindly updating FIP https://review.opendev.org/c/openstack/neutron/+/899469 | 20:00 |
| lajoskatona | haleyb: Hi, could you please check my super tiny patch when you have some free time: https://review.opendev.org/c/openstack/neutron/+/899469 (funny background: I found the issue on stackoverflow ;)) | 20:01 |
| haleyb | lajoskatona: is there any way to add a test? :) | 20:13 |
| opendevreview | Harald Jensås proposed openstack/neutron master: [OVN] DB sync host/physnet - filter on agent_type https://review.opendev.org/c/openstack/neutron/+/899077 | 20:16 |
| opendevreview | Brian Haley proposed openstack/neutron master: Remove ovn_l3_mode configuration option https://review.opendev.org/c/openstack/neutron/+/901505 | 20:20 |
| opendevreview | Brian Haley proposed openstack/neutron master: Remove segment_mtu configuration option https://review.opendev.org/c/openstack/neutron/+/901506 | 20:30 |
| lajoskatona | haleyb: I think I checked that and said that I cant add ,but I can check tomorrow again because it was long time ago and perhaps I mess it with something else.... | 20:34 |
| haleyb | lajoskatona: yeah, and even the one it's fixing didn't have a test, i had to ask... | 20:35 |
| opendevreview | Brian Haley proposed openstack/neutron master: Remove deprected and unused argument from update_port_status() https://review.opendev.org/c/openstack/neutron/+/901507 | 20:53 |
| opendevreview | Merged openstack/neutron master: Remove deprecated [designate] admin_* parameters https://review.opendev.org/c/openstack/neutron/+/900021 | 21:24 |
| opendevreview | Merged openstack/neutron-lib master: api-ref: Document only unbound ports vnic_type updates https://review.opendev.org/c/openstack/neutron-lib/+/900826 | 21:44 |
| opendevreview | Miro Tomaska proposed openstack/neutron master: Metadata: handle process exceptions https://review.opendev.org/c/openstack/neutron/+/890986 | 22:12 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!