opendevreview | Merged openstack/neutron master: [UT] OVN fake resources factory method should return instance https://review.opendev.org/c/openstack/neutron/+/904133 | 12:13 |
---|---|---|
ralonsoh | (one sec, opening the links) | 14:00 |
ralonsoh | #startmeeting networking | 14:00 |
opendevmeet | Meeting started Tue Jan 2 14:00:52 2024 UTC and is due to finish in 60 minutes. The chair is ralonsoh. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'networking' | 14:00 |
mlavalle | \o | 14:00 |
ralonsoh | hello all | 14:00 |
ralonsoh | Ping list: bcafarel, elvira, frickler, mlavalle, mtomaska, obondarev, slaweq, tobias-urdin, ykarel, lajoskatona, jlibosva, averdagu, amotoki | 14:01 |
slaweq | Hi and HNY! | 14:01 |
ralonsoh | HNY! | 14:01 |
bcafarel | o/ and HNY all! | 14:01 |
ykarel | o/ HNY all !! | 14:01 |
elvira | o/ hny | 14:02 |
ralonsoh | this is going to be a short meeting, we'll review the calenda, bugs and on demand topics | 14:02 |
ralonsoh | next week haleyb will lead the meeting again | 14:02 |
slaweq | ++ | 14:02 |
ralonsoh | so let's start | 14:02 |
ralonsoh | #topic announcements | 14:02 |
ralonsoh | #link https://releases.openstack.org/caracal/schedule.html | 14:02 |
ralonsoh | most important thing: caracal milestone 2 | 14:02 |
ralonsoh | #link https://releases.openstack.org/caracal/schedule.html#c-2 | 14:03 |
ralonsoh | most relevant features should be approved and under review right now | 14:03 |
ralonsoh | as commented 2 weeks ago, some projects have a spec freeze now | 14:03 |
ralonsoh | we don't but we should not delay that | 14:03 |
ralonsoh | I'm guilty of not spending time last weeks on spec reviewal | 14:04 |
ralonsoh | but I'll ping you in Friday for that | 14:04 |
bcafarel | that time of year it is quite allowed | 14:04 |
ralonsoh | and last topic in this section is the Ussuri EOL patch | 14:04 |
ralonsoh | #link https://review.opendev.org/c/openstack/releases/+/903294 | 14:04 |
ralonsoh | as commented (in the patch) | 14:04 |
ralonsoh | there are some open reviews | 14:05 |
ralonsoh | but I'm against merging them without the proper testing | 14:05 |
ralonsoh | (backports have removed the FT) | 14:05 |
ralonsoh | because are not working, so... no | 14:05 |
ralonsoh | so please comment on the open patches or in the releases one | 14:05 |
ralonsoh | something else? | 14:06 |
ralonsoh | ok, let's move on | 14:06 |
mlavalle | not from me | 14:06 |
ralonsoh | #topic bugs | 14:07 |
ralonsoh | we have (should have) 2 reports | 14:07 |
ralonsoh | from bcafarel: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/N7UNL4EI3ZJELP5FMLVCFAONUWTLVD3J/ | 14:07 |
bcafarel | quite a long report :) | 14:07 |
ralonsoh | heheheh | 14:07 |
ralonsoh | the other one is missing | 14:07 |
ralonsoh | but I collected the pending LP bugs | 14:07 |
ralonsoh | so we have 3 to discuss today | 14:07 |
ralonsoh | #link https://bugs.launchpad.net/neutron/+bug/2047101 | 14:08 |
ralonsoh | The test case for 'rbac_policy_quota' execution reports an error. | 14:08 |
ralonsoh | if I'm not wrong, there is a opne review for this one | 14:08 |
ralonsoh | one sec... | 14:08 |
ralonsoh | yes | 14:08 |
ralonsoh | #link https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/904106 | 14:08 |
ralonsoh | so I'll update the LP bug and assign it to liwejian | 14:08 |
ralonsoh | next one | 14:09 |
ralonsoh | #link https://bugs.launchpad.net/neutron/+bug/2047092 | 14:09 |
ralonsoh | "We need a way to distinguish physical_network" | 14:09 |
ralonsoh | to be honest, I'm not sure aboyt what the bug is requesting | 14:09 |
ralonsoh | I commented in c#1 with other options (policies, RBACs) | 14:09 |
ralonsoh | but I have no idea what AZ means in this context | 14:10 |
ralonsoh | any idea? | 14:10 |
frickler | just guessing maybe they want to use tags instead. but your question for feedback will hopefully help | 14:10 |
ralonsoh | but tags are available for members, not only admins | 14:11 |
ralonsoh | maybe is asking for a way of grouping the physnets | 14:12 |
ralonsoh | in any case, more feedback will be needed for this bug/feature | 14:12 |
frickler | it all depends on the actual use case, which is missing, ack | 14:12 |
ralonsoh | ok, let's wait for more information from the reported then | 14:13 |
ralonsoh | last bug is from previous meetings | 14:13 |
ralonsoh | #link https://bugs.launchpad.net/neutron/+bug/2036423 | 14:13 |
ralonsoh | "subnet's gateway ip can be unset while attached to router" | 14:13 |
ralonsoh | i | 14:13 |
ralonsoh | it is expired but still relevant | 14:13 |
ralonsoh | reviewing the code we don't handle correctly the subnet GW IP update | 14:14 |
ralonsoh | in the L3 agent or, as reported in the bug, in the OVS agent | 14:14 |
ralonsoh | so, IMO, if we are not handling this event, we should prevent that action (if the subnet is attached to a router) | 14:15 |
ralonsoh | ^^ do you agree? | 14:15 |
ykarel | +1 | 14:16 |
ralonsoh | ok, I'll take this one then. Because that implies an API change, I don't think we'll be able to backport it. And, of course, we need to document that change. I'll push a patch soon. | 14:17 |
slaweq | ++ | 14:17 |
mtomaska | +1 as well. just finished reading | 14:17 |
slaweq | And probably some new shim API extension may be needed then | 14:17 |
ralonsoh | yes, exactly | 14:17 |
*** elvira1 is now known as elvira | 14:17 | |
ralonsoh | thanks folks | 14:18 |
ralonsoh | that's all I have in this topic | 14:18 |
ralonsoh | any other pending bug? | 14:18 |
ralonsoh | and as commented, last section today | 14:18 |
ralonsoh | #topic on_demand | 14:18 |
ralonsoh | ^^ anything you want to add? | 14:19 |
mtomaska | yes I have a quick one | 14:19 |
ralonsoh | sure | 14:19 |
mtomaska | this patch. https://review.opendev.org/c/openstack/neutron/+/903572/9 I am adding a new RPC method which already exists in RPC interfaces. One way to solve it would be to start using oslo.messaging nemaspaces. Any concern if I start doing that? | 14:20 |
mtomaska | we currently set all RPC namespaces to None https://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/constants.py#L566-L581 | 14:20 |
ralonsoh | but we are already using it | 14:20 |
ralonsoh | namespace=constants.RPC_NAMESPACE_DHCP_PLUGIN | 14:20 |
ralonsoh | right? | 14:20 |
mtomaska | No we are not. I did that in my patch just to see if it will work. Notice the FIXME I left | 14:21 |
ralonsoh | no no, I mean from the base code | 14:21 |
ralonsoh | version='1.0') | 14:21 |
ralonsoh | sorry | 14:21 |
ralonsoh | https://review.opendev.org/c/openstack/neutron/+/903572/9/neutron/agent/dhcp/agent.py#b869 | 14:21 |
mtomaska | yeah and that is None if I am reading that correctly https://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/constants.py#L571 | 14:22 |
slaweq | yes, all those are set to None currently | 14:23 |
ralonsoh | ok, I'm stupid! sorry | 14:23 |
slaweq | haha | 14:23 |
mtomaska | so essentially we have one namespace None :) | 14:23 |
ralonsoh | what method is clashing with "get_ports"? | 14:23 |
slaweq | IMHO You can propose to change that and we can try to start using them | 14:23 |
mtomaska | So I am wondering if it would be ok to start using namespaces after all these years of just using None | 14:24 |
mtomaska | metadata agent get_ports is clashing https://opendev.org/openstack/neutron/src/branch/master/neutron/agent/metadata/agent.py#L70 | 14:24 |
slaweq | TODO comment in that neutron-lib contants file is very old :) | 14:24 |
ralonsoh | right, I see | 14:25 |
ralonsoh | so for now I would (1) use get_dhcp_ports and (2) enable the namespaces | 14:25 |
mtomaska | other way to "fix it" would be to not use the same method_name | 14:25 |
ralonsoh | (2) is something that could introduce some errors | 14:26 |
ralonsoh | and could be a potential issue during upgrades | 14:26 |
mtomaska | hmm I would be for one option or the other but not both | 14:26 |
ralonsoh | agents with None and server with a string | 14:26 |
slaweq | right, how it will work with upgrade if we will change namespaces? | 14:26 |
ralonsoh | enabling the namespace names could be potentially problematic | 14:26 |
ralonsoh | when the server is upgraded, the non-updated clients will fail | 14:27 |
ralonsoh | all of them | 14:27 |
ralonsoh | but should be tested | 14:27 |
slaweq | ralonsoh: this IMO means that we can't do it really | 14:27 |
ralonsoh | because the migration alternative (if that really breaks the upgade process) | 14:28 |
ralonsoh | is to introduce two listeners in the servers | 14:28 |
ralonsoh | one with and another one without namespace | 14:28 |
ralonsoh | ^^ during 2 releases | 14:29 |
slaweq | but then mtomaska will still need to go with 1) approach for his patch | 14:29 |
ralonsoh | yes | 14:29 |
slaweq | ralonsoh please remember about SLURP releases :) | 14:29 |
ralonsoh | that is straightforward | 14:29 |
ralonsoh | slaweq, C will start with the migration | 14:29 |
ralonsoh | and E will keep them | 14:29 |
ralonsoh | yes, sorry | 14:29 |
ralonsoh | 2 SLURP releases | 14:30 |
ralonsoh | so 4 in total | 14:30 |
slaweq | 3 in total: C (SLURP), D (non SLURP) and E (SLURP) :) | 14:31 |
slaweq | so what I propose is: | 14:31 |
slaweq | 1. try to use namespaces and test it with grenade jobs to see how it works | 14:32 |
mtomaska | 1. I did that already. see patchset 9. grenade passed | 14:32 |
slaweq | 2. if that will work fine we can go with this approach IMHO, if there will be problem with upgrade as we are expecting, we will need to: | 14:32 |
slaweq | 3. do what ralonsoh said about two listeners for now and You should then go with different name of Your callback method in Your patch mtomaska | 14:33 |
ralonsoh | grenade is updating all services at the same time | 14:34 |
mtomaska | I also need that patch for downstream 16.2 async release :) | 14:34 |
ralonsoh | we don't have updated API and old agents | 14:34 |
mtomaska | and 17.1.3 | 14:34 |
slaweq | mtomaska You changed that namespace for DHCP agent only | 14:34 |
slaweq | and in grenade job this agent is only running on controller which is updated | 14:34 |
mtomaska | slaweq, o ok, you mean change all namespaces | 14:35 |
slaweq | on "compute" node, which is not upgraded to new version there is ovs agent running | 14:35 |
slaweq | mtomaska yes, You will need to change at least namespace used by the OVS agent to test with grenade job | 14:35 |
slaweq | and/or metadata agent | 14:35 |
ralonsoh | exactly | 14:35 |
slaweq | and L3 agent | 14:36 |
slaweq | those 3 are running in compute1 node: https://7b4153b100b6f570d4fc-1ca4271300c9fb8c2811a73921fc79fe.ssl.cf2.rackcdn.com/903572/9/check/neutron-ovs-grenade-multinode/d255232/compute1/logs/index.html | 14:36 |
slaweq | but not DHCP agent unfortunately | 14:36 |
ralonsoh | IMO, for your patch to be merged (and backportable is D/S), the method should be just "get_dhcp_ports" | 14:37 |
ralonsoh | the RPC namespace should be another LP bug | 14:37 |
ralonsoh | this is not trivial | 14:37 |
mtomaska | yes, a simple change is snowballing :) | 14:38 |
ralonsoh | perfect! thanks slaweq for the grenade information | 14:38 |
ralonsoh | I'll open a RFE to cover the RPC namespace changes | 14:38 |
mtomaska | ok. Let me rename it to get_dhcp_ports . Then I will document what we discussed here in a LP | 14:38 |
ralonsoh | mtomaska, will you open this LP bug? | 14:39 |
mtomaska | yes | 14:39 |
ralonsoh | perfect | 14:39 |
mtomaska | thank you for the info all | 14:39 |
ralonsoh | anything else you want to bring to the on demand section? | 14:39 |
ralonsoh | 2 heads-up | 14:40 |
ralonsoh | in 20 mins we have the CI meeting here in this channel | 14:40 |
ralonsoh | and I forgot the bug deputies | 14:40 |
ralonsoh | This week elvira is the bug deputy, next week will be slaweq | 14:40 |
ralonsoh | ack ^? | 14:40 |
slaweq | sure | 14:41 |
ralonsoh | I'll ping elvira offline | 14:41 |
ralonsoh | thank you all, see you | 14:41 |
ralonsoh | #endmeeting | 14:41 |
opendevmeet | Meeting ended Tue Jan 2 14:41:35 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:41 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/networking/2024/networking.2024-01-02-14.00.html | 14:41 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/networking/2024/networking.2024-01-02-14.00.txt | 14:41 |
opendevmeet | Log: https://meetings.opendev.org/meetings/networking/2024/networking.2024-01-02-14.00.log.html | 14:41 |
elvira | ralonsoh: ack! | 14:44 |
ralonsoh | thanks | 14:44 |
ykarel | #startmeeting neutron_ci | 15:01 |
opendevmeet | Meeting started Tue Jan 2 15:01:35 2024 UTC and is due to finish in 60 minutes. The chair is ykarel. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
opendevmeet | The meeting name has been set to 'neutron_ci' | 15:01 |
mlavalle | \o | 15:01 |
ralonsoh | hi | 15:01 |
ykarel | ping bcafarel, lajoskatona, mlavalle, mtomaska, ralonsoh, ykarel, jlibosva, elvira | 15:01 |
bcafarel | o/ again | 15:01 |
ykarel | This will be video meeting today: https://meetpad.opendev.org/neutron-ci-meetings | 15:02 |
ykarel | #topic Actions from previous meetings | 15:03 |
ykarel | ralonsoh to cleanup test_get_datapath_id | 15:03 |
ykarel | #link https://review.opendev.org/c/openstack/neutron/+/904076 | 15:03 |
ykarel | ykarel to check failures in test_agent_resync_on_non_existing_bridge | 15:04 |
ykarel | https://64984dc0bc4d6446d774-b4e19c98e06eb23bd3ecd1208eab0884.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/neutron/stable/wallaby/neutron-functional/35cecc0/testr_results.html | 15:09 |
ykarel | https://64984dc0bc4d6446d774-b4e19c98e06eb23bd3ecd1208eab0884.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/neutron/stable/wallaby/neutron-functional/35cecc0/controller/logs/dsvm-functional-logs/neutron.tests.functional.agent.ovn.metadata.test_metadata_agent.TestMetadataAgent.test_agent_resync_on_non_existing_bridge/testrun.txt | 15:09 |
ykarel | neutron.privileged.agent.linux.ip_lib.NetworkInterfaceNotFound: Network interface tapovn-780d921 not found in namespace ovnmeta-ovn-780d924a-eef9-4b4c-a6d8-e128f36d9b87. | 15:09 |
slaweq | https://opendev.org/openstack/neutron/src/branch/master/neutron/privileged/agent/linux/ip_lib.py#L210 | 15:10 |
ralonsoh | https://review.opendev.org/q/Ie195ad596fd148708fc30946bde964d52444afee | 15:11 |
ykarel | #action ralonsoh to check and propose fix for handling ip route commands handling | 15:12 |
ykarel | ykarel to check/confirm if issue is same as 2007166 and push backports to skip test | 15:13 |
ykarel | #link https://review.opendev.org/q/topic:%22bug/2007166%22+branch:stable/2023.1 | 15:13 |
ykarel | #topic Stable branches | 15:13 |
ykarel | all good | 15:13 |
ykarel | #topic Stadium projects | 15:14 |
ykarel | all green | 15:14 |
ykarel | #topic Rechecks | 15:14 |
ykarel | #topic Periodic | 15:15 |
ykarel | https://zuul.openstack.org/builds?job_name=neutron-ovn-tripleo-ci-centos-9-containers-multinode&project=openstack/neutron | 15:15 |
ralonsoh | +1 to remove the Wallaby centos9 job | 15:16 |
ykarel | #action ralonsoh to send patch to drop tripleo jobs from wallaby | 15:17 |
ykarel | #topic Grafana | 15:17 |
ykarel | https://grafana.opendev.org/d/f913631585/neutron-failure-rate | 15:17 |
ykarel | #topic On Demand | 15:18 |
ykarel | #endmeeting | 15:34 |
opendevmeet | Meeting ended Tue Jan 2 15:34:57 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:34 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/neutron_ci/2024/neutron_ci.2024-01-02-15.01.html | 15:34 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/neutron_ci/2024/neutron_ci.2024-01-02-15.01.txt | 15:34 |
opendevmeet | Log: https://meetings.opendev.org/meetings/neutron_ci/2024/neutron_ci.2024-01-02-15.01.log.html | 15:34 |
opendevreview | Rodolfo Alonso proposed openstack/neutron stable/wallaby: [stable-only] Remove the "neutron-ovn-tripleo-ci-centos-9-containers-multinode" job https://review.opendev.org/c/openstack/neutron/+/904498 | 15:40 |
ykarel | ralonsoh, i think can drop tripleo.yaml fully i.e all those jobs | 15:41 |
ralonsoh | right | 15:41 |
ralonsoh | I'll push a new ps | 15:41 |
ykarel | thx | 15:41 |
opendevreview | Rodolfo Alonso proposed openstack/neutron stable/wallaby: [stable-only] Remove all TripleO CI jobs https://review.opendev.org/c/openstack/neutron/+/904498 | 15:46 |
opendevreview | Merged openstack/neutron stable/2023.1: [ovn][ipv6] Skip test_update_router_admin_state https://review.opendev.org/c/openstack/neutron/+/904167 | 15:46 |
opendevreview | Merged openstack/neutron stable/2023.1: [ovn][ipv6] Add some more tests to skiplist https://review.opendev.org/c/openstack/neutron/+/904168 | 15:46 |
opendevreview | Merged openstack/neutron stable/2023.1: Remove obsolete PID files before start https://review.opendev.org/c/openstack/neutron/+/903149 | 16:29 |
opendevreview | Merged openstack/neutron stable/zed: [OVN] DB sync host/physnet - filter on agent_type https://review.opendev.org/c/openstack/neutron/+/903685 | 16:31 |
opendevreview | Miro Tomaska proposed openstack/neutron master: DHCP agent get ovn dhcp port from server https://review.opendev.org/c/openstack/neutron/+/903572 | 16:38 |
opendevreview | Miro Tomaska proposed openstack/neutron stable/2023.1: Metadata: handle process exceptions https://review.opendev.org/c/openstack/neutron/+/893775 | 17:35 |
ralonsoh | mtomaska, https://review.opendev.org/c/openstack/neutron/+/903572/10/neutron/agent/dhcp/agent.py#930 | 19:44 |
ralonsoh | if you change that, I'll +2 the patch | 19:45 |
mtomaska | ack. Ill do it right now | 19:48 |
mtomaska | thanks | 19:48 |
opendevreview | Miro Tomaska proposed openstack/neutron master: DHCP agent get ovn dhcp port from server https://review.opendev.org/c/openstack/neutron/+/903572 | 19:51 |
ralonsoh | +2 | 19:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!