| *** tkajinam is now known as Guest1349 | 01:24 | |
| opendevreview | Vasyl Saienko proposed openstack/neutron master: Remove unneeded check in dhcp.py https://review.opendev.org/c/openstack/neutron/+/910208 | 06:38 |
|---|---|---|
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Remove OVN_GATEWAY_INVALID_CHASSIS artifact https://review.opendev.org/c/openstack/neutron/+/909305 | 07:58 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Make mandatory the router name in the LRP.external_ids https://review.opendev.org/c/openstack/neutron/+/910222 | 07:59 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Create an OVN DB transaction context decorator https://review.opendev.org/c/openstack/neutron/+/910538 | 07:59 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: [ovn] Ensure OVN DB update on change of number of GW ports https://review.opendev.org/c/openstack/neutron/+/909955 | 08:03 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: [ovn] Add support for enable_default_route_bfd attribute https://review.opendev.org/c/openstack/neutron/+/878543 | 08:03 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: WIP: Add documentation for aa-l3-gw-multihoming https://review.opendev.org/c/openstack/neutron/+/899402 | 08:03 |
| *** elodilles_pto is now known as elodilles | 08:29 | |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: [netaddr>=1.0.0] Do not use netaddr.core.ZEROFILL flag with IPv6 https://review.opendev.org/c/openstack/neutron-lib/+/910331 | 08:33 |
| ralonsoh | slaweq, lajoskatona ^^ if you have 1 min | 08:37 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Create an OVN DB transaction context decorator https://review.opendev.org/c/openstack/neutron/+/910538 | 09:10 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] "Logical_Router" pinned to chassis, OVN L3 scheduler https://review.opendev.org/c/openstack/neutron/+/909194 | 09:10 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Provide HA functionality to "Logical_Router" chassis pinning https://review.opendev.org/c/openstack/neutron/+/909437 | 09:13 |
| opendevreview | Lajos Katona proposed openstack/neutron master: Add tap_mirror to extension to OVN supported extensions https://review.opendev.org/c/openstack/neutron/+/905840 | 09:24 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: objects/trunk: Disble pylint comparison-with-callable https://review.opendev.org/c/openstack/neutron/+/910583 | 09:26 |
| fnordahl | The gate appears to be blocked by a pylint error atm, ^ is an apparoach to fix it. Not sure if the proper fix belongs here or somewhere else, but we surely would need the gate unblocked quickly | 09:27 |
| lajoskatona | ralonsoh: checking | 09:31 |
| ralonsoh | fnordahl, let me check that | 09:34 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Implement OVN agent metadata extension https://review.opendev.org/c/openstack/neutron/+/898238 | 09:35 |
| ralonsoh | fnordahl, I think we can skip that by assigning the __tablename__ in the DB model | 09:53 |
| ralonsoh | class Trunk(standard_attr.HasStandardAttributes, model_base.BASEV2, | 09:53 |
| ralonsoh | model_base.HasId, model_base.HasProject): | 09:53 |
| ralonsoh | __tablename__ = 'trunks' | 09:53 |
| ralonsoh | instead of adding a pep8 exception | 09:53 |
| fnordahl | Ok, I'll check and update the proposal to do that if it works, thanks for looking! | 09:54 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/2023.1: [OVN] A LRP in an external tunnelled network has no chassis https://review.opendev.org/c/openstack/neutron/+/910588 | 09:56 |
| opendevreview | Lajos Katona proposed openstack/neutron-tempest-plugin master: Tap Mirror API and scenario tests https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/886004 | 09:56 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Add "subnet-external-network" extension to "subnet" resource https://review.opendev.org/c/openstack/neutron/+/907313 | 10:04 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: Explicitly set __tablename__ for Trunk https://review.opendev.org/c/openstack/neutron/+/910583 | 10:08 |
| fnordahl | ralonsoh: that does indeed appear to do the trick, new iteration up ^ thank again! | 10:08 |
| ralonsoh | folks ^^ please check this patch, this error is blocking the pep8 CI right now | 10:39 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: [ovn] Ensure all routes are deleted when deleting ExtGw https://review.opendev.org/c/openstack/neutron/+/910332 | 10:55 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: [ovn] Ensure OVN DB update on change of number of GW ports https://review.opendev.org/c/openstack/neutron/+/909955 | 10:55 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: [ovn] Add support for enable_default_route_bfd attribute https://review.opendev.org/c/openstack/neutron/+/878543 | 10:55 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: WIP: Add documentation for aa-l3-gw-multihoming https://review.opendev.org/c/openstack/neutron/+/899402 | 10:55 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Add "socket" NUMA affinity policy https://review.opendev.org/c/openstack/neutron/+/910594 | 11:36 |
| ralonsoh | haleyb, hi! please check https://review.opendev.org/c/openstack/neutron/+/910583. It is breaking the pep8 CI job | 11:37 |
| opendevreview | Michel Nederlof proposed openstack/ovn-bgp-agent master: Fix address scope test and add address scope unit tests https://review.opendev.org/c/openstack/ovn-bgp-agent/+/907187 | 11:38 |
| opendevreview | Michel Nederlof proposed openstack/ovn-bgp-agent master: Add support for l3vpn with NB driver https://review.opendev.org/c/openstack/ovn-bgp-agent/+/906505 | 11:38 |
| opendevreview | Merged openstack/neutron stable/2023.2: Retry ``set|get_link_attribute(s)`` if the interface is not present https://review.opendev.org/c/openstack/neutron/+/910355 | 12:01 |
| opendevreview | Merged openstack/neutron stable/2023.1: Retry ``set|get_link_attribute(s)`` if the interface is not present https://review.opendev.org/c/openstack/neutron/+/910356 | 12:14 |
| opendevreview | Michel Nederlof proposed openstack/ovn-bgp-agent master: Add support for l3vpn with NB driver https://review.opendev.org/c/openstack/ovn-bgp-agent/+/906505 | 13:02 |
| iurygregory | lucasagomes, hey hey o/ ikoliveira is the guy I was talking about, he would like to contribute to the neutron project =) | 13:24 |
| lucasagomes | ikoliveira, hey there o/ | 13:24 |
| iurygregory | he is from my alma mater university here in Brazil =) | 13:24 |
| lucasagomes | welcome :D | 13:25 |
| ikoliveira | iurygregory: tks for introducing me!! o/ | 13:26 |
| ikoliveira | iurygregory tks for introducing me!! o/ | 13:26 |
| ikoliveira | lucasgomes: hello, friend!! can we start now? hahaha | 13:28 |
| iurygregory | ikoliveira, good luck working with Neutron :D | 13:29 |
| lucasagomes | ikoliveira, sure what do u need ? | 13:30 |
| lucasagomes | ikoliveira, have you contributed with openstack before ? | 13:30 |
| ikoliveira | tks guys, i was looking for issues but dont know where to start | 13:32 |
| lucasagomes | ikoliveira, if it's ur first contribution, I would suggest u first learn how to deploy it with DevStack | 13:32 |
| lucasagomes | ikoliveira, after that take a look at our LP for bugs https://bugs.launchpad.net/neutron/ | 13:32 |
| lucasagomes | ikoliveira, lemme see if we have some low hanging fruit that would be a good start | 13:32 |
| lucasagomes | 1s | 13:32 |
| ikoliveira | ok | 13:33 |
| lucasagomes | https://bugs.launchpad.net/neutron/+bug/1808917 this is a bit old, perhaps worth investigating if it's still happens | 13:35 |
| lucasagomes | But seems like a good thing to start | 13:35 |
| ikoliveira | i made deployment with devstack with in a vm but didint woked a lot with it. maybe its a good idea to do it again | 13:36 |
| lucasagomes | In any case, on that launchpad you can always filter by low priority bugs | 13:36 |
| ikoliveira | lucasgomes: nice, gonna see it | 13:36 |
| lucasagomes | ikoliveira, yeah, I don't know when you did it... But recently but not so recently the default mechanism driver was changed to ML2/OVN in devstack | 13:36 |
| ikoliveira | lucasagomes: nice, gonna see it | 13:36 |
| lucasagomes | Maybe u would also want to take a look at the documentation and learn a bit more about OVN with ur DevStack instance | 13:37 |
| lucasagomes | Some things are particular to OVN and can be quite different from ML2/OVS (e.g how DHCP works in ML2/OVN compared to ML2/OVS) | 13:38 |
| ikoliveira | lucasagomes: Ok, gonna see those things that you said and follow your suggests. tks for received me! | 13:43 |
| lucasagomes | ikoliveira, yw! | 13:43 |
| *** ralonsoh_ is now known as ralonsoh | 13:59 | |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Implement OVN agent metadata extension https://review.opendev.org/c/openstack/neutron/+/898238 | 14:19 |
| haleyb | ralonsoh: ack on the pep8 fix | 14:28 |
| ralonsoh | perfect | 14:29 |
| haleyb | ralonsoh: and i updated info on my favorite bug, i can have even more nested networks and ml2/ovs "just works" | 14:30 |
| haleyb | i'd like to find a solution for this, it's a big issue for a customer | 14:30 |
| ralonsoh | haleyb, I'm spawning an environment to check this again | 14:30 |
| haleyb | ack, thanks | 14:31 |
| haleyb | ralonsoh, slaweq: https://review.opendev.org/c/openstack/neutron/+/894399 is ready for review again | 14:33 |
| ralonsoh | ok | 14:33 |
| ralonsoh | haleyb, did you follow the eventlet issue? | 14:33 |
| ralonsoh | https://review.opendev.org/c/openstack/governance/+/902585/16/goals/proposed/migrate-eventlet-usages-to-asyncio.rst | 14:33 |
| haleyb | ralonsoh: i hadn't seen the latest update, did you have any issues with it? | 14:35 |
| ralonsoh | everything | 14:36 |
| ralonsoh | we need to coordinate a migration strategy with the communityu | 14:36 |
| ralonsoh | and we need to know what the community is going to propose and implement | 14:36 |
| ralonsoh | probably a migration library compatible with asyncio | 14:36 |
| ralonsoh | but we need to be aware of it, because this is going to be a pain during the next release | 14:37 |
| haleyb | ralonsoh: from the ML and that change, it's clear the short-term issue of landing patches in eventlet is fixed, the medium-term steps look to be 2-cycles in duration (at least), i'll read that part again | 14:44 |
| ralonsoh | yes, the mid and long term solutions are the critical ones, in terms of code migration | 14:44 |
| fnordahl | ralonsoh: https://review.opendev.org/c/openstack/neutron/+/878543 has been updated if you have a spare moment to take another look | 14:46 |
| ralonsoh | I'll check it today | 14:46 |
| fnordahl | thank you, much apprechiated | 14:47 |
| grishatsu | Hi, I am using neutron with Yoga version in my product. Is there a known issue that when rabbitmq is down temporarily (not HA) neutron-rpc-server fails to recover correctly? (The q-reports queues are not created, and therefor not consuming health checks from agents) | 15:01 |
| mlavalle | haleyb: I cannot help reproducing that for now. I've been heads down working on a customer case. If I'm done today, I might be able to help tomorrow. Would that still be useful? | 15:03 |
| haleyb | mlavalle: ack, thanks for letting me know! | 15:03 |
| mlavalle | haleyb: do you want me to try tomorrow, if I have time? | 15:04 |
| haleyb | mlavalle: yes, if ralonsoh can't it would be good for a third to confirm/deny, thanks! | 15:05 |
| grishatsu | HELP SENDPASS | 15:25 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [eventlet] Bump eventlet version to 0.35.1 https://review.opendev.org/c/openstack/neutron/+/910638 | 15:26 |
| ralonsoh | fnordahl, please check https://review.opendev.org/c/openstack/neutron/+/878543 | 15:53 |
| fnordahl | ralonsoh: thanks, on it | 15:55 |
| noonedeadpunk | hey folks! do you have any idea how to reach ovn-bgp-agent core team? | 16:20 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: [ovn] Add support for enable_default_route_bfd attribute https://review.opendev.org/c/openstack/neutron/+/878543 | 16:29 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: WIP: Add documentation for aa-l3-gw-multihoming https://review.opendev.org/c/openstack/neutron/+/899402 | 16:29 |
| opendevreview | Miguel Lavalle proposed openstack/neutron master: Enable HA for OVN router flavors https://review.opendev.org/c/openstack/neutron/+/901513 | 16:29 |
| mlavalle | ralonsoh, haleyb: thanks for your reviews to https://review.opendev.org/c/openstack/neutron/+/901513. I've done my best to respond to your concerns. Please take a look again when you have a chance | 16:32 |
| frickler | noonedeadpunk: lucasagomes is right here, as well as some neutron cores, so maybe simply ask? | 16:41 |
| noonedeadpunk | I'm a bit /o\ about https://bugs.launchpad.net/ovn-bgp-agent/+bug/2054599 right now | 16:43 |
| noonedeadpunk | I know I did not wisiest thing in terms of interface names, but slightly lost about direction on how to solve this right now | 16:44 |
| noonedeadpunk | While renaming them locally might be easiest thing to do, wanna make code slightly more fool-proof | 16:44 |
| opendevreview | Merged openstack/neutron stable/2023.1: [OVN] A LRP in an external tunnelled network has no chassis https://review.opendev.org/c/openstack/neutron/+/910588 | 16:44 |
| noonedeadpunk | the part where I got lost, is basically how would be to properly trimm interface names for vlans. As dropping last digits of vlan tag is obviously wrong | 16:45 |
| noonedeadpunk | so it should be dropped from the bridge name. | 16:45 |
| noonedeadpunk | And then it feels that bridge name is expected to be consistent as well, in order to fetch all vlans for it | 16:46 |
| haleyb | noonedeadpunk: luis is usually in this channel, as are others that work on the project, just don't see them all here today | 16:46 |
| noonedeadpunk | https://opendev.org/openstack/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/privileged/linux_net.py#L440 | 16:47 |
| noonedeadpunk | so basically this leaves with the only option - ensure that bridge name is always not longer then 15 - 1 - (as max vlan number is 4 digits) | 16:48 |
| noonedeadpunk | * 15 - 1 (joint dot) - 4 | 16:48 |
| noonedeadpunk | but also it feels a bit that https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910304 could be fixing the root cause and there might be better place in code to address it. not sure | 16:49 |
| noonedeadpunk | and there seems to be plenty more places that I've faced today | 16:55 |
| noonedeadpunk | *then | 16:55 |
| noonedeadpunk | So all-in-all I'm already not sure what the best way forward will be here | 16:56 |
| haleyb | noonedeadpunk: my simple answer is that neutron/neutron-lib uses DEVICE_NAME_MAX_LEN (15) in various places, so there might be places in ovn-bgp-agent that need to take care. So perhaps there needs to be a function that builds these names consistently, truncating another part of the name to leave the vlan id intact. | 17:00 |
| haleyb | i'm just not involved in the day to day of the project | 17:00 |
| noonedeadpunk | totally understandable. be neither - just rolled it out for the first time and facing couple of stacktraces :) | 17:01 |
| noonedeadpunk | but then I'm also slightly afraid/confused of all places where this should be and should not be done. As part should probably left un-trimmed (the one, that gets bridge name from neutron mappings) | 17:03 |
| noonedeadpunk | but ok, will try to do my best I guess... | 17:04 |
| noonedeadpunk | and basically - is it worth patching under privileged/linux_net or on some higher level after all... | 17:05 |
| grishatsu | Hi, I am using neutron with Yoga version in my product. Is there a known issue that when rabbitmq is down temporarily (not HA) neutron-rpc-server fails to recover correctly? (The q-reports queues are not created, and therefor not consuming health checks from agents) | 17:07 |
| haleyb | noonedeadpunk: and not to go off on a tangent, but you can set an altname that's 256 chars long, 'ip link property add dev lo altname biglongloooooopbackname' - but that would be a bigger change, just got me thinking about us always truncating the name | 17:21 |
| noonedeadpunk | yeah, there was "some" trimming in the repo as well. But when I've started expanding that, it become a bit /o\ | 17:23 |
| noonedeadpunk | but I guess I've almost found path through that... | 17:24 |
| noonedeadpunk | I really wonder though if nobody before named an external bridge in ovs as `br-provider` and had 4-digit vlans on it... | 17:25 |
| haleyb | i don't remember any bugs, but will now expect one in 3...2...1... | 17:33 |
| noonedeadpunk | I was going to track that under https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910304 fwiw :) | 17:38 |
| noonedeadpunk | * https://bugs.launchpad.net/ovn-bgp-agent/+bug/2054599 | 17:38 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Handle trimming of vlan interface namings https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910654 | 18:06 |
| noonedeadpunk | hopefully this helps ^ | 18:06 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Handle trimming of vlan interface namings https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910654 | 18:35 |
| opendevreview | Frode Nordahl proposed openstack/neutron master: [ovn] Add support for enable_default_route_bfd attribute https://review.opendev.org/c/openstack/neutron/+/878543 | 21:03 |
| fnordahl | ralonsoh: done ^ patch grew by 173 lines, all of it functional tests. thank you for pointing out the need for that, much better with tests! | 21:07 |
| mlavalle | haleyb: you still around? | 22:09 |
| haleyb | mlavalle: yes, still here | 22:09 |
| mlavalle | haleyb: ralonsoh suggested this https://review.opendev.org/c/openstack/neutron/+/901513/19..20/neutron/services/ovn_l3/plugin.py#b418. But it clashes with this test:https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/api/test_extensions.py#L49 | 22:12 |
| mlavalle | haleyb: it fails in this line https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/api/test_extensions.py#L32 | 22:14 |
| opendevreview | Merged openstack/neutron master: Explicitly set __tablename__ for Trunk https://review.opendev.org/c/openstack/neutron/+/910583 | 22:17 |
| haleyb | mlavalle: sorry, dog's dinner clock fired, i could set my watch by her needs | 22:22 |
| mlavalle | haleyb: LOL. here's what I propose. Go back to the way I was handling the extension configuration before ralonsoh's suggestion and we fix the tests early in the next cycle | 22:24 |
| haleyb | testtools.matchers._impl.MismatchError: 'l3-ha' not in {...} | 22:24 |
| haleyb | that failure? | 22:24 |
| mlavalle | yes | 22:24 |
| *** jph6 is now known as jph | 22:24 | |
| haleyb | hmm, thinking | 22:25 |
| opendevreview | Merged openstack/neutron master: [ovn] Ensure all routes are deleted when deleting ExtGw https://review.opendev.org/c/openstack/neutron/+/910332 | 22:30 |
| haleyb | mlavalle: i can understand the change rodolfo wanted, but not sure how to do that and pass the test | 22:33 |
| mlavalle | haleyb: same here. I agree with his point, but now we need to change our testing strategy | 22:33 |
| haleyb | mlavalle: the qos extension does something similar from looking at the code? | 22:34 |
| mlavalle | haleyb: yeah, but I don't know what is the difference | 22:36 |
| haleyb | https://review.opendev.org/c/openstack/neutron/+/722415 was the change, looking at it to see if it's obvious | 22:36 |
| haleyb | extensions = CONF.network_feature_enabled.api_extensions | 22:46 |
| mlavalle | yeap | 22:46 |
| haleyb | where is that set? is that in tempest? | 22:46 |
| haleyb | i'm down the rabbit hole how | 22:46 |
| mlavalle | yes that is tempest | 22:46 |
| mlavalle | haleyb: if you have too many things to do, I can talk to ralonsoh tomorrow morning and see what he suggests | 22:47 |
| mlavalle | haleyb: in the meantime I can address the comments you made earlier today | 22:47 |
| haleyb | no, just meaning i'm jumping across reviews and repos, it's all swapped-in now | 22:47 |
| mlavalle | and I'm glad the pep8 issue got fixed. it was driving me crazy | 22:48 |
| haleyb | just merged ^^ up there | 22:48 |
| mlavalle | yes, I noticed | 22:48 |
| haleyb | mlavalle: so that 'l3-ha' string has been in the api_extensions forever, is there a name conflict? | 22:50 |
| haleyb | hmm, l3-ext-ha-mode is that original extension | 22:51 |
| haleyb | so i'm not sure how to fix this at the moment, it's like chicken/egg | 22:54 |
| haleyb | mlavalle: hopefully rodolfo will know the fix | 22:59 |
| mlavalle | haleyb: yes, I'll talk to him. like I said, I'll fix what you commented today | 23:03 |
| mlavalle | and thanks for the review | 23:03 |
| haleyb | mlavalle: some of that was just nits, it's not intuitive how all those files play together to create the sample | 23:04 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!