| opendevreview | Brian Haley proposed openstack/neutron master: Simplify recursive handling of nested ovn networks for snat https://review.opendev.org/c/openstack/neutron/+/916939 | 00:28 |
|---|---|---|
| opendevreview | Miguel Lavalle proposed openstack/neutron master: User defined router flavor driver with no LSP https://review.opendev.org/c/openstack/neutron/+/917800 | 00:46 |
| opendevreview | Miguel Lavalle proposed openstack/neutron master: User defined router flavor driver with no LSP https://review.opendev.org/c/openstack/neutron/+/917800 | 01:14 |
| opendevreview | liuyulong proposed openstack/neutron master: Add a default goto table=94 for openvswitch fw https://review.opendev.org/c/openstack/neutron/+/907382 | 01:25 |
| opendevreview | Merged openstack/neutron stable/2024.1: Don't update revision number if object was not modified https://review.opendev.org/c/openstack/neutron/+/918641 | 05:13 |
| tkajinam | does anyone know the status of https://opendev.org/x/tap-as-a-service-tempest-plugin ? | 05:39 |
| tkajinam | the repository is badly unmaintained. I see tap-as-a-service is part of stadium and maintained in openstack namespace and neutron-tempest-plugin provides taas related tests. I wonder if this repository should be retired | 05:41 |
| tkajinam | hmm. it seems the jobs defined there are used by old stable branches in tap-as-a-service repo. I wonder why we still have ancient branches such as ocata in the repository . probably these weren't EOLed properly until it was moved back to openstack namespace ? | 05:43 |
| slaweq | hi tkajinam, this is most likely question to lajoskatona but from what I know it should be retired long time ago as we moved those test to the neutron-tempest-plugin: https://github.com/openstack/neutron-tempest-plugin/tree/master/neutron_tempest_plugin/tap_as_a_service | 07:14 |
| lajoskatona | slaweq, tkajinam: Hi | 07:18 |
| lajoskatona | slaweq, tkajinam: https://opendev.org/x/tap-as-a-service-tempest-plugin is really not maintained, to tell the truth as it is under x/ namespace I don't know which process can be applied to it | 07:20 |
| tkajinam | slaweq, lajoskatona ok. probably I can send an email to hear some inputs there. | 08:03 |
| tkajinam | lajoskatona, yeah, I don't know either. I'll ask if anyone knows the appropriate process to retire it, and also retire old stable branches of taas repo | 08:03 |
| tkajinam | happened to find this repository when trying to remove all references to oslosphinx which was already retired. | 08:04 |
| lajoskatona | tkajinam: for retiring taas old branches I run a few rounds, but as these old branches are not registered in openstack/releases release team has to do it manually and that is usually quite sensitive | 08:07 |
| tkajinam | lajoskatona, yeah. but we have to move the branch retirement forward because these old branches uses stable branchs jobs from that taas-tempest-plugin repo. | 08:08 |
| tkajinam | technically we can leave these branches, if we ignore zuul config errors but I think it's a good timing to sort out that old pending to-do, IMO | 08:09 |
| lajoskatona | tkajinam: I found these old mails for this topic to have input for the deletion of these: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/MK5KX3JRVIJGRYRI2JV3UNKGCJOLPEB2/ | 08:10 |
| lajoskatona | https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/5KYIBFZQXFHSPQVVJIK2ZJYO7NSK2QLQ/ | 08:10 |
| tkajinam | lajoskatona, thanks ! | 08:11 |
| tkajinam | hmm I don't see any replies to these two mails... I probably have to annoy elodilles or frickler to get their actual help for the branch deletion. | 08:13 |
| lajoskatona | tkajinam: +1, please ping me if you need any background or help | 08:17 |
| tkajinam | lajoskatona, will do :-) | 08:20 |
| andrewbogott_ | lajoskatona: can you advise what I should do about the circular dependency of a patch needing a tempest change and the tempest change needing the patch? (that being https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/890248 and https://review.opendev.org/c/openstack/neutron/+/886214) | 14:19 |
| haleyb | andrewbogott_: only the n-t-p one should have a depends-on, that way we can't merge a test that will break things. Reviewers should see tempest is green before merging the neutron patch | 14:47 |
| lajoskatona | andrewbogott_: Hi, checking | 14:47 |
| andrewbogott_ | OK, so have a depends-on on the tempest change but not on the neutron change, is that correct? And then recheck the neutron change if/when tempest change is merged? | 14:48 |
| haleyb | andrewbogott_: the neutron change needs to merge first, but we shouldn't merge unless the tempest change is green (i.e. the new test passes) | 14:50 |
| lajoskatona | andrewbogott_: so is your neutron change green without the depends-on to n-t-p? | 14:50 |
| andrewbogott_ | iirc neither change is green without the other patch. | 14:50 |
| andrewbogott_ | Hence the circularity | 14:51 |
| haleyb | hmm | 14:51 |
| andrewbogott_ | Isnt' that a normal situation? Patches often come with test changes that validate the patch... | 14:51 |
| lajoskatona | andrewbogott_: worst case we can temporarily disable/skip the test and merge neutron patch and than enable /unskip again the tempest test | 14:51 |
| andrewbogott_ | ok, so for now which should have the depends-on and which shouldn't? :D | 14:52 |
| lajoskatona | haleyb: Hi, in the past I remember that we did similar with skipping for the time of the neutron patch merge, but it was once perhaps so not good records for the process :-) | 14:55 |
| lajoskatona | haleyb: can you recall perhaps? | 14:55 |
| haleyb | andrewbogott_: it's a rare case imo, usually indicates an unwanted change in behavior. we could mark the test unstable, merge, then un-do. i don't remember what we did in the past | 14:55 |
| haleyb | lajoskatona: i don't remember :( | 14:55 |
| lajoskatona | haleyb, andrewbogott_: perhaps I mess it with something else | 14:56 |
| lajoskatona | haleyb, andrewbogott_: I have to leave now to catch my bus home, but I will read back the irc logs and tomorrow I will be back at latest | 14:56 |
| haleyb | lajoskatona: i guess usually we're adding new tests so don't see this issue? | 14:56 |
| andrewbogott_ | thanks all. I'll stand by for now. | 14:57 |
| lajoskatona | haleyb: was in a situation once when we remove the tempest test to add it to fullstack perhaps to keep the coverage | 14:57 |
| opendevreview | Brian Haley proposed openstack/neutron master: Simplify recursive handling of nested ovn networks for snat https://review.opendev.org/c/openstack/neutron/+/916939 | 19:40 |
| opendevreview | Andrew Bogott proposed openstack/neutron master: port policies: Allow port creation/updating in shared networks https://review.opendev.org/c/openstack/neutron/+/886214 | 20:02 |
| opendevreview | Brian Haley proposed openstack/neutron master: Simplify recursive handling of nested ovn networks for snat https://review.opendev.org/c/openstack/neutron/+/916939 | 21:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!