| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: docs: Remove archives https://review.opendev.org/c/openstack/neutron/+/934285 | 00:02 |
|---|---|---|
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: docs: Remove archives https://review.opendev.org/c/openstack/neutron/+/934285 | 00:08 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Use set_nb_global_options in maintenance task https://review.opendev.org/c/openstack/neutron/+/931068 | 00:12 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: nit: Add info about ovn version with additional_chassis https://review.opendev.org/c/openstack/neutron/+/934286 | 00:16 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: nit: Add info about ovn version with additional_chassis https://review.opendev.org/c/openstack/neutron/+/934286 | 00:17 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Return rc != 0 on invalid neutron-ovn-db-sync-util cli options https://review.opendev.org/c/openstack/neutron/+/934287 | 00:32 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Enable no-else-return pylint check https://review.opendev.org/c/openstack/neutron/+/934205 | 00:54 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Enable no-else-return pylint check https://review.opendev.org/c/openstack/neutron/+/934205 | 00:57 |
| opendevreview | liuyulong proposed openstack/neutron master: Add basical functionalities for metadata path extension https://review.opendev.org/c/openstack/neutron/+/881535 | 01:18 |
| opendevreview | liuyulong proposed openstack/neutron master: Add metadata path extension openflows https://review.opendev.org/c/openstack/neutron/+/888097 | 01:18 |
| opendevreview | liuyulong proposed openstack/neutron master: Fullstack case for metadata path https://review.opendev.org/c/openstack/neutron/+/888098 | 01:18 |
| opendevreview | liuyulong proposed openstack/neutron master: Add devstack plugin to enable ovs metadata_path https://review.opendev.org/c/openstack/neutron/+/928586 | 01:18 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Remove prefix delegation code https://review.opendev.org/c/openstack/neutron/+/934283 | 01:58 |
| opendevreview | Merged openstack/neutron master: Remove postgresql code https://review.opendev.org/c/openstack/neutron/+/934171 | 04:56 |
| opendevreview | Merged openstack/neutron master: Use set_nb_global_options in maintenance task https://review.opendev.org/c/openstack/neutron/+/931068 | 05:16 |
| opendevreview | yatin proposed openstack/neutron master: [DNM] check pin translation jobs https://review.opendev.org/c/openstack/neutron/+/934035 | 06:33 |
| opendevreview | Stephen Finucane proposed openstack/os-vif master: mypy: Add type annotations https://review.opendev.org/c/openstack/os-vif/+/745162 | 10:26 |
| opendevreview | Jakub Libosvar proposed openstack/neutron master: OVN metadata agent additional_chassis detection https://review.opendev.org/c/openstack/neutron/+/934188 | 13:22 |
| opendevreview | Jakub Libosvar proposed openstack/neutron master: OVN metadata agent additional_chassis detection https://review.opendev.org/c/openstack/neutron/+/934188 | 13:24 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Handle trimming of vlan interface namings https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910654 | 13:34 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Handle trimming of vlan interface namings https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910654 | 13:37 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Use neutron_lib constants a device name limiter https://review.opendev.org/c/openstack/ovn-bgp-agent/+/934327 | 13:46 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Use neutron_lib constants a device name limiter https://review.opendev.org/c/openstack/ovn-bgp-agent/+/934327 | 13:53 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Handle trimming of vlan interface namings https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910654 | 14:03 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Use neutron_lib constants a device name limiter https://review.opendev.org/c/openstack/ovn-bgp-agent/+/934327 | 14:03 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Use neutron_lib constants a device name limiter https://review.opendev.org/c/openstack/ovn-bgp-agent/+/934327 | 14:08 |
| haleyb | ihrachys: we found it building packages on noble, which is py3.12 | 14:38 |
| ihrachys | haleyb: yeah I figured already what the cause was. the typing hints package for the library had if-else using python versions, but mypy was not smart enough to know about the fact we deal with version mismatch by catching a TypeError... so it was complaining. I changed it to proper python version check and it works now. the fix here | 15:28 |
| ihrachys | https://review.opendev.org/c/openstack/neutron/+/929866/9/neutron/conf/db/migration_cli.py | 15:28 |
| haleyb | ihrachys: do you need me to try on noble? | 15:29 |
| ihrachys | yeah, if you can. I checked with py312 myself but that's on ... nix-darwin... so... not even linux. | 15:29 |
| ihrachys | the breakage was due to https://review.opendev.org/c/openstack/neutron/+/931515 btw that as you can see dropped the "proper" version check. | 15:29 |
| ihrachys | this kinda reverts the "fix" though. wonder if we want to deal with "distributions with own feature backports" after all, and a ignore mypy comment is warranted. | 15:31 |
| haleyb | ihrachys: yeah i think that's why we went to try/except | 15:33 |
| ihrachys | haleyb: a feature backport here would mean that a distro decided to backport a breaking change in importlib? | 15:35 |
| ihrachys | I mean, in python stdlib? | 15:36 |
| ihrachys | oh interesting. apparently there's https://pypi.org/project/backports.entry-points-selectable/ to handle this interface mismatch transparently and it's linked from official docs | 15:38 |
| ihrachys | official docs referring to the package just above https://docs.python.org/3/library/importlib.metadata.html#distribution-metadata | 15:39 |
| ihrachys | though it would mean we'd have to go through adding this to global requirements etc. meh. | 15:40 |
| haleyb | ihrachys: interesting. and i don't have a problem going back to "sys" check | 15:42 |
| ihrachys | yeah I think the original patch by Takashi was perhaps over an abundance of caution that maybe is too pedantic in this case (a distro backporting a python interface breaking change in python itself is... they just shouldn't do that, they will break the world that assumes the versions match interface in official docs) | 15:44 |
| opendevreview | Merged openstack/ovsdbapp master: Remove unused bindep tools https://review.opendev.org/c/openstack/ovsdbapp/+/933865 | 15:48 |
| opendevreview | Jakub Libosvar proposed openstack/neutron stable/2024.2: OVN metadata agent additional_chassis detection https://review.opendev.org/c/openstack/neutron/+/934340 | 16:12 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Enable no-else-return pylint check https://review.opendev.org/c/openstack/neutron/+/934205 | 16:12 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: refactor: simplify device_exists_with_ips_and_mac https://review.opendev.org/c/openstack/neutron/+/934341 | 16:12 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Handle trimming of vlan interface namings https://review.opendev.org/c/openstack/ovn-bgp-agent/+/910654 | 16:27 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/ovn-bgp-agent master: Use neutron_lib constants a device name limiter https://review.opendev.org/c/openstack/ovn-bgp-agent/+/934327 | 16:29 |
| s3rj1k | Hi all, can we talk briefly about this RFE https://bugs.launchpad.net/neutron/+bug/2086776 on next meetup? Should I add it to meeting agenda? | 17:06 |
| haleyb | ihrachys: have Noble results, see my comments for more info | 17:47 |
| haleyb | s3rj1k: can you describe the missing/wrong flows you see in the bug? and is this happening on later versions than Victoria? Preferably a reproducer on something close to master is best. | 17:52 |
| haleyb | basically, if there is a bug I'd rather fix it than workaround it | 17:52 |
| ihrachys | haleyb: I suspect your had to enable mypy because it was not installing it in tox env and so you called the one external to tox env. there's a fix for this https://review.opendev.org/c/openstack/neutron/+/934284 | 18:19 |
| s3rj1k | haleyb: I don't think that repro would be easy, doable but as separate bug, what I would want is to have some backup plan to auto mediate any issue on production, I'll do a separate report in case I manage to reproduce flow issue | 18:21 |
| haleyb | ihrachys: yes, that is probably it, let me comment there | 18:27 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Enable no-else-return pylint check https://review.opendev.org/c/openstack/neutron/+/934205 | 18:33 |
| opendevreview | Merged openstack/ovn-bgp-agent master: Expose FIP if external_mac was set https://review.opendev.org/c/openstack/ovn-bgp-agent/+/930784 | 18:34 |
| opendevreview | Merged openstack/ovn-bgp-agent master: nb driver: Don't expose FIP if the external_mac is not set https://review.opendev.org/c/openstack/ovn-bgp-agent/+/924531 | 18:34 |
| opendevreview | Merged openstack/ovn-bgp-agent master: Introduce LSP address column parsing functions https://review.opendev.org/c/openstack/ovn-bgp-agent/+/925801 | 18:34 |
| opendevreview | Merged openstack/ovn-bgp-agent master: Move devstack job to experimental https://review.opendev.org/c/openstack/ovn-bgp-agent/+/933861 | 18:34 |
| opendevreview | Merged openstack/ovn-bgp-agent master: functional: Introduce a base class for OVN func testing https://review.opendev.org/c/openstack/ovn-bgp-agent/+/933789 | 18:34 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Fix dependencies for mypy tox target https://review.opendev.org/c/openstack/neutron/+/934284 | 18:36 |
| ihrachys | haleyb: I think it may mean that your mypy failure may be gone if you retest again with pep8 target? | 18:38 |
| haleyb | ihrachys: i think pep8 runs fine, just not mypy by itself, will try. think the change i mentioned in your fixup would address it | 20:23 |
| haleyb | sigh, the translation part of pep8 fails on Noble too, msgfmt not installed | 20:29 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: mypy: enable for all non-test modules https://review.opendev.org/c/openstack/neutron/+/929866 | 22:01 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Enable no-else-return pylint check https://review.opendev.org/c/openstack/neutron/+/934205 | 22:23 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: refactor: simplify device_exists_with_ips_and_mac https://review.opendev.org/c/openstack/neutron/+/934341 | 22:28 |
| opendevreview | Jakub Libosvar proposed openstack/ovn-bgp-agent master: WIP: Support ovn-bgp agent with DVR disabled https://review.opendev.org/c/openstack/ovn-bgp-agent/+/933930 | 22:28 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Remove prefix delegation code https://review.opendev.org/c/openstack/neutron/+/934283 | 22:44 |
| *** haleyb is now known as haleyb|out | 22:44 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!