opendevreview | liuyulong proposed openstack/neutron-tempest-plugin master: Re-enable the router test_migration cases https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318 | 01:11 |
---|---|---|
opendevreview | liuyulong proposed openstack/neutron-tempest-plugin master: Re-enable the router test_migration cases https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318 | 02:10 |
*** vsaienko is now known as jumpojoy | 05:31 | |
gmann | ykarel: can we merge this also (need to remove DNM and #Test comment), to avoid failure on tomorrow migration https://review.opendev.org/c/openstack/neutron/+/932920 | 05:46 |
ykarel | gmann, yes will sync on this today with Team | 05:48 |
ykarel | there are still some issues, but we have workarounds in patch so should be fine for now | 05:48 |
gmann | ykarel: thanks | 05:49 |
opendevreview | Merged openstack/networking-bgpvpn master: tests: test_db_base_plugin_v2.py was moved to common https://review.opendev.org/c/openstack/networking-bgpvpn/+/935621 | 06:14 |
opendevreview | liuyulong proposed openstack/neutron-tempest-plugin master: Re-enable the router test_migration cases https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318 | 06:27 |
opendevreview | liuyulong proposed openstack/neutron-tempest-plugin master: Re-enable the router test_migration cases https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318 | 06:38 |
ralonsoh | bcafarel, hello! If you have 1 minute: https://review.opendev.org/q/Ie6210f7dab4d54d734255d3ac2271cac99590f46 | 07:44 |
ralonsoh | thanks! | 07:44 |
bcafarel | sure thing, looking | 08:02 |
opendevreview | liuyulong proposed openstack/neutron-tempest-plugin master: Re-enable the router test_migration cases https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318 | 08:05 |
opendevreview | liuyulong proposed openstack/neutron-tempest-plugin master: Re-enable the router test_migration cases https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/936318 | 08:13 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Improve initial hash ring setup https://review.opendev.org/c/openstack/neutron/+/936428 | 09:32 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: DNM - Test "neutron-ovn-tempest-ipv6-only-ovs*" with 4 workers https://review.opendev.org/c/openstack/neutron/+/936429 | 09:33 |
ralonsoh | ykarel, ^ there is a dependency on a devstack change, to add this new wsgi config variable | 09:33 |
ralonsoh | I think that will work, using the DB transactionality to sync all workers in a node | 09:33 |
ykarel | ralonsoh, thx | 10:12 |
ykarel | let's see how the test job goes | 10:12 |
ykarel | ralonsoh, also we have to unblock https://review.opendev.org/c/openstack/neutron/+/932920 , remove dnm/test | 10:13 |
ykarel | noble switch is about to happen today/tomorrow | 10:14 |
ralonsoh | right, please merge https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/933277 | 10:18 |
ralonsoh | that is a dependency | 10:18 |
ykarel | yes that's in gate | 10:19 |
ykarel | we can approve once check is green | 10:19 |
ykarel | we can remove depends-on neutron-tempest-plugin as can get both independently | 10:19 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: Update tempest jobs for Ubuntu Noble (24.04) https://review.opendev.org/c/openstack/neutron/+/932920 | 10:20 |
ralonsoh | right, let me push a new PS | 10:20 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: Update tempest jobs for Ubuntu Noble (24.04) https://review.opendev.org/c/openstack/neutron/+/932920 | 10:20 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: Update tempest jobs for Ubuntu Noble (24.04) https://review.opendev.org/c/openstack/neutron/+/932920 | 10:21 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: DNM - Test "neutron-ovn-tempest-ipv6-only-ovs*" with 4 workers https://review.opendev.org/c/openstack/neutron/+/936429 | 10:41 |
ralonsoh | ykarel, I don't think the Neutron jobs will use the devstack patch | 10:54 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: DNM - Test "neutron-ovn-tempest-ipv6-only-ovs*" with 4 workers https://review.opendev.org/c/openstack/neutron/+/936429 | 11:00 |
opendevreview | Merged openstack/ovn-bgp-agent stable/2024.2: Move devstack job to experimental https://review.opendev.org/c/openstack/ovn-bgp-agent/+/936401 | 12:03 |
opendevreview | Merged openstack/ovn-bgp-agent stable/2024.1: Move devstack job to experimental https://review.opendev.org/c/openstack/ovn-bgp-agent/+/936402 | 12:03 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Update the LRP gateway_mtu when the external network changes https://review.opendev.org/c/openstack/neutron/+/936723 | 12:08 |
opendevreview | Merged openstack/ovn-bgp-agent stable/2023.2: Move devstack job to experimental https://review.opendev.org/c/openstack/ovn-bgp-agent/+/936403 | 12:13 |
ralonsoh | ykarel, I thought https://review.opendev.org/c/openstack/neutron/+/936429/4/zuul.d/tempest-singlenode.yaml#819 was enough to make the job dependant on this project | 12:14 |
ralonsoh | but I don't see this specific patch being executed in the CI | 12:14 |
ykarel | ralonsoh, sorry didn't got that | 12:31 |
ykarel | you mean depends-on not working? | 12:32 |
ykarel | ok i see | 12:35 |
ykarel | so depends-on is working but you missed to apply that at required place | 12:35 |
ykarel | commented on devstack patch | 12:35 |
opendevreview | yatin proposed openstack/tap-as-a-service stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/tap-as-a-service/+/936725 | 12:49 |
opendevreview | Merged openstack/neutron stable/2024.1: Add policy enforcer for QoS policy "tags" service plugin https://review.opendev.org/c/openstack/neutron/+/936342 | 12:51 |
ralonsoh | ykarel, ahhhh right! | 12:52 |
ralonsoh | thanks! | 12:52 |
opendevreview | yatin proposed openstack/tap-as-a-service stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/tap-as-a-service/+/936726 | 12:52 |
opendevreview | yatin proposed openstack/neutron-vpnaas stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/neutron-vpnaas/+/936727 | 12:54 |
opendevreview | yatin proposed openstack/neutron-vpnaas stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/neutron-vpnaas/+/936728 | 13:00 |
opendevreview | yatin proposed openstack/networking-bagpipe stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bagpipe/+/936729 | 13:02 |
opendevreview | yatin proposed openstack/networking-bagpipe stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bagpipe/+/936730 | 13:03 |
opendevreview | yatin proposed openstack/networking-bgpvpn stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bgpvpn/+/936731 | 13:04 |
opendevreview | yatin proposed openstack/networking-bgpvpn stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bgpvpn/+/936732 | 13:05 |
opendevreview | yatin proposed openstack/networking-sfc stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-sfc/+/936734 | 13:13 |
opendevreview | yatin proposed openstack/networking-sfc stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-sfc/+/936735 | 13:14 |
opendevreview | yatin proposed openstack/neutron-dynamic-routing stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/936737 | 13:18 |
opendevreview | yatin proposed openstack/neutron-dynamic-routing stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/936738 | 13:19 |
opendevreview | yatin proposed openstack/neutron-vpnaas stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/neutron-vpnaas/+/936728 | 13:21 |
opendevreview | yatin proposed openstack/neutron-fwaas stable/2024.2: Account for iptables-save output spacing differences https://review.opendev.org/c/openstack/neutron-fwaas/+/936739 | 13:28 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Update the LRP gateway_mtu when the external network changes https://review.opendev.org/c/openstack/neutron/+/936723 | 14:04 |
ykarel | slaweq, ralonsoh when you get chance https://review.opendev.org/c/openstack/neutron-lib/+/936265 | 14:18 |
ralonsoh | sure | 14:18 |
ralonsoh | ykarel, is it needed zuul_work_dir? | 14:19 |
ralonsoh | you dropped it in the neutron patch | 14:20 |
ralonsoh | do we need it in n-lib? | 14:20 |
ykarel | ralonsoh, yes it's needed as we want to run neutron tests there | 14:21 |
ykarel | in that job | 14:21 |
ralonsoh | ahh yes, right, by default the work dir should be n-lib | 14:21 |
ralonsoh | +1 | 14:21 |
ykarel | also some stadium job fixes https://review.opendev.org/q/topic:%22stadium-stable-jobs%22 | 14:27 |
ykarel | lajoskatona, ralonsoh slaweq ^ | 14:27 |
ralonsoh | yeah, I have them open | 14:27 |
ralonsoh | waiting for the CI | 14:27 |
ykarel | k thx, some of those reported | 14:27 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Improve initial hash ring setup https://review.opendev.org/c/openstack/neutron/+/936428 | 14:44 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: DNM - Test "neutron-ovn-tempest-ipv6-only-ovs*" with 4 workers https://review.opendev.org/c/openstack/neutron/+/936429 | 14:44 |
amnik | ralonsoh: Hello | 14:46 |
amnik | ralonsoh: Can we discuss https://bugs.launchpad.net/neutron/+bug/2089726 a bit now? | 14:46 |
opendevreview | Merged openstack/neutron stable/2023.2: Filter out the floating IPs when removing a shared RBAC https://review.opendev.org/c/openstack/neutron/+/936014 | 14:46 |
ralonsoh | amnik, sure | 14:47 |
amnik | rolonsoh: It relates to your comment on https://review.opendev.org/c/openstack/ovsdbapp/+/936327 | 14:47 |
ralonsoh | I know, yes | 14:47 |
ralonsoh | if you need to improve the datapath provisioning, improve this method | 14:48 |
ralonsoh | but your change has implications in all OVN DB events | 14:48 |
ralonsoh | not only the datapath one | 14:48 |
ralonsoh | apart from that, why do you want to execute several provisioning operations in parallel if there is a sync lock? | 14:49 |
ralonsoh | doesn't make any sense | 14:49 |
amnik | yes but provision is called in run method of event that call by EventHandler | 14:50 |
ralonsoh | that's exactly what I'm saying | 14:50 |
amnik | rolonsoh: This is the case, if run method execute one by one, why should we use sync lock? | 14:51 |
ralonsoh | that code was initially implemented 7 years ago | 14:52 |
ralonsoh | I would need to revisit the original patch in n-ovn | 14:52 |
ralonsoh | that is used to avoid calling the metadata provisioning during a resync | 14:54 |
ralonsoh | that's all | 14:54 |
amnik | this lock is read_lock so multiple reader can execute provision. right? | 14:54 |
ralonsoh | most probably but this code is purely python | 14:54 |
amnik | then if run execute parrallely, it improve performance | 14:54 |
ralonsoh | what is the advantage of using multiple threads there? | 14:55 |
ralonsoh | "it improve performance" I need figures | 14:55 |
ralonsoh | 1) if you want to improve this operation, parallelize this code in the agent, not ovsdbapp | 14:56 |
ralonsoh | 2) show figures to probe that this implementation truly improves the performance | 14:56 |
amnik | event that comes put in queue parrallely but consuming them happend sequentially. | 14:59 |
ralonsoh | so implement a paralelization model there: use a queue, each run will add a new event to the queue and a thread pool processing the dp provisioning | 15:00 |
ralonsoh | again, I'm not approving the ovsdbapp, the implications in the Neutron code are critical and these are not tested at all | 15:01 |
amnik | I think improvment in case of OVN agent is that ovnmeta will created more quickly | 15:02 |
amnik | rolonsoh: I get your point! | 15:02 |
amnik | you say that use queue in agent and parrallely execute the events in agent not ovsdbapp. right? | 15:04 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Improve initial hash ring setup https://review.opendev.org/c/openstack/neutron/+/936428 | 15:06 |
opendevreview | Rodolfo Alonso proposed openstack/neutron master: DNM - Test "neutron-ovn-tempest-ipv6-only-ovs*" with 4 workers https://review.opendev.org/c/openstack/neutron/+/936429 | 15:06 |
opendevreview | Merged openstack/networking-bgpvpn stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bgpvpn/+/936731 | 16:13 |
opendevreview | Merged openstack/neutron-vpnaas stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/neutron-vpnaas/+/936728 | 16:14 |
opendevreview | Merged openstack/neutron-dynamic-routing stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/936738 | 16:31 |
opendevreview | Merged openstack/networking-bgpvpn stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bgpvpn/+/936732 | 16:59 |
opendevreview | Merged openstack/networking-sfc stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-sfc/+/936734 | 17:00 |
opendevreview | Merged openstack/tap-as-a-service stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/tap-as-a-service/+/936725 | 17:01 |
opendevreview | Merged openstack/tap-as-a-service stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/tap-as-a-service/+/936726 | 17:01 |
opendevreview | Merged openstack/networking-sfc stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-sfc/+/936735 | 17:02 |
opendevreview | Merged openstack/networking-bagpipe stable/2024.1: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bagpipe/+/936729 | 17:04 |
opendevreview | Merged openstack/networking-bagpipe stable/2023.2: Stable Only: Use branched tempest jobs https://review.opendev.org/c/openstack/networking-bagpipe/+/936730 | 17:04 |
opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider master: Member batch actions to increase performance https://review.opendev.org/c/openstack/ovn-octavia-provider/+/936765 | 17:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!