| *** ralonsoh_out is now known as ralonsoh | 05:25 | |
| ralonsoh | haleyb, hello! I've realised that this Friday RedHat people have a "recharge day". We are not going to attend to the drivers meeting | 06:36 |
|---|---|---|
| ralonsoh | there is a topic added by jlibosvar | 06:36 |
| ralonsoh | but we won't be there this week | 06:36 |
| opendevreview | Rico Lin proposed openstack/neutron stable/2024.2: Fix ovn db sync with log resources https://review.opendev.org/c/openstack/neutron/+/950479 | 06:38 |
| opendevreview | Rico Lin proposed openstack/neutron master: Fix ovn db sync with log resources https://review.opendev.org/c/openstack/neutron/+/948053 | 06:39 |
| opendevreview | Rico Lin proposed openstack/neutron stable/2025.1: Fix ovn db sync with log resources https://review.opendev.org/c/openstack/neutron/+/950480 | 06:43 |
| LarsErikP | Hi. Does anyone here know anything about why this https://bugs.launchpad.net/ubuntu/+source/neutron-dynamic-routing/+bug/2090992 has not been released from proposed into updates in UCA? | 07:03 |
| opendevreview | Arnaud Morin proposed openstack/neutron master: Add TXT records to dnsmasq https://review.opendev.org/c/openstack/neutron/+/950486 | 07:12 |
| frickler | LarsErikP: as you can see from the tags, this is waiting for verification, maybe haleyb_ can check it. but also that is a matter to discuss with canonical, not in the upstream channel here | 07:19 |
| opendevreview | Renjing Xiao proposed x/whitebox-neutron-tempest-plugin master: Check per-vm isolation in rate limit test https://review.opendev.org/c/x/whitebox-neutron-tempest-plugin/+/950487 | 07:29 |
| LarsErikP | frickler: I always forget which channel is correct for UCA stuff : | 07:34 |
| LarsErikP | :p | 07:35 |
| LarsErikP | fwiw, I commented my "verification" in the bug as well. It works ;) | 07:36 |
| opendevreview | Rico Lin proposed openstack/neutron master: Fix ovn db sync with log resources https://review.opendev.org/c/openstack/neutron/+/948053 | 07:51 |
| frickler | semi-correct channel used to be #ubuntu-server but that's pretty much dead these days, too | 07:51 |
| frickler | (on libera) | 07:51 |
| opendevreview | Rico Lin proposed openstack/neutron stable/2024.2: Fix ovn db sync with log resources https://review.opendev.org/c/openstack/neutron/+/950479 | 08:00 |
| opendevreview | Rico Lin proposed openstack/neutron stable/2025.1: Fix ovn db sync with log resources https://review.opendev.org/c/openstack/neutron/+/950480 | 08:08 |
| ralonsoh | hi folks, please check https://review.opendev.org/c/openstack/neutron/+/949135 | 08:22 |
| ralonsoh | let's merge this before removing eventlet from the L3 agent | 08:22 |
| ralonsoh | that must work with both backends | 08:22 |
| opendevreview | Lajos Katona proposed openstack/neutron master: [eventlet-removal] DHCP: move RPC init to service.start phase https://review.opendev.org/c/openstack/neutron/+/950498 | 09:16 |
| opendevreview | Lajos Katona proposed openstack/neutron master: WIP: [eventlet-removal] remove eventlet references from dhcp_agent https://review.opendev.org/c/openstack/neutron/+/950499 | 09:16 |
| slaweq | ralonsoh I added one comment to that patch, other than this minor thing it looks good for me | 09:18 |
| ralonsoh | slaweq, thanks! | 09:19 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Move the RPC initialization to the ``Service.start`` phase https://review.opendev.org/c/openstack/neutron/+/949135 | 09:20 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [UT] Removal of eventlet from the unit tests https://review.opendev.org/c/openstack/neutron/+/950502 | 09:29 |
| opendevreview | Lajos Katona proposed openstack/neutron master: WIP: [eventlet-removal] remove eventlet references from dhcp_agent https://review.opendev.org/c/openstack/neutron/+/950499 | 10:03 |
| ralonsoh | lajoskatona, hello! https://review.opendev.org/c/openstack/neutron/+/950498 should not depend on oslo.service patch, I think | 10:12 |
| ralonsoh | actually no | 10:12 |
| lajoskatona | ralonsoh: yeah, I move that line to the next patch | 10:14 |
| opendevreview | Lajos Katona proposed openstack/neutron master: WIP: [eventlet-removal] remove eventlet references from dhcp_agent https://review.opendev.org/c/openstack/neutron/+/950499 | 10:14 |
| ralonsoh | lajoskatona, I've commented in the patch. You'll need most probably to call init_host in the UTs/FTs after creating the dhcp instance | 10:14 |
| ralonsoh | to have the rpc member | 10:15 |
| lajoskatona | ralonsoh: I check it, to tell the truth, I just started to check the test environments :-) | 10:15 |
| ralonsoh | no rush! just trying to help | 10:16 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [FT] Remove of eventlet from the functional tests https://review.opendev.org/c/openstack/neutron/+/950521 | 10:41 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider master: Fix LB disable/enable functionality https://review.opendev.org/c/openstack/ovn-octavia-provider/+/933879 | 10:41 |
| opendevreview | Stephen Finucane proposed openstack/neutron-lib master: Move mypy configuration to pyproject.toml https://review.opendev.org/c/openstack/neutron-lib/+/950522 | 10:43 |
| opendevreview | Stephen Finucane proposed openstack/neutron-lib master: pre-commit: Bump versions https://review.opendev.org/c/openstack/neutron-lib/+/950523 | 10:43 |
| opendevreview | Stephen Finucane proposed openstack/neutron-lib master: pre-commit: Migrate pep8 target to pre-commit https://review.opendev.org/c/openstack/neutron-lib/+/950524 | 10:43 |
| *** sfinucan is now known as stephenfin | 11:19 | |
| opendevreview | Sebastian Lohff proposed openstack/neutron-vpnaas master: Set service type when registering provider config https://review.opendev.org/c/openstack/neutron-vpnaas/+/950529 | 11:42 |
| opendevreview | Merged openstack/neutron-tempest-plugin master: Bump advance image to Ubuntu Jammy 22.04 https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/949140 | 12:04 |
| ralonsoh | ykarel, slaweq if you have some mins: https://review.opendev.org/c/openstack/neutron/+/949584 | 12:38 |
| ralonsoh | no rush, just whenever you have some time | 12:39 |
| haleyb_ | ralonsoh: thanks for the heads up. Someone from Canonical wanted to join but could not attend either, so next Friday seems better for everyone. | 12:40 |
| ralonsoh | haleyb_, yes, I think so | 12:41 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [FT] Remove of eventlet from the functional tests https://review.opendev.org/c/openstack/neutron/+/950521 | 13:12 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [UT] Removal of eventlet from the unit tests https://review.opendev.org/c/openstack/neutron/+/950502 | 13:13 |
| ralonsoh | stephenfin, about pre-commit\ | 13:16 |
| ralonsoh | https://review.opendev.org/c/openstack/neutron-lib/+/950524/1/.pre-commit-config.yaml#24 | 13:16 |
| ralonsoh | that replaces the pep8 job definition, right? | 13:17 |
| ralonsoh | Now we define everything in this file, with one single command line | 13:17 |
| stephenfin | ralonsoh: There is one thing missing: pylint. However, that does not appear to be doing anything from what I can tell? | 13:25 |
| stephenfin | Otherwise, yes. It replaces everything. We are using this pattern in the SDK team projects (and nova) for some time now. | 13:26 |
| stephenfin | https://github.com/openstack/nova/blob/221a3e89e8988bc664298106ee691a4e41ca71f9/tox.ini#L104-L111 | 13:26 |
| ralonsoh | stephenfin, we run pylint calling coding-checks | 13:28 |
| ralonsoh | I think that is missing | 13:29 |
| stephenfin | Okay, that can be done by pre-commit but it's not ideal since pylint requires every dependency be installed. I probably need to tweak that. | 13:29 |
| stephenfin | Do you have a list of pylint checks that you run (or have suggestions for how I can figure that out myself)? I wonder if ruff/flake8 would be good enough? | 13:30 |
| stephenfin | *ruff/flake8 + mypy | 13:30 |
| ralonsoh | we are now executing both flake8 and pylint | 13:31 |
| ralonsoh | I think you suggested to move to ruff, same as in SDK or CLI | 13:31 |
| ralonsoh | let me check what we are actually checking with pylint | 13:31 |
| haleyb_ | check .pylintrc :) | 13:32 |
| ralonsoh | right | 13:34 |
| ralonsoh | the coverage is limited to some tests (name formats, line length, etc) | 13:34 |
| ralonsoh | and we have plenty of exceptions | 13:34 |
| haleyb_ | we also do not strictly verify the test tree with pylint, it's up to people to notice things and manually address them. I have a few patches for that :) | 14:03 |
| haleyb_ | would maybe be good if we could somehow be less strict there, i think ruff allows that? | 14:04 |
| ralonsoh | I think that could be the next step, to migrate to ruff | 14:04 |
| haleyb_ | for example, pylint really dislikes lambda | 14:05 |
| * haleyb_ goes to find his patches | 14:05 | |
| haleyb_ | https://review.opendev.org/c/openstack/neutron/+/946855 and https://review.opendev.org/c/openstack/neutron/+/946001 | 14:07 |
| haleyb_ | it is never-ending work trying to keep the test tree pylint-clean | 14:07 |
| haleyb_ | and finding signature-mutators disable was a big win on warnings | 14:08 |
| haleyb_ | bcafarel: can you take a look at this backport chain? https://review.opendev.org/c/openstack/neutron/+/949852 - the n-t-p change depending on them is just about done (and green) - https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/906020 | 14:45 |
| bcafarel | haleyb_: sure, looking | 14:46 |
| haleyb_ | thanks! | 14:47 |
| ykarel | ralonsoh, done | 14:54 |
| ralonsoh | thanks! | 14:54 |
| TheJulia | o/ | 15:07 |
| TheJulia | Question for folks, has there been any thought about with the switch to the uwsgi launcher, what plugins trying to be loaded into neutron should do since the uwsgi load pattern doesn't seem to respect/honor/use the legacy config files pattern | 15:08 |
| TheJulia | specifically, it looks like upon process launch, the files are auto-determined in https://github.com/openstack/neutron/blob/master/neutron/server/__init__.py#L38 | 15:08 |
| TheJulia | Specifically, a number of ironic's jobs are now broken since being forced to switch to uwsgi, and it appears rooted in that the main process launches without the additional configuration set by the plugin https://e3fa69918ab3893f89a3-76ad47885070581f857a540cadaa6a6d.ssl.cf1.rackcdn.com/openstack/55cf2727b4c54f06b897353cf71ea0a3/controller/logs/screen-neutron-api.txt because it is auto-detected and not otherwise passed. | 15:12 |
| TheJulia | Where as when I look at another service launching using the prior code path with the configuration files, I see the genericswitch ml2 plugin being passed in from the plugin | 15:12 |
| TheJulia | https://e3fa69918ab3893f89a3-76ad47885070581f857a540cadaa6a6d.ssl.cf1.rackcdn.com/openstack/55cf2727b4c54f06b897353cf71ea0a3/controller/logs/screen-neutron-rpc-server.txt | 15:12 |
| stephenfin | haleyb_: Sorry, missed the replies. The good news (IMO) is that a lot of those look like things that mypy or pyupgrade would catch | 15:44 |
| stephenfin | Certainly, things like initialising a variable to None when it will always later be assigned as a dict are mypy's (and other type checkers) bread and butter | 15:45 |
| haleyb_ | stephenfin: yeah, we're pretty good in the code side of the tree, testing is ad-hoc but i occasionally run against everything and clean things up. anything to make life easier and not allow simple issues into the tree is goodness | 15:47 |
| stephenfin | In case it helps, we're using ruff in the SDK projects for some time now and it's been amazing. We have the UP and S rules enabled alongside the default set so we have been able to replace pyupgrade, bandit and most of flake8 (we just keep the hacking specific checks enabled for now, though I've a TODO to turn my hand to some rust and add them to ruff eventually) | 15:49 |
| haleyb_ | oh, even bandit, we run that as well | 15:50 |
| haleyb_ | $time is the only factor | 15:51 |
| opendevreview | Stephen Finucane proposed openstack/neutron-lib master: pre-commit: Migrate pep8 target to pre-commit https://review.opendev.org/c/openstack/neutron-lib/+/950524 | 16:44 |
| opendevreview | Stephen Finucane proposed openstack/neutron-lib master: tests: Stop using ddt https://review.opendev.org/c/openstack/neutron-lib/+/950575 | 16:44 |
| opendevreview | Stephen Finucane proposed openstack/neutron-lib master: pre-commit: Migrate pep8 target to pre-commit https://review.opendev.org/c/openstack/neutron-lib/+/950524 | 16:45 |
| opendevreview | Stephen Finucane proposed openstack/neutron-lib master: tests: Stop using ddt https://review.opendev.org/c/openstack/neutron-lib/+/950575 | 16:45 |
| opendevreview | Merged openstack/neutron master: [OVN] OVN agent retrieval filter matching improvement https://review.opendev.org/c/openstack/neutron/+/949584 | 17:00 |
| opendevreview | Merged openstack/neutron stable/2024.2: [OVN] Support address group for ovn driver https://review.opendev.org/c/openstack/neutron/+/949852 | 17:14 |
| opendevreview | Merged openstack/neutron stable/2024.1: [OVN] Support address group for ovn driver https://review.opendev.org/c/openstack/neutron/+/949854 | 17:14 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: Fix some pylint warnings in the test tree https://review.opendev.org/c/openstack/neutron/+/946001 | 17:17 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: pyupgrade changes for Python3.10+ https://review.opendev.org/c/openstack/neutron/+/946855 | 17:17 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: Move mypy configuration to pyproject.toml https://review.opendev.org/c/openstack/neutron/+/950578 | 17:17 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: pre-commit: Bump versions https://review.opendev.org/c/openstack/neutron/+/950579 | 17:17 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: pre-commit: Migrate to ruff, enable autopep8 https://review.opendev.org/c/openstack/neutron/+/950580 | 17:17 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: tox: Fix indentation https://review.opendev.org/c/openstack/neutron/+/950581 | 17:17 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: trivial: Autofix low-hanging linter failures https://review.opendev.org/c/openstack/neutron/+/950582 | 17:17 |
| -opendevstatus- NOTICE: Gerrit is being updated to the latest 3.10 bugfix release as part of early prep work for an eventual 3.11 upgrade. Gerrit will be offline momentarily while it restarts on the new version. | 17:34 | |
| opendevreview | Merged openstack/neutron-lib master: Move mypy configuration to pyproject.toml https://review.opendev.org/c/openstack/neutron-lib/+/950522 | 18:51 |
| opendevreview | Merged openstack/neutron-lib master: pre-commit: Bump versions https://review.opendev.org/c/openstack/neutron-lib/+/950523 | 18:51 |
| opendevreview | Elvira García Ruiz proposed openstack/neutron master: [WIP] Consider logging options when using OVNdbsync https://review.opendev.org/c/openstack/neutron/+/948783 | 21:03 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!