| opendevreview | OpenStack Proposal Bot proposed openstack/neutron-vpnaas-dashboard master: Imported Translations from Zanata https://review.opendev.org/c/openstack/neutron-vpnaas-dashboard/+/956318 | 03:43 |
|---|---|---|
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Check LSP is subport before removing it from the trunk https://review.opendev.org/c/openstack/neutron/+/956336 | 07:06 |
| opendevreview | Merged openstack/neutron-vpnaas-dashboard master: Imported Translations from Zanata https://review.opendev.org/c/openstack/neutron-vpnaas-dashboard/+/956318 | 07:14 |
| ykarel | slaweq, hi can you check https://review.opendev.org/c/openstack/neutron/+/955987, should unblock other on top patches | 07:22 |
| ralonsoh | ^^ thanks in advance! | 07:29 |
| slaweq | done | 07:31 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Provide the extension name to ``OVNExtensionEvent`` classes https://review.opendev.org/c/openstack/neutron/+/956173 | 07:32 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Spread OVN metadata agent heartbeat response in time https://review.opendev.org/c/openstack/neutron/+/956174 | 07:32 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Handle creation of Port_Binding with chassis set (2) https://review.opendev.org/c/openstack/neutron/+/956177 | 07:32 |
| ralonsoh | I've update the 5th patch and rebased the upper ones too | 07:33 |
| opendevreview | Merged openstack/neutron master: [doc] Document the L3 QoS support in Neutron https://review.opendev.org/c/openstack/neutron/+/954911 | 07:42 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-tempest-plugin master: Skip multi GW router update if IP in use https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/956341 | 08:41 |
| ralonsoh | slaweq, ykarel ^ a quick review if possible. More context in https://bugs.launchpad.net/neutron/+bug/2117383/comments/1 | 08:42 |
| ralonsoh | a rare coincidence, but the GW port IP deleted and reused again was, between these two operations, assigned to another GW port router | 08:42 |
| ralonsoh | stephenfin, hello! I have one question related to https://review.opendev.org/c/openstack/neutron/+/950580. Since this patch, we no longer execute the flake8 local plugin tests | 10:07 |
| ralonsoh | is it possible to refactor this for pylint, for example? | 10:07 |
| stephenfin | Oh really? It should. I've enabled the N checks https://review.opendev.org/c/openstack/neutron/+/950580/4/tox.ini#199 | 10:08 |
| stephenfin | Let me take a look | 10:08 |
| ralonsoh | stephenfin, ahhh hold on, the "hacking" step | 10:11 |
| ralonsoh | my bad... | 10:11 |
| ralonsoh | all fine! | 10:11 |
| stephenfin | phew | 10:11 |
| ralonsoh | this is because I'm checking other networking project that still used flake8 and I'm not able to execute the local plugins | 10:11 |
| ralonsoh | so I'm trying to compare to neutron, but both configs are different | 10:12 |
| stephenfin | The use of neutron and neutron-lib as dependencies is odd though. I didn't pay attention to that previously | 10:14 |
| stephenfin | That means changes to the local copies of these files don't get reflected until they are released | 10:14 |
| stephenfin | We don't do that in SDK | 10:14 |
| ralonsoh | yeah but the plugin is local | 10:14 |
| stephenfin | That's okay. But you need to override the Python path | 10:15 |
| stephenfin | https://github.com/openstack/openstacksdk/blob/master/tox.ini#L153-L157 | 10:15 |
| ralonsoh | yes, this is missing in networking-sfc | 10:16 |
| stephenfin | Is there a reason the neutron-lib extensions aren't published? I assume that the expectation is that they would be consumed by other projects? | 10:17 |
| ralonsoh | stephenfin, where should be published? in the entry points? | 10:17 |
| stephenfin | yes https://github.com/openstack/hacking/blob/master/setup.cfg#L35-L64 | 10:18 |
| ralonsoh | ooook, so I'll push a patch right no | 10:18 |
| ralonsoh | now* | 10:18 |
| ralonsoh | stephenfin, last question: where did you move https://review.opendev.org/c/openstack/neutron/+/950580/4/tox.ini#b243? | 10:21 |
| stephenfin | Double check this but iirc it's not needed since 'select = H' enables *all* checks, including optional ones | 10:22 |
| * stephenfin puts vim configuration in the files to confirm that | 10:22 | |
| ralonsoh | ahhh ok, right | 10:23 |
| stephenfin | Nope, I'm wrong. Err... I've been doing that for a while. I better go back and check where else I've done this /o\ | 10:25 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: Re-enable optional hacking checks https://review.opendev.org/c/openstack/neutron/+/956349 | 10:26 |
| stephenfin | ralonsoh: sorry about that :( | 10:26 |
| opendevreview | Stephen Finucane proposed openstack/neutron master: pre-commit: Use local neutron hacking checks https://review.opendev.org/c/openstack/neutron/+/956350 | 10:32 |
| stephenfin | that should depend on your patch to publish checks from neutron-lib ^ | 10:32 |
| ralonsoh | cool, on my way! | 10:32 |
| opendevreview | Merged openstack/neutron master: [OVN] Fix OVN agent register process https://review.opendev.org/c/openstack/neutron/+/955987 | 10:33 |
| opendevreview | Rodolfo Alonso proposed openstack/networking-sfc master: Fix the H999 flake8 local plugin https://review.opendev.org/c/openstack/networking-sfc/+/956351 | 10:34 |
| stephenfin | ack, I marked it as -W with a description of necessary steps to remove -W | 10:34 |
| opendevreview | Lajos Katona proposed openstack/networking-sfc master: DNM: test evntlet import https://review.opendev.org/c/openstack/networking-sfc/+/955751 | 10:34 |
| ralonsoh | lajoskatona, ^^ | 10:34 |
| stephenfin | ralonsoh: the other obvious question is: do any of these belong in hacking proper? | 10:35 |
| ralonsoh | I think so, yes | 10:36 |
| stephenfin | eventlet removal is a community wide goal, and some of those other checks looks widely applicable (or already have variants in hacking) like the assertion ones | 10:36 |
| stephenfin | in fact I'd wager every one of those neutron and neutron-lib checks look sensible bar the nnes with neutron in their name | 10:37 |
| stephenfin | *ones | 10:37 |
| ralonsoh | stephenfin, well, I would need to check one by one | 10:37 |
| ralonsoh | to be honest, some of these methods are from 2016 | 10:38 |
| stephenfin | ack, and it's definitly low-priority | 10:38 |
| lajoskatona | ralonsoh, stephenfin: reading..... | 10:52 |
| ralonsoh | lajoskatona, the -sfc project had an incorrect entry points definition | 10:55 |
| ralonsoh | lajoskatona, I pushed a new PS and your patch checking it on top | 10:55 |
| ralonsoh | it should fail now | 10:55 |
| ralonsoh | and actually if failing!! https://zuul.opendev.org/t/openstack/build/5f25cb286fd8441885eef098217caa89 | 10:56 |
| ralonsoh | (I need to fix the UTs of my patch) | 10:57 |
| lajoskatona | ralonsoh: cool | 10:58 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Add the hacking checks to the entry points https://review.opendev.org/c/openstack/neutron-lib/+/956353 | 11:00 |
| opendevreview | Merged openstack/neutron master: [OVN] OVN agents should clean up "Chassis_Private" tags https://review.opendev.org/c/openstack/neutron/+/955998 | 11:01 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: pre-commit: Use local neutron hacking checks https://review.opendev.org/c/openstack/neutron/+/956350 | 11:01 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Provide the extension name to ``OVNExtensionEvent`` classes https://review.opendev.org/c/openstack/neutron/+/956173 | 11:07 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Spread OVN metadata agent heartbeat response in time https://review.opendev.org/c/openstack/neutron/+/956174 | 11:07 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Handle creation of Port_Binding with chassis set (2) https://review.opendev.org/c/openstack/neutron/+/956177 | 11:07 |
| opendevreview | Merged openstack/neutron master: [OVN] The OVN agent should handle its own tags and status https://review.opendev.org/c/openstack/neutron/+/956147 | 11:18 |
| opendevreview | Merged openstack/neutron master: [OVN] The OVN agent should be able to re-register https://review.opendev.org/c/openstack/neutron/+/956148 | 11:18 |
| opendevreview | Rodolfo Alonso proposed openstack/networking-sfc master: Fix the H999 flake8 local plugin https://review.opendev.org/c/openstack/networking-sfc/+/956351 | 11:29 |
| opendevreview | Elod Illes proposed openstack/networking-bgpvpn unmaintained/xena: [CI] Remove tripleo-ci-centos-8-scenario004-standalone job https://review.opendev.org/c/openstack/networking-bgpvpn/+/956358 | 11:59 |
| opendevreview | Merged openstack/neutron-tempest-plugin master: Skip multi GW router update if IP in use https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/956341 | 13:06 |
| ykarel | haleyb, lajoskatona can you check https://review.opendev.org/c/openstack/neutron/+/956173 and https://review.opendev.org/c/openstack/neutron/+/956174 last in the series | 14:03 |
| ykarel | slaweq, can you check https://review.opendev.org/c/x/tobiko/+/955769 ready now | 14:32 |
| opendevreview | Elod Illes proposed openstack/networking-bgpvpn unmaintained/wallaby: [CI] Remove tripleo-ci-centos-8-scenario004-standalone job https://review.opendev.org/c/openstack/networking-bgpvpn/+/956379 | 14:53 |
| opendevreview | Jakub Libosvar proposed openstack/neutron-specs master: Propose spec for OVN BGP integration https://review.opendev.org/c/openstack/neutron-specs/+/952872 | 15:32 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Add the hacking checks to the entry points https://review.opendev.org/c/openstack/neutron-lib/+/956353 | 16:47 |
| opendevreview | Merged openstack/neutron master: [OVN] Provide the extension name to ``OVNExtensionEvent`` classes https://review.opendev.org/c/openstack/neutron/+/956173 | 19:44 |
| opendevreview | Merged openstack/neutron master: [OVN] Spread OVN metadata agent heartbeat response in time https://review.opendev.org/c/openstack/neutron/+/956174 | 19:51 |
| opendevreview | Merged openstack/neutron master: [OVN] Handle creation of Port_Binding with chassis set (2) https://review.opendev.org/c/openstack/neutron/+/956177 | 21:12 |
| -opendevstatus- NOTICE: All OpenDev IRC and Matrix bots will be offline briefly (including channel logging and meeting management) in order to move them to a newer server | 23:50 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!