| *** zseguin is now known as Guest14350 | 07:21 | |
| opendevreview | Slawek Kaplonski proposed openstack/neutron-tempest-plugin master: [FWaaS] Add basic scenario test for FW attached to L2 ports https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/995695 | 07:41 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/neutron-lib master: Remove support for hacking < 2.0.0 https://review.opendev.org/c/openstack/neutron-lib/+/999057 | 07:47 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-fwaas master: Remove dead ``local-check-factory`` from tox.ini https://review.opendev.org/c/openstack/neutron-fwaas/+/999063 | 08:12 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-vpnaas master: Remove dead ``local-check-factory`` from tox.ini https://review.opendev.org/c/openstack/neutron-vpnaas/+/999064 | 08:13 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-dynamic-routing master: Remove dead ``local-check-factory`` from tox.ini https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/999065 | 08:13 |
| ralonsoh | tkajinam, ^^ | 08:13 |
| ralonsoh | I've commented in your patch and added these 3 patches | 08:14 |
| opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: hacking: remove N524 check from tox.ini https://review.opendev.org/c/openstack/tap-as-a-service/+/999066 | 08:21 |
| opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: Extract DB model classes into models https://review.opendev.org/c/openstack/tap-as-a-service/+/995059 | 08:22 |
| opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: Remove nested DB context decorators from private getter methods https://review.opendev.org/c/openstack/tap-as-a-service/+/995060 | 08:22 |
| opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: Introduce OVO objects for TaaS resources https://review.opendev.org/c/openstack/tap-as-a-service/+/995061 | 08:22 |
| opendevreview | Lajos Katona proposed openstack/tap-as-a-service master: Use new OVO classes in Taas_db_Mixin https://review.opendev.org/c/openstack/tap-as-a-service/+/998629 | 08:22 |
| opendevreview | Lajos Katona proposed openstack/networking-bagpipe master: hacking: remove N524 check from tox.ini https://review.opendev.org/c/openstack/networking-bagpipe/+/999067 | 08:25 |
| opendevreview | Lajos Katona proposed openstack/networking-bgpvpn master: hacking: remove N524 check from tox.ini https://review.opendev.org/c/openstack/networking-bgpvpn/+/999068 | 08:28 |
| lajoskatona | ralonsoh: I pushed similar patches for taas, bgpvpn & bagpipe to remove check_no_contextlib_nested hacking rule from tox.ini (https://review.opendev.org/q/topic:%22remove_dead_code%22+owner:katonalala@gmail.com ) | 08:31 |
| ralonsoh | lajoskatona, thanks! | 08:31 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Add ``security-groups-name-restrictions`` API extension https://review.opendev.org/c/openstack/neutron-lib/+/999069 | 08:35 |
| ralonsoh | lajoskatona, actually the `local-plugins` section should be removed in these 3 projects | 08:39 |
| ralonsoh | they are importing n-lib checks | 08:40 |
| ralonsoh | but these are already registered by n-lib as a dependency | 08:40 |
| ralonsoh | so it is redundant | 08:40 |
| ralonsoh | tkajinam, ^^ Am I right?? | 08:40 |
| ralonsoh | or stephenfin | 08:40 |
| ralonsoh | e.g.: https://review.opendev.org/c/openstack/networking-bgpvpn/+/999068/1/tox.ini | 08:41 |
| ralonsoh | this `[flake8:local-plugins]` is unnecessary if I'm not wrong | 08:41 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: ai: Add code-review agent guide https://review.opendev.org/c/openstack/neutron/+/996106 | 08:42 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: ai: Add Launchpad bug triage agent https://review.opendev.org/c/openstack/neutron/+/996231 | 08:42 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: ai: Add git commit message formatting agent https://review.opendev.org/c/openstack/neutron/+/996233 | 08:42 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Add agnostic WSGI support for API worker election and identification https://review.opendev.org/c/openstack/neutron/+/995666 | 08:42 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Add mod_wsgi support to ``get_api_worker_count()`` https://review.opendev.org/c/openstack/neutron/+/995800 | 08:43 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Make ``get_start_time()`` server-agnostic https://review.opendev.org/c/openstack/neutron/+/995802 | 08:43 |
| opendevreview | Elvira García Ruiz proposed openstack/neutron master: Manage PVLAN PGs in OVN after PVLAN plugin is enabled or disabled https://review.opendev.org/c/openstack/neutron/+/998184 | 08:46 |
| tkajinam | lajoskatona, ralonsoh checking | 08:57 |
| lajoskatona | ralonsoh, tkajinam: ok, thanks | 08:58 |
| opendevreview | Doug Goldstein proposed openstack/neutron master: Reject overlapping network segment ranges for tunnel types https://review.opendev.org/c/openstack/neutron/+/998561 | 09:02 |
| tkajinam | lajoskatona, I agree with ralonsoh and we don't need local-plugin. it's required use plugins from local directory, but in this case these come from neutron-lib which is installed in venv | 09:06 |
| tkajinam | one strange thing is that some of the checks such as N521 is off-by-default but is not enabled... | 09:06 |
| tkajinam | side note: hacking 6.x is not compatible with Python 3.14 and we have to update it to 7.x during next cycle, when we migrate pep8 jobs to ubuntu 26.04 | 09:07 |
| opendevreview | Takashi Kajinami proposed openstack/tap-as-a-service master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/tap-as-a-service/+/999070 | 09:13 |
| opendevreview | Takashi Kajinami proposed openstack/neutron-fwaas master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-fwaas/+/999071 | 09:15 |
| opendevreview | Takashi Kajinami proposed openstack/neutron-vpnaas master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-vpnaas/+/999073 | 09:18 |
| opendevreview | Takashi Kajinami proposed openstack/neutron-dynamic-routing master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/999074 | 09:19 |
| opendevreview | Takashi Kajinami proposed openstack/neutron-dynamic-routing master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/999074 | 09:21 |
| opendevreview | Takashi Kajinami proposed openstack/neutron-vpnaas master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-vpnaas/+/999073 | 09:21 |
| opendevreview | Takashi Kajinami proposed openstack/neutron-fwaas master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-fwaas/+/999071 | 09:21 |
| opendevreview | Takashi Kajinami proposed openstack/tap-as-a-service master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/tap-as-a-service/+/999070 | 09:21 |
| opendevreview | Takashi Kajinami proposed openstack/neutron master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron/+/999075 | 09:22 |
| opendevreview | Florian Streibelt proposed openstack/neutron master: Allow setting a service name different from dnsmasq in DhcpLocalProcess https://review.opendev.org/c/openstack/neutron/+/999078 | 10:01 |
| opendevreview | Merged openstack/tap-as-a-service master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/tap-as-a-service/+/999070 | 10:01 |
| opendevreview | Premysl Kouril proposed openstack/neutron-vpnaas-dashboard master: Fix router name and connections expansion in VPN services table https://review.opendev.org/c/openstack/neutron-vpnaas-dashboard/+/999079 | 10:13 |
| ralonsoh | lajoskatona, ^ please check this one | 10:18 |
| ralonsoh | this is related to https://review.opendev.org/c/openstack/neutron-vpnaas-dashboard/+/960388 | 10:18 |
| ralonsoh | if valid, we'll need to backport it to 2026.1 | 10:19 |
| opendevreview | Florian Streibelt proposed openstack/neutron master: Allow setting a service name different from dnsmasq in DhcpLocalProcess https://review.opendev.org/c/openstack/neutron/+/999078 | 10:23 |
| opendevreview | Lajos Katona proposed openstack/networking-bgpvpn master: hacking: enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/networking-bgpvpn/+/999068 | 10:29 |
| opendevreview | Lajos Katona proposed openstack/networking-bagpipe master: hacking: remove N524 check from tox.ini https://review.opendev.org/c/openstack/networking-bagpipe/+/999067 | 10:30 |
| opendevreview | Lajos Katona proposed openstack/networking-bagpipe master: hacking: enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/networking-bagpipe/+/999067 | 10:30 |
| opendevreview | Merged openstack/neutron-lib master: Sanitize provided MAC address in convert_to_mac_if_none https://review.opendev.org/c/openstack/neutron-lib/+/998473 | 10:32 |
| opendevreview | Merged openstack/neutron-dynamic-routing master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/999074 | 10:44 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Validate RBAC ``target_project`` as UUID or wildcard https://review.opendev.org/c/openstack/neutron/+/998537 | 10:48 |
| opendevreview | Merged openstack/neutron-vpnaas master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-vpnaas/+/999073 | 10:56 |
| opendevreview | Merged openstack/ovn-octavia-provider master: Fix LB creation with --vip-port-id https://review.opendev.org/c/openstack/ovn-octavia-provider/+/997099 | 10:58 |
| opendevreview | Merged openstack/neutron-fwaas master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron-fwaas/+/999071 | 10:58 |
| *** ralonsoh_ is now known as ralonsoh | 11:01 | |
| opendevreview | Terry Wilson proposed openstack/neutron master: Use API-defined has_lock in BGP code https://review.opendev.org/c/openstack/neutron/+/998343 | 11:04 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Add ``security-groups-name-restrictions`` API extension https://review.opendev.org/c/openstack/neutron-lib/+/999069 | 11:18 |
| opendevreview | Takashi Kajinami proposed openstack/networking-bagpipe master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/networking-bagpipe/+/999097 | 12:31 |
| opendevreview | Takashi Kajinami proposed openstack/networking-bgpvpn master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/networking-bgpvpn/+/999098 | 12:32 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron-tempest-plugin master: [FWaaS] Add basic scenario test for FW attached to L2 ports https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/995695 | 12:32 |
| opendevreview | Takashi Kajinami proposed openstack/networking-sfc master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/networking-sfc/+/999100 | 12:33 |
| tkajinam | oh sorry the same was already proposed. I'll abandone these | 12:34 |
| opendevreview | Merged openstack/neutron master: Reject overlapping network segment ranges for tunnel types https://review.opendev.org/c/openstack/neutron/+/998561 | 12:41 |
| opendevreview | Mohsen Sepandar proposed openstack/neutron-fwaas master: Enable fwaas_v2 driver in DVR mode https://review.opendev.org/c/openstack/neutron-fwaas/+/989857 | 12:50 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider stable/2026.1: Fix LB creation with --vip-port-id https://review.opendev.org/c/openstack/ovn-octavia-provider/+/999113 | 13:22 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider stable/2025.2: Fix LB creation with --vip-port-id https://review.opendev.org/c/openstack/ovn-octavia-provider/+/999114 | 13:23 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron-tempest-plugin master: [FWaaS] Add basic scenario test for FW attached to L2 ports https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/995695 | 13:24 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider stable/2025.1: Fix LB creation with --vip-port-id https://review.opendev.org/c/openstack/ovn-octavia-provider/+/999115 | 13:27 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron-specs master: Add spec for the indirect Floating IPs https://review.opendev.org/c/openstack/neutron-specs/+/996269 | 13:29 |
| opendevreview | Doug Goldstein proposed openstack/neutron stable/2026.1: Reject overlapping network segment ranges for tunnel types https://review.opendev.org/c/openstack/neutron/+/998930 | 13:34 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider stable/2025.2: Fix LB creation with --vip-port-id https://review.opendev.org/c/openstack/ovn-octavia-provider/+/999114 | 13:43 |
| opendevreview | Fernando Royo proposed openstack/ovn-octavia-provider stable/2026.1: Fix LB creation with --vip-port-id https://review.opendev.org/c/openstack/ovn-octavia-provider/+/999113 | 13:44 |
| opendevreview | Florian Streibelt proposed openstack/neutron master: Allow setting a service name different from dnsmasq in DhcpLocalProcess https://review.opendev.org/c/openstack/neutron/+/999078 | 13:44 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999131 | 14:11 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/2026.1: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999132 | 14:11 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/2025.2: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999133 | 14:12 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron stable/2025.1: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999134 | 14:12 |
| ralonsoh | slaweq, I need quick reviews on these 4 patches | 14:12 |
| slaweq | ralonsoh: done | 14:24 |
| ralonsoh | thanks! | 14:24 |
| slaweq | but I also added comment in the patch for master branch | 14:24 |
| ralonsoh | slaweq, what should we use there? | 14:25 |
| ralonsoh | slaweq, do you mean by adding a policy to check if the user is admin and check the parent resource project? | 14:27 |
| slaweq | ralonsoh: from quick looking I think we should update policy in https://github.com/openstack/neutron/blob/master/neutron/conf/policies/subnetpool.py#L238 to have something like "RULE_ADMIN_OR_PARENT_OWNER" or something like that | 14:29 |
| ralonsoh | slaweq, but this could be overridden by a custom policy | 14:30 |
| slaweq | as many other things | 14:30 |
| ralonsoh | this check, IMO, must be done always and cannot be unset | 14:30 |
| slaweq | but then it is up to the cloud operator, right? | 14:30 |
| ralonsoh | yes, it is, but I'm not sure that if a cloud operator will be aware of this potential issue | 14:31 |
| slaweq | one of the goals of "S-RBAC" feature was to get rid of hardcoded checks and such validations in policies | 14:31 |
| slaweq | operator already can do many more dangareus things by doing custom policies probably | 14:32 |
| ralonsoh | then we would need to create a document for potential issues | 14:32 |
| ralonsoh | I'm OK with moving that to the policies | 14:32 |
| ralonsoh | as it belongs there | 14:32 |
| ralonsoh | but I would also create a document for "potential issues if you change the default policies" | 14:33 |
| slaweq | it is always dangerous to do custom policies | 14:33 |
| slaweq | that's why we provide default ones which are considered to be safe and good :) | 14:33 |
| ralonsoh | Ok, as you commented, I would first fix the issue (thanks for the +2). I'll propose another patch with the policy change + doc | 14:33 |
| slaweq | regarding "potential issues if you change the default policies" the guide would be short IMO, just somethign like: "with custom policies you may expose everything to everyone" :) | 14:34 |
| ralonsoh | heheheh I know, but at least to document what we know that could be an issue, like for example this CVE | 14:34 |
| slaweq | I don't think such doc is needed really but you can add some note about it to https://docs.openstack.org/neutron/latest/admin/intro-api-srbac-policies.html | 14:36 |
| frickler | looks like the designate job is failing for those fixes, not sure if related or not, I cannot dig deeper myself right now https://zuul.opendev.org/t/openstack/build/548538a4b1a64e1d8a5b716296f521c6 | 15:00 |
| frickler | oh, it was failing earlier today already, so likely unrelated. you'll likely want to make that non-voting as a workaround | 15:01 |
| ralonsoh | frickler, it failed twice in a row, but different errors, I think | 15:02 |
| frickler | I think it is the same, looks like designate itself is affected https://zuul.opendev.org/t/openstack/build/548538a4b1a64e1d8a5b716296f521c6/log/controller/logs/screen-designate-central.txt#1012-1092 | 15:07 |
| frickler | I've asked in the dns channel to verify but I assume oschwart is already trying to work on this with https://review.opendev.org/c/openstack/designate/+/999112 | 15:09 |
| frickler | seems it is not failing 100%, looking at https://zuul.opendev.org/t/openstack/builds?job_name=neutron-tempest-plugin-designate-scenario&skip=0 there was one failure some days ago, two today, but also still a lot of passing jobs | 15:23 |
| opendevreview | Elvira García Ruiz proposed openstack/neutron master: Manage PVLAN PGs in OVN after PVLAN plugin is enabled or disabled https://review.opendev.org/c/openstack/neutron/+/998184 | 16:08 |
| opendevreview | Doug Goldstein proposed openstack/neutron stable/2026.1: ovn: Don't wipe network HA_Chassis_Group on empty Gateway_Chassis https://review.opendev.org/c/openstack/neutron/+/999158 | 16:28 |
| opendevreview | Miro Tomaska proposed openstack/neutron master: Add upstream EVPN multinode Zuul job https://review.opendev.org/c/openstack/neutron/+/994257 | 16:59 |
| opendevreview | Miro Tomaska proposed openstack/neutron master: Add upstream EVPN multinode Zuul job https://review.opendev.org/c/openstack/neutron/+/994257 | 17:00 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: zuul: Make OVS multinode tempest jobs non-voting https://review.opendev.org/c/openstack/neutron/+/999159 | 17:06 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: zuul: Make OVS multinode tempest jobs non-voting https://review.opendev.org/c/openstack/neutron/+/999159 | 17:13 |
| opendevreview | Jakub Libosvar proposed openstack/neutron master: zuul: Make OVS multinode tempest jobs non-voting https://review.opendev.org/c/openstack/neutron/+/999159 | 17:14 |
| opendevreview | Helen Chen proposed openstack/neutron master: EVPN: Catch KeyError in OVS's EVPN config https://review.opendev.org/c/openstack/neutron/+/999163 | 17:21 |
| opendevreview | Merged openstack/neutron master: Enable hacking plugins from neutron-lib https://review.opendev.org/c/openstack/neutron/+/999075 | 17:48 |
| opendevreview | Miro Tomaska proposed openstack/neutron-tempest-plugin master: Add add and remove subnets between evpn routers https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/999166 | 18:12 |
| opendevreview | Helen Chen proposed openstack/neutron master: EVPN: Catch KeyError in OVS's EVPN config https://review.opendev.org/c/openstack/neutron/+/999163 | 18:18 |
| opendevreview | Helen Chen proposed openstack/neutron master: EVPN: Catch KeyError in OVS's EVPN config https://review.opendev.org/c/openstack/neutron/+/999163 | 18:18 |
| opendevreview | Helen Chen proposed openstack/neutron master: EVPN: Catch KeyError in OVS's EVPN config https://review.opendev.org/c/openstack/neutron/+/999163 | 18:19 |
| opendevreview | Merged openstack/neutron stable/2025.2: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999133 | 18:33 |
| opendevreview | Merged openstack/neutron stable/2025.1: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999134 | 18:47 |
| opendevreview | Merged openstack/neutron stable/2026.1: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999132 | 19:08 |
| opendevreview | Merged openstack/neutron master: Use API-defined has_lock in BGP code https://review.opendev.org/c/openstack/neutron/+/998343 | 19:08 |
| opendevreview | Dr. Jens Harbott proposed openstack/neutron unmaintained/2024.1: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999186 | 20:17 |
| opendevreview | Helen Chen proposed openstack/neutron master: EVPN: Create a dummy interface per L3 VNI https://review.opendev.org/c/openstack/neutron/+/999188 | 20:22 |
| opendevreview | Dr. Jens Harbott proposed openstack/neutron unmaintained/2023.1: Prevent cross-project subnet onboard on shared networks https://review.opendev.org/c/openstack/neutron/+/999189 | 20:42 |
| opendevreview | Terry Wilson proposed openstack/neutron master: Add EVPN db_sync support https://review.opendev.org/c/openstack/neutron/+/999198 | 22:35 |
| opendevreview | Jakub Libosvar proposed openstack/neutron master: Replace FakeAgentAPI with real components in BGP event tests https://review.opendev.org/c/openstack/neutron/+/999199 | 23:37 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!