| shaohe_feng | zhenguo: seems something wrong with nimble gate | 03:10 |
|---|---|---|
| zhenguo | shaohe_feng: ImportError: No module named vine.five | 03:12 |
| shaohe_feng | zhenguo: yes. | 03:12 |
| shaohe_feng | zhenguo: who maintain the gate? | 03:12 |
| shaohe_feng | zhenguo: maybe gate need upgrade. | 03:13 |
| zhenguo | shaohe_feng: seems all projects gate broken? | 03:13 |
| shaohe_feng | zhenguo: do you means, same with nuetron and cinder and others? | 03:14 |
| shaohe_feng | shihanzhang: ping? | 03:16 |
| zhenguo | shaohe_feng: I just checked, other projects don't have this problems | 03:16 |
| zhenguo | shaohe_feng: not sure what's vine.five... | 03:16 |
| shaohe_feng | zhenguo: we need to look into this problem. | 03:16 |
| zhenguo | shaohe_feng: sure | 03:17 |
| zhenguo | shaohe_feng: do you know which patch introduced the problems | 03:17 |
| shaohe_feng | zhenguo: let me check it | 03:18 |
| zhenguo | shaohe_feng: thanks | 03:19 |
| shaohe_feng | zhenguo: in my env, kombu.VERSION, version_info_t(major=3, minor=0, micro=37, releaselevel='', serial='') | 03:24 |
| shaohe_feng | zhenguo: and kombu.five does not import vine.five | 03:25 |
| zhenguo | shaohe_feng: I can't connect my env now, | 03:25 |
| shaohe_feng | zhenguo: can you access the gate? | 03:25 |
| shaohe_feng | zhenguo: can you check the which version of kombu? | 03:25 |
| zhenguo | shaohe_feng: let me check | 03:25 |
| shaohe_feng | zhenguo: and run: $ python -c "import kombu; print kombu.VERSION" | 03:26 |
| zhenguo | shaohe_feng: I can't connect my vm :( | 03:27 |
| shaohe_feng | zhenguo: and run $ python -c "import kombu; print globals()['kombu']" | 03:28 |
| shaohe_feng | zhenguo: open the kombu/five.py, check does it import vine.five ? | 03:29 |
| zhenguo | shaohe_feng: maybe shihanzhang can help to do this, @shihanzhang, why I can't connect my VM? | 03:31 |
| shihanzhang | zhenguo, your VM in xi'an has problem? | 03:43 |
| zhenguo | shihanzhang: yes, can't connect now, I just talked with zhaobo :) | 03:44 |
| shihanzhang | ok, he will help you to check it. | 03:45 |
| *** Kevin_Zheng has joined #openstack-nimble | 06:16 | |
| *** lei-zh has joined #openstack-nimble | 07:46 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Use upper constraints https://review.openstack.org/392060 | 07:47 |
| lei-zh | so where is the tox install command inherited from? | 07:50 |
| lei-zh | their gate must be failing either:) | 07:51 |
| zhenguo | shaohe_feng, lei-zh: the gate problems will be addressed with https://review.openstack.org/392060 | 07:53 |
| *** lei-zh has left #openstack-nimble | 07:56 | |
| *** lei-zh has joined #openstack-nimble | 07:56 | |
| openstackgerrit | Merged openstack/nimble: Use upper constraints https://review.openstack.org/392060 | 07:57 |
| zhenguo | shaohe_feng: I find you add a class._resource for authorization, but if there are multi operations running at the same time, like A wants to power on node1 and B wants to power off node2, how would you keep _resource as you expected? | 08:16 |
| * zhenguo brb | 08:22 | |
| *** lei-zh has quit IRC | 08:43 | |
| *** lei-zh has joined #openstack-nimble | 08:49 | |
| *** lei-zh has quit IRC | 09:10 | |
| *** lei-zh has joined #openstack-nimble | 09:20 | |
| shaohe_feng | zhenguo: yes. _resource is class attribute. But very operations, there will be a instance of the controller. And you can see very _resource call is instance attribute instead of class attribute. | 09:26 |
| shaohe_feng | zhenguo: I will do a example for you. | 09:27 |
| zhenguo | shaohe_feng: ok, will check when my env is ready :) | 09:28 |
| shaohe_feng | zhenguo: http://paste.openstack.org/show/587520/ | 09:31 |
| shaohe_feng | zhenguo: I have check the upper-constraints https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt | 09:34 |
| shaohe_feng | zhenguo: It use kombu===3.0.37 | 09:34 |
| shaohe_feng | zhenguo: it the same version with my evn. | 09:35 |
| shaohe_feng | zhenguo: so it will not import vine.five | 09:35 |
| zhenguo | shaohe_feng: yes, but my new env use kombu 4.0 | 09:35 |
| zhenguo | shaohe_feng: which introduce vine.five | 09:36 |
| shaohe_feng | zhenguo: so when will nimble will upgrade to kombu 4.0? | 09:37 |
| zhenguo | shaohe_feng: I have fixed the probelems to keep use upper-constraints | 09:38 |
| zhenguo | shaohe_feng: maybe when oslo.messaging fixed the dependency problems | 09:38 |
| zhenguo | shaohe_feng: we don't directly depends on kombu | 09:39 |
| shaohe_feng | zhenguo: OK. let oslo.messaging upgrade it. | 09:39 |
| shaohe_feng | zhenguo: https://review.openstack.org/#/c/391773/2 | 09:39 |
| shaohe_feng | zhenguo: This is Zhong Luyao and lei-zh 's patch for multil tenant. | 09:40 |
| zhenguo | shaohe_feng: ok, will review later :) | 09:40 |
| shaohe_feng | zhenguo: You can see we add a new parameter "contex" for model_query | 09:40 |
| shaohe_feng | zhenguo: but we just get project_id from "contex" in model_query. | 09:41 |
| shaohe_feng | zhenguo: so we need to dicuss it is necessary to pass "contex" | 09:42 |
| zhenguo | shaohe_feng: I think it's ok, in case of other parameters in context used in future | 09:42 |
| shaohe_feng | zhenguo: yes. | 09:42 |
| zhenguo | shaohe_feng: or we can discuss whether more parameters needed in future | 09:42 |
| shaohe_feng | zhenguo: but nova also get the "session" from "contex" | 09:43 |
| shaohe_feng | zhenguo: we did not know why nova need "session". need dive into it. | 09:43 |
| shaohe_feng | zhenguo: yes, for extension, we can add the new parameter "contex" | 09:44 |
| shaohe_feng | zhenguo: anyone know why nova need to get the "session" from "contex"？ | 09:44 |
| zhenguo | shaohe_feng: maybe RuiChen and Kevin_Zheng can help with that | 09:45 |
| shaohe_feng | So let's ping RuiChen and Kevin_Zheng ^ | 09:45 |
| zhenguo | liusheng: our functinal tests has enabled in gate jobs, but it's failed :( | 09:47 |
| zhenguo | shaohe_feng: our gate broken again | 09:47 |
| shaohe_feng | zhenguo: let check it. | 09:47 |
| * zhenguo brb | 09:49 | |
| zhenguo | seems because 'bash: line 1: ./gate_hook.sh: Permission denied' | 10:09 |
| zhenguo | will check later | 10:09 |
| *** lei-zh has quit IRC | 10:11 | |
| shaohe_feng | zhenguo: come back. | 10:36 |
| shaohe_feng | zhenguo: $ ls -l devstack/gate/gate_hook.sh | 10:36 |
| shaohe_feng | -rw-rw-r-- 1 shhfeng shhfeng 1030 10月 20 01:15 devstack/gate/gate_hook.sh | 10:36 |
| shaohe_feng | zhenguo: I list other project: | 10:38 |
| shaohe_feng | $ ls -l magnum/magnum/tests/contrib/gate_hook.sh | 10:38 |
| shaohe_feng | -rwxrwxr-x 1 shhfeng shhfeng 4733 10月 1 10:50 magnum/magnum/tests/contrib/gate_hook.sh | 10:38 |
| shaohe_feng | zhenguo: they are all have "excute" permission | 10:40 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: add execute permission for gate_hook.sh https://review.openstack.org/392101 | 10:42 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: add execute permission for gate_hook.sh https://review.openstack.org/392101 | 10:44 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: add execute permission for gate_hook.sh https://review.openstack.org/392101 | 10:45 |
| zhenguo | shaohe_feng: thanks for the patch, will check when I'm home | 10:46 |
| shaohe_feng | zhenguo: OK. Thanks. | 10:50 |
| shaohe_feng | zhenguo: you can read the commit of this patch: https://review.openstack.org/#/c/389277/ | 10:50 |
| shaohe_feng | zhenguo: I have mentioned Another way to check the authorization is in the Pencan before Hook. | 10:50 |
| shaohe_feng | zhenguo: Today, Zang Rui go through the neutron code. and I have find it is really do authorization during Pencan Hook. | 10:52 |
| shaohe_feng | zhenguo: you can see the neutron code here: https://github.com/openstack/neutron/blob/master/neutron/pecan_wsgi/hooks/policy_enforcement.py | 10:53 |
| zhenguo | shaohe_feng: ok, maybe that's better, will check when I'm home latter, thanks | 10:53 |
| shaohe_feng | zhenguo: I have check other code, they all use hard code to do authorization, they are arguly. | 10:54 |
| zhenguo | shaohe_feng: haha | 10:54 |
| shaohe_feng | zhenguo: now nimble use decorator to do the authorization, and neutron use hook. | 10:54 |
| shaohe_feng | zhenguo: Do we need to follow neutron way? | 10:55 |
| zhenguo | shaohe_feng: I think that's better, we can leverage pecan hook | 10:55 |
| shaohe_feng | zhenguo: Or just keep our way. I have consider these two ways. And the commit of my patch also mentioned these two way. | 10:56 |
| zhenguo | shaohe_feng: ok will read it, and ttyl | 10:57 |
| shaohe_feng | zhenguo: But I did not know neurton use hook. So I add a decorator, just from sketch. | 10:59 |
| shaohe_feng | zhenguo: I add _resource attribute, nuetorn add a resource_info. https://github.com/openstack/neutron/blob/master/neutron/pecan_wsgi/hooks/policy_enforcement.py#L62 | 11:02 |
| shaohe_feng | zhenguo: I need to go home | 11:02 |
| shaohe_feng | zhenguo: when will you go here to set up a physical env for nimble? | 11:02 |
| shaohe_feng | zhenguo: liusheng: which project include this file safe-devstack-vm-gate-wrap.sh? | 12:25 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Enable required services in gate_hook https://review.openstack.org/392171 | 13:59 |
| zhenguo | shaohe_feng: I added a patch to enable all required services to solve the gate devstack problems | 14:00 |
| zhenguo | shaohe_feng: your patch have addressed the permission issue | 14:01 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Enable required services in gate_hook https://review.openstack.org/392171 | 14:58 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Enable required services in gate_hook https://review.openstack.org/392171 | 15:14 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Enable required services in gate_hook https://review.openstack.org/392171 | 15:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!