| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add object test utils https://review.openstack.org/379484 | 00:09 |
|---|---|---|
| openstackgerrit | Merged openstack/nimble: Updated from global requirements https://review.openstack.org/395190 | 00:12 |
| *** yuntongjin has joined #openstack-nimble | 01:33 | |
| *** lei-zh has joined #openstack-nimble | 01:46 | |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add launched_at to instance API object and update doc https://review.openstack.org/395286 | 02:37 |
| openstackgerrit | Zhong Luyao proposed openstack/nimble: Use sqlalchemyutils.model_query https://review.openstack.org/391773 | 03:04 |
| *** yuntongjin has quit IRC | 03:18 | |
| zhenguo | shaohe_feng: are you around? | 03:20 |
| *** lei-zh has quit IRC | 03:54 | |
| *** RuiChen has quit IRC | 04:19 | |
| *** yuntongjin has joined #openstack-nimble | 04:32 | |
| shaohe_feng | zhenguo: yes | 04:54 |
| shaohe_feng | zhenguo: I just see you have add the db utils | 04:54 |
| shaohe_feng | zhenguo: I have update it just now. And find it merged. I will file a patch for add a context and give a simple test case for it. | 04:56 |
| shaohe_feng | zhenguo: then others can add their own db_test cases. | 04:56 |
| zhenguo | shaohe_feng: thanks | 04:56 |
| zhenguo | shaohe_feng: and I just commented this https://review.openstack.org/#/c/379484/3/nimble/tests/unit/__init__.py, not sure why ironic still keep eventlet imported there | 04:57 |
| zhenguo | shaohe_feng: I am preparing the api test base infras, need object utils merged first :) | 04:58 |
| shaohe_feng | zhenguo: yes, need to look into it. | 04:59 |
| zhenguo | shaohe_feng: ok, thanks | 04:59 |
| zhenguo | shaohe_feng: I would like to hold an irc meeting this week, please feel free to add agenda here https://wiki.openstack.org/wiki/Meetings/Nimble | 05:00 |
| shaohe_feng | zhenguo: let me look into it. | 05:00 |
| zhenguo | shaohe_feng: and we have to choose a feasible time for our meeting | 05:01 |
| zhenguo | hi all, please feel free to add agenda here https://wiki.openstack.org/wiki/Meetings/Nimble for our first irc meeting | 05:02 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: Add context parameter for DB test utils https://review.openstack.org/379484 | 05:05 |
| shaohe_feng | zhenguo: I have update the DB util patch. add a text case. And the text case pass. | 05:07 |
| shaohe_feng | zhenguo: So others can base on this util, add their own patch. | 05:07 |
| zhenguo | shaohe_feng: thanks | 05:07 |
| shaohe_feng | zhenguo: 3 places update. | 05:08 |
| shaohe_feng | zhenguo: 1. extra should be a text | 05:08 |
| shaohe_feng | 2. need a context. | 05:08 |
| zhenguo | shaohe_feng: ok, I find we don't use extra field anywhere now, should we add it to API instance object? | 05:09 |
| shaohe_feng | 3. we use instance_create to create a instance. | 05:09 |
| shaohe_feng | zhenguo: but ironic use create_node. the create in prefix. | 05:09 |
| zhenguo | shaohe_feng: and seems we don't have an API for updating instance now :( | 05:09 |
| zhenguo | shaohe_feng: yes, my mistake | 05:10 |
| shaohe_feng | zhenguo: not sure. But there is a extra in db. anyway, we add it. There is no harmful in utils | 05:11 |
| shaohe_feng | zhenguo: $ python -m testtools.run nimble.tests.unit.db.test_instances | 05:11 |
| zhenguo | shaohe_feng: yes, I just considered to use it | 05:11 |
| shaohe_feng | zhenguo: Use this command to check the only db testcase. | 05:12 |
| zhenguo | shaohe_feng: ok | 05:12 |
| shaohe_feng | zhenguo: just used to create check utils can works well. :) and an example for others | 05:13 |
| zhenguo | shaohe_feng: ok, I will push the api base tests ASAP | 05:14 |
| * zhenguo away | 05:24 | |
| *** lei-zh has joined #openstack-nimble | 05:26 | |
| openstackgerrit | Merged openstack/nimble: Add context parameter for DB test utils https://review.openstack.org/379484 | 05:30 |
| openstackgerrit | Merged openstack/nimble: Updated from global requirements https://review.openstack.org/395341 | 05:31 |
| openstackgerrit | Merged openstack/nimble: Add launched_at to instance API object and update doc https://review.openstack.org/395286 | 05:36 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: Add object test utils https://review.openstack.org/395411 | 06:12 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: Add object test utils https://review.openstack.org/395411 | 06:14 |
| zhenguo | shaohe_feng: please see comments here https://review.openstack.org/#/c/395411/2 | 06:18 |
| shaohe_feng | zhenguo: yes. I have check nimble use PBR | 06:21 |
| zhenguo | shaohe_feng: so we don't need that anymore, right? | 06:21 |
| shaohe_feng | zhenguo: And I think, the current object test do not need eventlet. | 06:21 |
| shaohe_feng | zhenguo: only wsgi_server and rpc use eventlet | 06:22 |
| zhenguo | shaohe_feng: yes | 06:23 |
| shaohe_feng | zhenguo: the monkey_patch can help to improve the socket performance. | 06:23 |
| shaohe_feng | zhenguo: so let me remove it. | 06:23 |
| zhenguo | shaohe_feng: ok, thanks | 06:23 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: Add object test utils https://review.openstack.org/395411 | 06:24 |
| shaohe_feng | zhenguo: after these 2 utils, now others can add their focus testcase more easily. | 06:28 |
| zhenguo | shaohe_feng: yes, these utils really helpful :) | 06:29 |
| zhenguo | shaohe_feng: can we merge the last two patches for multi-tenant support today, so they can focus on test cases work :P | 06:32 |
| shaohe_feng | zhenguo: yes. | 06:34 |
| zhenguo | shaohe_feng: thanks a lot | 06:34 |
| shaohe_feng | lei-zh: any comments on https://review.openstack.org/#/c/391773/ and https://review.openstack.org/#/c/389562/8 | 06:35 |
| shaohe_feng | lei-zh: let's we merge it today. But there's a -1 on https://review.openstack.org/#/c/389562/8 | 06:35 |
| zhenguo | shaohe_feng: seems it needs a reabase as the depends on patch updated. | 06:36 |
| zhenguo | s/reabase/rebase | 06:36 |
| *** Kevin_Zheng has joined #openstack-nimble | 06:39 | |
| shaohe_feng | zhenguo: OK. let's rebase | 06:40 |
| zhenguo | Kevin_Zheng: Do you have time to add instance types related UT this week or we have to assign the task to someone else? | 06:43 |
| Kevin_Zheng | zhenguo: I'm working on a nova priority spec this week, not sure I can do it or not | 06:44 |
| zhenguo | Kevin_Zheng: ok | 06:45 |
| *** shihanzhang has quit IRC | 07:21 | |
| shaohe_feng | zhenguo: I have check the ironic code https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/models.py#L145 | 08:09 |
| shaohe_feng | zhenguo: the extra = Column(db_types.JsonEncodedDict) | 08:10 |
| openstackgerrit | Merged openstack/nimble: Add object test utils https://review.openstack.org/395411 | 08:10 |
| zhenguo | shaohe_feng: so it's not a string | 08:10 |
| shaohe_feng | zhenguo: https://github.com/openstack/nimble/blob/master/nimble/db/sqlalchemy/models.py#L136 | 08:11 |
| shaohe_feng | zhenguo: yes, nimbel code is text. | 08:11 |
| zhenguo | shaohe_feng: haha | 08:11 |
| zhenguo | shaohe_feng: what's type of nova instance extra field? | 08:11 |
| shaohe_feng | zhenguo: but https://github.com/openstack/nimble/blob/master/nimble/objects/instance.py#L45 | 08:12 |
| shaohe_feng | zhenguo: let me check it. | 08:12 |
| shaohe_feng | zhenguo: just a minute | 08:12 |
| zhenguo | shaohe_feng: thanks | 08:12 |
| shaohe_feng | zhenguo: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L165 | 08:17 |
| shaohe_feng | zhenguo: extra_resources for computeNode . it is text | 08:18 |
| zhenguo | shaohe_feng: seems json is more better, users can use it directly | 08:21 |
| *** yuntongjin has quit IRC | 08:23 | |
| zhenguo | shaohe_feng: but we can convert before send it to users, not sure the difference between them in db column type. | 08:23 |
| openstackgerrit | Zhong Luyao proposed openstack/nimble: Add project filtering for instance api https://review.openstack.org/389562 | 08:33 |
| *** lei-zh has quit IRC | 08:42 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-nimble | 08:49 | |
| *** lei-zh has joined #openstack-nimble | 09:05 | |
| shaohe_feng | zhenguo: sure. now the object layer is json, and db layer is text. | 09:14 |
| shaohe_feng | zhenguo: we need to convert json to text by jsonutils.loads/jsonutils.dumps | 09:14 |
| zhenguo | shaohe_feng: ok, and I would like to return extra field with instance details request. | 09:16 |
| * zhenguo brb | 09:23 | |
| shaohe_feng | zhenguo: now I think there is a bug in our code about extra. | 09:23 |
| shaohe_feng | zhenguo: please see this link: http://paste.openstack.org/show/588517/ | 09:24 |
| shaohe_feng | zhenguo: now I do use really db instead of mock for instance_get test. It failed. | 09:24 |
| shaohe_feng | zhenguo: just because the extra in object is json, but in db layer is text. | 09:26 |
| shaohe_feng | zhenguo: and maybe none of us has create a instance with extra. | 09:26 |
| shaohe_feng | zhenguo: another thing I need to talk is about do we use really db for object test or just mock db | 09:28 |
| shaohe_feng | zhenguo: you can see ironic code is that: https://github.com/openstack/ironic/blob/master/ironic/tests/unit/objects/test_node.py#L38 | 09:29 |
| shaohe_feng | zhenguo: they are mock db test. but the TestNodeObject is derived from base.DbTestCase. class TestNodeObject(base.DbTestCase): | 09:30 |
| shaohe_feng | zhenguo: so we can use really DB for test. | 09:30 |
| shaohe_feng | zhenguo: but really DB may be time consumed. | 09:31 |
| zhenguo | shaohe_feng: sorry, I was away for smoking :P | 09:34 |
| zhenguo | shaohe_feng: regarding extra, as it's not in API Instance object, so we can't create instance with extra field | 09:35 |
| zhenguo | shaohe_feng: I think it's ok to use really db like Ironic now, if time consuming is serious, we can change in future. | 09:37 |
| shaohe_feng | shaohe_feng: OK, got it. Thanks. | 09:39 |
| shaohe_feng | zhenguo: so we need to fix this bug. let also use extra as json. just like ironic. https://github.com/openstack/ironic/blob/master/ironic/db/sqlalchemy/models.py#L145 | 09:43 |
| zhenguo | shaohe_feng: yes, we need to fix it | 09:43 |
| shaohe_feng | zhenguo: or leave it as text. and convert it from json to text, when object layer pass it to DB layer? | 09:44 |
| shaohe_feng | zhenguo: which one do you prefer? | 09:44 |
| zhenguo | shaohe_feng: seems like change it to json in DB layer is more easier, wdyt? | 09:44 |
| shaohe_feng | zhenguo: yes. It it more easier. | 09:45 |
| zhenguo | shaohe_feng: hah | 09:45 |
| shaohe_feng | zhenguo: but not user we need to update db migration. | 09:45 |
| shaohe_feng | zhenguo: not user/not sure | 09:45 |
| zhenguo | shaohe_feng: I think we don't need to update db migration before we go public | 09:46 |
| shaohe_feng | zhenguo: OK, got it. | 09:46 |
| zhenguo | shaohe_feng: just like we don't need to update api microversion | 09:46 |
| shaohe_feng | zhenguo: yes. seems to maintain these change is tedious | 09:47 |
| zhenguo | shao_feng: lol | 09:47 |
| *** RuiChen has joined #openstack-nimble | 09:48 | |
| RuiChen | Hi nimble folks, I update the Nimble wiki page to add some fresh content, architecture, development tips, devstack link page and some use cases, feel free to check and update it | 09:51 |
| zhenguo | RuiChen: thanks a lot | 09:52 |
| RuiChen | https://wiki.openstack.org/wiki/Nimble | 09:52 |
| RuiChen | and all the nimble contributors in the list :-) | 09:54 |
| RuiChen | zhenguo: thank you loading picture for me | 09:55 |
| zhenguo | RuiChen: haha | 09:55 |
| zhenguo | about the contributors, @shaohe_feng should Zhong Luyao be added? | 09:56 |
| zhenguo | shaohe_feng: does he has an irc nick? | 09:57 |
| RuiChen | feel free to add yourself :-) | 09:58 |
| * zhenguo is away for dinner... | 09:59 | |
| * RuiChen dinner time | 09:59 | |
| shaohe_feng | zhenguo: maybe she has not register IRC. | 10:01 |
| shaohe_feng | zhenguo: we should add her. | 10:01 |
| *** lei-zh has quit IRC | 10:03 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: change the type of extra to JsonEncodedDict https://review.openstack.org/395508 | 10:22 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: Use sqlalchemyutils.model_query https://review.openstack.org/391773 | 10:32 |
| openstackgerrit | Zhong Luyao proposed openstack/nimble: Use sqlalchemyutils.model_query https://review.openstack.org/391773 | 10:40 |
| openstackgerrit | Zhong Luyao proposed openstack/nimble: Add project filtering for instance api https://review.openstack.org/389562 | 10:40 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: change the type of extra to JsonEncodedDict https://review.openstack.org/395508 | 10:52 |
| openstackgerrit | Zhong Luyao proposed openstack/nimble: Use sqlalchemyutils.model_query https://review.openstack.org/391773 | 11:25 |
| RuiChen | shaohe_feng: done, add her into wiki | 11:40 |
| zhenguo | shaohe_feng, RuiChen: a girl? lol | 12:01 |
| *** yuntongjin has joined #openstack-nimble | 12:55 | |
| *** yuntongjin has quit IRC | 13:03 | |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: use really DB for instance object test https://review.openstack.org/395610 | 14:01 |
| shaohe_feng | zhenguo: yes, a girl. | 14:02 |
| shaohe_feng | zhenguo: use really DB instead of mock DB. https://review.openstack.org/395610 | 14:03 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: Use sqlalchemyutils.model_query https://review.openstack.org/391773 | 14:05 |
| shaohe_feng | zhenguo: a student from USTC(University of Science and Technology of China) | 14:07 |
| zhenguo | shaohe_feng: got it, haha | 14:39 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Correct instance type create API response location https://review.openstack.org/395664 | 15:11 |
| zhenguo | shaohe_feng: are you still around? | 15:15 |
| openstackgerrit | Merged openstack/nimble: Correct instance type create API response location https://review.openstack.org/395664 | 15:52 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add base API tests and utils https://review.openstack.org/395688 | 16:07 |
| *** RuiChen has quit IRC | 20:46 | |
| *** RuiChen has joined #openstack-nimble | 20:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!