| *** luyao has joined #openstack-nimble | 01:23 | |
| *** yuntongjin has joined #openstack-nimble | 01:29 | |
| *** yuntongjin has quit IRC | 01:30 | |
| *** RuiChen has joined #openstack-nimble | 02:02 | |
| *** luyao has quit IRC | 02:13 | |
| openstackgerrit | liusheng proposed openstack/nimble: Add instance CURD related functional tests https://review.openstack.org/398068 | 03:46 |
|---|---|---|
| *** luyao has joined #openstack-nimble | 04:04 | |
| zhenguo | liusheng, shaohe_feng: I think the current functional tests should be moved to unit tests, wdyt? we can find another way for functional testing, maybe use nimbleclient | 04:27 |
| zhenguo | liusheng, shaohe_feng: FYI http://specs.openstack.org/openstack/keystone-specs/specs/kilo/functional-testing.html | 04:35 |
| zhenguo | liusheng, shaohe_feng: I find nova use gate-nova-tox-db-functional-ubuntu-xenial which doesn't require a dsvm | 04:51 |
| *** luyao has quit IRC | 04:58 | |
| shaohe_feng | zhenguo: I'm here | 04:58 |
| zhenguo | shaohe_feng: hi | 05:03 |
| zhenguo | shaohe_feng: nova functional tests doesn't rely on devstack env, and ironic doesn't have a functional test in gate | 05:04 |
| zhenguo | shaohe_feng: we setup a dsvm and hook script there, but in fact our functional tests now doesn't need devstack env at all @liusheng | 05:05 |
| shaohe_feng | zhenguo: I have see your meesage. Yes, now our functional test use pecan.testing. It does not start a http server. | 05:07 |
| shaohe_feng | zhenguo: I think it is more like integration testing. | 05:07 |
| shaohe_feng | zhenguo: but in Openstack, seems only two type test, unit and functional | 05:08 |
| zhenguo | shaohe_feng: yes, nova's functional tests is integration tests as well, | 05:08 |
| shaohe_feng | zhenguo: So I think the devstack is the real functional test. | 05:08 |
| zhenguo | shaohe_feng: nova moved integration tests to functional tests https://review.openstack.org/#/c/136772/ | 05:09 |
| zhenguo | shoahe_feng: but the main project like nova, doesn't need devstack env, and ironic doesn't have functional tests | 05:09 |
| shaohe_feng | zhenguo: yes. I have see the patch. Nova distinguished integration and functional tests in the beginnig | 05:14 |
| shaohe_feng | zhenguo: and then they remove the integration test. The patch not tell us the reason, but IMHO, it is more conveniece for code maangement. | 05:16 |
| zhenguo | shaohe_feng: yes, so currently we follow nova's way | 05:16 |
| zhenguo | shaohe_feng: we use pecan.testing which need to update our gate to remove dsvm | 05:17 |
| zhenguo | shaohe_feng: or move current functional tests to unit tests? | 05:17 |
| shaohe_feng | zhenguo: let me check the nova code, little minutes | 05:19 |
| zhenguo | shaohe_feng: ok, thanks | 05:19 |
| zhenguo | shaohe_feng: maybe this is helpful https://blueprints.launchpad.net/nova/+spec/functional-tests-for-nova | 05:20 |
| shaohe_feng | zhenguo: In my nova path, nova also have regressions test nova/tests/functional/regressions/ | 05:24 |
| zhenguo | shaohe_feng: yes, seems nova have more tests | 05:25 |
| zhenguo | shaohe_feng: but as a new startup project, which way do you perfer? remove functional tests or keep the current implementation | 05:27 |
| zhenguo | shaohe_feng: nova unit tests also include api tests using fake_request which I think is similar to pecan.testing | 05:31 |
| zhenguo | shaohe_feng: ironic's pecan.testing part is in UT as well. | 05:32 |
| *** yuntongjin has joined #openstack-nimble | 05:33 | |
| shaohe_feng | zhenguo: I seen nova use self.start_service for functional test. I'm check whether it does start real server | 05:35 |
| zhenguo | shaohe_feng: we also start_service in ironic UT for conductor manager tests | 05:39 |
| zhenguo | shaohe_feng: which uses a fake topic | 05:40 |
| * zhenguo brb | 05:43 | |
| shaohe_feng | zhenguo: so we will move functional tests into unit? | 06:06 |
| zhenguo | shaohe_feng: I'm not sure, | 06:07 |
| *** yuntongjin has quit IRC | 06:08 | |
| zhenguo | shaohe_feng: maybe we need to invite more people to join this discussion | 06:08 |
| shaohe_feng | zhenguo: yes. | 06:09 |
| zhenguo | Kevin_Zheng, liusheng, RuiChen, shaohe_feng, shihanzhang: let's talk about functional tests and unit tests | 06:09 |
| zhenguo | shaohe_feng: seems yuntongjin just quitted | 06:10 |
| shaohe_feng | zhenguo: yes, he is not in seat. | 06:12 |
| shaohe_feng | zhenguo: guess, he is smoking. :P | 06:13 |
| zhenguo | shaohe_feng: hah | 06:13 |
| zhenguo | hi all, you can scroll back to see our discussion about functional tests, it's really need you all to help to decide what our functional tests would be like | 06:13 |
| liusheng | seems different project have different definitions of functional tests :( | 06:16 |
| zhenguo | liusheng: that's true, but which way we should follow as a new startup project? | 06:18 |
| liusheng | zhenguo: For Nova functional tests, it will also start a wsgi app in tests code | 06:20 |
| zhenguo | liusheng: yes, like what we do currently | 06:21 |
| *** ChanServ sets mode: +o zhenguo | 06:36 | |
| * zhenguo brb | 06:41 | |
| openstackgerrit | liusheng proposed openstack/nimble: Add instance CURD related functional tests https://review.openstack.org/398068 | 07:32 |
| zhenguo | shoahe_feng: we will keep the current way to use functional tests and remove dependency on dsvm in our gate. | 07:35 |
| zhenguo | shaohe_feng: wdyt? | 07:35 |
| *** luyao has joined #openstack-nimble | 07:38 | |
| RuiChen | dsvm waste so many time to build an whole devstack, we hope our patches can be verified and merged quickly, and acturally dsvm is not necessary for functional tests now | 07:38 |
| openstackgerrit | liusheng proposed openstack/nimble: Add support for updating instance type https://review.openstack.org/386439 | 07:39 |
| zhenguo | yes, we will introduce tempest wih dsvm real env tests | 07:39 |
| liusheng | zhenguo: tempest work item can be assigned to me :) | 07:43 |
| zhenguo | liusheng: ok, thanks very much :) | 07:43 |
| liusheng | zhenguo: np :) | 07:44 |
| shaohe_feng | zhenguo: agree. at present our functional tests do not need dsvm | 07:56 |
| zhenguo | shaohe_feng: thanks | 07:57 |
| *** yuntongjin has joined #openstack-nimble | 07:58 | |
| liusheng | zhenguo: Is this right ? https://review.openstack.org/#/c/398176/ | 08:22 |
| zhenguo | liusheng: already got a +2, haha | 08:25 |
| liusheng | zhenguo: I am not very sure :P | 08:25 |
| zhenguo | liusheng: lol | 08:26 |
| zhenguo | liusheng: I think infra guys will be very happy if we can reduce the vm occupied time. | 08:27 |
| liusheng | zhenguo: so they give +2 so quickly ? hah | 08:28 |
| zhenguo | liusheng: hah | 08:28 |
| liusheng | zhenguo: and already got a +A... | 08:31 |
| zhenguo | liusheng:lol, so fast... | 08:31 |
| RuiChen | community think nimble is very very important project, everybody wait to review its patch :-) | 08:32 |
| zhenguo | lol, I believe that's true... | 08:33 |
| liusheng | merged, let's try the new functional job | 08:36 |
| openstackgerrit | liusheng proposed openstack/nimble: Remove the post_test_hook.sh script https://review.openstack.org/398184 | 08:36 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Follow up patch of bb68cb7b31ca4798ec4a55b25dd4ea66bf15a29b https://review.openstack.org/398185 | 08:38 |
| *** luyao has quit IRC | 08:41 | |
| liusheng | seems the project config cannot become effective immediately | 08:50 |
| zhenguo | liusheng: yes, the gate check is not finished yet, should not be that long now | 08:54 |
| openstackgerrit | ShaoHe Feng proposed openstack/nimble: add PolicyFixture for functional test. https://review.openstack.org/398198 | 08:58 |
| *** luyao has joined #openstack-nimble | 08:58 | |
| shaohe_feng | liusheng: I add this patch. https://review.openstack.org/398198 | 08:58 |
| shaohe_feng | liusheng: you can follow the commit message when you do you instance fucntonal test. | 08:59 |
| shaohe_feng | liusheng: for we have add authorization for instance functional test | 09:00 |
| shaohe_feng | zhenguo: do we need authorization for instance_type? | 09:01 |
| zhenguo | shaohe_feng, liusheng: IIRC, currently we don't have authorizaton in tests right? | 09:01 |
| zhenguo | shaohe_feng: yes, | 09:02 |
| shaohe_feng | zhenguo: yes. we have not authorizaton in tests. we need add it. | 09:02 |
| zhenguo | shaohe_feng: there's a instance_type_projects table in db, but not used | 09:02 |
| liusheng | shaohe_feng: I used to think we can add some specific test for authorization, and the we don't consider auth for testing instance and instance type functionalities | 09:03 |
| liusheng | shaohe_feng: reasonable ? | 09:03 |
| shaohe_feng | zhenguo: you need to add testcase list in your item, so we will not forget it. and we will add it after the fucntional tests are merged. | 09:03 |
| zhenguo | shaohe_feng: sure | 09:03 |
| shaohe_feng | liusheng: yes. agree. need specific test for authorization. and zhenguo will add this in testcase item list. | 09:05 |
| shaohe_feng | zhenguo: so what about instance_type_projects? | 09:05 |
| liusheng | shaohe_feng: cool! | 09:05 |
| shaohe_feng | zhenguo: should we use instance_type_projects for authorization? | 09:05 |
| zhenguo | shaohe_feng: instance_type is almost copied from volume_type | 09:05 |
| zhenguo | shaohe_feng: but we don't introduce projects | 09:06 |
| zhenguo | shaohe_feng: instance_type_projects makes it possible that you can specify which projects can use this type | 09:06 |
| zhenguo | shaohe_feng: projects or tenants :P | 09:07 |
| liusheng | zhenguo: the new jenkins job config works :) | 09:07 |
| zhenguo | liusheng: hah | 09:07 |
| shaohe_feng | zhenguo: OK. So we need to record project_id in instance_type_projects? | 09:08 |
| shaohe_feng | liusheng: cool. | 09:08 |
| zhenguo | shaohe_feng: not sure, but we can copy volume type directly | 09:08 |
| zhenguo | shaohe_feng: need some volunteer to work on this | 09:08 |
| shaohe_feng | zhenguo: so let us read the cinder code. | 09:09 |
| zhenguo | shaohe_feng: ok | 09:09 |
| shaohe_feng | zhenguo: yes. OK. let me find a volunteer. | 09:09 |
| zhenguo | shaohe_feng: hah, thanks | 09:09 |
| openstackgerrit | Merged openstack/nimble: Follow up patch of bb68cb7b31ca4798ec4a55b25dd4ea66bf15a29b https://review.openstack.org/398185 | 09:12 |
| openstackgerrit | Merged openstack/nimble: Remove the post_test_hook.sh script https://review.openstack.org/398184 | 09:16 |
| *** luyao has quit IRC | 09:23 | |
| zhenguo | shaohe_feng: I added some checklist on our trello board tests subtasks card, not sure policy check should be in functional or unit tests | 09:30 |
| *** tiantian has joined #openstack-nimble | 09:35 | |
| *** yuntongjin has quit IRC | 09:46 | |
| openstackgerrit | shihanzhang proposed openstack/python-nimbleclient: Support Instance Resource https://review.openstack.org/392399 | 10:13 |
| *** liusheng has quit IRC | 10:29 | |
| *** liusheng has joined #openstack-nimble | 10:30 | |
| openstackgerrit | Zhong Luyao proposed openstack/nimble: bug fix: delete instance correctly https://review.openstack.org/398306 | 11:38 |
| openstackgerrit | Zhong Luyao proposed openstack/nimble: bug fix: delete instance correctly https://review.openstack.org/398306 | 11:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!