| *** yuntongjin has joined #openstack-nimble | 01:29 | |
| zhenguo | morning nimble | 01:50 |
|---|---|---|
| yuntongjin | morning nimblers | 01:57 |
| *** luyao has quit IRC | 02:10 | |
| *** luyao has joined #openstack-nimble | 02:11 | |
| openstackgerrit | Merged openstack/nimble: update api-ref for admin tenant filter. https://review.openstack.org/400107 | 02:20 |
| openstackgerrit | Merged openstack/nimble: Import ironicclient directly https://review.openstack.org/400139 | 02:23 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Add engine api interfaces https://review.openstack.org/399476 | 03:25 |
| *** yuntongjin has quit IRC | 03:31 | |
| zhenguo | shaohe_feng, liusheng: I would like to introduce image in nimble, do you think we need to support both v1 and v2 api or just v2? | 03:42 |
| liusheng | you mean glance ? | 03:42 |
| zhenguo | liusheng: yes | 03:42 |
| liusheng | zhenguo: the glance v1 APIs isn't maintained any more | 03:43 |
| zhenguo | liusheng: oh, so we don't need it | 03:43 |
| liusheng | zhenguo: yes | 03:43 |
| zhenguo | liusheng: thanks | 03:43 |
| *** kong has quit IRC | 04:30 | |
| *** yuntongjin has joined #openstack-nimble | 04:43 | |
| openstackgerrit | liusheng proposed openstack/nimble: Add tempest plugin for Nimble(part1) https://review.openstack.org/400517 | 05:02 |
| openstackgerrit | liusheng proposed openstack/nimble: Add tempest plugin for Nimble(part1) https://review.openstack.org/400517 | 05:04 |
| openstackgerrit | liusheng proposed openstack/nimble: Add tempest plugin for Nimble(part1) https://review.openstack.org/400517 | 05:07 |
| *** yuntongjin has quit IRC | 06:06 | |
| *** yuntongjin has joined #openstack-nimble | 06:23 | |
| openstackgerrit | yuntongjin proposed openstack/nimble: Add unittest test_filter_scheduler. https://review.openstack.org/387814 | 06:32 |
| openstackgerrit | liusheng proposed openstack/nimble: Add tempest plugin for Nimble(part1) https://review.openstack.org/400517 | 06:40 |
| shaohe_feng | zhenguo: https://docs.python.org/3/library/unittest.mock.html#autospeccing | 06:43 |
| shaohe_feng | zhenguo: this docs is Interesting. not only introduce mock, but also something tests. | 06:44 |
| shaohe_feng | such as: | 06:44 |
| shaohe_feng | The second issue is more general to mocking. If you refactor some of your code, rename members and so on, any tests for code that is still using the old api but uses mocks instead of the real objects will still pass. This means your tests can all pass even though your code is broken. | 06:44 |
| shaohe_feng | Note that this is another reason why you need integration tests as well as unit tests. Testing everything in isolation is all fine and dandy, but if you don’t test how your units are “wired together” there is still lots of room for bugs that tests might have caugh.t | 06:44 |
| zhenguo | shaohe_feng:yes, thanks for shareing the link :P | 06:46 |
| openstackgerrit | liusheng proposed openstack/nimble: Add tempest plugin for Nimble(part1) https://review.openstack.org/400517 | 06:58 |
| liusheng | zhenguo: the part 1 (basic frame) of tempest plugin has been locally tested ok, and the infra job patch has been uploaded, https://review.openstack.org/#/c/400539/ ^^ | 07:06 |
| zhenguo | liusheng: oh, thanks a lot, hah | 07:07 |
| liusheng | zhenguo: np:) | 07:08 |
| shaohe_feng | liusheng: awesome. | 07:14 |
| liusheng | shaohe_feng: thanks :) | 07:14 |
| zhenguo | shaohe_feng: please help to review the tempest patch, if there's no big issues I would like to land the codes as soon as possible, as the related infra patch depends on this, we need to get approved from infra guys to enable this gate. | 07:18 |
| shaohe_feng | zhenguo: OK. | 07:19 |
| zhenguo | shaohe_feng: thanks | 07:19 |
| shaohe_feng | liusheng: zhenguo: where can I get devstack-vm-gate-wrap.sh ? | 07:35 |
| zhenguo | shaohe_feng: it's not related to us | 07:35 |
| zhenguo | shaohe_feng: it's infras thing, which used to setup devstack I think | 07:36 |
| liusheng | shaohe_feng: devstack-gate repo | 07:36 |
| shaohe_feng | liusheng: Andreas Jaeger give comments | 07:39 |
| liusheng | shaohe_feng: thanks | 07:40 |
| liusheng | shaohe_feng: seems, it need the definition in project.yaml... | 08:56 |
| *** yuntongjin has quit IRC | 09:12 | |
| openstackgerrit | Merged openstack/nimble: Add engine api interfaces https://review.openstack.org/399476 | 09:16 |
| zhenguo | liusheng: I searched all tempest job in projects file, seem they use a pattern like {pipeline} and {suffix} and specify pipline to 'gate' instead of directly using gate-tempest-xxx | 09:26 |
| zhenguo | liusheng: not sure what's the difference, but they all don't directly use the job name | 09:27 |
| liusheng | zhenguo: hmmm, I guess it is just a template, but we dont need template. but I am also not sure.. | 09:28 |
| zhenguo | liusheng: or maybe you don't need a trailing ':' | 09:28 |
| liusheng | zhenguo: maybe, I have to leave now because something of my family. you can help re-submit the patch if you have time. thanks | 09:30 |
| zhenguo | liusheng: ok | 09:30 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Introduce image service https://review.openstack.org/400652 | 09:54 |
| zhenguo | shaohe_feng: as we discussed, ironic related operations should be moved from api to engine, right? | 11:02 |
| zhenguo | shaohe_feng: after ironicclient refactored, seems api ironic api call will failed currently. | 11:03 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Move all rpc call to engine api https://review.openstack.org/400736 | 12:57 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Move all rpc call to engine api https://review.openstack.org/400736 | 17:11 |
| openstackgerrit | Merged openstack/nimble: Introduce image service https://review.openstack.org/400652 | 17:18 |
| openstackgerrit | Zhenguo Niu proposed openstack/nimble: Move all rpc call to engine api https://review.openstack.org/400736 | 17:28 |
| openstackgerrit | Merged openstack/nimble: Move all rpc call to engine api https://review.openstack.org/400736 | 17:45 |
| -openstackstatus- NOTICE: Gerrit is offline until 21:30 UTC for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2016-November/107379.html | 21:09 | |
| *** ChanServ changes topic to "Gerrit is offline until 21:30 UTC for scheduled maintenance: http://lists.openstack.org/pipermail/openstack-dev/2016-November/107379.html" | 21:09 | |
| *** ChanServ changes topic to "Bugs: bugs.launchpad.net/nimble | Review: https://review.openstack.org/#/q/project:openstack/nimble,n,z" | 21:40 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!