*** neiljerram has joined #openstack-opw | 01:33 | |
*** neiljerram has quit IRC | 01:40 | |
*** arushi has joined #openstack-opw | 05:16 | |
*** arushi has quit IRC | 05:31 | |
*** rossella_s has quit IRC | 06:31 | |
*** rossella_s has joined #openstack-opw | 06:31 | |
*** njirap has joined #openstack-opw | 07:34 | |
*** njirap has quit IRC | 08:09 | |
*** njirap has joined #openstack-opw | 08:34 | |
*** njirap has quit IRC | 09:30 | |
*** njirap_ has joined #openstack-opw | 09:31 | |
*** aysyd has joined #openstack-opw | 11:07 | |
*** aysyd has quit IRC | 11:38 | |
*** neiljerram has joined #openstack-opw | 12:15 | |
*** njirap_ has quit IRC | 13:34 | |
*** neiljerram has quit IRC | 13:46 | |
*** psargent has joined #openstack-opw | 13:49 | |
*** neiljerram has joined #openstack-opw | 13:54 | |
*** julim has quit IRC | 14:13 | |
*** lblanchard has joined #openstack-opw | 14:21 | |
*** rossella_s has quit IRC | 14:31 | |
*** rossella_s has joined #openstack-opw | 14:31 | |
psargent | neiljerram: are you there? | 14:57 |
---|---|---|
neiljerram | yes, hi! | 14:58 |
psargent | hello! How are you ! I am having some problems with git review! | 14:59 |
neiljerram | Yes, I saw your email | 14:59 |
neiljerram | Have you submitted anything to review.openstack.org before? | 14:59 |
psargent | I would need to do a 'ssh-add <key-name> before issuing the git review command | 15:00 |
neiljerram | Yes. | 15:01 |
psargent | I submitted a patch | 15:01 |
psargent | yes, I submitted something in review.openstack.org | 15:01 |
neiljerram | When was that? I couldn't find anything when I looked just now - do you have a URL? | 15:02 |
psargent | ok...let me look | 15:02 |
neiljerram | Reason for asking is that there's a relatively complex process of setting up an account, becoming a member of OpenStack, and agreeing to some legal terms, before one can submit anything at all. | 15:02 |
psargent | yes....I did that previously and thought everything was set up | 15:03 |
neiljerram | If you've never done that, or if - for example - you did that with a different email address - that may be the problem. | 15:03 |
neiljerram | AH, ok, ignore that concern, then. | 15:04 |
neiljerram | OK, I can see your previous changes now: https://review.openstack.org/240407 and https://review.openstack.org/240728 | 15:05 |
neiljerram | No idea why I didn't see those when I looked a bit earlier. | 15:05 |
psargent | ok.... | 15:05 |
psargent | Is the <key-name> the same keyname that is in the review.openstack.org settings? | 15:08 |
neiljerram | I'm not sure, but possibly not. | 15:10 |
neiljerram | In my settings I see names like "imported-openssh-key" and "neil@laruns", but those are not the right thing for <key-name> | 15:11 |
neiljerram | Do you remember how you originally generated an SSH key pair? | 15:11 |
neiljerram | (Or rather, _the_ SSH key pair of which you uploaded the public part to review.openstack.org) | 15:12 |
psargent | hmmm...thinking.... | 15:12 |
psargent | I don't remember generating the SSH key pair for review.openstack.org.....I didn't have anything in my notes....I do remember playing around with SSH key pair when I was doing something else | 15:15 |
neiljerram | So it might even have been on some other computer? non-Linux? | 15:15 |
psargent | yes | 15:16 |
neiljerram | In that case probably the best thing is to generate and upload a new pair. | 15:16 |
psargent | ok | 15:16 |
neiljerram | So you can do 'ssh-keygen' to do that. | 15:16 |
psargent | ahh.... | 15:17 |
neiljerram | Then, in your settings on review.openstack.org, click 'Add SSH Public Key', and follow the instructions | 15:18 |
psargent | ok....i'll try right now | 15:18 |
*** julim has joined #openstack-opw | 15:20 | |
psargent | .... added a key in ".ssh/id_rsa.pub" and now I am going to settings | 15:20 |
psargent | ...I added a ssh public key in review.openstack.org...I am going to try the "git review" command again | 15:24 |
neiljerram | cool. But you may also need (1) an SSH agent running, if it isn't already, (2) 'ssh-add' | 15:25 |
neiljerram | You can check for (1) with 'ps waux | grep agent' | 15:26 |
psargent | ok...I checked if the SSH agent is running by 'ps waux | grep agent' ...didn't get anything back so don't think it is running.... I will issue ssh-add | 15:28 |
neiljerram | OK, then probably ssh-add will complain... | 15:29 |
psargent | should I issue the ssh-add | 15:29 |
neiljerram | sure | 15:30 |
neiljerram | (It won't matter if it complains) | 15:30 |
psargent | ok | 15:30 |
psargent | yes...it complained...could not open a connection to your authetication agent | 15:31 |
neiljerram | OK, so to start an agent: eval `ssh-agent` | 15:31 |
neiljerram | The backquotes are important there. | 15:31 |
psargent | ok | 15:32 |
neiljerram | And then 'ssh-add' | 15:33 |
psargent | Issued both commands and got this message: Identity added: /c/Users/Petra/.ssh/id_rsa (/c/Users/Petra/.ssh/id_rsa) | 15:34 |
neiljerram | I recommend that you search for some web pages to explain what's going on here. I just did a quick search for 'ssh-agent ssh-add', and found some pages that explain much better than I am doing here. | 15:34 |
neiljerram | Cool. So now I would expect your git review command to work! | 15:35 |
psargent | ok....I will.....I will take notes...just in case this happens again! | 15:35 |
neiljerram | By the way are you on Windows, or Linux? | 15:35 |
psargent | Windows | 15:35 |
neiljerram | OK... that might cause a few problems, just because most OpenStack developers use Linux. Didn't you set up a Linux machine? | 15:36 |
psargent | I am doing my git/gerrit things on windows...but all my devstack stuff is on linux | 15:40 |
neiljerram | To be honest I doubt that will make sense. | 15:41 |
neiljerram | It should work while you're working on the spec. | 15:41 |
psargent | ok... | 15:42 |
neiljerram | But when you're doing coding, you'll want the code that you're pushing to Gerrit to be the same as what you're using for testing in devstack | 15:42 |
psargent | ok...that makes sense...I can set it up | 15:43 |
neiljerram | Anyway, one thing that you should now do is copy the private key that you just made (/c/Users/Petra/.ssh/id_rsa) to .ssh/id_rsa in your account on Linux. | 15:43 |
neiljerram | Then you'll be able to do ssh-add on Linux too using the same key. | 15:43 |
neiljerram | Anyway, does the 'git review' work now? | 15:44 |
psargent | ok | 15:44 |
neiljerram | Actually you must be quite a wiz to have git and ssh working on Windows! I'm not sure I'd know exactly how to do that! | 15:45 |
psargent | I issued the command 'git review' and get this error: Problem running 'git remote update gerrit' | 15:46 |
psargent | Fetching gerrit | 15:46 |
psargent | fatal: Project not found: openstack/project | 15:46 |
psargent | fatal: Could not read from remote repository. | 15:46 |
psargent | Please make sure you have the correct access rights | 15:46 |
psargent | and the repository exists. | 15:47 |
psargent | error: Could not fetch gerrit | 15:47 |
neiljerram | Are you inside your neutron-specs repository? | 15:47 |
psargent | yes, I am inside the neutron-specs repo | 15:49 |
neiljerram | What does the '.gitreview' file say? | 15:49 |
psargent | host=review.openstack.org port=29418 project=openstack/neutron-specs.git | 15:53 |
neiljerram | Hmmm. | 15:57 |
neiljerram | It certainly looks like a problem that the error message says "openstack/project". | 15:58 |
neiljerram | I would expect "openstack/neutron-specs", as it says in your .gitreview file. | 15:58 |
psargent | hmmm....where could it be getting openstack/project.... | 15:59 |
neiljerram | My .gitreview file has a [gerrit] heading, and is also on multiple lines, like this: | 16:01 |
neiljerram | [gerrit] | 16:01 |
neiljerram | host=review.openstack.org | 16:01 |
neiljerram | port=29418 | 16:01 |
neiljerram | project=openstack/neutron-specs.git | 16:01 |
psargent | yes....mine is the same way | 16:02 |
neiljerram | OK | 16:02 |
psargent | yesterday, when I was troubleshooting... I tried to manually repo by....git remote add gerrit ssh://username@review.openstack.org:29418/openstack/project.git | 16:04 |
psargent | would that have anything to do with this issue? | 16:04 |
neiljerram | Ah, yes. | 16:05 |
neiljerram | OK, so you can undo that, with "git remote rm gerrit" | 16:06 |
neiljerram | Then try "git-review -s" | 16:06 |
psargent | ok....thought I was fixing the problem!!!! sorry...i'll do 'git remote.... | 16:07 |
neiljerram | No worries. | 16:08 |
neiljerram | Was that from https://ask.openstack.org/en/question/63383/could-not-connect-to-gerrit/ ? | 16:10 |
psargent | YEAH!!!! got pass the error....now asking for Password for 'https://psargent@review.openstack.org:443'.... | 16:10 |
neiljerram | Hmm, not sure you should be asked for a password... | 16:10 |
psargent | ok...one more thing that I changed...let me look at my notes... | 16:11 |
neiljerram | Is your Gerrit ID psargent ? | 16:11 |
psargent | I think I know why | 16:11 |
psargent | yes | 16:11 |
neiljerram | Yes, perhaps you did this: | 16:15 |
neiljerram | git config --global gitreview.scheme https | 16:15 |
neiljerram | git config --global gitreview.port 443 | 16:15 |
psargent | Yep!...I was just typing that! | 16:16 |
neiljerram | (from http://docs.openstack.org/infra/manual/developers.html) | 16:16 |
psargent | I think this password is in settings ...https password | 16:16 |
neiljerram | So I think you now want: | 16:17 |
neiljerram | git config --global --unset-all gitreview.scheme | 16:17 |
neiljerram | git config --global --unset-all gitreview.port | 16:17 |
psargent | ohh ok....Cancel the password....and then issue the above commands | 16:18 |
neiljerram | Or, from that same web page: "Keep in mind that you will need to generate an HTTP password in Gerrit to use this connection." | 16:18 |
neiljerram | But I recommend trying the unset-alls first | 16:19 |
psargent | ok....unset-alls | 16:19 |
*** Akanksha08 has joined #openstack-opw | 16:19 | |
psargent | ok... I cancelled entering the password....I issued the unset-alls command | 16:23 |
psargent | now shall I do the git review command | 16:23 |
neiljerram | Then try 'git review -s' again... | 16:23 |
psargent | ...received this error: We don't know where your gerrit is. Please manually create a remote | 16:26 |
psargent | named "gerrit" and try again. | 16:26 |
psargent | Could not connect to gerrit at https://psargent@review.openstack.org:29418/openstack/neutron-specs.git | 16:26 |
psargent | Error: Could not connect to gerrit. | 16:27 |
psargent | Enter your gerrit username: psargent | 16:27 |
psargent | Trying again with https://psargent@review.openstack.org:29418/openstack/neutron-specs.git | 16:27 |
psargent | <traceback object at 0x00000000034B6088> | 16:27 |
psargent | We don't know where your gerrit is. Please manually create a remote | 16:27 |
psargent | named "gerrit" and try again. | 16:27 |
psargent | Could not connect to gerrit at https://psargent@review.openstack.org:29418/openstack/neutron-specs.git | 16:27 |
psargent | Traceback (most recent call last): | 16:27 |
psargent | File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main | 16:27 |
psargent | "__main__", fname, loader, pkg_name) | 16:27 |
psargent | File "C:\Python27\lib\runpy.py", line 72, in _run_code | 16:27 |
psargent | exec code in run_globals | 16:27 |
psargent | File "C:\Python27\Scripts\git-review.exe\__main__.py", line 9, in <module> | 16:27 |
psargent | File "C:\Python27\lib\site-packages\git_review\cmd.py", line 1534, in main | 16:27 |
neiljerram | hmm | 16:28 |
neiljerram | Does 'ping review.openstack.org' work? | 16:29 |
psargent | yes | 16:30 |
neiljerram | maybe it really is that think about your ISP blocking SSH on strange ports. | 16:30 |
neiljerram | *thing | 16:30 |
psargent | hmmm | 16:31 |
neiljerram | Did you do the " generate an HTTP password in Gerrit" step, before? | 16:31 |
psargent | no | 16:31 |
neiljerram | ok, so perhaps you should do that, and then put back the gitreview.scheme and gitreview.port config again, and see if that makes things work | 16:32 |
psargent | ok....i'll try | 16:33 |
psargent | Yeah!! I got this: Creating a git remote called "gerrit" that maps to: | 16:43 |
psargent | https://psargent@review.openstack.org:443/openstack/neutron-specs.git | 16:43 |
psargent | Creating a git remote called "gerrit" that maps to: | 16:44 |
psargent | https://psargent@review.openstack.org:443/openstack/neutron-specs.git | 16:44 |
psargent | The branch 's' does not exist on the given remote 'gerrit'. If these | 16:44 |
psargent | changes are intended to start a new branch, re-run with the '-R' | 16:44 |
psargent | option enabled. | 16:44 |
psargent | I type " git review s" instead of " git review -s" | 16:45 |
*** enthurohini has joined #openstack-opw | 17:12 | |
neiljerram | Sorry, was on another meeting for a while.... | 17:32 |
neiljerram | But great, looks like all is now working for you. | 17:32 |
*** julim has quit IRC | 18:04 | |
*** julim has joined #openstack-opw | 18:06 | |
psargent | I am not sure if everything is working...i don't see the spec in gerrit in git-review | 18:14 |
*** neiljerram has quit IRC | 18:27 | |
*** enthurohini has quit IRC | 18:30 | |
*** rossella_s has quit IRC | 18:31 | |
*** rossella_s has joined #openstack-opw | 18:31 | |
*** Akanksha08 has quit IRC | 19:04 | |
*** lblanchard has quit IRC | 19:10 | |
*** lblanchard has joined #openstack-opw | 19:14 | |
*** jesusaur has quit IRC | 21:42 | |
*** jesusaur has joined #openstack-opw | 21:43 | |
*** jesusaur has quit IRC | 22:11 | |
*** lblanchard has quit IRC | 22:12 | |
*** Eva-i has quit IRC | 22:14 | |
*** jesusaur has joined #openstack-opw | 22:28 | |
*** Eva-i has joined #openstack-opw | 22:42 | |
*** julim has quit IRC | 22:50 | |
*** julim has joined #openstack-opw | 22:52 | |
*** Eva-i has quit IRC | 23:00 | |
*** Eva-i has joined #openstack-opw | 23:00 | |
*** julim has quit IRC | 23:11 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!