| *** yamahata has quit IRC | 00:28 | |
| *** zhiyan_ is now known as zhiyan | 01:24 | |
| *** yamahata has joined #openstack-oslo | 01:30 | |
| *** gcb has joined #openstack-oslo | 01:36 | |
| *** xuhanp has joined #openstack-oslo | 01:45 | |
| *** mriedem has left #openstack-oslo | 02:01 | |
| *** yamahata has quit IRC | 02:09 | |
| *** yamahata has joined #openstack-oslo | 03:44 | |
| *** hdd_ has quit IRC | 05:46 | |
| *** regard has quit IRC | 06:08 | |
| *** flaper87|afk is now known as flaper87 | 08:14 | |
| openstackgerrit | Ildiko Vancsa proposed a change to openstack/oslo-incubator: Add copyright text to openstack/common/__init__.py https://review.openstack.org/79273 | 08:21 |
|---|---|---|
| *** ihrachys|afk is now known as ihrachys | 08:28 | |
| *** xuhanp has quit IRC | 10:18 | |
| openstackgerrit | Nikola Dipanov proposed a change to openstack-dev/hacking: Make H202 check honor pep8 #noqa comment https://review.openstack.org/79287 | 10:25 |
| *** lbragstad has joined #openstack-oslo | 10:49 | |
| *** lbragstad__ has quit IRC | 10:50 | |
| openstackgerrit | Nikola Dipanov proposed a change to openstack-dev/hacking: Make H202 check honor pep8 #noqa comment https://review.openstack.org/79287 | 11:03 |
| openstackgerrit | Nikola Dipanov proposed a change to openstack-dev/hacking: Make H202 check honor pep8 #noqa comment https://review.openstack.org/79287 | 11:17 |
| *** lbragstad has quit IRC | 11:51 | |
| *** yamahata has quit IRC | 11:54 | |
| *** lbragstad has joined #openstack-oslo | 12:27 | |
| *** mriedem has joined #openstack-oslo | 12:34 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/oslo-incubator: User a more accurate max_delay for reconnects https://review.openstack.org/79304 | 12:40 |
| *** dims_ has quit IRC | 12:44 | |
| openstackgerrit | Cyril Roelandt proposed a change to openstack/oslosphinx: Add Python 3 trove classifiers https://review.openstack.org/79311 | 12:51 |
| *** dims_ has joined #openstack-oslo | 12:56 | |
| *** gcb has quit IRC | 13:11 | |
| *** rustlebee is now known as russellb | 13:26 | |
| *** yamahata has joined #openstack-oslo | 13:44 | |
| *** yamahata has quit IRC | 13:58 | |
| *** beekneemech is now known as bnemec | 14:02 | |
| *** yamahata has joined #openstack-oslo | 14:04 | |
| *** yamahata has quit IRC | 14:08 | |
| *** yamahata has joined #openstack-oslo | 14:15 | |
| *** yamahata has quit IRC | 14:20 | |
| openstackgerrit | Ildiko Vancsa proposed a change to openstack/oslo-incubator: Add copyright text to openstack/common/__init__.py https://review.openstack.org/79273 | 14:24 |
| *** yamahata has joined #openstack-oslo | 14:26 | |
| *** yamahata has quit IRC | 14:33 | |
| *** yamahata has joined #openstack-oslo | 14:36 | |
| *** yamahata__ has joined #openstack-oslo | 14:41 | |
| *** yamahata has quit IRC | 14:42 | |
| *** yamahata__ has quit IRC | 14:43 | |
| *** yamahata has joined #openstack-oslo | 14:45 | |
| *** yamahata has quit IRC | 14:48 | |
| *** yamahata has joined #openstack-oslo | 14:50 | |
| openstackgerrit | Jenkins proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/77644 | 14:51 |
| *** hdd_ has joined #openstack-oslo | 14:52 | |
| openstackgerrit | therese-mchale proposed a change to openstack/oslo-incubator: Retry running queries when not in a transaction https://review.openstack.org/76136 | 14:52 |
| openstackgerrit | Jenkins proposed a change to openstack/stevedore: Updated from global requirements https://review.openstack.org/75595 | 14:52 |
| *** corvus is now known as jeblair | 15:07 | |
| *** hdd_ has quit IRC | 15:13 | |
| *** hdd has joined #openstack-oslo | 15:45 | |
| hdd | anyone else having problems using run_tests.sh for oslo-incubator? | 15:46 |
| hdd | I'm getting "ImportError: No module named openstack.common.db" | 15:46 |
| dhellmann | hdd: I usually call tox directly to run the tests, have you tried that? | 15:48 |
| hdd | dhellmann, I'll give it a whirl | 15:54 |
| dhellmann | hdd, fwiw I did just try "run_tests.sh" and saw the same error | 15:54 |
| dhellmann | I'm running tox now on master to see if it shows up there, too | 15:54 |
| dhellmann | hdd: tests pass for me with "tox -e py27" so I don't know if the issue is with the virtualenv created by run_tests.sh or the different way it runs the tests | 15:56 |
| hdd | yeah, tox works for me too | 15:58 |
| hdd | thanks | 15:58 |
| openstackgerrit | Zhi Yan Liu proposed a change to openstack/oslo-incubator: Making table utf-8 charset checking be optional for DB migration https://review.openstack.org/75356 | 16:07 |
| dhellmann | dims, did we ever announce that we were creating this channel on the mailing list? | 16:08 |
| dims_ | dhellmann, don't think so | 16:09 |
| openstackgerrit | Zhi Yan Liu proposed a change to openstack/oslo-incubator: Making table utf-8 charset checking be optional for DB migration https://review.openstack.org/75356 | 16:10 |
| dhellmann | dims_: ok, I'll do that now | 16:10 |
| *** yamahata has quit IRC | 16:13 | |
| openstackgerrit | Zhi Yan Liu proposed a change to openstack/oslo-incubator: Making table utf-8 charset checking be optional for DB migration https://review.openstack.org/75356 | 16:14 |
| zhiyan | hi folks, i'd like to raise a review request for https://review.openstack.org/75356 in this "preferred" channel ;) | 16:20 |
| openstackgerrit | Joe Gordon proposed a change to openstack-dev/hacking: Revert "Make H202 check honor pep8 #noqa comment" https://review.openstack.org/79354 | 16:21 |
| *** manask has joined #openstack-oslo | 16:25 | |
| *** manask has left #openstack-oslo | 16:27 | |
| dhellmann | hi, zhiyan | 16:32 |
| dhellmann | zhiyan: do you consider that change critical for the release candidate? | 16:33 |
| zhiyan | dhellmann: i think it is a important "fix" for glance, at least | 16:33 |
| dhellmann | zhiyan: ok, there wasn't a priority attached to the bug report yet, so I wasn't sure how big of an issue it was | 16:34 |
| zhiyan | dhellmann: without it, deployer will failed to do db migration for glance | 16:34 |
| dhellmann | zhiyan: that sounds pretty critical :-) | 16:35 |
| dhellmann | zhiyan: how does the deployer set the option to not require utf8? or is that something glance would do? | 16:35 |
| zhiyan | dhellmann: could you pls help set a bug priority for oslo one? | 16:35 |
| zhiyan | dhellmann: 2 secs, i have one patch for it | 16:35 |
| dhellmann | zhiyan: the change in glance is only marked medium | 16:36 |
| zhiyan | dhellmann: https://review.openstack.org/#/c/75865/ | 16:36 |
| zhiyan | dhellmann: yes, it now is. i can set it up if needed | 16:36 |
| dhellmann | so every project that wants to use this flag would have to update the command they use to run the migrations to add the new switch? | 16:37 |
| zhiyan | dhellmann: tbh i'm sure glance project only currently | 16:38 |
| bnemec | I wonder if this should have been opt-in. | 16:38 |
| bnemec | We hit it in heat in tripleo too. | 16:38 |
| bnemec | Our fix was to globally enable utf8 tables in our mysql config, but in retrospect that probably should have been a red flag. | 16:38 |
| dhellmann | bnemec: yes, I'm starting to think so | 16:38 |
| dhellmann | I wonder if we make any assumptions elsewhere that we are using utf8 in the database | 16:39 |
| bnemec | dhellmann: The original bug that prompted this was here: https://bugs.launchpad.net/heat/+bug/1261605 | 16:41 |
| openstackgerrit | Chris Buccella proposed a change to openstack/oslo-incubator: Don't store the request ID value in middleware https://review.openstack.org/79358 | 16:42 |
| dhellmann | bnemec: thanks | 16:43 |
| zhiyan | bnemec: hi, iirc, there's a change which changes heat db create CLI script, to use utf8 as the db default charset, right? | 16:44 |
| bnemec | zhiyan: Yes, there was a separate bug raised and fixed about that: https://bugs.launchpad.net/heat/+bug/1276880 | 16:45 |
| zhiyan | dhellmann: btw, thanks for you review/pickup | 16:45 |
| bnemec | But it still doesn't help you if you have an existing install with incorrect encoding. | 16:45 |
| bnemec | Which is going to cause deployer headaches on H->I upgrades. | 16:46 |
| dhellmann | bnemec: that original bug makes me think that if we're not consistent, we will continue to have failures with foreign keys between tables where the encodings don't match | 16:46 |
| dhellmann | or charsets, I guess, which may not be the same thing as encoding | 16:46 |
| bnemec | Yeah, I don't know if they tested that. | 16:46 |
| dhellmann | so I think we want all the tables to have the same charset, even if it isn't utf-8 | 16:46 |
| zhiyan | bnemec: indeed! that's what i want to say here, seems currently we can only give a flag to db_sync to make it be possible, i mean execute migration to auto "fix" utf8 issue (and foreign keys issue maybe) | 16:47 |
| zhiyan | dhellmann: agree | 16:49 |
| *** harlowja has joined #openstack-oslo | 16:49 | |
| dhellmann | zhiyan: so if we want the charsets to match, then just disabling the utf-8 check isn't going to do the right thing | 16:50 |
| dhellmann | isn't there a migration to update the charsets of all tables? that's probably very expensive | 16:50 |
| bnemec | Here's now nova handled it: https://github.com/openstack/nova/blob/0a2ab98491cbf62e148e8289bc69c26357bd136c/nova/db/sqlalchemy/migrate_repo/versions/170_havana.py#L1395 | 16:51 |
| bnemec | dhellmann: zhiyan: ^ | 16:51 |
| zhiyan | bnemec: dhellmann: so i prepared this https://review.openstack.org/#/c/75898/5/glance/db/sqlalchemy/migrate_repo/versions/035_mysql_set_utf8_charset.py | 16:52 |
| zhiyan | but, as we know, deployer need a chance to execute it. | 16:53 |
| dhellmann | zhiyan: I think I need to see something explaining the bigger picture. What effect does it have on glance if the charset is no longer consistent across tables? How does a deployer fix up the charset and tables? That sort of thing. | 16:55 |
| dhellmann | I think I understand some of the issues, but I'm not sure I understand how the proposed solution fixes them, if that makes sense. | 16:55 |
| dhellmann | If you could add some details to the bug report answering some of those questions, that would help me with the review. | 16:56 |
| zhiyan | dhellmann: ok, so pls raise you questions in the bug report. it will help us to track them. | 16:57 |
| dhellmann | zhiyan: sure, I can do that | 16:57 |
| zhiyan | dhellmann: thanks again. no rush, but tbh you know this issue might break glance now db_sync under particular deployment, so i think it is a worth fix for the coming release. | 16:59 |
| *** yamahata__ has joined #openstack-oslo | 17:07 | |
| *** boris-42 has joined #openstack-oslo | 17:11 | |
| boris-42 | Nice | 17:12 |
| boris-42 | Finially we have oslo chat! | 17:12 |
| dhellmann | hi, boris-42 ! | 17:14 |
| boris-42 | dhellmann hi! | 17:15 |
| openstackgerrit | Ildiko Vancsa proposed a change to openstack/oslo-incubator: Add copyright text to openstack/common/__init__.py https://review.openstack.org/79273 | 17:15 |
| boris-42 | dhellmann I think this will be quite popular chat=) | 17:16 |
| *** saikrishna_ has joined #openstack-oslo | 17:16 | |
| dhellmann | boris-42: :-) | 17:17 |
| *** yamahata__ has quit IRC | 17:18 | |
| *** yamahata__ has joined #openstack-oslo | 17:18 | |
| *** yamahata__ has quit IRC | 17:18 | |
| *** yamahata has joined #openstack-oslo | 17:18 | |
| *** lbragstad has left #openstack-oslo | 17:23 | |
| *** dhellmann is now known as dhellmann_ | 17:23 | |
| *** lbragstad has joined #openstack-oslo | 17:24 | |
| *** saikrishna_ has quit IRC | 17:57 | |
| *** mriedem1 has joined #openstack-oslo | 18:02 | |
| *** mriedem has quit IRC | 18:04 | |
| *** zhiyan is now known as zhiyan_ | 18:08 | |
| harlowja | dhellmann_ nice blog post btw, a+ | 18:13 |
| harlowja | :) | 18:14 |
| harlowja | for others, http://doughellmann.com/2014/03/04/the-intersection-of-the-openstack-and-python-communities.html | 18:14 |
| harlowja | “That is a lot of code. Why do we have so much code?”, lol | 18:14 |
| *** SergeyLukjanov has joined #openstack-oslo | 18:15 | |
| *** zhiyan_ is now known as zhiyan | 18:19 | |
| dhellmann_ | harlowja: thanks :-) | 18:23 |
| *** dhellmann_ is now known as dhellmann | 18:23 | |
| harlowja | why do we have so much code, lol | 18:25 |
| dhellmann | questions most people don't ask :-) | 18:25 |
| harlowja | :) | 18:28 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Lock test tweaks https://review.openstack.org/79401 | 18:31 |
| *** zhiyan is now known as zhiyan_ | 18:34 | |
| mriedem1 | dims_: could you join #openstack-cinder quick? | 18:43 |
| harlowja | intersting, getting taskflow notifications in here also | 18:52 |
| mriedem1 | dims_: https://bugs.launchpad.net/cinder/+bug/1290503 | 18:53 |
| dhellmann | harlowja: all of the oslo repos should notify here now | 18:55 |
| harlowja | dhellmann k, good to know | 18:55 |
| *** rpodolyaka has joined #openstack-oslo | 18:57 | |
| *** rpodolyaka has quit IRC | 19:04 | |
| *** rpodolyaka has joined #openstack-oslo | 19:06 | |
| *** mriedem has joined #openstack-oslo | 19:10 | |
| *** mriedem1 has quit IRC | 19:15 | |
| bnemec | dhellmann: Do you want another look at https://review.openstack.org/#/c/78806/ or should I go ahead and approve? | 19:21 |
| dhellmann | bnemec: lgtm, but you can approve | 19:22 |
| bnemec | dhellmann: Okay, cool. Just wanted to check because you had left a lot of comments on it. :-) | 19:22 |
| dhellmann | bnemec: yep, thanks :-) | 19:23 |
| dims_ | mriedem, ack | 19:34 |
| mriedem | dims_: opened https://bugs.launchpad.net/cinder/+bug/1290503, was wondering if any of that made sense to you since you worked on that domain context stuff | 19:36 |
| mriedem | but now i'm wondering if it's related to bug 1288049 | 19:36 |
| *** rpodolyaka has quit IRC | 19:41 | |
| dims_ | mriedem, see the differences in the log format string | 19:41 |
| dims_ | oslo-incubator/etc/openstack.conf.sample: #logging_context_format_string=%(asctime)s.%(msecs)03d %(process)d %(levelname)s %(name)s [%(request_id)s %(user_identity)s] %(instance)s%(message)s | 19:41 |
| dims_ | nova/etc/nova.conf.sample: #logging_context_format_string=%(asctime)s.%(msecs)03d %(process)d %(levelname)s %(name)s [%(request_id)s %(user)s %(tenant)s] %(instance)s%(message)s | 19:41 |
| dims_ | cinder may be using user | 19:42 |
| dims_ | mriedem, try switching https://github.com/openstack/cinder/blob/master/cinder/openstack/common/log.py#L144 to look like Nova's | 19:44 |
| mriedem | dims_: well nova doesn't use that stuff in it's request context i don't think, nova has it's own request context | 19:44 |
| mriedem | it doesn't use oslo's | 19:44 |
| mriedem | from what i remmeber | 19:44 |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Be smarter about config generator default package name https://review.openstack.org/79429 | 19:52 |
| bnemec | Hah! 20 pending reviews. Pretty sure that's a new record for me. :-) | 19:54 |
| lbragstad | bnemec: ++ nice | 19:55 |
| bnemec | lbragstad: Clearly I need to get busy reviewing now. :-) | 19:56 |
| lbragstad | :) | 19:57 |
| dims_ | mriedem, that was just the initial thought looking at the stack trace. i am heading out, should be back later today. will look deeper | 19:57 |
| bnemec | Heh, awesome. The utf8 thing came up on the list about an hour after we discussed it here. | 20:01 |
| bnemec | Guess we're not the only ones worried about it. | 20:01 |
| openstackgerrit | gordon chung proposed a change to openstack/pycadf: add docstrings to functions https://review.openstack.org/79440 | 20:29 |
| *** rpodolyaka has joined #openstack-oslo | 20:41 | |
| *** rpodolyaka has quit IRC | 20:46 | |
| *** rpodolyaka has joined #openstack-oslo | 20:47 | |
| openstackgerrit | gordon chung proposed a change to openstack/pycadf: add docstrings to functions https://review.openstack.org/79440 | 21:18 |
| openstackgerrit | Jenkins proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/77644 | 21:36 |
| *** dims_ has quit IRC | 21:58 | |
| *** lbragstad has quit IRC | 22:15 | |
| *** dims_ has joined #openstack-oslo | 22:15 | |
| harlowja | dhellmann off the top of your head do u know if there are bugs/blueprints tracking the oslo.messaging py3.3 adjustments? | 22:32 |
| *** mriedem has left #openstack-oslo | 22:37 | |
| *** yamahata has quit IRC | 22:54 | |
| *** yamahata has joined #openstack-oslo | 22:56 | |
| *** rpodolyaka has quit IRC | 23:04 | |
| *** rpodolyaka has joined #openstack-oslo | 23:09 | |
| *** flaper87 is now known as flaper87|afk | 23:22 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo.messaging: Start adding a futures executor based executor https://review.openstack.org/70914 | 23:23 |
| *** yamahata has quit IRC | 23:31 | |
| openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: WIP: Support -S flag in scripts https://review.openstack.org/79492 | 23:39 |
| *** beav has quit IRC | 23:45 | |
| *** beav has joined #openstack-oslo | 23:46 | |
| *** beav has quit IRC | 23:50 | |
| *** bknudson has joined #openstack-oslo | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!