*** yamahata has joined #openstack-oslo | 00:36 | |
*** yamahata has quit IRC | 01:45 | |
*** yamahata has joined #openstack-oslo | 03:30 | |
*** zhiyan_ is now known as zhiyan | 03:50 | |
*** zhiyan is now known as zhiyan_ | 04:39 | |
openstackgerrit | Ian Wienand proposed a change to openstack/oslo-incubator: Don't call provision.py directly https://review.openstack.org/85634 | 05:11 |
---|---|---|
openstackgerrit | Ian Wienand proposed a change to openstack/oslo-incubator: Add OSLO_LOCK_PATH if not set https://review.openstack.org/85637 | 05:33 |
openstackgerrit | Ian Wienand proposed a change to openstack/oslo-incubator: Add funcName to audit/info message output https://review.openstack.org/85638 | 05:45 |
*** ihrachyshka has joined #openstack-oslo | 06:10 | |
*** ihrachyshka has quit IRC | 06:40 | |
*** flaper87|afk is now known as flaper87 | 07:04 | |
*** ihrachyshka has joined #openstack-oslo | 07:23 | |
*** I159 has joined #openstack-oslo | 07:35 | |
*** dshulyak has joined #openstack-oslo | 08:16 | |
*** rpodolyaka has quit IRC | 08:31 | |
*** rpodolyaka1 has joined #openstack-oslo | 08:31 | |
*** rpodolyaka1 has left #openstack-oslo | 08:46 | |
*** rpodolyaka1 has joined #openstack-oslo | 08:46 | |
*** arosen has quit IRC | 09:07 | |
*** ihrachyshka has quit IRC | 09:15 | |
*** stannie has joined #openstack-oslo | 09:32 | |
*** ihrachyshka has joined #openstack-oslo | 09:48 | |
*** killzone has quit IRC | 10:03 | |
openstackgerrit | Victor Stinner proposed a change to openstack/oslo-incubator: Fix unit/rpc/test_common.py on Python 3 https://review.openstack.org/80533 | 10:07 |
*** sreshetnyak has joined #openstack-oslo | 10:14 | |
openstackgerrit | Victor Stinner proposed a change to openstack/oslo-incubator: Fix safe_encode(): return bytes on Python 3 https://review.openstack.org/80571 | 10:17 |
*** sreshetnyak has quit IRC | 10:27 | |
*** sreshetnyak has joined #openstack-oslo | 10:27 | |
openstackgerrit | Victor Stinner proposed a change to openstack/oslo-incubator: Partial fix of test_strutils.py on Python 3 https://review.openstack.org/80573 | 10:42 |
*** sreshetnyak has quit IRC | 11:50 | |
*** sreshetnyak has joined #openstack-oslo | 11:52 | |
*** lbragstad has quit IRC | 12:01 | |
*** yamahata has quit IRC | 12:20 | |
*** bogdando has quit IRC | 12:22 | |
*** bogdando has joined #openstack-oslo | 12:22 | |
*** jecarey has quit IRC | 12:29 | |
*** lbragstad has joined #openstack-oslo | 12:34 | |
*** sergmelikyan has joined #openstack-oslo | 12:36 | |
sergmelikyan | dhellmann, I have a few questions about design of oslo.config. | 12:37 |
sergmelikyan | Why does it have global options state? (all options registered application wide) and does not follow, for example, Python config module design? | 12:38 |
*** ihrachyshka has quit IRC | 12:40 | |
*** ihrachyshka has joined #openstack-oslo | 12:40 | |
*** erecio has joined #openstack-oslo | 12:41 | |
dhellmann | sergmelikyan: lots of history there: https://wiki.openstack.org/wiki/Oslo#Why_does_oslo.config_have_a_CONF_object.3F_Global_object_SUCK.21 | 12:55 |
sergmelikyan | dhellmann, thx! | 12:58 |
*** jecarey has joined #openstack-oslo | 13:05 | |
openstackgerrit | Victor Stinner proposed a change to openstack/oslo.messaging: Add an optional timeout parameter to Listener.poll https://review.openstack.org/71003 | 13:08 |
*** rustlebee is now known as russellb | 13:08 | |
*** mriedem has joined #openstack-oslo | 13:15 | |
*** dims has joined #openstack-oslo | 13:22 | |
mriedem | hey oslophiles, question about this: | 13:35 |
mriedem | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/utils.py#L252 | 13:35 |
mriedem | turns out that doesn't work if yo'ure creating foreign keys because the metadata has to be shared between table objects for it to work | 13:35 |
mriedem | i'm thinking about at least putting a NOTE in that code to warn against trying to use it for FK creation, any opinion on that? alternative is add kwarg for metadata and default to None | 13:36 |
openstackgerrit | Victor Stinner proposed a change to openstack/oslo-incubator: New module openstack.common.time_monotonic https://review.openstack.org/85717 | 13:44 |
*** yamahata has joined #openstack-oslo | 13:45 | |
dhellmann | mriedem: should that function take an optional metadata arg to handle the case you describe? | 13:46 |
mriedem | dhellmann: that's what i was thinking....and was just writing a bug but then cancelled it | 13:46 |
openstackgerrit | garyk proposed a change to openstack/oslo.vmware: Remove __del__ usage in oslo.vmware driver https://review.openstack.org/82781 | 13:46 |
mriedem | because if you provide metadata, the method is really only doing one thing for you, creating the table | 13:46 |
dhellmann | mriedem: well, good point | 13:46 |
mriedem | dhellmann: so the utility becomes less of a utility at that point | 13:46 |
mriedem | dhellmann: at a minimum i'll push up a patch that adds a note to not use it's current form for FK creation | 13:47 |
mriedem | so someone else doesn't lose a few days like me :) | 13:47 |
dhellmann | mriedem: the note sounds good, maybe in the docstring so it ends up in the generated docs, too | 13:47 |
mriedem | dhellmann: sure, will do | 13:47 |
dhellmann | mriedem: I wonder how widely used that function is, if it's not useful for making tables with foreign keys. I guess it's still useful for examining the current table structure? | 13:48 |
mriedem | dhellmann: yeah, you can still use it for other things like altering columns, creating/dropping unique constraints, etc | 13:48 |
dhellmann | mriedem: makes sense | 13:49 |
dhellmann | a nice ".. warning:: Do not use for creating fkeys because..." does seem in order | 13:49 |
mriedem | dhellmann: yup, doing it now | 13:50 |
mriedem | i'll open a bug to back it up with the stacktrace you get if you use it incorrectly for more details | 13:50 |
dhellmann | mriedem: perfect, thanks | 13:53 |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Add a warning to not use get_table for working with ForeignKeys https://review.openstack.org/85722 | 14:18 |
openstackgerrit | Victor Stinner proposed a change to openstack/oslo-incubator: timeutils: add time_monotonic() function https://review.openstack.org/85717 | 14:21 |
openstackgerrit | Victor Stinner proposed a change to openstack/oslo-incubator: timeutils: add time_monotonic() function https://review.openstack.org/85717 | 14:49 |
*** yamahata has quit IRC | 15:04 | |
*** yamahata has joined #openstack-oslo | 15:04 | |
*** ihrachyshka has quit IRC | 15:24 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Remove PrettyTable from documentation requirements https://review.openstack.org/84515 | 15:36 |
openstackgerrit | Cyril Roelandt proposed a change to openstack/oslo.config: Fix test_version on Python 3.4 https://review.openstack.org/85608 | 15:46 |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Add a warning to not use get_table for working with ForeignKeys https://review.openstack.org/85722 | 15:54 |
dhellmann | what's the deal with run_tests.sh? is that still used (on purpose)? I see a few changes related to making it work, should we just remove it instead? | 16:01 |
openstackgerrit | Russell Bryant proposed a change to openstack/oslo.messaging: Update ensure() to catch all Exceptions. https://review.openstack.org/85750 | 16:01 |
*** I159 has quit IRC | 16:12 | |
*** markmcclain has joined #openstack-oslo | 16:33 | |
*** beekneemech is now known as bnemec | 16:34 | |
bnemec | dhellmann: It might be time to revisit removing run_tests.sh. I know there have been some improvements to tox and friends to address the things people were still using run_tests for. | 16:35 |
bnemec | And I think run_tests.sh is broken more often than not since hardly anyone uses it anymore. :-) | 16:35 |
*** harlowja has joined #openstack-oslo | 16:56 | |
dhellmann | bnemec: yeah, that's sort of what I thought | 16:58 |
dhellmann | bnemec: we could also make it just run tox, I suppose | 16:58 |
*** markmcclain has quit IRC | 16:59 | |
*** markmcclain has joined #openstack-oslo | 17:00 | |
*** markmcclain has quit IRC | 17:00 | |
openstackgerrit | Jenkins proposed a change to openstack/cliff: Updated from global requirements https://review.openstack.org/83120 | 17:29 |
*** mriedem has quit IRC | 17:33 | |
openstackgerrit | Jenkins proposed a change to openstack/pycadf: Updated from global requirements https://review.openstack.org/85765 | 17:36 |
openstackgerrit | Jenkins proposed a change to openstack/stevedore: Updated from global requirements https://review.openstack.org/75595 | 17:38 |
openstackgerrit | Cyril Roelandt proposed a change to openstack/oslo.config: Fix test_version on Python 3.4 https://review.openstack.org/85608 | 17:44 |
*** mriedem has joined #openstack-oslo | 17:44 | |
*** arnaud has joined #openstack-oslo | 17:48 | |
openstackgerrit | Russell Bryant proposed a change to openstack/oslo.messaging: Update ensure() to catch all Exceptions https://review.openstack.org/85750 | 17:53 |
russellb | that period in commit message check drives me crazy | 18:03 |
harlowja | russellb +1, i don't quite get it | 18:13 |
*** hartsocks has joined #openstack-oslo | 18:20 | |
*** morganfainberg_Z is now known as morganfainberg | 18:39 | |
*** markmcclain has joined #openstack-oslo | 18:39 | |
openstackgerrit | Russell Bryant proposed a change to openstack/oslo.messaging: Update ensure() to catch all MessagingExceptions https://review.openstack.org/85750 | 18:47 |
openstackgerrit | Russell Bryant proposed a change to openstack/oslo.messaging: Update ensure() to catch MessagingError https://review.openstack.org/85750 | 18:47 |
*** markmcclain has quit IRC | 19:26 | |
*** harlowja has quit IRC | 20:03 | |
*** dims has quit IRC | 20:08 | |
*** russellb_ has joined #openstack-oslo | 20:09 | |
*** boris-42 has quit IRC | 20:10 | |
*** russellb has quit IRC | 20:10 | |
*** russellb_ is now known as russellb | 20:10 | |
*** markmcclain has joined #openstack-oslo | 20:18 | |
*** harlowja has joined #openstack-oslo | 20:19 | |
*** boris-42 has joined #openstack-oslo | 20:28 | |
*** markmcclain has quit IRC | 20:32 | |
*** markmcclain has joined #openstack-oslo | 20:32 | |
*** erecio has quit IRC | 20:49 | |
*** arnaud has quit IRC | 20:59 | |
openstackgerrit | Jenkins proposed a change to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/85816 | 21:06 |
*** GheRivero_ has joined #openstack-oslo | 21:10 | |
openstackgerrit | Jenkins proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/85831 | 21:15 |
openstackgerrit | Jenkins proposed a change to openstack/taskflow: Updated from global requirements https://review.openstack.org/85842 | 21:17 |
openstackgerrit | Jenkins proposed a change to openstack/cliff: Updated from global requirements https://review.openstack.org/83120 | 21:19 |
*** harlowja is now known as harlowja_away | 21:31 | |
*** harlowja_away is now known as harlowja | 21:35 | |
*** GheRivero has quit IRC | 21:55 | |
*** GheRivero_ is now known as GheRivero | 21:55 | |
*** mriedem has quit IRC | 21:56 | |
*** markmcclain has quit IRC | 22:02 | |
*** mriedem has joined #openstack-oslo | 22:06 | |
*** markmcclain has joined #openstack-oslo | 22:06 | |
*** jecarey_ has joined #openstack-oslo | 22:19 | |
*** jecarey has quit IRC | 22:19 | |
*** lbragstad has quit IRC | 22:24 | |
*** jecarey_ has quit IRC | 22:25 | |
*** arnaud has joined #openstack-oslo | 22:34 | |
*** zhiyan_ has quit IRC | 22:34 | |
*** zhiyan_ has joined #openstack-oslo | 22:35 | |
*** mriedem has quit IRC | 22:52 | |
*** yamahata has quit IRC | 23:24 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Integrate urlparse for configuration augmentation https://review.openstack.org/85494 | 23:32 |
*** flaper87 is now known as flaper87|afk | 23:33 | |
openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Add test case for config generator hostname check https://review.openstack.org/83594 | 23:33 |
*** markmcclain has quit IRC | 23:35 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow for only iterating over the most 'fresh' jobs https://review.openstack.org/85520 | 23:35 |
*** markmcclain has joined #openstack-oslo | 23:35 | |
*** markmcclain has quit IRC | 23:52 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!