| *** shakamunyi has joined #openstack-oslo | 00:31 | |
| *** shakamunyi has quit IRC | 00:37 | |
| *** mriedem1 has quit IRC | 01:01 | |
| *** mriedem has joined #openstack-oslo | 01:05 | |
| mriedem | if there are any db people around, i just found out that nova's db utils for drop_unique_constraint recreates the table for sqlite but oslo db utils doesn't here: | 01:29 |
|---|---|---|
| mriedem | https://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/utils.py#L307 | 01:29 |
| mriedem | that makes me said b/c i'm trying to remove this code from nova: https://review.openstack.org/#/c/79070/ | 01:29 |
| mriedem | does anyone know why oslo db utils is different? | 01:29 |
| mriedem | s/said/sad/ :( | 01:30 |
| dhellmann | mriedem: either something wasn't synced into nova from the incbuator, or the other way around | 01:30 |
| dhellmann | mriedem: I'd have to look at the git-blame output for the file(s) | 01:30 |
| mriedem | dhellmann: i can do that | 01:30 |
| mriedem | if oslo is way older i'll sync from nova to oslo | 01:31 |
| mriedem | boris-42: in case you know any history ^ | 01:31 |
| dhellmann | mriedem: sounds good; you'll want to coordinate that with victors and rpodolyaka | 01:31 |
| mriedem | dhellmann: yeah, looks like viktors did the sync from nova: https://review.openstack.org/37439 | 01:32 |
| mriedem | but that's not the same code that's been in nova.db.sqlalchemy.utils so not sure where he synced that from in nova | 01:33 |
| dhellmann | mriedem: probably nova.openstack.common.db? | 01:50 |
| mriedem | dhellmann: checking that now, maybe, would have meant someone modified that directly in nova and not oslo, or something weird | 01:52 |
| mriedem | anyway, opened bug 1307266 to track it | 01:52 |
| mriedem | and nova didn't sync oslo db for a looong time before icehouse | 01:52 |
| mriedem | like around grizzly i think | 01:52 |
| mriedem | nope, the way that method exists in oslo didn't exist that way in nova since grizzly | 01:54 |
| mriedem | so i don't know where it came from or how it ended up that way | 01:54 |
| dhellmann | mriedem: I don't like mysterious code :-/ | 01:55 |
| mriedem | dhellmann: i guess no one else is using that utility method | 01:55 |
| mriedem | nova wasn't | 01:55 |
| mriedem | anyway, i'll clean it up this week | 01:56 |
| dhellmann | ok, cool -- thanks! | 01:56 |
| mriedem | np | 01:56 |
| mriedem | then i can gut 1000+ LOC from nova | 01:56 |
| *** mriedem has left #openstack-oslo | 02:04 | |
| *** mriedem has quit IRC | 02:04 | |
| *** zhiyan_ is now known as zhiyan | 02:41 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a deprecation module https://review.openstack.org/87055 | 03:17 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a deprecation module https://review.openstack.org/87055 | 03:21 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a deprecation module https://review.openstack.org/87055 | 03:22 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a deprecation module https://review.openstack.org/87055 | 03:25 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a deprecation module https://review.openstack.org/87055 | 03:29 |
| *** zhiyan is now known as zhiyan_ | 04:07 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a deprecation module https://review.openstack.org/87055 | 04:15 |
| *** gcb has joined #openstack-oslo | 04:45 | |
| *** zhiyan_ is now known as zhiyan | 05:43 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Always return unicode exception message https://review.openstack.org/87162 | 05:58 |
| openstackgerrit | Mitsuru Kanabuchi proposed a change to openstack/oslo-incubator: Add ThreadGroup:stop_timers and stop_threads https://review.openstack.org/87180 | 07:10 |
| *** flaper87|afk is now known as flaper87 | 07:17 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Always return unicode exception message https://review.openstack.org/87162 | 07:17 |
| *** dshulyak has joined #openstack-oslo | 07:46 | |
| *** ihrachyshka has joined #openstack-oslo | 07:53 | |
| *** morganfainberg is now known as morganfainberg_Z | 08:00 | |
| *** ihrachyshka has quit IRC | 08:05 | |
| *** ihrachyshka has joined #openstack-oslo | 08:05 | |
| *** zhiyan is now known as zhiyan_ | 09:30 | |
| *** ihrachyshka has quit IRC | 10:36 | |
| *** ihrachyshka has joined #openstack-oslo | 10:53 | |
| *** ihrachyshka has quit IRC | 10:57 | |
| openstackgerrit | Bogdan Dobrelya proposed a change to openstack/oslo-incubator: Fix python26 compatibility for RFCSysLogHandler https://review.openstack.org/86875 | 11:14 |
| openstackgerrit | Bogdan Dobrelya proposed a change to openstack/oslo-incubator: Fix python26 compatibility for RFCSysLogHandler https://review.openstack.org/86875 | 11:27 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo-incubator: Opportunistic migration tests https://review.openstack.org/75107 | 11:49 |
| openstackgerrit | Bogdan Dobrelya proposed a change to openstack/oslo-incubator: Fix python26 compatibility for RFCSysLogHandler https://review.openstack.org/86875 | 11:52 |
| *** zhiyan_ is now known as zhiyan | 12:27 | |
| *** zhiyan is now known as zhiyan_ | 12:36 | |
| *** zhiyan_ is now known as zhiyan | 12:36 | |
| *** erecio has joined #openstack-oslo | 12:51 | |
| *** erecio has quit IRC | 12:52 | |
| *** erecio has joined #openstack-oslo | 12:53 | |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslo-incubator: Remove deprecated LoopingCall https://review.openstack.org/87262 | 12:59 |
| *** jecarey has quit IRC | 13:00 | |
| *** gcb has quit IRC | 13:03 | |
| *** bknudson has quit IRC | 13:06 | |
| *** erecio has joined #openstack-oslo | 13:18 | |
| *** mriedem has joined #openstack-oslo | 13:18 | |
| *** gcb has joined #openstack-oslo | 13:29 | |
| *** jecarey has joined #openstack-oslo | 13:42 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack/oslo-incubator: Missing parameter added in policy.py https://review.openstack.org/87272 | 14:01 |
| *** I159 has joined #openstack-oslo | 14:11 | |
| *** beekneemech is now known as bnemec | 14:18 | |
| *** dims has quit IRC | 14:35 | |
| openstackgerrit | Cyril Roelandt proposed a change to openstack/oslo-incubator: sizelimit: port to Python 3 https://review.openstack.org/80450 | 14:39 |
| *** bknudson has joined #openstack-oslo | 14:41 | |
| *** dims has joined #openstack-oslo | 14:42 | |
| *** erecio has quit IRC | 14:44 | |
| *** zhiyan is now known as zhiyan_ | 14:54 | |
| openstackgerrit | Cyril Roelandt proposed a change to openstack/oslo-incubator: sizelimit: port to Python 3 https://review.openstack.org/80450 | 15:09 |
| *** dims has quit IRC | 15:13 | |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslo-incubator: Remove deprecated LoopingCall https://review.openstack.org/87262 | 15:14 |
| openstackgerrit | Dirk Mueller proposed a change to openstack-dev/hacking: Open 0.9.0 development https://review.openstack.org/87301 | 15:38 |
| *** dims has joined #openstack-oslo | 15:39 | |
| mriedem | rpodolyaka: viktors: ping re bug https://bugs.launchpad.net/oslo/+bug/1307266 and https://review.openstack.org/#/c/37439/ | 15:48 |
| *** I159 has quit IRC | 15:51 | |
| *** dims has quit IRC | 15:52 | |
| *** dims has joined #openstack-oslo | 16:05 | |
| *** dims has quit IRC | 16:13 | |
| openstackgerrit | Alan Pevec proposed a change to openstack/oslo-incubator: Move notification point to a better place https://review.openstack.org/87309 | 16:19 |
| *** dims has joined #openstack-oslo | 16:27 | |
| *** gcb has quit IRC | 16:28 | |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslo-incubator: Compatibility with Pep8 1.5.4+ https://review.openstack.org/87313 | 16:40 |
| *** arnaud has joined #openstack-oslo | 16:44 | |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslo-incubator: Compatibility with Pep8 1.5.4+ https://review.openstack.org/87313 | 16:48 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix common.cliutils to work with Python3 https://review.openstack.org/87319 | 16:50 |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslo.rootwrap: Remove unused variable 'command' https://review.openstack.org/87320 | 16:53 |
| openstackgerrit | Dirk Mueller proposed a change to openstack/oslo.rootwrap: Fix import grouping https://review.openstack.org/87321 | 16:53 |
| *** harlowja_away is now known as harlowja | 16:54 | |
| openstackgerrit | Thomas Bechtold proposed a change to openstack/taskflow: Reuse already defined variable https://review.openstack.org/87323 | 17:06 |
| harlowja | dhellmann thx, although version_utils is pretty much catered to openstack releases and not generic library versions it appears | 17:16 |
| dhellmann | harlowja, yeah | 17:16 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a deprecation module https://review.openstack.org/87055 | 17:18 |
| harlowja | dhellmann which is why maybe we can suck ^ into oslo or something | 17:24 |
| dhellmann | harlowja: there's also http://git.openstack.org/cgit/openstack/oslo-incubator/tree/openstack/common/log.py#n314 | 17:25 |
| dhellmann | but yeah, all of that needs to be collected into one place -- I thought to put it in oslo.version | 17:26 |
| harlowja | dhellmann ya, that one seems odd (in log.py) since i thought the warnings module was the expected place to emit these in python (not the logging module) | 17:26 |
| dhellmann | harlowja: I think that was about making the API easy to reach | 17:27 |
| dhellmann | "we already have a log object everywhere and we want deprecations logged" or something | 17:27 |
| harlowja | gotcha | 17:27 |
| harlowja | warnings module is everywhere to :-P | 17:27 |
| harlowja | ;) | 17:27 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix common.scheduler.base_weight.BaseWeigher to be Python3 compatible https://review.openstack.org/87336 | 17:30 |
| harlowja | dhellmann ack, more meetings :-P | 17:52 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix common.scheduler.base_weight.BaseWeigher to be Python3 compatible https://review.openstack.org/87336 | 17:56 |
| *** morganfainberg_Z is now known as morganfainberg | 18:15 | |
| *** I159 has joined #openstack-oslo | 18:26 | |
| *** I159 has quit IRC | 19:02 | |
| *** markmc has joined #openstack-oslo | 19:03 | |
| openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Fix drop_unique_constraint utility for sqlite https://review.openstack.org/87369 | 20:00 |
| mriedem | dhellmann: dims: bnemec: ^ fix for https://review.openstack.org/#/c/37439/ | 20:00 |
| dhellmann | mriedem: thanks, I'll look at it this afternoon | 20:01 |
| mriedem | dhellmann: ha, so i just saw this in oslo's version: "DEPRECATED: this function is deprecated and will be removed from oslo.db" | 20:02 |
| dhellmann | mriedem: yeah, we need a better way to track deprecated stuff :-/ | 20:03 |
| mriedem | dhellmann: speak of the devil, harlowja has something in taskflow up for review for that | 20:03 |
| mriedem | https://review.openstack.org/#/c/87055/ | 20:03 |
| *** markmc has quit IRC | 20:05 | |
| dhellmann | mriedem: we have some deprecation stuff in oslo's log and versionutils modules, too | 20:06 |
| mriedem | dhellmann: anyway, the deprecation message is wrong anyway | 20:11 |
| mriedem | you can't use sqla-migrate's UniqueConstraint.drop directly since it raises the not supported exception | 20:12 |
| mriedem | https://github.com/stackforge/sqlalchemy-migrate/blob/0.9/migrate/changeset/databases/sqlite.py#L143 | 20:12 |
| mriedem | you'll just blow up more directly :) | 20:12 |
| dhellmann | hrm | 20:13 |
| openstackgerrit | George Peristerakis proposed a change to openstack/oslo-incubator: Import mock is python 3 compatible https://review.openstack.org/87375 | 20:22 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix tests.unit.reports.test_views failures under Python3 https://review.openstack.org/87376 | 20:24 |
| harlowja | mriedem speak of the devil! | 20:30 |
| harlowja | lol | 20:30 |
| mriedem | muwahaha | 20:30 |
| harlowja | i'm not sure which one is the best though, ha, the versionutils one seems tied to openstack versions (not then useful for clients or other libraries), the log stuff is useful only if u are using oslo.log | 20:32 |
| harlowja | the stuff i was trying to create would/could be useful to all, but its not the current way of doing it | 20:33 |
| harlowja | although https://review.openstack.org/#/c/87055/ does seem to be more of how the external world does it, but idk | 20:33 |
| dhellmann | harlowja: as part of graduating oslo.log, I want to move the body of that log function to the versionutils module | 20:36 |
| dhellmann | otherwise we have a circular dependency | 20:36 |
| *** jecarey has quit IRC | 20:44 | |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix tests.unit.reports.test_views failures under Python3 https://review.openstack.org/87376 | 20:46 |
| *** yamahata has joined #openstack-oslo | 20:47 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Add API for creating translation functions https://review.openstack.org/87386 | 20:55 |
| *** jecarey has joined #openstack-oslo | 20:57 | |
| *** markmcclain has joined #openstack-oslo | 21:00 | |
| harlowja | dhellmann agreed, that does make sense | 21:11 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix tests.unit.reports.test_views failures under Python3 https://review.openstack.org/87376 | 21:49 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix tests.unit.reports.test_views failures under Python3 https://review.openstack.org/87376 | 21:51 |
| *** mriedem has left #openstack-oslo | 21:53 | |
| *** mriedem has quit IRC | 21:53 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Always return unicode exception message https://review.openstack.org/87162 | 21:53 |
| *** dims has quit IRC | 21:57 | |
| *** markmcclain has quit IRC | 22:01 | |
| *** dims has joined #openstack-oslo | 22:10 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Integrate urlparse for configuration augmentation https://review.openstack.org/85494 | 22:10 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix tests.unit.reports.test_views failures under Python3 https://review.openstack.org/87376 | 22:14 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use sequencing when posting jobs https://review.openstack.org/86198 | 22:47 |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix tests.unit.reports.test_guru_meditation_report under Python3 https://review.openstack.org/87404 | 22:54 |
| *** dims has quit IRC | 22:57 | |
| *** yamahata has quit IRC | 23:01 | |
| *** bknudson has quit IRC | 23:12 | |
| *** dims has joined #openstack-oslo | 23:22 | |
| *** flaper87 is now known as flaper87|afk | 23:23 | |
| openstackgerrit | Frederic Lepied proposed a change to openstack/oslo-incubator: Fix tests/unit/crypto/test_utils.py under Python3 https://review.openstack.org/87413 | 23:46 |
| *** yamahata has joined #openstack-oslo | 23:47 | |
| *** yamahata has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!