*** zhiyan_ is now known as zhiyan | 00:37 | |
*** zhiyan has quit IRC | 00:58 | |
*** norman has quit IRC | 00:58 | |
*** zhiyan has joined #openstack-oslo | 01:00 | |
*** harlowja has joined #openstack-oslo | 01:00 | |
morganfainberg | dhellmann, i could see a single "breakout" like session being useful +1 from me | 01:10 |
---|---|---|
*** jecarey has joined #openstack-oslo | 01:11 | |
*** yamahata_ has joined #openstack-oslo | 01:19 | |
*** yamahata has joined #openstack-oslo | 01:20 | |
*** norman has joined #openstack-oslo | 01:41 | |
*** amotoki has quit IRC | 02:43 | |
*** morganfainberg is now known as morganfainberg_Z | 02:47 | |
*** yamahata has quit IRC | 02:57 | |
*** wingwj has joined #openstack-oslo | 03:07 | |
*** harlowja is now known as harlowja_away | 03:09 | |
*** arnaud has quit IRC | 03:10 | |
*** norman has quit IRC | 03:35 | |
*** yamahata has joined #openstack-oslo | 04:17 | |
*** harlowja_away is now known as harlowja | 04:18 | |
*** arnaud__ has joined #openstack-oslo | 04:40 | |
*** yamahata has quit IRC | 04:48 | |
*** yamahata has joined #openstack-oslo | 04:49 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Implement run iterations https://review.openstack.org/86470 | 05:06 |
*** amotoki has joined #openstack-oslo | 05:33 | |
*** arnaud__ has quit IRC | 05:52 | |
*** harlowja is now known as harlowja_away | 06:30 | |
*** flaper87|afk is now known as flaper87 | 06:38 | |
*** shakamunyi has quit IRC | 06:42 | |
openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Implements notification-dispatcher-filter https://review.openstack.org/77886 | 07:05 |
*** shakamunyi has joined #openstack-oslo | 07:08 | |
*** ihrachyshka has joined #openstack-oslo | 07:09 | |
*** shakamunyi has quit IRC | 07:12 | |
*** ihrachyshka has quit IRC | 07:19 | |
*** ihrachyshka has joined #openstack-oslo | 07:20 | |
*** rpodolyaka has joined #openstack-oslo | 07:37 | |
*** rpodolyaka has quit IRC | 07:47 | |
*** rpodolyaka has joined #openstack-oslo | 07:47 | |
*** shakamunyi has joined #openstack-oslo | 08:08 | |
*** shakamunyi has quit IRC | 08:13 | |
*** markmc has joined #openstack-oslo | 08:42 | |
*** viktors|afk is now known as viktors | 08:45 | |
*** 5EXAA26CG has joined #openstack-oslo | 08:49 | |
*** ihrachyshka has quit IRC | 08:58 | |
*** shakamunyi has joined #openstack-oslo | 09:09 | |
*** shakamunyi has quit IRC | 09:14 | |
*** zhiyan is now known as zhiyan_ | 09:32 | |
*** zhiyan_ is now known as zhiyan | 09:58 | |
*** ihrachyshka has joined #openstack-oslo | 10:06 | |
*** dims has quit IRC | 10:08 | |
*** zhiyan is now known as zhiyan_ | 10:08 | |
*** ihrachyshka has quit IRC | 10:09 | |
*** ihrachyshka has joined #openstack-oslo | 10:10 | |
*** shakamunyi has joined #openstack-oslo | 10:10 | |
openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Remove amqp default exchange hack. https://review.openstack.org/90046 | 10:11 |
openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Remove amqp default exchange hack https://review.openstack.org/90046 | 10:11 |
*** shakamunyi has quit IRC | 10:14 | |
*** dims has joined #openstack-oslo | 10:19 | |
*** ihrachyshka has quit IRC | 10:30 | |
*** shakamunyi has joined #openstack-oslo | 11:11 | |
*** shakamunyi has quit IRC | 11:15 | |
*** ihrachyshka has joined #openstack-oslo | 11:40 | |
*** shakamunyi has joined #openstack-oslo | 11:57 | |
*** erecio has joined #openstack-oslo | 12:09 | |
*** erecio has quit IRC | 12:13 | |
viktors | dims: around? | 12:15 |
*** erecio has joined #openstack-oslo | 12:24 | |
dims | viktors, pong | 12:26 |
*** erecio has quit IRC | 12:27 | |
viktors | dims: hello! I'm still looking for oslo.db-repository reviewers. Could you please look at it? | 12:34 |
dims | viktors, i glanced through it. if you ask me it's good enough to start with what you have right now and tweak it once we get that into oslo.db git tree | 12:36 |
dims | viktors, will leave a reply in the review | 12:38 |
viktors | dims: thanks! | 12:39 |
*** erecio has joined #openstack-oslo | 12:40 | |
*** bknudson has quit IRC | 13:14 | |
*** mriedem has joined #openstack-oslo | 13:17 | |
*** jecarey has quit IRC | 13:17 | |
*** markmcclain has joined #openstack-oslo | 13:19 | |
*** markmcclain has quit IRC | 13:20 | |
*** jecarey has joined #openstack-oslo | 13:35 | |
*** bknudson has joined #openstack-oslo | 13:41 | |
*** wpf has joined #openstack-oslo | 13:48 | |
*** zhiyan_ is now known as zhiyan | 13:55 | |
openstackgerrit | Julien Danjou proposed a change to openstack/stevedore: driver: raise by default on import failure https://review.openstack.org/90086 | 14:01 |
*** tongli has joined #openstack-oslo | 14:05 | |
viktors | dhellmann: hello | 14:10 |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo-incubator: Log a cause of db backend connection failure https://review.openstack.org/86640 | 14:12 |
dhellmann | viktors: hi | 14:20 |
dhellmann | viktors: did you rebuild the malors repository for oslo.db? I'm getting all sorts of merge errors when I try to refresh the copy I checked out to review. | 14:25 |
*** markmcclain has joined #openstack-oslo | 14:28 | |
viktors | dhellmann: yes, last week I pushed there gradulate.sh output | 14:28 |
viktors | dhellmann: when have you cloned it? | 14:28 |
dhellmann | viktors: right after you pointed it out initially | 14:28 |
dhellmann | viktors: what caused you to need to rebuild it? | 14:29 |
viktors | dhellmann: hm... I've not rebuild the malors repository after it | 14:30 |
dhellmann | viktors: ok, I don't know what's going on then, maybe I messed up something locally | 14:30 |
viktors | dhellmann: I have no ideas also | 14:32 |
dhellmann | viktors: I'll just clone a new copy, it's not worth worrying about | 14:33 |
dhellmann | did you have something to ask me when you pinged earlier? | 14:33 |
viktors | dhellmann: I vanted to ask you, should I ping somebody else for oslo.db review? This repository was already reviewed by Julien, Davanum, Ronan and you. | 14:36 |
dhellmann | viktors: I think the code is ready to go, so when you address the comments on https://review.openstack.org/#/c/78955/ we'll make sure the infra team knows and schedule the import with them | 14:36 |
viktors | dhellmann: done recently | 14:37 |
dhellmann | viktors: ah, I needed to reload :-) | 14:37 |
viktors | dhellmann: :) | 14:37 |
*** wpf has quit IRC | 14:39 | |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo-incubator: Opportunistic migration tests https://review.openstack.org/75107 | 14:43 |
dhellmann | viktors: can you talk to Ilya about the pending changes to the db code, since it is being graduated? all of those patches should wait and be re-applied to the new oslo.db repository when it is created | 14:44 |
dhellmann | I don't know Ilya's IRC handle... | 14:44 |
viktors | dhellmann: ok, I'll inform him | 14:45 |
viktors | dhellmann: I suppose, your note also realted to rpodolyaka's patches? | 14:46 |
dhellmann | viktors: I hadn't noticed those, but the same would apply, yes | 14:46 |
*** 5EXAA26CG is now known as I159 | 14:49 | |
viktors | dhellmann: ok | 14:49 |
rpodolyaka | viktors: dhellmann: perhaps I'm a bit out of context here, but do you mean that patches like https://review.openstack.org/#/c/74081/ should wait? | 14:55 |
rpodolyaka | *until oslo.db is imported into a separate repo and we set up a gerrit review process | 14:55 |
dhellmann | rpodolyaka: yes, that's right | 14:55 |
dhellmann | we don't want the incubator code changed during the migration, because we'll lose patches | 14:56 |
rpodolyaka | ah, got it | 14:56 |
dhellmann | I went ahead and -2 that one, since it only needed one more +2 | 14:57 |
dhellmann | viktors, rpodolyaka : maybe we need to automate a check based on https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Updating_the_Incubator and add a check job for it | 14:58 |
*** nacim has joined #openstack-oslo | 14:58 | |
rpodolyaka | dhellmann: probably | 15:02 |
*** dims has quit IRC | 15:03 | |
rpodolyaka | dhellmann: it's definitely not critical for db patches, as viktors and I have been reviewing 90%+ of them :) but in general case, yes, if it can be automated, it should be automated | 15:04 |
*** dims has joined #openstack-oslo | 15:05 | |
dhellmann | rpodolyaka: yeah, it might help if people aren't aware of changes going on -- one less thing for a reviewer to have to look for | 15:05 |
bnemec | FWIW, I did glance through the oslo.db repo and didn't see any problems. The tests all passed locally for me. | 15:08 |
viktors | dhellmann: but what about critical bugfixes? | 15:08 |
bnemec | I will admit I don't know exactly what I'm looking for there though. :-) | 15:08 |
viktors | dhellmann: how should we commit them to the graduating code? | 15:09 |
dhellmann | viktors: if that case actually comes up, we'll figure it out | 15:09 |
dhellmann | bnemec: just a sanity check, at this point | 15:10 |
*** ihrachyshka has quit IRC | 15:10 | |
bnemec | viktors: https://wiki.openstack.org/wiki/Oslo#Graduation has some discussion of how critical fixes should be handled. | 15:11 |
bnemec | dhellmann: Okay, sanity +1 then :-) | 15:11 |
* dhellmann is also in favor of sanity | 15:12 | |
viktors | bnemec: thanks, will look | 15:12 |
dhellmann | ultimately I would like the reviews of new repositories to go quickly, but there's always a possibility for a race condition there | 15:13 |
openstackgerrit | James Carey proposed a change to openstack/oslo.messaging: Enable log messages to handle exceptions containing unicode https://review.openstack.org/90111 | 15:13 |
viktors | dhellmann: tell me please, what should I do for ``Update Gerrit Groups and ACLs: TODO`` item ? | 15:22 |
dhellmann | viktors: the TODO list is a summary of the wiki, but along the way some of the titles have changed. That one corresponds to https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Update_the_Gerrit_Group_Members | 15:24 |
dhellmann | viktors: that step has to be done after infra has created the group for you in gerrit; I can walk you through it when you're ready to do it | 15:25 |
*** markmc has quit IRC | 15:25 | |
viktors | dhellmann: ok, thank you | 15:25 |
dhellmann | viktors: it's not hard, but I'll need to be looking at the gerrit screens to get the names of the links and fields right :-) | 15:26 |
* dhellmann makes a note to take screenshots of that process | 15:26 | |
*** dshulyak has quit IRC | 15:31 | |
openstackgerrit | James Carey proposed a change to openstack/oslo.messaging: Enable log messages to handle exceptions containing unicode https://review.openstack.org/90111 | 15:32 |
*** dshulyak has joined #openstack-oslo | 15:33 | |
*** adrian_otto has joined #openstack-oslo | 15:34 | |
dhellmann | viktors: here's a list of the pending db changes I found and -2: https://etherpad.openstack.org/p/oslo-db-blocked-incubator-changes | 15:38 |
*** I159 has quit IRC | 15:39 | |
viktors | dhellmann: ok, I'll check also | 15:41 |
viktors | dhellmann: I've added some patches to etherpad | 15:47 |
dhellmann | viktors: nice, thanks! | 15:47 |
*** markmcclain has quit IRC | 15:53 | |
*** ihrachyshka has joined #openstack-oslo | 15:56 | |
*** ihrachyshka has quit IRC | 16:02 | |
*** dims has quit IRC | 16:03 | |
*** ihrachyshka has joined #openstack-oslo | 16:03 | |
*** dims has joined #openstack-oslo | 16:05 | |
*** viktors is now known as viktors|afk | 16:14 | |
*** dims has quit IRC | 16:17 | |
*** dims has joined #openstack-oslo | 16:17 | |
*** nacim has quit IRC | 16:21 | |
hartsocks | dhellmann: ping | 16:37 |
dhellmann | hartsocks: pong | 16:37 |
hartsocks | dhellmann: I wanted to start moving on this again https://blueprints.launchpad.net/oslo/+spec/service-validation … | 16:38 |
hartsocks | dhellmann: I have notes here: https://etherpad.openstack.org/p/service-validation … but I think I lost something along the way. You were telling me about a plugin model I should use. | 16:38 |
dhellmann | the goal is to have application validation registered and performed early, without waiting for runtime logic to be invoked, right? | 16:39 |
hartsocks | yeah | 16:40 |
hartsocks | I recently did a Nova patch where ... | 16:40 |
hartsocks | … I hooked into the existing service start and shutdown … | 16:40 |
hartsocks | … it feels like that's the right kind of place to hook into. | 16:40 |
dhellmann | yeah, that seems valid | 16:40 |
dhellmann | there are a couple of problems to solve | 16:40 |
dhellmann | 1. discovering options that may not be registered yet | 16:40 |
dhellmann | 2. discovering the list of validators | 16:41 |
dhellmann | if we solve 2, we can use the validators to solve 1 | 16:41 |
dhellmann | so I think what I was suggesting was that you look at entry points as a way to find the functions that need to be run to validate the config | 16:41 |
dhellmann | each of those functions can register the options it needs (sharing the definitions with the code that actually uses those options, of course) | 16:42 |
*** richm has joined #openstack-oslo | 16:42 | |
richm | hello - question about oslo.messaging http://docs.openstack.org/developer/oslo.messaging/notification_listener.html | 16:42 |
richm | I'm trying to write a notification listener for nova events | 16:42 |
dhellmann | and then somewhere early in the startup process for the service, something would call oslo.config.validate(cfg.CONF, 'nova.configvalidators') or something like that | 16:42 |
richm | I'm using ^^^ as example code | 16:43 |
dhellmann | hartsocks: does that approach make sense? | 16:43 |
richm | I'm using Target(exchange='nova', topic='notifications') | 16:43 |
richm | I never get any hits | 16:43 |
dhellmann | hartsocks: the validators themselves just need to be callables that take a config object as argument and return a list of the things wrong (that way oslo.config.validate() can report all of the problems at one time before throwing the exception) | 16:43 |
richm | my NotificationEndpoint class has been extended to have all of the priorities - info, warn, etc. | 16:44 |
hartsocks | dhellmann: I get the idea. | 16:44 |
dhellmann | richm: have you compared what you're doing with what ceilometer does? | 16:44 |
richm | dhellmann: you mean this? http://git.openstack.org/cgit/openstack/ceilometer/tree/ceilometer/compute | 16:45 |
dhellmann | richm: you might need 'notifications.info' for example, instead of 'notifications' | 16:45 |
hartsocks | dhellmann: updated the etherpad. It was 'entry points' that I was forgetting. Thanks. | 16:48 |
dhellmann | hartsocks: sure thing | 16:48 |
dhellmann | richm: looks like ceilometer is also using 'notifications', so that's probably not it | 16:49 |
*** harlowja_away is now known as harlowja | 16:51 | |
openstackgerrit | George Peristerakis proposed a change to openstack/oslo-incubator: wrapping the mock module with six https://review.openstack.org/87375 | 16:55 |
*** zhiyan is now known as zhiyan_ | 17:03 | |
*** morganfainberg_Z is now known as morganfainberg | 17:12 | |
morganfainberg | dhellmann, re: https://review.openstack.org/#/c/89419/ i have a 1-line fix to solve your specific issue. i'll propose it and get it in, we can work on stevedore stuff (and acceptance) going forward | 17:16 |
*** adrian_otto has quit IRC | 17:16 | |
morganfainberg | dhellmann, also we're having the oslo meeting tomorrow morning, right? | 18:00 |
*** arnaud has joined #openstack-oslo | 18:00 | |
*** ihrachyshka has quit IRC | 18:07 | |
dhellmann | morganfainberg: yes, to the meeting; :-( to the resistance to following standards on plugins | 18:09 |
morganfainberg | dhellmann, we'll fight that battle. i'm sure we can get it in | 18:10 |
morganfainberg | dhellmann, there is always resistance to change | 18:10 |
dhellmann | morganfainberg: yeah, it's someone different every time lately | 18:10 |
morganfainberg | dhellmann, there are some concerns about consistency (valid) of the dbschema for testing if we require things to be added to an explicit list. tests will likely import the model anyway, so reflection created schemas will be different if it's not added | 18:10 |
morganfainberg | dhellmann, so lets not fight the big battle to fix a test cases (more immidiate fix needed) | 18:11 |
dhellmann | morganfainberg: makes sense | 18:11 |
morganfainberg | i've tested that change with both usedevelop=false and usedevelop=true | 18:12 |
morganfainberg | it looks like it resolves the issue | 18:12 |
morganfainberg | let me know if you're still seeing problems w/ packaging | 18:12 |
morganfainberg | (i know it's not through gate yet, but...) | 18:12 |
dhellmann | morganfainberg: have a link to your change handy? | 18:15 |
dhellmann | morganfainberg: it sounds like it should be fine, and our packaging job is pulling from master daily, so I'll keep an eye on both | 18:16 |
morganfainberg | dhellmann, https://review.openstack.org/#/c/90173/1 | 18:22 |
morganfainberg | dhellmann, cool | 18:22 |
*** markmcclain has joined #openstack-oslo | 19:07 | |
jogo | dhellmann: can you take another look at https://review.openstack.org/#/c/86692/ | 19:11 |
jogo | dhellmann: want to get my hacking series landed | 19:11 |
*** dims has quit IRC | 19:11 | |
*** tongli has quit IRC | 19:17 | |
*** ihrachyshka has joined #openstack-oslo | 19:27 | |
*** dims has joined #openstack-oslo | 19:33 | |
*** arnaud has quit IRC | 19:38 | |
*** ihrachyshka has quit IRC | 19:47 | |
*** ihrachyshka has joined #openstack-oslo | 19:47 | |
jogo | dims: now I just need a review on https://review.openstack.org/#/c/86692/ to make them all land | 19:56 |
jogo | morganfainberg: ^ | 19:57 |
jogo | woot thanks dims | 19:57 |
morganfainberg | jogo, hi! | 19:57 |
jogo | morganfainberg: never mind, got the review | 19:58 |
morganfainberg | jogo, sure thing! | 19:58 |
jogo | morganfainberg: had a 6 or 7 deep dependant branch that wanted to go away | 19:58 |
morganfainberg | aha, makes sense | 19:58 |
dims | :) | 19:59 |
*** harlowja is now known as harlowja_away | 20:06 | |
*** bknudson has quit IRC | 20:28 | |
*** jecarey has quit IRC | 20:32 | |
*** bknudson has joined #openstack-oslo | 20:37 | |
*** jecarey has joined #openstack-oslo | 20:42 | |
*** erecio has quit IRC | 20:55 | |
*** harlowja_away is now known as harlowja | 21:01 | |
*** markmcclain has quit IRC | 21:23 | |
*** yamahata has quit IRC | 21:24 | |
dhellmann | dims, if you have a few minutes to look at https://review.openstack.org/#/c/87386/ I'd appreciate it (gettextutils API changes before graduation) | 21:39 |
*** markmcclain has joined #openstack-oslo | 21:42 | |
*** bknudson has quit IRC | 21:42 | |
*** mriedem has left #openstack-oslo | 21:48 | |
*** dims has quit IRC | 21:56 | |
*** dims has joined #openstack-oslo | 22:08 | |
*** yamahata has joined #openstack-oslo | 22:09 | |
*** shakamunyi has quit IRC | 22:20 | |
*** ihrachyshka has quit IRC | 22:27 | |
*** mriedem has joined #openstack-oslo | 22:37 | |
*** bknudson has joined #openstack-oslo | 22:44 | |
*** wingwj has quit IRC | 23:03 | |
*** wingwj has joined #openstack-oslo | 23:05 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a example that activates a future when a result is ready https://review.openstack.org/90247 | 23:06 |
*** markmcclain has quit IRC | 23:07 | |
*** richm has left #openstack-oslo | 23:07 | |
*** flaper87 is now known as flaper87|afk | 23:08 | |
*** wpf has joined #openstack-oslo | 23:18 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a jobboard fetching context manager https://review.openstack.org/90252 | 23:39 |
*** wingwj has quit IRC | 23:39 | |
harlowja | tommorow 1600UTC right? | 23:48 |
*** yamahata has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!