| openstackgerrit | Pranesh Pandurangan proposed a change to openstack/oslo-incubator: Enable configuring tcp keepalive https://review.openstack.org/90870 | 00:00 |
|---|---|---|
| *** yamahata has joined #openstack-oslo | 00:06 | |
| openstackgerrit | Pranesh Pandurangan proposed a change to openstack/oslo-incubator: Enable configuring tcp keepalive https://review.openstack.org/90870 | 00:30 |
| *** praneshp has quit IRC | 00:31 | |
| *** arnaud has quit IRC | 02:09 | |
| *** zhiyan_ is now known as zhiyan | 02:12 | |
| *** mriedem has left #openstack-oslo | 02:26 | |
| *** mriedem has quit IRC | 02:26 | |
| *** harlowja is now known as harlowja_away | 02:27 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack-dev/hacking: Updated from global requirements https://review.openstack.org/91220 | 02:37 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/cliff: Updated from global requirements https://review.openstack.org/88716 | 02:38 |
| *** praneshp has joined #openstack-oslo | 02:41 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/91232 | 02:45 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.config: Updated from global requirements https://review.openstack.org/89240 | 02:45 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/91233 | 02:45 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.test: Updated from global requirements https://review.openstack.org/91234 | 02:45 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.version: Updated from global requirements https://review.openstack.org/91235 | 02:45 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/91236 | 02:46 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslosphinx: Updated from global requirements https://review.openstack.org/91237 | 02:46 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/pycadf: Updated from global requirements https://review.openstack.org/88729 | 02:46 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/stevedore: Updated from global requirements https://review.openstack.org/88735 | 02:47 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/taskflow: Updated from global requirements https://review.openstack.org/89896 | 02:47 |
| *** shakamunyi has quit IRC | 04:05 | |
| *** praneshp has quit IRC | 04:17 | |
| *** praneshp_ has joined #openstack-oslo | 04:17 | |
| openstackgerrit | Pranesh Pandurangan proposed a change to openstack/oslo-incubator: Enable configuring tcp keepalive https://review.openstack.org/90870 | 04:25 |
| *** morganfainberg is now known as morganfainberg_Z | 05:10 | |
| *** zhiyan is now known as zhiyan_ | 05:20 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow job iterjobs to cycle endlessly (WIP) https://review.openstack.org/91171 | 05:44 |
| *** viktors|afk is now known as viktors | 06:19 | |
| *** gcb has joined #openstack-oslo | 06:38 | |
| *** mkoderer has joined #openstack-oslo | 06:44 | |
| *** flaper87|afk is now known as flaper87 | 06:49 | |
| *** flaper87 is now known as flaper87|afk | 06:51 | |
| *** flaper87|afk is now known as flaper87 | 07:03 | |
| gcb | flaper87: ping | 07:06 |
| flaper87 | gcb: pong | 07:06 |
| gcb | flaper87: about the bp https://blueprints.launchpad.net/oslo/+spec/cache-redis-backend, Do you still work on this ? | 07:07 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow job iterjobs to cycle endlessly (WIP) https://review.openstack.org/91171 | 07:07 |
| flaper87 | gcb: no, I still have to complete the work on the memcache one, I was planning to do so soon. | 07:07 |
| flaper87 | gcb: if you want to take it, please, feel free | 07:07 |
| flaper87 | I can assign it to you | 07:08 |
| gcb | flaper87: thanks, I will :) | 07:08 |
| flaper87 | gcb: what's your lp username? | 07:08 |
| gcb | flaper87: glongwave | 07:09 |
| flaper87 | gcb: done | 07:10 |
| gcb | flaper87: will add you as the reviewer :) | 07:10 |
| flaper87 | gcb: awesome, thanks a lot | 07:11 |
| flaper87 | :) | 07:11 |
| *** ekarlso has joined #openstack-oslo | 07:17 | |
| *** gcb has quit IRC | 07:36 | |
| *** nacim has joined #openstack-oslo | 07:37 | |
| *** praneshp_ has quit IRC | 07:38 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow job iterjobs to cycle endlessly (WIP) https://review.openstack.org/91171 | 08:06 |
| *** ihrachyshka has joined #openstack-oslo | 08:17 | |
| openstackgerrit | Cyril Roelandt proposed a change to openstack/taskflow: Add an example for the job board feature https://review.openstack.org/91190 | 10:08 |
| *** markmc has joined #openstack-oslo | 10:34 | |
| *** openstackgerrit has quit IRC | 10:51 | |
| *** yamahata has quit IRC | 10:56 | |
| jd__ | is there a way to replace the Pecan JSONifier by oslo one? (dhellmann?) | 11:30 |
| jd__ | though that wouldn't actually solve totally my issue I guess :( | 11:33 |
| *** gcb has joined #openstack-oslo | 11:34 | |
| ihrachyshka | bnemec: hi. around? I want to discuss json lib stuff | 11:38 |
| *** gcb has quit IRC | 11:40 | |
| *** gcb has joined #openstack-oslo | 11:53 | |
| ihrachyshka | gcb: around? | 11:55 |
| gcb | ihrachyshka: hi | 11:56 |
| ihrachyshka | gcb: re that jsonutils patch. are you familiar with json? | 11:56 |
| ihrachyshka | gcb: for some projects where I've tried to import the fix, I get failures like: http://logs.openstack.org/44/91044/1/check/gate-nova-python26/88205da/testr_results.html.gz | 11:56 |
| ihrachyshka | gcb: this is probably due to optimisation in simplejson covered here: https://code.djangoproject.com/ticket/11742 | 11:57 |
| gcb | no , just find in my test environment python 2.7 ,there is simplejsion and json | 11:58 |
| gcb | hi, I would check the link ,hope can find something | 11:58 |
| ihrachyshka | gcb: I've tried to add .decode('utf-8') and .encode('utf-8') to loads() and dumps(), and it passes now. Now the question is: is it worth adding another patch to make unicode explicit, or is it better to just stick to simplejson unconditionally? (at the moment, test fails for py26 and works for py27 because they use different implementations) | 11:58 |
| ihrachyshka | this was enough to fix the test: http://paste.openstack.org/show/77956/ | 11:59 |
| ihrachyshka | but I'm not sure we should walk that route | 11:59 |
| ihrachyshka | so any comments are appreciated | 11:59 |
| gcb | will if I have :) | 11:59 |
| ihrachyshka | gcb: tnx for your time even if not :) | 12:00 |
| viktors | ihrachyshka: please see https://code.google.com/p/simplejson/issues/detail?id=40 | 12:08 |
| ihrachyshka | viktors: yeah, I saw that. so basically, we should always do unicode() or .decode('utf-8') if we want unicode | 12:12 |
| ihrachyshka | right? | 12:12 |
| viktors | ihrachyshka: in my opinion - yes, but I'm not familiar with it :) | 12:13 |
| ihrachyshka | or better, six.text_type() | 12:13 |
| viktors | this will add py3 compatibility | 12:14 |
| *** erecio has joined #openstack-oslo | 12:20 | |
| ihrachyshka | viktors: gcb: bnemec: sent https://review.openstack.org/#/c/91344/ to fix unicode json issue revealed. Please take a look when you have spare time. | 12:24 |
| viktors | ihrachyshka: -1 - no tests :) | 12:25 |
| ihrachyshka | viktors: :) roger that | 12:26 |
| *** erecio_1 has joined #openstack-oslo | 12:36 | |
| *** erecio has quit IRC | 12:38 | |
| viktors | dhellmann: around? | 12:44 |
| *** gcb has quit IRC | 12:47 | |
| *** jecarey has quit IRC | 12:56 | |
| *** gcb has joined #openstack-oslo | 12:58 | |
| *** gcb has quit IRC | 13:09 | |
| *** mriedem has joined #openstack-oslo | 13:19 | |
| *** bknudson has joined #openstack-oslo | 13:22 | |
| dhellmann | hi, viktors | 13:38 |
| *** erecio_1 has quit IRC | 13:39 | |
| viktors | dhellmann: hello! Can you please look at the drafted blueprint "Add tpool proxy wrapper for DB-API calls" - https://blueprints.launchpad.net/oslo/+spec/add-tpool-proxy-wrapper | 13:40 |
| dhellmann | viktors: definitely! | 13:41 |
| viktors | dhellmann: thanks! | 13:41 |
| dhellmann | viktors: that description looks good; can I go ahead and schedule it for J1? | 13:42 |
| viktors | dhellmann: yes, sure | 13:45 |
| *** jecarey has joined #openstack-oslo | 13:46 | |
| dhellmann | viktors: ok, good -- we need it to have someone assigned, but we don't need a name right away -- by the week after the summit, I think | 13:46 |
| viktors | dhellmann: ok | 13:49 |
| *** openstackgerrit has joined #openstack-oslo | 13:56 | |
| *** erecio_1 has joined #openstack-oslo | 13:57 | |
| ihrachyshka | viktors: added test for https://review.openstack.org/#/c/91344/2 | 13:57 |
| viktors | ihrachyshka: ok, will look | 14:05 |
| ihrachyshka | jd__: I thought we generally separate patches that are loosely related | 14:05 |
| jd__ | ihrachyshka: yeah but I don't think loosely applies here | 14:05 |
| ihrachyshka | jd__: f.e. we generally separate 'hacking rule turned on' patch from 'fix code to pass hacking rule' | 14:06 |
| ihrachyshka | jd__: I don't know, maybe it's worth asking other guys | 14:06 |
| *** yamahata has joined #openstack-oslo | 14:06 | |
| jd__ | I don't think I saw that before, but it doesn't make more sense | 14:07 |
| jd__ | sure, that's just a -1, anybody can override | 14:07 |
| ihrachyshka | dhellmann: bnemec: what do you think about the jd__'s comments at https://review.openstack.org/#/c/91368/ regarding possible patch merge? | 14:07 |
| * jd__ doesn't buy the "we always do that way" arguments :) | 14:08 | |
| ihrachyshka | jd__: I feel your pain and concern :) | 14:08 |
| dhellmann | ihrachyshka: I see jd__'s point on merging them, esp. if the only reason for adding the new requirement is to be able to add tests using it | 14:10 |
| dhellmann | ihrachyshka: should that be a test requirement, or is it really a runtime requirement? | 14:10 |
| ihrachyshka | dhellmann: hm, probably for unit tests only, but we don't have this dependency in global test requirements, only runtime: https://github.com/openstack/requirements/blob/master/test-requirements.txt | 14:11 |
| ihrachyshka | dhellmann: should we add that in global-requirements then? | 14:11 |
| ihrachyshka | runtime dependency concept is moot in terms of incubator since probably no one uses it as a library. | 14:12 |
| dhellmann | ihrachyshka: simplejson is in https://github.com/openstack/requirements/blob/master/global-requirements.txt | 14:12 |
| ihrachyshka | dhellmann: yes, but this is for runtime, not tests | 14:12 |
| dhellmann | ihrachyshka: yes, but we still use the 2 files to provide clear guidance for consumers of the incubator about where they should list their requirements | 14:13 |
| dhellmann | it sounds like simplejson is a runtime requirement, so placing it in requirements.txt is correct | 14:13 |
| ihrachyshka | dhellmann: yeah, ok, got it. well, it's partly runtime, but that's not requirements, it's recommendation :) | 14:13 |
| dhellmann | ihrachyshka: true | 14:14 |
| ihrachyshka | dhellmann: so should we push that to global requirements in test-requirements.txt file? | 14:16 |
| ihrachyshka | I'm not sure how this works | 14:16 |
| dhellmann | ihrachyshka: the global requirements list covers both cases, so you don't need to change anything there | 14:16 |
| dhellmann | and you can leave it in the runtime requirements for the incubator, too | 14:17 |
| dhellmann | I do think it probably makes sense to merge those commits, but they're in a series already so it's not a big deal | 14:17 |
| dhellmann | \o/ [Wed 10:16:04 AM] <openstackgerrit> A change was merged to openstack-infra/config: Import oslo.db repository https://review.openstack.org/78955 | 14:18 |
| dhellmann | way to go viktors & rpodolyaka! | 14:18 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: Enforce unicode json output for jsonutils.loads() https://review.openstack.org/91344 | 14:18 |
| ihrachyshka | dhellmann: jd__: good, merged the patches in one :) ^^ | 14:18 |
| rpodolyaka | \o/ | 14:18 |
| viktors | dhellmann: cool! \o/ | 14:18 |
| viktors | dhellmann: what is the next step? | 14:19 |
| dhellmann | https://www.youtube.com/watch?v=n_w4oSCJIQk | 14:19 |
| rpodolyaka | :D | 14:19 |
| viktors | :-D | 14:20 |
| dhellmann | viktors: we need to wait a bit for the import to actually happen, then verify that the repo looks right (check it out) | 14:20 |
| dhellmann | and then continue with the checklist you've been working from :-) | 14:20 |
| viktors | dhellmann: ok | 14:24 |
| dhellmann | viktors: we still haven't figured out exactly what we're going to do with cross-project testing, so it's probably better not to start having any apps adopt the new lib until we discuss that at the summit | 14:31 |
| dhellmann | viktors: but you're supposed to be on holiday anyway, right? :-) | 14:31 |
| ihrachyshka | rpodolyaka: hi. sorry for my ignorance, but can you check whether I get your comment right? so six.text_type() aka unicode() fails for non-ASCII strings? so instead we may do json.loads(s.decode('utf-8'))? | 14:32 |
| rpodolyaka | ihrachyshka: hey! yes, right. either that, or six.text_type(s, 'utf-8') | 14:34 |
| ihrachyshka | rpodolyaka: but six version is not more portable than .decode(), right? | 14:35 |
| * rpodolyaka is thinking | 14:35 | |
| rpodolyaka | so the only caveat I can think of is that when you are using Python 3 and passing an str() value, not bytes | 14:36 |
| rpodolyaka | in that case, decode() would fail | 14:36 |
| rpodolyaka | as in python 3 str instances don't have decode() method | 14:36 |
| viktors | dhellmann: yes, I'll be on vacation since tomorrow :) | 14:36 |
| ihrachyshka | rpodolyaka: six won't? | 14:36 |
| viktors | dhellmann: what is the best practice for cross-project testing in oslo libraries? | 14:36 |
| dhellmann | viktors: that's the question I hope to have answered at the summit :-) | 14:37 |
| * rpodolyaka looks how six.text_type is implemented | 14:37 | |
| viktors | dhellmann: got it :) | 14:37 |
| *** erecio_1 has quit IRC | 14:37 | |
| viktors | dhellmann: and what about oslo.messaging? | 14:37 |
| ihrachyshka | rpodolyaka: it's just str or unicode | 14:37 |
| ihrachyshka | nothing more | 14:38 |
| rpodolyaka | ihrachyshka: yeah, this should be better | 14:38 |
| rpodolyaka | as we will be doing unicode(s, 'utf-8') or str(s, 'utf-8') depending on the python release | 14:38 |
| rpodolyaka | and if s is unicode/str this should be a no-op | 14:38 |
| * rpodolyaka tests that | 14:38 | |
| dhellmann | viktors: the existing libs is what brought the question up in the first place. for now I'm trying to avoid making things worse. :-/ | 14:39 |
| rpodolyaka | heh, no | 14:39 |
| ihrachyshka | If encoding and/or errors are given, str() will decode the object which can either be a byte string or a character buffer using the codec for encoding | 14:39 |
| ihrachyshka | (from https://docs.python.org/3.1/library/functions.html#str) | 14:39 |
| ihrachyshka | basically, it should fail | 14:39 |
| ihrachyshka | but I haven't checked | 14:39 |
| * bnemec is done with the morning meeting and reads the scrollback | 14:40 | |
| rpodolyaka | ihrachyshka: so when I pass a unicode/str value to unicode/str on python2/python3 appropriately I receive TypeError: decoding Unicode is not supported | 14:42 |
| rpodolyaka | ihrachyshka: with encoding argument pased | 14:42 |
| rpodolyaka | ihrachyshka: if it's not passed, it's a no-op | 14:42 |
| viktors | dhellmann: ok | 14:43 |
| rpodolyaka | ihrachyshka: I'd go for something like: if type(s) is not six.text_type: s = six.text_type(s, 'utf-8') then | 14:43 |
| dhellmann | rpodolyaka: why not isinstance()? | 14:45 |
| ihrachyshka | dhellmann: + | 14:45 |
| dhellmann | viktors: I've checked out a copy of oslo.db and the tests are passing locally :-) | 14:46 |
| rpodolyaka | dhellmann: ihrachyshka: yeah, that's probably better :) | 14:46 |
| bnemec | Why are we specifying an encoding in this case? | 14:46 |
| * bnemec may still be behind | 14:46 | |
| dhellmann | bnemec: good question | 14:46 |
| viktors | dhellmann: let me do the same thing :) | 14:46 |
| bnemec | 99% of our six.text_type calls are just six.text_type(foo) | 14:46 |
| rpodolyaka | bnemec: python 2 defaults to ascii when decoding bytes in unicode() | 14:46 |
| rpodolyaka | bnemec: and json from the standard library defaults | 14:47 |
| rpodolyaka | to utf-8 | 14:47 |
| bnemec | Bleh | 14:47 |
| bnemec | I think we dealt with something like that in gettextutils. Let me see if there's something we could reuse. | 14:47 |
| dhellmann | we have that stringutils module, too | 14:48 |
| bnemec | dhellmann: Oh, that was it. Too many utf8/ascii issues to keep straight. :-) | 14:50 |
| rpodolyaka | so the thing I'm worried about is that https://review.openstack.org/#/c/91344/2/openstack/common/jsonutils.py will make it impossible to have utf-8 encoded json input on python 2.x | 14:50 |
| rpodolyaka | unless, the input uses escaped unicode literals | 14:50 |
| bnemec | rpodolyaka: ihrachyshka: Take a look at https://github.com/openstack/oslo-incubator/blob/master/openstack/common/strutils.py#L100 | 14:50 |
| ihrachyshka | bnemec: great :) | 14:51 |
| rpodolyaka | bnemec: oh, nice, didn't know we had one | 14:52 |
| bnemec | bknudson: Not sure if you got an answer, but oslo.config seems like a reasonable place for the config fixture. | 14:52 |
| bnemec | dhellmann: ^ | 14:52 |
| ihrachyshka | so we end up with 'return json.loads(strutils.safe_decode(s))', right? | 14:53 |
| bknudson | bnemec: ok, that's what I thought was going to happen, wasn't sure if it's done yet. | 14:53 |
| rpodolyaka | ihrachyshka: looks correct | 14:53 |
| dhellmann | bnemec, bknudson : yep: https://blueprints.launchpad.net/oslo/+spec/graduate-config-fixture | 14:53 |
| rpodolyaka | ihrachyshka: but a test case would be great :) | 14:53 |
| bnemec | dhellmann: Ah, nice :-) | 14:53 |
| bknudson | when that's done we should be able to change keystone to not use oslo-incubator fixtures, will use oslotest and oslo.config instead | 14:54 |
| dhellmann | bknudson: excellent | 14:55 |
| bnemec | The "Pick Me" link in launchpad really needs a ! | 14:56 |
| bnemec | dhellmann: So is that just a question of copying the file to oslo.config as oslo/config/fixture.py or something along those lines? | 14:59 |
| dhellmann | bnemec: yeah, I haven't looked at it very closely to see if there are any cleanups needed (importing from oslotest instead of another incubator fixture, etc.) | 14:59 |
| dhellmann | bnemec: but that's the general idea | 15:00 |
| bnemec | dhellmann: Okay, I'll take a closer look. Thanks. | 15:00 |
| dhellmann | bnemec: cool, thanks | 15:00 |
| *** dshulyak has quit IRC | 15:05 | |
| *** mkoderer has quit IRC | 15:12 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Save .git directory but not other git files https://review.openstack.org/91391 | 15:14 |
| dhellmann | viktors: ^^ | 15:15 |
| bnemec | dhellmann: $$ is an escaping thing? | 15:17 |
| dhellmann | bnemec: yeah, it escapes the $ in a double-quoted string | 15:17 |
| dhellmann | bnemec: if it's more clear, I could change that to something like './(^.git$|'$(the stuff with echo) | 15:18 |
| dhellmann | I think bash will do the right thing with that form, but I'm not sure it's easier for a human to parse | 15:19 |
| bnemec | Eh, it's a regex. There are just so many subtle variations on the syntax that I'm never sure what's going on. | 15:19 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: Enforce unicode json output for jsonutils.loads() https://review.openstack.org/91344 | 15:22 |
| *** erecio_1 has joined #openstack-oslo | 15:22 | |
| dhellmann | bnemec: yeah | 15:22 |
| ihrachyshka | bnemec: dhellmann: rpodolyaka: jd__: ^^ hopefully everything is handled | 15:22 |
| bnemec | dhellmann: It seems to be giving me the current pid when I put $$ in a double-quoted string though. :-/ | 15:23 |
| dhellmann | bnemec: ugh | 15:23 |
| dhellmann | I wonder how it worked here | 15:23 |
| * dhellmann runs more tests | 15:23 | |
| bnemec | Maybe it's because I'm running it out of context or something, but I get: ./\(^.git31376\|\) | 15:24 |
| dhellmann | bnemec, me, too | 15:25 |
| bnemec | Bash and regexes are going to be the reason I end up in a padded room at the end of my career. :-) | 15:26 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: jsonutils.load() accepts file pointer, not string https://review.openstack.org/91396 | 15:28 |
| dhellmann | bnemec: I know $$ escapes $ in some syntax, but it's definitely not bash. | 15:31 |
| * dhellmann needs more caffeine | 15:31 | |
| bnemec | dhellmann: It would in an oslo.config config file. :-) | 15:32 |
| bnemec | (I think) | 15:32 |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo.config: Graduate config fixture https://review.openstack.org/91397 | 15:32 |
| dhellmann | bnemec: you know, that's probably what I was thinking of. we had a bug report about that in the last few days, which led to a doc update that I reviewed | 15:32 |
| * dhellmann is still waiting for the esperanto of computer languages | 15:32 | |
| bnemec | haha | 15:33 |
| bnemec | This is why I usually insist on fantastic test coverage for anything involving regexes. | 15:34 |
| bnemec | Of course, lately every time I run across a regex it's in something that can't be easily unit tested. :-/ | 15:34 |
| bnemec | Oh, the imports are backwards in the graduation change. | 15:35 |
| * bnemec really needs to finish up that hacking rule... | 15:35 | |
| dhellmann | backwards? | 15:36 |
| openstackgerrit | Ben Nemec proposed a change to openstack/oslo.config: Graduate config fixture https://review.openstack.org/91397 | 15:37 |
| dhellmann | ah | 15:38 |
| bnemec | dhellmann: Incidentally, I used graduate.sh to split something out of diskimage-builder and it seemed to work quite nicely. | 15:41 |
| bnemec | I cut out the oslo renaming stuff at the end of course. | 15:41 |
| dhellmann | nice | 15:41 |
| bnemec | And the filter-branch took *forever*, but it did finish eventually. | 15:42 |
| dhellmann | yeah, that step takes ages because it replays every commit and changes them | 15:42 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Save .git directory but not other git files https://review.openstack.org/91391 | 15:45 |
| dhellmann | bnemec: I tested ^^ and examined the prune script it generated | 15:46 |
| *** erecio_1 has quit IRC | 15:46 | |
| dhellmann | bnemec: well, that's not quite doing the right thing either | 15:47 |
| dhellmann | the prune script looks right, but it doesn't ignore .git | 15:47 |
| bnemec | Heh, fun. :-) | 15:48 |
| *** ihrachyshka has quit IRC | 15:54 | |
| dhellmann | it helps to read the whole regex | 15:56 |
| *** erecio_1 has joined #openstack-oslo | 15:59 | |
| *** rpodolyaka has left #openstack-oslo | 16:03 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Save .git directory but not other git files https://review.openstack.org/91391 | 16:04 |
| *** nacim has quit IRC | 16:05 | |
| *** viktors has quit IRC | 16:12 | |
| openstackgerrit | Marc Abramowitz proposed a change to openstack-dev/pbr: pbr/testr_command.py: Add logging https://review.openstack.org/89203 | 16:16 |
| *** erecio_1 has quit IRC | 16:31 | |
| *** markmc has quit IRC | 16:33 | |
| dhellmann | bnemec: yes, we think we have the namespace package issues worked out, so we can keep using "oslo." | 16:38 |
| bnemec | dhellmann: \o/ | 16:40 |
| dhellmann | bnemec: unless you meant "should olso.i18n" be a generic lib? | 16:40 |
| bnemec | dhellmann: Nope, just the namespace thing. | 16:40 |
| dhellmann | ok | 16:40 |
| * dhellmann is wondering if we should just call it gettextutils now | 16:40 | |
| bnemec | Weird, that patch is showing up in my dashboard as if I already reviewed it, but I didn't leave a score. | 16:41 |
| bnemec | Is new Gerrit smart enough to see that I left a no-score since the last patch set? Because that would be awesome. :-) | 16:42 |
| *** harlowja_away is now known as harlowja | 16:54 | |
| *** erecio_1 has joined #openstack-oslo | 16:55 | |
| *** praneshp has joined #openstack-oslo | 16:59 | |
| *** praneshp_ has joined #openstack-oslo | 17:02 | |
| *** praneshp has quit IRC | 17:04 | |
| *** praneshp_ is now known as praneshp | 17:04 | |
| *** erecio_1 has quit IRC | 17:45 | |
| *** tjones has joined #openstack-oslo | 17:51 | |
| tjones | dims: im here ;-) | 17:51 |
| dims | hey, welcome! | 17:57 |
| dims | dhellmann, arnaud and others we were talking on the vmwareapi nova sub team meet. we possibly need another rev of oslo.vmware. arnaud will ping later | 17:58 |
| *** morganfainberg_Z is now known as morganfainberg | 18:14 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-incubator: Commit changes to local repository after exporting https://review.openstack.org/91125 | 18:26 |
| *** erecio has joined #openstack-oslo | 18:27 | |
| *** rustlebee has left #openstack-oslo | 18:29 | |
| dhellmann | dims: ok | 18:37 |
| *** arnaud__ has joined #openstack-oslo | 18:40 | |
| praneshp | dims: ping | 19:13 |
| dims | pong | 19:15 |
| praneshp | dims: about your comment on https://review.openstack.org/#/c/90870/, I’ll be able to work on it only later, so a changeset will be available after sometime only | 19:15 |
| praneshp | is the policy to comment done after the changeset is ready? | 19:16 |
| praneshp | I just meant to ack your comments and say done. | 19:16 |
| dims | ah. i usually say "Done" after i push a changeset and say "Will do" if it will take some time to push out a change set. not a hard and fast rule, i just thought something may have gone wrong when you pushed out a review and you may not have noticed it and were waiting for me to respond to | 19:18 |
| praneshp | dims: cool cool. thanks | 19:18 |
| dims | praneshp, one thing to remember is the hyperv folks run this stuff on windows platforms too. so we will need to accomodate them | 19:20 |
| dims | i got bit for some changes when i was doing ipv6 work | 19:20 |
| praneshp | dims: is the socket library different on windows? I’ll have a look | 19:21 |
| dims | this does not make me feel good - http://stackoverflow.com/questions/796957/is-windowss-setsockopt-broken | 19:22 |
| *** ihrachyshka has joined #openstack-oslo | 19:35 | |
| *** ihrachyshka has quit IRC | 19:38 | |
| *** ihrachyshka has joined #openstack-oslo | 19:38 | |
| *** markmcclain has joined #openstack-oslo | 20:03 | |
| praneshp | dims: I looked at that stackoverflow question about SO_REUSEADDRD on unix v windows | 20:03 |
| praneshp | I wonder how the hyperv tests pass for nova, which does this | 20:04 |
| praneshp | dims: https://github.com/openstack/nova/blob/master/nova/wsgi.py#L181 | 20:04 |
| dims | praneshp, something to keep an eye out for. hopefully the hyper-v CI will catch stuff or others will chime in | 20:04 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: Enforce unicode json output for jsonutils.loads() https://review.openstack.org/91344 | 20:11 |
| *** jecarey has quit IRC | 20:24 | |
| -openstackstatus- NOTICE: the gate is backed up due to broken nodepool images, fix in progress (eta 22:00 utc) | 20:25 | |
| *** ChanServ changes topic to "the gate is backed up due to broken nodepool images, fix in progress (eta 22:00 utc)" | 20:25 | |
| *** jecarey has joined #openstack-oslo | 20:34 | |
| *** erecio has quit IRC | 20:58 | |
| *** arnaud__ has quit IRC | 20:59 | |
| harlowja | dhellmann yt, got a python question for u | 21:00 |
| dhellmann | harlowja: hi | 21:08 |
| harlowja | dhellmann hey, so maybe simple answer, but say u have an infinite iterator, that say can be spurous in that it may not always have values at the given moment (but could in a few minutes), should the iterator next() throw stop iteration, or should it block, i have a case for this kind of spurous iterator, but thinking whats the most pythonic way | 21:11 |
| dhellmann | if you throw StopIteration whatever is iterating is going to assume it has consumed all of the data | 21:11 |
| *** markmcclain has quit IRC | 21:12 | |
| dhellmann | harlowja: ^^ so that's probably not what you want, it sounds like maybe an iterator isn't the best API for this if the caller shouldn't block | 21:16 |
| dhellmann | harlowja: you could yield some sort of sentinel value that the caller could check | 21:16 |
| harlowja | dhellmann ya, i'm thinking the api isn't really iterator then | 21:22 |
| harlowja | agreed | 21:23 |
| openstackgerrit | Solly Ross proposed a change to openstack/oslo-incubator: Report: Fix JinjaView deepcopy https://review.openstack.org/78730 | 21:23 |
| *** yamahata has quit IRC | 21:37 | |
| *** yamahata has joined #openstack-oslo | 21:40 | |
| *** mriedem has left #openstack-oslo | 21:41 | |
| *** mriedem has quit IRC | 21:41 | |
| *** ihrachyshka has quit IRC | 22:21 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Move from generator to iterator for iterjobs https://review.openstack.org/91171 | 22:24 |
| *** bknudson has quit IRC | 22:29 | |
| *** arnaud__ has joined #openstack-oslo | 22:48 | |
| *** bknudson has joined #openstack-oslo | 22:49 | |
| *** bknudson has quit IRC | 22:54 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Wrap the failure to load in the not found exception https://review.openstack.org/90499 | 22:55 |
| *** flaper87 is now known as flaper87|afk | 23:00 | |
| *** arnaud__ has quit IRC | 23:03 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a jobboard fetching context manager https://review.openstack.org/90252 | 23:04 |
| *** bknudson has joined #openstack-oslo | 23:09 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!