*** markmcclain has quit IRC | 00:08 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Track node hierarchy (WIP) https://review.openstack.org/92945 | 01:29 |
---|---|---|
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a example which uses the run_iter function in a for loop https://review.openstack.org/95053 | 01:54 |
*** praneshp has quit IRC | 02:42 | |
*** harlowja_ is now known as harlowja_away | 02:55 | |
*** mriedem has left #openstack-oslo | 02:57 | |
*** mriedem has quit IRC | 02:57 | |
openstackgerrit | Zhongyue Luo proposed a change to openstack/oslo-incubator: Deletes timeutils.set_time_override https://review.openstack.org/72061 | 03:27 |
*** morganfainberg is now known as morganfainberg_Z | 04:42 | |
*** xjxj has joined #openstack-oslo | 05:20 | |
*** xjxj has quit IRC | 05:23 | |
*** jeffreycoho has joined #openstack-oslo | 05:24 | |
*** jeffreycoho has quit IRC | 05:39 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add kwarg check_pending argument to fake lock https://review.openstack.org/95081 | 06:05 |
*** praneshp has joined #openstack-oslo | 06:18 | |
*** praneshp_ has joined #openstack-oslo | 06:37 | |
*** praneshp has quit IRC | 06:40 | |
*** praneshp_ is now known as praneshp | 06:40 | |
*** mkoderer has joined #openstack-oslo | 06:41 | |
*** 21WAALF0O has joined #openstack-oslo | 07:36 | |
*** 21WAALF0O is now known as I159 | 07:37 | |
*** I159 has quit IRC | 07:37 | |
*** I159 has joined #openstack-oslo | 07:37 | |
*** ihrachyshka has joined #openstack-oslo | 07:37 | |
*** ihrachyshka has quit IRC | 07:42 | |
*** ihrachyshka has joined #openstack-oslo | 07:42 | |
*** praneshp has quit IRC | 07:58 | |
*** nacim has joined #openstack-oslo | 08:00 | |
ihrachyshka | dhellmann: around? | 08:09 |
*** yamahata has joined #openstack-oslo | 08:13 | |
*** flaper87|afk is now known as flaper87 | 09:28 | |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Opportunistic migration tests https://review.openstack.org/93424 | 09:31 |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Fix the test using in-file SQLite database https://review.openstack.org/93423 | 09:31 |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Fix migrations changing the type of deleted column https://review.openstack.org/93414 | 09:34 |
*** flaper87 is now known as flaper87|afk | 09:39 | |
*** flaper87|afk is now known as flaper87 | 09:54 | |
*** openstackstatus has quit IRC | 10:20 | |
*** openstack has joined #openstack-oslo | 10:21 | |
*** openstackstatus has joined #openstack-oslo | 10:22 | |
*** ChanServ sets mode: +v openstackstatus | 10:22 | |
openstackgerrit | Christian Berendt proposed a change to openstack/oslo.messaging: add missing log hints for level C/E/I/W https://review.openstack.org/94805 | 10:28 |
openstackgerrit | Christian Berendt proposed a change to openstack/oslo.vmware: remove definitions of Python Source Code Encoding https://review.openstack.org/95133 | 10:32 |
*** flaper87 is now known as flaper87|afk | 10:43 | |
*** ihrachyshka has quit IRC | 10:54 | |
*** ihrachyshka has joined #openstack-oslo | 10:58 | |
openstackgerrit | Christian Berendt proposed a change to openstack/oslo-incubator: use /usr/bin/env python instead of /usr/bin/python https://review.openstack.org/95139 | 11:08 |
*** ihrachyshka has quit IRC | 11:36 | |
*** ihrachyshka has joined #openstack-oslo | 11:48 | |
*** dims has joined #openstack-oslo | 12:28 | |
*** dims has quit IRC | 12:28 | |
*** dims has joined #openstack-oslo | 12:33 | |
*** jecarey has quit IRC | 12:50 | |
*** erecio has joined #openstack-oslo | 12:51 | |
*** bknudson has joined #openstack-oslo | 12:55 | |
*** yamahata has quit IRC | 12:59 | |
*** jecarey has joined #openstack-oslo | 13:13 | |
*** rpodolyaka1 is now known as rpodolyaka | 14:11 | |
*** markmcclain has joined #openstack-oslo | 14:16 | |
*** markmcclain1 has joined #openstack-oslo | 14:17 | |
openstackgerrit | Andrey Kurilin proposed a change to openstack/oslo-incubator: Add eventlet.tpool.Proxy for DB API calls https://review.openstack.org/95170 | 14:19 |
*** markmcclain has quit IRC | 14:20 | |
ihrachyshka | at https://wiki.openstack.org/wiki/Oslo/Messaging and in docstrings in oslo.messaging, executor specific RPCServer classes are mentioned (BlockingRPCServer, EventletRPCServer) though they are not implemented | 14:40 |
ihrachyshka | should we trim docstrings or actually implement these server types? | 14:41 |
dhellmann | ihrachyshka: the wiki page was a design document, so it probably doesn't need to change, but if the docstrings refer to classes that don't exist then I agree we should update them with the correct instructions | 14:49 |
ihrachyshka | dhellmann: so specific classes are not needed? | 14:49 |
dhellmann | ihrachyshka: markmc or flaper87|afk may have a better answer, but it looks like the name of the executor is passed to get_rpc_server() instead | 14:50 |
ihrachyshka | dhellmann: yes, these are just for convenience, if any | 14:50 |
ihrachyshka | so that you don't need to pass executor | 14:50 |
ihrachyshka | and probably adding a bit more checks (executor argument is just a string that in theory can be invalid) | 14:50 |
jd__ | dhellmann: stevedore release? :D | 14:51 |
dhellmann | ihrachyshka: right, if the name isn't valid an exception is thrown when the driver can't be loaded | 14:51 |
dhellmann | jd__: I need to see what the status of alpha releases is with the infra team | 14:51 |
jd__ | just sayin' | 14:52 |
*** yamahata has joined #openstack-oslo | 14:52 | |
dhellmann | jd__: I also need to fix the way that exception handling in the driver manager works, since the current form distorts the traceback | 14:52 |
jd__ | it's still better than the current one :( | 14:53 |
dhellmann | jd__: see the traceback in https://bugs.launchpad.net/python-stevedore/+bug/1316328 | 14:53 |
dhellmann | jd__: yeah | 14:53 |
ihrachyshka | dhellmann: ok, good, I'll update the docstrings. I was just a bit miss leaded yesterday by the reference to those classes. I guess the text in docstrings came from that design document. | 14:54 |
*** ihrachyshka has quit IRC | 14:54 | |
dhellmann | ihrachyshka: the classes may have existed at one point. I seem to remember discussing removing them before the library was officially released. | 14:55 |
*** gcb_ has joined #openstack-oslo | 15:06 | |
*** gcb_ has quit IRC | 15:23 | |
*** gcb_ has joined #openstack-oslo | 15:24 | |
*** gcb_ has quit IRC | 15:38 | |
*** gcb_ has joined #openstack-oslo | 15:47 | |
*** I159 has quit IRC | 15:47 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/92947 | 15:51 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/taskflow: Updated from global requirements https://review.openstack.org/93254 | 15:52 |
*** gcb_ has quit IRC | 16:04 | |
*** gcb_ has joined #openstack-oslo | 16:05 | |
*** morganfainberg_Z is now known as morganfainberg | 16:12 | |
*** gcb_ has quit IRC | 16:14 | |
*** nacim has quit IRC | 16:15 | |
*** gcb_ has joined #openstack-oslo | 16:15 | |
*** bnemec is now known as beekneemech | 16:49 | |
*** gcb_ has quit IRC | 16:49 | |
mkoderer | dhellmann: I think I will add some unit tests for base.py in oslotest - seems to be missing | 16:51 |
beekneemech | Heh, this is the second time today that the question of who tests the test code has come up. :-) | 16:53 |
beekneemech | mkoderer: That is definitely something we should have now that it's a library though. | 16:53 |
beekneemech | This used to get exercised by the other incubator tests, but that won't be the case now. | 16:54 |
*** harlowja_away is now known as harlowja_ | 16:55 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Update wording in instructions in the templates https://review.openstack.org/95218 | 16:56 |
dhellmann | mkoderer: great! | 16:57 |
mkoderer | beekneemech: +1 | 16:57 |
*** AAzza has joined #openstack-oslo | 17:03 | |
*** praneshp has joined #openstack-oslo | 17:06 | |
*** markmcclain1 has quit IRC | 17:08 | |
beekneemech | dhellmann: One thing on https://review.openstack.org/#/c/94906/ | 17:15 |
beekneemech | I know we mention the naming scheme in the wiki on graduation so maybe it's not necessary here, but I wanted to point out that there are more considerations involved. | 17:15 |
openstackgerrit | Brant Knudson proposed a change to openstack/oslo.db: Add connection trace for DB2 https://review.openstack.org/92182 | 17:15 |
dhellmann | beekneemech: maybe that section should just link to the wiki where we have all of the rules spelled out? | 17:15 |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Revert "Let git do mailmap mapping for us" https://review.openstack.org/88627 | 17:16 |
beekneemech | dhellmann: That might be good. Maintaining it in two places is just going to get out of sync eventually. | 17:16 |
dhellmann | beekneemech: which wiki page do you mean? I see https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Choosing_a_Name but that doesn't have much more detail | 17:17 |
beekneemech | dhellmann: Well, it does specify production runtime deps as users of the oslo prefix, but it could probably be clearer. | 17:19 |
dhellmann | beekneemech: I'll update the template to point there and we can fix the wording in the wiki | 17:19 |
dhellmann | I thought maybe I had left more clear directions somewhere else :-) | 17:20 |
beekneemech | Do we want to bless the oslo$SOMETHING name scheme for non-runtime stuff, or require actual names? | 17:20 |
dhellmann | like oslotest and oslosphinx? | 17:20 |
dhellmann | good point, we should describe that case | 17:20 |
beekneemech | dhellmann: We discussed this so much that I'm losing track of what's actually documented and what was just an IRC chat. :-) | 17:20 |
beekneemech | dhellmann: Yeah | 17:20 |
dhellmann | bah, I can't update a closed commit | 17:22 |
dhellmann | beekneemech: can you take a stab at adding that case to the wiki while I figure out how to unbork my git repo and update that template :-) | 17:22 |
beekneemech | dhellmann: Ah, sorry. I was thinking we would address that in the followup. | 17:24 |
beekneemech | dhellmann: Yeah, I'll update the wiki. | 17:24 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Update wording in instructions in the templates https://review.openstack.org/95218 | 17:24 |
dhellmann | beekneemech: no problem, I should have just done it that way | 17:25 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Update wording in instructions in the templates https://review.openstack.org/95218 | 17:26 |
dhellmann | ok, I think that version is good ^^ | 17:27 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add source of web sequence diagram https://review.openstack.org/95222 | 17:30 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add source of engine-state sequence diagram https://review.openstack.org/95222 | 17:31 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add source of engine-state sequence diagram https://review.openstack.org/95222 | 17:31 |
*** lbragstad has quit IRC | 17:32 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Regenerate engine-state sequence diagram https://review.openstack.org/95223 | 17:33 |
beekneemech | dhellmann: https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Choosing_a_Name updated | 17:35 |
*** ihrachyshka has joined #openstack-oslo | 17:38 | |
*** bknudson has quit IRC | 17:39 | |
openstackgerrit | Monty Taylor proposed a change to openstack-dev/pbr: Remove --use-mailmap as it's not needed https://review.openstack.org/95225 | 17:40 |
openstackgerrit | Nataliia Uvarova proposed a change to openstack/oslo-incubator: Fix logging setup for Python 3.4 https://review.openstack.org/94028 | 17:45 |
dhellmann | beekneemech: nice, thank you | 17:51 |
openstackgerrit | Masaru Nomura proposed a change to openstack/oslo.vmware: Add two files to oslo/vmware and tests/ https://review.openstack.org/95231 | 17:57 |
openstackgerrit | Masaru Nomura proposed a change to openstack/oslo.vmware: Add API for introspecting VMDKs https://review.openstack.org/95231 | 18:04 |
openstackgerrit | Joshua Harlow proposed a change to openstack-dev/pbr: Teach PBR about envra versions (useful for rpms). https://review.openstack.org/95234 | 18:15 |
*** jecarey has quit IRC | 18:21 | |
*** jecarey has joined #openstack-oslo | 18:22 | |
openstackgerrit | Terry Howe proposed a change to openstack/cliff: The --variable option to shell format is redundant https://review.openstack.org/95246 | 18:22 |
*** ihrachyshka has quit IRC | 18:24 | |
*** bknudson has joined #openstack-oslo | 18:33 | |
openstackgerrit | Solly Ross proposed a change to openstack/oslo-incubator: Report: Add basic processes section https://review.openstack.org/78793 | 18:51 |
openstackgerrit | Solly Ross proposed a change to openstack/oslo-incubator: Report: Propagate view_type through collections https://review.openstack.org/78792 | 18:51 |
openstackgerrit | Solly Ross proposed a change to openstack/oslo-incubator: Report: Support Sequences and Mappings as Data https://review.openstack.org/78791 | 18:51 |
*** jogo is now known as flashgordon | 18:52 | |
openstackgerrit | George Peristerakis proposed a change to openstack/oslo-incubator: wrapping the mock module with six https://review.openstack.org/87375 | 19:00 |
*** erecio_1 has joined #openstack-oslo | 19:36 | |
*** erecio has quit IRC | 19:39 | |
*** erecio_2 has joined #openstack-oslo | 19:58 | |
*** erecio_1 has quit IRC | 20:01 | |
*** mkoderer has quit IRC | 20:12 | |
*** erecio_2 has quit IRC | 20:14 | |
-openstackstatus- NOTICE: Gerrit will be offline for about 20 minutes in order to rename some projects starting at 21:00 UTC. | 20:34 | |
openstackgerrit | Masaru Nomura proposed a change to openstack/oslo.vmware: Add API for introspecting VMDKs https://review.openstack.org/95231 | 20:34 |
openstackgerrit | George Peristerakis proposed a change to openstack/oslo-incubator: wrapping the mock module with six https://review.openstack.org/87375 | 20:44 |
*** jecarey has quit IRC | 21:05 | |
*** AAzza has quit IRC | 21:14 | |
*** dshulyak has quit IRC | 21:14 | |
*** bogdando has quit IRC | 21:15 | |
*** dshulyak has joined #openstack-oslo | 21:16 | |
*** bogdando has joined #openstack-oslo | 21:16 | |
*** jecarey has joined #openstack-oslo | 21:18 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Add fix-import-cycle-log-and-versionutils spec https://review.openstack.org/95273 | 21:19 |
-openstackstatus- NOTICE: Gerrit is offline in order to rename some projects. ETA: 22:00. | 21:35 | |
*** ChanServ changes topic to "Gerrit is offline in order to rename some projects. ETA: 22:00." | 21:35 | |
boris-42 | dhellmann hey there | 21:52 |
dhellmann | hi, boris-42 | 21:52 |
boris-42 | dhellmann how are you? | 21:53 |
dhellmann | it's 5:53 PM on a Friday before a holiday weekend, so I'm 7 minutes from relaxation :-) | 21:54 |
dhellmann | you? | 21:54 |
boris-42 | dhellmann 5hrs before flight to Seatle=) | 21:54 |
boris-42 | dhellmann not sure that I'll be on oslo meeting | 21:54 |
boris-42 | =) | 21:54 |
dhellmann | the oslo meeting was 6 hours ago :-) | 21:54 |
boris-42 | ohhh | 21:55 |
boris-42 | 9 morning* | 21:55 |
boris-42 | not evening | 21:55 |
boris-42 | =( | 21:55 |
dhellmann | I have an action item to suggest that you send email to the -dev list to propose that oslo adopt osprofile | 21:55 |
dhellmann | no one had any objections, but we didn't have quorum to take the vote in the meeting anyway, so it's not a big deal | 21:55 |
dhellmann | I wonder if victors and rpodolyaka had the same confusion, I missed them earlier | 21:56 |
boris-42 | dhellmann hehe+) | 21:56 |
boris-42 | dhellmann so | 21:56 |
dhellmann | the meeting time is 16:00 UTC, for future reference | 21:56 |
boris-42 | dhellmann harlowja_ fixed issue with security | 21:56 |
boris-42 | dhellmann in osprofiler | 21:56 |
dhellmann | ah | 21:56 |
boris-42 | dhellmann now there are keys | 21:56 |
boris-42 | dhellmann and only person that know keys can set up trace_id | 21:57 |
boris-42 | key* | 21:57 |
dhellmann | that sounds like a good solution | 21:57 |
boris-42 | dhellmann as well I am going to add support of tracing every X request | 21:57 |
boris-42 | dhellmann so all issues from etherpad will be addressed | 21:58 |
boris-42 | in first version | 21:58 |
dhellmann | great! | 21:58 |
boris-42 | so when I address (during this weekend | 21:59 |
boris-42 | will finish this and send email | 21:59 |
*** harlowja_ is now known as harlowja_away | 21:59 | |
boris-42 | dhellmann there is one small issue that I found, we don't send the name of project in traces | 22:00 |
boris-42 | dhellmann just service name | 22:00 |
boris-42 | dhellmann so as well need to fix it | 22:00 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Add spec for app-agnostic-logging-parameters https://review.openstack.org/95281 | 22:00 |
dhellmann | boris-42: that sounds like it shouldn't be too hard to fix, though, right? | 22:01 |
boris-42 | dhellmann yep | 22:01 |
boris-42 | dhellmann just add one more argument in one function | 22:01 |
boris-42 | dhellmann it's good that we didn't merge patches in other projects yet=) | 22:02 |
boris-42 | dhellmann cause otherwise it will require 1 patch / project lol=) | 22:02 |
dhellmann | heh | 22:02 |
boris-42 | dhellmann so actually what I think is that we can keep turned on profiler in all devstack gates | 22:03 |
boris-42 | dhellmann cause it won't affect performance, cause nobody will setup trace_ids | 22:04 |
boris-42 | dhellmann put in headers* | 22:04 |
dhellmann | that sounds ok, but if nothing is setting the trace_ids what is the point of including them in the first place? | 22:05 |
dhellmann | oh, and did you resolve the question of having 2 sets of request ids (for tracing and for the request processing)? | 22:05 |
boris-42 | dhellmann so the purpose is that we have rally gates | 22:07 |
dhellmann | ah, ok | 22:07 |
boris-42 | dhellmann and we will be able to use in rally gates that use std dsvm stuff | 22:07 |
boris-42 | dhellmann profiling stuff | 22:08 |
boris-42 | dhellmann what do you mean by request processing? | 22:08 |
dhellmann | someone brought up the fact that there is already a parent request id being passed around for sub-requests, but that the tracing library adds another one | 22:09 |
*** yamahata has quit IRC | 22:10 | |
*** bknudson has quit IRC | 22:12 | |
boris-42 | dhellmann In the same email I will put explanation why it's impossible to use them | 22:12 |
*** bknudson has joined #openstack-oslo | 22:12 | |
boris-42 | dhellmann I mean they have different nature so... | 22:12 |
dhellmann | ok, that sounds good -- maybe we can change the ids we have now in a way that will allow them to be used for both purposes | 22:13 |
dhellmann | ok, my holiday weekend has officially started, so I'm signing off | 22:13 |
dhellmann | have a good flight, boris-42! | 22:13 |
boris-42 | dhellmann thanks=) | 22:13 |
boris-42 | dhellmann nope we are not ableā¦ they are just different for different things | 22:13 |
boris-42 | dhellmann have a nice holidays! +) | 22:13 |
dhellmann | boris-42: if that's the case, that's the case :-) | 22:14 |
*** openstackgerrit has quit IRC | 22:14 | |
*** yamahata has joined #openstack-oslo | 22:14 | |
*** openstackgerrit has joined #openstack-oslo | 22:15 | |
openstackgerrit | Monty Taylor proposed a change to openstack/oslotest: Update .gitreview for project rename https://review.openstack.org/95284 | 22:15 |
*** openstackstatus has quit IRC | 22:18 | |
*** openstack has joined #openstack-oslo | 22:19 | |
harlowja_ | dhellmann ya, i put in hmac header validation into osprofiler for boris-42 | 22:19 |
*** openstackstatus has joined #openstack-oslo | 22:20 | |
*** ChanServ sets mode: +v openstackstatus | 22:20 | |
harlowja_ | basically reject headers from hmac checks that don't pan out | 22:20 |
harlowja_ | so clients without the key wouldn't be able to send in wrong things | 22:20 |
harlowja_ | https://docs.python.org/2/library/hmac.html | 22:22 |
*** ChanServ changes topic to "#openstack-oslo" | 22:28 | |
*** dims has quit IRC | 22:56 | |
*** morganfainberg is now known as morganfainberg_Z | 23:01 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/oslo-incubator: Fix MemoryBackend not purging item from _keys_expired on delete https://review.openstack.org/95303 | 23:08 |
*** praneshp has quit IRC | 23:57 | |
*** praneshp has joined #openstack-oslo | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!