*** yamahata has quit IRC | 00:01 | |
*** yamahata has joined #openstack-oslo | 00:04 | |
openstackgerrit | Rick Harris proposed a change to openstack/oslo-incubator: Centralize bash-completion in Novaclient https://review.openstack.org/101376 | 00:12 |
---|---|---|
openstackgerrit | Rick Harris proposed a change to openstack/oslo-incubator: Centralize bash-completion in Novaclient https://review.openstack.org/101376 | 00:28 |
*** zzzeek has quit IRC | 00:28 | |
*** zzzeek has joined #openstack-oslo | 00:29 | |
*** zzzeek has quit IRC | 00:35 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 00:46 |
*** mrda has quit IRC | 00:47 | |
*** yamahata has quit IRC | 00:49 | |
*** mrda has joined #openstack-oslo | 00:53 | |
*** dims has joined #openstack-oslo | 00:58 | |
*** dims has quit IRC | 01:02 | |
*** dims_ has joined #openstack-oslo | 01:05 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 01:12 |
*** dstanek_404 is now known as dstanek | 01:14 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 01:34 |
*** yamahata has joined #openstack-oslo | 01:38 | |
*** dims_ has quit IRC | 01:39 | |
*** tsekiyam_ has joined #openstack-oslo | 02:08 | |
*** tsekiyama has quit IRC | 02:11 | |
*** tsekiyam_ has quit IRC | 02:12 | |
*** bnemec is now known as bnemec_away | 02:20 | |
*** praneshp has quit IRC | 02:30 | |
*** zzzeek has joined #openstack-oslo | 02:34 | |
openstackgerrit | Ken'ichi Ohmichi proposed a change to openstack/oslo-specs: Add add-uri-string-pattern-validation specs https://review.openstack.org/101393 | 02:43 |
*** zhiyan_ is now known as zhiyan | 02:49 | |
*** harlowja is now known as harlowja_away | 02:56 | |
*** zzzeek has quit IRC | 03:00 | |
*** zzzeek has joined #openstack-oslo | 03:04 | |
*** mestery has quit IRC | 03:17 | |
*** praneshp has joined #openstack-oslo | 03:32 | |
*** praneshp_ has joined #openstack-oslo | 03:34 | |
*** praneshp has quit IRC | 03:37 | |
*** praneshp_ is now known as praneshp | 03:37 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/pycadf: Updated from global requirements https://review.openstack.org/99091 | 03:38 |
*** arnaud__ has quit IRC | 04:02 | |
*** arnaud has joined #openstack-oslo | 04:42 | |
*** ildikov has quit IRC | 04:53 | |
*** openstackgerrit has quit IRC | 04:57 | |
*** praneshp has quit IRC | 05:19 | |
*** mrda is now known as mrda-away | 05:48 | |
*** ildikov has joined #openstack-oslo | 06:00 | |
*** tkelsey has joined #openstack-oslo | 06:40 | |
*** rpodolyaka has quit IRC | 07:19 | |
*** ihrachyshka has joined #openstack-oslo | 07:19 | |
*** ihrachyshka has quit IRC | 07:26 | |
*** ihrachyshka has joined #openstack-oslo | 07:28 | |
*** ihrachyshka has quit IRC | 07:31 | |
*** rdopieralski has joined #openstack-oslo | 07:32 | |
*** Xurong has quit IRC | 07:33 | |
*** Xurong has joined #openstack-oslo | 07:33 | |
*** zhiyan is now known as zhiyan_ | 08:00 | |
*** ihrachyshka has joined #openstack-oslo | 08:00 | |
*** i159 has joined #openstack-oslo | 08:01 | |
*** nacim has joined #openstack-oslo | 08:02 | |
sileht | jd__, can you take a look to https://review.openstack.org/#/c/100952/ | 08:27 |
*** arnaud has quit IRC | 08:28 | |
jd__ | sileht: can't you use the mock fixture instead? | 08:30 |
jd__ | just a suggestion | 08:30 |
sileht | jd__, oslo.msg don't have fixture module from incubator :) | 08:31 |
jd__ | ok | 08:32 |
jd__ | though you could add it but it's not a big deal | 08:32 |
jd__ | sileht: approved | 08:33 |
sileht | jd__, thanks | 08:33 |
sileht | jd__, if you have sometime I have this one too: https://review.openstack.org/#/c/100889/ the last one I need for the next release | 08:34 |
jd__ | let me check | 08:34 |
sileht | jd__, thx | 08:37 |
ihrachyshka | hey guys, several question about oslo.messaging. First, I was asked by a reviewer why oslo.messaging doesn't use 127.0.0.1 instead of 'localhost' as default values for hosts. He claims it's safer. I think the point is moot. What's your take? | 08:44 |
ihrachyshka | I guess he assumes there are use cases when localhost is not resolving correctly. are there any resolver libraries that fail to resolve symbolic name? | 08:44 |
*** oomichi has quit IRC | 08:53 | |
*** oomichi has joined #openstack-oslo | 08:54 | |
*** oomichi has quit IRC | 08:55 | |
*** lxsli has joined #openstack-oslo | 08:59 | |
*** lxsli has left #openstack-oslo | 09:00 | |
*** yamahata_ has quit IRC | 09:13 | |
*** amotoki has quit IRC | 09:34 | |
markmc | ihrachyshka, I suspect no-one has given it much thought and we could change it | 09:42 |
markmc | ihrachyshka, localhost works for ipv6 too? | 09:42 |
* markmc guesses wildly | 09:42 | |
ihrachyshka | markmc: no, I don't think so. F.e. on fedora20: | 09:45 |
ihrachyshka | 127.0.0.1 localhost.localdomain localhost | 09:45 |
ihrachyshka | ::1 localhost6.localdomain6 localhost6 | 09:45 |
ihrachyshka | so localhost will always resolve to ipv4 version | 09:45 |
haypo | markmc: yes | 09:45 |
ihrachyshka | it's from /etc/hosts | 09:46 |
markmc | right | 09:46 |
haypo | markmc: try "ping6 localhost" | 09:46 |
haypo | ihrachyshka: on my fedora 20, i also have "::1 localhost ..." in my /etc/hosts | 09:46 |
ihrachyshka | haypo: is it possible that there is a special handler in ping utility for localhost? | 09:46 |
ihrachyshka | haypo: weird :) | 09:47 |
ihrachyshka | haypo: what's your 'hostname'? | 09:47 |
haypo | i prefer to write 127.0.0.1 or ::1, it avoids DNS resolution (even if it's only local) | 09:47 |
haypo | I tested on Windows, "localhost" can be any IP using the hosts file :) | 09:47 |
haypo | ihrachyshka: my hostname is "smithers" | 09:48 |
ihrachyshka | well... I don't know :) I assume I haven't modified the file. Anyway, ping6 still works for localhost, it's either some special hook in e.g. libc or in ping6 itself | 09:50 |
ihrachyshka | when I do 'dig localhost', I get only A record for 127.0.0.1 | 09:51 |
sileht | I guess localhost should bind ipv4+ipv6 local addresses | 09:53 |
ihrachyshka | yes, as per RFC. though maybe it's not done via /etc/hosts even if records are there | 10:06 |
ihrachyshka | also on related note, 127.0.0.1 is not the only ipv4 loopback address, the whole 127.0.0.0/8 range is reserved for this | 10:06 |
ihrachyshka | for one of the products that I've worked on, we even used this to differentiate two distinct sources of (DNS UPDATE) requests. :) | 10:07 |
ihrachyshka | btw guys, maybe you will be interested in this. starting from yesterday, neutron is now using oslo.messaging instead of oslo-incubator RPC layer | 10:08 |
sileht | ihrachyshka, well done ! | 10:24 |
sileht | markmc, an you take a look to https://review.openstack.org/#/c/100889/, I have a sporadically issue in ceilometer du | 10:34 |
sileht | due to this bug | 10:35 |
i159 | Hi folks! I already have a bit of attention to the patch https://review.openstack.org/#/c/93398/, thanks for Mike and Doug! But we still need it to be merged, because this patch is the blocker for several significant patches for Keystone. You can easily find Keystone patches in the patches authored by me. So, Oslo folks, especially core people, please, review this patch. Thanks! | 10:37 |
*** flaper87|afk is now known as flaper87 | 10:51 | |
*** openstackgerrit has joined #openstack-oslo | 10:55 | |
openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Ensures listener queues exist in fake driver https://review.openstack.org/100889 | 10:56 |
*** yamahata_ has joined #openstack-oslo | 11:02 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Use cfgfilter to hide transport opts from API https://review.openstack.org/98779 | 11:16 |
therve | markmc, Hi, could you have a look at https://review.openstack.org/#/c/100457/ and see if it makes sense? | 11:17 |
*** zzzeek has quit IRC | 11:35 | |
*** flaper87 is now known as flaper87|afk | 11:40 | |
*** nacim has quit IRC | 11:47 | |
*** nacim has joined #openstack-oslo | 11:47 | |
*** eezhova has joined #openstack-oslo | 11:50 | |
*** zzzeek has joined #openstack-oslo | 11:55 | |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H402 https://review.openstack.org/101497 | 11:57 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H803, it's mostly an old flamewar https://review.openstack.org/101498 | 11:57 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H305 because it's python version specific https://review.openstack.org/101499 | 11:57 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H803, it's mostly an old flamewar https://review.openstack.org/101498 | 12:08 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H305 because it's python version specific https://review.openstack.org/101499 | 12:08 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H402 https://review.openstack.org/101497 | 12:08 |
*** zzzeek has quit IRC | 12:22 | |
*** yamahata has quit IRC | 12:39 | |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo-specs: Add rootwrap-daemon-mode blueprint https://review.openstack.org/94613 | 13:05 |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: replace string format arguments with function parameters https://review.openstack.org/94355 | 13:19 |
*** bknudson has left #openstack-oslo | 13:28 | |
*** russellb is now known as rustlebee | 13:29 | |
*** mriedem has joined #openstack-oslo | 13:31 | |
*** bknudson has joined #openstack-oslo | 13:42 | |
*** zhiyan_ has quit IRC | 13:50 | |
*** rdopieralski has quit IRC | 14:24 | |
*** tsekiyama has joined #openstack-oslo | 14:31 | |
*** yamahata has joined #openstack-oslo | 14:32 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Add spec for app-agnostic-logging-parameters https://review.openstack.org/95281 | 14:40 |
ttx | dhellmann: For spec approval you may want to try spec2bp.py from https://review.openstack.org/#/c/101566 | 14:49 |
ttx | I need feedback on it | 14:49 |
ttx | dhellmann: if you want to give it a go, https://review.openstack.org/#/c/98536/ is probably ripe for final approval. | 14:50 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: Improve initial documentation https://review.openstack.org/96961 | 14:54 |
openstackgerrit | George Peristerakis proposed a change to openstack/oslotest: Moving to use the mock module found in Python3 https://review.openstack.org/101315 | 15:00 |
*** jecarey has joined #openstack-oslo | 15:03 | |
dhellmann | sileht: is oslo.messaging not using oslotest, yet? | 15:09 |
dhellmann | ttx: ok, I have a couple of specs to approve this week so I'll give it a spin | 15:10 |
sileht | dhellmann, I don't thing so | 15:11 |
sileht | *think* | 15:12 |
dhellmann | sileht: ok, the fixtures you mentioned are in the library so it would be better to use those versions than the ones in the incubator | 15:12 |
sileht | dhellmann, I confirm no oslotest | 15:12 |
* sileht is adding use oslotest in oslo.msg into its todo list | 15:13 | |
dhellmann | sileht: thanks! | 15:13 |
ihrachyshka | dhellmann: hey. I've used config generator for oslo.msg and I see that 'host' option from matchmaker_redis didn't get into a separate group but was written out as if belonging to DEFAULT section. See: https://review.openstack.org/#/c/100014/7/etc/neutron.conf Is it a known issue? I wonder whether it's a bug in generator or in the library itself | 15:15 |
ihrachyshka | see line 385 | 15:16 |
openstackgerrit | George Peristerakis proposed a change to openstack/oslotest: Moving to use the mock module found in Python3 https://review.openstack.org/101315 | 15:16 |
ihrachyshka | matchmaker_redis seems to create a separate group, but it doesn't work. But... matchmaker_ring actually gets its own group | 15:17 |
dhellmann | ihrachyshka: did you use the "library" option to the generator, or did you have it scan the messaging code? | 15:17 |
dhellmann | ihrachyshka: it could be a bug in the messaging library's option discovery function | 15:18 |
ihrachyshka | I used -l | 15:18 |
ihrachyshka | matchmaker_redis specifies group as cfg.OptGroup, while matchmaker_ring uses pure string | 15:19 |
ihrachyshka | maybe that makes the difference | 15:19 |
ihrachyshka | let me check | 15:19 |
ihrachyshka | nope, it doesn't change anything | 15:23 |
ihrachyshka | dhellmann: indeed a bug in list_opts | 15:28 |
*** nacim has quit IRC | 15:28 | |
markmc | ihrachyshka, the config generator guesses which group an option belongs to AFAIR | 15:32 |
markmc | ihrachyshka, it's probably guessing wrong | 15:32 |
ihrachyshka | markmc: nope, there's a bug in list_opts in oslo.msg, as dhellmann said | 15:32 |
markmc | ihrachyshka, ah | 15:33 |
ihrachyshka | markmc: I'm about to send a fix | 15:33 |
markmc | sorry | 15:33 |
ihrachyshka | that's ok, I've discovered the existence of the function ~ 30 secs ago :) | 15:34 |
markmc | ah, I see the issue | 15:34 |
markmc | right, cool | 15:34 |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Set correct group for matchmaker_redis options https://review.openstack.org/101583 | 15:36 |
ihrachyshka | here you go: ^^ | 15:36 |
ihrachyshka | dhellmann: markmc: ^^ | 15:37 |
markmc | cool | 15:37 |
markmc | dhellmann, just see your release etherpads now - I thought we said 1.4.0a1 rather than 1.4.0.0a1 ? | 15:40 |
* markmc adds https://etherpad.openstack.org/p/oslo.messaging-1.4.0 to the agenda | 15:40 | |
*** zzzeek has joined #openstack-oslo | 15:44 | |
*** zzzeek has quit IRC | 15:45 | |
*** zzzeek has joined #openstack-oslo | 15:48 | |
haypo | markmc: thanks for the review of the poll timeout | 15:49 |
haypo | markmc: sorry, i didn't have time this week to add new tests | 15:49 |
markmc | haypo, hehe - I hope it was worth the wait :) | 15:49 |
haypo | markmc: don't worry, i made progress in parallel | 15:49 |
haypo | markmc: i'm working directly on the asyncio project (python 3.3+) | 15:49 |
markmc | haypo, that's fine, I'm looking forward to digging into the trollius stuff soon | 15:49 |
haypo | markmc: and i made good progress in Trollius too (Python 2 specific changes) | 15:50 |
* markmc has his oslo.messaging review queue to a small number of large patches | 15:50 | |
markmc | awesome | 15:50 |
haypo | markmc: last week, i tried to work on Ceilometer, but i had issues in Trollius and i also needed the trollius executor | 15:50 |
haypo | markmc: to be honest, i broke Trollius API at least 2 times in 3 months :) | 15:51 |
markmc | haypo, only 2 times - you're not trying hard enough :) | 15:51 |
haypo | ok, maybe 3 times then | 15:51 |
markmc | haypo, you mean regressions, or changed the API incompatibly ? | 15:51 |
haypo | markmc: by breaking the API, i changed the name of the module for example... | 15:51 |
haypo | API breaks | 15:52 |
markmc | haypo, ah, ok | 15:52 |
markmc | we'll want that to settle down before taking a dependency on it | 15:52 |
markmc | do you think you're almost done with API changes? | 15:52 |
haypo | markmc: i was not sure before last week | 15:53 |
haypo | when i changed the name of the module, i dropped the ability to use modules written for asyncio | 15:53 |
haypo | but with a few changes in Trollius, it's now possible to use asyncio code in Trollius | 15:54 |
haypo | markmc: so i'm confident that the API is almost stable :) | 15:54 |
*** SridharG has joined #openstack-oslo | 15:54 | |
markmc | cool :) | 15:54 |
haypo | markmc: the problem is that there is no major application using Trollius right now, only modules | 15:54 |
markmc | I guess API stability really only becomes important when an application switches to it | 15:55 |
haypo | it would be nice to see a large application like ceilometer working with Trollius before moving to the famous "1.0" version | 15:55 |
markmc | right | 15:55 |
haypo | API incompatibilities were required to support Python 3.4 and later, and to ease the transition from Trollius to asyncio | 15:55 |
haypo | because the final goal is to use directly asyncio! | 15:56 |
haypo | (Trollius is supposed to be trampoline until OpenStack complelty switch to Python 3, in 5 years maybe ;-)) | 15:56 |
markmc | absolutely! | 15:57 |
markmc | 5 years is being a bit ambitious | 15:57 |
markmc | I hope to work on it during my retirement | 15:58 |
ihrachyshka | :D | 15:58 |
ihrachyshka | I'm quite young, I'll see it coming in my late 40s maybe! | 15:58 |
*** mriedem has quit IRC | 15:58 | |
haypo | i have to go, good week-end | 15:59 |
haypo | markmc: see you at paris for the sprint!! | 15:59 |
dhellmann | markmc: lifeless convinced me that for full compatibility we need the extra ".0" | 15:59 |
markmc | absolutely, have a nice weekend | 15:59 |
haypo | markmc: i updated my overall roadmap for Trollius in OpenStack: http://haypo-notes.readthedocs.org/openstack.html#roadmap | 16:00 |
markmc | dhellmann, where was this convincing ? | 16:00 |
* markmc happy to go read back | 16:00 | |
haypo | oops s/Start Trollius dependency: done!/Add Trollius dependency: done!/g | 16:00 |
dhellmann | markmc: https://review.openstack.org/96608 | 16:01 |
markmc | dhellmann, ah, of course - sorry | 16:01 |
*** mriedem has joined #openstack-oslo | 16:05 | |
*** arnaud__ has joined #openstack-oslo | 16:14 | |
ihrachyshka | disgusting... to get 2 line fix from jsonutils in oslo.messaging, I need to sync 1478 lines of crap code from (new) depending modules | 16:15 |
ihrachyshka | well, not crap really, but still | 16:15 |
*** jogo is now known as flashgordon | 16:15 | |
*** ildikov has quit IRC | 16:18 | |
ihrachyshka | is oslo.i18n ready to be used in oslo-incubator code? | 16:18 |
ihrachyshka | It would be beneficial to at least break that sync madness on this module, because its incubator version grabs log and local modules. | 16:20 |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Synced from oslo-incubator https://review.openstack.org/95696 | 16:22 |
markmc | ihrachyshka, nothing in the jsonutils changes requires an updated gettextutils, I'd happily approve a jsonutils sync | 16:25 |
markmc | ihrachyshka, the gettextutils sync is just blocked on my "we're really going to do translated log messages in this library? really really?" | 16:26 |
*** ihrachyshka has quit IRC | 16:35 | |
*** praneshp has joined #openstack-oslo | 16:52 | |
*** mestery has joined #openstack-oslo | 16:53 | |
*** i159 has quit IRC | 16:54 | |
*** viktors is now known as viktors|afk | 16:56 | |
*** mestery has quit IRC | 16:59 | |
*** harlowja_away is now known as harlowja | 17:00 | |
*** ihrachyshka has joined #openstack-oslo | 17:01 | |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.messaging: Set correct group for matchmaker_redis options https://review.openstack.org/101583 | 17:03 |
harlowja | haypo whats the current thinking with the eventlet python3 release, does that affect the roadmap for trollius? | 17:06 |
harlowja | i thought they at least put out a alpha version | 17:06 |
*** ildikov has joined #openstack-oslo | 17:09 | |
*** ihrachyshka has quit IRC | 17:15 | |
markmc | harlowja, IMO, it may speed up the port to python3 but doesn't lesson the desire to move to asyncio/trollius | 17:24 |
markmc | https://wiki.openstack.org/wiki/Oslo/blueprints/asyncio | 17:25 |
markmc | "The availability of eventlet on Python 3 would not change anything, we want to replace it for all the reasons listed above. " | 17:25 |
*** markmc has quit IRC | 17:26 | |
*** ihrachyshka has joined #openstack-oslo | 17:27 | |
*** mriedem has quit IRC | 17:47 | |
*** yamahata has quit IRC | 17:48 | |
harlowja | whats stopping eventlet from plugging into asyncio underneath the covers :-P | 17:50 |
*** SridharG has quit IRC | 17:51 | |
*** lbragstad has joined #openstack-oslo | 18:00 | |
openstackgerrit | George Peristerakis proposed a change to openstack/oslo-incubator: wrapping the mock module with six https://review.openstack.org/87375 | 18:20 |
*** krotscheck has quit IRC | 18:28 | |
*** krotscheck has joined #openstack-oslo | 18:31 | |
*** krotscheck has quit IRC | 18:32 | |
*** krotscheck has joined #openstack-oslo | 18:36 | |
*** markmcclain has joined #openstack-oslo | 18:38 | |
*** ihrachyshka has quit IRC | 18:45 | |
*** tkelsey has quit IRC | 18:46 | |
*** ildikov has quit IRC | 18:54 | |
*** harlowja is now known as harlowja_away | 18:57 | |
*** harlowja_away is now known as harlowja | 19:01 | |
openstackgerrit | Michael H Wilson proposed a change to openstack/oslo.messaging: Add first unit test for 0MQ https://review.openstack.org/93905 | 19:09 |
bknudson | they keystone change for oslo.db should be making its way through the gate soon -- https://review.openstack.org/#/c/77210/ | 19:20 |
dhellmann | bknudson: nice! | 19:21 |
openstackgerrit | Julien Danjou proposed a change to openstack/oslo-incubator: rpc, notifier: remove deprecated modules https://review.openstack.org/101629 | 19:21 |
dhellmann | jd__: I think technically removing the rpc code is ok, but in the interest of not surprising anyone I think we should announce it on the mailing list first. | 19:24 |
*** lbragstad has quit IRC | 19:36 | |
therve | Also publish_errors needs to be fixed before | 19:37 |
therve | And I'm not sure who's "everybody" in "everybody migrated to oslo.messaging" :) | 19:37 |
harlowja | btw, the qpid + kombu thing seems to be getting closer to happening/merging | 19:39 |
harlowja | could reduce some of the code in oslo.messaging if that merges | 19:40 |
harlowja | https://github.com/celery/kombu/pull/335 | 19:40 |
harlowja | https://github.com/celery/kombu/pull/335#issuecomment-46448402 | 19:40 |
*** ihrachyshka has joined #openstack-oslo | 19:40 | |
* harlowja i always thought it 'felt more natural' if oslo.messaging mainly used kombu | 19:41 | |
harlowja | and added special sauce ontop of kombu | 19:41 |
*** mestery_ has joined #openstack-oslo | 19:44 | |
*** mestery_ is now known as mestery | 19:45 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: Improve initial documentation https://review.openstack.org/96961 | 19:46 |
*** ildikov has joined #openstack-oslo | 19:51 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: Improve initial documentation https://review.openstack.org/96961 | 19:53 |
*** ildikov has quit IRC | 20:02 | |
ihrachyshka | dhellmann: hey, I have a question re: pep8 checks in incubator | 20:06 |
dhellmann | ihrachyshka: ok | 20:06 |
ihrachyshka | dhellmann: in incubator, there are some pep8 violations, but they seem to be in ignore list. when I sync some files from them to oslo.msg, its pep8 check starts to complain | 20:07 |
ihrachyshka | so I go to incubator and try to fix them there first. I disable the check that failed, rerun tox -e pep8 to see failure... and it passes | 20:07 |
ihrachyshka | f.e. I got the failure: http://logs.openstack.org/96/95696/5/check/gate-oslo.messaging-pep8/100b737/console.html in oslo.msg | 20:07 |
ihrachyshka | but even if I remove E251 from incubator's ignore list, it doesn't fail there | 20:08 |
dhellmann | ihrachyshka: do those repositories use different versions of flake8 or hacking? | 20:08 |
ihrachyshka | dhellmann: hm, let me check | 20:08 |
dhellmann | ihrachyshka: or do you have an old tox environment in your incubator repository? | 20:08 |
ihrachyshka | pinned versions of hacking look the same. rebuilding tox env... | 20:11 |
ihrachyshka | aha, indeed, it helped to reveal failures! :) great, thanks a lot | 20:12 |
*** ildikov has joined #openstack-oslo | 20:12 | |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: pep8: fixed E251 violations https://review.openstack.org/101643 | 20:18 |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: pep8: fixed F402 violations https://review.openstack.org/101644 | 20:18 |
dhellmann | ihrachyshka: good :-) | 20:27 |
*** mestery has quit IRC | 20:28 | |
*** markmcclain has quit IRC | 20:28 | |
*** markmcclain has joined #openstack-oslo | 20:39 | |
*** lbragstad has joined #openstack-oslo | 20:40 | |
*** zhiyan_ has joined #openstack-oslo | 20:46 | |
jd__ | dhellmann: sure :) | 20:46 |
*** markmcclain has quit IRC | 20:54 | |
ihrachyshka | dhellmann: I've crafted 8 more pep8 checks enabled in separate patches. Most of them are really tiny. Should I squash them before sending, or better to have tiny isolated pieces? | 21:01 |
dhellmann | ihrachyshka: just put them all together into one patch | 21:14 |
ihrachyshka | dhellmann: ok thanks, I'll abandon those two I've sent an hour ago | 21:15 |
dhellmann | ihrachyshka: ok | 21:15 |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: pep8: fixed multiple violations https://review.openstack.org/101656 | 21:22 |
*** jecarey has quit IRC | 21:22 | |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: pep8: fixed multiple violations https://review.openstack.org/101656 | 21:34 |
*** jecarey has joined #openstack-oslo | 21:38 | |
*** ihrachyshka has quit IRC | 21:54 | |
*** praneshp_ has joined #openstack-oslo | 21:56 | |
*** praneshp has quit IRC | 21:57 | |
*** praneshp_ is now known as praneshp | 21:57 | |
openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Sync excutils from Oslo https://review.openstack.org/101660 | 22:03 |
*** jecarey has quit IRC | 22:11 | |
*** yamahata has joined #openstack-oslo | 22:22 | |
*** mestery has joined #openstack-oslo | 22:31 | |
*** mestery has quit IRC | 22:31 | |
*** mestery has joined #openstack-oslo | 22:32 | |
*** morganfainberg is now known as morganfainberg_Z | 22:41 | |
*** jecarey has joined #openstack-oslo | 22:43 | |
*** jecarey has quit IRC | 22:50 | |
*** mestery has quit IRC | 23:21 | |
*** tsekiyama has quit IRC | 23:52 | |
*** bknudson has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!