*** yamahata has quit IRC | 00:03 | |
*** morganfainberg_L has quit IRC | 00:39 | |
*** arnaud has quit IRC | 00:51 | |
*** amotoki has joined #openstack-oslo | 00:59 | |
*** flashgordon is now known as jogo | 01:01 | |
*** morganfainberg_L has joined #openstack-oslo | 01:14 | |
*** yamahata has joined #openstack-oslo | 01:17 | |
*** mestery has joined #openstack-oslo | 01:28 | |
openstackgerrit | Kevin McCarthy proposed a change to openstack-dev/pbr: Restore Monkeypatched Distribution Instance https://review.openstack.org/101785 | 01:32 |
---|---|---|
*** yamahata has quit IRC | 01:58 | |
*** yamahata has joined #openstack-oslo | 01:58 | |
*** haypo has quit IRC | 02:15 | |
*** HenryG has joined #openstack-oslo | 02:21 | |
*** haypo has joined #openstack-oslo | 02:24 | |
*** haypo has joined #openstack-oslo | 02:24 | |
*** zzzeek has joined #openstack-oslo | 02:36 | |
*** arnaud has joined #openstack-oslo | 02:48 | |
*** lbragstad has quit IRC | 02:54 | |
*** lbragstad has joined #openstack-oslo | 02:55 | |
*** zhiyan_ is now known as zhiyan | 03:04 | |
*** arnaud has quit IRC | 03:06 | |
*** arnaud has joined #openstack-oslo | 03:11 | |
*** zzzeek has quit IRC | 03:34 | |
*** arnaud has quit IRC | 03:35 | |
*** zzzeek has joined #openstack-oslo | 03:51 | |
*** arnaud has joined #openstack-oslo | 04:02 | |
*** zzzeek has quit IRC | 04:17 | |
*** praneshp_ has joined #openstack-oslo | 04:23 | |
*** praneshp has quit IRC | 04:24 | |
*** praneshp_ is now known as praneshp | 04:24 | |
*** arnaud has quit IRC | 04:24 | |
*** arnaud has joined #openstack-oslo | 04:26 | |
*** SridharG has joined #openstack-oslo | 04:26 | |
*** ildikov has quit IRC | 05:10 | |
*** morganfainberg_L has quit IRC | 05:24 | |
*** ajc_ has joined #openstack-oslo | 05:29 | |
*** ildikov has joined #openstack-oslo | 05:35 | |
*** arnaud has quit IRC | 06:04 | |
*** arnaud has joined #openstack-oslo | 06:08 | |
*** pblaho has joined #openstack-oslo | 06:16 | |
*** openstackstatus has quit IRC | 06:27 | |
*** SridharG has quit IRC | 06:30 | |
*** pblaho is now known as pblaho|afk | 06:32 | |
*** SridharG has joined #openstack-oslo | 06:36 | |
*** rdopieralski has joined #openstack-oslo | 06:52 | |
*** pblaho|afk is now known as pblaho | 06:53 | |
*** viktors|afk is now known as viktors | 06:59 | |
*** praneshp has quit IRC | 07:08 | |
*** praneshp has joined #openstack-oslo | 07:09 | |
openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Ensures listener queues exist in fake driver https://review.openstack.org/100889 | 07:10 |
*** praneshp has quit IRC | 07:21 | |
viktors | bnemec: around? | 07:28 |
*** ihrachyshka has joined #openstack-oslo | 07:29 | |
*** sileht has quit IRC | 07:35 | |
*** nacim has joined #openstack-oslo | 07:52 | |
openstackgerrit | garyk proposed a change to openstack/oslo.vmware: Tanslations: make use of _LE and _LW https://review.openstack.org/101821 | 07:57 |
*** i159 has joined #openstack-oslo | 08:01 | |
*** ildikov has quit IRC | 08:03 | |
*** sileht has joined #openstack-oslo | 08:04 | |
*** mrda is now known as mrda-away | 08:12 | |
*** arnaud has quit IRC | 08:19 | |
*** oomichi has quit IRC | 08:19 | |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Opportunistic migration tests https://review.openstack.org/93424 | 08:34 |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Implementation Alembic as migration engine https://review.openstack.org/99965 | 08:34 |
*** sileht has quit IRC | 08:38 | |
*** sileht has joined #openstack-oslo | 08:41 | |
*** markmc has joined #openstack-oslo | 08:53 | |
*** SridharG has quit IRC | 08:53 | |
*** ildikov_ has joined #openstack-oslo | 08:55 | |
*** tkelsey has joined #openstack-oslo | 08:58 | |
*** tkelsey_ has joined #openstack-oslo | 08:59 | |
*** ihrachyshka is now known as ihrachyshka|food | 08:59 | |
*** ujjain has quit IRC | 09:01 | |
*** ildikov_ has quit IRC | 09:04 | |
*** ildikov has joined #openstack-oslo | 09:08 | |
*** ihrachyshka|food has quit IRC | 09:10 | |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo-specs: Add rootwrap-daemon-mode blueprint https://review.openstack.org/94613 | 09:23 |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo-specs: Add rootwrap-daemon-mode blueprint https://review.openstack.org/94613 | 09:28 |
sileht | Can you take a look to https://review.openstack.org/#/c/100889/, I have rebased it, and fix the markmc comment | 09:30 |
sileht | jd__, ^ | 09:30 |
*** jaosorior has joined #openstack-oslo | 09:31 | |
*** pblaho is now known as pblaho|afk | 09:45 | |
*** pblaho|afk is now known as pblaho | 09:48 | |
*** SridharG has joined #openstack-oslo | 09:53 | |
*** ihrachyshka has joined #openstack-oslo | 09:55 | |
*** pblaho is now known as pblaho|afk | 10:09 | |
*** pblaho|afk is now known as pblaho | 10:13 | |
*** pblaho is now known as pblaho|afk | 10:28 | |
*** zhiyan is now known as zhiyan_ | 10:32 | |
jd__ | "the markmc comment", that sounds like a good title for a movie | 10:32 |
*** ildikov has quit IRC | 11:00 | |
*** yamahata has quit IRC | 11:13 | |
*** lbragstad has quit IRC | 11:40 | |
*** pblaho|afk is now known as pblaho | 11:41 | |
*** pblaho has quit IRC | 11:50 | |
*** ildikov has joined #openstack-oslo | 11:54 | |
*** SridharG has quit IRC | 11:57 | |
openstackgerrit | ChangBo Guo(gcb) proposed a change to openstack/oslo.db: Avoid usage of mutables as default args https://review.openstack.org/101893 | 12:24 |
*** erecio has joined #openstack-oslo | 12:24 | |
openstackgerrit | ChangBo Guo(gcb) proposed a change to openstack/oslo.rootwrap: Avoid usage of mutables as default args https://review.openstack.org/101898 | 12:30 |
*** gordc has joined #openstack-oslo | 12:40 | |
*** ajc_ has quit IRC | 12:40 | |
*** yamahata has joined #openstack-oslo | 12:45 | |
*** bknudson has joined #openstack-oslo | 13:02 | |
openstackgerrit | Abhishek Kekane proposed a change to openstack/oslo-incubator: Add default log level for websocket https://review.openstack.org/101908 | 13:10 |
jaosorior | anybody knows what the status of oslo.version is? | 13:11 |
jaosorior | Is it recommended for usage? | 13:11 |
*** mriedem has joined #openstack-oslo | 13:13 | |
*** pblaho has joined #openstack-oslo | 13:14 | |
*** jecarey has quit IRC | 13:16 | |
*** lbragstad has joined #openstack-oslo | 13:18 | |
*** tkelsey has quit IRC | 13:22 | |
*** tkelsey_ has quit IRC | 13:22 | |
*** markmc has quit IRC | 13:23 | |
*** SridharG has joined #openstack-oslo | 13:29 | |
*** dims has joined #openstack-oslo | 13:31 | |
viktors | bnemec: hi | 13:33 |
*** zzzeek has joined #openstack-oslo | 13:37 | |
bnemec | viktors: Hey | 13:40 |
*** ildikov has quit IRC | 13:40 | |
viktors | bnemec: I wanted to ask you review a single patch, but I found some issues there for now | 13:43 |
viktors | bnemec: so it's just "hello!" | 13:44 |
viktors | :) | 13:44 |
bnemec | viktors: Sounds good. And hello! :-) | 13:45 |
*** ildikov_ has joined #openstack-oslo | 13:49 | |
*** rustlebee is now known as russellb | 13:50 | |
*** gordc has quit IRC | 13:50 | |
therve | dims, Hey, around for https://review.openstack.org/100457 ? | 13:53 |
dims | therve, looking | 13:56 |
dims | ah i just left a comment in that | 13:57 |
therve | Yes :) | 13:57 |
therve | dims, It's not the other way because of testing issues | 13:57 |
therve | The first patch did that and failed to run | 13:57 |
therve | Presumably it will be a very short lived fix anyway | 13:57 |
dims | therve, i see. patch seemed counter to the request in the bug report - "The publish_errors option will try to use oslo notifier, but we should use oslo.messaging instead if available." | 13:58 |
* dhellmann starts releasing libraries... | 13:58 | |
therve | dims, They can't live next to each other anyway, so I don't think that matters | 13:58 |
dims | therve, commit message needs to be fixed at least to say that we try openstack.common.log_handler.PublishErrorsHandler first | 13:59 |
dims | therve, i got it now. let's fix the commit message and i'll +2 it | 13:59 |
therve | I think it says that, although maye not that clearly? | 13:59 |
therve | I changed it already fwiw :) | 13:59 |
jd__ | unleash the libs, dhellmann! | 13:59 |
dhellmann | jd__: we need some t-shirts for the oslo team with "Unleash the libs!" for the summit | 14:01 |
jd__ | hehe | 14:02 |
ihrachyshka | therve: they can live together, you just don't import them at the same time :) | 14:05 |
therve | ihrachyshka, That's a very limited definitino of live :) | 14:05 |
dims | therve, would this work? "Try PublishErrorsHandler in oslo notifier first. If it does not exist fall back | 14:05 |
dims | to the one in oslo.messaging." what we have in the commit message is a bit unclear | 14:05 |
*** yamahata has quit IRC | 14:05 | |
therve | dims, Well we already try the notifier first... | 14:05 |
*** yamahata has joined #openstack-oslo | 14:06 | |
dims | therve, the words that trips me over is "instead of the one". if you don't want to touch the commit message, that's fine. i'll +2 as-is | 14:07 |
dims | just let me know | 14:07 |
therve | No I'd be happy to fix it | 14:08 |
therve | dims, "If log_handler is not available, fallback to oslo.messaging PublishErrorsHandler | 14:10 |
therve | to not require oslo notifier." ? | 14:10 |
dims | sounds good | 14:10 |
openstackgerrit | Thomas Herve proposed a change to openstack/oslo-incubator: Use oslo.messaging to publish log errors https://review.openstack.org/100457 | 14:11 |
dims | thanks therve | 14:12 |
therve | dims, Thank you! | 14:12 |
*** morganfainberg_L has joined #openstack-oslo | 14:18 | |
bknudson | dhellmann: could you add --no-merges when listing commits in the release? | 14:18 |
dhellmann | bknudson: yeah, I'll do that next time | 14:18 |
dhellmann | bknudson: pbr does that, but we have a bug in pbr where it looks at dates of the original commit, but not the merge, so it shows some changes being in a version before they were actually released, so I was trying to be cautious this time around and get *everything* | 14:22 |
*** morganfainberg_L is now known as mdrnstm | 14:23 | |
*** mdrnstm has quit IRC | 14:23 | |
*** mdrnstm has joined #openstack-oslo | 14:23 | |
*** tsekiyama has joined #openstack-oslo | 14:34 | |
*** morganfainberg has quit IRC | 14:45 | |
*** morganfainberg_Z has joined #openstack-oslo | 14:45 | |
*** mdrnstm is now known as morganfainberg | 14:45 | |
*** jecarey has joined #openstack-oslo | 14:51 | |
*** markmc has joined #openstack-oslo | 15:03 | |
*** ihrachyshka has quit IRC | 15:04 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: Add API documentation https://review.openstack.org/98861 | 15:13 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: Add API documentation https://review.openstack.org/98861 | 15:18 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslotest: Add API documentation https://review.openstack.org/98861 | 15:19 |
*** nacim has quit IRC | 15:21 | |
*** ildikov_ has quit IRC | 15:32 | |
*** rdopieralski has quit IRC | 15:37 | |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Opportunistic migration tests https://review.openstack.org/93424 | 15:38 |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Implementation Alembic as migration engine https://review.openstack.org/99965 | 15:38 |
*** pblaho is now known as pblaho|afk | 15:47 | |
*** ildikov has joined #openstack-oslo | 15:53 | |
openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Add a base test case for DB schema comparison https://review.openstack.org/93398 | 15:56 |
*** pblaho|afk is now known as pblaho | 15:59 | |
*** viktors is now known as viktors|afk | 16:01 | |
*** jaosorior has quit IRC | 16:12 | |
*** bknudson has quit IRC | 16:14 | |
*** praneshp has joined #openstack-oslo | 16:15 | |
*** dstanek_zzz is now known as dstanek | 16:24 | |
mriedem | i'd like to move cpu_count() from nova into oslo-incubator, but not sure the best place to put it | 16:24 |
mriedem | https://review.openstack.org/#/c/69266/1/nova/utils.py | 16:24 |
mriedem | i plan on using that in cinder/glance for the same reason as nova created it | 16:25 |
mriedem | thinking service.py? | 16:26 |
*** arnaud__ has joined #openstack-oslo | 16:29 | |
mriedem | but glance doesn't copy the service module from oslo, hmm | 16:31 |
dhellmann | mriedem: seems a little small for a stand-alone module, but I could see it ending up in oslo.concurrency eventually https://review.openstack.org/#/c/97296/3/specs/juno/graduate-oslo-concurrency.rst | 16:35 |
dhellmann | service won't go there, so I'm not sure service is the best place for the function | 16:35 |
mriedem | dhellmann: cool, i was thinking processutils initially, but that's more CLI stuff rather than threads/processes, so didn't seem to fit as much | 16:36 |
dhellmann | yeah | 16:37 |
mriedem | was also thinking lockutils | 16:37 |
mriedem | although cpu_count is not related to locking | 16:37 |
dhellmann | mriedem: are there any other related functions in nova that could be combined into a cpuutils module? | 16:37 |
mriedem | dhellmann: i can look | 16:38 |
dhellmann | mriedem: the other question I have is, when is that function not implemented in multiprocessing? because maybe that's no longer the case? | 16:39 |
mriedem | dhellmann: the python docs say it may raise that | 16:40 |
*** arnaud__ has quit IRC | 16:40 | |
mriedem | looks like python 3.4 has it in the os module https://docs.python.org/3/library/os.html#os.cpu_count | 16:43 |
dhellmann | mriedem: the implementation is using NotImplementedError as the exception any time it sees an error trying to determine the number | 16:43 |
dhellmann | mriedem: I thought maybe it was an operating system support issue, but it looks like all errors are converted to that exception | 16:44 |
* bnemec chuckles while triaging https://bugs.launchpad.net/oslo/+bug/1333337 | 16:45 | |
dhellmann | mriedem: maybe osutils is the right name? or sysutils? | 16:46 |
dhellmann | bnemec: heh | 16:46 |
mriedem | dhellmann: i'm open to either, osutils would be more specific | 16:47 |
mriedem | dhellmann: also thinking about what oslo would return for NotImplementedError - nova is returning 1 because cpu_count() is being used to set the number of workers, which used to default to 1 | 16:47 |
dhellmann | mriedem: I'm not sure the number of CPUs is an operating system choice :-) | 16:47 |
mriedem | an oslo consumer might use that for something else, so maybe returning None would be more appropriate to signal 'i don't know' | 16:48 |
mriedem | dhellmann: good point :) | 16:48 |
mriedem | derp | 16:48 |
mriedem | i'm fine with sysutils if you are | 16:48 |
dhellmann | mriedem: it seems like we want a get_number_of_workers() that uses cpu count but defaults to 1, instead of calling the function cpu_count | 16:48 |
*** dstanek is now known as dstanek_zzz | 16:48 | |
bnemec | Isn't returning None still going to require wrapper logic in the consumers? | 16:48 |
mriedem | bnemec: yeah, which sucks | 16:49 |
mriedem | you could pass in something... | 16:49 |
dhellmann | and that appears to be the whole point of this function | 16:49 |
mriedem | 'use this if you can't figure it out' | 16:49 |
mriedem | right | 16:49 |
dhellmann | I think it's just poorly named | 16:49 |
dhellmann | if the intent is to get a useful number of workers, then the name should indicate that somehow | 16:49 |
bnemec | A configurable default could work. | 16:50 |
dhellmann | get_parallelization_factor() or get_worker_count() or something | 16:50 |
bnemec | def cpu_count(default=1): | 16:50 |
mriedem | i'm also ok with just renaming when moving to oslo and passing a default kwarg | 16:50 |
dhellmann | bnemec: when would anything ever pass a different value? | 16:50 |
bnemec | Then if someone wants different behavior they can make that happen. | 16:50 |
bnemec | dhellmann: I dunno, 1 seems like a reasonable default to me, but if someone wanted to do something different they could default to None and do the wrapper logic. | 16:52 |
*** dstanek_zzz is now known as dstanek | 16:52 | |
mriedem | in nova if the option isn't explictly set it just uses cpu_count(), else 1 if NotImplementedError | 16:53 |
mriedem | glance today defaults to 1 | 16:53 |
dhellmann | bnemec: that's true, but I'd rather we create APIs that are well-defined and what you're describing seems like a different function than this one. | 16:53 |
mriedem | i'd do the same in glance probably, check if the option is set and if not, call cpu_count() else default to 1 | 16:53 |
dhellmann | mriedem: so this function is only used to set the default for the number of workers? | 16:53 |
mriedem | dhellmann: set the number of workers if not explicitly specified in the config | 16:54 |
dhellmann | mriedem: right | 16:54 |
dhellmann | and where is that configuration option defined? | 16:54 |
mriedem | the only other integrated projects i'm aware of that have a workers value like this is cinder and ceilometer, and they also default to 1 | 16:54 |
mriedem | in each project, not oslo | 16:54 |
mriedem | nova has multiple workers, glance has one for the api worker, cinder has one for the volume api worker | 16:55 |
mriedem | i think ceilometer has one | 16:55 |
bnemec | dhellmann: The only thing is that a default of 1 makes it impossible to tell whether that's the actual cpu count or the "couldn't get the cpu count" value. None requires the wrapper logic which defeats the purpose of the function. | 16:55 |
mriedem | looks like trove has an api worker and conductor worker | 16:55 |
dhellmann | bnemec: right, so the question is, is this function really about getting an accurate CPU count, or is it about getting the default for the number of workers? | 16:56 |
bnemec | But I don't have a specific case in mind where someone might want to do something different in the "can't get cpu count" case, so maybe it's not worth worrying about. | 16:56 |
dhellmann | yeah | 16:57 |
bnemec | dhellmann: Well, number of workers is pretty service-specific so I feel like that would belong in service.py again. | 16:58 |
mriedem | so call it get_worker_count() and return 1 if NotImplementedError? is default=1 kwarg even useful? | 16:58 |
bnemec | If it's in oslo.concurrency then I think cpu count is the appropriate thing. | 16:58 |
dhellmann | bnemec: that makes sense, so I think we should put it in with the service code | 16:59 |
dhellmann | mriedem: I don't think the default argument is useful, but I'm willing to be proven wrong :-) | 16:59 |
bnemec | The default argument could always be added later too. | 17:00 |
mriedem | me neither really since everyone defaults to 1 | 17:00 |
mriedem | sure | 17:00 |
mriedem | i need to dig into trove's usage for api since they default to None | 17:00 |
bnemec | no args -> 1 defaulted arg isn't going to be an api-breaking change. | 17:00 |
mriedem | not sure wtf that means | 17:00 |
mriedem | gonna eat lunch and then push something up, need to remember to give credit to russellb for the method and tests | 17:01 |
openstackgerrit | Chris Krelle proposed a change to openstack/oslo-incubator: Add option to generate_sample.sh to use tox.ini excludes https://review.openstack.org/78765 | 17:02 |
*** i159 has quit IRC | 17:08 | |
*** harlowja_away is now known as harlowja | 17:08 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: Improve initial documentation https://review.openstack.org/96961 | 17:17 |
*** arnaud__ has joined #openstack-oslo | 17:36 | |
*** ildikov has quit IRC | 17:42 | |
*** harlowja has quit IRC | 18:00 | |
mriedem | bnemec: looks like the difference between 1 workers and None is the difference between a ProcessLauncher and ServiceLauncher in service.py | 18:02 |
mriedem | only seeing that because trove_api_workers defaults to None | 18:02 |
mriedem | so it'd get a ServiceLauncher | 18:02 |
openstackgerrit | pritesh proposed a change to openstack-dev/hacking: Add hacking check for vim configuration in source files https://review.openstack.org/101969 | 18:06 |
*** bknudson has joined #openstack-oslo | 18:06 | |
*** ihrachyshka has joined #openstack-oslo | 18:08 | |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H904 https://review.openstack.org/101701 | 18:16 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H803, it's mostly an old flamewar https://review.openstack.org/101498 | 18:16 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H305 because it's python version specific https://review.openstack.org/101499 | 18:16 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H402 https://review.openstack.org/101497 | 18:16 |
*** markmcclain has joined #openstack-oslo | 18:20 | |
*** ihrachyshka has quit IRC | 18:21 | |
bnemec | mriedem: Oh, because ServiceLauncher doesn't support multiple workers? | 18:28 |
bnemec | At least if I'm reading the code right. | 18:28 |
mriedem | bnemec: that's what it looks like | 18:29 |
mriedem | bnemec: i'm asking if the trove guys made a conscious decision there though | 18:29 |
mriedem | workers=1 means ProcessLauncher with a child service | 18:29 |
mriedem | wokers=None means ServiceLauncher by itself | 18:29 |
mriedem | so any big gains? do you avoid any kind of overhead from ProcessLauncher? | 18:30 |
bnemec | mriedem: ServiceLauncher supports the restart on sighup functionality, but that's about the extent of my knowledge on these things. | 18:31 |
bnemec | Oh, wait, ProcessLauncher does too. | 18:32 |
bnemec | So I have no idea why you would use one over the other. :-) | 18:32 |
mriedem | i'm in no rush to change this code in trove, but was just thinking ahead | 18:34 |
mriedem | i've leave the default get_worker_count() to return 1 for now | 18:35 |
mriedem | and we can override later if needed as previously discussed | 18:35 |
*** harlowja has joined #openstack-oslo | 18:38 | |
*** harlowja has quit IRC | 18:38 | |
*** harlowja has joined #openstack-oslo | 18:39 | |
*** harlowja has quit IRC | 18:39 | |
bnemec | mriedem: Yeah, that works for me. | 18:39 |
bnemec | dhellmann: Any objections? ^ | 18:39 |
*** ildikov has joined #openstack-oslo | 18:42 | |
dhellmann | bnemec, mriedem : that makes sense | 18:46 |
SlickNik | mriedem: I don't think that there's was any specific method to choosing those defaults in trove. | 18:50 |
SlickNik | mriedem: I'd be totally fine with changing that if needed — to align with how other OS projects are doing / going to do it | 18:51 |
*** harlowja has joined #openstack-oslo | 18:51 | |
*** harlowja has quit IRC | 18:51 | |
mriedem | SlickNik: they are the same, None and 1 | 18:51 |
mriedem | just sorted that out myself | 18:51 |
mriedem | apparently my eyes weren't working before food | 18:52 |
SlickNik | ah, just saw your link from the other window. :) | 18:52 |
SlickNik | Thanks for the clarification | 18:52 |
*** harlowja has joined #openstack-oslo | 18:52 | |
*** harlowja has quit IRC | 18:52 | |
*** harlowja has joined #openstack-oslo | 18:53 | |
*** mrda-away is now known as mrda | 18:56 | |
*** dims_ has joined #openstack-oslo | 18:57 | |
*** dims has quit IRC | 18:58 | |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Move nova.utils.cpu_count() to service.py module https://review.openstack.org/101978 | 18:58 |
mriedem | bnemec: dhellmann: ^ | 18:59 |
dhellmann | mriedem: thanks, I'll put that in my review queue | 18:59 |
mriedem | thanks | 18:59 |
*** krotscheck has quit IRC | 19:10 | |
*** hyakuhei1_ has quit IRC | 19:10 | |
*** krotscheck has joined #openstack-oslo | 19:27 | |
*** hyakuhei__ has joined #openstack-oslo | 19:27 | |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Move nova.utils.cpu_count() to service.py module https://review.openstack.org/101978 | 19:35 |
*** erecio has quit IRC | 19:37 | |
*** erecio has joined #openstack-oslo | 19:38 | |
zzzeek | dhellmann: do i understand correctly that a test suite, like the one in nova, currently can run tests against SQLite as well as one additional DB (PG or MySQL for example), at most? e.g. sqlite always loads up and then whatever is set under nova.openstack.common.db.options.connection ? | 19:50 |
openstackgerrit | Matt Riedemann proposed a change to openstack/oslo-incubator: Move nova.utils.cpu_count() to service.py module https://review.openstack.org/101978 | 19:51 |
openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Remove unnecessary setUp functions https://review.openstack.org/101990 | 19:54 |
*** ihrachyshka has joined #openstack-oslo | 19:58 | |
openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Remove unnecessary setUp function https://review.openstack.org/101990 | 19:59 |
mriedem | bnemec: ha | 20:03 |
mriedem | i started something | 20:03 |
bnemec | mriedem: Heh, I was trying to figure out how the dep could be outdated when I pushed it five seconds earlier. :-) | 20:04 |
*** markmcclain has quit IRC | 20:06 | |
*** bknudson has quit IRC | 20:10 | |
*** mriedem has quit IRC | 20:10 | |
*** jecarey has quit IRC | 20:10 | |
*** jecarey has joined #openstack-oslo | 20:10 | |
*** bknudson has joined #openstack-oslo | 20:11 | |
*** mriedem has joined #openstack-oslo | 20:11 | |
*** markmcclain has joined #openstack-oslo | 20:13 | |
dhellmann | zzzeek: that sounds like it might be right, but I don't know enough about how those tests work to say for certain | 20:17 |
*** jecarey has quit IRC | 20:36 | |
*** pblaho has quit IRC | 20:44 | |
*** jecarey has joined #openstack-oslo | 20:51 | |
openstackgerrit | Max Lobur proposed a change to openstack/oslo.db: Add __contains__ to ModelBase to fully behave like a dict https://review.openstack.org/102008 | 20:53 |
*** dims__ has joined #openstack-oslo | 20:54 | |
*** dims__ has quit IRC | 20:55 | |
*** dims__ has joined #openstack-oslo | 20:56 | |
*** dims_ has quit IRC | 20:57 | |
*** ajo|mac has joined #openstack-oslo | 20:59 | |
*** markmcclain has quit IRC | 20:59 | |
*** erecio has quit IRC | 21:00 | |
*** markmcclain has joined #openstack-oslo | 21:01 | |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H904 https://review.openstack.org/101701 | 21:02 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H803, it's mostly an old flamewar https://review.openstack.org/101498 | 21:02 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H305 because it's python version specific https://review.openstack.org/101499 | 21:02 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H402 https://review.openstack.org/101497 | 21:02 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: add hacking preamble https://review.openstack.org/102014 | 21:02 |
*** SridharG has quit IRC | 21:03 | |
*** ihrachyshka has quit IRC | 21:39 | |
*** ihrachyshka has joined #openstack-oslo | 21:39 | |
openstackgerrit | gordon chung proposed a change to openstack/oslo-incubator: mark middlware module as graduating https://review.openstack.org/102022 | 21:41 |
*** lbragstad has quit IRC | 21:53 | |
*** markmc has quit IRC | 21:54 | |
*** mriedem has left #openstack-oslo | 22:01 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.i18n: Add links to policy discussions https://review.openstack.org/102028 | 22:03 |
*** dstanek is now known as dstanek_zzz | 22:07 | |
*** markmcclain has quit IRC | 22:08 | |
*** bknudson has quit IRC | 22:10 | |
*** dstanek_zzz is now known as dstanek | 22:16 | |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H904 https://review.openstack.org/101701 | 22:18 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H803, it's mostly an old flamewar https://review.openstack.org/101498 | 22:18 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: add hacking preamble https://review.openstack.org/102014 | 22:18 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H305 because it's python version specific https://review.openstack.org/101499 | 22:18 |
openstackgerrit | Sean Dague proposed a change to openstack-dev/hacking: remove H402 https://review.openstack.org/101497 | 22:18 |
bnemec | Sigh. I just noticed a minor typo in the preamble change after he just pushed a new version to address my previous nit. :-( | 22:23 |
*** ajo|mac has quit IRC | 22:46 | |
openstackgerrit | pritesh proposed a change to openstack-dev/hacking: Add hacking check for vim configuration in source files https://review.openstack.org/101969 | 22:48 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Improve WBE testing coverage https://review.openstack.org/101717 | 22:48 |
*** ihrachyshka has quit IRC | 22:48 | |
*** dstanek is now known as dstanek_zzz | 22:50 | |
*** ajo|mac has joined #openstack-oslo | 22:53 | |
openstackgerrit | Michael H Wilson proposed a change to openstack/oslo.messaging: Add first unit test for 0MQ https://review.openstack.org/93905 | 22:56 |
openstackgerrit | Michael H Wilson proposed a change to openstack/oslo.messaging: WIP Transport URL test case https://review.openstack.org/102047 | 22:56 |
*** ajo|mac has quit IRC | 23:06 | |
*** ajo|mac has joined #openstack-oslo | 23:07 | |
*** markmcclain has joined #openstack-oslo | 23:12 | |
*** morganfainberg_L has joined #openstack-oslo | 23:12 | |
*** morganfainberg has quit IRC | 23:12 | |
*** morganfainberg_Z is now known as morganfainberg | 23:12 | |
*** markmcclain1 has joined #openstack-oslo | 23:13 | |
harlowja | dhellmann u get anytime to look over https://review.openstack.org/#/c/100048/ yet? | 23:13 |
*** markmcclain has quit IRC | 23:17 | |
*** tsekiyam_ has joined #openstack-oslo | 23:17 | |
*** tsekiyama has quit IRC | 23:21 | |
*** tsekiyam_ has quit IRC | 23:21 | |
*** morganfainberg_L is now known as mdrnstm | 23:21 | |
*** mdrnstm has quit IRC | 23:22 | |
*** mdrnstm has joined #openstack-oslo | 23:22 | |
*** morganfainberg has quit IRC | 23:22 | |
*** mdrnstm is now known as morganfainberg | 23:22 | |
*** morganfainberg_Z has joined #openstack-oslo | 23:22 | |
*** ajo|mac has quit IRC | 23:35 | |
*** ajo|mac_ has joined #openstack-oslo | 23:35 | |
*** oomichi has joined #openstack-oslo | 23:42 | |
*** arnaud__ has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!