| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: - implement exception compatibility layer - work up a system of filters to replace imperative exception handling logic with declarative logic - fully move all exception reraises to be rules https://review.openstack.org/105307 | 00:00 |
|---|---|---|
| zzzeek | OK, this is my first big change + blueprint + everything, I probably screwed some things up | 00:00 |
| *** yamahata has quit IRC | 00:05 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a redis backed job/jobboard https://review.openstack.org/105298 | 00:06 |
| harlowja | zzzeek something i refer newbs to, https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure | 00:07 |
| harlowja | just as a start :) | 00:07 |
| harlowja | some people are more strict about this | 00:07 |
| zzzeek | oh i put my own style of commit messages into my thing…. ? checking | 00:08 |
| harlowja | and might ding u for the first line | 00:08 |
| zzzeek | ill amend that | 00:08 |
| harlowja | cool | 00:08 |
| zzzeek | it looks like my patch is already off from what master is, how is that going to pop up, jenkins build ? | 00:08 |
| harlowja | zzzeek ya | 00:09 |
| zzzeek | ok | 00:09 |
| harlowja | http://status.openstack.org/zuul/ will run your stuff | 00:09 |
| harlowja | if u want to watch that | 00:09 |
| harlowja | https://github.com/harlowja/gerrit_view#czuul is much better (actually its pretty much the same, just a terminal view i made) | 00:09 |
| harlowja | http://pypi.python.org/pypi/gerrit-view (u can selective pick out a project like --project "openstack/oslo.db" | 00:10 |
| harlowja | if u want to watch whats happening | 00:10 |
| harlowja | http://docs.openstack.org/infra/publications/zuul/#%281%29 is neat to look over to understand the full thing | 00:11 |
| harlowja | *well actually probably only a few people understand the full thing, ha | 00:12 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Implement exception interception and filtering layer https://review.openstack.org/105307 | 00:14 |
| harlowja | boris-42 u might want to check ^ out since i think u did alot of that exception stuff | 00:14 |
| zzzeek | OK who wants to review | 00:15 |
| zzzeek | i redid the commit message. I know how to put up patches, the blueprint part is new to me. | 00:15 |
| harlowja | :) | 00:15 |
| harlowja | another thing that will happen, is the the flake8 checks will run, and this runs some specific ones that openstack has that i think your patch will fail on | 00:16 |
| harlowja | http://docs.openstack.org/developer/hacking/#imports ; so just something to be aware of | 00:16 |
| zzzeek | harlowja: what line | 00:17 |
| harlowja | handle_error.py ? | 00:17 |
| zzzeek | oh this chemy import event, exc as sqla_exc | 00:17 |
| zzzeek | k | 00:17 |
| harlowja | zzzeek and they like to group things | 00:17 |
| harlowja | http://docs.openstack.org/developer/hacking/#import-order-template | 00:18 |
| harlowja | and it will actually check this | 00:18 |
| harlowja | and barf if it isn't likeing it | 00:18 |
| zzzeek | okey doke | 00:18 |
| zzzeek | this is a review so just review it ! :) | 00:18 |
| harlowja | lol | 00:18 |
| harlowja | ya ya | 00:18 |
| harlowja | i'll do that, gotta go explain what asyncio and stuff is to a coworker | 00:19 |
| harlowja | but after that :-P | 00:19 |
| zzzeek | who should review the blueprint | 00:19 |
| *** joesavak has joined #openstack-oslo | 00:26 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:26 | |
| *** jsavak has joined #openstack-oslo | 00:27 | |
| *** tsekiya__ has joined #openstack-oslo | 00:28 | |
| *** tsekiyama has quit IRC | 00:30 | |
| *** joesavak has quit IRC | 00:31 | |
| *** tsekiyam_ has quit IRC | 00:32 | |
| *** jsavak has quit IRC | 00:41 | |
| *** zzzeek has quit IRC | 00:41 | |
| *** zzzeek has joined #openstack-oslo | 00:53 | |
| *** yamahata has joined #openstack-oslo | 00:55 | |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Fix wrong usage of assertRaises https://review.openstack.org/105077 | 00:56 |
| *** liusheng has quit IRC | 01:02 | |
| *** tsekiya__ has quit IRC | 01:07 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo-specs: Add use-events-for-error-wrapping https://review.openstack.org/105306 | 01:09 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Implement exception interception and filtering layer https://review.openstack.org/105307 | 01:17 |
| harlowja | zzzeek i think boris-42 likely is a good candiate, any others that have worked on oslo.db | 01:18 |
| zzzeek | yup | 01:18 |
| zzzeek | i have a lot of work getting all the pep8 stuff fixed :) | 01:18 |
| zzzeek | oddly, i have flake8 turned on here.... | 01:18 |
| zzzeek | id love to get this stuff happening when i get a PR but bitbucket doesnt have much of a PR api yet | 01:19 |
| harlowja | :) good ole pep8, ha | 01:20 |
| zzzeek | well imports in alphabetical order isnt exaclty pep8 i think | 01:20 |
| harlowja | ya, its openstack special | 01:22 |
| harlowja | special sauce | 01:22 |
| zzzeek | ok so, ordering is like: | 01:26 |
| zzzeek | from oslo.db.openstack.common.gettextutils import _LW | 01:26 |
| zzzeek | from oslo.db.openstack.common import timeutils | 01:26 |
| zzzeek | from oslo.db import options | 01:27 |
| zzzeek | meaning, take all the tokens together despite the word “import” ? | 01:27 |
| zzzeek | i think this was like this | 01:27 |
| zzzeek | yeah im getting pep8 failures for other code hre | 01:27 |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Implement exception interception and filtering layer https://review.openstack.org/105307 | 01:28 |
| harlowja | zzzeek :) | 01:30 |
| harlowja | zzzeek u can download https://review.openstack.org/#/c/68988/ if u want | 01:30 |
| zzzeek | id have to figure out how to run their pep8-er on just my diff | 01:30 |
| harlowja | or examine it if u want | 01:30 |
| harlowja | i could never remember the import order, so i just made a tool, ha | 01:31 |
| zzzeek | yeah, “tools” to fix pep8, what an idea! | 01:31 |
| harlowja | ;) | 01:31 |
| zzzeek | i found this https://github.com/hhatto/autopep8 | 01:31 |
| zzzeek | but of course it makes mistakes | 01:31 |
| harlowja | ya thats the problem with the 'auto' part | 01:31 |
| harlowja | mine never makes mistakes, ha | 01:31 |
| zzzeek | it works pretty well, better than this other one i used to use | 01:31 |
| harlowja | ya, i just made a small tool to fix the import oredering stuffs, | 01:32 |
| *** liusheng has joined #openstack-oslo | 01:32 | |
| harlowja | the way i know remembre to do it is to convert 'from oslo.db.openstack.common.gettextutils import _LW' -> oslo.db.openstack.common.gettextutils._LW for all imports then sort them in your brainnzz | 01:32 |
| zzzeek | i re-uploaded my blueprint to be a little less harsh on the existing code :) | 01:32 |
| harlowja | cool | 01:33 |
| harlowja | another thing that i've made recently zzzeek (u may or may not find it useful) is https://github.com/harlowja/remote_tox | 01:33 |
| harlowja | if u setup a cluster of vms that can act as slaves that thing will send the code to somewhere else (one of those slaves) and run tox there, lol | 01:33 |
| zzzeek | um OK :) | 01:34 |
| zzzeek | want to write a thing for my jenkins to run pep8 when i get a PR :) | 01:34 |
| harlowja | hmmm | 01:34 |
| zzzeek | whos your openstack sponsor co | 01:34 |
| harlowja | move your thing over to stackforge ;) | 01:34 |
| zzzeek | heh | 01:34 |
| harlowja | zzzeek yahoo | 01:34 |
| zzzeek | that would just prove all the “oh theyre just going to take over SQLAlchemy” naysayers correc | 01:35 |
| zzzeek | correct | 01:35 |
| zzzeek | wow yahoo. i have never met yahoo employee | 01:35 |
| harlowja | lol | 01:35 |
| zzzeek | and ive been in this game since ‘95 | 01:35 |
| harlowja | first time for everything | 01:35 |
| zzzeek | when yahoo was the only game in town | 01:35 |
| zzzeek | they were like google | 01:35 |
| zzzeek | wow! the yahoo guys! they are so hooked ! | 01:35 |
| harlowja | ya, back in them olden-days | 01:35 |
| zzzeek | wow now lets go to altavista to search for something! | 01:36 |
| harlowja | def, altavista was my fav | 01:36 |
| zzzeek | ahha you are an olde | 01:36 |
| harlowja | not that much, ha | 01:36 |
| harlowja | medium olde | 01:36 |
| harlowja | not olde olde | 01:36 |
| zzzeek | you were literate in the 90’s olde | 01:37 |
| harlowja | :) | 01:38 |
| harlowja | yes | 01:38 |
| *** joesavak has joined #openstack-oslo | 01:38 | |
| zzzeek | but not, “i saw the original star wars in 77” olde | 01:38 |
| harlowja | right, not that far back :) | 01:38 |
| zzzeek | a long time ago | 01:39 |
| zzzeek | in a decade far far away | 01:39 |
| harlowja | ya, back then when people had to walk to school barefoot | 01:39 |
| zzzeek | we did | 01:39 |
| harlowja | uphill | 01:39 |
| harlowja | both ways uphill | 01:39 |
| harlowja | * which may not seem possible, but it was, ha | 01:39 |
| zzzeek | our town was designed by mc escher | 01:40 |
| harlowja | yup, youngins now got it easy, only 1 way uphill | 01:41 |
| zzzeek | im told kids cant even walk down the street anymore unattended | 01:41 |
| zzzeek | if you leave your kid in the car for 5 minutes you can get arrested or something | 01:41 |
| zzzeek | this is very surprising to me | 01:41 |
| harlowja | ya, i used to live in my car, for days, kids these days | 01:42 |
| harlowja | can't even handle 5 minutes | 01:42 |
| harlowja | haha | 01:42 |
| zzzeek | well if you’re younger than star wars age not sure if you recall, the seats were these giant benches and the seatbelts were only in the front | 01:42 |
| zzzeek | and only a crazy person used them | 01:42 |
| harlowja | with horses? | 01:43 |
| zzzeek | yeah | 01:43 |
| zzzeek | and i waited in the car all the time, who cared | 01:43 |
| harlowja | ya, without a/c too, jeez | 01:44 |
| zzzeek | i actually got a download of the star wars movies that I *think* are the 1981 release | 01:44 |
| harlowja | the only a/c u got was the horse flipping its tail | 01:44 |
| zzzeek | so they are largely their old form | 01:44 |
| harlowja | none of that computer crap messing up the movie | 01:46 |
| harlowja | damn computer crap | 01:46 |
| harlowja | lol | 01:46 |
| *** mriedem has quit IRC | 01:55 | |
| *** zzzeek has quit IRC | 01:55 | |
| *** mriedem has joined #openstack-oslo | 02:00 | |
| *** arnaud__ has quit IRC | 02:03 | |
| *** zhiyan_ is now known as zhiyan | 02:08 | |
| *** joesavak has quit IRC | 02:09 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a redis backed job/jobboard https://review.openstack.org/105298 | 02:21 |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-specs: Support policy configuration directories https://review.openstack.org/104157 | 02:43 |
| *** SridharG has joined #openstack-oslo | 02:47 | |
| *** liusheng has quit IRC | 02:51 | |
| *** liusheng has joined #openstack-oslo | 02:53 | |
| *** mriedem has left #openstack-oslo | 02:56 | |
| *** mriedem has quit IRC | 02:57 | |
| *** zzzeek has joined #openstack-oslo | 03:01 | |
| *** dstanek_zzz is now known as dstanek | 03:05 | |
| *** zzzeek has quit IRC | 03:13 | |
| *** SridharG has quit IRC | 03:13 | |
| *** amotoki has joined #openstack-oslo | 03:14 | |
| *** dims has quit IRC | 03:24 | |
| *** arnaud__ has joined #openstack-oslo | 03:30 | |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-specs: Support policy configuration directories https://review.openstack.org/104157 | 04:21 |
| *** ajc_ has joined #openstack-oslo | 04:25 | |
| openstackgerrit | Adrian Otto proposed a change to openstack-dev/pbr: Switch from pypi.python.org to pypi.orpestack.org https://review.openstack.org/105344 | 04:27 |
| *** praneshp has quit IRC | 04:43 | |
| *** SridharG has joined #openstack-oslo | 04:45 | |
| *** dstanek is now known as dstanek_zzz | 04:55 | |
| *** dims has joined #openstack-oslo | 04:58 | |
| *** dims has quit IRC | 05:02 | |
| *** praneshp_ has joined #openstack-oslo | 05:11 | |
| *** dstanek_zzz is now known as dstanek | 05:29 | |
| *** ildikov has joined #openstack-oslo | 05:30 | |
| *** harlowja is now known as harlowja_away | 05:42 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a redis backed job/jobboard https://review.openstack.org/105298 | 05:54 |
| *** dstanek is now known as dstanek_zzz | 05:55 | |
| *** dims has joined #openstack-oslo | 05:58 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/oslo-specs: Add a redis backed job/jobboard https://review.openstack.org/105298 | 05:59 |
| *** dims has quit IRC | 06:03 | |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-incubator: [WIP] Add support for policy configration directories https://review.openstack.org/105362 | 06:08 |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-specs: Support policy configuration directories https://review.openstack.org/104157 | 06:13 |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-incubator: [WIP] Add support for policy configration directories https://review.openstack.org/105362 | 06:14 |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-incubator: [WIP] Add support for policy configration directories https://review.openstack.org/105362 | 06:44 |
| *** nacim has quit IRC | 06:51 | |
| *** AAzza_afk is now known as AAzza | 06:53 | |
| *** dims_ has joined #openstack-oslo | 06:59 | |
| *** dims_ has quit IRC | 07:04 | |
| *** pcm_ has quit IRC | 07:05 | |
| *** pcm_ has joined #openstack-oslo | 07:06 | |
| *** HenryG has quit IRC | 07:07 | |
| *** tkelsey has joined #openstack-oslo | 07:18 | |
| *** rmcall has quit IRC | 07:19 | |
| *** rmcall has joined #openstack-oslo | 07:20 | |
| *** AAzza is now known as AAzza_afk | 07:23 | |
| *** pblaho has joined #openstack-oslo | 07:23 | |
| *** praneshp has joined #openstack-oslo | 07:27 | |
| *** praneshp_ has quit IRC | 07:29 | |
| *** rdopieralski has joined #openstack-oslo | 07:38 | |
| *** markmc has joined #openstack-oslo | 07:40 | |
| *** ihrachyshka has joined #openstack-oslo | 07:48 | |
| *** nacim has joined #openstack-oslo | 08:00 | |
| *** flaper87|afk is now known as flaper87 | 08:06 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Add a base test case for DB schema comparison https://review.openstack.org/93398 | 08:14 |
| boris-42 | markmc hi, sorry for 100500 pings but | 08:22 |
| boris-42 | markmc could you pls at least say when I can expect review for my spec, e.g. in 2-3 weeks (and I won't ping you these 3 weeks) | 08:22 |
| boris-42 | markmc thanks | 08:23 |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-incubator: [WIP] Add support for policy configration directories https://review.openstack.org/105362 | 08:23 |
| *** ildikov has quit IRC | 08:23 | |
| *** dims has joined #openstack-oslo | 08:28 | |
| *** dims has quit IRC | 08:33 | |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-incubator: [WIP] Add support for policy configration directories https://review.openstack.org/105362 | 08:35 |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/oslo.db: Implementation Alembic as migration engine https://review.openstack.org/99965 | 08:38 |
| *** dstanek_zzz is now known as dstanek | 08:40 | |
| openstackgerrit | Alex Xu proposed a change to openstack/oslo-incubator: [WIP] Add support for policy configration directories https://review.openstack.org/105362 | 08:52 |
| *** stannie has joined #openstack-oslo | 09:04 | |
| *** HenryG has joined #openstack-oslo | 09:05 | |
| *** dstanek is now known as dstanek_zzz | 09:05 | |
| *** arnaud__ has quit IRC | 09:09 | |
| *** tsufiev has joined #openstack-oslo | 09:18 | |
| tsufiev | hi there! how do you run unit tests in oslo incubator? | 09:19 |
| tsufiev | i've some some weird error during running them with tox: http://paste.openstack.org/show/85642/ | 09:19 |
| *** ajc_ has quit IRC | 09:20 | |
| tsufiev | does anyone know what to do with it? | 09:21 |
| *** i159 has joined #openstack-oslo | 09:22 | |
| *** dims has joined #openstack-oslo | 09:29 | |
| *** ildikov has joined #openstack-oslo | 09:30 | |
| *** dims has quit IRC | 09:33 | |
| therve | tsufiev, It's not super weird :). mysql_config is not found, you should install the package providing it | 09:33 |
| tsufiev | therve, there are not so many mysql_config packages in pip index :-/ | 09:35 |
| tsufiev | timur@tsufiev-pc:~/develop/oslo-incubator$ pip search mysql|grep config -> opengever.mysqlconfig - configures the mysql as database engine | 09:35 |
| tsufiev | is that one i should use? | 09:36 |
| therve | No it's not a python package, it's a mysql package | 09:36 |
| therve | Typically libmysqlclient-dev | 09:37 |
| *** praneshp has quit IRC | 09:42 | |
| tsufiev | therve, thank you, it was that package indeed :) | 09:43 |
| *** alexpilotti has joined #openstack-oslo | 10:00 | |
| *** yamahata has quit IRC | 10:02 | |
| *** oomichi has quit IRC | 10:04 | |
| *** viktors|afk has quit IRC | 10:13 | |
| *** alexpilotti has joined #openstack-oslo | 10:37 | |
| *** zhiyan is now known as zhiyan_ | 10:46 | |
| *** zhiyan_ is now known as zhiyan | 10:47 | |
| *** nacim has quit IRC | 10:53 | |
| *** AAzza_afk is now known as AAzza | 11:01 | |
| *** dims_ has joined #openstack-oslo | 11:02 | |
| openstackgerrit | Timur Sufiev proposed a change to openstack/oslo-incubator: Enhance versionutils.deprecated to work with classes https://review.openstack.org/104916 | 11:04 |
| openstackgerrit | garyk proposed a change to openstack/oslo.vmware: Add support for using extensions https://review.openstack.org/100911 | 11:05 |
| rdopieralski | anybody familiar with oslo.messaging? | 11:06 |
| rdopieralski | I'd like to ask for some advice -- whether it would make sense to try and make a websocket transport for it. | 11:08 |
| *** AAzza is now known as AAzza_afk | 11:16 | |
| *** ihrachyshka has quit IRC | 11:23 | |
| *** ihrachyshka has joined #openstack-oslo | 11:26 | |
| openstackgerrit | Timur Sufiev proposed a change to openstack/oslo-incubator: Enhance versionutils.deprecated to work with classes https://review.openstack.org/104916 | 11:31 |
| openstackgerrit | A change was merged to openstack/oslo-specs: Add rootwrap-daemon-mode blueprint https://review.openstack.org/94613 | 11:40 |
| YorikSar | dhellmann: Good morning. Thanks a lot :) | 11:43 |
| dhellmann | YorikSar: I'm not sure the milestone or priority are right for the bp, so update those if you feel they should be. | 11:44 |
| *** dstanek_zzz is now known as dstanek | 11:45 | |
| YorikSar | dhellmann: I can't change the priority (and not sure if it's necessary), milestone is fine. | 11:46 |
| dhellmann | YorikSar: ok, I can change it for you if you want | 11:46 |
| YorikSar | dhellmann: Since I have code almost finished anyway, priority should not be a problem. So Low is fine for me | 11:47 |
| dhellmann | YorikSar: ok | 11:48 |
| openstackgerrit | A change was merged to openstack/oslo-specs: Add basic support for conditional execution https://review.openstack.org/98946 | 11:50 |
| *** SridharG has quit IRC | 12:00 | |
| *** markmcclain has joined #openstack-oslo | 12:11 | |
| *** markmcclain1 has joined #openstack-oslo | 12:13 | |
| *** markmcclain has quit IRC | 12:16 | |
| boris-42 | dhellmann markmc so guys could you provide some opinion about my spec https://review.openstack.org/#/c/103825/ | 12:18 |
| boris-42 | dhellmann markmc I really don't see any super big reason to block this... | 12:18 |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon https://review.openstack.org/81798 | 12:23 |
| *** viktors has joined #openstack-oslo | 12:24 | |
| *** dims_ has quit IRC | 12:26 | |
| *** dims_ has joined #openstack-oslo | 12:26 | |
| *** dims_ has quit IRC | 12:27 | |
| *** dims_ has joined #openstack-oslo | 12:28 | |
| *** nacim has joined #openstack-oslo | 12:30 | |
| *** morganfainberg is now known as morganfainberg_Z | 12:46 | |
| ihrachyshka | gus: around? I have a question re oslo.db | 12:46 |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.rootwrap: Add an option to run rootwrap as a daemon https://review.openstack.org/81798 | 12:54 |
| *** dstanek is now known as dstanek_zzz | 12:55 | |
| *** pblaho_ has joined #openstack-oslo | 13:04 | |
| *** pblaho has quit IRC | 13:04 | |
| *** markmcclain1 has quit IRC | 13:06 | |
| viktors | pblaho_: around? | 13:09 |
| pblaho_ | viktors: meeting... will you have time later? | 13:09 |
| viktors | pblaho_: sure | 13:10 |
| pblaho_ | viktors: thnx | 13:10 |
| *** bknudson has joined #openstack-oslo | 13:13 | |
| *** mriedem has joined #openstack-oslo | 13:13 | |
| *** pcm_ has quit IRC | 13:17 | |
| *** HenryG has quit IRC | 13:17 | |
| *** zzzeek has joined #openstack-oslo | 13:20 | |
| *** jecarey has quit IRC | 13:23 | |
| *** zzzeek has quit IRC | 13:34 | |
| openstackgerrit | Tom Cammann proposed a change to openstack/oslo.config: Check config default value is correct type https://review.openstack.org/105450 | 13:38 |
| viktors | bnemec: around? | 13:39 |
| openstackgerrit | Valeriy Ponomaryov proposed a change to openstack/oslo-incubator: Fix exception message in openstack.common.processutils.execute https://review.openstack.org/105452 | 13:42 |
| openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Refactor the PBM support https://review.openstack.org/102480 | 13:42 |
| *** SridharG has joined #openstack-oslo | 13:47 | |
| bnemec | viktors: For a bit | 13:55 |
| *** pblaho_ has quit IRC | 13:59 | |
| *** jecarey has joined #openstack-oslo | 14:01 | |
| openstackgerrit | Tom Cammann proposed a change to openstack/oslo.config: Check config default value is correct type https://review.openstack.org/105450 | 14:02 |
| *** pblaho_ has joined #openstack-oslo | 14:03 | |
| *** pblaho_ is now known as pblaho | 14:05 | |
| pblaho | viktors: I am here and available | 14:05 |
| *** rdopieralski has quit IRC | 14:05 | |
| viktors | pblaho: I have a question as for your patch https://review.openstack.org/#/c/99670/ (Changes import orders to pass H305 check) | 14:06 |
| viktors | is it still in WIP state? | 14:06 |
| *** jaosorior has joined #openstack-oslo | 14:07 | |
| pblaho | viktors: I am not sure about how hacking discussion ended.... | 14:08 |
| pblaho | viktors: I will check and decide | 14:08 |
| viktors | pblaho: I found,that patch https://review.openstack.org/#/c/100231/ (revert hacking to 0.8 series) was abandoned, so we can move on | 14:10 |
| viktors | pblaho: ok, thanks | 14:10 |
| pblaho | viktors: yeah, just found it too | 14:10 |
| *** flaper87 is now known as flaper87|afk | 14:11 | |
| pblaho | viktors: ok... I will change that patch to previous version as rpodolyaka suggested .. it looks more reasonable to me to let that imports be inside of function | 14:12 |
| viktors | pblaho: ok | 14:12 |
| *** dstanek_zzz is now known as dstanek | 14:13 | |
| *** pcm_ has joined #openstack-oslo | 14:14 | |
| *** pcm__ has joined #openstack-oslo | 14:16 | |
| *** pcm_ has quit IRC | 14:20 | |
| *** flaper87|afk is now known as flaper87 | 14:34 | |
| ihrachyshka | dhellmann: hey. I need to pass some options to underneath sql driver (specifically, raise_on_warnings=False). I may add those options to connection string, but I think it should be default for the driver I attempt to use. Is there a place in oslo.db to put default values for those options? | 14:35 |
| boris-42 | ihrachyshka hi | 14:42 |
| boris-42 | ihrachyshka probably you face something like this http://paste.openstack.org/show/85680/ | 14:42 |
| boris-42 | ihrachyshka it's from keystone when it tries to send any notification | 14:42 |
| *** ihrachyshka has quit IRC | 14:43 | |
| *** pcm__ has quit IRC | 14:46 | |
| *** james_li has joined #openstack-oslo | 14:51 | |
| *** alexpilotti has quit IRC | 14:55 | |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Changes import orders to pass H305 check https://review.openstack.org/99670 | 14:56 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes whitespaces between imports to pass H307 https://review.openstack.org/99671 | 14:56 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes comments to pass E265 check. https://review.openstack.org/99676 | 14:56 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Uses keyword params for i18n string to pass H703 https://review.openstack.org/99674 | 14:56 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes indentations to pass E128 check. https://review.openstack.org/99675 | 14:56 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Updates one line docstring with dot to pass H402 https://review.openstack.org/99672 | 14:56 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Adds empty line to multilines docs to pass H405 https://review.openstack.org/99673 | 14:56 |
| openstackgerrit | A change was merged to openstack/oslo.messaging: Replaced 'e.g.' with 'for example' https://review.openstack.org/105028 | 14:59 |
| *** ildikov has quit IRC | 14:59 | |
| *** zhiyan is now known as zhiyan_ | 15:00 | |
| *** mriedem1 has joined #openstack-oslo | 15:01 | |
| pblaho | do anyone has idea what bug I should recheck this https://review.openstack.org/#/c/99639/ with? | 15:02 |
| *** mriedem has quit IRC | 15:02 | |
| *** ildikov has joined #openstack-oslo | 15:02 | |
| openstackgerrit | mouad benchchaoui proposed a change to openstack/oslo.messaging: Fix reconnect race condition with RabbitMQ cluster https://review.openstack.org/103157 | 15:09 |
| openstackgerrit | A change was merged to openstack/oslo.config: Replaced 'e.g.' with 'for example' https://review.openstack.org/105086 | 15:09 |
| *** tkelsey has quit IRC | 15:19 | |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes comments to pass E265 check. https://review.openstack.org/99676 | 15:24 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Uses keyword params for i18n string to pass H703 https://review.openstack.org/99674 | 15:24 |
| openstackgerrit | Petr Blaho proposed a change to openstack/oslo.db: Fixes indentations to pass E128 check. https://review.openstack.org/99675 | 15:24 |
| *** AAzza_afk is now known as AAzza | 15:25 | |
| viktors | bnemec: ping | 15:27 |
| *** zzzeek has joined #openstack-oslo | 15:30 | |
| bnemec | viktors: ack | 15:32 |
| viktors | bnemec: hi! I want to ask you to look at patch, which compares SQLA models definitions with actual DB state - https://review.openstack.org/#/c/93398/ | 15:34 |
| viktors | bnemec: does i159 fixed your notes? | 15:35 |
| bnemec | viktors: looking | 15:35 |
| *** bknudson has quit IRC | 15:38 | |
| bnemec | viktors: Yeah, looks like all of the comments were addressed. | 15:38 |
| viktors | bnemec: thank you! | 15:40 |
| viktors | bnemec: this was a long running patch :) | 15:40 |
| bnemec | viktors: Yeah | 15:40 |
| bnemec | Definitely a \o/ moment :-) | 15:40 |
| viktors | bnemec: I want to improve this feature in OS projects, but I'm not really sure, when should we release oslo.db | 15:42 |
| viktors | maybe dhellmann knows :) | 15:43 |
| bnemec | Yeah, he's the release guru. :-) | 15:43 |
| viktors | :) | 15:43 |
| bnemec | I don't see any reason not to release oslo.db with this added though. It's a significant enough change and we need a release to start using it. | 15:43 |
| viktors | agreed | 15:44 |
| dhellmann | viktors, bnemec : yes, you can release a new alpha with that change. I think the ironic team at least is waiting for that, aren't they? | 15:45 |
| dhellmann | maybe that's not the patch they're waiting for | 15:45 |
| viktors | dhellmann: they wait also one more chain - https://review.openstack.org/#/c/93424/ (Opportunistic migration tests) | 15:46 |
| *** tsekiyama has joined #openstack-oslo | 15:46 | |
| viktors | so reviewers are welcomed :) | 15:46 |
| * bnemec is reviewing CSS changes again | 15:46 | |
| * bnemec wonders what he did wrong in a past life to deserve this ;-) | 15:46 | |
| dhellmann | bnemec: maybe we should find some folks on the horizon ui team to look at that stuff? :-) | 15:47 |
| bnemec | dhellmann: Probably. :-) | 15:47 |
| viktors | dhellmann: should I send a email to `-dev` mail list about the new oslo.db release? | 15:49 |
| dhellmann | viktors: yes, for each release we need to announce the version and what has changed | 15:50 |
| dhellmann | viktors: I've been using the same basic outline in the messages I've sent for releases, and you could use one of those as an example | 15:51 |
| viktors | dhellmann: ok, thanks, will do. | 15:51 |
| dhellmann | viktors: did we get you set up with a gpg key for signing the release tags? | 15:51 |
| viktors | dhellmann: yes | 15:51 |
| dhellmann | ok, good | 15:51 |
| openstackgerrit | A change was merged to openstack/oslosphinx: Fixed link text colour for incubation variant https://review.openstack.org/105233 | 15:51 |
| dhellmann | viktors: oh, I said "alpha" release before but you're doing non-alpha releases 0.x for oslo.db, right? | 15:52 |
| viktors | dhellmann: I suppose to make a new release tomorrow morning, if we don't have any timestamps for it | 15:52 |
| viktors | dhellmann: 0.3.0 I suppose | 15:52 |
| dhellmann | yes | 15:52 |
| dhellmann | do you have an etherpad with the release notes in it, like for the other libs? | 15:52 |
| dhellmann | for example: https://etherpad.openstack.org/p/oslo-i18n-1.0.0 | 15:52 |
| dhellmann | viktors: you can use https://etherpad.openstack.org/p/oslo-db-1.0.0 | 15:53 |
| viktors | dhellmann: ok, wikk do | 15:53 |
| viktors | *will | 15:53 |
| dhellmann | viktors: ok, thanks | 15:53 |
| viktors | dhellmann: so just to clarify - tomorrow is ok for new release? | 15:54 |
| dhellmann | viktors: yes, that's fine. I try not to release new libraries on fridays because I don't want to have to deal with anything that breaks with the release over a weekend. So I have been trying to make releases on Monday or Tuesday morning in my time zone. | 15:56 |
| *** praneshp has joined #openstack-oslo | 15:57 | |
| viktors | dhellmann: ok, thanks a lot! | 15:57 |
| dhellmann | viktors: thank *you* for doing the hard work :-) | 15:57 |
| *** viktors is now known as viktors|afk | 16:00 | |
| *** praneshp has quit IRC | 16:03 | |
| *** praneshp has joined #openstack-oslo | 16:10 | |
| *** pblaho has quit IRC | 16:12 | |
| *** ildikov has quit IRC | 16:22 | |
| openstackgerrit | Tom Cammann proposed a change to openstack/oslo.config: Check config default value is correct type https://review.openstack.org/105450 | 16:24 |
| *** alexpilotti has joined #openstack-oslo | 16:26 | |
| *** alexpilotti has quit IRC | 16:32 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Add release notes for 1.4.0.0a2/a3 https://review.openstack.org/105515 | 16:32 |
| openstackgerrit | A change was merged to openstack/oslo.db: Add a base test case for DB schema comparison https://review.openstack.org/93398 | 16:34 |
| zzzeek | OK so. when i want oslo.db tests to hit MySQL, I just make a MySQL schema with that magic name / username ? | 16:35 |
| i159 | zzzeek: are you talking about `openstack_citest` magic url? | 16:37 |
| zzzeek | yes | 16:37 |
| i159 | Yes, CI has databases and users with this names in both of Postgres and MySQL | 16:38 |
| i159 | zzzeek: Yes, CI has databases and users with this names in both of Postgres and MySQL | 16:38 |
| zzzeek | the “skip” in the test suite is jst looking for that URL right | 16:38 |
| zzzeek | yeah | 16:40 |
| i159 | zzzeek: yes, we assume that a user can don't have this database on local machine | 16:40 |
| zzzeek | nm i got it | 16:40 |
| zzzeek | the code has been cleaned up recently :) | 16:40 |
| i159 | zzzeek: great! And note, that `openstack_citest` user is superuser and it can create and dop new databases | 16:41 |
| zzzeek | i159: any reason that utils.is_backend_avail() doesnt accept jut a striaght SQLAlchemy URL ? | 16:41 |
| zzzeek | Id like to support an option like “export OSLODB_TEST_URL=postgresql://foo:bar@host/test; tox -e py27” | 16:42 |
| i159 | zzzeek: maybe I didn't got your message, but something very similar is implemented now | 16:43 |
| openstackgerrit | A change was merged to openstack/oslo-incubator: Fix exception message in openstack.common.processutils.execute https://review.openstack.org/105452 | 16:44 |
| i159 | zzzeek: please see this module https://github.com/openstack/oslo.db/blob/master/oslo/db/sqlalchemy/provision.py#L143 | 16:44 |
| *** arnaud__ has joined #openstack-oslo | 16:44 | |
| zzzeek | i159: OK but in OpportunisticFixture, we are fixed: DBNAME = PASSWORD = USERNAME = 'openstack_citest' | 16:45 |
| zzzeek | i159: i will propose somethign ilke thijs: export OSLODB_OPPORTUNISTIC_DBS=“postgreql://foo:bar@host/test mysql://foo:bar@host/test oracle://dsn” | 16:46 |
| zzzeek | i159: OpportunisticFixture will gather these up and do the right thing | 16:46 |
| zzzeek | i159: not to mention that the host here is hardcoded to “localhost" | 16:47 |
| i159 | zzzeek: yes, because CI has it. Every test run in its temporary database, citest credentials is just an entry point | 16:48 |
| zzzeek | i159: OK, I am not proposing any change to any of that. I am proposing, making the test suite more flexible when it is run in other places, like, my workstation, or, in some environemnt testing special database backends that arent on localhost, or tests that can run against any backend, or tests that dont use hostname in the URL | 16:49 |
| *** mkoderer has quit IRC | 16:52 | |
| i159 | zzzeek: I think you can customize your own OS_TEST_DBAPI_ADMIN_CONNECTION in your environment. I can't see how should we change existing code to provide this possibility, and I can't see any reason to implement it, because it looks to me like very personal customization. But you can discuss it with rpodolyaka and viktors. | 16:54 |
| zzzeek | i159: what if i want to write a test that runs against oracle? | 16:54 |
| zzzeek | i159: not possible. Oracle doesnt have “localhost” in its URL. | 16:54 |
| zzzeek | i159: is that a reason ? | 16:54 |
| i159 | zzzeek: I think it will be difficult. I may be wrong, but I don't remember any places in our code with Oracle support. But the reason really good =) | 16:56 |
| zzzeek | i159: it is super easy. just need to open this stuff up. dont worry ill do it :) | 16:56 |
| i159 | zzzeek: Ok, great : ) | 16:57 |
| zzzeek | i159: keep in mind, SQLAlchemy’s test suite runs against *any* backend, it exports test suites that are run by 3rd party drivers, it can run tests repeatedly against many DBAPIs / drivers at the same time, it does many many things in this regard that are way beyond what oslo.db needs | 16:57 |
| zzzeek | i159: so…I konw how to do it :) | 16:58 |
| i159 | zzzeek: Cool! I'm interested in review, keep me in, please. | 16:59 |
| *** flaper87 is now known as flaper87|afk | 17:00 | |
| zzzeek | i159: i think also the “create a schema for every test” thing might not be viable on some systems. if we are doing DB-connected tests with this thing, we should be able to hit systems like DB2 and similar where creating new DBs might not be viable. it might have to be able to run in different modes. | 17:03 |
| i159 | zzzeek: the author of this approach is rpodolyaka, you should discuss it with him, I'm sure he has iron arguments ; ) | 17:06 |
| zzzeek | i159: i know why it is like this | 17:06 |
| zzzeek | i159: and i think this appraoch is good but i want to open it up some | 17:06 |
| zzzeek | i159: its much easier to read now than it was a few weeks ago in fact | 17:06 |
| *** dstanek is now known as dstanek_zzz | 17:07 | |
| zzzeek | i159: the test system we have here needs to scale out to be used by any project in many different ways | 17:07 |
| i159 | zzzeek: Sounds awesome! I know very little about DB2, Oracle, so I'll follow your changes and help you with it as possible. | 17:09 |
| zzzeek | ive subscribed you | 17:11 |
| *** i159 has quit IRC | 17:13 | |
| *** james_li has quit IRC | 17:23 | |
| *** mriedem has joined #openstack-oslo | 17:25 | |
| *** dstanek_zzz is now known as dstanek | 17:28 | |
| *** mriedem1 has quit IRC | 17:29 | |
| *** harlowja_away is now known as harlowja | 17:29 | |
| *** tmcpeak has joined #openstack-oslo | 17:34 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Implement exception interception and filtering layer https://review.openstack.org/105307 | 17:34 |
| *** dims_ has quit IRC | 17:41 | |
| *** AAzza is now known as AAzza_afk | 17:45 | |
| *** pblaho has joined #openstack-oslo | 17:58 | |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.config: Hook IPOpt class into the docs https://review.openstack.org/105538 | 17:59 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.config: Hook up config fixture docs https://review.openstack.org/105539 | 17:59 |
| openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.config: Add release notes for 1.3.0 and 1.4.0.0a1/2 https://review.openstack.org/105540 | 17:59 |
| *** AAzza_afk is now known as AAzza | 18:03 | |
| *** dims_ has joined #openstack-oslo | 18:08 | |
| *** dims_ has quit IRC | 18:12 | |
| *** tmcpeak has left #openstack-oslo | 18:13 | |
| *** dims_ has joined #openstack-oslo | 18:16 | |
| *** arnaud__ has quit IRC | 18:16 | |
| *** alexpilotti has joined #openstack-oslo | 18:18 | |
| openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Moved main loop to server class https://review.openstack.org/104983 | 18:21 |
| *** mkoderer has joined #openstack-oslo | 18:22 | |
| Alexei_9871 | markmc: Hi please tell me if you have some time to chat | 18:22 |
| *** dstanek is now known as dstanek_zzz | 18:26 | |
| *** james_li has joined #openstack-oslo | 18:33 | |
| *** AAzza is now known as AAzza_afk | 18:37 | |
| *** pblaho has quit IRC | 18:42 | |
| *** markmcclain has joined #openstack-oslo | 18:59 | |
| *** markmcclain1 has joined #openstack-oslo | 19:00 | |
| *** markmcclain has quit IRC | 19:03 | |
| *** arnaud has joined #openstack-oslo | 19:08 | |
| *** dstanek_zzz is now known as dstanek | 19:11 | |
| openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Moved main loop to server class https://review.openstack.org/104983 | 19:15 |
| *** SridharG has quit IRC | 19:25 | |
| *** ildikov has joined #openstack-oslo | 19:28 | |
| *** arnaud has quit IRC | 19:32 | |
| *** markmcclain has joined #openstack-oslo | 19:36 | |
| *** markmcclain1 has quit IRC | 19:37 | |
| *** dstanek is now known as dstanek_zzz | 19:38 | |
| james_li | Hi All, can someone look at this new bug https://bugs.launchpad.net/oslo.messaging/+bug/1339285 ? | 19:42 |
| *** jecarey has quit IRC | 19:49 | |
| *** james_li has quit IRC | 20:05 | |
| *** james_li has joined #openstack-oslo | 20:15 | |
| *** jecarey has joined #openstack-oslo | 20:16 | |
| *** dstanek_zzz is now known as dstanek | 20:24 | |
| *** arnaud has joined #openstack-oslo | 20:27 | |
| *** arnaud__ has joined #openstack-oslo | 20:27 | |
| *** jecarey has quit IRC | 20:33 | |
| *** mkoderer has quit IRC | 20:42 | |
| openstackgerrit | A change was merged to openstack/oslo.messaging: Add release notes for 1.4.0.0a2/a3 https://review.openstack.org/105515 | 20:52 |
| *** james_li has quit IRC | 21:04 | |
| *** AAzza_afk is now known as AAzza | 21:05 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Implement exception interception and filtering layer https://review.openstack.org/105307 | 21:05 |
| *** markmcclain has quit IRC | 21:07 | |
| *** markmc has quit IRC | 21:12 | |
| *** markmc has joined #openstack-oslo | 21:12 | |
| *** AAzza is now known as AAzza_afk | 21:13 | |
| *** arnaud__ has quit IRC | 21:15 | |
| *** arnaud has quit IRC | 21:15 | |
| *** markmc has quit IRC | 21:16 | |
| *** arnaud has joined #openstack-oslo | 21:29 | |
| *** tmcpeak has joined #openstack-oslo | 21:34 | |
| openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Moved main loop to server class https://review.openstack.org/104983 | 21:37 |
| *** stannie has quit IRC | 21:40 | |
| *** mriedem has left #openstack-oslo | 21:50 | |
| *** mriedem has quit IRC | 21:50 | |
| *** arnaud has quit IRC | 21:50 | |
| *** dstanek is now known as dstanek_zzz | 21:51 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a timing listener that also prints the results https://review.openstack.org/105604 | 21:54 |
| *** dims__ has joined #openstack-oslo | 21:55 | |
| *** dims_ has quit IRC | 21:56 | |
| *** tmcpeak has left #openstack-oslo | 21:57 | |
| *** dstanek_zzz is now known as dstanek | 23:20 | |
| *** alexpilotti has quit IRC | 23:35 | |
| *** dstanek is now known as dstanek_zzz | 23:38 | |
| openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Implement exception interception and filtering layer https://review.openstack.org/105307 | 23:39 |
| openstackgerrit | James E. Blair proposed a change to openstack/pycadf: Remove docutils pin https://review.openstack.org/105626 | 23:42 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Avoid comparison to active qsize when spawning new green workers https://review.openstack.org/105633 | 23:52 |
| boris-42 | zzzeek around? | 23:58 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Avoid comparison to active qsize when spawning new green workers https://review.openstack.org/105633 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!