*** Ish__ has joined #openstack-oslo | 00:03 | |
*** tsekiya__ has quit IRC | 00:04 | |
*** tsekiya__ has joined #openstack-oslo | 00:06 | |
*** zzzeek has quit IRC | 00:18 | |
*** dims_ has joined #openstack-oslo | 00:27 | |
*** arnaud has quit IRC | 00:29 | |
*** arnaud__ has quit IRC | 00:29 | |
openstackgerrit | amrith proposed a change to openstack/oslo-incubator: Mask passwords in exceptions and error messages https://review.openstack.org/109417 | 01:01 |
---|---|---|
celttechie | If someone had a minute to review: https://review.openstack.org/#/c/108198/ ...it won't take long. | 01:18 |
*** liusheng has joined #openstack-oslo | 01:20 | |
openstackgerrit | A change was merged to openstack/taskflow: Enable hacking checks H305 and H307 in tox.ini template https://review.openstack.org/109204 | 01:26 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 01:28 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 01:32 |
openstackgerrit | amrith proposed a change to openstack/oslo-incubator: Log stdout, stderr and command on execute() error https://review.openstack.org/109469 | 01:39 |
*** Ish__ has quit IRC | 01:39 | |
*** yamahata has quit IRC | 01:40 | |
*** liusheng has quit IRC | 01:50 | |
*** liusheng has joined #openstack-oslo | 01:51 | |
*** liusheng has quit IRC | 02:03 | |
*** liusheng has joined #openstack-oslo | 02:04 | |
*** praneshp has quit IRC | 02:13 | |
*** arosen has quit IRC | 02:17 | |
*** Ish__ has joined #openstack-oslo | 02:23 | |
*** SridharG has quit IRC | 02:23 | |
*** zzzeek has joined #openstack-oslo | 02:32 | |
*** Ish__ has quit IRC | 02:33 | |
*** harlowja is now known as harlowja_away | 02:37 | |
*** Ish__ has joined #openstack-oslo | 02:38 | |
*** dims_ has quit IRC | 02:48 | |
*** zzzeek has quit IRC | 02:50 | |
*** HenryG is now known as HenryG_afk | 03:08 | |
*** tsekiya__ has quit IRC | 03:09 | |
*** yamahata has joined #openstack-oslo | 03:18 | |
*** arnaud has joined #openstack-oslo | 03:29 | |
*** arnaud has quit IRC | 03:43 | |
*** celttechie has quit IRC | 03:49 | |
*** arnaud has joined #openstack-oslo | 04:05 | |
*** harlowja_at_home has joined #openstack-oslo | 04:16 | |
*** harlowja_at_home has quit IRC | 04:17 | |
*** noelbk has quit IRC | 04:17 | |
*** harlowja_at_home has joined #openstack-oslo | 04:18 | |
*** arnaud has quit IRC | 04:33 | |
*** arnaud has joined #openstack-oslo | 04:35 | |
*** harlowja_at_home has quit IRC | 04:41 | |
*** SridharG has joined #openstack-oslo | 04:53 | |
*** mrda is now known as mrda-traveling | 04:55 | |
*** jecarey has joined #openstack-oslo | 04:59 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 05:13 |
*** aaronorosen has joined #openstack-oslo | 05:45 | |
*** k4n0 has joined #openstack-oslo | 05:56 | |
*** praneshp has joined #openstack-oslo | 06:00 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/106938 | 06:03 |
*** harlowja_at_home has joined #openstack-oslo | 06:06 | |
*** Ish__ has joined #openstack-oslo | 06:10 | |
*** Ish__ has left #openstack-oslo | 06:12 | |
*** arnaud has quit IRC | 06:12 | |
*** praneshp_ has joined #openstack-oslo | 06:16 | |
*** praneshp has quit IRC | 06:19 | |
*** praneshp_ is now known as praneshp | 06:19 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/108572 | 06:29 |
*** noelbk has joined #openstack-oslo | 06:34 | |
*** mkoderer_cloud has joined #openstack-oslo | 06:41 | |
*** abhijeetm has joined #openstack-oslo | 06:45 | |
*** abhishek has joined #openstack-oslo | 06:45 | |
*** abhijeetm has left #openstack-oslo | 06:45 | |
*** harlowja_at_home has quit IRC | 06:59 | |
*** praneshp has quit IRC | 07:09 | |
*** praneshp has joined #openstack-oslo | 07:10 | |
*** praneshp has quit IRC | 07:21 | |
*** i159 has joined #openstack-oslo | 07:26 | |
*** flaper87 has quit IRC | 07:30 | |
*** flaper87 has joined #openstack-oslo | 07:30 | |
abhishek | hi dhellmann, you around? | 07:32 |
*** yamahata__ has quit IRC | 07:48 | |
*** flaper87 is now known as flaper87|afk | 07:52 | |
*** ihrachyshka has joined #openstack-oslo | 07:54 | |
*** ihrachyshka has quit IRC | 07:55 | |
*** ihrachyshka has joined #openstack-oslo | 08:02 | |
*** nacim has joined #openstack-oslo | 08:05 | |
*** ihrachyshka has quit IRC | 08:12 | |
*** pblaho has joined #openstack-oslo | 08:14 | |
*** ihrachyshka has joined #openstack-oslo | 08:27 | |
*** ildikov has joined #openstack-oslo | 08:37 | |
*** noelbk has quit IRC | 08:37 | |
*** noelbk has joined #openstack-oslo | 08:37 | |
*** ildikov_ has quit IRC | 08:40 | |
*** oomichi has quit IRC | 08:49 | |
openstackgerrit | Alex Frolov proposed a change to openstack/oslo-incubator: Transfer class LazyPluggable from nova to oslo-incubator https://review.openstack.org/107373 | 09:25 |
openstackgerrit | Chris Dent proposed a change to openstack/oslo.messaging: Fix error in example of an RPC server https://review.openstack.org/108410 | 09:27 |
openstackgerrit | Bertrand Lallau proposed a change to openstack/oslo.messaging: Add call/cast rpc logs for debug purpose https://review.openstack.org/109526 | 09:31 |
*** ihrachyshka has quit IRC | 09:41 | |
*** ihrachyshka has joined #openstack-oslo | 09:41 | |
*** amotoki has quit IRC | 09:42 | |
openstackgerrit | Bertrand Lallau proposed a change to openstack/oslo.messaging: Add call/cast rpc logs for debug purpose https://review.openstack.org/109526 | 09:43 |
*** dims has joined #openstack-oslo | 10:24 | |
openstackgerrit | A change was merged to openstack/oslo.db: Add disconnect modification support to exception handling https://review.openstack.org/106432 | 10:24 |
openstackgerrit | A change was merged to openstack/oslo.db: Updated from global requirements https://review.openstack.org/105173 | 10:26 |
openstackgerrit | A change was merged to openstack/oslo.db: Integrate the ping listener into the filter system. https://review.openstack.org/106491 | 10:29 |
*** yamahata has quit IRC | 10:31 | |
*** pcm_ has joined #openstack-oslo | 10:32 | |
*** pcm__ has joined #openstack-oslo | 10:33 | |
*** pcm_ has quit IRC | 10:37 | |
openstackgerrit | A change was merged to openstack/oslo.db: Port _is_db_connection_error check to exception filters https://review.openstack.org/106492 | 10:39 |
openstackgerrit | A change was merged to openstack/oslo.db: Use SQLAlchemy cursor execute events for tracing https://review.openstack.org/106406 | 10:49 |
*** Alexei_9871 has joined #openstack-oslo | 11:03 | |
*** mkoderer_cloud has quit IRC | 11:06 | |
*** mkoderer_cloud has joined #openstack-oslo | 11:06 | |
openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Add create_database_permission_exist function https://review.openstack.org/109259 | 11:12 |
openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Should not send replies for cast messages https://review.openstack.org/109143 | 11:15 |
openstackgerrit | Rossella Sblendido proposed a change to openstack/oslo.db: Retry query if db deadlock error is received https://review.openstack.org/109549 | 11:19 |
*** alexpilotti has joined #openstack-oslo | 11:27 | |
*** ihrachyshka has quit IRC | 11:28 | |
*** ihrachyshka has joined #openstack-oslo | 11:28 | |
*** k4n0 has quit IRC | 11:38 | |
openstackgerrit | Bertrand Lallau proposed a change to openstack/oslo.messaging: Add call/cast rpc logs for debug purpose https://review.openstack.org/109526 | 12:03 |
*** ihrachyshka has quit IRC | 12:07 | |
*** ihrachyshka has joined #openstack-oslo | 12:07 | |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo-incubator: Remove oslo.log from lockutils https://review.openstack.org/109561 | 12:09 |
openstackgerrit | chandan kumar proposed a change to openstack/oslo.config: Added link to bug tracker and documentation in oslo.config readme https://review.openstack.org/107917 | 12:21 |
*** dims has quit IRC | 12:23 | |
*** dims has joined #openstack-oslo | 12:25 | |
dhellmann | abhishek: I'm here now, if you're still online. | 12:37 |
abhishek | dhellmann:hi, i want to talk with you about, https://review.openstack.org/#/c/106690/ | 12:38 |
abhishek | dhellmann:oslo-spec for adding new comparison check in oslo-incubator's policy module | 12:38 |
dhellmann | abhishek: ok | 12:39 |
abhishek | sorry, please reffer this spec https://review.openstack.org/#/c/106285/ | 12:39 |
dhellmann | abhishek: found it; I'm reading your responses now | 12:40 |
*** gordc has joined #openstack-oslo | 12:40 | |
abhishek | dhellmann:ok | 12:41 |
*** HenryG_afk is now known as HenryG | 12:42 | |
dhellmann | abhishek: is all of this about matching literal expressions that would otherwise look like variables (like '%(test_key)s')? | 12:42 |
abhishek | dhellmann:yes | 12:43 |
dhellmann | ok, that only became clear after reading the implementation you have | 12:43 |
dhellmann | what's the use case for that? | 12:43 |
abhishek | dhellmann:like in glance I want to create some license image and want to ensure that other users should not download and use that | 12:44 |
dhellmann | abhishek: how would you express that with this new rule? | 12:45 |
abhishek | dhellmann: i will create a licensed image by adding custom property to the image say x_license_code = license_key | 12:45 |
dhellmann | abhishek: ok, and then what would the proposed policy rule look like? I'm afraid I'm being dense, but I don't see why you can't already do that. | 12:46 |
abhishek | example: x_license_key = abc_1234" and add it to image and then add a rule in policy.json, say 'restricted': 'abc_1234==%(x_license_key)s' makes more sense | 12:47 |
abhishek | and for download image "download_image": "role:admin or rule:restricted" | 12:48 |
dhellmann | so you want to place the literal value representing the key you're checking first in the rule, and the variable second? | 12:49 |
*** bknudson has quit IRC | 12:49 | |
abhishek | dhellmann:yes | 12:49 |
dhellmann | abhishek: it seems like you could express that now as x_license_key:abc_1234 right? | 12:50 |
abhishek | dhellmann:yes | 12:50 |
dhellmann | or, hang on, actually it would be abc_1234:%(x_license_key)s | 12:50 |
* dhellmann isn't a policy syntax expert, obviously | 12:50 | |
abhishek | yes, this is right | 12:50 |
*** russellb is now known as rustlebee | 12:50 | |
dhellmann | ok, and so you want to remove the %(x_license_key)s part of the check? | 12:51 |
dhellmann | that is, you want to turn %(x_license_key)s to just x_license_key | 12:51 |
dhellmann | that doesn't seem like it buys us much, though, when considered against the need to update existing documentation for the syntax change | 12:52 |
abhishek | noelbk, I want this as " %(x_license_key)s" only | 12:52 |
dhellmann | abhishek: but that's not the example you gave above, you said 'restricted': 'abc_1234==%(x_license_key)s' | 12:54 |
abhishek | yes, that's true | 12:54 |
dhellmann | abhishek: are you saying you want the rule to be written: 'restricted': '%(x_license_key)s' | 12:54 |
dhellmann | that's not what you code change does, I think | 12:55 |
abhishek | dhellmann:just a minute, i will explain you properly | 12:55 |
dhellmann | ok | 12:57 |
abhishek | dehllmann: in the rule 'restricted': 'abc_1234==%(x_license_key)s', 'abc_1234' is called as 'kind' and %(x_license_key)s is called as 'match' | 12:57 |
abhishek | dhellmann: if you reffer https://github.com/openstack/oslo-incubator/blob/master/openstack/common/policy.py#L892 | 12:58 |
abhishek | dhellmann: you can find that 'abc_1234' need to be passed as credential to this check in order to do the comparison of kind and match | 12:59 |
abhishek | dhellmann: currently, you can pass only context info (i.e. user, tenant, role etc) in the credential while enforcing the policy check | 13:00 |
abhishek | dhellmann: so if I want to enforce policy using any image property then, its not possible to pass this property in the credential | 13:02 |
dhellmann | the image properties are passed in the "target" variable, right? | 13:02 |
abhishek | yes | 13:02 |
abhishek | dhellmann:https://review.openstack.org/#/c/98737/10/glance/openstack/common/policy.py | 13:03 |
dhellmann | I think that makes the syntax you want: 'abc_1234':%(x_license_key)s | 13:03 |
dhellmann | which, I agree, isn't obvious | 13:03 |
*** bnemec has joined #openstack-oslo | 13:04 | |
abhishek | dhellmann:so what's your opinion on this | 13:05 |
abhishek | if you see the docstring, https://github.com/openstack/oslo-incubator/blob/master/openstack/common/policy.py#L876 this syntax is already used | 13:06 |
dhellmann | abhishek: well, I am not sure changing the syntax in such a slight way for a case that we already support makes a lot of sense | 13:06 |
*** bknudson has joined #openstack-oslo | 13:07 | |
dhellmann | abhishek: I do agree the current form is a bit backwards, but the inconsistency of having it work both ways just adds to the documentation burden | 13:07 |
abhishek | dhellmann:yes | 13:08 |
abhishek | dhellmann: then can I add this check in GenericCheck class only, which will solve the purpose? | 13:09 |
dhellmann | abhishek: no, I don't think this is a change we want to make right now. I would like, at some point, to create a policy language that is easier to read and write, but I think that is a much bigger project than what you are proposing here. | 13:10 |
*** zzzeek has joined #openstack-oslo | 13:11 | |
viktors|afk | zzzeek: hi! | 13:11 |
*** viktors|afk is now known as viktors | 13:11 | |
abhishek | dhellmann:I will upload the new spec with appropriate example, which will help to understand more clearly | 13:12 |
abhishek | dhellmann:thank you for your time | 13:14 |
dhellmann | abhishek: ok | 13:15 |
*** lbragstad has joined #openstack-oslo | 13:18 | |
*** mriedem has joined #openstack-oslo | 13:20 | |
*** ihrachyshka has quit IRC | 13:29 | |
*** ihrachyshka has joined #openstack-oslo | 13:29 | |
*** jecarey has quit IRC | 13:30 | |
i159 | zzzeek: Hi! I have several questions to you. Have you a minute, please? | 13:30 |
zzzeek | i159: sure, just be patient for my responses as im getting multiple messsages out :) | 13:31 |
i159 | zzzeek: At first short one :) Where is the best place to put a test for PGInspector.load_enums? | 13:33 |
zzzeek | hm | 13:33 |
zzzeek | probably test/dialect/postgresql/test_dialect | 13:33 |
*** bnemec is now known as beekneemech | 13:34 | |
i159 | zzzeek: ok... I want to create something like schema.DropEnum, but the ddl module code looks to me very unusual. Should I do it or postgresql.ENUM(name=enum).drop(conn) is enaugh? | 13:38 |
zzzeek | there already is a postgresql.DropEnum | 13:39 |
openstackgerrit | A change was merged to openstack/oslo.db: Raise DBReferenceError on foreign key violation https://review.openstack.org/94333 | 13:44 |
i159 | zzzeek: It's amazing how I missed it! Anyway, good news. I hope I'll be done with a pull request today. And I have one more big question... | 13:44 |
*** abhijeetm has joined #openstack-oslo | 13:44 | |
openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Set the main logger name to match the application https://review.openstack.org/109578 | 13:46 |
i159 | zzzeek: I want to discuss your comment https://review.openstack.org/#/c/99965/. I have tried to implement oslo.config instead of Alembic config. I met a lot of problems. Alembic uses config inside of environment and script modules. Oslo.config has different interface. It seems to me like an amount of overhead work to implement it. I guess I could missed a simple way. Actually I think it is an overhead, but I still need your opinion. Thanks! | 13:51 |
openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Clean up default tox environment list https://review.openstack.org/109582 | 13:51 |
zzzeek | i159: OK i want you to not use “alembic.ini” - the file | 13:52 |
zzzeek | i159: but you *do* have to use alembic.config.Config | 13:52 |
zzzeek | i159: you need to copy the things you need from oslo.config into alembic.Config | 13:52 |
zzzeek | i159: programmatically | 13:52 |
i159 | zzzeek: Ok, sounds good to me. Thanks for your answers! | 13:54 |
zzzeek | i159: good luck i have not made it easy for you :) | 13:54 |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Add release notes for stable/icehouse 1.3.1 release https://review.openstack.org/107915 | 14:05 |
*** markmcclain has joined #openstack-oslo | 14:09 | |
*** yamahata has joined #openstack-oslo | 14:12 | |
openstackgerrit | Mark McLoughlin proposed a change to openstack/oslo.messaging: Add release notes for 1.4.0.0a4 https://review.openstack.org/109599 | 14:13 |
*** nacim has quit IRC | 14:22 | |
viktors | zzzeek: hi! | 14:30 |
zzzeek | hey viktors | 14:31 |
viktors | recently we with rpodolyaka found a strange issue with SQLA connections | 14:31 |
viktors | zzzeek: can you please help us investigate it? | 14:32 |
zzzeek | viktors: sure | 14:32 |
viktors | zzzeek: let's got to PM | 14:32 |
*** ihrachyshka has quit IRC | 14:38 | |
openstackgerrit | A change was merged to openstack/oslo.db: Bump hacking to version 0.9.2 https://review.openstack.org/107402 | 14:42 |
*** abhijeetm has left #openstack-oslo | 14:43 | |
*** abhishek has quit IRC | 14:44 | |
openstackgerrit | Radoslav Gerganov proposed a change to openstack/oslo.vmware: Log additional details of suds faults https://review.openstack.org/104534 | 14:50 |
YorikSar | dhellmann: Hi... Can you help me with graduate.sh script? | 14:50 |
openstackgerrit | Ken Giusti proposed a change to openstack/oslo.messaging: An initial implementation of a 1.0 based messaging driver https://review.openstack.org/75815 | 14:50 |
*** markmcclain has quit IRC | 14:51 | |
dhellmann | YorikSar: I can try :-) | 14:52 |
YorikSar | dhellmann: I'm suprisingly getting a merge conflict | 14:52 |
*** lbragstad has quit IRC | 14:52 | |
dhellmann | YorikSar: that is surprising. can you set up a pastebin with the commands you're running and a link to the repository, so I can try it? | 14:53 |
*** jecarey has joined #openstack-oslo | 14:53 | |
YorikSar | dhellmann: (btw, I've added -d option to filter-branch so that it takes about 3 minutes instead of 25) | 14:54 |
YorikSar | dhellmann: I've cloned original oslo-incubator and run ../oslo-incubator/tools/graduate.sh concurrency openstack/common/{lockutils.py,processutils.py} tests/unit/test_lockutils.py tests/unit/test_processutils.py | 14:55 |
*** lbragstad has joined #openstack-oslo | 14:55 | |
dhellmann | that all looks right | 14:55 |
dhellmann | what does the -d option do? | 14:56 |
YorikSar | dhellmann: And somewhere along the way I'm getting on "lockutils: do not grab the lock in creators" commit... I thought that can't happen. | 14:56 |
YorikSar | dhellmann: It sets temporary directory where filter-branch works. I've moved it to tmpfs | 14:56 |
dhellmann | ok | 14:57 |
dhellmann | Let me try it here... | 14:57 |
*** celttechie has joined #openstack-oslo | 15:01 | |
*** ihrachyshka has joined #openstack-oslo | 15:06 | |
YorikSar | dhellmann: Huh... It seems that not only tmpfs played its role :) | 15:07 |
YorikSar | dhellmann: I've tried to use --index-filter instead of --tree-filter. | 15:08 |
dhellmann | YorikSar: ah, ok | 15:08 |
dhellmann | YorikSar: I have an unaltered version of the script here and it's still running | 15:08 |
YorikSar | dhellmann: I thought it made no difference time-wise. | 15:08 |
dhellmann | I'm interested in that -d option if it really does make this faster, but I wanted to try it without any change | 15:08 |
YorikSar | dhellmann: Yes, I've reverted index-filter change, only -d left. But I think the first time I ran it as is and had the same issue. | 15:09 |
dhellmann | I'm not an expert, but I think the tree-filter option needs to be used in order to actually change the contents of the commits in the way we want. | 15:09 |
dhellmann | ok, I'll let this copy finish running and let you know if I get an error | 15:09 |
YorikSar | dhellmann: index-filter does the same but without checking out anything. So you can use update-index to remove whatever you like. | 15:10 |
* YorikSar is a secret fan of Git plumbing commands | 15:10 | |
dhellmann | I wonder if that is faster, too? of course, if it doesn't work... :-) | 15:10 |
dhellmann | YorikSar: if you get a combination of options that works, please submit a patch to the incubator repo :-) | 15:11 |
YorikSar | dhellmann: That's my intention :) | 15:11 |
dhellmann | +1 | 15:11 |
YorikSar | dhellmann: I don't think we can provide a way to automatically create tmpfs dir, but... We can add an option, I guess. | 15:11 |
dhellmann | YorikSar: would creating a directory with mktemp do it? | 15:12 |
YorikSar | dhellmann: Only if your /tmp is tmpfs | 15:12 |
dhellmann | YorikSar: well, yes, true | 15:12 |
YorikSar | dhellmann: But if your /tmp is tmpfs (not like on my system) and you follow instructions on wiki thoroughly (not like me, I didn't cd to /tmp), you'll get that speedup anyway | 15:13 |
*** tongli has joined #openstack-oslo | 15:14 | |
dhellmann | YorikSar: I see a merge conflict as well, now | 15:14 |
YorikSar | dhellmann: Yay, index-filter approach works then :) | 15:14 |
YorikSar | dhellmann: I don't see anything different about that commit... | 15:17 |
YorikSar | dhellmann: Hm... Doesn't that rebase create a straight commit history without merges? If so it might've applied commits in wrong order or smth. | 15:18 |
dhellmann | YorikSar: I was able to fix up that commit by hand and let the rebase continue, but then I hit another in the same function | 15:20 |
dhellmann | I wonder if this is caused by the fact that we had to revert changes to that function somewhere | 15:21 |
YorikSar | dhellmann: It shouldn't... I'm thinking about converting all calls to filter-branch to one call so that we won't need rebase. | 15:22 |
dhellmann | YorikSar: see if this repo looks right to you: https://github.com/dhellmann/oslo.concurrency | 15:22 |
dhellmann | if you can improve the script, that would make me happy | 15:23 |
dhellmann | I worked from some commands markmc gave me to create this version, but I confess I don't understand all of the calls | 15:23 |
dhellmann | YorikSar: obviously the stuff in graduate.sh after the rebase still needs to be done | 15:24 |
YorikSar | dhellmann: Yes, it looks fine, but... Hm... Was it an original intention to remove all merge commits? | 15:24 |
*** arnaud has joined #openstack-oslo | 15:25 | |
dhellmann | YorikSar: yes, because I thought otherwise we can't really prune the history | 15:25 |
YorikSar | dhellmann: So you've just resolved couple of conflicts, right? | 15:25 |
dhellmann | that's right | 15:25 |
*** ihrachyshka has quit IRC | 15:27 | |
YorikSar | dhellmann: Ok... | 15:27 |
dhellmann | the result looks right compared to the current state of master, but I don't know if the history is accurate any more | 15:28 |
*** ihrachyshka has joined #openstack-oslo | 15:28 | |
YorikSar | dhellmann: I'll verify that. I'm still waiting for my graduate.sh run to finish... | 15:31 |
YorikSar | dhellmann: Although I guess I don't need to. | 15:32 |
*** arnaud__ has joined #openstack-oslo | 15:32 | |
dhellmann | yeah, feel free to clone that repo and keep working on it from there. I guess you'll have to run the remaining commands by hand. :-/ | 15:33 |
*** erecio has joined #openstack-oslo | 15:34 | |
YorikSar | dhellmann: I guess I'm too eager to improve graduate.sh, so I'll have your repo as a golden version to compare to :) | 15:35 |
dhellmann | YorikSar: ok, that sounds good | 15:36 |
*** ihrachyshka has quit IRC | 15:36 | |
*** ihrachyshka has joined #openstack-oslo | 15:37 | |
*** jogo is now known as flashgordon | 15:38 | |
YorikSar | dhellmann: Well, that speedup was definitelly from index-filter. I've killed original version running (with tmpfs) on 28th minute. And index-filter version already failed with conflict after 2:44 :) | 15:38 |
*** erecio has quit IRC | 15:38 | |
dhellmann | YorikSar: I'll be interested to see if your results are the same :-) | 15:39 |
*** mriedem has quit IRC | 15:40 | |
*** mriedem has joined #openstack-oslo | 15:42 | |
YorikSar | dhellmann: So... I've copied your resolituons of those conflicts and 'git diff dhellman/master' doesn't show anything :) | 15:43 |
dhellmann | YorikSar: using index-filter? | 15:44 |
YorikSar | dhellmann: yes | 15:44 |
dhellmann | YorikSar: how about the log messages and other metadata? | 15:44 |
dhellmann | commit ids would change, probably | 15:44 |
*** jaypipes has joined #openstack-oslo | 15:44 | |
YorikSar | dhellmann: I'mlooking into removing commit ids from git log output... And then I'll tell :) | 15:45 |
*** jaypipes is now known as leakypipes | 15:45 | |
YorikSar | dhellmann: % diff -s <(git log | grep -v '^commit') <(git log dhellman/master | grep -v '^commit') | 15:47 |
YorikSar | dhellmann: │Files /proc/self/fd/11 and /proc/self/fd/12 are identical | 15:47 |
YorikSar | dhellmann: Removing it with git log args seemed to be too hard | 15:47 |
openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Clean up default tox environment list https://review.openstack.org/109582 | 15:49 |
openstackgerrit | Doug Hellmann proposed a change to openstack/cliff: Do not allow wheels for stable tests https://review.openstack.org/109639 | 15:49 |
YorikSar | dhellmann: I gotta go now, but I'll push a change request soon :) | 15:49 |
dhellmann | YorikSar: ok, sounds good, thanks for working on that! | 15:49 |
dhellmann | team meeting in ~10 minutes | 15:50 |
*** dims has quit IRC | 15:56 | |
openstackgerrit | A change was merged to openstack/oslo.messaging: Add release notes for stable/icehouse 1.3.1 release https://review.openstack.org/107915 | 16:04 |
*** dims has joined #openstack-oslo | 16:07 | |
openstackgerrit | A change was merged to openstack/oslo.messaging: Add release notes for 1.4.0.0a4 https://review.openstack.org/109599 | 16:10 |
*** ihrachyshka has quit IRC | 16:11 | |
*** noelbk has quit IRC | 16:31 | |
openstackgerrit | Matthew Booth proposed a change to openstack/oslo.db: Handle constraint not found on postgresql https://review.openstack.org/109649 | 16:44 |
openstackgerrit | A change was merged to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/106938 | 16:47 |
*** lbragstad has quit IRC | 16:51 | |
*** noelbk has joined #openstack-oslo | 16:52 | |
*** Alexei_9871 has left #openstack-oslo | 17:00 | |
*** viktors is now known as viktors|afk | 17:02 | |
*** i159 has quit IRC | 17:02 | |
*** praneshp has joined #openstack-oslo | 17:03 | |
YorikSar | Now that the meeting's over... About oslo.local and others. | 17:03 |
YorikSar | I've seen oslo.local usage in oslo.log. It can be made options really easy. | 17:04 |
YorikSar | Like try: form oslo.concurrency import local except ImportError: etc | 17:04 |
YorikSar | I wonder if we should create a separate library just for that 10 lines of code. | 17:05 |
YorikSar | Or is it used in some services that wouldn't want to drag all oslo.concurrency in? | 17:08 |
dhellmann | YorikSar: we might not. See https://wiki.openstack.org/wiki/Oslo/Dependencies though | 17:08 |
YorikSar | dhellmann: I might be missing some problem in this graph... | 17:10 |
dhellmann | YorikSar: where were you suggesting putting local? concurrency? | 17:10 |
YorikSar | dhellmann: Yes | 17:10 |
dhellmann | that would introduce a cycle between oslo.log and oslo.concurrency right now | 17:11 |
YorikSar | dhellmann: It'll be broken by just oneline commit. | 17:11 |
*** noelbk has quit IRC | 17:12 | |
dhellmann | are there any projects that would use oslo.log but not the dependencies of oslo.concurrency? | 17:12 |
*** noelbk has joined #openstack-oslo | 17:12 | |
YorikSar | dhellmann: https://review.openstack.org/109561 - as I understand it needs to land in incubator as per https://wiki.openstack.org/wiki/Oslo/CreatingANewLibrary#Updating_the_Incubator | 17:12 |
dhellmann | YorikSar: ok, I'm in another meeting, so I'll have to look at this more closely in a little while | 17:13 |
dhellmann | you might be right | 17:13 |
YorikSar | dhellmann: I don't actually know... I'll look into it later. | 17:13 |
YorikSar | dhellmann: Ok, I have to walk my dog anyway. :) | 17:13 |
*** harlowja_away is now known as harlowja | 17:17 | |
amrith | dhellmann, I've marked the patch as WIP but it may be worthwhile to get reviews going so that at the time when it can get into o.concurrency, it can drop right in. | 17:19 |
*** mkoderer_cloud has quit IRC | 17:22 | |
*** lbragstad has joined #openstack-oslo | 17:28 | |
*** yamahata has quit IRC | 17:30 | |
openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Implement a dialect-level function dispatch system https://review.openstack.org/109436 | 17:34 |
Alexei_987 | harlowja: Hi are you available? | 17:49 |
Alexei_987 | dhellmann: Hi is there any chance that you know why we send 2 reply messages for each rpc call? https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/_drivers/amqpdriver.py#L69 | 17:50 |
Alexei_987 | dhellmann: IMHO 2nd one could be removed if driver would be updated accordinly | 17:50 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use checked commit when committing kazoo transactions https://review.openstack.org/108256 | 18:01 |
YorikSar | dhellmann: Ok, in openstack/* I see only horizon, os-collect-config and oslo.vmware having oslo.local but not having either lockutils or processutils | 18:02 |
YorikSar | dhellmann: And I think that's because of oslo.log | 18:02 |
harlowja | Alexei_987 i don't know :-/ | 18:04 |
harlowja | seems odd to send a ending message | 18:04 |
Alexei_987 | harlowja: from the logic it seems useless.. most likely some kind of legacy stuff related to multicall | 18:04 |
harlowja | ya, i wonder why just 1 ending message, why not 2 or 3 or 4 | 18:05 |
harlowja | lol | 18:05 |
*** bknudson has quit IRC | 18:05 | |
Alexei_987 | harlowja: oslo.messaging is one big mistery.. | 18:05 |
YorikSar | dhellmann: Yep, that's true. | 18:05 |
harlowja | i think u should send 100 ending messages; just incase the first 99 don't make it :-P | 18:05 |
*** markmcclain has joined #openstack-oslo | 18:06 | |
harlowja | Alexei_987 i always thought the usage of 'rpc_amqp._MsgIdCache()' was odd also | 18:07 |
harlowja | but thats a different thing | 18:07 |
Alexei_987 | harlowja: yeah thats another strange stuff since it definetely doesn't work in ReplyWaiter | 18:08 |
Alexei_987 | harlowja: we never register anything there | 18:08 |
harlowja | its also only 16 items long | 18:08 |
harlowja | magic 16 | 18:08 |
*** markmcclain1 has joined #openstack-oslo | 18:09 | |
harlowja | so u only get 16 known dupes, more than that and u can have dupes | 18:09 |
Alexei_987 | harlowja: I hope to discuss major refactoring of all this stuff at the summit | 18:09 |
Alexei_987 | harlowja: and meanwhile try to work on some kind of functional tests | 18:09 |
harlowja | Alexei_987 what are your thoughts around just using more of kombu to do all the work? | 18:09 |
harlowja | when https://github.com/celery/kombu/pull/335 goes in, qpid will work in kombu | 18:09 |
Alexei_987 | harlowja: my thoughts are that we should throw away all the stuff that we don't need | 18:10 |
harlowja | how much is then needed? | 18:10 |
*** markmcclain has quit IRC | 18:10 | |
Alexei_987 | harlowja: IMHO we should target to implement our basic api classes | 18:10 |
Alexei_987 | harlowja: we have 2 pairs of classes - RPCClient + RPCServer | 18:10 |
Alexei_987 | + same for notify | 18:10 |
harlowja | so just a couple tiny things that plug-in to kombu to do the rest | 18:11 |
harlowja | ? | 18:11 |
Alexei_987 | if we could make it work with minimum code that would be great | 18:11 |
Alexei_987 | yeah | 18:11 |
Alexei_987 | harlowja: I'm working on zmq driver when I have some free time https://github.com/Alexei-Kornienko/oslo.messaging/blob/zeromq/oslo/messaging/_drivers/impl_zmq.py | 18:12 |
Alexei_987 | and try to keep it small and simple | 18:12 |
harlowja | Alexei_987 kombu has a zeromq one? not good enough? | 18:12 |
harlowja | https://github.com/celery/kombu/issues/85 ? | 18:12 |
* harlowja not sure how good/bad the kombu one is | 18:13 | |
harlowja | * https://github.com/celery/kombu/blob/master/kombu/transport/zmq.py | 18:13 |
Alexei_987 | harlowja: will take a look on that. I didn't know it's there | 18:13 |
YorikSar | dhellmann: In stackforge/* there are ec2-api using local from outside oslo and magentodb that uses pastedeploy that uses local, others either have processutils or lockutils or have just log or legacy rpc. | 18:15 |
harlowja | cool, kombu seems to get more activity than oslo.messaging; so it'd be nice to keep oslo.messaging as a set of things ontop of kombu that are more openstack specific (if we can do this, which it seems like with that qpid+kombu addition we could) | 18:15 |
harlowja | Alexei_987 thats just my thoughts; others may believe different | 18:15 |
Alexei_987 | harlowja: from a quick look it doesn't seem as a good option to zmq since it requires M*M connections | 18:15 |
harlowja | Alexei_987 kombu accepts patches though ;) | 18:16 |
Alexei_987 | harlowja: and it won't work with dynamic discovery + HA | 18:16 |
Alexei_987 | we'll see about that. Right now I have to fix impl_rabbit somehow | 18:16 |
Alexei_987 | since it doesn't work as we want it to work | 18:16 |
harlowja | Alexei_987 understood, thats my concern with alot of oslo honestly; that we are avoiding contributing back to dependent projects (kombu for example) | 18:17 |
harlowja | *if its a real concern or a josh-created one is another question entirely :-P | 18:19 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/109672 | 18:26 |
*** ihrachyshka has joined #openstack-oslo | 18:28 | |
*** ihrachyshka has quit IRC | 18:36 | |
*** tongli has quit IRC | 18:36 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the linear flow symbol constraints https://review.openstack.org/107897 | 18:36 |
zzzeek | dhellmann rpodolyaka viktors|afk : https://etherpad.openstack.org/p/sqla_exceptions_caught | 18:38 |
*** pblaho has quit IRC | 18:39 | |
dhellmann | amrith: yes, WIP with continuing your work was the idea | 18:39 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the unordered flow symbol constraints https://review.openstack.org/108161 | 18:40 |
dhellmann | YorikSar: I think the dependency work I did predates the idea that oslo.log would be a library for apps to configure logging, so it's possible we can include local in the concurrency library, too. Why don't you update the graduation spec with that (submit a change against the existing spec) and we'll use that as a place to record the conversation and decision. | 18:42 |
dhellmann | Alexei_987: I don't know about why we have 2 responses. Maybe it has something to do with the way the rpc sender is expecting a response? | 18:42 |
YorikSar | dhellmann: I'm going to try to research if we can include threadgroup here as well... | 18:43 |
YorikSar | dhellmann: I think it'd be good to see all races happen in one library :) | 18:44 |
dhellmann | Alexei_987: keep in mind, oslo.messaging grew out of the rpc implementation actually used in nova, so it may have some legacy constructs | 18:44 |
Alexei_987 | dhellmann: Ok.. just plan to post a patch that makes reply waiter lot simpler | 18:44 |
dhellmann | YorikSar: I *think* the only things that use threadgroup are the other modules in the oslo.server list, so if we put it there then it will just be an implementation detail of that library | 18:45 |
dhellmann | Alexei_987: ok | 18:45 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the graph flow symbol constraints https://review.openstack.org/108175 | 18:45 |
zzzeek | dhellmann rpodolyaka viktors|afk : im going to get a coffee. there isn’t much to look at but this is based on my assumptions being sound. back in a bit | 18:45 |
YorikSar | dhellmann: Ok, I'll verify that. | 18:46 |
dhellmann | zzzeek: I'm just catching up on scrollback, but I'll take a look at what you've put together in that etherpad | 18:47 |
zzzeek | dhellmann: no hurry | 18:47 |
*** morganfainberg is now known as morganfainberg_Z | 18:53 | |
zzzeek | ok caught a glitch and fixed it, now im really going for coffee | 18:57 |
*** bknudson has joined #openstack-oslo | 19:02 | |
*** ihrachyshka has joined #openstack-oslo | 19:02 | |
openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo-incubator: Use index-filter instead of tree-filter in graduate.sh https://review.openstack.org/109685 | 19:02 |
YorikSar | dhellmann: Almost forgot ^ | 19:02 |
*** SridharG has quit IRC | 19:03 | |
*** bknudson has quit IRC | 19:06 | |
*** Ish__ has joined #openstack-oslo | 19:12 | |
openstackgerrit | A change was merged to openstack/oslo.utils: Make the i18n integration module private https://review.openstack.org/109094 | 19:18 |
openstackgerrit | A change was merged to openstack/oslo.utils: Add API docs and clean up other docs https://review.openstack.org/109101 | 19:20 |
*** bknudson has joined #openstack-oslo | 19:20 | |
dhellmann | YorikSar: added to my review list | 19:23 |
*** Ish__ has quit IRC | 19:27 | |
*** ihrachyshka has quit IRC | 19:29 | |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Teach pbr about post versioned dev versions. https://review.openstack.org/80449 | 19:30 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Raise an error if preversion versions are too low https://review.openstack.org/108269 | 19:30 |
*** pblaho has joined #openstack-oslo | 19:30 | |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Look for and process sem-ver pseudo headers in git https://review.openstack.org/108270 | 19:30 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Refactor oneline changelog walking. https://review.openstack.org/108271 | 19:30 |
openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Introduce a SemanticVersion object https://review.openstack.org/94108 | 19:30 |
*** pblaho has quit IRC | 19:35 | |
*** Ish__ has joined #openstack-oslo | 19:39 | |
*** dims has quit IRC | 20:20 | |
*** dims has joined #openstack-oslo | 20:21 | |
*** Ish__ has quit IRC | 20:27 | |
*** Ish__ has joined #openstack-oslo | 20:29 | |
*** beekneemech has quit IRC | 20:50 | |
*** dims has quit IRC | 21:03 | |
*** celttechie has quit IRC | 21:18 | |
*** celttechie has joined #openstack-oslo | 21:18 | |
*** celttechie is now known as celttechie|afk | 21:18 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 21:23 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 21:28 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow handlers to provide validation callables https://review.openstack.org/101679 | 21:33 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: WBE notification message validation https://review.openstack.org/103657 | 21:41 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use a common message dispatcher https://review.openstack.org/101094 | 21:43 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Allow handlers to provide validation callables https://review.openstack.org/101679 | 21:43 |
*** jecarey has quit IRC | 21:47 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: WBE notification message validation https://review.openstack.org/103657 | 21:48 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: WBE response message validation https://review.openstack.org/103690 | 21:48 |
*** mriedem has quit IRC | 21:48 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: WBE request message validation https://review.openstack.org/103695 | 21:48 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add basic WBE validation sanity tests https://review.openstack.org/104016 | 21:49 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Improve WBE testing coverage https://review.openstack.org/101717 | 21:49 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add proxy heartbeat support https://review.openstack.org/104397 | 21:52 |
*** morganfainberg_Z is now known as morganfainberg | 21:55 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add proxy heartbeat support https://review.openstack.org/104397 | 21:56 |
*** gordc has quit IRC | 22:14 | |
*** lbragsta_ has joined #openstack-oslo | 22:17 | |
*** lbragstad has quit IRC | 22:20 | |
*** lbragsta_ has quit IRC | 22:21 | |
*** ildikov has quit IRC | 22:31 | |
*** yamahata has joined #openstack-oslo | 22:45 | |
*** Ish__ has quit IRC | 22:52 | |
openstackgerrit | A change was merged to openstack/cliff: Do not allow wheels for stable tests https://review.openstack.org/109639 | 22:54 |
*** Ish__ has joined #openstack-oslo | 22:54 | |
*** morganfainberg is now known as morganfainberg_Z | 22:55 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: Remove oslo.log from lockutils https://review.openstack.org/109561 | 22:57 |
*** harlowja is now known as harlowja_away | 22:58 | |
YorikSar | dhellmann: Around? | 23:02 |
dhellmann | YorikSar: for just a few more minutes, yes | 23:03 |
openstackgerrit | A change was merged to openstack/oslo-specs: Support policy configuration directories https://review.openstack.org/104157 | 23:03 |
YorikSar | dhellmann: I finally got my dream history with all merge commits. But I'm running into an error with cookiecutter... | 23:04 |
YorikSar | TypeError: unsupported operand type(s) for -: 'Undefined' and 'Undefined' | 23:04 |
dhellmann | hrm | 23:04 |
dhellmann | YorikSar: try installing a slightly older version of the cookiecutter for now | 23:04 |
YorikSar | dhellmann: Did you encounter such error? It seems it doesn't get some template argument it needs. | 23:05 |
dhellmann | I know they have been doing some work on it | 23:05 |
YorikSar | dhellmann: Ok, will try... | 23:05 |
dhellmann | let me see which version I'm using | 23:05 |
dhellmann | YorikSar: cookiecutter==0.7.0 | 23:05 |
dhellmann | YorikSar: if the older version works, file a bug with the traceback you're seeing against oslo and we can look at our templates | 23:06 |
*** harlowja_away is now known as harlowja | 23:06 | |
YorikSar | dhellmann: Bug to oslo or to cookiecutter? | 23:06 |
dhellmann | oslo | 23:06 |
YorikSar | dhellmann: Ok | 23:06 |
YorikSar | dhellmann: And just to brag a bit: https://github.com/YorikSar/oslo.concurrency/commits/master | 23:08 |
YorikSar | dhellmann: All commits saved their Author, Comitter and dates :) | 23:08 |
*** morganfainberg_Z is now known as morganfainberg | 23:08 | |
openstackgerrit | A change was merged to openstack/oslo-incubator: lockutils: split tests and run in Python 3 https://review.openstack.org/107698 | 23:09 |
dhellmann | YorikSar: nice! | 23:10 |
YorikSar | dhellmann: I'll prepare and post another CR for graduate.sh now | 23:10 |
YorikSar | dhellmann: I hope it's not too hackish | 23:11 |
dhellmann | YorikSar: ok, sounds good | 23:11 |
dhellmann | YorikSar: it's past time for my weekend to start; I'll look at your changes early next week. Have a good weekend! | 23:12 |
YorikSar | dhellmann: You too :) | 23:12 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add proxy heartbeat support https://review.openstack.org/104397 | 23:13 |
*** flaper87l has joined #openstack-oslo | 23:20 | |
*** flaper87l is now known as flaper87 | 23:20 | |
*** tcammann has joined #openstack-oslo | 23:22 | |
*** rpodolyaka1 has joined #openstack-oslo | 23:23 | |
*** gpocente1 has joined #openstack-oslo | 23:24 | |
*** jokke__ has joined #openstack-oslo | 23:24 | |
*** GheRiver1 has joined #openstack-oslo | 23:24 | |
*** flaper87|afk has quit IRC | 23:29 | |
*** rpodolyaka has quit IRC | 23:29 | |
*** gpocentek has quit IRC | 23:29 | |
*** ekarlso has quit IRC | 23:29 | |
*** tcammann_ has quit IRC | 23:29 | |
*** jokke_ has quit IRC | 23:29 | |
*** GheRivero has quit IRC | 23:29 | |
*** boris-42 has quit IRC | 23:29 | |
*** Ish__ has quit IRC | 23:29 | |
*** boris-42 has joined #openstack-oslo | 23:31 | |
*** Ish__ has joined #openstack-oslo | 23:31 | |
*** ekarlso has joined #openstack-oslo | 23:32 | |
*** Ish__ has quit IRC | 23:32 | |
*** mtreinish has quit IRC | 23:33 | |
*** mtreinish has joined #openstack-oslo | 23:46 | |
*** morganfainberg is now known as morganfainberg_Z | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!