| *** stevemar has joined #openstack-oslo | 00:04 | |
| *** yamahata has joined #openstack-oslo | 00:05 | |
| *** yamahata has quit IRC | 00:05 | |
| *** yamahata has joined #openstack-oslo | 00:05 | |
| *** tsekiyama has joined #openstack-oslo | 00:23 | |
| *** tsekiyam_ has quit IRC | 00:27 | |
| *** tsekiyama has quit IRC | 00:27 | |
| *** bknudson has joined #openstack-oslo | 00:29 | |
| *** pblaho_ has quit IRC | 00:34 | |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Raise an error if preversion versions are too low https://review.openstack.org/108269 | 00:43 |
|---|---|---|
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Look for and process sem-ver pseudo headers in git https://review.openstack.org/108270 | 00:43 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Refactor oneline changelog walking. https://review.openstack.org/108271 | 00:43 |
| openstackgerrit | lifeless proposed a change to openstack-dev/pbr: Only consider tags that look like versions. https://review.openstack.org/114403 | 00:43 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Update oslo-incubator to 037dee004c3e2239 https://review.openstack.org/114409 | 01:14 |
| *** dims has quit IRC | 01:22 | |
| *** dims has joined #openstack-oslo | 01:22 | |
| *** dims_ has joined #openstack-oslo | 01:25 | |
| *** dims has quit IRC | 01:25 | |
| *** zzzeek_ has joined #openstack-oslo | 01:59 | |
| *** zzzeek has quit IRC | 01:59 | |
| *** zzzeek_ is now known as zzzeek | 01:59 | |
| *** dims_ has quit IRC | 02:04 | |
| *** dims has joined #openstack-oslo | 02:05 | |
| *** zzzeek has quit IRC | 02:18 | |
| *** Krast has joined #openstack-oslo | 02:33 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Initial shift to having backends provide storage impls https://review.openstack.org/114422 | 02:40 |
| *** dims has quit IRC | 02:53 | |
| *** Krast has quit IRC | 03:10 | |
| *** Krast has joined #openstack-oslo | 03:10 | |
| *** praneshp has quit IRC | 03:12 | |
| *** harlowja is now known as harlowja_away | 03:42 | |
| *** amotoki has joined #openstack-oslo | 03:56 | |
| *** tong_ has joined #openstack-oslo | 04:00 | |
| *** tongli has quit IRC | 04:00 | |
| *** praneshp_ has joined #openstack-oslo | 04:05 | |
| *** amotoki has quit IRC | 04:10 | |
| *** harlowja_at_home has joined #openstack-oslo | 04:16 | |
| *** harlowja_at_home has quit IRC | 04:24 | |
| *** amotoki has joined #openstack-oslo | 04:33 | |
| *** ildikov has quit IRC | 04:51 | |
| *** harlowja_at_home has joined #openstack-oslo | 04:59 | |
| *** inteq has joined #openstack-oslo | 05:08 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use explicit WBE request state transitions https://review.openstack.org/114162 | 05:09 |
| *** tong_ has quit IRC | 05:12 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use explicit WBE request state transitions https://review.openstack.org/114162 | 05:12 |
| *** Krast has quit IRC | 05:31 | |
| *** harlowja_at_home has quit IRC | 05:35 | |
| *** ildikov has joined #openstack-oslo | 05:53 | |
| *** dims has joined #openstack-oslo | 05:54 | |
| *** dims has quit IRC | 05:58 | |
| openstackgerrit | Vlad Okhrimenko proposed a change to openstack/oslo.db: Add get_non_innodb_tables() to utils https://review.openstack.org/108994 | 05:58 |
| openstackgerrit | Vlad Okhrimenko proposed a change to openstack/oslo.db: Add get_non_innodb_tables() to utils https://review.openstack.org/108994 | 05:58 |
| *** Krast has joined #openstack-oslo | 06:09 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add WBE protocol message version properties https://review.openstack.org/101778 | 06:11 |
| *** stevemar has quit IRC | 06:22 | |
| *** AAzza_afk is now known as AAzza | 06:36 | |
| *** pblaho_ has joined #openstack-oslo | 06:45 | |
| *** mrda is now known as mrda-weekend | 06:46 | |
| *** pblaho_ has quit IRC | 06:46 | |
| *** pblaho_ has joined #openstack-oslo | 06:47 | |
| *** pblaho_ is now known as pblaho | 06:48 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/oslo.messaging: Sync jsonutils from oslo-incubator https://review.openstack.org/114454 | 07:18 |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/oslo.messaging: Sync jsonutils from oslo-incubator https://review.openstack.org/114454 | 07:20 |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/oslo.messaging: Sync jsonutils from oslo-incubator https://review.openstack.org/114454 | 07:22 |
| *** noelbk has joined #openstack-oslo | 07:40 | |
| *** ihrachyshka has joined #openstack-oslo | 07:58 | |
| openstackgerrit | YAMAMOTO Takashi proposed a change to openstack/oslo.messaging: Sync jsonutils from oslo-incubator https://review.openstack.org/114454 | 08:05 |
| *** ihrachyshka has quit IRC | 08:11 | |
| *** ihrachyshka has joined #openstack-oslo | 08:17 | |
| *** praneshp_ has quit IRC | 08:29 | |
| *** yamahata has quit IRC | 08:43 | |
| *** alexpilotti has joined #openstack-oslo | 09:10 | |
| YorikSar | harlowja: Nice list. Moved it to other global options. | 09:13 |
| *** markmc has joined #openstack-oslo | 09:18 | |
| *** pblaho is now known as pblaho|afk | 09:36 | |
| *** Alexei_987 has quit IRC | 09:36 | |
| *** noelbk has quit IRC | 09:39 | |
| amrith | YorikSar, g'morning. do you have any estimates on when oslo.concurrency will be ready for commits? | 09:41 |
| YorikSar | amrith: Hi. No... I'll ask this today on IRC oslo meeting. | 09:42 |
| amrith | YorikSar, sorry. I thought you were driving that. | 09:42 |
| YorikSar | amrith: I'm not even sure we should merge anything to oslo-incubator's process- and lockutils | 09:42 |
| YorikSar | amrith: I've created a CR to openstack-infra/config, but didn't get enough infra-core's +2s yet | 09:43 |
| amrith | hmm | 09:43 |
| amrith | I'm wondering what the process is going to be to get some of these changes into oslo.<something> and then merged back down into trove. | 09:44 |
| amrith | for some of them there's an OSSA component | 09:44 |
| amrith | and some incentive to get it into juno | 09:44 |
| YorikSar | amrith: So I'll ping them later when US wakes up. The only Europe-based infra-core (SergeyLukjanov) already +2d it. | 09:44 |
| YorikSar | Once oslo.concurrency will have the first release, you can switch Trove to use it and it'll get all the fixes in the world :) | 09:45 |
| amrith | 1600UTC, I'll be sure to be on that (I think I can) | 09:45 |
| amrith | YorikSar, that sounds scary but I think there should be enough time to shake through it. | 09:46 |
| YorikSar | amrith: There're some rather ugly things that will prevent release at first... | 09:47 |
| amrith | aw crap, I can't make it at 1600 UTC. I'll look at the log after the meeting. sorry. | 09:47 |
| YorikSar | amrith: So we might end up having only an alpha release before Juno. | 09:47 |
| amrith | does it make sense then to consider some changes (will provide a list) for merging into oslo-incubator | 09:47 |
| amrith | ahead of the split to o.c | 09:47 |
| amrith | https://review.openstack.org/#/c/109417/, https://review.openstack.org/#/c/109469/, https://review.openstack.org/#/c/110933/, and https://review.openstack.org/#/c/113407/ | 09:49 |
| amrith | the last one is strutils | 09:49 |
| amrith | so shouldn't go to o.c anyway. | 09:49 |
| amrith | if these four could merge to o-i, (the total loc change is small and the merge should be a snap) it would be great for the downstream projects. | 09:50 |
| amrith | that way they can merge from o-i in a small change without having to pick up whatever may come in o.c | 09:50 |
| amrith | and would virtually guarantee making to to juno, well before j3 | 09:51 |
| amrith | YorikSar, may I make a request of you. If I put this request into the agenda, would you be willing to present it to the team? I'm sorry but I won't be able to attend the meeting myself at that time. | 09:52 |
| YorikSar | amrith: We can't add anything to oslo.concurrency repo as repo itself is already on review (and Oslo team already approved it). | 09:55 |
| amrith | ok. | 09:55 |
| amrith | but can we add to oslo.incubator at this stage? | 09:55 |
| amrith | or is it frozen? | 09:55 |
| YorikSar | amrith: I think the way to go will be to port these CRs to oslo.concurrency once it's created. | 09:56 |
| *** Krast has quit IRC | 09:56 | |
| YorikSar | amrith: And after split happens we _might_ land those changes to oslo-incubator as well... | 09:56 |
| amrith | ok, so the option of merging into oslo.incubator now would not be a viable one? | 09:56 |
| YorikSar | amrith: I'm not sure. I'll verify that on the meeting. | 09:57 |
| amrith | ok, thanks. | 09:57 |
| YorikSar | amrith: I'm actually new to Oslo and its processes :) | 09:57 |
| amrith | oh, ok. may I stick it on the agenda with a note that you and I put it there? | 09:57 |
| YorikSar | I've got oslo.concurrency by accident when Ben went on vacation :) | 09:57 |
| YorikSar | Do you have link to the agenda at hand? | 09:58 |
| amrith | yes, am editing it now | 09:58 |
| amrith | https://wiki.openstack.org/w/index.php?title=Meetings/Oslo&action=edit§ion=1 | 09:58 |
| YorikSar | amrith: I think there should be an item on oslo.concurrency | 09:59 |
| YorikSar | Yes, thanks. | 09:59 |
| YorikSar | Add a subitem under that oslo.cocurrency item and mark it with our nicks. | 09:59 |
| amrith | done | 09:59 |
| amrith | or rather, doing ;) | 09:59 |
| YorikSar | :) | 10:00 |
| YorikSar | amrith: Wow... Quite a load of CRs you have there... | 10:01 |
| amrith | done, updated https://wiki.openstack.org/wiki/Meetings/Oslo#Agenda_for_Next_Meeting | 10:03 |
| YorikSar | amrith: On one hand, it'd be not very right to freeze code in incubator right now (I doubt anyone will adopt the library in Juno). On the other hand, maintaining 2 almost similar codebases can turn out to be a nightmare. | 10:03 |
| amrith | I think dhellmann will be running the meeting today so I'll drop him a note about this. | 10:04 |
| amrith | re: o-i now ... | 10:04 |
| amrith | I'm not sure about that | 10:04 |
| amrith | if changes went into o-i now, I think projects would sync before j3 | 10:04 |
| amrith | I would certainly say that Trove would sync these changes. | 10:04 |
| amrith | but if it gets much later I don't think we'll have the option. | 10:05 |
| YorikSar | Yeah... | 10:05 |
| amrith | which is what I fear with the oslo.concurrency route | 10:05 |
| YorikSar | Maybe we can leave incubator open for some time (until j3?) to let these fixes land. | 10:06 |
| amrith | one issue there is that these changes merge two files (processutils.py and strutils.py) and with dependencies that may include a number of files in the sync (already). | 10:06 |
| amrith | and all of these pose some destabilization risk to the projects. | 10:06 |
| amrith | yes, | 10:06 |
| YorikSar | amrith: btw, strutils are already separated to oslo.utils, aren't they? | 10:06 |
| amrith | leaving o-i open till j3 would be much appreciated | 10:06 |
| amrith | I (one second) not sure | 10:06 |
| YorikSar | amrith: Ah, but incubator code uses incubator version of strutils... | 10:07 |
| amrith | doesn't look it | 10:07 |
| amrith | yes | 10:07 |
| amrith | OH crap | 10:07 |
| amrith | do I have to make the same change in oslo.utils? | 10:07 |
| amrith | This "copying code around" is going to be the death of me ;( | 10:07 |
| amrith | oh great ... oslo.utils version of strutils.py is different from oslo-incubator version. | 10:08 |
| amrith | this is just peachy ;) | 10:08 |
| amrith | oops, have to run. someone at the door. it is 6am and someone at the door. that's weird | 10:09 |
| amrith | will be right back | 10:09 |
| YorikSar | amrith: That's the fallout of abused incubator... | 10:09 |
| YorikSar | amrith: I hope to hear from you soon. | 10:10 |
| YorikSar | (good people don't come to others' doors at 6am) | 10:10 |
| YorikSar | amrith: https://wiki.openstack.org/wiki/Oslo#Graduation | 10:13 |
| YorikSar | When that process starts, the MAINTAINERS file should be updated so the status of the module(s) is "Graduating". While the module is in the Graduating state, bug fixes and features will need to be maintained in the incubator and in the new library. | 10:13 |
| YorikSar | So, I guess, until the first release of oslo.concurrency you'll have to port changes around. | 10:14 |
| amrith | am back | 10:19 |
| amrith | that was a delivery | 10:19 |
| amrith | at 6am | 10:19 |
| amrith | that's fine, I can port changes around. | 10:20 |
| *** pcm_ has joined #openstack-oslo | 10:20 | |
| *** pcm_ has joined #openstack-oslo | 10:21 | |
| *** dims has joined #openstack-oslo | 10:25 | |
| YorikSar | What can be delivered at 6am? Breakfast? | 10:25 |
| amrith | a mattress | 10:25 |
| YorikSar | I guess, 6am is a bit too late for mattress :D | 10:26 |
| amrith | it was supposed to be 7:30am - 10:30am | 10:26 |
| amrith | yes, just a bit late for yesterday | 10:26 |
| amrith | but early for today ... | 10:26 |
| *** dims has quit IRC | 10:32 | |
| amrith | YorikSar, does that item on the agenda look ok? | 10:37 |
| *** rpodolyaka has quit IRC | 10:43 | |
| *** ihrachyshka_ has joined #openstack-oslo | 10:45 | |
| *** rpodolyaka has joined #openstack-oslo | 10:45 | |
| *** ihrachyshka has quit IRC | 10:46 | |
| *** Alexei_987 has joined #openstack-oslo | 10:51 | |
| YorikSar | amrith: Yeah, it's fine. We'll just clarify these points. | 11:04 |
| *** pblaho|afk is now known as pblaho | 11:05 | |
| *** dims has joined #openstack-oslo | 11:06 | |
| openstackgerrit | Vipin Balachandran proposed a change to openstack/oslo.vmware: Exception hierarchy refactoring https://review.openstack.org/114503 | 11:08 |
| *** dims has quit IRC | 11:12 | |
| *** dims has joined #openstack-oslo | 11:12 | |
| openstackgerrit | Vipin Balachandran proposed a change to openstack/oslo.vmware: Exception hierarchy refactoring https://review.openstack.org/114503 | 11:17 |
| *** pblaho is now known as pblaho|afk | 11:20 | |
| *** SridharG has joined #openstack-oslo | 11:27 | |
| *** SridharG has quit IRC | 11:37 | |
| ihrachyshka_ | hey. what are the plans to release new oslo.db? | 11:50 |
| *** inteq has quit IRC | 11:50 | |
| ihrachyshka_ | rpodolyaka: ^^ have you heard anything on the matter? | 11:54 |
| rpodolyaka | ihrachyshka_: hey! as soon as we sort out the problems with a few new exceptions raised in consuming projects | 11:56 |
| rpodolyaka | ihrachyshka_: patches are on review, but haven't been merged yet | 11:56 |
| *** ildikov has quit IRC | 11:56 | |
| rpodolyaka | ihrachyshka_: so I hope we'll cut a release next week | 11:57 |
| ihrachyshka_ | rpodolyaka: ok. I need that new version to bump global dependencies to the one that will set raise_on_warnings=False for mysqlconnector :) | 11:57 |
| ihrachyshka_ | great, thanks | 11:57 |
| rpodolyaka | sure, np | 11:57 |
| ihrachyshka_ | it's great to have people involved around your TZ :) | 11:58 |
| *** ihrachyshka_ is now known as ihrachyshka | 11:58 | |
| *** ildikov has joined #openstack-oslo | 11:58 | |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Add Pylint testenv environment https://review.openstack.org/111725 | 12:00 |
| *** amotoki has quit IRC | 12:17 | |
| *** pblaho|afk is now known as pblaho | 12:24 | |
| *** gordc has joined #openstack-oslo | 12:29 | |
| *** pblaho is now known as pblaho|afk | 12:39 | |
| *** AAzza is now known as AAzza_afk | 12:59 | |
| *** russellb is now known as rustlebee | 13:03 | |
| *** pcm__ has joined #openstack-oslo | 13:11 | |
| *** AAzza_afk is now known as AAzza | 13:13 | |
| *** dims_ has joined #openstack-oslo | 13:13 | |
| *** YorikSar_ has joined #openstack-oslo | 13:13 | |
| *** dims has quit IRC | 13:20 | |
| *** pcm_ has quit IRC | 13:20 | |
| *** YorikSar has quit IRC | 13:20 | |
| *** cdent has joined #openstack-oslo | 13:22 | |
| *** bknudson has quit IRC | 13:22 | |
| cdent | sileht: when you have a moment could you restamp the following, you put a +2 on it a while ago, but a problem was identified: https://review.openstack.org/#/c/108410/ | 13:22 |
| *** mriedem has joined #openstack-oslo | 13:23 | |
| *** AAzza is now known as AAzza_afk | 13:27 | |
| *** bknudson has joined #openstack-oslo | 13:40 | |
| *** cdent_ has joined #openstack-oslo | 13:43 | |
| *** cdent has quit IRC | 13:45 | |
| *** cdent_ is now known as cdent | 13:45 | |
| *** pblaho|afk is now known as pblaho | 13:55 | |
| *** markmcclain has joined #openstack-oslo | 14:03 | |
| *** stevemar has joined #openstack-oslo | 14:08 | |
| *** markmcclain1 has joined #openstack-oslo | 14:13 | |
| *** markmcclain has quit IRC | 14:15 | |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Log additional details of suds faults https://review.openstack.org/104534 | 14:21 |
| *** gordc_ has joined #openstack-oslo | 14:23 | |
| *** gordc_ has quit IRC | 14:23 | |
| *** jecarey has joined #openstack-oslo | 14:26 | |
| *** pblaho has quit IRC | 14:28 | |
| *** jeckersb has joined #openstack-oslo | 14:31 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: port ds_util from nova to oslo.vmware https://review.openstack.org/114551 | 14:33 |
| dhellmann | YorikSar_, amrith : the policy for backports is described in https://wiki.openstack.org/wiki/Oslo#Graduation | 14:34 |
| * amrith runs to read | 14:34 | |
| amrith | dhellmann, I guess my request boils down to this. "During this phase, only critical bug fixes will be allowed in the incubator version of the code. " ... Do my fixes rise to the level of "critical bug fixes". | 14:35 |
| amrith | dhellmann, a question also re: oslo.utils. Is it now graduated? I'm assuming yes. There is code in o-in that doesn't match oslo.utils (strutils.py). How does one reconcile those? | 14:36 |
| dhellmann | amrith: what are the differences? | 14:37 |
| amrith | there's no mask_password() in strutils.py in oslo.utils | 14:37 |
| dhellmann | amrith: sorry, and remind me again what your fix is (I know you've told me...) | 14:37 |
| dhellmann | amrith: ah, I think that's slated to move to oslo.log, let me check my notes | 14:38 |
| amrith | three of the fixes are for processutils.py and relate to passwords in log.message, and to an issue with retrying communicate() after failure. | 14:38 |
| amrith | the fix to strutils.py is to make mask_password() better | 14:38 |
| amrith | it changes the regexps used there. | 14:38 |
| amrith | let me get you a link for the two files | 14:38 |
| dhellmann | amrith: ok, I remember that one now (sorry, lots of patches to keep in my head) | 14:39 |
| *** tsekiyama has joined #openstack-oslo | 14:39 | |
| amrith | https://github.com/openstack/oslo.utils/blob/master/oslo/utils/strutils.py and https://github.com/openstack/oslo-incubator/blob/master/openstack/common/strutils.py | 14:39 |
| *** dims_ is now known as dimsum | 14:40 | |
| *** dimsum is now known as dimsum_ | 14:40 | |
| dhellmann | hmm, the spec says mask_password should be there http://git.openstack.org/cgit/openstack/oslo-specs/plain/specs/juno/graduate-oslo-utils.rst | 14:40 |
| dhellmann | I do remember talking about that, though, let me see if there's anything in the logging spec | 14:41 |
| dhellmann | ah, yeah: http://git.openstack.org/cgit/openstack/oslo-specs/plain/specs/juno/graduate-oslo-log.rst | 14:41 |
| dhellmann | Expose :func:`mask_password` through log.py but move the | 14:41 |
| dhellmann | implementation to a private module to hide the global variables it | 14:41 |
| dhellmann | uses. | 14:41 |
| *** ildikov has quit IRC | 14:43 | |
| amrith | so ... mask_password() moved from logging (I think) to strutils | 14:43 |
| amrith | in oslo incubator | 14:43 |
| amrith | let me find you that commit | 14:43 |
| amrith | https://github.com/openstack/oslo-incubator/commit/cb5a804bd4692e647fb49727d8929db5c8d75aa2 | 14:43 |
| YorikSar_ | dhellmann: So do I get it right: all patches that are on review for incubator can land to incubator with intend to have port for oslo.* lib available later, until first version of the lib is published. | 14:47 |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Update oslo.utils spec mention of mask_password https://review.openstack.org/114558 | 14:47 |
| YorikSar_ | dhellmann: btw, which version is this about? First alpha or first 0.1/1.0? | 14:47 |
| d0ugal | What version of oslo.config was the oslo-config-generator utility added? | 14:48 |
| d0ugal | ah, looks like 1.4 - there isn't a final release yet right? | 14:49 |
| jeckersb | markmc: hey, i wanted to pop in, say hi, and let you know i'm digging into the rabbitmq heartbeat stuff | 14:50 |
| markmc | jeckersb, oh, hey! awesome | 14:51 |
| amrith | YorikSar_, I'm heading to my 11:30-1 meeting so I'll read the transcript of the oslo meeting when I get back to a PC. ttyl! | 14:51 |
| markmc | d0ugal, right, still only in alpha - http://docs.openstack.org/developer/oslo.config/#a2 | 14:51 |
| amrith | YorikSar_, I also brought the issue of strutils.py to dhellmann's attention | 14:52 |
| d0ugal | markmc: aha, thanks - I'll hold off migrating to it then :) | 14:52 |
| amrith | YorikSar_, ^^ ttyl | 14:52 |
| markmc | d0ugal, migrating to it in which project? | 14:52 |
| d0ugal | markmc: Tuskar | 14:52 |
| *** YorikSar_ is now known as YorikSar | 14:52 | |
| markmc | jeckersb, would be worth saying hi to jamespage on #openstack-dev too | 14:52 |
| markmc | jeckersb, well, all Juno projects are happily using alpha oslo libs | 14:53 |
| markmc | d0ugal, sorry, that's for you | 14:53 |
| YorikSar | amrith: Yes, I've read that. See you. | 14:53 |
| markmc | d0ugal, they'll all get final releases closer to the Juno release | 14:53 |
| d0ugal | markmc: oh, maybe I'll go for it then. | 14:53 |
| d0ugal | Migrated to oslo.db earlier this week, was looking to see what else we should use :) | 14:53 |
| *** zhiyan has quit IRC | 14:53 | |
| *** zhiyan has joined #openstack-oslo | 14:54 | |
| markmc | d0ugal, could take a look at https://github.com/markmc/nova/commit/dd2aaac15d18a064c92bea589ec4586d8583cbe3 | 14:54 |
| jeckersb | markmc: ok that's good to know, i noticed it was not so nice for icehouse | 14:54 |
| markmc | d0ugal, but I presume it would easier for tuskar | 14:54 |
| d0ugal | markmc: Probably, we have very few custom config options. I'll take a look, thanks! | 14:55 |
| markmc | d0ugal, np | 14:55 |
| dhellmann | amrith: see https://review.openstack.org/114558 | 15:04 |
| dhellmann | YorikSar: for a new lib, we're using version 0.1.0 as the first release (see https://wiki.openstack.org/wiki/Oslo/VersioningPolicy for details) | 15:04 |
| YorikSar | dhellmann: So incubator is open for changes until 0.1.0 or until 0.1.0a1? | 15:05 |
| *** ildikov has joined #openstack-oslo | 15:05 | |
| dhellmann | YorikSar: we don't use alpha releases of versions < 1.0 | 15:10 |
| YorikSar | dhellmann: Ah, ok. | 15:11 |
| dhellmann | YorikSar: all of the concurrency stuff is completely frozen right now until we get the new repo created; then changes need to go into oslo.concurrency first, and the incubator can be treated like a stable branch for backports | 15:11 |
| dhellmann | after the repo is imported, we'll do whatever cleanup work is needed for the new library (hiding things that should be implementation details, updating docs, etc.) and then prepare a 0.1.0 release | 15:12 |
| YorikSar | dhellmann: I think this is not mentioned on wiki... | 15:12 |
| YorikSar | dhellmann: (I mean the direction of porting stuff) | 15:12 |
| dhellmann | if we need to make more changes, we will release 0.1.1 or 0.2.0 (using semver rules to decide which) and then at the end of juno we will evaluate using 1.0 | 15:12 |
| dhellmann | https://wiki.openstack.org/wiki/Oslo#Graduation should have all of the backporting "rules" but please let me know if we can make that clearer, the wording probably has room for improvement :-) | 15:13 |
| YorikSar | dhellmann: Yes, I get how I got confused. | 15:15 |
| YorikSar | There are words: All changes should be proposed first to the new library repository, and then bug fixes can be back-ported to the incubator. | 15:15 |
| YorikSar | But they are in 'post-new-release' part I wasn't giving enough attention to. | 15:16 |
| dhellmann | YorikSar: ok, so it's clear now? I want to make sure we're careful with the policies, so if there's a way to improve it we should | 15:22 |
| dimsum_ | dhellmann: should we get code in oslo-incubator to "adopt" oslo.utils first? this is causing some issues in nova as nova/openstack/common will still refer to the old modules in there | 15:22 |
| dimsum_ | dhellmann: suggestion was from markmc on the nova/oslo.utils review | 15:22 |
| dhellmann | dimsum_, markmc : that will force projects that want bug fixes in those incubated modules to adopt oslo.utils to get them. Is there global state involved, or different versions of functions? | 15:23 |
| YorikSar | dhellmann: Is it ok if I edit that page? I'll move this sentence higher so that it'll be totally clear that this rule works since graduation starts. | 15:24 |
| dhellmann | YorikSar: sure | 15:24 |
| amrith | dhellmann, sorry 2 b terse, am on a ph. the direction is inverted. we went from log to strutils, not the other way. | 15:24 |
| dimsum_ | dhellmann: test issues due to override_time/utcnow in multiple copies | 15:25 |
| dimsum_ | dhellmann: and i can't remove older modules from nova/openstack/common and folks will continue to use it | 15:26 |
| dhellmann | amrith: mask_password is in strutils in the incubator, but since it is related to logging I thought we were moving it to oslo.log? that's what I found in the oslo.log spec, in any case | 15:26 |
| dhellmann | dimsum_: ah, ok | 15:27 |
| amrith | oh? | 15:27 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add WBE protocol message version properties https://review.openstack.org/101778 | 15:27 |
| dhellmann | dimsum_: sure, let's see what the incubator looks like using oslo.utils, then. | 15:27 |
| * dhellmann wonders if we should have worked top down instead of bottom up | 15:27 | |
| amrith | dhellmann, on july 2 it appears someone went the other way in oslo-incubator | 15:28 |
| * dhellmann head desk | 15:28 | |
| amrith | maybe the decision you speak of came after | 15:28 |
| dimsum_ | dhellmann: ack. thanks | 15:28 |
| *** ihrachyshka has quit IRC | 15:29 | |
| dhellmann | amrith: let me find that discussion, I think it was in a meeting | 15:29 |
| dhellmann | dimsum_: do you remember talking about mask_password? | 15:29 |
| dimsum_ | it got moved i believe | 15:30 |
| dhellmann | dimsum_: according to the specs, we were going to put that in the oslo.log library, but it was moved to strutils instead? and it's not in oslo.utils? | 15:31 |
| dhellmann | maybe next cycle we should create a branch at the beginning for backports, and just delete things from the master version of the incubator as we go along | 15:32 |
| YorikSar | dhellmann: https://wiki.openstack.org/w/index.php?title=Oslo&diff=60632&oldid=60443 - is it fine? | 15:33 |
| dimsum_ | right, dhellmann, we took it out of oslo.utils per spec - https://github.com/openstack/oslo-specs/blob/master/specs/juno/graduate-oslo-utils.rst | 15:33 |
| dimsum_ | hmm, not reading this right | 15:34 |
| dhellmann | dimsum_: http://specs.openstack.org/openstack/oslo-specs/specs/juno/graduate-oslo-log.html | 15:34 |
| dhellmann | dimsum_: somehow we have competing specs :-) | 15:34 |
| dhellmann | dimsum_: FWIW, having it in strutils does make sense, too. | 15:35 |
| dimsum_ | now that we are where we are....keeping mask_password out of oslo.utils seems ok. no? | 15:35 |
| amrith | dhellmann, YorikSar ... have to go away. my 11:30 meeting just showed up (fashionably late). sorry | 15:35 |
| dhellmann | dimsum_: well, where is it going to go? if we didn't want something else to rely on oslo.log, maybe oslo.utils is the right place and we should move it over there? | 15:35 |
| dhellmann | dimsum_: esp. as we are trying to not have any libraries depend on oslo.log now -- maybe that log spec is the "old" version? | 15:36 |
| dhellmann | we need a better way to track all of these changes, because I can't keep them in my head | 15:36 |
| dhellmann | maybe one big document instead of a bunch of little specs | 15:36 |
| dhellmann | this should be less of a problem as we move up the stack, I suppose | 15:37 |
| dimsum_ | dhellmann: no one is using mask_password other than log and processutils from what i can tell | 15:38 |
| dhellmann | YorikSar: that looks good, thank you | 15:38 |
| dimsum_ | where is processutils heading to? | 15:38 |
| dhellmann | dimsum_: oslo.concurrency | 15:38 |
| dhellmann | ok, let's put mask_password into oslo.utils (copy the incubated version over, then let amrith repropose his changes to the new repo) so that we can maintain our rule of not having libraries depend on oslo.log | 15:38 |
| dimsum_ | ack | 15:39 |
| *** mriedem is now known as mattykins | 15:41 | |
| dhellmann | dimsum_, amrith : I think when we made the original decision only oslo.log used mask_password so making it a private function there made sense | 15:41 |
| *** mattykins is now known as matty_kins | 15:41 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Remove mask_password from oslo.log https://review.openstack.org/114579 | 15:43 |
| dhellmann | dimsum_, amrith : ^^ | 15:43 |
| *** praneshp has joined #openstack-oslo | 15:44 | |
| dimsum_ | dhellmann: so, would oslo.log depend on oslo.utils? or private copy of method | 15:44 |
| dhellmann | dimsum_: oslo.log can use oslo.utils, that's not a problem | 15:45 |
| dhellmann | dimsum_: so we'll have one public version of the function in oslo.utils.strutils | 15:45 |
| dhellmann | brb | 15:45 |
| *** praneshp_ has joined #openstack-oslo | 15:47 | |
| *** markmcclain1 has quit IRC | 15:48 | |
| *** praneshp has quit IRC | 15:49 | |
| *** praneshp_ is now known as praneshp | 15:49 | |
| *** pblaho has joined #openstack-oslo | 15:51 | |
| dhellmann | team meeting in 5 min in #openstack-meeting-alt | 15:56 |
| *** bnemec is now known as beekneemech | 16:01 | |
| *** markmcclain has joined #openstack-oslo | 16:22 | |
| *** markmcclain has quit IRC | 16:27 | |
| *** jogo is now known as flashgordon | 16:28 | |
| *** markmcclain has joined #openstack-oslo | 16:44 | |
| *** markmcclain has quit IRC | 16:47 | |
| *** markmcclain has joined #openstack-oslo | 16:47 | |
| *** markmcclain has quit IRC | 16:48 | |
| *** markmcclain has joined #openstack-oslo | 16:49 | |
| *** markmcclain has quit IRC | 16:51 | |
| *** dimsum_ has quit IRC | 16:55 | |
| *** dims has joined #openstack-oslo | 16:58 | |
| *** openstackgerrit has quit IRC | 17:02 | |
| dhellmann | beekneemech: I'm going to grab lunch before I read through that patch | 17:02 |
| *** pblaho has quit IRC | 17:02 | |
| *** openstackgerrit has joined #openstack-oslo | 17:02 | |
| beekneemech | dhellmann: Sounds good, thanks | 17:02 |
| *** harlowja_away is now known as harlowja | 17:03 | |
| harlowja | YorikSar so I keep on wondering if we should really just go back to using filelocks :-/ | 17:10 |
| harlowja | AB3 and such are nice (and would likely work) but jeez it just seems complex :-/ | 17:10 |
| *** markmc has quit IRC | 17:13 | |
| *** shakamunyi has joined #openstack-oslo | 17:24 | |
| dims | dhellmann: ping | 17:29 |
| dims | beekneemech: ping | 17:30 |
| beekneemech | dims: pong | 17:30 |
| dims | beekneemech: mask_password - can you please take a quick peek? https://review.openstack.org/#/c/113407/ once that goes through i'll submit a oslo.utils sync to bring in mask_password | 17:31 |
| *** matty_kins is now known as mriedem | 17:32 | |
| beekneemech | dims: I thought we were just going to move it and then make the changes after. | 17:32 |
| dims | ah ok will do that then | 17:33 |
| dhellmann | dims: yeah, backport protocol | 17:33 |
| openstackgerrit | Andreas Jaeger proposed a change to openstack/oslo.concurrency: Initial translation setup https://review.openstack.org/114608 | 17:34 |
| * beekneemech is totally not trying to avoid reviewing a regex change | 17:34 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Increase/adjust the logging of the WBE response/send activities https://review.openstack.org/102959 | 17:39 |
| *** shakamunyi has quit IRC | 17:43 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.utils: New public API for mask_password ported from incubator https://review.openstack.org/114611 | 17:44 |
| *** Alexei_987 has quit IRC | 17:45 | |
| dhellmann | beekneemech, dims: regarding that mock change, maybe this is something we just want to do after graduation? | 17:50 |
| dhellmann | beekneemech, dims : i.e., not make this change in the incubator at all, but allow it in the libraries | 17:51 |
| *** praneshp has quit IRC | 17:51 | |
| dims | "mock change"? | 17:51 |
| *** dims is now known as dimsum_ | 17:52 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.utils: Make strutils.mask_password more secure https://review.openstack.org/114614 | 17:55 |
| dhellmann | dimsum_: https://review.openstack.org/#/c/87375/18 | 17:55 |
| dimsum_ | dhellmann: lined up 2 reviews in oslo.utils, 114611 for the port/sync of existing mask_password. 114614 is basically Amrith(s) patch against oslo.utils | 17:56 |
| beekneemech | dhellmann: So, skip the change entirely, or just for the files that are already graduating? | 17:57 |
| dhellmann | dimsum_: cool, thanks | 17:57 |
| dimsum_ | dhellmann: ack. need to minimize churn in oslo-incubator | 17:57 |
| dhellmann | beekneemech: the whole thing | 17:57 |
| *** shakamunyi has joined #openstack-oslo | 17:57 | |
| beekneemech | I'm a little fuzzy on how we're running any py3 tests without this. I guess everything we're running uses mox? | 17:57 |
| dhellmann | beekneemech: yeah | 17:58 |
| dhellmann | beekneemech: or just uses the installed version of mock | 17:58 |
| dhellmann | beekneemech: if we don't allow this now, then we can allow a smaller change later when we remove some of these modules in kilo | 17:59 |
| dhellmann | something in k1 | 17:59 |
| dhellmann | but I don't think we want to try to take only part of it now | 17:59 |
| beekneemech | dhellmann: Yeah, as long as we do it before we start graduating anything else. :-) | 17:59 |
| dhellmann | beekneemech: the more I think about it, the more I think the first change for kilo will be to branch so we can delete stuff as we graduate it | 18:00 |
| beekneemech | dhellmann: That probably makes sense. Rather than treat master as a stable branch, have an actual stable branch. | 18:05 |
| beekneemech | Although, we already have stable branches. | 18:06 |
| dhellmann | beekneemech: yeah, we'd need to come up with a new name for the branch :-/ | 18:06 |
| *** zzzeek has joined #openstack-oslo | 18:15 | |
| YorikSar | harlowja: We might. I'd wait for more opinions about that. | 18:16 |
| dhellmann | beekneemech: and I guess it could only be for backports of graduating modules, which would make the rules for submitting patches more complicated | 18:16 |
| YorikSar | harlowja: And AB3 is not that complex at all ;) | 18:16 |
| YorikSar | harlowja: I like this low-level stuff | 18:16 |
| harlowja | YorikSar understand :) | 18:16 |
| amrith | YorikSar, dhellmann ... I'm back and trying to catch up on what you folks discussed while I was away | 18:18 |
| beekneemech | dhellmann: Yeah, it would definitely complicate things. | 18:18 |
| YorikSar | dhellmann: Should I ask infra team to add someone else to oslo-concurrency-core/-ptl? | 18:19 |
| YorikSar | dhellmann: (but oslo-* groups) | 18:19 |
| beekneemech | dhellmann: I'm not real familiar with how this sort of branching works - is there some way we can create the branch and just move modules there as they graduate? So we'd have a graduated branch and a master branch. | 18:19 |
| dhellmann | YorikSar: the oslo-ptl group should be in oslo-concurrency-ptl and oslo-core should be in oslo-concurrency-core | 18:20 |
| beekneemech | I guess I don't know if there's a sane way to move things between branches like that though. | 18:20 |
| dhellmann | beekneemech: no, not really, that's why I was suggesting branching and then deleting from master | 18:20 |
| YorikSar | dhellmann: And noone else initially, right? | 18:20 |
| beekneemech | dhellmann: Yeah, I was just trying to come up with a way to make it extremely clear which changes should go into the graduated branch. | 18:21 |
| beekneemech | If none of the ungraduated code is even there, then nobody can accidentally propose a change to it. :-) | 18:21 |
| dhellmann | beekneemech: true | 18:22 |
| beekneemech | We also have a divergence problem then - any code in the graduated branch that is also in master needs to be kept in sync between them. | 18:22 |
| beekneemech | Otherwise if it graduates part way through the cycle it'll be a mess. | 18:22 |
| YorikSar | dhellmann: Oh, wait... Should I add myself there? | 18:24 |
| dhellmann | YorikSar: if you're willing to be the lead, then yes | 18:26 |
| YorikSar | dhellmann: I do. I just thought there should be some kind of vote or smth. | 18:27 |
| dhellmann | YorikSar: we can confirm it, but you're doing the work so I don't think it's going to be a problem | 18:28 |
| dhellmann | YorikSar: look at the maintainers file in the incubator and add anyone who was managing a module in oslo.concurrency to oslo-concurrency-core (it may just be Michael Stills) | 18:29 |
| YorikSar | fungi: Sorry, oslo-concurrency-core: +mikalstill | 18:33 |
| dhellmann | YorikSar: if you're in the group, you can add people I think | 18:33 |
| YorikSar | dhellmann: Oh, wrong channel... | 18:33 |
| dhellmann | YorikSar: so get fungi to add your user, and then you can do the rest (spares them from the extra load) | 18:33 |
| YorikSar | dhellmann: Ok, won't trouble fungi with Michael then. | 18:34 |
| YorikSar | dhellmann: Thanks for your help! | 18:36 |
| *** praneshp has joined #openstack-oslo | 18:39 | |
| amrith | dhellmann, YorikSar if I understand the discussion correctly, strutils change is good to go into oslo-incubator and will be merged into oslo.utils in dims' change. the processutils change is to wait for o.c which will be soon. | 18:43 |
| openstackgerrit | A change was merged to openstack/oslo.vmware: Add methods to the Datastore objects https://review.openstack.org/109160 | 18:45 |
| *** Alexei_987 has joined #openstack-oslo | 18:49 | |
| *** praneshp has quit IRC | 18:54 | |
| amrith | dimsum_, yt? | 18:54 |
| dimsum_ | hey amrith | 18:55 |
| dimsum_ | did i mess sth up? :) | 18:55 |
| amrith | hi dimsum_ ... is oslo a "one +2 and you are good to go" or a "two +2's required" | 18:55 |
| amrith | no all looks good | 18:55 |
| amrith | just wanted to know when I could expect to see strutils land in o-i | 18:55 |
| amrith | so I could plan to sync down to trove | 18:55 |
| amrith | I see you +2'ed it | 18:55 |
| amrith | I just wanted to know if there needed to be one more +2 or it would get merged | 18:56 |
| dimsum_ | sequence is...oslo.utils should go in first and then backport into oslo-incubator. beekneemech and dhellmann promised to help push these through ASAP | 18:56 |
| dimsum_ | usually takes time to take things through the gate/check jobs as well as you know | 18:57 |
| dimsum_ | watch out for any feedback on the 2 reviews with your changes | 18:58 |
| dhellmann | amrith: we require 2 +2 like the other openstack projects | 18:59 |
| amrith | ok. thanks! | 19:00 |
| *** cdent has quit IRC | 19:00 | |
| dimsum_ | amrith: you in cambridge? | 19:01 |
| amrith | yup | 19:01 |
| amrith | not right now | 19:01 |
| amrith | but that's where the office is | 19:01 |
| amrith | now I'm at home | 19:01 |
| amrith | are you local as well? | 19:01 |
| dimsum_ | ah. i live south of you...sharon,ma | 19:01 |
| YorikSar | amrith: btw, oslo.concurrency repo is created, you can start porting your processutils changes there. | 19:02 |
| amrith | south east of me, more east than south. I'm near leomonster. | 19:02 |
| amrith | YorikSar, thanks | 19:02 |
| amrith | I will start that now | 19:02 |
| amrith | you'll have code by morning your time | 19:02 |
| amrith | I think it is getting pretty late for you now, yes? | 19:02 |
| openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Bypass vCenter when uploading to datastores https://review.openstack.org/114634 | 19:13 |
| YorikSar | amrith: It is. And tomorrow is Saturday, so I doubtly will review your code. ;) | 19:14 |
| dhellmann | amrith, YorikSar : I think dims already ported your patch to oslo.utils in https://review.openstack.org/#/c/114614/ didn't he? (not landed, but submitted) | 19:20 |
| amrith | dhellmann, he did. | 19:23 |
| amrith | I've seen it | 19:23 |
| dhellmann | amrith: ok, just wanted to make sure you didn't do any extra work! :-) | 19:24 |
| dhellmann | amrith: oh, wait, I misread YorikSar's comments in the scrollback, he's talking about different changes -- carry on and ignore me | 19:24 |
| amrith | dhellmann, I think dimsum_ did the strutils change. I have to do the processutils change into o.c | 19:25 |
| dhellmann | amrith: got it | 19:26 |
| amrith | ok folks. have a good weekend YorikSar dhellmann dimsum_ ... | 19:27 |
| dimsum_ | you too amrith | 19:28 |
| YorikSar | amrith: You too :) | 19:28 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Split requirements into py2 and py3 files https://review.openstack.org/114641 | 19:33 |
| *** AAzza_afk is now known as AAzza | 19:43 | |
| *** ruhe has quit IRC | 19:51 | |
| *** dmitryme has quit IRC | 19:52 | |
| *** SergeyLukjanov has quit IRC | 19:52 | |
| *** dmitryme has joined #openstack-oslo | 19:55 | |
| YorikSar | dhellmann: In the graduation wiki page there is step 'Add a .gitreview File to the Repository'. afaiu it's added by cookiecutter template. | 19:57 |
| YorikSar | dhellmann: I'll remove this step, ok? | 19:57 |
| YorikSar | (and item in TODO list) | 19:57 |
| dhellmann | YorikSar: yeah, I think the way the cookiecutter template is applied changed to make that work, so we don't have to do it by hand any more | 19:58 |
| YorikSar | dhellmann: And then there's no way to verify that jobs run fine (except first CR someone would create) | 20:00 |
| *** SergeyLukjanov has joined #openstack-oslo | 20:00 | |
| dhellmann | YorikSar: that might have been part of why I didn't worry about the .gitreview file -- it's a simple enough commit to get right to trigger the tests | 20:00 |
| dhellmann | YorikSar: is there a step about making sure the documentation builds? that would be another reasonable first step | 20:01 |
| YorikSar | dhellmann: Yeah. I got failing docs in oslo.concurrency :) | 20:01 |
| *** ruhe has joined #openstack-oslo | 20:03 | |
| YorikSar | dhellmann: But it looks like all it needs is sphinx in test-requirements.txt, and that can be done by cookiecutter too. | 20:03 |
| openstackgerrit | gordon chung proposed a change to openstack/oslo.middleware: add doc generation support https://review.openstack.org/114645 | 20:03 |
| *** bknudson has quit IRC | 20:09 | |
| *** mriedem1 has joined #openstack-oslo | 20:11 | |
| *** mriedem1 has quit IRC | 20:11 | |
| *** mriedem1 has joined #openstack-oslo | 20:12 | |
| *** mriedem has quit IRC | 20:13 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.concurrency: Fix docs generation https://review.openstack.org/114647 | 20:15 |
| dhellmann | YorikSar: I don't have +2 on oslo.concurrency yet, did you update the members of those groups? | 20:18 |
| dhellmann | YorikSar: I can't help you with reviews unti that's done :-) | 20:18 |
| YorikSar | dhellmann: No, not yet... | 20:18 |
| YorikSar | dhellmann: Let me ask on -infra... | 20:18 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: EXPERIMENT: switch oslo-incubator to use oslo.utils https://review.openstack.org/114649 | 20:20 |
| *** AAzza is now known as AAzza_afk | 20:26 | |
| YorikSar | dhellmann: Looking at Zuul I think adding all devstack jobs to a new library is a bad idea... | 20:29 |
| dhellmann | YorikSar: we need to integration-test our changes so we know we're not breaking projects | 20:30 |
| dhellmann | YorikSar: when we have more functional tests, it's possible we can have fewer full integration tests, but in the mean time we need to be careful | 20:31 |
| YorikSar | dhellmann: But until the library is at least released (or even used by some project), these jobs just make Jenins runs longer and eat Jenkins workers... | 20:31 |
| dhellmann | YorikSar: we need the job in place before projects adopt the library, otherwise there will be a window of time when we could introduce changes that break that adoption | 20:33 |
| dhellmann | for example, if glance adopts oslo.db before we are gating oslo.db on glance, and then something in oslo.db changes to break glance, we won't catch it until tests for glance run with the new version of oslo.db | 20:34 |
| dhellmann | YorikSar: so for a little while we are wasteful, but it's not very long (we hope) | 20:35 |
| YorikSar | dhellmann: Sure. So we should introduce these jobs before adoption. | 20:35 |
| YorikSar | dhellmann: Well, for oslo.concurrency it'll be until Juno | 20:35 |
| YorikSar | (as no project will adopt it this late) | 20:35 |
| dhellmann | YorikSar: quite likely | 20:35 |
| dhellmann | maybe we should rethink the order of some of the steps in our process for kilo | 20:35 |
| YorikSar | dhellmann: But until then I should leave those jobs alone, right? :) | 20:36 |
| dhellmann | YorikSar: yeah, I spent a lot of time coming up with this process last cycle, so I don't want to change it without some thought going into it -- I'm open to changing it, just not on the basis of a few minutes thought late on a Friday :-) | 20:37 |
| YorikSar | dhellmann: It's not Friday anymore here ;) | 20:37 |
| dhellmann | YorikSar: why are you working on the weekend!? I think we have a rule against that in Oslo... | 20:38 |
| dimsum_ | dhellmann: experimental oslo-incubator patch using oslo.utils (http://logs.openstack.org/49/114649/1/check/gate-oslo-incubator-python26/ad18bde/console.html) looks like we need a few more things | 20:38 |
| dimsum_ | dims@dims-mac:~/junk$ grep AttributeError consoleText | sort | uniq | 20:39 |
| dimsum_ | AttributeError: 'module' object has no attribute 'import_class' | 20:39 |
| dimsum_ | AttributeError: 'module' object has no attribute 'import_module' | 20:39 |
| dimsum_ | AttributeError: 'module' object has no attribute 'import_object' | 20:39 |
| dimsum_ | AttributeError: 'module' object has no attribute 'mask_password' | 20:39 |
| dhellmann | dimsum_: those are the ones we didn't want to include, so the crypto code should continue to use the incubated version of that module until we can update it to use stevedore | 20:40 |
| dimsum_ | k we need a oslo.utils release with mask_password at least | 20:40 |
| YorikSar | dhellmann: I just have my timetable shifting to very late time going to sleep quite often. | 20:41 |
| dimsum_ | YorikSar: whereabouts are you? | 20:42 |
| YorikSar | dimsum_: Saratov, Russia, UTC+4 | 20:42 |
| dimsum_ | ah, nice! | 20:42 |
| dimsum_ | though, not so nice for sleep patterns :) | 20:43 |
| YorikSar | dimsum_: Once my gf comes back to work after vacation, my sleep patterns should get fixed - she's a very early bird :) | 20:44 |
| dimsum_ | :) | 20:44 |
| dhellmann | dimsum_: yep, maybe we can get that in for monday | 20:46 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use __qualname__ where appropriate https://review.openstack.org/106683 | 20:46 |
| dhellmann | dimsum_: I'm traveling a bit next week, but will try to do some reviews this weekend | 20:47 |
| YorikSar | dimsum_: And what happend to those import_* methods? | 20:47 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Mask passwords in exceptions and error messages https://review.openstack.org/114656 | 20:48 |
| dimsum_ | YorikSar: we prefixed a '_' to their names (see spec for oslo-utils) | 20:48 |
| dimsum_ | dhellmann: thanks, have fun at linuxcon(?) | 20:49 |
| dhellmann | dimsum_: yeah, cloudopen/linuxconf | 20:50 |
| YorikSar | dimsum_: Will do... | 20:51 |
| YorikSar | dimsum_: Ah, migrate to stevedore, right. | 20:51 |
| dhellmann | YorikSar, dimsum_ : and if those uses aren't appropriate for stevedore (they appear to be loading things out of another library that doesn't register entry points) maybe we need one or two of those functions exposed in the importutils module after all -- let's look at which is the better solution | 20:52 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use __qualname__ where appropriate https://review.openstack.org/106683 | 20:54 |
| *** bknudson has joined #openstack-oslo | 20:56 | |
| *** bknudson1 has joined #openstack-oslo | 20:57 | |
| YorikSar | dhellmann: From the looks of it it doesn't look like there're cases that can't be replaced with stevedore... Except, maybe, in crypto | 20:58 |
| *** bknudson has quit IRC | 21:01 | |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Log stdout, stderr and command on execute() error https://review.openstack.org/114659 | 21:01 |
| dimsum_ | dhellmann: we can't force people to move :( we should add the originals back and deprecate them at least | 21:02 |
| dimsum_ | (or provide equivalent calls in stevedore!) | 21:02 |
| dhellmann | dimsum_: adding them to stevedore is an interesting idea, but I'm not sure the model fits. stevedore is really focused on entry point discovery patterns. | 21:04 |
| dhellmann | dimsum_: I wonder if the oslo code using that crypto stuff could be changed - why is it doing dynamic imports, for example? | 21:05 |
| YorikSar | dhellmann: They are not so dynamic, actually... Just modules from Crypto.Hash package. | 21:05 |
| dhellmann | YorikSar: well, what I meant is why are we building package names and importing them instead of just doing the imports at the top of the module? | 21:06 |
| YorikSar | dhellmann: It looks like it can be easily replaced with: from Crypto import Hash; module = getattr(Hash, name) | 21:07 |
| YorikSar | Since __init__.py in Hash package imports all hashes anyway | 21:07 |
| YorikSar | Or does it?.. Let me check. | 21:08 |
| dimsum_ | dhellmann: here's the list of methods we need to look at | 21:11 |
| dimsum_ | http://paste.openstack.org/show/95740/ | 21:11 |
| dhellmann | dimsum_: ok, we can ignore the rpc and notifier stuff, I think, but the others look like we'll have to do more evaluation | 21:13 |
| YorikSar | Nope, there's more to it. But we can always inline import_module - its just 2 lines of code from example in Python docs anyway. | 21:14 |
| dhellmann | YorikSar: well, if we already have the function we should just go ahead and use it | 21:14 |
| dhellmann | it's beer o'clock here, so I'm going to sign off for the night. have a good weekend! | 21:14 |
| YorikSar | dhellmann: You too :) | 21:15 |
| dimsum_ | good night folks and a good weekend | 21:15 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Handle a failure on communicate() https://review.openstack.org/114664 | 21:17 |
| YorikSar | dimsum_: Good night | 21:19 |
| *** pcm__ has quit IRC | 21:25 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack-dev/oslo-cookiecutter: Add common fixes for docs generation to template https://review.openstack.org/114667 | 21:30 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Expose only `ensure_atom` from storage https://review.openstack.org/103378 | 21:33 |
| *** jeckersb is now known as jeckersb_gone | 21:38 | |
| *** jecarey has quit IRC | 21:38 | |
| *** mriedem1 has quit IRC | 21:41 | |
| *** arnaud__ has joined #openstack-oslo | 21:45 | |
| *** dimsum_ has quit IRC | 22:16 | |
| *** dimsum_ has joined #openstack-oslo | 22:16 | |
| *** markmcclain has joined #openstack-oslo | 22:19 | |
| *** dimsum_ has quit IRC | 22:20 | |
| *** dimsum_ has joined #openstack-oslo | 22:26 | |
| *** dimsum_ has quit IRC | 22:26 | |
| *** dimsum_ has joined #openstack-oslo | 22:26 | |
| *** dimsum_ has quit IRC | 22:28 | |
| *** dimsum_ has joined #openstack-oslo | 22:28 | |
| *** dimsum_ has quit IRC | 22:30 | |
| *** dimsum_ has joined #openstack-oslo | 22:30 | |
| *** shakamunyi has quit IRC | 22:30 | |
| *** zzzeek has quit IRC | 22:41 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: EXPERIMENT: switch oslo-incubator to use oslo.utils https://review.openstack.org/114649 | 22:42 |
| *** dimsum_ has quit IRC | 22:46 | |
| *** dimsum_ has joined #openstack-oslo | 22:47 | |
| *** stevemar has quit IRC | 22:49 | |
| *** dimsum_ has quit IRC | 22:51 | |
| amrith | hello ... anyone able to help understand why jenkins is failing in oslo.concurrency? gate-oslo.concurrency-docs is the test that is failing. | 22:52 |
| amrith | dhellmann, YorikSar ... on oslo.concurrency, I'm getting consistent failures of gate-oslo.concurrency-docs. I got one failure of python27 with a backtrace that included lockutils. I've logged 1357582 to record that. | 22:54 |
| *** dimsum_ has joined #openstack-oslo | 23:04 | |
| *** gordc has quit IRC | 23:04 | |
| *** morganfainberg is now known as morganfainberg_Z | 23:07 | |
| *** dimsum_ has quit IRC | 23:10 | |
| *** dimsum_ has joined #openstack-oslo | 23:10 | |
| *** tsekiyam_ has joined #openstack-oslo | 23:12 | |
| *** dimsum_ has quit IRC | 23:15 | |
| *** tsekiyama has quit IRC | 23:15 | |
| *** zzzeek has joined #openstack-oslo | 23:16 | |
| *** tsekiyam_ has quit IRC | 23:16 | |
| harlowja | arg, what happened in https://review.openstack.org/#/c/109143/ :-/ | 23:19 |
| harlowja | not good :-/ | 23:19 |
| harlowja | community fail | 23:19 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Looks like oslo.concurrency is missing a sphinx https://review.openstack.org/114692 | 23:19 |
| openstackgerrit | A change was merged to openstack/pycadf: clean up license headers https://review.openstack.org/110498 | 23:20 |
| openstackgerrit | A change was merged to openstack/oslo.utils: New public API for mask_password ported from incubator https://review.openstack.org/114611 | 23:20 |
| *** zzzeek has quit IRC | 23:21 | |
| amrith | harlowja, would you be able to give a quick sanity check to https://review.openstack.org/#/c/114692/1 | 23:21 |
| amrith | in the new oslo.concurrency branch, all jenkins jobs are failing | 23:21 |
| amrith | looks like sphinx was missed in test-requirements.txt | 23:21 |
| amrith | I just pushed a patch set to test | 23:22 |
| amrith | and it seems to have worked | 23:22 |
| amrith | harlowja, ^^ (thx) | 23:22 |
| harlowja | i don't think i can +2 but sure :) | 23:22 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Looks like oslo.concurrency is missing a sphinx https://review.openstack.org/114692 | 23:22 |
| amrith | harlowja, thanks ... | 23:23 |
| amrith | I have no idea whether my fix makes sense or not | 23:23 |
| harlowja | seems ok | 23:23 |
| amrith | it just seemed like we weren't installing fix | 23:23 |
| amrith | so it was a guess on my part. | 23:23 |
| amrith | ok, thanks! | 23:23 |
| harlowja | lets see what happens :-P | 23:23 |
| amrith | once in a while the blind squirrel finds an acorn. I think I found an acorn ;) | 23:24 |
| amrith | thanks harlowja! | 23:26 |
| harlowja | lol | 23:27 |
| harlowja | np | 23:27 |
| *** markmcclain has quit IRC | 23:35 | |
| *** shakamunyi has joined #openstack-oslo | 23:51 | |
| *** zzzeek has joined #openstack-oslo | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!