*** oomichi has joined #openstack-oslo | 00:00 | |
openstackgerrit | A change was merged to openstack/oslo.messaging: Port to Python 3 https://review.openstack.org/108007 | 00:11 |
---|---|---|
*** yamahata has joined #openstack-oslo | 00:18 | |
*** harlowja is now known as harlowja_away | 00:29 | |
*** tsekiyam_ has quit IRC | 00:30 | |
openstackgerrit | A change was merged to openstack-dev/pbr: Teach pbr about post versioned dev versions. https://review.openstack.org/80449 | 00:44 |
openstackgerrit | A change was merged to openstack/oslo.utils: Make strutils.mask_password more secure https://review.openstack.org/114614 | 00:45 |
*** dims has joined #openstack-oslo | 00:54 | |
*** harlowja_away is now known as harlowja | 00:56 | |
*** praneshp has quit IRC | 01:09 | |
jogo | dhellmann: https://bugs.launchpad.net/nova/+bug/1349452 | 01:13 |
jogo | dhellmann: any way to make oslo executils timeout if no response | 01:14 |
*** bknudson has quit IRC | 01:23 | |
*** shakamunyi has joined #openstack-oslo | 01:34 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare: Support for pluggable Datastore selection https://review.openstack.org/114551 | 01:38 |
*** oomichi has quit IRC | 01:48 | |
openstackgerrit | zhangjl proposed a change to openstack/oslo.messaging: Message was sended to wrong node with use zmq as rpc_backend https://review.openstack.org/84938 | 01:56 |
*** oomichi has joined #openstack-oslo | 01:57 | |
openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Mask passwords in exceptions and error messages https://review.openstack.org/114656 | 01:58 |
*** arnaud__ has quit IRC | 02:01 | |
*** noelbk has quit IRC | 02:02 | |
*** noelbk has joined #openstack-oslo | 02:02 | |
*** alexpilotti has quit IRC | 02:09 | |
*** morganfainberg is now known as morganfainberg_Z | 02:14 | |
*** inteq has joined #openstack-oslo | 02:19 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare: Support for pluggable Datastore selection https://review.openstack.org/114551 | 02:22 |
openstackgerrit | amrith proposed a change to openstack/oslo-incubator: Mask passwords in exceptions and error messages https://review.openstack.org/109417 | 02:26 |
*** Krast_ has quit IRC | 02:26 | |
*** Krast has joined #openstack-oslo | 02:26 | |
openstackgerrit | amrith proposed a change to openstack/oslo-incubator: Mask passwords in exceptions and error messages https://review.openstack.org/109417 | 02:30 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare: Support for pluggable Datastore selection https://review.openstack.org/114551 | 02:34 |
*** arnaud has quit IRC | 02:35 | |
openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Mask passwords in exceptions and error messages https://review.openstack.org/114656 | 02:35 |
*** dims has quit IRC | 02:35 | |
*** arnaud has joined #openstack-oslo | 02:41 | |
*** dims has joined #openstack-oslo | 02:42 | |
*** dims has quit IRC | 02:47 | |
*** jecarey has joined #openstack-oslo | 03:06 | |
*** shakamunyi has quit IRC | 03:09 | |
*** dims has joined #openstack-oslo | 03:12 | |
*** dims has quit IRC | 03:17 | |
*** markmcclain has quit IRC | 03:24 | |
*** amotoki has joined #openstack-oslo | 03:33 | |
openstackgerrit | zhangjl proposed a change to openstack/oslo.messaging: Message was sended to wrong node with use zmq as rpc_backend https://review.openstack.org/84938 | 03:34 |
*** shakamunyi has joined #openstack-oslo | 04:07 | |
*** harlowja is now known as harlowja_away | 04:08 | |
*** SridharG has joined #openstack-oslo | 04:14 | |
*** harlowja_at_home has joined #openstack-oslo | 04:57 | |
*** harlowja_at_home has quit IRC | 04:59 | |
*** arnaud has quit IRC | 05:00 | |
*** dims has joined #openstack-oslo | 05:01 | |
*** harlowja_at_home has joined #openstack-oslo | 05:04 | |
*** dims has quit IRC | 05:06 | |
*** Krast has quit IRC | 05:08 | |
*** shakamunyi has quit IRC | 05:13 | |
*** arnaud has joined #openstack-oslo | 05:26 | |
*** inteq has quit IRC | 05:27 | |
*** arnaud has quit IRC | 05:31 | |
*** k4n0 has joined #openstack-oslo | 05:36 | |
*** morganfainberg_Z is now known as morganfainberg | 05:41 | |
openstackgerrit | Andreas Jaeger proposed a change to openstack/oslo.concurrency: Initial translation setup https://review.openstack.org/114608 | 05:45 |
*** SridharG has quit IRC | 05:47 | |
*** ildikov has quit IRC | 05:58 | |
*** arnaud has joined #openstack-oslo | 06:04 | |
*** Krast has joined #openstack-oslo | 06:14 | |
*** SridharG has joined #openstack-oslo | 06:15 | |
*** arnaud__ has joined #openstack-oslo | 06:16 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Initial shift to having backends provide storage impls https://review.openstack.org/114422 | 06:17 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Initial shift to having backends provide storage impls https://review.openstack.org/114422 | 06:18 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/114732 | 06:22 |
*** harlowja_at_home has quit IRC | 06:23 | |
*** Krast has quit IRC | 06:28 | |
*** mrda has quit IRC | 06:30 | |
*** mrda has joined #openstack-oslo | 06:33 | |
*** arnaud has quit IRC | 06:40 | |
*** arnaud__ has quit IRC | 06:40 | |
*** flaper87|afk is now known as flaper87 | 06:46 | |
*** noelbk has quit IRC | 06:54 | |
*** noelbk has joined #openstack-oslo | 06:54 | |
*** noelbk has quit IRC | 06:55 | |
*** noelbk has joined #openstack-oslo | 06:55 | |
*** ildikov has joined #openstack-oslo | 06:58 | |
*** ihrachyshka has joined #openstack-oslo | 06:59 | |
*** noelbk has quit IRC | 07:00 | |
*** ihrachyshka has quit IRC | 07:10 | |
*** ildikov has quit IRC | 07:15 | |
*** ildikov_ has joined #openstack-oslo | 07:15 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Initial shift to having backends provide storage impls https://review.openstack.org/114422 | 07:25 |
*** AAzza_afk is now known as AAzza | 07:29 | |
openstackgerrit | Bogdan Dobrelya proposed a change to openstack/oslo.messaging: Should not send replies for cast messages https://review.openstack.org/115010 | 07:35 |
*** pblaho has joined #openstack-oslo | 07:42 | |
*** noelbk has joined #openstack-oslo | 07:46 | |
openstackgerrit | Ann Kamyshnikova proposed a change to openstack/oslo.db: ModelsMigrationsSync:Override compare_server_default for MySQL https://review.openstack.org/115203 | 07:47 |
*** stannie has joined #openstack-oslo | 07:48 | |
openstackgerrit | Bogdan Dobrelya proposed a change to openstack/oslo.messaging: Should not send replies for cast messages https://review.openstack.org/115010 | 07:48 |
*** noelbk has quit IRC | 07:55 | |
*** noelbk has joined #openstack-oslo | 07:56 | |
*** noelbk has quit IRC | 08:05 | |
*** ihrachyshka has joined #openstack-oslo | 08:07 | |
*** ihrachyshka has quit IRC | 08:13 | |
*** ihrachyshka has joined #openstack-oslo | 08:13 | |
*** Krast has joined #openstack-oslo | 08:22 | |
*** gpocente1 is now known as gpocentek | 08:27 | |
*** gpocentek has joined #openstack-oslo | 08:27 | |
openstackgerrit | Ma Wen Cheng proposed a change to openstack/oslo.messaging: Disable Topic name used as Queue name for QPID consumers https://review.openstack.org/113808 | 08:34 |
openstackgerrit | Julien Danjou proposed a change to openstack/oslo-incubator: log: add missing space in error message https://review.openstack.org/115213 | 08:41 |
openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Moved all tests to unit folder https://review.openstack.org/115136 | 08:51 |
openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Added functional test for RPC https://review.openstack.org/115137 | 08:51 |
*** yamahata has quit IRC | 08:57 | |
*** ihrachyshka_ has joined #openstack-oslo | 08:59 | |
*** ihrachyshka has quit IRC | 09:02 | |
openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Moved all tests to unit folder https://review.openstack.org/115136 | 09:02 |
openstackgerrit | Alexei Kornienko proposed a change to openstack/oslo.messaging: Added functional test for RPC https://review.openstack.org/115137 | 09:02 |
*** dims has joined #openstack-oslo | 09:35 | |
*** dims has quit IRC | 09:39 | |
*** AAzza is now known as AAzza_afk | 09:40 | |
*** alexpilotti has joined #openstack-oslo | 09:45 | |
*** ujjain has quit IRC | 09:46 | |
*** ujjain has joined #openstack-oslo | 09:48 | |
*** ujjain has quit IRC | 09:51 | |
*** ujjain has joined #openstack-oslo | 09:51 | |
*** pblaho is now known as pblaho|afk | 10:00 | |
*** linkid has joined #openstack-oslo | 10:05 | |
*** pblaho|afk is now known as pblaho | 10:29 | |
*** pcm_ has joined #openstack-oslo | 10:30 | |
openstackgerrit | Bogdan Dobrelya proposed a change to openstack/oslo.messaging: Should not send replies for cast messages https://review.openstack.org/115010 | 10:31 |
openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Log stdout, stderr and command on execute() error https://review.openstack.org/114659 | 10:44 |
openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Handle a failure on communicate() https://review.openstack.org/114664 | 10:45 |
*** ihrachyshka_ is now known as ihrachyshka | 11:04 | |
*** dims has joined #openstack-oslo | 11:17 | |
*** pblaho has quit IRC | 11:50 | |
*** dims has quit IRC | 11:56 | |
*** Krast has quit IRC | 12:02 | |
*** gordc has joined #openstack-oslo | 12:09 | |
*** dims has joined #openstack-oslo | 12:09 | |
*** pblaho has joined #openstack-oslo | 12:14 | |
*** pcm__ has joined #openstack-oslo | 12:22 | |
*** pblaho has quit IRC | 12:24 | |
*** pcm_ has quit IRC | 12:26 | |
*** kgiusti has joined #openstack-oslo | 12:26 | |
*** pblaho has joined #openstack-oslo | 12:27 | |
openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Add olostest in requirements https://review.openstack.org/115269 | 12:27 |
openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Add oslotest in requirements https://review.openstack.org/115269 | 12:35 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare Driver - Ignore datastore in maintenance mode https://review.openstack.org/115272 | 12:35 |
*** dims has quit IRC | 12:37 | |
*** dims has joined #openstack-oslo | 12:38 | |
*** jeckersb_gone is now known as jeckersb | 12:38 | |
*** pblaho has quit IRC | 12:48 | |
*** markmc has joined #openstack-oslo | 12:49 | |
*** dtantsur has joined #openstack-oslo | 12:53 | |
*** pblaho has joined #openstack-oslo | 12:56 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare Driver - Ignore datastore in maintenance mode https://review.openstack.org/115272 | 12:57 |
dtantsur | Hi folks! Anyone mind reviewing relatively easy patch to oslo-incubator https://review.openstack.org/#/c/113978 ? I'm sorry for bothering you, but it's blocking 2 patches to python-ironicclient. Thank you | 12:58 |
*** pblaho is now known as pblaho|meeting | 13:00 | |
*** amotoki has quit IRC | 13:03 | |
*** bknudson has joined #openstack-oslo | 13:12 | |
*** AAzza_afk has quit IRC | 13:15 | |
*** AAzza_afk has joined #openstack-oslo | 13:15 | |
*** mriedem has joined #openstack-oslo | 13:15 | |
*** AAzza_afk is now known as AAzza | 13:16 | |
openstackgerrit | Vlad Okhrimenko proposed a change to openstack/oslo.db: Add get_non_innodb_tables() to utils https://review.openstack.org/108994 | 13:16 |
openstackgerrit | Vlad Okhrimenko proposed a change to openstack/oslo.db: Add get_non_innodb_tables() to utils https://review.openstack.org/108994 | 13:17 |
*** miqui has joined #openstack-oslo | 13:19 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare Driver - Ignore datastore in maintenance mode https://review.openstack.org/115272 | 13:20 |
*** ildikov_ has quit IRC | 13:23 | |
*** jecarey has quit IRC | 13:28 | |
*** AAzza has quit IRC | 13:30 | |
*** pblaho|meeting is now known as pblaho | 13:31 | |
*** zzzeek has joined #openstack-oslo | 13:32 | |
*** pblaho has quit IRC | 13:34 | |
*** AAzza_afk has joined #openstack-oslo | 13:36 | |
*** AAzza_afk is now known as AAzza | 13:36 | |
*** pblaho has joined #openstack-oslo | 13:37 | |
*** ildikov_ has joined #openstack-oslo | 13:38 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare: Support for pluggable Datastore selection https://review.openstack.org/114551 | 13:39 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare Driver - Ignore datastore in maintenance mode https://review.openstack.org/115272 | 13:39 |
*** oomichi has quit IRC | 13:42 | |
*** HenryG_ has joined #openstack-oslo | 13:46 | |
*** HenryG has quit IRC | 13:47 | |
*** zzzeek has quit IRC | 13:48 | |
*** zzzeek has joined #openstack-oslo | 13:50 | |
*** linkid has left #openstack-oslo | 13:50 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare Driver - Ignore datastore in maintenance mode https://review.openstack.org/115272 | 13:53 |
amrith | dims, are you there? | 13:54 |
dims | amrith: pong | 13:54 |
amrith | hi dims | 13:55 |
amrith | I'm going to have to do another merge of strutils.py | 13:55 |
amrith | from oslo.utils into oslo.concurrency | 13:55 |
amrith | since it appears that o.c has its copy of strutils.py | 13:55 |
amrith | which means I have to pick up some more encodeutils changes | 13:55 |
amrith | I'll pull that in later today | 13:55 |
zzzeek | hi viktors , i need a little more guidance re: your comments on https://review.openstack.org/#/c/110170/, thanks! | 13:55 |
amrith | are you at #troveday by any chance? | 13:55 |
amrith | YorikSar ^^^ ... pl see above (heads-up). this is to pick up the change I submitted in oslo-incubator which just merged into oslo.utils. | 13:57 |
amrith | dims ^^^ | 13:57 |
dims | amrith: did not feel right to pop into to mid summit w/o participating even a little bit :) | 13:58 |
dims | amrith: ack (encodeutils) | 13:58 |
amrith | sorry #troveday is a day long trove related event (cambridge marriott). feel free to drop by ... | 13:58 |
amrith | mid-cycle is tomorrow through Friday | 13:58 |
amrith | if you want to stop by #troveday today, that's not a problem (free all day event on openstack trove). | 13:59 |
amrith | cocktail party in the evening ;) | 13:59 |
*** mriedem has left #openstack-oslo | 13:59 | |
*** mriedem has joined #openstack-oslo | 13:59 | |
dims | amrith: sounds great. i'll try | 14:00 |
amrith | dims, I'll push changes later today once I can figure out the lineage of the strutils.py that ended up in oslo.concurrency. looking forward to meeting you if you can make it. | 14:01 |
amrith | thx | 14:01 |
viktors | zzzeek: hi! | 14:02 |
zzzeek | hey | 14:02 |
viktors | as for your questions | 14:02 |
*** amrith is now known as amrith_ | 14:02 | |
YorikSar | amrith: Hi. | 14:03 |
viktors | zzzeek: oslo.db have no test_connect_fail() test method, so foolks from Ironic made it itself | 14:03 |
YorikSar | amrith: I think you should land patch to oslo.utils, then port to incubator, and then update it in concurrency using usual incubator update process. | 14:04 |
viktors | they can use either our is_backend_avail() method or his - nevermind | 14:04 |
zzzeek | viktors: from what i can tell , that test only tests the _is_backend_avail() function they made right there | 14:04 |
zzzeek | viktors: we have plenty of tests for that function in oslo.db | 14:04 |
zzzeek | viktors: if their function works, it returns False - success! | 14:04 |
viktors | zzzeek: my note was - this patch will break Ironic's unittests, because they uses self.FIXTURE.* attributes | 14:04 |
ihrachyshka | zzzeek: hey! so long... :) do you know how to reach anyone from those who maintain sqlalchemy-migate on stackforge to check and merge (and release) my patches that are needed for mysql-connector | 14:04 |
ihrachyshka | ? | 14:04 |
YorikSar | amrith: I'm trying to figure out if we actually need strutils there and how can we switch to oslo.utils. | 14:05 |
zzzeek | ihrachyshka: i dont know whos doing sqlalchemy-migrate | 14:05 |
zzzeek | viktors: OK….so since that test in ironic seems to do nothing useful can I patch them to remove it ? | 14:05 |
zzzeek | viktors: doesnt seem like a big deal ? | 14:05 |
viktors | zzzeek: it's not a big deal - to use is_backend_avail() from oslo.db, we need remove self.FIXTURE.* attributes usage | 14:05 |
zzzeek | viktors: ok | 14:06 |
viktors | you can run locally Ironic unittest with custom oslo.db to see this exception | 14:07 |
*** HenryG_ is now known as HenryG | 14:07 | |
zzzeek | viktors: Ok how are things like this timed, we like to fix all consuming projects before oslo.db is released, right? eg. this doesnt hold up the patch itself | 14:07 |
*** markmcclain has joined #openstack-oslo | 14:07 | |
ihrachyshka | zzzeek: ah, ok... I thought that you've passed authority for the codebase to someone. was it technically an independent fork to stackforge space? | 14:08 |
zzzeek | ihrachyshka: last i knew, domen kozar was the maintained | 14:08 |
zzzeek | maintainer | 14:08 |
zzzeek | ihrachyshka: also, I never wrote sqlalchemy-migrate. I gave them some patches around sqlalchemy 0.6 but that was it | 14:09 |
ihrachyshka | zzzeek: ouch. I was misleaded then. :) ok, thanks anyway. | 14:10 |
viktors | zzzeek: it's would be really nice to run projects unittests on each oslo.db patch to avoid of this issues. dhellmann has some ideas how to do it | 14:10 |
zzzeek | viktors: yeah that is dhellmann stuff for sure :) im still fully confused by incubators and all that | 14:11 |
* zzzeek just writes the code | 14:11 | |
viktors | :) | 14:11 |
*** oomichi has joined #openstack-oslo | 14:12 | |
viktors | zzzeek: you can look at this spec - https://review.openstack.org/#/c/95885/ | 14:13 |
*** shakamunyi has joined #openstack-oslo | 14:16 | |
*** oomichi has quit IRC | 14:17 | |
*** zzzeek has quit IRC | 14:17 | |
*** zzzeek_ has joined #openstack-oslo | 14:17 | |
zzzeek_ | im having real network probs today | 14:17 |
zzzeek_ | viktors: looks good to me | 14:17 |
zzzeek_ | viktors: so i need to know what else you want to see on that patch, it changed existing functionality in-place so what new tests do you need ? | 14:18 |
viktors | zzzeek_: I talked about tests from that spec ) | 14:19 |
viktors | zzzeek_: unittests looks good for me, I just don't want to break another projects | 14:20 |
viktors | again :) | 14:20 |
zzzeek_ | viktors: what spec? https://review.openstack.org/#/c/95885/6/specs/enhance-cross-test-gate-job.rst ? | 14:20 |
viktors | yes | 14:20 |
zzzeek_ | viktors: OK sorry I’m trying to get at, what do you need on https://review.openstack.org/#/c/110170/ to approve, just that it runs with other projects ? | 14:20 |
zzzeek_ | viktors: e.g. you want me to patch to ironic first ? | 14:21 |
viktors | zzzeek_: yes | 14:21 |
viktors | zzzeek_: or add some backward compatibility stuff to your patch | 14:21 |
zzzeek_ | oh “OS” == “openstack” | 14:21 |
zzzeek_ | viktors: i think they dont want to use that acronym | 14:21 |
zzzeek_ | I thought you meant “open source" | 14:21 |
viktors | zzzeek_: oh, sorry for this confusion | 14:22 |
*** jkraj has joined #openstack-oslo | 14:25 | |
*** tsekiyama has joined #openstack-oslo | 14:29 | |
*** celttechie has joined #openstack-oslo | 14:30 | |
*** shakamunyi has quit IRC | 14:32 | |
openstackgerrit | Vlad Okhrimenko proposed a change to openstack/oslo.db: Add get_non_innodb_tables() to utils https://review.openstack.org/108994 | 14:36 |
openstackgerrit | Vlad Okhrimenko proposed a change to openstack/oslo.db: Add get_non_innodb_tables() to utils https://review.openstack.org/108994 | 14:36 |
*** ildikov_ has quit IRC | 14:38 | |
*** celttechie has quit IRC | 14:45 | |
*** pblaho is now known as pblaho|afk | 14:46 | |
*** pblaho|afk is now known as pblaho | 14:47 | |
*** shakamunyi has joined #openstack-oslo | 14:47 | |
*** jecarey has joined #openstack-oslo | 14:48 | |
*** markmcclain has quit IRC | 14:52 | |
*** markmcclain has joined #openstack-oslo | 14:53 | |
*** zzzeek_ has quit IRC | 14:55 | |
*** zzzeek has joined #openstack-oslo | 14:55 | |
*** celttechie has joined #openstack-oslo | 14:57 | |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare: Support for pluggable Datastore selection https://review.openstack.org/114551 | 15:08 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.vmware: VMWare Driver - Ignore datastore in maintenance mode https://review.openstack.org/115272 | 15:09 |
*** markmcclain has quit IRC | 15:12 | |
*** alexpilotti has quit IRC | 15:18 | |
*** flaper87 is now known as flaper87|afk | 15:19 | |
*** ihrachyshka has quit IRC | 15:22 | |
openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Reorganize DbTestCase to use provisioning completely https://review.openstack.org/110170 | 15:32 |
openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Use testr instance provisioning to lazily create databases https://review.openstack.org/110486 | 15:32 |
openstackgerrit | Michael Bayer proposed a change to openstack/oslo.db: Add transactional test support to provisioning https://review.openstack.org/113153 | 15:32 |
zzzeek | viktors: I just restored those names and confirm taht ironic’s tests now pass | 15:32 |
*** praneshp has joined #openstack-oslo | 15:39 | |
*** dtantsur is now known as dtantsur|brb | 15:45 | |
viktors | zzzeek: thanks! I'll look at patch | 15:48 |
*** AAzza is now known as AAzza_afk | 15:49 | |
*** mriedem has quit IRC | 15:55 | |
*** AAzza_afk is now known as AAzza | 15:58 | |
*** dims has quit IRC | 15:59 | |
*** dims has joined #openstack-oslo | 15:59 | |
*** SridharG has quit IRC | 16:00 | |
*** celttechie has quit IRC | 16:02 | |
*** mriedem has joined #openstack-oslo | 16:03 | |
*** dims has quit IRC | 16:04 | |
*** alexpilotti has joined #openstack-oslo | 16:04 | |
*** ildikov has joined #openstack-oslo | 16:05 | |
*** arnaud has joined #openstack-oslo | 16:05 | |
*** alexpilotti has quit IRC | 16:06 | |
*** alexpilotti has joined #openstack-oslo | 16:06 | |
openstackgerrit | Oleksii Chuprykov proposed a change to openstack/oslo.db: Added check to see whether oslotest is installed https://review.openstack.org/115269 | 16:14 |
*** pblaho has quit IRC | 16:15 | |
*** viktors is now known as viktors|afk | 16:16 | |
*** arnaud has quit IRC | 16:24 | |
*** AAzza is now known as AAzza_afk | 16:28 | |
bnemec | amrith_: Let's not patch strutils in oslo.concurrency. Let's just convert oslo.concurrency to use oslo.utils. | 16:31 |
*** markmcclain has joined #openstack-oslo | 16:34 | |
*** AAzza_afk is now known as AAzza | 16:36 | |
*** jkraj has quit IRC | 16:47 | |
*** markmcclain has quit IRC | 16:49 | |
*** arnaud has joined #openstack-oslo | 16:54 | |
*** stannie has quit IRC | 16:54 | |
*** markmcclain has joined #openstack-oslo | 16:55 | |
*** sheeprine has quit IRC | 16:56 | |
*** harlowja_away is now known as harlowja | 16:56 | |
*** sheeprine has joined #openstack-oslo | 16:57 | |
*** ihrachyshka has joined #openstack-oslo | 16:58 | |
*** sheeprine has quit IRC | 17:00 | |
*** sheeprine has joined #openstack-oslo | 17:00 | |
*** mriedem1 has joined #openstack-oslo | 17:02 | |
*** arnaud has quit IRC | 17:02 | |
*** mriedem has quit IRC | 17:03 | |
*** AAzza is now known as AAzza_afk | 17:09 | |
*** cburgess has joined #openstack-oslo | 17:09 | |
jogo | cburgess: o/ | 17:09 |
jogo | dhellmann: so cburgess and I have been looking at https://bugs.launchpad.net/nova/+bug/1349452 | 17:09 |
jogo | cburgess: I like jarlow's gist | 17:10 |
jogo | https://gist.github.com/harlowja/9c35e443dfa136a4f965 | 17:10 |
cburgess | Yeah I just saw that. | 17:10 |
cburgess | Though he is using a lock rather then a semaphore. Not sure if that hits the same bug. | 17:11 |
cburgess | I'm trying to find the original eventlet bug that vishy linked now. Digging through my logs. | 17:11 |
jogo | cburgess: awesome | 17:11 |
cburgess | OK so... the original bug that vishy things we are hitting is https://bitbucket.org/eventlet/eventlet/issue/137/use-of-threading-locks-causes-deadlock | 17:12 |
jogo | bnemec: paybe you can help us, we have a oslo/eventlet bug | 17:12 |
jogo | bnemec: maybe* | 17:12 |
jogo | bnemec: that is causing random nova-compute deadlocks because ... FAIL | 17:12 |
cburgess | It looks like one or both of these changes https://github.com/openstack/nova/commit/a0bcd7b90c38b104cb278223679cedf5cc11c74c, https://github.com/openstack/nova/commit/4b6ea1e1b87241918baf21a16817417226a9fc62 is resulting in us now trying to hold a threading.semaphore and an eventlet one at the same time. | 17:13 |
openstackgerrit | gordon chung proposed a change to openstack/oslo-incubator: add deprecation note to middleware https://review.openstack.org/115349 | 17:13 |
cburgess | The theory is that this is causing a deadlock preventing the eventlet reactor from poping a thead and doing work. | 17:14 |
cburgess | In effect deadlocking the entire eventlet stack. | 17:14 |
*** dtantsur|brb is now known as dtantsur | 17:14 | |
jogo | cburgess: can you update the bug with that | 17:15 |
cburgess | jogo: Doing it now. ;) | 17:15 |
jogo | cburgess: excellent | 17:15 |
jogo | cburgess: so not sure how to procede because oslo doesn't want to be eventlet specific or whatever that is | 17:15 |
* bnemec continues to hate lockutils | 17:15 | |
cburgess | jogo: I was guessing based upon the comments from the original commits. Let me find the original patches. | 17:16 |
jogo | bnemec: yeah, IMHO oslo trying to move away from eventlet was a mistake | 17:16 |
jogo | bnemec: not because eventlet is good, but because its tricky and too easy to get wrong | 17:17 |
cburgess | jogo: Ouch thats above my pay grade :) | 17:17 |
jogo | bnemec: well wrather the weay oslo tried to move away | 17:17 |
jogo | rrather* | 17:18 |
* jogo hasn't had his coffee yet | 17:18 | |
cburgess | jogo: I just updated the ticket with the info. Also the original oslo commits that we *think* are causing the problem are here https://review.openstack.org/#/c/43895/ https://review.openstack.org/#/c/54581/ | 17:18 |
cburgess | jogo: I think we need to write a test case to prove this one way or another. harlowja seems has a good start. I don't like the idea that we have to run a full tempest test against nova to see the deadlock. | 17:19 |
jogo | bnemec: so how do you think we can move forward and try to resolve this bug? | 17:19 |
jogo | cburgess: excellent idea | 17:19 |
bnemec | jogo: Yeah, I guess I'm not surprised that mixing locks would cause issues. | 17:20 |
cburgess | jogo: If we can run something locally or even with a similiar usage pattern at least then we know what the issue is. | 17:20 |
jogo | bnemec: so this bug manifests itself when nova-compute and nova-network are running on the same node | 17:20 |
bnemec | dhellmann: YorikSar: ^ related to the oslo.concurrency graduation. | 17:20 |
harlowja | cburgess ya, to easy to do crazy things when u dont monkey patch threading | 17:20 |
harlowja | especially with libraries we don't control... | 17:20 |
harlowja | anyone uses a lock anywhere, and it dies | 17:20 |
cburgess | harlowja: Oh yeah for sure. I suppse we could patch threading but we intentionally don't do that in nova right now. | 17:20 |
jogo | cburgess: why don't we? | 17:21 |
harlowja | i guess u just never hope a library that gets pulled in tries to use a lock :-/ | 17:21 |
cburgess | jogo: Good question, that was actually going to be my next question. Let me pull up the code where we do the monkeypatch. | 17:21 |
cburgess | jogo: https://github.com/openstack/nova/blob/master/nova/cmd/__init__.py#L43 | 17:22 |
cburgess | We only do it if we are using the debugger. | 17:22 |
harlowja | cburgess any idea why that is? whats special about the debugger | 17:22 |
harlowja | seems like u just increased the number of things u have to debug when u turn off threading being monkey patched (isn't that causing more issues when debugging, lol) | 17:23 |
cburgess | harlowja: No clue, been that way for a while though, I think we even did it that way in essex, I know it was like that in grizzly. | 17:23 |
jogo | the debugger should be off by default | 17:23 |
jogo | the debugger is for remote debugging | 17:24 |
cburgess | The original eventlet bug goes away if we do thread=False | 17:24 |
*** markmcclain has quit IRC | 17:25 | |
harlowja | a http://en.wikipedia.org/wiki/Heisenbug lol | 17:25 |
*** markmcclain has joined #openstack-oslo | 17:25 | |
jogo | cburgess: so I am a bit confused, I thought thread=False means we don't monkey patch threading, in which case https://gist.github.com/harlowja/9c35e443dfa136a4f965 | 17:26 |
jogo | cburgess: so are you saying not setting thread=False is triggering a different bug? | 17:26 |
cburgess | jogo: The original bug from comstud indicated that thread=False causes the bug to go away. | 17:27 |
cburgess | https://bitbucket.org/eventlet/eventlet/issue/137/use-of-threading-locks-causes-deadlock | 17:27 |
cburgess | jogo: Granted we aren't even sure thats the bug we arer hitting. Its just a theory. This is why I think we need to write an indepdent test case kind of like harlowja started with the gist. | 17:28 |
jogo | cburgess: but then we can hit the issue that harlowja has | 17:28 |
jogo | cburgess: gotcha | 17:28 |
cburgess | jogo: Yeah catch22, damned if we do, damned if we don't. | 17:28 |
harlowja | ya, run that gist, program locks | 17:28 |
cburgess | This is why I'm a but confused as to exactly whats going on and why we are trying to mix threading. Like bnemec we are almost guaranteed to it issues doing that. | 17:29 |
cburgess | OK that wasn't english | 17:30 |
cburgess | I need more coffee. | 17:30 |
cburgess | So to be clear, we are guessing at the issue. it seems similiar to the original eventlet issue comstud found but it could just be another issue when mixing threading implementations. | 17:30 |
jogo | cburgess: right | 17:30 |
*** SridharG has joined #openstack-oslo | 17:31 | |
cburgess | jogo: So... I'll see if I can create a tets case today. This might be tricky given we might need multiple processes holding multiple locks. | 17:31 |
bnemec | So, what we might need for lockutils is a way to conditionally use eventlet semaphores even if we aren't monkeypatched? | 17:32 |
cburgess | bnemec: Yeah we might need an eventlet version and a non-eventlet version. | 17:33 |
harlowja | and pray that no other library (like logging uses a lock and calls into any eventlet patched function via any way) | 17:34 |
cburgess | harlowja: Thats actually how comstud foud the originaly issue, python logging. | 17:34 |
harlowja | cburgess ya, its rightly using a lock somewhere inside of it | 17:34 |
* harlowja reminds me of a conversation yesterday with a guy at work, about how he was saying python should of never introduced the threading concepts at all, lol | 17:35 | |
bnemec | Hmm, but that would only potentially solve the debugger case where we monkeypatch thread=False. | 17:35 |
cburgess | OK well let me see if I can find a way to reproduce this in a simple test case. Something we can all see and work on. | 17:35 |
bnemec | For the other case lockutils will already be using an eventlet semaphore. | 17:35 |
jogo | cburgess: good luck! | 17:35 |
cburgess | jogo: Random question... we aren't running with the debugger during tempest testing are we? Just curious. | 17:38 |
cburgess | As we are sure its disabled so we aren't calling thread=False right? | 17:38 |
jogo | cburgess: I don't think so | 17:38 |
jogo | cburgess: 99% sure | 17:38 |
cburgess | k | 17:38 |
*** shakamunyi has quit IRC | 17:39 | |
*** AAzza_afk is now known as AAzza | 17:41 | |
*** dims has joined #openstack-oslo | 17:53 | |
dims | hi amrith_: i made it | 17:56 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/115363 | 18:06 |
*** shakamunyi has joined #openstack-oslo | 18:11 | |
*** viktors has joined #openstack-oslo | 18:14 | |
*** dtantsur is now known as dtantsur|afk | 18:22 | |
*** mriedem has joined #openstack-oslo | 18:23 | |
*** mriedem1 has quit IRC | 18:24 | |
*** shakamunyi has quit IRC | 18:30 | |
*** AAzza is now known as AAzza_afk | 18:35 | |
*** dims has quit IRC | 18:37 | |
*** shakamunyi has joined #openstack-oslo | 18:44 | |
*** AAzza_afk is now known as AAzza | 18:48 | |
*** SridharG has quit IRC | 18:51 | |
*** dims has joined #openstack-oslo | 19:00 | |
*** dims has quit IRC | 19:00 | |
openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Bypass vCenter when uploading to datastores https://review.openstack.org/114634 | 19:01 |
*** dims has joined #openstack-oslo | 19:01 | |
*** dims has quit IRC | 19:05 | |
*** harlowja has quit IRC | 19:13 | |
*** harlowja has joined #openstack-oslo | 19:13 | |
*** zzzeek has quit IRC | 19:15 | |
*** ihrachyshka has quit IRC | 19:16 | |
openstackgerrit | A change was merged to openstack/oslo.messaging: Fix error in example of an RPC server https://review.openstack.org/108410 | 19:17 |
*** markmcclain has quit IRC | 19:17 | |
*** zzzeek has joined #openstack-oslo | 19:17 | |
*** AAzza is now known as AAzza_afk | 19:24 | |
*** ildikov has quit IRC | 19:24 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add an example which shows how to use the run_iter cancelling https://review.openstack.org/115382 | 19:24 |
*** tpatil has joined #openstack-oslo | 19:29 | |
tpatil | Hi, Can someone please review this patch https://review.openstack.org/#/c/103186/? This issue is very critical especially when you are restarting (sending SIGHUP signal) nova-compute service. | 19:33 |
*** ihrachyshka has joined #openstack-oslo | 19:35 | |
*** ildikov_ has joined #openstack-oslo | 19:39 | |
openstackgerrit | Ken Giusti proposed a change to openstack/oslo.messaging: An initial implementation of an AMQP 1.0 based messaging driver https://review.openstack.org/75815 | 19:42 |
*** dhellman_ has joined #openstack-oslo | 19:46 | |
*** tpatil has quit IRC | 19:50 | |
*** markmcclain has joined #openstack-oslo | 19:50 | |
*** freyes has joined #openstack-oslo | 19:55 | |
*** dhellman_ has quit IRC | 19:59 | |
*** kgiusti has left #openstack-oslo | 20:02 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add an example which shows how to use the run_iter throw https://review.openstack.org/115382 | 20:04 |
*** gordc has quit IRC | 20:11 | |
*** gordc has joined #openstack-oslo | 20:12 | |
*** markmc has quit IRC | 20:21 | |
*** dims has joined #openstack-oslo | 20:37 | |
*** viktors has quit IRC | 20:40 | |
*** dims has quit IRC | 20:45 | |
*** shakamunyi has quit IRC | 20:46 | |
*** miqui has quit IRC | 20:49 | |
openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo-incubator: Add mock cleanup function to each test case https://review.openstack.org/95465 | 20:51 |
*** celttechie has joined #openstack-oslo | 21:34 | |
*** gordc has quit IRC | 22:07 | |
*** gordc has joined #openstack-oslo | 22:08 | |
*** ihrachyshka has quit IRC | 22:14 | |
*** HenryG_ has joined #openstack-oslo | 22:17 | |
*** HenryG has quit IRC | 22:19 | |
*** markmcclain has quit IRC | 22:26 | |
openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Bypass vCenter when uploading to datastores https://review.openstack.org/114634 | 22:28 |
*** jecarey has quit IRC | 22:29 | |
*** harlowja has quit IRC | 22:39 | |
*** harlowja has joined #openstack-oslo | 22:39 | |
*** zzzeek has quit IRC | 22:42 | |
*** mriedem has left #openstack-oslo | 22:46 | |
*** zzzeek has joined #openstack-oslo | 22:47 | |
*** jeckersb is now known as jeckersb_gone | 22:57 | |
*** arnaud has joined #openstack-oslo | 22:59 | |
*** bknudson has quit IRC | 23:01 | |
*** shakamunyi has joined #openstack-oslo | 23:02 | |
*** gordc has quit IRC | 23:02 | |
*** zzzeek_ has joined #openstack-oslo | 23:08 | |
*** zzzeek has quit IRC | 23:08 | |
*** zzzeek_ is now known as zzzeek | 23:08 | |
*** zzzeek has quit IRC | 23:10 | |
*** shakamunyi has quit IRC | 23:18 | |
openstackgerrit | Arnaud Legendre proposed a change to openstack/oslo.vmware: Bypass vCenter when uploading to datastores https://review.openstack.org/114634 | 23:21 |
*** sheeprine has quit IRC | 23:25 | |
*** sheeprine has joined #openstack-oslo | 23:25 | |
*** sheeprine has quit IRC | 23:25 | |
*** sheeprine has joined #openstack-oslo | 23:25 | |
*** shakamunyi has joined #openstack-oslo | 23:33 | |
*** ajo_ has joined #openstack-oslo | 23:34 | |
*** celttechie_ has joined #openstack-oslo | 23:34 | |
*** sheeprine has quit IRC | 23:36 | |
*** celttechie has quit IRC | 23:36 | |
*** ajo has quit IRC | 23:36 | |
*** sheeprine has joined #openstack-oslo | 23:36 | |
*** sheeprine has quit IRC | 23:36 | |
*** sheeprine has joined #openstack-oslo | 23:36 | |
*** HenryG_ is now known as HenryG | 23:42 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Initial shift to having backends provide storage impls https://review.openstack.org/114422 | 23:45 |
*** tsekiyam_ has joined #openstack-oslo | 23:46 | |
*** tsekiyama has quit IRC | 23:50 | |
*** tsekiyam_ has quit IRC | 23:50 | |
*** celttechie_ has quit IRC | 23:53 | |
*** yamahata has joined #openstack-oslo | 23:53 | |
*** markmc has joined #openstack-oslo | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!