| *** takedakn has joined #openstack-oslo | 00:00 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Show the ChangeLog in the history page of the documentation. https://review.openstack.org/119668 | 00:05 |
|---|---|---|
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Show the ChangeLog in the history page of the documentation https://review.openstack.org/119668 | 00:07 |
| *** takedakn has quit IRC | 00:17 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Show the ChangeLog in the history page of the documentation https://review.openstack.org/119668 | 00:35 |
| *** oomichi has joined #openstack-oslo | 00:35 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Show the ChangeLog in the history page of the documentation https://review.openstack.org/119668 | 00:42 |
| *** takedakn has joined #openstack-oslo | 00:47 | |
| *** harlowja_at_home has joined #openstack-oslo | 01:22 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Reduce unused tox environments https://review.openstack.org/118941 | 01:25 |
| *** yamahata has joined #openstack-oslo | 01:36 | |
| openstackgerrit | A change was merged to openstack/stevedore: Build universal wheels https://review.openstack.org/119420 | 01:53 |
| *** dims has joined #openstack-oslo | 01:54 | |
| *** HenryG_ is now known as HenryG | 02:01 | |
| *** jecarey has joined #openstack-oslo | 02:21 | |
| *** dims has quit IRC | 02:56 | |
| *** oomichi is now known as oomichi_away | 02:57 | |
| *** oomichi_away has quit IRC | 03:02 | |
| *** jecarey has quit IRC | 03:08 | |
| *** burgobianco has quit IRC | 03:23 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack-dev/pbr: Allow for inclusion of authors and changelog when building docs https://review.openstack.org/119688 | 03:28 |
| *** stevemar has quit IRC | 03:28 | |
| *** stevemar has joined #openstack-oslo | 03:44 | |
| *** harlowja_at_home has quit IRC | 03:54 | |
| *** arnaud has joined #openstack-oslo | 04:48 | |
| *** redrobot has joined #openstack-oslo | 05:10 | |
| *** arnaud has quit IRC | 05:32 | |
| *** amotoki has joined #openstack-oslo | 05:34 | |
| *** flaper87|afk is now known as flaper87 | 05:39 | |
| *** takedakn has quit IRC | 05:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/118539 | 06:01 |
| *** arnaud has joined #openstack-oslo | 06:07 | |
| *** takedakn has joined #openstack-oslo | 06:25 | |
| openstackgerrit | Mehdi Abaakouk proposed a change to openstack/oslo.messaging: Ensure the amqp options are present in config file https://review.openstack.org/119627 | 06:51 |
| *** jaosorior has joined #openstack-oslo | 07:09 | |
| *** stevemar has quit IRC | 07:13 | |
| *** ujjain has quit IRC | 07:17 | |
| *** ujjain has joined #openstack-oslo | 07:17 | |
| *** arnaud has quit IRC | 07:22 | |
| *** ihrachyshka has joined #openstack-oslo | 07:22 | |
| *** ihrachyshka_ has joined #openstack-oslo | 07:29 | |
| *** ihrachyshka has quit IRC | 07:32 | |
| *** ihrachyshka_ has quit IRC | 07:36 | |
| *** ihrachyshka_ has joined #openstack-oslo | 07:36 | |
| *** pblaho has joined #openstack-oslo | 07:41 | |
| *** pblaho has quit IRC | 07:41 | |
| *** pblaho has joined #openstack-oslo | 07:41 | |
| *** noelbk has quit IRC | 07:54 | |
| *** sheeprine has quit IRC | 07:55 | |
| *** andreykurilin_ has joined #openstack-oslo | 07:58 | |
| *** takedakn has quit IRC | 08:01 | |
| openstackgerrit | Yuriy Taraday proposed a change to openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/117940 | 08:10 |
| *** viktors|afk is now known as viktors | 08:11 | |
| *** sheeprine has joined #openstack-oslo | 08:15 | |
| *** ildikov has joined #openstack-oslo | 08:52 | |
| viktors | jd__: hi! Can you please add your +2 to patch https://review.openstack.org/#/c/119644/ (Let oslotest manage the six.move setting for mox). It fixes oslo.db's unittest issues caused by the new oslotest release. Thanks! | 08:52 |
| jd__ | viktors: sure | 09:05 |
| *** andreykurilin_ has quit IRC | 09:13 | |
| openstackgerrit | A change was merged to openstack/oslo.concurrency: Work toward Python 3.4 support and testing https://review.openstack.org/118786 | 09:15 |
| viktors | jd__: thanks a lot! | 09:22 |
| openstackgerrit | Ihar Hrachyshka proposed a change to openstack/oslo.db: Set utf8 encoding for mysql and postgresql https://review.openstack.org/111236 | 09:45 |
| *** dtantsur is now known as dtantsur|lunch | 09:53 | |
| openstackgerrit | Christian Berendt proposed a change to openstack-dev/cookiecutter: Remove unneeded definitions of Python Source Code Encoding https://review.openstack.org/111169 | 09:57 |
| openstackgerrit | Christian Berendt proposed a change to openstack-dev/cookiecutter: Enable hacking check H104 https://review.openstack.org/111171 | 09:58 |
| *** pblaho is now known as pblaho|afk | 09:58 | |
| *** pblaho|afk is now known as pblaho | 09:59 | |
| *** yamahata has quit IRC | 10:09 | |
| *** pcm_ has joined #openstack-oslo | 10:10 | |
| *** pblaho is now known as pblaho|afk | 10:21 | |
| *** AAzza_afk has quit IRC | 10:32 | |
| *** AAzza_afk has joined #openstack-oslo | 10:34 | |
| *** AAzza_afk is now known as AAzza | 10:34 | |
| *** andreykurilin has joined #openstack-oslo | 10:47 | |
| *** dims has joined #openstack-oslo | 11:00 | |
| openstackgerrit | A change was merged to openstack/oslo.concurrency: Log stdout, stderr and command on execute() error https://review.openstack.org/114659 | 11:01 |
| *** dims has quit IRC | 11:16 | |
| *** dims has joined #openstack-oslo | 11:16 | |
| *** dims_ has joined #openstack-oslo | 11:17 | |
| *** pblaho|afk is now known as pblaho | 11:19 | |
| *** dims has quit IRC | 11:21 | |
| openstackgerrit | amrith proposed a change to openstack/oslo-incubator: Log stdout, stderr and command on execute() error https://review.openstack.org/109469 | 11:27 |
| *** tedross has joined #openstack-oslo | 11:48 | |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Handle a failure on communicate() https://review.openstack.org/114664 | 11:59 |
| amrith | YorikSar, https://review.openstack.org/#/c/114664/ would not have merged due to the earlier merge of https://review.openstack.org/114659. I have rebased. There is a change that I'd like you and beekneemech to look at. It may not pass muster as it may be considered not-pythonic. | 12:02 |
| amrith | YorikSar, beekneemech ^^ | 12:02 |
| amrith | https://review.openstack.org/#/c/114664/6/oslo/concurrency/processutils.py,cm line 218 | 12:03 |
| amrith | thanks | 12:03 |
| *** kgiusti has joined #openstack-oslo | 12:03 | |
| YorikSar | amrith: Hi. How did sanitized_cmd change get there? | 12:08 |
| amrith | looking | 12:09 |
| amrith | https://review.openstack.org/#/c/114659/ I think | 12:09 |
| amrith | 69 minutes ago | 12:09 |
| YorikSar | amrith: I mean https://review.openstack.org/#/c/114664/6/oslo/concurrency/processutils.py,cm lines 232 and 236 | 12:09 |
| amrith | and https://review.openstack.org/#/c/116763/ | 12:10 |
| YorikSar | amrith: I thought that was covered elsewhere. | 12:10 |
| amrith | sorry, those two. | 12:10 |
| amrith | I made those changes in this change set | 12:10 |
| amrith | here's why | 12:10 |
| amrith | the block (if not attempts and else) are executed | 12:10 |
| amrith | if the exception is either OSError or ProcessExecutionError | 12:10 |
| amrith | if it is ProcessExecutionError, err.cmd is OK | 12:11 |
| amrith | but if it is OSError, there's no err.cmd | 12:11 |
| amrith | I know what err.cmd is ... it must be sanitized_cmd | 12:11 |
| amrith | which is in scope at that time | 12:11 |
| amrith | so I made that change | 12:11 |
| amrith | to handle the case of that logging for an exception of type OSError | 12:11 |
| YorikSar | amrith: It looks like her: https://review.openstack.org/#/c/114659/10/oslo/concurrency/processutils.py,cm (line 242) sanitized_cmd was reverted... | 12:12 |
| amrith | yes, they are the same thing | 12:12 |
| amrith | if you look at like 222 (in that change) | 12:12 |
| amrith | you'll see that err.cmd is really sanitized_cmd | 12:12 |
| amrith | the exception being thrown at line 219 is caught on line 224 | 12:13 |
| amrith | in https://review.openstack.org/#/c/114659/10/oslo/concurrency/processutils.py,cm | 12:13 |
| amrith | or am I missing something? | 12:13 |
| YorikSar | amrith: Ah, right... | 12:13 |
| YorikSar | amrith: I thought it was some deeper exception. | 12:13 |
| *** dims_ has quit IRC | 12:16 | |
| *** dims has joined #openstack-oslo | 12:16 | |
| YorikSar | amrith: Just one issue with logging, otherwise looks good. | 12:18 |
| *** dims_ has joined #openstack-oslo | 12:20 | |
| *** dims has quit IRC | 12:21 | |
| *** pblaho is now known as pblaho|afk | 12:21 | |
| amrith | YorikSar, what's it (or did you put it in review) | 12:25 |
| amrith | my browser died | 12:25 |
| amrith | I see it | 12:25 |
| *** dtantsur|lunch is now known as dtantsur | 12:29 | |
| amrith | YorikSar, I'll resubmit with a new test. Will be in a couple of hours. | 12:29 |
| amrith | thanks for quick review. | 12:29 |
| *** ildikov_ has joined #openstack-oslo | 12:31 | |
| *** ildikov has quit IRC | 12:34 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Remove dependency on global CONF https://review.openstack.org/118644 | 12:40 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Move handlers and formatters out https://review.openstack.org/118665 | 12:43 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Extract WritableLogger from log module https://review.openstack.org/118671 | 12:43 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Use fixtures from oslo.i18n and oslo.cfg https://review.openstack.org/118952 | 12:44 |
| *** yamahata has joined #openstack-oslo | 12:45 | |
| *** amrith is now known as _amrith_ | 12:47 | |
| *** pblaho|afk is now known as pblaho | 12:47 | |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Remove duplicate test and cleanup unnecessary files https://review.openstack.org/118959 | 12:47 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Add API documentation to docs build https://review.openstack.org/118960 | 12:49 |
| *** pblaho is now known as pblaho|afk | 13:02 | |
| *** pblaho|afk is now known as pblaho | 13:13 | |
| *** tedross has quit IRC | 13:16 | |
| *** bknudson has quit IRC | 13:25 | |
| viktors | dhellmann: around? | 13:26 |
| *** mriedem has joined #openstack-oslo | 13:27 | |
| openstackgerrit | Denis M. proposed a change to openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/117940 | 13:27 |
| dhellmann | viktors: yes | 13:28 |
| *** tedross has joined #openstack-oslo | 13:31 | |
| *** mriedem1 has joined #openstack-oslo | 13:35 | |
| *** mriedem has quit IRC | 13:36 | |
| *** kgiusti has quit IRC | 13:36 | |
| viktors | dhellmann: I wanted to ask you about oslo.* libraries testing with another projects - is there any possibility to run a such test on gerrit? | 13:38 |
| *** kgiusti has joined #openstack-oslo | 13:40 | |
| viktors | dhellmann: by the way, I was wondered, that oslotest was released at Friday night :) | 13:42 |
| *** bknudson has joined #openstack-oslo | 13:46 | |
| *** miqui has joined #openstack-oslo | 13:49 | |
| *** jecarey has joined #openstack-oslo | 13:55 | |
| *** jaypipes has joined #openstack-oslo | 13:55 | |
| dhellmann | viktors: we had a blueprint about that early in the cycle, but there wasn't a lot of support because it was going to use a lot of resources in the CI systems | 13:56 |
| dhellmann | viktors: https://blueprints.launchpad.net/oslo-incubator/+spec/enhance-cross-test-gate-job | 13:56 |
| viktors | dhellmann: yes, I remember this bp. My question is - what should we do now? | 13:57 |
| dhellmann | viktors: I'm not planning to do anything about it between now and the summit | 13:57 |
| dhellmann | the existing script works for running tests locally, so you could use that if you want | 13:57 |
| viktors | it'` not exactly what we need, unfortunately ( | 13:58 |
| viktors | dhellmann: as for CI resources - maybe there is a sense to run these test only when the new release tagged? | 13:59 |
| viktors | and then (if fails) use the existing script works for running tests locally | 14:00 |
| dhellmann | I don't think there's a way to trigger tests and block the tag from landing | 14:00 |
| openstackgerrit | A change was merged to openstack/oslo.db: Let oslotest manage the six.move setting for mox https://review.openstack.org/119644 | 14:01 |
| viktors | dhellmann: by tha way, thanks for ^ :) | 14:01 |
| dhellmann | viktors: that took a while to figure out :-) | 14:01 |
| dhellmann | viktors: do you need a release of oslo.db this week? | 14:01 |
| *** markmcclain has joined #openstack-oslo | 14:02 | |
| viktors | dhellmann: the previous release was a few weeks ago, so maybe it is time | 14:02 |
| viktors | should I mark it as j3 or something similar? | 14:03 |
| dhellmann | viktors: no, just follow the usual numbering scheme | 14:03 |
| *** markmcclain has quit IRC | 14:03 | |
| dhellmann | viktors: I can tag it, if you like, I'm doing a bunch of others right now | 14:04 |
| *** beekneemech is now known as bnemec | 14:04 | |
| viktors | dhellmann: I want to test it with integrated project, at first :) | 14:05 |
| dhellmann | viktors: ok, good idea | 14:05 |
| dhellmann | viktors: the integration tests will already have been run via devstack gate, but the unit tests won't | 14:05 |
| *** markmcclain has joined #openstack-oslo | 14:05 | |
| viktors | yes, thats why I asked you about such tests on gate | 14:05 |
| dhellmann | right, just making sure you didn't waste time on tests that had been run | 14:06 |
| *** ihrachyshka_ has quit IRC | 14:06 | |
| viktors | can you please explain a bit, why do you think, that a new release should not trigger tests ? | 14:06 |
| openstackgerrit | Dina Belova proposed a change to openstack/oslo-incubator: Delete the token and endpoint on expiry of token of client https://review.openstack.org/118628 | 14:08 |
| viktors | dhellmann: I agree, that is it can block the tag, but IMO its better to find such issues as soon as possible | 14:08 |
| dhellmann | viktors: yeah, like I said, it came down to the number of extra test servers we would have needed | 14:08 |
| viktors | dhellmann: but at first you supposed to run these tests on each commit or on release only? | 14:10 |
| *** pblaho is now known as pblaho|afk | 14:10 | |
| dhellmann | viktors: the proposal was to do it on commit. there is no way to do it on release that would block the release and there's no changeset to report errors on when you push a tag, so the logs just sort of disappear into a black hole | 14:11 |
| *** zz_jgrimm is now known as jgrimm | 14:12 | |
| viktors | dhellmann: got it. My suggestion was - if we will run such test only on release, we can reduce amount of required CI recourses | 14:13 |
| *** _amrith_ is now known as amrith | 14:13 | |
| *** pblaho|afk is now known as pblaho | 14:14 | |
| dims_ | dhellmann: will "from oslo import log" even work? given that we have oslo/__init__.py in oslo.i18n and oslo.messaging as well? what would i add in __init__.py in oslo.log/oslo/__init.py? | 14:15 |
| dhellmann | YorikSar: what's the plan for documenting the new daemon mode in oslo.rootwrap? | 14:25 |
| YorikSar | dhellmann: I really should get around to do that... | 14:26 |
| dhellmann | viktors: right, I'm trying to explain that there isn't really a useful point to do that -- there's no commit to attach links to the logs on, so we would have to just watch for the jobs | 14:26 |
| dhellmann | YorikSar: yeah, ttx and I would like to have something for a release, soon | 14:26 |
| dhellmann | dims_: yes, we do "from oslo import i18n" | 14:27 |
| YorikSar | dhellmann: I'll see if I can do that this evening | 14:27 |
| ttx | YorikSar: it doesn't have to be fully detailed, but we need to mention it. | 14:28 |
| *** zzzeek has joined #openstack-oslo | 14:28 | |
| viktors | dhellmann: I got it, but it's sounds weird a bit | 14:29 |
| YorikSar | ttx: I think I can compile smth from my spec. | 14:29 |
| dims_ | dhellmann: so i add "from .log import *" in oslo.log/oslo/log/__init__.py, that would do it? | 14:31 |
| dhellmann | dims_: either that, or importing specific symbols | 14:32 |
| ttx | YorikSar: awesome, thanks | 14:32 |
| *** yamahata has quit IRC | 14:33 | |
| dhellmann | YorikSar: thank you! | 14:35 |
| openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo.log: Add API documentation to docs build https://review.openstack.org/118960 | 14:38 |
| dhellmann | dims_: did we decide oslo.utils would be 1.0 this cycle, or next? | 14:39 |
| dims_ | dhellmann: hmmm, don't recall Doug, will have to grep the meeting logs? | 14:40 |
| * dhellmann reloads that page | 14:40 | |
| dhellmann | dims_: ok, we said 1.0 | 14:41 |
| dims_ | dhellmann: cool | 14:41 |
| dhellmann | dims_: I'll cut an rc today, but I see a few patches we probably want to land before the final release | 14:42 |
| dhellmann | dims_: esp. we need to sort out the autodoc question | 14:42 |
| dims_ | dhellmann: will look. | 14:42 |
| dims_ | dhellmann: yea, i got the autodoc ignore stuff we don't want exposed | 14:42 |
| dhellmann | dims_: yeah, I'm still torn on whether to use that or just create a few files by hand | 14:43 |
| dims_ | dhellmann: 2 things got me doing that...one is to stop docs from going stale if someone forgets to create by hand and other one was to make sure doc strings added are proper and we don't have to rush around trying to fix docstrings at the last minute. (I threw that switch for Nova to make sure everyone checks in good docstrings, seems to be working). we can talk more on friday | 14:47 |
| dhellmann | dims_: yeah, I like the automodule stuff, I just don't like auto-creating the automodule stuff, if that makes sense | 14:47 |
| dims_ | dhellmann: i hear ya. | 14:48 |
| dhellmann | dims_: I'd also like to be consistent, and we have some hand-crafted files in the other libs | 14:49 |
| dims_ | dhellmann: ya, other files will be used as-is | 14:54 |
| *** yamahata has joined #openstack-oslo | 15:05 | |
| *** mtanino has joined #openstack-oslo | 15:07 | |
| *** amrith is now known as _amrith_ | 15:20 | |
| *** andreykurilin has quit IRC | 15:23 | |
| openstackgerrit | A change was merged to openstack/oslo.messaging: Improve help strings https://review.openstack.org/117419 | 15:24 |
| *** markmcclain has quit IRC | 15:26 | |
| *** tedross has quit IRC | 15:27 | |
| *** ildikov_ has quit IRC | 15:41 | |
| *** tedross has joined #openstack-oslo | 15:43 | |
| *** yamahata has quit IRC | 15:43 | |
| *** jaosorior has quit IRC | 15:52 | |
| *** markmcclain has joined #openstack-oslo | 15:59 | |
| *** viktors is now known as viktors|afk | 16:01 | |
| *** _amrith_ is now known as amrith | 16:02 | |
| *** arnaud has joined #openstack-oslo | 16:04 | |
| *** nealph_ has quit IRC | 16:11 | |
| openstackgerrit | A change was merged to openstack/oslo.messaging: warn against sorting requirements https://review.openstack.org/118724 | 16:23 |
| openstackgerrit | amrith proposed a change to openstack/oslo.concurrency: Handle a failure on communicate() https://review.openstack.org/114664 | 16:32 |
| *** pblaho has quit IRC | 16:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/117940 | 16:53 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/119815 | 16:53 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Updated from global requirements https://review.openstack.org/118564 | 16:53 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.log: Updated from global requirements https://review.openstack.org/119144 | 16:53 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/115363 | 16:53 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.serialization: Updated from global requirements https://review.openstack.org/119145 | 16:53 |
| *** harlowja_away is now known as harlowja | 17:14 | |
| harlowja | dhellmann do u mind re+2ing https://review.openstack.org/#/c/114162/ (this is one of the final ones so that can get out a taskflow release), followup was added with the adjusted name + comments | 17:15 |
| harlowja | thx! | 17:16 |
| *** jaosorior has joined #openstack-oslo | 17:18 | |
| *** praneshp has joined #openstack-oslo | 17:19 | |
| harlowja | mriedem1 would u be able to check out https://review.openstack.org/#/c/119632/ ; mainly just sucking over the fixed jsonutils | 17:19 |
| mriedem1 | harlowja: +1 | 17:21 |
| harlowja | thx | 17:21 |
| *** markmcclain has quit IRC | 17:24 | |
| dims_ | dhellmann: i've lined up some requirements reviews - https://review.openstack.org/#/q/status:open+project:openstack/requirements,n,z - fyi | 17:24 |
| *** noelbk has joined #openstack-oslo | 17:26 | |
| *** takedakn has joined #openstack-oslo | 17:30 | |
| dhellmann | harlowja: looking | 17:31 |
| harlowja | ithx | 17:31 |
| harlowja | then i can get a release out and join the party, lol | 17:31 |
| harlowja | dhellmann another one that might interest u, https://review.openstack.org/#/c/119688/ (i was trying to include the changelog in the taskflow docs, and apparently found that it isn't getting generated when building docs) | 17:33 |
| harlowja | i'm unsure how the oslo libraries pull it in for there docs, ha | 17:33 |
| harlowja | i guess maybe cause the oslo libraries using pip install | 17:33 |
| dhellmann | harlowja: yes, you need to at least build an sdist of taskflow in the tox environment where the docs build | 17:34 |
| harlowja | dhellmann i tried that, but apparently how infra builds the docs is that they don't use the docs venv :-/ | 17:34 |
| dhellmann | they use the venv env | 17:34 |
| harlowja | hmmm | 17:35 |
| *** markmcclain has joined #openstack-oslo | 17:35 | |
| harlowja | i expected them to call into the 'docs' venv, but i guess thats non-standard | 17:35 |
| harlowja | which explained why it didn't work, ha | 17:36 |
| harlowja | in https://review.openstack.org/#/c/119668 | 17:36 |
| dhellmann | harlowja: the docs venv came after the doc building job | 17:36 |
| harlowja | ya, i wonder if it should be switched to have the doc building job always use the docs venv | 17:37 |
| harlowja | probably some simple adjustment of that infra script | 17:37 |
| dhellmann | harlowja: it doesn't look like setting skipsdist = False to the venv settings in taskflow does the right thing anyway | 17:37 |
| dhellmann | harlowja: yeah, noone has gotten to it yet | 17:37 |
| harlowja | let me see if i can locate that script, ha | 17:37 |
| harlowja | dhellmann another simple one if u get a sec (this one literally take 2 secs), https://review.openstack.org/#/c/119632/ :) | 17:41 |
| harlowja | thx | 17:41 |
| *** alexpilotti has joined #openstack-oslo | 17:48 | |
| dhellmann | harlowja: if you have more, please update https://etherpad.openstack.org/p/juno-oslo-feature-freeze | 17:52 |
| dhellmann | I can't keep up with a bunch of separate lists | 17:52 |
| dhellmann | only release blockers, though, please | 17:52 |
| harlowja | dhellmann afaik thats it :) | 17:52 |
| harlowja | but sure, will add | 17:52 |
| harlowja | alright, lets see if https://review.openstack.org/#/c/119851/ does the right thing for the docs venv | 18:07 |
| harlowja | *or at least makes it possible to use it, ha | 18:07 |
| *** sreshetnyak has quit IRC | 18:20 | |
| *** sreshetnyak has joined #openstack-oslo | 18:21 | |
| *** sreshetnyak has quit IRC | 18:36 | |
| *** tedross has quit IRC | 18:40 | |
| *** openstackgerrit has quit IRC | 18:51 | |
| *** tedross has joined #openstack-oslo | 18:53 | |
| *** wendar_ is now known as wendar | 18:58 | |
| dhellmann | dims_: have a sec to talk about docs? | 19:01 |
| dims_ | dhellmann: yep | 19:03 |
| dhellmann | so I see 2 issues with https://review.openstack.org/#/c/118960/ | 19:03 |
| dhellmann | one is filtering the files out of the toctree does prevent them from showing up in the table of contents, but sphinx will still process the files | 19:03 |
| dhellmann | I think that means we can't turn on warnerrors=true because sphinx will warn about the file not being in the toctree | 19:04 |
| dhellmann | second, and oslo.log is a good example of this, we're generating module names like oslo.log.log but that's not how we want people to use the library (we want "from oslo import log") | 19:04 |
| dhellmann | that's a lot easier to do by hand | 19:04 |
| dhellmann | so I think what we should do is auto-generate the files one time, and then move them around and clean them up and check them in | 19:05 |
| dhellmann | then we can disable the auto-generation | 19:05 |
| dhellmann | what do you think? | 19:05 |
| dhellmann | dims_: I left that as a comment on the review, too, for posterity | 19:07 |
| *** openstackgerrit has joined #openstack-oslo | 19:07 | |
| dims_ | sounds good to me dhellmann you know the flip side of it already from AM chat. we have to figure out a manual way to update docstrings before we cut new versions | 19:07 |
| dhellmann | dims_: update docstrings? | 19:08 |
| dims_ | say if someone updates the code and forgets to update docs | 19:08 |
| dhellmann | oh, like if they forget to add a new function to the autodoc instructions? | 19:09 |
| dims_ | y | 19:09 |
| dhellmann | yeah, that's something we'll have to keep an eye on in reviews, but I would rather forget to document something we mean to make public than the other way around | 19:09 |
| dims_ | sounds good | 19:10 |
| dhellmann | dims_: how hard do you think it would be to move all of the logging-related options into a single config group? | 19:12 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Be smarter about required flow symbols https://review.openstack.org/108137 | 19:14 |
| dims_ | dhellmann: should not be too bad | 19:15 |
| dhellmann | dims_: yeah, I'm looking at https://review.openstack.org/#/c/118644/3/oslo/log/log.py and trying to think about how we can hide the configuration settings from users of oslo.log | 19:15 |
| dhellmann | I wonder if the configfilter lets us register cli options after the arguments have been parsed | 19:15 |
| dhellmann | oh, sure enough, it does | 19:16 |
| dhellmann | I wonder if that actually works | 19:16 |
| dims_ | great question :) | 19:16 |
| * dims_ back in a bit | 19:17 | |
| *** pblaho has joined #openstack-oslo | 19:18 | |
| *** andreykurilin has joined #openstack-oslo | 19:22 | |
| dhellmann | dims_: ah, well, no it doesn't work | 19:23 |
| dhellmann | dims_: https://bugs.launchpad.net/oslo.config/+bug/1366946 | 19:27 |
| dhellmann | dims_: if it was just the debug & verbose options, I would say let the apps register them (make that part of the migration process) but we have a bunch of other cli opt definitions so I guess we have to keep them in the library :-/ | 19:30 |
| *** ajo_ has joined #openstack-oslo | 19:42 | |
| *** ajo_ has quit IRC | 19:59 | |
| openstackgerrit | A change was merged to openstack-dev/oslo-cookiecutter: Work toward Python 3.4 support and testing https://review.openstack.org/118856 | 20:00 |
| openstackgerrit | Doug Hellmann proposed a change to openstack-dev/oslo-cookiecutter: Build universal wheels by default https://review.openstack.org/119896 | 20:02 |
| *** dtantsur is now known as dtantsur|afk | 20:04 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Revamp the symbol lookup mechanism https://review.openstack.org/109672 | 20:04 |
| *** ajo_ has joined #openstack-oslo | 20:06 | |
| *** markmcclain has quit IRC | 20:08 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the linear flow symbol constraints https://review.openstack.org/107897 | 20:10 |
| *** amrith is now known as _amrith_ | 20:13 | |
| openstackgerrit | A change was merged to openstack/oslo.db: warn against sorting requirements https://review.openstack.org/118719 | 20:16 |
| *** kgiusti has left #openstack-oslo | 20:16 | |
| *** tedross has quit IRC | 20:20 | |
| openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.messaging: Import notifier middleware from oslo-incubator https://review.openstack.org/105746 | 20:30 |
| dhellmann | jd__: that was your change, but it needed a rebase ^^ | 20:31 |
| dhellmann | jd__: oddly, there were no merge conflicts, so I don't know why jenkins couldn't merge it for us | 20:32 |
| openstackgerrit | A change was merged to openstack/oslo.config: Work toward Python 3.4 support and testing https://review.openstack.org/118787 | 20:33 |
| openstackgerrit | A change was merged to openstack/oslo.config: Explain groups for DeprecatedOpts https://review.openstack.org/118680 | 20:33 |
| openstackgerrit | A change was merged to openstack/oslo.serialization: Work toward Python 3.4 support and testing https://review.openstack.org/118793 | 20:37 |
| openstackgerrit | A change was merged to openstack/cliff: mock.assert_called_once() is not a valid method https://review.openstack.org/119252 | 20:38 |
| openstackgerrit | A change was merged to openstack/cliff: Work toward Python 3.4 support and testing https://review.openstack.org/118772 | 20:38 |
| *** miqui has quit IRC | 20:43 | |
| *** r1chardj0n3s has quit IRC | 20:44 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the unordered flow symbol constraints https://review.openstack.org/108161 | 20:45 |
| *** r1chardj0n3s has joined #openstack-oslo | 20:45 | |
| openstackgerrit | Monty Taylor proposed a change to openstack/cliff: Add docs environment to tox.ini https://review.openstack.org/119912 | 20:47 |
| *** HenryG has quit IRC | 20:48 | |
| *** ajo has quit IRC | 20:49 | |
| *** markmcclain has joined #openstack-oslo | 20:50 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the graph flow symbol constraints https://review.openstack.org/108175 | 20:54 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the linear flow symbol constraints https://review.openstack.org/107897 | 20:55 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the unordered flow symbol constraints https://review.openstack.org/108161 | 20:55 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Relax the graph flow symbol constraints https://review.openstack.org/108175 | 20:55 |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add a couple of scope shadowing test cases https://review.openstack.org/110076 | 20:56 |
| harlowja | dhellmann i've seen that with a taskflow one also (the weird jenkins bird showing up) | 20:56 |
| harlowja | wasn't quite sure what that was about | 20:56 |
| harlowja | *gerrit bird i mean | 20:56 |
| harlowja | was sorta odd :-/ | 20:57 |
| dhellmann | yeah, I suspect it has something to do with when in the processing the merge failure is discovered | 20:57 |
| harlowja | agreed, i had to do something similar, just rebase it manually (no merge conflicts happened) | 20:58 |
| *** ajo_ has quit IRC | 20:58 | |
| *** HenryG has joined #openstack-oslo | 21:00 | |
| *** mriedem1 is now known as mriedem | 21:04 | |
| *** yamahata has joined #openstack-oslo | 21:35 | |
| *** yamahata has quit IRC | 21:36 | |
| *** yamahata has joined #openstack-oslo | 21:36 | |
| *** pblaho has quit IRC | 21:37 | |
| *** flaper87 is now known as flaper87|afk | 21:38 | |
| *** mriedem1 has joined #openstack-oslo | 21:44 | |
| *** mriedem has quit IRC | 21:45 | |
| *** dims_ has quit IRC | 21:48 | |
| *** dims has joined #openstack-oslo | 21:49 | |
| *** pcm_ has quit IRC | 21:51 | |
| *** jecarey has quit IRC | 21:53 | |
| *** dims has quit IRC | 21:53 | |
| *** dims has joined #openstack-oslo | 21:56 | |
| *** dims has quit IRC | 22:03 | |
| *** dims has joined #openstack-oslo | 22:03 | |
| *** dims has quit IRC | 22:08 | |
| *** jgrimm is now known as zz_jgrimm | 22:18 | |
| *** takedakn has quit IRC | 22:38 | |
| *** takedakn has joined #openstack-oslo | 22:38 | |
| *** mtanino has quit IRC | 22:40 | |
| *** bknudson has quit IRC | 22:49 | |
| *** jaosorior has quit IRC | 22:52 | |
| *** alexpilotti has quit IRC | 23:02 | |
| *** markmcclain has quit IRC | 23:14 | |
| *** yamahata has quit IRC | 23:37 | |
| *** _amrith_ is now known as amrith | 23:38 | |
| openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Update the state graph builder to use state machines https://review.openstack.org/119957 | 23:43 |
| *** arnaud has quit IRC | 23:44 | |
| *** jaypipes has quit IRC | 23:46 | |
| *** r1chardj0n3s is now known as r1chardj0n3s_afk | 23:48 | |
| *** r1chardj0n3s_afk is now known as r1chardj0n3s | 23:52 | |
| *** dims has joined #openstack-oslo | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!