*** harlowja_at_home has joined #openstack-oslo | 00:02 | |
*** e0ne has joined #openstack-oslo | 00:08 | |
*** alexpilotti has quit IRC | 00:08 | |
*** e0ne has quit IRC | 00:10 | |
*** e0ne has joined #openstack-oslo | 00:14 | |
*** e0ne has quit IRC | 00:19 | |
*** e0ne has joined #openstack-oslo | 00:23 | |
*** e0ne has quit IRC | 00:26 | |
*** e0ne has joined #openstack-oslo | 00:30 | |
*** oomichi has joined #openstack-oslo | 00:35 | |
*** stevemar has quit IRC | 00:40 | |
*** e0ne has quit IRC | 00:49 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 00:50 |
---|---|---|
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 00:52 |
*** boris-42 has quit IRC | 00:52 | |
*** e0ne has joined #openstack-oslo | 00:53 | |
*** e0ne has quit IRC | 01:06 | |
*** e0ne has joined #openstack-oslo | 01:09 | |
*** e0ne has quit IRC | 01:11 | |
*** git-harry has quit IRC | 01:12 | |
*** git-harry has joined #openstack-oslo | 01:12 | |
*** arnaud__ has joined #openstack-oslo | 01:16 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use condition variables using 'with' https://review.openstack.org/139895 | 01:17 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use condition variables using 'with' https://review.openstack.org/139895 | 01:21 |
*** harlowja_at_home has quit IRC | 01:37 | |
*** stevemar has joined #openstack-oslo | 02:05 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 02:39 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 02:43 |
*** ihrachyshka has quit IRC | 03:21 | |
*** sabari is now known as zz_sabari | 03:31 | |
*** david-lyle_afk has quit IRC | 03:31 | |
*** zz_sabari is now known as sabari | 03:31 | |
*** sabari is now known as zz_sabari | 03:36 | |
*** miqui_ has quit IRC | 03:40 | |
*** amotoki__away is now known as amotoki | 03:41 | |
*** david-lyle_afk has joined #openstack-oslo | 03:43 | |
*** david-lyle_afk has quit IRC | 03:50 | |
*** arnaud__ has quit IRC | 04:00 | |
*** zz_sabari is now known as sabari | 04:02 | |
*** david-lyle_afk has joined #openstack-oslo | 04:02 | |
*** david-lyle_afk has quit IRC | 04:02 | |
*** sabari is now known as zz_sabari | 04:07 | |
*** dimsum__ has quit IRC | 04:11 | |
*** arnaud__ has joined #openstack-oslo | 04:15 | |
*** jecarey has joined #openstack-oslo | 04:20 | |
*** ishant has joined #openstack-oslo | 04:28 | |
*** ishant has quit IRC | 04:28 | |
*** ckmvishnu has joined #openstack-oslo | 04:29 | |
*** zz_sabari is now known as sabari | 04:45 | |
*** jecarey has quit IRC | 04:53 | |
*** david-lyle_afk has joined #openstack-oslo | 05:01 | |
*** dimsum__ has joined #openstack-oslo | 05:11 | |
*** dimsum__ has quit IRC | 05:17 | |
*** arnaud__ has quit IRC | 05:18 | |
*** arnaud__ has joined #openstack-oslo | 05:30 | |
*** arnaud__ has quit IRC | 05:32 | |
*** arnaud__ has joined #openstack-oslo | 05:34 | |
*** arnaud__ has quit IRC | 05:38 | |
*** arnaud__ has joined #openstack-oslo | 05:41 | |
*** arnaud__ has quit IRC | 05:42 | |
*** rpodolyaka1 has joined #openstack-oslo | 06:01 | |
*** k4n0 has joined #openstack-oslo | 06:01 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/136566 | 06:13 |
*** ckmvishnu has quit IRC | 06:15 | |
*** vigneshvar has joined #openstack-oslo | 06:38 | |
*** liusheng has joined #openstack-oslo | 06:39 | |
*** liusheng has quit IRC | 06:51 | |
*** liusheng has joined #openstack-oslo | 06:52 | |
*** stevemar has quit IRC | 07:03 | |
*** arnaud__ has joined #openstack-oslo | 07:06 | |
*** subscope has joined #openstack-oslo | 07:40 | |
*** i159 has joined #openstack-oslo | 07:48 | |
*** tsufiev has quit IRC | 07:58 | |
*** mfedosin_ has quit IRC | 07:59 | |
*** dteselkin has quit IRC | 07:59 | |
*** liusheng has quit IRC | 08:02 | |
*** liusheng has joined #openstack-oslo | 08:03 | |
*** ihrachyshka has joined #openstack-oslo | 08:08 | |
*** mfedosin has joined #openstack-oslo | 08:10 | |
*** dteselkin has joined #openstack-oslo | 08:10 | |
*** rpodolyaka1 has quit IRC | 08:11 | |
*** tsufiev has joined #openstack-oslo | 08:14 | |
*** pblaho has joined #openstack-oslo | 08:42 | |
*** gothicmindfood has quit IRC | 08:48 | |
*** exploreshaifali has joined #openstack-oslo | 08:50 | |
*** arnaud__ has quit IRC | 08:51 | |
*** arnaud__ has joined #openstack-oslo | 08:52 | |
openstackgerrit | Sabari proposed openstack/oslo.vmware: Update urllib3 requirements https://review.openstack.org/139296 | 08:52 |
openstackgerrit | Frode Nordahl proposed openstack/oslo.messaging: Enable IPv6-support in libzmq by default https://review.openstack.org/138075 | 08:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/139945 | 08:58 |
*** exploreshaifali has quit IRC | 09:12 | |
*** dimsum__ has joined #openstack-oslo | 09:15 | |
*** gothicmindfood has joined #openstack-oslo | 09:15 | |
*** dimsum__ has quit IRC | 09:20 | |
*** oomichi has quit IRC | 09:22 | |
*** dtantsur|afk is now known as dtantsur | 09:34 | |
*** arnaud__ has quit IRC | 09:38 | |
*** e0ne has joined #openstack-oslo | 09:48 | |
*** sabari is now known as zz_sabari | 09:48 | |
*** e0ne has quit IRC | 10:04 | |
*** e0ne has joined #openstack-oslo | 10:06 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/oslo-incubator: Delete graduated concurrency files https://review.openstack.org/122796 | 10:15 |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo-specs: oslo.messaging functional tests proposal https://review.openstack.org/139964 | 10:41 |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo-specs: oslo.messaging functional tests proposal https://review.openstack.org/139964 | 10:43 |
*** andreykurilin_ has joined #openstack-oslo | 10:44 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo-specs: oslo.messaging functional tests proposal https://review.openstack.org/139964 | 10:48 |
*** noelbk has joined #openstack-oslo | 11:17 | |
*** ihrachyshka has quit IRC | 11:25 | |
*** ihrachyshka has joined #openstack-oslo | 11:29 | |
*** noelbk has quit IRC | 11:39 | |
*** dimsum__ has joined #openstack-oslo | 11:47 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: rabbit: more precise iterconsume timeout https://review.openstack.org/139980 | 11:59 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: qpid: honor iterconsume timeout https://review.openstack.org/139981 | 11:59 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: The executor don't need the set the timeout https://review.openstack.org/139982 | 11:59 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: The executor doesn't need to set the timeout https://review.openstack.org/139982 | 12:00 |
ihrachyshka | dimsum__: hey. did you have a change to fix the bug in oslo.concurrency with substitutions? | 12:04 |
dimsum__ | ihrachyshka: hey, i have a small test case to reproduce the situation, don't have an actual fix yet | 12:04 |
*** dimsum__ is now known as dims | 12:05 | |
ihrachyshka | dims: yeah, I actually wanted to start from a test case for that :) is it for oslo.concurrency? | 12:10 |
dims | even more basic... in oslo.config - http://paste.openstack.org/show/147086/ | 12:11 |
ihrachyshka | dims: ah yeah. iiuc there is no obvious fix for that | 12:12 |
ihrachyshka | dims: unless we introduce a special case for 'accessing configs via substitute' | 12:13 |
*** andreykurilin_ has quit IRC | 12:14 | |
*** viktors|afk is now known as viktors | 12:48 | |
*** takedakn has joined #openstack-oslo | 12:51 | |
*** amotoki has quit IRC | 12:54 | |
*** vigneshvar has quit IRC | 12:58 | |
*** exploreshaifali has joined #openstack-oslo | 13:03 | |
*** alexpilotti has joined #openstack-oslo | 13:08 | |
*** bknudson has quit IRC | 13:08 | |
*** ihrachyshka_ has joined #openstack-oslo | 13:22 | |
*** ihrachyshka has quit IRC | 13:23 | |
*** kgiusti has joined #openstack-oslo | 13:36 | |
*** amrith is now known as _amrith_ | 13:36 | |
*** gordc has joined #openstack-oslo | 13:38 | |
dims | ihrachyshka_: seems to go against the design of the cfg filter unfortunately | 13:42 |
ihrachyshka_ | dims: yes, that's why I said that the whole idea seems to be contrary to substitute feature | 13:43 |
ihrachyshka_ | which is essential | 13:43 |
dims | ihrachyshka_: y | 13:44 |
*** jeckersb_gone is now known as jeckersb | 13:47 | |
ihrachyshka_ | dims: I'll raise that on the meeting today | 13:49 |
ihrachyshka_ | dims: for oslo.concurrency, I would just go with switching back to cfg.CONF | 13:50 |
ihrachyshka_ | dims: thoughts? | 13:50 |
dims | let's talk to dhellmann, who should be here soon...ish | 13:51 |
*** pblaho has quit IRC | 14:06 | |
*** pblaho has joined #openstack-oslo | 14:08 | |
*** mjturek has joined #openstack-oslo | 14:23 | |
*** mriedem has joined #openstack-oslo | 14:35 | |
*** jaypipes has joined #openstack-oslo | 14:40 | |
openstackgerrit | Chuck Short proposed openstack/oslo.serialization: Fix strings for python3 https://review.openstack.org/140020 | 14:41 |
*** takedakn has quit IRC | 14:48 | |
*** zzzeek has joined #openstack-oslo | 14:50 | |
*** pradk has joined #openstack-oslo | 15:00 | |
*** bknudson has joined #openstack-oslo | 15:00 | |
*** arnaud__ has joined #openstack-oslo | 15:02 | |
dhellmann | viktors & zzzeek : can you review the alembic runner spec again, please? https://review.openstack.org/#/c/112842/10 | 15:04 |
zzzeek | hookay | 15:05 |
dhellmann | it seems like it's a lot simpler than the original version, but you both understand what we need better than I do | 15:05 |
*** _amrith_ is now known as amrith | 15:06 | |
*** arnaud__ has quit IRC | 15:07 | |
*** pblaho_ has joined #openstack-oslo | 15:10 | |
viktors | dhellmann: ok, will look | 15:14 |
*** exploreshaifali has quit IRC | 15:14 | |
dhellmann | zzzeek, viktors: thanks | 15:14 |
*** pblaho has quit IRC | 15:14 | |
*** jecarey has joined #openstack-oslo | 15:19 | |
*** gordc has quit IRC | 15:20 | |
*** gordc has joined #openstack-oslo | 15:23 | |
*** e0ne has quit IRC | 15:28 | |
viktors | zzzeek: hi! | 15:28 |
dhellmann | harlowja_away: did you release taskflow last week? | 15:30 |
zzzeek | viktors: hey viktors did u see my reviews | 15:30 |
viktors | zzzeek: yes, as for issue with OperationalError, which was mentioned on Friday - I tested with SQLA from master, and DBConnectionError was raised properly. | 15:31 |
viktors | zzzeek: thanks a lot! | 15:31 |
zzzeek | viktors: yes but also the gerrit makes it work in 0.9 | 15:31 |
zzzeek | viktors: they are all V+1 so lets push them up | 15:31 |
viktors | zzzeek: I've tested your changes to oslo.db and I got same issue, unfortunately, can you please check it on your side? | 15:32 |
zzzeek | viktors: OK | 15:32 |
viktors | zzzeek: my test was looks like this - http://paste.openstack.org/show/147249/ | 15:32 |
*** ihrachyshka_ has quit IRC | 15:33 | |
*** arnaud__ has joined #openstack-oslo | 15:35 | |
*** e0ne has joined #openstack-oslo | 15:39 | |
*** k4n0 has quit IRC | 15:40 | |
*** arnaud__ has quit IRC | 15:42 | |
dhellmann | reminder, meeting starting in 15 minutes | 15:45 |
*** zz_jgrimm is now known as jgrimm | 15:45 | |
openstackgerrit | Julien Danjou proposed openstack/tooz: memcached: add support for group deletion https://review.openstack.org/140037 | 15:47 |
openstackgerrit | Julien Danjou proposed openstack/tooz: tests: minor code simplification https://review.openstack.org/140038 | 15:47 |
*** arnaud__ has joined #openstack-oslo | 15:47 | |
openstackgerrit | Julien Danjou proposed openstack/tooz: memcached: add support for _destroy_group https://review.openstack.org/140039 | 15:47 |
openstackgerrit | Qin Zhao proposed openstack/oslo.concurrency: Move retrying dependency to version 1.2.3 https://review.openstack.org/140040 | 15:48 |
*** amotoki has joined #openstack-oslo | 15:51 | |
zzzeek | viktors: that test case is a different one. for that one I’m not sure we have a workaround short of upgrading to SQLAlhcemy 1.0 | 15:51 |
zzzeek | viktors: that’s the same SQLA issue but that’s not the “ping” handler, there is no opportunity for us to patch around that _revalidate_connection | 15:51 |
*** rpodolyaka1 has joined #openstack-oslo | 15:52 | |
zzzeek | viktors: this is because you are running on the same checked-out connection, rather than checking out fresh | 15:52 |
zzzeek | viktors: in nova api etc. it wouldn’t usually look like this, it would be on a new API hit and the ping handler would be hitting it | 15:52 |
*** kbyrne has quit IRC | 15:55 | |
*** ihrachyshka_ has joined #openstack-oslo | 15:57 | |
*** mtanino has joined #openstack-oslo | 15:57 | |
*** jaypipes has quit IRC | 15:59 | |
viktors | zzzeek: got it, I should check your changes with the real DBAPI hits instead of executing "select 1" on connections | 15:59 |
zzzeek | viktors: im looking to see if i can also wrap the pool connection function in < SQLA 1.0 | 16:00 |
*** kbyrne has joined #openstack-oslo | 16:00 | |
zzzeek | viktors: because yes, when it first connects, we aren’t catching that at all | 16:00 |
zzzeek | viktors: if this is critical for SQLA 0.9 i can try to patch into the actual connect fn | 16:00 |
viktors | zzzeek: I'm not really sure, is it critical, we need to check some usecases | 16:01 |
viktors | zzzeek: btw, it's meeting time ) | 16:01 |
zzzeek | viktors: yes | 16:01 |
*** ihrachyshka_ is now known as ihrachyshka | 16:02 | |
*** harlowja_at_home has joined #openstack-oslo | 16:03 | |
zzzeek | viktors: it’s also not working in SQLA 0.8 :( http://logs.openstack.org/38/139738/3/check/gate-oslo.db-tox-sqla_08/06edb8d/console.html | 16:04 |
*** david-lyle_afk is now known as david-lyle | 16:06 | |
*** tsekiyama has joined #openstack-oslo | 16:10 | |
*** gordc has quit IRC | 16:10 | |
viktors | zzzeek: :( | 16:13 |
zzzeek | viktors: is there a bug report illusrating what ppl definitely need here? | 16:13 |
zzzeek | i can keep patching this in, not a problem | 16:13 |
*** arnaud__ has quit IRC | 16:13 | |
zzzeek | i forgot to make it work on 0.8 i see why that is | 16:14 |
*** gordc has joined #openstack-oslo | 16:15 | |
*** gordc has quit IRC | 16:15 | |
viktors | zzzeek: do know, when we should bump SQLA version in global requirements? | 16:18 |
zzzeek | viktors: im happy bumping to 0.9, if we haven’t already | 16:19 |
viktors | zzzeek: we haven't - see https://github.com/openstack/requirements/blob/master/global-requirements.txt#L140 | 16:19 |
zzzeek | viktors: i dont know whats involved, but I’m +1 to bump | 16:19 |
openstackgerrit | Qin Zhao proposed openstack/oslo.concurrency: Move retrying dependency to version 1.2.3 https://review.openstack.org/140040 | 16:21 |
*** exploreshaifali has joined #openstack-oslo | 16:23 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Updated from global requirements https://review.openstack.org/140058 | 16:23 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: kombu: fix driver loading with kombu+qpid scheme https://review.openstack.org/140059 | 16:23 |
*** gordc has joined #openstack-oslo | 16:23 | |
*** jaypipes has joined #openstack-oslo | 16:25 | |
viktors | zzzeek: the fresh one - https://review.openstack.org/#/c/139880/ :) | 16:30 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: kombu: fix driver loading with kombu+qpid scheme https://review.openstack.org/140059 | 16:30 |
zzzeek | viktors: wow that just came out ? | 16:30 |
viktors | zzzeek: yes | 16:31 |
zzzeek | viktors: ok how does this work, this requirements file gets merged into all projects ? | 16:31 |
viktors | zzzeek: openstack bot will sync this requirement by projects | 16:32 |
zzzeek | viktors: woop! | 16:32 |
zzzeek | I can yank a crapload out when that hits ! | 16:32 |
zzzeek | viktors: need a +2 for https://review.openstack.org/#/c/139725/ and you probably want https://review.openstack.org/#/c/139733/ | 16:32 |
viktors | :-D | 16:33 |
viktors | zzzeek: ok, will do | 16:33 |
viktors | zzzeek: you probably want to +2A this https://review.openstack.org/#/c/140058/ | 16:35 |
zzzeek | viktors: done | 16:36 |
*** amrith is now known as _amrith_ | 16:37 | |
openstackgerrit | Merged openstack/oslo.vmware: Update urllib3 requirements https://review.openstack.org/139296 | 16:42 |
*** arnaud__ has joined #openstack-oslo | 16:44 | |
*** jgrimm has quit IRC | 16:44 | |
*** i159 has quit IRC | 16:45 | |
*** arnaud__ has quit IRC | 16:47 | |
*** exploreshaifali has quit IRC | 16:49 | |
*** amotoki has quit IRC | 16:53 | |
*** pblaho_ has quit IRC | 16:55 | |
zzzeek | dhellmann: suppose oslo.db requirements.txt says: “sqlalchemy >= 0.9.7” | 17:02 |
zzzeek | dhellmann: then, in that same oslo.db revision, we look at: https://github.com/openstack/oslo.db/blob/master/oslo/db/sqlalchemy/compat/handle_error.py#L39 | 17:02 |
zzzeek | dhellmann: under what circumstances would that conditional be False ? | 17:02 |
*** harlowja_at_home has quit IRC | 17:02 | |
zzzeek | the source to “utils.sqla_097” is: https://github.com/openstack/oslo.db/blob/master/oslo/db/sqlalchemy/compat/utils.py | 17:03 |
dhellmann | zzzeek: the question isn't so much about removing that code, but about actually being able to say that the requirements can change to sqlalchemy >= 0.97 | 17:04 |
*** sigmavirus24_awa is now known as sigmavirus24 | 17:04 | |
zzzeek | dhellmann: that’s outside of my wheelhouse :) that decision is based on what I see at https://review.openstack.org/#/c/139880/ and at what point that gets propagated | 17:05 |
dhellmann | zzzeek: yeah, I need you to learn about and understand the requirements stuff -- you can't shrug it off | 17:05 |
dhellmann | I cannot be the only one in Oslo who knows how the requirements updates are managed and what implications changing requirements has on our project | 17:05 |
zzzeek | dhellmann: it has to do with downstream vendors and packaging | 17:05 |
dhellmann | no, that is not all | 17:05 |
dhellmann | it also has to do with the way upgrades are tested | 17:06 |
dhellmann | grenade installs everything, runs some tests, upgrades things, then runs more tests | 17:06 |
*** zz_sabari is now known as sabari_ | 17:06 | |
dhellmann | it also ensures that the requirements overlap between the old version and the new version of the WHOLE system | 17:06 |
dhellmann | the packagers have some say about when we can bump requirements, but their voices are not the only voices with say | 17:07 |
zzzeek | dhellmann: wouldnt that grenade test be a simple block for such a change ? | 17:07 |
zzzeek | dhellmann: e.g. i propose library >= X. grenade fails because project Q needs library < X. | 17:07 |
dhellmann | yes, but the point of us having this conversation is to ensure that you understand that the test exists, and to make sure you're looking at how it works | 17:08 |
dhellmann | it is quite likely that everything is technically OK | 17:08 |
zzzeek | dhellmann: OK. im not following what you want me to be doing here, I’m not proposing any changes to requirements.txt. are you asking that I be involved in deciding when requirements.txt is safe to be bumped? | 17:09 |
dhellmann | it wasn't clear from what you said in the meeting if the requirements change had already merged, so I wanted to make sure you understood the whole process for that update | 17:09 |
dhellmann | since the change has merged, that means some version of grenade was able to run the upgrade test with that version of the lib, and so if oslo.db has that as a minimum it should be safe to remove the obsolete code | 17:10 |
*** sabari_ is now known as zz_sabari_ | 17:10 | |
zzzeek | dhellmann: yes, that discussion was only about, once oslo.db/requriements.txt has a version in it, the code immediately desecending from that file in that revision can assume that version | 17:11 |
dhellmann | yes, I believe that is safe | 17:12 |
*** viktors is now known as viktors|afk | 17:16 | |
*** openstackgerrit has quit IRC | 17:19 | |
*** openstackgerrit has joined #openstack-oslo | 17:19 | |
*** noelbk has joined #openstack-oslo | 17:20 | |
dhellmann | dims: it looks like most of the pre-release code work for oslo.context is done, but there are some project management tasks to do: https://blueprints.launchpad.net/oslo-incubator/+spec/graduate-oslo-context | 17:25 |
dhellmann | dims: some of that may be done, I only marked off the things I was sure of | 17:26 |
dims | dhellmann: if you are happy with the code, i can work on the rest | 17:26 |
*** rharwood has joined #openstack-oslo | 17:29 | |
*** ViswaV has joined #openstack-oslo | 17:31 | |
rharwood | hey all, oslo.messaging question. Looking at https://github.com/openstack/oslo.messaging/blob/a7f3ecb36041538026de8f095db773afec3534fc/oslo/messaging/_drivers/impl_rabbit.py#L70-72 suggests that rabbit_hosts should be set to `$rabbit_host:$rabbit_port` in the single-host case. Is that correct? | 17:31 |
dhellmann | dims: yeah, I think this is good for a first version | 17:32 |
dhellmann | rharwood: that's the default, so you shouldn't have to set it explicitly if that's what you mean | 17:33 |
rharwood | dhellmann: so it default to something with dollar signs in it, or does it do the substitution of the rabbit_host and rabbit_port values into that expression? | 17:35 |
dhellmann | rharwood: oh, $foo substitutes the value of foo in that place | 17:35 |
*** ViswaV has quit IRC | 17:35 | |
rharwood | dhellmann: great, thanks! | 17:36 |
*** ViswaV has joined #openstack-oslo | 17:36 | |
*** e0ne has quit IRC | 17:46 | |
*** stevemar has joined #openstack-oslo | 17:52 | |
openstackgerrit | Merged openstack/oslo.db: Updated from global requirements https://review.openstack.org/140058 | 17:59 |
*** _amrith_ is now known as amrith | 18:04 | |
*** ViswaV has quit IRC | 18:04 | |
*** ViswaV has joined #openstack-oslo | 18:06 | |
openstackgerrit | gordon chung proposed openstack/oslo-specs: messaging: notification dispatcher filter https://review.openstack.org/135379 | 18:12 |
*** denis_makogon has joined #openstack-oslo | 18:16 | |
*** harlowja_away is now known as harlowja | 18:20 | |
*** e0ne has joined #openstack-oslo | 18:23 | |
*** mriedem has quit IRC | 18:28 | |
*** andreykurilin_ has joined #openstack-oslo | 18:33 | |
*** e0ne has quit IRC | 18:43 | |
*** jaosorior has joined #openstack-oslo | 18:45 | |
*** e0ne has joined #openstack-oslo | 18:49 | |
*** vigneshvar has joined #openstack-oslo | 18:52 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Standardize bases in the pluggable modules https://review.openstack.org/139741 | 18:53 |
dims | dhellmann: pushed 0.1.0, should i add it to global requirements? | 19:05 |
palendae | dhellmann: You stated last week for https://bugs.launchpad.net/python-cliff/+bug/1379055 you were thinking about moving to cmd instead of cmd2 for - were you thinking of recreating any cmd2 features? | 19:05 |
dims | dhellmann: updated the work items in the blueprint page as well | 19:05 |
palendae | Or simply dropping those? | 19:05 |
*** raildo has joined #openstack-oslo | 19:07 | |
*** dtantsur is now known as dtantsur|afk | 19:07 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility https://review.openstack.org/140119 | 19:10 |
harlowja | dims let me know what u think of ^ | 19:10 |
harlowja | the talk of deprecation and helpers and such makes me think others need that | 19:10 |
harlowja | or at least a common utility to provide common deprecation patterns... | 19:11 |
*** rpodolyaka2 has joined #openstack-oslo | 19:11 | |
dims | harlowja: we have a @deprecated in oslo-incubator/openstack/common/versionutils.py - fyi | 19:13 |
harlowja | yes, thats not the same though | 19:13 |
dims | harlowja: y looking at yours now. | 19:13 |
harlowja | it uses pyhton logging, not what i think is the more common warnings module (which explicily is i think made for this stuff) | 19:13 |
harlowja | * aka https://docs.python.org/2/library/exceptions.html#exceptions.DeprecationWarning | 19:14 |
harlowja | and such | 19:14 |
harlowja | not saying the versionutils isn't useful, its just umm, different | 19:14 |
harlowja | * https://docs.python.org/2/library/warnings.html#warning-categories | 19:15 |
harlowja | i sorta think the versionutils one is ok for applications (nova, glance...) but for libraries they should prefer the warnings/depreciation warnings path | 19:15 |
dims | harlowja: yes, this will definitely be handy | 19:18 |
harlowja | ya, might as well provide some common patterns if we can | 19:19 |
harlowja | they may not be perfect, but i've found them usful | 19:19 |
dims | harlowja: what i would really love to have...is something like jdiff - http://javadiff.sourceforge.net/ so i can browse what changed and drill down into each class/method/parameter | 19:20 |
dims | haven't found one yet :( | 19:20 |
harlowja | interesting | 19:20 |
harlowja | does sound nice | 19:21 |
dims | too bad python is dynamic :) | 19:21 |
harlowja | ;) | 19:22 |
harlowja | i hear thats becoming more and more blurry :( | 19:22 |
harlowja | doesn't python 3 have type annotations or something | 19:23 |
* dims is clueless | 19:23 | |
harlowja | * http://www.infoq.com/news/2014/08/python-type-annotation-proposal | 19:23 |
harlowja | :-/ | 19:23 |
harlowja | def fib(n: int) -> None: | 19:24 |
harlowja | i think http://legacy.python.org/dev/peps/pep-3107/ already exists | 19:24 |
harlowja | that would ummm, be interesting | 19:25 |
harlowja | zzzeek would u be ok with a dogpile backend that uses pymemcache (i see there is one there for memcached and Pylibmc but not for pymemcache) * https://pypi.python.org/pypi/pymemcache | 19:27 |
harlowja | * https://pypi.python.org/pypi/pymemcache#comparison-with-other-libraries | 19:28 |
harlowja | dims the other neat things about the warnings module is https://docs.python.org/2/library/logging.html#logging.captureWarnings | 19:29 |
harlowja | so if people really still want to use logging (like the versionutils one), then sure they can | 19:29 |
*** zzzeek has quit IRC | 19:29 | |
dims | harlowja: nice! would be handy for the gate/check | 19:30 |
harlowja | ya | 19:30 |
*** vigneshvar has quit IRC | 19:31 | |
harlowja | although afaik the gate has warnings on | 19:31 |
harlowja | i believe | 19:31 |
*** liusheng has quit IRC | 19:32 | |
*** liusheng has joined #openstack-oslo | 19:32 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility https://review.openstack.org/140119 | 19:32 |
harlowja | i can add some tests for that stuff to if desired | 19:32 |
*** zzzeek has joined #openstack-oslo | 19:32 | |
harlowja | there is a way to locally capture all the warnings | 19:33 |
harlowja | * https://docs.python.org/2/library/warnings.html#testing-warnings | 19:33 |
*** zz_jgrimm has joined #openstack-oslo | 19:33 | |
harlowja | with warnings.catch_warnings(record=True) or something | 19:33 |
zzzeek | harlowja: sure, but also you can make a backend for that and use it externally too, doesnt need to be committed for you to use it | 19:33 |
harlowja | kk | 19:33 |
harlowja | fair nuff | 19:33 |
zzzeek | is that a newer backend | 19:33 |
*** andreykurilin_ has quit IRC | 19:33 | |
zzzeek | not sure why i dont have that already | 19:33 |
harlowja | newer library i think | 19:33 |
harlowja | jd__ is the expert in it, ha | 19:34 |
harlowja | tooz uses that | 19:34 |
harlowja | but other projects in openstack use python-memcached so therein lies the conundrum | 19:34 |
harlowja | and global requirements approvers don't like dups | 19:35 |
harlowja | *for better or worse | 19:35 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility https://review.openstack.org/140119 | 19:40 |
*** zz_jgrimm is now known as jgrimm | 19:40 | |
*** vigneshvar has joined #openstack-oslo | 19:42 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add deprecation + reflection auto documentation https://review.openstack.org/140129 | 19:46 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a moved_inheritable_class deprecation helper https://review.openstack.org/140132 | 19:54 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Standardize bases in the pluggable modules https://review.openstack.org/139741 | 19:55 |
dhellmann | harlowja: how does https://review.openstack.org/#/c/140119/3 related to versionutils? | 19:59 |
harlowja | not related, imho different usages | 19:59 |
harlowja | the versionutils one is tightly coupled to logging and the specific depreciation logging there, this one isn't | 20:00 |
harlowja | which i feel isn't appropriate for libraries to use (since i feel its not the common practice to do that) | 20:00 |
harlowja | 140119 uses the warnings module (which can be plugged into logging if so chosen) | 20:01 |
*** stannie1 has joined #openstack-oslo | 20:01 | |
harlowja | and uses the common https://docs.python.org/2/library/exceptions.html#exceptions.DeprecationWarning and such | 20:01 |
harlowja | so that libraries can follow the more standard practices here (vs the versionutils one) | 20:02 |
dhellmann | ok | 20:02 |
harlowja | i think the version utils one ok for applications that have used it and such, those that follow openstack releases... (its got its usages), | 20:02 |
harlowja | thats my 2 cents | 20:02 |
dhellmann | I don't know how I feel about having 2 versions of this sort of thing, though | 20:03 |
dhellmann | I like some of the features of this new one | 20:03 |
harlowja | i feel the newer one is the right way, but i might be just to opinonated ;) | 20:03 |
harlowja | vs using the logging module to replicate some of the warnings module | 20:03 |
dhellmann | yeah, we we discussed today, we can't get rid of the old one because that API is what people are using now. | 20:03 |
harlowja | the warning module shows location of code that is depreciated and such | 20:03 |
harlowja | i'm not suggesting get rid of | 20:03 |
dhellmann | I guess in this case we're warning developers and in the other case we're warning deployers | 20:04 |
harlowja | but 2 likely have to coexist at some point if u ever want to move things away to something else... | 20:04 |
harlowja | ya, maybe at that point its just a usage documentation | 20:04 |
dhellmann | yeah | 20:04 |
harlowja | versionutils for deployers, warnings (or variation of 140119) for deveopers | 20:04 |
harlowja | depending on who u are targeting | 20:04 |
harlowja | ex @ http://paste.ubuntu.com/9431427/ | 20:07 |
harlowja | but probably u've already seen similar stuff | 20:07 |
harlowja | warnings shows u the code location | 20:07 |
harlowja | which deployers don't care about | 20:07 |
harlowja | so perhaps thats how these co-exist | 20:07 |
harlowja | warnings already have the 'warn once' stuff built-in, it looks like oslo.log rebuilt that | 20:08 |
harlowja | *or rebuilt something similar | 20:09 |
dhellmann | yeah, I get that it's not a perfect thing, but we have to keep supporting it while people are using it | 20:11 |
dhellmann | harlowja: https://blueprints.launchpad.net/oslo-incubator/+spec/fix-import-cycle-log-and-versionutils | 20:12 |
harlowja | sure so perhaps that can just be fixed by using the warnings interconnect, idk | 20:13 |
harlowja | https://docs.python.org/2/library/logging.html#logging.captureWarnings | 20:13 |
harlowja | i'm not saying not support the other mechanism, its just they aren't the same usecases and not really the same result | 20:13 |
dhellmann | yeah, I don't know if we want all deprecations logged | 20:13 |
dhellmann | right, that much is clear now :-) | 20:14 |
harlowja | kk | 20:14 |
*** subscope_ has joined #openstack-oslo | 20:14 | |
harlowja | i believe libraries like sqlalchemy, and many others already use the warnings library, so it'd seem nice to use it for when its appropriate | 20:14 |
dhellmann | Yeah, the question is when is it appropriate? We only want to log warnings for things that deployers can fix. Otherwise, having warnings show up in unit test output, or even have them tripped as errors at some point in tests, brings them to the attention of developers. | 20:15 |
harlowja | sure, so maybe big warnings in unit test output | 20:17 |
harlowja | with red blinky colors | 20:17 |
*** mriedem has joined #openstack-oslo | 20:17 | |
harlowja | then turn that off on release | 20:17 |
harlowja | or yellow blinky (i'm not sure, can't decide) | 20:17 |
dhellmann | heh | 20:17 |
*** raildo has quit IRC | 20:18 | |
harlowja | anyways, something to think about; i find it useful, for developer <-> developer kind of stuff, that avoids breaking crap | 20:21 |
harlowja | or at least break crap in a more elegant manner, ha | 20:21 |
harlowja | maybe just turn on https://docs.python.org/2/library/logging.html#logging.captureWarnings in the CI system, turn it off outside of it | 20:23 |
*** noelbk has quit IRC | 20:23 | |
harlowja | have things that showup as 'py.warnings' blinky red/yellow (or maybe red/green to match the season) | 20:23 |
*** alexpilotti has quit IRC | 20:27 | |
*** e0ne has quit IRC | 20:32 | |
harlowja | ex, http://paste.ubuntu.com/9431665/ could be something that is plugged in (does not include blinky colors) | 20:32 |
*** rpodolyaka2 has quit IRC | 20:45 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add and use a new simple helper logging module https://review.openstack.org/123007 | 20:47 |
*** jamespage_ has joined #openstack-oslo | 20:52 | |
*** e0ne has joined #openstack-oslo | 20:59 | |
*** jamespage_ has quit IRC | 21:00 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Raise TemplateSubstitutionError from _substitute https://review.openstack.org/140143 | 21:00 |
*** e0ne has quit IRC | 21:02 | |
palendae | dhellmann: So I'm looking at removing the cmd2 dependency in cliff, and it appears right now interactive.py expects arguments passed around to be cmd2 classes (like ParsedString) | 21:02 |
palendae | dhellmann: Were you thinking about pulling in some of the cmd2 logic/classes when dropping back to stdlib cmd? | 21:03 |
*** amrith is now known as _amrith_ | 21:03 | |
*** jamespage_ has joined #openstack-oslo | 21:06 | |
*** e0ne has joined #openstack-oslo | 21:06 | |
*** kgiusti has left #openstack-oslo | 21:09 | |
dhellmann | palendae: let me look at that code | 21:10 |
palendae | dhellmann: http://git.openstack.org/cgit/openstack/cliff/tree/cliff/interactive.py#n101 specifically | 21:10 |
dhellmann | palendae: oh, cmd supports an interactive mode, so we might just have to update to use cmd instead of cmd2 | 21:11 |
palendae | dhellmann: Right, I actually just did that - however, the `statement` variable is cmd2.ParsedString | 21:11 |
dhellmann | right, I think in cmd you'll just get a string | 21:11 |
palendae | If I simply change cmd2 -> cmd, I just get a str | 21:11 |
palendae | Wasn't sure if you planned on replicating any of cmd2's features | 21:12 |
dhellmann | I was not planning to, no | 21:12 |
palendae | I'm ok with writing a spec for it, just want to make sure I'm on the same general page | 21:12 |
dhellmann | have you contacted catherine about a release? | 21:12 |
palendae | I have not | 21:12 |
dhellmann | palendae: yeah, it's been a while since I've thought about this and apparently I didn't write down the plan | 21:12 |
palendae | I'm kind of picking this up from sigmavirus24; but I can certainly reach out to her | 21:12 |
palendae | Came from https://bugs.launchpad.net/python-cliff/+bug/1379055 | 21:13 |
dhellmann | right | 21:13 |
sigmavirus24 | palendae: I'll assign that to you if you haven't already reassigned it | 21:13 |
palendae | sigmavirus24: Go for it | 21:13 |
sigmavirus24 | palendae: lp id? | 21:13 |
palendae | sigmavirus24: Actually I just did it | 21:14 |
sigmavirus24 | good | 21:14 |
dhellmann | palendae: oh, you know, she might have given me some rights on that repo the last time we had an issue, hang on | 21:14 |
*** mriedem1 has joined #openstack-oslo | 21:15 | |
dhellmann | palendae: it looks like I can merge changes but not make releases on pypi | 21:16 |
*** mriedem has quit IRC | 21:17 | |
dhellmann | palendae, sigmavirus24 : https://bitbucket.org/catherinedevlin/cmd2/pull-request/6/in-the-event-which-is-not-installed-return/diff is merged | 21:17 |
sigmavirus24 | dhellmann: awesome! | 21:18 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.log: Switch to oslo.context https://review.openstack.org/140147 | 21:18 |
palendae | dhellmann: Thanks | 21:18 |
dhellmann | palendae, sigmavirus24 : so now we just need a release. I'll email Catherine. | 21:18 |
palendae | dhellmann: Cool | 21:18 |
sigmavirus24 | :thumbsup: | 21:18 |
*** denis_makogon has quit IRC | 21:20 | |
*** andreykurilin_ has joined #openstack-oslo | 21:22 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo-incubator: Switch over to oslo.context https://review.openstack.org/140149 | 21:23 |
*** e0ne has quit IRC | 21:29 | |
*** e0ne has joined #openstack-oslo | 21:34 | |
*** jecarey has quit IRC | 21:39 | |
*** subscope_ has quit IRC | 21:48 | |
dhellmann | dims: you're tearing through the steps for creating oslo.context! :-) | 21:54 |
*** jgrimm is now known as zz_jgrimm | 21:57 | |
*** zz_jgrimm is now known as jgrimm | 21:58 | |
dims | dhellmann: :) muscle memory now | 21:58 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility https://review.openstack.org/140119 | 21:59 |
*** noelbk has joined #openstack-oslo | 21:59 | |
*** boris-42 has joined #openstack-oslo | 22:00 | |
*** pradk has quit IRC | 22:04 | |
*** jamespage_ has quit IRC | 22:05 | |
openstackgerrit | ayoung proposed openstack/oslo-specs: Graduate Policy https://review.openstack.org/140161 | 22:05 |
*** _amrith_ is now known as amrith | 22:10 | |
*** oomichi has joined #openstack-oslo | 22:11 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add and use a new simple helper logging module https://review.openstack.org/123007 | 22:17 |
*** jeckersb is now known as jeckersb_gone | 22:20 | |
openstackgerrit | Merged openstack/taskflow: Use condition variables using 'with' https://review.openstack.org/139895 | 22:25 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add appropriate links into README.rst https://review.openstack.org/140167 | 22:28 |
openstackgerrit | Merged openstack/tooz: tests: do not skip test on connection error https://review.openstack.org/138060 | 22:29 |
*** andreykurilin_ has quit IRC | 22:30 | |
*** andreykurilin_ has joined #openstack-oslo | 22:31 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo-incubator: Remove whitespace after project description https://review.openstack.org/140170 | 22:33 |
openstackgerrit | Joshua Harlow proposed openstack/oslo-incubator: Remove whitespace after project description + before range https://review.openstack.org/140170 | 22:35 |
openstackgerrit | Joshua Harlow proposed openstack/oslo-incubator: Exit the script early if something fails https://review.openstack.org/140171 | 22:38 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add deprecation + reflection auto documentation https://review.openstack.org/140129 | 22:39 |
openstackgerrit | Merged openstack/tooz: tests: remove check_port https://review.openstack.org/138062 | 22:40 |
openstackgerrit | Merged openstack/tooz: memcached: delete stale/dead group members on get_members() https://review.openstack.org/138064 | 22:40 |
openstackgerrit | Merged openstack/tooz: tests: check for leave group events on dead members cleanup https://review.openstack.org/138377 | 22:40 |
*** ihrachyshka has quit IRC | 22:40 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add deprecation + reflection auto documentation https://review.openstack.org/140129 | 22:41 |
*** alexpilotti has joined #openstack-oslo | 22:47 | |
*** gordc has quit IRC | 22:50 | |
*** noelbk has quit IRC | 22:53 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Ensure DBConnectionError is raised on failed revalidate https://review.openstack.org/139738 | 22:54 |
*** bknudson has quit IRC | 22:55 | |
*** vigneshvar has quit IRC | 22:58 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 22:58 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Standardize bases in the pluggable modules https://review.openstack.org/139741 | 23:01 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a moved_inheritable_class deprecation helper https://review.openstack.org/140132 | 23:01 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow loading conductors via entrypoints https://review.openstack.org/124617 | 23:01 |
*** oslonorway has joined #openstack-oslo | 23:02 | |
*** oslonorway has left #openstack-oslo | 23:03 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add and use a new simple helper logging module https://review.openstack.org/123007 | 23:03 |
*** alexpilotti has quit IRC | 23:11 | |
*** jaosorior has quit IRC | 23:23 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: config: Add a spec for a oslo.config proxy config opts https://review.openstack.org/130047 | 23:33 |
*** jgrimm is now known as zz_jgrimm | 23:41 | |
harlowja | jaypipes u mind looking over ^ ; seems like u looked it over once, just adjusted it to hopefully be more nice and such, ha | 23:43 |
harlowja | when u get some time | 23:43 |
harlowja | hopefully its more clear and more agreeable and such | 23:44 |
harlowja | although i do understand dhellmann points | 23:44 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!