*** david-lyle is now known as david-lyle_afk | 00:11 | |
*** andreykurilin_ has quit IRC | 00:12 | |
*** andreykurilin_ has joined #openstack-oslo | 00:13 | |
*** dims has quit IRC | 00:17 | |
*** ViswaV has quit IRC | 00:18 | |
*** dims has joined #openstack-oslo | 00:19 | |
*** ViswaV has joined #openstack-oslo | 00:20 | |
*** ViswaV has quit IRC | 00:25 | |
*** ViswaV has joined #openstack-oslo | 00:25 | |
*** dims has quit IRC | 00:30 | |
*** noelbk has joined #openstack-oslo | 00:35 | |
*** noelbk has quit IRC | 00:39 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Update links + python version supported https://review.openstack.org/140541 | 00:39 |
---|---|---|
*** dims has joined #openstack-oslo | 00:43 | |
*** dims has quit IRC | 01:11 | |
*** zzzeek has quit IRC | 01:16 | |
*** sabari is now known as zz_sabari | 01:25 | |
*** tsekiyam_ has joined #openstack-oslo | 01:42 | |
*** ViswaV has quit IRC | 01:44 | |
*** andreykurilin_ has quit IRC | 01:44 | |
*** tsekiyama has quit IRC | 01:46 | |
*** tsekiyam_ has quit IRC | 01:46 | |
*** oomichi_ has joined #openstack-oslo | 01:57 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 02:09 | |
*** harlowja has joined #openstack-oslo | 02:10 | |
*** raildo_ has quit IRC | 02:24 | |
*** prontotest has joined #openstack-oslo | 02:25 | |
*** prontotest has left #openstack-oslo | 02:25 | |
*** oomichi_ has quit IRC | 02:44 | |
*** zz_sabari is now known as sabari | 02:54 | |
*** harlowja is now known as harlowja_away | 03:12 | |
*** _amrith_ is now known as amrith | 03:20 | |
*** amotoki has joined #openstack-oslo | 03:28 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 03:31 | |
*** oomichi_ has joined #openstack-oslo | 03:35 | |
*** mtanino has quit IRC | 03:39 | |
*** amotoki has quit IRC | 04:17 | |
*** amotoki has joined #openstack-oslo | 04:34 | |
*** harlowja_at_home has joined #openstack-oslo | 05:06 | |
*** rpodolyaka2 has joined #openstack-oslo | 05:18 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Add driver autogenerated docs https://review.openstack.org/140263 | 05:19 |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Add driver autogenerated docs https://review.openstack.org/140263 | 05:25 |
*** harlowja_away is now known as harlowja | 05:28 | |
*** harlowja is now known as harlowja_away | 05:29 | |
openstackgerrit | Merged openstack/taskflow: Remove rtype from task clone() doc https://review.openstack.org/140264 | 05:48 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility https://review.openstack.org/140119 | 06:03 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility https://review.openstack.org/140119 | 06:05 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Add a deprecation helper/utility https://review.openstack.org/140119 | 06:07 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/136566 | 06:12 |
*** harlowja_at_home has quit IRC | 06:37 | |
*** oomichi_ has quit IRC | 06:46 | |
openstackgerrit | Merged openstack/taskflow: Just assign a empty collection instead of copy/clear https://review.openstack.org/140530 | 07:05 |
*** e0ne has joined #openstack-oslo | 07:08 | |
*** k4n0 has joined #openstack-oslo | 07:25 | |
*** ViswaV has joined #openstack-oslo | 07:28 | |
*** ViswaV_ has joined #openstack-oslo | 07:32 | |
*** ViswaV has quit IRC | 07:32 | |
*** dtantsur|afk is now known as dtantsur | 07:55 | |
flaper87 | sileht: ping | 08:00 |
sileht | flaper87, pong | 08:00 |
flaper87 | sileht: hey, good morning :) | 08:01 |
flaper87 | sileht: got few mins to talk about https://bugs.launchpad.net/oslo.messaging/+bug/1288878 | 08:01 |
flaper87 | ? | 08:01 |
sileht | yep | 08:01 |
flaper87 | cool | 08:01 |
flaper87 | so, I think it'd be worth to catch the clear failure and log a warning/error instead of blowing everything up onto user's faces | 08:02 |
flaper87 | I know you said you don't like the idea | 08:02 |
flaper87 | but I don't think the fact that it's a public API is a good reason not to do it | 08:02 |
flaper87 | actually, since it's a public API, we *have* to be more careful on how we communicate these things to users | 08:03 |
flaper87 | if we delete a localcontext that doesn't exist, we should we make it fail ? | 08:04 |
flaper87 | s/we/why/ | 08:04 |
sileht | flaper87, the issue is that only get_local_context should be public, clean/set should be private | 08:05 |
flaper87 | sileht: that I agree with, lets fix it :D, lets make them private and raise a warning | 08:06 |
flaper87 | then we'll remove them from the public API | 08:06 |
flaper87 | but until then, I think we shouldn't blow this up on user's face | 08:06 |
sileht | flaper87, if the user cannot clear the localcontext it cannot get AttributeError (excepting if it have not monkeypatched correclty) | 08:07 |
flaper87 | sileht: exactly, that last bit is the one I'm worried about. I think, in this particular case, there's something we can do to make user's life easier | 08:09 |
flaper87 | Probably by moving forward with your original patch | 08:09 |
*** rpodolyaka2 has quit IRC | 08:10 | |
sileht | flaper87, my original patch will only hide the real issue, monkeypatching done after module have been loaded | 08:10 |
sileht | flaper87, as eventlet says : 'It is important to call monkey_patch() as early in the lifetime of the application as possible' | 08:11 |
flaper87 | sileht: yup, I know that. My point is that we need to communicate this to the user before we get to the point of clearing the local context | 08:11 |
flaper87 | Otherwise, every user of oslo.messaging+eventlet will come to us with the same issue/questions | 08:11 |
flaper87 | and they'll all claim it's our fault | 08:11 |
flaper87 | The reason I moved that bug to confirmed again is because it's not the first time I get these complains | 08:12 |
flaper87 | Probably try/except is not the best solution there, as you mentioned. However, there must be something we can do to improve the user experience there | 08:12 |
sileht | flaper87, I'm bit sad to write code just because people doesn't use eventlet correclty... | 08:14 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.serialization: Deprecate substituting jsonutils as a anyjson reference impl https://review.openstack.org/117844 | 08:15 |
openstackgerrit | Merged openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/136566 | 08:16 |
flaper87 | sileht: people doesn't use eventlet correctly becaue they don't know how to do it. If there's something we can do to help with that, I believe we should. I'm not saying we have to add hacks to avoid these errors but at least, there should be a warning somewhere telling the user that eventlet monkey_patch was not called when it was supposed to | 08:16 |
flaper87 | s/doesn't/don't/ | 08:16 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.serialization: Deprecate substituting jsonutils as a anyjson reference impl https://review.openstack.org/117844 | 08:16 |
sileht | flaper87, a warning in the eventlet executor and some docs looks a good solution for me | 08:16 |
flaper87 | sileht: there you go, now we're talking :) | 08:17 |
flaper87 | ok, lets go with that | 08:17 |
flaper87 | I'll comment on the bug again with a gist of our discussion | 08:17 |
flaper87 | thanks for your time | 08:17 |
sileht | flaper87, cool that | 08:17 |
sileht | flaper87, cool thanks | 08:17 |
*** ViswaV_ has quit IRC | 08:23 | |
*** stevemar has quit IRC | 08:25 | |
*** oomichi has joined #openstack-oslo | 08:26 | |
*** e0ne has quit IRC | 08:36 | |
*** oomichi has quit IRC | 08:40 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Warns user if thread monkeypatch is not done https://review.openstack.org/140610 | 08:49 |
sileht | flaper87, ^^ | 08:50 |
flaper87 | sileht: awesome, thanks. You beat me on that | 08:50 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Fixes localcontext API https://review.openstack.org/140616 | 09:08 |
sileht | flaper87, and the API deprecation ^^ | 09:10 |
* sileht wanted to do that since a long time | 09:10 | |
*** i159 has joined #openstack-oslo | 09:20 | |
* flaper87 reviews that | 09:22 | |
*** sabari is now known as zz_sabari | 09:26 | |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.db: Use PyMySQL as DB driver in py3 environment https://review.openstack.org/133962 | 09:33 |
*** ozamiatin has quit IRC | 09:38 | |
*** e0ne has joined #openstack-oslo | 09:41 | |
*** ihrachyshka has joined #openstack-oslo | 09:51 | |
*** subscope has joined #openstack-oslo | 09:56 | |
jokke_ | morning | 10:02 |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.db: Use PyMySQL as DB driver in py3 environment https://review.openstack.org/133962 | 10:16 |
*** viktors|afk is now known as viktors | 10:20 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Fixes localcontext API https://review.openstack.org/140616 | 10:24 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Warns user if thread monkeypatch is not done https://review.openstack.org/140610 | 10:24 |
*** ihrachyshka_ has joined #openstack-oslo | 10:28 | |
*** ihrachyshka has quit IRC | 10:30 | |
*** amotoki has quit IRC | 10:51 | |
*** andreykurilin_ has joined #openstack-oslo | 11:34 | |
*** alexpilotti has joined #openstack-oslo | 11:35 | |
*** inc0 has joined #openstack-oslo | 11:39 | |
inc0 | dhellmann, ping | 11:41 |
*** vigneshvar has joined #openstack-oslo | 11:46 | |
openstackgerrit | Ilya Pekelny proposed openstack/oslo.db: Use alternative url string for Py3 https://review.openstack.org/139015 | 11:57 |
*** e0ne has quit IRC | 12:00 | |
*** david-lyle_afk is now known as david-lyle | 12:09 | |
*** david-lyle is now known as david-lyle_afk | 12:17 | |
*** david-lyle_afk is now known as david-lyle | 12:17 | |
*** david-lyle is now known as david-lyle_afk | 12:23 | |
*** david-lyle_afk is now known as david-lyle | 12:23 | |
*** sgotliv has joined #openstack-oslo | 12:25 | |
*** jaosorior has joined #openstack-oslo | 12:27 | |
*** amotoki has joined #openstack-oslo | 12:29 | |
*** david-lyle is now known as david-lyle_afk | 12:31 | |
*** david-lyle_afk is now known as david-lyle | 12:31 | |
*** e0ne has joined #openstack-oslo | 12:52 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Raise TemplateSubstitutionError from _substitute https://review.openstack.org/140143 | 12:54 |
dhellmann | inc0: pong | 12:56 |
inc0 | hello dhellmann, I have question about oslo.versionedobjects | 12:56 |
dhellmann | ok | 12:57 |
inc0 | is there anything going on in this matter? I'm trying to prepare heat to introduce this | 12:57 |
dhellmann | inc0: we haven't started working on it, yet. The spec is approved but we have a lot of other work happening right now. | 12:58 |
inc0 | do you have any vision of API to use? which parts will be in oslo and which will have to be implemented in every project? | 12:58 |
dhellmann | inc0: I really don't know that code well yet. Have you talked to Dan? | 12:59 |
openstackgerrit | Merged openstack/oslo.messaging: rabbit: more precise iterconsume timeout https://review.openstack.org/139980 | 12:59 |
inc0 | what is his irc nick? | 12:59 |
dhellmann | inc0: the API is described a bit in the spec: http://specs.openstack.org/openstack/oslo-specs/specs/kilo/adopt-oslo-versionedobjects.html | 12:59 |
dhellmann | inc0: dansmith | 13:00 |
*** david-lyle is now known as david-lyle_afk | 13:00 | |
inc0 | ok, I'll try to catch him, thanks | 13:00 |
*** kgiusti has joined #openstack-oslo | 13:03 | |
*** tedross has joined #openstack-oslo | 13:04 | |
openstackgerrit | Merged openstack/oslo.messaging: qpid: honor iterconsume timeout https://review.openstack.org/139981 | 13:04 |
openstackgerrit | Merged openstack/oslo.messaging: The executor doesn't need to set the timeout https://review.openstack.org/139982 | 13:05 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Set the version string https://review.openstack.org/140671 | 13:11 |
*** andreykurilin_ has quit IRC | 13:27 | |
*** jeckersb is now known as jeckersb_gone | 13:27 | |
*** vigneshvar has quit IRC | 13:28 | |
*** amotoki_ has joined #openstack-oslo | 13:28 | |
*** amrith is now known as _amrith_ | 13:30 | |
jd__ | flaper87: hint hint https://review.openstack.org/#/c/127923/ | 13:40 |
* flaper87 clicks | 13:40 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency: Clean up API documentation https://review.openstack.org/140680 | 13:40 |
viktors | jd__: hi! Can you please +2A a simple patch https://review.openstack.org/#/c/140291 ? | 13:45 |
openstackgerrit | Merged openstack/oslo-specs: Restore app-agnostic-logging-parameters spec https://review.openstack.org/132551 | 13:47 |
*** amotoki has quit IRC | 13:51 | |
*** amotoki_ is now known as amotoki | 13:51 | |
*** stevemar has joined #openstack-oslo | 13:54 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Stop sorting options on output https://review.openstack.org/136482 | 13:56 |
*** subscope has quit IRC | 14:08 | |
*** subscope has joined #openstack-oslo | 14:21 | |
*** jecarey has joined #openstack-oslo | 14:23 | |
*** bknudson has joined #openstack-oslo | 14:23 | |
*** mriedem has joined #openstack-oslo | 14:23 | |
*** mjturek has joined #openstack-oslo | 14:23 | |
*** jaypipes has joined #openstack-oslo | 14:29 | |
*** mjturek has quit IRC | 14:31 | |
dhellmann | viktors: I have a question about oslo.db and glance, if you have a minute? | 14:33 |
dhellmann | viktors: I am working on moving the oslo/db package to oslo_db. I have a traceback in a devstack log where glance is importing oslo.db in a way I don't understand: http://logs.openstack.org/87/138787/8/check/gate-tempest-dsvm-neutron-src-oslo.db/88772a7/logs/devstacklog.txt.gz | 14:33 |
dhellmann | viktors: it does "from oslo import db" and then later "db.options.set_defaults()" but there is nothing in the oslo/db/__init__.py that would create an "options" and oslo/db/options.py is not being imported as far as I can tell | 14:34 |
dhellmann | flaper87: maybe you have an idea about this, too? ^^ | 14:35 |
* flaper87 clicks | 14:35 | |
* flaper87 reads | 14:36 | |
dhellmann | flaper87: I don't understand how that glance code can be working with the released version of oslo.db. | 14:36 |
flaper87 | oh, mhhh... | 14:39 |
*** dims has joined #openstack-oslo | 14:39 | |
viktors | looks really weird | 14:39 |
flaper87 | Python works mysterious ways | 14:39 |
flaper87 | Should I have put that in quotes? | 14:40 |
flaper87 | :P | 14:40 |
viktors | I'm not sure, that this file was executed ) | 14:40 |
flaper87 | viktors: that was my guess as well but you need glance-mange to sync the db | 14:41 |
dhellmann | flaper87: oh, how weird, if I run some other glance imports first it works: http://paste.openstack.org/show/148708/ | 14:42 |
viktors | dhellmann: see http://paste.openstack.org/show/148709/ | 14:42 |
dhellmann | viktors: ah | 14:42 |
*** tsekiyama has joined #openstack-oslo | 14:42 | |
viktors | dhellmann: have you got something? | 14:43 |
dhellmann | no, I thought you had found some magic happening somewhere | 14:43 |
dhellmann | it appears that we're relying on an import side-effect here, and that seems bad | 14:44 |
*** inc0 has quit IRC | 14:44 | |
* flaper87 digging into this | 14:44 | |
flaper87 | dhellmann: import side effect sounds like a nice way to say: "A very fucked-up attribute injection" | 14:45 |
flaper87 | :P | 14:45 |
* flaper87 stops ranting and digs more | 14:45 | |
dhellmann | this looks like a python "feature": http://paste.openstack.org/show/148710/ | 14:45 |
dhellmann | flaper87: I think I'll submit a patch to glance to change the way that import works in the migration module, to not rely on this side-effect | 14:46 |
viktors | yes, it looks like, that we have "from oslo.db import options" before db.options usage | 14:46 |
dhellmann | viktors: yes, something like that | 14:46 |
flaper87 | probably something related to the namespace thingy | 14:46 |
flaper87 | dhellmann: ok, if you want, I'll take care of that | 14:47 |
flaper87 | s/I'll/I can/ | 14:47 |
dhellmann | yeah, patch coming shortly | 14:47 |
flaper87 | ok | 14:47 |
* flaper87 waits, ready for review | 14:47 | |
*** sgotliv has quit IRC | 14:53 | |
*** pblaho has joined #openstack-oslo | 14:54 | |
*** _amrith_ is now known as amrith | 14:55 | |
dhellmann | flaper87: https://review.openstack.org/140709 | 14:57 |
dhellmann | viktors: ^^ | 14:57 |
flaper87 | dhellmann: +2 | 14:58 |
flaper87 | I'll wait for jenkins and ninja-approve if necessary | 14:58 |
dhellmann | flaper87: ty; I'm blocked on that oslo.db namespace package change by this. I could have worked around it, but I think fixing this in glance is the more correct solution. | 14:59 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Warns user if thread monkeypatch is not done https://review.openstack.org/140610 | 15:03 |
*** dims has quit IRC | 15:05 | |
*** dims has joined #openstack-oslo | 15:05 | |
*** jeckersb_gone is now known as jeckersb | 15:08 | |
*** sgotliv has joined #openstack-oslo | 15:10 | |
*** dims has quit IRC | 15:10 | |
*** mtanino has joined #openstack-oslo | 15:13 | |
sileht | dhellmann, does oslo.context have been released ? | 15:24 |
sileht | dhellmann, according pypi yes, can I migrate to that version ? | 15:24 |
dhellmann | sileht: yes, there is a 0.1.0 release of oslo.context | 15:25 |
dhellmann | we need to figure out what we need to add to it to make it work for oslo.messaging | 15:25 |
dhellmann | to replace or supplement the API in oslo.messaging | 15:25 |
sileht | dhellmann, I don't know who use the oslo.messaging localcontext but because get_local_context signature is broken and looks weird, I bet nobody | 15:27 |
dhellmann | sileht: let's not make that assumption without checking :-) | 15:27 |
sileht | dhellmann, the difference I see: | 15:27 |
sileht | * the context was a dict it will because an object | 15:27 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware: Add pbr to installation requirements https://review.openstack.org/130790 | 15:28 |
sileht | * the list of field is describe by oslo.context but before we just put the whole ctxt receive in rpccall/notification | 15:28 |
*** zz_jgrimm is now known as jgrimm | 15:29 | |
sileht | * and the thread cache of oslo.context is never cleaned | 15:29 |
sileht | dhellmann, ^ | 15:29 |
dhellmann | sileht: the thread cache is cleaned when a new context is created | 15:29 |
dhellmann | although I wonder if we should have some sort of explicit cleanup there | 15:29 |
sileht | dhellmann, oslo.messaging create a greenthread each time a rpc message is dispatched | 15:30 |
dhellmann | sileht: as far as I can tell, only oslo.messaging has references to get_local_context and set_local_context | 15:30 |
sileht | dhellmann, yes | 15:30 |
dhellmann | sileht: what sets the context for those threads? | 15:30 |
sileht | dhellmann, the oslo/messaging/{rpc,notify}/dispatcher.py | 15:31 |
sileht | dhellmann, this the context set when the client have use rpclient.call(CTXT, ....) | 15:32 |
dhellmann | ok, and is that a dictionary or is that an object? | 15:32 |
sileht | dhellmann, a dictionnary | 15:32 |
dhellmann | the CTXT variable, I mean | 15:32 |
dhellmann | :-( | 15:32 |
* sileht checks | 15:32 | |
dhellmann | ok, this may be a longer-term change | 15:32 |
dhellmann | part of the idea for oslo.context was to have those instances directly usable by oslo.messaging, too | 15:33 |
sileht | dhellmann, we can do that we a backward compatibility path | 15:33 |
dhellmann | yeah | 15:34 |
sileht | dhellmann, https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/_drivers/amqpdriver.py#L358 | 15:34 |
dhellmann | but your point about having a lot more threads than I realized, and oslo.context never cleaning up, makes me think maybe we should do something about that | 15:34 |
dhellmann | sileht: hahaha | 15:34 |
sileht | dhellmann, yes this is the only blocking point | 15:34 |
dhellmann | sileht: we have a bit of a conflict with the way the context is used elsewhere. | 15:35 |
* dhellmann goes to look at the nova code again | 15:35 | |
*** gordc has joined #openstack-oslo | 15:35 | |
dhellmann | ah, the store in nova uses weak references | 15:35 |
dhellmann | and oslo.context only uses a threading.local | 15:36 |
dhellmann | ugh, did that weak local reference thing end up in concurrency? | 15:36 |
dhellmann | oh, maybe we didn't put it anywhere | 15:37 |
openstackgerrit | Rossella Sblendido proposed openstack/oslo.db: Retry query if db deadlock error is received https://review.openstack.org/109549 | 15:37 |
sileht | dhellmann, it works is monkeypatching occurs before the threading.local is created | 15:37 |
sileht | is/if | 15:37 |
dhellmann | sileht: yes, I think we're assuming that | 15:38 |
dhellmann | however, we have a memory leak, don't we? because things are added to the local store, but never removed -- does the thread code clean that up when a thread exits? | 15:38 |
sileht | dhellmann, in oslo.messaging, no because we clean this store but for nova I think yes | 15:39 |
dhellmann | right, I was asking in the general case how memory leaks are avoided with threading.local or the monkeypatched version | 15:40 |
sileht | ahah | 15:41 |
sileht | for rpc stuff only oslo.messaging known when the work starts and ends | 15:42 |
sileht | for wsgi stuff only only the wsgi controller known that | 15:42 |
dhellmann | true | 15:42 |
sileht | for pecan we can add post_request hook | 15:42 |
sileht | oslo.messaging already do the cleanup, but we have to update nova to use the context prepare by oslo.messaging | 15:43 |
sileht | and nova have to switch to oslo.context first to not break averything | 15:43 |
dhellmann | that makes sense | 15:44 |
dhellmann | can oslo.messaging use the API in oslo.context to fetch the current context object? or does it need to have one passed explicitly? | 15:44 |
sileht | oslo.messaging doesn't need the context | 15:45 |
dhellmann | ? | 15:45 |
dhellmann | it has a context, but it's not the same now, and I thought it would be good for it to be the same | 15:46 |
dhellmann | do you mean it doesn't need the API in oslo.context for fetching the current context? | 15:46 |
dhellmann | ah, I see, the context in _dispatch() is coming from the message | 15:48 |
dhellmann | that makes sense | 15:48 |
sileht | oslo.messaging doesn't really care about the context, the client send a dict, we serialize it, pass it throught the messaging broker, unserialize to a dict (or a helper method like nova does), and pass it the rpc endpoint AND make it availlable via localcontenxt.get_local_context | 15:48 |
*** inc0 has joined #openstack-oslo | 15:49 | |
dhellmann | sileht: on the receiving side, what turns that context dictionary into a context object that can be used by the application? | 15:50 |
dhellmann | or is it just passed to the application code as a dictionary? | 15:50 |
dhellmann | I see in _do_dispatch() something deserializes it and then the results are passed to the endpoint's method | 15:51 |
sileht | dhellmann, the one in localcontext is a dict and the one passed to the application endpoint is a dict by default, but the application can set a hook | 15:51 |
sileht | nova does this hook: https://github.com/openstack/nova/blob/master/nova/rpc.py#L117 | 15:51 |
dhellmann | ok, cool | 15:52 |
dhellmann | so oslo.messaging doesn't actually need to know about oslo.context, then | 15:52 |
sileht | nop | 15:52 |
dhellmann | cool. I don't think I would have done anything differently if I had known that earlier, but it's still good to know now. | 15:53 |
sileht | I wonder if we could just drop oslo.messaging localcontext (after deprecation ;) ) | 15:53 |
dhellmann | sileht: well, we still need it for inside oslo.messaging don't we? | 15:54 |
dhellmann | or do we always have an explicit reference to the context? | 15:54 |
sileht | dhellmann, oslo.messaging set this local store in case of someone else want to get the context, but olso.messaging itself doesn't need that | 15:56 |
dhellmann | sileht: ok, yes, we should get rid of that. oslo.context has that feature now | 15:57 |
sileht | dhellmann, so I can deprecated everything and tell developper to use oslo.context so ? | 15:57 |
dhellmann | sileht: yes | 15:58 |
sileht | cool | 15:58 |
dhellmann | sileht: harlowja_away is working on adding some nice developer-oriented deprecation tools to oslo.utils: https://review.openstack.org/140119 | 15:58 |
dhellmann | sileht: thanks for working through this with me; I have to step away for a bit, but I feel a lot better about my understanding of how the context works in oslo.messaging now. | 16:00 |
sileht | dhellmann, welcome | 16:02 |
*** inc0 has quit IRC | 16:04 | |
sileht | dhellmann, harlowja_away I wonder if we can complete the docstring with deprecated stuff for the sphinx documentation | 16:08 |
*** dtantsur is now known as dtantsur|brb | 16:10 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Deprecates this localcontext API https://review.openstack.org/140616 | 16:13 |
*** amrith is now known as _amrith_ | 16:13 | |
dhellmann | sileht: I'm not sure what you mean? | 16:16 |
*** rpodolyaka2 has joined #openstack-oslo | 16:17 | |
*** e0ne_ has joined #openstack-oslo | 16:18 | |
sileht | dhellmann, automatically adding text that says a method is deprecated in favor in something else in the dev documentation | 16:19 |
*** e0ne has quit IRC | 16:19 | |
*** rpodolyaka2 has quit IRC | 16:19 | |
dhellmann | sileht: oh, nice, I like that idea | 16:19 |
sileht | I don't know how works sphinx but perhaps it's doable | 16:20 |
dhellmann | sileht: I'll have to think about it. If the decorator adds information to the function, we should be able to get to it from sphinx. | 16:20 |
*** rpodolyaka2 has joined #openstack-oslo | 16:22 | |
flaper87 | dhellmann: the patch failed on py27 | 16:26 |
flaper87 | I think some mock needs to be updated | 16:26 |
dhellmann | flaper87: looking | 16:27 |
dhellmann | flaper87: can I run only some of the glance tests? I tried "tox -e py27 -- test_cache_middleware", but it seems to be running them all | 16:29 |
*** e0ne_ is now known as e0ne | 16:30 | |
*** dims has joined #openstack-oslo | 16:32 | |
*** sgotliv has quit IRC | 16:32 | |
flaper87 | dhellmann: I normally use nosetest for that :/ | 16:32 |
dhellmann | flaper87: ok, I'll try that | 16:32 |
dhellmann | I know we have oslo setup for that, so maybe I can make that patch for glance, too | 16:32 |
dhellmann | after lunch :-) | 16:32 |
*** _amrith_ is now known as amrith | 16:33 | |
flaper87 | there's run_tests as well but I don't like that script much | 16:33 |
flaper87 | :D | 16:33 |
*** jaosorior has quit IRC | 16:33 | |
openstackgerrit | Merged openstack/oslo-incubator: Delete graduated concurrency files https://review.openstack.org/122796 | 16:34 |
*** subscope has quit IRC | 16:35 | |
*** zzzeek has joined #openstack-oslo | 16:35 | |
*** dims has quit IRC | 16:36 | |
*** dims has joined #openstack-oslo | 16:36 | |
zzzeek | viktors: new version of the fix at https://review.openstack.org/#/c/139738/ | 16:40 |
*** vigneshvar has joined #openstack-oslo | 16:41 | |
viktors | zzzeek: hey! Just tested this on devstack | 16:42 |
zzzeek | im sure it did somethign different, whether or not it worked | 16:43 |
*** ihrachyshka_ has quit IRC | 16:44 | |
*** sgotliv has joined #openstack-oslo | 16:44 | |
*** tsekiyama has quit IRC | 16:44 | |
viktors | zzzeek: yes, I already tested with conn.execute("select 1") and it's works fine with your fix | 16:45 |
zzzeek | viktors: i moved the event handling right into the moment it connects inside the pool, there’s no way it can be missed :) | 16:45 |
zzzeek | viktors: it can just potentially break other crap if i missed anything. but it’s doing what 1.0 does | 16:46 |
*** zhiyan has quit IRC | 16:46 | |
*** jraim has quit IRC | 16:48 | |
viktors | zzzeek: hm.... There is seems to be something wrong - please look at http://paste.openstack.org/show/148787/ | 16:48 |
zzzeek | viktors: ah i know waht that is and i think that affects SQLA 1.0 also :) will fix | 16:50 |
*** subscope has joined #openstack-oslo | 16:51 | |
viktors | zzzeek: thanks a lot for your work on this :) | 16:51 |
zzzeek | ya | 16:51 |
*** zz_sabari is now known as sabari | 16:53 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 16:53 | |
zzzeek | viktors: this is great stuff | 16:53 |
openstackgerrit | Merged openstack/oslo.db: Fix TestConnectionUtils to py3x compatibility https://review.openstack.org/140291 | 16:54 |
openstackgerrit | Merged openstack/oslo.messaging: Warns user if thread monkeypatch is not done https://review.openstack.org/140610 | 16:54 |
openstackgerrit | Merged openstack/oslo.vmware: Add pbr to installation requirements https://review.openstack.org/130790 | 16:54 |
viktors | zzzeek: we supposed to retry db-api queries on disconnect, so DBConnectionError should indicate `db-gone-away` situation | 16:57 |
viktors | also sometimes I see patches like this - https://review.openstack.org/#/c/122114 | 16:57 |
*** amrith is now known as _amrith_ | 16:58 | |
*** viktors is now known as viktors|afk | 17:00 | |
*** amotoki has quit IRC | 17:02 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/139945 | 17:03 |
*** i159 has quit IRC | 17:05 | |
*** david-lyle_afk is now known as david-lyle | 17:06 | |
*** e0ne has quit IRC | 17:12 | |
*** k4n0 has quit IRC | 17:12 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Ensure DBConnectionError is raised on failed revalidate https://review.openstack.org/139738 | 17:20 |
zzzeek | viktors|afk: if you’re still there, try it again | 17:20 |
zzzeek | viktors|afk: fixed that | 17:20 |
*** zzzeek has quit IRC | 17:25 | |
*** zzzeek has joined #openstack-oslo | 17:25 | |
*** jaypipes has quit IRC | 17:26 | |
*** dtantsur|brb is now known as dtantsur | 17:27 | |
*** sabari is now known as zz_sabari | 17:30 | |
*** tedross has quit IRC | 17:35 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/140780 | 17:36 |
*** ihrachyshka has joined #openstack-oslo | 17:38 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 17:40 | |
*** jraim has joined #openstack-oslo | 17:41 | |
*** ihrachyshka has quit IRC | 17:42 | |
*** amotoki has joined #openstack-oslo | 17:49 | |
*** amotoki_ has joined #openstack-oslo | 17:50 | |
*** stevemar has quit IRC | 17:50 | |
*** andreykurilin_ has joined #openstack-oslo | 17:53 | |
*** amotoki_ has quit IRC | 17:54 | |
*** amotoki has quit IRC | 17:54 | |
*** tsekiyama has joined #openstack-oslo | 17:55 | |
*** tsekiyama has quit IRC | 18:00 | |
*** _amrith_ is now known as amrith | 18:03 | |
*** ViswaV has joined #openstack-oslo | 18:07 | |
*** zhiyan has joined #openstack-oslo | 18:09 | |
*** zz_sabari is now known as sabari | 18:18 | |
*** ViswaV has quit IRC | 18:19 | |
*** ViswaV has joined #openstack-oslo | 18:19 | |
*** e0ne has joined #openstack-oslo | 18:25 | |
*** sabari is now known as zz_sabari | 18:25 | |
*** ViswaV has quit IRC | 18:26 | |
*** ViswaV has joined #openstack-oslo | 18:26 | |
*** harlowja_away is now known as harlowja | 18:31 | |
harlowja | sileht dhellmann hmmm, sphinx documentation plugin somehow, likely possible, i think dhellmann is more of the expert on that stuff than me :) | 18:33 |
*** pradk has joined #openstack-oslo | 18:36 | |
harlowja | *more of an expert on sphinx that is | 18:39 |
harlowja | sileht check out https://review.openstack.org/#/c/140119/ ; that can be the start of useful patterns for folks | 18:40 |
harlowja | the tests included in that have some examples of how to use it.. | 18:41 |
harlowja | hopefully useful for some folks | 18:45 |
*** pblaho has quit IRC | 18:45 | |
harlowja | zzzeek u might be a useful reviewer of that also ;0 | 18:45 |
harlowja | ;) | 18:45 |
*** rpodolyaka2 has quit IRC | 18:50 | |
*** viktors1 has joined #openstack-oslo | 18:52 | |
*** rpodolyaka2 has joined #openstack-oslo | 18:52 | |
viktors1 | harlowja: hi! | 18:53 |
harlowja | viktors1 yo yo | 18:53 |
viktors1 | harlowja: do you plan to maintain patch https://review.openstack.org/#/c/120198/ ? It should make py3 tests green =) | 18:54 |
harlowja | sure i can update | 18:54 |
viktors1 | thanks! | 18:55 |
harlowja | np | 18:55 |
*** viktors1 has quit IRC | 18:57 | |
jogo | dims: https://bugs.launchpad.net/neutron/+bug/1399788 | 18:57 |
dims | jogo: back to back stuff today, subscribed to it | 19:01 |
jogo | dims: thanks, it looks like it *may* be an oslo-incubator related issue but not sure | 19:02 |
dims | jogo: ack | 19:03 |
harlowja | dhellmann do u have any time to look over https://review.openstack.org/#/c/135146/ again (this time with super-docs) | 19:04 |
*** gordc has quit IRC | 19:06 | |
*** jaypipes has joined #openstack-oslo | 19:07 | |
*** zz_sabari is now known as sabari | 19:07 | |
dhellmann | harlowja: I'll put it on my list for today or tomorrow | 19:07 |
harlowja | thx | 19:07 |
*** sabari is now known as zz_sabari | 19:09 | |
*** andreykurilin_ has quit IRC | 19:09 | |
*** tsekiyama has joined #openstack-oslo | 19:11 | |
*** zz_sabari is now known as sabari | 19:12 | |
*** gordc has joined #openstack-oslo | 19:13 | |
jogo | jd__: making sure you know you are hacking core (now that oslo-core is removed) https://review.openstack.org/#/admin/groups/153,members | 19:16 |
harlowja | dhellmann dims jd__ and any others http://lists.openstack.org/pipermail/openstack-dev/2014-December/052688.html | 19:17 |
harlowja | if that date not good, let me know, or respond and can adjust... | 19:17 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.db: Fix more invalid encoding and scoping issues https://review.openstack.org/120198 | 19:20 |
harlowja | viktors|afk updated, but i'm still getting stuff like http://paste.ubuntu.com/9466228/ in 3.4 | 19:21 |
harlowja | thats using | 19:22 |
harlowja | SQLAlchemy==0.9.8 | 19:22 |
harlowja | sqlalchemy-migrate==0.9.1 | 19:22 |
palendae | dhellmann: Seeing as you're getting into the cmd2 maintenance and I only see neutronclient using cliff, is it worth the effort still to investigate removing the cmd2 dependency from cliff? | 19:23 |
dhellmann | palendae: python-openstackclient also uses cliff -- that's actually why I wrote cliff to begin with | 19:25 |
palendae | Ah, ok, missed that one | 19:25 |
palendae | I was looking at each service | 19:25 |
dhellmann | palendae: the neutron team created their client with the idea that the plugins would be compatible with the unified client, but I think we reimplemented the commands to make them consistent with the design of the other commands there | 19:25 |
dhellmann | palendae: https://github.com/dhellmann/aeromancer | 19:26 |
dhellmann | (skunkworks project) | 19:26 |
harlowja | not so skunkworks anymore, muhahaha | 19:26 |
harlowja | lol | 19:26 |
palendae | All the readme links 404, fyi :) | 19:26 |
dhellmann | heh, the readme is empty -- if you install that and run it against a copy of all of the openstack code, you can ask it questions about openstack projects | 19:26 |
palendae | Cool | 19:26 |
palendae | That's....a lot of code | 19:27 |
dhellmann | yeah, those will work when I make it a real stackforge project | 19:27 |
dhellmann | yeah, I'm using it as an excuse to relearn a alembic and sqlalchemy | 19:27 |
palendae | Fair enough | 19:27 |
palendae | I should do something like that too, lots of time buried in Ansible lately | 19:27 |
dhellmann | although I've been tempted to throw that out and use elasticsearch instead | 19:27 |
jd__ | jogo: yes I added mysefl | 19:31 |
jd__ | jogo: I didn't bother to ask sorry :) | 19:31 |
jogo | jd__: ahhh that is fine, but a heads up would have been appreciated | 19:31 |
jogo | jd__: glad to have more people on the team | 19:32 |
jd__ | my bad :) | 19:32 |
dims | harlowja: lgtm (17th) | 19:35 |
*** sabari is now known as zz_sabari | 19:39 | |
*** dtantsur is now known as dtantsur|afk | 19:40 | |
harlowja | dims cools | 19:41 |
*** zz_sabari is now known as sabari | 19:44 | |
*** ViswaV has quit IRC | 19:54 | |
dhellmann | flaper87: I can't make that test fail locally, so I'm going to recheck the patch. | 19:54 |
*** sabari is now known as zz_sabari | 19:57 | |
*** zz_sabari is now known as sabari | 19:57 | |
*** sgotliv has quit IRC | 20:00 | |
*** dims has quit IRC | 20:02 | |
*** kgiusti has quit IRC | 20:04 | |
*** kgiusti has joined #openstack-oslo | 20:06 | |
dhellmann | flaper87: failed again :-/ | 20:08 |
harlowja | dhellmann sileht https://github.com/twisted/twisted/blob/trunk/twisted/python/deprecate.py is also similar to the code in that review (or at least has somewhat similar capabilities); useful to see other projects deprecation patterns... | 20:10 |
harlowja | i believe https://github.com/twisted/twisted/blob/trunk/twisted/python/deprecate.py#L119 is simlar to the docstring modification... | 20:10 |
harlowja | that and https://github.com/twisted/twisted/blob/trunk/twisted/python/deprecate.py#L213 | 20:10 |
dhellmann | harlowja: did you happen to look on pypi for a library that does this sort of thing? | 20:11 |
harlowja | i think i did, from what i remember | 20:11 |
harlowja | don't think i found much of anything | 20:11 |
dhellmann | it's hard to search for "deprecate"; lots of hits for actual deprecated modules | 20:11 |
harlowja | ya, i think i remember looking for deprecation utils or something, pretty sure i tried to find something, lol | 20:11 |
harlowja | some other guy in my team i think also looked | 20:12 |
dhellmann | yeah, just seeing 2 modules doing this work made me think maybe it's worth having it stand on its own | 20:12 |
harlowja | agreed | 20:12 |
harlowja | its confusing also to me why python doesn't provide such patterns somewhere | 20:12 |
dhellmann | there's nothing really "oslo-y" about that implementation, right? | 20:12 |
harlowja | nopers | 20:12 |
harlowja | u can make up a snappy name for it :-P | 20:13 |
harlowja | i'm not so good at names, lol | 20:13 |
harlowja | https://pypi.python.org/pypi/zope.deprecation is close, but u know zope | 20:13 |
dhellmann | how about baggage, as in "we're carrying this code as baggage" | 20:13 |
harlowja | i guess oslo.utils isn't much better, ha | 20:13 |
dhellmann | harlowja: yeah, we chose that on purpose to scare away outside users :-) | 20:14 |
harlowja | ;) | 20:14 |
harlowja | i bet the zope people did the same, lol | 20:14 |
dhellmann | I think at the time the namespacing was considered a feature | 20:14 |
harlowja | hmmm, https://pypi.python.org/pypi/baggage doesn't exist +1 | 20:14 |
flaper87 | dhellmann: I'll take a look | 20:14 |
dhellmann | flaper87: it's not obvious that the test in question is mocking anything | 20:15 |
dhellmann | well, not anything related to the code I'm actually changing -- a couple of import statements | 20:15 |
dhellmann | harlowja, ironically "deprecate" is available on pypi so you could just use that :-) | 20:16 |
harlowja | lo | 20:16 |
harlowja | lol | 20:16 |
*** sabari is now known as zz_sabari | 20:16 | |
dhellmann | harlowja: we could make this a new oslo lib, but release it outside of utils if you want | 20:16 |
harlowja | hmmm, baggage or deprecate, hmmm | 20:16 |
harlowja | dhellmann sure, i'm ok with that | 20:17 |
dhellmann | harlowja: or how about "debtcollector" | 20:17 |
harlowja | lol | 20:17 |
harlowja | to many options :-P | 20:17 |
dhellmann | repoman is taken | 20:17 |
harlowja | https://pypi.python.org/pypi/deprecation is also free, weird | 20:17 |
harlowja | nobody deprecates stuff i guess | 20:18 |
harlowja | lol | 20:18 |
dhellmann | ooh, bagman isn't taken | 20:18 |
dhellmann | meh, debtcollector seems better | 20:18 |
harlowja | hmmm, i'm fine with whatever u guys want | 20:18 |
harlowja | :-P | 20:18 |
dhellmann | how about a ML thread? I think we have a bunch of cores offline for travel or at sprints or things, so I'm not sure we're going to get consensus here in the chat room today | 20:19 |
harlowja | agreed, and that durn xmas | 20:19 |
harlowja | will send | 20:19 |
dhellmann | coming up fast | 20:19 |
harlowja | alright, sendin ML out | 20:20 |
dhellmann | harlowja: cool, thanks | 20:21 |
harlowja | sent @ http://lists.openstack.org/pipermail/openstack-dev/2014-December/052692.html | 20:27 |
jamespage | dhellmann, sileht: hey | 20:29 |
jamespage | would you guys have time to re-review https://review.openstack.org/#/c/128233/ - getting alot of left-a-bit right-a-bit now | 20:29 |
*** rpodolyaka2 has quit IRC | 20:32 | |
dhellmann | jamespage: looking | 20:35 |
openstackgerrit | Rodrigo Duarte proposed openstack/oslo-specs: Graduate Policy https://review.openstack.org/140161 | 20:36 |
jamespage | dhellmann, ta | 20:36 |
dhellmann | jamespage: regarding the log.error vs log.exception call in impl_zmq.py line 628 -- is mm.unregister() calling out to some other library, or is that more of our code? | 20:38 |
dhellmann | it doesn't seem like a traceback is going to be useful there | 20:38 |
jogo | possible oslo.messaging bug https://bugs.launchpad.net/oslo.messaging/+bug/1393182 | 20:40 |
harlowja | dhellmann another possibility of a new oslo library is that automaton stuff | 20:41 |
dhellmann | harlowja: yep | 20:41 |
dhellmann | harlowja: one at a time, though :-) | 20:41 |
harlowja | basically to avoid https://review.openstack.org/#/c/139215/ from diverging to much ... | 20:41 |
dhellmann | jamespage: +2 with comments | 20:42 |
dhellmann | jogo: looking | 20:42 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Add a thread + futures executor based executor https://review.openstack.org/70914 | 20:42 |
jogo | dhellmann: thanks | 20:43 |
dhellmann | jogo: I'm not sure why you think that's a messaging bug? It looks like the driver is having trouble connecting to rabbit there | 20:43 |
dhellmann | we might need sileht to take a look, though, I'm far from an expert at the messaging stuff | 20:44 |
dhellmann | jogo: "error: [Errno 104] Connection reset by peer" | 20:44 |
*** ViswaV has joined #openstack-oslo | 20:44 | |
jogo | dhellmann: it may not be | 20:44 |
jogo | but thought it would be good to rule it out as a possibility | 20:45 |
jogo | hmm I should be able to reproduce this easily actually | 20:45 |
*** rpodolyaka2 has joined #openstack-oslo | 20:47 | |
dhellmann | harlowja: if your oslo.utils requirements bump doesn't get another +2a after the tests pass let me know and I'll re-approve -- it was just rebased, right? | 20:48 |
dhellmann | jogo: ok, thanks | 20:48 |
harlowja | dhellmann ya, someone modified oslo.vmware or something | 20:48 |
dhellmann | harlowja: weird that gerrit/zuul/whatever couldn't resolve that conflict | 20:49 |
harlowja | i'm gonna say its linus fault | 20:49 |
harlowja | lol | 20:49 |
dhellmann | heh | 20:50 |
*** dims has joined #openstack-oslo | 21:03 | |
*** amrith is now known as _amrith_ | 21:06 | |
*** dims has quit IRC | 21:08 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a helper callback class triggered on task events https://review.openstack.org/140838 | 21:13 |
*** zz_sabari is now known as sabari | 21:13 | |
*** dims has joined #openstack-oslo | 21:17 | |
openstackgerrit | Rodrigo Duarte proposed openstack/oslo-specs: Graduate Policy https://review.openstack.org/140161 | 21:18 |
*** kgiusti has quit IRC | 21:23 | |
*** denis_makogon_ has joined #openstack-oslo | 21:26 | |
*** tedross has joined #openstack-oslo | 21:27 | |
*** denis_makogon has quit IRC | 21:31 | |
*** denis_makogon_ is now known as denis_makogon | 21:31 | |
*** dmakogon_ has joined #openstack-oslo | 21:32 | |
*** jecarey has quit IRC | 21:38 | |
*** rpodolyaka2 has quit IRC | 21:53 | |
*** sabari is now known as zz_sabari | 21:54 | |
*** zz_sabari is now known as sabari | 21:55 | |
openstackgerrit | Merged openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/139945 | 21:57 |
*** ViswaV has quit IRC | 22:01 | |
*** sabari is now known as zz_sabari | 22:07 | |
*** tedross has quit IRC | 22:08 | |
*** zz_sabari is now known as sabari | 22:10 | |
harlowja | dhellmann i'll write up that spec, maybe later this week for the deprecation thing, will see if anyone really objects to that on ML first | 22:10 |
harlowja | or should i wait longer ? | 22:11 |
*** _amrith_ is now known as amrith | 22:17 | |
*** jeckersb is now known as jeckersb_gone | 22:21 | |
*** andreykurilin_ has joined #openstack-oslo | 22:25 | |
openstackgerrit | gordon chung proposed openstack/oslo.messaging: Implements notification-dispatcher-filter https://review.openstack.org/77886 | 22:28 |
openstackgerrit | gordon chung proposed openstack/oslo.messaging: Implements notification-dispatcher-filter https://review.openstack.org/77886 | 22:32 |
*** mriedem has left #openstack-oslo | 22:44 | |
*** ViswaV has joined #openstack-oslo | 22:47 | |
*** vigneshvar has quit IRC | 22:59 | |
dhellmann | harlowja: whenever you're ready | 23:07 |
harlowja | k | 23:07 |
dhellmann | harlowja: benemec is out this week, but I don't imagine he'll object. if he does, he can comment on the spec | 23:07 |
harlowja | kk | 23:07 |
dhellmann | look at the graduation template, that's probably closest to what you want | 23:08 |
harlowja | sures | 23:08 |
harlowja | thx | 23:08 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 23:22 |
*** gordc has quit IRC | 23:23 | |
*** raildo_ has joined #openstack-oslo | 23:24 | |
*** pradk has quit IRC | 23:29 | |
*** jeckersb_gone is now known as jeckersb | 23:31 | |
*** ViswaV has quit IRC | 23:32 | |
*** sabari is now known as zz_sabari | 23:51 | |
*** zz_sabari is now known as sabari | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!