| *** noelbk has quit IRC | 00:02 | |
| *** zz_zz_zz_sabari is now known as sabari | 00:06 | |
| gus | Dear oslo.i18n folks: you may be interested in https://review.openstack.org/141945 (I wrote a custom pylint check that enforces many of the oslo.i18n guiidelines) | 00:06 |
|---|---|---|
| *** JayF has left #openstack-oslo | 00:07 | |
| *** raildo has joined #openstack-oslo | 00:11 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add an example which shows how to send events out from tasks https://review.openstack.org/141951 | 00:19 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add an example which shows how to send events out from tasks https://review.openstack.org/141951 | 00:21 |
| *** takedakn has joined #openstack-oslo | 00:25 | |
| *** sabari is now known as zz_sabari | 00:27 | |
| *** mtanino has quit IRC | 00:27 | |
| dhellmann | gus: would it make sense to put that in oslo.i18n so projects can use it optionally if they want to enable it? | 00:29 |
| gus | dhellmann: yes, but there isn't any pylint infrastructure in oslo afaik. | 00:31 |
| gus | dhellmann: and realistically it's going to hit the same roadblock as my earlier context-manager pylint test anyway: pylint is gpl, importing gpl makes people fearful and uncertain. | 00:32 |
| gus | dhellmann: I'd be happy to propose a change to add it to oslo.i18n if you think you would approve such a thing. | 00:34 |
| gus | (the unittest would mean adding pylint to test-requirements.txt, or creating a new tox env with pylint available) | 00:35 |
| *** david-lyle is now known as david-lyle_afk | 00:35 | |
| *** dims has joined #openstack-oslo | 00:38 | |
| *** raildo has quit IRC | 00:39 | |
| *** oomichi has joined #openstack-oslo | 00:41 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a 'can_be_notified' method that checks before notifying https://review.openstack.org/141955 | 00:43 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a 'can_be_notified' method that checks before notifying https://review.openstack.org/141955 | 00:44 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a 'can_be_notified' method that checks before notifying https://review.openstack.org/141955 | 00:45 |
| *** noelbk has joined #openstack-oslo | 00:46 | |
| harlowja | dhellmann https://review.openstack.org/#/c/139215/ sooo; thats going in, might have to get that automaton library on stackforge soon; guess i should make another adopt-create doc, lol | 00:49 |
| *** raildo has joined #openstack-oslo | 00:51 | |
| *** raildo has quit IRC | 00:51 | |
| *** takedakn has quit IRC | 00:55 | |
| *** alexpilotti has joined #openstack-oslo | 00:58 | |
| *** mtanino has joined #openstack-oslo | 01:06 | |
| *** tsekiyama has joined #openstack-oslo | 01:10 | |
| *** tsekiyama has quit IRC | 01:14 | |
| *** noelbk has quit IRC | 01:25 | |
| *** prad has quit IRC | 01:33 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: config: Add a spec for a oslo.config proxy config opts https://review.openstack.org/130047 | 01:35 |
| *** alexpilotti has quit IRC | 01:47 | |
| *** mtanino has quit IRC | 02:05 | |
| *** dims has quit IRC | 02:06 | |
| *** dims has joined #openstack-oslo | 02:06 | |
| *** dims has quit IRC | 02:11 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption (WIP) https://review.openstack.org/141961 | 02:13 |
| *** oomichi has quit IRC | 02:16 | |
| openstackgerrit | Merged openstack/oslo.config: Move files out of the namespace package https://review.openstack.org/139735 | 02:18 |
| openstackgerrit | Merged openstack/oslo.db: Fix the link to the bug reporting site https://review.openstack.org/141842 | 02:18 |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption (WIP) https://review.openstack.org/141961 | 02:20 |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption (WIP) https://review.openstack.org/141961 | 02:27 |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption (WIP) https://review.openstack.org/141961 | 02:31 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 02:32 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption (WIP) https://review.openstack.org/141961 | 02:32 |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption (WIP) https://review.openstack.org/141961 | 02:42 |
| *** jaypipes has joined #openstack-oslo | 02:50 | |
| *** mriedem has quit IRC | 02:51 | |
| *** jaosorior has joined #openstack-oslo | 02:52 | |
| *** dims has joined #openstack-oslo | 02:59 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a 'can_be_notified' method that checks before notifying https://review.openstack.org/141955 | 03:18 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a 'can_be_registered' method that checks before notifying https://review.openstack.org/141955 | 03:19 |
| *** zzzeek has quit IRC | 03:31 | |
| *** boris-42 has quit IRC | 03:33 | |
| *** zz_sabari is now known as sabari | 03:46 | |
| *** dims has quit IRC | 03:49 | |
| *** oomichi has joined #openstack-oslo | 03:53 | |
| *** oomichi has quit IRC | 03:54 | |
| *** liusheng has quit IRC | 04:00 | |
| *** liusheng has joined #openstack-oslo | 04:01 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-incubator: Replace the 'release_notes' shell script with a python variant https://review.openstack.org/141939 | 04:12 |
| *** zzzeek has joined #openstack-oslo | 04:24 | |
| *** sabari is now known as zz_sabari | 04:29 | |
| *** jecarey has joined #openstack-oslo | 04:30 | |
| *** zzzeek has quit IRC | 04:30 | |
| *** lbragstad has quit IRC | 04:35 | |
| *** vishy has quit IRC | 04:35 | |
| *** jraim_ has quit IRC | 04:36 | |
| *** sileht has quit IRC | 04:36 | |
| *** gus has quit IRC | 04:36 | |
| *** lbragstad has joined #openstack-oslo | 04:38 | |
| *** jraim has joined #openstack-oslo | 04:38 | |
| *** gus has joined #openstack-oslo | 04:39 | |
| *** vishy has joined #openstack-oslo | 04:39 | |
| *** sileht has joined #openstack-oslo | 04:40 | |
| *** takedakn has joined #openstack-oslo | 04:50 | |
| *** takedakn has quit IRC | 04:55 | |
| *** takedakn has joined #openstack-oslo | 04:56 | |
| *** takedakn has quit IRC | 05:00 | |
| *** achanda has joined #openstack-oslo | 05:02 | |
| *** oomichi has joined #openstack-oslo | 05:38 | |
| *** harlowja is now known as harlowja_away | 05:42 | |
| *** noelbk has joined #openstack-oslo | 05:43 | |
| *** rpodolyaka2 has joined #openstack-oslo | 05:51 | |
| *** achanda has quit IRC | 05:53 | |
| *** boris-42 has joined #openstack-oslo | 05:59 | |
| *** rpodolyaka2 has quit IRC | 05:59 | |
| *** rpodolyaka2 has joined #openstack-oslo | 06:00 | |
| *** oomichi has quit IRC | 06:02 | |
| *** jaosorior has quit IRC | 06:03 | |
| *** achanda has joined #openstack-oslo | 06:03 | |
| *** noelbk has quit IRC | 06:06 | |
| *** vigneshvar has joined #openstack-oslo | 06:12 | |
| *** gcb has joined #openstack-oslo | 06:25 | |
| *** vigneshvar has quit IRC | 06:28 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption https://review.openstack.org/141961 | 06:30 |
| *** takedakn has joined #openstack-oslo | 06:37 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module https://review.openstack.org/103245 | 06:41 |
| *** takedakn has quit IRC | 06:42 | |
| *** takedakn has joined #openstack-oslo | 06:42 | |
| *** jecarey has quit IRC | 06:45 | |
| *** stevemar has quit IRC | 06:46 | |
| *** zz_sabari is now known as sabari | 06:48 | |
| *** vigneshvar has joined #openstack-oslo | 06:54 | |
| *** rpodolyaka2 has quit IRC | 06:54 | |
| *** takedakn has quit IRC | 06:56 | |
| *** takedakn has joined #openstack-oslo | 06:56 | |
| *** rpodolyaka2 has joined #openstack-oslo | 07:00 | |
| *** gcb has quit IRC | 07:00 | |
| *** gcb has joined #openstack-oslo | 07:00 | |
| *** takedakn has quit IRC | 07:01 | |
| *** achanda has quit IRC | 07:10 | |
| *** achanda has joined #openstack-oslo | 07:11 | |
| *** achanda has quit IRC | 07:16 | |
| *** pcaruana has joined #openstack-oslo | 07:19 | |
| *** e0ne has joined #openstack-oslo | 07:26 | |
| *** achanda has joined #openstack-oslo | 07:34 | |
| *** rpodolyaka2 has quit IRC | 07:43 | |
| *** e0ne has quit IRC | 07:51 | |
| *** liusheng has quit IRC | 07:51 | |
| *** liusheng has joined #openstack-oslo | 07:52 | |
| *** achanda has quit IRC | 08:08 | |
| *** achanda has joined #openstack-oslo | 08:15 | |
| *** rushiagr_away is now known as rushiagr | 08:21 | |
| *** xek has joined #openstack-oslo | 08:22 | |
| *** ajo has joined #openstack-oslo | 08:23 | |
| *** xek has quit IRC | 08:26 | |
| *** Krast has joined #openstack-oslo | 08:42 | |
| *** k4n0 has joined #openstack-oslo | 08:47 | |
| *** liusheng has quit IRC | 08:48 | |
| *** liusheng has joined #openstack-oslo | 08:49 | |
| *** sabari is now known as zz_sabari | 09:07 | |
| *** stannie has joined #openstack-oslo | 09:18 | |
| *** achanda has quit IRC | 09:32 | |
| *** achanda has joined #openstack-oslo | 09:32 | |
| *** dtantsur|afk is now known as dtantsur | 09:33 | |
| *** achanda has quit IRC | 09:37 | |
| *** achanda has joined #openstack-oslo | 09:41 | |
| *** achanda has quit IRC | 09:44 | |
| *** mtanino has joined #openstack-oslo | 09:44 | |
| *** achanda has joined #openstack-oslo | 09:44 | |
| *** achanda has quit IRC | 09:50 | |
| *** achanda has joined #openstack-oslo | 09:50 | |
| *** mtanino is now known as mtanino_zzz | 09:54 | |
| *** e0ne has joined #openstack-oslo | 09:55 | |
| *** ihrachyshka has joined #openstack-oslo | 10:04 | |
| *** ekarlso- has quit IRC | 10:07 | |
| *** ekarlso- has joined #openstack-oslo | 10:07 | |
| *** mfedosin has quit IRC | 10:17 | |
| *** e0ne has quit IRC | 10:34 | |
| *** e0ne has joined #openstack-oslo | 10:38 | |
| *** achanda has quit IRC | 10:40 | |
| *** dulek has joined #openstack-oslo | 10:43 | |
| *** liusheng has quit IRC | 10:44 | |
| *** liusheng has joined #openstack-oslo | 10:45 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo-specs: oslo.messaging examples proposal https://review.openstack.org/140318 | 11:04 |
| *** e0ne has quit IRC | 11:09 | |
| *** e0ne has joined #openstack-oslo | 11:24 | |
| dhellmann | harlowja_away: maybe you can work with them to extract some of that stuff back into a library? | 11:38 |
| dhellmann | gus: ah, I always forget about the gpl issue. Maybe you should just start a new project to hold the code? | 11:39 |
| *** dulek has quit IRC | 11:46 | |
| *** gcb has quit IRC | 11:48 | |
| *** dims has joined #openstack-oslo | 12:07 | |
| *** jraim_ has joined #openstack-oslo | 12:12 | |
| *** dougwig_ has joined #openstack-oslo | 12:12 | |
| *** ihrachyshka has quit IRC | 12:12 | |
| *** gcb has joined #openstack-oslo | 12:14 | |
| *** jraim has quit IRC | 12:14 | |
| *** jraim_ is now known as jraim | 12:14 | |
| *** dougwig has quit IRC | 12:14 | |
| *** sileht has quit IRC | 12:14 | |
| *** dougwig_ is now known as dougwig | 12:14 | |
| *** sileht has joined #openstack-oslo | 12:16 | |
| *** ihrachyshka has joined #openstack-oslo | 12:19 | |
| *** tsufiev has quit IRC | 12:20 | |
| *** e0ne has quit IRC | 12:23 | |
| *** mtanino_zzz has quit IRC | 12:26 | |
| *** tsufiev has joined #openstack-oslo | 12:26 | |
| *** amotoki has joined #openstack-oslo | 12:26 | |
| *** ujjain has quit IRC | 12:31 | |
| *** ujjain has joined #openstack-oslo | 12:33 | |
| *** stannie has quit IRC | 12:34 | |
| *** tedross has joined #openstack-oslo | 12:57 | |
| *** alexpilotti has joined #openstack-oslo | 13:02 | |
| *** alexpilotti_ has joined #openstack-oslo | 13:06 | |
| *** mtanino has joined #openstack-oslo | 13:07 | |
| *** dims has quit IRC | 13:07 | |
| *** alexpilotti has quit IRC | 13:07 | |
| *** alexpilotti_ is now known as alexpilotti | 13:07 | |
| *** dims has joined #openstack-oslo | 13:07 | |
| *** dulek has joined #openstack-oslo | 13:07 | |
| *** e0ne has joined #openstack-oslo | 13:09 | |
| *** kgiusti has joined #openstack-oslo | 13:12 | |
| *** Guest53822 has joined #openstack-oslo | 13:12 | |
| *** Guest53822 has quit IRC | 13:14 | |
| *** BrianShang has joined #openstack-oslo | 13:16 | |
| *** BrianShang has left #openstack-oslo | 13:17 | |
| *** salv-orlando has joined #openstack-oslo | 13:20 | |
| *** jeckersb_gone is now known as jeckersb | 13:20 | |
| *** e0ne is now known as e0ne_ | 13:25 | |
| *** lifeless_ has joined #openstack-oslo | 13:33 | |
| *** kobis1 has joined #openstack-oslo | 13:34 | |
| *** kobis1 has left #openstack-oslo | 13:35 | |
| *** lifeless has quit IRC | 13:35 | |
| *** dtantsur is now known as dtantsur|brb | 13:35 | |
| *** e0ne_ has quit IRC | 13:35 | |
| *** vigneshvar has quit IRC | 13:42 | |
| *** gordc has joined #openstack-oslo | 13:42 | |
| *** e0ne has joined #openstack-oslo | 13:48 | |
| *** mtanino has quit IRC | 13:56 | |
| *** mfedosin has joined #openstack-oslo | 14:14 | |
| *** ajo_ has joined #openstack-oslo | 14:21 | |
| *** amrith is now known as _amrith_ | 14:22 | |
| *** mtreinish_ has joined #openstack-oslo | 14:22 | |
| *** mriedem has joined #openstack-oslo | 14:27 | |
| *** HenryG_ has joined #openstack-oslo | 14:28 | |
| *** k4n0 has quit IRC | 14:30 | |
| *** ajo has quit IRC | 14:30 | |
| *** HenryG has quit IRC | 14:30 | |
| *** mtreinish has quit IRC | 14:30 | |
| *** mtreinish_ is now known as mtreinish | 14:30 | |
| *** k4n0 has joined #openstack-oslo | 14:31 | |
| *** tedross has quit IRC | 14:39 | |
| *** tedross has joined #openstack-oslo | 14:40 | |
| *** e0ne is now known as e0ne_ | 14:43 | |
| *** e0ne_ is now known as e0ne | 14:47 | |
| *** dtantsur|brb is now known as dtantsur | 14:50 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:02 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 15:05 | |
| *** zzzeek has joined #openstack-oslo | 15:05 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:06 | |
| *** jecarey has joined #openstack-oslo | 15:17 | |
| *** flaper87 has quit IRC | 15:18 | |
| *** flaper87 has joined #openstack-oslo | 15:18 | |
| *** zzzeek_ has joined #openstack-oslo | 15:20 | |
| *** zzzeek has quit IRC | 15:23 | |
| *** zzzeek_ is now known as zzzeek | 15:23 | |
| *** stevemar has joined #openstack-oslo | 15:24 | |
| *** mriedem has quit IRC | 15:25 | |
| *** mriedem has joined #openstack-oslo | 15:25 | |
| *** HenryG_ has quit IRC | 15:25 | |
| *** HenryG_ has joined #openstack-oslo | 15:25 | |
| *** k4n0 has quit IRC | 15:25 | |
| *** k4n0 has joined #openstack-oslo | 15:25 | |
| *** tedross has quit IRC | 15:25 | |
| *** tedross has joined #openstack-oslo | 15:25 | |
| *** jecarey has quit IRC | 15:26 | |
| *** jecarey has joined #openstack-oslo | 15:26 | |
| *** _amrith_ is now known as amrith | 15:34 | |
| *** dulek has quit IRC | 15:40 | |
| *** pcaruana has quit IRC | 15:42 | |
| bnemec | dhellmann: Just a heads up that https://review.openstack.org/#/c/140143/ needs a rebase because the namespace change merged. | 15:52 |
| dhellmann | bnemec: thanks; I'm fighting with the oslo.db thing for now but when I finish that I'll come back to those other patches | 15:53 |
| bnemec | Sounds good | 15:54 |
| *** achanda has joined #openstack-oslo | 15:57 | |
| clif_h | dhellmann: this bug that I found in ironicclient seems to be originating from openstack.common.apiclient.exceptions | 16:05 |
| *** achanda has quit IRC | 16:05 | |
| clif_h | should I associate with oslo as well? | 16:05 |
| clif_h | https://bugs.launchpad.net/python-ironicclient/+bug/1402840 | 16:08 |
| *** achanda has joined #openstack-oslo | 16:15 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: safe_log Sanitize Passwords in List of Dicts https://review.openstack.org/123759 | 16:17 |
| *** rushiagr is now known as rushiagr_away | 16:18 | |
| *** ihrachyshka has quit IRC | 16:20 | |
| openstackgerrit | Dave Walker proposed openstack-dev/pbr: Ignore non-release related tags https://review.openstack.org/142144 | 16:23 |
| *** kragniz is now known as kragwhale | 16:26 | |
| bnemec | clif_h: Yes. I went ahead and added the appropriate project. | 16:33 |
| clif_h | bnemec: thank you! | 16:33 |
| bnemec | np | 16:33 |
| *** noelbk has joined #openstack-oslo | 16:43 | |
| *** david-lyle_afk is now known as david-lyle | 16:44 | |
| *** jaosorior has joined #openstack-oslo | 16:44 | |
| *** vigneshvar has joined #openstack-oslo | 16:51 | |
| *** e0ne is now known as e0ne_ | 16:53 | |
| *** e0ne_ is now known as e0ne | 16:53 | |
| *** alexpilotti has quit IRC | 16:55 | |
| *** dtantsur is now known as dtantsur|afk | 16:59 | |
| *** rushiagr_away is now known as rushiagr | 17:05 | |
| jecarey | jogo, I had to do some redesign for the optional hacking checks, but I think I've got something ready for you to review (https://review.openstack.org/#/c/134052/) when you get a chance. | 17:11 |
| *** vigneshvar has quit IRC | 17:14 | |
| *** mtanino has joined #openstack-oslo | 17:18 | |
| *** achanda has quit IRC | 17:21 | |
| *** dims has quit IRC | 17:23 | |
| *** dims has joined #openstack-oslo | 17:23 | |
| *** achanda_ has joined #openstack-oslo | 17:24 | |
| *** alexpilotti has joined #openstack-oslo | 17:27 | |
| *** dims_ has joined #openstack-oslo | 17:28 | |
| *** achanda_ has quit IRC | 17:28 | |
| *** dims has quit IRC | 17:28 | |
| *** achanda has joined #openstack-oslo | 17:29 | |
| *** tsekiyama has joined #openstack-oslo | 17:30 | |
| *** ihrachyshka has joined #openstack-oslo | 17:30 | |
| *** achanda has quit IRC | 17:33 | |
| *** vigneshvar has joined #openstack-oslo | 17:33 | |
| *** kragwhale is now known as kragniz | 17:43 | |
| *** e0ne has quit IRC | 17:50 | |
| *** achanda has joined #openstack-oslo | 17:56 | |
| *** k4n0 has quit IRC | 18:06 | |
| *** achanda has quit IRC | 18:12 | |
| *** harlowja_away is now known as harlowja | 18:12 | |
| harlowja | dhellmann ya, as for oslo.messaging examples; i'm fine with working with thems :) | 18:13 |
| *** achanda has joined #openstack-oslo | 18:13 | |
| *** achanda has quit IRC | 18:14 | |
| *** achanda has joined #openstack-oslo | 18:14 | |
| *** rpodolyaka2 has joined #openstack-oslo | 18:24 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo-specs: Add automaton adoption https://review.openstack.org/141961 | 18:27 |
| SlickNik | dhellmann: Had a question regarding http://docs.openstack.org/developer/oslo.i18n/usage.html | 18:29 |
| SlickNik | dhellmann: basically common code for trove services is under trove/common | 18:30 |
| SlickNik | and since i18n is used across services, I'd like keep the adapter under common. | 18:31 |
| dhellmann | SlickNik: that's fine, the docs are just an example | 18:31 |
| dhellmann | SlickNik: the point is you should *not* use the one in trove/openstack/common | 18:31 |
| SlickNik | dhellmann: That's what I thought. Just wanted to check with you in case there was something I'm missing. | 18:32 |
| SlickNik | dhellmann: Thanks! | 18:32 |
| dhellmann | SlickNik: np | 18:32 |
| *** noelbk has quit IRC | 18:35 | |
| *** HenryG_ has quit IRC | 18:48 | |
| *** HenryG has joined #openstack-oslo | 18:49 | |
| *** noelbk has joined #openstack-oslo | 18:52 | |
| *** vigneshvar has quit IRC | 18:55 | |
| *** rpodolyaka2 has quit IRC | 18:55 | |
| *** noelbk has quit IRC | 19:03 | |
| *** vigneshvar has joined #openstack-oslo | 19:07 | |
| *** rpodolyaka2 has joined #openstack-oslo | 19:19 | |
| *** achanda has quit IRC | 19:26 | |
| *** rpodolyaka2 has quit IRC | 19:27 | |
| *** noelbk has joined #openstack-oslo | 19:36 | |
| *** ihrachyshka has quit IRC | 19:37 | |
| *** rpodolyaka2 has joined #openstack-oslo | 19:50 | |
| *** rpodolyaka2 has quit IRC | 19:57 | |
| *** dims_ has quit IRC | 19:58 | |
| *** dims has joined #openstack-oslo | 19:59 | |
| *** tedross has quit IRC | 20:01 | |
| *** kgiusti1 has joined #openstack-oslo | 20:01 | |
| *** kgiusti has quit IRC | 20:01 | |
| *** exploreshaifali has joined #openstack-oslo | 20:03 | |
| *** dims has quit IRC | 20:03 | |
| *** e0ne has joined #openstack-oslo | 20:05 | |
| *** tedross has joined #openstack-oslo | 20:17 | |
| *** dims has joined #openstack-oslo | 20:18 | |
| *** andreykurilin_ has joined #openstack-oslo | 20:25 | |
| *** prad has joined #openstack-oslo | 20:32 | |
| *** prad has quit IRC | 20:33 | |
| *** rushiagr is now known as rushiagr_away | 20:44 | |
| *** ajo_ has quit IRC | 20:52 | |
| *** salv-orlando has quit IRC | 21:00 | |
| *** salv-orlando has joined #openstack-oslo | 21:01 | |
| *** tedross has quit IRC | 21:10 | |
| *** kgiusti1 has quit IRC | 21:19 | |
| openstackgerrit | Merged openstack/oslo.concurrency: Don't use ConfigFilter for lockutils https://review.openstack.org/141436 | 21:38 |
| openstackgerrit | Merged openstack/oslo.concurrency: Clean up API documentation https://review.openstack.org/140680 | 22:03 |
| jogo | jecarey: awesome, will review in a bit | 22:06 |
| openstackgerrit | Merged openstack/oslo.messaging: Don't allow call with fanout target https://review.openstack.org/138684 | 22:12 |
| *** amrith is now known as _amrith_ | 22:14 | |
| *** vigneshvar has quit IRC | 22:27 | |
| jogo | bnemec: ping https://review.openstack.org/#/c/54403/ | 22:30 |
| bnemec | jogo: Yeah, I think I'm going to throw in the towel on those checks and +1 Sean's removal proposal. | 22:32 |
| openstackgerrit | James Carey proposed openstack-dev/hacking: Add optional hacking checks https://review.openstack.org/134052 | 22:32 |
| jogo | bnemec: I was thinking just check for project vs other | 22:33 |
| jogo | bnemec: but that works for me as well | 22:34 |
| jogo | bnemec: these turn out to be hard to programmatically enforce | 22:34 |
| jogo | and I am fine with removing 'em because ETOOHARD | 22:34 |
| bnemec | jogo: Yeah, we could do that, but it still requires manual enforcement of the stdlib vs. third-party. | 22:34 |
| bnemec | Exactly. :-) | 22:35 |
| jogo | bnemec: if you abandon your patch and +2 seans removal I will +W it right now | 22:35 |
| *** tsekiyam_ has joined #openstack-oslo | 22:36 | |
| bnemec | jogo: I don't think he's actually pushed a patch yet. I don't see one anyway. | 22:37 |
| jogo | bnemec: I think it was abandoned | 22:38 |
| jogo | sdague: ^ | 22:38 |
| jogo | https://review.openstack.org/#/c/101499/ | 22:38 |
| jogo | bnemec: that one doesn't remove enough I think | 22:39 |
| jogo | bnemec: want to propose one yourself? | 22:39 |
| bnemec | Yeah, and it probably merge conflicts too. | 22:39 |
| *** tsekiyama has quit IRC | 22:39 | |
| jogo | sigmavirus24: re https://review.openstack.org/#/c/134052 | 22:40 |
| jogo | sigmavirus24: your +1/-1 on that would be appreciated | 22:40 |
| *** tsekiyam_ has quit IRC | 22:41 | |
| bnemec | jogo: I can probably do that. I have to take a look at the ML thread to figure out what needs to go. | 22:42 |
| sigmavirus24 | jogo looking | 22:43 |
| *** tsekiyama has joined #openstack-oslo | 22:43 | |
| jogo | bnemec: AFAIK anything that needs to determine what type of import it is (project, 3rd party etc) | 22:43 |
| jogo | sigmavirus24: doesn't flake8 have a disabled by default option as well | 22:44 |
| sigmavirus24 | jogo: we do. mccabe is off by default | 22:44 |
| sigmavirus24 | pep8 also has checks disabled by default | 22:44 |
| jogo | sigmavirus24: can we re-use that logic? | 22:46 |
| sigmavirus24 | jogo: already looking since I was expecting that | 22:46 |
| sigmavirus24 | https://github.com/jcrocholl/pep8/blob/master/pep8.py#L68 is what does it for pep8 | 22:46 |
| *** tsekiyama has quit IRC | 22:47 | |
| jogo | sigmavirus24: eww, not very extensible. and I don't want to monkey patch | 22:47 |
| sigmavirus24 | yeah | 22:47 |
| sigmavirus24 | I'm looking to see how we do it with mccabe | 22:47 |
| * jogo is enjoying flake8 in git | 22:48 | |
| jogo | mccabe's complexity is -1 by default | 22:49 |
| sigmavirus24 | yep | 22:49 |
| sigmavirus24 | I think that means we don't run it at all | 22:49 |
| sigmavirus24 | but I can't find where that logic is | 22:49 |
| jogo | ahh of max_complexity < 0: return | 22:50 |
| *** alexpilotti has quit IRC | 22:50 | |
| jaosorior | dhellmann: are you around? | 22:50 |
| sigmavirus24 | hah so that logic is entirely contained in mccabe the package | 22:50 |
| jogo | that is in doc/extensions.rst | 22:50 |
| jogo | so then I think our optional logic isn't amazing, but its decent | 22:50 |
| jogo | jecarey: ^ | 22:51 |
| *** mriedem has quit IRC | 22:51 | |
| jogo | bnemec: your working on the replacement for https://review.openstack.org/#/c/54403/ right? | 22:52 |
| jecarey | jogo: I'm willing to make changes ... or we could get this in and then improve. | 22:52 |
| jogo | jecarey: I would rather make some of those fixes first | 22:53 |
| bnemec | jogo: Yeah | 22:53 |
| jogo | I think grouping the optional hacking things together is good | 22:53 |
| jogo | too | 22:53 |
| jogo | jecarey: I think you can address my comments in < 5 lines additional most of them trivial | 22:54 |
| jogo | bnemec: excellent | 22:54 |
| * jogo gets his +2 stamp ready | 22:54 | |
| jecarey | jogo ok ... I'll take a look and make the updates. | 22:54 |
| jogo | jecarey: thanks! standing by with a +2 :) | 22:55 |
| jogo | jecarey: there is another issue http://logs.openstack.org/52/134052/5/check//gate-hacking-integration-nova/c4d107b/console.html | 23:03 |
| jogo | hmm wonder if that is related to your patch or something else | 23:04 |
| jogo | hmm not related | 23:05 |
| jogo | sigmavirus24: http://logs.openstack.org/52/134052/5/check//gate-hacking-integration-nova/c4d107b/console.html | 23:05 |
| sigmavirus24 | jogo: interesting | 23:06 |
| sigmavirus24 | The entry point is registered by python can't import that name? | 23:06 |
| *** dims has quit IRC | 23:07 | |
| jogo | sigmavirus24: maybe its a PBR issue | 23:07 |
| *** dims has joined #openstack-oslo | 23:07 | |
| *** dims has quit IRC | 23:08 | |
| *** dims has joined #openstack-oslo | 23:08 | |
| sigmavirus24 | jogo: so this looks familiar but I can't remember where I've seen it before | 23:09 |
| jogo | sigmavirus24: talking to mordred in infra about it | 23:09 |
| jogo | he thinks it could be setuptools related | 23:10 |
| sigmavirus24 | let me see what pbr.util.resolve_name does | 23:11 |
| *** e0ne has quit IRC | 23:11 | |
| openstackgerrit | James Carey proposed openstack-dev/hacking: Add optional hacking checks https://review.openstack.org/134052 | 23:20 |
| *** gordc has quit IRC | 23:23 | |
| bnemec | jogo: Okay, I replied to Sean's thread with my thoughts on what should be removed. It's getting late here, so I think I'll let that stew overnight and if no one objects to my suggestions I'll go ahead with the patch tomorrow morning. | 23:25 |
| jogo | bnemec: thanks | 23:26 |
| *** andreykurilin_ has quit IRC | 23:30 | |
| openstackgerrit | James Carey proposed openstack-dev/hacking: Add optional hacking checks https://review.openstack.org/134052 | 23:31 |
| openstackgerrit | James Carey proposed openstack-dev/hacking: Add optional hacking checks https://review.openstack.org/134052 | 23:32 |
| gus | dhellmann re pylint gpl: yep, I think a separate project on stackforge is going to be the easiest way to go. No-one seems willing to make decisions about license interactions so FUD is winning atm :( | 23:39 |
| *** jecarey has quit IRC | 23:39 | |
| *** e0ne has joined #openstack-oslo | 23:41 | |
| *** e0ne has quit IRC | 23:47 | |
| *** amotoki has quit IRC | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!