Tuesday, 2015-01-06

*** jaosorior has quit IRC00:03
*** GheRivero has quit IRC00:03
*** ajo has quit IRC00:06
*** GheRivero has joined #openstack-oslo00:15
*** dims__ has joined #openstack-oslo00:15
*** dims_ has joined #openstack-oslo00:19
*** jecarey has quit IRC00:20
*** andreykurilin has quit IRC00:20
*** dims__ has quit IRC00:23
*** dims_ has quit IRC00:24
openstackgerritMerged openstack-dev/pbr: Use a wheelhouse in the integration test  https://review.openstack.org/14502900:25
*** tsekiyam_ has joined #openstack-oslo00:28
*** tsekiyama has quit IRC00:31
*** david-ly_ has joined #openstack-oslo00:36
*** david-ly_ has quit IRC00:41
*** achanda has joined #openstack-oslo00:50
*** achanda has quit IRC00:55
*** achanda has joined #openstack-oslo00:56
*** zzzeek has quit IRC00:56
*** achanda has quit IRC01:01
*** GheRivero has quit IRC01:10
*** GheRivero has joined #openstack-oslo01:11
*** GheRivero has quit IRC01:20
*** salv-orlando has quit IRC01:21
*** dims__ has joined #openstack-oslo01:24
*** GheRivero has joined #openstack-oslo01:27
*** tsekiyam_ has quit IRC01:33
openstackgerritMerged openstack/oslo-incubator: Remove unnecessary import of eventlet  https://review.openstack.org/14503301:37
*** mtanino has quit IRC01:38
*** mfedosin has joined #openstack-oslo01:45
*** yamahata has quit IRC01:51
*** mriedem1 has joined #openstack-oslo01:56
*** mriedem has quit IRC01:57
openstackgerritMerged openstack/oslo.serialization: Move files out of the namespace package  https://review.openstack.org/14504802:04
openstackgerritMerged openstack/stevedore: Use pkg_resources resolve() and require() instead of load()  https://review.openstack.org/14504202:05
openstackgerritMerged openstack/oslo.db: Ensure PostgreSQL connection errors are wrapped  https://review.openstack.org/14132302:07
*** GheRivero has quit IRC02:09
*** zzzeek has joined #openstack-oslo02:10
*** GheRivero has joined #openstack-oslo02:15
*** dims__ has quit IRC02:16
*** gordc has joined #openstack-oslo02:35
*** dims__ has joined #openstack-oslo02:38
*** sigmavirus24 is now known as sigmavirus24_awa02:42
*** takedakn has joined #openstack-oslo02:55
openstackgerritEli Qiao proposed openstack/oslo.db: Make sure sort_key_attr is QueryableAttribute when query  https://review.openstack.org/14363202:56
*** zzzeek has quit IRC03:00
*** sigmavirus24_awa is now known as sigmavirus2403:04
openstackgerritIan Wienand proposed openstack/oslo.config: Make tox use develop mode  https://review.openstack.org/14511903:05
*** salv-orlando has joined #openstack-oslo03:07
*** salv-orlando has quit IRC03:10
*** salv-orlando has joined #openstack-oslo03:10
*** gordc has quit IRC03:13
*** dims__ has quit IRC03:14
*** salv-orlando has quit IRC03:16
*** salv-orlando has joined #openstack-oslo03:16
*** mfedosin has quit IRC03:38
openstackgerritMerged openstack/oslo.middleware: switch to oslo.context  https://review.openstack.org/14384003:39
*** takedakn has quit IRC03:39
*** david-lyle has joined #openstack-oslo03:48
*** salv-orlando has quit IRC03:54
*** mriedem1 has quit IRC04:04
*** yamahata has joined #openstack-oslo04:11
*** dims__ has joined #openstack-oslo04:15
*** gordc has joined #openstack-oslo04:15
*** dims__ has quit IRC04:20
*** amotoki has joined #openstack-oslo04:21
*** sigmavirus24 is now known as sigmavirus24_awa04:24
*** david-lyle is now known as david-lyle_afk04:25
*** e0ne has joined #openstack-oslo05:09
*** e0ne has quit IRC05:11
*** gordc has quit IRC05:17
*** k4n0 has joined #openstack-oslo05:24
*** salv-orlando has joined #openstack-oslo05:25
*** k4n0 has quit IRC05:25
*** salv-orlando has quit IRC05:28
*** arnaud has joined #openstack-oslo05:28
*** salv-orlando has joined #openstack-oslo05:30
openstackgerritIan Wienand proposed openstack/oslo.config: Clear up MultiStrOpt and related documentation  https://review.openstack.org/13261305:36
*** rpodolyaka2 has joined #openstack-oslo05:48
*** dims__ has joined #openstack-oslo06:04
*** salv-orlando has quit IRC06:11
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex  https://review.openstack.org/14325606:12
*** salv-orlando has joined #openstack-oslo06:13
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.utils: Add method is_valid_port in netutils  https://review.openstack.org/14361706:16
*** salv-orlando has quit IRC06:20
*** salv-orlando has joined #openstack-oslo06:22
*** stevemar2 has joined #openstack-oslo06:31
*** stevemar has quit IRC06:34
*** dims__ has quit IRC06:38
*** mfedosin has joined #openstack-oslo06:51
*** e0ne has joined #openstack-oslo07:02
*** vigneshvar has joined #openstack-oslo07:08
*** rpodolyaka2 has quit IRC07:16
*** rpodolyaka2 has joined #openstack-oslo07:17
*** e0ne has quit IRC07:18
*** stevemar2 has quit IRC07:44
*** arnaud has quit IRC07:46
*** rpodolyaka2 has quit IRC08:02
*** arnaud has joined #openstack-oslo08:03
*** rpodolyaka2 has joined #openstack-oslo08:04
*** rpodolyaka2 has quit IRC08:05
*** arnaud has quit IRC08:08
*** rpodolyaka2 has joined #openstack-oslo08:08
*** rpodolyaka2 has quit IRC08:10
*** salv-orlando has quit IRC08:15
*** salv-orlando has joined #openstack-oslo08:15
openstackgerritEli Qiao proposed openstack/oslo.db: Make sure sort_key_attr is QueryableAttribute when query  https://review.openstack.org/14363208:45
*** f13o has joined #openstack-oslo08:54
*** f13o has quit IRC08:55
*** f13o has joined #openstack-oslo08:55
*** dtantsur|afk is now known as dtantsur09:00
*** arnaud__ has joined #openstack-oslo09:04
*** ihrachyshka has joined #openstack-oslo09:08
*** arnaud__ has quit IRC09:09
*** i159 has joined #openstack-oslo09:10
*** yamahata has quit IRC09:12
*** yamahata has joined #openstack-oslo09:12
*** salv-orlando has quit IRC09:22
*** f13o has quit IRC09:23
*** salv-orlando has joined #openstack-oslo09:27
*** ihrachyshka has quit IRC09:30
*** amotoki has quit IRC09:31
*** pblaho has joined #openstack-oslo09:32
*** mfedosin has quit IRC09:33
*** mfedosin has joined #openstack-oslo09:46
*** GheRivero has quit IRC09:48
*** GheRivero has joined #openstack-oslo09:48
*** andreykurilin has joined #openstack-oslo09:53
*** GheRivero has quit IRC09:53
*** GheRivero has joined #openstack-oslo09:53
*** andreykurilin has quit IRC09:57
*** andreykurilin has joined #openstack-oslo09:58
*** mkoderer_cloud has joined #openstack-oslo10:00
*** alexpilotti has joined #openstack-oslo10:02
*** isviridov_away is now known as isviridov10:10
*** dims__ has joined #openstack-oslo10:11
*** dims__ has quit IRC10:17
*** GheRivero has quit IRC10:20
*** e0ne has joined #openstack-oslo10:25
*** GheRivero has joined #openstack-oslo10:31
*** yassine has joined #openstack-oslo10:32
*** GheRivero has quit IRC10:46
*** GheRivero has joined #openstack-oslo10:47
*** arnaud__ has joined #openstack-oslo10:54
*** arnaud__ has quit IRC10:58
*** yassine has quit IRC11:01
*** e0ne is now known as e0ne_11:09
*** e0ne_ has quit IRC11:20
*** yamahata has quit IRC11:23
*** GheRivero has quit IRC11:24
*** GheRivero has joined #openstack-oslo11:24
*** e0ne has joined #openstack-oslo11:30
*** andreykurilin has quit IRC11:31
*** dims__ has joined #openstack-oslo11:44
*** dims__ has quit IRC11:49
*** jaypipes has joined #openstack-oslo11:51
*** dims__ has joined #openstack-oslo11:59
*** jecarey has joined #openstack-oslo12:02
*** yassine has joined #openstack-oslo12:12
*** ihrachyshka has joined #openstack-oslo12:17
*** mfedosin has quit IRC12:17
*** dims__ has quit IRC12:25
openstackgerritMike Fedosin proposed openstack/oslo.config: Fix of wrong cli opts unregistration  https://review.openstack.org/14521412:37
*** arnaud__ has joined #openstack-oslo12:42
*** enykeev has quit IRC12:46
*** arnaud__ has quit IRC12:47
openstackgerritJulien Danjou proposed openstack/oslo.log: Replace RFCSysLogHandler by a syslog() based one  https://review.openstack.org/13684212:48
*** vigneshvar has quit IRC12:51
*** gordc has joined #openstack-oslo12:55
*** dims__ has joined #openstack-oslo12:57
*** gordc has quit IRC13:03
*** jecarey has quit IRC13:03
*** takedakn has joined #openstack-oslo13:08
dhellmanndims: are we ready to remove the context code from the incubator? I think that patch is the last step for https://blueprints.launchpad.net/oslo-incubator/+spec/graduate-oslo-context13:12
*** jeckersb_gone is now known as jeckersb13:23
*** e0ne is now known as e0ne_13:25
*** e0ne_ has quit IRC13:35
*** arnaud__ has joined #openstack-oslo13:43
ihrachyshkadhellmann, any new stevedore release planned? needed to fix gate failures due to huge logs.13:45
*** arnaud__ has quit IRC13:47
*** gordc has joined #openstack-oslo13:49
*** kgiusti has quit IRC13:55
*** kgiusti has joined #openstack-oslo13:56
*** sigmavirus24_awa is now known as sigmavirus2413:57
*** e0ne has joined #openstack-oslo13:58
sigmavirus24Is there anyone from oslo.messaging around who can help me track down https://bugs.launchpad.net/oslo.messaging/+bug/1406629 ? (or determine if it's still an issue)14:02
*** amrith is now known as _amrith_14:08
silehtsigmavirus24, interesting, I known, how to workaround that14:12
sigmavirus24sileht: so the way we're working around it right now is making sure that we never restart rabbit while services are running14:18
sigmavirus24but we didn't have this problem with oslo.messaging 1.4.x14:18
sigmavirus24so it seems like there was a regression along the way in behaviour (which I guess I should note on the bug because that's probably something we figured out after diagnosing it)14:19
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed.  https://review.openstack.org/14523214:20
silehtsigmavirus24, should fix the issue ^^14:20
silehtsigmavirus24, I say workaround before the bug report talk about a issue in kombu, but anyway oslo.messaging must cleanup its channels too14:21
*** kragniz has quit IRC14:22
*** kragniz has joined #openstack-oslo14:22
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed.  https://review.openstack.org/14523214:24
sigmavirus24sileht: thanks!14:26
*** mriedem has joined #openstack-oslo14:28
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed.  https://review.openstack.org/14523214:37
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed.  https://review.openstack.org/14523214:39
*** zzzeek has joined #openstack-oslo14:42
*** GheRivero has quit IRC14:42
dhellmannihrachyshka: stevedore 1.2.0 is built14:46
ihrachyshkadhellmann, cool, thanks!14:46
*** GheRivero has joined #openstack-oslo14:49
openstackgerritVictor Stinner proposed openstack/oslo.messaging: Port rabbitmq and zmq drivers to Python 3  https://review.openstack.org/14524114:51
*** zzzeek has quit IRC14:52
*** zzzeek has joined #openstack-oslo14:53
*** jecarey has joined #openstack-oslo14:54
*** arnaud__ has joined #openstack-oslo14:59
*** sigmavirus24 is now known as sigmavirus24_awa14:59
*** _amrith_ is now known as amrith15:03
*** arnaud__ has quit IRC15:04
*** zz_jgrimm is now known as jgrimm15:05
*** takedakn1 has joined #openstack-oslo15:06
*** zzzeek has quit IRC15:06
*** zzzeek has joined #openstack-oslo15:06
*** takedakn has quit IRC15:08
*** mtanino has joined #openstack-oslo15:15
openstackgerritMerged openstack/stevedore: clean up default environments run by tox  https://review.openstack.org/14504315:16
openstackgerritMerged openstack/stevedore: ignore .testrepository directory created by testr  https://review.openstack.org/14504415:16
openstackgerritDoug Hellmann proposed openstack/oslo.i18n: Fix the link to the bug tracker in the README  https://review.openstack.org/14524615:17
*** stevemar has joined #openstack-oslo15:22
*** sigmavirus24_awa is now known as sigmavirus2415:23
*** takedakn1 has quit IRC15:40
*** subscope has quit IRC15:51
*** e0ne is now known as e0ne_15:57
*** arnaud__ has joined #openstack-oslo15:58
*** pblaho_ has joined #openstack-oslo15:59
*** pblaho has quit IRC16:01
*** e0ne_ is now known as e0ne16:06
*** pblaho_ has quit IRC16:06
*** pblaho has joined #openstack-oslo16:07
openstackgerritBrant Knudson proposed openstack/oslo-incubator: Change oslo.config to oslo_config  https://review.openstack.org/14525616:07
*** pblaho has quit IRC16:09
openstackgerritBrant Knudson proposed openstack/oslo-incubator: Change oslo.config to oslo_config  https://review.openstack.org/14525616:10
*** tsekiyama has joined #openstack-oslo16:13
*** pblaho has joined #openstack-oslo16:15
*** denis_makogon has quit IRC16:17
*** mkoderer_cloud has quit IRC16:23
openstackgerritVictor Stinner proposed openstack/oslo.messaging: Port zmq driver to Python 3  https://review.openstack.org/14524116:29
*** e0ne is now known as e0ne_16:31
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed.  https://review.openstack.org/14523216:34
openstackgerritDoug Hellmann proposed openstack/oslo.messaging: Move files out of the namespace package  https://review.openstack.org/14479416:35
openstackgerritMerged openstack/taskflow: Remove need to inherit/adjust netutils split  https://review.openstack.org/14508716:39
openstackgerritMerged openstack/oslo.utils: Add method is_valid_port in netutils  https://review.openstack.org/14361716:40
*** pblaho_ has joined #openstack-oslo16:40
*** pblaho has quit IRC16:40
*** e0ne_ has quit IRC16:41
bknudsonwe have "from oslo import i18n" is that "import oslo_i18n as i18n" ?16:44
dhellmannbknudson: yeah, did I miss that in the docs?16:45
bknudsonassuming I read docs!16:45
dhellmannit looks like most of the usage instructions assume you import it as oslo_i18n, but if you want to alias it that should be fine16:46
bknudsonit just might be less change since we were using i18n before.16:47
dhellmannmakes sense16:47
bknudsonalthough I prefer not aliasing if I don't have to, so I'll probably switch them.16:47
*** pradk has joined #openstack-oslo16:48
*** pblaho_ has quit IRC16:48
*** pblaho_ has joined #openstack-oslo16:48
openstackgerritMerged openstack/oslo.i18n: Fix the link to the bug tracker in the README  https://review.openstack.org/14524616:54
*** pblaho_ has quit IRC16:54
*** yamahata has joined #openstack-oslo16:59
therveI'm getting an error when using oslo config generator and oslo.i18n messages: http://paste.openstack.org/show/155765/17:04
therveHas anyone seen that problem? The fix seems easy but I wonder why nobody saw it17:04
dims__therve: oslo.i18n was released this morning, i believe dhellmann has a review pending against heat already17:05
thervedims__, Right that's another issue I believe17:05
dims__therve: ah ok17:05
openstackgerritMichael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module  https://review.openstack.org/13821517:05
dims__looking17:05
*** i159 has quit IRC17:06
*** e0ne has joined #openstack-oslo17:07
dims__therve: please do log a bug against oslo.i18n, let me try to recreate it17:07
dhellmanntherve: I hadn't seen that one because I didn't run that test17:07
dims__dhellmann: "tox -egenconfig" in heat17:07
thervedhellmann, Yeah it's not a new problem AFAICT.17:07
therveI just switched away from the incubator generator, and somehow discovered it17:08
therveI thought maybe I was missing some oslo.i18n setup17:08
dhellmanntherve: is heat using translations for help text?17:08
dhellmannwhat option is causing the problem?17:08
thervedhellmann, We are apparently, yes17:09
dhellmanntherve: ok, that's unexpected :-)17:10
thervedhellmann, That's what I was wondering too. Possibly unsupported?17:10
dhellmannit's not bad, just not something I think we've seen so far17:10
dhellmannwe should support it, if it's not too bad17:10
dhellmannthe fix is probably to change the way we build the strings in the config generator17:11
thervehttps://github.com/openstack/heat/blob/master/heat/common/config.py#L163 is the help17:11
therveRIght17:11
therveIt's a one line diff IIUC17:11
dims__i think i know how to fix therve17:14
dims__give me a sec17:14
thervedims__, https://bugs.launchpad.net/oslo.config/+bug/140803217:14
dims__therve: http://paste.openstack.org/show/155768/17:16
thervedims__, Yep that's my try as well :)17:16
openstackgerritDoug Hellmann proposed openstack/oslo.middleware: Move files out of the namespace package  https://review.openstack.org/14527117:16
therveSeems to make the tests fail though17:16
dims__y checking17:16
*** e0ne has quit IRC17:17
*** e0ne has joined #openstack-oslo17:17
*** e0ne has quit IRC17:17
dhellmannyou might need to explicitly call oslo.i18n.translate() on opt.help17:17
thervedims__, http://paste.openstack.org/show/155769/ :/17:18
thervedhellmann, Inside oslo.config itself you mean?17:19
dhellmanntherve: yes17:19
therveRight. I wonder if the help is translable otherwise indeed.17:19
dhellmannmaybe not, though, Message.__unicode__ should work17:20
dhellmannwell, it'll come out with the default locale, which is probably what you want17:20
dims__we just need to fix the test17:20
dims__y17:20
*** bknudson has quit IRC17:21
dhellmannlunch time, bbiab17:22
*** noelbk has joined #openstack-oslo17:24
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True  https://review.openstack.org/10937317:28
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Add a info log when a reconnection occurs  https://review.openstack.org/13841117:28
dims__therve: funny construct gets past tests :) http://paste.openstack.org/show/155770/17:31
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True  https://review.openstack.org/10937317:31
dims__trying something better :)17:31
therveYeah not pretty but works17:32
dims__let me file a review anyways!17:32
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.config: Support i18n messages in config generator  https://review.openstack.org/14528017:38
dims__dhellmann: therve: done - https://review.openstack.org/14528017:38
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True  https://review.openstack.org/10937317:41
*** yassine has quit IRC17:45
openstackgerritMehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True  https://review.openstack.org/10937317:48
*** bknudson has joined #openstack-oslo17:48
* bnemec thinks we need a moratorium on merging patches until the namespace changes merge17:50
bnemecOtherwise dhellmann is going to murder us all ;-)17:50
dims__LOL :)17:54
*** otherwiseguy has joined #openstack-oslo17:54
*** e0ne has joined #openstack-oslo18:08
sigmavirus24rebase rebase rebase rebase18:09
*** sdague has joined #openstack-oslo18:11
sdaguequestion about logging, are there any thoughts in making debug logging have a frame reference so that pathname might be more meaninful?18:11
sdaguefor instance - http://logs.openstack.org/70/144070/6/gate/gate-tempest-dsvm-neutron-full/56b1168/logs/screen-n-cpu.txt.gz#_2015-01-06_14_16_12_52618:12
sdagueknowing that lock function is in lockutils.py isn't exceptionally useful for knowing what's going on18:12
*** yamahata has quit IRC18:18
*** e0ne has quit IRC18:21
*** noelbk has quit IRC18:22
dhellmannbnemec: too true ;-)18:28
dhellmanndims__: do we have a test that passes a Message object as the help text?18:30
*** dtantsur is now known as dtantsur|afk18:31
dhellmannsdague: I'm not clear about what you're asking. Are you suggesting we make it possible to pass a frame reference in to the lock calls, or that we do something with logging? Or that we have the lock calls figure out their caller and log that automatically?18:33
*** yamahata has joined #openstack-oslo18:37
dims__dhellmann: oslo.config does not depend on oslo.i18n currently18:37
dhellmanndims__: ok, we should add it as a test requirement so we can have an explicit test for this new case18:37
dims__ack, will do18:38
openstackgerritDoug Hellmann proposed openstack/oslo.middleware: Move files out of the namespace package  https://review.openstack.org/14527118:55
*** bknudson has quit IRC19:06
*** yamahata has quit IRC19:14
*** e0ne has joined #openstack-oslo19:18
*** e0ne is now known as e0ne_19:19
openstackgerritDoug Hellmann proposed openstack/oslo.log: Update comment to match implementation  https://review.openstack.org/14530719:21
*** yamahata has joined #openstack-oslo19:21
*** yamahata has quit IRC19:26
*** rpodolyaka2 has joined #openstack-oslo19:28
*** e0ne_ has quit IRC19:28
openstackgerritDoug Hellmann proposed openstack/oslo.log: Update comment to match implementation  https://review.openstack.org/14530719:29
*** e0ne has joined #openstack-oslo19:34
*** ihrachyshka has quit IRC19:35
*** david-lyle_afk is now known as david-lyle19:39
openstackgerritMerged openstack/oslo.log: Correct the position of the syslog handler  https://review.openstack.org/13897119:41
*** dims__ has quit IRC19:45
*** dims__ has joined #openstack-oslo19:46
*** rpodolyaka2 has quit IRC19:47
openstackgerritDoug Hellmann proposed openstack/oslo.log: Add API documentation  https://review.openstack.org/14531819:48
*** dims__ has quit IRC19:49
*** dims__ has joined #openstack-oslo19:49
openstackgerritMerged openstack/oslo.log: Implement resource to logging extra keywords  https://review.openstack.org/14481319:53
*** mfedosin has joined #openstack-oslo20:01
*** rpodolyaka2 has joined #openstack-oslo20:02
*** bknudson has joined #openstack-oslo20:10
boris-42dhellmann: hey there20:23
boris-42dhellmann: did you see https://review.openstack.org/#/c/145214/ ? this should fix rally tests20:23
dhellmannboris-42: so the problem had to do with the way rally was registering and unregistering options?20:25
mfedosinboris-42, dhellmann hi!20:26
mfedosindhellmann, yes20:26
mfedosinit's here https://github.com/stackforge/rally/blob/master/tests/unit/cmd/test_cliutils.py#L120. I thought that we need to pass exactly the same opt object that we used to register an option20:29
dhellmannmfedosin: you could also create a separate ConfigOpts instance though, right?20:30
mfedosinbut basically it's not. in rally there a new object with the same name and destination that passed to unregister method20:31
dhellmannI'm trying to understand how this hasn't come up before, and if this unregistration logic is just fundamentally broken somehow20:31
dhellmannmfedosin: why is it a new object, though? what prevents you from keeping the one that was originally registered?20:31
mfedosindhellmann, i don't know, you better ask Boris why they create a new object20:33
mfedosinbut before oslo config requires only an object with 'dest' field to unregister20:34
mfedosinhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L189120:34
dhellmannyeah, ok, I'm just trying to understand why the use in rally is the only place this comes up and whether the issue is there or in oslo.config20:35
mfedosinas for me I think it's more correct to pass registered opt object there, so I did in my commit20:37
mfedosinor if we want to unregister opt by destination then just pass a string value there20:38
mfedosinrather than artificially created object20:39
*** rpodolyaka2 has quit IRC20:40
*** andreykurilin has joined #openstack-oslo20:43
*** pcaruana is now known as pcaruana|afk|20:45
dhellmannright20:50
dhellmannmfedosin: +2 on https://review.openstack.org/#/c/145214/ to restore the old behavior20:52
openstackgerritMichael Bayer proposed openstack/oslo.db: Add pretty_tox wrapper script  https://review.openstack.org/14533420:53
openstackgerritMerged openstack/oslo.messaging: Add an optional executor callback to dispatcher  https://review.openstack.org/13665220:54
*** harlowja_at_home has joined #openstack-oslo20:59
openstackgerritDoug Hellmann proposed openstack/oslo.utils: Move files out of the namespace package  https://review.openstack.org/14505821:02
mfedosindhellmann, thanks!21:03
mfedosindhellmann, another solution is we can change https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1891 by adding another condition like:  elif opt.dest in self._opts and self._opts[opt.dest] is opt:21:07
mfedosinand then rally team will have to make changes in their code to comply with it.21:08
mfedosinalso I suggest to make first (opt) parameter looks like the second (:param group: an optional OptGroup object or group name), so it could be Opt object or just name. And if it's a  string then we call _do_get method to get the desired object and the unregister it.21:08
mfedosinThis solution is more correct, but it breaks backward compatibility and many (read Boris) will be dissatisfied.21:09
mfedosinbut they just need to change https://github.com/stackforge/rally/blob/master/tests/unit/cmd/test_cliutils.py#L120 from  CONF.unregister_opt(category_opt) to  CONF.unregister_opt('category')21:11
mfedosinwhat do you think?21:11
*** tsekiyama has quit IRC21:12
*** amrith is now known as _amrith_21:15
*** tsekiyama has joined #openstack-oslo21:15
harlowja_at_homedhellmann, do u need me to release taskflow for the oslo.utils stuffs?21:17
dhellmannharlowja_at_home: yeah, if you could21:19
harlowja_at_homekk21:19
harlowja_at_homewill jump over to laptop in a bit and do that21:20
*** russellb has joined #openstack-oslo21:27
*** arnaud__ has quit IRC21:30
openstackgerritMichael Bayer proposed openstack/oslo.db: Add pretty_tox wrapper script  https://review.openstack.org/14533421:38
*** ajo has joined #openstack-oslo21:49
*** e0ne has quit IRC22:02
openstackgerritDoug Hellmann proposed openstack/oslo.utils: Move files out of the namespace package  https://review.openstack.org/14505822:19
*** kgiusti has quit IRC22:25
*** dims_ has joined #openstack-oslo22:28
*** mfedosin has quit IRC22:29
*** gordc has quit IRC22:29
openstackgerritDoug Hellmann proposed openstack/oslo.i18n: Add a fixture to let tests manage the lazy flag  https://review.openstack.org/14536422:30
dhellmanndims_: I think that was the fastest review I've seen in a while :-)22:32
openstackgerritMerged openstack/oslo.middleware: Move files out of the namespace package  https://review.openstack.org/14527122:32
dims_:)22:32
*** dims__ has quit IRC22:32
dims_dhellmann: may take that back if pep8 fails because of the last line in the file22:34
dims_shows up red - https://review.openstack.org/#/c/145364/1/oslo_i18n/tests/test_fixture.py,unified22:34
dhellmanndims_: bah22:35
dims_wanna fix it?22:36
dhellmannyeah, doing that now22:36
openstackgerritDoug Hellmann proposed openstack/oslo.i18n: Add a fixture to let tests manage the lazy flag  https://review.openstack.org/14536422:37
dims_ah! James beat me to it, so i have to wait for the jobs and then +2/+A :)22:39
dhellmanndims_: :-)22:50
openstackgerritOpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements  https://review.openstack.org/14478622:52
openstackgerritMichael Bayer proposed openstack/oslo.db: Add pretty_tox wrapper script  https://review.openstack.org/14533422:57
openstackgerritMerged openstack/oslo.concurrency: Add a reader/writer lock  https://review.openstack.org/13821722:59
*** sigmavirus24 is now known as sigmavirus24_awa23:01
*** bknudson has quit IRC23:02
openstackgerritDavanum Srinivas (dims) proposed openstack-dev/pbr: Add pointers to various resources  https://review.openstack.org/14483823:03
*** alexpilotti has quit IRC23:12
openstackgerritDavanum Srinivas (dims) proposed openstack-dev/pbr: Add pointers to various resources  https://review.openstack.org/14483823:14
*** jgrimm is now known as zz_jgrimm23:18
openstackgerritDoug Hellmann proposed openstack/oslo.i18n: Improve fixture documentation  https://review.openstack.org/14537523:18
*** ajo has quit IRC23:20
*** stevemar has quit IRC23:20
*** miqui has quit IRC23:20
*** rharwood has quit IRC23:21
*** shardy has quit IRC23:21
*** andreykurilin1 has quit IRC23:21
*** isq has quit IRC23:21
*** git-harry has quit IRC23:21
*** tsufiev has quit IRC23:21
*** frickler has quit IRC23:21
*** dstanek has quit IRC23:21
*** mtanino has quit IRC23:21
*** bnemec has quit IRC23:21
*** krotscheck has quit IRC23:21
*** burgobianco has quit IRC23:21
*** redrobot has quit IRC23:21
*** SergeyLukjanov has quit IRC23:21
*** therve has quit IRC23:21
*** ekarlso- has quit IRC23:21
*** cburgess_ has quit IRC23:21
*** jogo has quit IRC23:21
*** blogan has quit IRC23:21
*** git-harry has joined #openstack-oslo23:21
*** ajo has joined #openstack-oslo23:21
*** stevemar has joined #openstack-oslo23:21
*** tsufiev has joined #openstack-oslo23:21
*** andreykurilin1 has joined #openstack-oslo23:22
*** mriedem has quit IRC23:22
*** mtanino has joined #openstack-oslo23:22
*** bnemec has joined #openstack-oslo23:22
*** krotscheck has joined #openstack-oslo23:22
*** burgobianco has joined #openstack-oslo23:22
*** redrobot has joined #openstack-oslo23:22
*** SergeyLukjanov has joined #openstack-oslo23:22
*** therve has joined #openstack-oslo23:22
*** ekarlso- has joined #openstack-oslo23:22
*** cburgess_ has joined #openstack-oslo23:22
*** blogan has joined #openstack-oslo23:22
*** jogo has joined #openstack-oslo23:22
*** rharwood has joined #openstack-oslo23:23
*** boris-42 has quit IRC23:24
*** burgobianco has quit IRC23:24
*** miqui has joined #openstack-oslo23:25
*** frickler has joined #openstack-oslo23:26
*** burgobianco has joined #openstack-oslo23:26
*** boris-42 has joined #openstack-oslo23:26
*** zz_jgrimm has quit IRC23:26
*** zz_jgrimm has joined #openstack-oslo23:29
*** jecarey has quit IRC23:33
*** pradk has quit IRC23:38
openstackgerritMerged openstack/oslo.utils: Move files out of the namespace package  https://review.openstack.org/14505823:45
harlowja_at_homedhellmann, http://lists.openstack.org/pipermail/openstack-dev/2015-January/053871.html23:45
harlowja_at_homeall should be good i think23:45
*** dims_ has quit IRC23:48
*** dims__ has joined #openstack-oslo23:53
*** dstanek has joined #openstack-oslo23:55
*** shardy has joined #openstack-oslo23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!