*** jaosorior has quit IRC | 00:03 | |
*** GheRivero has quit IRC | 00:03 | |
*** ajo has quit IRC | 00:06 | |
*** GheRivero has joined #openstack-oslo | 00:15 | |
*** dims__ has joined #openstack-oslo | 00:15 | |
*** dims_ has joined #openstack-oslo | 00:19 | |
*** jecarey has quit IRC | 00:20 | |
*** andreykurilin has quit IRC | 00:20 | |
*** dims__ has quit IRC | 00:23 | |
*** dims_ has quit IRC | 00:24 | |
openstackgerrit | Merged openstack-dev/pbr: Use a wheelhouse in the integration test https://review.openstack.org/145029 | 00:25 |
---|---|---|
*** tsekiyam_ has joined #openstack-oslo | 00:28 | |
*** tsekiyama has quit IRC | 00:31 | |
*** david-ly_ has joined #openstack-oslo | 00:36 | |
*** david-ly_ has quit IRC | 00:41 | |
*** achanda has joined #openstack-oslo | 00:50 | |
*** achanda has quit IRC | 00:55 | |
*** achanda has joined #openstack-oslo | 00:56 | |
*** zzzeek has quit IRC | 00:56 | |
*** achanda has quit IRC | 01:01 | |
*** GheRivero has quit IRC | 01:10 | |
*** GheRivero has joined #openstack-oslo | 01:11 | |
*** GheRivero has quit IRC | 01:20 | |
*** salv-orlando has quit IRC | 01:21 | |
*** dims__ has joined #openstack-oslo | 01:24 | |
*** GheRivero has joined #openstack-oslo | 01:27 | |
*** tsekiyam_ has quit IRC | 01:33 | |
openstackgerrit | Merged openstack/oslo-incubator: Remove unnecessary import of eventlet https://review.openstack.org/145033 | 01:37 |
*** mtanino has quit IRC | 01:38 | |
*** mfedosin has joined #openstack-oslo | 01:45 | |
*** yamahata has quit IRC | 01:51 | |
*** mriedem1 has joined #openstack-oslo | 01:56 | |
*** mriedem has quit IRC | 01:57 | |
openstackgerrit | Merged openstack/oslo.serialization: Move files out of the namespace package https://review.openstack.org/145048 | 02:04 |
openstackgerrit | Merged openstack/stevedore: Use pkg_resources resolve() and require() instead of load() https://review.openstack.org/145042 | 02:05 |
openstackgerrit | Merged openstack/oslo.db: Ensure PostgreSQL connection errors are wrapped https://review.openstack.org/141323 | 02:07 |
*** GheRivero has quit IRC | 02:09 | |
*** zzzeek has joined #openstack-oslo | 02:10 | |
*** GheRivero has joined #openstack-oslo | 02:15 | |
*** dims__ has quit IRC | 02:16 | |
*** gordc has joined #openstack-oslo | 02:35 | |
*** dims__ has joined #openstack-oslo | 02:38 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 02:42 | |
*** takedakn has joined #openstack-oslo | 02:55 | |
openstackgerrit | Eli Qiao proposed openstack/oslo.db: Make sure sort_key_attr is QueryableAttribute when query https://review.openstack.org/143632 | 02:56 |
*** zzzeek has quit IRC | 03:00 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 03:04 | |
openstackgerrit | Ian Wienand proposed openstack/oslo.config: Make tox use develop mode https://review.openstack.org/145119 | 03:05 |
*** salv-orlando has joined #openstack-oslo | 03:07 | |
*** salv-orlando has quit IRC | 03:10 | |
*** salv-orlando has joined #openstack-oslo | 03:10 | |
*** gordc has quit IRC | 03:13 | |
*** dims__ has quit IRC | 03:14 | |
*** salv-orlando has quit IRC | 03:16 | |
*** salv-orlando has joined #openstack-oslo | 03:16 | |
*** mfedosin has quit IRC | 03:38 | |
openstackgerrit | Merged openstack/oslo.middleware: switch to oslo.context https://review.openstack.org/143840 | 03:39 |
*** takedakn has quit IRC | 03:39 | |
*** david-lyle has joined #openstack-oslo | 03:48 | |
*** salv-orlando has quit IRC | 03:54 | |
*** mriedem1 has quit IRC | 04:04 | |
*** yamahata has joined #openstack-oslo | 04:11 | |
*** dims__ has joined #openstack-oslo | 04:15 | |
*** gordc has joined #openstack-oslo | 04:15 | |
*** dims__ has quit IRC | 04:20 | |
*** amotoki has joined #openstack-oslo | 04:21 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 04:24 | |
*** david-lyle is now known as david-lyle_afk | 04:25 | |
*** e0ne has joined #openstack-oslo | 05:09 | |
*** e0ne has quit IRC | 05:11 | |
*** gordc has quit IRC | 05:17 | |
*** k4n0 has joined #openstack-oslo | 05:24 | |
*** salv-orlando has joined #openstack-oslo | 05:25 | |
*** k4n0 has quit IRC | 05:25 | |
*** salv-orlando has quit IRC | 05:28 | |
*** arnaud has joined #openstack-oslo | 05:28 | |
*** salv-orlando has joined #openstack-oslo | 05:30 | |
openstackgerrit | Ian Wienand proposed openstack/oslo.config: Clear up MultiStrOpt and related documentation https://review.openstack.org/132613 | 05:36 |
*** rpodolyaka2 has joined #openstack-oslo | 05:48 | |
*** dims__ has joined #openstack-oslo | 06:04 | |
*** salv-orlando has quit IRC | 06:11 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/143256 | 06:12 |
*** salv-orlando has joined #openstack-oslo | 06:13 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.utils: Add method is_valid_port in netutils https://review.openstack.org/143617 | 06:16 |
*** salv-orlando has quit IRC | 06:20 | |
*** salv-orlando has joined #openstack-oslo | 06:22 | |
*** stevemar2 has joined #openstack-oslo | 06:31 | |
*** stevemar has quit IRC | 06:34 | |
*** dims__ has quit IRC | 06:38 | |
*** mfedosin has joined #openstack-oslo | 06:51 | |
*** e0ne has joined #openstack-oslo | 07:02 | |
*** vigneshvar has joined #openstack-oslo | 07:08 | |
*** rpodolyaka2 has quit IRC | 07:16 | |
*** rpodolyaka2 has joined #openstack-oslo | 07:17 | |
*** e0ne has quit IRC | 07:18 | |
*** stevemar2 has quit IRC | 07:44 | |
*** arnaud has quit IRC | 07:46 | |
*** rpodolyaka2 has quit IRC | 08:02 | |
*** arnaud has joined #openstack-oslo | 08:03 | |
*** rpodolyaka2 has joined #openstack-oslo | 08:04 | |
*** rpodolyaka2 has quit IRC | 08:05 | |
*** arnaud has quit IRC | 08:08 | |
*** rpodolyaka2 has joined #openstack-oslo | 08:08 | |
*** rpodolyaka2 has quit IRC | 08:10 | |
*** salv-orlando has quit IRC | 08:15 | |
*** salv-orlando has joined #openstack-oslo | 08:15 | |
openstackgerrit | Eli Qiao proposed openstack/oslo.db: Make sure sort_key_attr is QueryableAttribute when query https://review.openstack.org/143632 | 08:45 |
*** f13o has joined #openstack-oslo | 08:54 | |
*** f13o has quit IRC | 08:55 | |
*** f13o has joined #openstack-oslo | 08:55 | |
*** dtantsur|afk is now known as dtantsur | 09:00 | |
*** arnaud__ has joined #openstack-oslo | 09:04 | |
*** ihrachyshka has joined #openstack-oslo | 09:08 | |
*** arnaud__ has quit IRC | 09:09 | |
*** i159 has joined #openstack-oslo | 09:10 | |
*** yamahata has quit IRC | 09:12 | |
*** yamahata has joined #openstack-oslo | 09:12 | |
*** salv-orlando has quit IRC | 09:22 | |
*** f13o has quit IRC | 09:23 | |
*** salv-orlando has joined #openstack-oslo | 09:27 | |
*** ihrachyshka has quit IRC | 09:30 | |
*** amotoki has quit IRC | 09:31 | |
*** pblaho has joined #openstack-oslo | 09:32 | |
*** mfedosin has quit IRC | 09:33 | |
*** mfedosin has joined #openstack-oslo | 09:46 | |
*** GheRivero has quit IRC | 09:48 | |
*** GheRivero has joined #openstack-oslo | 09:48 | |
*** andreykurilin has joined #openstack-oslo | 09:53 | |
*** GheRivero has quit IRC | 09:53 | |
*** GheRivero has joined #openstack-oslo | 09:53 | |
*** andreykurilin has quit IRC | 09:57 | |
*** andreykurilin has joined #openstack-oslo | 09:58 | |
*** mkoderer_cloud has joined #openstack-oslo | 10:00 | |
*** alexpilotti has joined #openstack-oslo | 10:02 | |
*** isviridov_away is now known as isviridov | 10:10 | |
*** dims__ has joined #openstack-oslo | 10:11 | |
*** dims__ has quit IRC | 10:17 | |
*** GheRivero has quit IRC | 10:20 | |
*** e0ne has joined #openstack-oslo | 10:25 | |
*** GheRivero has joined #openstack-oslo | 10:31 | |
*** yassine has joined #openstack-oslo | 10:32 | |
*** GheRivero has quit IRC | 10:46 | |
*** GheRivero has joined #openstack-oslo | 10:47 | |
*** arnaud__ has joined #openstack-oslo | 10:54 | |
*** arnaud__ has quit IRC | 10:58 | |
*** yassine has quit IRC | 11:01 | |
*** e0ne is now known as e0ne_ | 11:09 | |
*** e0ne_ has quit IRC | 11:20 | |
*** yamahata has quit IRC | 11:23 | |
*** GheRivero has quit IRC | 11:24 | |
*** GheRivero has joined #openstack-oslo | 11:24 | |
*** e0ne has joined #openstack-oslo | 11:30 | |
*** andreykurilin has quit IRC | 11:31 | |
*** dims__ has joined #openstack-oslo | 11:44 | |
*** dims__ has quit IRC | 11:49 | |
*** jaypipes has joined #openstack-oslo | 11:51 | |
*** dims__ has joined #openstack-oslo | 11:59 | |
*** jecarey has joined #openstack-oslo | 12:02 | |
*** yassine has joined #openstack-oslo | 12:12 | |
*** ihrachyshka has joined #openstack-oslo | 12:17 | |
*** mfedosin has quit IRC | 12:17 | |
*** dims__ has quit IRC | 12:25 | |
openstackgerrit | Mike Fedosin proposed openstack/oslo.config: Fix of wrong cli opts unregistration https://review.openstack.org/145214 | 12:37 |
*** arnaud__ has joined #openstack-oslo | 12:42 | |
*** enykeev has quit IRC | 12:46 | |
*** arnaud__ has quit IRC | 12:47 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.log: Replace RFCSysLogHandler by a syslog() based one https://review.openstack.org/136842 | 12:48 |
*** vigneshvar has quit IRC | 12:51 | |
*** gordc has joined #openstack-oslo | 12:55 | |
*** dims__ has joined #openstack-oslo | 12:57 | |
*** gordc has quit IRC | 13:03 | |
*** jecarey has quit IRC | 13:03 | |
*** takedakn has joined #openstack-oslo | 13:08 | |
dhellmann | dims: are we ready to remove the context code from the incubator? I think that patch is the last step for https://blueprints.launchpad.net/oslo-incubator/+spec/graduate-oslo-context | 13:12 |
*** jeckersb_gone is now known as jeckersb | 13:23 | |
*** e0ne is now known as e0ne_ | 13:25 | |
*** e0ne_ has quit IRC | 13:35 | |
*** arnaud__ has joined #openstack-oslo | 13:43 | |
ihrachyshka | dhellmann, any new stevedore release planned? needed to fix gate failures due to huge logs. | 13:45 |
*** arnaud__ has quit IRC | 13:47 | |
*** gordc has joined #openstack-oslo | 13:49 | |
*** kgiusti has quit IRC | 13:55 | |
*** kgiusti has joined #openstack-oslo | 13:56 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:57 | |
*** e0ne has joined #openstack-oslo | 13:58 | |
sigmavirus24 | Is there anyone from oslo.messaging around who can help me track down https://bugs.launchpad.net/oslo.messaging/+bug/1406629 ? (or determine if it's still an issue) | 14:02 |
*** amrith is now known as _amrith_ | 14:08 | |
sileht | sigmavirus24, interesting, I known, how to workaround that | 14:12 |
sigmavirus24 | sileht: so the way we're working around it right now is making sure that we never restart rabbit while services are running | 14:18 |
sigmavirus24 | but we didn't have this problem with oslo.messaging 1.4.x | 14:18 |
sigmavirus24 | so it seems like there was a regression along the way in behaviour (which I guess I should note on the bug because that's probably something we figured out after diagnosing it) | 14:19 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed. https://review.openstack.org/145232 | 14:20 |
sileht | sigmavirus24, should fix the issue ^^ | 14:20 |
sileht | sigmavirus24, I say workaround before the bug report talk about a issue in kombu, but anyway oslo.messaging must cleanup its channels too | 14:21 |
*** kragniz has quit IRC | 14:22 | |
*** kragniz has joined #openstack-oslo | 14:22 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed. https://review.openstack.org/145232 | 14:24 |
sigmavirus24 | sileht: thanks! | 14:26 |
*** mriedem has joined #openstack-oslo | 14:28 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed. https://review.openstack.org/145232 | 14:37 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed. https://review.openstack.org/145232 | 14:39 |
*** zzzeek has joined #openstack-oslo | 14:42 | |
*** GheRivero has quit IRC | 14:42 | |
dhellmann | ihrachyshka: stevedore 1.2.0 is built | 14:46 |
ihrachyshka | dhellmann, cool, thanks! | 14:46 |
*** GheRivero has joined #openstack-oslo | 14:49 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Port rabbitmq and zmq drivers to Python 3 https://review.openstack.org/145241 | 14:51 |
*** zzzeek has quit IRC | 14:52 | |
*** zzzeek has joined #openstack-oslo | 14:53 | |
*** jecarey has joined #openstack-oslo | 14:54 | |
*** arnaud__ has joined #openstack-oslo | 14:59 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 14:59 | |
*** _amrith_ is now known as amrith | 15:03 | |
*** arnaud__ has quit IRC | 15:04 | |
*** zz_jgrimm is now known as jgrimm | 15:05 | |
*** takedakn1 has joined #openstack-oslo | 15:06 | |
*** zzzeek has quit IRC | 15:06 | |
*** zzzeek has joined #openstack-oslo | 15:06 | |
*** takedakn has quit IRC | 15:08 | |
*** mtanino has joined #openstack-oslo | 15:15 | |
openstackgerrit | Merged openstack/stevedore: clean up default environments run by tox https://review.openstack.org/145043 | 15:16 |
openstackgerrit | Merged openstack/stevedore: ignore .testrepository directory created by testr https://review.openstack.org/145044 | 15:16 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.i18n: Fix the link to the bug tracker in the README https://review.openstack.org/145246 | 15:17 |
*** stevemar has joined #openstack-oslo | 15:22 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:23 | |
*** takedakn1 has quit IRC | 15:40 | |
*** subscope has quit IRC | 15:51 | |
*** e0ne is now known as e0ne_ | 15:57 | |
*** arnaud__ has joined #openstack-oslo | 15:58 | |
*** pblaho_ has joined #openstack-oslo | 15:59 | |
*** pblaho has quit IRC | 16:01 | |
*** e0ne_ is now known as e0ne | 16:06 | |
*** pblaho_ has quit IRC | 16:06 | |
*** pblaho has joined #openstack-oslo | 16:07 | |
openstackgerrit | Brant Knudson proposed openstack/oslo-incubator: Change oslo.config to oslo_config https://review.openstack.org/145256 | 16:07 |
*** pblaho has quit IRC | 16:09 | |
openstackgerrit | Brant Knudson proposed openstack/oslo-incubator: Change oslo.config to oslo_config https://review.openstack.org/145256 | 16:10 |
*** tsekiyama has joined #openstack-oslo | 16:13 | |
*** pblaho has joined #openstack-oslo | 16:15 | |
*** denis_makogon has quit IRC | 16:17 | |
*** mkoderer_cloud has quit IRC | 16:23 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Port zmq driver to Python 3 https://review.openstack.org/145241 | 16:29 |
*** e0ne is now known as e0ne_ | 16:31 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Ensure kombu channels are closed. https://review.openstack.org/145232 | 16:34 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Move files out of the namespace package https://review.openstack.org/144794 | 16:35 |
openstackgerrit | Merged openstack/taskflow: Remove need to inherit/adjust netutils split https://review.openstack.org/145087 | 16:39 |
openstackgerrit | Merged openstack/oslo.utils: Add method is_valid_port in netutils https://review.openstack.org/143617 | 16:40 |
*** pblaho_ has joined #openstack-oslo | 16:40 | |
*** pblaho has quit IRC | 16:40 | |
*** e0ne_ has quit IRC | 16:41 | |
bknudson | we have "from oslo import i18n" is that "import oslo_i18n as i18n" ? | 16:44 |
dhellmann | bknudson: yeah, did I miss that in the docs? | 16:45 |
bknudson | assuming I read docs! | 16:45 |
dhellmann | it looks like most of the usage instructions assume you import it as oslo_i18n, but if you want to alias it that should be fine | 16:46 |
bknudson | it just might be less change since we were using i18n before. | 16:47 |
dhellmann | makes sense | 16:47 |
bknudson | although I prefer not aliasing if I don't have to, so I'll probably switch them. | 16:47 |
*** pradk has joined #openstack-oslo | 16:48 | |
*** pblaho_ has quit IRC | 16:48 | |
*** pblaho_ has joined #openstack-oslo | 16:48 | |
openstackgerrit | Merged openstack/oslo.i18n: Fix the link to the bug tracker in the README https://review.openstack.org/145246 | 16:54 |
*** pblaho_ has quit IRC | 16:54 | |
*** yamahata has joined #openstack-oslo | 16:59 | |
therve | I'm getting an error when using oslo config generator and oslo.i18n messages: http://paste.openstack.org/show/155765/ | 17:04 |
therve | Has anyone seen that problem? The fix seems easy but I wonder why nobody saw it | 17:04 |
dims__ | therve: oslo.i18n was released this morning, i believe dhellmann has a review pending against heat already | 17:05 |
therve | dims__, Right that's another issue I believe | 17:05 |
dims__ | therve: ah ok | 17:05 |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module https://review.openstack.org/138215 | 17:05 |
dims__ | looking | 17:05 |
*** i159 has quit IRC | 17:06 | |
*** e0ne has joined #openstack-oslo | 17:07 | |
dims__ | therve: please do log a bug against oslo.i18n, let me try to recreate it | 17:07 |
dhellmann | therve: I hadn't seen that one because I didn't run that test | 17:07 |
dims__ | dhellmann: "tox -egenconfig" in heat | 17:07 |
therve | dhellmann, Yeah it's not a new problem AFAICT. | 17:07 |
therve | I just switched away from the incubator generator, and somehow discovered it | 17:08 |
therve | I thought maybe I was missing some oslo.i18n setup | 17:08 |
dhellmann | therve: is heat using translations for help text? | 17:08 |
dhellmann | what option is causing the problem? | 17:08 |
therve | dhellmann, We are apparently, yes | 17:09 |
dhellmann | therve: ok, that's unexpected :-) | 17:10 |
therve | dhellmann, That's what I was wondering too. Possibly unsupported? | 17:10 |
dhellmann | it's not bad, just not something I think we've seen so far | 17:10 |
dhellmann | we should support it, if it's not too bad | 17:10 |
dhellmann | the fix is probably to change the way we build the strings in the config generator | 17:11 |
therve | https://github.com/openstack/heat/blob/master/heat/common/config.py#L163 is the help | 17:11 |
therve | RIght | 17:11 |
therve | It's a one line diff IIUC | 17:11 |
dims__ | i think i know how to fix therve | 17:14 |
dims__ | give me a sec | 17:14 |
therve | dims__, https://bugs.launchpad.net/oslo.config/+bug/1408032 | 17:14 |
dims__ | therve: http://paste.openstack.org/show/155768/ | 17:16 |
therve | dims__, Yep that's my try as well :) | 17:16 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.middleware: Move files out of the namespace package https://review.openstack.org/145271 | 17:16 |
therve | Seems to make the tests fail though | 17:16 |
dims__ | y checking | 17:16 |
*** e0ne has quit IRC | 17:17 | |
*** e0ne has joined #openstack-oslo | 17:17 | |
*** e0ne has quit IRC | 17:17 | |
dhellmann | you might need to explicitly call oslo.i18n.translate() on opt.help | 17:17 |
therve | dims__, http://paste.openstack.org/show/155769/ :/ | 17:18 |
therve | dhellmann, Inside oslo.config itself you mean? | 17:19 |
dhellmann | therve: yes | 17:19 |
therve | Right. I wonder if the help is translable otherwise indeed. | 17:19 |
dhellmann | maybe not, though, Message.__unicode__ should work | 17:20 |
dhellmann | well, it'll come out with the default locale, which is probably what you want | 17:20 |
dims__ | we just need to fix the test | 17:20 |
dims__ | y | 17:20 |
*** bknudson has quit IRC | 17:21 | |
dhellmann | lunch time, bbiab | 17:22 |
*** noelbk has joined #openstack-oslo | 17:24 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True https://review.openstack.org/109373 | 17:28 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Add a info log when a reconnection occurs https://review.openstack.org/138411 | 17:28 |
dims__ | therve: funny construct gets past tests :) http://paste.openstack.org/show/155770/ | 17:31 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True https://review.openstack.org/109373 | 17:31 |
dims__ | trying something better :) | 17:31 |
therve | Yeah not pretty but works | 17:32 |
dims__ | let me file a review anyways! | 17:32 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.config: Support i18n messages in config generator https://review.openstack.org/145280 | 17:38 |
dims__ | dhellmann: therve: done - https://review.openstack.org/145280 | 17:38 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True https://review.openstack.org/109373 | 17:41 |
*** yassine has quit IRC | 17:45 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Declare DirectPublisher exchanges with passive=True https://review.openstack.org/109373 | 17:48 |
*** bknudson has joined #openstack-oslo | 17:48 | |
* bnemec thinks we need a moratorium on merging patches until the namespace changes merge | 17:50 | |
bnemec | Otherwise dhellmann is going to murder us all ;-) | 17:50 |
dims__ | LOL :) | 17:54 |
*** otherwiseguy has joined #openstack-oslo | 17:54 | |
*** e0ne has joined #openstack-oslo | 18:08 | |
sigmavirus24 | rebase rebase rebase rebase | 18:09 |
*** sdague has joined #openstack-oslo | 18:11 | |
sdague | question about logging, are there any thoughts in making debug logging have a frame reference so that pathname might be more meaninful? | 18:11 |
sdague | for instance - http://logs.openstack.org/70/144070/6/gate/gate-tempest-dsvm-neutron-full/56b1168/logs/screen-n-cpu.txt.gz#_2015-01-06_14_16_12_526 | 18:12 |
sdague | knowing that lock function is in lockutils.py isn't exceptionally useful for knowing what's going on | 18:12 |
*** yamahata has quit IRC | 18:18 | |
*** e0ne has quit IRC | 18:21 | |
*** noelbk has quit IRC | 18:22 | |
dhellmann | bnemec: too true ;-) | 18:28 |
dhellmann | dims__: do we have a test that passes a Message object as the help text? | 18:30 |
*** dtantsur is now known as dtantsur|afk | 18:31 | |
dhellmann | sdague: I'm not clear about what you're asking. Are you suggesting we make it possible to pass a frame reference in to the lock calls, or that we do something with logging? Or that we have the lock calls figure out their caller and log that automatically? | 18:33 |
*** yamahata has joined #openstack-oslo | 18:37 | |
dims__ | dhellmann: oslo.config does not depend on oslo.i18n currently | 18:37 |
dhellmann | dims__: ok, we should add it as a test requirement so we can have an explicit test for this new case | 18:37 |
dims__ | ack, will do | 18:38 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.middleware: Move files out of the namespace package https://review.openstack.org/145271 | 18:55 |
*** bknudson has quit IRC | 19:06 | |
*** yamahata has quit IRC | 19:14 | |
*** e0ne has joined #openstack-oslo | 19:18 | |
*** e0ne is now known as e0ne_ | 19:19 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Update comment to match implementation https://review.openstack.org/145307 | 19:21 |
*** yamahata has joined #openstack-oslo | 19:21 | |
*** yamahata has quit IRC | 19:26 | |
*** rpodolyaka2 has joined #openstack-oslo | 19:28 | |
*** e0ne_ has quit IRC | 19:28 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Update comment to match implementation https://review.openstack.org/145307 | 19:29 |
*** e0ne has joined #openstack-oslo | 19:34 | |
*** ihrachyshka has quit IRC | 19:35 | |
*** david-lyle_afk is now known as david-lyle | 19:39 | |
openstackgerrit | Merged openstack/oslo.log: Correct the position of the syslog handler https://review.openstack.org/138971 | 19:41 |
*** dims__ has quit IRC | 19:45 | |
*** dims__ has joined #openstack-oslo | 19:46 | |
*** rpodolyaka2 has quit IRC | 19:47 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Add API documentation https://review.openstack.org/145318 | 19:48 |
*** dims__ has quit IRC | 19:49 | |
*** dims__ has joined #openstack-oslo | 19:49 | |
openstackgerrit | Merged openstack/oslo.log: Implement resource to logging extra keywords https://review.openstack.org/144813 | 19:53 |
*** mfedosin has joined #openstack-oslo | 20:01 | |
*** rpodolyaka2 has joined #openstack-oslo | 20:02 | |
*** bknudson has joined #openstack-oslo | 20:10 | |
boris-42 | dhellmann: hey there | 20:23 |
boris-42 | dhellmann: did you see https://review.openstack.org/#/c/145214/ ? this should fix rally tests | 20:23 |
dhellmann | boris-42: so the problem had to do with the way rally was registering and unregistering options? | 20:25 |
mfedosin | boris-42, dhellmann hi! | 20:26 |
mfedosin | dhellmann, yes | 20:26 |
mfedosin | it's here https://github.com/stackforge/rally/blob/master/tests/unit/cmd/test_cliutils.py#L120. I thought that we need to pass exactly the same opt object that we used to register an option | 20:29 |
dhellmann | mfedosin: you could also create a separate ConfigOpts instance though, right? | 20:30 |
mfedosin | but basically it's not. in rally there a new object with the same name and destination that passed to unregister method | 20:31 |
dhellmann | I'm trying to understand how this hasn't come up before, and if this unregistration logic is just fundamentally broken somehow | 20:31 |
dhellmann | mfedosin: why is it a new object, though? what prevents you from keeping the one that was originally registered? | 20:31 |
mfedosin | dhellmann, i don't know, you better ask Boris why they create a new object | 20:33 |
mfedosin | but before oslo config requires only an object with 'dest' field to unregister | 20:34 |
mfedosin | https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1891 | 20:34 |
dhellmann | yeah, ok, I'm just trying to understand why the use in rally is the only place this comes up and whether the issue is there or in oslo.config | 20:35 |
mfedosin | as for me I think it's more correct to pass registered opt object there, so I did in my commit | 20:37 |
mfedosin | or if we want to unregister opt by destination then just pass a string value there | 20:38 |
mfedosin | rather than artificially created object | 20:39 |
*** rpodolyaka2 has quit IRC | 20:40 | |
*** andreykurilin has joined #openstack-oslo | 20:43 | |
*** pcaruana is now known as pcaruana|afk| | 20:45 | |
dhellmann | right | 20:50 |
dhellmann | mfedosin: +2 on https://review.openstack.org/#/c/145214/ to restore the old behavior | 20:52 |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Add pretty_tox wrapper script https://review.openstack.org/145334 | 20:53 |
openstackgerrit | Merged openstack/oslo.messaging: Add an optional executor callback to dispatcher https://review.openstack.org/136652 | 20:54 |
*** harlowja_at_home has joined #openstack-oslo | 20:59 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Move files out of the namespace package https://review.openstack.org/145058 | 21:02 |
mfedosin | dhellmann, thanks! | 21:03 |
mfedosin | dhellmann, another solution is we can change https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1891 by adding another condition like: elif opt.dest in self._opts and self._opts[opt.dest] is opt: | 21:07 |
mfedosin | and then rally team will have to make changes in their code to comply with it. | 21:08 |
mfedosin | also I suggest to make first (opt) parameter looks like the second (:param group: an optional OptGroup object or group name), so it could be Opt object or just name. And if it's a string then we call _do_get method to get the desired object and the unregister it. | 21:08 |
mfedosin | This solution is more correct, but it breaks backward compatibility and many (read Boris) will be dissatisfied. | 21:09 |
mfedosin | but they just need to change https://github.com/stackforge/rally/blob/master/tests/unit/cmd/test_cliutils.py#L120 from CONF.unregister_opt(category_opt) to CONF.unregister_opt('category') | 21:11 |
mfedosin | what do you think? | 21:11 |
*** tsekiyama has quit IRC | 21:12 | |
*** amrith is now known as _amrith_ | 21:15 | |
*** tsekiyama has joined #openstack-oslo | 21:15 | |
harlowja_at_home | dhellmann, do u need me to release taskflow for the oslo.utils stuffs? | 21:17 |
dhellmann | harlowja_at_home: yeah, if you could | 21:19 |
harlowja_at_home | kk | 21:19 |
harlowja_at_home | will jump over to laptop in a bit and do that | 21:20 |
*** russellb has joined #openstack-oslo | 21:27 | |
*** arnaud__ has quit IRC | 21:30 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Add pretty_tox wrapper script https://review.openstack.org/145334 | 21:38 |
*** ajo has joined #openstack-oslo | 21:49 | |
*** e0ne has quit IRC | 22:02 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Move files out of the namespace package https://review.openstack.org/145058 | 22:19 |
*** kgiusti has quit IRC | 22:25 | |
*** dims_ has joined #openstack-oslo | 22:28 | |
*** mfedosin has quit IRC | 22:29 | |
*** gordc has quit IRC | 22:29 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.i18n: Add a fixture to let tests manage the lazy flag https://review.openstack.org/145364 | 22:30 |
dhellmann | dims_: I think that was the fastest review I've seen in a while :-) | 22:32 |
openstackgerrit | Merged openstack/oslo.middleware: Move files out of the namespace package https://review.openstack.org/145271 | 22:32 |
dims_ | :) | 22:32 |
*** dims__ has quit IRC | 22:32 | |
dims_ | dhellmann: may take that back if pep8 fails because of the last line in the file | 22:34 |
dims_ | shows up red - https://review.openstack.org/#/c/145364/1/oslo_i18n/tests/test_fixture.py,unified | 22:34 |
dhellmann | dims_: bah | 22:35 |
dims_ | wanna fix it? | 22:36 |
dhellmann | yeah, doing that now | 22:36 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.i18n: Add a fixture to let tests manage the lazy flag https://review.openstack.org/145364 | 22:37 |
dims_ | ah! James beat me to it, so i have to wait for the jobs and then +2/+A :) | 22:39 |
dhellmann | dims_: :-) | 22:50 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements https://review.openstack.org/144786 | 22:52 |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Add pretty_tox wrapper script https://review.openstack.org/145334 | 22:57 |
openstackgerrit | Merged openstack/oslo.concurrency: Add a reader/writer lock https://review.openstack.org/138217 | 22:59 |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:01 | |
*** bknudson has quit IRC | 23:02 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack-dev/pbr: Add pointers to various resources https://review.openstack.org/144838 | 23:03 |
*** alexpilotti has quit IRC | 23:12 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack-dev/pbr: Add pointers to various resources https://review.openstack.org/144838 | 23:14 |
*** jgrimm is now known as zz_jgrimm | 23:18 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.i18n: Improve fixture documentation https://review.openstack.org/145375 | 23:18 |
*** ajo has quit IRC | 23:20 | |
*** stevemar has quit IRC | 23:20 | |
*** miqui has quit IRC | 23:20 | |
*** rharwood has quit IRC | 23:21 | |
*** shardy has quit IRC | 23:21 | |
*** andreykurilin1 has quit IRC | 23:21 | |
*** isq has quit IRC | 23:21 | |
*** git-harry has quit IRC | 23:21 | |
*** tsufiev has quit IRC | 23:21 | |
*** frickler has quit IRC | 23:21 | |
*** dstanek has quit IRC | 23:21 | |
*** mtanino has quit IRC | 23:21 | |
*** bnemec has quit IRC | 23:21 | |
*** krotscheck has quit IRC | 23:21 | |
*** burgobianco has quit IRC | 23:21 | |
*** redrobot has quit IRC | 23:21 | |
*** SergeyLukjanov has quit IRC | 23:21 | |
*** therve has quit IRC | 23:21 | |
*** ekarlso- has quit IRC | 23:21 | |
*** cburgess_ has quit IRC | 23:21 | |
*** jogo has quit IRC | 23:21 | |
*** blogan has quit IRC | 23:21 | |
*** git-harry has joined #openstack-oslo | 23:21 | |
*** ajo has joined #openstack-oslo | 23:21 | |
*** stevemar has joined #openstack-oslo | 23:21 | |
*** tsufiev has joined #openstack-oslo | 23:21 | |
*** andreykurilin1 has joined #openstack-oslo | 23:22 | |
*** mriedem has quit IRC | 23:22 | |
*** mtanino has joined #openstack-oslo | 23:22 | |
*** bnemec has joined #openstack-oslo | 23:22 | |
*** krotscheck has joined #openstack-oslo | 23:22 | |
*** burgobianco has joined #openstack-oslo | 23:22 | |
*** redrobot has joined #openstack-oslo | 23:22 | |
*** SergeyLukjanov has joined #openstack-oslo | 23:22 | |
*** therve has joined #openstack-oslo | 23:22 | |
*** ekarlso- has joined #openstack-oslo | 23:22 | |
*** cburgess_ has joined #openstack-oslo | 23:22 | |
*** blogan has joined #openstack-oslo | 23:22 | |
*** jogo has joined #openstack-oslo | 23:22 | |
*** rharwood has joined #openstack-oslo | 23:23 | |
*** boris-42 has quit IRC | 23:24 | |
*** burgobianco has quit IRC | 23:24 | |
*** miqui has joined #openstack-oslo | 23:25 | |
*** frickler has joined #openstack-oslo | 23:26 | |
*** burgobianco has joined #openstack-oslo | 23:26 | |
*** boris-42 has joined #openstack-oslo | 23:26 | |
*** zz_jgrimm has quit IRC | 23:26 | |
*** zz_jgrimm has joined #openstack-oslo | 23:29 | |
*** jecarey has quit IRC | 23:33 | |
*** pradk has quit IRC | 23:38 | |
openstackgerrit | Merged openstack/oslo.utils: Move files out of the namespace package https://review.openstack.org/145058 | 23:45 |
harlowja_at_home | dhellmann, http://lists.openstack.org/pipermail/openstack-dev/2015-January/053871.html | 23:45 |
harlowja_at_home | all should be good i think | 23:45 |
*** dims_ has quit IRC | 23:48 | |
*** dims__ has joined #openstack-oslo | 23:53 | |
*** dstanek has joined #openstack-oslo | 23:55 | |
*** shardy has joined #openstack-oslo | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!