*** raildo has quit IRC | 00:00 | |
*** tsekiyam_ has joined #openstack-oslo | 00:02 | |
openstackgerrit | Merged openstack/tooz: Upgrade to hacking 0.10 https://review.openstack.org/146893 | 00:06 |
---|---|---|
dims__ | ihrachyshka: do you want to throw in sql style comments in that test as well? | 00:08 |
*** tsekiyama has quit IRC | 00:09 | |
*** shardy has quit IRC | 00:09 | |
*** rpodolyaka1 has quit IRC | 00:09 | |
*** dstanek has quit IRC | 00:09 | |
*** dstanek has joined #openstack-oslo | 00:09 | |
*** rpodolyaka1 has joined #openstack-oslo | 00:09 | |
ihrachyshka | dims__, you mean #/--? | 00:09 |
dims__ | ihrachyshka: y | 00:09 |
ihrachyshka | ok, I'll add them. though I need to check that they fail otherwise. | 00:10 |
dims__ | sounds good | 00:10 |
*** jraim has joined #openstack-oslo | 00:10 | |
*** shardy has joined #openstack-oslo | 00:11 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/145891 | 00:13 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/141509 | 00:13 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements https://review.openstack.org/144786 | 00:16 |
*** stevemar has joined #openstack-oslo | 00:17 | |
*** tsekiyama has joined #openstack-oslo | 00:19 | |
*** tsekiyam_ has quit IRC | 00:21 | |
*** tsekiyama has quit IRC | 00:23 | |
mriedem | was just going to pull that down and play with it | 00:26 |
mriedem | for nova and glance unit tests | 00:26 |
mriedem | ihrachyshka: dims__: ^ | 00:27 |
*** stevemar has quit IRC | 00:27 | |
openstackgerrit | Csaba Henk proposed openstack/oslo.concurrency: processutils: execute(): fix option incompatibility https://review.openstack.org/147033 | 00:27 |
*** david-lyle has joined #openstack-oslo | 00:28 | |
ihrachyshka | mriedem, I've checked on glance only for now (it's 01:24 here) | 00:30 |
ihrachyshka | mriedem, if you have time for nova check, please do so | 00:30 |
ihrachyshka | dims__, -- comments are parsed out correctly, though for # comments, not the case (I suspect sqlparse module we use to parse SQL does not know about those). | 00:31 |
ihrachyshka | no idea whether it worked before when we executed single statement though. I will check it. | 00:31 |
mriedem | ihrachyshka: you should be sleeping if it's 1:30am :) | 00:35 |
ihrachyshka | mriedem, no way, "someone" proposed to revert mah patches | 00:36 |
*** achanda has quit IRC | 00:39 | |
ihrachyshka | dims__, ok, so it didn't work correct with # before too, so not an issue :) | 00:42 |
openstackgerrit | Merged openstack/oslo.concurrency: Revert "Port processutils to Python 3" https://review.openstack.org/146940 | 00:43 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove 'SaveOrderTask' and test state in class variables (WIP) https://review.openstack.org/147038 | 00:44 |
*** achanda has joined #openstack-oslo | 00:46 | |
*** vipul has joined #openstack-oslo | 00:47 | |
*** zhiyan has joined #openstack-oslo | 00:48 | |
vipul | what's the state of oslo.context? any projects using it? | 00:48 |
vipul | also looks like it's a little behind in terms of renaming things like tenant -> project | 00:48 |
*** rossella_s has quit IRC | 00:52 | |
*** jraim has quit IRC | 00:54 | |
*** dougwig has quit IRC | 00:54 | |
*** rossella_s has joined #openstack-oslo | 00:54 | |
ihrachyshka | vipul, at least neutron now consumes it | 00:55 |
*** david-lyle has quit IRC | 00:58 | |
*** dougwig has joined #openstack-oslo | 00:58 | |
*** david-lyle has joined #openstack-oslo | 00:58 | |
*** jraim has joined #openstack-oslo | 01:00 | |
*** david-lyle has quit IRC | 01:05 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 01:05 | |
dims__ | ihrachyshka: +1 to mriedem. get some sleep :) | 01:06 |
*** rossella_s has quit IRC | 01:07 | |
ihrachyshka | ack guys, as you said; bye :) | 01:07 |
*** ihrachyshka has quit IRC | 01:07 | |
*** rossella_s has joined #openstack-oslo | 01:08 | |
*** david-lyle has joined #openstack-oslo | 01:09 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 01:11 | |
*** jraim has quit IRC | 01:13 | |
openstackgerrit | xhzhf proposed openstack/oslo.vmware: oslo.vmware: __getattr__ throw exception insteading returning none https://review.openstack.org/147044 | 01:13 |
openstackgerrit | xhzhf proposed openstack/oslo.vmware: oslo.vmware: getattr throw exception insteading returning none https://review.openstack.org/147044 | 01:15 |
*** jraim has joined #openstack-oslo | 01:19 | |
*** sabari is now known as zz_sabari | 01:21 | |
*** achanda has quit IRC | 01:23 | |
*** david-lyle has quit IRC | 01:24 | |
*** david-lyle has joined #openstack-oslo | 01:29 | |
*** zzzeek has quit IRC | 01:31 | |
*** david-lyle has quit IRC | 01:35 | |
*** salv-orlando has quit IRC | 01:41 | |
*** david-lyle has joined #openstack-oslo | 01:52 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 01:53 | |
*** rossella_s has quit IRC | 01:53 | |
*** rossella_s has joined #openstack-oslo | 01:56 | |
*** david-lyle has quit IRC | 01:59 | |
*** salv-orlando has joined #openstack-oslo | 02:00 | |
*** amrith is now known as _amrith_ | 02:02 | |
*** dims__ has quit IRC | 02:02 | |
*** dims__ has joined #openstack-oslo | 02:03 | |
*** zhiyan has quit IRC | 02:05 | |
*** zhiyan has joined #openstack-oslo | 02:06 | |
*** dims__ has quit IRC | 02:07 | |
*** vishy has quit IRC | 02:11 | |
*** vishy has joined #openstack-oslo | 02:15 | |
*** salv-orlando has quit IRC | 02:19 | |
*** mriedem1 has joined #openstack-oslo | 02:20 | |
*** mriedem has quit IRC | 02:22 | |
*** zz_sabari is now known as sabari | 02:23 | |
*** mtanino has quit IRC | 02:25 | |
*** yamahata has quit IRC | 02:31 | |
*** david-lyle has joined #openstack-oslo | 02:40 | |
*** stevemar has joined #openstack-oslo | 02:46 | |
*** harlowja is now known as harlowja_away | 02:46 | |
*** lbragstad has quit IRC | 02:47 | |
*** russellb has quit IRC | 02:47 | |
*** otherwiseguy has quit IRC | 02:48 | |
*** zhiyan has quit IRC | 02:55 | |
*** lbragstad has joined #openstack-oslo | 02:55 | |
*** zhiyan has joined #openstack-oslo | 02:57 | |
*** jroll has quit IRC | 03:00 | |
*** russellb has joined #openstack-oslo | 03:02 | |
*** lbragstad has quit IRC | 03:08 | |
*** lbragstad has joined #openstack-oslo | 03:10 | |
*** jroll has joined #openstack-oslo | 03:10 | |
*** russellb has quit IRC | 03:15 | |
*** otherwiseguy has joined #openstack-oslo | 03:17 | |
*** jraim has quit IRC | 03:18 | |
*** jraim has joined #openstack-oslo | 03:20 | |
*** yamahata has joined #openstack-oslo | 03:24 | |
*** david-lyle has quit IRC | 03:25 | |
*** russellb has joined #openstack-oslo | 03:25 | |
*** jroll has quit IRC | 03:26 | |
*** miqui has joined #openstack-oslo | 03:29 | |
*** jroll has joined #openstack-oslo | 03:32 | |
*** russellb has quit IRC | 03:38 | |
*** lbragstad has quit IRC | 03:38 | |
*** russellb has joined #openstack-oslo | 03:39 | |
*** rossella_s has quit IRC | 03:40 | |
*** salv-orlando has joined #openstack-oslo | 03:43 | |
*** rossella_s has joined #openstack-oslo | 03:43 | |
*** jraim has quit IRC | 03:45 | |
*** jraim has joined #openstack-oslo | 03:47 | |
*** lbragstad has joined #openstack-oslo | 03:47 | |
jogo | any new osll libs in the past few hours? | 03:48 |
jogo | https://bugs.launchpad.net/nova/+bug/1410626 | 03:49 |
jogo | I wonder if oslo is hiding an import error | 03:51 |
*** amotoki has joined #openstack-oslo | 03:53 | |
*** sabari is now known as zz_sabari | 03:54 | |
*** lbragstad has quit IRC | 04:00 | |
*** rossella_s has quit IRC | 04:00 | |
*** lbragstad has joined #openstack-oslo | 04:02 | |
*** salv-orlando has quit IRC | 04:02 | |
*** mriedem1 has left #openstack-oslo | 04:03 | |
*** rossella_s has joined #openstack-oslo | 04:07 | |
sigmavirus24 | jogo: last few hours? no, but in the past day I think oslo.db and oslo.concurrency have seen releases | 04:09 |
jogo | it was eventlet :) | 04:10 |
sigmavirus24 | ah | 04:10 |
* sigmavirus24 just noticed your question | 04:10 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 04:11 | |
*** rushiagr_away is now known as rushiagr | 04:12 | |
*** rossella_s has quit IRC | 04:34 | |
*** salv-orlando has joined #openstack-oslo | 04:35 | |
*** rossella_s has joined #openstack-oslo | 04:38 | |
*** yamahata has quit IRC | 04:38 | |
*** yamahata has joined #openstack-oslo | 04:39 | |
*** salv-orlando has quit IRC | 04:39 | |
*** dims__ has joined #openstack-oslo | 04:52 | |
*** dims__ has quit IRC | 04:57 | |
*** vishy has quit IRC | 04:57 | |
*** jamespage has quit IRC | 05:00 | |
*** vishy has joined #openstack-oslo | 05:02 | |
*** rossella_s has quit IRC | 05:12 | |
*** otherwiseguy has quit IRC | 05:12 | |
*** otherwiseguy has joined #openstack-oslo | 05:16 | |
*** rossella_s has joined #openstack-oslo | 05:16 | |
*** zigo has quit IRC | 05:20 | |
*** zigo has joined #openstack-oslo | 05:21 | |
*** rossella_s has quit IRC | 05:36 | |
*** rossella_s has joined #openstack-oslo | 05:36 | |
*** russellb has quit IRC | 05:49 | |
*** achanda has joined #openstack-oslo | 05:49 | |
*** russellb has joined #openstack-oslo | 05:49 | |
*** vigneshvar has joined #openstack-oslo | 05:50 | |
*** lbragstad has quit IRC | 05:52 | |
*** subscope_ has joined #openstack-oslo | 05:52 | |
*** otherwiseguy has quit IRC | 05:53 | |
*** otherwiseguy has joined #openstack-oslo | 05:54 | |
*** lbragstad has joined #openstack-oslo | 05:55 | |
*** rpodolyaka2 has joined #openstack-oslo | 06:02 | |
*** rpodolyaka2 has quit IRC | 06:07 | |
*** rpodolyaka2 has joined #openstack-oslo | 06:07 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/143256 | 06:11 |
*** achanda has quit IRC | 06:11 | |
*** salv-orlando has joined #openstack-oslo | 06:26 | |
*** inc0 has joined #openstack-oslo | 06:28 | |
*** subscope_ has quit IRC | 06:45 | |
*** salv-orlando has quit IRC | 06:46 | |
*** stevemar has quit IRC | 06:47 | |
*** salv-orlando has joined #openstack-oslo | 06:51 | |
*** salv-orlando has quit IRC | 06:52 | |
*** ajo has joined #openstack-oslo | 07:04 | |
*** zhiyan has quit IRC | 07:08 | |
*** rpodolyaka2 has quit IRC | 07:10 | |
*** zhiyan has joined #openstack-oslo | 07:11 | |
*** otherwiseguy has quit IRC | 07:14 | |
*** otherwiseguy has joined #openstack-oslo | 07:17 | |
*** rpodolyaka2 has joined #openstack-oslo | 07:25 | |
*** yamahata has quit IRC | 07:29 | |
*** otherwiseguy has quit IRC | 07:34 | |
*** oomichi_ has quit IRC | 07:37 | |
*** russellb has quit IRC | 07:37 | |
*** salv-orlando has joined #openstack-oslo | 07:38 | |
*** salv-orlando has quit IRC | 07:39 | |
*** russellb has joined #openstack-oslo | 07:40 | |
*** otherwiseguy has joined #openstack-oslo | 07:45 | |
*** jaosorior has joined #openstack-oslo | 08:03 | |
*** dulek has joined #openstack-oslo | 08:05 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Upgrade to hacking 0.10 https://review.openstack.org/141018 | 08:05 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Deprecates the localcontext API https://review.openstack.org/147086 | 08:14 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: [TEST] https://review.openstack.org/145798 | 08:18 |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Deprecates the localcontext API https://review.openstack.org/140616 | 08:20 |
*** lbragstad has quit IRC | 08:24 | |
*** dtantsur|afk is now known as dtantsur | 08:30 | |
*** russellb has quit IRC | 08:30 | |
*** lbragstad has joined #openstack-oslo | 08:34 | |
*** jaosorior has quit IRC | 08:36 | |
*** otherwiseguy has quit IRC | 08:36 | |
*** jaosorior has joined #openstack-oslo | 08:38 | |
*** russellb has joined #openstack-oslo | 08:39 | |
*** otherwiseguy has joined #openstack-oslo | 08:39 | |
*** jamespage has joined #openstack-oslo | 08:40 | |
openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: Deprecates the localcontext API https://review.openstack.org/140616 | 08:42 |
*** salv-orlando has joined #openstack-oslo | 08:57 | |
*** i159 has joined #openstack-oslo | 08:57 | |
*** jaosorior has quit IRC | 08:58 | |
*** jaosorior has joined #openstack-oslo | 08:59 | |
*** salv-orlando has quit IRC | 09:11 | |
*** jeckersb is now known as jeckersb_gone | 09:18 | |
*** dims__ has joined #openstack-oslo | 09:31 | |
*** dims__ has quit IRC | 09:36 | |
haypo | hi | 09:38 |
*** rpodolyaka2 has quit IRC | 09:49 | |
*** salv-orlando has joined #openstack-oslo | 09:51 | |
openstackgerrit | Rossella Sblendido proposed openstack/oslo.db: Retry query if db deadlock error is received https://review.openstack.org/109549 | 09:56 |
*** vishy has quit IRC | 09:59 | |
*** e0ne has joined #openstack-oslo | 10:00 | |
*** rpodolyaka2 has joined #openstack-oslo | 10:00 | |
*** ihrachyshka has joined #openstack-oslo | 10:01 | |
*** otherwiseguy has quit IRC | 10:03 | |
*** dulek has quit IRC | 10:04 | |
*** otherwiseguy has joined #openstack-oslo | 10:05 | |
*** vishy has joined #openstack-oslo | 10:10 | |
*** dulek has joined #openstack-oslo | 10:10 | |
*** pblaho has joined #openstack-oslo | 10:10 | |
*** vishy has quit IRC | 10:21 | |
*** russellb has quit IRC | 10:22 | |
*** russellb has joined #openstack-oslo | 10:26 | |
openstackgerrit | Merged openstack/oslo-incubator: Update run_cross_test.sh to pass extra args to tox https://review.openstack.org/147009 | 10:28 |
*** e0ne is now known as e0ne_ | 10:31 | |
haypo | https://review.openstack.org/#/c/146872/ fails to be merged because DSVM tests are randomly failing | 10:31 |
openstackgerrit | Merged openstack/oslo-incubator: Ignore errors uninstalling lib in run_cross_test.sh https://review.openstack.org/147016 | 10:32 |
haypo | "reverify no bug" was tried 3 times. should i try one more time? or something else should be done? | 10:32 |
sileht | haypo, seems to be the eventlet.util issue | 10:33 |
*** vishy has joined #openstack-oslo | 10:33 | |
haypo | oh ok, so it's better to wait until the eventlet issue is fixed | 10:34 |
sileht | I haven't follow how this will resolve, but I wonder why the requirement have not been changed yet (with !=0.16 | 10:35 |
sileht | ) | 10:36 |
haypo | https://review.openstack.org/#/c/145955/ was not accepted yet (eventlet fix for juno) | 10:36 |
haypo | sileht: i was decided to fix nova, not to block eventlet | 10:36 |
haypo | sileht: there are pending reviews to fix the issue... | 10:36 |
haypo | i wrote the fix for master, the voted +1 for the backport on juno | 10:36 |
haypo | claudiu belu voted -2 for the fix on icehouse because he wants first to see the juno fix merged... https://review.openstack.org/#/c/146096/ | 10:37 |
sileht | ok cool, we just have to wait | 10:37 |
haypo | sileht: no, nova core dev have to vote. no change was accepted yet for icehouse or juno | 10:38 |
haypo | as usual, it takes time to review nova patches :-p | 10:40 |
*** dims__ has joined #openstack-oslo | 10:41 | |
*** e0ne_ has quit IRC | 10:42 | |
*** e0ne has joined #openstack-oslo | 10:57 | |
*** dims__ has quit IRC | 11:00 | |
*** russellb has quit IRC | 11:00 | |
*** dims__ has joined #openstack-oslo | 11:00 | |
*** dims__ has quit IRC | 11:05 | |
*** russellb has joined #openstack-oslo | 11:06 | |
*** alexpilotti has joined #openstack-oslo | 11:07 | |
openstackgerrit | Julien Danjou proposed openstack/tooz: Add a file based driver https://review.openstack.org/146507 | 11:09 |
*** takedakn has joined #openstack-oslo | 11:18 | |
*** e0ne_ has joined #openstack-oslo | 11:23 | |
*** takedakn has quit IRC | 11:24 | |
*** e0ne has quit IRC | 11:26 | |
*** dims__ has joined #openstack-oslo | 11:44 | |
openstackgerrit | Visnusaran Murugan proposed openstack/oslo.utils: context-manager to trap, log and ignore exception https://review.openstack.org/131068 | 11:52 |
*** rushiagr is now known as rushiagr_away | 11:53 | |
*** e0ne_ has quit IRC | 11:55 | |
*** e0ne has joined #openstack-oslo | 11:58 | |
*** takedakn has joined #openstack-oslo | 12:05 | |
*** _amrith_ is now known as amrith | 12:07 | |
*** takedakn has quit IRC | 12:11 | |
*** miarmak has joined #openstack-oslo | 12:16 | |
*** rushiagr_away is now known as rushiagr | 12:31 | |
*** isviridov_away is now known as isviridov | 12:32 | |
*** denis_makogon has joined #openstack-oslo | 12:55 | |
*** msdubov_ has joined #openstack-oslo | 12:55 | |
msdubov_ | dhellmann Hi! | 12:55 |
*** boris-42 has joined #openstack-oslo | 12:56 | |
*** e0ne has quit IRC | 12:56 | |
*** e0ne has joined #openstack-oslo | 12:57 | |
*** amotoki_ has joined #openstack-oslo | 13:07 | |
*** takedakn has joined #openstack-oslo | 13:11 | |
*** takedakn has quit IRC | 13:12 | |
*** takedakn has joined #openstack-oslo | 13:12 | |
*** e0ne is now known as e0ne_ | 13:14 | |
*** takedakn has quit IRC | 13:19 | |
*** yassine has joined #openstack-oslo | 13:20 | |
*** takedakn has joined #openstack-oslo | 13:20 | |
*** e0ne_ is now known as e0ne | 13:23 | |
*** amrith is now known as _amrith_ | 13:30 | |
*** takedakn has quit IRC | 13:34 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:50 | |
*** kgiusti has joined #openstack-oslo | 13:51 | |
*** gordc has joined #openstack-oslo | 13:54 | |
*** takedakn has joined #openstack-oslo | 13:55 | |
*** inc0_ has joined #openstack-oslo | 14:01 | |
*** inc0 has quit IRC | 14:03 | |
*** inc0_ has quit IRC | 14:05 | |
*** vigneshvar has quit IRC | 14:16 | |
*** takedakn has quit IRC | 14:19 | |
*** zzzeek has joined #openstack-oslo | 14:21 | |
*** msdubov_ has quit IRC | 14:21 | |
dhellmann | sileht, haypo : can you give me more background on the "eventlet.util" issue that is blocking the heat test driver fix in https://review.openstack.org/#/c/146872/ ? | 14:22 |
viktors | zzzeek: hi! | 14:22 |
zzzeek | viktors: hey | 14:22 |
haypo | dhellmann: the module was deprecated, it was removed in eventlet 0.16 | 14:23 |
viktors | zzzeek: as for wiki page `PyMySQL evaluation` - should I inform you about some additions or edit this page directly? | 14:23 |
haypo | dhellmann: i proposed a fix for nova master which was merged | 14:23 |
dhellmann | oh, and now we need it backported? | 14:24 |
haypo | dhellmann: the backport for juno is under review (one +2), the backport for icehouse is blocked because someone is waiting until the juno change is merged | 14:24 |
zzzeek | viktors: edit directly :) | 14:24 |
haypo | https://review.openstack.org/146096 (icehouse) | 14:24 |
haypo | https://review.openstack.org/145955 (juno) | 14:24 |
dhellmann | haypo: the juno change failed jenkins | 14:25 |
dhellmann | and there's a comment from ihrachyshka about capping eventlet | 14:25 |
dhellmann | haypo: both cap changes have been approved in requirements, so I guess we're waiting for them to merge? | 14:26 |
ihrachyshka | dhellmann, heat failure is expected to be fixed now | 14:26 |
haypo | dhellmann: i checked this morning, the juno patch failed because of boto failures | 14:26 |
ihrachyshka | dhellmann, I mean, the whole master should be unblocked | 14:26 |
viktors | zzzeek: I have some notes as for MySQLdb patching mostly. Should we add something specific there? | 14:26 |
haypo | i read "recheck boto" | 14:26 |
zzzeek | viktors: shurgs | 14:26 |
ihrachyshka | dhellmann, cap fix was merged for juno already | 14:26 |
dhellmann | ihrachyshka: you'll be broken again if we release oslo.messaging without the patch I mentioned | 14:26 |
haypo | sorry, i saw a comment "recheck boto" | 14:26 |
viktors | zzzeek: ok :) | 14:26 |
*** takedakn has joined #openstack-oslo | 14:26 | |
dhellmann | I think we're waiting for the icehouse patch : https://review.openstack.org/#/c/147063/ | 14:27 |
ihrachyshka | dhellmann, which patch? | 14:27 |
dhellmann | ihrachyshka: https://review.openstack.org/#/c/146872/ | 14:27 |
*** _amrith_ is now known as amrith | 14:28 | |
ihrachyshka | dhellmann, ack. so yeah, in case of oslo.messaging, we test it against icehouse directly, so we need cap there too to pass | 14:28 |
ihrachyshka | dhellmann, I thought you meant grenade issue | 14:28 |
ihrachyshka | too many gate failures recently :( | 14:29 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Sync latest run_cross_tests.sh https://review.openstack.org/147177 | 14:29 |
sileht | dhellmann, haypo finally sdague will cap the version: https://review.openstack.org/#/c/147062/ | 14:29 |
sileht | (for icehouse/juno) | 14:29 |
sileht | icehouse: https://review.openstack.org/#/c/147063/ | 14:29 |
* sileht too late | 14:30 | |
ihrachyshka | :) | 14:30 |
dhellmann | sileht: right, I think we're just waiting for the second one to merge | 14:30 |
dhellmann | sileht, ihrachyshka, haypo : merged | 14:32 |
*** yamahata has joined #openstack-oslo | 14:32 | |
ihrachyshka | nice | 14:32 |
haypo | dhellmann: cool. will it take time until the changes land on all gates? | 14:32 |
ihrachyshka | haypo, should be immediate for new rechecks | 14:32 |
dhellmann | haypo: no, they should be updated the next time a job runs | 14:33 |
haypo | dhellmann: for oslo.concurrency, we will probably have less issue if we never decode the output (stdout/stderr) on Python 2 | 14:34 |
haypo | dhellmann: that's why i proposed a change to only decode output on Python 3 | 14:34 |
haypo | dhellmann: it means that we should do something around mask_password() to *not* try to decode output on python 2 if output types is bytes | 14:35 |
dhellmann | haypo: if the python 3 version decodes by default, that will still break cases where the output is binary | 14:35 |
sdague | haypo: like dhellmann said, this issue came from using openssl in pipe to create encrypted content | 14:36 |
dhellmann | haypo: I haven't had a chance to look at your new patch, yet, so let me comment more there | 14:36 |
haypo | dhellmann: for cases like openssl generating pure binary data, it would be nice to have an option to explicitly request binary | 14:36 |
haypo | dhellmann: in this case, mask_password() would not be called, even on error | 14:36 |
haypo | sdague: i saw your patch using a temporary file to not write binary to stdout. well, it works, but we should maybe support this usecase | 14:36 |
dhellmann | haypo: yes, we may need to provide separate functions for those 2 cases | 14:36 |
haypo | dhellmann: there are different incompatible needs: support python 3 and support binary output :-) | 14:37 |
sdague | haypo: the rest of the nova team didn't want that though, because it has security implications of content on disk that shouldn't need to be | 14:37 |
dhellmann | haypo: the most important requirement is to not make the new default behavior of the existing function break. Moving an app to python 3 may require updating calls to use a new function. | 14:38 |
haypo | sdague: agreed. it's better to avoid a temporary file if need (note: tempfile.TemporaryFile is quite security, it uses a file descriptor) | 14:38 |
dhellmann | haypo: or we might introduce a new function that is "smarter" or takes an extra required option or something. But execute() needs to stay more or less the same. | 14:38 |
haypo | dhellmann: i would prefer to not split the API between python 2 and python 3, it's much more convinient to have a single code base | 14:39 |
haypo | dhellmann: what i just proposed here address all cases without breaking backward compatibility | 14:39 |
sdague | haypo: you can't use tempfile.TemporaryFile, you can't pass an fd to that command | 14:39 |
dhellmann | haypo: ok, I'll take a look at the function | 14:39 |
sdague | so stepping back, is this being done because mask_password is being called on all output strings? | 14:40 |
sdague | I'm trying to understand the mask_password comment above and how it relates | 14:40 |
dhellmann | mask_password also messes with the encoding | 14:40 |
haypo | sdague: on Linux, you can use /proc/self/fd/<fd>. with recent Python version, you have to ensure that the file descriptor in inherited with pass_fds={fd} | 14:41 |
haypo | sdague: but well, it sounds maybe too complex for such simple usecase (call openssl) ;-) | 14:41 |
haypo | dhellmann: IMO the first step is to modify mask_password() to not try to decode | 14:41 |
sdague | haypo: yeh, that's all kinds of complicated and broken. And define recent :) | 14:41 |
haypo | dhellmann: if you get bytes, return bytes. that's all | 14:41 |
haypo | dhellmann: you have less trouble on Python 2 if you only work on bytes | 14:42 |
dhellmann | haypo: again, that would break a bunch of things. | 14:42 |
sdague | I wonder if it's better to annotate strings that might have passwords in them, and only run mask_password in those cases | 14:42 |
haypo | dhellmann: if you don't want to change the default behaviour, it can be an option | 14:42 |
dhellmann | sdague: yeah, I'm not sure why execute() always calls mask_password | 14:42 |
dhellmann | haypo: an option, a second function, whatever works | 14:42 |
haypo | dhellmann: mask_password(data, encoding=None) or mask_password(data, binary=True) for example | 14:43 |
sdague | haypo: more importantly, why is mask_password running inside the execute at all | 14:43 |
dhellmann | that also works -- whatever logic is easier/cleaner | 14:43 |
haypo | sdague: currently, ssh_execute() always call mask_password() on stdout&stderr, execute() only calls mask_password() on error (to build an exception) | 14:43 |
sdague | because if passwords were available, they were in the process list | 14:43 |
sdague | oh... hmmm | 14:44 |
*** yamahata has quit IRC | 14:44 | |
dhellmann | sdague: it looks like it's just in the error handling | 14:44 |
*** yamahata has joined #openstack-oslo | 14:44 | |
haypo | so i propose (1) add an option to mask_password() to only work on bytes (2) execute/ssh_execute work on bytes on Python 2, and work on unicode on Python 3 | 14:45 |
dims__ | sdague: the mask_password was added by amrith for 1343604 | 14:45 |
dims__ | bug 1343604 | 14:45 |
dhellmann | https://review.openstack.org/#/c/114656/ | 14:45 |
dhellmann | haypo: yeah, if we are going to provide a way to turn off encoding we should include functions called by execute() | 14:46 |
*** jgrimm is now known as zz_jgrimm | 14:46 | |
amrith | o/ | 14:47 |
haypo | dhellmann: if i remember correctly, only mask_password() is impacted | 14:47 |
*** tsekiyama has joined #openstack-oslo | 14:47 | |
dhellmann | I think that's probably right, but I would have to look more close | 14:47 |
dhellmann | time for breakfast, brb | 14:47 |
sdague | so, I would actually argue that things shouldn't be sanitized in ProcessExecutionError | 14:47 |
amrith | just in time for breakfast! | 14:47 |
sdague | what about a different look at this, which is sensitive_output parameter on execute | 14:48 |
sdague | only if that's set, try to do any of this scrubbing | 14:48 |
sdague | which would also put it back on the caller to annotate when a command is running that could leak things if the output was logged | 14:49 |
*** mtanino has joined #openstack-oslo | 14:49 | |
sdague | which would also be tremendously useful from a code audit perspective to be more explicit in the projects about where that was the case | 14:50 |
viktors | zzzeek: by the way, maybe do you know, why don't we use monkey_patch'ed MySQLdb ? | 14:50 |
zzzeek | viktors: because it’s in C | 14:51 |
*** miarmak has quit IRC | 14:51 | |
amrith | since I showed up late, I may be missing some context here. the reason for putting the check in *execute() was to eliminate the proliferation of changes and the potential exposure down the road from a call whcih didn't specify this flag. | 14:51 |
zzzeek | viktors: if we want to produce a rebuild / patched version of MySQLdb that works as linked in that post there, we can do that too. dont know how stable it is | 14:51 |
amrith | it appears that the issue is with mask_password() | 14:51 |
dhellmann | sdague: yeah, that would be good, but as amrith just said we were trying to add safety without requiring a lot of other changes in apps | 14:52 |
amrith | you would still have that issue if the user specified the flag | 14:52 |
viktors | zzzeek: I mean, that eventlet uses tpool for connections and can monkey patch it - https://github.com/eventlet/eventlet/blob/v0.16.1/eventlet/patcher.py#L225-L237 | 14:52 |
zzzeek | viktors: mysql-connector is now mysqls/oracle’s official driver. we really shoudl use that | 14:52 |
amrith | and there was an issue converting a pure ascii string | 14:52 |
amrith | that would still fail the same way | 14:52 |
viktors | zzzeek: I really don't mind, but it still not on pypi =(( | 14:52 |
amrith | so the issue isn't with adding a flag and placing the responsibility on the caller of *execute() | 14:52 |
sdague | dhellmann: so, I do understand that pov, however that actually kind of makes it harder to figure out where the soft spots actually are. I think it's hiding too much | 14:52 |
zzzeek | viktors: i dont even know what that code means :) | 14:52 |
amrith | it is with providing a safe routine that will mask_passwords() no matter what the incoming string is. | 14:52 |
zzzeek | viktors: its transparently thread-pooling mysqldb ? | 14:52 |
sdague | amrith: I agree there are 2 different things here | 14:53 |
viktors | zzzeek: seems to be - https://github.com/eventlet/eventlet/blob/v0.16.1/eventlet/green/MySQLdb.py | 14:53 |
sdague | mask_password needs to abort early on binary | 14:53 |
sdague | and not assume it gets a string | 14:53 |
dhellmann | sdague: yeah, that's fair | 14:53 |
zzzeek | viktors: OK so what is going on here: http://www.diamondtin.com/2014/sqlalchemy-gevent-mysql-python-drivers-comparison/ | 14:53 |
zzzeek | viktors: where MySQLdb performs really badly | 14:53 |
amrith | sdague, if we agree that there are two issues, i submit to you that putting the responsibility on the caller to decide when to mask or not seems like not a solution to a problem we have today. | 14:53 |
amrith | no? | 14:54 |
zzzeek | viktors: also we shoudl be getting all of that tpool behavior in openstack now, no ? | 14:54 |
zzzeek | viktors: I have no issue with threadpools either. lets put what you have there on the wiki, and is that happening now or not ? | 14:54 |
haypo | viktors: i like this comment: https://github.com/farcepest/MySQLdb1/pull/56#issuecomment-69777527 " | 14:54 |
haypo | @msabramo Stop loosing your time, use https://github.com/PyMySQL/mysqlclient-python | 14:54 |
haypo | " | 14:54 |
viktors | haypo: :-D | 14:55 |
zzzeek | viktors: really, I dont see much of a need for eventlet in the 1st place in the DB side of apps :) the GIL doesnt block on IO :) so im just writing things down that i am finding but i dont care | 14:55 |
haypo | viktors: julien danjou told me the same | 14:55 |
sdague | amrith: mostly agree, though the work around would be different in that case. I'm just looking at the flow of this code, and have been running into other overhiding issues recently, so wanted to raise the overhiding problem. | 14:55 |
haypo | PyMySQL is actively developed and it supports Python 3... | 14:56 |
haypo | it also (indirectly) supports asynchronous programming | 14:56 |
sdague | amrith: knowing what masking meant in this case, we'd never have enabled it for that openssl call, for instance | 14:56 |
dhellmann | sdague, amrith, haypo : would it be useful to write up a spec for a function to replace execute() that handles the encoding/decoding, masking, etc. better? | 14:56 |
viktors | haypo: "at the moment PyMySQL is winning pretty much because all the alternatives are worse" (c) zzzeek | 14:56 |
zzzeek | haypo: add to the wiki here: https://wiki.openstack.org/wiki/PyMySQL_evaluation | 14:57 |
amrith | dhellmann, so we would propose to deprecate *execute() | 14:57 |
zzzeek | haypo: feel free to edit and leave your thoughts | 14:57 |
amrith | in favor of something new? | 14:57 |
zzzeek | (a.k.a. do zeek’s work!) | 14:57 |
dhellmann | amrith: yes, over time | 14:57 |
haypo | zzzeek: sorry, i never used it. i can just repeat what I read | 14:57 |
zzzeek | haypo: ah. well thats all im doing :) | 14:57 |
dhellmann | amrith: a new function lets us make it work completely differently, without breaking existing callers of execute() | 14:57 |
dhellmann | we might need the same for mask_password, unless we consider that encoding behavior simply broken | 14:57 |
amrith | ok, that sounds fine. I'd like the new function to also include a timeout option https://bugs.launchpad.net/oslo.concurrency/+bug/1360952 ;) | 14:58 |
dhellmann | amrith: sure, that could be in the spec | 14:58 |
amrith | I'll volunteer to help with/write that | 14:58 |
*** tsekiyam_ has joined #openstack-oslo | 14:58 | |
dhellmann | amrith: although with the new watchdog module sdague added, we might not need the timeout | 14:58 |
dhellmann | amrith: cool, thanks | 14:58 |
*** tsekiya__ has joined #openstack-oslo | 15:00 | |
*** tsekiyam_ has quit IRC | 15:00 | |
dims__ | amrith: tsk,tsk, you cause too much trouble :) | 15:00 |
* dims__ kidding of course | 15:00 | |
amrith | dims__, I was given a t-shirt some years ago which said "Here comes BIG trouble". | 15:01 |
dims__ | LOL nice | 15:01 |
amrith | a co-worker got the other t-shirt "Here comes LITTLE trouble". | 15:01 |
amrith | I'll get you one of those | 15:01 |
amrith | dims__, ^^ | 15:01 |
*** tsekiyama has quit IRC | 15:01 | |
dims__ | haha | 15:01 |
dims__ | sounds good | 15:01 |
*** pblaho has quit IRC | 15:05 | |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: Use default in dumps() https://review.openstack.org/147194 | 15:06 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: support set() encoding https://review.openstack.org/147195 | 15:06 |
*** jecarey has joined #openstack-oslo | 15:08 | |
dhellmann | bnemec, dims__, haypo: are we ready for an oslo.concurrency release this morning, now that https://review.openstack.org/#/c/146940/ has merged? | 15:12 |
*** amotoki_ has quit IRC | 15:12 | |
haypo | dhellmann: i'm only aware of a regression introduced by my change, and my change was reverted | 15:13 |
haypo | dhellmann: so i guess that we are ready? | 15:13 |
dhellmann | haypo: that's what I thought, but wanted to check before releasing | 15:13 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: support set() encoding https://review.openstack.org/147195 | 15:13 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: Use default in dumps() https://review.openstack.org/147194 | 15:13 |
openstackgerrit | Julien Danjou proposed openstack/oslo.serialization: jsonutils: support UUID encoding https://review.openstack.org/147198 | 15:13 |
sdague | dhellmann: want me to manually test that on nova unit tests? | 15:14 |
dhellmann | sdague: sure | 15:14 |
haypo | sdague: yeah, it would help :) | 15:14 |
dhellmann | sdague: you can use the tools/run_cross_tests.sh script | 15:14 |
sdague | dhellmann: what repo is that in? | 15:14 |
dhellmann | sdague: most of the oslo libs have one, and oslo.concurrency does | 15:14 |
*** mriedem has joined #openstack-oslo | 15:16 | |
sdague | ok, will do | 15:16 |
*** tsekiya__ has quit IRC | 15:17 | |
*** amotoki_ has joined #openstack-oslo | 15:18 | |
dims__ | dhellmann: +1 | 15:18 |
sdague | running | 15:19 |
*** tsekiyama has joined #openstack-oslo | 15:20 | |
dhellmann | dims__: I spent some time yesterday on a patch to nova to use oslo.log, and didn't find any changes to the API needed for the unit tests to work. I need to set up a devstack run to make sure I have the app startup stuff right. | 15:20 |
sdague | dhellmann: if you push the patch for review, zuul can tell you, right? | 15:21 |
dhellmann | sdague: yeah, I was trying to do a little testing to make sure we don't have to tweak the API before releasing | 15:22 |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module https://review.openstack.org/138215 | 15:22 |
*** tsekiyama has quit IRC | 15:23 | |
*** tsekiyama has joined #openstack-oslo | 15:24 | |
sdague | dhellmann: so with a little tweaking, run_cross_tests.sh could probably take 2 repos, and do the clones for you, so it wouldn't need to live in any particular repo. | 15:24 |
dhellmann | viktors, rpodolyaka1, zzzeek : the folks in #openstack-keystone have some questions about alembic support in oslo.db, if you have a minute to join us | 15:24 |
sdague | dhellmann: ok, nova unit tests just returned, all passed | 15:24 |
*** stevemar has joined #openstack-oslo | 15:24 | |
dhellmann | sdague: sure. I have everything checked out all the time anyway, though | 15:24 |
viktors | dhellmann: ok | 15:25 |
sdague | dhellmann: yeh, I was just thinking about it from other people spot checking | 15:25 |
dhellmann | sdague: I'm testing cinder now | 15:25 |
dhellmann | sdague: sure. The idea was for the script to be used in those gate jobs, which also already had everything checked out. I also use it with 2 existing repos with branches (like nova and oslo.log). | 15:25 |
openstackgerrit | Julien Danjou proposed openstack-dev/hacking: H105: also check for Authors and authors https://review.openstack.org/147201 | 15:27 |
dims__ | dhellmann: ack, i'll be back in a bit and help with that. need to head out to return hardware/badge, will be unemployed for 2 days! :) | 15:27 |
dhellmann | dims__: enjoy your "time off"! | 15:28 |
dims__ | :) | 15:28 |
*** jroll has quit IRC | 15:28 | |
*** jroll has joined #openstack-oslo | 15:28 | |
dhellmann | ok, nova and cinder unit tests pass with oslo.concurrency master so I'm going to tag a release | 15:29 |
dhellmann | ah, crap | 15:35 |
dhellmann | well, I just tagged oslo.concurrency 1.4.1 | 15:35 |
* bnemec doesn't like the sound of that | 15:35 | |
dhellmann | instead of 0.4.1 | 15:35 |
* dhellmann needs to add some protections to the release script | 15:35 | |
* dhellmann also needs to rush less | 15:36 | |
bnemec | Well if we were going to do that, we might as well have broken backwards compatibility in execute. :-) | 15:36 |
dhellmann | bnemec: heh | 15:37 |
dhellmann | I wonder if we can just delete it :-/ | 15:37 |
dhellmann | I don't think I can delete the tag, though | 15:37 |
bnemec | At this point we're treating the concurrency api as stable anyway, so it shouldn't be a big problem. | 15:38 |
*** e0ne is now known as e0ne_ | 15:38 | |
bnemec | Just a few months early for the 1.x release. :-) | 15:38 |
*** e0ne_ is now known as e0ne | 15:38 | |
dhellmann | yeah, it's just a weirdly large jump | 15:39 |
*** amotoki_ has quit IRC | 15:39 | |
bnemec | It'll make a fun trivia question some day. | 15:41 |
*** amrith is now known as _amrith_ | 15:41 | |
* bnemec is strangely positive today | 15:41 | |
bnemec | Doubly strange because everything I touched yesterday was broken. | 15:41 |
dhellmann | ok, oslo.concurrency 1.4.1 announcement sent | 15:47 |
*** _amrith_ is now known as amrith | 15:48 | |
kragniz | dhellmann: I like the bonus version number :D | 15:48 |
dhellmann | kragniz: don't spend it all in one place ;-) | 15:48 |
kragniz | hehe | 15:49 |
*** zz_sabari is now known as sabari | 16:04 | |
*** amrith is now known as _amrith_ | 16:07 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement generic update-on-match feature https://review.openstack.org/146228 | 16:09 |
*** alexpilotti_ has joined #openstack-oslo | 16:10 | |
*** alexpilotti has quit IRC | 16:12 | |
*** alexpilotti_ is now known as alexpilotti | 16:12 | |
*** takedakn has quit IRC | 16:29 | |
*** mfedosin has quit IRC | 16:30 | |
*** tsufiev has quit IRC | 16:30 | |
*** mfedosin has joined #openstack-oslo | 16:31 | |
*** tsufiev has joined #openstack-oslo | 16:33 | |
*** achanda has joined #openstack-oslo | 16:36 | |
*** tsufiev has quit IRC | 16:41 | |
*** tsufiev has joined #openstack-oslo | 16:44 | |
*** Guest8210 is now known as redrobot | 16:54 | |
*** dims__ has quit IRC | 17:00 | |
*** dims__ has joined #openstack-oslo | 17:01 | |
*** achanda has quit IRC | 17:03 | |
*** dtantsur is now known as dtantsur|afk | 17:03 | |
*** dulek has quit IRC | 17:03 | |
*** dims__ has quit IRC | 17:05 | |
*** viktors is now known as viktors|afk | 17:06 | |
*** ihrachyshka has quit IRC | 17:06 | |
*** achanda has joined #openstack-oslo | 17:07 | |
*** i159 has quit IRC | 17:10 | |
*** zz_jgrimm is now known as jgrimm | 17:12 | |
*** e0ne is now known as e0ne_ | 17:21 | |
*** noelbk has joined #openstack-oslo | 17:21 | |
*** yassine has quit IRC | 17:30 | |
*** takedakn has joined #openstack-oslo | 17:31 | |
*** e0ne_ has quit IRC | 17:32 | |
*** yamahata has quit IRC | 17:32 | |
*** bknudson has quit IRC | 17:33 | |
dhellmann | sileht: I'm really tempted to skip test_two_pools_three_listener since it seems to have some non-deterministic qualities | 17:34 |
sileht | dhellmann, I'm working on a change to make it determinist https://review.openstack.org/#/c/145798/, but it fail, I try to be sure that is not a bug in the fake driver | 17:37 |
dhellmann | sileht: ok | 17:37 |
dhellmann | it looks like https://review.openstack.org/#/c/146872/ also had an issue with an ssh timeout | 17:37 |
*** rpodolyaka2 has quit IRC | 17:38 | |
*** gordc has quit IRC | 17:38 | |
*** rpodolyaka2 has joined #openstack-oslo | 17:41 | |
dhellmann | bnemec: if you have a little time today, could you look at https://review.openstack.org/145924 | 17:41 |
sileht | dhellmann, seems to be a connection reset from libvirt: http://logs.openstack.org/72/146872/2/gate/gate-tempest-dsvm-neutron-src-oslo.messaging/2d5da2d/logs/screen-n-cpu.txt.gz?level=TRACE | 17:41 |
dhellmann | sileht: yeah, I figured that was unrelated to the messaging changes | 17:42 |
*** sabari is now known as zz_sabari | 17:42 | |
*** zz_sabari is now known as sabari | 17:42 | |
sileht | dhellmann, I think it's unrelated too | 17:42 |
*** jaosorior has quit IRC | 17:43 | |
bnemec | dhellmann: Did you see my last comment on that? | 17:43 |
*** takedakn has quit IRC | 17:43 | |
dhellmann | bnemec: apparently not | 17:43 |
bnemec | I don't understand the vmware stuff well enough to know whether that's a legit failure or not. | 17:43 |
dhellmann | oh, the external ci thing | 17:43 |
dhellmann | hmm | 17:44 |
*** e0ne has joined #openstack-oslo | 17:45 | |
*** sabari is now known as zz_sabari | 17:47 | |
*** achanda has quit IRC | 17:47 | |
*** rpodolyaka2 has quit IRC | 17:51 | |
dhellmann | that's not a very helpful error message :-/ | 17:51 |
openstackgerrit | James Carey proposed openstack/oslo.i18n: Add test fixture to prefix lazily translated messages https://review.openstack.org/147262 | 17:51 |
*** kbyrne has quit IRC | 17:56 | |
bnemec | Yeah, I was hoping one of the vmware folks would come along and be able to tell us whether it could be related. | 17:59 |
*** jaosorior has joined #openstack-oslo | 17:59 | |
dhellmann | bnemec: it looks like that's a configuration error on the server; I'm seeing the same error for unrelated patches | 18:02 |
*** e0ne has quit IRC | 18:04 | |
bnemec | dhellmann: +2 | 18:04 |
dhellmann | bnemec: thanks | 18:05 |
*** prad has joined #openstack-oslo | 18:10 | |
*** harlowja_away is now known as harlowja | 18:10 | |
*** achanda has joined #openstack-oslo | 18:12 | |
*** _amrith_ is now known as amrith | 18:13 | |
*** gordc has joined #openstack-oslo | 18:21 | |
harlowja | ' this release | 18:22 |
harlowja | has a whole extra version number, just for you' | 18:22 |
harlowja | oh man, so special :-P | 18:22 |
dhellmann | harlowja: because we care | 18:24 |
harlowja | :) | 18:24 |
harlowja | btw dhellmann if u get some time https://review.openstack.org/#/c/141939/ :) | 18:25 |
harlowja | cause python is cool ^ | 18:25 |
harlowja | lol | 18:25 |
dhellmann | harlowja: heh, ok, I'll take a look | 18:26 |
harlowja | :-P | 18:26 |
*** vigneshvar has joined #openstack-oslo | 18:32 | |
*** bknudson has joined #openstack-oslo | 18:36 | |
*** rushiagr is now known as rushiagr_away | 18:37 | |
*** rpodolyaka2 has joined #openstack-oslo | 18:38 | |
*** yamahata has joined #openstack-oslo | 18:40 | |
*** e0ne has joined #openstack-oslo | 18:42 | |
openstackgerrit | Ryan Hsu proposed openstack/oslo.vmware: DO NOT MERGE - Testing https://review.openstack.org/147269 | 18:46 |
*** e0ne is now known as e0ne_ | 18:48 | |
*** zz_sabari is now known as sabari | 18:52 | |
*** e0ne_ has quit IRC | 18:53 | |
*** isq has joined #openstack-oslo | 18:55 | |
*** isq has quit IRC | 18:56 | |
*** isq has joined #openstack-oslo | 18:56 | |
*** noelbk has quit IRC | 19:04 | |
*** e0ne has joined #openstack-oslo | 19:06 | |
*** alexpilotti has quit IRC | 19:10 | |
*** ihrachyshka has joined #openstack-oslo | 19:10 | |
*** noelbk has joined #openstack-oslo | 19:12 | |
*** achanda has quit IRC | 19:18 | |
*** crc32 has joined #openstack-oslo | 19:19 | |
*** rpodolyaka2 has quit IRC | 19:20 | |
*** achanda has joined #openstack-oslo | 19:23 | |
*** rpodolyaka2 has joined #openstack-oslo | 19:48 | |
openstackgerrit | James Carey proposed openstack/oslo.i18n: Add test fixture to prefix lazily translated messages https://review.openstack.org/147262 | 19:49 |
*** dims__ has joined #openstack-oslo | 19:51 | |
*** jecarey has quit IRC | 19:54 | |
*** dims__ has quit IRC | 19:56 | |
*** ihrachyshka has quit IRC | 19:56 | |
*** prad has quit IRC | 20:00 | |
*** e0ne is now known as e0ne_ | 20:01 | |
*** vigneshvar has quit IRC | 20:02 | |
*** vigneshvar has joined #openstack-oslo | 20:02 | |
*** e0ne_ has quit IRC | 20:07 | |
*** sabari is now known as zz_sabari | 20:08 | |
*** david-lyle has joined #openstack-oslo | 20:10 | |
*** dims__ has joined #openstack-oslo | 20:11 | |
*** e0ne has joined #openstack-oslo | 20:12 | |
*** vigneshvar has quit IRC | 20:17 | |
*** harlowja is now known as harlowja_away | 20:30 | |
*** vigneshvar has joined #openstack-oslo | 20:33 | |
*** harlowja_away is now known as harlowja | 20:38 | |
*** achanda has quit IRC | 20:45 | |
*** zz_sabari is now known as sabari | 20:56 | |
*** achanda has joined #openstack-oslo | 20:56 | |
*** amrith is now known as _amrith_ | 20:59 | |
*** david-lyle has quit IRC | 21:01 | |
dims__ | dhellmann: all set with the minesweeper question? | 21:03 |
*** achanda has quit IRC | 21:08 | |
*** achanda has joined #openstack-oslo | 21:11 | |
*** ajo has quit IRC | 21:16 | |
*** ajo has joined #openstack-oslo | 21:18 | |
*** e0ne is now known as e0ne_ | 21:18 | |
*** achanda has quit IRC | 21:21 | |
dhellmann | dims__: yeah, I think I got the answers I neededd | 21:24 |
dhellmann | dims__: it looks like the job is failing, but not because of anything we've done | 21:26 |
dims__ | right | 21:26 |
dhellmann | dims__: so I'm thinking for oslo.log, we just release 0.1.0 without making any announcements, and then work on one or two projects quietly to make sure we have the API right before making the full announcement | 21:27 |
dims__ | dhellmann: exactly, low key | 21:28 |
*** e0ne_ is now known as e0ne | 21:28 | |
*** ihrachyshka has joined #openstack-oslo | 21:28 | |
dims__ | Nova for sure, we can pick another as well | 21:29 |
dhellmann | maybe we should actually announce that 0.1.0 shouldn't be used? | 21:29 |
dhellmann | yeah, I have a patch for nova, just no easy way to test it well | 21:29 |
dhellmann | running the devstack gate stuff by hand is so complicated | 21:29 |
dims__ | dhellmann: is the review up? | 21:29 |
dhellmann | no, not yet, there's no release of oslo.log so it will just fail :-) | 21:29 |
dims__ | so, there's a trick i use | 21:30 |
dhellmann | dims__: pray, tell | 21:30 |
dims__ | trying to find old notes | 21:31 |
dhellmann | there's a draft option to git-review, but I don't think I've ever used that | 21:31 |
dims__ | nova-docker for example has all the devstack hooks within its repo, so sometimes i just throw in other things before tempest or before devstack gets installed and try it out there | 21:32 |
dhellmann | interesting | 21:33 |
dims__ | there's a soft requirements check flag which i turn on so dsvm jobs don't barf | 21:33 |
dims__ | but the downside is, we can only change code in nova-docker git repo | 21:34 |
dims__ | unless we can pull your raw nova diff patch from the internets and apply that on top of nova somehow | 21:35 |
dims__ | can you log a nova review and mark it as WIP? let me try to see if i can somehow get it to run | 21:35 |
dims__ | in the past i actually pulled libvirt from source and built it in the jobs vm to test newer libvirt | 21:36 |
dhellmann | I'm going to have to sign off soon. Maybe we're over thinking this, and we should just release 0.1.0 tomorrow and then I can publish the nova patch as a WIP and we can see how it goes. | 21:36 |
dhellmann | I need to track down whichever project was using the old LOG.deprecated() function, too, and figure out the steps to get that updated. | 21:37 |
dhellmann | I probably have some outstanding incubator patches related to all of this that we'll need to land | 21:37 |
dims__ | yep, +1 to release quietly | 21:37 |
dims__ | sounds good dhellmann | 21:38 |
dhellmann | dims__: ok, I'll do that in the morning | 21:39 |
dhellmann | thanks for thinking it through with me, dims__ | 21:39 |
dims__ | my pleasure dhellmann | 21:39 |
ihrachyshka | dhellmann, hm, using latest oslo.concurrency, I still see lock_path option failure: https://review.openstack.org/#/c/139717/ so apparently patch to remove ConfigFilter didn't help (?) | 21:40 |
*** e0ne is now known as e0ne_ | 21:40 | |
ihrachyshka | "NoSuchOptError: no such option: lock_path" it says | 21:41 |
*** e0ne_ is now known as e0ne | 21:42 | |
*** david-lyle has joined #openstack-oslo | 21:42 | |
*** achanda has joined #openstack-oslo | 21:43 | |
*** e0ne has quit IRC | 21:43 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Add migration notes https://review.openstack.org/147312 | 21:45 |
dhellmann | ihrachyshka: is the test using a ConfigOpts instance that was set up with the concurrency options? | 21:46 |
dhellmann | ihrachyshka: unfortunately, I have an appointment so I'm going to have to sign off, but I should be able to help you look at it tomorrow | 21:46 |
*** stevemar has quit IRC | 21:48 | |
ihrachyshka | dhellmann, ack, thanks | 21:49 |
*** david-lyle has quit IRC | 21:49 | |
*** msdubov_ has joined #openstack-oslo | 21:59 | |
*** rpodolyaka2 has quit IRC | 22:05 | |
*** achanda has quit IRC | 22:08 | |
*** achanda has joined #openstack-oslo | 22:12 | |
*** msdubov_ has quit IRC | 22:15 | |
jogo | haypo: ping re: eventlet | 22:19 |
*** dims__ has quit IRC | 22:20 | |
*** dims__ has joined #openstack-oslo | 22:21 | |
haypo | jogo: pong | 22:22 |
jogo | haypo: so event 0.16.0 and 0.16.1 | 22:23 |
jogo | haypo: I am doing a retrospective on the stable/* failure due to that | 22:23 |
jogo | and I saw you helped fix the master branch stuff before the release | 22:23 |
haypo | jogo: eventlet.util was removed in eventlet 0.16 | 22:23 |
haypo | jogo: there was a mistake in the tarball or the wheel package (i don't remember which one), it still contains eventlet.util in the 0.16 release | 22:24 |
haypo | 0.16.1 fixes that (tarball & wheel contain the same thing) | 22:24 |
haypo | jogo: i wrote a simple change to stop using eventlet.util in nova | 22:24 |
jogo | haypo: yeah I saw that. | 22:24 |
jogo | haypo: so did you know before the release that was going to be an issue? | 22:25 |
haypo | jogo: my change was backported to icehouse & juno, patches are under review | 22:25 |
jogo | haypo: in the end we capped the eventlet version in stable/* | 22:25 |
haypo | jogo: no. i'm not the maintainer of eventlet. i was not aware that eventlet.util was deprecated, nor that it was removed | 22:25 |
*** dims__ has quit IRC | 22:25 | |
haypo | jogo: i contributed to patches to support python 3 in eventlet, especially when using monkey patching | 22:26 |
jogo | haypo: so you just stumbled upon bug https://bugs.launchpad.net/nova/+bug/1407685 ? | 22:26 |
haypo | jogo: to avoid similar issues, you may enable deprecation warnings | 22:26 |
jogo | haypo: trying to figure out how that bug was filed before the release of 0.16.1 | 22:27 |
haypo | jogo: i commented the bug | 22:30 |
haypo | jogo: nova started to fail the eventlet 0.16, but only if eventlet is installed using the wheel package (or tarball? i don't remember) | 22:31 |
haypo | so the issue was not immediatly seen by everybody | 22:31 |
haypo | even if they upgraded eventlet or reinstalled nova | 22:32 |
*** david-lyle has joined #openstack-oslo | 22:33 | |
*** bknudson has quit IRC | 22:37 | |
*** gordc has quit IRC | 22:39 | |
*** jgrimm is now known as zz_jgrimm | 22:39 | |
jogo | haypo: ahhh, thanks for the clarification | 22:39 |
*** dims__ has joined #openstack-oslo | 22:45 | |
*** bknudson has joined #openstack-oslo | 23:03 | |
*** dims__ has quit IRC | 23:07 | |
*** ihrachyshka has quit IRC | 23:08 | |
*** dims__ has joined #openstack-oslo | 23:15 | |
*** david-lyle has quit IRC | 23:16 | |
*** achanda has quit IRC | 23:25 | |
*** achanda has joined #openstack-oslo | 23:26 | |
*** dims__ has quit IRC | 23:32 | |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement generic update-on-match feature https://review.openstack.org/146228 | 23:39 |
openstackgerrit | Michael Bayer proposed openstack/oslo.db: Implement generic update-on-match feature https://review.openstack.org/146228 | 23:43 |
*** mriedem has quit IRC | 23:52 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:52 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove 'SaveOrderTask' and test state in class variables https://review.openstack.org/147038 | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!